platform/upstream/libSkiaSharp.git
11 years agoFix bug in cubic-clipper (SkEdgeClipper). When we chop the cubic on Top/Bottom
reed@google.com [Tue, 15 Jan 2013 15:51:59 +0000 (15:51 +0000)]
Fix bug in cubic-clipper (SkEdgeClipper). When we chop the cubic on Top/Bottom
of the cliprect, we (correctly) clamp the Y coordinate of the control-point
right next to the on-curve point that was chopped (this ensures we don't go
slightly outside of the clip-rect due to imperfect T value calculation). However,
the code was also clamping the other control-point as well, resulting in warping
the cubic, which could sometimes force it outside of the clip.

The fix is to just remove the line of code that clampped the 2nd control-point.

unittest added to reproduce a test cubic that triggered an assert, due to the
cubic being outside of the cliprect. The test (w/o the fix) will assert in
a SK_DEBUG build.
Review URL: https://codereview.appspot.com/7100056

git-svn-id: http://skia.googlecode.com/svn/trunk@7184 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoTurn off timeIndividualTiles
borenet@google.com [Tue, 15 Jan 2013 15:50:42 +0000 (15:50 +0000)]
Turn off timeIndividualTiles

The parser isn't working properly.
Review URL: https://codereview.appspot.com/7100057

git-svn-id: http://skia.googlecode.com/svn/trunk@7183 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoImplementation of the displacement effect (both CPU and GPU)
sugoi@google.com [Tue, 15 Jan 2013 15:40:19 +0000 (15:40 +0000)]
Implementation of the displacement effect (both CPU and GPU)

TEST=Added new GM called "displacement"
Review URL: https://codereview.appspot.com/7058075

git-svn-id: http://skia.googlecode.com/svn/trunk@7182 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoTo support alignment pragmas (for speed), we need to relax assumptions about
reed@google.com [Tue, 15 Jan 2013 14:54:00 +0000 (14:54 +0000)]
To support alignment pragmas (for speed), we need to relax assumptions about
our sizeof. So rewrite operator= and copy-constructor to just copy individual
fields.
Review URL: https://codereview.appspot.com/7098063

git-svn-id: http://skia.googlecode.com/svn/trunk@7181 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agodashing asPoints could draw excessively long first dash
robertphillips@google.com [Tue, 15 Jan 2013 12:53:31 +0000 (12:53 +0000)]
dashing asPoints could draw excessively long first dash

https://codereview.appspot.com/7098054/

Will require rebaselining of dashing gm.

git-svn-id: http://skia.googlecode.com/svn/trunk@7177 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Tue, 15 Jan 2013 12:19:31 +0000 (12:19 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@7176 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agocall endContext() if we have to return false from setContext(), to keep the
mike@reedtribe.org [Tue, 15 Jan 2013 03:28:22 +0000 (03:28 +0000)]
call endContext() if we have to return false from setContext(), to keep the
debugging fInSetContext flag up-to-date.

git-svn-id: http://skia.googlecode.com/svn/trunk@7175 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agofix warning on linux
humper@google.com [Tue, 15 Jan 2013 03:03:38 +0000 (03:03 +0000)]
fix warning on linux

BUG=

Review URL: https://codereview.appspot.com/7101058

git-svn-id: http://skia.googlecode.com/svn/trunk@7174 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Tue, 15 Jan 2013 02:01:40 +0000 (02:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@7173 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agofix all the false --> NULL issues in the gradient code
humper@google.com [Mon, 14 Jan 2013 22:09:54 +0000 (22:09 +0000)]
fix all the false --> NULL issues in the gradient code

BUG=

Review URL: https://codereview.appspot.com/7095056

git-svn-id: http://skia.googlecode.com/svn/trunk@7170 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoremove namespace qualifier for feof; it's making android unhappy
humper@google.com [Mon, 14 Jan 2013 22:01:14 +0000 (22:01 +0000)]
remove namespace qualifier for feof; it's making android unhappy

BUG=

Review URL: https://codereview.appspot.com/7106048

git-svn-id: http://skia.googlecode.com/svn/trunk@7169 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix a problem in the matrix convolution image filter exposed by https://code.google...
senorblanco@chromium.org [Mon, 14 Jan 2013 21:53:45 +0000 (21:53 +0000)]
Fix a problem in the matrix convolution image filter exposed by https://code.google.com/p/skia/source/detail?r=7152:  when offsetting texture coordinates in a GrEffect, take the origin of the source bitmap origin into account, and flip Y coordinates when we need to.

NOTE:  this will cause the matrixconvolution GM's to need to be rebaselined (again!).

Review URL: https://codereview.appspot.com/7086054

git-svn-id: http://skia.googlecode.com/svn/trunk@7168 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoanother false --> NULL return fix
humper@google.com [Mon, 14 Jan 2013 21:01:28 +0000 (21:01 +0000)]
another false --> NULL return fix

false --> NULL for failure return

BUG=

Review URL: https://codereview.appspot.com/7100052

git-svn-id: http://skia.googlecode.com/svn/trunk@7167 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agofalse --> NULL for failure return
humper@google.com [Mon, 14 Jan 2013 20:17:04 +0000 (20:17 +0000)]
false --> NULL for failure return

BUG=

Review URL: https://codereview.appspot.com/7096058

git-svn-id: http://skia.googlecode.com/svn/trunk@7165 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agomove template specializations to inline functions in the header to make windows happy...
humper@google.com [Mon, 14 Jan 2013 20:11:00 +0000 (20:11 +0000)]
move template specializations to inline functions in the header to make windows happy again

BUG=

Review URL: https://codereview.appspot.com/7099053

git-svn-id: http://skia.googlecode.com/svn/trunk@7164 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoreplace getline with fgets for portability
humper@google.com [Mon, 14 Jan 2013 19:42:08 +0000 (19:42 +0000)]
replace getline with fgets for portability

BUG=

Review URL: https://codereview.appspot.com/7085058

git-svn-id: http://skia.googlecode.com/svn/trunk@7163 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoremove dynamic_cast because rtti is disabled on some platforms (but not all??)
humper@google.com [Mon, 14 Jan 2013 19:20:28 +0000 (19:20 +0000)]
remove dynamic_cast because rtti is disabled on some platforms (but not all??)

BUG=

Review URL: https://codereview.appspot.com/7102056

git-svn-id: http://skia.googlecode.com/svn/trunk@7161 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agofix gcc build
humper@google.com [Mon, 14 Jan 2013 19:03:46 +0000 (19:03 +0000)]
fix gcc build

BUG=

Review URL: https://codereview.appspot.com/7095055

git-svn-id: http://skia.googlecode.com/svn/trunk@7160 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemove SK_DRAW_POS_TEXT_IGNORE_SUBPIXEL_LEFT_ALIGN_FIX.
bungeman@google.com [Mon, 14 Jan 2013 19:03:20 +0000 (19:03 +0000)]
Remove SK_DRAW_POS_TEXT_IGNORE_SUBPIXEL_LEFT_ALIGN_FIX.
https://codereview.appspot.com/7070073/

git-svn-id: http://skia.googlecode.com/svn/trunk@7159 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRuntime configuration system for skia. This will allow developers to control setting...
humper@google.com [Mon, 14 Jan 2013 18:49:19 +0000 (18:49 +0000)]
Runtime configuration system for skia.  This will allow developers to control settings at launch time without relying on compile-time flags or recompilation.  It can be used to turn features on and off, as well as to control numeric quantities to 'tune' algorithms.  Once I make sure it's working across all platforms I'll send out a quick tutorial on its use.

Review URL: https://codereview.appspot.com/7098051

git-svn-id: http://skia.googlecode.com/svn/trunk@7158 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMake SkScalerContextRec::getMatrixFrom2x2 more direct.
bungeman@google.com [Mon, 14 Jan 2013 18:25:55 +0000 (18:25 +0000)]
Make SkScalerContextRec::getMatrixFrom2x2 more direct.
https://codereview.appspot.com/7070072/

git-svn-id: http://skia.googlecode.com/svn/trunk@7157 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix uninitialized memory issue
robertphillips@google.com [Mon, 14 Jan 2013 18:10:08 +0000 (18:10 +0000)]
Fix uninitialized memory issue

https://codereview.appspot.com/7085055/

git-svn-id: http://skia.googlecode.com/svn/trunk@7156 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoChange SkAutoTUnref usage
robertphillips@google.com [Mon, 14 Jan 2013 17:40:15 +0000 (17:40 +0000)]
Change SkAutoTUnref usage

https://codereview.appspot.com/7094054/

git-svn-id: http://skia.googlecode.com/svn/trunk@7155 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix debug build after r7153 (removed param referenced in assertion)
bsalomon@google.com [Mon, 14 Jan 2013 17:07:22 +0000 (17:07 +0000)]
Fix debug build after r7153 (removed param referenced in assertion)

git-svn-id: http://skia.googlecode.com/svn/trunk@7154 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoChange signature of SkShader::asNewEffect(), implement for SkBitmapProcShader.
bsalomon@google.com [Mon, 14 Jan 2013 16:46:26 +0000 (16:46 +0000)]
Change signature of SkShader::asNewEffect(), implement for SkBitmapProcShader.
Review URL: https://codereview.appspot.com/7086051

git-svn-id: http://skia.googlecode.com/svn/trunk@7153 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoChanging imageFilter GM tests to use drawBitmap instead of drawSprite
junov@chromium.org [Mon, 14 Jan 2013 16:27:50 +0000 (16:27 +0000)]
Changing imageFilter GM tests to use drawBitmap instead of drawSprite

The motivation is be able to test the filters with scaled SkPicture playback in isolation from the issues that surround usage of drawSprite
Review URL: https://codereview.appspot.com/7060071

git-svn-id: http://skia.googlecode.com/svn/trunk@7152 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoUse the NDK's cpu-features library when building skia for Chromium/Android.
digit@google.com [Mon, 14 Jan 2013 14:58:22 +0000 (14:58 +0000)]
Use the NDK's cpu-features library when building skia for Chromium/Android.

This patch ensures that when Skia is built for Chromium, it will
always use the Android NDK's cpu-features helper library to detect
NEON at runtime.

This is needed because sandboxed Chromium renderer processes cannot
access /proc, and the probing performed in SkUtilsArm.cpp will never
work. As such, the NEON code paths will never be used even when the
device supports them.

Chromium has special code that ensures that the browser process
passes the CPU features flags to every renderer process, but
Skia needs to use android_getCpuFeatures() to get them.

See http://crbug.com/164154 for full details.
Review URL: https://codereview.appspot.com/7102045

git-svn-id: http://skia.googlecode.com/svn/trunk@7149 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix typo bug caught by mac warn-as-error (= should have been &=).
bsalomon@google.com [Mon, 14 Jan 2013 14:36:40 +0000 (14:36 +0000)]
Fix typo bug caught by mac warn-as-error (= should have been &=).

git-svn-id: http://skia.googlecode.com/svn/trunk@7148 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoImplement getConstantColorComponents() for matrix convolution.
bsalomon@google.com [Fri, 11 Jan 2013 22:24:04 +0000 (22:24 +0000)]
Implement getConstantColorComponents() for matrix convolution.

R=senorblanco@chromium.org
Review URL: https://codereview.appspot.com/7092047

git-svn-id: http://skia.googlecode.com/svn/trunk@7146 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd GrEffect::updateKnownColorComponents(). It is used to determine whether the outpu...
bsalomon@google.com [Fri, 11 Jan 2013 21:08:55 +0000 (21:08 +0000)]
Add GrEffect::updateKnownColorComponents(). It is used to determine whether the output of an effect has a constant output value for r,g,b, or a.
Review URL: https://codereview.appspot.com/7064057

git-svn-id: http://skia.googlecode.com/svn/trunk@7144 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdding commandline option to gm to make it write image results for tests that fails...
junov@chromium.org [Fri, 11 Jan 2013 21:04:40 +0000 (21:04 +0000)]
Adding commandline option to gm to make it write image results for tests that fails due to pixel mismatches.
Review URL: https://codereview.appspot.com/7100043

git-svn-id: http://skia.googlecode.com/svn/trunk@7143 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix leaks in blurrect benchs and gm.
bsalomon@google.com [Fri, 11 Jan 2013 20:54:44 +0000 (20:54 +0000)]
Fix leaks in blurrect benchs and gm.
Review URL: https://codereview.appspot.com/7071060

git-svn-id: http://skia.googlecode.com/svn/trunk@7142 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoEnable per-tile logging in bench_pictures
borenet@google.com [Fri, 11 Jan 2013 20:45:24 +0000 (20:45 +0000)]
Enable per-tile logging in bench_pictures

- Modify bench_pictures buildstep to translate "key: True" --> "--key" rather
  than requiring "key: value" --> "--key value"
- Add whacky TileArgs helper which includes "timeIndividualTiles: True"
Review URL: https://codereview.appspot.com/7092046

git-svn-id: http://skia.googlecode.com/svn/trunk@7141 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd option to render PDFs to memory only.
edisonn@google.com [Fri, 11 Jan 2013 20:30:41 +0000 (20:30 +0000)]
Add option to render PDFs to memory only.
Review URL: https://codereview.appspot.com/7097045

git-svn-id: http://skia.googlecode.com/svn/trunk@7140 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSkImageDecoder_WIC should work on Win7 with Win8 SDK.
bungeman@google.com [Fri, 11 Jan 2013 20:02:32 +0000 (20:02 +0000)]
SkImageDecoder_WIC should work on Win7 with Win8 SDK.
https://codereview.appspot.com/7099044/

git-svn-id: http://skia.googlecode.com/svn/trunk@7139 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix typo, report in validate diff teh value of the pixel, not the address of the...
edisonn@google.com [Fri, 11 Jan 2013 16:08:07 +0000 (16:08 +0000)]
Fix typo, report in validate diff teh value of the pixel, not the address of the pixel.

git-svn-id: http://skia.googlecode.com/svn/trunk@7135 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRebaselined webpage image GMs for ['base-macmini'] on Google Storage.
rmistry@google.com [Fri, 11 Jan 2013 14:19:52 +0000 (14:19 +0000)]
Rebaselined webpage image GMs for ['base-macmini'] on Google Storage.

git-svn-id: http://skia.googlecode.com/svn/trunk@7130 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMake GrEffect::textureAccess non-virtual. Require subclasses to append their GrTAs.
bsalomon@google.com [Fri, 11 Jan 2013 13:54:30 +0000 (13:54 +0000)]
Make GrEffect::textureAccess non-virtual. Require subclasses to append their GrTAs.
Review URL: https://codereview.appspot.com/7062063

git-svn-id: http://skia.googlecode.com/svn/trunk@7129 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemove non-destructive playback from GrIODB.
bsalomon@google.com [Fri, 11 Jan 2013 13:54:21 +0000 (13:54 +0000)]
Remove non-destructive playback from GrIODB.
Review URL: https://codereview.appspot.com/7057070

git-svn-id: http://skia.googlecode.com/svn/trunk@7128 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Fri, 11 Jan 2013 02:01:25 +0000 (02:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@7127 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoWhitespace change to trigger rebuilds
rmistry@google.com [Fri, 11 Jan 2013 01:42:39 +0000 (01:42 +0000)]
Whitespace change to trigger rebuilds

git-svn-id: http://skia.googlecode.com/svn/trunk@7126 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRename onFilterImageGPU to filterImageGPU(), to match skia convention. No change...
senorblanco@chromium.org [Thu, 10 Jan 2013 19:55:18 +0000 (19:55 +0000)]
Rename onFilterImageGPU to filterImageGPU(), to match skia convention.  No change in functionality.

(Note that this does mean that clients must override onFilterImage() to implement the raster path, but filterImageGPU() to implement the GPU path.)

Review URL: https://codereview.appspot.com/7058078

git-svn-id: http://skia.googlecode.com/svn/trunk@7123 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoDirectWrite generatePath must transform the path by the current matrix.
bungeman@google.com [Thu, 10 Jan 2013 18:56:18 +0000 (18:56 +0000)]
DirectWrite generatePath must transform the path by the current matrix.
https://codereview.appspot.com/7061061/

This will require at least the shadertext2 gm for DirectWrite to be rebaselined.

git-svn-id: http://skia.googlecode.com/svn/trunk@7121 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd display of more SkPaint fields in Debugger
robertphillips@google.com [Thu, 10 Jan 2013 18:54:11 +0000 (18:54 +0000)]
Add display of more SkPaint fields in Debugger

https://codereview.appspot.com/7060063/

git-svn-id: http://skia.googlecode.com/svn/trunk@7120 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agogm: if no readPath is given, report all tests as "missing reference image" instead...
epoger@google.com [Thu, 10 Jan 2013 17:11:27 +0000 (17:11 +0000)]
gm: if no readPath is given, report all tests as "missing reference image" instead of "passed"
Review URL: https://codereview.appspot.com/7070066

git-svn-id: http://skia.googlecode.com/svn/trunk@7119 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix assertion caused by change in 7117.
bungeman@google.com [Thu, 10 Jan 2013 16:58:02 +0000 (16:58 +0000)]
Fix assertion caused by change in 7117.

SkRect::intersect returns false if either rectange is empty.
SkCanvas::quickReject returns true if an empty rectange is entirely contained within the clip bounds.

git-svn-id: http://skia.googlecode.com/svn/trunk@7118 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoProperly reject clipped out draws in BBox pictures.
bungeman@google.com [Thu, 10 Jan 2013 16:31:09 +0000 (16:31 +0000)]
Properly reject clipped out draws in BBox pictures.
https://codereview.appspot.com/7057065/

git-svn-id: http://skia.googlecode.com/svn/trunk@7117 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agogm self-test: update expected dashing2.png images (in inputs/ dir) to reflect new...
epoger@google.com [Thu, 10 Jan 2013 15:56:44 +0000 (15:56 +0000)]
gm self-test: update expected dashing2.png images (in inputs/ dir) to reflect new behavior

TBR=reed1
Review URL: https://codereview.appspot.com/7068060

git-svn-id: http://skia.googlecode.com/svn/trunk@7116 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoUpdate order in third_party/externals svn:externals property to match DEPS.
bungeman@google.com [Thu, 10 Jan 2013 15:47:41 +0000 (15:47 +0000)]
Update order in third_party/externals svn:externals property to match DEPS.

With the previous order a clean svn checkout fails to pull jsoncpp correctly.

git-svn-id: http://skia.googlecode.com/svn/trunk@7115 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemove default clip/drawstate in GrIODB.
bsalomon@google.com [Thu, 10 Jan 2013 14:40:28 +0000 (14:40 +0000)]
Remove default clip/drawstate in GrIODB.

R=robertphillips@google.com
Review URL: https://codereview.appspot.com/7070064

git-svn-id: http://skia.googlecode.com/svn/trunk@7114 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Thu, 10 Jan 2013 02:01:29 +0000 (02:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@7113 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix incorrect sample cnt assert
bsalomon@google.com [Wed, 9 Jan 2013 23:29:39 +0000 (23:29 +0000)]
Fix incorrect sample cnt assert

git-svn-id: http://skia.googlecode.com/svn/trunk@7112 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoEnsure that SkMemoryStream does not crash dereferencing fData.
scroggo@google.com [Wed, 9 Jan 2013 22:02:58 +0000 (22:02 +0000)]
Ensure that SkMemoryStream does not crash dereferencing fData.

SkMemoryStream attempts to dereference fData in multiple places.
Instead of allowing it to be NULL, resulting in a crash, set it
to SkData::NewEmpty().

Add a test for SkStream that will crash when its SkData is set to NULL.

Review URL: https://codereview.appspot.com/7061059

git-svn-id: http://skia.googlecode.com/svn/trunk@7111 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoThis takes the convex path tesselator from the Android code and hooks it into a
jvanverth@google.com [Wed, 9 Jan 2013 21:04:52 +0000 (21:04 +0000)]
This takes the convex path tesselator from the Android code and hooks it into a
GrPathRenderer. GrAndroidPathRenderer is activated by gyp flag 'skia_android_path_rendering'.

A few changes to get this to work:
- Had to change SkPaint* param to SkStrokeRec& in ConvexPathVertices()
- Had to copy the vertex buffer created by the Android code to GrDrawTarget-generated vertex buffer, and convert float alpha to GrColor for AA paths

git-svn-id: http://skia.googlecode.com/svn/trunk@7110 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd clear after each image save, so that GPU images won't end up progressively compos...
jvanverth@google.com [Wed, 9 Jan 2013 18:22:53 +0000 (18:22 +0000)]
Add clear after each image save, so that GPU images won't end up progressively compositing on top of one another.

git-svn-id: http://skia.googlecode.com/svn/trunk@7108 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agofix iOS build after adding modifierKeys to click events
reed@google.com [Wed, 9 Jan 2013 16:36:30 +0000 (16:36 +0000)]
fix iOS build after adding modifierKeys to click events

git-svn-id: http://skia.googlecode.com/svn/trunk@7107 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRebaselined webpage image GMs for ['base-shuttle-win7-intel-angle'] on Google Storage.
rmistry@google.com [Wed, 9 Jan 2013 13:33:22 +0000 (13:33 +0000)]
Rebaselined webpage image GMs for ['base-shuttle-win7-intel-angle'] on Google Storage.

git-svn-id: http://skia.googlecode.com/svn/trunk@7100 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Wed, 9 Jan 2013 02:01:30 +0000 (02:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@7099 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agospeculative change to speedup blurrect bench for large radius, to see if the bots...
mike@reedtribe.org [Wed, 9 Jan 2013 00:59:11 +0000 (00:59 +0000)]
speculative change to speedup blurrect bench for large radius, to see if the bots are timing out

git-svn-id: http://skia.googlecode.com/svn/trunk@7098 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoTurn off WarnAsError when building ANGLE projects on windows.
bsalomon@google.com [Tue, 8 Jan 2013 21:46:05 +0000 (21:46 +0000)]
Turn off WarnAsError when building ANGLE projects on windows.

git-svn-id: http://skia.googlecode.com/svn/trunk@7096 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoTurn off warnings-as-error on 64bit windows build due to many size_t-related warnings.
bsalomon@google.com [Tue, 8 Jan 2013 20:40:22 +0000 (20:40 +0000)]
Turn off warnings-as-error on 64bit windows build due to many size_t-related warnings.

git-svn-id: http://skia.googlecode.com/svn/trunk@7095 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoEnable warnings-as-errors on Windows.
bsalomon@google.com [Tue, 8 Jan 2013 20:31:53 +0000 (20:31 +0000)]
Enable warnings-as-errors on Windows.
Review URL: https://codereview.appspot.com/7066054

git-svn-id: http://skia.googlecode.com/svn/trunk@7094 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agogm: remove --diffPath option and all other pixel diff functionality.
epoger@google.com [Tue, 8 Jan 2013 18:47:31 +0000 (18:47 +0000)]
gm: remove --diffPath option and all other pixel diff functionality.
If you want pixel diffs, you need to run skdiff instead; from now on,
gm will only tell you WHETHER the images differed (not HOW they differed).
Review URL: https://codereview.appspot.com/7064047

git-svn-id: http://skia.googlecode.com/svn/trunk@7093 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix signed/unsigned comparison in PictureTest.cpp
bsalomon@google.com [Tue, 8 Jan 2013 18:42:20 +0000 (18:42 +0000)]
Fix signed/unsigned comparison in PictureTest.cpp

git-svn-id: http://skia.googlecode.com/svn/trunk@7092 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRebaselined webpage image GMs for ['base-android-xoom'] on Google Storage.
rmistry@google.com [Tue, 8 Jan 2013 17:59:54 +0000 (17:59 +0000)]
Rebaselined webpage image GMs for ['base-android-xoom'] on Google Storage.

git-svn-id: http://skia.googlecode.com/svn/trunk@7091 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRebaselined webpage image GMs for %s on Google Storage.
rmistry@google.com [Tue, 8 Jan 2013 17:57:12 +0000 (17:57 +0000)]
Rebaselined webpage image GMs for %s on Google Storage.

git-svn-id: http://skia.googlecode.com/svn/trunk@7090 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRebaselined webpage image GMs for %s on Google Storage.
rmistry@google.com [Tue, 8 Jan 2013 17:52:58 +0000 (17:52 +0000)]
Rebaselined webpage image GMs for %s on Google Storage.

git-svn-id: http://skia.googlecode.com/svn/trunk@7089 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix signed/unsigned comparison warning in PictureTest.cpp
bsalomon@google.com [Tue, 8 Jan 2013 17:24:44 +0000 (17:24 +0000)]
Fix signed/unsigned comparison warning in PictureTest.cpp

git-svn-id: http://skia.googlecode.com/svn/trunk@7088 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agotranslate modifier keys for xevents
reed@google.com [Tue, 8 Jan 2013 16:50:52 +0000 (16:50 +0000)]
translate modifier keys for xevents

git-svn-id: http://skia.googlecode.com/svn/trunk@7087 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix macro redefinition warning on 10.6 bots in mesa code.
bsalomon@google.com [Tue, 8 Jan 2013 16:33:41 +0000 (16:33 +0000)]
Fix macro redefinition warning on 10.6 bots in mesa code.

R=humper@google.com
Review URL: https://codereview.appspot.com/7063050

git-svn-id: http://skia.googlecode.com/svn/trunk@7086 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agofix linux build
reed@google.com [Tue, 8 Jan 2013 16:25:42 +0000 (16:25 +0000)]
fix linux build

git-svn-id: http://skia.googlecode.com/svn/trunk@7085 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agofix win build
reed@google.com [Tue, 8 Jan 2013 16:22:44 +0000 (16:22 +0000)]
fix win build

git-svn-id: http://skia.googlecode.com/svn/trunk@7084 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agopass modifier keys to click events (e.g. control | shift etc.)
reed@google.com [Tue, 8 Jan 2013 16:17:50 +0000 (16:17 +0000)]
pass modifier keys to click events (e.g. control | shift etc.)
Review URL: https://codereview.appspot.com/7062054

git-svn-id: http://skia.googlecode.com/svn/trunk@7082 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agofix GPU drawing for 8 bit alpha bitmaps
humper@google.com [Tue, 8 Jan 2013 16:08:01 +0000 (16:08 +0000)]
fix GPU drawing for 8 bit alpha bitmaps

BUG=

Review URL: https://codereview.appspot.com/7070052

git-svn-id: http://skia.googlecode.com/svn/trunk@7081 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years ago$(SVN_VERSION) -> $SVN_VERSION in build-tot-chromium.sh
rmistry@google.com [Tue, 8 Jan 2013 15:56:15 +0000 (15:56 +0000)]
$(SVN_VERSION) -> $SVN_VERSION in build-tot-chromium.sh
Review URL: https://codereview.appspot.com/7071053

git-svn-id: http://skia.googlecode.com/svn/trunk@7080 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoScript to checkout and build ToT chromium with ToT skia
rmistry@google.com [Tue, 8 Jan 2013 14:43:40 +0000 (14:43 +0000)]
Script to checkout and build ToT chromium with ToT skia
Review URL: https://codereview.appspot.com/7036049

git-svn-id: http://skia.googlecode.com/svn/trunk@7079 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoProposed fix to new stroking/path render selection system
robertphillips@google.com [Tue, 8 Jan 2013 13:45:09 +0000 (13:45 +0000)]
Proposed fix to new stroking/path render selection system

https://codereview.appspot.com/7075043/

git-svn-id: http://skia.googlecode.com/svn/trunk@7076 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agofix warings. add SkTAbs()
reed@google.com [Tue, 8 Jan 2013 13:23:32 +0000 (13:23 +0000)]
fix warings. add SkTAbs()

git-svn-id: http://skia.googlecode.com/svn/trunk@7075 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agofix spelling: cannonical -> canonical
reed@google.com [Tue, 8 Jan 2013 13:07:25 +0000 (13:07 +0000)]
fix spelling: cannonical -> canonical

git-svn-id: http://skia.googlecode.com/svn/trunk@7074 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRebaselined webpage image GMs for ['base-shuttle-win7-intel-float'] on Google Storage.
rmistry@google.com [Tue, 8 Jan 2013 02:11:58 +0000 (02:11 +0000)]
Rebaselined webpage image GMs for ['base-shuttle-win7-intel-float'] on Google Storage.

git-svn-id: http://skia.googlecode.com/svn/trunk@7073 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Tue, 8 Jan 2013 02:01:29 +0000 (02:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@7072 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agofix warnings
reed@google.com [Mon, 7 Jan 2013 22:26:05 +0000 (22:26 +0000)]
fix warnings
Review URL: https://codereview.appspot.com/7060053

git-svn-id: http://skia.googlecode.com/svn/trunk@7070 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agofix warnings (float to int), and convert to skia-style
reed@google.com [Mon, 7 Jan 2013 21:54:25 +0000 (21:54 +0000)]
fix warnings (float to int), and convert to skia-style

style examples:
- use const: (const SkRect&) instead of (SkRect&)
- spacing: (Type& r) instead of ( Type &r )
- use SK_OVERRIDE
Review URL: https://codereview.appspot.com/7066051

git-svn-id: http://skia.googlecode.com/svn/trunk@7069 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agodisable warnings-as-error for JSON code, which has warnings (at least on mac)
reed@google.com [Mon, 7 Jan 2013 20:51:13 +0000 (20:51 +0000)]
disable warnings-as-error for JSON code, which has warnings (at least on mac)
Review URL: https://codereview.appspot.com/7064053

git-svn-id: http://skia.googlecode.com/svn/trunk@7068 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agodisable werror on 64 bit
humper@google.com [Mon, 7 Jan 2013 20:28:16 +0000 (20:28 +0000)]
disable werror on 64 bit

BUG=

Review URL: https://codereview.appspot.com/7057057

git-svn-id: http://skia.googlecode.com/svn/trunk@7066 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoabandon SK_IGNORE_TREAT_AS_SPRITE as a flag, and use SK_IGNORE_TRANS_CLAMP_FIX
reed@google.com [Mon, 7 Jan 2013 20:27:52 +0000 (20:27 +0000)]
abandon SK_IGNORE_TREAT_AS_SPRITE as a flag, and use SK_IGNORE_TRANS_CLAMP_FIX
for the fixes in SkDraw.cpp and SkBitmapProcState.cpp

Also, change the call in SkDraw.cpp to pass 0 for subpixel bits, to match the
old logic.... we should have a runtime fix for this in the future, so a caller
*can* get subpixel-filtered images w/ just translate.

git-svn-id: http://skia.googlecode.com/svn/trunk@7065 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agofix warnings
reed@google.com [Mon, 7 Jan 2013 20:25:04 +0000 (20:25 +0000)]
fix warnings
Review URL: https://codereview.appspot.com/7073044

git-svn-id: http://skia.googlecode.com/svn/trunk@7064 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agofix warning in render pdf tool
humper@google.com [Mon, 7 Jan 2013 20:08:56 +0000 (20:08 +0000)]
fix warning in render pdf tool

BUG=

Review URL: https://codereview.appspot.com/7033056

git-svn-id: http://skia.googlecode.com/svn/trunk@7063 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRevert part of r7047 to check Xoom failures
robertphillips@google.com [Mon, 7 Jan 2013 20:07:48 +0000 (20:07 +0000)]
Revert part of r7047 to check Xoom failures

https://codereview.appspot.com/7070049/

git-svn-id: http://skia.googlecode.com/svn/trunk@7062 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agofix warning from scalar --> int32 conversion
humper@google.com [Mon, 7 Jan 2013 19:54:40 +0000 (19:54 +0000)]
fix warning from scalar --> int32 conversion

BUG=

Review URL: https://codereview.appspot.com/7065050

git-svn-id: http://skia.googlecode.com/svn/trunk@7061 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agohopefully fix gyp mistake for iOS
humper@google.com [Mon, 7 Jan 2013 19:02:46 +0000 (19:02 +0000)]
hopefully fix gyp mistake for iOS

BUG=

Review URL: https://codereview.appspot.com/7065052

git-svn-id: http://skia.googlecode.com/svn/trunk@7058 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoCleaned up warnings in Windows build.
jvanverth@google.com [Mon, 7 Jan 2013 18:41:28 +0000 (18:41 +0000)]
Cleaned up warnings in Windows build.

git-svn-id: http://skia.googlecode.com/svn/trunk@7057 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix warning-as-error for var used only in an assert (and therefore not in the release...
bsalomon@google.com [Mon, 7 Jan 2013 17:35:10 +0000 (17:35 +0000)]
Fix warning-as-error for var used only in an assert (and therefore not in the release build).

git-svn-id: http://skia.googlecode.com/svn/trunk@7054 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemove GrTDArray.
bsalomon@google.com [Mon, 7 Jan 2013 17:23:00 +0000 (17:23 +0000)]
Remove GrTDArray.

Two dynamic array classes is enough.

R=reed@google.com
Review URL: https://codereview.appspot.com/7069047

git-svn-id: http://skia.googlecode.com/svn/trunk@7053 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAttempt to fix NULL to intptr_t warning-as-error on mac build.
bsalomon@google.com [Mon, 7 Jan 2013 17:21:07 +0000 (17:21 +0000)]
Attempt to fix NULL to intptr_t warning-as-error on mac build.

git-svn-id: http://skia.googlecode.com/svn/trunk@7052 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoeliminate all warnings in non-thirdparty code on mac
humper@google.com [Mon, 7 Jan 2013 16:47:43 +0000 (16:47 +0000)]
eliminate all warnings in non-thirdparty code on mac

Most of these issues were due to functions whose definitions appear in header files; I changed those functions to be 'static inline' instead of just 'static' or 'inline', which kills the warning for such functions.

Other functions that were static or anonymous-namespaced but were unused in cpp files were probably called at some point but are no longer; someone who knows more than I do should probably scrub all the functions I either deleted or #if 0'ed out and make sure that the right thing is happening here.

Lots of unused variables removed, and one nasty const issue handled.

There remains a single warning in thirdparty/externals/cityhash/src/city.cc on line 146 related to a signed/unsigned mismatch.  I don't know if we have control over this library so I didn't fix this one, but perhaps someone could do something about that one.

BUG=

Review URL: https://codereview.appspot.com/7067044

git-svn-id: http://skia.googlecode.com/svn/trunk@7051 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRebaselined webpage image GMs for ['base-android-xoom'] on Google Storage.
rmistry@google.com [Mon, 7 Jan 2013 16:30:35 +0000 (16:30 +0000)]
Rebaselined webpage image GMs for ['base-android-xoom'] on Google Storage.

git-svn-id: http://skia.googlecode.com/svn/trunk@7050 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRebaselined webpage image GMs for %s on Google Storage.
rmistry@google.com [Mon, 7 Jan 2013 16:27:33 +0000 (16:27 +0000)]
Rebaselined webpage image GMs for %s on Google Storage.

git-svn-id: http://skia.googlecode.com/svn/trunk@7049 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoShow the paint's typeface information in the details pane of the debugger.
humper@google.com [Mon, 7 Jan 2013 15:48:19 +0000 (15:48 +0000)]
Show the paint's typeface information in the details pane of the debugger.

Also add a convenience constructor for SkMemoryStream that takes the SkData directly
(instead of having to construct an empty one and call setData).
Review URL: https://codereview.appspot.com/7065045

git-svn-id: http://skia.googlecode.com/svn/trunk@7048 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoThis CL introduces a new path renderer.
sugoi@google.com [Mon, 7 Jan 2013 14:26:40 +0000 (14:26 +0000)]
This CL introduces a new path renderer.

Here are the characteristics :
- It uses the original path, before stroking
- It supports traight lines only (no curves)
- It supports butt or square caps only
- It supports miter or bevel joins only
- No AA support
Support for these will be added step by step later on.

A first pass at the benchmarks on my linux machine gave me these approximate speed improvements (running all bench with the option '--forceAA 0') :
path_stroke_small_long_line 4X
path_stroke_small_sawtooth 4X
path_stroke_big_rect 4X
path_stroke_small_rect 6X
path_stroke_big_triangle 4X
path_stroke_small_triangle 10X
lines_1_BW 1.5X
dashline_2_square 1.5X
dashline_1_square 1.5X

Also note that I can't submit this code until GrDrawTarget::isOpaque() is implemented, unless I just disable my renderer completely for now.

BUG=chromium:135111
TEST=The following gms are affected and may require rebaselining : lineclosepath, linepath, strokes_poly
Review URL: https://codereview.appspot.com/7026049

git-svn-id: http://skia.googlecode.com/svn/trunk@7047 2bbb7eff-a529-9590-31e7-b0007b416f81