platform/upstream/efl.git
14 years agopatch from tasn: rtl fit.
Carsten Haitzler [Sun, 22 Nov 2009 01:49:44 +0000 (01:49 +0000)]
patch from tasn: rtl fit.

SVN revision: 43886

14 years agofind gl symbols runtime - some gl's support the feature but havent
Carsten Haitzler [Sat, 21 Nov 2009 10:51:51 +0000 (10:51 +0000)]
find gl symbols runtime - some gl's support the feature but havent
standardised symbols! (bad gl! bad!)

SVN revision: 43857

14 years agominor formatting.
Christopher Michael [Sat, 21 Nov 2009 01:34:49 +0000 (01:34 +0000)]
minor formatting.

SVN revision: 43855

14 years ago * eina_module: Add eina_module_find. Thanks to Fabiano Fidêncio <fidencio@profusion...
Cedric BAIL [Fri, 20 Nov 2009 20:46:24 +0000 (20:46 +0000)]
* eina_module: Add eina_module_find. Thanks to Fabiano Fidêncio <fidencio@profusion.mobi>.

SVN revision: 43847

14 years ago * ecore_con: Add support for TCP_NODELAY.
Cedric BAIL [Fri, 20 Nov 2009 10:58:19 +0000 (10:58 +0000)]
* ecore_con: Add support for TCP_NODELAY.

SVN revision: 43818

14 years ago * ecore_con_url: When download was broken in the middle, you could
Cedric BAIL [Thu, 19 Nov 2009 18:45:51 +0000 (18:45 +0000)]
* ecore_con_url: When download was broken in the middle, you could
have a status of 200 without all data being downloaded. This should
fix this case.

SVN revision: 43805

14 years agostupid AC_CHECK_PROG
Vincent Torri [Thu, 19 Nov 2009 09:02:25 +0000 (09:02 +0000)]
stupid AC_CHECK_PROG

SVN revision: 43800

14 years ago0x0 smarts will no be rendered again - well children will be... but its still
Carsten Haitzler [Thu, 19 Nov 2009 08:37:22 +0000 (08:37 +0000)]
0x0 smarts will no be rendered again - well children will be... but its still
bad form to do this. oddly - the desktop panning in e does this. need to check.

SVN revision: 43799

14 years agominor fix
Vincent Torri [Thu, 19 Nov 2009 08:29:22 +0000 (08:29 +0000)]
minor fix

SVN revision: 43797

14 years agofix bug spotted by Brian Wang.
Gustavo Sverzut Barbieri [Thu, 19 Nov 2009 00:38:34 +0000 (00:38 +0000)]
fix bug spotted by Brian Wang.

SVN revision: 43793

14 years agoxrandr 1.3 checks - 1.3 minimum.
Carsten Haitzler [Wed, 18 Nov 2009 02:31:00 +0000 (02:31 +0000)]
xrandr 1.3 checks - 1.3 minimum.

SVN revision: 43764

14 years agoEdje_Edit
Iván Briano [Wed, 18 Nov 2009 00:27:49 +0000 (00:27 +0000)]
Edje_Edit
 - Watch for non-shared strings when copying states
 - Get/Set external parameters

SVN revision: 43757

14 years ago<glima> commit msg would be something like: "applying size recalcs on
Iván Briano [Tue, 17 Nov 2009 00:19:24 +0000 (00:19 +0000)]
<glima> commit msg would be something like: "applying size recalcs on
        childs in the case they have size hints for Evas_Object_Box'es.
        it was documented on the layouts api but never implemented"

SVN revision: 43745

14 years ago1. if you stack above/below yourself.. you get lost as an obj! ignore
Carsten Haitzler [Sun, 15 Nov 2009 13:46:20 +0000 (13:46 +0000)]
1. if you stack above/below yourself.. you get lost as an obj! ignore
that case
2. add render debug #ifdef in evas_render.c and latent render debug stuff

SVN revision: 43706

14 years agoEcore : cleanup
Jonathan Atton [Sat, 14 Nov 2009 14:06:58 +0000 (14:06 +0000)]
Ecore : cleanup

SVN revision: 43691

14 years agoEcore : Fix ecore con destroy
Jonathan Atton [Sat, 14 Nov 2009 13:43:38 +0000 (13:43 +0000)]
Ecore : Fix ecore con destroy

SVN revision: 43689

14 years agoi forgot to align the result
Vincent Torri [Sat, 14 Nov 2009 08:43:18 +0000 (08:43 +0000)]
i forgot to align the result

SVN revision: 43688

14 years agobetter configure output
Vincent Torri [Sat, 14 Nov 2009 08:40:11 +0000 (08:40 +0000)]
better configure output

If nobody is against it, i'll change the configure output
of the EFL so that it is the same

SVN revision: 43687

14 years agofix font alloc bug!
Carsten Haitzler [Sat, 14 Nov 2009 05:08:00 +0000 (05:08 +0000)]
fix font alloc bug!

SVN revision: 43686

14 years agoFix to new Ecore API
Iván Briano [Fri, 13 Nov 2009 23:59:46 +0000 (23:59 +0000)]
Fix to new Ecore API

SVN revision: 43685

14 years agodo not run cleanup all the time and avoid bug of walking list from
Gustavo Sverzut Barbieri [Fri, 13 Nov 2009 20:34:51 +0000 (20:34 +0000)]
do not run cleanup all the time and avoid bug of walking list from
inside list.

if l->next was also deleted by _ecore_main_fd_handlers_cleanup(), then
we had a crash :-(

SVN revision: 43676

14 years agoConstness and pass object around
Iván Briano [Fri, 13 Nov 2009 18:35:19 +0000 (18:35 +0000)]
Constness and pass object around

SVN revision: 43671

14 years ago * ecore_con_url: The fd could change for a same url. So destroy it and recreat.
Cedric BAIL [Fri, 13 Nov 2009 18:12:09 +0000 (18:12 +0000)]
* ecore_con_url: The fd could change for a same url. So destroy it and recreat.

SVN revision: 43670

14 years ago * eina: Now it's possible set a level when eina should abort on log.
Cedric BAIL [Fri, 13 Nov 2009 17:52:43 +0000 (17:52 +0000)]
* eina: Now it's possible set a level when eina should abort on log.

SVN revision: 43669

14 years agoEcore : ecore_dowload return the job and we can canceled it.
Jonathan Atton [Fri, 13 Nov 2009 17:51:52 +0000 (17:51 +0000)]
Ecore : ecore_dowload return the job and we can canceled it.

SVN revision: 43668

14 years ago * ecore: Fix ecore_timer_freeze during timer execution.
Cedric BAIL [Fri, 13 Nov 2009 17:37:43 +0000 (17:37 +0000)]
* ecore: Fix ecore_timer_freeze during timer execution.

SVN revision: 43667

14 years ago * ecore: Fix destruction of frozen timer, by not delaying their destruction.
Cedric BAIL [Fri, 13 Nov 2009 16:57:12 +0000 (16:57 +0000)]
* ecore: Fix destruction of frozen timer, by not delaying their destruction.

SVN revision: 43665

14 years agofix gles symbols
Carsten Haitzler [Fri, 13 Nov 2009 12:31:31 +0000 (12:31 +0000)]
fix gles symbols

SVN revision: 43662

14 years agofix gles defs
Carsten Haitzler [Fri, 13 Nov 2009 11:30:28 +0000 (11:30 +0000)]
fix gles defs

SVN revision: 43660

14 years agoon paper.. go gles2 too... that should work.. in theory. need to test.
Carsten Haitzler [Fri, 13 Nov 2009 08:43:50 +0000 (08:43 +0000)]
on paper.. go gles2 too... that should work.. in theory. need to test.

SVN revision: 43659

14 years agofix color stuff.. next.. need to fix z stuff.
Carsten Haitzler [Fri, 13 Nov 2009 08:38:12 +0000 (08:38 +0000)]
fix color stuff.. next.. need to fix z stuff.

SVN revision: 43658

14 years agofix some valgrind issues
Carsten Haitzler [Fri, 13 Nov 2009 08:28:47 +0000 (08:28 +0000)]
fix some valgrind issues

SVN revision: 43657

14 years agoand now complex stuff works..... woot!
Carsten Haitzler [Fri, 13 Nov 2009 08:19:13 +0000 (08:19 +0000)]
and now complex stuff works..... woot!

SVN revision: 43656

14 years agofix disabling of blendipoos!
Carsten Haitzler [Fri, 13 Nov 2009 07:30:03 +0000 (07:30 +0000)]
fix disabling of blendipoos!

SVN revision: 43655

14 years agodel fbo as well if it exists
Carsten Haitzler [Fri, 13 Nov 2009 07:25:08 +0000 (07:25 +0000)]
del fbo as well if it exists

SVN revision: 43654

14 years agorender-to-texture now is used for evas maps... but only simple cases seem to
Carsten Haitzler [Fri, 13 Nov 2009 07:22:31 +0000 (07:22 +0000)]
render-to-texture now is used for evas maps... but only simple cases seem to
work. (in ello) elementary stuff seems... less happy. will work on it! also
havent done the gles bits. just desktop gl (first port of call for
doing/testing). the #ifdefs are ther waiting with fixme's

SVN revision: 43653

14 years agofix stringshare of small strings.
Gustavo Sverzut Barbieri [Thu, 12 Nov 2009 19:41:02 +0000 (19:41 +0000)]
fix stringshare of small strings.

_eina_stringshare_small_bucket_find() was receiving the plength with
size -1 since the first character is the same, but inside it was not
doing the same, thus it was always failing the first test based on
size.

SVN revision: 43634

14 years agoconsistent return
Iván Briano [Thu, 12 Nov 2009 15:41:45 +0000 (15:41 +0000)]
consistent return

SVN revision: 43630

14 years agoecore_exe is currently not supported on WinCE
Lars Munch [Thu, 12 Nov 2009 15:15:57 +0000 (15:15 +0000)]
ecore_exe is currently not supported on WinCE

SVN revision: 43629

14 years agoFix WinCE engine build
Lars Munch [Thu, 12 Nov 2009 13:49:46 +0000 (13:49 +0000)]
Fix WinCE engine build

SVN revision: 43628

14 years ago * link correctly ecore against pthread
Vincent Torri [Wed, 11 Nov 2009 23:43:58 +0000 (23:43 +0000)]
 * link correctly ecore against pthread
 * use the efl_pthread.m4 macro
 * add configure output for pthread support in ecore

SVN revision: 43627

14 years agoAdd check on libgcrypt library in configure. Needed when GNUtls
Vincent Torri [Wed, 11 Nov 2009 20:05:47 +0000 (20:05 +0000)]
Add check on libgcrypt library in configure. Needed when GNUtls
support is enabled.

SVN revision: 43622

14 years agoAdd some more video extensions to ethumb emotion plugin.
Rafael Antognolli [Wed, 11 Nov 2009 19:06:52 +0000 (19:06 +0000)]
Add some more video extensions to ethumb emotion plugin.

Patch by: João Paulo Rechi Vita.

SVN revision: 43621

14 years agoAdd logging to ethumb emotion plugin.
Rafael Antognolli [Wed, 11 Nov 2009 19:03:25 +0000 (19:03 +0000)]
Add logging to ethumb emotion plugin.

Some debug logging info to ethumb emotion plugin.

SVN revision: 43620

14 years agoAdd Windows directory monitoring to ecore_file. It was tough.
Vincent Torri [Wed, 11 Nov 2009 17:45:55 +0000 (17:45 +0000)]
Add Windows directory monitoring to ecore_file. It was tough.
A lot of thanks to Lars Munch for his great help

SVN revision: 43617

14 years agoallow glew engine to be compiled again
Vincent Torri [Wed, 11 Nov 2009 12:51:24 +0000 (12:51 +0000)]
allow glew engine to be compiled again

SVN revision: 43615

14 years ago/me stuuuuuuuupid, spank spank spank... go test your code before commit :-D
Gustavo Sverzut Barbieri [Wed, 11 Nov 2009 12:47:46 +0000 (12:47 +0000)]
/me stuuuuuuuupid, spank spank spank... go test your code before commit :-D

SVN revision: 43613

14 years agomore evas_map utils, let's avoid duplicating these everywhere.
Gustavo Sverzut Barbieri [Wed, 11 Nov 2009 12:33:52 +0000 (12:33 +0000)]
more evas_map utils, let's avoid duplicating these everywhere.

SVN revision: 43612

14 years agostep 1. some map support! images only right now. next. render-to-texture.
Carsten Haitzler [Wed, 11 Nov 2009 11:39:25 +0000 (11:39 +0000)]
step 1. some map support! images only right now. next. render-to-texture.
invasive change right now.

SVN revision: 43611

14 years agofix compilation of glew engine.
Vincent Torri [Wed, 11 Nov 2009 11:17:11 +0000 (11:17 +0000)]
fix compilation of glew engine.
Unfortunately, the computer on which i compile does not
support OpenGL 2.0, so i can't test the engine.

SVN revision: 43610

14 years agoUse proper index to select mask in _ecore_xcb_key_mask_get
Mikhail Gusarov [Tue, 10 Nov 2009 22:15:00 +0000 (22:15 +0000)]
Use proper index to select mask in _ecore_xcb_key_mask_get

SVN revision: 43607

14 years agoFix linking issue when cross building from linux to windows
Lars Munch [Tue, 10 Nov 2009 16:58:36 +0000 (16:58 +0000)]
Fix linking issue when cross building from linux to windows

SVN revision: 43604

14 years agoFix linking issue when cross building from linux to windows
Lars Munch [Tue, 10 Nov 2009 16:58:20 +0000 (16:58 +0000)]
Fix linking issue when cross building from linux to windows

SVN revision: 43603

14 years agoaaag found the bugger. printf--
Carsten Haitzler [Tue, 10 Nov 2009 09:10:59 +0000 (09:10 +0000)]
aaag found the bugger. printf--

SVN revision: 43601

14 years agook. i'm hunting the bug. yes! printf debuggin gets in! i want others to be
Carsten Haitzler [Tue, 10 Nov 2009 08:50:11 +0000 (08:50 +0000)]
ok. i'm hunting the bug. yes! printf debuggin gets in! i want others to be
able to find it too.

SVN revision: 43600

14 years agoprintf--!
Carsten Haitzler [Mon, 9 Nov 2009 23:48:26 +0000 (23:48 +0000)]
printf--!

SVN revision: 43597

14 years agofix segv on obj del - didnt remove callbacks!
Carsten Haitzler [Mon, 9 Nov 2009 23:47:42 +0000 (23:47 +0000)]
fix segv on obj del - didnt remove callbacks!

SVN revision: 43596

14 years agowhatevr the obj c lang push thing is... it breaks evas' build entirely on
Carsten Haitzler [Mon, 9 Nov 2009 16:29:10 +0000 (16:29 +0000)]
whatevr the obj c lang push thing is... it breaks evas' build entirely on
normal linux. remove.

SVN revision: 43589

14 years agoFix Cocoa.h detection on MacOSX
Raoul HECKY [Mon, 9 Nov 2009 15:40:01 +0000 (15:40 +0000)]
Fix Cocoa.h detection on MacOSX

SVN revision: 43586

14 years agomove check to more unlikely position in chekc order
Carsten Haitzler [Mon, 9 Nov 2009 15:20:32 +0000 (15:20 +0000)]
move check to more unlikely position in chekc order

SVN revision: 43585

14 years agogod damnt that took some time! fixed some bugs with map + smart objcs +
Carsten Haitzler [Mon, 9 Nov 2009 15:18:37 +0000 (15:18 +0000)]
god damnt that took some time! fixed some bugs with map + smart objcs +
repainting etc. etc. - seems to be working now in complex smart obj tests and
simple ones.

SVN revision: 43584

14 years ago * evas: Add support for async callback in Quartz backend.
Cedric BAIL [Mon, 9 Nov 2009 13:04:41 +0000 (13:04 +0000)]
* evas: Add support for async callback in Quartz backend.

TODO: Add map support.

SVN revision: 43582

14 years agoInitialize value for correct counting of # cpu on macosx
Raoul HECKY [Mon, 9 Nov 2009 10:39:49 +0000 (10:39 +0000)]
Initialize value for correct counting of # cpu on macosx

SVN revision: 43571

14 years agonote about distcheck b0rken
Carsten Haitzler [Mon, 9 Nov 2009 10:22:08 +0000 (10:22 +0000)]
note about distcheck b0rken

SVN revision: 43570

14 years agofix build after vtorri broke it! :)
Carsten Haitzler [Mon, 9 Nov 2009 10:21:38 +0000 (10:21 +0000)]
fix build after vtorri broke it! :)

SVN revision: 43569

14 years agoAdd __MACH__ and __APPLE__ guards to compile on macosx
Raoul HECKY [Mon, 9 Nov 2009 09:07:10 +0000 (09:07 +0000)]
Add __MACH__ and __APPLE__ guards to compile on macosx

SVN revision: 43568

14 years ago * fix order of libraries during link (fix windows compilation)
Vincent Torri [Mon, 9 Nov 2009 05:41:41 +0000 (05:41 +0000)]
 * fix order of libraries during link (fix windows compilation)
 * paths based on $prefix are not set at configure time. The correct
   way is to use them in Makefile.am.
 * $themesdir and $sysconfdir does not seem to be used

SVN revision: 43567

14 years agodon't free stack variable
Vincent Torri [Mon, 9 Nov 2009 05:27:35 +0000 (05:27 +0000)]
don't free stack variable

SVN revision: 43566

14 years agofix compilation on windows OS
Vincent Torri [Sun, 8 Nov 2009 23:37:20 +0000 (23:37 +0000)]
fix compilation on windows OS

SVN revision: 43562

14 years ago * ecore_exe_win32: manage ADD and DEL events. It works more or
Vincent Torri [Sun, 8 Nov 2009 22:19:30 +0000 (22:19 +0000)]
 * ecore_exe_win32: manage ADD and DEL events. It works more or
   less, but that Windows stuff is a bit like voodoo magic
 * Ecore.h : we can use the Ecore_Exe events on Windows, now (at
   least ADD and DEL, but the others will follow)

SVN revision: 43549

14 years agofix compilation when no pthread is available
Vincent Torri [Sun, 8 Nov 2009 22:16:17 +0000 (22:16 +0000)]
fix compilation when no pthread is available

Cedric: returning false in ecore_thread_cancel is good ?

SVN revision: 43548

14 years agoFixes for the Win32 port:
Vincent Torri [Sun, 8 Nov 2009 22:14:48 +0000 (22:14 +0000)]
Fixes for the Win32 port:

 * if ecore_events are in the queue, timeout 0 is passed and
   MsgWaitForMultipleObjects returns immediately, which can
   lead to problems. If timeout is 0, we do nothing (that is,
   we wait for the ecore_events to finish first)
 * manage the case when MsgWaitForMultipleObjects returns WAIT_FAILED

SVN revision: 43547

14 years agoRemove use of deprecated event
Sebastian Dransfeld [Sun, 8 Nov 2009 20:27:12 +0000 (20:27 +0000)]
Remove use of deprecated event

XINE_EVENT_MRL_REFERENCE is deprecated, listen for
XINE_EVENT_MRL_REFERENCE_EXT.

SVN revision: 43540

14 years agoRemove unused variable
Sebastian Dransfeld [Sun, 8 Nov 2009 20:27:02 +0000 (20:27 +0000)]
Remove unused variable

SVN revision: 43539

14 years agoRemove unused variables
Sebastian Dransfeld [Sun, 8 Nov 2009 20:26:51 +0000 (20:26 +0000)]
Remove unused variables

SVN revision: 43538

14 years agoUncomment label along with goto
Sebastian Dransfeld [Sun, 8 Nov 2009 20:26:36 +0000 (20:26 +0000)]
Uncomment label along with goto

SVN revision: 43537

14 years agoFix compiler warnings
Sebastian Dransfeld [Sun, 8 Nov 2009 19:52:44 +0000 (19:52 +0000)]
Fix compiler warnings

SVN revision: 43536

14 years agofunction defined as void, don't return a value
Sebastian Dransfeld [Sun, 8 Nov 2009 19:52:31 +0000 (19:52 +0000)]
function defined as void, don't return a value

SVN revision: 43535

14 years agofix compilation on OpenBSD
Vincent Torri [Sat, 7 Nov 2009 19:44:39 +0000 (19:44 +0000)]
fix compilation on OpenBSD

SVN revision: 43516

14 years agofix compilation on BSD systems
Vincent Torri [Sat, 7 Nov 2009 19:10:08 +0000 (19:10 +0000)]
fix compilation on BSD systems

SVN revision: 43515

14 years agofix evas compilation when async preload is disabled
Vincent Torri [Sat, 7 Nov 2009 18:19:44 +0000 (18:19 +0000)]
fix evas compilation when async preload is disabled

SVN revision: 43514

14 years agofix compilation of eina_amalgamation.c on Windows
Vincent Torri [Sat, 7 Nov 2009 16:09:58 +0000 (16:09 +0000)]
fix compilation of eina_amalgamation.c on Windows

SVN revision: 43513

14 years agouse static buffer
Vincent Torri [Sat, 7 Nov 2009 07:09:06 +0000 (07:09 +0000)]
use static buffer

SVN revision: 43510

14 years agostrdupa does not exist on BSD. Use simply strdup
Vincent Torri [Sat, 7 Nov 2009 05:58:01 +0000 (05:58 +0000)]
strdupa does not exist on BSD. Use simply strdup

SVN revision: 43509

14 years agoorget to commit configure.ac
Vincent Torri [Sat, 7 Nov 2009 05:23:47 +0000 (05:23 +0000)]
orget to commit configure.ac

SVN revision: 43507

14 years agosmart children of mapped objs etc. work work!
Carsten Haitzler [Sat, 7 Nov 2009 05:01:43 +0000 (05:01 +0000)]
smart children of mapped objs etc. work work!

SVN revision: 43506

14 years agoMake ethumb match case-insensitive.
Rafael Antognolli [Fri, 6 Nov 2009 22:17:55 +0000 (22:17 +0000)]
Make ethumb match case-insensitive.

Ethumb wasn't matching files to plugins if the extension were not
composed of all lowercase chars. This patch makes the ethumb match
case-insensitive.

Patch by: João Paulo Rechi Vita

SVN revision: 43502

14 years ago * ecore_thread: Add possibility to cancel Ecore_Thread.
Cedric BAIL [Fri, 6 Nov 2009 22:15:04 +0000 (22:15 +0000)]
* ecore_thread: Add possibility to cancel Ecore_Thread.

WARNING: THIS BREAK API AND ABI !!!

SVN revision: 43501

14 years agofix comment
Vincent Torri [Fri, 6 Nov 2009 18:31:53 +0000 (18:31 +0000)]
fix comment

SVN revision: 43496

14 years agofix DLL creation on Windows
Vincent Torri [Fri, 6 Nov 2009 18:27:56 +0000 (18:27 +0000)]
fix DLL creation on Windows

SVN revision: 43495

14 years agouseless includes
Vincent Torri [Fri, 6 Nov 2009 18:12:37 +0000 (18:12 +0000)]
useless includes

SVN revision: 43493

14 years agofix comment
Vincent Torri [Fri, 6 Nov 2009 18:11:55 +0000 (18:11 +0000)]
fix comment

SVN revision: 43492

14 years ago * evas: Add convertion function for 8bpp grayscale no pal (256 and 16 values).
Cedric BAIL [Fri, 6 Nov 2009 15:15:37 +0000 (15:15 +0000)]
* evas: Add convertion function for 8bpp grayscale no pal (256 and 16 values).

SVN revision: 43491

14 years ago2 more!
Carsten Haitzler [Fri, 6 Nov 2009 15:15:12 +0000 (15:15 +0000)]
2 more!

SVN revision: 43490

14 years agoremove 2 more types
Carsten Haitzler [Fri, 6 Nov 2009 15:14:34 +0000 (15:14 +0000)]
remove 2 more types

SVN revision: 43489

14 years agofix - remove typedefs of gl stuff. not needed.
Carsten Haitzler [Fri, 6 Nov 2009 15:13:29 +0000 (15:13 +0000)]
fix - remove typedefs of gl stuff. not needed.

SVN revision: 43488

14 years agobetter text perf - less geometry data for complex text drawing.
Carsten Haitzler [Fri, 6 Nov 2009 11:32:23 +0000 (11:32 +0000)]
better text perf - less geometry data for complex text drawing.
simpler yuv with matrix.

SVN revision: 43487

14 years agooops - infinite loopies
Carsten Haitzler [Fri, 6 Nov 2009 10:30:24 +0000 (10:30 +0000)]
oops - infinite loopies

SVN revision: 43486

14 years agoreturn somethnig
Carsten Haitzler [Fri, 6 Nov 2009 10:26:54 +0000 (10:26 +0000)]
return somethnig

SVN revision: 43485

14 years agofix smart map redraw errors.
Carsten Haitzler [Fri, 6 Nov 2009 08:44:49 +0000 (08:44 +0000)]
fix smart map redraw errors.

SVN revision: 43483