Cedric BAIL [Wed, 24 Jul 2019 22:48:30 +0000 (15:48 -0700)]
elementary: use data:null to remove unecessary structure declaration.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D9389
Mike Blumenkrantz [Thu, 25 Jul 2019 18:46:34 +0000 (14:46 -0400)]
elm_test/plug: fix error handling
Summary:
if plug connection fails, a notification can't always be created because
there may be no object passed to this function to create a notify object on
@fix
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl_widgets
Differential Revision: https://phab.enlightenment.org/D9400
Mike Blumenkrantz [Thu, 25 Jul 2019 18:46:12 +0000 (14:46 -0400)]
elm/glview: fix glview to (again) return null if context creation fails
Summary:
engine internals have changed, so it's necessary to actually check whether
the glview api is available now to determine whether the glview is viable
@fix
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl_widgets
Differential Revision: https://phab.enlightenment.org/D9397
Mike Blumenkrantz [Thu, 25 Jul 2019 18:45:48 +0000 (14:45 -0400)]
efl_ui/timepicker: fix range clamping on 12 hour timepickers
Summary: this errors all the time otherwise
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: devilhorns, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9396
Marcel Hollerbach [Fri, 12 Jul 2019 18:04:06 +0000 (20:04 +0200)]
efl_ui_spotlight_manager_*: cleanup canvas state on invalidate
this is needed so we can support a empty object which is not freed.
Sounds useless, but required by bindings, this fixes the issue described
in D9300.
Differential Revision: https://phab.enlightenment.org/D9306
Marcel Hollerbach [Fri, 12 Jul 2019 17:33:31 +0000 (19:33 +0200)]
efl_ui_spotlight_container: mirror the behavior of view_manager
setting the parent here is usefull, as we can forgot about this object
then, and do not have to free the object by hand.
Differential Revision: https://phab.enlightenment.org/D9305
Marcel Hollerbach [Fri, 12 Jul 2019 16:39:07 +0000 (18:39 +0200)]
efl_ui_spotlight_container: fix ownership behavior of view_manager
view_manager is a property that takes ownership of the view_manager
object. We are setting the parent in the setter which means, we should
actaully have one ref to the parent, and one from the caller, so we need
to unref one.
Differential Revision: https://phab.enlightenment.org/D9304
SangHyeon Jade Lee [Mon, 22 Jul 2019 11:12:30 +0000 (11:12 +0000)]
efl_ui : apply item part visible signal properly.
efl_layout_signal is being overrided by efl_ui_layout,
so do not call the signal emit on resize object directly,
call the signal emit on the item widget.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D9233
Marcel Hollerbach [Thu, 25 Jul 2019 17:35:15 +0000 (19:35 +0200)]
rename Item_Container -> Collection
this is the last bit of renaming
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D9410
Marcel Hollerbach [Thu, 25 Jul 2019 17:24:58 +0000 (19:24 +0200)]
efl_ui_spec_suite: simplify this
when i initially added item_container to the spec test suite, there was
no plan to make Efl.Ui.List / Efl.Ui.Grid like it is now. However, now
we can simply use Efl.Ui.List and Grid instead of this helper class.
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D9409
Marcel Hollerbach [Wed, 24 Jul 2019 15:57:01 +0000 (17:57 +0200)]
rename efl_ui_item_container -> efl_ui_collection
this is the first rename of the main widget, the renames of the test
suites will follow
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D9408
Marcel Hollerbach [Wed, 24 Jul 2019 14:36:17 +0000 (16:36 +0200)]
efl_ui_grid_item: remove this
this is not needed anymore, the grid items can also just inherit
directly from the items.
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D9395
Marcel Hollerbach [Wed, 24 Jul 2019 13:59:24 +0000 (15:59 +0200)]
efl_ui_list_item: remove this
this has nothing usefull in it. Additionally, future commits will brings
up another design where there is a central default item style, which can
be hinted.
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D9394
Marcel Hollerbach [Wed, 24 Jul 2019 18:49:38 +0000 (20:49 +0200)]
efl_ui_item_container: speed up item lookup
the problem with accessor is that the normal eina accessor is only for
immutable lists, by the time you change the list, the accessor has a
problem and might crash. This would mean we have to recreate the
accessors after every change to the internal list representation, which
would invalidate the cache all the time.
The usage of grid and list here is also very performant in cache using,
all the usages normally iterate forward or backward, which makes this
cache really helpfull.
With this commit the lookup of sizes is improved a lot, because
eina_list_nth is not used anymore. (Cuts of ~90ms in creation time)
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D9387
Mike Blumenkrantz [Thu, 25 Jul 2019 17:35:41 +0000 (13:35 -0400)]
tests/ecore: verify that quit() -> begin() does not pre-cancel main loop
Summary: ref
17f433c57bfa11319a22fde1aedb21e99a3a1268
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9375
Xavi Artigas [Thu, 25 Jul 2019 15:30:44 +0000 (17:30 +0200)]
mono-docs: Clearer docs for ConstructingHandle
Only *slightly* clearer.
Xavi Artigas [Thu, 25 Jul 2019 14:38:52 +0000 (16:38 +0200)]
mono-docs: More tweaks to the docs blacklist
SubhransuSekhar Mohanty [Thu, 25 Jul 2019 06:17:05 +0000 (15:17 +0900)]
efl_canvas_vg svg: free the svg tree returned by eet_data_read()
The eet_data_read() api creates the structure by referencing the wwt data structure
and reading from eet file. So the structure should be deleted by the user of the function.
As eet_data_read() api documentation dosen't specify about the ownership I guess
we need to free this structure to avoid memory leak.
Shinwoo Kim [Thu, 25 Jul 2019 06:02:02 +0000 (15:02 +0900)]
evas image: apply filter at runtime
Summary:
If you call efl_gfx_filter_program_set in a mouse event callback,
it does not work. Because render_pre removes area uisng evas_render_update_del.
Reviewers: Hermet, jpeg, jsuya, cedric
Reviewed By: Hermet, cedric
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9301
Marcel Hollerbach [Wed, 24 Jul 2019 20:06:07 +0000 (22:06 +0200)]
efl_ui_grid/list: fix build
wrong header file + wrong class define. That was forgotten to be pushed
with the commits before, sorry.
Cedric BAIL [Wed, 24 Jul 2019 18:51:54 +0000 (11:51 -0700)]
elementary: make Efl.Ui.Position_Manager a namespace.
This does the following rename as per T8058:
Efl.Ui.Item_Position_Manager -> Efl.Ui.Position_Manager.Entity
Efl.Ui.Grid_Position_Manager -> Efl.Ui.Position_Manager.Grid
Efl.Ui.List_Position_Manager -> Efl.Ui.Position_Manager.List
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D9388
Marcel Hollerbach [Wed, 24 Jul 2019 13:06:09 +0000 (15:06 +0200)]
efl_ui_list: make it work with item_container
This also refactors the example a little bit.
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D9385
Marcel Hollerbach [Wed, 24 Jul 2019 12:43:45 +0000 (14:43 +0200)]
efl_ui_grid: make it work with item_container
this also reformats the example, removes
comments that are misleading, removes UI elements that have no purpose.
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D9384
Carsten Haitzler (Rasterman) [Wed, 24 Jul 2019 18:26:09 +0000 (19:26 +0100)]
warnings remove in efl thread/exe examples
Marcel Hollerbach [Sat, 29 Jun 2019 14:19:08 +0000 (16:19 +0200)]
Introduce Efl.Ui.Item_Container
this is a new widget which aims to replace Efl.Ui.Grid / Efl.Ui.List.
The widget is split up in a widget and a interface for item placement.
Efl_Ui_Item_Position_Manager: The interface contains API which is used
by the Item_Container to place the items, there is also a set of common
tests which tests for the casual tripping wires, and ensures that the
events are emitted in the correct moments (the later part still can be
improved)
Efl_Ui_Item_Container: The widget itself, it contains the API for the
enduser to add Items to the widget, it handles the different modes for
selection type and emits the events for selection changes. The pack API
is conform with the spec unit test. An additional set of tests is
defined which should be able to be run on every widget with a specific
position_manager beeing set.
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D9285
Carsten Haitzler (Rasterman) [Wed, 24 Jul 2019 16:52:31 +0000 (17:52 +0100)]
build - cmake files - remove old seemingly unused cmake files
Carsten Haitzler (Rasterman) [Wed, 24 Jul 2019 16:51:27 +0000 (17:51 +0100)]
examples - add efl_thread and efl_exe to them
Hermet Park [Wed, 24 Jul 2019 12:29:28 +0000 (21:29 +0900)]
Revert "elm/scrollable: avoid unnecessary edje recalcs"
This reverts commit
4279f75f0b0ba7a259badf2c33356201bf7869ba.
This totally breaks popup control in Tizen,
Need to consider necessity of this patch,
further potential side effects possibilities.
Hermet Park [Wed, 24 Jul 2019 12:28:49 +0000 (21:28 +0900)]
Revert "Revert "efl/scroll manager: stop clearing animators on every wheel event""
This reverts commit
a836c73ef61f5557746c5e4d944b01a77bc3a8de.
Sorry, I mistook the picking of commit id...
Xavi Artigas [Wed, 24 Jul 2019 12:14:13 +0000 (14:14 +0200)]
mono-docs: Filter out some more unwanted constructors
These should not be used by users, so take them out of the DocFX docs.
Hermet Park [Wed, 24 Jul 2019 11:47:20 +0000 (20:47 +0900)]
Revert "efl/scroll manager: stop clearing animators on every wheel event"
This reverts commit
e6393393ccafe59d4e434a78c79952601d93956a.
This totally break popup control in Tizen,
Please consider necessity of this patch,
further potential side effects possibilities.
Hermet Park [Wed, 24 Jul 2019 05:28:00 +0000 (14:28 +0900)]
textpath: + null handling.
Xavi Artigas [Tue, 23 Jul 2019 18:58:42 +0000 (20:58 +0200)]
mono-docs: Indicate when methods and properties are BETA
Summary:
Previous commit added a <remarks> section to BETA classes.
Methods (and properties) cannot have <remarks> section so a bit
of bold text is added instead to their summary.
Depends on D9380
Test Plan: Generate docs and observe beta methods and properties have a note regarding their betaness in the summary.
Reviewers: lauromoura, vitor.sousa
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9382
Xavi Artigas [Tue, 23 Jul 2019 10:45:17 +0000 (12:45 +0200)]
mono-docs: Allow HTML codes in documentation
Summary:
All comments from EO files are HTML-escaped (i.e. "<" is turned into "<"), and this is good.
However all text added by the mono code generator is HTML-escaped too, and that is a pity.
Circumventing the escaping in the generator involves serious code changes so it is simpler to
allow "escaping" characters to avoid escaping...
"<" is turned into "<"
but
"\<" is turned into "<"
If you are giving these strings from C, remember that the backslash needs to be escaped too!
For example: "\\<b\\>Hello\\</b\\>"
This is intended for use in the generators, NOT in the EO docs.
Test Plan: Everything works as before, but now HTML codes can be added from the generators.
Reviewers: lauromoura, vitor.sousa, felipealmeida
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9380
Xavi Artigas [Tue, 23 Jul 2019 14:38:04 +0000 (16:38 +0200)]
mono-docs: Indicate when a class is BETA
Summary:
The mono generator adds a <remarks> section to all BETA classes with an explanatory text.
These tags are understood by DocFX and Monodevelop.
On top of this, this commit modifies the DocFX template to give the Remarks section a more
prominent place in the page.
Test Plan: Render docs, Beta classes should have a big blue box with a remark about the class being Beta and dangerous.
Reviewers: lauromoura, vitor.sousa
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9381
Marcel Hollerbach [Mon, 22 Jul 2019 09:38:00 +0000 (11:38 +0200)]
eolian: start to express ownership transfere
before @owned was not even expressed in the api definitions of the
generated APIs, this adds support for it.
@owned is now expressed with EFL_TRANSFER_OWNERSHIP in a arguments. And
that preprocessor directive is documented.
Reviewed-by: Daniel Kolesa <daniel@octaforge.org>
Differential Revision: https://phab.enlightenment.org/D9369
Vitor Sousa [Tue, 23 Jul 2019 12:09:23 +0000 (14:09 +0200)]
eolian_mono: parse `binbuf` and `event` keywords, also re-enable binbuf tests
Summary:
Parse `binbuf` and `event` type names and generate the proper binding type.
In
288f645e3cdb tests for `Eina.Binbuf` were disabled in order to avoid the
usage of deprecated notations in eolian.
Since the new `binbuf` keyword works as a substitute for the old notation
`ptr(Eina.Binbuf)`, tests were updated and re-enabled using the new notation.
Test Plan: `meson test`
Reviewers: felipealmeida, lauromoura, q66
Reviewed By: q66
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9349
Subodh Kumar [Tue, 23 Jul 2019 07:37:09 +0000 (09:37 +0200)]
[elm] Add missing sizing eval hook at check
Summary:
check is not shown in our Tizen demo.
sizing eval missing.
@fix
Test Plan: NA
Reviewers: zmike, Hermet, cedric, bu5hm4n
Subscribers: bu5hm4n, #reviewers, #committers
Tags: #efl
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D9378
Radoslaw Cybulski [Mon, 29 Jul 2019 12:40:18 +0000 (14:40 +0200)]
atspi: get_at_point and neighbor navigation unified
Get at point navigation used different object hierarchy, then neighbor
navigation, which could produced inconsistent results. This patch unifies
object hierarchy used by both methods.
@tizen_only
Change-Id: Ic598c053771134d8814d59968475e54cd95f2910
Radoslaw Cybulski [Tue, 9 Jul 2019 14:33:27 +0000 (16:33 +0200)]
atspi: add pause / resume reading functionality
@tizen_only
Change-Id: I00dd618dcbed153eb4cf7783f3da5ba6d6b8c0af
Radoslaw Cybulski [Wed, 3 Jul 2019 12:14:16 +0000 (14:14 +0200)]
atspi: add paused / resumed speaking notification handling
@tizen_only
Change-Id: I5110fffc7dc965cca0ca675aa1b30772bc98dd07
Radoslaw Cybulski [Wed, 3 Jul 2019 07:08:52 +0000 (09:08 +0200)]
atspi: fixed invalid do action condition, added check to highlight grab
Do gesture had invalid _is_object_permitted check, fixed.
Highlight grab is now governed by call to accept_object, thus limiting
objects, that might be highlighted to those, that might be tapped.
@tizen_only
Change-Id: I7ed979bba6178ad266daf9c93f681ec925936978
Hermet Park [Tue, 30 Jul 2019 08:04:22 +0000 (17:04 +0900)]
Revert "meson: Enable dlog logging system only if dlog library available"
This reverts commit
12969299a1870b0a07f9a5c483551e9bc09b55d5.
Change-Id: I05ac0272de06bf89dff9399302d4a26548205d5c
Hermet Park [Tue, 30 Jul 2019 08:04:05 +0000 (17:04 +0900)]
Revert "meson: remove unnecessary depenadancy"
This reverts commit
8a718e1b13521734d0329d442dc65f2e3ef5d16f.
Change-Id: I65c4cfe695049c2f9c270a1ebb3fe1565a61c661
Hermet Park [Tue, 30 Jul 2019 08:03:50 +0000 (17:03 +0900)]
Revert "meson: move tizen configuration from meson_options to efl.spec"
This reverts commit
b2e77cf9955f0c1a96eab566a01249124cfde720.
Change-Id: Ie123dd91799f35a1ce6f974575159635ae9098df
Hermet Park [Tue, 30 Jul 2019 08:03:32 +0000 (17:03 +0900)]
Revert "meson: move all tizen specific dependancy to 'tizen' option"
This reverts commit
f8fe674efbf578262fdd7f3befa4f396531cbb77.
Change-Id: I5d2492b722f203b3f08120ca85275e90550cb9d2
Hermet Park [Tue, 30 Jul 2019 08:03:19 +0000 (17:03 +0900)]
Revert "Backported missing svg loader from upstream"
This reverts commit
d5619bcf6707e1fe737505afb5a38da70ca420a0.
Change-Id: I79113e506fa2b368f0d85692a2d619ec76516b6c
Hermet Park [Tue, 30 Jul 2019 08:03:04 +0000 (17:03 +0900)]
Revert "remove unnecessary dependancy from elementary module to keep it same as upstream."
This reverts commit
55fb93d46bfc8e1c8e672404d2e6c702c7c2a28b.
Change-Id: I020afa40e39b1033588f4ad0eae1bfd70021fcc1
Hermet Park [Tue, 30 Jul 2019 08:02:52 +0000 (17:02 +0900)]
Revert "move tizen specific structure to its own header"
This reverts commit
f2efb7fc0d2b8d9242d1a74663d53a0fc58d362b.
Change-Id: I57e63d5d16bf66faf87f7f107475c9efbc44b348
Hermet Park [Tue, 30 Jul 2019 08:01:36 +0000 (17:01 +0900)]
Revert "fix build break when wayland2 is not enabled"
This reverts commit
cd7d98ce738e075996d4d0845e59fe03ce0d9ab2.
Change-Id: Id5bde3262cca6d344010a9e3fea4eb43010c9da9
Hermet Park [Tue, 30 Jul 2019 08:01:14 +0000 (17:01 +0900)]
Revert "ecore_wl2_input: do not generate duplicated mouse in events"
This reverts commit
29998e606393c7f4852320e3ce3e48f252f5020c.
Change-Id: I7e076fc1023d68b5c8593dd210f96915dbf50b3f
Hosang Kim [Tue, 30 Jul 2019 06:42:42 +0000 (15:42 +0900)]
efl_ui_win: fix condition of using precreated window
First window has parent now, so fix condition of checking parent.
@tizen
Change-Id: I7a15db139c51c46c17a0c66f6be39022c5af5acc
Woochanlee [Tue, 30 Jul 2019 06:37:49 +0000 (15:37 +0900)]
config: Changed the order in which the _elm_recache() called
@tizen_fix
Change-Id: Ia6aa50a99fefbff63cd7e2f1322395fba470acfb
jeon [Mon, 29 Jul 2019 05:34:15 +0000 (14:34 +0900)]
ecore_wl2_input: do not generate duplicated mouse in events
- touch down call _pointer_cb_enter()
- So touch down generate mouse in events twice when a mouse is connected
- if mouse is connected, the server generate and send pointer_enter / leave events
when touched window is changed.
Change-Id: I57c64188d62f02382c54ade8b4582664d3b666ee
subhransu mohanty [Wed, 24 Jul 2019 10:37:09 +0000 (19:37 +0900)]
fix build break when wayland2 is not enabled
the structure was defined inside LEMENTARY_WL2 macro
move it outside.
Change-Id: I9de4e185ed1d562d9aa94e8257eaf3e618d39b49
subhransu mohanty [Wed, 24 Jul 2019 09:37:35 +0000 (18:37 +0900)]
move tizen specific structure to its own header
don't polute the common header and then put work around to fixit.
just create a new header and use it instead.
Change-Id: I651fac5d3f5dbf13a5d8d5b76ab177d9e55d6bb4
subhransu mohanty [Wed, 24 Jul 2019 07:52:25 +0000 (16:52 +0900)]
remove unnecessary dependancy from elementary module to keep it same as upstream.
Change-Id: I9ad0d8f5b872fee4e8a1b252cb0563e2ab8a2222
subhransu mohanty [Wed, 24 Jul 2019 06:45:49 +0000 (15:45 +0900)]
Backported missing svg loader from upstream
Change-Id: Ie1aff1cc8a597d3ad20502aa914de153e339fab3
subhransu mohanty [Wed, 24 Jul 2019 06:06:35 +0000 (15:06 +0900)]
meson: move all tizen specific dependancy to 'tizen' option
Change-Id: I3dd32b5aebb89a7276cf6f58d93bc9b77238bd4b
subhransu mohanty [Wed, 24 Jul 2019 04:35:25 +0000 (13:35 +0900)]
meson: move tizen configuration from meson_options to efl.spec
instead of poluting the meson_options.txt file we can move the tizen
related configuration to the spec file and configure while invoking meson.
Change-Id: I9b05bb1c552d1f1cc2508bd83e7f125d49d1b592
subhransu mohanty [Wed, 24 Jul 2019 03:51:49 +0000 (12:51 +0900)]
meson: remove unnecessary depenadancy
I hope this is a copy paste error not actual dependancy.
It build but no idea if it will fail at runtime :)
Change-Id: I863110a5be61dbcd92dcc3e3ded1ff1e0d52c66c
subhransu mohanty [Wed, 24 Jul 2019 03:50:33 +0000 (12:50 +0900)]
meson: Enable dlog logging system only if dlog library available
Change-Id: I76b5125489c3bef004ffc7bba3342c485c1a03b6
Hermet Park [Fri, 26 Jul 2019 07:49:45 +0000 (16:49 +0900)]
ecore_evas: prevent double free evas.
When user manually free the ecore evas,
it could delete evas internally,
then evas_invalidate would be triggered,
invalidate callback would try free evas again,
this causes double free evas.
TEST SCENARIO:
ee = ecore_evas_new(...);
...
ecore_evas_free(ee);
-> free evas
-> invalidated cb
-> free evas (**double free)
This is a regression bug by
5847886a3fdb7c470bd55e215b822bbbaf109080
Change-Id: I954f605e69c2c92270c4e0c17f8d2198cedac3b5
Hermet Park [Fri, 26 Jul 2019 06:33:30 +0000 (15:33 +0900)]
efl_ui_animation_view: + null check.
The transit handle could be danglinged,
User could stop the animation in "play,start" callback.
Change-Id: I5279fbf5271248e80a123645a77a646c1c0cbc82
SubhransuSekhar Mohanty [Thu, 25 Jul 2019 06:17:05 +0000 (15:17 +0900)]
efl_canvas_vg svg: free the svg tree returned by eet_data_read()
The eet_data_read() api creates the structure by referencing the wwt data structure
and reading from eet file. So the structure should be deleted by the user of the function.
As eet_data_read() api documentation dosen't specify about the ownership I guess
we need to free this structure to avoid memory leak.
Change-Id: I0a9341d046d2a2b46cb920cfbe3e6588259f5cea
Hermet Park [Wed, 24 Jul 2019 12:29:28 +0000 (21:29 +0900)]
Revert "elm/scrollable: avoid unnecessary edje recalcs"
This reverts commit
4279f75f0b0ba7a259badf2c33356201bf7869ba.
This totally breaks popup control in Tizen,
Need to consider necessity of this patch,
further potential side effects possibilities.
Change-Id: Ic6752023e2b10e81c57b604f8990cfaae125fa56
Hermet Park [Wed, 24 Jul 2019 05:28:00 +0000 (14:28 +0900)]
textpath: + null handling.
Change-Id: I8963a33752fca6e2d045783cac2ed5231276e43d
Jongmin Lee [Mon, 22 Jul 2019 23:27:21 +0000 (08:27 +0900)]
spec: remove unused files
Spec example files were worked only for autotools.
Since, EFL now use meson instead of autotools, they are not valid anymore.
Change-Id: Ide710fdb93f22fdd5d00f98cc0ef06ebf67bec51
SangHyeon Jade Lee [Tue, 23 Jul 2019 05:21:24 +0000 (14:21 +0900)]
evas : resolve conflict on upstream merge
Change-Id: I3dbb6cffedb054182beda333419313a0d00eff70
Signed-off-by: SangHyeon Jade Lee <sh10233.lee@samsung.com>
Mike Blumenkrantz [Mon, 22 Jul 2019 13:57:39 +0000 (15:57 +0200)]
efl_ui/scroll_manager: mimic feel of legacy scroller
Summary:
previously this used a hard linear scroll with a fixed animation time for
mouse wheel events, resulting in an unnatural scroll feel due to abrupt
animation termination
using the decelerate interpolator improves this, and we should be using the
config to determine animation speed
Depends on D9347
Reviewers: bu5hm4n, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9354
Carsten Haitzler (Rasterman) [Mon, 22 Jul 2019 14:10:40 +0000 (15:10 +0100)]
Revert "efl_ui_layout: set needs_size_calc flag at constructor"
This reverts commit
98b19244329725c76ba601ea66ad5161841a68b9.
This totally broke elm widget min size calcs, e dialogs... sizing is
totally broken and unusable as a result. this is a major break and
needs immediate reverting back to a working state. Sorry Woki. You
need to test this... elementary_Test out of the box is totally broken
as all hell not to mention a lot more.
Christopher Michael [Mon, 22 Jul 2019 14:05:27 +0000 (10:05 -0400)]
Revert "tests/ecore_wl2: Reduce calls to ecore_wl2_display_connect"
Reverting this as it causes tests to stall (essentially 'meson test
ecore_wl2-suite' just hangs) when run inside a compositor.
This reverts commit
a526285db4dd281148a8d4ffd347bbc2dec881e3.
Christopher Michael [Mon, 22 Jul 2019 13:48:19 +0000 (09:48 -0400)]
tests/ecore_wl2: Reduce calls to ecore_wl2_display_connect
In order to reduce display setup time during test execution, we can
just connect once and run all the window tests after that.
ref T8016
Christopher Michael [Mon, 22 Jul 2019 13:34:30 +0000 (09:34 -0400)]
tests/ecore_wl2: Combine tests of ecore_wl2_window_surface functions
ref T8016
Christopher Michael [Mon, 22 Jul 2019 13:34:03 +0000 (09:34 -0400)]
tests/ecore_wl2: Add wayland protocol as a dep for ecore_wl2 tests
ref T8016
Subodh Kumar [Mon, 22 Jul 2019 13:09:00 +0000 (09:09 -0400)]
[elm] Add missing sizing eval hook at radio
Summary:
radio is not shown in our Tizen demo.
sizing eval missing.
@fix
Reviewers: Hermet, bu5hm4n, cedric, zmike
Reviewed By: zmike
Subscribers: akanad, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9356
Wonki Kim [Mon, 22 Jul 2019 13:08:55 +0000 (09:08 -0400)]
efl_ui_layout: set needs_size_calc flag at constructor
Summary:
even if there is a min definition on theme for some object,
the objects don't have the min size if we do nothing after creating it.
elm_layout_sizing_eval will return with doing nothing while executing contructor
so that _sizing_eval in _layout_group_calculate will never be invoked without calling hint_set, text_set, content_set, etc.
this patch modifies a initial state of needs_size_calc flag
so that object will doing _sizing_eval after executing constructor.
Test Plan:
1. remove lines that call apis such as content_set, hint_set, text_set
in radio test on elementary_test
2. observe that radios don't have min size
Reviewers: bu5hm4n, Hermet, zmike
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9368
Christopher Michael [Mon, 22 Jul 2019 13:02:10 +0000 (09:02 -0400)]
tests/ecore_wl2: Add test for ecore_wl2_window_display_get
ref T8016
Christopher Michael [Mon, 22 Jul 2019 13:00:17 +0000 (09:00 -0400)]
tests/ecore_wl2: Add test for ecore_wl2_window_aux_hints_supported_get
ref T8016
Christopher Michael [Mon, 22 Jul 2019 12:57:33 +0000 (08:57 -0400)]
tests/ecore_wl2: Add test for ecore_wl2_window_output_find
ref T8016
Christopher Michael [Mon, 22 Jul 2019 12:55:04 +0000 (08:55 -0400)]
tests/ecore_wl2: Add test for ecore_wl2_window_rotation_get
ref T8016
Christopher Michael [Mon, 22 Jul 2019 12:40:34 +0000 (08:40 -0400)]
tests/ecore_wl2: Add test case for ecore_wl2_window_surface_id_get
ref T8016
Christopher Michael [Mon, 22 Jul 2019 12:37:08 +0000 (08:37 -0400)]
tests/ecore_wl2: Add test for ecore_wl2_window_surface_get function
ref T8016
Christopher Michael [Mon, 22 Jul 2019 12:34:11 +0000 (08:34 -0400)]
tests/ecore_wl2: Remove use of macros for display setup & connect
ref T8016
Marcel Hollerbach [Mon, 22 Jul 2019 08:43:12 +0000 (10:43 +0200)]
efl_ui_widget: fix warning
Mike Blumenkrantz [Tue, 16 Jul 2019 17:40:15 +0000 (13:40 -0400)]
efl_ui_widget: add safety checks to verify parents aren't being added as children
somehow it was never checked to see if a parent was being added as a subobject
of a parent's own child object (recursive hierarchy)
@fix
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D9333
Cedric BAIL [Mon, 22 Jul 2019 08:27:10 +0000 (10:27 +0200)]
ecore_evas_convert: add the ability to split large jpeg file.
Summary:
After trying convert to split very large image and running out of
memory, this few line of code did seems like the best solution. Maybe
there is some benefit to try to make Ecore_Evas_Convert more useful.
Reviewers: zmike, raster, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9337
Hermet Park [Mon, 22 Jul 2019 08:31:06 +0000 (17:31 +0900)]
efl_canvas_vg image: changed image parameter type.
it's still in improvement stage in beta.
Hermet Park [Mon, 22 Jul 2019 08:14:10 +0000 (17:14 +0900)]
ecore_evas buffer: fix a deadlock issue.
We encountered a deadlock case in ecore_evas_image_object in ecore_evas_buffer
that only happens if the ecore_evas_buffer has nothing changed to render,
though it's triggered to rendering.
See this normal scenario that is working fine as our intention.
being ecore_evas_render()
...
-> ecore_evas_buffer_prepare()
-> evas_object_image_data_get()
-> increment lock by backend engine. (egl/tbm ...)
-> render()
-> render_post()
-> _ecore_evas_buffer_update_image()
-> evas_object_image_data_set()
->decrement lock by backend engine (egl/tbm ...)
...
end ecore_evas_render()
The problem is, if the ecore_evas_buffer canvas doesn't changed at all,
render post will be skipped, it could lose the chance to unlock the image data.
Now the host can't render anymore since it's image source lost the lock.
@fix
Hermet Park [Mon, 22 Jul 2019 08:01:45 +0000 (17:01 +0900)]
efl_ui_textpath: deprecate elm_textpath_circle_set()
Summary:
this api can be replaced with elm_textpath_circular_set()
Depends on {D9260}
Reviewers: #committers, kimcinoo
Reviewed By: #committers, kimcinoo
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9314
Hermet Park [Mon, 22 Jul 2019 07:47:43 +0000 (16:47 +0900)]
efl_ui_textpath: introduce efl_ui_textpath_circular_set() interface.
Summary:
This patch revises efl_ui_textpath_circle_set() interface.
Current circle_set() behavior is wrongly working,
it makes object minimal size with (x * 2, y * 2).
Insanely, how big size if the object is far from the screen origin.
Secondly, current interface requires center position,
How this center position could be guranteed if user wants to put it into a container?
Third, actual textpath output could be out of the textpath boundary,
since the textpath is originated to middle of text height.
the display boundary can be outside of the textpath geometry by (half of text height).
All in all, put altogether in fix,
I confirmed there is no methods without any compatibility break.
This brings elm_textpath_circular_set() api introduced.
@feature
Reviewers: #committers, kimcinoo, jsuya
Subscribers: zmike, bu5hm4n, segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9260
JunsuChoi [Mon, 22 Jul 2019 04:54:25 +0000 (13:54 +0900)]
evas_vg_json: Add image embedded example
Summary:
add example code and json resource.
plus)
Add ECTOR_BACKEND="default" Environment variable
because cairo backend is not supported.
Depends on
D9218 Ector.Renderer : Implement Ector.Renderer.(Software).Image class
D9219 Efl.Canvas.Vg : Implement Efl.Canvas.Vg.Image class
D9220 vg_common_json : Support image data of node
Test Plan:
cd .src/examples/evas/
gcc -o evas_vg_json evas-vg-json.c `pkg-config --libs --cflags evas ecore ecore-evas eina ector eo efl`
./evas_vg_json
Reviewers: Hermet, kimcinoo, smohanty
Subscribers: bu5hm4n, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9351
JunsuChoi [Mon, 22 Jul 2019 04:53:21 +0000 (13:53 +0900)]
vg_common_json : Support image data of node
Summary:
When node has image data, it creates Efl.Canvas.Vg.Image class
and set transform information and data information.
Depends on
D9218 Ector.Renderer : Implement Ector.Renderer.(Software).Image class
D9219 Efl.Canvas.Vg : Implement Efl.Canvas.Vg.Image class
Test Plan: N/A
Reviewers: Hermet, smohanty, kimcinoo
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9220
JunsuChoi [Mon, 22 Jul 2019 04:37:47 +0000 (13:37 +0900)]
Efl.Canvas.Vg : Implement Efl.Canvas.Vg.Image class
Summary:
Implements a vector class that can support image.
User can use this class to output an image with a vector object.
Depends on D9218:Ector.Renderer : Implement Ector.Renderer.(Software).Image class
Test Plan: N/A
Reviewers: Hermet, smohanty, kimcinoo
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9219
JunsuChoi [Mon, 22 Jul 2019 04:29:02 +0000 (13:29 +0900)]
Ector.Renderer : Implement Ector.Renderer.(Software).Image class
Summary:
Implement a class and drawer that outputs image data from the Ector.
Image data is output with a vector object and supports transform.
Test Plan: N/A
Reviewers: Hermet, smohanty, kimcinoo
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9218
Carsten Haitzler (Rasterman) [Sun, 21 Jul 2019 23:36:07 +0000 (00:36 +0100)]
ecore wl2 - fall back to shm if dmabuf fails in buf init
so even if shm was an allowed mode/flag, we never fell back to shm if
dmabufs were not possible (/dev/dri/renderD128 didn't exist or wansn't
open-able). that's decidedly a bad thing to do.
@fix
Carsten Haitzler (Rasterman) [Sat, 20 Jul 2019 10:52:52 +0000 (11:52 +0100)]
ecore - efl thread - remove mroe error case cnp code and share it
more cnp code de-duplication
Carsten Haitzler (Rasterman) [Sat, 20 Jul 2019 10:48:30 +0000 (11:48 +0100)]
ecore - efl thread - move duplicate code into shared func to reduce cnp
more copy & paste code - put into shared func.
Carsten Haitzler (Rasterman) [Sat, 20 Jul 2019 10:46:07 +0000 (11:46 +0100)]
ecore - efl thread - remove more copy & paste in fd in clearing handling
move to common shared function to reduce c&p
Carsten Haitzler (Rasterman) [Sat, 20 Jul 2019 10:44:05 +0000 (11:44 +0100)]
ecore - efl thread - reduce copy & paste and merge into single func
the call and call sync stuff was almost entirely copy & paste - this
moves all the common code into shared funcs that reduce code bloat. it
also moved from heap to stack for sync reply struct location.