brianosman [Fri, 22 Jul 2016 18:04:53 +0000 (11:04 -0700)]
Bundle SkShader::asFragmentProcessor arguments in a struct
The signature of this thing keeps changing (and is about to change again).
This just makes maintenance much easier.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2175563003
Review-Url: https://codereview.chromium.org/
2175563003
caryclark [Fri, 22 Jul 2016 17:56:26 +0000 (10:56 -0700)]
limit number of searched roots
Extreme numbers can generate more than
three found cubic roots when the roots
are found through a binary search.
Fail in this case.
TBR=reed@google.com
BUG=630649
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2176733002
Review-Url: https://codereview.chromium.org/
2176733002
jvanverth [Fri, 22 Jul 2016 17:34:52 +0000 (10:34 -0700)]
Recycle small uniform buffers.
BUG=skia:5031
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2159333002
Review-Url: https://codereview.chromium.org/
2159333002
brianosman [Fri, 22 Jul 2016 17:33:07 +0000 (10:33 -0700)]
Connect dst color space in a few places (removing TODOs)
There is one more XFORMTODO left, but it requires more plumbing.
With this change, certain drawing paths do gamut conversion with
no special hacking required.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2174843002
Review-Url: https://codereview.chromium.org/
2174843002
mtklein [Fri, 22 Jul 2016 17:20:52 +0000 (10:20 -0700)]
Revert of Add SkRasterPipeline blitter. (patchset #18 id:340001 of https://codereview.chromium.org/
2146413002/ )
Reason for revert:
Leaking the blitter
https://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-ASAN/builds/7908/steps/test_skia%20on%20Ubuntu/logs/stdio
Original issue's description:
> Add SkRasterPipeline blitter.
>
> This is now pixel-exact with the existing sRGB SW impl as far as I've tested.
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2146413002
> CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
>
> Committed: https://skia.googlesource.com/skia/+/
3011e337693a9786f62d8de9ac4b239ad6dbdaca
TBR=reed@google.com,mtklein@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review-Url: https://codereview.chromium.org/
2178523002
vjiaoblack [Fri, 22 Jul 2016 17:04:15 +0000 (10:04 -0700)]
Creating framework for drawShadowedPicture
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2146073003
Committed: https://skia.googlesource.com/skia/+/
0ae097d116f4332be02a135ffc99c162473dee6a
Committed: https://skia.googlesource.com/skia/+/
95302da19d8b0a3bcd9d9be0e79f486760787f09
Review-Url: https://codereview.chromium.org/
2146073003
csmartdalton [Fri, 22 Jul 2016 15:59:08 +0000 (08:59 -0700)]
Allow GrReducedClip to take non-integer query bounds
Fixes places where AA bloat was being conflated with geometric
boundaries and updates GrReducedClip to work with non-integer query
bounds. This allows for better clip reduction with AA shared edges.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2160093002
Review-Url: https://codereview.chromium.org/
2160093002
mtklein [Fri, 22 Jul 2016 15:53:26 +0000 (08:53 -0700)]
Add SkRasterPipeline blitter.
This is now pixel-exact with the existing sRGB SW impl as far as I've tested.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2146413002
CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
Review-Url: https://codereview.chromium.org/
2146413002
csmartdalton [Fri, 22 Jul 2016 15:39:06 +0000 (08:39 -0700)]
Fix SkClipStack bug with inverse-filled difference elements
Previously, SkClipStack would call "setEmpty" on itself when an
inverse-filled difference element made the stack empty. This was
a problem because setEmpty would forget the element had an inverse
fill, yet leave the op as "difference". This change modifies it to
manually update the clip bounds and set the gen-ID to kEmptyGenID,
rather than calling setEmpty.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2175493002
Review-Url: https://codereview.chromium.org/
2175493002
mtklein [Fri, 22 Jul 2016 15:35:27 +0000 (08:35 -0700)]
Don't ask GLX for EGL procs.
Seems to fix my woes.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2168293003
Review-Url: https://codereview.chromium.org/
2168293003
borenet [Fri, 22 Jul 2016 15:31:07 +0000 (08:31 -0700)]
Change SKPs to new asset management format
BUG=skia:5427
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2169653003
DOCS_PREVIEW= https://skia.org/?cl=
2169653003
Review-Url: https://codereview.chromium.org/
2169653003
mtklein [Fri, 22 Jul 2016 14:35:08 +0000 (07:35 -0700)]
Fix SW sRGB dst + LCD coverage bug.
We're using the linear procs for sRGB destintations
and the sRGB procs for linear destinations. Fix that.
C.f. State32::getLCDProc(), which flags |= kDstIsSRGB_LCDFlag.
kDistIsSRGB is (1<<2) == 4, so the sRGB procs must be 4-7, not 0-3.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2177493002
Review-Url: https://codereview.chromium.org/
2177493002
brianosman [Fri, 22 Jul 2016 14:22:04 +0000 (07:22 -0700)]
Update SkImage_NewFromTexture test, to just test release
procs of SkImage::MakeFromTexture.
Previous code included an old pattern, and may be
responsible for intermittent Mac bot failure
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2168933002
Review-Url: https://codereview.chromium.org/
2168933002
bsalomon [Fri, 22 Jul 2016 14:10:19 +0000 (07:10 -0700)]
Revert of Retract PipelineBuilder some more (patchset #9 id:160001 of https://codereview.chromium.org/
2092893003/ )
Reason for revert:
skbug.com/5559
Original issue's description:
> Retract PipelineBuilder some more
>
> The main part of this CL is widening SkDrawContext::drawBatch's API to accept the userStencilSettings & drawFace
>
> There is some ancillary spookiness related to expanding the should_apply_coverage_aa & mustUseHWAA methods to encompass mixedSamples
>
> Calved off:
> https://codereview.chromium.org/
2165283002/ (Remove DrawFace enum from GrPipelineBuilder)
> https://codereview.chromium.org/
2167183002/ (Minor change to Ganesh path renderers)
>
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2092893003
>
> Committed: https://skia.googlesource.com/skia/+/
2895eeb11a9f0d9c0018d49dd4bc45f6c6fc062c
TBR=robertphillips@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review-Url: https://codereview.chromium.org/
2175573004
brianosman [Fri, 22 Jul 2016 13:26:11 +0000 (06:26 -0700)]
Cleanup of code that converts from GPU-backed resources to SkImageInfo
Functions like GrMakeInfoFromTexture encouraged incorrect code to be
written. Similarly, the ability to construct an info from any GrSurface
was never going to be correct. Luckily, the only client of that had all
of the correct parameters much higher on the stack (and dictated or
replaced most of the properties of the returned info anyway).
With this, I can finally remove the color space as an output of the
pixel config -> color type conversion, which was never going to be
correct.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2173513002
Review-Url: https://codereview.chromium.org/
2173513002
msarett [Fri, 22 Jul 2016 13:23:00 +0000 (06:23 -0700)]
Add clamp to sk_linear_to_srgb, reorder instructions
Improves performance for xforms toSRGB and to2Dot2. Seems
more optimal to save clamping until the end. That way we
don't stall the mul pipeline with a min/max.
toSRGB: 371us -> 346us
to2Dot2: 404us -> 387us
FWIW, it probably makes sense to clamp inside
sk_linear_to_srgb anyway. If not, we should potentially
provide two versions (one that clamps and one that
doesn't).
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2173803002
CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
Review-Url: https://codereview.chromium.org/
2173803002
benjaminwagner [Fri, 22 Jul 2016 13:19:21 +0000 (06:19 -0700)]
Add SK_SUPPORT_LEGACY_ACCESSBITMAP to public.bzl.
BUG=skia:
TBR=robertphillips
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2165633008
Review-Url: https://codereview.chromium.org/
2165633008
jcgregorio [Fri, 22 Jul 2016 12:40:58 +0000 (05:40 -0700)]
Revert of Redo Tiling (patchset #14 id:260001 of https://codereview.chromium.org/
2134893002/ )
Reason for revert:
Crashing on Win with:
Caught exception
3221225477 EXCEPTION_ACCESS_VIOLATION, was running:
unit test GrShape
srgb gm shadertext2
srgb gm shallow_gradient_conical
srgb gm shallow_gradient_sweep
srgb gm shallow_gradient_linear_nodither
step returned non-zero exit code: -
1073741819
https://status.skia.org/?commit_label=author&filter=search&search_value=Test-Win-MSVC-GCE-CPU-AVX2-x86-Release
Original issue's description:
> In the current code, tiling and bilerp sampling are strongly tied together. They can be separated by taking advantage of observation that translating a sample point into filter points in the bilerp stage the filter points will be at most 0.5 outside the tile. This allows simplified repositioning for the various tiling modes; clamp and mirror use min and max while repeat has max -> 0 and 0-> max. This allows bilerp to simply treat the filter points that fall off the tile. This allows tiling and bilerp sampling to be totally separate.
>
> This CL has several parts that are intertwined:
> * move pin/wrap functionality into BilerpSampler.
> * remove the nearest neighbor and bilerp tilers
> * create a simplified general tiler
> * remove the pipeline virtual calls bilerpEdge and bilerpSpan because everything works of sample points now.
> * redo all the bilerp sampling to use the new local to methods to wrap/pin.
> * introduce a new medium rate sample that handles spans with 1 < |dx| < 2.
>
> This change improves the performance as displayed below:
> Most of top 25 desktop improves or are the same. A few are worse, but close to the noise floor. In addition, this change has about 3% smaller code.
>
> old time new time new/old
>
13274693 8414645 0.633886 top25desk_google_com_search_q_c.skp_1
> 4946466 3258018 0.658656 top25desk_wordpress.skp_1
> 6977187 5737584 0.822335 top25desk_youtube_com.skp_1
> 3770021 3296831 0.874486 top25desk_google_com__hl_en_q_b.skp_1
> 8890813 8600143 0.967307 top25desk_answers_yahoo_com.skp_1
> 3178974 3094300 0.973364 top25desk_facebook.skp_1
> 8871835 8711260 0.981901 top25desk_twitter.skp_1
> 838509 829290 0.989005 top25desk_blogger.skp_1
> 2821870 2801111 0.992644 top25desk_plus_google_com_11003.skp_1
> 511978 509530 0.995219 top25desk_techcrunch_com.skp_1
> 2408588 2397435 0.995369 top25desk_ebay_com.skp_1
> 4446919 4448004 1.00024 top25desk_espn.skp_1
> 2863241 2875696 1.00435 top25desk_google_com_calendar_.skp_1
> 7170086 7208447 1.00535 top25desk_booking_com.skp_1
> 7356109 7417776 1.00838 top25desk_pinterest.skp_1
> 5265591 5340392 1.01421 top25desk_weather_com.skp_1
> 5675244 5774144 1.01743 top25desk_sports_yahoo_com_.skp_1
> 1048531 1067663 1.01825 top25desk_games_yahoo_com.skp_1
> 2075501 2115131 1.01909 top25desk_amazon_com.skp_1
> 4262170 4370441 1.0254 top25desk_news_yahoo_com.skp_1
> 3789319 3897996 1.02868 top25desk_docs___1_open_documen.skp_1
> 919336 949979 1.03333 top25desk_wikipedia__1_tab_.skp_1
> 4274454 4489369 1.05028 top25desk_mail_google_com_mail_.skp_1
> 4149326 4376556 1.05476 top25desk_linkedin.skp_1
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2134893002
> CQ_INCLUDE_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot;master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
>
> Committed: https://skia.googlesource.com/skia/+/
8602ede5fdfa721dcad4dcb11db028c1c24265f1
TBR=mtklein@google.com,herb@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review-Url: https://codereview.chromium.org/
2174793002
bsalomon [Fri, 22 Jul 2016 11:09:47 +0000 (04:09 -0700)]
Disable CopySurface test on Nexus 10 for flakiness
BUG=skia:5509
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2169073003
Review-Url: https://codereview.chromium.org/
2169073003
mtklein [Fri, 22 Jul 2016 10:34:25 +0000 (03:34 -0700)]
GN: restore gn.py partly as fetch-gn
Same as before, except it explicitly only fetches GN instead of acting
like a proxy for it. I found myself always typing 'gn' anyway.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2167353002
Review-Url: https://codereview.chromium.org/
2167353002
caryclark [Fri, 22 Jul 2016 10:34:19 +0000 (03:34 -0700)]
conic fuzz fix
If no closest section is found in conic intersection
(which can happen if the numbers are out of range)
abort the intersection.
Also suppress assert fired in this case so it only
checks intersections with in-range values.
TBR=reed@google.com
BUG=630378
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2166813006
Review-Url: https://codereview.chromium.org/
2166813006
mtklein [Thu, 21 Jul 2016 20:54:39 +0000 (13:54 -0700)]
GN: remove hooks again
NOTRY=true
TBR=jcgregorio@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2168933004
Review-Url: https://codereview.chromium.org/
2168933004
mtklein [Thu, 21 Jul 2016 20:43:48 +0000 (13:43 -0700)]
No symlink. The bots are not running hooks anyway.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2170663003
Review-Url: https://codereview.chromium.org/
2170663003
bungeman [Thu, 21 Jul 2016 20:32:09 +0000 (13:32 -0700)]
Fix SkScalerContext_FreeType::generateFontMetrics.
SkScalerContext::generateFontMetrics implementations should not attempt
to take into account skew. This implementation should correctly handle
bitmap fonts as well.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2165323002
Review-Url: https://codereview.chromium.org/
2165323002
brianosman [Thu, 21 Jul 2016 20:28:36 +0000 (13:28 -0700)]
Add SkColorSpace to GrDrawContext
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2164363002
Review-Url: https://codereview.chromium.org/
2164363002
herb [Thu, 21 Jul 2016 20:22:04 +0000 (13:22 -0700)]
In the current code, tiling and bilerp sampling are strongly tied together. They can be separated by taking advantage of observation that translating a sample point into filter points in the bilerp stage the filter points will be at most 0.5 outside the tile. This allows simplified repositioning for the various tiling modes; clamp and mirror use min and max while repeat has max -> 0 and 0-> max. This allows bilerp to simply treat the filter points that fall off the tile. This allows tiling and bilerp sampling to be totally separate.
This CL has several parts that are intertwined:
* move pin/wrap functionality into BilerpSampler.
* remove the nearest neighbor and bilerp tilers
* create a simplified general tiler
* remove the pipeline virtual calls bilerpEdge and bilerpSpan because everything works of sample points now.
* redo all the bilerp sampling to use the new local to methods to wrap/pin.
* introduce a new medium rate sample that handles spans with 1 < |dx| < 2.
This change improves the performance as displayed below:
Most of top 25 desktop improves or are the same. A few are worse, but close to the noise floor. In addition, this change has about 3% smaller code.
old time new time new/old
13274693 8414645 0.633886 top25desk_google_com_search_q_c.skp_1
4946466 3258018 0.658656 top25desk_wordpress.skp_1
6977187 5737584 0.822335 top25desk_youtube_com.skp_1
3770021 3296831 0.874486 top25desk_google_com__hl_en_q_b.skp_1
8890813 8600143 0.967307 top25desk_answers_yahoo_com.skp_1
3178974 3094300 0.973364 top25desk_facebook.skp_1
8871835 8711260 0.981901 top25desk_twitter.skp_1
838509 829290 0.989005 top25desk_blogger.skp_1
2821870 2801111 0.992644 top25desk_plus_google_com_11003.skp_1
511978 509530 0.995219 top25desk_techcrunch_com.skp_1
2408588 2397435 0.995369 top25desk_ebay_com.skp_1
4446919 4448004 1.00024 top25desk_espn.skp_1
2863241 2875696 1.00435 top25desk_google_com_calendar_.skp_1
7170086 7208447 1.00535 top25desk_booking_com.skp_1
7356109 7417776 1.00838 top25desk_pinterest.skp_1
5265591 5340392 1.01421 top25desk_weather_com.skp_1
5675244 5774144 1.01743 top25desk_sports_yahoo_com_.skp_1
1048531 1067663 1.01825 top25desk_games_yahoo_com.skp_1
2075501 2115131 1.01909 top25desk_amazon_com.skp_1
4262170 4370441 1.0254 top25desk_news_yahoo_com.skp_1
3789319 3897996 1.02868 top25desk_docs___1_open_documen.skp_1
919336 949979 1.03333 top25desk_wikipedia__1_tab_.skp_1
4274454 4489369 1.05028 top25desk_mail_google_com_mail_.skp_1
4149326 4376556 1.05476 top25desk_linkedin.skp_1
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2134893002
CQ_INCLUDE_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot;master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
Review-Url: https://codereview.chromium.org/
2134893002
msarett [Thu, 21 Jul 2016 20:19:03 +0000 (13:19 -0700)]
Miscellaneous color space refactors
(1) Use float matrix[16] everywhere (enables future code
sharing).
(2) SkColorLookUpTable refactors
*** Store in a single allocation (like SkGammas)
*** Eliminate fOutputChannels (we always require 3,
and probably always will)
(3) Change names of read_big_endian_* helpers
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2166093003
CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
Review-Url: https://codereview.chromium.org/
2166093003
mtklein [Thu, 21 Jul 2016 20:01:08 +0000 (13:01 -0700)]
GN: add missing .exe
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2168763005
NOTRY=true
Review-Url: https://codereview.chromium.org/
2168763005
bsalomon [Thu, 21 Jul 2016 19:49:30 +0000 (12:49 -0700)]
Reenable support for CHROMIUM_set_uniform_location
BUG=skia:5015
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2167303002
Review-Url: https://codereview.chromium.org/
2167303002
caryclark [Thu, 21 Jul 2016 19:28:04 +0000 (12:28 -0700)]
let line/cubic intersect at four spots
With this, let's update the fuzzer.
R=kjlubick@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2169983002
Review-Url: https://codereview.chromium.org/
2169983002
mtklein [Thu, 21 Jul 2016 19:25:45 +0000 (12:25 -0700)]
Basic standalone GN configs.
This sketches out what a world without Chrome's GN configs would look like.
Instead of DEPSing in build/, we now host our own gypi_to_gn.py.
The symlink from skia/ to . lets us run gclient hooks when the .gclient file is in the directory above skia/ or inside skia/. That means we don't need gn.py anymore.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2167163002
Review-Url: https://codereview.chromium.org/
2167163002
dvonbeck [Thu, 21 Jul 2016 19:19:54 +0000 (12:19 -0700)]
Fixed GM:lightingshader2 size
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2171853002
Review-Url: https://codereview.chromium.org/
2171853002
robertphillips [Thu, 21 Jul 2016 19:04:08 +0000 (12:04 -0700)]
Retract PipelineBuilder some more
The main part of this CL is widening SkDrawContext::drawBatch's API to accept the userStencilSettings & drawFace
There is some ancillary spookiness related to expanding the should_apply_coverage_aa & mustUseHWAA methods to encompass mixedSamples
Calved off:
https://codereview.chromium.org/
2165283002/ (Remove DrawFace enum from GrPipelineBuilder)
https://codereview.chromium.org/
2167183002/ (Minor change to Ganesh path renderers)
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2092893003
Review-Url: https://codereview.chromium.org/
2092893003
msarett [Thu, 21 Jul 2016 19:00:24 +0000 (12:00 -0700)]
Drop support for libjpeg-turbo < 1.2 in SkJpegCodec
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2164283002
Review-Url: https://codereview.chromium.org/
2164283002
msarett [Thu, 21 Jul 2016 18:57:49 +0000 (11:57 -0700)]
Remove unnecessary getColorSpace() API from SkCodec
Not needed since now we can get it from the SkImageInfo.
TBR=reed@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2170793004
Review-Url: https://codereview.chromium.org/
2170793004
egdaniel [Thu, 21 Jul 2016 18:50:37 +0000 (11:50 -0700)]
Setup system in Vulkan to reuse VkDescriptorSet allocations.
This CL uses the new system for uniform buffers. In a follow up CL I will
add support for samplers.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2163673002
Review-Url: https://codereview.chromium.org/
2163673002
caryclark [Thu, 21 Jul 2016 17:44:07 +0000 (10:44 -0700)]
allow curves on side of lines to be very small
Increase the precision of the 'all on one side' pathops
angle test to reduce the number of unorderable segments
found by the cubics_d3 test.
This allows pathsops_unittest release build with -v -V -x
to run without error.
TBR=reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2168163002
Review-Url: https://codereview.chromium.org/
2168163002
borenet [Thu, 21 Jul 2016 17:27:00 +0000 (10:27 -0700)]
Add "skp" asset
Don't get rid of SKP_VERSION and associated stuff just yet.
BUG=skia:5427
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2167763002
DOCS_PREVIEW= https://skia.org/?cl=
2167763002
Review-Url: https://codereview.chromium.org/
2167763002
vjiaoblack [Thu, 21 Jul 2016 17:25:54 +0000 (10:25 -0700)]
Creating framework for drawShadowedPicture
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2146073003
Committed: https://skia.googlesource.com/skia/+/
0ae097d116f4332be02a135ffc99c162473dee6a
Review-Url: https://codereview.chromium.org/
2146073003
caryclark [Thu, 21 Jul 2016 16:41:13 +0000 (09:41 -0700)]
add pathops debugging to fuzz
Add optional debugging routines for use in gdb.
R=kjlubick
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2171773002
Review-Url: https://codereview.chromium.org/
2171773002
lsalzman [Thu, 21 Jul 2016 16:37:59 +0000 (09:37 -0700)]
limit the number of points in SkDashPathEffect::asPoints
If the length of a line path is sufficiently long relative to the dash
interval, it is possible to cause SkDashPathEffect::asPoints to produce
so many points that it overflows the amount that can fit in an int type,
or otherwise produce non-finite values, i.e. path from (0,0) to (0,9e15)
with a dash interval of 1.
This fixes that by capping the amount of points to a sane limit - in this
case, 1mil, since that limit is also used in utils/SkDashPath.cpp and has
precedent.
Downstream Firefox bug report: https://bugzilla.mozilla.org/show_bug.cgi?id=1287515
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2165013002
Review-Url: https://codereview.chromium.org/
2165013002
robertphillips [Thu, 21 Jul 2016 16:35:07 +0000 (09:35 -0700)]
Remove SkGrPixelRef
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2167173002
Review-Url: https://codereview.chromium.org/
2167173002
egdaniel [Thu, 21 Jul 2016 16:29:01 +0000 (09:29 -0700)]
Add vulkan compile bot to CQ
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2166353003
Review-Url: https://codereview.chromium.org/
2166353003
vjiaoblack [Thu, 21 Jul 2016 16:24:16 +0000 (09:24 -0700)]
Revert of Creating framework for drawShadowedPicture (patchset #14 id:260001 of https://codereview.chromium.org/
2146073003/ )
Reason for revert:
Decided to re-wait for a final LGTM.
Already found a bug in variable naming to fix.
Original issue's description:
> Creating framework for drawShadowedPicture
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2146073003
>
> Committed: https://skia.googlesource.com/skia/+/
0ae097d116f4332be02a135ffc99c162473dee6a
TBR=reed@google.com,robertphillips@google.com,bsalomon@google.com,jvanverth@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review-Url: https://codereview.chromium.org/
2167223002
robertphillips [Thu, 21 Jul 2016 16:21:04 +0000 (09:21 -0700)]
Remove DrawFace enum from GrPipelineBuilder
This gets GrPipelineBuilder.h out of the headers
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2165283002
Committed: https://skia.googlesource.com/skia/+/
da152ebb032c61bb2561bbb3e9a78037ad174d34
Review-Url: https://codereview.chromium.org/
2165283002
vjiaoblack [Thu, 21 Jul 2016 16:10:23 +0000 (09:10 -0700)]
Creating framework for drawShadowedPicture
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2146073003
Review-Url: https://codereview.chromium.org/
2146073003
robertphillips [Thu, 21 Jul 2016 15:55:08 +0000 (08:55 -0700)]
Minor change to Ganesh path renderers
In large part this is an attempt to get non-substantive changes out of https://codereview.chromium.org/
2092893003/ (Retract PipelineBuilder some more)
All the other parameters extracted from DrawPathArgs are passed around by reference except for the userStencilSettings
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2167183002
Review-Url: https://codereview.chromium.org/
2167183002
caryclark [Thu, 21 Jul 2016 15:53:32 +0000 (08:53 -0700)]
fix builder fuzz
Fix ASAN_heap-use-after-free crash
R=kjlubick
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2168963002
Review-Url: https://codereview.chromium.org/
2168963002
robertphillips [Thu, 21 Jul 2016 15:18:05 +0000 (08:18 -0700)]
Revert of Remove DrawFace enum from GrPipelineBuilder (patchset #2 id:20001 of https://codereview.chromium.org/
2165283002/ )
Reason for revert:
No Vulkan bot in CQ :(
Original issue's description:
> Remove DrawFace enum from GrPipelineBuilder
>
> This gets GrPipelineBuilder.h out of the headers
>
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2165283002
>
> Committed: https://skia.googlesource.com/skia/+/
da152ebb032c61bb2561bbb3e9a78037ad174d34
TBR=bsalomon@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review-Url: https://codereview.chromium.org/
2167193002
bsalomon [Thu, 21 Jul 2016 15:05:01 +0000 (08:05 -0700)]
Update build_command_buffer.py to copy libcommand_buffer_gles2.so from the correct dir on linux
Apparently the linux build now puts the library in chromium's output dir rather than a lib/ subdir.
TBR=borenet@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2165013003
Review-Url: https://codereview.chromium.org/
2165013003
robertphillips [Thu, 21 Jul 2016 14:58:41 +0000 (07:58 -0700)]
Remove DrawFace enum from GrPipelineBuilder
This gets GrPipelineBuilder.h out of the headers
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2165283002
Review-Url: https://codereview.chromium.org/
2165283002
robertphillips [Thu, 21 Jul 2016 14:17:54 +0000 (07:17 -0700)]
Deprecate SkDevice::accessBitmap method
Relies on https://codereview.chromium.org/
2162423003/ (Add SK_SUPPORT_LEGACY_ACCESSBITMAP Skia guard) landing in Chromium first.
Calved off: https://codereview.chromium.org/
2163323002/ (Add desired width & height to drawContext (as opposed to using the width & height of the RT))
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2168483003
Review-Url: https://codereview.chromium.org/
2168483003
brianosman [Thu, 21 Jul 2016 14:15:37 +0000 (07:15 -0700)]
Adding color space to SkSpecialImage
Mostly means that GPU backed special images need to be supplied (and
store) a color space object.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2163343002
Review-Url: https://codereview.chromium.org/
2163343002
msarett [Thu, 21 Jul 2016 14:11:26 +0000 (07:11 -0700)]
Refactor parsing and storage of SkGammas
Benefits:
(1) Parses and stores gamma tags in a single allocation.
(2) Recognizes equal gamma tags to skip parsing work and
save memory.
Non-Benefits:
(1) Not less complicated.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2117773002
Committed: https://skia.googlesource.com/skia/+/
2ea944c2b710caf29d4795ac953bad14224796f7
Committed: https://skia.googlesource.com/skia/+/
959ccc1f3f49e1ddeb51c32c30ac4a2d94653856
Review-Url: https://codereview.chromium.org/
2117773002
mtklein [Thu, 21 Jul 2016 13:29:01 +0000 (06:29 -0700)]
Roll buildtools for latest GN binary.
This GN binary has a JSON backend that's meant to be parsed to seed other
build configurations (e.g. CMake, Android, Google3).
You will need to re-run ./gn.py to fetch the newest binary.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2164263002
Review-Url: https://codereview.chromium.org/
2164263002
caryclark [Thu, 21 Jul 2016 12:48:43 +0000 (05:48 -0700)]
fix fuzzer bug
Fix another fuzzer bug.
Some PathOps asserts only make sense if the incoming data is
well-behaved. Well-behaved tests set debugging state to
trigger these additional asserts.
Formalize this by creating macros similar to SkASSERT that
check to see if the assert should be skipped.
TBR=reed@google.com
BUG=629962
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2169863002
Review-Url: https://codereview.chromium.org/
2169863002
msarett [Thu, 21 Jul 2016 12:38:49 +0000 (05:38 -0700)]
Trigger bots and upload images to Gold
TBR=borenet@google.com
NOTRY=true
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2163993003
Review-Url: https://codereview.chromium.org/
2163993003
jcgregorio [Thu, 21 Jul 2016 12:37:28 +0000 (05:37 -0700)]
docs: Add info on using blamer to the sheriffing docs.
BUG=skia:
R=kjlubick
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2167803002
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=
2167803002
Review-Url: https://codereview.chromium.org/
2167803002
mtklein [Thu, 21 Jul 2016 01:10:07 +0000 (18:10 -0700)]
Correct sRGB <-> linear everywhere.
This trims the SkPM4fPriv methods down to just foolproof methods.
(Anything trying to build these itself is probably wrong.)
Things like Sk4f srgb_to_linear(Sk4f) can't really exist anymore,
at least not efficiently, so this refactor is somewhat more invasive
than you might think. Generally this means things using to_4f() are
also making a misstep... that's gone too.
It also does not make sense to try to play games with linear floats
with 255 bias any more. That hack can't work with real sRGB coding.
Rather than update them, I've removed a couple of L32 xfermode fast
paths. I'd even rather drop it entirely...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2163683002
CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
Review-Url: https://codereview.chromium.org/
2163683002
msarett [Wed, 20 Jul 2016 23:14:16 +0000 (16:14 -0700)]
Revert of Refactor parsing and storage of SkGammas (patchset #8 id:280001 of https://codereview.chromium.org/
2117773002/ )
Reason for revert:
Tests failing
Original issue's description:
> Refactor parsing and storage of SkGammas
>
> Benefits:
> (1) Parses and stores gamma tags in a single allocation.
> (2) Recognizes equal gamma tags to skip parsing work and
> save memory.
>
> Non-Benefits:
> (1) Not less complicated.
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2117773002
>
> Committed: https://skia.googlesource.com/skia/+/
2ea944c2b710caf29d4795ac953bad14224796f7
> Committed: https://skia.googlesource.com/skia/+/
959ccc1f3f49e1ddeb51c32c30ac4a2d94653856
TBR=reed@google.com,brianosman@google.com,mtklein@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review-Url: https://codereview.chromium.org/
2171623002
reed [Wed, 20 Jul 2016 23:13:32 +0000 (16:13 -0700)]
Have MakeFromImage fission the SkImage into a raster or a texture (patchset #1 id:1 of https://codereview.chromium.org/
2167813002/ )"
This reverts commit
3fb87201a104c9445fca341756a153f7b147c2a5.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2164073004
TBR=robertphilips@google.com
Review-Url: https://codereview.chromium.org/
2164073004
reed [Wed, 20 Jul 2016 22:38:15 +0000 (15:38 -0700)]
Revert of have MakeFromImage fission the SkImage into a raster or a texture (patchset #1 id:1 of https://codereview.chromium.org/
2167813002/ )
Reason for revert:
broke ios build in chrome -- no_gpu?
Original issue's description:
> have MakeFromImage fission the SkImage into a raster or a texture
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2167813002
>
> Committed: https://skia.googlesource.com/skia/+/
a61bfc6292edb990eae0b948648016550ef739a9
TBR=robertphillips@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review-Url: https://codereview.chromium.org/
2168643003
msarett [Wed, 20 Jul 2016 22:10:02 +0000 (15:10 -0700)]
Refactor parsing and storage of SkGammas
Benefits:
(1) Parses and stores gamma tags in a single allocation.
(2) Recognizes equal gamma tags to skip parsing work and
save memory.
Non-Benefits:
(1) Not less complicated.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2117773002
Committed: https://skia.googlesource.com/skia/+/
2ea944c2b710caf29d4795ac953bad14224796f7
Review-Url: https://codereview.chromium.org/
2117773002
reed [Wed, 20 Jul 2016 21:22:37 +0000 (14:22 -0700)]
have MakeFromImage fission the SkImage into a raster or a texture
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2167813002
Review-Url: https://codereview.chromium.org/
2167813002
brianosman [Wed, 20 Jul 2016 20:55:39 +0000 (13:55 -0700)]
Adding an SkColorSpace to SkImage_Gpu
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2165703003
Review-Url: https://codereview.chromium.org/
2165703003
caryclark [Wed, 20 Jul 2016 20:15:51 +0000 (13:15 -0700)]
exclude unused functions when mac uses freetype (for pdf)
R=bungeman@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2163833004
Review-Url: https://codereview.chromium.org/
2163833004
msarett [Wed, 20 Jul 2016 19:58:52 +0000 (12:58 -0700)]
Revert of Refactor parsing and storage of SkGammas (patchset #7 id:220001 of https://codereview.chromium.org/
2117773002/ )
Reason for revert:
Broken bots.
Original issue's description:
> Refactor parsing and storage of SkGammas
>
> Benefits:
> (1) Parses and stores gamma tags in a single allocation.
> (2) Recognizes equal gamma tags to skip parsing work and
> save memory.
>
> Non-Benefits:
> (1) Not less complicated.
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2117773002
>
> Committed: https://skia.googlesource.com/skia/+/
2ea944c2b710caf29d4795ac953bad14224796f7
TBR=reed@google.com,brianosman@google.com,mtklein@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review-Url: https://codereview.chromium.org/
2159253005
reed [Wed, 20 Jul 2016 19:28:40 +0000 (12:28 -0700)]
remove dead methods now that we use specials exclusively for imagefilters
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2164763003
Review-Url: https://codereview.chromium.org/
2164763003
jvanverth [Wed, 20 Jul 2016 19:22:14 +0000 (12:22 -0700)]
Use dFdx in Vulkan to address distance field issues.
On Nexus Player and occasionally Nexus 5x we get transparent boxes around
paths. This appears to be because the dFdy call is not as accurate as
dFdx, which is the opposite of Mali 400. As Mali 400 is not supported with
Vulkan, we can go back to using dFdx in this case.
BUG=skia:5523
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2163213004
Review-Url: https://codereview.chromium.org/
2163213004
mtklein [Wed, 20 Jul 2016 19:10:11 +0000 (12:10 -0700)]
Tune linear->sRGB constants to round-trip all bytes.
I basically just ran a big 5-deep for-loop over the five constants here.
This is the first set of coefficients I found that round trips all bytes.
I suspect there are many such sets.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2162063003
CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
Review-Url: https://codereview.chromium.org/
2162063003
msarett [Wed, 20 Jul 2016 18:44:42 +0000 (11:44 -0700)]
Refactor parsing and storage of SkGammas
Benefits:
(1) Parses and stores gamma tags in a single allocation.
(2) Recognizes equal gamma tags to skip parsing work and
save memory.
Non-Benefits:
(1) Not less complicated.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2117773002
Review-Url: https://codereview.chromium.org/
2117773002
reed [Wed, 20 Jul 2016 18:24:51 +0000 (11:24 -0700)]
re-disable save/restore peephole optimization
BUG=skia:5548, 629408
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2163283002
Review-Url: https://codereview.chromium.org/
2163283002
dvonbeck [Wed, 20 Jul 2016 18:20:30 +0000 (11:20 -0700)]
SkLS now accepting nullptr for diffuse shader and normal source, now accurately handling alpha
This CL's base is the CL for taking in a diffuse shader into SkLS on the API side: https://codereview.chromium.org/
2064153002
BUG=skia:5502,skia:5517
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2132113002
Review-Url: https://codereview.chromium.org/
2132113002
kjlubick [Wed, 20 Jul 2016 17:18:49 +0000 (10:18 -0700)]
Add vulkan sdk to CIPD
BUG=skia:5427
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2164953002
Review-Url: https://codereview.chromium.org/
2164953002
reed [Wed, 20 Jul 2016 17:06:59 +0000 (10:06 -0700)]
re-chop if we fail on a big-bad-cubic
BUG=629455
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2159223005
Review-Url: https://codereview.chromium.org/
2159223005
bungeman [Wed, 20 Jul 2016 16:49:10 +0000 (09:49 -0700)]
Improve assert reporting.
Make SkASSERTF output readable.
Ensure the assert predicate is stringified once.
Make the abort code consistent.
TBR=reed
This doesn't change any public API, most of this should be privatized.
Review-Url: https://codereview.chromium.org/
2161103002
robertphillips [Wed, 20 Jul 2016 15:54:31 +0000 (08:54 -0700)]
Remove SkDevice::accessRenderTarget virtual
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2167723002
Review-Url: https://codereview.chromium.org/
2167723002
egdaniel [Wed, 20 Jul 2016 15:33:00 +0000 (08:33 -0700)]
Add GrVkRecycledResource subclass
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2167453003
Review-Url: https://codereview.chromium.org/
2167453003
fmenozzi [Wed, 20 Jul 2016 15:26:12 +0000 (08:26 -0700)]
Add integer array uniforms to GL and Vulkan
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2163173005
Review-Url: https://codereview.chromium.org/
2163173005
bsalomon [Wed, 20 Jul 2016 14:15:44 +0000 (07:15 -0700)]
Consolidate special case shape transformation logic in GrShapeTest.
Enable all tests on all geometry types.
Add conversion of fill+miter-stroke->fill for rect geometries in GrShape.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2157013003
Review-Url: https://codereview.chromium.org/
2157013003
bungeman [Wed, 20 Jul 2016 14:15:16 +0000 (07:15 -0700)]
Add iOS to platform_os_emoji.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2164783004
Review-Url: https://codereview.chromium.org/
2164783004
martina.kollarova [Wed, 20 Jul 2016 14:01:46 +0000 (07:01 -0700)]
Fix context creation problems in dm
Fixes these issues:
1. The glXCreateContextAttribsARB call seems to modify the
context_attrib parameter upon failure. Since context_attrib was static,
if it first tried to create an OpenGL 4.4 context and it failed, further
attempts to create a context with lower versions would also fail.
2. Getting an OpenGL 3.0 context was never tried.
3. Context creation for ES 3.0 was failing on my machine. Since ES 2.0
looks like the intended version from the surrounding code, I set it to
that. It could be rewritten to use a similar loop as standard OpenGL and
try from the highest version to the lowest.
BUG=skia:5403
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2147513002
Review-Url: https://codereview.chromium.org/
2147513002
reed [Wed, 20 Jul 2016 13:04:34 +0000 (06:04 -0700)]
use special-image for imagefilters and save/restore layer
add special virtuals to device, in preparation for using them instead of bitmap for imagefilters
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2155933002
patch from issue
2155933002 at patchset 20001 (http://crrev.com/
2155933002#ps20001)
use specialimages instead of bitmaps for imagefiltering
Review-Url: https://codereview.chromium.org/
2155063002
borenet [Wed, 20 Jul 2016 12:54:50 +0000 (05:54 -0700)]
Add "Infra" to the builder_name_schema
BUG=skia:4763
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2154433002
Review-Url: https://codereview.chromium.org/
2154433002
mtklein [Wed, 20 Jul 2016 12:23:31 +0000 (05:23 -0700)]
Fix color order for 565,4444, and I8 samplers.
10 GMs fixed on Linux/Win!
Also, don't unpremul I8 colors. It's inconsistent with the other formats.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2166623002
Review-Url: https://codereview.chromium.org/
2166623002
kjlubick [Tue, 19 Jul 2016 23:50:03 +0000 (16:50 -0700)]
Port FuzzPathop from chromium
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2148023002
Review-Url: https://codereview.chromium.org/
2148023002
reed [Tue, 19 Jul 2016 21:33:20 +0000 (14:33 -0700)]
pre-land special methods on device
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2161233002
Review-Url: https://codereview.chromium.org/
2161233002
jvanverth [Tue, 19 Jul 2016 21:17:20 +0000 (14:17 -0700)]
Stub in Mac viewer code.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2164683002
patch from issue
2164683002 at patchset 1 (http://crrev.com/
2164683002#ps1)
Review-Url: https://codereview.chromium.org/
2167503002
brianosman [Tue, 19 Jul 2016 21:16:49 +0000 (14:16 -0700)]
Remove unused MakeFromTextureCopy API
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2165803002
Review-Url: https://codereview.chromium.org/
2165803002
robertphillips [Tue, 19 Jul 2016 21:04:39 +0000 (14:04 -0700)]
Minor cleanup of GrStencilAndCoverTextContext
Split out of https://codereview.chromium.org/
2163483002/ (Use SkFont in GrStencilAndCoverTextContext)
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2165673002
Review-Url: https://codereview.chromium.org/
2165673002
mtklein [Tue, 19 Jul 2016 20:36:03 +0000 (13:36 -0700)]
Update rounding/clamping comments on sk_linear_to_srgb().
Rounding is enough. No need for an explicit clamp if the inputs are in range.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2161223002
Review-Url: https://codereview.chromium.org/
2161223002
Ben Wagner [Tue, 19 Jul 2016 19:55:16 +0000 (15:55 -0400)]
Make SkOTTable_name.cpp UTF-8.
When editing on Windows this file became iso-8859-1.
msarett [Tue, 19 Jul 2016 20:00:35 +0000 (13:00 -0700)]
Fix master-skia build
TBR=djsollen@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2159223003
Review-Url: https://codereview.chromium.org/
2159223003
mtklein [Tue, 19 Jul 2016 19:59:35 +0000 (12:59 -0700)]
Fix color order on LCD text when using sRGB software backend.
BUG=skia:5182
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2166533002
Review-Url: https://codereview.chromium.org/
2166533002
caryclark [Tue, 19 Jul 2016 19:27:32 +0000 (12:27 -0700)]
exclude test that fails on google3 asan
R=dogben@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2164703002
Review-Url: https://codereview.chromium.org/
2164703002
caryclark [Tue, 19 Jul 2016 18:29:14 +0000 (11:29 -0700)]
fix fuzzer
Previous spans always have a valid next pointer. The final span does not.
Change the test for a valid link to take into consideration whether
the links are chased forwards or backwards.
TBR=reed@google.com
BUG=629454
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2166543002
Review-Url: https://codereview.chromium.org/
2166543002
msarett [Tue, 19 Jul 2016 18:17:55 +0000 (11:17 -0700)]
Disable qcms on build for Android framework
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2160863003
Review-Url: https://codereview.chromium.org/
2160863003
msarett [Tue, 19 Jul 2016 17:48:58 +0000 (10:48 -0700)]
Enable libjpeg-turbo features
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2161843002
Review-Url: https://codereview.chromium.org/
2161843002
fmenozzi [Tue, 19 Jul 2016 17:45:57 +0000 (10:45 -0700)]
Clarify GrGradientEffect key enum
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2158323003
Review-Url: https://codereview.chromium.org/
2158323003
bsalomon [Tue, 19 Jul 2016 16:46:29 +0000 (09:46 -0700)]
Make sk_app::WindowContext directly create a SkSurface without an intermediate GrRenderTarget
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2165703002
Review-Url: https://codereview.chromium.org/
2165703002