Jan Kotas [Fri, 15 Mar 2019 01:36:41 +0000 (18:36 -0700)]
Disable failing test against #23262 (#23263)
Bruce Forstall [Thu, 14 Mar 2019 22:51:30 +0000 (15:51 -0700)]
Merge pull request #23260 from BruceForstall/AlwaysArchiveCrossgenComparisonResults
Archive crossgen comparison job results even if job fails
Jan Vorlicek [Thu, 14 Mar 2019 22:31:25 +0000 (23:31 +0100)]
Merge pull request #23180 from franksinankaya/gcc_cleanup_12
Fix conversion and signedness issues in Event Tracer
Aaron Robinson [Thu, 14 Mar 2019 22:15:56 +0000 (15:15 -0700)]
Fix the calling convention for P/Invokes and delegates to hostpolicy (#23249)
* Fix the calling convention for P/Invokes and delegates
* Update mock library to match official hostpolicy calling conventions
Jan Vorlicek [Thu, 14 Mar 2019 21:30:00 +0000 (22:30 +0100)]
Fix GetProcessAffinityMask (#23247)
The function was returning mask not expected by runtime for coreclr
built with NUMA enabled on machines with multiple NUMA nodes.
The mask was 0 in case the current process was affinitized to CPUs
from multiple NUMA nodes. It was following MSDN doc, however the
doc turned out to be ambiguous. Moreover, the runtime depended
on the fact that on Windows, a process is never run on multiple
NUMA nodes unless is explicitly calls APIs to set ideal processor
for threads. But on Unix, there is no such case and by default, a
process is affinitized to all existing processors over all NUMA
nodes.
And there was one more issue. The GetProcessAffinityMask was returning
a mask within a single CPU group, which is a transformed view of
NUMA node on Windows. So the CPU indices in the mask didn't necessarily
correspond to the native Unix CPU indices. But, the SetThreadAffinityMask
was using the native Unix CPU indices.
To fix the problem, the GetProcessAffinityMask is changed so that
it always returns a mask corresponding to the native Unix CPU indices
(reporting upto 64 processors as the mask is 64 bit wide). Thus it
corresponds to what the SetThreadAffinityMask expects. And it also exactly
matches the behavior when NUMA support is not compiled in.
Moreover, the COMPlus_GCHeapAffinitizeMask bits now correspond to
the native Unix CPU indices.
The GetProcessAffinityMask is used by GC and thread pool only when
NUMA is not enabled using the COMPlus_GCCpuGroup env variable.
dotnet-maestro[bot] [Thu, 14 Mar 2019 20:54:25 +0000 (13:54 -0700)]
[master] Update dependencies from optimization repositories (#23226)
* Update dependencies from https://dnceng@dev.azure.com/dnceng/internal/_git/dotnet-optimization build
20190314.1
This change updates the following dependencies
- optimization.IBC.CoreCLR - 99.99.99-master-
20190314.1
- optimization.PGO.CoreCLR - 99.99.99-master-
20190314.1
Koundinya Veluri [Thu, 14 Mar 2019 20:51:25 +0000 (13:51 -0700)]
Fix DisableTier0Jit when multi-core JIT is enabled (#23200)
- With multi-core JIT, a method may be jitted before it is called, in which case the call counting entry would not already exist
Sergey Andreenko [Thu, 14 Mar 2019 20:36:03 +0000 (13:36 -0700)]
Update CoreFX Linux Arm64 exclusion list. (#22697)
* Update CoreFX Linux Arm64 exclusion list.
* Exclude System.Globalization.Calendars.Tests.
* Exclude System.Threading.Tasks.Tests.
* Exclude #23242
Bruce Forstall [Thu, 14 Mar 2019 20:34:53 +0000 (13:34 -0700)]
Archive crossgen comparison job results even if job fails
dotnet-maestro[bot] [Thu, 14 Mar 2019 16:02:17 +0000 (09:02 -0700)]
Update dependencies from https://github.com/dotnet/corefx build
20190313.10 (#23255)
This change updates the following dependencies
- Microsoft.NETCore.Platforms - 3.0.0-preview4.19163.10
- Microsoft.Private.CoreFx.NETCoreApp - 4.6.0-preview4.19163.10
Jan Vorlicek [Thu, 14 Mar 2019 09:22:44 +0000 (10:22 +0100)]
Merge pull request #23203 from janvorli/fix-no-return-false-positives
Fix no-return false positives in static analyzer build
Michal Strehovský [Thu, 14 Mar 2019 08:33:59 +0000 (09:33 +0100)]
Delete suspicious code in delegate construction (#22830)
Delegate construction is trying to do some weird special casing around closed delegates to interface methods that is breaking non-virtual delegates to default interface methods. The special casing has suspicious comments indicating people didn't know why it's needed in the first place, so I'm going with a theory that it's a cargo cult (e.g. why the reasons specified in the comments don't apply to normal virtual methods?).
Fixes #22728.
Sung Yoon Whang [Thu, 14 Mar 2019 02:42:28 +0000 (19:42 -0700)]
Disable tracing/inducedgc test on all Unix platforms (#23240)
* Disabling tracing/tracevalidation/inducedgc test on all unix
* Leave the exclusion list on arm64 there
Sergey Andreenko [Thu, 14 Mar 2019 01:31:27 +0000 (18:31 -0700)]
Fix/clean compNoGCHelperCallKillSet for arm. (#23078)
* Add an assert to compNoGCHelperCallKillSet.
That registers that lose GC or byref values also are in compHelperCallKillSet return set.
* Move compNoGCHelperCallKillSet from compiler to emitter.
* Rename `compNoGCHelperCallKillSet` to `emitGetGCRegsKilledByNoGCCall`.
* Fix GCRegsKill sets for arm CORINFO_HELP_PROF_FCN_ENTER and CORINFO_HELP_PROF_FCN_LEAVE.
Sinan Kaya [Mon, 11 Mar 2019 17:58:42 +0000 (17:58 +0000)]
Choose the SString constructor explicitly
Sinan Kaya [Mon, 11 Mar 2019 18:12:01 +0000 (18:12 +0000)]
signedness conversion
Sinan Kaya [Mon, 11 Mar 2019 17:31:46 +0000 (17:31 +0000)]
fix conversion issues
Brian Sullivan [Thu, 14 Mar 2019 00:33:25 +0000 (17:33 -0700)]
Merge pull request #23109 from briansull/gh-21231
Fix for Issue 21231
dotnet-maestro[bot] [Thu, 14 Mar 2019 00:27:22 +0000 (17:27 -0700)]
Update dependencies from https://github.com/dotnet/corefx build
20190312.12 (#23227)
This change updates the following dependencies
- Microsoft.NETCore.Platforms - 3.0.0-preview4.19162.12
- Microsoft.Private.CoreFx.NETCoreApp - 4.6.0-preview4.19162.12
Levi Broderick [Wed, 13 Mar 2019 22:43:25 +0000 (15:43 -0700)]
Add OperationStatus-based UTF8 transcoding APIs (#23219)
Bruce Forstall [Wed, 13 Mar 2019 22:38:41 +0000 (15:38 -0700)]
Merge pull request #23220 from BruceForstall/FixArm64HfaJmpCallNyi
Arm64: Implement JMP call for HFA register arguments
Brian Sullivan [Thu, 7 Mar 2019 22:20:44 +0000 (14:20 -0800)]
Fix for Issue 21231
When transferring a Zero offset from one GenTree node to another, we need to check if there already is a FieldSeq and append to it.
Added third parameter 'kind' to JitHashTable::Set, and Added enum SetKind
Only allow Set to overwrite an existing entry when kind is set to Overwrite.
Added validation for all calls to JitHashTable::Set
asserting that we don't expect the key to already exist or that we passed Overwrite indicating that we expect to handle it properly.
Added two test cases for Issue 21231
Juan Hoyos [Wed, 13 Mar 2019 21:39:25 +0000 (14:39 -0700)]
Remove fixed sign tool version (#23182)
Juan Hoyos [Wed, 13 Mar 2019 21:38:41 +0000 (14:38 -0700)]
Update documentation: make docker images point to the registry. (#23243)
Carol Eidt [Wed, 13 Mar 2019 21:26:51 +0000 (14:26 -0700)]
Fix SIMD handle issues (#23193)
* Fix SIMD handle issues
PR #23052 was overly aggressive at applying the provided class handle (which defaults to NO_CLASS_HANDLE). In addition, make a small change to `SIMDIntrinsicWiden`, as it doesn't need to go through the complexity of inferring a class handle when it already exists on the node it's duplicating.
Fix #23159
Carol Eidt [Wed, 13 Mar 2019 21:19:17 +0000 (14:19 -0700)]
Merge pull request #23212 from CarolEidt/VectorABITest
Preliminary Vector ABI test
Sergey Andreenko [Wed, 13 Mar 2019 20:08:38 +0000 (13:08 -0700)]
exclude tracing/keyword/TwoKeywords/TwoKeywords on WIndows x86. (#23237)
JC Aguilera [Wed, 13 Mar 2019 19:59:46 +0000 (12:59 -0700)]
Merge pull request #23236 from jcagme/updateOptimizationUrl
Update optimization repo url
juanam [Wed, 13 Mar 2019 19:52:54 +0000 (12:52 -0700)]
Update optimization repo url
Michal Strehovsky [Wed, 13 Mar 2019 12:30:44 +0000 (05:30 -0700)]
Fix missed RelocatedType annotation
[tfs-changeset: 1735855]
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Michal Strehovský [Wed, 13 Mar 2019 18:50:13 +0000 (19:50 +0100)]
Enable FeatureDefaultInterfaces unconditionally (#23225)
Fixes #22940.
Andrew Au [Wed, 13 Mar 2019 16:56:41 +0000 (09:56 -0700)]
Fix issue 23151 (Cleanup TODO introduced by PR #23148)
Sung Yoon Whang [Wed, 13 Mar 2019 08:10:35 +0000 (01:10 -0700)]
Add new counter APIs (#23077)
* Refactor EventCounter and add PollingCounter
* Add PollingCounter
* Add IncrementingEventCounter and IncrementingPollingCounter
* Add MetaData API to Counters
* Some more refactoring
* removing commented out code
* some more cleanup
* build fix and addressing some PR comments
* Addressing PR feedback
* use StringBuilder to generate metadata string
Aaron Robinson [Wed, 13 Mar 2019 03:34:45 +0000 (20:34 -0700)]
Default Interface COM testing project (#23195)
* Add tests for native COM client consuming managed COM server that
consumes interfaces with default implementation.
dotnet-maestro[bot] [Wed, 13 Mar 2019 02:43:08 +0000 (19:43 -0700)]
Update dependencies from https://github.com/dotnet/corefx build
20190311.10 (#23205)
This change updates the following dependencies
- Microsoft.NETCore.Platforms - 3.0.0-preview4.19161.10
- Microsoft.Private.CoreFx.NETCoreApp - 4.6.0-preview4.19161.10
Bruce Forstall [Sat, 9 Mar 2019 01:58:54 +0000 (17:58 -0800)]
Arm64: Implement JMP call for HFA register arguments
Add the code to load up HFA register arguments into their correct registers
before a JMP call.
Removes remaining NYI.
Fixes #23147
Add a test case with several variants of HFA and JMP call.
Jan Vorlicek [Wed, 13 Mar 2019 00:07:00 +0000 (01:07 +0100)]
Move ANALYZER_NORETURN after function return type.
GCC doesn't like attributes before the extern keyword.
Andy Ayers [Tue, 12 Mar 2019 23:46:24 +0000 (16:46 -0700)]
Don't retain modifiers for instantation stub signatures (#23210)
`ConvToJitSig` is not expecting to see modifiers for return types in sigs,
so don't bother preserving them when creating instantiation stubs.
This comes up for instantiation stubs for methods of `ReadOnlySpan<T>`.
Also, if we are preserving modifiers in a sig, make sure to prefix their type
handles with `ELEM_TYPE_INTERNAL`.
Fixes #23136.
Tanner Gooding [Tue, 12 Mar 2019 21:29:38 +0000 (14:29 -0700)]
Fixing a couple of issues in the Utf8Parsing/Formatting code (#23134)
* Fixing NumberToSingle and NumberToDouble to handle DigitsCount == 0
* Fixing Utf8Formatter.Float to transcode non ASCII bytes
* Responding to PR feedback
Carol Eidt [Tue, 12 Mar 2019 18:28:10 +0000 (11:28 -0700)]
Preliminary Vector ABI test
John Salem [Tue, 12 Mar 2019 16:39:50 +0000 (09:39 -0700)]
Fix syntax bug: bash requires spaces around brackets for tests (#23017)
dotnet-maestro[bot] [Tue, 12 Mar 2019 05:38:22 +0000 (22:38 -0700)]
[master] Update dependencies from dotnet/core-setup (#23165)
* Update dependencies from https://github.com/dotnet/core-setup build
20190311.01
This change updates the following dependencies
- Microsoft.NETCore.App - 3.0.0-preview4-27511-01
Andrew Au [Fri, 1 Mar 2019 18:12:48 +0000 (10:12 -0800)]
Fix issue 21089 (Add tests for the `EventPipe support for "Parameters"` feature.)
Michal Strehovský [Mon, 11 Mar 2019 20:57:29 +0000 (21:57 +0100)]
Replace Delegate.CreateDelegate (dotnet/corert#7147)
Replacing this with a pattern that is easier to statically analyze. We use the GetType/GetMethod/CreateDelegate pattern in several places already.
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Carol Eidt [Mon, 11 Mar 2019 23:11:50 +0000 (16:11 -0700)]
Merge pull request #23141 from CarolEidt/Fix23059
Fix handling of struct setup assignments
dotnet-maestro[bot] [Mon, 11 Mar 2019 21:01:05 +0000 (14:01 -0700)]
[master] Update dependencies from dotnet/arcade (#23169)
* Update dependencies from https://github.com/dotnet/arcade build
20190310.1
This change updates the following dependencies
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19160.1
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19160.1
* Update dependencies from https://github.com/dotnet/arcade build
20190310.2
This change updates the following dependencies
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19160.2
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19160.2
Hugh Bellamy [Mon, 11 Mar 2019 20:59:13 +0000 (20:59 +0000)]
Fix NRE in EqualStringArrays (#23174)
dotnet-maestro[bot] [Mon, 11 Mar 2019 20:58:36 +0000 (13:58 -0700)]
[master] Update dependencies from dotnet/corefx (#23170)
* Update dependencies from https://github.com/dotnet/corefx build
20190310.5
This change updates the following dependencies
- Microsoft.NETCore.Platforms - 3.0.0-preview4.19160.5
- Microsoft.Private.CoreFx.NETCoreApp - 4.6.0-preview4.19160.5
* Update dependencies from https://github.com/dotnet/corefx build
20190310.8
This change updates the following dependencies
- Microsoft.NETCore.Platforms - 3.0.0-preview4.19160.8
- Microsoft.Private.CoreFx.NETCoreApp - 4.6.0-preview4.19160.8
Michal Strehovský [Mon, 11 Mar 2019 20:58:20 +0000 (21:58 +0100)]
Fix bad test (#23173)
The test was testing that a non-virtual call to an abstract method that is methodimpl on the same type will land in the methodimpl. This behavior is not specced and cannot be hit with any mainstream .NET languages. We are making non-virtual calls to abstract methods throw a BadImageFormatException instead.
Fixes #23096.
Bruce Forstall [Mon, 11 Mar 2019 20:36:45 +0000 (13:36 -0700)]
Merge pull request #23187 from BruceForstall/AlwaysArchiveCoreFxTestResultsXml
Always archive corefx testresults.xml files
Bruce Forstall [Mon, 11 Mar 2019 20:10:43 +0000 (13:10 -0700)]
Always archive corefx testresults.xml files
These were only being archived for successful runs, which is
when they are the least interesting. Archive them for all test runs.
Jan Vorlicek [Mon, 11 Mar 2019 16:49:05 +0000 (09:49 -0700)]
Fix no-return false positives in static analyzer build
There were about 800 false positive issues in the clang status analyzer
build caused by the fact that various forms of asserts were not considered
by the analyzer as not returning.
This change adds __attribute__((analyzer_noreturn)) (wrapped in a macro) to
those assertion functions.
Steve MacLean [Mon, 11 Mar 2019 16:26:57 +0000 (12:26 -0400)]
Add EntryPointFilter option (#23054)
* Add EntryPointFilter
Eric StJohn [Mon, 11 Mar 2019 15:53:46 +0000 (08:53 -0700)]
Add a target to get native resources from another DLL to ILProj SDK (#23117)
We use a similar target in CoreFx and I'll need it for another project that is planning on
using this SDK.
When ILResourceReference it will be disassembled to get native resources (EG: fileversion)
to pass to ILasm.
If ILResourceReference is not specified then it does nothing.
Dan Moseley [Sat, 9 Mar 2019 21:54:04 +0000 (13:54 -0800)]
Remove 2 suffix step 1 (dotnet/corefx#35904)
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Jan Vorlicek [Mon, 11 Mar 2019 15:08:50 +0000 (16:08 +0100)]
Merge pull request #23093 from franksinankaya/gcc_warnings_9
GCC Signed compare and Narrowing warnings
Jan Vorlicek [Mon, 11 Mar 2019 13:59:27 +0000 (14:59 +0100)]
Merge pull request #23111 from am11/gcc-configuration
Improve gcc configuration
Jan Vorlicek [Mon, 11 Mar 2019 12:23:25 +0000 (13:23 +0100)]
Merge pull request #23099 from janvorli/remove-pal-cleanup
Remove init_count zeroing from PAL cleanup at process exit
Jan Vorlicek [Mon, 11 Mar 2019 11:08:26 +0000 (12:08 +0100)]
Merge pull request #23121 from janvorli/enable-clang-staticanalyzer-build
Enable build with clang static analyzer
Adeel [Mon, 11 Mar 2019 09:38:32 +0000 (02:38 -0700)]
Remove conditions around CMAKE_REQUIRED_LIBRARIES
Levi Broderick [Mon, 11 Mar 2019 04:40:27 +0000 (21:40 -0700)]
Refactor Encoding to split fast-path and fallback logic (#23098)
This refactoring is limited to ASCIIEncoding at the moment, but it can easily be applied to UTF-8 / UTF-16 / UTF-32.
High-level changes:
- Fallback logic has been split from the fast-path, improving performance of GetBytes and similar routines.
- All of the plumbing of when to invoke the fallback logic and how to manage leftover data has been moved into the base class.
- Almost all of the logic except for the fast-path is now written in terms of verifiable code (Span and ReadOnlySpan).
- Minor bug fixes in EncoderNLS.Convert (see https://github.com/dotnet/coreclr/issues/23020).
dotnet-maestro[bot] [Sun, 10 Mar 2019 16:17:48 +0000 (09:17 -0700)]
Update dependencies from https://github.com/dotnet/arcade build
20190309.2 (#23163)
This change updates the following dependencies
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19159.2
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19159.2
dotnet-maestro[bot] [Sun, 10 Mar 2019 16:17:35 +0000 (09:17 -0700)]
Update dependencies from https://github.com/dotnet/corefx build
20190310.1 (#23164)
This change updates the following dependencies
- Microsoft.NETCore.Platforms - 3.0.0-preview4.19160.1
- Microsoft.Private.CoreFx.NETCoreApp - 4.6.0-preview4.19160.1
dotnet-maestro[bot] [Sun, 10 Mar 2019 12:22:47 +0000 (05:22 -0700)]
Update dependencies from https://dnceng@dev.azure.com/dnceng/internal/_git/dotnet-optimization build
20190308.5 (#23156)
This change updates the following dependencies
- optimization.IBC.CoreCLR - 99.99.99-master-
20190308.5
- optimization.PGO.CoreCLR - 99.99.99-master-
20190308.5
dotnet-maestro[bot] [Sun, 10 Mar 2019 01:03:48 +0000 (17:03 -0800)]
Update dependencies from https://github.com/dotnet/corefx build
20190308.7 (#23154)
This change updates the following dependencies
- Microsoft.NETCore.Platforms - 3.0.0-preview4.19158.7
- Microsoft.Private.CoreFx.NETCoreApp - 4.6.0-preview4.19158.7
dotnet-maestro[bot] [Sat, 9 Mar 2019 21:58:04 +0000 (13:58 -0800)]
Update dependencies from https://github.com/dotnet/core-setup build
20190308.16 (#23155)
This change updates the following dependencies
- Microsoft.NETCore.App - 3.0.0-preview4-27508-16
Egor Bogatov [Sat, 9 Mar 2019 21:55:43 +0000 (00:55 +0300)]
Move Buffer to shared (#23157)
Andrew Au [Sat, 9 Mar 2019 00:07:39 +0000 (16:07 -0800)]
Two more instances
Andrew Au [Fri, 8 Mar 2019 23:13:58 +0000 (15:13 -0800)]
Eliminate SampleProfilerEventInstance
Andrew Au [Sat, 9 Mar 2019 00:00:36 +0000 (16:00 -0800)]
Avoid StackWalk in EventPipeEventInstance constructor
Stephen Toub [Sat, 9 Mar 2019 16:41:43 +0000 (11:41 -0500)]
Add stack depth check to all Task continuations (#23152)
Currently Task has a stack depth check that avoids stack overflows on very deep stack continuation chains, but it only applies to Task.ContinueWith, not to other kinds of continuations. This changes that to have it apply to all.
As part of this, this also deletes the current StackGuard type used to achieve the check. The type was meant to avoid expensive calls to check where we are on the stack, but now that we're using TryEnsureSufficientExecutionStack, it's actually faster to just call that rather than access the current StackGuard from a ThreadLocal. This then also cleans up the call sites nicely, as they no longer need finally blocks to undo the increment performed on the StackGuard.
dotnet-maestro[bot] [Sat, 9 Mar 2019 06:54:38 +0000 (22:54 -0800)]
Update dependencies from https://github.com/dotnet/arcade build
20190308.5 (#23146)
This change updates the following dependencies
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19158.5
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19158.5
Marek Safar [Sat, 9 Mar 2019 05:32:53 +0000 (06:32 +0100)]
Move part of RuntimeHelpers to shared partition (#23130)
* Move part of RuntimeHelpers to shared partition
* Remove FormatterServices.cs
Aaron Robinson [Sat, 9 Mar 2019 01:36:37 +0000 (17:36 -0800)]
Properly override IsEquivalentTo() API in RuntimeType (#23137)
* Properly override IsEquivalentTo() API in RuntimeType
* Add tests for API validation
Sung Yoon Whang [Fri, 8 Mar 2019 22:54:38 +0000 (14:54 -0800)]
Update eventcounter spec (#23142)
Bruce Forstall [Fri, 8 Mar 2019 22:45:11 +0000 (14:45 -0800)]
Merge pull request #23140 from BruceForstall/RemoveArm64NYI
Remove unneeded arm64 NYI
Jarret Shook [Fri, 8 Mar 2019 22:43:53 +0000 (14:43 -0800)]
Use 4 core external build queues (#23079)
Sergey Andreenko [Fri, 8 Mar 2019 22:24:17 +0000 (14:24 -0800)]
Fix missing RunTests.sh in CoreFX Linux jobs. (#23135)
Carol Eidt [Fri, 8 Mar 2019 21:09:41 +0000 (13:09 -0800)]
Fix handling of struct setup assignments
In #22791 I was creating struct assignments with COMMAs on the rhs, but that isn't handled downstream.
Fix #23059
Bruce Forstall [Fri, 8 Mar 2019 20:43:54 +0000 (12:43 -0800)]
Remove unneeded arm64 NYI
InitVarDscInfo::alignReg is only used by `_TARGET_ARM_`, so put
it under that ifdef.
Contributes to #18178
Bruce Forstall [Fri, 8 Mar 2019 20:25:21 +0000 (12:25 -0800)]
Merge pull request #23086 from BruceForstall/Arm64ChangeIntFloatSaveOrder
Arm64: always save int registers at higher addresses than float regs
Andrew Hoefling [Thu, 7 Mar 2019 23:08:22 +0000 (18:08 -0500)]
Optimized RemoveItemsRange to call the list.RemoveRange if the items is of type List<T>
Andrew Hoefling [Thu, 7 Mar 2019 00:34:57 +0000 (19:34 -0500)]
Simplified the RemoveItem logic since we have more robust validation
Andrew Hoefling [Wed, 6 Mar 2019 17:57:09 +0000 (12:57 -0500)]
InsertItemsRange API now checks if the underlying items.IsReadOnly first then collection == null
Andrew Hoefling [Wed, 6 Mar 2019 17:47:03 +0000 (12:47 -0500)]
Removed (Int64) cast statements from RemoveItemsRange when checking for overflow errors
Andrew Hoefling [Wed, 6 Mar 2019 01:31:19 +0000 (20:31 -0500)]
Added new RemoveRange validation check to see if the resulting range (index + count) > items.Count and if it is true throw ArgumentException
Andrew Hoefling [Wed, 6 Mar 2019 00:00:01 +0000 (19:00 -0500)]
Updated InsertItemsRange to simplify the expression and added performance improvements. If the underlying `items` is using List<T> we should use it's InsertRange method since it is optimized, othersie we use InsertItem
Andrew Hoefling [Tue, 5 Mar 2019 23:46:05 +0000 (18:46 -0500)]
Updated RemoveAt->RemoveItem. This change removes redundent validation checks that happen using the RemoveAt API. RemoveItem gives us direct access to invoke the command
Andrew Hoefling [Tue, 5 Mar 2019 23:15:08 +0000 (18:15 -0500)]
Updated RemoveRange invocation of RemoveAt to use index instead of i, because the array changes with each iteration of the for loop and will cause side-effects which may include index out of range exceptions. This needs to be index because as the array shrinks the index is always at the correct position.
Andrew Hoefling [Tue, 5 Mar 2019 23:14:01 +0000 (18:14 -0500)]
Added ArgumentOutOfRangeException exception in RemoveRange if the count is less than 0
Andrew Hoefling [Tue, 5 Mar 2019 05:26:08 +0000 (00:26 -0500)]
Updated RemoveItemsRange to properly remove each item and not just the index items
Andrew Hoefling [Tue, 5 Mar 2019 04:50:36 +0000 (23:50 -0500)]
Updated RemoveItemsRange to prevent int.MaxValue overflow errors
Andrew Hoefling [Tue, 5 Mar 2019 04:44:19 +0000 (23:44 -0500)]
Remove ternary operator from invocation as it is the same as inputing items.Count
Andrew Hoefling [Tue, 5 Mar 2019 03:28:05 +0000 (22:28 -0500)]
Added ReplaceItemsRange API and updated ReplaceRange to invoke the protected method
Andrew Hoefling [Tue, 5 Mar 2019 02:54:41 +0000 (21:54 -0500)]
Adding braces on for loop
Andrew Hoefling [Tue, 5 Mar 2019 02:53:52 +0000 (21:53 -0500)]
Updated foreach to use T instead of var
Andrew Hoefling [Tue, 5 Mar 2019 02:53:26 +0000 (21:53 -0500)]
Updated index out of range exception check to be a single comparison
Andrew Hoefling [Tue, 5 Mar 2019 01:16:16 +0000 (20:16 -0500)]
Added new Range Manipulation APIs for Collection<T> which propogate up to ObservableCollection<T>. AddRange, InsertRange, RemoveRange and Replace Range
Adeel [Fri, 8 Mar 2019 19:04:43 +0000 (11:04 -0800)]
Use CLR_LINK
Filip Navara [Fri, 8 Mar 2019 18:55:25 +0000 (19:55 +0100)]
Allow deserialization for ResourceManager created with non-default resource set type (#23051)