cchen [Tue, 15 Dec 2020 19:49:52 +0000 (13:49 -0600)]
[OPENMP51] Add present modifier in defaultmap clause
Support present modifier in defaultmap by adding an extra dimension
for `ImplicitMap`. Therefore, we now create OMPMapClause in `ActOnOpenMPExecutableDirective`
based on both `maptype` and `maptype-modifier`.
Reviewed By: ABataev
Differential Revision: https://reviews.llvm.org/D92427
Nico Weber [Tue, 15 Dec 2020 18:36:15 +0000 (13:36 -0500)]
[lld/mac] Set ordinal on dynamic undefined symbols in symbol table
This lets `nm -m` print "(from libfoo)" in its output, which is more
accessible than dumping the bind table.
See https://reviews.llvm.org/D57190#2455761 for the somewhat
surprising `AltEntry` that appears in symtab.s.
Differential Revision: https://reviews.llvm.org/D93318
Philip Reames [Tue, 15 Dec 2020 19:07:30 +0000 (11:07 -0800)]
[tests] fix an accidental target dependence added in
99ac8868
Philip Reames [Tue, 15 Dec 2020 18:53:27 +0000 (10:53 -0800)]
[tests][LV] precommit tests for D93317
Nathan James [Tue, 15 Dec 2020 18:16:16 +0000 (18:16 +0000)]
[clangd] Provide suggestions with invalid config keys
Update the config file warning when an unknown key is detected which is likely a typo by suggesting the likely key.
This won't suggest a key that has already been seen in the block.
Appends the fix to the diag, however right now there is no support for presenting that fix to the user.
Reviewed By: sammccall
Differential Revision: https://reviews.llvm.org/D92990
Mircea Trofin [Tue, 15 Dec 2020 18:04:01 +0000 (10:04 -0800)]
[NFC] update extract-lowbits.ll and scalar-pf-to-i64.ll
Auto-updated with update_llc_test_checks
Marek Kurdej [Tue, 15 Dec 2020 18:03:11 +0000 (19:03 +0100)]
[libc++] Fix synopsis in string::ends_with test. NFC.
Kevin P. Neal [Tue, 15 Dec 2020 17:55:58 +0000 (12:55 -0500)]
Revert "[FPEnv] Teach the IRBuilder about invoke's correct use of the strictfp attribute."
The test is busted on some hosts that aren't the one I'm using.
This reverts commit
67a1ffd88ac08526bb6cfc7b3f607e6668ba1c70.
Tres Popp [Tue, 15 Dec 2020 17:15:52 +0000 (18:15 +0100)]
[mlir] Add std.pow lowering to LLVMIR
Differential Revision: https://reviews.llvm.org/D93311
Mircea Trofin [Tue, 15 Dec 2020 17:51:09 +0000 (09:51 -0800)]
[NFC] Update extract-bits.ll
Running update_llc_test_checks adds @PLT annotations to a number of
calls.
Tres Popp [Tue, 15 Dec 2020 17:26:11 +0000 (18:26 +0100)]
[mlir] Add std.powf to ROCDL lowering.
Differential Revision: https://reviews.llvm.org/D93313
Kirill Bobyrev [Tue, 15 Dec 2020 17:42:09 +0000 (18:42 +0100)]
Revert "[clangd] Log remote index connectivity status"
This reverts commit
dcdef5b5b3df457566e7faf61e1e5789c42528d1.
This commit breaks clangd-ubuntu-tsan builds:
http://lab.llvm.org:8011/#builders/131/builds/1392
Tres Popp [Tue, 15 Dec 2020 17:40:48 +0000 (18:40 +0100)]
[mlir] Fix GPUToNVVM test
Kevin P. Neal [Tue, 15 Dec 2020 17:35:46 +0000 (12:35 -0500)]
[FPEnv] Teach the IRBuilder about invoke's correct use of the strictfp attribute.
Similar to D69312, and documented in D69839, the IRBuilder needs to add
the strictfp attribute to invoke instructions when constrained floating
point is enabled.
Differential Revision: https://reviews.llvm.org/D93134
Simon Pilgrim [Tue, 15 Dec 2020 17:35:19 +0000 (17:35 +0000)]
[X86] Regenerate avxvnni.ll tests - remove unused prefix. NFCI.
Kirill Bobyrev [Tue, 15 Dec 2020 17:29:11 +0000 (18:29 +0100)]
[clangd] Log remote index connectivity status
Reviewed By: sammccall
Differential Revision: https://reviews.llvm.org/D92198
Tres Popp [Tue, 15 Dec 2020 16:18:06 +0000 (17:18 +0100)]
[mlir] Add NVVM lowering for std.pow
Differential Revision: https://reviews.llvm.org/D93303
Simon Pilgrim [Tue, 15 Dec 2020 17:27:10 +0000 (17:27 +0000)]
[X86] Explicitly use SDValue instead of auto. NFCI.
Fix static analyzer warning about not using a SDValue&
Simon Pilgrim [Tue, 15 Dec 2020 17:15:06 +0000 (17:15 +0000)]
SeparateConstOffsetFromGEP::lowerToSingleIndexGEPs - don't use dyn_cast_or_null. NFCI.
ResultPtr is guaranteed to be non-null - and using dyn_cast_or_null causes unnecessary static analyzer warnings.
We can't say the same for FirstResult AFAICT, so keep dyn_cast_or_null for that.
Amy Huang [Tue, 15 Dec 2020 16:41:22 +0000 (08:41 -0800)]
[llvm-symbolizer] Add missing include for config.h
The cmake variable LLVM_ENABLE_DIA_SDK was being used here but
was undefined because config.h wasn't included.
Differential Revision: https://reviews.llvm.org/D93309
Fangrui Song [Tue, 15 Dec 2020 17:20:06 +0000 (09:20 -0800)]
[ELF] Error for out-of-range R_X86_64_[REX_]GOTPCRELX
Reviewed By: grimar
Differential Revision: https://reviews.llvm.org/D93259
Joe Ellis [Tue, 15 Dec 2020 16:56:43 +0000 (16:56 +0000)]
[AArch64][NEON] Remove undocumented vceqz{,q}_p16, vml{a,s}q_n_f64 intrinsics
Prior to this patch, Clang supported the following C/C++ intrinsics:
vceqz_p16
vceqzq_p16
vmlaq_n_f64
vmlsq_n_f64
... exposed through arm_neon.h. However, these intrinsics are not part
of the ACLE, allowing developers to write code that is not compatible
with other toolchains.
This patch removes these intrinsics.
There is a bug report capturing this issue here:
https://bugs.llvm.org/show_bug.cgi?id=47471
Reviewed By: bsmith
Differential Revision: https://reviews.llvm.org/D93206
Raul Tambre [Tue, 15 Dec 2020 06:41:22 +0000 (08:41 +0200)]
[PGO] Allow overriding -vp-counters-per-site
In some build configurations more than 1.5 might be required.
Paramaterize so it can be changed by the user.
Reviewed By: yamauchi
Differential Revision: https://reviews.llvm.org/D93281
Simon Pilgrim [Tue, 15 Dec 2020 13:36:22 +0000 (13:36 +0000)]
[X86] Remove unnecessary SUBV_BROADCAST combines. NFCI.
Noticed while dealing with D92645 - these are now handled by getFauxShuffleMask + shuffle combining code.
Louis Dionne [Tue, 15 Dec 2020 16:45:53 +0000 (11:45 -0500)]
[libc++] Fix allocate_shared when used with an explicitly convertible allocator
When the allocator is only explicitly convertible from other specializations
of itself, the new version of std::allocate_shared would not work because
it would try to do an implicit conversion. This patch fixes the problem
and adds a test so that we don't fall into the same trap in the future.
Mircea Trofin [Tue, 15 Dec 2020 16:40:01 +0000 (08:40 -0800)]
[utils] The func_dict for a prefix may just be empty
Follow up from D92965 - since we try to find failed prefixes
after each RUN line, it's possible the whole list of functions for a
prefix be non-existent, which is fine - this happens when none of the
RUN lines seen so far used the prefix.
Nathan James [Tue, 15 Dec 2020 16:19:12 +0000 (16:19 +0000)]
[clang][driver][NFC] Use StringRef instead of std::string
Paul Walker [Tue, 15 Dec 2020 15:31:57 +0000 (15:31 +0000)]
[NFC] Fix a few SVEInstrInfo related stylistic issues.
Tres Popp [Thu, 10 Dec 2020 22:49:42 +0000 (23:49 +0100)]
[mlir] Add std op for X raised to the power of Y
Proposal:
https://llvm.discourse.group/t/rfc-standard-add-powop-to-std-dialect/2377
Differential Revision: https://reviews.llvm.org/D93119
David Green [Tue, 15 Dec 2020 15:58:52 +0000 (15:58 +0000)]
[ARM] Match dual lane vmovs from insert_vector_elt
MVE has a dual lane vector move instruction, capable of moving two
general purpose registers into lanes of a vector register. They look
like one of:
vmov q0[2], q0[0], r2, r0
vmov q0[3], q0[1], r3, r1
They only accept these lane indices though (and only insert into an
i32), either moving lanes 1 and 3, or 0 and 2.
This patch adds some tablegen patterns for them, selecting from vector
inserts elements. Because the insert_elements are know to be
canonicalized to ascending order there are several patterns that we need
to select. These lane indices are:
3 2 1 0 -> vmovqrr 31; vmovqrr 20
3 2 1 -> vmovqrr 31; vmov 2
3 1 -> vmovqrr 31
2 1 0 -> vmovqrr 20; vmov 1
2 0 -> vmovqrr 20
With the top one being the most common. All other potential patterns of
lane indices will be matched by a combination of these and the
individual vmov pattern already present. This does mean that we are
selecting several machine instructions at once due to the need to
re-arrange the inserts, but in this case there is nothing else that will
attempt to match an insert_vector_elt node.
Differential Revision: https://reviews.llvm.org/D92553
Quentin Chateau [Tue, 15 Dec 2020 15:31:25 +0000 (16:31 +0100)]
[clangd] Improve goToDefinition on auto and dectype
locateSymbolAt (used in goToDeclaration) follows the
deduced type instead of failing to locate the declaration.
Reviewed By: sammccall
Differential Revision: https://reviews.llvm.org/D92977
Ulrich Weigand [Tue, 15 Dec 2020 15:18:43 +0000 (16:18 +0100)]
[SystemZ] Remove most hard-coded R1D instances for sibcalls
Indirect sibling calls need to use %r1 to hold the target address.
This is currently hard-coded in many places. This is not only
unnecessary, but makes future changes in this area difficult.
This patch now encodes the target address as operand without
hard coding a register in most places throughout the MI back-end.
Code generation still always uses %r1, but this is now decided
solely in one place in SystemZTargetLowering::LowerCall.
NFC intended.
Mircea Trofin [Fri, 11 Dec 2020 00:15:18 +0000 (16:15 -0800)]
[utils] Fix UpdateTestChecks case where 2 runs differ for last label
Two RUN lines produce outputs that, each, have some common parts and
some different parts. The common parts are checked under label A. The
differing parts are associated to a function and checked under labels B
and C, respectivelly.
When build_function_body_dictionary is called for the first RUN line, it
will attribute the function body to labels A and C. When the second RUN
is passed to build_function_body_dictionary, it sees that the function
body under A is different from what it has. If in this second RUN line,
A were at the end of the prefixes list, A's body is still kept
associated with the first run's function.
When we output the function body (i.e. add_checks), we stop after
emitting for the first prefix matching that function. So we end up with
the wrong function body (first RUN's A-association).
There is no reason to special-case the last label in the prefixes list,
and the fix is to always clear a label association if we find a RUN line
where the body is different.
Differential Revision: https://reviews.llvm.org/D93078
Raphael Isemann [Tue, 15 Dec 2020 15:13:17 +0000 (16:13 +0100)]
[lldb] Fix import-std-module tests after libc++ got a new __memory subdirectory
7ad49aec125b3c1205b164331d0aa954d773f890 added a __memory subdirectory to libc++
but the code we use to find libc++ from the debug info support files wasn't
prepared to encounter unknown subdirectories within libc++. The import-std-module
tests automatically fell back to not importing the std module which caused
them to fail.
This patch removes our hardcoded exception for the 'experimental' subdirectory
and instead just ignores all subdirectories of c++/vX/ when searching the
support files.
Florian Hahn [Tue, 15 Dec 2020 14:44:38 +0000 (14:44 +0000)]
[AnnotationRemarks] Also generate annotation remarks when using -O0.
The AnnotationRemarks pass is already run at the end of the module
pipeline. This patch also adds it before bailing out for -O0, so remarks
are also generated with -O0.
Kazushi (Jam) Marukawa [Tue, 15 Dec 2020 13:43:09 +0000 (22:43 +0900)]
[VE] Support FRAMEADDR
Implement FRAMEADDR for VE. Add a regression test also.
Reviewed By: simoll
Differential Revision: https://reviews.llvm.org/D93295
Kazushi (Jam) Marukawa [Tue, 15 Dec 2020 12:52:51 +0000 (21:52 +0900)]
[VE][NFC] Sort VEISD operations
Reviewed By: simoll
Differential Revision: https://reviews.llvm.org/D93294
Florian Hahn [Tue, 15 Dec 2020 14:02:52 +0000 (14:02 +0000)]
[VPlan] Use VPDef for VPWidenSelectRecipe.
This patch turns updates VPWidenSelectRecipe to manage the value
it defines using VPDef.
Reviewed By: gilr
Differential Revision: https://reviews.llvm.org/D90560
Sebastian Neubauer [Tue, 15 Dec 2020 09:33:50 +0000 (10:33 +0100)]
[AMDGPU] Unify flat offset logic
Move getNumFlatOffsetBits from AMDGPUAsmParser and SIInstrInfo into
AMDGPUBaseInfo.
Differential Revision: https://reviews.llvm.org/D93287
Sebastian Neubauer [Tue, 15 Dec 2020 13:46:15 +0000 (14:46 +0100)]
[AMDGPU][NFC] Add more global_atomic_cmpswap tests
Hansang Bae [Mon, 14 Dec 2020 16:54:03 +0000 (10:54 -0600)]
[OpenMP] Initialize runtime in the forked child process
This patch enables serial initialization in the forked child process
to fix unstable runtime behavior when used with Python-based AI tools.
Differential Revision: https://reviews.llvm.org/D93230
Sam McCall [Tue, 15 Dec 2020 13:17:44 +0000 (14:17 +0100)]
[clangd] Oops, fix code in #ifdef WIN32
Jun Ma [Tue, 15 Dec 2020 09:20:55 +0000 (17:20 +0800)]
[InstCombine] Remove scalable vector restriction in foldVectorBinop
Differential Revision: https://reviews.llvm.org/D93289
Sam McCall [Tue, 15 Dec 2020 13:00:03 +0000 (14:00 +0100)]
Reland [clangd] Extract per-dir CDB cache to its own threadsafe class. NFC
This reverts commit
4d956af594c5adc9d566d1846d86dd89c70c9c0b.
Assertion failures on windows fixed by
965d71c69acce658e9e3de00b25a351b00937820
Sam McCall [Tue, 15 Dec 2020 12:58:08 +0000 (13:58 +0100)]
[clangd] Avoid traversing C:\ -> C: when looking for CDBs
Boost in its infinite wisdom considers C: a parent of C:\, and we've
inherited that. This breaks the assumption that after canonicalizing a
path, the path parents are the directory's parents.
Florian Hahn [Tue, 15 Dec 2020 12:51:28 +0000 (12:51 +0000)]
[LV] Pass explicit vector width to not require a X86 target.
Chuanqi Xu [Tue, 15 Dec 2020 12:50:38 +0000 (20:50 +0800)]
[clang-format] Recognize c++ coroutine keywords as unary operator to avoid misleading pointer alignment
Summary: The clang-format may go wrong when handle c++ coroutine keywords and pointer.
The default value for PointerAlignment is PAS_Right. So the following format is good:
```
co_return *a;
```
But within some code style, the value for PointerAlignment is PAS_Left, the behavior goes wrong:
```
co_return* a;
```
test-plan: check-clang
reviewers: MyDeveloperDay
Differential Revision: https://reviews.llvm.org/D91245
Jun Ma [Mon, 14 Dec 2020 06:42:55 +0000 (14:42 +0800)]
[InstCombine][NFC] Change cast of FixedVectorType to dyn_cast.
Jun Ma [Tue, 15 Dec 2020 03:37:10 +0000 (11:37 +0800)]
[InstCombine] Remove scalable vector restriction in InstCombineCompares
Differential Revision: https://reviews.llvm.org/D93269
Jun Ma [Fri, 11 Dec 2020 03:29:47 +0000 (11:29 +0800)]
[InstCombine] Remove scalable vector restriction when fold SelectInst
Differential Revision: https://reviews.llvm.org/D93083
Hsiangkai Wang [Fri, 11 Dec 2020 08:08:10 +0000 (16:08 +0800)]
[RISCV] Define vwadd/vwaddu/vwsub/vwsubu intrinsics.
Define vwadd/vwaddu/vwsub/vwsubu intrinsics and lower to V instructions.
Authored-by: Roger Ferrer Ibanez <rofirrim@gmail.com>
Co-Authored-by: Hsiangkai Wang <kai.wang@sifive.com>
Differential Revision: https://reviews.llvm.org/D93108
Paul Walker [Sat, 24 Oct 2020 10:23:10 +0000 (11:23 +0100)]
[SVE] Move INT_TO_FP i1 promotion into custom lowering.
AddPromotedToType is being used to legalise INT_TO_FP operations
when the source is a predicate. The point where this introduces
vector extends might cause problems in the future so this patch
falls back to manual promotion within custom lowering.
Differential Revision: https://reviews.llvm.org/D90093
Paul Walker [Thu, 3 Dec 2020 12:26:29 +0000 (12:26 +0000)]
[CodeGenPrepare] Update optimizeGatherScatterInst for scalable vectors.
optimizeGatherScatterInst does nothing specific to fixed length vectors
but uses FixedVectorType to extract the number of elements. This patch
simply updates the code to use VectorType and getElementCount instead.
For testing I just copied Transforms/CodeGenPrepare/X86/gather-scatter-opt.ll
replacing `<4 x ` with `<vscale x 4`.
Differential Revision: https://reviews.llvm.org/D92572
Simon Pilgrim [Mon, 14 Dec 2020 17:54:49 +0000 (17:54 +0000)]
[X86] Remove trailing whitespace. NFC.
Simon Pilgrim [Mon, 14 Dec 2020 17:49:33 +0000 (17:49 +0000)]
[X86][AVX] LowerBUILD_VECTOR - reduce 256/512-bit build vectors with zero/undef upper elements + pad.
As discussed on D92645, we don't do a good job of recognising when we don't require the full width of a ymm/zmm build vector because the upper elements are undef/zero.
This commit allows us to make use of implicit zeroing of upper elements with AVX instructions, which we emulate in DAG with a INSERT_SUBVECTOR into the bottom of a undef/zero vector of the original type.
This exposed a limitation in getTargetConstantBitsFromNode which didn't extract bits from INSERT_SUBVECTORs of different element widths which I've included as well to prevent a couple of regressions.
Florian Hahn [Tue, 15 Dec 2020 09:39:47 +0000 (09:39 +0000)]
[LV] Add reduction test, which exposed a crash in a pending patch.
Florian Hahn [Tue, 15 Dec 2020 09:30:14 +0000 (09:30 +0000)]
[VPlan] Use VPDef for VPWidenGEPRecipe.
This patch turns updates VPWidenGEPRecipe to manage the value it defines
using VPDef. The VPValue is used during VPlan construction and
codegeneration instead of the plain IR reference where possible.
Reviewed By: gilr
Differential Revision: https://reviews.llvm.org/D90561
Florian Hahn [Tue, 15 Dec 2020 09:11:24 +0000 (09:11 +0000)]
[VPlan] Use VPdef for VPWidenCall.
This patch turns updates VPWidenREcipe to manage the value it defines
using VPDef.
Reviewed By: gilr
Differential Revision: https://reviews.llvm.org/D90559
Jan Svoboda [Tue, 15 Dec 2020 08:59:19 +0000 (09:59 +0100)]
[clang][cli] Squash multiple cc1 -fxxx-exceptions flags into single -exception-model=xxx option
This patch enables marshalling of the exception model options while enforcing their mutual exclusivity. The clang driver interface remains the same, this only affects the cc1 command line.
Depends on D93215.
Reviewed By: dexonsmith
Differential Revision: https://reviews.llvm.org/D93216
Jan Svoboda [Tue, 15 Dec 2020 08:41:11 +0000 (09:41 +0100)]
[clang][cli] Squash exception model in LangOptions into one member
This squashes multiple members in LangOptions into one. This is leveraged in a follow-up patch that implements marshalling of related command-line options.
Depends on D93214.
Reviewed By: dexonsmith
Differential Revision: https://reviews.llvm.org/D93215
Jan Svoboda [Mon, 14 Dec 2020 12:08:48 +0000 (13:08 +0100)]
[clang][cli] Create accessors for exception models in LangOptions
This abstracts away the members that are being replaced in a follow-up patch.
Depends on D83979.
Reviewed By: dexonsmith
Differential Revision: https://reviews.llvm.org/D93214
xndcn [Tue, 15 Dec 2020 08:45:56 +0000 (09:45 +0100)]
[clangd] Add hover info for `this` expr
How about add hover information for `this` expr?
It seems useful to show related information about the class for `this` expr sometimes.
Reviewed By: sammccall
Differential Revision: https://reviews.llvm.org/D92041
Kazushi (Jam) Marukawa [Sat, 12 Dec 2020 03:27:32 +0000 (12:27 +0900)]
[VE] Support atomic exchange instructions
Support atomic exchange and atomic compare and exchange instructions.
Change CAS and TS1AM instructions for ISel patterns. Add selectADDRzi
pattern for them. Add TS1AM pseudo instruction also for better ISel.
Add shouldExpandAtomicRMWInIR() function to expand all atomicrmw
instructions except atomicrmw xchg. Add custom lower for i8/i16
atomicrmw xchg. Modify replaceFI to support CAS/TS1AM instructions
which use "reg+disp" operands instead of "reg+imm+disp" operands.
And, add several regression tests to check the correctness.
Reviewed By: simoll
Differential Revision: https://reviews.llvm.org/D93161
Hsiangkai Wang [Tue, 15 Dec 2020 05:49:54 +0000 (13:49 +0800)]
[RISCV][NFC] Define scalable vectors for half types.
This is a preperation work for vfadd intrinsics.
Differential Revision: https://reviews.llvm.org/D93275
Georgii Rymar [Mon, 14 Dec 2020 15:04:45 +0000 (18:04 +0300)]
[llvm-readelf] - Don't print OS/Processor specific prefix for known ELF file types.
This is a change suggested in post commit comments for
D93096 (https://reviews.llvm.org/D93096#2451796).
Imagine we want to add a custom OS specific ELF file type.
For that we can update the `ElfObjectFileType` array:
```
static const EnumEntry<unsigned> ElfObjectFileType[] = {
...
{"Core", "CORE (Core file)", ELF::ET_CORE},
{"MyType", "MyType (my description)", 0xfe01},
};
```
The current code then might print:
```
OS Specific: (MyType (my description))
```
Though instead we probably would like to see a nicer output, e.g:
```
Type: MyType (my description)
```
To achieve that we can reorder the code slightly.
It is impossible to add a test I think, because we have no custom values in
the `ElfObjectFileType` array in LLVM.
Differential revision: https://reviews.llvm.org/D93217
Max Kazantsev [Tue, 15 Dec 2020 07:40:17 +0000 (14:40 +0700)]
[SCEV] Add missing type check into getRangeForAffineNoSelfWrappingAR
We make type widening without checking if it's needed. Bail if the max
iteration count is wider than AR's type.
Amara Emerson [Mon, 14 Dec 2020 23:25:35 +0000 (15:25 -0800)]
[GlobalISel][IRTranslator] Ensure branch probabilities are added when translating invoke edges.
This uses a straightforward port of findUnwindDestinations() from SelectionDAG.
Differential Revision: https://reviews.llvm.org/D93256
Kazu Hirata [Tue, 15 Dec 2020 07:00:17 +0000 (23:00 -0800)]
[IR] Remove isPowerOf2ByteWidth
The predicate used to be used with the C backend, which was removed on
Mar 23, 2012 in commit
64a232343aa649fdacf78698da3e4d5737dee56a. It
seems to be unused since then.
Max Kazantsev [Tue, 15 Dec 2020 06:46:09 +0000 (13:46 +0700)]
[Test] Test on assertion failure with expensive SCEV range inference
Kazu Hirata [Tue, 15 Dec 2020 06:40:13 +0000 (22:40 -0800)]
[Analysis] Use llvm::erase_value (NFC)
Raul Tambre [Tue, 15 Dec 2020 06:15:58 +0000 (08:15 +0200)]
Re-apply "[CMake][compiler-rt][AArch64] Avoid preprocessing LSE builtins separately"
aa772fc85e0f526615c78b9c3979c2be945a754c (D92530) has landed fixing relocations on Darwin.
3000c19df64f89ff319590f3a6e4d6b93d20983d (D93236) has landed working around an assembly parser bug on Darwin.
Previous quick-fix
d9697c2e6b153ac7dc40a69450d9b672f71b1029 (D93198) included in this commit.
Invoking the preprocessor ourselves is fragile and would require us to replicate CMake's handling of definitions, compiler flags, etc for proper compatibility.
In my toolchain builds this notably resulted in a bunch of warnings from unused flags as my CMAKE_C_FLAGS includes CPU-specific optimization options.
Notably this part was already duplicating the logic for VISIBILITY_HIDDEN define.
Instead, symlink the files and set the proper set of defines on each.
This should also be faster as we avoid invoking the compiler multiple times.
Fixes https://llvm.org/PR48494
Differential Revision: https://reviews.llvm.org/D93278
Raul Tambre [Tue, 15 Dec 2020 06:12:44 +0000 (08:12 +0200)]
[Compiler-rt][AArch64] Workaround for .cfi_startproc assembler parser bug.
Put .cfi_startproc on a new line to avoid hitting the assembly parser bug in MasmParser::parseDirectiveCFIStartProc().
Reviewed By: tambre
Differential Revision: https://reviews.llvm.org/D93236
Med Ismail Bennani [Tue, 15 Dec 2020 02:40:47 +0000 (03:40 +0100)]
[lldb/API] Expose Target::CreateBreakpoint(..., move_to_nearest_code) overload
This patch exposes the Target::CreateBreakpoint overload with the
boolean argument to move to the neareast code to the SBAPI.
This is useful when creating column breakpoints to restrict lldb's
resolution to the pointed source location, preventing it to go to the next
line.
rdar://
72196842
Differential Revision: https://reviews.llvm.org/D93266
Signed-off-by: Med Ismail Bennani <medismail.bennani@gmail.com>
Med Ismail Bennani [Tue, 15 Dec 2020 05:11:35 +0000 (06:11 +0100)]
Revert "[lldb/API] Expose Target::CreateBreakpoint(..., move_to_nearest_code) overload"
This reverts commit
04696ff002e7d311887b7b7e6e171340a0623dd9.
Exposing the LazyBool private type in SBTarget.h breaks some tests.
Hsiangkai Wang [Fri, 11 Dec 2020 07:16:08 +0000 (15:16 +0800)]
[RISCV] Define vadd/vsub/vrsub intrinsics and lower to V instructions.
This patch is based on the proposal from Roger Ferrer Ibanez.
http://lists.llvm.org/pipermail/llvm-dev/2020-October/145850.html
Differential Revision: https://reviews.llvm.org/D93013
LLVM GN Syncbot [Tue, 15 Dec 2020 03:35:00 +0000 (03:35 +0000)]
[gn build] Port
d2ed9d6b7ec
Nico Weber [Tue, 15 Dec 2020 03:33:29 +0000 (22:33 -0500)]
Reland "[MachineDebugify] Insert synthetic DBG_VALUE instructions"
This reverts commit
841f9c937f6e593c926a26aedf054436eb807fe6.
The change landed many months ago; something else broke those tests.
Med Ismail Bennani [Tue, 15 Dec 2020 02:40:47 +0000 (03:40 +0100)]
[lldb/API] Expose Target::CreateBreakpoint(..., move_to_nearest_code) overload
This patch exposes the Target::CreateBreakpoint overload with the
boolean argument to move to the neareast code to the SBAPI.
This is useful when creating column breakpoints to restrict lldb's
resolution to the pointed source location, preventing it to go to the next
line.
rdar://
72196842
Differential Revision: https://reviews.llvm.org/D93266
Signed-off-by: Med Ismail Bennani <medismail.bennani@gmail.com>
Nico Weber [Tue, 15 Dec 2020 03:13:40 +0000 (22:13 -0500)]
Revert "[MachineDebugify] Insert synthetic DBG_VALUE instructions"
This reverts commit
2a5675f11d3bc803a245c0e2a3b47491c8f8a065.
The tests it adds fail: https://reviews.llvm.org/D78135#2453736
Nico Weber [Tue, 15 Dec 2020 03:12:15 +0000 (22:12 -0500)]
Revert "[Debugify] Support checking Machine IR debug info"
This reverts commit
c4d2d4337d50bed3cafd564daece1a197005b22b.
Necessary to revert
2a5675f11d3bc803a245c0e.
Luo, Yuanke [Sun, 13 Dec 2020 03:14:46 +0000 (11:14 +0800)]
[X86] Add test case for commit
e52bc1d2bba794b.
Differential Revision: https://reviews.llvm.org/D93173
Nico Weber [Tue, 15 Dec 2020 03:04:41 +0000 (22:04 -0500)]
Revert "Lex: Migrate HeaderSearch::LoadedModuleMaps to FileEntryRef"
This reverts commit
a40db5502b2515a6f2f1676b5d7a655ae0f41179.
and follow-up
d636b881bb9214938973098a012fad453082c444
Somewhat speculative, likely broke check-clang on Windows:
https://reviews.llvm.org/D92975#2453482
Nico Weber [Tue, 15 Dec 2020 02:59:51 +0000 (21:59 -0500)]
Revert "[amdgpu] Default to code object v3"
This reverts commit
4b2e7d0215021d0d1df1a6319884b21d33936265.
Breaks check-clang, see https://reviews.llvm.org/D93258#2453600
Qiu Chaofan [Tue, 15 Dec 2020 02:30:00 +0000 (10:30 +0800)]
[NFC] [Legalizer] Use common method for expanding fp-to-int operands
Reviewed By: RKSimon, steven.zhang
Differential Revision: https://reviews.llvm.org/D92481
Rong Xu [Tue, 15 Dec 2020 02:41:09 +0000 (18:41 -0800)]
[PGO] remove unintentional code in early commit
Remove unintentional code in
commit 54e03d [PGO] Verify BFI counts after loading profile data.
River Riddle [Tue, 15 Dec 2020 02:07:45 +0000 (18:07 -0800)]
[mlir][Inliner] Refactor the inliner to use nested pass pipelines instead of just canonicalization
Now that passes have support for running nested pipelines, the inliner can now allow for users to provide proper nested pipelines to use for optimization during inlining. This revision also changes the behavior of optimization during inlining to optimize before attempting to inline, which should lead to a more accurate cost model and prevents the need for users to schedule additional duplicate cleanup passes before/after the inliner that would already be run during inlining.
Differential Revision: https://reviews.llvm.org/D91211
Siva Chandra [Tue, 15 Dec 2020 02:05:19 +0000 (18:05 -0800)]
[libc] Add remainder[f|l] and remquo[f|l] to the list of aarch64 entrypoints.
Xiang1 Zhang [Tue, 15 Dec 2020 01:51:21 +0000 (17:51 -0800)]
[Debugify] Support checking Machine IR debug info
Add mir-check-debug pass to check MIR-level debug info.
For IR-level, currently, LLVM have debugify + check-debugify to generate
and check debug IR. Much like the IR-level pass debugify, mir-debugify
inserts sequentially increasing line locations to each MachineInstr in a
Module, But there is no equivalent MIR-level check-debugify pass, So now
we support it at "mir-check-debug".
Reviewed By: djtodoro
Differential Revision: https://reviews.llvm.org/D91595
Siva Chandra [Tue, 15 Dec 2020 01:51:13 +0000 (17:51 -0800)]
[libc][NFC] Skip adding dummy targets for skipped unit tests.
Xiang1 Zhang [Tue, 15 Dec 2020 01:42:21 +0000 (17:42 -0800)]
Revert "[Debugify] Support checking Machine IR debug info"
This reverts commit
57a3d9ec4a8c1422f07264bed9f12a4ea416707e.
Cheng Wang [Fri, 4 Dec 2020 10:21:48 +0000 (18:21 +0800)]
[libc] Add memcmp implementation.
Reviewed By: gchatelet
Differential Revision: https://reviews.llvm.org/D93009
Xiang1 Zhang [Tue, 15 Dec 2020 01:28:34 +0000 (17:28 -0800)]
[Debugify] Support checking Machine IR debug info
Add mir-check-debug pass to check MIR-level debug info.
For IR-level, currently, LLVM have debugify + check-debugify to generate
and check debug IR. Much like the IR-level pass debugify, mir-debugify
inserts sequentially increasing line locations to each MachineInstr in a
Module, But there is no equivalent MIR-level check-debugify pass, So now
we support it at "mir-check-debug".
Reviewed By: djtodoro
Differential Revision: https://reviews.llvm.org/D95195
Craig Topper [Tue, 15 Dec 2020 01:19:53 +0000 (17:19 -0800)]
[RISCV] Prevent assertion in the assembler if vmerge or vfmerge are given a V0 destination.
Craig Topper [Tue, 15 Dec 2020 00:48:56 +0000 (16:48 -0800)]
[RISCV] Handle Match_InvalidSImm5 in RISCVAsmParser::MatchAndEmitInstruction
Craig Topper [Tue, 15 Dec 2020 00:48:20 +0000 (16:48 -0800)]
[RISCV] Teach debug output from assembly parser to print register names instead of enum values.
Alexander Kornienko [Mon, 14 Dec 2020 22:06:36 +0000 (23:06 +0100)]
Remove the ast_type_traits namespace.
This is the final cleanup after https://reviews.llvm.org/D74499
Reviewed By: steveire
Differential Revision: https://reviews.llvm.org/D93244
Siva Chandra Reddy [Tue, 15 Dec 2020 01:12:08 +0000 (17:12 -0800)]
[libc][Obvious] Mark functions in DummyFEnv.h as static inline.
Jon Chesterfield [Tue, 15 Dec 2020 01:10:41 +0000 (01:10 +0000)]
[amdgpu] Default to code object v3
[amdgpu] Default to code object v3
v4 is not yet readily available, and doesn't appear
to be implemented in the back end
Reviewed By: t-tye
Differential Revision: https://reviews.llvm.org/D93258
Reid Kleckner [Tue, 15 Dec 2020 00:56:04 +0000 (16:56 -0800)]
Revert "ADT: Migrate users of AlignedCharArrayUnion to std::aligned_union_t, NFC"
We determined that the MSVC implementation of std::aligned* isn't suited
to our needs. It doesn't support 16 byte alignment or higher, and it
doesn't really guarantee 8 byte alignment. See
https://github.com/microsoft/STL/issues/1533
Also reverts "ADT: Change AlignedCharArrayUnion to an alias of std::aligned_union_t, NFC"
Also reverts "ADT: Remove AlignedCharArrayUnion, NFC" to bring back
AlignedCharArrayUnion.
This reverts commit
4d8bf870a82765eb0d4fe53c82f796b957c05954.
This reverts commit
d10f9863a5ac1cb681af07719650c44b48f289ce.
This reverts commit
4b5dc150b9862271720b3d56a3e723a55dd81838.
Changpeng Fang [Tue, 15 Dec 2020 00:34:32 +0000 (16:34 -0800)]
AMDGPU: If a store defines (alias) a load, it clobbers the load.
Summary:
If a store defines (must alias) a load, it clobbers the load.
Fixes: SWDEV-258915
Reviewers:
arsenm
Differential Revision:
https://reviews.llvm.org/D92951