Zbigniew Jędrzejewski-Szmek [Tue, 15 Mar 2016 04:50:25 +0000 (00:50 -0400)]
nss-myhostname: remove dead test of variable that was not set
Zbigniew Jędrzejewski-Szmek [Fri, 4 Mar 2016 15:50:45 +0000 (10:50 -0500)]
test-nss: test the resolution of various names
nss-dns is also "tested". It should be almost always available,
and provides a reference for comparison.
Zbigniew Jędrzejewski-Szmek [Fri, 4 Mar 2016 16:28:04 +0000 (11:28 -0500)]
string-table: split long definitions
Zbigniew Jędrzejewski-Szmek [Thu, 3 Mar 2016 20:35:34 +0000 (15:35 -0500)]
Move nss typedefs into nss-util.h
In preparation for subsequent changes.
Zbigniew Jędrzejewski-Szmek [Thu, 3 Mar 2016 20:07:02 +0000 (15:07 -0500)]
nss-myhostname: trivial style fixes
Zbigniew Jędrzejewski-Szmek [Tue, 1 Mar 2016 17:08:02 +0000 (12:08 -0500)]
Redefine 32bit time_t format to signed
It seems that it is signed both on i386 and arm.
Avoids a stupid gcc warning on arm:
src/udev/udevadm-monitor.c: In function ‘print_device’:
src/udev/udevadm-monitor.c:44:16: warning: format ‘%u’ expects argument of type ‘unsigned int’, but argument 3 has type ‘__time_t {aka long int}’ [-Wformat=]
printf("%-6s[%"PRI_TIME".%06ld] %-8s %s (%s)\n",
^
Zbigniew Jędrzejewski-Szmek [Tue, 1 Mar 2016 16:52:03 +0000 (11:52 -0500)]
test-sizeof: add a helper which prints variable sizes and signedness
This helps to understand misleading gcc warnings about type mismatches.
Zbigniew Jędrzejewski-Szmek [Tue, 1 Mar 2016 14:17:03 +0000 (09:17 -0500)]
test-selinux: add some simple tests which call functions and print the results and timings
Zbigniew Jędrzejewski-Szmek [Wed, 2 Mar 2016 15:16:39 +0000 (10:16 -0500)]
selinux: use raw variants of security_compute_create and setfscreatecon
As suggested by Evgeny Vereshchagin as a follow up for
https://github.com/systemd/systemd/pull/2781#issuecomment-
191043402.
Zbigniew Jędrzejewski-Szmek [Wed, 2 Mar 2016 01:35:55 +0000 (20:35 -0500)]
selinux: always try to load the full selinux db
https://github.com/systemd/systemd/pull/2508#issuecomment-
190901170
Maybe fixes https://bugzilla.redhat.com/show_bug.cgi?id=1308771.
Daniel Mack [Tue, 1 Mar 2016 09:06:51 +0000 (10:06 +0100)]
Merge pull request #2773 from eliasp/type-warnings
Use `PRIu64` to print `uint64_t` in log msgs
Zbigniew Jędrzejewski-Szmek [Tue, 1 Mar 2016 04:18:16 +0000 (23:18 -0500)]
Merge pull request #2702 from poettering/resolved-iterate-fix
resolved iteration fix
Zbigniew Jędrzejewski-Szmek [Tue, 1 Mar 2016 01:45:42 +0000 (20:45 -0500)]
Merge pull request #2767 from benjarobin/fix-warn
systemctl: Fix warn: action_to_runlevel() is not used
Elias Probst [Mon, 29 Feb 2016 21:42:43 +0000 (22:42 +0100)]
Use `PRIu64` to print `uint64_t` in log msgs
Lennart Poettering [Mon, 29 Feb 2016 19:33:51 +0000 (20:33 +0100)]
Merge pull request #2771 from 0xAX/core-kernel-timestamp-cleanup
core: use DUAL_TIMESTAMP_NULL to reset kernel_timestamp
Lennart Poettering [Mon, 29 Feb 2016 19:32:02 +0000 (20:32 +0100)]
Merge pull request #2769 from martinpitt/adjtime
Fixes for adjtime parsing
Martin Pitt [Mon, 29 Feb 2016 16:40:08 +0000 (17:40 +0100)]
test-clock: fix FILE* leak
Close the FILE* instead of the underlying fd.
Zbigniew Jędrzejewski-Szmek [Mon, 29 Feb 2016 15:10:55 +0000 (10:10 -0500)]
Merge pull request #2752 from eliasp/no-container-name-escaping
Don't escape the name of the container nspawn service
Lennart Poettering [Mon, 29 Feb 2016 15:05:48 +0000 (16:05 +0100)]
Merge pull request #2763 from tblume/shorten-hostname-before-removing-dots
shorten hostname before checking for trailing dot
Lennart Poettering [Mon, 29 Feb 2016 15:03:32 +0000 (16:03 +0100)]
Merge pull request #2756 from thom311/master
core: avoid compiler warning when compiling with -fexceptions
Martin Pitt [Mon, 29 Feb 2016 14:16:11 +0000 (15:16 +0100)]
test-clock: fix assertions
Use assert_se() to ensure that they don't get optimized away.
Martin Pitt [Mon, 29 Feb 2016 14:16:03 +0000 (15:16 +0100)]
timedated: trivial stylistic fix
Don't use {} for single-line "then" blocks.
Martin Pitt [Mon, 29 Feb 2016 14:19:10 +0000 (15:19 +0100)]
Merge pull request #2766 from keszybz/coverity
test-clock: fix fd "leak"
Benjamin ROBIN [Mon, 29 Feb 2016 14:07:09 +0000 (15:07 +0100)]
systemctl: Fix warn: action_to_runlevel() is not used
If HAVE_SYSV_COMPAT is not defined: ‘action_to_runlevel’ defined but not used
Zbigniew Jędrzejewski-Szmek [Mon, 29 Feb 2016 13:03:32 +0000 (08:03 -0500)]
test-clock: fix fd "leak"
CID #1352301.
Alexander Kuleshov [Mon, 29 Feb 2016 12:56:57 +0000 (18:56 +0600)]
core: use DUAL_TIMESTAMP_NULL to reset kernel_timestamp
instead of direct reset of kernel_timestamp fields.
Ronny Chevalier [Mon, 29 Feb 2016 11:23:55 +0000 (12:23 +0100)]
Merge pull request #2764 from benjarobin/fix-stdio-bridge
stdio-bridge: Correctly propagate error
Benjamin Robin [Mon, 29 Feb 2016 09:36:11 +0000 (10:36 +0100)]
stdio-bridge: Correctly propagate error
Return EXIT_FAILURE and print the correct errno code if sd_bus_get_fd() or sd_bus_get_events() fail
Thomas Blume [Mon, 29 Feb 2016 09:19:01 +0000 (10:19 +0100)]
shorten hostname before checking for trailing dot
Shortening can lead to a hostname that has a trailing dot.
Therefore it should be done before checking from trailing dots.
Zbigniew Jędrzejewski-Szmek [Mon, 29 Feb 2016 00:23:29 +0000 (19:23 -0500)]
Merge pull request #2746 from daurnimator/patch-1
ISSUE_TEMPLATE: Use a list for submission type so that it appears as a checkbox
Zbigniew Jędrzejewski-Szmek [Mon, 29 Feb 2016 00:12:31 +0000 (19:12 -0500)]
Merge pull request #2753 from phomes/trivial-fixes2
Trivial fixes
Zbigniew Jędrzejewski-Szmek [Sun, 28 Feb 2016 23:56:07 +0000 (18:56 -0500)]
Merge pull request #2749 from martinpitt/adjtime
Thomas Haller [Sat, 27 Feb 2016 12:40:50 +0000 (13:40 +0100)]
core: avoid compiler warning when compiling with -fexceptions
Initialize auto variables with cleanup attribute, otherwise we
get a compiler warning with -fexceptions.
./configure CFLAGS='-Wmaybe-uninitialized -fexceptions -O2'
Thomas Hindoe Paaboel Andersen [Wed, 24 Feb 2016 23:29:09 +0000 (00:29 +0100)]
stdio-bridge: remove dead code
Thomas Hindoe Paaboel Andersen [Wed, 24 Feb 2016 23:27:56 +0000 (00:27 +0100)]
tree-wide: indentation fixes
Elias Probst [Fri, 26 Feb 2016 19:35:09 +0000 (20:35 +0100)]
Don't escape the name of the container in instances of
When using `%I` for instances of `systemd-nspawn@.service`, the result
will be `systemd-nspawn` trying to launch a container named e.g.
`fedora/23` instead of `fedora-23`.
Using `%i` instead prevents escaping `-` in a container name and uses
the unmodified container name from the machine store.
Martin Pitt [Fri, 26 Feb 2016 14:54:05 +0000 (15:54 +0100)]
timedated: be more tolerant in parsing /etc/adjtime
Similarly to the previous commit, make context_write_data_local_rtc()
understand /etc/adjtime files with just one or two lines, with or without a
final newline.
Normalize the file to the current definition in hwclock(8), in the spirit of
"be liberal what you accept and strict what you produce": Add line terminators,
and set the second line to "0" if missing.
Fixes: #2638
Martin Pitt [Fri, 26 Feb 2016 11:33:41 +0000 (12:33 +0100)]
clock-util: be more tolerant in parsing /etc/adjtime
As we default to "hardware clock is in UTC" if /etc/adjtime is not present, it
also makes sense to have that default if /etc/adjtime contains only one or two
lines.
Drop the "gibberish" test case, as this was just EIO because of not containing
three lines, which is already contained in other tests. clock_is_localtime()
never actually validated the format of the first two lines, and there is little
point in doing that.
This addresses the reading half of issue #2638.
Martin Pitt [Fri, 26 Feb 2016 10:25:22 +0000 (11:25 +0100)]
clock-util: make clock_is_localtime() testable and add initial tests
Add path argument to clock_is_localtime() and default to "/etc/adjtime" if it's
NULL. This makes the function testable.
Add test-clock: initial test cases for some scenarios, using a temporary file.
This also checks the behaviour with a NULL (i. e. the system's /etc/adjtime)
file.
daurnimator [Thu, 25 Feb 2016 22:54:30 +0000 (09:54 +1100)]
.github/ISSUE_TEMPLATE: Use a list for submission type so that it appears as a checkbox
Zbigniew Jędrzejewski-Szmek [Thu, 25 Feb 2016 20:29:59 +0000 (15:29 -0500)]
Merge pull request #2671 from 0xAX/move-pager-open-to-one-place
tree-wide: merge pager_open_if_enabled() to the pager_open()
Alexander Kuleshov [Fri, 19 Feb 2016 18:25:13 +0000 (00:25 +0600)]
tree-wide: merge pager_open_if_enabled() to the pager_open()
Many subsystems define own pager_open_if_enabled() function which
checks '--no-pager' command line argument and open pager depends
on its value. All implementations of pager_open_if_enabled() are
the same. Let's merger this function with pager_open() from the
shared/pager.c and remove pager_open_if_enabled() from all subsytems
to prevent code duplication.
Lennart Poettering [Thu, 25 Feb 2016 19:01:56 +0000 (20:01 +0100)]
Merge pull request #2743 from pfl/dhcp4_server
sd-dhcp-server: Send replies to BOOTP relay server port
Patrik Flykt [Thu, 25 Feb 2016 13:36:40 +0000 (15:36 +0200)]
sd-dhcp-server: Send replies to BOOTP relay server port
RFC 2131 Section 4.1 says that
"If the ’giaddr’ field in a DHCP message from a client is non-zero,
the server sends any return messages to the ’DHCP server’ port on the
BOOTP relay agent whose address appears in ’giaddr’."
Fix this by adding a destination port when sending unicast UDP packets
and provide the server port when a BOOTP relay agent is being used.
Daniel Mack [Wed, 24 Feb 2016 14:51:34 +0000 (15:51 +0100)]
Merge pull request #2722 from torstehu/fix-typo2
treewide: fix typos and then/that use
Torstein Husebø [Mon, 8 Feb 2016 12:27:22 +0000 (13:27 +0100)]
treewide: fix typos and then/that use
Martin Pitt [Wed, 24 Feb 2016 07:06:53 +0000 (08:06 +0100)]
Merge pull request #2719 from evverx/add-test-to-makefile
tests: various fixes
Zbigniew Jędrzejewski-Szmek [Wed, 24 Feb 2016 05:40:48 +0000 (00:40 -0500)]
Merge pull request #2726 from ssiloti/master
dnssec: only run tests that require gcrypt if we have it
Zbigniew Jędrzejewski-Szmek [Wed, 24 Feb 2016 05:39:06 +0000 (00:39 -0500)]
Merge pull request #2727 from ian-kelling/man-pr-v3
man: clarify unit ordering language
Ian Kelling [Mon, 22 Feb 2016 02:21:50 +0000 (18:21 -0800)]
man: clarify unit ordering language
Steven Siloti [Wed, 24 Feb 2016 04:15:23 +0000 (20:15 -0800)]
dnssec: only run tests that require gcrypt if we have it
Zbigniew Jędrzejewski-Szmek [Tue, 23 Feb 2016 23:48:37 +0000 (18:48 -0500)]
Merge pull request #2724 from vcaputo/minor-formatting-cleanups
tree-wide: minor formatting inconsistency cleanups
Vito Caputo [Tue, 23 Feb 2016 17:52:52 +0000 (09:52 -0800)]
tree-wide: minor formatting inconsistency cleanups
Zbigniew Jędrzejewski-Szmek [Tue, 23 Feb 2016 22:12:40 +0000 (17:12 -0500)]
Merge pull request #2639 from nafets227/master
Bugfix set virt=none when running on XEN Dom0
Stefan Schallenberg aka nafets227 [Tue, 16 Feb 2016 20:36:12 +0000 (21:36 +0100)]
basic: Bugfix Detect XEN Dom0 as no virtualization
When running in XEN Dom0 the virtualization check:
1) detect_xen returns HYPERVISOR_NONE so next checks are executed
2) /proc/sys/hypervisor detects a XEN hypervisor
it is lacking the special Dom0 detection as in detect_xen
With this patch, at the end of all virtualization checks we double-check if running in XEN Dom0 or DomU.
Stefan Schallenberg aka nafets227 [Thu, 18 Feb 2016 20:10:28 +0000 (21:10 +0100)]
basic: Debug-logging of Virtualisation detection
print out every single detection executed and its result.
Zbigniew Jędrzejewski-Szmek [Tue, 23 Feb 2016 19:58:01 +0000 (14:58 -0500)]
Merge pull request #2725 from phomes/misc-cleanup
Misc cleanup
Thomas Hindoe Paaboel Andersen [Tue, 23 Feb 2016 19:25:48 +0000 (20:25 +0100)]
networkctl: fix const
Thomas Hindoe Paaboel Andersen [Tue, 23 Feb 2016 19:16:59 +0000 (20:16 +0100)]
tree-wide: remove unused variables
Thomas Hindoe Paaboel Andersen [Tue, 23 Feb 2016 18:21:54 +0000 (19:21 +0100)]
basic: mark unused variable as such
Lennart Poettering [Tue, 23 Feb 2016 19:27:59 +0000 (20:27 +0100)]
Merge pull request #2664 from zonque/bootchart-removal
Remove systemd-bootchart
Zbigniew Jędrzejewski-Szmek [Tue, 23 Feb 2016 18:39:56 +0000 (13:39 -0500)]
Merge pull request #2723 from poettering/importd-man
Zbigniew Jędrzejewski-Szmek [Tue, 23 Feb 2016 18:46:16 +0000 (13:46 -0500)]
man: style fixes
Lennart Poettering [Tue, 23 Feb 2016 17:24:03 +0000 (18:24 +0100)]
man: change recommended order of NSS modules in /etc/nsswitch.conf
So far we recommended placing "nss-mymachines" after "nss-resolve" in the order
of preference in /etc/nsswitch.conf. This change reverse this order.
Rationale: single-label names are resolved via LLMNR by resolved, which has to
time out if no peer by that name exists. By placing "nss-mymachines" first
(which always responds immediately) we avoid running into this timeout for most
containers. Both modules should return the same data if LLMNR is used by the
container anyway.
While we are at it, improve the man pages of the three NSS modules in other
ways a bit.
Evgeny Vereshchagin [Tue, 23 Feb 2016 16:53:19 +0000 (16:53 +0000)]
tests: add exec-capabilityambientset* to Makefile.am
This is a follow-up to
70d7aea5c
Evgeny Vereshchagin [Tue, 23 Feb 2016 15:59:14 +0000 (15:59 +0000)]
tests: add exec-runtimedirectory* to Makefile.am
This is a follow-up to
cc3ddc851
Lennart Poettering [Tue, 23 Feb 2016 12:17:00 +0000 (13:17 +0100)]
tests: fix x86 personality tests to only on x86
Evgeny Vereshchagin [Tue, 23 Feb 2016 14:33:20 +0000 (14:33 +0000)]
tests: add exec-spec-interpolation.service to Makefile.am
This is a follow-up to 2525499
Lennart Poettering [Tue, 23 Feb 2016 15:55:16 +0000 (16:55 +0100)]
Merge pull request #2708 from vcaputo/journal-restore-offline-state-on-error
journal: restore offline state on error
Lennart Poettering [Tue, 23 Feb 2016 15:54:52 +0000 (16:54 +0100)]
Merge pull request #2717 from keszybz/networkctl-prettification
Networkctl prettification
Lennart Poettering [Tue, 23 Feb 2016 15:24:01 +0000 (16:24 +0100)]
man: link some unit files to their online bus API documentation
Lennart Poettering [Tue, 23 Feb 2016 15:23:42 +0000 (16:23 +0100)]
man: add minimal man page for systemd-importd.service
Zbigniew Jędrzejewski-Szmek [Tue, 23 Feb 2016 04:23:56 +0000 (23:23 -0500)]
networkctl: only print lldp legend for capabilities that were actually seen
Zbigniew Jędrzejewski-Szmek [Tue, 23 Feb 2016 13:17:19 +0000 (08:17 -0500)]
basic: simplify ether_addr_is_null
Zbigniew Jędrzejewski-Szmek [Tue, 23 Feb 2016 13:17:19 +0000 (08:17 -0500)]
Fix two typos
Zbigniew Jędrzejewski-Szmek [Tue, 23 Feb 2016 13:17:03 +0000 (08:17 -0500)]
man: update link to Fedora Cloud images
Better to use the mirror manager and https.
Daniel Mack [Mon, 22 Feb 2016 20:01:39 +0000 (21:01 +0100)]
architecture.h: remove PROC_CPUINFO_MODEL
This was only needed for bootchart, so it can go now.
Daniel Mack [Fri, 12 Feb 2016 14:03:51 +0000 (15:03 +0100)]
Remove systemd-bootchart
This commit rips out systemd-bootchart. It will be given a new home, outside
of the systemd repository. The code itself isn't actually specific to
systemd and can be used without systemd even, so let's put it somewhere
else.
Martin Pitt [Tue, 23 Feb 2016 07:45:54 +0000 (08:45 +0100)]
Merge pull request #2709 from vcaputo/normalize_inc_dec_usage
tree-wide: make ++/-- usage consistent WRT spacing
Martin Pitt [Tue, 23 Feb 2016 07:25:13 +0000 (08:25 +0100)]
Merge pull request #2707 from teg/man-network
network: minor manpage clarifications
Martin Pitt [Tue, 23 Feb 2016 07:19:20 +0000 (08:19 +0100)]
Merge pull request #2698 from poettering/personality
Personality fixes
Vito Caputo [Tue, 23 Feb 2016 04:32:04 +0000 (20:32 -0800)]
tree-wide: make ++/-- usage consistent WRT spacing
Throughout the tree there's spurious use of spaces separating ++ and --
operators from their respective operands. Make ++ and -- operator
consistent with the majority of existing uses; discard the spaces.
Vito Caputo [Tue, 23 Feb 2016 04:00:13 +0000 (20:00 -0800)]
journal: restore offline state on error
If we fail to create the thread, technically we should leave the
offline_state as OFFLINE_JOINED, not OFFLINE_SYNCING.
Zbigniew Jędrzejewski-Szmek [Tue, 23 Feb 2016 00:56:23 +0000 (19:56 -0500)]
Merge pull request #2706 from whot/hwdb-updates
Lenovo T460 and P50 touchpad axis corrections
Tom Gundersen [Tue, 23 Feb 2016 00:09:31 +0000 (01:09 +0100)]
man: link - add suggestion for debugging
udevadm test-builtin can be very useful for testing .link files, so add a reference.
Addresses issue #2406.
Tom Gundersen [Mon, 22 Feb 2016 23:29:32 +0000 (00:29 +0100)]
man: network - clarify BindCarrier documentation
Make it clear that we are talking of links (in the sense used in networkd) and not ports.
Addresses issue #964.
Tom Gundersen [Mon, 22 Feb 2016 23:21:53 +0000 (00:21 +0100)]
man: network - improve IPv6Token documentation
Enabling router advertisement may even trigger SLAAC or DHCPv6 to be used to configure
IPv6 addresses on the link. It may not be obvious that only in the SLAAC case will the
Token have an effect. Clarify this in the man page.
Addresses issue #863.
Peter Hutterer [Mon, 22 Feb 2016 23:52:21 +0000 (09:52 +1000)]
hwdb: reshuffle Lenovo entries to sort alphabetically by model
Peter Hutterer [Mon, 22 Feb 2016 23:49:08 +0000 (09:49 +1000)]
hwdb: add axis range corrections for the Lenovo T460 and P50
Lennart Poettering [Mon, 22 Feb 2016 22:25:36 +0000 (23:25 +0100)]
Merge pull request #2701 from keszybz/udev-rules
udev-rules cleanup fix
Lennart Poettering [Mon, 22 Feb 2016 19:39:45 +0000 (20:39 +0100)]
resolved: fix notification iteration logic when transactions are completed
When a transaction is complete, and we notify its owners, make sure we deal
correctly with the requesters removing themselves from the list of owners while
we continue iterating.
This was previously already dealt with with transactions that require other
transactions for DNSSEC purposes, fix this for other possibly transaction
owners too now.
Since iterating through "Set" objects is not safe regarding removal of entries
from it, rework the logic to use two Sets, and move each entry we notified from
one set to the other set before we dispatch the notification. This move operation
requires no additional memory, and enables us to ensure that we don't notify
any object twice.
Fixes: #2676
Lennart Poettering [Mon, 22 Feb 2016 17:40:28 +0000 (18:40 +0100)]
hashmap: use void* and uint8_t* for generic pointers
As suggested by CODING_STYLE we should use "void*" as type for generic memory,
and uint8_t* for generic bytes. Hence use that instead of "char*", which should
really be used only for strings these days.
Lennart Poettering [Mon, 22 Feb 2016 22:22:42 +0000 (23:22 +0100)]
github: CONTRIBUTING.md moved, let's fix the link to it
Lennart Poettering [Mon, 22 Feb 2016 17:36:54 +0000 (18:36 +0100)]
tests: add personality tests
Lennart Poettering [Mon, 22 Feb 2016 17:29:05 +0000 (18:29 +0100)]
util-lib: simplify personality() string matching
Lennart Poettering [Mon, 22 Feb 2016 15:28:17 +0000 (16:28 +0100)]
virt: make sure we don't ignore some errors
Lennart Poettering [Mon, 22 Feb 2016 15:01:53 +0000 (16:01 +0100)]
man: extend the Personality= documentation
Among other fixes, add information about more architectures that are supported
these days.
Lennart Poettering [Mon, 22 Feb 2016 14:50:35 +0000 (15:50 +0100)]
util-lib: support various ppc archs in personality logic
Lennart Poettering [Mon, 22 Feb 2016 14:39:52 +0000 (15:39 +0100)]
util-lib: use the architecture ids from architecture.h for personalities
We have this ids, hence let's use them universally.
Lennart Poettering [Mon, 22 Feb 2016 14:26:54 +0000 (15:26 +0100)]
build-sys: move shared/architecture.[ch] into basic/
After all, it is pretty generic, has no external deps besides libc, and is very
similar to virt.[ch] which is also in basic/