Tianqi Chen [Tue, 23 Jun 2020 00:47:01 +0000 (17:47 -0700)]
[TIR][REFACTOR][API-CHANGE] Change Call.name to Call.op(RelayExpr) (#5863)
* [TIR][REFACTOR][API-CHANGE] Change Call.name(string) to Call.op(tvm::Op/RelayExpr)
This PR brings a major refactor to the tir::Call structure.
The current Call structure uses a string field(name) to identify the
function/intrinsic being called. This approach is limited as we start
to expand TIR to be more structured. In particular, we are interested in
the following aspects:
- Type a function and perform better compile time type checking so that we
can find errors early.
- Register additional properties about an operator, such as:
- Whether an intrinsic can be vectorized
- What is the adjoint function of the intrinsic(for tensor expression AD)
- Whether the operator has side effect.
- Perform specific codegen about an intrinsic if necessary.
- Call into another function in the same module.
The refactor changes the Call.name field to Call.op.
The Call.op field has a RelayExpr type, and we can pass:
- A tvm::Op which represents the corresponding intrinsic.
- A tvm::GlobalVar for calling into another function in the IRModule.
All the current intrinsics are migrated by registering an tvm::Op.
Because the unified IR shares a single Op registry. We use the "tir"
namespace for tir related intrinsics, for example bitwise and is now registered
under `tir.bitwise_and`.
To simplify upgrade, we introduce a `tir.call_extern` intrinsic
that allows us to call into arbitary external function without type checking.
However, we should move towards more type checked variants in the system.
Under the new op design. We should no longer try to pattern match all the
specific intrincis. Instead, we should rely on attr of each Op to do transformation.
For example, the vectorization pass depends on the TVectorizable property of the op,
which can be registered independently.
In this way, we can still grow the number of intrinsics when necessary
without having to change all the passes.
The same rule applies for tensor expression AD. Currently we are performing
AD by pattern match on operators like exp, sin, cos. We should instead
change to the ajoint registeration mechanism like those in relay.
Followup refactors need to be performed, including:
- Fold the Call.call_type into operator's attribute.
- Enrich the operator registry information
- Refactor passes(e.g. AD, intrin lowering) to use the attribute based transformation
* Fix nms
* Fix remaining testcase
* Address review comment
Haichen Shen [Mon, 22 Jun 2020 23:45:44 +0000 (16:45 -0700)]
[COMMUNITY] Matthew Brookhart -> Reviewer (#5886)
Thomas Viehmann [Mon, 22 Jun 2020 23:40:45 +0000 (01:40 +0200)]
keep parameter names from PyTorch (#5887)
Thomas Viehmann [Mon, 22 Jun 2020 13:33:04 +0000 (15:33 +0200)]
Improve type handling in PyTorch frontend (#5834)
* Improve type handling in PyTorch frontend
- Use type information from graph for inputs if available. Check
against shape information from graph if available.
- Allow user to set default dtype (default to float32 for sanity and
compatibility).
- Implement type promotion to follow PyTorch mechanism. This includes
fixing the handling of many "Scalar" overloads in PyTorch binary ops.
- Fix arange/linspace type semantics.
- Added support for traced functions. (Because it really is about the
"self" input handling.)
Aside from adding an optional default_dtype keyword argument, this does not
change the signature/requirements of from_pytorch.
* Fix scalar detection using numpy.isscalar
and address other review comments. Thank you @siju-samuel
* refine test criteron on qnn_test::test_serialized_modules, fix bool conversion of const
Matthew Brookhart [Mon, 22 Jun 2020 05:55:16 +0000 (22:55 -0700)]
Fail early before running invalid dynamic graphs (#5856)
* fail early before running invalid dynamic graphs
* fix an issue with the VM comment
Junru Shao [Mon, 22 Jun 2020 03:53:39 +0000 (20:53 -0700)]
[Bugfix][Build] Fix building with LLVM-10 on macOS (#5859)
Balint Cristian [Sun, 21 Jun 2020 22:36:51 +0000 (01:36 +0300)]
[QUANTIZE] Add nn.batch_flatten as quantizable. (#5805)
* [ONNX] Skip ADD inside Gemm op when vector is zero
* [QUANTIZE] Add nn.batch_flatten as quantizable.
Junru Shao [Sat, 20 Jun 2020 02:36:08 +0000 (19:36 -0700)]
[Target] Introduce Target Id Registry (#5838)
Cody Yu [Sat, 20 Jun 2020 00:04:53 +0000 (17:04 -0700)]
[DOCS] Update has_dtype/has_shape to pattern lang doc (#5847)
Tianqi Chen [Fri, 19 Jun 2020 17:37:46 +0000 (10:37 -0700)]
Fix map assign issue in CI test (#5854)
Thomas Viehmann [Fri, 19 Jun 2020 15:28:45 +0000 (17:28 +0200)]
Add Python Classes for all Attrs (#5853)
Menooker [Fri, 19 Jun 2020 14:40:40 +0000 (22:40 +0800)]
[DataType] Add bfloat16 (#5601)
Junru Shao [Fri, 19 Jun 2020 14:35:44 +0000 (07:35 -0700)]
[Object] Introduce POD-C Compliant tvm::Map (#5740)
mbaret [Fri, 19 Jun 2020 14:35:05 +0000 (15:35 +0100)]
[FIX] Recover global state after test_util.py (#5824)
In test_util.py, a program exit is simulated to test
that the error throwing behaviour is accurate.
Unforunately, this also deletes necessary global state
and so all subsequent tests that run and use tempdir
throw the same error.
This patch is a simple fix to restore the global state
at the end of the test.
Change-Id: I62fef46167e47f6af43271e2ce1db30f54857647
Haichen Shen [Thu, 18 Jun 2020 23:29:21 +0000 (16:29 -0700)]
[AutoTVM] Suppress the warning messages when compile engine selects impls (#5821)
ANSHUMAN TRIPATHY [Thu, 18 Jun 2020 23:21:55 +0000 (04:51 +0530)]
Additional canonicalization added for AddNode (#5846)
Matthew Brookhart [Thu, 18 Jun 2020 22:28:01 +0000 (15:28 -0700)]
fix batchnorm infer_value error, add regression test and unit test (#5845)
Zhi [Thu, 18 Jun 2020 22:18:29 +0000 (15:18 -0700)]
[RUNTIME] Introduce MetadataModule to separate code compilation/interpretation and weight initialization (#5770)
Jared Roesch [Thu, 18 Jun 2020 18:33:25 +0000 (11:33 -0700)]
`tvm` crate stage 3 of Rust refactor (#5769)
* Adapt to new macro
* Add tvm crate
* Fix out of tree pass with new bindings
* Super slick API working
* Add examples
* Delay egg example and add ASF headers
* Move array.rs around
* Remove outdated tests will restore in CI PR
* Fix some memory issues
* Fix ref counting issue
* Formatting and cleanup
* Remove out-of-tree for now
* Remove out-of-tree
Thomas Viehmann [Thu, 18 Jun 2020 18:14:21 +0000 (20:14 +0200)]
ffi (Object): make class dict visible in instances (#5843)
masahi [Thu, 18 Jun 2020 16:24:03 +0000 (01:24 +0900)]
[Torch][Quantized] Fix converting serialized quantized models (#5839)
* [Torch] Fix converting serialized quantized models
* clean up dtype check
* comment clean up
Siju Samuel [Thu, 18 Jun 2020 00:50:33 +0000 (06:20 +0530)]
[KERAS]RepeatVector, Conv3DTranspose op support added (#5833)
Thomas Viehmann [Wed, 17 Jun 2020 20:39:12 +0000 (22:39 +0200)]
Add a combine batch_matmul pass (#5791)
* Add a combine batch_matmul pass
Contrary what you might expect, this doesn't share as much code with
the combine dense pass as it does with the combine 2d conv pass.
This is because it concatenates the "output feature" dimensions.
* fix docstring
Haichen Shen [Wed, 17 Jun 2020 20:15:14 +0000 (13:15 -0700)]
[Frontend][MXNet] Support a few contrib ops in mxnet (#5819)
* support for bert in mxnet1.6 and gluonnlp0.9
* fix converter
* Add test cases
* add a todo
Yao Wang [Wed, 17 Jun 2020 17:05:35 +0000 (10:05 -0700)]
[Frontend][TensorFlow]Fix TF Dynamic input shape (#5825)
* Fix TF Dynamic input shape
* Remove warning
* Add test
Mahesh Ambule [Wed, 17 Jun 2020 03:53:08 +0000 (09:23 +0530)]
[Relay, Topi] [Frontend][TFLite, MXNet] ReverseSequence operator (#5495)
* TFLite reverse_sequence op
* TFLite add_n implementation
* reverse_sequence implementation
* reverse_sequence implementation
* reverse sequence
* TOPI,Relay,TFLite - Reverse Sequence
Signed-off-by: maheshambule <mahesh_ambule@persistent.com>
* Reverse Sequence small fixes
Signed-off-by: maheshambule <mahesh_ambule@persistent.com>
* lint fixes
Signed-off-by: maheshambule <mdambule07@gmail.com>
* TFLite reverse_sequence op
Signed-off-by: maheshambule
* MXNet SequenceReverse implementation
* clang format
* clang format
* review comment fixes
Zhi [Wed, 17 Jun 2020 03:49:51 +0000 (20:49 -0700)]
[RUNTIME][String] Overload string operators (#5806)
Haichen Shen [Wed, 17 Jun 2020 02:30:49 +0000 (19:30 -0700)]
[Fix] Fix recursive let for well formed check (#5780)
lixiaoquan [Tue, 16 Jun 2020 22:11:22 +0000 (06:11 +0800)]
[MergeComposite] Fix InferType when module contains Prelude (#5797)
A function may refer to other resources in the same module, so keep
the content of original module when infering a function.
Thomas Viehmann [Tue, 16 Jun 2020 21:13:40 +0000 (23:13 +0200)]
fix relay.build to not change the module argument in place (#5822)
Haichen Shen [Tue, 16 Jun 2020 20:14:07 +0000 (13:14 -0700)]
[Relay][OpStrategy] Tweak cublas/cudnn priority level (#5820)
* Tweak cublas plevel
* update
* trigger ci
Ina Dobreva [Tue, 16 Jun 2020 17:16:26 +0000 (20:16 +0300)]
[Frontend][TFlite] Add parser support for relu6, leaky_relu, relu_n1_to_1, log_softmax (#4805)
* [Frontend][TFLite]Add support for relu6, leaky_relu, relu_n1_to_1, log_softmax
* add implementation in parser
* add qnn tests for each operator
* Implement clip operation for quantized relu6, relu1
* add 'clip' as in the quantized fused operations
* remove redundant assertions and imports
* Fix floating value quantization for RELU6 and RELU1
ANSHUMAN TRIPATHY [Tue, 16 Jun 2020 15:24:12 +0000 (20:54 +0530)]
Error msg update (#5818)
Tianqi Chen [Mon, 15 Jun 2020 20:08:55 +0000 (13:08 -0700)]
[COMMUNITY] Siju Samuel -> Committer (#5817)
Tianqi Chen [Mon, 15 Jun 2020 17:28:59 +0000 (10:28 -0700)]
[CI] Limit number of threads in all jobs (#5815)
Leandro Nunes [Mon, 15 Jun 2020 14:54:38 +0000 (15:54 +0100)]
Pin hand landmark network to version 0.7.4. (#5813)
* Versions above 0.7.4 are broken due to changes in the
quantization operations in the model, which are current
not supported by TVM.
Fixes #5774.
Samuel [Mon, 15 Jun 2020 12:47:53 +0000 (18:17 +0530)]
[MXNET]conv3d and conv3d_transpose addedx (#5814)
Tianqi Chen [Mon, 15 Jun 2020 03:53:11 +0000 (20:53 -0700)]
[CI] Move cpu-only frontend tests to a CPU stage (#5807)
Bing Xu [Mon, 15 Jun 2020 01:54:15 +0000 (18:54 -0700)]
[topi] fix strategy for sparse dense cuda (#5782)
Junru Shao [Sun, 14 Jun 2020 23:28:06 +0000 (16:28 -0700)]
Allow RPCWrappedFunc to rewrite runtime::String as std::string (#5796)
Zijing Gu [Sun, 14 Jun 2020 21:40:20 +0000 (17:40 -0400)]
[topi] fix sparse dense schedule on cuda (#5803)
Balint Cristian [Sun, 14 Jun 2020 17:37:32 +0000 (20:37 +0300)]
[QUANTIZE] Add config switch for nn.dense layer type. (#5801)
Tianqi Chen [Sun, 14 Jun 2020 16:45:46 +0000 (09:45 -0700)]
[TIR][REFACTOR] Add tir prefix to type keys (#5802)
Balint Cristian [Sun, 14 Jun 2020 03:39:20 +0000 (06:39 +0300)]
[ONNX] Skip multiply with 1.0f constant for GEMM import (#5800)
* [ONNX] Skip ADD inside Gemm op when vector is zero
* [ONNX] Skip multiply with 1.0f constant for GEMM import
Tianqi Chen [Sat, 13 Jun 2020 19:18:17 +0000 (12:18 -0700)]
[TEST] Temporary disable fp16 type_as test for PyTorch Frontend (#5799)
Tianqi Chen [Sat, 13 Jun 2020 16:09:00 +0000 (09:09 -0700)]
[TIR][REFACTIR] Update TIR nodes std::string->String. (#5793)
This PR updates the remaining TIR node's member to use
String instead of std::string.
Rand Xie [Sat, 13 Jun 2020 04:52:45 +0000 (21:52 -0700)]
support aten::type_as in the pytorch frontend (#5787)
* support aten::type_as in the pytorch frontend
* use _convert_data_type to convert torch type to tvm type and add more types in the type_as test
Yao Wang [Sat, 13 Jun 2020 03:32:46 +0000 (20:32 -0700)]
Fix tf parser (#5794)
Tianqi Chen [Sat, 13 Jun 2020 00:23:05 +0000 (17:23 -0700)]
[TIR][REFACTOR] Cleanup unused classes (#5789)
Matthew Brookhart [Fri, 12 Jun 2020 22:11:34 +0000 (15:11 -0700)]
Edit onnx parser to infer values in post order (#5755)
* edit onnx parser to infer values in post order to speed up onnx imports with many calls to infer_value
* fix pylint
Tianqi Chen [Fri, 12 Jun 2020 21:19:40 +0000 (14:19 -0700)]
[COMMUNITY] @wpan11nv -> Reviewer (#5790)
lixiaoquan [Fri, 12 Jun 2020 17:42:13 +0000 (01:42 +0800)]
[TF] Support symbolic inputs of Fill (#5762)
* [TF] Support symbolic inputs of Fill
* Rebase and simplify. Value has been converted to constant if it is
tf.Constant
Samuel [Fri, 12 Jun 2020 17:18:05 +0000 (22:48 +0530)]
[TENSORFLOW]Conv3d Transpose OP added (#5775)
* [TENSORFLOW]Conv3d Transpose OP added
* Testcase updated, tf cpu supports only ndhwc
Samuel [Fri, 12 Jun 2020 17:16:52 +0000 (22:46 +0530)]
[PYTORCH]aten::norm support added (#5776)
Samuel [Fri, 12 Jun 2020 16:27:32 +0000 (21:57 +0530)]
[FRONTEND]Darknet support batch size for yolo (#5688)
Fix the issue reported in
https://discuss.tvm.ai/t/yolov3-tiny-batch-input-test-failed/6796
mbaret [Fri, 12 Jun 2020 15:43:33 +0000 (16:43 +0100)]
[BYOC][FIX] Infer types in MergeComposite (#5766)
If InferType isn't run between partitioning passes,
function calls are inserted which don't have a type.
This can result in failures for patterns which want
to check types.
This works around it simply by running InferType after
every partitioning.
Change-Id: Ie0887f0564a41eb0913bfe42a362e8effe9681b9
Josh Fromm [Fri, 12 Jun 2020 15:39:24 +0000 (08:39 -0700)]
Add ignore storage_order attribute to onnx pooling parser. (#5781)
Bing Xu [Fri, 12 Jun 2020 15:35:03 +0000 (08:35 -0700)]
[cmake] update vulkan rules (#5777)
Yi-Hsiang (Sean) Lai [Fri, 12 Jun 2020 15:33:20 +0000 (11:33 -0400)]
fix calibration pass to support multiple functions (#5768)
Co-authored-by: Ubuntu <ubuntu@ip-172-31-43-142.us-east-2.compute.internal>
MORITA Kazutaka [Fri, 12 Jun 2020 15:31:31 +0000 (00:31 +0900)]
[CODEGEN][CONTRIB] CoreML codegen (#5634)
* [CODEGEN][CONTRIB] CoreML codegen
* import coremltools only when it is necessary
* fix pylint errors
* don't import contrib.coreml when using runtime lib
* skip coreml codegen test in CI
* don't register relay.ext.coremlcompiler in __init__.py
* move tvm/contrib/coreml.py to tvm/contrib/target/coreml.py
* use existing transformers for graph partitioning
* skip test only when coremltools is not available
* add check for annotation
* move _register_coreml_op to python/tvm/relay/op/contrib/coreml.py
* skip compile when xcode is unavailable
* relay.op.Op -> tvm.ir.Op
* set USE_COREML on
* refine test
notoraptor [Fri, 12 Jun 2020 15:24:56 +0000 (11:24 -0400)]
[topi][relay] Add operation gather to relay. (#5716)
hlu1 [Fri, 12 Jun 2020 15:24:29 +0000 (08:24 -0700)]
[Topi] pass-by-value -> pass-by-const-reference (#5783)
Tianqi Chen [Fri, 12 Jun 2020 15:24:18 +0000 (08:24 -0700)]
[REFACTOR][API-Change] Migrate all Object construction to constructor. (#5784)
This PR migrates all the remaining object constructions to the new constructor style
that is consistent with the rest of the codebase and changes the affected files accordingly.
Other changes:
- ThreadScope::make -> ThreadScope::Create
- StorageScope::make -> StorageScope::Create
wrongtest [Fri, 12 Jun 2020 15:23:12 +0000 (23:23 +0800)]
[RUNTIME] Add compile_shared option to linux compile utility fn (#5751)
* feat: Add compile_shared option to linux compile fn
* feat: Add compile_shared option for linux compile util fn
* fix: Fix minrpc testcase use executable compilation
* fix: Fix binutil case where call create_shared to create executable
Co-authored-by: baoxinqi <baoxinqi@4paradigm.com>
majiang31312 [Fri, 12 Jun 2020 15:22:24 +0000 (23:22 +0800)]
fix #5686: remove a overstrict assert in MakeAllreduce (#5686) (#5785)
Zhi [Fri, 12 Jun 2020 15:20:57 +0000 (08:20 -0700)]
[DOC][FIX] Fix some typos in git-clang-format.sh (#5786)
Yao Wang [Fri, 12 Jun 2020 05:54:23 +0000 (22:54 -0700)]
[Frontend][TensorFlow] Improve Control Flow and TensorArray (#5699)
* Improve TF parser control flow and tensor array
* Fix tf tensor array scatter
* Add ssd test
* Add back static ta test
* Minor fix for frontend and test_forward
* SplitRel for dynamic shape
* Fix test ssd
* Fix loop var naming issue
* Minor improve
* Fix format
* Fix clang format
* Fix tensor array in pytorch frontend
* Fix stack size issue for ssd test
* Address comments
* Fix slice size
* Fix build
* Rebase
Tianqi Chen [Thu, 11 Jun 2020 23:35:43 +0000 (16:35 -0700)]
[TIR][REFACTOR][API-Change] Migrate tir/stmt.h to use constructor. (#5778)
This PR migrate tvm/tir/stmt.h to the new constructor style that is
consistent with the rest of the codebase and changes the affected files accordingly.
Tianqi Chen [Thu, 11 Jun 2020 18:36:01 +0000 (11:36 -0700)]
[TIR][REFACTOR][API-Change] Migrate the tvm/tir/expr.h to construct style. (#5773)
This PR migrate tvm/tir/expr.h to the new constructor style that is
consistent with the rest of the codebase and changes the affected files accordingly.
Thomas Viehmann [Thu, 11 Jun 2020 16:38:46 +0000 (18:38 +0200)]
Make batch matrix multiplication on GPU tunable (#5752)
This is primarily aimed at the AMD GPU backend and done as part
of a project for AMD, but should work for all users of the GPU
schedule.
Matthew Brookhart [Thu, 11 Jun 2020 14:25:09 +0000 (07:25 -0700)]
Add ShapePattern and DataTypePattern (#5760)
Thomas Viehmann [Thu, 11 Jun 2020 12:10:27 +0000 (14:10 +0200)]
Fix gelu in PyTorch frontend, tighten numerical checks (#5763)
Previously, the PyTorch frontend approximated gelu with fastgelu.
To provide a more faithful conversion, we implement gelu instead.
We also tighten the numerical comparisons between PyTorch and
TVM-from-PyTorch to 1e-5. The object detection models need an
increased tolerance of 1e-4 to pass.
I had to throw in a few fixes for missing conversions
(probably due to working with very new PyTorch).
I must admit the GoogLeNet/NasNet test didn't run on my machine,
probably due to problems at my end.
Samuel [Thu, 11 Jun 2020 09:12:35 +0000 (14:42 +0530)]
[TOPI][RELAY][PYTORCH]Conv3d_transpose op support added (#5737)
* [TOPI][RELAY][PYTORCH]Conv3d_transpose op support added
* Test cases in topi/relay
* conv3d_transpose_ncdhw_python added
* Review comments fixed
Haichen Shen [Thu, 11 Jun 2020 03:49:57 +0000 (20:49 -0700)]
[Relay] Fix for recursive let (#5757)
* Make let processing iterative
* Try again
* Fix pretty printer overflow
* cleanup
* fix lint
* Fix text printer
Co-authored-by: Jared Roesch <roeschinc@gmail.com>
Co-authored-by: Jared Roesch <jroesch@octoml.ai>
Zijing Gu [Wed, 10 Jun 2020 17:07:36 +0000 (13:07 -0400)]
[topi] block sparse dense on cuda (#5746)
Jared Roesch [Wed, 10 Jun 2020 09:07:19 +0000 (02:07 -0700)]
[Rust] Second stage of Rust Refactor (#5527)
* Add tvm-rt crate
* Backport changes from frontend branch
* Format
* Add ASF headers
* Address self-code review
* Replace with helper
* Fix lint
* Fix
* Clean up repro debugging
* WIP
* Remove global resgistry to fix one memory issue
* Fix
* Format
* Format
* Update rust/tvm-rt/README.md
Co-authored-by: Jason Knight <binarybana@gmail.com>
* Format
* Duplicate TVM macros
* Split macros
* Restore old macro for old crates
* Repair macros
* Fix format
* Format
Co-authored-by: Jason Knight <binarybana@gmail.com>
Tianqi Chen [Wed, 10 Jun 2020 05:28:52 +0000 (22:28 -0700)]
[REFACTOR][TIR] Provide->ProducerStore, Realize->ProducerRealize. (#5750)
This PR finishes up the final step for DSL/TIR de-coupling to refactor
Provide/Realize to use the DataProducer.
As in the case of ProducerLoad, ProducerStore/Realize are not supposed
to appear in a vaid TIR function ans are only used by high-level DSLs
as intermediate structures.
Cody Yu [Wed, 10 Jun 2020 05:03:09 +0000 (22:03 -0700)]
[Bugfix] Fix reshape (#5739)
* Fix reshape
* fix doc warning
* fix ci
* address comments
Junru Shao [Wed, 10 Jun 2020 00:32:38 +0000 (17:32 -0700)]
[Minor][Test] Clean WASM environment before build (#5759)
Matthew Brookhart [Tue, 9 Jun 2020 22:33:57 +0000 (15:33 -0700)]
Add Scatter to Topi/Relay/ONNX via hybrid script (#5619)
* I can construct scatter but not embed it in a Relay Graph
* working 1-4 dimesion scatter
* add scatter to ONNX
fix lint
* isolate tests to cpu backend
* Fix i386 test
* fix gpu tolerance
* use elemwise_shape_func for scatter
* fix incorrect rebase
Yong Wu [Tue, 9 Jun 2020 16:48:33 +0000 (00:48 +0800)]
[TOPI][Relay][OP] support dynamic NMS(Non Maximum Suppression), symbolic begin, end, and strides for strided_slice (#4312)
* [TOPI][Relay][OP] Dynamic NMS and strided_slice
* Incorporate comments
* fix nnvm compatibility issues
* fix InferCorrectLayout
* Minor fix
* fix for fuse
* Workaround to pass batch_size into hybrid function to handle dynamic shape
* Seperate rearrange
* fix lint
* fix ci, comments
* change attr to Optional<T>
* clang format
* remove empty lines
* partial ignore for end of strided_slice
* pylint
* add out_indices for gpu get_valid_counts
* change to slice_mode
* clang-format, fix comments
* fix comment
* change slice_mode to string
* fix CI
* update docstring
Co-authored-by: Yao Wang <kevinthesunwy@gmail.com>
xqdan [Tue, 9 Jun 2020 15:34:27 +0000 (23:34 +0800)]
[ARITH][BACKPORT-0.6] fix a min/max simplify bug (#5749)
* fix a min/max simplify bug
* fix cpplint
* turn into oposite when c1val<0 and add more case
* fix c1=0
Co-authored-by: xqdan <danxiaoqiang@huawei.com>
Trevor Morris [Mon, 8 Jun 2020 23:43:28 +0000 (16:43 -0700)]
Don't add cast for TF batch norm when type isn't changing (#5731)
Tianqi Chen [Sun, 7 Jun 2020 21:11:05 +0000 (14:11 -0700)]
[REFACTOR][TE][TIR] Call::Halide => ProducerLoad, DSL/TIR decouple. (#5743)
In the HalideIR's design, DSL components and IR are mixed together.
For example, Call::Halide can containa reference to a function which is
constructed in the tensor expression language.
While this coupled design simplifies certain aspect of the DSL construction,
it prevents the TIR to evolve as a clean standalone IR:
- The additional tensor expression provided in the function is opaque to the IR
and may become obsolete as we transform them.
- The duplication of the information in the DSL tensor and IR makes it hard to
design a stand-alone text format (when there are elements shared in the tensor
expression and normal statements).
This PR aims to clearly de-couple the TIR from high-level DSL structures(tensor expression),
while still provide clear extensions to build DSLs on top of the TIR.
We introduce a DataProducer as a base class for high level tensor expressions objects
that produce data. We then introduce ProducerLoad to replace the Call::Halide usage,
so that the Call node can always be self contained and used for low-level calls.
The high-level tensor expression DSL can still generate a PrimExpr that contains a ProducerLoad.
These PrimExprs contains fragments of information that can be combined together to
generate a low-level TIR PrimFunc.
We also state clearly that DataProducer **should not** appear in any TIR PrimFunc.
Instead, the high-level DSL layer should lowered DataProducers to Buffers and TIR statements
that produces these buffers. We can further provide verifications to validate such invariance.
Changes:
- Introduce DataProducer to serve as a base class for Tensor in tensor expressions.
- Migrate use of Call::Halide to ProducerLoad
- Migrate the other usages of Calls.
We will also create follow-up PRs to migrate the remaining two DSL related IR nodes(Realize/Provide)
to use the DataProducer.
Zhi [Sun, 7 Jun 2020 19:41:23 +0000 (12:41 -0700)]
sequential cpp test (#5745)
Junru Shao [Sat, 6 Jun 2020 22:23:20 +0000 (15:23 -0700)]
Add some docs on downstream consistency (#5742)
https://github.com/apache/incubator-tvm/pull/5730#issuecomment-
639567636
Tianqi Chen [Sat, 6 Jun 2020 20:23:31 +0000 (13:23 -0700)]
[REFACTOR][ARITH] Remove legacy compute_expr.h (#5738)
Replaces most of the ComptuteReduce using foldl.
handar423 [Sat, 6 Jun 2020 03:40:17 +0000 (11:40 +0800)]
fix small bug about dense_grad (#5695)
abergeron [Fri, 5 Jun 2020 21:17:41 +0000 (17:17 -0400)]
Fix the values for test_fmod since it fails way too often otherwise (#5723)
Tianqi Chen [Fri, 5 Jun 2020 19:13:17 +0000 (12:13 -0700)]
[TEST] Fix flaky topi/tests/python/test_topi_pooling.py:test_adaptive_pool (#5736)
Cody Yu [Fri, 5 Jun 2020 17:27:57 +0000 (10:27 -0700)]
Fix reshape usage in ARM Winograd (#5732)
akosik-anyvision [Fri, 5 Jun 2020 15:39:20 +0000 (11:39 -0400)]
Change 'delete's in Relay VM Instruction dtor to 'delete[]'s (#5735)
Thomas Viehmann [Fri, 5 Jun 2020 09:49:37 +0000 (11:49 +0200)]
ROCm: Add warp shuffles and enable reductions (#5727)
Thank you @masahi and @wpan11nv for the feedback
Samuel [Fri, 5 Jun 2020 05:48:44 +0000 (11:18 +0530)]
[ONNX]MaxRoiPool, Mod & Xor op support added (#5729)
Tianqi Chen [Thu, 4 Jun 2020 22:04:17 +0000 (15:04 -0700)]
[REFACTOR] Separate ArgTypeCode from DLDataTypeCode (#5730)
We use a single enum(TypeCode) to represent ArgTypeCode and DLDataTypeCode.
However, as we start to expand more data types, it is clear that argument
type code(in the FFI convention) and data type code needs to evolve separately.
So that we can add first class for data types without having changing the FFI ABI.
This PR makes the distinction clear and refactored the code to separate the two.
- [PY] Separate ArgTypeCode from DataTypeCode
- [WEB] Separate ArgTypeCode from DataTypeCode
- [JAVA] Separate ArgTypeCode from DataTypeCode
Dhruva Ray [Thu, 4 Jun 2020 17:55:38 +0000 (23:25 +0530)]
[Frontend][TFLite] Add parser support for shape and range (#5329)
* [Relay][Frontend][TFLite] Add parser support for shape and range
Signed-off-by: Dhruva Ray <dhruvaray@gmail.com>
* Incorporated review comments and used new functions
Signed-off-by: Dhruva Ray <dhruvaray@gmail.com>
* Few cosmetic changes
Signed-off-by: Dhruva Ray <dhruvaray@gmail.com>
* Removed an extra line added by rebase...
Signed-off-by: Dhruva Ray <dhruvaray@gmail.com>
Dhruva Ray [Thu, 4 Jun 2020 17:54:56 +0000 (23:24 +0530)]
[TOPI,RELAY][TFLITE] Sparse to dense operator (#5447)
* [Relay][Frontend][TFLite] Add parser support for shape and range
Signed-off-by: Dhruva Ray <dhruvaray@gmail.com>
* [TOPI,RELAY][TFLITE] Sparse to dense operator
Signed-off-by: Dhruva Ray <dhruvaray@gmail.com>
* use param name in documentation
Signed-off-by: Dhruva Ray <dhruvaray@gmail.com>
* sphinx doc errors fixed
Signed-off-by: Dhruva Ray <dhruvaray@gmail.com>
* incorporated review comments
Signed-off-by: Dhruva Ray <dhruvaray@gmail.com>
* Missing a blank line...
Signed-off-by: Dhruva Ray <dhruvaray@gmail.com>
* use get_tensor_expr
Signed-off-by: Dhruva Ray <dhruvaray@gmail.com>
* Accidently removed this function in the rebase...
Signed-off-by: Dhruva Ray <dhruvaray@gmail.com>
* support default value for default_value
Signed-off-by: Dhruva Ray <dhruvaray@gmail.com>
* clang format fixes
Signed-off-by: Dhruva Ray <dhruvaray@gmail.com>
* topi pylint fixes
Signed-off-by: Dhruva Ray <dhruvaray@gmail.com>
Thomas Viehmann [Thu, 4 Jun 2020 15:46:55 +0000 (17:46 +0200)]
codegen llvm: move nvptx-specific intrinsic handling into codegen_nvptx (#5726)
See discussion in #5600.
I'm also throwing in a pointer lifetime fix for the context held by
NVPTX because otherwise topi/tests/python/test_topi_softmax.py
would sefault for me. With the test, I can also run resnet-18 on
the nvptx target in gpu_imagenet_bench.py.
Junru Shao [Thu, 4 Jun 2020 15:29:03 +0000 (08:29 -0700)]
Fix runtime::String backward compatibility in JSON (#5725)
Wuwei Lin [Thu, 4 Jun 2020 06:47:04 +0000 (02:47 -0400)]
[AutoTVM, Relay] Clear compile engine after task extraction (#5724)