Jes Sorensen [Fri, 16 May 2014 08:04:07 +0000 (10:04 +0200)]
staging: rtl8723au: Disentangle chip_configure from HAL wrappers
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Fri, 16 May 2014 08:04:06 +0000 (10:04 +0200)]
staging: rtl8723au: We love wrappers!
Get rid of pointless wrapper around a simple kfree()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Fri, 16 May 2014 08:04:05 +0000 (10:04 +0200)]
staging: rtl8723au: Remove HAL wrappers about USB init/deinit
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Fri, 16 May 2014 08:04:04 +0000 (10:04 +0200)]
staging: rtl8723au: Remove HAL wrappers around read_chip_version
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Fri, 16 May 2014 08:04:03 +0000 (10:04 +0200)]
staging: rtl8723au: Remove unused HAL wrappers around PHY register read/write calls
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Fri, 16 May 2014 08:04:02 +0000 (10:04 +0200)]
staging: rtl8723au: Remove HAL notch_filter wrappers
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Fri, 16 May 2014 08:04:01 +0000 (10:04 +0200)]
staging: rtl8723au: Remove unused hal_reset_security_engine code
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Fri, 16 May 2014 08:04:00 +0000 (10:04 +0200)]
staging: rtl8723au: Get rid of sreset related HAL clutter
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Fri, 16 May 2014 08:03:59 +0000 (10:03 +0200)]
staging: rtl8723au: Get rid of rtw_hal_dm_* clutter
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Fri, 16 May 2014 08:03:58 +0000 (10:03 +0200)]
staging: rtl8723au: Remove some more HAL clutter
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Fri, 16 May 2014 08:03:57 +0000 (10:03 +0200)]
staging: rtl8723au: Call rtl8723a_init_default_value_directly()
We really don't need two layers of silly indirection to call this
function.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Fri, 16 May 2014 08:03:56 +0000 (10:03 +0200)]
staging: rtl8723au: Remove unused hal_data_sz from struct rtw_adapter
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Fri, 16 May 2014 08:03:55 +0000 (10:03 +0200)]
staging: rtl8723au: Remove unused rtl8723a_clone_haldata()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Fri, 16 May 2014 08:03:54 +0000 (10:03 +0200)]
staging: rtl8723au: Remove unused bBTFWReady from struct rtw_adapter
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Fri, 16 May 2014 08:03:53 +0000 (10:03 +0200)]
staging: rtl8723au: osdep_service.h: Reduce excessive header inclusion
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Fri, 16 May 2014 08:03:52 +0000 (10:03 +0200)]
staging: rtl8723au: Remove obsolete BITx #defines
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Fri, 16 May 2014 08:03:51 +0000 (10:03 +0200)]
staging: rtl8723au: odm_HWConfig.c: Use BIT() consistently
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Fri, 16 May 2014 08:03:50 +0000 (10:03 +0200)]
staging: rtl8723au: odm.c: Use BIT() instead of BITx
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Fri, 16 May 2014 08:03:49 +0000 (10:03 +0200)]
staging: rtl8723au: rtl8723a_hal_init.c: Use BIT() consistently
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Fri, 16 May 2014 08:03:48 +0000 (10:03 +0200)]
staging: rtl8723au: rtl8723a_phycfg.c: Use BIT() instead of BITx
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Fri, 16 May 2014 08:03:47 +0000 (10:03 +0200)]
staging: rtl8723au: HalDMOutSrt8723A_CE.c: Use BIT() instead of BITx
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Fri, 16 May 2014 08:03:46 +0000 (10:03 +0200)]
staging: rtl8723au: hal_com.c: Use BIT() consistently instead of BITx
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Fri, 16 May 2014 08:03:45 +0000 (10:03 +0200)]
staging: rtl8723au: rtl8723a_bt-coexist.c: Be consistent in use of BIT()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Fri, 16 May 2014 08:03:44 +0000 (10:03 +0200)]
staging: rtl8723au: usb_halinit.c: Use BIT() instead of BITx
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Fri, 16 May 2014 08:03:43 +0000 (10:03 +0200)]
staging: rtl8723au: rtl8723au_led.c: Use BIT() instead of BITx
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Fri, 16 May 2014 08:03:42 +0000 (10:03 +0200)]
staging: rtl8723au: rtw_sreset.h: Use BIT() instead of BITx
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Fri, 16 May 2014 08:03:41 +0000 (10:03 +0200)]
staging: rtl8723au: odm_reg.h: Use BIT() instead of BITx
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Fri, 16 May 2014 08:03:40 +0000 (10:03 +0200)]
staging: rtl8723au: odm_debug.h: Use BIT() instead of BITx
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Fri, 16 May 2014 08:03:39 +0000 (10:03 +0200)]
staging: rtl8723au: odm.h: Use BIT() instead of BITx
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Fri, 16 May 2014 08:03:38 +0000 (10:03 +0200)]
staging: rtl8723au: hal_intf.h: Be consistent and use BIT() instead of BITx
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Fri, 16 May 2014 08:03:37 +0000 (10:03 +0200)]
staging: rtl8723au: Hal8723PwrSeq.h: Use BIT() instead of BITx
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Fri, 16 May 2014 08:03:36 +0000 (10:03 +0200)]
staging: rtl8723au: Hal8723APhyCfg.h: Use BIT() instead of BITx
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Fri, 16 May 2014 08:03:35 +0000 (10:03 +0200)]
staging: rtl8723au: rtl8723a_bt-coexist.h: Be consistent and use BIT()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Fri, 16 May 2014 08:03:34 +0000 (10:03 +0200)]
staging: rtl8723au: rtl8723a_spec.h: Use BIT() instead of BITx macros
Be consistent and stick to BIT()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Octavian Purdila [Fri, 16 May 2014 05:24:59 +0000 (08:24 +0300)]
goldfish: pipe: fix warnings for 32bit builds
drivers/platform/goldfish/goldfish_pipe.c: In function 'goldfish_cmd_status':
drivers/platform/goldfish/goldfish_pipe.c:164:14: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
writel((u32)(u64)pipe, dev->base + PIPE_REG_CHANNEL);
^
drivers/platform/goldfish/goldfish_pipe.c: In function 'goldfish_cmd':
drivers/platform/goldfish/goldfish_pipe.c:180:14: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
writel((u32)(u64)pipe, dev->base + PIPE_REG_CHANNEL);
^
drivers/platform/goldfish/goldfish_pipe.c: In function 'goldfish_pipe_read_write':
drivers/platform/goldfish/goldfish_pipe.c:337:16: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
writel((u32)(u64)pipe, dev->base + PIPE_REG_CHANNEL);
Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Cc: Jun Tian <jun.j.tian@intel.com>
Acked-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Octavian Purdila <octavian.purdila@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Octavian Purdila [Fri, 16 May 2014 05:24:58 +0000 (08:24 +0300)]
goldfish: bus: fix warnings for 32bit builds
drivers/platform/goldfish/pdev_bus.c: In function 'goldfish_new_pdev':
drivers/platform/goldfish/pdev_bus.c:136:14: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
writel((u32)(u64)name, pdev_bus_base + PDEV_BUS_GET_NAME);
Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Cc: Jun Tian <jun.j.tian@intel.com>
Acked-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Octavian Purdila <octavian.purdila@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Geert Uytterhoeven [Sun, 6 Apr 2014 13:37:25 +0000 (15:37 +0200)]
staging: rts5139: Make variables inside #ifdef CONFIG_PM
If CONFIG_PM=n:
drivers/staging/rts5139/rts51x_transport.c:649: warning: ‘media_not_present’ defined but not used
drivers/staging/rts5139/rts51x_transport.c:651: warning: ‘invalid_cmd_field’ defined but not used
Move the variables inside the #ifdef CONFIG_PM, and make them const while
we're at it.
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Neil Armstrong [Fri, 11 Apr 2014 12:58:58 +0000 (14:58 +0200)]
staging: rts5139: fix bad symbol declaration
With sparse, the following error appears :
CHECK drivers/staging/rts5139/ms_mg.c
drivers/staging/rts5139/ms_mg.c:82:5: warning: symbol 'mg_set_tpc_para_sub' was not declared. Should it be static?
Rename function with correct prefix and move declaration to coherent internal header file.
Signed-off-by: Neil 'Superna' Armstrong <superna9999@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Thomas Tanaka [Thu, 17 Apr 2014 04:05:09 +0000 (21:05 -0700)]
staging: rts5139: fixed coding style
Fixed checkpatch warnings > 80 lines
Signed-off-by: Thomas Tanaka <thomas.tanaka@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Fabio Falzoi [Tue, 22 Apr 2014 21:23:04 +0000 (23:23 +0200)]
Staging: rts5139: More appropriate use of sizeof operand
Use the pointer rts51x to get the size of the struct.
Signed-off-by: Fabio Falzoi <fabio.falzoi84@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Fabio Falzoi [Tue, 22 Apr 2014 21:23:03 +0000 (23:23 +0200)]
Staging: rts5139: Removed OOM messages
All allocation Out Of Memory messages removed.
We rely on the generic OOM message in dump_stack().
Signed-off-by: Fabio Falzoi <fabio.falzoi84@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Fabio Falzoi [Tue, 22 Apr 2014 21:23:02 +0000 (23:23 +0200)]
Staging: rts5139: Use standard pr_<level> prefixing
Define pr_fmt macro to prefix every pr_<level> function in standard way.
Signed-off-by: Fabio Falzoi <fabio.falzoi84@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Fabio Falzoi [Tue, 22 Apr 2014 21:23:01 +0000 (23:23 +0200)]
Staging: rts5139: Splitted one-line multiple assignment
Splitted a multiple assignment on two separate lines.
Signed-off-by: Fabio Falzoi <fabio.falzoi84@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Fabio Falzoi [Tue, 22 Apr 2014 21:23:00 +0000 (23:23 +0200)]
Staging: rts5139: Fixed multi-line code alignment
Multi-line code aligned with open parenthesis.
Signed-off-by: Fabio Falzoi <fabio.falzoi84@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Fabio Falzoi [Tue, 22 Apr 2014 21:22:59 +0000 (23:22 +0200)]
Staging: rts5139: Camel case labels replaced
Replace camel case labels with linux coding style compliant names.
Signed-off-by: Fabio Falzoi <fabio.falzoi84@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Camille Bordignon [Sun, 6 Apr 2014 16:21:27 +0000 (18:21 +0200)]
staging: sep: Fix coding style
Fix coding style warning "Missing a blank line after declarations"
Signed-off-by: Camille Bordignon <camille.bordignon@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Thu, 15 May 2014 21:49:24 +0000 (22:49 +0100)]
staging: vt6656: Remove PIPEnsControlOutAsyn/CONTROLnsRequestOutAsyn
This now the same as PIPEnsControlOut.
Replace with PIPEnsControlOut/CONTROLnsRequestOut.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Thu, 15 May 2014 21:49:23 +0000 (22:49 +0100)]
staging: vt6656: PIPEnsControlIn use usb_control_msg
Now that this function is nolonger atomic useusb_control_msg.
Return STATUS_FAILURE if ntStatus less than wLength
Remove the old struct urb and struct usb_ctrlrequest structures.
Remove fMP_CONTROL_READS flag.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Thu, 15 May 2014 21:49:22 +0000 (22:49 +0100)]
staging: vt6656: usbpipe.c PIPEnsControlOut use usb_control_msg
Now that this fucntion is nolonger atomic change to usb_control_msg
Return STATUS_FAILURE if ntStatus less than wLength.
Remove fMP_CONTROL_WRITES flag
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Thu, 15 May 2014 21:49:21 +0000 (22:49 +0100)]
staging: vt6656: lock changes device_xmit
Replace locks with the spin_lock_irqsave and spin_unlock_irqrestore
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Thu, 15 May 2014 21:49:20 +0000 (22:49 +0100)]
staging: vt6656: lock changes: s_nsBulkInUsbIoCompleteRead.
Use spin_lock_irqsave/spin_unlock_irqrestore
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Thu, 15 May 2014 21:49:19 +0000 (22:49 +0100)]
staging: vt6656: lock changes: usbpipe.c add mutex lock.
PIPEnsControlOut and PIPEnsControlIn are nolonger
atomic but they do need a usb lock.
Add new mutex lock for these functions and PIPEnsControlOutAsyn.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Thu, 15 May 2014 21:49:18 +0000 (22:49 +0100)]
staging: vt6656: lock changes: vRunCommand nsDMA_tx_packet
vRunCommand is nolonger atomic add lock for nsDMA_tx_packet.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Thu, 15 May 2014 21:49:17 +0000 (22:49 +0100)]
staging: vt6656: lock changes: bMgrPrepareBeaconToSend add lock.
bMgrPrepareBeaconToSend is nolonger atomic
csBeacon_xmit must be locked add spin lock.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Thu, 15 May 2014 21:49:16 +0000 (22:49 +0100)]
staging: vt6656: lock changes: vDMA0_tx_80211
vDMA0_tx_80211 is atomically called.
RFbSetPower can not be called atomically.
If wCurrentRate is different to pDevice->wCurrentRate call
bScheduleCommand WLAN_CMD_SETPOWER.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Thu, 15 May 2014 21:49:15 +0000 (22:49 +0100)]
staging: vt6656: lock changes: csMgmt_xmit.
csMgmt_xmit is nolonger atomically called but part of must be.
Reorder the function so that RFbSetPower is called first.
Add new lock spinlock for the remainder of the function.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Thu, 15 May 2014 21:49:14 +0000 (22:49 +0100)]
staging: vt6656: lock changes: RXvMngWorkItem.
Narrow atomic locks in RXvMngWorkItem.
We must lock the DequeueRCB and RXvFreeRCB so that
they are in sync.
vMgrRxManagePacket can nolonger be atomically called.
There is no need for an overall lock.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Thu, 15 May 2014 21:49:13 +0000 (22:49 +0100)]
staging: vt6656: lock changes: vRunCommand remove locks.
Removing atomic locked paths to usbpipe.c PIPEnsControlOut and PIPEnsControlIn
This function will nolonger need any locking.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Thu, 15 May 2014 21:49:12 +0000 (22:49 +0100)]
staging: vt6656: lock changes: Remove spin locks.
Remove atomic paths to usbpipe.c PIPEnsControlOut and PIPEnsControlIn
Remove from
PIPEnsControlOut
PIPEnsControlIn
BSSvSecondCallBack
vt6656_hostap_ioctl
iwctl_siwmode
iwctl_siwencode
iwctl_siwpower
iwctl_siwencodeext
KeyvInitTable
device_init_registers
device_open
device_close
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Thu, 15 May 2014 21:49:11 +0000 (22:49 +0100)]
staging: vt6656: struct vnt_usb_send_context remove camel case.
Camel case changes
pDevice -> priv
pPacket -> skb
pUrb -> urb
uBufLen -> buf_len;
bBoolInUse -> in_use
Data -> data
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Thu, 15 May 2014 21:49:10 +0000 (22:49 +0100)]
staging: vt6656: nsDMA_tx_packet Move pContext later.
call s_vGetFreeContext later in function skiping large
chunk of code.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Denis Pithon [Mon, 12 May 2014 15:22:46 +0000 (17:22 +0200)]
staging/wlan-ng: code refactoring
Extract new static function from p80211netdev_rx_bh() to fix coding
style issue (too many leading tabs).
Signed-off-by: Denis Pithon <denis.pithon@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Denis Pithon [Mon, 12 May 2014 15:22:45 +0000 (17:22 +0200)]
staging/wlan-ng: remove function declaration
Removed useless function prototype: static function p80211netdev_rx_bh()
is defined before being used.
Signed-off-by: Denis Pithon <denis.pithon@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Denis Pithon [Mon, 12 May 2014 15:22:44 +0000 (17:22 +0200)]
staging/wlan-ng: update function header comment
Header comment of p80211netdev_rx_bh() does not match function
prototype. Fixed.
Signed-off-by: Denis Pithon <denis.pithon@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Neil Armstrong [Fri, 11 Apr 2014 13:00:49 +0000 (15:00 +0200)]
staging: wlan-ng: fix bad symbol declaration
With sparse, the following error appears :
CHECK drivers/staging/wlan-ng/p80211netdev.c
drivers/staging/wlan-ng/cfg80211.c:710:6: warning: symbol 'prism2_connect_result' was not declared. Should it be static?
drivers/staging/wlan-ng/cfg80211.c:719:6: warning: symbol 'prism2_disconnected' was not declared. Should it be static?
drivers/staging/wlan-ng/cfg80211.c:725:6: warning: symbol 'prism2_roamed' was not declared. Should it be static?
Move functions declaration to coherent internal header file.
Signed-off-by: Neil 'Superna' Armstrong <superna9999@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sherif Shehab Aldin [Sat, 5 Apr 2014 21:35:15 +0000 (23:35 +0200)]
driver: staging: wlan-ng: Removed unnecessary spaces after cast from hfa384x_usb.c
Fixed: No space is necessary after a cast
Signed-off-by: Sherif Shehab Aldin <shehabaldin.sherif@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sherif Shehab Aldin [Sat, 5 Apr 2014 21:35:06 +0000 (23:35 +0200)]
driver: staging: wlan-ng: Removed #if 0 lines from hfa384x_usb.c
Removed lines that were ignored by #if 0
Signed-off-by: Sherif Shehab Aldin <shehabaldin.sherif@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sherif Shehab Aldin [Sat, 5 Apr 2014 21:34:56 +0000 (23:34 +0200)]
driver: staging: wlan-ng: Removed multiple assignments
Removed multiple assignments from hfa384x_usb.c
Signed-off-by: Sherif Shehab Aldin <shehabaldin.sherif@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sherif Shehab Aldin [Sat, 5 Apr 2014 21:34:48 +0000 (23:34 +0200)]
driver: staging: wlan-ng: Fixed white spaces issues
In hfa384x_usb.c:
Moved Logical continuations to the correct lines
Removed unnecessary blank lines
Signed-off-by: Sherif Shehab Aldin <shehabaldin.sherif@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sherif Shehab Aldin [Sat, 5 Apr 2014 21:34:40 +0000 (23:34 +0200)]
driver: staging: wlan-ng: Fixed Alignment to match open parenthesis
Fixed Alignment to match open parenthesis in hfa384x_usb.c
Signed-off-by: Sherif Shehab Aldin <shehabaldin.sherif@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sherif Shehab Aldin [Sat, 5 Apr 2014 21:34:12 +0000 (23:34 +0200)]
driver: staging: wlan-ng: Removed Unnecessary space after function pointer name
Removed Unnecessary space after function pointer name
Signed-off-by: Sherif Shehab Aldin <shehabaldin.sherif@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sherif Shehab Aldin [Sat, 5 Apr 2014 21:34:01 +0000 (23:34 +0200)]
driver: staging: wlan-ng: Setting character pointers as const
changed declaration of ctlx_str to:
static const char * const ctlx_str[]
Signed-off-by: Sherif Shehab Aldin <shehabaldin.sherif@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sherif Shehab Aldin [Sat, 5 Apr 2014 21:33:53 +0000 (23:33 +0200)]
driver: staging: wlan-ng: switched to pr_warn
changed printk(KERN_WARNING .. to pr_warn
Signed-off-by: Sherif Shehab Aldin <shehabaldin.sherif@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sherif Shehab Aldin [Sat, 5 Apr 2014 21:33:45 +0000 (23:33 +0200)]
driver: staging: wlan-ng: Removed unnecessary typedefs from hfa384x_usb.c
Removed unnecessary typedefs from hfa384x_usb.c
Signed-off-by: Sherif Shehab Aldin <shehabaldin.sherif@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sherif Shehab Aldin [Sat, 5 Apr 2014 21:33:16 +0000 (23:33 +0200)]
driver: staging: wlan-ng: Fixed Breaking long lines and strings style rule
Fixed coding style rule "Breaking long lines and strings" for hfa384x_usb.c
Signed-off-by: Sherif Shehab Aldin <shehabaldin.sherif@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Micky Ching [Wed, 2 Apr 2014 09:58:52 +0000 (17:58 +0800)]
staging: rts5208: fix static checker warnings
The patch
fa590c222fba: "staging: rts5208: add support for rts5208
and rts5288" from Nov 12, 2013, leads to the following static checker
warning:
drivers/staging/rts5208/rtsx_chip.c:107 rtsx_enable_bus_int()
warn: add curly braces?
This warning is produced because incorrect code indent.
Signed-off-by: Micky Ching <micky_ching@realsil.com.cn>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Rocco Folino [Wed, 2 Apr 2014 22:47:46 +0000 (00:47 +0200)]
staging: gs_fpgaboot: Fixed code style issues
Fixed missing a blank line after declarations warning
Signed-off-by: Rocco Folino <lordzen87@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jerry Snitselaar [Thu, 24 Apr 2014 07:31:48 +0000 (00:31 -0700)]
staging/line6: blank line after declaration cleanup
Fix coding style warnings reported by checkpath.
Signed-off-by: Jerry Snitselaar <dev@snitselaar.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Artem Fetishev [Sun, 11 May 2014 18:14:30 +0000 (21:14 +0300)]
drivers: staging: ft1000: Fix lines over 80 characters
..plus some function arg indentation which I haven't noticed at first.
Signed-off-by: Artem Fetishev <wwctrsrx@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Artem Fetishev [Sun, 11 May 2014 18:14:29 +0000 (21:14 +0300)]
drivers: staging: ft1000: Remove typedefs
Remove typedefs according to the "Chapter 5: Typedefs" from
Documentation/CodingStyle.
Signed-off-by: Artem Fetishev <wwctrsrx@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Artem Fetishev [Sun, 11 May 2014 18:14:28 +0000 (21:14 +0300)]
drivers: staging: ft1000: Use pr_info instead of printk
Improve coding style by fixing this checkstyle warning:
WARNING: Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO ...
Signed-off-by: Artem Fetishev <wwctrsrx@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Artem Fetishev [Sun, 11 May 2014 18:14:27 +0000 (21:14 +0300)]
drivers: staging: ft1000: Fix IOCTL_FT1000_* marcos
Fixes include:
- Add closing brackets;
- Remove sizeof (_IOR and _IOW macro can accept types);
- Replace _IOW which size of 0 (the last arg) with _IO.
- Actually these macros are not used anywhere and might be removed.
Signed-off-by: Artem Fetishev <wwctrsrx@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Artem Fetishev [Sun, 11 May 2014 18:14:26 +0000 (21:14 +0300)]
drivers: staging: ft1000: Fix indentation
Fixes indentation in header files.
Signed-off-by: Artem Fetishev <wwctrsrx@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Angus Gibson [Mon, 7 Apr 2014 02:29:30 +0000 (12:29 +1000)]
staging: ft1000: remove explicit static initialisation
Fix checkpatch.pl error where a static variable was explicitly
initialised to false
Signed-off-by: Angus Gibson <darthshrine@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Paul McQuade [Thu, 3 Apr 2014 16:21:22 +0000 (17:21 +0100)]
Staging:ft1000_debug.c:Renaming __FUNCTION__
__Function__ gets renamed with __func__
Signed-off-by: Paul McQuade <paulmcquad@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Anders Darander [Tue, 1 Apr 2014 06:29:40 +0000 (08:29 +0200)]
Staging: ft1000-usb: use netdev_warn
Fix coding style issue by replacing printk with netdev_warn.
Signed-off-by: Anders Darander <anders.darander@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Anders Darander [Tue, 1 Apr 2014 06:29:39 +0000 (08:29 +0200)]
Staging: ft1000-usb: wrap macros in do while
Fix coding style issue by wrapping the macro in a do {} while (0).
Signed-off-by: Anders Darander <anders.darander@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Dan Carpenter [Wed, 14 May 2014 16:13:07 +0000 (19:13 +0300)]
staging: dgnc: UART_IIR_XOFF code is buggy
The UART_IIR_XOFF was supposed to be a no-op but, because there was a
missing semi-colon, the if statement is not "Empty". I have just deleted
this code because it was supposed to be a no-op anyway. UART_IIR_XOFF
is a standard define and not something specific to this driver.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Martin Kepplinger [Tue, 29 Apr 2014 09:43:08 +0000 (11:43 +0200)]
staging: dgnc: use dev_err() instead of printk()
Use dev_err() insted of printk() in order to provice userspace with
more useful information and use the common kernel coding style.
Signed-off-by: Martin Kepplinger <martink@posteo.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Vitaly Osipov [Sat, 26 Apr 2014 14:59:17 +0000 (00:59 +1000)]
staging: dgnc: redundant NULL checks before kfree()
Removed redundant NULL checks before calling kfree()
Signed-off-by: Vitaly Osipov <vitaly.osipov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Son P. Nguyen [Sun, 20 Apr 2014 18:05:39 +0000 (18:05 +0000)]
Staging: dgnc: dgnc_driver: fixed incorrect braces
Fixed incorrect braces (coding style)
Signed-off-by: Son P. Nguyen <fastmutex@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Antoine Sirinelli [Thu, 27 Mar 2014 21:31:55 +0000 (22:31 +0100)]
staging: dgnc: cleanup dgnc_finalize_board_init()
Trivial cleanups:
- Transform a printk() to a dev_err() call
- Fix 2 lines over 80 characters
Signed-off-by: Antoine Sirinelli <antoine@monte-stello.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Hounschell [Fri, 25 Apr 2014 18:32:15 +0000 (14:32 -0400)]
staging: dgap: Add Mark Hounschell to maintainers list for dgap
Add Mark Hounschell to the MAINTAINERs list for the dgap driver
Signed-off-by: Mark Hounschell <markh@compro.net>
Suggested-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Christian Engelmayer [Wed, 7 May 2014 19:43:37 +0000 (21:43 +0200)]
staging: vt6656: fix potential leak in vt6656_hostap_ioctl()
Commit
fb841d67 (staging: vt6656: don't leak 'param' in vt6656_hostap_ioctl()
when returning -EOPNOTSUPP) cleaned up direct returns in the ioctl switch
statement that leaked already allocated memory. Fix the same issue for
VIAWGET_HOSTAPD_SCAN_REQ and VIAWGET_HOSTAPD_MLME that are not supported by
this driver. Detected by Coverity - CID 144381.
Signed-off-by: Christian Engelmayer <cengelma@gmx.at>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Wed, 30 Apr 2014 20:31:13 +0000 (21:31 +0100)]
staging: vt6656: desh.h Remove unused macros and structures.
All are dead and of no use.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Wed, 30 Apr 2014 20:31:12 +0000 (21:31 +0100)]
staging: vt6656: rxtx: Remove unused uDMAIdx from driver.
Remove from functions and callers.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Martin Kepplinger [Tue, 6 May 2014 05:58:39 +0000 (07:58 +0200)]
staging: vt6656: make spin_lock_irq() human readable
Don't require FIRMWAREbDownload() to, first off, unlock a held lock.
Thus do all locking in main_usb.c and hold it for a insignificantly
shorter period of time. This makes the affected area significantly more
readable though.
Signed-off-by: Martin Kepplinger <martink@posteo.de>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Guido Martínez [Sat, 19 Apr 2014 19:45:00 +0000 (16:45 -0300)]
staging: vt6655: fix checkpatch bracing issues
This patchs fixes tons of warnings such as:
WARNING: braces {} are not necessary for single statement blocks
#354: FILE: drivers/staging/vt6655/wmgr.c:354:
+ for (ii = 0; ii < WLAN_BSSID_LEN; ii++) {
+ pMgmt->abyDesireBSSID[ii] = 0xFF;
+ }
Please note: this patch only fixes bracing issues (and there is still a
lot to do); so if you run checkpatch it _will_ throw a lot of errors.
Use --test-only=braces
Signed-off-by: Guido Martínez <guido@vanguardiasur.com.ar>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Guido Martínez [Sat, 19 Apr 2014 19:44:59 +0000 (16:44 -0300)]
staging: vt6655: remove dead code
Remove dead code in many places on this driver.
Signed-off-by: Guido Martínez <guido@vanguardiasur.com.ar>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tobias Klauser [Fri, 25 Apr 2014 09:53:58 +0000 (11:53 +0200)]
staging: vt6656: Use proper target pointer in memcpy()
The coverity scanner marked these two memcpy()'s as causing a buffer
overflow in CIDs 142743 and 142744. This is due the h_dest member of
struct ethhdr being used as a target (size ETH_ALEN) in memcpy, but the
copy is of size ETH_HLEN. However, the intention here seems to be to
copy the entire ethernet header. Make that clear by specifying the
proper destination buffer.
Also remove the unnecessary casts of the source argument.
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
projects / platform / kernel / linux-rpi.git / log