Maryam Ariyan [Wed, 21 Feb 2018 20:18:36 +0000 (15:18 -0500)]
Adding missing typeforward for Lazy<T,TMetadata> to System.ComponentModel.Composition
Fixes dotnet/corefx#27299
Commit migrated from https://github.com/dotnet/corefx/commit/
54b46bd3a729d8a139c224cbef4721daffee3c97
Lakshmi Priya Sekar [Tue, 20 Feb 2018 19:06:08 +0000 (11:06 -0800)]
Merge pull request dotnet/corefx#26979 from Priya91/newhttpauth
Add test infra for auth testing.
Commit migrated from https://github.com/dotnet/corefx/commit/
ff123e89989b2b34e82c854ea597626d884d52ba
Matt Galbraith [Tue, 20 Feb 2018 18:30:31 +0000 (10:30 -0800)]
Merge pull request dotnet/corefx#27214 from MattGal/add-some-new-linuxes
Add RH / Centos 7.4 skus
Commit migrated from https://github.com/dotnet/corefx/commit/
ebcc5683a3156fa44dd991e540737e1daa38eebb
Brian Robbins [Tue, 20 Feb 2018 18:26:00 +0000 (10:26 -0800)]
Mark Microsoft.Diagnostics.Tracing.EventSource.Redist Package as Stable with Version 2.0 (dotnet/corefx#27219)
* Set a 2.0.0 stable version for System.Diagnostics.Tracing.EventSource.Redist
* Set HarvestStablePackage=false for Microsoft.Diagnostics.Tracing.EventSource.Redist.
Commit migrated from https://github.com/dotnet/corefx/commit/
df9b10e54443d81d07051db33ec47ad5b4f53294
Matt Galbraith [Tue, 20 Feb 2018 18:21:45 +0000 (10:21 -0800)]
Remove 7.3 Centos/RH from CI
Commit migrated from https://github.com/dotnet/corefx/commit/
267816c72ed50b2113f5f496d91dbbd7ae352b5d
Viktor Hofer [Tue, 20 Feb 2018 18:15:48 +0000 (19:15 +0100)]
Refactor CheckTimeout to enable inlining (dotnet/corefx#27262)
Commit migrated from https://github.com/dotnet/corefx/commit/
b89d83a9b57f0a803cd143e16623bd3103043bcb
Ian Hays [Tue, 20 Feb 2018 17:01:18 +0000 (09:01 -0800)]
Merge pull request dotnet/corefx#27216 from ianhays/compressionstream_tests
Fix some compression tests
Commit migrated from https://github.com/dotnet/corefx/commit/
cfe3ac1dd76cebe61a2206c0549085a669770a3b
Jan Kotas [Tue, 20 Feb 2018 16:14:57 +0000 (08:14 -0800)]
Replace ValueStringBuilder.set_Length with indexer (dotnet/corefx#27274)
Indexer that let's you see and edit the content of the pending string is more efficient and flexible.
Fixes dotnet/corefx#26643
Commit migrated from https://github.com/dotnet/corefx/commit/
e45523d96acf833d727636fffeeb763b02a2360e
Geoff Kizer [Tue, 20 Feb 2018 13:20:20 +0000 (05:20 -0800)]
SocketsHttpHandler: Don't reuse connection with extraneous received data (dotnet/corefx#27265)
* don't reuse connection with extraneous received data
* add tracking issue
Commit migrated from https://github.com/dotnet/corefx/commit/
5a57de7524fa3c3a2ba2b4f643f30464f917e14f
Stephen Toub [Tue, 20 Feb 2018 13:02:52 +0000 (08:02 -0500)]
Disabling CanRecurseFromRoot test, again (dotnet/corefx#27276)
Commit migrated from https://github.com/dotnet/corefx/commit/
2fe35d98cd2ceb7e5649321a49039ec27ccbff6e
Geoff Kizer [Tue, 20 Feb 2018 06:07:37 +0000 (22:07 -0800)]
Merge pull request dotnet/corefx#27255 from geoffkizer/fixcl
SocketsHttpHandler: remove Content-Length header if Transfer-Encoding: chunked is present
Commit migrated from https://github.com/dotnet/corefx/commit/
f9853fafb6e49c1c6e94f8c3130af9da4a1574a2
Jeremy Kuhne [Tue, 20 Feb 2018 05:01:21 +0000 (21:01 -0800)]
Handle errors getting state in Unix (dotnet/corefx#27239)
* Handle errors getting state in Unix
Throwing errors while examining extended state while enumerating isn't consistent with Windows behavior. Windows never throws past getting directory entry data as all state is already available.
Ensure entry attribute state is consistent with initial construction.
* Win 7 CI machines are also setting NotContentIndexed.
Commit migrated from https://github.com/dotnet/corefx/commit/
597f44c5056badfb47f45731480454d698849800
Jeremy Kuhne [Tue, 20 Feb 2018 04:42:15 +0000 (20:42 -0800)]
Add tests against corelib shared IO internals (dotnet/corefx#27261)
These were removed when we cleaned up unused code in CoreFX common. Next steps are to CoreFX PathInternal usages to CoreLib and remove existing CoreLib.
Commit migrated from https://github.com/dotnet/corefx/commit/
6993b6df87e4148e23d65ae854b945d3866f856c
Jeremy Kuhne [Tue, 20 Feb 2018 01:22:47 +0000 (17:22 -0800)]
Update root dir enum test (dotnet/corefx#27254)
Update assert for better logging. Skip directory entries.
fixes dotnet/corefx#27244
Commit migrated from https://github.com/dotnet/corefx/commit/
59b2bfdc28ab814553601379392ebfe24eb610aa
Geoff Kizer [Mon, 19 Feb 2018 19:32:24 +0000 (11:32 -0800)]
remove CL if TE present
Commit migrated from https://github.com/dotnet/corefx/commit/
f9c486d14ec01e98b9e73b4eb23f729783678e3c
Geoff Kizer [Mon, 19 Feb 2018 19:28:15 +0000 (11:28 -0800)]
modify test to work around CL population issue
Commit migrated from https://github.com/dotnet/corefx/commit/
ff5318905c9134d5fbf87b6597f72d331bc9a029
Geoff Kizer [Mon, 19 Feb 2018 19:10:00 +0000 (11:10 -0800)]
Merge pull request dotnet/corefx#26926 from MarcoRossignoli/issues/26856_GetHostByName
Remove old GetHostByName logic
Commit migrated from https://github.com/dotnet/corefx/commit/
643bccc7f2c24a897cc15c42486d4184e1f931eb
Stephen Toub [Mon, 19 Feb 2018 17:57:48 +0000 (12:57 -0500)]
Disable CanRecurseFromRoot test (dotnet/corefx#27252)
Commit migrated from https://github.com/dotnet/corefx/commit/
336bc1868948c01db4ba72be49c2b959099e542d
Stephen Toub [Mon, 19 Feb 2018 16:06:18 +0000 (11:06 -0500)]
Implement SocketsHttpHandler's Expect100ContinueTimeout and ConnectTimeout (dotnet/corefx#27242)
With the expectation that we'll want to expose this in 2.1, implement Expect100ContinueTimeout and ConnectTimeout. The members are currently internal but can be flipped public easily once the APIs are approved. This also fixes an issue with cancellation around the connect phase, where a cancellation request that came in during the SSL auth phase would not be respected.
Commit migrated from https://github.com/dotnet/corefx/commit/
01fa16ffd618846a913cad719269c8bb441ceb28
Dan Moseley [Sat, 17 Feb 2018 16:59:53 +0000 (08:59 -0800)]
Do not clear service name before deleting it by name (dotnet/corefx#27225)
* Do not clear service name
* Quote
Commit migrated from https://github.com/dotnet/corefx/commit/
b9c5530c830b7ee0cb0e165a8b083e477cac891f
Marco Rossignoli [Sat, 17 Feb 2018 09:47:24 +0000 (09:47 +0000)]
update GetNextIPAddress signature
Commit migrated from https://github.com/dotnet/corefx/commit/
f0c299f4dc45e833fdfa89252e3d2c5f2445c0b8
Jeremy Kuhne [Sat, 17 Feb 2018 05:52:07 +0000 (21:52 -0800)]
Fix enumerating the root directory. (dotnet/corefx#27223)
* Fix enumerating the root directory.
Shouldn't trim the trailing separator when at the root. On Windows that makes
the path drive relative- which breaks most of the logic.
Add a test to catch this case.
* Add the Unix part of the fix.
Commit migrated from https://github.com/dotnet/corefx/commit/
5b4ce203c563a20053f32f9901ea6b7dc67c8e37
Jeremy Barton [Sat, 17 Feb 2018 02:56:31 +0000 (18:56 -0800)]
Normalize names of span inputs in crypto API
The asymmetric types operate on either hashed input, or unprocessed input.
The existing API tends to call hashed input "hash" (or "rgbHash" for older API),
and unprocessed input "data" (or "rgbData").
This change modifies the new (ReadOnly)Span-based methods to use "data"
and "hash" (as appropriate) instead of "source". Particularly because the
hash-based methods in DSA do not contain the word Hash, making "source"
for CreateSignature ambiguous.
In the cases where the existing parameter was named "rgbHash" (et al) the
"rgb" was dropped in the (ReadOnly)Span variant, including in the cases
where the (ReadOnly)Span variant is a proper overload.
Commit migrated from https://github.com/dotnet/corefx/commit/
c360ba27944379f8234ff3a14e30b05f1279bd8e
Stephen Toub [Sat, 17 Feb 2018 00:09:31 +0000 (19:09 -0500)]
Add SslStream test to validate options aren't mutated (dotnet/corefx#27203)
* Add SslStream test to validate options aren't mutated
While reading the code, I thought I saw the AuthenticateAsClientAsync options mutating the input options bag, which it shouldn't do. I wrote a test for it, only to realize that I'd read the code incorrectly and it wasn't mutating things incorrectly. But since I'd written the test, figured I might as well check it in.
* Address PR feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
cac1f05d705072c4bb20045f84ef3370d87a976a
Caesar Chen [Sat, 17 Feb 2018 00:03:46 +0000 (16:03 -0800)]
Enable SendReceive_VaryingLengthBuffers_Success on Windows run (dotnet/corefx#27181)
* enable test on Windows run
* delete script
* disable test issue dotnet/corefx#27211
* disable test see dotnet/corefx#27217
Commit migrated from https://github.com/dotnet/corefx/commit/
d3a69ff4448a0bd4df12e6af481898825c066c67
Jan Vorlicek [Fri, 16 Feb 2018 21:21:13 +0000 (22:21 +0100)]
Enable overriding of OpenSSL version (dotnet/corefx#27208)
Also change the order of attempts to load the libssl.so so that
the version 1.0.2 is tried first to make it less probable that some
of our other dependencies end up loading conflicting version of libssl
on Debian 8 that has bumped the libssl soname to 1.0.2.
Commit migrated from https://github.com/dotnet/corefx/commit/
1c974c975d7c354c8dadd96b449847b6ad01180f
Ian Hays [Fri, 16 Feb 2018 20:49:53 +0000 (12:49 -0800)]
Fix some compression tests
Commit migrated from https://github.com/dotnet/corefx/commit/
d87258fc6f42d882a3e52a2452c945c0937e0f1a
Matt Galbraith [Fri, 16 Feb 2018 19:56:59 +0000 (11:56 -0800)]
Add RH / Centos 7.4 skus
Commit migrated from https://github.com/dotnet/corefx/commit/
c5868abf1e9eb7c6bb10df18e270a83444ce3966
Lakshmi Priya Sekar [Fri, 16 Feb 2018 19:24:15 +0000 (11:24 -0800)]
More test fixes from CI.
Commit migrated from https://github.com/dotnet/corefx/commit/
3fe39953a3213f60110e319cef869958a9638c49
Jeremy Kuhne [Fri, 16 Feb 2018 19:10:07 +0000 (11:10 -0800)]
Use NtCreateFile on Win32 (dotnet/corefx#27195)
NtCreateFile allows passing in a base handle which makes opening child directories much faster. This cuts anywhere from 3-10% of the time off of a GetFiles() call.
It is significantly faster as it avoids normalization and path parsing overhead.
Commit migrated from https://github.com/dotnet/corefx/commit/
a28a2cdda67c024126f690bbe1331174a194f9ce
Matt Galbraith [Fri, 16 Feb 2018 18:49:38 +0000 (10:49 -0800)]
Merge pull request dotnet/corefx#27111 from MattGal/use-dotnetcore-build-pool
Move Windows builds to DotNetCore-Build pool
Commit migrated from https://github.com/dotnet/corefx/commit/
03ecb64ea5fc26c5a475261f64aa6026f945d03d
Stephen Toub [Fri, 16 Feb 2018 18:20:44 +0000 (13:20 -0500)]
Fix encryption policy error message missing argument (dotnet/corefx#27205)
The message is currently "The '{0}' encryption policy is not supported on this platform." rather than, e.g. "The 'NoEncryption' encryption policy is not supported on this platform."
Commit migrated from https://github.com/dotnet/corefx/commit/
e282c38afc12c2ebeb2b411c186758e8a25fa743
Viktor Hofer [Fri, 16 Feb 2018 18:01:27 +0000 (19:01 +0100)]
Use stackalloc for longer SystemDirectory paths (dotnet/corefx#27204)
* Use stackalloc for longer SystemDirectory paths
* change stackalloc to 260
Commit migrated from https://github.com/dotnet/corefx/commit/
bdba43d52e44ed9f2d194ab5b151aa47c60edbf4
Pavel Krymets [Fri, 16 Feb 2018 17:58:27 +0000 (09:58 -0800)]
Cross compile Pipelines and retarget ref to netstandard1.1 (dotnet/corefx#27166)
Cross compile Pipelines and retarget ref to netstandard1.1
Commit migrated from https://github.com/dotnet/corefx/commit/
ef8ed755cdf2ba6e223ecd33c2169ec3afdbca32
Stephen Toub [Fri, 16 Feb 2018 17:04:45 +0000 (12:04 -0500)]
Fix AuthenticateAsServerAsync argument name in ref (dotnet/corefx#27201)
Commit migrated from https://github.com/dotnet/corefx/commit/
e153e40c6eaf8d79d86628fdde1b356422dc8fbe
Stephen Toub [Fri, 16 Feb 2018 17:02:45 +0000 (12:02 -0500)]
Improve test coverage of SocketsHttpHandler (dotnet/corefx#27135)
* Improve test coverage of SocketsHttpHandler
Used code coverage information to write targeted tests to cover various uncovered paths in SocketsHttpHandler. Along the way fixed a variety of issues relating to throwing the wrong exception type, a stack overflow due to an unexpected recursive call, etc.
* Address PR feedback
* Re-disable a test
Commit migrated from https://github.com/dotnet/corefx/commit/
39677219aaeab8c6591b625ab2874acb17eaf4ef
dotnet-maestro-bot [Fri, 16 Feb 2018 16:59:11 +0000 (10:59 -0600)]
Update CoreFx to preview2-26216-03 (dotnet/corefx#27200)
Commit migrated from https://github.com/dotnet/corefx/commit/
423108d574ad4319beffdafeea92da717ae2ac7b
Viktor Hofer [Fri, 16 Feb 2018 16:43:40 +0000 (17:43 +0100)]
Remove unsafe code for HexEscape in favor of string.Create (dotnet/corefx#27194)
Commit migrated from https://github.com/dotnet/corefx/commit/
a8e60020ca743b7d334013798098b072de8d0a6a
Marco Rossignoli [Fri, 16 Feb 2018 13:43:34 +0000 (13:43 +0000)]
remove cast
Commit migrated from https://github.com/dotnet/corefx/commit/
3a241096e73404332dc45cedb411006e76403299
Marco Rossignoli [Fri, 16 Feb 2018 12:29:29 +0000 (12:29 +0000)]
clean
Commit migrated from https://github.com/dotnet/corefx/commit/
8566f4e43dc1b61dbee9d00188fbdeee8758865a
Max Kerr [Fri, 16 Feb 2018 12:18:59 +0000 (04:18 -0800)]
Modify StreamContent to use default CopyToAsync buffer size when no size is provided (dotnet/corefx#27176)
* Add a tentative fix
* Minor fixes.
* Remove unused default value.
* Re-order error checks for compatibility reasons.
* Add a test to pin exception behavior when both parameters are incorrect.
Commit migrated from https://github.com/dotnet/corefx/commit/
c28fbce3ce31cc0274b14e6e4ae08a84ec04ed1b
Omair Majid [Fri, 16 Feb 2018 12:18:00 +0000 (07:18 -0500)]
Fix build on clang 5 (dotnet/corefx#27178)
This contains two fixes, both related to new warnings introduced with
clang 5:
http://releases.llvm.org/5.0.0/tools/clang/docs/ReleaseNotes.html
1. clang 5 introduces a -Wzero-as-null-pointer-constant warning, which
becomes an error with Werror. This warning is not known by older
versions of clang and affects a lot of C/C++ code, such as:
static pthread_mutex_t lock = PTHREAD_MUTEX_INITIALIZER;
It also affects code we pick up from our dependency libraries. Lets
check if the compiler knows about this warning and disable it if so.
2. clang 5 introduces checks for casts. The library expects a `char *`,
so lets cast our pointer to the expected type so it will continue
working.
Commit migrated from https://github.com/dotnet/corefx/commit/
a9f4a46f48baeaadd515d85ac9de1249b8023a5a
dotnet-maestro-bot [Fri, 16 Feb 2018 09:45:35 +0000 (03:45 -0600)]
Update CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview2-26216-01, beta-26216-00, beta-26216-00, respectively (dotnet/corefx#27196)
Commit migrated from https://github.com/dotnet/corefx/commit/
57aa7d9645864c89c22f0f1ae9dc90b16792a10f
David Fowler [Fri, 16 Feb 2018 05:55:28 +0000 (21:55 -0800)]
Remove Commit from PipeWriter (dotnet/corefx#27182)
- PipeWriter.Complete now commits any uncommitted data instead of throwing.
- Updated the tests
Commit migrated from https://github.com/dotnet/corefx/commit/
77c45b1fc1b87bf1e131ab16e672d36f557e088d
dotnet-maestro-bot [Fri, 16 Feb 2018 05:35:06 +0000 (23:35 -0600)]
Update BuildTools, CoreFx to preview2-02516-02, preview2-26216-01, respectively (dotnet/corefx#27186)
Commit migrated from https://github.com/dotnet/corefx/commit/
808a63a56e11d8c03c4551e738f76510c65dd1fc
Paulo Janotti [Fri, 16 Feb 2018 04:00:49 +0000 (20:00 -0800)]
Enforce ILLink AssemblyPath order (dotnet/corefx#27188)
The order of assembly references should take project references first.
Commit migrated from https://github.com/dotnet/corefx/commit/
7c4602eff88e30241f8f07a4ea7146e623045e90
Dan Moseley [Fri, 16 Feb 2018 03:59:23 +0000 (19:59 -0800)]
Log libc version in our "OS info logging test" (dotnet/corefx#27143)
* Glibc logging
* Updates
Commit migrated from https://github.com/dotnet/corefx/commit/
1840df10f8ea2d62ceb2b5ab2c367f4f9e54e6da
Jeremy Kuhne [Fri, 16 Feb 2018 02:45:51 +0000 (18:45 -0800)]
Remove FileSystem unused common files (dotnet/corefx#27184)
Also update .sln using UpdateVSConfigurations
Commit migrated from https://github.com/dotnet/corefx/commit/
7eb6dba62ec630d33db7dcd9e810a937a92d975f
Lakshmi Priya Sekar [Fri, 16 Feb 2018 00:59:26 +0000 (16:59 -0800)]
More test fixes from CI runs.
Commit migrated from https://github.com/dotnet/corefx/commit/
29374f83897d19995b640c1d663e68dfb9fb1058
Jeremy Kuhne [Fri, 16 Feb 2018 00:41:51 +0000 (16:41 -0800)]
Change RootDirectory properties to span (dotnet/corefx#27134)
Exposing string restricts the ability to change internals without introducing unnecessary allocations.
Commit migrated from https://github.com/dotnet/corefx/commit/
3ac69e86e0c8e654a9802bf593fdc98ea69a4fb8
dotnet-maestro-bot [Fri, 16 Feb 2018 00:20:07 +0000 (18:20 -0600)]
Update BuildTools to preview2-02515-02 (dotnet/corefx#27175)
Commit migrated from https://github.com/dotnet/corefx/commit/
bda2ef6506e6bd8bd8a839bca3d02d2517e587f4
Viktor Hofer [Thu, 15 Feb 2018 22:32:19 +0000 (23:32 +0100)]
Fix regression & enable ClearInitLocals in System.Text.RegularExpressions (dotnet/corefx#27146)
* Fix bug in RegexWriter ref struct change
* Remove duplicate ValueListBuilder implementation
* Enable ILLinkClearInitLocals
* Rename concrete ValueListBuilder impl to Pop
Commit migrated from https://github.com/dotnet/corefx/commit/
9e0151b48f3a45d497e8835423ed38e7661cd056
Lakshmi Priya Sekar [Thu, 15 Feb 2018 22:21:24 +0000 (14:21 -0800)]
Response to PR feedback.
Commit migrated from https://github.com/dotnet/corefx/commit/
9721f49e0838a3b3355437cb1f6882d9d62ab557
Geoff Kizer [Thu, 15 Feb 2018 21:39:32 +0000 (13:39 -0800)]
Merge pull request dotnet/corefx#27151 from geoffkizer/sslproxytunnel
SocketsHttpHandler: refactor pool manager logic to enable SSL proxy tunneling support
Commit migrated from https://github.com/dotnet/corefx/commit/
6e3bcbec17273cd38db67e47e7a2975a25160ac2
Stephen Toub [Thu, 15 Feb 2018 21:04:40 +0000 (16:04 -0500)]
Streamline SocketHttpHandler's ParseStatusLine validation (dotnet/corefx#27163)
* Streamline SocketHttpHandler's ParseStatusLine validation
For a typical status line like "HTTP/1.1 200 OK", cuts the time of ParseStatusLine almost in half.
* Address PR feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
c8d23b4941b3b620633db397a0094f55b01be22b
Jon Hanna [Thu, 15 Feb 2018 20:37:30 +0000 (20:37 +0000)]
Make many helpers, factories and tables static in Microsoft.CSharp (dotnet/corefx#27044)
* Have TypeArray in charge of the empty TypeArray singleton
* Make TypeArray allocation a static responsibility of TypeArray
* Remove some orphaned members.
Mostly BSYMMGR-returning members that had been used to allocate
TypeArrays
* Make members static were possible.
Those that can already be easily made static. Includes removing some
members that this makes no longer necessary.
* Remove unused parameters
Since some are of the types we'll be making static, and such parameters
will have to go anyway.
* Make TypeTable static
And more conventional names within TypeTable.
* More TypeManager state & methods to static
* Make SYMTBL.Key an immutable struct.
* SYMTBL completely static and renamed to SymbolStore
More conventional name, and doesn't clash with other SymbolTable class.
* GetWinRTCollectionIfacesAll to property.
* SymFactory static class.
* Remove PredefinedTypes._symbolManager field
Only used in assertion.
* Remove assert comparison with this in GetAggregate
Assert is the only reason to not be static, allows a cascade of more
changes to static.
* Make InternalsVisibleTo check static.
* Make cycle of instance methods static
Take quite a large set of methods which must be instance because of
cyclic instance dependencies, and make them all static.
Removes dependency in AggregateSymbol and NullableType on TypeManager
instances.
* Replace GetAggTypeSym with virtual method on CType.
Merged with existing GetAts on NullableType. Comment says this would be
nice, and indeed it would, and its easy now.
* Make those members that can now be static, static.
* Remove orphaned members and fields.
* PredefinedMembers entirely static.
* Remove UserStringBuilder.m_buildingInProgress
Only used in asserts, just assert on whether m_strBuilder is null or
not.
Also rename m_strBuilder to _strBuilder to be more conventional.
* Favour returning over out in UserStringBuilder
And favour clearing StringBuilder over creating another.
* Make ErrorHandling completely static.
Creating UserStringBuilder instances on demand.
* TypeManager static.
* Make CNullable methods static and merge directly into ExpressionBinder
Don't cache method and property, as they're already cached.
* Don't preload types.
Either they'll be loaded soon anyway, or else it's a wasted effort.
* Move CompareTypes into Better.cs
* Remove BSYMMGR.LookupAggMember
Just call into SymbolStore.LookupSym
* Move LookupNextSym logic into Symbol
* Remove BSYMMGR and GlobalSymbolContext
No longer any use.
* ExprFactory static
* SymbolLoader static
* CSemanticChecker static
* Don't pre-emptively load System.Object
Will be loaded as a base of the first type encountered anyway.
* SymbolTable static
* More methods can be made static
* Remove orphaned method.
* Move methods for getting MemberInfos from expressions into those expressions
* Replace ExpressionTreeCallRewriter.GetObject with virtual property in Expr
* TypeArray tidy-up.
* Pass ExpressionBinder to operator delegates, and make them static.
Allows array to be created once statically, rather than on each
instance construction.
* Create RuntimeBinder, ExpressionBinder and BindingContext per operation
These are now very lightweight, so it's simpler to create them anew
each time rather than overwriting the values in the BindingContext.
* Make RuntimeBinder, ExpressionBinder and BindingContext structs
No need to allocate on the heap.
* Remove AggregateDeclaration
We only ever care about the AggregateSymbol it relates to.
(The two aren't really separate in dynamic code, where there aren't
really declarations).
* Remove IsChecked and CallingContext from C# binders.
Now not used as they are passed to RuntimeBinder on construction,
except for CallingContext remaining in CSharpInvokeMemberBinder for use
in deferring.
* Make RecordBinOpSigFromArgs static.
A last member that can be made static.
* Make static-member-only classes static.
* Make NameHashKey a readonly struct.
Commit migrated from https://github.com/dotnet/corefx/commit/
b7d1ae93c179510991f75709c3c3c1d3e3d062c1
Stephen Toub [Thu, 15 Feb 2018 19:59:30 +0000 (14:59 -0500)]
Fix race condition in PostAsyncExpect100Continue_RetryOnConnectionClosed_Success test (dotnet/corefx#27148)
Commit migrated from https://github.com/dotnet/corefx/commit/
28799e8af0556efe1b9e5e98b700460951ae9eb2
dotnet-maestro-bot [Thu, 15 Feb 2018 19:25:39 +0000 (13:25 -0600)]
Update BuildTools, CoreClr, CoreFx, ProjectNTfs, ProjectNTfsTestILC to preview2-02515-01, preview2-26214-07, preview2-26215-04, beta-26215-00, beta-26215-00, respectively (dotnet/corefx#27112)
Commit migrated from https://github.com/dotnet/corefx/commit/
42a3e4384f419322bb4ea32a63fda0ff75e3f29d
Jiayi Yu [Thu, 15 Feb 2018 19:08:39 +0000 (11:08 -0800)]
Initialized a bool variable to fix warning (dotnet/corefx#26947)
Commit migrated from https://github.com/dotnet/corefx/commit/
5615f5325cd41e49ba970b3f8bd620d3680cfe90
Geoff Kizer [Thu, 15 Feb 2018 18:55:32 +0000 (10:55 -0800)]
address review feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
46785d3ae61987ae8ae389b2138645e82b54efb0
Jeremy Kuhne [Thu, 15 Feb 2018 18:32:03 +0000 (10:32 -0800)]
Current directory code duplicates Environment (dotnet/corefx#27153)
Just call Environment.CurrentDirectory. Remove a number of P/Invokes
that are no longer in use.
Commit migrated from https://github.com/dotnet/corefx/commit/
8e6222ab2f2b48f20a274272693665dac8259c79
Jon Hanna [Thu, 15 Feb 2018 18:18:00 +0000 (18:18 +0000)]
Remove more orphaned code in Microsoft.CSharp (dotnet/corefx#27104)
* Remove IExprWithObject and ExprWithArgs.OptionalObject
No longer used.
* Remove CLR_PostIncrement/Decrement
Rename CLR_PreIncrement/Decrement to CLR_Increment/Decrement as it
covers both pre- and post- cases.
* Remove Symbol.IsVirtual()
Commit migrated from https://github.com/dotnet/corefx/commit/
0a61a146f78eb396d057eae9734d3f6e335d9a8b
David Fowler [Thu, 15 Feb 2018 18:03:02 +0000 (10:03 -0800)]
Made a few tweaks to pipelines (dotnet/corefx#27158)
* Made a few tweaks to pipelines
- Renamed the file containing the class IDuplexPipe
- Changed the default scheduler to use the ThreadPool if none was specified
Commit migrated from https://github.com/dotnet/corefx/commit/
c2b5a8e3d6339a2c863b1cd48b8663273574fe48
Ben Adams [Thu, 15 Feb 2018 16:10:22 +0000 (16:10 +0000)]
Remove intrinsic from Vector4:op_Division(struct,float) (dotnet/corefx#27122)
* Remove intrinsic from Vector4:op_Division(struct,float)
* feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
820949492d84ed81c6f793e142b54f33cbd65524
Tomas Weinfurt [Thu, 15 Feb 2018 10:47:50 +0000 (02:47 -0800)]
disable two tests on ubuntu 18 while investigating root casue (dotnet/corefx#27144)
Commit migrated from https://github.com/dotnet/corefx/commit/
d00eb7ec42434b0a7e2c3b4f6cd88c896ebaa30f
Jeremy Kuhne [Thu, 15 Feb 2018 06:49:17 +0000 (22:49 -0800)]
Cleaning out dead code (dotnet/corefx#27150)
Also refactor Unix attribute handling a bit to be more consistent and
ensure that we don't make unnecessary addtional filesystem calls.
Commit migrated from https://github.com/dotnet/corefx/commit/
16f26ba855f5cc6d52a738e8bc3856c6f77cf761
Brian Robbins [Thu, 15 Feb 2018 03:48:46 +0000 (19:48 -0800)]
Temporarily Disable EventSource ETW Tests and Revert TraceEvent Package Version (dotnet/corefx#27141)
Commit migrated from https://github.com/dotnet/corefx/commit/
0cf7583bf8d01e5445950b03956b2134402de286
Maryam Ariyan [Thu, 15 Feb 2018 03:20:00 +0000 (22:20 -0500)]
Adding test to verify FileStream.Dispose() ignores IO Related Exception in finalizer (dotnet/corefx#26921)
* Adding test to verify FileStream.Dispose() skips IO Related Exception only on finalization
* Skipping test on netfx because the behavior in netfx is different
Commit migrated from https://github.com/dotnet/corefx/commit/
a15cc53eb5a4248c76bdc60beb3e31628bd8acf8
Maryam Ariyan [Thu, 15 Feb 2018 03:03:22 +0000 (22:03 -0500)]
Fixing fa-IR negative currency format for test GetCurrencyNegativePatterns (dotnet/corefx#27138)
Fixes dotnet/corefx#27022 and dotnet/corefx#27127
Commit migrated from https://github.com/dotnet/corefx/commit/
fe548ac62bdc46785e7e153a5f2a3de15daefd6d
Geoff Kizer [Thu, 15 Feb 2018 02:43:15 +0000 (18:43 -0800)]
add code to establish proxy tunnel for SSL
Commit migrated from https://github.com/dotnet/corefx/commit/
d84a28844502bcf30538a18e30e33118ca879467
Geoff Kizer [Wed, 14 Feb 2018 06:52:20 +0000 (22:52 -0800)]
reorganize pool manager logic and rework HttpConnectionKey to support ssl proxy tunneling
Commit migrated from https://github.com/dotnet/corefx/commit/
39ed24e9f6f55d6077742776e154ead199e1b3a0
Lakshmi Priya Sekar [Wed, 14 Feb 2018 02:07:33 +0000 (18:07 -0800)]
Mark failing tests with issue.
Commit migrated from https://github.com/dotnet/corefx/commit/
828468a258cfba872c84c3976835e9c664f68dee
Koundinya Veluri [Thu, 15 Feb 2018 00:15:01 +0000 (16:15 -0800)]
Disable a SignalAndWait test so that relevant change in CoreCLR can be brought into CoreFX (dotnet/corefx#27131)
Commit migrated from https://github.com/dotnet/corefx/commit/
6f06dcc32df6939e726d46ca45f8491db7967fb8
Jeremy Kuhne [Thu, 15 Feb 2018 00:06:04 +0000 (16:06 -0800)]
Add some pattern transformation tests (dotnet/corefx#27133)
Commit migrated from https://github.com/dotnet/corefx/commit/
11182e0c4e65fb1e6fa0596ca9d991e3382c9fb2
Viktor Hofer [Thu, 15 Feb 2018 00:02:08 +0000 (01:02 +0100)]
reduce regex op code time (dotnet/corefx#26877)
* reduce regex op code time
* Use ValueListBuilder and stackalloc during op code generation
* Increasing op array size
Commit migrated from https://github.com/dotnet/corefx/commit/
1eb5ddf1d0a3dbc0a221769a45d81d2a2b7fa81d
Lakshmi Priya Sekar [Tue, 13 Feb 2018 23:38:23 +0000 (15:38 -0800)]
Add tests to all handlers.
Commit migrated from https://github.com/dotnet/corefx/commit/
aa2482155262063229ea3f0e5d868890d8490415
Lakshmi Priya Sekar [Tue, 13 Feb 2018 02:35:19 +0000 (18:35 -0800)]
Fix test
Commit migrated from https://github.com/dotnet/corefx/commit/
102e4d3c731e1765a21a3a5fd3e908c428ef4a88
Lakshmi Priya Sekar [Fri, 2 Feb 2018 21:46:33 +0000 (13:46 -0800)]
Add test infra for auth testing.
Commit migrated from https://github.com/dotnet/corefx/commit/
a7d6718d2919ef81a5cebb0ce92a53b4989234d4
Tomáš Matoušek [Wed, 14 Feb 2018 23:01:55 +0000 (15:01 -0800)]
Add support for PDB Checksum debug directory entry (dotnet/corefx#26976)
Commit migrated from https://github.com/dotnet/corefx/commit/
6b099e771d3b775b5cd273ec1b6fcec12ee7abbe
Geoff Kizer [Wed, 14 Feb 2018 19:13:34 +0000 (11:13 -0800)]
Merge pull request dotnet/corefx#27088 from geoffkizer/refactorloopbackserver
reorganize and cleanup some LoopbackServer code
Commit migrated from https://github.com/dotnet/corefx/commit/
46267c1dbe46f0127e670ce25933ff49a5ec9d6e
Jeremy Barton [Wed, 14 Feb 2018 15:33:30 +0000 (07:33 -0800)]
Add FixedTimeEquals and other crypto helper routines as public API
Commit migrated from https://github.com/dotnet/corefx/commit/
3872bafe8186a3e74cb66efa4a2835d60ed67ba2
Marco Rossignoli [Wed, 14 Feb 2018 09:44:42 +0000 (09:44 +0000)]
Merge branch 'issues/26856_GetHostByName' of https://github.com/MarcoRossignoli/corefx into issues/26856_GetHostByName
Commit migrated from https://github.com/dotnet/corefx/commit/
b2770e847169aba29f28496727be69acae12b4f6
Marco Rossignoli [Wed, 14 Feb 2018 09:41:59 +0000 (09:41 +0000)]
clean unix
Commit migrated from https://github.com/dotnet/corefx/commit/
92dbe7de2ced0f130e46f1bc42399837562d5b14
Jeremy Kuhne [Wed, 14 Feb 2018 05:49:57 +0000 (21:49 -0800)]
API tweaks to match latest updates to spec (dotnet/corefx#27102)
* API tweaks to match latest updates to spec
Add a few new tests
See dotnet/corefx#25873
* Properly clear state when enumerating on Unix.
Make sure we don't include special directories in subdir processing. Add test.
Collapse helper that was only called in one place, and remove dead one.
Commit migrated from https://github.com/dotnet/corefx/commit/
1c9cd8118abfa13165d88a4e660fbdcc6c2ebc4c
Brian Robbins [Wed, 14 Feb 2018 04:25:55 +0000 (20:25 -0800)]
Fix and Enable Most ETW EventSource Tests (dotnet/corefx#27107)
Commit migrated from https://github.com/dotnet/corefx/commit/
ad52ae103416ea67e30abf21c19d5d0c0cd01b11
Matt Galbraith [Fri, 9 Feb 2018 22:22:28 +0000 (14:22 -0800)]
Move Windows builds to DotNetCore-Build (Server 2016 + VS 2017 only) build agents.
Commit migrated from https://github.com/dotnet/corefx/commit/
8606fede4922513fbb83b090361545d8998ab653
Krzysztof Cwalina [Wed, 14 Feb 2018 00:37:20 +0000 (16:37 -0800)]
Merge pull request dotnet/corefx#27007 from pakrym/pakrym/pipelines
Add System.IO.Pipelines API
Commit migrated from https://github.com/dotnet/corefx/commit/
3c708ab64564304fed352355b52e2ea047860e4d
Geoff Kizer [Wed, 14 Feb 2018 00:03:28 +0000 (16:03 -0800)]
fix tests from merge
Commit migrated from https://github.com/dotnet/corefx/commit/
b028092ce1af45e109edb0609b7b8cef42ee8a99
Geoff Kizer [Tue, 13 Feb 2018 23:03:42 +0000 (15:03 -0800)]
add response generation overloads
Commit migrated from https://github.com/dotnet/corefx/commit/
6943fc7c0e92359e6335a618f6ff5ee8402af4ac
Geoff Kizer [Tue, 13 Feb 2018 21:14:44 +0000 (13:14 -0800)]
address PR feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
6ab005635528a03daa52ca727a4a74dcc0316830
Geoff Kizer [Sun, 11 Feb 2018 22:04:30 +0000 (14:04 -0800)]
reorganize and cleanup some LoopbackServer code
Commit migrated from https://github.com/dotnet/corefx/commit/
ec6a7215bb28a061d2357d8c3874447bc575132d
Caesar Chen [Tue, 13 Feb 2018 23:24:22 +0000 (15:24 -0800)]
Change HTTP default request version to HTTP/2 (dotnet/corefx#27079)
* change http default request version
* fix innerloop test
Commit migrated from https://github.com/dotnet/corefx/commit/
f7a852f64bf20889579be70710f386a8d4802a34
Pavel Krymets [Tue, 13 Feb 2018 22:32:58 +0000 (14:32 -0800)]
More comments
Commit migrated from https://github.com/dotnet/corefx/commit/
17b00a58129e659cf01a1cb6c045c400f8e0c984
Jose Perez Rodriguez [Tue, 13 Feb 2018 22:24:40 +0000 (14:24 -0800)]
Fix test project
Commit migrated from https://github.com/dotnet/corefx/commit/
bb72f2e32593383ec3862d064cc8916ba5c4daa4
Stephen Toub [Tue, 13 Feb 2018 21:30:34 +0000 (16:30 -0500)]
Enable SocketsHttpHandler cancellation support (dotnet/corefx#27029)
* Enable SocketsHttpHandler cancellation support
This change significantly improves the cancellation support in SocketsHttpHandler. Previously we were passing the CancellationToken around to every method, eventually bottoming out in calls to the underlying Stream which then ends up passing them down to the underlying Socket. But today Socket's support for cancellation is minimal, only doing up-front checks; if cancellation is requested during the socket operation rather than before, the request will be ignored. Since HttpClient implements features like timeouts on top of cancellation support, it's important to do better than this.
The change implements cancellation by registering with the CancellationToken to dispose of the connection. This will cause any reads/writes to wake up. We then translate resulting exceptions into cancellation exceptions. When in the main SendAsync method, we register once for the whole body of the operation until the point that we're returning the response message. For individual operations on the response content stream, we register per operation; however, when feasible we try to avoid the registration costs by only registering if operations don't complete synchronously. We also account for the case that on Unix, closing the connection may result in read operations waking up not with an exception but rather with EOF, which we also need to translate into cancellation when appropriate.
Along the way I cleaned up a few minor issues as well.
I also added a bunch of cancellation-related tests:
- Test cancellation occurring while sending request content
- Test cancellation occurring while receiving response headers
- Test cancellation occurring while receiving response body and using a buffered operation
- Test that all of the above are triggerable with CancellationTokenSource.Cancel, HttpClient.CancelPendingRequests, and HttpClient.Dispose
- Test cancellation occurring while receiving response body and using an unbuffered operation, either a ReadAsync or CopyToAsync on the response stream
- Test that a CancelPendingRequests doesn't affect unbuffered operations on the response stream
There are deficiencies here in the existing handlers, and tests have been selectively disabled accordingly (I also fixed a couple cases that naturally fell out of the changes I was making for SocketsHttpHandler). SocketsHttpHandler passes now for all of them.
* Add test that Dispose doesn't cancel response stream
Commit migrated from https://github.com/dotnet/corefx/commit/
53be85c2fe473fdea8c001e3d9fd81dd478b858e
Oswald Maskens [Tue, 13 Feb 2018 21:04:14 +0000 (22:04 +0100)]
Added tests for Microsoft.VisualBasic.CompilerServices.Conversions dotnet/corefx#1… (dotnet/corefx#26744)
* Added tests for Microsoft.VisualBasic.CompilerServices.Conversions dotnet/corefx#14344
* added tests for ToBoolean fro Object
Commit migrated from https://github.com/dotnet/corefx/commit/
c705032f0f4f6e3d34f65cf5660e3c8ea109ad47
dotnet-maestro-bot [Tue, 13 Feb 2018 20:02:54 +0000 (14:02 -0600)]
Update BuildTools, CoreClr, CoreFx to preview2-02513-01, preview2-26213-05, preview2-26213-06, respectively (dotnet/corefx#27093)
Commit migrated from https://github.com/dotnet/corefx/commit/
b9b5b807378f7d17817749288c6b89db9694181a
Tomáš Matoušek [Tue, 13 Feb 2018 19:41:05 +0000 (11:41 -0800)]
Remove 'PDBC' data signature
Commit migrated from https://github.com/dotnet/corefx/commit/
a3647d844791f916dff1053665bbce4574d0b8ee
Jose Perez Rodriguez [Tue, 13 Feb 2018 19:24:31 +0000 (11:24 -0800)]
Fixing pkgproj
Commit migrated from https://github.com/dotnet/corefx/commit/
200bae71172c2aaae4698eb7ab5f14d72d678bea
Eric Erhardt [Fri, 9 Feb 2018 05:02:42 +0000 (21:02 -0800)]
Fix Process Start tests in outerloop on Unix.
Get the real user name in the test process, not the child process. The outerloop tests are run with 'sudo'. Which means by the time we are in the child process SUDO_USER will be set to 'root', since the parent test process was run with 'sudo'.
Fixes dotnet/corefx#26675
Commit migrated from https://github.com/dotnet/corefx/commit/
bca11a079c914ed971b2f300b876f89a920a0398