Benjamin Otte [Thu, 5 Feb 2004 23:02:59 +0000 (23:02 +0000)]
ext/mad/gstid3tag.c: skip undecodable id3v2 tag instead of keeping it
Original commit message from CVS:
2004-02-05 Benjamin Otte <in7y118@public.uni-hamburg.de>
* ext/mad/gstid3tag.c: (gst_id3_tag_chain):
skip undecodable id3v2 tag instead of keeping it
David Schleef [Thu, 5 Feb 2004 22:24:58 +0000 (22:24 +0000)]
gst/mpegaudioparse/gstmpegaudioparse.c: Unref leaked buffer. (Noticed by Ronald)
Original commit message from CVS:
* gst/mpegaudioparse/gstmpegaudioparse.c: (gst_mp3parse_chain):
Unref leaked buffer. (Noticed by Ronald)
David I. Lehn [Thu, 5 Feb 2004 17:09:37 +0000 (17:09 +0000)]
pkgconfig/gstreamer-libs-uninstalled.pc.in: Sync requires with other checks. >= vs =.
Original commit message from CVS:
* pkgconfig/gstreamer-libs-uninstalled.pc.in:
Sync requires with other checks. >= vs =.
Jan Schmidt [Thu, 5 Feb 2004 13:16:22 +0000 (13:16 +0000)]
Rework caps negotiation in the element so that it works again.
Original commit message from CVS:
Rework caps negotiation in the element so that it works again.
Thomas Vander Stichele [Thu, 5 Feb 2004 11:52:06 +0000 (11:52 +0000)]
fix uninstalled pkgconfig files remove play and gconf from -libs
Original commit message from CVS:
fix uninstalled pkgconfig files
remove play and gconf from -libs
David Schleef [Thu, 5 Feb 2004 03:19:12 +0000 (03:19 +0000)]
gst/wavparse/gstwavparse.c: Fix a caps memleak.
Original commit message from CVS:
* gst/wavparse/gstwavparse.c: (gst_wavparse_parse_fmt): Fix a caps
memleak.
Benjamin Otte [Thu, 5 Feb 2004 03:02:42 +0000 (03:02 +0000)]
gst-libs/gst/riff/riff-read.c: use correct GST_TAG_ENCODER tag
Original commit message from CVS:
2004-02-05 Benjamin Otte <in7y118@public.uni-hamburg.de>
* gst-libs/gst/riff/riff-read.c: (gst_riff_read_info):
use correct GST_TAG_ENCODER tag
Benjamin Otte [Thu, 5 Feb 2004 00:18:24 +0000 (00:18 +0000)]
ext/alsa/gstalsa.c: be sure to stop the clock when going to paused
Original commit message from CVS:
2004-02-05 Benjamin Otte <in7y118@public.uni-hamburg.de>
* ext/alsa/gstalsa.c: (gst_alsa_change_state):
be sure to stop the clock when going to paused
* sys/oss/gstosssink.c: (gst_osssink_change_state):
reset number of transmitted when going to ready.
fixes #132935
2004-02-05 Charles Schmidt <cschmidt2@emich.edu>
reviewed by Benjamin Otte
* ext/mad/gstid3tag.c: (gst_mad_id3_to_tag_list):
extract track count (fixes #133410)
Thomas Vander Stichele [Wed, 4 Feb 2004 23:33:28 +0000 (23:33 +0000)]
update translations
Original commit message from CVS:
update translations
Benjamin Otte [Wed, 4 Feb 2004 22:17:16 +0000 (22:17 +0000)]
ext/mad/gstid3tag.c: that should be !=, not == (fixes #132519)
Original commit message from CVS:
2004-02-04 Benjamin Otte <in7y118@public.uni-hamburg.de>
* ext/mad/gstid3tag.c: (gst_id3_tag_do_caps_nego):
that should be !=, not == (fixes #132519)
Thomas Vander Stichele [Wed, 4 Feb 2004 21:47:06 +0000 (21:47 +0000)]
bump version
Original commit message from CVS:
bump version
David Schleef [Wed, 4 Feb 2004 21:40:49 +0000 (21:40 +0000)]
Make sure set_explicit_caps() is called before adding pad.
Original commit message from CVS:
Make sure set_explicit_caps() is called before adding pad.
* ext/ffmpeg/gstffmpegdemux.c: (gst_ffmpegdemux_loop):
* gst/id3/gstid3types.c: (gst_id3types_loop):
* gst/mpegstream/gstmpegdemux.c: (gst_mpeg_demux_parse_syshead):
* gst/realmedia/rmdemux.c: (gst_rmdemux_add_stream):
Thomas Vander Stichele [Wed, 4 Feb 2004 21:30:15 +0000 (21:30 +0000)]
appease libtool gods
Original commit message from CVS:
appease libtool gods
Thomas Vander Stichele [Wed, 4 Feb 2004 21:14:45 +0000 (21:14 +0000)]
ignore copied m4's
Original commit message from CVS:
ignore copied m4's
Thomas Vander Stichele [Wed, 4 Feb 2004 21:10:00 +0000 (21:10 +0000)]
small update
Original commit message from CVS:
small update
Thomas Vander Stichele [Wed, 4 Feb 2004 21:05:45 +0000 (21:05 +0000)]
first prerel
Original commit message from CVS:
first prerel
Thomas Vander Stichele [Wed, 4 Feb 2004 19:59:53 +0000 (19:59 +0000)]
don't run user tests on auto test suite
Original commit message from CVS:
don't run user tests on auto test suite
David Schleef [Wed, 4 Feb 2004 19:45:32 +0000 (19:45 +0000)]
Convert GST_DEBUG_CAPS() to GST_DEBUG():
Original commit message from CVS:
Convert GST_DEBUG_CAPS() to GST_DEBUG():
* gst/mpeg1videoparse/gstmp1videoparse.c:
(mp1videoparse_parse_seq):
* gst/realmedia/rmdemux.c: (gst_rmdemux_add_stream):
* gst/videoscale/gstvideoscale.c: (gst_videoscale_getcaps):
* sys/xvideo/gstxwindow.c: (_gst_xwindow_new):
* sys/xvideo/xvideosink.c: (gst_xvideosink_sinkconnect),
(gst_xvideosink_getcaps):
* sys/xvimage/xvimagesink.c: (gst_xvimagesink_get_xv_support):
* testsuite/gst-lint: more tests
David Schleef [Wed, 4 Feb 2004 19:28:51 +0000 (19:28 +0000)]
Replace use of GST_PAD_FORMATS_FUNCTION() and similar macros with the code that they would expand to.
Original commit message from CVS:
Replace use of GST_PAD_FORMATS_FUNCTION() and similar macros
with the code that they would expand to.
* ext/flac/gstflacdec.c: (gst_flacdec_get_src_formats),
(gst_flacdec_get_src_query_types),
(gst_flacdec_get_src_event_masks):
* ext/gnomevfs/gstgnomevfssrc.c: (gst_gnomevfssrc_get_formats),
(gst_gnomevfssrc_get_query_types),
(gst_gnomevfssrc_get_event_mask):
Benjamin Otte [Wed, 4 Feb 2004 17:23:56 +0000 (17:23 +0000)]
gst/sine/gstsinesrc.c: fix memleak by properly disposing sinesrc
Original commit message from CVS:
2004-02-04 Benjamin Otte <in7y118@public.uni-hamburg.de>
* gst/sine/gstsinesrc.c: (gst_sinesrc_class_init),
(gst_sinesrc_dispose):
fix memleak by properly disposing sinesrc
Julien Moutte [Tue, 3 Feb 2004 23:05:46 +0000 (23:05 +0000)]
gst-libs/gst/xoverlay/xoverlay.*: Adding the _expose method to tell an overlay to redraw the image because it has bee...
Original commit message from CVS:
2004-02-04 Julien MOUTTE <julien@moutte.net>
* gst-libs/gst/xoverlay/xoverlay.c: (gst_x_overlay_expose):
* gst-libs/gst/xoverlay/xoverlay.h: Adding the _expose method to tell
an overlay to redraw the image because it has been exposed.
* sys/ximage/ximagesink.c: (gst_ximagesink_ximage_destroy),
(gst_ximagesink_ximage_put), (gst_ximagesink_expose),
(gst_ximagesink_xoverlay_init), (gst_ximagesink_init):
* sys/ximage/ximagesink.h: Implement expose method from XOverlay
interface
* sys/xvimage/xvimagesink.c: (gst_xvimagesink_xvimage_destroy),
(gst_xvimagesink_xvimage_put), (gst_xvimagesink_expose),
(gst_xvimagesink_xoverlay_init), (gst_xvimagesink_init):
* sys/xvimage/xvimagesink.h: Implement expose method from XOverlay
interface
Benjamin Otte [Tue, 3 Feb 2004 22:51:33 +0000 (22:51 +0000)]
ext/gdk_pixbuf/gstgdkpixbuf.c: more memleak fixage
Original commit message from CVS:
2004-02-03 Benjamin Otte <in7y118@public.uni-hamburg.de>
* ext/gdk_pixbuf/gstgdkpixbuf.c: (gst_gdk_pixbuf_type_find):
more memleak fixage
Benjamin Otte [Tue, 3 Feb 2004 22:07:24 +0000 (22:07 +0000)]
fix memleaks shown by gst-typefind
Original commit message from CVS:
2004-02-03 Benjamin Otte <in7y118@public.uni-hamburg.de>
* ext/gdk_pixbuf/gstgdkpixbuf.c: (plugin_init):
* gst/typefind/gsttypefindfunctions.c:
fix memleaks shown by gst-typefind
Thomas Vander Stichele [Tue, 3 Feb 2004 20:27:24 +0000 (20:27 +0000)]
last glib_root standing
Original commit message from CVS:
last glib_root standing
Thomas Vander Stichele [Tue, 3 Feb 2004 20:20:07 +0000 (20:20 +0000)]
remove glib_root add hack rule for .Plo files
Original commit message from CVS:
remove glib_root
add hack rule for .Plo files
Benjamin Otte [Tue, 3 Feb 2004 18:42:49 +0000 (18:42 +0000)]
gst/qtdemux/qtdemux.c: set explicit caps before adding the element, so the autopluggers can plug correctly.
Original commit message from CVS:
2004-02-03 Benjamin Otte <in7y118@public.uni-hamburg.de>
* gst/qtdemux/qtdemux.c: (gst_qtdemux_add_stream):
set explicit caps before adding the element, so the autopluggers can
plug correctly.
* gst/typefind/gsttypefindfunctions.c: (mp3_type_find),
(mpeg2_sys_type_find), (mpeg1_sys_type_find),
(mpeg_video_type_find), (mpeg_video_stream_type_find),
(dv_type_find):
fix memleaks in typefind functions. gst_type_find_suggest takes a const
argument.
Thomas Vander Stichele [Tue, 3 Feb 2004 16:49:54 +0000 (16:49 +0000)]
use glib-gen.mak fix Makefile.am bugs and clean them up
Original commit message from CVS:
use glib-gen.mak
fix Makefile.am bugs and clean them up
Benjamin Otte [Tue, 3 Feb 2004 16:15:16 +0000 (16:15 +0000)]
ext/ogg/gstoggdemux.c: handle chain parsing correctly in the multichain case
Original commit message from CVS:
2004-02-03 Benjamin Otte <in7y118@public.uni-hamburg.de>
* ext/ogg/gstoggdemux.c: (gst_ogg_demux_chain):
handle chain parsing correctly in the multichain case
* ext/theora/theoradec.c: (gst_theora_dec_init), (_theora_ilog),
(theora_dec_from_granulepos), (theora_dec_to_granulepos),
(theora_dec_src_query), (theora_dec_src_event), (theora_dec_event),
(theora_dec_chain):
handle events and queries correctly
David I. Lehn [Tue, 3 Feb 2004 09:01:19 +0000 (09:01 +0000)]
.cvsignore: Ignore generated file _stdint.h.
Original commit message from CVS:
* .cvsignore:
Ignore generated file _stdint.h.
David I. Lehn [Tue, 3 Feb 2004 08:56:06 +0000 (08:56 +0000)]
gst-libs/gst/: Generate enum type code with glib-mkenums.
Original commit message from CVS:
* gst-libs/gst/colorbalance/Makefile.am:
* gst-libs/gst/colorbalance/colorbalance.h:
* gst-libs/gst/mixer/Makefile.am:
* gst-libs/gst/mixer/mixer.h:
* gst-libs/gst/play/Makefile.am:
* gst-libs/gst/play/play.h:
* gst-libs/gst/tuner/Makefile.am:
* gst-libs/gst/tuner/tuner.h:
Generate enum type code with glib-mkenums.
* gst-libs/gst/colorbalance/.cvsignore:
* gst-libs/gst/mixer/.cvsignore:
* gst-libs/gst/play/.cvsignore:
* gst-libs/gst/tuner/.cvsignore:
Ignore generated files.
David I. Lehn [Tue, 3 Feb 2004 08:52:58 +0000 (08:52 +0000)]
gst-libs/gst/audio/.cvsignore: Ignore generated file.
Original commit message from CVS:
* gst-libs/gst/audio/.cvsignore:
Ignore generated file.
* gst-libs/gst/audio/Makefile.am:
Do not install example filter.
David I. Lehn [Tue, 3 Feb 2004 08:50:41 +0000 (08:50 +0000)]
examples/switch/.cvsignore: Ignore generated file.
Original commit message from CVS:
* examples/switch/.cvsignore:
Ignore generated file.
Benjamin Otte [Tue, 3 Feb 2004 02:40:15 +0000 (02:40 +0000)]
co/: add AX_CREATE_STDINT_H to get correct type definitions for a52dec in _stdint.h.
Original commit message from CVS:
2004-02-03 Benjamin Otte <in7y118@public.uni-hamburg.de>
* common/m4/ax_create_stdint_h.m4:
* configure.ac:
add AX_CREATE_STDINT_H to get correct type definitions for a52dec in
_stdint.h.
* Makefile.am:
remove generated _stdint.h in DISTCLEANFILES
* ext/a52dec/gsta52dec.c:
include _stdint.h for a52dec. (should fix #133064)
Jeremy Simon [Mon, 2 Feb 2004 22:42:42 +0000 (22:42 +0000)]
gst/tags/gstvorbistag.c: Add replaygain support to vorbistag
Original commit message from CVS:
2004-02-02 Jeremy Simon <jesimon@libertysurf.fr>
* gst/tags/gstvorbistag.c: (gst_vorbis_tag_add),
(gst_tag_to_vorbis_comments):
Add replaygain support to vorbistag
Jeremy Simon [Mon, 2 Feb 2004 22:37:33 +0000 (22:37 +0000)]
ext/ffmpeg/gstffmpegcodecmap.c: Fix SVQ3 caps flag properties
Original commit message from CVS:
2004-02-02 Jeremy Simon <jesimon@libertysurf.fr>
* ext/ffmpeg/gstffmpegcodecmap.c: (gst_ffmpeg_codecid_to_caps),
(gst_ffmpeg_caps_to_extradata):
Fix SVQ3 caps flag properties
Use glib macro for bytes swap
Thomas Vander Stichele [Mon, 2 Feb 2004 22:25:38 +0000 (22:25 +0000)]
remove textdomain calls
Original commit message from CVS:
remove textdomain calls
Julien Moutte [Mon, 2 Feb 2004 22:18:38 +0000 (22:18 +0000)]
gst-libs/gst/play/play.c: Moving volume in the audio thread for instantaneous volume change. Maybe i will add another...
Original commit message from CVS:
2004-02-02 Julien MOUTTE <julien@moutte.net>
* gst-libs/gst/play/play.c: (gst_play_pipeline_setup),
(gst_play_set_audio_sink): Moving volume in the audio thread for
instantaneous volume change. Maybe i will add another volume in front
of visualization later, not sure yet though.
Julien Moutte [Mon, 2 Feb 2004 21:59:35 +0000 (21:59 +0000)]
sys/ximage/ximagesink.c: Better X events handling, only take the latest events for configure and motion.
Original commit message from CVS:
2004-02-02 Julien MOUTTE <julien@moutte.net>
* sys/ximage/ximagesink.c: (gst_ximagesink_renegotiate_size),
(gst_ximagesink_handle_xevents): Better X events handling, only take
the latest events for configure and motion.
* sys/xvimage/xvimagesink.c: (gst_xvimagesink_handle_xevents): same.
David Schleef [Mon, 2 Feb 2004 20:27:13 +0000 (20:27 +0000)]
Fix memory leaks:
Original commit message from CVS:
reviewed by: David Schleef <ds@schleef.org>
Fix memory leaks:
* ext/ffmpeg/gstffmpegdec.c: (gst_ffmpegdec_register):
* ext/ffmpeg/gstffmpegenc.c: (gst_ffmpegenc_register):
David Schleef [Mon, 2 Feb 2004 20:09:09 +0000 (20:09 +0000)]
code cleanup. Change bzero() to memset(). Remove duplicate ; at ends of lines.
Original commit message from CVS:
code cleanup. Change bzero() to memset(). Remove duplicate ; at ends
of lines.
* ext/cdparanoia/gstcdparanoia.c: (cdparanoia_event):
* ext/flac/gstflactag.c: (gst_flac_tag_chain):
* ext/xvid/gstxviddec.c: (gst_xviddec_src_link):
* gst-libs/gst/play/play.c: (gst_play_get_sink_element):
* gst/ac3parse/gstac3parse.c: (gst_ac3parse_chain):
* gst/effectv/gstedge.c: (gst_edgetv_sinkconnect):
* gst/effectv/gstvertigo.c: (gst_vertigotv_sinkconnect):
* gst/intfloat/float22int.c: (gst_float2_2_int_getcaps),
(gst_float2_2_int_link):
* gst/mpeg2sub/gstmpeg2subt.c: (gst_mpeg2subt_chain_subtitle):
* gst/rtjpeg/RTjpeg.c: (RTjpeg_init_mcompress):
* gst/tcp/gsttcpsink.c: (gst_tcpsink_init_send):
* gst/tcp/gsttcpsrc.c: (gst_tcpsrc_init_receive):
* gst/udp/gstudpsink.c: (gst_udpsink_init_send):
* gst/udp/gstudpsrc.c: (gst_udpsrc_init_receive):
* sys/v4l/gstv4lelement.c: (gst_v4lelement_init):
* sys/v4l2/v4l2src_calls.c: (gst_v4l2src_set_capture):
* testsuite/gst-lint: Add tests for bzero and ;;
David Schleef [Mon, 2 Feb 2004 18:28:45 +0000 (18:28 +0000)]
gst/debug/efence.c: Add fallback if MAP_ANONYMOUS isn't defined.
Original commit message from CVS:
* gst/debug/efence.c: Add fallback if MAP_ANONYMOUS isn't defined.
Thomas Vander Stichele [Mon, 2 Feb 2004 17:23:33 +0000 (17:23 +0000)]
change NULL to (NULL) for GST_ELEMENT_ERROR
Original commit message from CVS:
change NULL to (NULL) for GST_ELEMENT_ERROR
Make sure errors end with "."
Thomas Vander Stichele [Mon, 2 Feb 2004 16:11:29 +0000 (16:11 +0000)]
ignore files
Original commit message from CVS:
ignore files
Thomas Vander Stichele [Mon, 2 Feb 2004 14:34:52 +0000 (14:34 +0000)]
make code more readable by extracting magic numbers fix interface range
Original commit message from CVS:
make code more readable by extracting magic numbers
fix interface range
Thomas Vander Stichele [Mon, 2 Feb 2004 13:03:56 +0000 (13:03 +0000)]
adding files to be ignored
Original commit message from CVS:
adding files to be ignored
Thomas Vander Stichele [Mon, 2 Feb 2004 10:49:32 +0000 (10:49 +0000)]
block tick callback for 0.5 sec after a seek
Original commit message from CVS:
block tick callback for 0.5 sec after a seek
Thomas Vander Stichele [Mon, 2 Feb 2004 10:19:38 +0000 (10:19 +0000)]
check for NULLness and warn if we can't report GError
Original commit message from CVS:
check for NULLness and warn if we can't report GError
Julien Moutte [Sun, 1 Feb 2004 22:33:07 +0000 (22:33 +0000)]
gst-libs/gst/play/play.c: s/sinkconnect/sink_link
Original commit message from CVS:
2004-02-01 Julien MOUTTE <julien@moutte.net>
* gst-libs/gst/play/play.c: (gst_play_seek_to_time),
(gst_play_new): Accepting NULL GError, blocking time tick while seeking. * sys/ximage/ximagesink.c: (gst_ximagesink_sink_link),
(gst_ximagesink_chain), (gst_ximagesink_init): s/sinkconnect/sink_link
* sys/xvimage/xvimagesink.c: (gst_xvimagesink_sink_link),
(gst_xvimagesink_chain), (gst_xvimagesink_init): s/sinkconnect/sink_link
Thomas Vander Stichele [Sun, 1 Feb 2004 19:21:01 +0000 (19:21 +0000)]
add check for new function
Original commit message from CVS:
add check for new function
Benjamin Otte [Sat, 31 Jan 2004 20:57:21 +0000 (20:57 +0000)]
ext/alsa/gstalsa.c: really start/stop clock only on PLAYING <=> PAUSED
Original commit message from CVS:
2004-01-31 Benjamin Otte <in7y118@public.uni-hamburg.de>
* ext/alsa/gstalsa.c: (gst_alsa_change_state), (gst_alsa_start),
(gst_alsa_drain_audio), (gst_alsa_stop_audio):
really start/stop clock only on PLAYING <=> PAUSED
* ext/alsa/gstalsasink.c: (gst_alsa_sink_loop):
remove \n from debugging lines
* ext/ogg/gstoggdemux.c: (gst_ogg_demux_chain):
make it work when seeking does not
* ext/vorbis/vorbisdec.c: (vorbis_dec_event):
reset on DISCONT
Benjamin Otte [Sat, 31 Jan 2004 17:19:21 +0000 (17:19 +0000)]
ext/alsa/gstalsa.c: start clock on PAUSED=>PLAYING, not later
Original commit message from CVS:
2004-01-31 Benjamin Otte <in7y118@public.uni-hamburg.de>
* ext/alsa/gstalsa.c: (gst_alsa_change_state), (gst_alsa_start):
start clock on PAUSED=>PLAYING, not later
* ext/alsa/gstalsasink.c: (gst_alsa_sink_check_event):
extract correct time for different discont formats
(gst_alsa_sink_get_time):
don't segfault when no format is negotiated yet, just return 0
* ext/ogg/gstoggdemux.c: (gst_ogg_demux_src_event),
(gst_ogg_demux_handle_event), (gst_ogg_demux_push),
(gst_ogg_pad_push):
handle flush and discont events correctly
* ext/vorbis/vorbisdec.c: (vorbis_dec_event), (vorbis_dec_chain):
handle discont events correctly
Thomas Vander Stichele [Sat, 31 Jan 2004 15:56:32 +0000 (15:56 +0000)]
add error handling
Original commit message from CVS:
add error handling
Benjamin Otte [Sat, 31 Jan 2004 11:24:18 +0000 (11:24 +0000)]
ext/theora/theoradec.c: make comments work
Original commit message from CVS:
2004-01-31 Benjamin Otte <in7y118@public.uni-hamburg.de>
* ext/theora/theoradec.c: (theora_dec_chain):
make comments work
* ext/vorbis/vorbisdec.c: (vorbis_dec_src_query),
(vorbis_dec_src_event), (vorbis_dec_chain):
add encoder tag, fix tag reading to be more error tolerant, change
BITRATE to NOMINAL_BITRATE, add debugging, don't unref events after
gst_pad_event_default.
* gst/tags/gstvorbistag.c:
(gst_tag_list_from_vorbiscomment_buffer):
undefine function specific define at end of function
Jeremy Simon [Sat, 31 Jan 2004 10:25:05 +0000 (10:25 +0000)]
ext/flac/: Fix typos
Original commit message from CVS:
2004-01-31 Jeremy Simon <jesimon@libertysurf.fr>
* ext/flac/gstflacdec.c: (gst_flacdec_class_init):
* ext/flac/gstflacdec.h:
* ext/flac/gstflacenc.h:
Fix typos
David I. Lehn [Sat, 31 Jan 2004 00:29:21 +0000 (00:29 +0000)]
examples/gstplay/player.c: s/gstplay.h/play.h/
Original commit message from CVS:
* examples/gstplay/player.c: s/gstplay.h/play.h/
Thomas Vander Stichele [Fri, 30 Jan 2004 22:38:56 +0000 (22:38 +0000)]
done operating
Original commit message from CVS:
done operating
Thomas Vander Stichele [Fri, 30 Jan 2004 22:03:14 +0000 (22:03 +0000)]
removing deprecated code
Original commit message from CVS:
removing deprecated code
Thomas Vander Stichele [Fri, 30 Jan 2004 20:57:41 +0000 (20:57 +0000)]
add debug info flush after seek (julien)
Original commit message from CVS:
add debug info
flush after seek (julien)
Benjamin Otte [Fri, 30 Jan 2004 20:34:43 +0000 (20:34 +0000)]
add bit of info
Original commit message from CVS:
add bit of info
Benjamin Otte [Fri, 30 Jan 2004 20:23:24 +0000 (20:23 +0000)]
configure.ac: use AC_C_INLINE
Original commit message from CVS:
2004-01-30 Benjamin Otte <in7y118@public.uni-hamburg.de>
* configure.ac:
use AC_C_INLINE
* configure.ac:
* ext/Makefile.am:
* ext/theora/Makefile.am:
* ext/theora/theoradec.c:
add theora video decoder. Does just do simple decoding for now and
has been tested against Theora cvs only.
* ext/vorbis/vorbisdec.c: (vorbis_dec_event):
always reset packetno on DISCONT
Ronald S. Bultje [Fri, 30 Jan 2004 14:39:37 +0000 (14:39 +0000)]
gst/mpegstream/gstmpegdemux.c: Fix audio.
Original commit message from CVS:
2004-01-30 Ronald Bultje <rbultje@ronald.bitfreak.net>
* gst/mpegstream/gstmpegdemux.c: (gst_mpeg_demux_parse_syshead):
Fix audio.
Ronald S. Bultje [Fri, 30 Jan 2004 14:23:18 +0000 (14:23 +0000)]
gst/mpegaudioparse/gstmpegaudioparse.c: Fix header parsing - stolen from ffmpeg (thank you! :) ).
Original commit message from CVS:
2004-01-30 Ronald Bultje <rbultje@ronald.bitfreak.net>
* gst/mpegaudioparse/gstmpegaudioparse.c:
(mp3_type_frame_length_from_header):
Fix header parsing - stolen from ffmpeg (thank you! :) ).
Ronald S. Bultje [Fri, 30 Jan 2004 12:52:12 +0000 (12:52 +0000)]
ext/esd/esdsink.c: Since we have static pad template caps, we don't need to negotiate; either the core errors out or ...
Original commit message from CVS:
2004-01-30 Ronald Bultje <rbultje@ronald.bitfreak.net>
* ext/esd/esdsink.c: (gst_esdsink_init):
Since we have static pad template caps, we don't need to negotiate;
either the core errors out or we know the format.
Ronald S. Bultje [Fri, 30 Jan 2004 12:37:58 +0000 (12:37 +0000)]
gst/: Fix event handling.
Original commit message from CVS:
2004-01-30 Ronald Bultje <rbultje@ronald.bitfreak.net>
* gst-libs/gst/riff/riff-read.c: (gst_riff_peek_head),
(gst_riff_read_seek):
* gst/matroska/ebml-read.c: (gst_ebml_read_element_id),
(gst_ebml_read_seek):
Fix event handling.
Benjamin Otte [Fri, 30 Jan 2004 03:59:03 +0000 (03:59 +0000)]
fix compile error on unforgiving Gentoo compiler
Original commit message from CVS:
fix compile error on unforgiving Gentoo compiler
Benjamin Otte [Fri, 30 Jan 2004 03:51:04 +0000 (03:51 +0000)]
ext/ffmpeg/gstffmpegcodecmap.c: removee video/x-theora from vp3 decoder, it doesn't handle raw theora streams
Original commit message from CVS:
2004-01-30 Benjamin Otte <in7y118@public.uni-hamburg.de>
* ext/ffmpeg/gstffmpegcodecmap.c: (gst_ffmpeg_codecid_to_caps):
removee video/x-theora from vp3 decoder, it doesn't handle raw
theora streams
* ext/ogg/gstoggdemux.c: (gst_ogg_demux_init):
fix bug with finalizing element that never went to PAUSED
* ext/ogg/gstoggdemux.c: (gst_ogg_demux_src_query):
length and position queries were swapped
* ext/vorbis/vorbisdec.c: (gst_vorbis_dec_init),
(vorbis_dec_from_granulepos), (vorbis_dec_src_query),
(vorbis_dec_src_event):
implement querying time and bytes
Thomas Vander Stichele [Thu, 29 Jan 2004 23:20:45 +0000 (23:20 +0000)]
GST_ELEMENT_ERROR
Original commit message from CVS:
GST_ELEMENT_ERROR
Julien Moutte [Thu, 29 Jan 2004 22:44:42 +0000 (22:44 +0000)]
ext/gnomevfs/gstgnomevfssrc.c: Fixing seeking emiting FLUSH and even before DISCONT.
Original commit message from CVS:
2004-01-29 Julien MOUTTE <julien@moutte.net>
* ext/gnomevfs/gstgnomevfssrc.c: (gst_gnomevfssrc_get): Fixing seeking
emiting FLUSH and even before DISCONT.
* gst-libs/gst/play/gstplay.c: (gst_play_seek_to_time): Fix seeking to
get the best instant seeking as possible yay!
Ronald S. Bultje [Thu, 29 Jan 2004 16:00:55 +0000 (16:00 +0000)]
gst/mpeg1videoparse/gstmp1videoparse.c: Committed wrong version last week... Grr... Didn't notice until now.
Original commit message from CVS:
2004-01-29 Ronald Bultje <rbultje@ronald.bitfreak.net>
* gst/mpeg1videoparse/gstmp1videoparse.c:
(gst_mp1videoparse_real_chain):
Committed wrong version last week... Grr... Didn't notice until now.
Julien Moutte [Thu, 29 Jan 2004 10:02:48 +0000 (10:02 +0000)]
sys/: Emit the have_xwindow_id signal in xwindow_create.
Original commit message from CVS:
2004-01-29 Julien MOUTTE <julien@moutte.net>
* sys/ximage/ximagesink.c: (gst_ximagesink_xwindow_new):
* sys/xvimage/xvimagesink.c: (gst_xvimagesink_xwindow_new): Emit the
have_xwindow_id signal in xwindow_create.
Benjamin Otte [Thu, 29 Jan 2004 02:50:20 +0000 (02:50 +0000)]
ext/ogg/gstoggdemux.c: lots of changes - mainly support for chained bitstreams, seeking, querying and bugfixes of course
Original commit message from CVS:
2004-01-29 Benjamin Otte <in7y118@public.uni-hamburg.de>
* ext/ogg/gstoggdemux.c:
lots of changes - mainly support for chained bitstreams, seeking,
querying and bugfixes of course
* ext/vorbis/Makefile.am:
* ext/vorbis/vorbisdec.c:
* ext/vorbis/vorbisdec.h:
add vorbisdec raw vorbis decoder
* ext/vorbis/vorbis.c: (plugin_init):
register vorbisdec as PRIMARY, vorbisfile as SECONDARY
* gst/intfloat/Makefile.am:
* gst/intfloat/float22int.c:
* gst/intfloat/float22int.h:
* gst/intfloat/gstintfloatconvert.c: (plugin_init):
add float2intnew plugin. It converts multichannel interleaved float to
multichannel interleaved int. The name should probably be changed.
* gst/typefind/gsttypefindfunctions.c: (theora_type_find),
(plugin_init):
add typefinding for raw theora video so oggdemux can detect it.
Julien Moutte [Wed, 28 Jan 2004 22:14:14 +0000 (22:14 +0000)]
gst-libs/gst/play/gstplay.c: seek on video sink element first.
Original commit message from CVS:
2004-01-28 Julien MOUTTE <julien@moutte.net>
* gst-libs/gst/play/gstplay.c: (gst_play_seek_to_time): seek on video
sink element first.
* gst/videoscale/gstvideoscale.c:
(gst_videoscale_handle_src_event): Fixing src event handler.
Ronald S. Bultje [Wed, 28 Jan 2004 21:16:01 +0000 (21:16 +0000)]
sys/v4l/: Implement resizing... Hack. But that's why v4l is b0rked...
Original commit message from CVS:
2004-01-28 Ronald Bultje <rbultje@ronald.bitfreak.net>
* sys/v4l/gstv4lsrc.c: (gst_v4lsrc_class_init), (gst_v4lsrc_init),
(gst_v4lsrc_open), (gst_v4lsrc_close),
(gst_v4lsrc_palette_to_caps), (gst_v4lsrc_srcconnect),
(gst_v4lsrc_getcaps), (gst_v4lsrc_set_clock):
* sys/v4l/gstv4lsrc.h:
* sys/v4l/v4lsrc_calls.c: (gst_v4lsrc_capture_start),
(gst_v4lsrc_grab_frame), (gst_v4lsrc_capture_stop):
Implement resizing... Hack. But that's why v4l is b0rked...
Julien Moutte [Wed, 28 Jan 2004 10:45:33 +0000 (10:45 +0000)]
sys/: Removing some useless debugs messages, correctly cleaning the image created to check xshm calls on succes, adde...
Original commit message from CVS:
2004-01-28 Julien MOUTTE <julien@moutte.net>
* sys/ximage/ximagesink.c: (gst_ximagesink_check_xshm_calls),
(gst_ximagesink_ximage_new), (gst_ximagesink_ximage_destroy),
(gst_ximagesink_ximage_put), (gst_ximagesink_xwindow_new),
(gst_ximagesink_xwindow_destroy):
* sys/xvimage/xvimagesink.c: (gst_xvimagesink_check_xshm_calls),
(gst_xvimagesink_xvimage_new), (gst_xvimagesink_xvimage_destroy),
(gst_xvimagesink_xwindow_new), (gst_xvimagesink_xwindow_destroy),
(gst_xvimagesink_xwindow_resize), (gst_xvimagesink_get_xv_support),
(gst_xvimagesink_xcontext_get): Removing some useless debugs messages,
correctly cleaning the image created to check xshm calls on succes,
added a lot of XSync calls in X11 functions, and fixed a segfault when
no image format was defined before negotiation happened.
Benjamin Otte [Wed, 28 Jan 2004 05:21:23 +0000 (05:21 +0000)]
ext/alsa/gstalsa.c: use gst_element_get_time to get correct time
Original commit message from CVS:
2004-01-28 Benjamin Otte <in7y118@public.uni-hamburg.de>
* ext/alsa/gstalsa.c: (gst_alsa_query_func):
use gst_element_get_time to get correct time
Julien Moutte [Wed, 28 Jan 2004 00:29:42 +0000 (00:29 +0000)]
sys/: Our
Original commit message from CVS:
2004-01-28 Julien MOUTTE <julien@moutte.net>
* sys/ximage/ximagesink.c: (gst_ximagesink_handle_xerror),
(gst_ximagesink_check_xshm_calls), (gst_ximagesink_ximage_destroy),
(gst_ximagesink_xcontext_get), (gst_ximagesink_class_init):
* sys/xvimage/xvimagesink.c: (gst_xvimagesink_handle_xerror),
(gst_xvimagesink_check_xshm_calls),
(gst_xvimagesink_xvimage_destroy), (gst_xvimagesink_xcontext_get): Our
X plugins are now able to detect that XShm calls will fail even if the
server claims that it has XShm support (remote displays most of the
time). We then log the error as a GST_DEBUG and set use_shm to FALSE
so that we use non XShm functions. This feature is almost useless for
xvimagesink as Xv is not supported on remote displays anyway, but
it might happen than even on the local display XShm calls fail.
David Schleef [Tue, 27 Jan 2004 21:37:36 +0000 (21:37 +0000)]
ext/esd/esdsink.c: Fix sync issues in esdsink. Also changed esdsink to only use 44100,16,2, since esd sucks at rate ...
Original commit message from CVS:
* ext/esd/esdsink.c: (gst_esdsink_class_init), (gst_esdsink_init),
(gst_esdsink_link), (gst_esdsink_get_time), (gst_esdsink_chain),
(gst_esdsink_change_state): Fix sync issues in esdsink. Also
changed esdsink to only use 44100,16,2, since esd sucks at rate
conversion and esdsink has had difficulty negotiating.
Julien Moutte [Tue, 27 Jan 2004 21:24:14 +0000 (21:24 +0000)]
gst-libs/gst/play/gstplay.c: Fixing the way to get current position.
Original commit message from CVS:
2004-01-27 Julien MOUTTE <julien@moutte.net>
* gst-libs/gst/play/gstplay.c: (gst_play_tick_callback),
(gst_play_seek_to_time): Fixing the way to get current position.
Benjamin Otte [Tue, 27 Jan 2004 20:40:37 +0000 (20:40 +0000)]
sys/oss/gstosssink.c: use gst_element_get_time to get correct time
Original commit message from CVS:
2004-01-27 Benjamin Otte <in7y118@public.uni-hamburg.de>
* sys/oss/gstosssink.c: (gst_osssink_sink_query):
use gst_element_get_time to get correct time
Julien Moutte [Tue, 27 Jan 2004 16:42:40 +0000 (16:42 +0000)]
gst-libs/gst/play/gstplay.c: The easiest fix ever... Inverting 2 lines of code make spider autoplug correctly tagged ...
Original commit message from CVS:
2004-01-27 Julien MOUTTE <julien@moutte.net>
* gst-libs/gst/play/gstplay.c: (gst_play_set_location): The easiest
fix ever... Inverting 2 lines of code make spider autoplug correctly
tagged mp3 !
David Schleef [Tue, 27 Jan 2004 09:05:22 +0000 (09:05 +0000)]
gst/audioconvert/gstaudioconvert.c: Use gst_pad_try_set_caps_nonfixed().
Original commit message from CVS:
* gst/audioconvert/gstaudioconvert.c: (gst_audio_convert_link):
Use gst_pad_try_set_caps_nonfixed().
David Schleef [Tue, 27 Jan 2004 09:00:01 +0000 (09:00 +0000)]
gst/ac3parse/gstac3parse.c: update to checklist 5
Original commit message from CVS:
* gst/ac3parse/gstac3parse.c: update to checklist 5
* gst/adder/gstadder.c: rewrite negotiation. update to checklist 5
* gst/audioconvert/gstaudioconvert.c: update to checklist 5
* gst/audioscale/gstaudioscale.c: same
* gst/auparse/gstauparse.c: same
* gst/avi/gstavidemux.c: same
Benjamin Otte [Tue, 27 Jan 2004 01:53:27 +0000 (01:53 +0000)]
gst/asfdemux/gstasfdemux.c: stop processing after EOS
Original commit message from CVS:
2004-01-27 Benjamin Otte <in7y118@public.uni-hamburg.de>
* gst/asfdemux/gstasfdemux.c: (gst_asf_demux_handle_sink_event):
stop processing after EOS
Benjamin Otte [Tue, 27 Jan 2004 01:27:04 +0000 (01:27 +0000)]
gst/asfdemux/: lot's of fixes to make data extraction simpler and get the code architecture and compiler independant....
Original commit message from CVS:
2004-01-27 Benjamin Otte <in7y118@public.uni-hamburg.de>
* gst/asfdemux/asfheaders.h:
* gst/asfdemux/gstasfdemux.c:
* gst/asfdemux/gstasfmux.c: (gst_asfmux_put_guid),
(gst_asfmux_put_string), (gst_asfmux_put_wav_header),
(gst_asfmux_put_vid_header), (gst_asfmux_put_bmp_header):
lot's of fixes to make data extraction simpler and get the code
architecture and compiler independant. Add debugging category
* gst/goom/gstgoom.c: (gst_goom_change_state):
reset channel count on PAUSED=>READY, not READY=>PAUSED
Colin Walters [Mon, 26 Jan 2004 22:17:08 +0000 (22:17 +0000)]
ext/gnomevfs/gstgnomevfssrc.c (gst_gnomevfssrc_get): Remove ugly code to pull a bigger buffer in iradio mode. This a...
Original commit message from CVS:
2004-01-26 Colin Walters <walters@verbum.org>
* ext/gnomevfs/gstgnomevfssrc.c (gst_gnomevfssrc_get): Remove ugly
code to pull a bigger buffer in iradio mode. This as a side effect
makes typefinding work.
Jeremy Simon [Mon, 26 Jan 2004 21:04:32 +0000 (21:04 +0000)]
ext/ffmpeg/gstffmpegcodecmap.c: Fix SVQ3 decoding on PPC
Original commit message from CVS:
2004-01-26 Jeremy Simon <jesimon@libertysurf.fr>
* ext/ffmpeg/gstffmpegcodecmap.c: (gst_ffmpeg_caps_to_extradata):
Fix SVQ3 decoding on PPC
Julien Moutte [Mon, 26 Jan 2004 20:12:31 +0000 (20:12 +0000)]
gst/videoscale/gstvideoscale.c: Dunno how that one managed to stay there... Fixed.
Original commit message from CVS:
2004-01-26 Julien MOUTTE <julien@moutte.net>
* gst/videoscale/gstvideoscale.c: (gst_videoscale_chain): Dunno how
that one managed to stay there... Fixed.
Jeremy Simon [Mon, 26 Jan 2004 20:01:35 +0000 (20:01 +0000)]
Add SVQ3 specific flags to qtdemux and ffmpeg
Original commit message from CVS:
2004-01-26 Jeremy Simon <jesimon@libertysurf.fr>
* ext/ffmpeg/gstffmpegcodecmap.c: (gst_ffmpeg_codecid_to_caps),
(gst_ffmpeg_caps_to_extradata), (gst_ffmpeg_caps_to_pixfmt):
* gst/qtdemux/qtdemux.c: (plugin_init), (qtdemux_parse_trak),
(qtdemux_video_caps):
* gst/qtdemux/qtdemux.h:
Add SVQ3 specific flags to qtdemux and ffmpeg
Benjamin Otte [Mon, 26 Jan 2004 03:54:21 +0000 (03:54 +0000)]
gst-libs/gst/audio/audio.h: remove buffer-frames from audio caps
Original commit message from CVS:
2004-01-26 Benjamin Otte <in7y118@public.uni-hamburg.de>
* gst-libs/gst/audio/audio.h:
remove buffer-frames from audio caps
* gst/audioconvert/gstaudioconvert.c:
fix plugin to really work.
Ronald S. Bultje [Sun, 25 Jan 2004 22:07:16 +0000 (22:07 +0000)]
gst-libs/gst/: Add gtk-doc style comments. Also fix a function name.
Original commit message from CVS:
2004-01-25 Ronald Bultje <rbultje@ronald.bitfreak.net>
* gst-libs/gst/mixer/mixer.c:
* gst-libs/gst/propertyprobe/propertyprobe.c:
* gst-libs/gst/tuner/tuner.c: (gst_tuner_find_norm_by_name),
(gst_tuner_find_channel_by_name):
* gst-libs/gst/tuner/tuner.h:
Add gtk-doc style comments. Also fix a function name.
Benjamin Otte [Sun, 25 Jan 2004 16:12:14 +0000 (16:12 +0000)]
add cvsignore file
Original commit message from CVS:
add cvsignore file
Ronald S. Bultje [Sun, 25 Jan 2004 12:31:29 +0000 (12:31 +0000)]
ext/divx/gstdivxdec.c: Fix for new capsnego - also fixes gst-player with divxdec.
Original commit message from CVS:
2004-01-25 Ronald Bultje <rbultje@ronald.bitfreak.net>
* ext/divx/gstdivxdec.c: (gst_divxdec_init),
(gst_divxdec_negotiate):
Fix for new capsnego - also fixes gst-player with divxdec.
Julien Moutte [Sun, 25 Jan 2004 12:28:05 +0000 (12:28 +0000)]
gst-libs/gst/play/gstplay.c: Another try in visualization implementation. Still have an issue with switch blocking wh...
Original commit message from CVS:
2004-01-25 Julien MOUTTE <julien@moutte.net>
* gst-libs/gst/play/gstplay.c: (gst_play_pipeline_setup),
(gst_play_identity_handoff), (gst_play_set_location),
(gst_play_set_visualization), (gst_play_connect_visualization): Another
try in visualization implementation. Still have an issue with switch
blocking when pulling from video_queue and only audio comes out of
spider.
* gst/switch/gstswitch.c: (gst_switch_release_pad),
(gst_switch_poll_sinkpads), (gst_switch_class_init): Implementing pad
release method. And check if the pad is usable before pulling.
Ronald S. Bultje [Sun, 25 Jan 2004 11:17:11 +0000 (11:17 +0000)]
gst/videofilter/gstvideobalance.*: Implement lookup-tables. +/- 10x faster.
Original commit message from CVS:
2004-01-25 Ronald Bultje <rbultje@ronald.bitfreak.net>
* gst/videofilter/gstvideobalance.c: (gst_videobalance_dispose),
(gst_videobalance_init),
(gst_videobalance_colorbalance_list_channels),
(gst_videobalance_colorbalance_set_value),
(gst_videobalance_colorbalance_get_value),
(gst_videobalance_update_properties),
(gst_videobalance_update_tables_planar411),
(gst_videobalance_planar411):
* gst/videofilter/gstvideobalance.h:
Implement lookup-tables. +/- 10x faster.
Ronald S. Bultje [Sun, 25 Jan 2004 00:43:16 +0000 (00:43 +0000)]
gst/avi/gstavidemux.c: The index reading was broken. The rest worked fine, but the whole goal of my rewrite was to ma...
Original commit message from CVS:
2004-01-25 Ronald Bultje <rbultje@ronald.bitfreak.net>
* gst/avi/gstavidemux.c: (gst_avi_demux_stream_avih),
(gst_avi_demux_stream_odml), (gst_avi_demux_stream_index):
The index reading was broken. The rest worked fine, but the whole
goal of my rewrite was to make avidemux readable, and this was
not at all readable. Please use typed variables.
Ronald S. Bultje [Sun, 25 Jan 2004 00:25:16 +0000 (00:25 +0000)]
gst-libs/gst/riff/riff-read.c: Additional pad usability check.
Original commit message from CVS:
2004-01-25 Ronald Bultje <rbultje@ronald.bitfreak.net>
* gst-libs/gst/riff/riff-read.c: (gst_riff_read_info):
Additional pad usability check.
* gst/mpeg1videoparse/gstmp1videoparse.c: (gst_mp1videoparse_init),
(mp1videoparse_find_next_gop), (gst_mp1videoparse_time_code),
(gst_mp1videoparse_real_chain):
Fix MPEG video stream parsing. The original plugin had several
issues, including not timestamping streams where the source was
not timestamped (this happens with PTS values in mpeg system
streams, but MPEG video is also a valid stream on its own so
that needs timestamps too). We use the display time code for that
for now. Also, if one incoming buffer contains multiple valid
frames, we push them all on correctly now, including proper EOS
handling. Lastly, several potential segfaults were fixed, and we
properly sync on new sequence/gop headers to include them in next,
not previous frames (since they're header for the next frame, not
the previous). Also see #119206.
* gst/mpegaudioparse/gstmpegaudioparse.c: (gst_mp3parse_chain),
(bpf_from_header):
Move caps setting so we only do it after finding several valid
MPEG-1 fraes sequentially, not right after the first one (which
might be coincidental).
* gst/typefind/gsttypefindfunctions.c: (mpeg1_sys_type_find),
(mpeg_video_type_find), (mpeg_video_stream_type_find),
(plugin_init):
Add unsynced MPEG video stream typefinding, and change some
probability values so we detect streams rightly. The idea is as
follows: I can have an unsynced system stream which contains
video. In the current code, I would randomly get a type for either
system or video stream type found, because the probabilities are
being calculated rather randomly. I now use fixed values, so we
always prefer system stream if that was found (and that is how it
should be). If no system stream was found, we can still identity
the stream as video-only.
Benjamin Otte [Fri, 23 Jan 2004 17:45:54 +0000 (17:45 +0000)]
gst/avi/gstavidemux.c: don't write to buffer. Extract data without the need of __attribute__ ((packed))
Original commit message from CVS:
2004-01-23 Benjamin Otte <in7y118@public.uni-hamburg.de>
* gst/avi/gstavidemux.c: (gst_avi_demux_stream_avih),
(gst_avi_demux_stream_odml), (gst_avi_demux_stream_index):
don't write to buffer. Extract data without the need of
__attribute__ ((packed))
Ronald S. Bultje [Fri, 23 Jan 2004 16:55:21 +0000 (16:55 +0000)]
gst/typefind/gsttypefindfunctions.c: Fix MPEG-1 stream typefinding.
Original commit message from CVS:
2004-01-23 Ronald Bultje <rbultje@ronald.bitfreak.net>
* gst/typefind/gsttypefindfunctions.c: (mpeg1_parse_header),
(mpeg1_sys_type_find):
Fix MPEG-1 stream typefinding.
Ronald S. Bultje [Fri, 23 Jan 2004 16:01:04 +0000 (16:01 +0000)]
gst/typefind/gsttypefindfunctions.c: Fix typefinding for MPEG-1 system streams, similar to MPEG-2.
Original commit message from CVS:
2004-01-23 Ronald Bultje <rbultje@ronald.bitfreak.net>
* gst/typefind/gsttypefindfunctions.c: (mpeg2_sys_type_find):
Fix typefinding for MPEG-1 system streams, similar to MPEG-2.
Thomas Vander Stichele [Fri, 23 Jan 2004 15:34:49 +0000 (15:34 +0000)]
private debugging cat better error reporting
Original commit message from CVS:
private debugging cat
better error reporting