Bruce Forstall [Wed, 3 Apr 2019 17:02:27 +0000 (10:02 -0700)]
Merge pull request dotnet/coreclr#23670 from BruceForstall/FixArmAltjitAsmDiffs
Fix arm altjit asm diffs
Commit migrated from https://github.com/dotnet/coreclr/commit/
17add60f708fa55a5447a67851783ab98e01f0cf
Brian Robbins [Wed, 3 Apr 2019 15:48:26 +0000 (08:48 -0700)]
Emit event for calls to ReadyToRunInfo::GetEntryPoint. (dotnet/coreclr#23662)
Commit migrated from https://github.com/dotnet/coreclr/commit/
dffb3d30790131166c848283947125c59e428f38
dotnet-maestro-bot [Wed, 3 Apr 2019 15:31:52 +0000 (08:31 -0700)]
Update CoreClr to preview4-27603-71 (dotnet/coreclr#23679)
Commit migrated from https://github.com/dotnet/coreclr/commit/
efdfa1715ca4768521eb40eb295779c92ea97b87
Koundinya Veluri [Wed, 3 Apr 2019 13:51:43 +0000 (06:51 -0700)]
[Preview 4] Disable tier 0 JIT (quick JIT) by default, rename config option (dotnet/coreclr#23599)
Disable tier 0 JIT (quick JIT) by default, rename config option
- Tier 0 JIT is being called quick JIT in config options, renamed DisableTier0Jit to StartupTierQuickJit
- Disabled quick JIT by default, the current plan is to do that for preview 4
- Concerns were that code produced by quick JIT may be slow, may allocate more, may use more stack space, and may be much larger than optimized code, and there there may be many cases where these things lead to regressions when the span of time between startup and steady-state is important
- The thought was that with quick JIT disabled, tiering overhead from call counting and backgorund jitting with optimizations would be less, and perf during any point in time would be closer to 2.x releases
- This mostly loses the startup perf gains from tiering. It may also be slightly slower compared with tiering off due to some overhead. When quick JIT is disabled for the startup tier, made a change to disable tiered compilation for methods in modules that are not R2R'ed since they will not be tiered currently anyway. The overhead and regression in R2R'ed modules will be looked into separately to see if it can be reduced.
Fixes https://github.com/dotnet/coreclr/issues/22998
Fixes https://github.com/dotnet/coreclr/issues/19751
Commit migrated from https://github.com/dotnet/coreclr/commit/
b4390c41f29af20e4cb77d296940bb6c4649ee86
Jeremy Koritzinsky [Wed, 3 Apr 2019 11:21:16 +0000 (04:21 -0700)]
Treat WinMDs as having been loaded in the default ALC for AssemblyLoadContext.GetLoadContext (dotnet/coreclr#23678)
Commit migrated from https://github.com/dotnet/coreclr/commit/
5144947b45832e170b2eb3b8f909ec49d7122eaa
Jan Kotas [Tue, 2 Apr 2019 21:41:49 +0000 (14:41 -0700)]
Avoid unnecessary SetLastError on PInvokes (dotnet/corefxdotnet/coreclr#36544)
These console PInvokes are used in nearly every app. Omitting unnecessary SetLastError
will save us from generating marshalling stub for them.
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/
aab338efb65808acc1ff9b7f95bd3dd5f0a6a3be
Brian Sullivan [Wed, 3 Apr 2019 00:57:00 +0000 (17:57 -0700)]
Merge pull request dotnet/coreclr#23668 from briansull/pipeline-work
Remove a few Check builds and Check tests for PullRequests
Commit migrated from https://github.com/dotnet/coreclr/commit/
c007aec8171b74858147da283754a0ba85bff750
Tanner Gooding [Wed, 3 Apr 2019 00:06:27 +0000 (17:06 -0700)]
Updating the HWIntrinsic x86 codegen to handle indir nodes. (dotnet/coreclr#23629)
* Updating the SimpleBinOpTest.template to cover some additional containment scenarios
* Regenerating the x86 HWIntrinsic tests from their templates
* Updating the HWIntrinsic x86 codegen to handle indir nodes.
Commit migrated from https://github.com/dotnet/coreclr/commit/
a3defe122ceb580860daf01ae7c9c007280a08e3
Egor Chesakov [Tue, 2 Apr 2019 23:57:20 +0000 (16:57 -0700)]
Disable *.Arm32.Open in PullRequest and remove two queues from scheduled builds (dotnet/coreclr#23677)
Commit migrated from https://github.com/dotnet/coreclr/commit/
722a2226cf4ac246624f903f5b5be14ceb46f92d
Jeremy Koritzinsky [Tue, 2 Apr 2019 23:39:11 +0000 (16:39 -0700)]
Change tests to not modify Core_Root (dotnet/coreclr#23470)
Redesign tests that needed to modify Core_Root to no longer do so.
- Loader.FromNativePaths: Use `CORE_LIBRARIES` instead of `COREROOT`
- Loader.AssemblyDependencyResolver: Split out the invalid hosting test that needs hostpolicy to not be preloaded. Have `CoreRun` and `CoreShim` preload hostpolicy when a path to a hostpolicy is specified in the `MOCK_HOSTPOLICY` environment variable.
- Add a `CLRTest.MockHosting.targets` file that is imported when a test requires hostpolicy. It adds the reference to the mock hostpolicy and ensures that the `MOCK_HOSTPOLICY` environment variable is correctly set in the test scripts.
Fixes dotnet/coreclr#23429.
Commit migrated from https://github.com/dotnet/coreclr/commit/
2516a53b75ef74b585cc507e07d39e37675993b9
Carol Eidt [Tue, 2 Apr 2019 22:54:26 +0000 (15:54 -0700)]
Fix spill check for struct lclVars (dotnet/coreclr#23570)
* Fix spill check for struct lclVars
With the 1st class struct changes, the `SPILL_APPEND` check for the case of an assignment to a lclVar needs to handle block ops as well as lclVar lhs.
Fix dotnet/coreclr#23545
Commit migrated from https://github.com/dotnet/coreclr/commit/
f036d2339b030258bf31bc73ebc23f553744fa04
Bruce Forstall [Tue, 2 Apr 2019 22:22:17 +0000 (15:22 -0700)]
Fix arm altjit asm diffs
At shutdown, the VM iterates over generated code as part of ETW
"rundown". This currently includes altjit generated code. It calls
functions which interprets the code as native code, e.g., arm32
GC info as x86 GC info.
The fix is to make a call to BackoutJitData(), which was already
suggested in the comments. This removes the altjit generated code
from the "nibble map", and hence from the iteration.
Fixes dotnet/coreclr#23393
Commit migrated from https://github.com/dotnet/coreclr/commit/
bbf911341441941ecb42767b6f4e9441b1de9e78
Jan Vorlicek [Tue, 2 Apr 2019 22:08:58 +0000 (00:08 +0200)]
Merge pull request dotnet/coreclr#23521 from k15tfu/fix-issue-20784
Move C/C++ and platform headers to pal/inc/rt/cpp folder
Commit migrated from https://github.com/dotnet/coreclr/commit/
8053b7db57a6b95fa61f7c22f8bfcd277ef136bd
Brian Sullivan [Tue, 2 Apr 2019 21:46:27 +0000 (14:46 -0700)]
Reduce Check build and Check tests for PullRequest to
- Linux_arm
- Linux_arm64
- Linux_musl_x64
- Linux_x64
- OSX_x64
- Windows_NT_arm
- Windows_NT_arm64
- Windows_NT_x64
- Windows_NT_x86
Commit migrated from https://github.com/dotnet/coreclr/commit/
86b717d8c056d234bd33a5ce8019727ec32ff7e7
Brian Sullivan [Tue, 2 Apr 2019 21:05:16 +0000 (14:05 -0700)]
Merge pull request dotnet/coreclr#23565 from briansull/pipeline-work
Move to outerloop - several azure-pipeline jobs
Commit migrated from https://github.com/dotnet/coreclr/commit/
4defb6ccb57d5dc719aa7f51fb4cab1f168c9e44
William Godbe [Tue, 2 Apr 2019 18:22:19 +0000 (11:22 -0700)]
Merge pull request dotnet/coreclr#23601 from dotnet-maestro-bot/master-UpdateDependencies
Update CoreClr to preview4-27602-71 (master)
Commit migrated from https://github.com/dotnet/coreclr/commit/
4092c9b98caa4c10d29b3bcd347b33a5b119bd17
Fadi Hanna [Tue, 2 Apr 2019 17:41:49 +0000 (10:41 -0700)]
Output error messages to stderr. This provides a better integration with the .NET SDK (dotnet/coreclr#23658)
Commit migrated from https://github.com/dotnet/coreclr/commit/
28dd0b05804bcde13737bbc834d955352f327b54
Andy Ayers [Tue, 2 Apr 2019 16:06:32 +0000 (09:06 -0700)]
JIT: prolog zeroing accounting changes (dotnet/coreclr#23498)
Stop double-counting some locals when computing how many slots need to be
zeroed in the prolog.
Bump threshold for rep stosb style init from 16 bytes to 32 bytes on x64.
Commit migrated from https://github.com/dotnet/coreclr/commit/
900ae5b766aa0267d613c119f9bf3a90af02e048
José Rivero [Tue, 2 Apr 2019 14:06:42 +0000 (07:06 -0700)]
[EventPipe] Streaming events out-of-proc using IPC (dotnet/coreclr#23448)
- There was a race condition on EventPipe::Disable where we deallocated the s_pSession and set it to NULL, but there was still a thread waiting to write and dereference the null pointer. Now, we check that the session is not null.
- Added a new attach event to be handled to the Diagnostic server: Add streaming functionality (Syncronus) dotnet/coreclr#23299
- On Linux, IPC was failing when delete was invoked because we were using new (std::nothrow) instead of new (nothrow) when allocating the newly connected clients/streams. I have replaced the call with new. This fixed dotnet/coreclr#23580
- Move multiFileTraceLengthInSeconds out of the EventPipeSession.
- Unlink previously existing socket.
- EventPipeBlock: _ASSERTE was updated not to fail when data is not aligned if an error has already occurred.
- Update _ASSERTE in fastserializer.cpp to take into account the the write operation could have failed.
Commit migrated from https://github.com/dotnet/coreclr/commit/
40dda195590873d18236bfbc7742bb6fe7305730
dotnet-maestro-bot [Tue, 2 Apr 2019 13:19:22 +0000 (06:19 -0700)]
Update CoreClr to preview4-27602-71
Commit migrated from https://github.com/dotnet/coreclr/commit/
0fdfd2024c9e27bb5d2e98f729cac4374dab6943
Michal Strehovský [Tue, 2 Apr 2019 12:48:47 +0000 (14:48 +0200)]
Remove test exclusion for 23262 (dotnet/coreclr#23405)
The commit that added the test was rolled back.
Commit migrated from https://github.com/dotnet/coreclr/commit/
d6dad7520ea0bac3894e908835d0321075df822d
Ilia K [Thu, 28 Mar 2019 17:28:47 +0000 (20:28 +0300)]
Move C/C++ and platform headers to pal/inc/rt/cpp folder
Affected files: assert.h, emmintrin.h, and xmmintrin.h
Bug: 20784
Commit migrated from https://github.com/dotnet/coreclr/commit/
e4fb4b3ff0e6c989c104caf9c167078e6d0af894
Krzysztof Wicher [Tue, 2 Apr 2019 00:43:06 +0000 (17:43 -0700)]
PermissionSet: follow netfx more in order to avoid workarounds with nullable (dotnet/coreclr#23637)
Commit migrated from https://github.com/dotnet/coreclr/commit/
0531a855811148c0c312f38bada3a4ab34e5a9c4
Egor Chesakov [Tue, 2 Apr 2019 00:37:53 +0000 (17:37 -0700)]
Use join function in yaml for defining Helix queues and scenarios (dotnet/coreclr#23367)
* Enable Ubuntu.1804.Arm32.Open (running on Ubuntu.1604.Arm32.Open) against PRs
* Restrict Ubuntu.1404.Arm32.Open to running against CI (commit validation) only
* Enable Debian.9.Arm32.Open, Ubuntu.1604.Arm32.Open and Ubuntu.1804.Arm32.Open (running on Ubuntu.1604.Arm32.Open) against scheduled runs
* Enable Debian.9.Arm32, Ubuntu.1604.Arm32 and Ubuntu.1804.Arm32 (running on Ubuntu.1604.Arm32) in internal project (FYI, we haven't had any Linux arm32 testing in internal so far)
* Enable Debian.9.Arm64.Open (running on Ubuntu.1604.Arm64.Docker.Open) against scheduled runs
* Enable Alpine.38.Arm64 (running on Ubuntu.1604.Arm64.Docker) in internal project
Commit migrated from https://github.com/dotnet/coreclr/commit/
ad14d804b22df03c62e9fc4de8d882819e9fbd07
Krzysztof Wicher [Mon, 1 Apr 2019 23:23:52 +0000 (16:23 -0700)]
Change PermissionSet.SyncRoot to return this instead of null (dotnet/coreclr#23631)
Commit migrated from https://github.com/dotnet/coreclr/commit/
5cd9a8d2f9b5f7e3a651aedaa00916ab74ec38a3
Jan Kotas [Mon, 1 Apr 2019 23:20:55 +0000 (16:20 -0700)]
Match BOX idioms early in the importer (dotnet/coreclr#23550)
Commit migrated from https://github.com/dotnet/coreclr/commit/
13bc9b70459936da9c01c6774af6ac46431a11d2
Brian Sullivan [Mon, 1 Apr 2019 23:03:50 +0000 (16:03 -0700)]
revert comment change:
# Checked test builds
Commit migrated from https://github.com/dotnet/coreclr/commit/
3c6e4b9b271f2ee5228f89d10031fc7d51559dc1
Steve MacLean [Mon, 1 Apr 2019 22:09:41 +0000 (18:09 -0400)]
Disable load byte array (dotnet/coreclr#23638)
* Disable AssemblyLoadByteArrayName test
* Fix typo
Commit migrated from https://github.com/dotnet/coreclr/commit/
8b0dae626f6bff194f31ba04840075344d89b4c3
Steve MacLean [Mon, 1 Apr 2019 21:52:51 +0000 (17:52 -0400)]
Disable AssemblyLoadByteArrayName test (dotnet/coreclr#23635)
Commit migrated from https://github.com/dotnet/coreclr/commit/
2731d651bd2979e40e892e52c54c631ce7d47ed4
Levi Broderick [Mon, 1 Apr 2019 21:25:55 +0000 (14:25 -0700)]
Fix bad Debug.Assert statements in UTF-8 processing (dotnet/coreclr#23627)
Commit migrated from https://github.com/dotnet/coreclr/commit/
8c78e8597eb90ec133c7a09567ff0a8cd25d7c78
Carol Eidt [Mon, 1 Apr 2019 20:33:12 +0000 (13:33 -0700)]
LSRA cleanup (dotnet/coreclr#23617)
* LSRA cleanup
These are zero-diff changes. Some cleanup, some in preparation for improvemetns to save/restore of upper vectors.
Commit migrated from https://github.com/dotnet/coreclr/commit/
d686be5513cd09426704eb576858411d1e736d0d
Acid Chicken (硫酸鶏) [Mon, 1 Apr 2019 19:53:10 +0000 (04:53 +0900)]
Add new era in Japan called "Reiwa" (dotnet/coreclr#23614)
* Add new era in Japan called "Reiwa"
* Update Japanese eras English names
refs: <https://github.com/dotnet/coreclr/pull/23614#issuecomment-
478680005>
Commit migrated from https://github.com/dotnet/coreclr/commit/
0ec4acb43bd0344e680b3c608517389267a198a2
dotnet-maestro[bot] [Mon, 1 Apr 2019 19:32:01 +0000 (12:32 -0700)]
[master] Update dependencies from dotnet/corefx (dotnet/coreclr#23593)
- Microsoft.NETCore.Platforms - 3.0.0-preview4.19181.2
- Microsoft.Private.CoreFx.NETCoreApp - 4.6.0-preview4.19181.2
Commit migrated from https://github.com/dotnet/coreclr/commit/
a437fc0091ee297061ebf4c134fe9b31e716d0cf
Fadi Hanna [Mon, 1 Apr 2019 19:07:47 +0000 (12:07 -0700)]
Enable R2R compilation/inlining of PInvoke stubs where no marshalling is required (dotnet/coreclr#22560)
* These changes enable the inlining of some PInvokes that do not require any marshalling. With inlined pinvokes, R2R performance should become slightly better, since we'll avoid jitting some of the pinvoke IL stubs that we jit today for S.P.CoreLib. Performance gains not yet measured.
* Added JIT_PInvokeBegin/End helpers for all architectures. Linux stubs not yet implemented
* Add INLINE_GETTHREAD for arm/arm64
* Set CORJIT_FLAG_USE_PINVOKE_HELPERS jit flag for ReadyToRun compilations
* Updating R2RDump tool to handle pinvokes
Commit migrated from https://github.com/dotnet/coreclr/commit/
bc9248cad132fa01dd2b641b6b22849bc7a05457
Brian Sullivan [Mon, 1 Apr 2019 17:33:46 +0000 (10:33 -0700)]
Merge branch 'master' into pipeline-work
Commit migrated from https://github.com/dotnet/coreclr/commit/
322f14c14b10b789b0cc005a77a51896f846a5e6
Jan Kotas [Mon, 1 Apr 2019 15:37:03 +0000 (08:37 -0700)]
Enable negative type-check results in CoreLib version bubble (dotnet/coreclr#23549)
This negative type-check results are necessary to generate good code for AsyncTaskMethodBuilder.AwaitUnsafeOnCompleted
Commit migrated from https://github.com/dotnet/coreclr/commit/
ff43a803a814eaaa5eba02cafa4a91def3e4c7be
Carol Eidt [Mon, 1 Apr 2019 00:02:38 +0000 (17:02 -0700)]
re-add test exclusion for dotnet/coreclr#23545 (dotnet/coreclr#23598)
Commit migrated from https://github.com/dotnet/coreclr/commit/
cc23e89ca1e28be6129d3aa30c5672aceba587e1
Jan Kotas [Sat, 30 Mar 2019 15:03:14 +0000 (08:03 -0700)]
Update dependencies from https://github.com/dotnet/core-setup build
20190329.11 (dotnet/coreclr#23594)
- Microsoft.NETCore.App - 3.0.0-preview4-27529-11
Commit migrated from https://github.com/dotnet/coreclr/commit/
8993ac60a06b8a63fa830375e09dcca45691b356
Fei Peng [Sat, 30 Mar 2019 14:43:38 +0000 (07:43 -0700)]
Fix ARM64 isFullyImplementedIsa (dotnet/coreclr#23590)
Commit migrated from https://github.com/dotnet/coreclr/commit/
192a53da2f6f14c7e7fd2d21b2a25332912dfdda
Ganbarukamo41 [Sat, 30 Mar 2019 02:10:00 +0000 (02:10 +0000)]
Implement IEquatable to Memory and ReadOnlyMemory (dotnet/coreclr#23586)
Commit migrated from https://github.com/dotnet/coreclr/commit/
b23ad3afc2276945c5c5ab60ecda32d6e0c821a3
Steve MacLean [Sat, 30 Mar 2019 01:51:39 +0000 (21:51 -0400)]
Clean up AssemblyLoadContext30Extensions test (dotnet/coreclr#23581)
Build test against corefx ref facade
Enable Assembly.Load(byte[], ...) test
Commit migrated from https://github.com/dotnet/coreclr/commit/
57ea93ab397ac2b41112cd682aa749a97e2e5198
Sergey Andreenko [Sat, 30 Mar 2019 00:18:44 +0000 (17:18 -0700)]
Merge pull request dotnet/coreclr#23579 from sandreenko/removeFedoraRuns
Remove Fedora runs.
Commit migrated from https://github.com/dotnet/coreclr/commit/
79b2ed74655a840c482b58c7eceaf96df20fa5c5
Sergey Andreenko [Fri, 29 Mar 2019 23:45:31 +0000 (16:45 -0700)]
Increase GCStress test timeouts. (dotnet/coreclr#23576)
New machines are slower that we had before, so increate the timeout for the longest runs.
Commit migrated from https://github.com/dotnet/coreclr/commit/
2ca512927b7d8e8b4b4c8f8eb0cf7986d3115c0f
Sergey Andreenko [Fri, 29 Mar 2019 23:45:06 +0000 (16:45 -0700)]
Make tracelogging GCStressIncompatible. (dotnet/coreclr#23578)
Commit migrated from https://github.com/dotnet/coreclr/commit/
c7761a233b1e894bf9972d527aa85b02f6662cad
Brian Bohe [Fri, 29 Mar 2019 23:38:53 +0000 (16:38 -0700)]
A new way of tracking variables (dotnet/coreclr#23373)
* Defining VariableLiveRange class
* Adding some typedefs to avoid rewriting
* Defining VariableLiveDescriptor class
* Initializing VariableLiveRange structures before BasicBlock code is being generated
* Getting a siVarLoc for variable homes from a given LclVarDsc and stack level
* Defining VariableLiveKeeper class
* Reporting VariableLiveRanges on changes of variable livenesss or variable homes
* Adding USING_VARIABLE_LIVE_RANGE flag to enable disable VariableLiveRange
* Send VariableLiveRanges to debugger
* Reporting variable homes on prolog
* Wrong argument
* Miss to change variable homes count before sending them to debugger
* Adding dumper of VariableLiveRanges for each blocks and end of code generation
* Close all open VaribleLiveRanges on last BasicBlock
* Changing order of properties initialization on VariableLiveRange constructor
* Type error on assignation
* Rephrasing comments, moving dumps and fixing typos
* Changing const VARSET_TP* for VARSET_VALARG_TP on args
* Variable home was variable location in VariableLiveRange context
* Rephrase and rename of VariableLiveKeeper properties
* Missing some renames
* Adding const where BasicBlock should not be modified
* siBeginBlock and siInit have support for debug code for VariableLiveRange and siScope info
* Adding USING_VARIABLE_LIVE_RANGE flags on methods definition.
* Variable home -> variable location
* Renaming and rephrasing names and uses of VariableLiveRange
* Moving LiveRangeDumper ctor to class declation
* Removing destructors
Signed-off-by: Brian Bohe <brianbohe@gmail.com>
* Removing blank spaces and reordering functions inside class definition
Signed-off-by: Brian Bohe <brianbohe@gmail.com>
* Miss to increment the index after refactoring
* Logic for keeping the last BasicBlock end IL offset is shared between siScope and VariableLiverange for debug code
* Missing to print on debug the last block VariableLiveRanges
* Avoid updating VariableLiveRange when unspilling and dying at the same assembly instruction
* Rephrasing #ifs and #ifdefs
* Calling VariableLiveKeeper in one line
* Avoid copying siVarLoc on genSetScopeInfo
* Removing unused args from eeSetLVinfo
* Changing VariableLiveKeeper ctor
* Typo
Signed-off-by: Brian Bohe <brianbohe@gmail.com>
* Updating VariableLiveDescriptor ctor
Signed-off-by: Brian Bohe <brianbohe@gmail.com>
* Error on first argument
Signed-off-by: Brian Bohe <brianbohe@gmail.com>
* Changing reference for pointer
Signed-off-by: Brian Bohe <brianbohe@gmail.com>
* Renaming assembly offset -> native offset
* removing unnecesary comments and asserts
Signed-off-by: Brian Bohe <brianbohe@gmail.com>
* Update VariableLiveRange dump message
Signed-off-by: Brian Bohe <brianbohe@gmail.com>
* Moving VariableLiveRanges classes inside VariableLiveKeeper
* Wrong flag name
* Adding documentation about how we track variables for debug info
Signed-off-by: Brian Bohe <brianbohe@gmail.com>
* Adding opened issues to doc file
Signed-off-by: Brian Bohe <brianbohe@gmail.com>
* Changing dump tittle
Signed-off-by: Brian Bohe <brianbohe@gmail.com>
* Renaming VariableLiveKeeper property
Signed-off-by: Brian Bohe <brianbohe@gmail.com>
* Update documentation
Signed-off-by: Brian Bohe <brianbohe@gmail.com>
* Updating comments on flags
Signed-off-by: Brian Bohe <brianbohe@gmail.com>
* Setting Scope Info as default way of tracking variables for debug info
Signed-off-by: Brian Bohe <brianbohe@gmail.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/
493023e6e1bc03ec04ee4aa9f390e37dc4d0906e
Carol Eidt [Fri, 29 Mar 2019 23:35:09 +0000 (16:35 -0700)]
Fix HW intrinsic containment bugs (dotnet/coreclr#23558)
* Fix HW intrinsic containment bugs
For the Fma case (dotnet/coreclr#23430), fix the handling of contained 3-operand HW intrinsic nodes.
For the Bmi case (dotnet/coreclr#23534), fix a bad assert placement, and re-enable the Bmi tests.
Fix dotnet/coreclr#23530
Fix dotnet/coreclr#23534
* Add guard for Fma test
Commit migrated from https://github.com/dotnet/coreclr/commit/
1df87c785e0e43392abf4bcba56e2bf4d9249fd4
Steve MacLean [Fri, 29 Mar 2019 23:33:37 +0000 (19:33 -0400)]
Assembly.Load ALC name (dotnet/coreclr#23574)
Use normalized path for ALC name
Commit migrated from https://github.com/dotnet/coreclr/commit/
8c7d91177742e150b91f11cf37da84b8f80f6620
Sergey Andreenko [Fri, 29 Mar 2019 23:28:19 +0000 (16:28 -0700)]
Remove Fedora runs.
GCStress fails there because it can't use external disasembler when it is available in CoreRoot.
Commit migrated from https://github.com/dotnet/coreclr/commit/
519016d08d21f2f8bdb7f7c8a47a6914905523fe
Brian Sullivan [Fri, 29 Mar 2019 23:14:20 +0000 (16:14 -0700)]
Merge pull request dotnet/coreclr#23533 from briansull/Issue_23441
Fix for issue 23411
Commit migrated from https://github.com/dotnet/coreclr/commit/
12e7288df91d7c2fbc84be56e520535c1ee38382
Sergey Andreenko [Fri, 29 Mar 2019 22:31:28 +0000 (15:31 -0700)]
Increase GCStress test timeouts.
New machines are slower that we had before, so increate the timeout for the longest runs.
Commit migrated from https://github.com/dotnet/coreclr/commit/
fd81d2dfc658a1cfc7bf7957ef538b1ae2172989
Brian Sullivan [Fri, 29 Mar 2019 22:20:13 +0000 (15:20 -0700)]
Rework Debug/Release builds
Revert Check build changes
Commit migrated from https://github.com/dotnet/coreclr/commit/
ae234aa89ba38692b39c32cc413c674745d6c42f
Sergey Andreenko [Fri, 29 Mar 2019 22:17:37 +0000 (15:17 -0700)]
Use GenTreeStmt* where it is implied. (dotnet/coreclr#22963)
* Extract `impAppendStmt` and `impExtractLastStmt`.
* Delete `BEG_STMTS` fake stmt.
Use new functions to keep the list updated.
* Retype `impTreeList` and `impTreeLast` as statements.
Rename `impTreeList` and `impTreeLast` to show that they are statements.
* Fix fields that have to be stmt.
* Start using GenTreeStmt.
Change `optVNAssertionPropCurStmt` to use GenTreeStmt.
Replace `GenTree* stmt = block->bbTreeList` with `GenTreeStmt* stmt = block->firstStmt()`.
Save results of `FirstNonPhiDef` as `GenTreeStmt`.
* Replace do-while with for loop.
* Change type inside VNAssertionPropVisitorInfo.
* Delete unused args fron `optVNConstantPropOnTree`.
* Update fields to be stmt.
Update optVNConstantPropCurStmt to use Stmt.
Change `lvDefStmt` to stmt.
Update LoopCloning structs.
Update `optDebugLogLoopCloning`.
Make `compCurStmt` a statement.
Update declaration name in `BuildNode`.
* Clean simple cpp files.
Clean valuenum.
Clean ssabuilder.
Clean simd.
Clean optcse.
Clean loopcloning.
Clean copyprop.
Clean optimizer part1.
* Start cleaning importer, morph, flowgraph, gentree.
* Continue clean functons.
Clean assertionprop.
Clean morph.
Clean gentree.
Clean flowgraph.
Clean compiler.
Clean rangecheck.
Clean indirectcalltransofrmer.
Clean others.
* Create some temp stmt.
* Delete unnecessary noway_assert and casts.
* Init `impStmtList` and `impLastStmt` in release.
* Response review 1.
Commit migrated from https://github.com/dotnet/coreclr/commit/
311b5e2fe413c6c74a2a3680ab54d8a978651472
Fei Peng [Fri, 29 Mar 2019 21:28:30 +0000 (14:28 -0700)]
Simplify and unify Vector64/128/256 platform-agnostic intrinsic handling (dotnet/coreclr#23028)
* Simplify and unify Vector64/128/256 platform-agnostic intrinsic handling
* Removed unsupported ISAs
Commit migrated from https://github.com/dotnet/coreclr/commit/
4a4ba4d379002c8b8e77ef968f510cf0283201d0
Brian Sullivan [Fri, 29 Mar 2019 21:13:00 +0000 (14:13 -0700)]
Rework the if statements
Commit migrated from https://github.com/dotnet/coreclr/commit/
ce64f517fa68650f732938b8806bb58afccf2641
Brian Sullivan [Fri, 29 Mar 2019 20:48:48 +0000 (13:48 -0700)]
clone the whole code block and have two separate blocks for jobs
- one for coreclr-ci and another for coreclr-outerloop.
Commit migrated from https://github.com/dotnet/coreclr/commit/
106a1338f2c361df0a2726101d8c7acd4582d43e
Ilia [Fri, 29 Mar 2019 20:00:08 +0000 (23:00 +0300)]
Use char16_t for *_W macros in corhdr.h on Linux/MacOs (dotnet/coreclr#23559)
It fixes COR_CTOR_METHOD_NAME_W and many other macros on Linux
to be of type char16_t[] (not wchar_t[]) by using W("") instead of L"".
Bug: dotnet/coreclr#21977
Commit migrated from https://github.com/dotnet/coreclr/commit/
4e5a542537ea73c94d3443d9c82b05c744f76758
Sergey Andreenko [Fri, 29 Mar 2019 19:32:33 +0000 (12:32 -0700)]
exclude failing test. (dotnet/coreclr#23566)
Commit migrated from https://github.com/dotnet/coreclr/commit/
fee4d5f873efc37100bcbcf381401eb27434bb52
Brian Sullivan [Fri, 29 Mar 2019 17:45:57 +0000 (10:45 -0700)]
Remove / move to outer loop:
coreclr-ci (Test Pri0 Linux_musl arm64 checked)
coreclr-ci (Build Linux_musl arm64 debug)
coreclr-ci (Build Linux arm64 debug)
coreclr-ci (Build Linux_musl arm64 release)
coreclr-ci (Build Linux arm debug)
coreclr-ci (Build Linux_rhel6 x64 checked)
coreclr-ci (Build Linux_rhel6 x64 debug)
coreclr-ci (Build Windows_NT arm64 Debug)
coreclr-ci (Test Pri0 Linux_rhel6 x64 checked)
coreclr-ci (Build Linux_musl x64 debug)
coreclr-ci (build OSX x64 Debug)
coreclr-ci (build OSX x64 Release)
coreclr-ci (Build Windows_NT arm Debug)
coreclr-ci (build Linux x64 Debug)
coreclr-ci (build Linux x64 Release)
coreclr-ci (Build Linux arm release)
coreclr-ci (Build Windows_NT x64 Debug)
coreclr-ci (build Windows_NT x86 Release)
Commit migrated from https://github.com/dotnet/coreclr/commit/
f1b1985cd6ca80c002ba099efc3f17573d503f2e
Jeremy Koritzinsky [Fri, 29 Mar 2019 16:49:55 +0000 (09:49 -0700)]
Correctly marshal structure return values in member functions on Win-x64 and Win-x86 (dotnet/coreclr#23145)
* In Windows-x64, if we have a native member function signature with a struct return type, we need to do a by-ref return.
* Implement support for marshalling structure return values via a return buffer argument correctly in instance signatures on AMD64-Windows.
* Change field initialization ordering to satisfy warning.
* Try to narrow down the conditions that trigger these changes to just COM methods.
* Don't bash the return type on AMD64 Windows. Only treat it as a byref return buffer.
* PR feedback.
* Enable returning structs from COM methods via a return buffer on x86 for structs <= 8 bytes.
* Add test for struct returns with ThisCall. Extend the "struct return buffer" fix to functions marked as unmanaged thiscall since they all must be instance methods
* Don't include the return-type-bashing switch on AMD64 platforms.
* Don't do the signature swapping/copy on non-instance functions with struct returns.
* Cast the return type of GetStubTargetCallingConv to the right calling convention enum type.
* If we're doing a thiscall, marshal the "this" parameter before the return buffer (if the return buffer exists) on all platforms.
* Remove temporary logging code I added in for debugging.
* Clean up class naming.
* Try using a vtable instead of a pointer-to-member-function.
* Remove delete of class with non-virtual destructor
Commit migrated from https://github.com/dotnet/coreclr/commit/
6b889aba05b8e1ccc9cef793a2d1293e30598453
Jan Vorlicek [Fri, 29 Mar 2019 16:44:01 +0000 (17:44 +0100)]
Merge pull request dotnet/coreclr#23423 from franksinankaya/gcc_cleanup_16
SSE abstraction for GCC and abstract __if_exists
Commit migrated from https://github.com/dotnet/coreclr/commit/
cda8f7bf0a826878fc6ca6b9d7bc6f6011626cc9
Koundinya Veluri [Fri, 29 Mar 2019 13:53:35 +0000 (06:53 -0700)]
Change Timer implementation on Unixes to use only one scheduling thread (dotnet/coreclr#7071)
* Change Timer implementation on Unixes to use only one scheduling thread
- Separated from https://github.com/dotnet/corert/pull/7066
* Address feedback from https://github.com/dotnet/corert/pull/7066
* Remove reference to s_lock
* Reduce work inside lock
* Move _id
* Fix duplicate timers in scheduled timer list, move info to TimerQueue
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/
6e215e1faa8275c1468bcd059e29a530d2de0064
Sinan Kaya [Sat, 16 Feb 2019 20:16:11 +0000 (20:16 +0000)]
if exists
llvm
Commit migrated from https://github.com/dotnet/coreclr/commit/
6a3af88cd2cefb8932b2965db64080c2a7c197ef
Sinan Kaya [Sun, 24 Mar 2019 23:45:43 +0000 (23:45 +0000)]
Unify clang with GNUC
Enable SSE for GCC
Commit migrated from https://github.com/dotnet/coreclr/commit/
446393da44258d60aaa9c660602fb826c79fe6b3
Tanner Gooding [Fri, 29 Mar 2019 13:32:52 +0000 (06:32 -0700)]
Updating BuildTools, CoreCLR to preview4-03828-01, preview4-27528-71, respectively (dotnet/coreclr#23536)
* Removing FeedTasksPackageVersion from dependencies.props
* The corresponding metadata was removed in https://github.com/dotnet/coreclr/pull/22884
* Updating BuildTools, CoreCLR to preview4-03828-01, preview4-27528-71, respectively
* Adding a ! in String.Searching.cs
Commit migrated from https://github.com/dotnet/coreclr/commit/
9f2b33e9e124c1a6be86fa83c21a1a8134a9ca10
Ben Adams [Fri, 29 Mar 2019 06:49:08 +0000 (23:49 -0700)]
Avoid boxing allocations for async in Tier0 (dotnet/coreclr#22984)
Commit migrated from https://github.com/dotnet/coreclr/commit/
dc0d0721aca6c6b1da99346dfb95de78d7c83d6f
Sergey Andreenko [Fri, 29 Mar 2019 06:37:29 +0000 (23:37 -0700)]
Delete simple unused vars2 (dotnet/coreclr#23491)
* Clean `valuenum.cpp`.
* Clean `emitarm64.cpp`.
* Clean `lsraarm64.cpp`.
* Clean `lsraarmarch.cpp`.
* Clean `lowerarmarch.cpp`.
* Clean `lower.cpp`.
* Clean `ssabuilder.cpp`.
* Clean `simd.cpp`.
* Clear `simdcodegenxarch.cpp`.
* Clean `lowerxarch.cpp`.
* Clean `scopeinfo.cpp`.
Commit migrated from https://github.com/dotnet/coreclr/commit/
ecf92d0664acc8a36ee7ae69efefca5bb5a7dee5
Marek Safar [Fri, 29 Mar 2019 06:09:12 +0000 (07:09 +0100)]
Simplify StackFrame class (dotnet/coreclr#23483)
Commit migrated from https://github.com/dotnet/coreclr/commit/
f3747cd376bd870e01eef9448de15dda97117ca1
Jan Kotas [Fri, 29 Mar 2019 06:00:53 +0000 (23:00 -0700)]
Delete RuntimeThread.cs (dotnet/coreclr#23532)
No longer needed
Commit migrated from https://github.com/dotnet/coreclr/commit/
b1b8718355a687c7223de9f4a45e10937d2bf3f1
Levi Broderick [Fri, 29 Mar 2019 05:25:16 +0000 (22:25 -0700)]
Improve performance of Marvin32 (dotnet/coreclr#22816)
Commit migrated from https://github.com/dotnet/coreclr/commit/
ff25b931d519c1399838c3ac36ea41f264ae7cf3
Sergey Andreenko [Fri, 29 Mar 2019 02:00:01 +0000 (19:00 -0700)]
Exclude failing in PRs tests 2. (dotnet/coreclr#23540)
* exclude failing in PRs tests
* And another one.
* Exclude for all platforms.
Commit migrated from https://github.com/dotnet/coreclr/commit/
10510b5f9fae3361ec5b161b35014ae2cdefc009
Sergey Andreenko [Fri, 29 Mar 2019 01:54:03 +0000 (18:54 -0700)]
Delete `setup_coredis_tools` from runtest.py. (dotnet/coreclr#23495)
* Delete `setup_coredis_tools` from runtest.py.
* delete dead `setup_coredis_tools` .
Commit migrated from https://github.com/dotnet/coreclr/commit/
3483c6e33b47bd956c433c7437bffad7ab5aca21
Brian Sullivan [Wed, 27 Mar 2019 20:23:30 +0000 (13:23 -0700)]
Fix for issue dotnet/coreclr#23441
Added test case GitHub_23411
Commit migrated from https://github.com/dotnet/coreclr/commit/
cc04782de8f5a8f6eff0f8ff9e790c90edb3c68d
Sung Yoon Whang [Fri, 29 Mar 2019 00:25:00 +0000 (17:25 -0700)]
Fix increment calculation in IncrementingPollingCounter (dotnet/coreclr#23502)
* Add test for IncrementingPollingCounter
* Fix a bug in Increment calculation in IncrementingPollingCounter
* Remove setting DisplayName property since that's a private property for now
* fix comment
* Remove unused variables
Commit migrated from https://github.com/dotnet/coreclr/commit/
9517ad0821e339418b3d3d31145dc0bbb1afc38d
Sergey Andreenko [Fri, 29 Mar 2019 00:21:50 +0000 (17:21 -0700)]
Exclude failing in PRs tests. (dotnet/coreclr#23535)
* exclude failing in PRs tests
Commit migrated from https://github.com/dotnet/coreclr/commit/
72a3f75791be7d78c825ce1f4f02a54c8a7fa344
Carol Eidt [Thu, 28 Mar 2019 20:45:32 +0000 (13:45 -0700)]
Fix codegen for StoreNonTemporal (dotnet/coreclr#23511)
* Fix codegen for StoreNonTemporal
Also, add some asserts and mark some intrinsics as not supporting containment.
Fix dotnet/coreclr#23509
Commit migrated from https://github.com/dotnet/coreclr/commit/
ffe8a331dca0edce1d5bc9537537ed2bfba31b71
Egor Chesakov [Thu, 28 Mar 2019 20:26:23 +0000 (13:26 -0700)]
Restrict Ubuntu.1404.Arm32.Open from running against PRs (dotnet/coreclr#23523)
Commit migrated from https://github.com/dotnet/coreclr/commit/
d1f914ca36acf46aa64ebc35719f367b2ed1d96f
Carol Eidt [Thu, 28 Mar 2019 18:23:10 +0000 (11:23 -0700)]
Struct & SIMD improvements (dotnet/coreclr#22255)
* [WIP] Struct & SIMD improvements
- Enable CSE of struct values when handle is available (and add code to get the handle of HW SIMD types)
- Don't require block nodes for SIMD assignments
- Don't set `GTF_GLOB_REF` on `GT_OBJ` if it is local
- Set `lvRegStruct` on promoted SIMD fields
- Add tests for dotnet/coreclr#19910 (fixed with this PR) and dotnet/coreclr#3539 & dotnet/coreclr#19438 (fixed with dotnet/coreclr#21314)
- Additional cleanup
Fix dotnet/coreclr#19910
Commit migrated from https://github.com/dotnet/coreclr/commit/
3d4a1d5cea0ae71eed1482990ce6e575049829d8
Jeremy Koritzinsky [Thu, 28 Mar 2019 18:22:04 +0000 (11:22 -0700)]
Fix Helix queue names (dotnet/coreclr#23468)
* Fix Helix queue names
* Fix open Deb9 queue name.
Commit migrated from https://github.com/dotnet/coreclr/commit/
a32f7e6b176fc18973581d48d919112d66e321aa
Egor Chesakov [Thu, 28 Mar 2019 18:18:06 +0000 (11:18 -0700)]
Switch to BYOC BuildPools in internal project (dotnet/coreclr#23501)
* dnceng-linux-internal-temp -> BuildPool.Ubuntu.1604.Amd64
* dotnet-internal-temp -> BuildPool.Windows.10.Amd64.VS2017
Commit migrated from https://github.com/dotnet/coreclr/commit/
3027b9d4cc4ee4637834eec99c08b16bc54b38bb
Bruce Forstall [Thu, 28 Mar 2019 18:08:05 +0000 (11:08 -0700)]
Merge pull request dotnet/coreclr#23519 from BruceForstall/RestoreWindowsArmBuildJobs
Restore Windows arm32/arm64 innerloop build jobs
Commit migrated from https://github.com/dotnet/coreclr/commit/
2d0a5baba4cb1e4f09845d92f8d610a419a83f58
Santiago Fernandez Madero [Wed, 27 Mar 2019 22:17:36 +0000 (15:17 -0700)]
Nullable: System.Object (dotnet/coreclr#23466)
Commit migrated from https://github.com/dotnet/coreclr/commit/
62fb2047ac7f037296fcf11466f7731c40ca1e70
Krzysztof Wicher [Wed, 27 Mar 2019 18:25:12 +0000 (11:25 -0700)]
Nullable: all calendars (dotnet/coreclr#23469)
* calendar
* nullable: all calendars
* fix likely corert error
Commit migrated from https://github.com/dotnet/coreclr/commit/
90f5615e349a002fc00288c147e82b965ecfa1b0
Santiago Fernandez Madero [Wed, 27 Mar 2019 17:54:45 +0000 (10:54 -0700)]
Nullable: System.Char (dotnet/coreclr#23480)
Commit migrated from https://github.com/dotnet/coreclr/commit/
5b00a73b86470d77103808e2b59b3c42ecf46223
Bruce Forstall [Thu, 28 Mar 2019 16:55:55 +0000 (09:55 -0700)]
Restore Windows arm32/arm64 innerloop build jobs
These are required by the innerloop flow jobs.
Commit migrated from https://github.com/dotnet/coreclr/commit/
51c84cbde3c1d7531a149e33cc445bee34fc081e
Vladimir Sadov [Thu, 28 Mar 2019 17:25:25 +0000 (10:25 -0700)]
Merge pull request dotnet/coreclr#23325 from VSadov/CmpExchA64
Resolve 22303 (interlocked failures on ARM64)
Commit migrated from https://github.com/dotnet/coreclr/commit/
e5bfd7d89ad0704a23545ac1e6d6a80918e2dbe5
simplejackcoder [Thu, 28 Mar 2019 15:20:15 +0000 (08:20 -0700)]
GetPinnableReference on String.cs (dotnet/coreclr#23428)
* GetPinnableReference on String.cs
* Add attributes for debugger and performance
Commit migrated from https://github.com/dotnet/coreclr/commit/
7c4717e01baf2cc5f4f6a73fc56109b527311c2d
Jan Kotas [Thu, 28 Mar 2019 05:37:22 +0000 (22:37 -0700)]
Move QueryPerformanceCounter PInvokes to shared (dotnet/corefxdotnet/coreclr#36409)
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/
378a0424d350911b569ff3ab0263bb1c1e5fa5ba
buyaa-n [Wed, 27 Mar 2019 02:15:17 +0000 (19:15 -0700)]
Nullable updates for byte type (dotnet/coreclr#23460)
Commit migrated from https://github.com/dotnet/coreclr/commit/
9f285b762839d916683f08b06d450fd9969004fe
buyaa-n [Tue, 26 Mar 2019 16:32:15 +0000 (09:32 -0700)]
Nullable changes for boolean type (dotnet/coreclr#23451)
* Nullable changes for boolean type
Commit migrated from https://github.com/dotnet/coreclr/commit/
4907260fc84002da9aa86362b97f0f991269e847
Santiago Fernandez Madero [Tue, 26 Mar 2019 16:27:32 +0000 (09:27 -0700)]
Nullable: String (dotnet/coreclr#23450)
Commit migrated from https://github.com/dotnet/coreclr/commit/
fe73f198d553334838bfeeb9e33e9b58a0ea4c67
Krzysztof Wicher [Tue, 26 Mar 2019 16:23:00 +0000 (09:23 -0700)]
nullable: number (dotnet/coreclr#23454)
Commit migrated from https://github.com/dotnet/coreclr/commit/
626633d6c52cbc91c187def2e547e3ffdbe7e095
Krzysztof Wicher [Tue, 26 Mar 2019 04:10:24 +0000 (21:10 -0700)]
Nullable: Uint32, (U)Int16, (U)Int64 (dotnet/coreclr#23449)
* Nullable: UInt32
* (U)Int16, (U)Int64
* Make NumberFormatInfo non-nullable
Commit migrated from https://github.com/dotnet/coreclr/commit/
1af82292d5495e5119109927afd7de71b6622e12
Krzysztof Wicher [Tue, 26 Mar 2019 02:13:42 +0000 (19:13 -0700)]
Nullable: Int32 (dotnet/coreclr#23443)
* Nullable: Int32
* remove restore and move nullable up front
* remove trailing \n after #nullable to make it easier to remove later
Commit migrated from https://github.com/dotnet/coreclr/commit/
e0362db668b468925190ad3ff9f0a6f2b4c7a539
Steve MacLean [Thu, 28 Mar 2019 00:15:45 +0000 (20:15 -0400)]
ALC Enhancement nits (dotnet/coreclr#23506)
isCollectible default should be false
String should be string
Commit migrated from https://github.com/dotnet/coreclr/commit/
75250f4edf8e6142e2e70fb7b3966bf2348fe0e1
Steve MacLean [Wed, 27 Mar 2019 23:49:17 +0000 (19:49 -0400)]
ALC enhancements (dotnet/coreclr#22273)
* Initial implementatation of ALC enhancements
Add public constructor with name
Add Name property
Add Assemblies property
Add All property
Override ToString
Name Default and Assembly.Load(...) ALCs
Add AssemblyLoadContext30Extensions test
Commit migrated from https://github.com/dotnet/coreclr/commit/
f1440bb696e2eee957a30f37c6c735f51696edad
Steve MacLean [Wed, 27 Mar 2019 21:24:00 +0000 (17:24 -0400)]
Extend WindowsEventLog test for EntryPointFilter (dotnet/coreclr#23178)
* Extend WindowsEventLog test
Verify EntryPointFilter solves logging problem with native host swallowing exceptions
WindowsEventLog only look at new entries
WindowsEventLog remove time check
Add mechanism to corhost to emulate host swallowing all exceptions
* PR feedback
Commit migrated from https://github.com/dotnet/coreclr/commit/
66c05cea421a9f388eaebece2b9e64ce4560c5c5
Swaroop Sridhar [Wed, 27 Mar 2019 21:03:25 +0000 (14:03 -0700)]
Update DllMap doc (dotnet/coreclr#22804)
* Update DllMap doc
Update DllMap design doc:
* To note the NativeLibrary APIs that can be used to implement DllMap
* To point to a sample implementation of DllMap.
Commit migrated from https://github.com/dotnet/coreclr/commit/
c3e1bd5ccc482c9a7670762676bda95ebd34707d
Steve MacLean [Wed, 27 Mar 2019 18:02:18 +0000 (14:02 -0400)]
Add ALC.ContextualReflection.md (dotnet/coreclr#23335)
Commit migrated from https://github.com/dotnet/coreclr/commit/
6a48f05c77e80b604d71a9b84cc6b014306e849e
Sergey Andreenko [Wed, 27 Mar 2019 17:59:04 +0000 (10:59 -0700)]
Revert "Delete unused variables in jit. Part 2. (dotnet/coreclr#23481)" (dotnet/coreclr#23488)
This reverts commit dotnet/coreclr@
6cb120cc74ca61fc314e3cc43007778d2aafd041.
Commit migrated from https://github.com/dotnet/coreclr/commit/
cbeadacafba718557e47fc166d7fd688b01515d7
Sergey Andreenko [Wed, 27 Mar 2019 17:22:18 +0000 (10:22 -0700)]
Delete unused variables in jit. Part 2. (dotnet/coreclr#23481)
* Clean `valuenum.cpp`.
* Clean `emitarm64.cpp`.
* Clean `lsraarm64.cpp`.
* Clean `lsraarmarch.cpp`.
* Clean `lowerarmarch.cpp`.
* Clean `lower.cpp`.
* Clean `ssabuilder.cpp`.
* Clean `simd.cpp`.
* Clear `simdcodegenxarch.cpp`.
* Clean `lowerxarch.cpp`.
* Clean `scopeinfo.cpp`.
* Clean `hwintrinsiccodegenxarch.cpp`.
Commit migrated from https://github.com/dotnet/coreclr/commit/
6cb120cc74ca61fc314e3cc43007778d2aafd041