Martin Fleisz [Fri, 24 Aug 2018 07:45:26 +0000 (09:45 +0200)]
Merge pull request #4816 from akallabeth/drive_cmd_fix
Fix #4680: Return proper directory name.
Martin Fleisz [Fri, 24 Aug 2018 06:37:41 +0000 (08:37 +0200)]
Merge pull request #4814 from akallabeth/linked_list_add_object
Linked list add object for user defined functions
Martin Fleisz [Thu, 23 Aug 2018 14:58:22 +0000 (16:58 +0200)]
Merge pull request #4811 from akallabeth/dyn_fullscreen_fix
Fixed single monitor fullscreen resolution update.
Martin Fleisz [Thu, 23 Aug 2018 14:07:48 +0000 (16:07 +0200)]
Merge pull request #4787 from akallabeth/redirect_fqdn_fix
Redirect fqdn fix
Armin Novak [Thu, 23 Aug 2018 08:04:26 +0000 (10:04 +0200)]
Fix #4680: Return proper directory name.
David Fort [Thu, 23 Aug 2018 07:40:49 +0000 (09:40 +0200)]
Merge pull request #4813 from ondrejholy/coverity
Bunch of fixes based on covscan results
Ondrej Holy [Mon, 20 Aug 2018 09:11:47 +0000 (11:11 +0200)]
winpr/winsock: Fix leak found by covscan
0 is valid return value from socket().
leaked_handle: Handle variable "fd" going out of scope leaks the handle.
Ondrej Holy [Wed, 22 Aug 2018 11:17:10 +0000 (13:17 +0200)]
winpr/winsock: Format code by astyle
Run ./scripts/format_code.sh before the following changes.
Ondrej Holy [Tue, 21 Aug 2018 08:27:56 +0000 (10:27 +0200)]
winpr/utils/wlog: Fix leak found by covscan
leaked_storage: Variable "result" going out of scope leaks the storage it points to.
leaked_storage: Variable "bt" going out of scope leaks the storage it points to.
Ondrej Holy [Wed, 22 Aug 2018 11:16:58 +0000 (13:16 +0200)]
winpr/utils/wlog: Format code by astyle
Run ./scripts/format_code.sh before the following changes.
Ondrej Holy [Mon, 20 Aug 2018 08:55:29 +0000 (10:55 +0200)]
winpr/utils/ntlm: Prevent releasing function argument
The patch changes API of functions instead of fixing unused and broken code.
freed_arg: "free" frees parameter "NtHash".
David Fort [Wed, 22 Aug 2018 15:53:16 +0000 (17:53 +0200)]
Merge pull request #4797 from akallabeth/rpm_expand_fix
Removed comments with variables and (previously added) buggy suse con…
Ondrej Holy [Wed, 22 Aug 2018 11:16:31 +0000 (13:16 +0200)]
winpr/utils/ntlm: Format code by astyle
Run ./scripts/format_code.sh before the following changes.
Ondrej Holy [Mon, 20 Aug 2018 07:52:24 +0000 (09:52 +0200)]
winpr/sspi/ntlm: Fix leak found by covscan
leaked_storage: Variable "sam" going out of scope leaks the storage it points to.
leaked_storage: Variable "s" going out of scope leaks the storage it points to.
leaked_storage: Variable "snt" going out of scope leaks the storage it points to.
Ondrej Holy [Mon, 20 Aug 2018 07:50:43 +0000 (09:50 +0200)]
winpr/io/device: Fix leak found by covscan
leaked_storage: Variable "lpPipePath" going out of scope leaks the storage it points to.
Ondrej Holy [Wed, 22 Aug 2018 11:16:03 +0000 (13:16 +0200)]
winpr/io/device: Format code by astyle
Run ./scripts/format_code.sh before the following changes.
Ondrej Holy [Mon, 20 Aug 2018 07:47:33 +0000 (09:47 +0200)]
winpr/file: Fix leak found by covscan
overwrite_var: Overwriting handle "h" in "h = (HANDLE)0xffffffffffffffff" leaks the handle.
Ondrej Holy [Mon, 20 Aug 2018 07:33:42 +0000 (09:33 +0200)]
uwac: Fix leak found by covscan
leaked_storage: Variable "data" going out of scope leaks the storage it points to.
copy_paste_error: "opaque_region" in "w->opaque_region" looks like a copy-paste error.
Ondrej Holy [Wed, 22 Aug 2018 11:15:32 +0000 (13:15 +0200)]
uwac: Format code by astyle
Run ./scripts/format_code.sh before the following changes.
Ondrej Holy [Mon, 20 Aug 2018 07:10:49 +0000 (09:10 +0200)]
rdtk: Fix leak found by covscan
leaked_storage: Variable "fontBaseFile" going out of scope leaks the storage it points to.
leaked_storage: Variable "image" going out of scope leaks the storage it points to.
Ondrej Holy [Tue, 21 Aug 2018 08:12:05 +0000 (10:12 +0200)]
crypto/tls: Prevent usage of freed pointer found by coverity
pass_freed_arg: Passing freed pointer "pemCert" as an argument to "WLog_PrintMessage".
Ondrej Holy [Mon, 20 Aug 2018 09:26:35 +0000 (11:26 +0200)]
core/transport: Fix leak found by covscan
0 is valid return value from socket().
leaked_handle: Handle variable "sockfd" going out of scope leaks the handle.
Ondrej Holy [Fri, 17 Aug 2018 14:25:20 +0000 (16:25 +0200)]
core/tcp: Prevent buffer overflow found by covscan
buffer_size_warning: Calling strncpy with a maximum size argument of 108 bytes on destination array "addr.sun_path" of size 108 bytes might leave the destination string unterminated.
Ondrej Holy [Wed, 22 Aug 2018 11:15:10 +0000 (13:15 +0200)]
core/tcp: Format code by astyle
Run ./scripts/format_code.sh before the following changes.
Ondrej Holy [Fri, 17 Aug 2018 14:22:56 +0000 (16:22 +0200)]
core/proxy: Fix leak found by covscan
leaked_storage: Variable "s" going out of scope leaks the storage it points to.
Ondrej Holy [Fri, 17 Aug 2018 14:20:43 +0000 (16:20 +0200)]
core/nla: Fix leak found by covscan
leaked_storage: Variable "s" going out of scope leaks the storage it points to.
Ondrej Holy [Fri, 17 Aug 2018 14:16:37 +0000 (16:16 +0200)]
core/nego: Fix leak found by covscan
leaked_storage: Variable "wszPCB" going out of scope leaks the storage it points to.
Ondrej Holy [Fri, 17 Aug 2018 14:14:53 +0000 (16:14 +0200)]
core/listener: Prevent buffer overflow found by covscan
buffer_size_warning: Calling strncpy with a maximum size argument of 108 bytes on destination array "addr.sun_path" of size 108 bytes might leave the destination string unterminated.
Ondrej Holy [Tue, 21 Aug 2018 07:45:46 +0000 (09:45 +0200)]
core/info: Silence false positive warnings from covscan
Change the code a bit to silence false positive warnings from covscan.
pass_freed_arg: Passing freed pointer "wString" as an argument to "Stream_Write".
pass_freed_arg: Passing freed pointer "wString" as an argument to "Stream_Write".
Ondrej Holy [Fri, 17 Aug 2018 14:10:26 +0000 (16:10 +0200)]
core/info: Fix leak found by covscan
leaked_storage: Variable "wString" going out of scope leaks the storage it points to.
Ondrej Holy [Fri, 17 Aug 2018 14:00:19 +0000 (16:00 +0200)]
core/gateway/rpc: Fix leak found by covscan
0 is valid return value from socket().
leaked_storage: Variable "auth_3_pdu" going out of scope leaks the storage it points to.
leaked_storage: Variable "response" going out of scope leaks the storage it points to.
leaked_handle: Handle variable "sockfd" going out of scope leaks the handle.
Ondrej Holy [Wed, 22 Aug 2018 11:14:45 +0000 (13:14 +0200)]
core/gateway/rpc: Format code by astyle
Run ./scripts/format_code.sh before the following changes.
Ondrej Holy [Fri, 17 Aug 2018 13:47:46 +0000 (15:47 +0200)]
core/gateway/rdg: Fix leak found by covscan
leaked_storage: Variable "request" going out of scope leaks the storage it points to.
leaked_handle: Handle variable "sockfd" going out of scope leaks the handle.
leaked_handle: Handle variable "sockfd" going out of scope leaks the handle.
Ondrej Holy [Tue, 21 Aug 2018 07:16:47 +0000 (09:16 +0200)]
codec/planar: Fix leak found by covscan
The patch changes API of functions instead of fixing unused and broken code.
leaked_storage: Returning without freeing "outPlane" leaks the storage that it points to.
Ondrej Holy [Fri, 17 Aug 2018 13:01:25 +0000 (15:01 +0200)]
codec/nsc: Fix leak found by covscan
leaked_storage: Variable "s" going out of scope leaks the storage it points to.
Ondrej Holy [Fri, 17 Aug 2018 12:56:49 +0000 (14:56 +0200)]
cache: Fix wrong condition found by covscan
copy_paste_error: "xorMaskData" in "pointer_color->xorMaskData" looks like a copy-paste error.
Ondrej Holy [Fri, 17 Aug 2018 12:45:07 +0000 (14:45 +0200)]
client/cmdline: Fix leak found by covscan
leaked_storage: Variable "base64" going out of scope leaks the storage it points to.
Ondrej Holy [Fri, 17 Aug 2018 12:40:12 +0000 (14:40 +0200)]
client/common: Fix leak found by covscan
leaked_storage: Variable "file" going out of scope leaks the storage it points to.
Ondrej Holy [Tue, 21 Aug 2018 07:07:15 +0000 (09:07 +0200)]
client/x11: Silence false positive warnings from covscan
Add code annotation to silence false positive warnings from covscan
due to omitting termination \0.
buffer_size: Calling strncpy with a source string whose length (13 chars) is greater than or equal to the size argument (13) will fail to null-terminate "&tmp[cs]".
Ondrej Holy [Fri, 17 Aug 2018 12:28:55 +0000 (14:28 +0200)]
client/x11: Fix leak found by covscan
leaked_storage: Variable "actionScript" going out of scope leaks the storage it points to.
Ondrej Holy [Wed, 22 Aug 2018 11:13:37 +0000 (13:13 +0200)]
client/x11: Format code by astyle
Run ./scripts/format_code.sh before the following changes.
Ondrej Holy [Fri, 17 Aug 2018 12:19:19 +0000 (14:19 +0200)]
channels/smartcard: Fix leak found by covscan
leaked_storage: Variable "operation" going out of scope leaks the storage it points to.
Ondrej Holy [Wed, 22 Aug 2018 11:13:07 +0000 (13:13 +0200)]
channels/smartcard: Format code by astyle
Run ./scripts/format_code.sh before the following changes.
Ondrej Holy [Tue, 21 Aug 2018 07:11:19 +0000 (09:11 +0200)]
channels/server: Silence false positive warnings from covscan
Change the code a bit to silence false positive warnings from covscan.
leaked_storage: Ignoring storage allocated by "audin_server_context_new(NULL)" leaks it.
leaked_storage: Ignoring storage allocated by "rdpsnd_server_context_new(NULL)" leaks it.
leaked_storage: Ignoring storage allocated by "cliprdr_server_context_new(NULL)" leaks it.
leaked_storage: Ignoring storage allocated by "echo_server_context_new(NULL)" leaks it.
leaked_storage: Ignoring storage allocated by "rdpdr_server_context_new(NULL)" leaks it.
leaked_storage: Ignoring storage allocated by "drdynvc_server_context_new(NULL)" leaks it.
leaked_storage: Ignoring storage allocated by "rdpei_server_context_new(NULL)" leaks it.
leaked_storage: Ignoring storage allocated by "remdesk_server_context_new(NULL)" leaks it.
leaked_storage: Ignoring storage allocated by "encomsp_server_context_new(NULL)" leaks it.
leaked_storage: Ignoring storage allocated by "rdpgfx_server_context_new(NULL)" leaks it.
Ondrej Holy [Wed, 22 Aug 2018 11:12:35 +0000 (13:12 +0200)]
channels/server: Format code by astyle
Run ./scripts/format_code.sh before the following changes.
Ondrej Holy [Fri, 17 Aug 2018 11:55:56 +0000 (13:55 +0200)]
channels/serial: Fix leak found by covscan
leaked_storage: Variable "ids" going out of scope leaks the storage it points to.
Ondrej Holy [Fri, 17 Aug 2018 11:52:38 +0000 (13:52 +0200)]
channels/remdesk: Fix leak found by covscan
leaked_storage: Variable "pass" going out of scope leaks the storage it points to.
Ondrej Holy [Fri, 17 Aug 2018 11:47:24 +0000 (13:47 +0200)]
channels/rdpgfx: Fix leak found by covscan
leaked_storage: Variable "s" going out of scope leaks the storage it points to.
Ondrej Holy [Wed, 22 Aug 2018 11:11:28 +0000 (13:11 +0200)]
channels/rdpgfx: Format code by astyle
Run ./scripts/format_code.sh before the following changes.
Ondrej Holy [Fri, 17 Aug 2018 11:43:18 +0000 (13:43 +0200)]
channels/rdpdr: Prevent buffer overflow found by covscan
buffer_size_warning: Calling strncpy with a maximum size argument of 256 bytes on destination array "irp->PathName" of size 256 bytes might leave the destination string unterminated.
buffer_size_warning: Calling strncpy with a maximum size argument of 256 bytes on destination array "irp->ExtraBuffer" of size 256 bytes might leave the destination string unterminated.
Ondrej Holy [Wed, 22 Aug 2018 11:07:46 +0000 (13:07 +0200)]
channels/rdpdr: Format code by astyle
Run ./scripts/format_code.sh before the following changes.
Ondrej Holy [Fri, 17 Aug 2018 10:56:45 +0000 (12:56 +0200)]
channels/rdpdr: Fix leak found by covscan
leaked_storage: Variable "newbuf" going out of scope leaks the storage it points to.
leaked_storage: Variable "keys" going out of scope leaks the storage it points to.
leaked_storage: Variable "pKeys" going out of scope leaks the storage it points to.
leaked_storage: Variable "s" going out of scope leaks the storage it points to.
leaked_storage: Variable "computerNameW" going out of scope leaks the storage it points to.
leaked_storage: Variable "s" going out of scope leaks the storage it points to.
Ondrej Holy [Fri, 17 Aug 2018 10:51:19 +0000 (12:51 +0200)]
channels/rail: Fix leak found by covscan
leaked_storage: Variable "s" going out of scope leaks the storage it points to.
Ondrej Holy [Fri, 17 Aug 2018 10:43:49 +0000 (12:43 +0200)]
channels/drive: Fix leak found by covscan
leaked_storage: Variable "outStr" going out of scope leaks the storage it points to.
Ondrej Holy [Fri, 17 Aug 2018 10:41:34 +0000 (12:41 +0200)]
channels/addin: Fix leak found by covscan
leaked_handle: Handle variable "hFind" going out of scope leaks the handle.
Ondrej Holy [Fri, 17 Aug 2018 10:30:33 +0000 (12:30 +0200)]
channels/audin: Fix leak found by covscan
leaked_storage: Variable out going out of scope leaks the storage it points to.
Armin Novak [Wed, 22 Aug 2018 10:33:34 +0000 (12:33 +0200)]
Implemented linked list compare and value copy functions.
Armin Novak [Tue, 21 Aug 2018 10:58:55 +0000 (12:58 +0200)]
Fixed single monitor fullscreen resolution update.
Martin Fleisz [Tue, 21 Aug 2018 08:01:47 +0000 (10:01 +0200)]
Merge pull request #4808 from akallabeth/tls_extract_pem_fix
Fixed #4806 broken bounds check.
Armin Novak [Tue, 21 Aug 2018 07:08:33 +0000 (09:08 +0200)]
Fixed #4806 broken bounds check.
Armin Novak [Mon, 13 Aug 2018 13:44:53 +0000 (15:44 +0200)]
Removed comments with variables and (previously added) buggy suse conditionals
David Fort [Mon, 13 Aug 2018 13:21:49 +0000 (15:21 +0200)]
Merge pull request #4795 from akallabeth/rpm_build_fix
Deactivated FFMPEG support for redhat systems (deps not in repo)
Armin Novak [Mon, 13 Aug 2018 12:34:06 +0000 (14:34 +0200)]
Deactivated FFMPEG support for redhat systems (deps not in repo)
Norbert Federa [Mon, 13 Aug 2018 12:33:49 +0000 (14:33 +0200)]
Merge pull request #4794 from akallabeth/drive_find_first_file_fix
Drive find first file fix
Armin Novak [Mon, 13 Aug 2018 11:23:52 +0000 (13:23 +0200)]
drive_file_query_information: Use GetFileAttributesExW
Armin Novak [Mon, 13 Aug 2018 11:17:56 +0000 (13:17 +0200)]
Fixed #4793: Return correct file handle for existing directory
akallabeth [Thu, 9 Aug 2018 08:41:56 +0000 (10:41 +0200)]
Merge pull request #4789 from akallabeth/nightly_ffmpeg_rpm
Enabled ffmpeg support on RPM based systems.
David Fort [Thu, 9 Aug 2018 08:22:24 +0000 (10:22 +0200)]
Merge pull request #4788 from akallabeth/multimon_fullscreen
Fixed #4786: Added fullscreen handling for dynamic resolution.
Armin Novak [Thu, 9 Aug 2018 07:58:56 +0000 (09:58 +0200)]
Added requirement check for WITH_DSP_FFMPEG
Armin Novak [Wed, 8 Aug 2018 11:31:52 +0000 (13:31 +0200)]
Enabled ffmpeg support on RPM based systems.
akallabeth [Wed, 8 Aug 2018 11:10:07 +0000 (13:10 +0200)]
Merge pull request #4783 from akallabeth/nightly_audio
Enabled FFMPEG for nightly builds.
Armin Novak [Wed, 8 Aug 2018 11:04:26 +0000 (13:04 +0200)]
Fixed #4786: Added fullscreen handling for dynamic resolution.
Armin Novak [Wed, 8 Aug 2018 10:26:57 +0000 (12:26 +0200)]
Allow redirect address override with a list of values.
Armin Novak [Wed, 8 Aug 2018 09:16:24 +0000 (11:16 +0200)]
Added command line option /redirect-prefer:<fqdn|ip|netbios>
Since redirection sometimes happens with internal DNS names that
are resolved different by outside DNS it must be possible to override
the preferred redirection hint.
Armin Novak [Wed, 8 Aug 2018 08:25:09 +0000 (10:25 +0200)]
Try redirection FQDN first, but check if it is resolvable.
Armin Novak [Mon, 6 Aug 2018 05:55:30 +0000 (07:55 +0200)]
Enabled FFMPEG dependency.
akallabeth [Wed, 1 Aug 2018 13:59:34 +0000 (15:59 +0200)]
Merge pull request #4778 from akallabeth/2_0_0_dev_4
Started next development cycle
Armin Novak [Wed, 1 Aug 2018 10:33:34 +0000 (12:33 +0200)]
Started next development cycle
akallabeth [Wed, 1 Aug 2018 13:27:31 +0000 (15:27 +0200)]
Merge pull request #4777 from akallabeth/changelog_2_0_0-rc3
release: version 2.0.0-rc3
Martin Fleisz [Wed, 1 Aug 2018 13:16:07 +0000 (15:16 +0200)]
Merge pull request #4776 from akallabeth/fixes_cleanups_etc
Mac audin Fixes and cleanups
Armin Novak [Wed, 1 Aug 2018 09:58:24 +0000 (11:58 +0200)]
Added const to function buffer pointers
Armin Novak [Wed, 1 Aug 2018 09:57:18 +0000 (11:57 +0200)]
Fixed expression ambiguity
Armin Novak [Wed, 1 Aug 2018 09:56:47 +0000 (11:56 +0200)]
Fixed invalid return value type.
Armin Novak [Wed, 1 Aug 2018 09:56:04 +0000 (11:56 +0200)]
Fixed funtion to function pointer argument mismatch
Armin Novak [Wed, 1 Aug 2018 09:54:45 +0000 (11:54 +0200)]
Fixed invalid format string.
Armin Novak [Wed, 1 Aug 2018 09:54:18 +0000 (11:54 +0200)]
Fixed missing array initializer values
Armin Novak [Wed, 1 Aug 2018 09:44:45 +0000 (11:44 +0200)]
Fixed mac audin
Armin Novak [Wed, 1 Aug 2018 08:04:00 +0000 (10:04 +0200)]
Fixed mac server compile issue.
Armin Novak [Tue, 31 Jul 2018 09:29:59 +0000 (11:29 +0200)]
release: version 2.0.0-rc3
MartinHaimberger [Tue, 31 Jul 2018 11:35:05 +0000 (13:35 +0200)]
Merge pull request #4773 from akallabeth/drive_multi_fix
Remember if drive was added by automout.
Martin Fleisz [Tue, 31 Jul 2018 09:13:29 +0000 (11:13 +0200)]
Merge pull request #4774 from akallabeth/audin_leak_fix
Fixed leak in audio format processing.
Martin Fleisz [Tue, 31 Jul 2018 09:03:39 +0000 (11:03 +0200)]
Merge pull request #4240 from akallabeth/wl_client_fixes
Fixed wayland issues.
Armin Novak [Tue, 31 Jul 2018 08:45:04 +0000 (10:45 +0200)]
Added default return value.
Armin Novak [Tue, 31 Jul 2018 08:33:19 +0000 (10:33 +0200)]
Fixed leak in audio format processing.
MartinHaimberger [Tue, 31 Jul 2018 08:22:22 +0000 (10:22 +0200)]
Merge pull request #4758 from akallabeth/dsp_fix
Audio/microphone fixes
akallabeth [Mon, 30 Jul 2018 11:31:32 +0000 (13:31 +0200)]
Merge pull request #4762 from mmattes/issue/4757
Fix for #4757
Armin Novak [Mon, 30 Jul 2018 11:16:45 +0000 (13:16 +0200)]
Removed obsolete winodws path hack.
Armin Novak [Mon, 30 Jul 2018 10:58:15 +0000 (12:58 +0200)]
Fixed windows automount drive arguments.
Armin Novak [Mon, 30 Jul 2018 10:37:19 +0000 (12:37 +0200)]
Added automount flag for windows and macos implementations.
Armin Novak [Mon, 30 Jul 2018 10:31:11 +0000 (12:31 +0200)]
Remember if drive was added by automout.