haraken@chromium.org [Fri, 16 Mar 2012 03:13:28 +0000 (03:13 +0000)]
[PerformanceTests] run-perf-tests should output correct units
https://bugs.webkit.org/show_bug.cgi?id=78303
Reviewed by Ryosuke Niwa.
Previously run-perf-tests just supported "ms" for units.
Consequently, Dromaeo perf tests had been reporting runs/s as "ms".
This patch fixes run-perf-tests so that they can support custom units.
The default unit is "ms".
The test result looks like this:
$ ./Tools/Scripts/run-perf-tests Dromaeo/dom-attr.html
RESULT Dromaeo: dom-attr= 6465.9525483 runs/s
median= 0.0 runs/s, stdev= 24.
2983433436 runs/s, min= 6435.
87649402 runs/s, max= 6515.
63693392 runs/s
PerformanceTests:
* Dromaeo/resources/dromaeorunner.js:
(.):
* resources/runner.js:
(PerfTestRunner.computeStatistics):
(PerfTestRunner.printStatistics):
Tools:
* Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner._process_parser_test_result):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110933
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
leo.yang@torchmobile.com.cn [Fri, 16 Mar 2012 03:00:45 +0000 (03:00 +0000)]
[BlackBerry] Sync up MIMETypeRegistry.cpp
https://bugs.webkit.org/show_bug.cgi?id=81191
Reviewed by Rob Buis.
Add png and jpeg to supportedImageMIMETypesForEncoding for BlackBerry.
* platform/MIMETypeRegistry.cpp:
(WebCore::initializeSupportedImageMIMETypesForEncoding):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110932
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dgrogan@chromium.org [Fri, 16 Mar 2012 02:54:52 +0000 (02:54 +0000)]
IndexedDB Tests: use self instead of window
https://bugs.webkit.org/show_bug.cgi?id=81043
'window' is meaningless in a worker; these tests will soon be run from
a worker context.
Reviewed by Tony Chang.
* storage/indexeddb/create-and-remove-object-store.html:
* storage/indexeddb/createObjectStore-name-argument-required.html:
* storage/indexeddb/createObjectStore-null-name.html:
* storage/indexeddb/cursor-continue.html:
* storage/indexeddb/cursor-delete.html:
* storage/indexeddb/cursor-inconsistency.html:
* storage/indexeddb/cursor-index-delete.html:
* storage/indexeddb/cursor-key-order.html:
* storage/indexeddb/cursor-primary-key-order.html:
* storage/indexeddb/cursor-skip-deleted.html:
* storage/indexeddb/cursor-update-value-argument-required.html:
* storage/indexeddb/cursor-update.html:
* storage/indexeddb/data-corruption.html:
* storage/indexeddb/database-basics.html:
* storage/indexeddb/database-quota.html:
* storage/indexeddb/delete-closed-database-object-expected.txt:
* storage/indexeddb/delete-closed-database-object.html:
* storage/indexeddb/deleteObjectStore-name-argument-required.html:
* storage/indexeddb/deleteObjectStore-null-name.html:
* storage/indexeddb/duplicates.html:
* storage/indexeddb/error-causes-abort-by-default.html:
* storage/indexeddb/exception-in-event-aborts.html:
* storage/indexeddb/factory-cmp-expected.txt:
* storage/indexeddb/factory-cmp.html:
* storage/indexeddb/factory-deletedatabase-interactions-expected.txt:
* storage/indexeddb/factory-deletedatabase-interactions.html:
* storage/indexeddb/factory-deletedatabase.html:
* storage/indexeddb/index-count.html:
* storage/indexeddb/index-cursor.html:
* storage/indexeddb/index-get-key-argument-required.html:
* storage/indexeddb/index-population.html:
* storage/indexeddb/index-unique.html:
* storage/indexeddb/invalid-keys-expected.txt:
* storage/indexeddb/invalid-keys.html:
* storage/indexeddb/key-generator.html:
* storage/indexeddb/key-sort-order-across-types.html:
* storage/indexeddb/key-sort-order-date.html:
* storage/indexeddb/key-type-array-expected.txt:
* storage/indexeddb/key-type-array.html:
* storage/indexeddb/key-type-infinity.html:
* storage/indexeddb/keypath-basics.html:
* storage/indexeddb/keypath-fetch-key.html:
* storage/indexeddb/mozilla/add-twice-failure.html:
* storage/indexeddb/mozilla/autoincrement-indexes.html:
* storage/indexeddb/mozilla/bad-keypath.html:
* storage/indexeddb/mozilla/clear.html:
* storage/indexeddb/mozilla/create-index-unique.html:
* storage/indexeddb/mozilla/create-index-with-integer-keys.html:
* storage/indexeddb/mozilla/create-objectstore-basics.html:
* storage/indexeddb/mozilla/create-objectstore-null-name.html:
* storage/indexeddb/mozilla/cursor-mutation-objectstore-only.html:
* storage/indexeddb/mozilla/cursor-update-updates-indexes.html:
* storage/indexeddb/mozilla/cursors.html:
* storage/indexeddb/mozilla/delete-result.html:
* storage/indexeddb/mozilla/event-source.html:
* storage/indexeddb/mozilla/global-data.html:
* storage/indexeddb/mozilla/indexes.html:
* storage/indexeddb/mozilla/key-requirements-delete-null-key.html:
* storage/indexeddb/mozilla/key-requirements-inline-and-passed.html:
* storage/indexeddb/mozilla/key-requirements-put-no-key.html:
* storage/indexeddb/mozilla/key-requirements-put-null-key.html:
* storage/indexeddb/mozilla/key-requirements.html:
* storage/indexeddb/mozilla/object-cursors.html:
* storage/indexeddb/mozilla/object-identity.html:
* storage/indexeddb/mozilla/object-store-inline-autoincrement-key-added-on-put.html:
* storage/indexeddb/mozilla/object-store-remove-values.html:
* storage/indexeddb/mozilla/objectstorenames.html:
* storage/indexeddb/mozilla/odd-result-order.html:
* storage/indexeddb/mozilla/put-get-values.html:
* storage/indexeddb/mozilla/readonly-transactions.html:
* storage/indexeddb/mozilla/readwrite-transactions.html:
* storage/indexeddb/mozilla/readyState.html:
* storage/indexeddb/mozilla/remove-index.html:
* storage/indexeddb/mozilla/remove-objectstore.html:
* storage/indexeddb/mozilla/versionchange-abort.html:
* storage/indexeddb/mozilla/versionchange.html:
* storage/indexeddb/mutating-cursor.html:
* storage/indexeddb/objectStore-required-arguments.html:
* storage/indexeddb/objectstore-autoincrement.html:
* storage/indexeddb/objectstore-clear.html:
* storage/indexeddb/objectstore-count.html:
* storage/indexeddb/objectstore-cursor.html:
* storage/indexeddb/objectstore-removeobjectstore.html:
* storage/indexeddb/open-close-version-expected.txt:
* storage/indexeddb/open-close-version.html:
* storage/indexeddb/open-cursor.html:
* storage/indexeddb/prefetch-bugfix-108071.html:
* storage/indexeddb/queued-commands.html:
* storage/indexeddb/request-event-propagation.html:
* storage/indexeddb/setVersion-null.html:
* storage/indexeddb/setVersion-undefined.html:
* storage/indexeddb/structured-clone-expected.txt:
* storage/indexeddb/structured-clone.html:
* storage/indexeddb/transaction-abort.html:
* storage/indexeddb/transaction-after-close.html:
* storage/indexeddb/transaction-and-objectstore-calls.html:
* storage/indexeddb/transaction-basics-expected.txt:
* storage/indexeddb/transaction-basics.html:
* storage/indexeddb/transaction-crash-on-abort-expected.txt:
* storage/indexeddb/transaction-crash-on-abort.html:
* storage/indexeddb/transaction-event-propagation.html:
* storage/indexeddb/transaction-read-only.html:
* storage/indexeddb/transaction-rollback.html:
* storage/indexeddb/transaction-storeNames-required.html:
* storage/indexeddb/two-version-changes-expected.txt:
* storage/indexeddb/two-version-changes.html:
* storage/indexeddb/value-undefined.html:
* storage/indexeddb/values-odd-types.html:
* storage/indexeddb/version-change-abort.html:
* storage/indexeddb/version-change-exclusive-expected.txt:
* storage/indexeddb/version-change-exclusive.html:
* storage/indexeddb/versionchangerequest-activedomobject-expected.txt:
* storage/indexeddb/versionchangerequest-activedomobject.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110931
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy_horton@apple.com [Fri, 16 Mar 2012 02:50:20 +0000 (02:50 +0000)]
Unreviewed mac rebaseline for fast/clip/{011,012}.html after trac.webkit.org/changeset/110072
There was a similar Chromium rebaseline in http://trac.webkit.org/changeset/110179
* platform/mac/fast/clip/011-expected.txt:
* platform/mac/fast/clip/012-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110930
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 16 Mar 2012 02:41:01 +0000 (02:41 +0000)]
[chromium] Decide occlusion in paint culling with CCOcclusionTracker
https://bugs.webkit.org/show_bug.cgi?id=81181
Patch by Dana Jansens <danakj@chromium.org> on 2012-03-15
Reviewed by Adrienne Walker.
Source/WebCore:
Plumb a CCOcclusionTracker* around instead of a bare Region, so that it
can make a more informed decision if a tile is occluded or not during
paint.
Covered by existing tests.
* platform/graphics/chromium/Canvas2DLayerChromium.cpp:
(WebCore::Canvas2DLayerChromium::paintContentsIfDirty):
* platform/graphics/chromium/Canvas2DLayerChromium.h:
(Canvas2DLayerChromium):
* platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::paintContentsIfDirty):
(WebCore::ContentLayerChromium::idlePaintContentsIfDirty):
* platform/graphics/chromium/ContentLayerChromium.h:
(WebCore):
(ContentLayerChromium):
* platform/graphics/chromium/ImageLayerChromium.cpp:
(WebCore::ImageLayerChromium::paintContentsIfDirty):
* platform/graphics/chromium/ImageLayerChromium.h:
(WebCore):
(ImageLayerChromium):
* platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::paintContentsIfDirty):
(WebCore::LayerChromium::idlePaintContentsIfDirty):
* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::prepareToUpdateTiles):
(WebCore::TiledLayerChromium::prepareToUpdate):
(WebCore::TiledLayerChromium::prepareToUpdateIdle):
* platform/graphics/chromium/TiledLayerChromium.h:
(TiledLayerChromium):
* platform/graphics/chromium/WebGLLayerChromium.cpp:
(WebCore::WebGLLayerChromium::paintContentsIfDirty):
* platform/graphics/chromium/WebGLLayerChromium.h:
(WebGLLayerChromium):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::paintContentsIfDirty):
(WebCore::CCLayerTreeHost::paintMaskAndReplicaForRenderSurface):
(WebCore::CCLayerTreeHost::paintLayerContents):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
Source/WebKit/chromium:
* tests/CCLayerTreeHostTest.cpp:
(WTF::ContentLayerChromiumWithUpdateTracking::paintContentsIfDirty):
(WTF::ContentLayerChromiumWithUpdateTracking::idlePaintContentsIfDirty):
(WTF::TestLayerChromium::paintContentsIfDirty):
* tests/Canvas2DLayerChromiumTest.cpp:
* tests/TiledLayerChromiumTest.cpp:
(TestCCOcclusionTracker):
(WTF::TestCCOcclusionTracker::TestCCOcclusionTracker):
(WTF::TestCCOcclusionTracker::setOcclusion):
(WTF::TestCCOcclusionTracker::layerScissorRectInTargetSurface):
(WTF):
(WTF::FakeTiledLayerChromium::prepareToUpdate):
(WTF::FakeTiledLayerChromium::prepareToUpdateIdle):
(WTF::FakeTiledLayerChromium::paintContentsIfDirty):
(WTF::TEST):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110929
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jberlin@webkit.org [Fri, 16 Mar 2012 02:36:55 +0000 (02:36 +0000)]
WebKitTestRunner layoutTestController.pathToLocalResource needs to be updated to work with
NRWT
https://bugs.webkit.org/show_bug.cgi?id=81299
Add failing expected results for mac-wk2 to get the bots green.
* platform/mac-wk2/fast/loader/local-CSS-from-local-expected.txt: Added.
* platform/mac-wk2/fast/loader/local-JavaScript-from-local-expected.txt: Added.
* platform/mac-wk2/fast/loader/local-image-from-local-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110928
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 16 Mar 2012 01:49:05 +0000 (01:49 +0000)]
[Forms] The "meter" element should not be a form-associated element.
https://bugs.webkit.org/show_bug.cgi?id=80380
Patch by Yoshifumi Inoue <yosin@chromium.org> on 2012-03-15
Reviewed by Kent Tamura.
Source/WebCore:
This patch changes base class of HTMLMeterElement to LabelableElement from
HTMLFormControlElement for saving memory space and iteration time of
extra "meter" elements in HTMLFormElement::m_formAssociatedElements
and matching the HTML5 specification for ease of maintenance.
This patch renames isLabelable method to supportLabels and makes isLabelable
as predicate of an instance of LabelableElement or not.
Changes of TextIterator is lead by usage of isFormControlElement. This
changes will be replaced with more meaningful predicate as part of
https://bugs.webkit.org/show_bug.cgi?id=80381
No new tests. Update existing tests to cover this change.
* editing/TextIterator.cpp:
(WebCore::TextIterator::advance): Check HTMLMeterElement in addition to isFormControlElement. This change is for text dump in LayoutTests implemented by document.innerText attribute.
* html/HTMLButton.h:
(WebCore::HTMLButtonElement::supportLabels): Renamed from isLabelable
* html/HTMLElement.h:
(WebCore::HTMLElement::isLabelable): Added. A predicate for an instance of LabelableElement.
* html/HTMLInputElement.h:
(WebCore::HTMLInputElement::supportLabels): Renamed from isLabelable
* html/HTMLKeygenElement.h:
(WebCore::HTMLKeygenElement::supportLabels): Renamed from isLabelable
* html/HTMLLabelElement.cpp:
(WebCore::nodeAsLabelableElement): Changed to return LabelableElement instead of HTMLFormControlElement.
(WebCore::HTMLLabelElement::control): Changed to return LabelableElement instead of HTMLFormControlElement.
* html/HTMLLabelElement.h:
(HTMLLabelElement):
* html/HTMLMeterElement.cpp:
(WebCore::HTMLMeterElement::HTMLMeterElement): Changed base class to LabelableElement.
(WebCore::HTMLMeterElement::create): Remove form parameter.
(WebCore::HTMLMeterElement::formControlType): Remove implementation of virtual method declared in HTMLFormControlElement.
(WebCore::HTMLMeterElement::parseAttribute): Replace HTMLFormControlElement to LabelableElement
(WebCore::HTMLMeterElement::attach): Replace HTMLFormControlElement to LabelableElement
* html/HTMLMeterElement.idl: Remove the "form" attribute which isn't listed in the HTML5 specification.
* html/HTMLMeterElement.h:
(HTMLMeterElement):
(WebCore::HTMLMeterElement::supportLabels): Renamed from isLabelable
* html/HTMLOutputElement.h:
(WebCore::HTMLOutputElement::supportLabels): Renamed from isLabelable
* html/HTMLProgressElement.h:
(WebCore::HTMLProgressElement::supportLabels): Renamed from isLabelable
* html/HTMLSelectElement.h:
(WebCore::HTMLSelectElement::supportLabels): Renamed from isLabelable
* html/HTMLTextAreaElement.h:
(WebCore::HTMLTextAreaElement::supportLabels): Renamed from isLabelable
* html/HiddenInputType.h:
(WebCore::HiddenInputType::supportLabels): Renamed from isLabelable
* html/InputType.h:
(WebCore::InputType::supportLabels): Renamed from isLabelable
* html/HTMLTagNames.in: Remove "constructorNeedsFormElement" for not passing "form" parameter in HTMLElementFactory.
* html/LabelableElement.cpp:
(WebCore::LabelableElement::labels): Replace isLabelable to supportLabels
* html/LabelableElement.h:
(LabelableElement):
LayoutTests:
This patch removes tests which checks non-existent "form" attribute
of the "meter" element. The "form" attribute is available only for
form-associated elements. However, the "meter" element isn't a
form-associated element.
* fast/dom/HTMLMeterElement/meter-element-form-expected.txt: Updated expectation for test output changes.
* fast/dom/HTMLMeterElement/meter-element-form.html: Changed for the "meter" element doesn't have IDL attribute "form".
* fast/forms/form-attribute-expected.txt: Updated expectation for test output changes.
* fast/forms/form-attribute.html: Removed lines for the "meter" element.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110927
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy_horton@apple.com [Fri, 16 Mar 2012 01:39:14 +0000 (01:39 +0000)]
canvas/philip/tests/2d.line.cap.round.html fails on Mac Lion WK1
https://bugs.webkit.org/show_bug.cgi?id=81289
<rdar://problem/
11059777>
Unreviewed skip of two more similarly flaky tests:
canvas/philip/tests/2d.shadow.canvas.transparent.2.html
canvas/philip/tests/2d.shadow.image.transparent.2.html
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110926
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adamk@chromium.org [Fri, 16 Mar 2012 01:24:07 +0000 (01:24 +0000)]
REGRESSION(r103452): 100% CPU usage and 5s pause after clicking on a link in Yahoo Mail
https://bugs.webkit.org/show_bug.cgi?id=81141
Reviewed by Ojan Vafai.
Source/WebCore:
Revert the behavior change from r103452: don't fire DOMSubtreeModified
events when an attribute value merely changes. Still fire that event
when an attribute is added or removed from an element.
Though this contradicts the DOM3 spec, it matches legacy WebKit behavior,
and given that Mutation Events are deprecated, it seems unwise to make
any additions to WebKit's implementation of them.
Test: fast/dom/subtree-modified-attributes.html
* dom/Element.cpp:
(WebCore::Element::didAddAttribute): Renamed from didModifyAttribute.
(WebCore::Element::didModifyAttribute): Remove the call to dispatchSubtreeModifiedEvent.
(WebCore):
* dom/Element.h:
(Element):
* dom/ElementAttributeData.cpp:
(WebCore::ElementAttributeData::addAttribute): Call didAddAttribute instead of didModifyAttribute.
LayoutTests:
* fast/dom/subtree-modified-attributes-expected.txt: Added.
* fast/dom/subtree-modified-attributes.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110925
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
leviw@chromium.org [Fri, 16 Mar 2012 01:08:09 +0000 (01:08 +0000)]
Unreviewed gardening. Fixing Chromium expectations after we began falling back to the failing
expectation checked in in r110911.
* platform/chromium/platform/chromium/virtual: Added.
* platform/chromium/platform/chromium/virtual/gpu: Added.
* platform/chromium/platform/chromium/virtual/gpu/fast: Added.
* platform/chromium/platform/chromium/virtual/gpu/fast/canvas: Added.
* platform/chromium/platform/chromium/virtual/gpu/fast/canvas/webgl: Added.
* platform/chromium/platform/chromium/virtual/gpu/fast/canvas/webgl/context-lost-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110924
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@webkit.org [Fri, 16 Mar 2012 00:55:32 +0000 (00:55 +0000)]
[WinCairo] Unreviewed build change after wtf path changes.
* DumpRenderTree/win/ImageDiffWinCairoCommon.vsprops: Updated include
directories to look at the private header directory to find 'wtf'.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110923
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Fri, 16 Mar 2012 00:52:00 +0000 (00:52 +0000)]
REGRESSION(r110595): webkit-patch suggest-reviewers doesn't work
https://bugs.webkit.org/show_bug.cgi?id=81293
Reviewed by Adam Barth.
r110595 introduced new format of the author field of ChangeLog entry:
"Adam Barth <abarth@webkit.org> && Benjamin Poulain <bpoulain@apple.com>"
Updte chanelog.py to support it.
* Scripts/webkitpy/common/checkout/changelog.py:
(ChangeLogEntry._split_contributor_names):
* Scripts/webkitpy/common/checkout/changelog_unittest.py:
(test_parse_authors):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110922
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 16 Mar 2012 00:45:26 +0000 (00:45 +0000)]
[chromium] Move overdraw metrics into a templated class for both paint and draw metrics.
https://bugs.webkit.org/show_bug.cgi?id=81156
Patch by Dana Jansens <danakj@chromium.org> on 2012-03-15
Reviewed by Adrienne Walker.
Source/WebCore:
Creates CCOverdrawMetrics which can be called to inform it about
draws/paints. At the end of the frame, the CCOverdrawMetrics
recordMetrics() method will put its data into histograms, a
TRACE_COUNTER for culling information, and a TRACE_EVENT for details
about the number of opaque/translucent pixels.
Covered by existing tests.
* WebCore.gypi:
* platform/chromium/TraceEvent.h:
(TraceEvent):
(WebCore::TraceEvent::addTraceEvent):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
* platform/graphics/chromium/cc/CCOverdrawMetrics.cpp: Added.
(WebCore):
(WebCore::CCOverdrawMetrics::CCOverdrawMetrics):
(WebCore::wedgeProduct):
(WebCore::quadArea):
(WebCore::CCOverdrawMetrics::didDraw):
(WebCore::CCOverdrawMetrics::recordMetrics):
(WebCore::CCOverdrawMetrics::recordMetricsInternal):
* platform/graphics/chromium/cc/CCOverdrawMetrics.h: Added.
(WebCore):
(CCOverdrawMetrics):
(WebCore::CCOverdrawMetrics::pixelsDrawnOpaque):
(WebCore::CCOverdrawMetrics::pixelsDrawnTranslucent):
(WebCore::CCOverdrawMetrics::pixelsCulled):
* platform/graphics/chromium/cc/CCQuadCuller.cpp:
(WebCore::CCQuadCuller::CCQuadCuller):
(WebCore::CCQuadCuller::append):
* platform/graphics/chromium/cc/CCQuadCuller.h:
(WebCore):
(CCQuadCuller):
* platform/graphics/chromium/cc/CCRenderPass.cpp:
(WebCore::CCRenderPass::appendQuadsForLayer):
* platform/graphics/chromium/cc/CCRenderPass.h:
(WebCore):
(CCRenderPass):
Source/WebKit/chromium:
* tests/CCQuadCullerTest.cpp:
(WebCore::appendQuads):
(WebCore):
(WebCore::TEST):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110921
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jberlin@webkit.org [Fri, 16 Mar 2012 00:30:33 +0000 (00:30 +0000)]
fast/events/pagehide-timeout.html, pageshow-pagehide-on-back-cached-with-frames.html, and
pageshow-pagehide-on-back-cached.html flakey on Lion Intel Debug WebKit testers
https://bugs.webkit.org/show_bug.cgi?id=81291
Skip these tests on mac-wk2 to get the bots green.
* platform/mac-wk2/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110920
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Fri, 16 Mar 2012 00:28:20 +0000 (00:28 +0000)]
[chromium] RateLimiter should hold a reference to its context
https://bugs.webkit.org/show_bug.cgi?id=80761
Reviewed by Stephen White.
* platform/graphics/chromium/RateLimiter.h:
(RateLimiter):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110919
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adamk@chromium.org [Fri, 16 Mar 2012 00:20:43 +0000 (00:20 +0000)]
Share code in FormAssociatedElement by resetting the form owner whenever insertedIntoTree is called
https://bugs.webkit.org/show_bug.cgi?id=81160
Reviewed by Kent Tamura.
Source/WebCore:
The only difference between the previous insertedIntoTree method and
resetFormOwner was a missing element->inDocument() check in the
former. But that check is actually important, as seen by the included test case.
Test: fast/forms/form-attribute-not-in-document.html
* html/FormAssociatedElement.cpp:
(WebCore::FormAssociatedElement::insertedIntoTree):
LayoutTests:
* fast/forms/form-attribute-not-in-document-expected.txt: Added.
* fast/forms/form-attribute-not-in-document.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110918
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dino@apple.com [Fri, 16 Mar 2012 00:17:53 +0000 (00:17 +0000)]
webgl/framebuffer-object-attachment failing on lion
https://bugs.webkit.org/show_bug.cgi?id=81290
Unreviewed. Adding the failing results to platform/mac.
* platform/mac-snowleopard/fast/canvas/webgl/framebuffer-object-attachment-expected.txt: Added.
* platform/mac/fast/canvas/webgl/framebuffer-object-attachment-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110917
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy_horton@apple.com [Fri, 16 Mar 2012 00:16:01 +0000 (00:16 +0000)]
canvas/philip/tests/2d.line.cap.round.html fails on Mac Lion WK1
https://bugs.webkit.org/show_bug.cgi?id=81289
<rdar://problem/
11059777>
Unreviewed skip of flaky test canvas/philip/tests/2d.line.cap.round.html.
* platform/mac/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110916
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
haraken@chromium.org [Fri, 16 Mar 2012 00:11:57 +0000 (00:11 +0000)]
[Refactoring] Rename StringBuilder variables in MarkupAccumulator.{h,cpp}
https://bugs.webkit.org/show_bug.cgi?id=81288
Reviewed by Adam Barth.
This is a refactoring for fixing bug 81214. Currently MarkupAccumulator mixes
'out' and 'result' for variable names of StringBuilder. This patch unifies them
to 'result'.
No tests. No change in behavior.
* editing/MarkupAccumulator.cpp: Renamed 'out' to 'result'.
(WebCore::appendCharactersReplacingEntities):
(WebCore::MarkupAccumulator::serializeNodes): Renamed 'node' to 'targetNode' for clarification
(and for avoiding style check error in MarkupAccumulator.h).
(WebCore::MarkupAccumulator::concatenateMarkup):
(WebCore::MarkupAccumulator::appendNodeValue):
(WebCore::MarkupAccumulator::shouldAddNamespaceAttribute):
(WebCore::MarkupAccumulator::appendNamespace):
(WebCore::MarkupAccumulator::entityMaskForText):
(WebCore::MarkupAccumulator::appendText):
(WebCore::MarkupAccumulator::appendComment):
(WebCore::MarkupAccumulator::appendProcessingInstruction):
(WebCore::MarkupAccumulator::appendElement):
(WebCore::MarkupAccumulator::appendOpenTag):
(WebCore::MarkupAccumulator::appendCloseTag):
(WebCore::MarkupAccumulator::appendAttribute):
(WebCore::MarkupAccumulator::appendCDATASection):
(WebCore::MarkupAccumulator::elementCannotHaveEndTag):
* editing/MarkupAccumulator.h: Removed redundant variable names.
(MarkupAccumulator):
(WebCore):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110915
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 15 Mar 2012 23:58:35 +0000 (23:58 +0000)]
Make the array pointer parameters in the Typed Array create() methods const.
https://bugs.webkit.org/show_bug.cgi?id=81147
Patch by David Dorwin <ddorwin@chromium.org> on 2012-03-15
Reviewed by Kenneth Russell.
This allows const arrays to be passed to these methods.
They use PassRefPtr<Subclass> create(), which already has a const parameter.
* wtf/Int16Array.h:
(Int16Array):
(WTF::Int16Array::create):
* wtf/Int32Array.h:
(Int32Array):
(WTF::Int32Array::create):
* wtf/Int8Array.h:
(Int8Array):
(WTF::Int8Array::create):
* wtf/Uint16Array.h:
(Uint16Array):
(WTF::Uint16Array::create):
* wtf/Uint32Array.h:
(Uint32Array):
(WTF::Uint32Array::create):
* wtf/Uint8Array.h:
(Uint8Array):
(WTF::Uint8Array::create):
* wtf/Uint8ClampedArray.h:
(Uint8ClampedArray):
(WTF::Uint8ClampedArray::create):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110913
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Thu, 15 Mar 2012 23:54:47 +0000 (23:54 +0000)]
Try to fix the Snow Leopard build.
* UIProcess/API/mac/PDFViewController.mm:
(WebKit::PDFViewController::pdfKitBundle):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110912
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dino@apple.com [Thu, 15 Mar 2012 23:54:12 +0000 (23:54 +0000)]
webgl/context-lost failing on Lion
https://bugs.webkit.org/show_bug.cgi?id=81284
Unreviewed. Adding the failing results to platform/mac.
* platform/mac-snowleopard/fast/canvas/webgl/context-lost-expected.txt: Added.
* platform/mac/fast/canvas/webgl/context-lost-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110911
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@webkit.org [Thu, 15 Mar 2012 23:47:43 +0000 (23:47 +0000)]
[WinCairo] Correct <wtf/*.h> include paths.
https://bugs.webkit.org/show_bug.cgi?id=81278
Reviewed by Eric Seidel.
Modify the #include declarations for several Cairo-related files
so that the wtf types are included using the full path.
* platform/graphics/FontPlatformData.h:
* platform/graphics/cairo/OwnPtrCairo.h:
* platform/graphics/cairo/RefPtrCairo.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110910
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 15 Mar 2012 23:44:01 +0000 (23:44 +0000)]
Implement LayoutTestController::setValueForUser on Windows https://bugs.webkit.org/show_bug.cgi?id=55834
Tools:
Implemented setValueForUser in both DumpRenderTree and WebKitTestRunner.
Patch by Lynn Neir <lynn.neir@skype.net> on 2012-03-15
Reviewed by Jessie Berlin.
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::setValueForUser):
* WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::setValueForUser):
(WTR):
* WebKitTestRunner/InjectedBundle/LayoutTestController.h:
(LayoutTestController):
LayoutTests:
removed test, no longer needed as test passes and matches baseline expected results and also updated wk2 skipped file to no longer skip this test.
Patch by Lynn Neir <lynn.neir@skype.net> on 2012-03-15
Reviewed by Jessie Berlin.
* platform/win/fast/forms/onchange-setvalueforuser-expected.txt: Removed.
* platform/wk2/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110909
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Thu, 15 Mar 2012 23:30:48 +0000 (23:30 +0000)]
only some tiles rendered when zoomed in
https://bugs.webkit.org/show_bug.cgi?id=81282
<rdar://problem/
11058898>
Reviewed by Andreas Kling.
* platform/graphics/ca/mac/TileCache.mm:
(WebCore::TileCache::rectForTileIndex):
Make sure that the tile cache bounds are scaled accordingly.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110908
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zeno.albisser@nokia.com [Thu, 15 Mar 2012 23:28:49 +0000 (23:28 +0000)]
[Qt] RenderThemeQt::fileListNameForWidth should override function in base class RenderTheme. (r110560)
https://bugs.webkit.org/show_bug.cgi?id=81107
Add "bool multipleFilesAllowed" to the parameter list of RenderThemeQt::fileListNameForWidth.
This way the base class function is properly overridden.
The need for this change became obvious after r110560 where the OVERRIDE keyword had been
added to the function signature.
Reviewed by Simon Hausmann.
* platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::fileListNameForWidth):
* platform/qt/RenderThemeQt.h:
(RenderThemeQt):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110907
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jberlin@webkit.org [Thu, 15 Mar 2012 23:21:41 +0000 (23:21 +0000)]
Selection is not collapsed in some WK2 editing tests
https://bugs.webkit.org/show_bug.cgi?id=69889
Add some expected failing results for mac-wk2 to get the bots green.
* platform/mac-wk2/editing/selection/caret-ltr-right-expected.txt: Added.
* platform/mac-wk2/editing/selection/caret-rtl-right-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110906
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yutak@chromium.org [Thu, 15 Mar 2012 23:17:31 +0000 (23:17 +0000)]
[Qt] Change default WebSocket protocol to the latest one
https://bugs.webkit.org/show_bug.cgi?id=73630
Reviewed by Simon Hausmann.
* Api/qwebpage.cpp:
(QWebPagePrivate::QWebPagePrivate):
Use RFC6455 WebSocket protocol by default.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110905
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Thu, 15 Mar 2012 23:11:53 +0000 (23:11 +0000)]
Update the start-queue.sh script to match what we're using on the bots
https://bugs.webkit.org/show_bug.cgi?id=81277
Reviewed by Eric Seidel.
Over time we've added more magic git commands to clean up the local repo after
it has been borked in various ways. The idea behind this sequence is to clear
out any changes in the working copy and then to rebuild the master branch from
origin/master.
This patch also removes the watchdog timer that we've stopped using on the
bots.
This patch was reviewed on <https://github.com/eseidel/webkit/pull/1>.
Note: Eric and I are experimenting with GitHub to see if it might be
useful for WebKit. If you have thoughts on this topic, please feel
free to grab Eric or me on #webkit to chat. I assume that he and I are
the only ones who care about this file so using this alternative
process for this patch shouldn't cause any trouble.
* EWSTools/start-queue.sh:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110904
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jonlee@apple.com [Thu, 15 Mar 2012 23:07:37 +0000 (23:07 +0000)]
Move NotificationContents into Notification
https://bugs.webkit.org/show_bug.cgi?id=80487
<rdar://problem/
10965519>
Reviewed by Jian Li.
Source/WebCore:
* notifications/Notification.cpp: Alter signature of constructor to take the fields directly instead of
a NotificationContents instance.
(WebCore::Notification::Notification): Derive KURL from string representation of icon.
(WebCore::Notification::create):
* notifications/Notification.h:
(Notification): Remove contents() accessor and replace with get for title and body. iconURL()
already existed, but use local variable instead of going through NotificationContents.
(WebCore::Notification::iconURL):
(WebCore::Notification::title):
(WebCore::Notification::body):
* notifications/NotificationCenter.h:
(WebCore::NotificationCenter::createNotification): Refactor to use new constructor.
* notifications/NotificationContents.h: Removed.
Remove NotificationContents.h from project files
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
Source/WebKit/chromium:
Refactor to use accessor methods on Notification.
* src/WebNotification.cpp:
(WebKit::WebNotification::title):
(WebKit::WebNotification::body):
Source/WebKit/mac:
* WebView/WebNotification.mm: Refactor to use accessor methods on Notification.
(-[WebNotification title]):
(-[WebNotification body]):
Source/WebKit/qt:
Refactor to use accessor methods on Notification.
* WebCoreSupport/NotificationPresenterClientQt.cpp:
(WebCore::NotificationWrapper::title):
(WebCore::NotificationWrapper::message):
(WebCore::NotificationPresenterClientQt::displayNotification):
(WebCore::NotificationPresenterClientQt::cancel):
(WebCore::NotificationPresenterClientQt::notificationClicked):
(WebCore::NotificationPresenterClientQt::dumpReplacedIdText):
(WebCore::NotificationPresenterClientQt::dumpShowText):
Source/WebKit2:
* UIProcess/Notifications/WebNotificationManagerProxy.cpp: Remove extraneous include.
* WebProcess/Notifications/WebNotificationManager.cpp:
(WebKit::WebNotificationManager::show): Refactor to use accessor methods on Notification.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110903
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 15 Mar 2012 23:04:39 +0000 (23:04 +0000)]
CopiedSpace::tryAllocateOversize assumes system page size
https://bugs.webkit.org/show_bug.cgi?id=80615
Patch by Myles Maxfield <mmaxfield@google.com> on 2012-03-15
Reviewed by Geoffrey Garen.
* heap/CopiedSpace.cpp:
(JSC::CopiedSpace::tryAllocateOversize):
* heap/CopiedSpace.h:
(CopiedSpace):
* heap/CopiedSpaceInlineMethods.h:
(JSC::CopiedSpace::oversizeBlockFor):
* wtf/BumpPointerAllocator.h:
(WTF::BumpPointerPool::create):
* wtf/StdLibExtras.h:
(WTF::roundUpToMultipleOf):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110902
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mhahnenberg@apple.com [Thu, 15 Mar 2012 22:50:51 +0000 (22:50 +0000)]
Fixing Windows build breakage
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110901
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Thu, 15 Mar 2012 22:48:57 +0000 (22:48 +0000)]
The commit-queue can hang when the test_expectations.txt style check fails during commit
https://bugs.webkit.org/show_bug.cgi?id=81251
Reviewed by Eric Seidel.
We forgot to check the --non-interactive flag, so we end up prompting
the "user" who doesn't exist on the bot. We might consider teaching
the User class about non-interactive if we have this sort of bug again.
* Scripts/webkitpy/tool/steps/commit.py:
(Commit.options):
(Commit._check_test_expectations):
(Commit.run):
* Scripts/webkitpy/tool/steps/commit_unittest.py:
(CommitTest.test_check_test_expectations):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110900
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jonlee@apple.com [Thu, 15 Mar 2012 22:44:02 +0000 (22:44 +0000)]
Deprecate ondisplay()
https://bugs.webkit.org/show_bug.cgi?id=80483
<rdar://problem/
10912432>
Reviewed by Jian Li.
Source/WebCore:
The appropriate event listener for notifications is onshow().
* notifications/Notification.h: Wrap ondisplay in ENABLE(LEGACY_NOTIFICATIONS).
* notifications/Notification.idl: Wrap ondisplay in ENABLE_LEGACY_NOTIFICATIONS.
Source/WebKit/chromium:
* src/WebNotification.cpp:
(WebKit::WebNotification::dispatchDisplayEvent): Dispatch the show event.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110899
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
wjmaclean@chromium.org [Thu, 15 Mar 2012 22:31:33 +0000 (22:31 +0000)]
[chromium] Wire up PlatformGestureCurves for CC, ScrollAnimatorNone.
https://bugs.webkit.org/show_bug.cgi?id=80607
Reviewed by James Robinson.
Source/WebCore:
Unit tests added. Layout tests to follow.
Provides implementation of PlatformGestureCurves in Chrome Compositor, and basic
support in ScrollAnimatorNone, for fling gestures.
* GNUmakefile.list.am:
* platform/ActivePlatformGestureAnimation.cpp:
(WebCore::ActivePlatformGestureAnimation::create):
(WebCore::ActivePlatformGestureAnimation::ActivePlatformGestureAnimation):
(WebCore::ActivePlatformGestureAnimation::animate):
* platform/ActivePlatformGestureAnimation.h:
(ActivePlatformGestureAnimation):
* platform/PlatformGestureCurveTarget.h:
(PlatformGestureCurveTarget):
* platform/ScrollAnimatorNone.cpp:
(WebCore::ScrollAnimatorNone::cancelAnimations):
(WebCore::ScrollAnimatorNone::animationTimerFired):
(WebCore::ScrollAnimatorNone::scrollBy):
(WebCore):
* platform/ScrollAnimatorNone.h:
(WebCore):
(ScrollAnimatorNone):
* platform/TouchFlingPlatformGestureCurve.cpp:
(WebCore::TouchFlingPlatformGestureCurve::apply):
* platform/WheelFlingPlatformGestureCurve.cpp:
(WebCore::WheelFlingPlatformGestureCurve::apply):
* platform/graphics/chromium/cc/CCActiveGestureAnimation.cpp:
(WebCore::CCActiveGestureAnimation::create):
(WebCore::CCActiveGestureAnimation::CCActiveGestureAnimation):
(WebCore::CCActiveGestureAnimation::animate):
* platform/graphics/chromium/cc/CCActiveGestureAnimation.h:
(CCActiveGestureAnimation):
* platform/graphics/chromium/cc/CCGestureCurve.h:
(CCGestureCurveTarget):
* platform/graphics/chromium/cc/CCInputHandler.h:
(WebCore):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::animate):
(WebCore::CCLayerTreeHostImpl::setActiveGestureAnimation):
(WebCore):
(WebCore::CCLayerTreeHostImpl::animateGestures):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(WebCore):
(WebCore::CCLayerTreeHostImpl::activeGestureAnimation):
(CCLayerTreeHostImpl):
Source/WebKit/chromium:
* public/WebInputEvent.h:
(WebKit::WebInputEvent::isScrollGestureEventType):
* src/WebCompositorInputHandlerImpl.cpp:
(PlatformGestureToCCGestureAdapter):
(WebCore::PlatformGestureToCCGestureAdapter::create):
(WebCore::PlatformGestureToCCGestureAdapter::apply):
(WebCore::PlatformGestureToCCGestureAdapter::scrollBy):
(WebCore::PlatformGestureToCCGestureAdapter::PlatformGestureToCCGestureAdapter):
(WebCore):
(WebKit::WebCompositorInputHandlerImpl::handleInputEvent):
(WebKit::WebCompositorInputHandlerImpl::handleGestureFling):
(WebKit):
(WebKit::WebCompositorInputHandlerImpl::scrollBy):
* src/WebCompositorInputHandlerImpl.h:
(WebCore):
(WebCompositorInputHandlerImpl):
* tests/PlatformGestureCurveTest.cpp:
* tests/WebCompositorInputHandlerImplTest.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110898
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@webkit.org [Thu, 15 Mar 2012 22:22:50 +0000 (22:22 +0000)]
Unreviewed build correction. WinCairo export definitions
file was not updated when the main Apple file was changed.
* win/WebKit2CFLite.def: Revise export declarations to match
new symbol names.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110897
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Thu, 15 Mar 2012 22:17:54 +0000 (22:17 +0000)]
[EFL] Make zlib a general build requirement
https://bugs.webkit.org/show_bug.cgi?id=80153
Reviewed by Hajime Morita.
After r109538 WebSocket module needs zlib to support deflate-frame extension.
.:
* Source/cmake/OptionsEfl.cmake:
Source/JavaScriptCore:
* wtf/Platform.h:
Source/WebCore:
* PlatformEfl.cmake:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110896
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
schenney@chromium.org [Thu, 15 Mar 2012 22:16:36 +0000 (22:16 +0000)]
[Chromium] Cleanup of outdated test expectations
https://bugs.webkit.org/show_bug.cgi?id=81253
Unreviewed chromium expectations.
* platform/chromium/test_expectations.txt: Adding Linux svg/text/text-tselect-02.f.svg
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110895
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rwlbuis@webkit.org [Thu, 15 Mar 2012 22:14:03 +0000 (22:14 +0000)]
[BlackBerry] Remove some features that we do not have anymore
https://bugs.webkit.org/show_bug.cgi?id=81274
Reviewed by Antonio Gomes.
Remove some features that we do not have anymore, code was removed some time ago.
* Source/cmake/OptionsBlackBerry.cmake:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110894
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 15 Mar 2012 22:13:47 +0000 (22:13 +0000)]
REGRESSION (r110371): broke platform/gtk/scrollbars/overflow-scrollbar-horizontal-wheel-scroll.html
https://bugs.webkit.org/show_bug.cgi?id=80825
Patch by Robert Kroeger <rjkroege@chromium.org> on 2012-03-15
Reviewed by James Robinson.
* page/EventHandler.cpp:
(WebCore::EventHandler::handleWheelEvent): Corrected a typo.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110893
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy_horton@apple.com [Thu, 15 Mar 2012 22:09:19 +0000 (22:09 +0000)]
Remove mac-future results
https://bugs.webkit.org/show_bug.cgi?id=81275
There should never be anything in LayoutTests/platform/mac-future.
Please don't put anything there in the future.
Rubber-stamped by Alexey Proskuryakov.
* platform/mac-future/css1: Removed.
* platform/mac-future/css1/font_properties: Removed.
* platform/mac-future/css1/font_properties/font-expected.png: Removed.
* platform/mac-future/css2.1: Removed.
* platform/mac-future/css2.1/t1508-c527-font-05-b-expected.png: Removed.
* platform/mac-future/css2.1/t1508-c527-font-10-c-expected.png: Removed.
* platform/mac-future/fast: Removed.
* platform/mac-future/fast/css: Removed.
* platform/mac-future/fast/css/font-family-pictograph-expected.png: Removed.
* platform/mac-future/fast/css/font-family-pictograph-expected.txt: Removed.
* platform/mac-future/fast/dom: Removed.
* platform/mac-future/fast/dom/52776-expected.txt: Removed.
* platform/mac-future/fast/forms: Removed.
* platform/mac-future/fast/forms/listbox-bidi-align-expected.png: Removed.
* platform/mac-future/fast/repaint: Removed.
* platform/mac-future/fast/repaint/canvas-putImageData-expected.txt: Removed.
* platform/mac-future/fast/text: Removed.
* platform/mac-future/fast/text/capitalize-boundaries-expected.png: Removed.
* platform/mac-future/fast/writing-mode: Removed.
* platform/mac-future/fast/writing-mode/fallback-orientation-expected.png: Removed.
* platform/mac-future/media: Removed.
* platform/mac-future/media/video-display-toggle-expected.txt: Removed.
* platform/mac-future/media/video-no-audio-expected.txt: Removed.
* platform/mac-future/svg: Removed.
* platform/mac-future/svg/W3C-I18N: Removed.
* platform/mac-future/svg/W3C-SVG-1.1-SE: Removed.
* platform/mac-future/svg/batik: Removed.
* platform/mac-future/svg/batik/masking: Removed.
* platform/mac-future/svg/batik/text: Removed.
* platform/mac-future/svg/batik/text/textGlyphOrientationHorizontal-expected.png: Removed.
* platform/mac-future/svg/carto.net: Removed.
* platform/mac-future/svg/carto.net/scrollbar-expected.png: Removed.
* platform/mac-future/svg/custom: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110892
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
benjamin@webkit.org [Thu, 15 Mar 2012 21:54:33 +0000 (21:54 +0000)]
NumericStrings should be inlined
https://bugs.webkit.org/show_bug.cgi?id=81183
Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-03-15
Reviewed by Gavin Barraclough.
NumericStrings is not always inlined. When it is not, the class is not faster
than using UString::number() directly.
* runtime/NumericStrings.h:
(JSC::NumericStrings::add):
(JSC::NumericStrings::lookupSmallString):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110891
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Thu, 15 Mar 2012 21:46:12 +0000 (21:46 +0000)]
Move test results from mac-lion to mac
https://bugs.webkit.org/show_bug.cgi?id=81266
Reviewed by Jessie Berlin.
* platform/mac-lion/canvas: Removed.
* platform/mac-lion/canvas/philip: Removed.
* platform/mac-lion/canvas/philip/tests: Removed.
* platform/mac-lion/editing: Removed.
* platform/mac-lion/editing/inserting: Removed.
* platform/mac-lion/editing/inserting/break-blockquote-after-delete-expected.png: Removed.
* platform/mac-lion/fast: Removed.
* platform/mac-lion/fast/css: Removed.
* platform/mac-lion/fast/css/font-family-pictograph-expected.txt: Removed.
* platform/mac-lion/svg: Removed.
* platform/mac-lion/svg/W3C-SVG-1.1-SE: Removed.
* platform/mac-lion/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt: Removed.
* platform/mac/editing/inserting/break-blockquote-after-delete-expected.png:
* platform/mac/fast/css/font-family-pictograph-expected.txt: Copied from LayoutTests/platform/mac-lion/fast/css/font-family-pictograph-expected.txt.
* platform/mac/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110890
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Thu, 15 Mar 2012 21:39:18 +0000 (21:39 +0000)]
Fix crbug 117957 - get settings scrolling with the wheel again.
https://bugs.webkit.org/show_bug.cgi?id=81247
Patch by Scott Byer <scottbyer@chromium.org> on 2012-03-15
Reviewed by James Robinson.
Tests to follow.
* page/FrameView.cpp:
(WebCore::FrameView::serviceScriptedAnimations):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110889
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Thu, 15 Mar 2012 21:33:44 +0000 (21:33 +0000)]
REGRESSION(r107168?): Assertion failures under pageContainsAnyHorizontalScrollbars causing multiple "crashes" on the Lion Intel Debug WebKit2 testers
https://bugs.webkit.org/show_bug.cgi?id=81162
<rdar://problem/
11050423>
Reviewed by Beth Dakin and Jessie Berlin.
Downgrade the ASSERT to a simple if check since scrollableArea->isOnActivePage() can return false when layout happens during page transitions.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::pageContainsAnyHorizontalScrollbars):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110888
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Thu, 15 Mar 2012 21:30:18 +0000 (21:30 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=81258
Add a preference for enabling the new multi-column layout code that will be based on regions.
Reviewed by Beth Dakin.
Source/WebCore:
* page/Settings.cpp:
(WebCore::Settings::Settings):
* page/Settings.h:
(WebCore::Settings::setRegionBasedColumnsEnabled):
(WebCore::Settings::regionBasedColumnsEnabled):
(Settings):
Source/WebKit/mac:
* WebView/WebPreferenceKeysPrivate.h:
* WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences setRegionBasedColumnsEnabled:]):
(-[WebPreferences regionBasedColumnsEnabled]):
* WebView/WebPreferencesPrivate.h:
* WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
Source/WebKit2:
* Shared/WebPreferencesStore.h:
(WebKit):
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetRegionBasedColumnsEnabled):
(WKPreferencesGetRegionBasedColumnsEnabled):
* UIProcess/API/C/WKPreferencesPrivate.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110887
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kling@webkit.org [Thu, 15 Mar 2012 21:24:32 +0000 (21:24 +0000)]
RenderStyle: Return Color objects by value instead of as const references.
<http://webkit.org/b/81180>
Reviewed by Antti Koivisto.
Make RenderStyle getters return "Color" rather than "const Color&". This is preparation
for storing some color values in a more space-efficient fashion.
* css/CSSStyleApplyProperty.cpp:
(WebCore::ApplyPropertyColor::applyInheritValue):
* page/animation/AnimationBase.cpp:
(PropertyWrapperColor):
(WebCore::PropertyWrapperColor::PropertyWrapperColor):
(WebCore::PropertyWrapperColor::blend):
(WebCore::PropertyWrapperMaybeInvalidColor::PropertyWrapperMaybeInvalidColor):
(PropertyWrapperMaybeInvalidColor):
(WebCore::PropertyWrapperVisitedAffectedColor::PropertyWrapperVisitedAffectedColor):
(WebCore::PropertyWrapperSVGPaint::PropertyWrapperSVGPaint):
(PropertyWrapperSVGPaint):
* platform/graphics/Color.h:
(WebCore::Color::Color):
* rendering/style/RenderStyle.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110886
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Thu, 15 Mar 2012 21:16:05 +0000 (21:16 +0000)]
Can't swipe to go back/forward when the current page is a PDF document
https://bugs.webkit.org/show_bug.cgi?id=81194
<rdar://problem/6954125>
Reviewed by Sam Weinig.
Override -[PDFViewScrollView scrollWheel:] and have the new implementation call
-[WKPDFView forwardScrollWheelEvent:] when the PDF is pinned to either the left or right side.
WKPDFView will then call PDFController::forwardScrollWheelEvent which checks if we can go back or forward,
and passes the event along to the WKView which ends up triggering the swiping machinery in Safari.
* UIProcess/API/mac/PDFViewController.h:
* UIProcess/API/mac/PDFViewController.mm:
(-[WKPDFView forwardScrollWheelEvent:]):
(WebKit):
(WebKit::PDFViewController::forwardScrollWheelEvent):
(WebKit::findEnclosingWKPDFView):
(WebKit::PDFViewScrollView_scrollWheel):
(WebKit::PDFViewController::pdfKitBundle):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didCommitLoadForFrame):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110885
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jberlin@webkit.org [Thu, 15 Mar 2012 21:07:49 +0000 (21:07 +0000)]
Assertion failures in WebCore::Page::goBackOrForward causing multiple "crashes" on Lion Intel
Debug WebKit2 testers
https://bugs.webkit.org/show_bug.cgi?id=81159
Rubber-stamped by Brady Eidson.
It is plausible that history could change in between the time a navigation request is
scheduled and the timer is fired, so the request index could be out of the b/f list range.
Hence, the assertion is invalid and should be removed.
* page/Page.cpp:
(WebCore::Page::goBackOrForward):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110884
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jberlin@webkit.org [Thu, 15 Mar 2012 21:07:37 +0000 (21:07 +0000)]
fast/dom/Window/window-properties.html and fast/dom/prototype-inheritance-2.html failing on
Mac WK2 because WebAudio is not enabled
https://bugs.webkit.org/show_bug.cgi?id=81259
Reviewed by Dan Bernstein.
Enable WebAudio so that it appears in the window object in the tests.
The webaudio tests are all still skipped in the Mac Skipped list.
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetStateToConsistentValues):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110883
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Thu, 15 Mar 2012 21:07:16 +0000 (21:07 +0000)]
Assertion failures in checkEncodedString when running WebKit2 tests
https://bugs.webkit.org/show_bug.cgi?id=67425
<rdar://problem/
11043492>
Reviewed by Anders Carlsson.
* platform/network/cf/ResourceErrorCF.cpp: (WebCore::ResourceError::cfError):
* platform/network/mac/ResourceErrorMac.mm: (WebCore::ResourceError::nsError):
The failing URL is certainly not guaranteed to be valid, so it's not correct to put it back
into a URL as if it's been normalized by KURL.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110882
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abecsi@webkit.org [Thu, 15 Mar 2012 20:39:51 +0000 (20:39 +0000)]
Fix ARM build after r110792.
Unreviewed build fix.
* jit/ExecutableAllocator.h:
(JSC::ExecutableAllocator::cacheFlush):
Remove superfluous curly brackets.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110881
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Thu, 15 Mar 2012 20:23:05 +0000 (20:23 +0000)]
<rdar://problem/
11036900> and https://bugs.webkit.org/show_bug.cgi?id=81079 REGRESSION(r107844): Clipboard API only remembers most recent data set on clipboard
Reviewed by Sam Weinig.
Source/WebCore:
Test: editing/pasteboard/copy-two-pasteboard-types-both-work.html
Add the non-destructive "addTypes" to supplement the destructive "setTypes"
* platform/PasteboardStrategy.h:
(PasteboardStrategy):
* platform/PlatformPasteboard.h:
(PlatformPasteboard):
* platform/mac/PlatformPasteboardMac.mm:
(WebCore::PlatformPasteboard::addTypes):
* WebCore.exp.in:
* platform/mac/ClipboardMac.mm:
(WebCore::ClipboardMac::setData): Call the non-destructive "addTypes" instead of
the destructive "setTypes"
Source/WebKit/mac:
Add the non-destructive "addTypes" to supplement the destructive "setTypes"
* WebCoreSupport/WebPlatformStrategies.h:
* WebCoreSupport/WebPlatformStrategies.mm:
(WebPlatformStrategies::addTypes):
Source/WebKit2:
Add the non-destructive "addTypes" to supplement the destructive "setTypes"
* UIProcess/WebContext.h:
* UIProcess/WebContext.messages.in:
* UIProcess/mac/WebContextMac.mm:
(WebKit::WebContext::addPasteboardTypes):
* WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::addTypes):
* WebProcess/WebCoreSupport/WebPlatformStrategies.h:
LayoutTests:
* editing/pasteboard/copy-two-pasteboard-types-both-work-expected.txt: Added.
* editing/pasteboard/copy-two-pasteboard-types-both-work.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110880
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
leviw@chromium.org [Thu, 15 Mar 2012 20:09:55 +0000 (20:09 +0000)]
Unreviewed gardening. New flaky tests and new failure modes for old flaky tests.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110879
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 15 Mar 2012 20:06:19 +0000 (20:06 +0000)]
[Chromium] REGRESSION(r110596) CCQuadCullerTest.verifyCullChildLinesUpTopLeft fails on Windows
https://bugs.webkit.org/show_bug.cgi?id=81083
Patch by Dana Jansens <danakj@chromium.org> on 2012-03-15
Reviewed by Adrienne Walker.
Source/WebCore:
The surface pointer on the occlusion tracker stack is uninitialized, and
can be non-null, but the layer's target surface is null, causing asserts
to fail. Fixes the TestCCOcclusionTrackerImpl to initialize the stack's
surface to be null.
* platform/graphics/chromium/cc/CCOcclusionTracker.cpp:
(WebCore::::enterTargetRenderSurface):
(WebCore::::unoccludedContentRect):
* platform/graphics/chromium/cc/CCOcclusionTracker.h:
(WebCore::CCOcclusionTrackerBase::StackObject::StackObject):
Source/WebKit/chromium:
* tests/CCQuadCullerTest.cpp:
(WebCore::TEST):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110878
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Thu, 15 Mar 2012 20:06:11 +0000 (20:06 +0000)]
ARMv7: prefer vmov(gpr,gpr->double) over vmov(gpr->single)
https://bugs.webkit.org/show_bug.cgi?id=81256
Reviewed by Oliver Hunt.
This is a 0.5% sunspider progression.
* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::convertInt32ToDouble):
- switch which form of vmov we use.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110877
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 15 Mar 2012 19:55:37 +0000 (19:55 +0000)]
[EFL] Add OwnPtr specialization for Ecore_Timer.
https://bugs.webkit.org/show_bug.cgi?id=80119
Patch by YoungTaeck Song <youngtaeck.song@samsung.com> on 2012-03-15
Reviewed by Hajime Morita.
Add an overload for deleteOwnedPtr(Ecore_Timer*) on EFL port.
* wtf/OwnPtrCommon.h:
(WTF):
* wtf/efl/OwnPtrEfl.cpp:
(WTF::deleteOwnedPtr):
(WTF):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110876
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
levin@chromium.org [Thu, 15 Mar 2012 19:54:27 +0000 (19:54 +0000)]
Various autoresize fixes.
https://bugs.webkit.org/show_bug.cgi?id=81199
Reviewed by Darin Fisher.
Source/WebCore:
Tested by WebViewTest additions.
* page/FrameView.cpp:
(WebCore::FrameView::autoSizeIfEnabled): Fixed a bug that caused a horizontal
scrollbar to appear when the size was width was fixed and height overflowed which
is one of the tests that was added.
Source/WebKit/chromium:
* public/WebView.h:
(WebView): Remove a deprecated api.
* src/WebViewImpl.cpp: Ditto.
* src/WebViewImpl.h: Ditto.
* tests/FrameTestHelpers.cpp:
(WebKit::FrameTestHelpers::registerMockedURLLoad): Added an overload with more flexibility.
The previous api didn't allow one to request a url with a search string.
(FrameTestHelpers):
* tests/FrameTestHelpers.h:
(FrameTestHelpers): Ditto.
* tests/WebViewTest.cpp: Fix the test because calling javascript:
was working. Make the test generic and added a lot more tests to cover
various possibilities. I avoided using a layout test because there wasn't
a way to get the scrollbar state, so I just generalized a test that was already there.
* tests/data/specify_size.html: Allow the test to take its size from the search string.
Tools:
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::reset): Stop using the deprecated api that was removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110875
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 15 Mar 2012 19:54:15 +0000 (19:54 +0000)]
Linux has madvise enough to support OSAllocator::commit/decommit
https://bugs.webkit.org/show_bug.cgi?id=80505
Patch by Hojong Han <hojong.han@samsung.com> on 2012-03-15
Reviewed by Geoffrey Garen.
* wtf/OSAllocatorPosix.cpp:
(WTF::OSAllocator::reserveUncommitted):
(WTF::OSAllocator::commit):
(WTF::OSAllocator::decommit):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110874
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caseq@chromium.org [Thu, 15 Mar 2012 19:33:55 +0000 (19:33 +0000)]
Web Inspector: normalize vertical overview bars by longest bar, not by longest frame
https://bugs.webkit.org/show_bug.cgi?id=81231
Reviewed by Vsevolod Vlasov.
* inspector/front-end/TimelineOverviewPane.js:
(WebInspector.TimelineOverviewPane):
(WebInspector.TimelineOverviewPane.prototype.reset):
(WebInspector.TimelineOverviewPane.prototype.accept):
(WebInspector.TimelineOverviewPane.prototype.windowEndTime):
(WebInspector.TimelineVerticalOverview.prototype.reset):
(WebInspector.TimelineVerticalOverview.prototype.update):
(WebInspector.TimelineVerticalOverview.prototype._aggregateFrames):
(WebInspector.TimelineVerticalOverview.prototype._aggregateRecords):
(WebInspector.TimelineVerticalOverview.prototype.getWindowTimes):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110873
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caseq@chromium.org [Thu, 15 Mar 2012 19:29:57 +0000 (19:29 +0000)]
Web Inspector: crash in InspectorTimelineAgent when trying to add children to cancelable records
https://bugs.webkit.org/show_bug.cgi?id=81245
Reviewed by Vsevolod Vlasov.
* inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::addRecordToTimeline):
(WebCore):
(WebCore::InspectorTimelineAgent::innerAddRecordToTimeline):
(WebCore::InspectorTimelineAgent::appendRecord):
(WebCore::InspectorTimelineAgent::commitCancelableRecords):
* inspector/InspectorTimelineAgent.h:
(InspectorTimelineAgent):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110872
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken@apple.com [Thu, 15 Mar 2012 19:17:24 +0000 (19:17 +0000)]
Windows build fix.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreReleasePGO.vsprops:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreReleasePGOOptimize.vsprops:
* JavaScriptCore.vcproj/WTF/copy-files.cmd:
* JavaScriptCore.vcproj/jsc/jscReleasePGO.vsprops:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110871
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
schenney@chromium.org [Thu, 15 Mar 2012 19:16:58 +0000 (19:16 +0000)]
Temporarily skip svg/custom/delete-text-crash.html on mac and win
https://bugs.webkit.org/show_bug.cgi?id=81006
Unreviewed update of expectations.
Patch by Philip Rogers <pdr@google.com> on 2012-03-15
* platform/mac/Skipped:
* platform/win/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110870
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
schenney@chromium.org [Thu, 15 Mar 2012 19:10:38 +0000 (19:10 +0000)]
[Chromium] Cleanup of outdated test expectations
https://bugs.webkit.org/show_bug.cgi?id=81253
Unreviewed chromium test expectations update.
* platform/chromium/test_expectations.txt: Updated bug numbers or removed several SVG-related expectations.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110869
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Thu, 15 Mar 2012 18:55:39 +0000 (18:55 +0000)]
Web Inspector: live locations could be disposed twice.
https://bugs.webkit.org/show_bug.cgi?id=81249
Reviewed by Vsevolod Vlasov.
* inspector/front-end/ScriptMapping.js:
(WebInspector.MainScriptMapping.prototype._unregisterLiveLocation):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110868
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy_horton@apple.com [Thu, 15 Mar 2012 18:45:45 +0000 (18:45 +0000)]
Unreviewed rebaseline of canvas/philip/tests/2d.line.cap.round; the platform
independent results are correct for mac now, so remove the specific ones.
* platform/mac-snowleopard/canvas/philip/tests/2d.line.cap.round-expected.txt: Removed.
* platform/mac/canvas/philip/tests/2d.line.cap.round-expected.txt: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110867
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carlosgc@webkit.org [Thu, 15 Mar 2012 18:31:36 +0000 (18:31 +0000)]
[GTK] Actually use --release and --debug command line options in run-gtk-test
https://bugs.webkit.org/show_bug.cgi?id=81234
Reviewed by Philippe Normand.
Actually handle --release and --debug command line options to
create the build directory, falling back to current hack to detect
whether it's a Release or Debug build when both options are missed.
* Scripts/run-gtk-tests:
(TestRunner.__init__): Receive options too.
(TestRunner._get_top_level_directory): Helper function to get the
top level directory.
(TestRunner._get_build_directory): Helper function to get the
build directory depending on --release/--debug command line
options or gessing it if both options are missing.
(TestRunner._ensure_accessibility_daemon_is_running): Use
self-options now.
(TestRunner.run): Ditto.
(TestRunner.run.run_tests): Pass options to the constructor
instead of run().
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110866
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carlosgc@webkit.org [Thu, 15 Mar 2012 18:28:53 +0000 (18:28 +0000)]
[GTK] Implement unicode submenu items
https://bugs.webkit.org/show_bug.cgi?id=81117
Reviewed by Martin Robinson.
Source/WebCore:
* loader/EmptyClients.h:
(WebCore::EmptyEditorClient::shouldShowUnicodeMenu): Just return
false.
* page/ContextMenuController.cpp:
(WebCore::insertUnicodeCharacter): Helper function to insert a
unicode character.
(WebCore::ContextMenuController::contextMenuItemSelected):
Implement unicode menu items using insertUnicodeCharacter() to
insert the apropriate unicode character.
(WebCore::ContextMenuController::createAndAppendUnicodeSubMenu):
Create the unicode submenu.
(WebCore::ContextMenuController::populate): Add unicode submenu
item for editable content.
(WebCore::ContextMenuController::checkOrEnableIfNeeded): Add
unicode submenu items to the switch.
* page/ContextMenuController.h:
* page/EditorClient.h:
(EditorClient): Add shouldShowUnicodeMenu() for GTK platform.
* platform/ContextMenuItem.h:
* platform/LocalizedStrings.h:
* platform/gtk/LocalizedStringsGtk.cpp:
(WebCore::contextMenuItemTagUnicodeInsertLRMMark): Add localized
string for the unicode menu item.
(WebCore::contextMenuItemTagUnicodeInsertRLMMark): Ditto.
(WebCore::contextMenuItemTagUnicodeInsertLREMark): Ditto.
(WebCore::contextMenuItemTagUnicodeInsertRLEMark): Ditto.
(WebCore::contextMenuItemTagUnicodeInsertLROMark): Ditto.
(WebCore::contextMenuItemTagUnicodeInsertRLOMark): Ditto.
(WebCore::contextMenuItemTagUnicodeInsertPDFMark): Ditto.
(WebCore::contextMenuItemTagUnicodeInsertZWSMark): Ditto.
(WebCore::contextMenuItemTagUnicodeInsertZWJMark): Ditto.
(WebCore::contextMenuItemTagUnicodeInsertZWNJMark): Ditto.
Source/WebKit/gtk:
* WebCoreSupport/ContextMenuClientGtk.cpp:
(WebKit::getUnicodeMenuItemPosition): Helper function to get the
position of the unicode menu item in the default context menu.
(WebKit::ContextMenuClient::getCustomMenuFromDefaultItems): Remove
code to build the unicode menu, since it's now built by WebCore.
* WebCoreSupport/EditorClientGtk.cpp:
(WebKit::EditorClient::shouldShowUnicodeMenu): Check whether
unicode menu should be shown based on gtk-show-unicode-menu GtkSetting.
* WebCoreSupport/EditorClientGtk.h:
Source/WebKit2:
* WebProcess/WebCoreSupport/WebEditorClient.h:
* WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp:
(WebKit::WebEditorClient::shouldShowUnicodeMenu): Implement
shouldShowUnicodeMenu() returning always true. When ContextMenu
API is implemented for GTK+ the UI process will decide whether to
show the unicode menu or not.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110865
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vsevik@chromium.org [Thu, 15 Mar 2012 18:26:11 +0000 (18:26 +0000)]
Web Inspector: MainScriptMapping should detect snippet scripts by means of sourceURL set before evaluation.
https://bugs.webkit.org/show_bug.cgi?id=81031
Reviewed by Pavel Feldman.
Source/WebCore:
* inspector/front-end/SnippetsModel.js:
(WebInspector.SnippetsModel):
(WebInspector.SnippetsModel.prototype._saveSettings):
(WebInspector.SnippetsModel.prototype.deleteSnippet):
(WebInspector.SnippetsModel.prototype._snippetAdded):
(WebInspector.SnippetsModel.prototype._sourceURLForSnippet):
(WebInspector.SnippetsModel.prototype.snippetIdForSourceURL):
(WebInspector.SnippetsModel.prototype.snippetForSourceURL):
(WebInspector.Snippet.prototype.evaluate):
(WebInspector.SnippetsScriptMapping):
(WebInspector.SnippetsScriptMapping.prototype.uiLocationToRawLocation.get if):
(WebInspector.SnippetsScriptMapping.prototype.uiLocationToRawLocation):
(WebInspector.SnippetsScriptMapping.prototype._releasedUISourceCodes):
(WebInspector.SnippetsScriptMapping.prototype._snippetAdded):
(WebInspector.SnippetsScriptMapping.prototype._snippetWillBeEvaluated):
(WebInspector.SnippetsScriptMapping.prototype._snippetRemoved.get this):
(WebInspector.SnippetsScriptMapping.prototype._snippetRemoved):
LayoutTests:
* inspector/debugger/snippets-model-expected.txt:
* inspector/debugger/snippets-model.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110864
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken@apple.com [Thu, 15 Mar 2012 18:24:05 +0000 (18:24 +0000)]
Windows build fix.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.vcproj:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110863
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alexis.menard@openbossa.org [Thu, 15 Mar 2012 18:24:01 +0000 (18:24 +0000)]
Fix the test failing with run-perf-tests.
Rubber stamped by Ryosuke Niwa.
* CSS/CSSPropertySetterGetter.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110862
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carlosgc@webkit.org [Thu, 15 Mar 2012 17:37:48 +0000 (17:37 +0000)]
[GTK] Run unit tests with --verbose in the bots
https://bugs.webkit.org/show_bug.cgi?id=81230
Reviewed by Martin Robinson.
* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(RunGtkAPITests): Add --verbose to run-gtk-test command.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110861
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caryclark@google.com [Thu, 15 Mar 2012 17:32:08 +0000 (17:32 +0000)]
migrate Yang Guo's expectations from chromium to webkit
https://bugs.webkit.org/show_bug.cgi?id=81026
Unreviewed test_expectations.
Patch by Elliot Poger <epoger@google.com> on 2012-03-15
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110860
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kevino@webkit.org [Thu, 15 Mar 2012 17:28:53 +0000 (17:28 +0000)]
Unreviewed. Fix typos in ChangeLog dates.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110859
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kevino@webkit.org [Thu, 15 Mar 2012 17:25:01 +0000 (17:25 +0000)]
Move wx port to using export macros
https://bugs.webkit.org/show_bug.cgi?id=77279
Reviewed by Hajime Morita.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110858
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kevino@webkit.org [Thu, 15 Mar 2012 17:14:35 +0000 (17:14 +0000)]
[wx] Unreviewed. Build fixes for Mac and DOM bindings.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110857
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Thu, 15 Mar 2012 16:55:38 +0000 (16:55 +0000)]
Web Inspector: extract CompilerScriptMapping from RawSourceCode.
https://bugs.webkit.org/show_bug.cgi?id=81088
Reviewed by Vsevolod Vlasov.
Source/WebCore:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/compile-front-end.py:
* inspector/front-end/CompilerScriptMapping.js: Added.
(WebInspector.CompilerScriptMapping):
(WebInspector.CompilerScriptMapping.prototype.rawLocationToUILocation):
(WebInspector.CompilerScriptMapping.prototype.get uiSourceCodeList):
(WebInspector.CompilerScriptMapping.prototype.addScript.get this):
(WebInspector.CompilerScriptMapping.prototype.addScript):
(WebInspector.CompilerScriptMapping.prototype.loadSourceMapForScript):
(WebInspector.CompilerScriptMapping.prototype.reset):
* inspector/front-end/RawSourceCode.js:
(WebInspector.RawSourceCode):
(WebInspector.RawSourceCode.prototype.setFormatted):
(WebInspector.RawSourceCode.prototype._resourceFinished):
(WebInspector.RawSourceCode.prototype._createUISourceCode):
(WebInspector.RawSourceCode.FormattedSourceMapping.prototype.rawLocationToUILocation):
* inspector/front-end/ResourceScriptMapping.js:
(WebInspector.ResourceScriptMapping.prototype.addScript):
* inspector/front-end/ScriptMapping.js:
(WebInspector.MainScriptMapping):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:
LayoutTests:
* http/tests/inspector/compiler-source-mapping-expected.txt:
* http/tests/inspector/compiler-source-mapping.html:
* http/tests/inspector/debugger-test.js:
(initialize_DebuggerTest.):
(initialize_DebuggerTest):
* inspector/debugger/raw-source-code-expected.txt:
* inspector/debugger/raw-source-code.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110856
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jberlin@webkit.org [Thu, 15 Mar 2012 16:52:21 +0000 (16:52 +0000)]
css3/filters/custom/custom-filter-property-computed-style.html passes in browser, fails in DRT.
https://bugs.webkit.org/show_bug.cgi?id=81029
Land expected passing results for WKTR.
* platform/mac-wk2/css3/filters/custom/custom-filter-property-computed-style-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110855
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Thu, 15 Mar 2012 16:44:09 +0000 (16:44 +0000)]
Web Inspector: Move all includes behind ENABLE(INSPECTOR) guards
https://bugs.webkit.org/show_bug.cgi?id=81132
Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-03-15
Reviewed by Yury Semikhatsky.
Include directives are moved several lines down in .cpp files and in
generator templates.
* inspector/CodeGeneratorInspector.py:
* inspector/ContentSearchUtils.cpp:
* inspector/DOMEditor.cpp:
* inspector/DOMNodeHighlighter.cpp:
* inspector/DOMPatchSupport.cpp:
* inspector/IdentifiersFactory.cpp:
* inspector/InjectedScript.cpp:
* inspector/InjectedScriptHost.cpp:
* inspector/InjectedScriptManager.cpp:
* inspector/InspectorAgent.cpp:
* inspector/InspectorApplicationCacheAgent.cpp:
* inspector/InspectorBaseAgent.cpp:
* inspector/InspectorCSSAgent.cpp:
* inspector/InspectorClient.cpp:
* inspector/InspectorConsoleAgent.cpp:
* inspector/InspectorController.cpp:
* inspector/InspectorCounters.cpp:
* inspector/InspectorDOMAgent.cpp:
* inspector/InspectorDOMDebuggerAgent.cpp:
* inspector/InspectorDOMStorageAgent.cpp:
* inspector/InspectorDatabaseAgent.cpp:
* inspector/InspectorDatabaseResource.cpp:
* inspector/InspectorDebuggerAgent.cpp:
* inspector/InspectorFileSystemAgent.cpp:
* inspector/InspectorFrontendClientLocal.cpp:
* inspector/InspectorFrontendHost.cpp:
* inspector/InspectorHistory.cpp:
* inspector/InspectorIndexedDBAgent.cpp:
* inspector/InspectorInstrumentation.cpp:
* inspector/InspectorMemoryAgent.cpp:
* inspector/InspectorPageAgent.cpp:
* inspector/InspectorProfilerAgent.cpp:
* inspector/InspectorResourceAgent.cpp:
* inspector/InspectorRuntimeAgent.cpp:
* inspector/InspectorState.cpp:
* inspector/InspectorStyleSheet.cpp:
* inspector/InspectorStyleTextEditor.cpp:
* inspector/InspectorTimelineAgent.cpp:
* inspector/InspectorValues.cpp:
* inspector/InstrumentingAgents.cpp:
* inspector/NetworkResourcesData.cpp:
* inspector/PageConsoleAgent.cpp:
* inspector/PageDebuggerAgent.cpp:
* inspector/PageRuntimeAgent.cpp:
* inspector/TimelineRecordFactory.cpp:
* inspector/WorkerConsoleAgent.cpp:
* inspector/WorkerDebuggerAgent.cpp:
* inspector/WorkerRuntimeAgent.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110854
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Thu, 15 Mar 2012 16:39:47 +0000 (16:39 +0000)]
Web Inspector: improve HeapSnapshot._buildReversIndex performance
https://bugs.webkit.org/show_bug.cgi?id=81224
Caching node indexes and node count in local variables instead of
calling getters each time reduces the method run time by
factor of 1.5
Reviewed by Pavel Feldman.
* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshot.prototype._buildReverseIndex):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110853
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
leviw@chromium.org [Thu, 15 Mar 2012 16:35:52 +0000 (16:35 +0000)]
Unreviewed gardening.
Updating slightly changed SVG animation text expectations post-110545.
* platform/chromium-linux-x86/fast/repaint/moving-shadow-on-path-expected.txt: Removed.
* platform/chromium-linux-x86/svg/css/stars-with-shadow-expected.txt: Removed.
* platform/chromium-linux/fast/repaint/moving-shadow-on-container-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/css/stars-with-shadow-expected.txt: Added.
* platform/chromium-mac/svg/css/stars-with-shadow-expected.txt: Added.
* platform/chromium-win-vista/fast/repaint: Removed.
* platform/chromium-win-xp/fast/repaint/moving-shadow-on-container-expected.txt: Added.
* platform/chromium-win/fast/repaint/moving-shadow-on-container-expected.txt: Added.
* platform/chromium/fast/repaint/moving-shadow-on-path-expected.txt: Replaced.
* platform/chromium/svg/css/stars-with-shadow-expected.txt: Replaced.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110852
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Thu, 15 Mar 2012 16:03:49 +0000 (16:03 +0000)]
2012-03-15 Nikolas Zimmermann <nzimmermann@rim.com>
SVG Animations update baseVal instead of animVal
https://bugs.webkit.org/show_bug.cgi?id=12437
Rubber-stamped by Rob Buis.
Rename constructFromCopy to constructFromVariant, and currentBaseValue to currentBaseValueVariant, to clarify what it actually does.
* svg/SVGAnimateElement.cpp:
(WebCore::SVGAnimateElement::resetToBaseValue):
* svg/SVGAnimatedLength.cpp:
(WebCore::SVGAnimatedLengthAnimator::constructFromVariant):
* svg/SVGAnimatedLength.h:
(SVGAnimatedLengthAnimator):
* svg/SVGAnimatedLengthList.cpp:
(WebCore::SVGAnimatedLengthListAnimator::constructFromVariant):
* svg/SVGAnimatedLengthList.h:
(SVGAnimatedLengthListAnimator):
* svg/SVGAnimatedNumber.cpp:
(WebCore::SVGAnimatedNumberAnimator::constructFromVariant):
* svg/SVGAnimatedNumber.h:
(SVGAnimatedNumberAnimator):
* svg/SVGAnimatedNumberList.cpp:
(WebCore::SVGAnimatedNumberListAnimator::constructFromVariant):
* svg/SVGAnimatedNumberList.h:
(SVGAnimatedNumberListAnimator):
* svg/SVGAnimatedTransformList.cpp:
(WebCore::SVGAnimatedTransformListAnimator::constructFromVariant):
* svg/SVGAnimatedTransformList.h:
(SVGAnimatedTransformListAnimator):
* svg/SVGAnimatedTypeAnimator.h:
(WebCore::SVGAnimatedTypeAnimator::constructFromVariant):
* svg/properties/SVGAnimatedListPropertyTearOff.h:
(WebCore::SVGAnimatedListPropertyTearOff::currentBaseValueVariant):
* svg/properties/SVGAnimatedProperty.h:
(SVGAnimatedProperty):
* svg/properties/SVGAnimatedPropertyTearOff.h:
(WebCore::SVGAnimatedPropertyTearOff::currentBaseValueVariant):
* svg/properties/SVGAnimatedStaticPropertyTearOff.h:
(WebCore::SVGAnimatedStaticPropertyTearOff::currentBaseValueVariant):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110851
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abecsi@webkit.org [Thu, 15 Mar 2012 15:58:45 +0000 (15:58 +0000)]
[Qt][WK2] Fix bounce-back behaviour for panning
https://bugs.webkit.org/show_bug.cgi?id=81144
Reviewed by Kenneth Rohde Christiansen.
Move the content back to boundaries immediately
in response to a tap gesture during the bounce-back
animation after panning.
* UIProcess/qt/QtPanGestureRecognizer.cpp:
(WebKit::QtPanGestureRecognizer::recognize):
* UIProcess/qt/QtViewportInteractionEngine.h:
Make the ensureContentWithinViewportBoundary function public.
(QtViewportInteractionEngine):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110850
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
senorblanco@chromium.org [Thu, 15 Mar 2012 15:36:06 +0000 (15:36 +0000)]
[chromium] Unreviewed gardening.
Updated Lion baselines for css3/filters. Skipped all custom tests,
and removed all baselines, since support is not currently compiled in.
* platform/chromium-mac-leopard/css3/filters/custom: Removed.
* platform/chromium-mac-leopard/css3/filters/custom/effect-custom-combined-missing-expected.png: Removed.
* platform/chromium-mac-leopard/css3/filters/custom/effect-custom-expected.png: Removed.
* platform/chromium-mac-leopard/css3/filters/custom/effect-custom-parameters-expected.png: Removed.
* platform/chromium-mac-snowleopard/css3/filters/composited-during-transition-layertree-expected.txt: Removed.
* platform/chromium-mac-snowleopard/css3/filters/custom: Removed.
* platform/chromium-mac-snowleopard/css3/filters/custom/effect-custom-combined-missing-expected.png: Removed.
* platform/chromium-mac-snowleopard/css3/filters/effect-brightness-expected.png: Removed.
* platform/chromium-mac-snowleopard/css3/filters/effect-brightness-expected.txt: Removed.
* platform/chromium-mac-snowleopard/css3/filters/effect-brightness-hw-expected.png: Removed.
* platform/chromium-mac-snowleopard/css3/filters/effect-combined-expected.png: Removed.
* platform/chromium-mac-snowleopard/css3/filters/effect-combined-expected.txt: Removed.
* platform/chromium-mac-snowleopard/css3/filters/effect-contrast-expected.png: Removed.
* platform/chromium-mac-snowleopard/css3/filters/effect-contrast-expected.txt: Removed.
* platform/chromium-mac-snowleopard/css3/filters/effect-grayscale-expected.png: Removed.
* platform/chromium-mac-snowleopard/css3/filters/effect-grayscale-expected.txt: Removed.
* platform/chromium-mac-snowleopard/css3/filters/effect-hue-rotate-expected.png: Removed.
* platform/chromium-mac-snowleopard/css3/filters/effect-hue-rotate-expected.txt: Removed.
* platform/chromium-mac-snowleopard/css3/filters/effect-invert-expected.png: Removed.
* platform/chromium-mac-snowleopard/css3/filters/effect-invert-expected.txt: Removed.
* platform/chromium-mac-snowleopard/css3/filters/effect-invert-hw-expected.png: Removed.
* platform/chromium-mac-snowleopard/css3/filters/effect-opacity-expected.png: Removed.
* platform/chromium-mac-snowleopard/css3/filters/effect-opacity-expected.txt: Removed.
* platform/chromium-mac-snowleopard/css3/filters/effect-saturate-expected.png: Removed.
* platform/chromium-mac-snowleopard/css3/filters/effect-saturate-expected.txt: Removed.
* platform/chromium-mac-snowleopard/css3/filters/effect-saturate-hw-expected.png: Removed.
* platform/chromium-mac-snowleopard/css3/filters/effect-sepia-expected.png: Removed.
* platform/chromium-mac-snowleopard/css3/filters/effect-sepia-expected.txt: Removed.
* platform/chromium-mac-snowleopard/css3/filters/effect-sepia-hw-expected.png: Removed.
* platform/chromium-mac-snowleopard/css3/filters/filter-repaint-expected.png: Removed.
* platform/chromium-mac-snowleopard/css3/filters/filter-with-transform-expected.png: Removed.
* platform/chromium-mac-snowleopard/css3/filters/nested-filter-expected.png: Removed.
* platform/chromium-mac-snowleopard/css3/filters/nested-filters-expected.png: Removed.
* platform/chromium-mac-snowleopard/css3/filters/regions-expanding-expected.png: Removed.
* platform/chromium-mac/css3/filters/composited-during-transition-layertree-expected.txt: Added.
* platform/chromium-mac/css3/filters/effect-brightness-expected.png: Added.
* platform/chromium-mac/css3/filters/effect-brightness-expected.txt: Added.
* platform/chromium-mac/css3/filters/effect-brightness-hw-expected.png: Added.
* platform/chromium-mac/css3/filters/effect-combined-expected.png: Added.
* platform/chromium-mac/css3/filters/effect-combined-expected.txt: Added.
* platform/chromium-mac/css3/filters/effect-contrast-expected.png: Added.
* platform/chromium-mac/css3/filters/effect-contrast-expected.txt: Added.
* platform/chromium-mac/css3/filters/effect-grayscale-expected.png: Added.
* platform/chromium-mac/css3/filters/effect-grayscale-expected.txt: Added.
* platform/chromium-mac/css3/filters/effect-hue-rotate-expected.png: Added.
* platform/chromium-mac/css3/filters/effect-hue-rotate-expected.txt: Added.
* platform/chromium-mac/css3/filters/effect-invert-expected.png: Added.
* platform/chromium-mac/css3/filters/effect-invert-expected.txt: Added.
* platform/chromium-mac/css3/filters/effect-invert-hw-expected.png: Added.
* platform/chromium-mac/css3/filters/effect-opacity-expected.png: Added.
* platform/chromium-mac/css3/filters/effect-opacity-expected.txt: Added.
* platform/chromium-mac/css3/filters/effect-saturate-expected.png: Added.
* platform/chromium-mac/css3/filters/effect-saturate-expected.txt: Added.
* platform/chromium-mac/css3/filters/effect-saturate-hw-expected.png: Added.
* platform/chromium-mac/css3/filters/effect-sepia-expected.png: Added.
* platform/chromium-mac/css3/filters/effect-sepia-expected.txt: Added.
* platform/chromium-mac/css3/filters/effect-sepia-hw-expected.png: Added.
* platform/chromium-mac/css3/filters/filter-repaint-expected.png: Added.
* platform/chromium-mac/css3/filters/filter-with-transform-expected.png: Added.
* platform/chromium-mac/css3/filters/nested-filter-expected.png: Added.
* platform/chromium-mac/css3/filters/nested-filters-expected.png: Added.
* platform/chromium-mac/css3/filters/regions-expanding-expected.png: Added.
* platform/chromium-win/css3/filters/custom: Removed.
* platform/chromium-win/css3/filters/custom/effect-custom-combined-missing-expected.png: Removed.
* platform/chromium-win/css3/filters/custom/effect-custom-expected.png: Removed.
* platform/chromium-win/css3/filters/custom/effect-custom-parameters-expected.png: Removed.
* platform/chromium/css3/filters/custom: Removed.
* platform/chromium/css3/filters/custom/effect-custom-combined-missing-expected.txt: Removed.
* platform/chromium/css3/filters/custom/effect-custom-disabled-expected.txt: Removed.
* platform/chromium/css3/filters/custom/effect-custom-expected.txt: Removed.
* platform/chromium/css3/filters/custom/effect-custom-parameters-expected.txt: Removed.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110849
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Thu, 15 Mar 2012 15:27:21 +0000 (15:27 +0000)]
Enable animVal support for SVGNumberList
https://bugs.webkit.org/show_bug.cgi?id=81219
Reviewed by Rob Buis.
Source/WebCore:
Enable animVal support for SVGNumberList. Easy patch, we just need to add the missing
constructFromCopy() method to SVGAnumatedNumberListAnimator and report AnimatedNumberList
as supporting animVal.
Covered by existing tests.
* svg/SVGAnimatedNumberList.cpp:
(WebCore::SVGAnimatedNumberListAnimator::constructFromCopy):
(WebCore):
* svg/SVGAnimatedNumberList.h:
(WebCore):
(SVGAnimatedNumberListAnimator):
* svg/SVGAnimatedType.cpp:
(WebCore::SVGAnimatedType::supportsAnimVal):
(WebCore::SVGAnimatedType::setVariantValue):
LayoutTests:
Extend SVGNumberList tests to cover animVal/baseVal at the same time.
* platform/chromium/test_expectations.txt:
* svg/animations/script-tests/svgnumberlist-animation-1.js:
(sample1):
(sample2):
(sample3):
(sample4):
(executeTest):
* svg/animations/script-tests/svgnumberlist-animation-2.js:
(sample1):
(sample2):
(sample3):
(sample4):
(executeTest):
* svg/animations/svgnumberlist-animation-1-expected.txt:
* svg/animations/svgnumberlist-animation-2-expected.txt:
* svg/filters/feColorMatrix-invalid-animation-expected.txt: We no longer mutate the DOM, thus the dump is now correct.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110848
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Thu, 15 Mar 2012 15:12:54 +0000 (15:12 +0000)]
Unreviewed, GTK build fix attempt after r110845.
* Scripts/run-gtk-tests: Added --release and --debug options.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110847
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kubo@profusion.mobi [Thu, 15 Mar 2012 14:58:55 +0000 (14:58 +0000)]
Parametrize run-with-jhbuild and update-webkitgtk-libs with platform --gtk/--efl
https://bugs.webkit.org/show_bug.cgi?id=79673
Preparatory work for bringing jhbuild enabled build to EFL port.
Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-03-15
Reviewed by Philippe Normand.
* Scripts/update-webkit-libs-jhbuild: Copied from Tools/Scripts/update-webkitgtk-libs.
* Scripts/update-webkitgtk-libs:
* gtk/run-with-jhbuild:
* jhbuild/jhbuild-wrapper: Copied from Tools/gtk/run-with-jhbuild.
(top_level_path):
(jhbuild_installed):
(jhbuild_cloned):
(jhbuild_at_expected_revision):
(update_jhbuild):
(clone_jhbuild):
(install_jhbuild):
(update_webkit_libs_jhbuild):
(determine_platform):
(ensure_jhbuild):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110846
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carlosgc@webkit.org [Thu, 15 Mar 2012 14:44:26 +0000 (14:44 +0000)]
[GTK] Add command line options to run-gtk-tests script
https://bugs.webkit.org/show_bug.cgi?id=81218
Reviewed by Philippe Normand.
Following command line options have been added:
-v, --verbose: to run gtester with --verbose. That would be used
by the bots to make it easier to know which test case it failing.
--display: to use a different display for Xvfb
It's also possible to pass one or more tests as arguments.
* Scripts/run-gtk-tests:
(TestRunner.__init__): Receive command line arguments.
(TestRunner._get_tests): Get all the tests or the ones passed by
command line arguments.
(TestRunner._ensure_accessibility_daemon_is_running): Use display
command line argument.
(TestRunner.run): Pas command line options.
(TestRunner.run.run_tests): Pass command line arguments.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110845
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rwlbuis@webkit.org [Thu, 15 Mar 2012 14:34:16 +0000 (14:34 +0000)]
Fix cast-align GCC warnings
https://bugs.webkit.org/show_bug.cgi?id=80790
Reviewed by Nikolas Zimmermann.
* platform/graphics/WOFFFileFormat.cpp:
(WebCore::writeUInt32):
(WebCore::writeUInt16):
(WebCore::convertWOFFToSfnt):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110844
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
peter@chromium.org [Thu, 15 Mar 2012 14:17:50 +0000 (14:17 +0000)]
Unreviewed. Rolled DEPS.
* DEPS:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110843
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Thu, 15 Mar 2012 14:15:52 +0000 (14:15 +0000)]
2012-03-15 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Forgot to preserve copyrights, per reviewer comment.
* svg/SVGAnimatedTransformList.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110842
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Thu, 15 Mar 2012 14:12:58 +0000 (14:12 +0000)]
Enable animVal support for SVGNumber
https://bugs.webkit.org/show_bug.cgi?id=81212
Reviewed by Rob Buis.
Source/WebCore:
Enable animVal support for SVGNumber. This aligns SVGAnimatedStaticPropertyTearOff,
with the other SVGListPropertyTearOff & SVGPropertyTearOff, as all support animVal now.
Converting the rest of the types can be done in small patches now.
Test: svg/animations/svgnumber-animation-4.html
* svg/SVGAnimatedNumber.cpp:
(WebCore::SVGAnimatedNumberAnimator::constructFromCopy):
(WebCore):
* svg/SVGAnimatedNumber.h:
(WebCore):
(SVGAnimatedNumberAnimator):
* svg/SVGAnimatedType.cpp:
(WebCore::SVGAnimatedType::supportsAnimVal):
(WebCore::SVGAnimatedType::setVariantValue):
* svg/properties/SVGAnimatedProperty.h:
(SVGAnimatedProperty):
* svg/properties/SVGAnimatedStaticPropertyTearOff.h:
(WebCore::SVGAnimatedStaticPropertyTearOff::animVal):
(WebCore::SVGAnimatedStaticPropertyTearOff::currentAnimatedValue):
(SVGAnimatedStaticPropertyTearOff):
(WebCore::SVGAnimatedStaticPropertyTearOff::currentBaseValue):
(WebCore::SVGAnimatedStaticPropertyTearOff::animationStarted):
(WebCore::SVGAnimatedStaticPropertyTearOff::animationEnded):
(WebCore::SVGAnimatedStaticPropertyTearOff::animationValueWillChange):
(WebCore::SVGAnimatedStaticPropertyTearOff::animationValueDidChange):
(WebCore::SVGAnimatedStaticPropertyTearOff::SVGAnimatedStaticPropertyTearOff):
LayoutTests:
Add new test covering animVal support for SVGNumber.
* svg/animations/script-tests/svgnumber-animation-4.js: Added.
(sample1):
(sample2):
(sample3):
(executeTest):
* svg/animations/svgnumber-animation-4-expected.txt: Added.
* svg/animations/svgnumber-animation-4.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110841
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carlosgc@webkit.org [Thu, 15 Mar 2012 14:00:03 +0000 (14:00 +0000)]
[GTK] WebKit2APITests/TestPrinting timeout in the bots
https://bugs.webkit.org/show_bug.cgi?id=81211
Reviewed by Philippe Normand.
Add gtk+ patch to fix timeout in the bots. A similar patch has
already landed in updatream gtk+, see
http://git.gnome.org/browse/gtk+/commit/?id=
5ebfad5d091f4c9d9c6e60364fad4c60842f027f
* gtk/jhbuild.modules:
* gtk/patches/gtk+-3.0.12-gtkprinter.patch: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110840
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Thu, 15 Mar 2012 13:34:14 +0000 (13:34 +0000)]
2012-03-15 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Fix typo introduced in my last patch leading to flakiness.
* svg/animations/script-tests/animateTransform-pattern-transform.js:
(executeTest):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110839
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Thu, 15 Mar 2012 13:09:28 +0000 (13:09 +0000)]
Enable animVal support for SVGTransformList
https://bugs.webkit.org/show_bug.cgi?id=80758
Reviewed by Antti Koivisto.
Source/WebCore:
Enable animVal support for SVGTransformList. SVGTransformLists are only animatable
via <animateTransform>, not via <animate> directly. Still we can handle it in the
same framework as all other types used for <animate>, as we also need proper animVal
support for <animateTransform>.
This patch removes the special <animateTransform> implementation, and lets
SVGAnimateTransformElement inherit from SVGAnimateElement, just like its done
for SVGAnimateColorElement & SVGSetElement.
All existing code (calculateFromAndToValues/FromAndByValues/etc..) are moved from
SVGAnimateTransform right into the SVGAnimatedTransformListAnimator.
This doesn't change <animateTransform> behavior, it just simplies the code
and enables animVal support for SVGTransformLists - all covered by existing tests.
* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
* svg/SVGAllInOne.cpp:
* svg/SVGAnimateElement.cpp:
(WebCore::SVGAnimateElement::SVGAnimateElement):
(WebCore::SVGAnimateElement::determineAnimatedPropertyType):
(WebCore::SVGAnimateElement::calculateAnimatedValue):
(WebCore::SVGAnimateElement::applyResultsToTarget):
* svg/SVGAnimateTransformElement.cpp:
(WebCore::SVGAnimateTransformElement::SVGAnimateTransformElement):
(WebCore::SVGAnimateTransformElement::hasValidAttributeType):
(WebCore::SVGAnimateTransformElement::parseAttribute):
* svg/SVGAnimateTransformElement.h:
(WebCore::SVGAnimateTransformElement::transformType):
(SVGAnimateTransformElement):
* svg/SVGAnimatedTransformList.cpp: Added.
(WebCore):
(WebCore::SVGAnimatedTransformListAnimator::SVGAnimatedTransformListAnimator):
(WebCore::SVGAnimatedTransformListAnimator::constructFromString):
(WebCore::SVGAnimatedTransformListAnimator::constructFromCopy):
(WebCore::SVGAnimatedTransformListAnimator::calculateFromAndToValues):
(WebCore::SVGAnimatedTransformListAnimator::calculateFromAndByValues):
(WebCore::SVGAnimatedTransformListAnimator::calculateAnimatedValue):
(WebCore::SVGAnimatedTransformListAnimator::calculateDistance):
* svg/SVGAnimatedTransformList.h:
(WebCore):
(SVGAnimatedTransformListAnimator):
(WebCore::SVGAnimatedTransformListAnimator::~SVGAnimatedTransformListAnimator):
* svg/SVGAnimatedType.cpp:
(WebCore::SVGAnimatedType::~SVGAnimatedType):
(WebCore::SVGAnimatedType::createTransformList):
(WebCore):
(WebCore::SVGAnimatedType::transformList):
(WebCore::SVGAnimatedType::valueAsString):
(WebCore::SVGAnimatedType::setValueAsString):
(WebCore::SVGAnimatedType::supportsAnimVal):
(WebCore::SVGAnimatedType::setVariantValue):
* svg/SVGAnimatedType.h:
(WebCore):
(SVGAnimatedType):
* svg/SVGAnimatorFactory.h:
(WebCore::SVGAnimatorFactory::create):
* svg/SVGGradientElement.cpp:
(WebCore::SVGGradientElement::parseAttribute):
* svg/SVGPatternElement.cpp:
(WebCore::SVGPatternElement::parseAttribute):
* svg/SVGStyledTransformableElement.cpp:
(WebCore::SVGStyledTransformableElement::parseAttribute):
* svg/SVGTextElement.cpp:
(WebCore::SVGTextElement::parseAttribute):
* svg/SVGTransform.cpp:
(WebCore::SVGTransform::transformTypePrefixForParsing):
(WebCore):
(WebCore::SVGTransform::valueAsString):
* svg/SVGTransform.h:
(SVGTransform):
* svg/SVGTransformList.cpp:
(WebCore::SVGTransformList::parse):
(WebCore):
* svg/SVGTransformList.h:
(SVGTransformList):
* svg/SVGTransformable.cpp:
(WebCore::SVGTransformable::parseTransformType):
* svg/SVGTransformable.h:
(WebCore):
* svg/SVGViewSpec.cpp:
(WebCore::SVGViewSpec::setTransform):
LayoutTests:
Rebaseline tests after enabling animVal support SVGAnimateTransformElement/SVGTransformList.
* svg/animations/animate-gradient-transform-expected.txt:
* svg/animations/animateTransform-pattern-transform-expected.txt:
* svg/animations/script-tests/animate-gradient-transform.js:
(sample1):
(sample2):
(sample3):
(executeTest):
* svg/animations/script-tests/animateTransform-pattern-transform.js:
(sample1):
(sample2):
(sample3):
(sample4):
(executeTest):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110838
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kov@webkit.org [Thu, 15 Mar 2012 12:50:24 +0000 (12:50 +0000)]
sheriffbot should also be addressable with a comma in addition to colon
https://bugs.webkit.org/show_bug.cgi?id=81101
Reviewed by Adam Barth.
* Scripts/webkitpy/common/net/irc/ircbot.py:
(IRCBot.on_pubmsg):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110837
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ahf@0x90.dk [Thu, 15 Mar 2012 12:06:47 +0000 (12:06 +0000)]
[Qt] MiniBrowser scroll indicators should not scroll out of view https://bugs.webkit.org/show_bug.cgi?id=81131
Reviewed by Kenneth Rohde Christiansen.
* MiniBrowser/qt/qml/ScrollIndicator.qml:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110836
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Thu, 15 Mar 2012 10:00:04 +0000 (10:00 +0000)]
Enable animVal support for SVGLengthList
https://bugs.webkit.org/show_bug.cgi?id=80750
Reviewed by Zoltan Herczeg.
Source/WebCore:
Introduce animVal support for generic SVGList types. This aligns SVGListProperty with SVGProperty
in terms of animVal/baseVal support. Use this to turn on animVal support for SVGLengthList.
Extend all existing SVGLengthList tests to correctly differentiate between baseVal/animVal.
* svg/SVGAnimateElement.cpp:
(WebCore::SVGAnimateElement::calculateAnimatedValue):
* svg/SVGAnimateTransformElement.cpp:
(WebCore::SVGAnimateTransformElement::resetToBaseValue):
(WebCore::SVGAnimateTransformElement::calculateAnimatedValue):
(WebCore::SVGAnimateTransformElement::applyResultsToTarget):
* svg/SVGAnimatedLengthList.cpp:
(WebCore::SVGAnimatedLengthListAnimator::constructFromCopy):
(WebCore):
* svg/SVGAnimatedLengthList.h:
(WebCore):
(SVGAnimatedLengthListAnimator):
* svg/SVGAnimatedType.cpp:
(WebCore::SVGAnimatedType::supportsAnimVal):
(WebCore::SVGAnimatedType::setVariantValue):
* svg/SVGAnimatedType.h:
* svg/SVGAnimationElement.cpp:
(WebCore::SVGAnimationElement::applyAnimatedValue):
* svg/properties/SVGAnimatedListPropertyTearOff.h:
(SVGAnimatedListPropertyTearOff):
(WebCore::SVGAnimatedListPropertyTearOff::baseVal):
(WebCore::SVGAnimatedListPropertyTearOff::animVal):
(WebCore::SVGAnimatedListPropertyTearOff::removeItemFromList):
(WebCore::SVGAnimatedListPropertyTearOff::detachListWrappers):
(WebCore::SVGAnimatedListPropertyTearOff::currentAnimatedValue):
(WebCore::SVGAnimatedListPropertyTearOff::currentBaseValue):
(WebCore::SVGAnimatedListPropertyTearOff::animationStarted):
(WebCore::SVGAnimatedListPropertyTearOff::animationEnded):
(WebCore::SVGAnimatedListPropertyTearOff::synchronizeWrappersIfNeeded):
(WebCore::SVGAnimatedListPropertyTearOff::animationValueWillChange):
(WebCore::SVGAnimatedListPropertyTearOff::animationValueDidChange):
* svg/properties/SVGAnimatedPathSegListPropertyTearOff.h:
(WebCore::SVGAnimatedPathSegListPropertyTearOff::baseVal):
(WebCore::SVGAnimatedPathSegListPropertyTearOff::animVal):
* svg/properties/SVGAnimatedProperty.h:
(WebCore::SVGAnimatedProperty::isAnimating):
(SVGAnimatedProperty):
(WebCore::SVGAnimatedProperty::animationValueWillChange):
(WebCore::SVGAnimatedProperty::animationValueDidChange):
(WebCore::SVGAnimatedProperty::~SVGAnimatedProperty):
(WebCore::SVGAnimatedProperty::SVGAnimatedProperty):
* svg/properties/SVGAnimatedPropertyTearOff.h:
(SVGAnimatedPropertyTearOff):
(WebCore::SVGAnimatedPropertyTearOff::baseVal):
(WebCore::SVGAnimatedPropertyTearOff::animVal):
(WebCore::SVGAnimatedPropertyTearOff::currentAnimatedValue):
(WebCore::SVGAnimatedPropertyTearOff::animationStarted):
(WebCore::SVGAnimatedPropertyTearOff::animationEnded):
(WebCore::SVGAnimatedPropertyTearOff::animationValueWillChange):
(WebCore::SVGAnimatedPropertyTearOff::animationValueDidChange):
(WebCore::SVGAnimatedPropertyTearOff::SVGAnimatedPropertyTearOff):
* svg/properties/SVGAnimatedTransformListPropertyTearOff.h:
(WebCore::SVGAnimatedTransformListPropertyTearOff::baseVal):
(WebCore::SVGAnimatedTransformListPropertyTearOff::animVal):
* svg/properties/SVGListProperty.h:
(WebCore::SVGListProperty::detachListWrappers):
(SVGListProperty):
(WebCore::SVGListProperty::setValuesAndWrappers):
(WebCore::SVGListProperty::clearValues):
(WebCore::SVGListProperty::clearValuesAndWrappers):
(WebCore::SVGListProperty::numberOfItems):
(WebCore::SVGListProperty::initializeValues):
(WebCore::SVGListProperty::initializeValuesAndWrappers):
(WebCore::SVGListProperty::canGetItem):
(WebCore::SVGListProperty::getItemValues):
(WebCore::SVGListProperty::getItemValuesAndWrappers):
(WebCore::SVGListProperty::insertItemBeforeValues):
(WebCore::SVGListProperty::insertItemBeforeValuesAndWrappers):
(WebCore::SVGListProperty::canReplaceItem):
(WebCore::SVGListProperty::replaceItemValues):
(WebCore::SVGListProperty::replaceItemValuesAndWrappers):
(WebCore::SVGListProperty::canRemoveItem):
(WebCore::SVGListProperty::removeItemValues):
(WebCore::SVGListProperty::removeItemValuesAndWrappers):
(WebCore::SVGListProperty::appendItemValues):
(WebCore::SVGListProperty::appendItemValuesAndWrappers):
(WebCore::SVGListProperty::values):
(WebCore::SVGListProperty::wrappers):
(WebCore::SVGListProperty::SVGListProperty):
* svg/properties/SVGListPropertyTearOff.h:
(SVGListPropertyTearOff):
(WebCore::SVGListPropertyTearOff::create):
(WebCore::SVGListPropertyTearOff::removeItemFromList):
(WebCore::SVGListPropertyTearOff::clear):
(WebCore::SVGListPropertyTearOff::initialize):
(WebCore::SVGListPropertyTearOff::insertItemBefore):
(WebCore::SVGListPropertyTearOff::replaceItem):
(WebCore::SVGListPropertyTearOff::appendItem):
(WebCore::SVGListPropertyTearOff::SVGListPropertyTearOff):
(WebCore::SVGListPropertyTearOff::commitChange):
* svg/properties/SVGPathSegListPropertyTearOff.cpp:
(WebCore::SVGPathSegListPropertyTearOff::clear):
(WebCore::SVGPathSegListPropertyTearOff::getItem):
(WebCore::SVGPathSegListPropertyTearOff::removeItem):
* svg/properties/SVGPathSegListPropertyTearOff.h:
(WebCore::SVGPathSegListPropertyTearOff::create):
(WebCore::SVGPathSegListPropertyTearOff::removeItemFromList):
(SVGPathSegListPropertyTearOff):
(WebCore::SVGPathSegListPropertyTearOff::initialize):
(WebCore::SVGPathSegListPropertyTearOff::insertItemBefore):
(WebCore::SVGPathSegListPropertyTearOff::replaceItem):
(WebCore::SVGPathSegListPropertyTearOff::appendItem):
(WebCore::SVGPathSegListPropertyTearOff::SVGPathSegListPropertyTearOff):
(WebCore::SVGPathSegListPropertyTearOff::commitChange):
* svg/properties/SVGPropertyInfo.h:
* svg/properties/SVGStaticListPropertyTearOff.h:
(SVGStaticListPropertyTearOff):
(WebCore::SVGStaticListPropertyTearOff::clear):
(WebCore::SVGStaticListPropertyTearOff::initialize):
(WebCore::SVGStaticListPropertyTearOff::getItem):
(WebCore::SVGStaticListPropertyTearOff::insertItemBefore):
(WebCore::SVGStaticListPropertyTearOff::replaceItem):
(WebCore::SVGStaticListPropertyTearOff::removeItem):
(WebCore::SVGStaticListPropertyTearOff::appendItem):
(WebCore::SVGStaticListPropertyTearOff::SVGStaticListPropertyTearOff):
(WebCore::SVGStaticListPropertyTearOff::commitChange):
* svg/properties/SVGTransformListPropertyTearOff.h:
(WebCore::SVGTransformListPropertyTearOff::create):
(WebCore::SVGTransformListPropertyTearOff::createSVGTransformFromMatrix):
(WebCore::SVGTransformListPropertyTearOff::consolidate):
(WebCore::SVGTransformListPropertyTearOff::SVGTransformListPropertyTearOff):
LayoutTests:
Update test expectations after turning on animVal support for SVGLengthList.
* svg/animations/script-tests/svglengthlist-animation-1.js:
(sample1):
(sample2):
(sample3):
* svg/animations/script-tests/svglengthlist-animation-2.js:
(sample1):
(sample2):
(sample3):
* svg/animations/script-tests/svglengthlist-animation-3.js:
(sample1):
(sample2):
(sample3):
* svg/animations/script-tests/svglengthlist-animation-4.js:
(sample1):
(sample2):
(sample3):
* svg/animations/script-tests/svglengthlist-animation-5.js:
(sample1):
(sample2):
(sample3):
* svg/animations/svglengthlist-animation-1-expected.txt:
* svg/animations/svglengthlist-animation-2-expected.txt:
* svg/animations/svglengthlist-animation-3-expected.txt:
* svg/animations/svglengthlist-animation-4-expected.txt:
* svg/animations/svglengthlist-animation-5-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110835
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carlosgc@webkit.org [Thu, 15 Mar 2012 09:08:57 +0000 (09:08 +0000)]
[WK2] WebPageProxy::activeURL should return unreachableURL() when it's not empty
https://bugs.webkit.org/show_bug.cgi?id=75465
Reviewed by Philippe Normand.
* UIProcess/API/gtk/tests/WebViewTest.cpp:
(WebViewTest::replaceContent): Return the main frame
unreachableURL if it's not empty.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::activeURL):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110834
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alexis.menard@openbossa.org [Thu, 15 Mar 2012 08:57:19 +0000 (08:57 +0000)]
Add a new perf test to benchmark setting and reading CSS properties from JS.
https://bugs.webkit.org/show_bug.cgi?id=81155
Reviewed by Ryosuke Niwa.
This benchmark read and set CSS properties from JS. It contains a list
of common CSS properties.
* CSS/CSSPropertySetterGetter.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110833
268f45cc-cd09-0410-ab3c-
d52691b4dbfc