platform/upstream/libSkiaSharp.git
10 years agoRemove ~GrIORef since last remaining virtual and now all inline
bsalomon [Wed, 8 Oct 2014 18:42:10 +0000 (11:42 -0700)]
Remove ~GrIORef since last remaining virtual and now all inline

TBR=reed@google.com
NOTRY=true

Review URL: https://codereview.chromium.org/638003003

10 years agoRevert of Use presence of a content key as non-scratch indicator (patchset #5 id...
bsalomon [Wed, 8 Oct 2014 18:21:33 +0000 (11:21 -0700)]
Revert of Use presence of a content key as non-scratch indicator (patchset #5 id:80001 of https://codereview.chromium.org/639873002/)

Reason for revert:
breaking nanobench on ubuntu

Original issue's description:
> Use presence of a content key as non-scratch indicator
>
> BUG=skia:2889
>
> Committed: https://skia.googlesource.com/skia/+/9eefe0851eeaa8ded05b4774ebcb38ed201d5dbf

TBR=robertphillips@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2889

Review URL: https://codereview.chromium.org/642493003

10 years agouse SkDocument to capture pdfs from SampleApp 'e'
reed [Wed, 8 Oct 2014 18:10:51 +0000 (11:10 -0700)]
use SkDocument to capture pdfs from SampleApp 'e'

BUG=skia:
TBR=
NOTRY=True

Review URL: https://codereview.chromium.org/634293004

10 years agoUse presence of a content key as non-scratch indicator
bsalomon [Wed, 8 Oct 2014 17:48:15 +0000 (10:48 -0700)]
Use presence of a content key as non-scratch indicator

BUG=skia:2889

Review URL: https://codereview.chromium.org/639873002

10 years agoAdd SK_API to GrGpuResource
bsalomon [Wed, 8 Oct 2014 17:24:07 +0000 (10:24 -0700)]
Add SK_API to GrGpuResource
TBR=reed@google.com

Review URL: https://codereview.chromium.org/638963003

10 years agoRebase Nexus 10 gm failure
egdaniel [Wed, 8 Oct 2014 16:38:30 +0000 (09:38 -0700)]
Rebase Nexus 10 gm failure

TBR=robertphillips@google.com

BUG=skia:

Review URL: https://codereview.chromium.org/638043002

10 years agopre-build the resources library for the fiddle jail
Greg Humphreys [Wed, 8 Oct 2014 16:36:42 +0000 (12:36 -0400)]
pre-build the resources library for the fiddle jail

BUG=skia:
TBR=jcgregorio

Review URL: https://codereview.chromium.org/637353003

10 years agorepair the webtry setup process
Greg Humphreys [Wed, 8 Oct 2014 16:33:31 +0000 (12:33 -0400)]
repair the webtry setup process

The previous version of the script didn't properly update the code for the webtry
user, so only changes to skia would really be pulled, not changes to the actual
webtry server itself.

This version of the setup script is 100% automated and brings everything up to date.

It's also a little more verbose about what it's doing, so it's easier to debug.

BUG=skia:
R=tfarina@chromium.org
TBR=jcgregorio, mtklein, tfarina

Review URL: https://codereview.chromium.org/636173003

10 years agoallow fiddles to use the futex system call; fixes fonts finally
Greg Humphreys [Wed, 8 Oct 2014 16:21:41 +0000 (12:21 -0400)]
allow fiddles to use the futex system call; fixes fonts finally

BUG=skia:

Review URL: https://codereview.chromium.org/639013002

10 years agoRearrange code in TextContexts to be more consistent and match style guide.
jvanverth [Wed, 8 Oct 2014 16:07:27 +0000 (09:07 -0700)]
Rearrange code in TextContexts to be more consistent and match style guide.

Review URL: https://codereview.chromium.org/641613003

10 years agoIn the generated fiddle, set the portable fonts flag first.
Greg Humphreys [Wed, 8 Oct 2014 16:04:20 +0000 (12:04 -0400)]
In the generated fiddle, set the portable fonts flag first.

BUG=skia:
TBR=jcgregorio

Review URL: https://codereview.chromium.org/635373002

10 years agoGrResourceCache2 manages scratch texture.
bsalomon [Wed, 8 Oct 2014 15:40:09 +0000 (08:40 -0700)]
GrResourceCache2 manages scratch texture.

BUG=skia:2889

Review URL: https://codereview.chromium.org/608883003

10 years agoMake GM default to reseting gpu contexts on android.
bsalomon [Wed, 8 Oct 2014 15:17:11 +0000 (08:17 -0700)]
Make GM default to reseting gpu contexts on android.

TBR=mtklein@google.com

Committed: https://skia.googlesource.com/skia/+/8dd35ce178e4319685a870faf544a0b1d7aef5bb

Review URL: https://codereview.chromium.org/635293003

10 years agopreliminary support for fiddle font use
Greg Humphreys [Wed, 8 Oct 2014 15:09:21 +0000 (11:09 -0400)]
preliminary support for fiddle font use

BUG=skia:2998
TBR=jcgregorio, tfarina

Review URL: https://codereview.chromium.org/639833003

10 years agoFix conditional check when copying coverage stages in ODS
egdaniel [Wed, 8 Oct 2014 14:39:19 +0000 (07:39 -0700)]
Fix conditional check when copying coverage stages in ODS

BUG=skia:

Review URL: https://codereview.chromium.org/639773004

10 years agofix android framework build errors
djsollen [Wed, 8 Oct 2014 14:12:11 +0000 (07:12 -0700)]
fix android framework build errors

Review URL: https://codereview.chromium.org/637953002

10 years agoDelay copying effects from DS or ODS till end of creating ODS
egdaniel [Wed, 8 Oct 2014 13:49:10 +0000 (06:49 -0700)]
Delay copying effects from DS or ODS till end of creating ODS

Also delay the removal of fixed function VA's until so we only have to do a single removal step

BUG=skia:

Review URL: https://codereview.chromium.org/634073002

10 years agoremove dead code from SK_SUPPORT_LEGACY_IMAGECACHE_NAME
reed [Wed, 8 Oct 2014 13:23:29 +0000 (06:23 -0700)]
remove dead code from SK_SUPPORT_LEGACY_IMAGECACHE_NAME

TBR=

Review URL: https://codereview.chromium.org/638903002

10 years agoImplement C path functions
robertphillips [Wed, 8 Oct 2014 13:04:35 +0000 (06:04 -0700)]
Implement C path functions

Mainly just to familiarize myself with this code.

Review URL: https://codereview.chromium.org/633183002

10 years agoRevert of Make GM default to reseting gpu contexts on android. (patchset #1 id:1...
bsalomon [Wed, 8 Oct 2014 12:41:24 +0000 (05:41 -0700)]
Revert of Make GM default to reseting gpu contexts on android. (patchset #1 id:1 of https://codereview.chromium.org/635293003/)

Reason for revert:
Crashing on Galaxy Nexus (probably tickled an existing skia or driver bug)

Original issue's description:
> Make GM default to reseting gpu contexts on android.
>
> TBR=mtklein@google.com
>
> Committed: https://skia.googlesource.com/skia/+/8dd35ce178e4319685a870faf544a0b1d7aef5bb

TBR=mtklein@google.com
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/639773003

10 years agoAdd SkCachedData and use it for SkMipMap
reed [Wed, 8 Oct 2014 12:17:12 +0000 (05:17 -0700)]
Add SkCachedData and use it for SkMipMap

This reverts commit 37c5a815d8ea33247968212ef4cc83394ceee1bc.

TBR=mtklein

Review URL: https://codereview.chromium.org/635333002

10 years agoExpose layer hoisting API in GrContext
robertphillips [Wed, 8 Oct 2014 12:17:02 +0000 (05:17 -0700)]
Expose layer hoisting API in GrContext

This CL exposes the layer hoisting API in GrContext for use in SkMultiPictureDraw::draw. It basically mirrors what SkGpuDevice::EXPERIMENTAL_drawPicture has been doing.

Review URL: https://codereview.chromium.org/533673002

10 years agoRevert of Make the Sk GL context class an abstract base class (patchset #4 id:60001...
bsalomon [Wed, 8 Oct 2014 11:45:09 +0000 (04:45 -0700)]
Revert of Make the Sk GL context class an abstract base class (patchset #4 id:60001 of https://codereview.chromium.org/630843002/)

Reason for revert:
nanobech failing on Android

Original issue's description:
> Make the Sk GL context class an abstract base class
>
> Make the Sk GL context class, SkGLNativeContext, an abstract base class. Before,
> it depended on ifdefs to implement the platform dependent polymorphism.  Move
> the logic to subclasses of the various platform implementations.
>
> This a step to enable Skia embedders to compile dm and bench_pictures. The
> concrete goal is to support running these test apps with Chromium command buffer.
>
> With this change, Chromium can implement its own version of SkGLNativeContext
> that uses command buffer, and host the implementation in its own repository.
>
> Implements the above by renaming the SkGLContextHelper to SkGLContext and
> removing the unneeded SkGLNativeContext. Also removes
> SkGLNativeContext::AutoRestoreContext functionality, it appeared to be unused:
> no use in Skia code, and no tests.
>
> BUG=skia:2992
>
> Committed: https://skia.googlesource.com/skia/+/a90ed4e83897b45d6331ee4c54e1edd4054de9a8

TBR=kkinnunen@nvidia.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2992

Review URL: https://codereview.chromium.org/639793002

10 years agoRevert of speculative fix for ios (patchset #1 id:1 of https://codereview.chromium...
bsalomon [Wed, 8 Oct 2014 11:43:50 +0000 (04:43 -0700)]
Revert of speculative fix for ios (patchset #1 id:1 of https://codereview.chromium.org/637293003/)

Reason for revert:
Need to revert a90ed4e83897b45d6331ee4c54e1edd4054de9a8

Original issue's description:
> speculative fix for ios
>
> TBR=
>
> Committed: https://skia.googlesource.com/skia/+/96e89d5b45e8e293139ecd95302b5b4f07f8e9dc

TBR=
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/636153002

10 years agospeculative fix for ios
Brian Salomon [Wed, 8 Oct 2014 11:40:25 +0000 (07:40 -0400)]
speculative fix for ios

TBR=

Review URL: https://codereview.chromium.org/637293003

10 years agoMake GM default to reseting gpu contexts on android.
bsalomon [Wed, 8 Oct 2014 11:20:56 +0000 (04:20 -0700)]
Make GM default to reseting gpu contexts on android.

TBR=mtklein@google.com

Review URL: https://codereview.chromium.org/635293003

10 years agoMake the Sk GL context class an abstract base class
kkinnunen [Wed, 8 Oct 2014 11:14:24 +0000 (04:14 -0700)]
Make the Sk GL context class an abstract base class

Make the Sk GL context class, SkGLNativeContext, an abstract base class. Before,
it depended on ifdefs to implement the platform dependent polymorphism.  Move
the logic to subclasses of the various platform implementations.

This a step to enable Skia embedders to compile dm and bench_pictures. The
concrete goal is to support running these test apps with Chromium command buffer.

With this change, Chromium can implement its own version of SkGLNativeContext
that uses command buffer, and host the implementation in its own repository.

Implements the above by renaming the SkGLContextHelper to SkGLContext and
removing the unneeded SkGLNativeContext. Also removes
SkGLNativeContext::AutoRestoreContext functionality, it appeared to be unused:
no use in Skia code, and no tests.

BUG=skia:2992

Review URL: https://codereview.chromium.org/630843002

10 years agoUpdate SKP version to 120
borenet [Wed, 8 Oct 2014 04:20:23 +0000 (21:20 -0700)]
Update SKP version to 120

Automatic commit by the RecreateSKPs bot.

TBR=

Review URL: https://codereview.chromium.org/637173002

10 years agoCleanup of shader building system
joshualitt [Tue, 7 Oct 2014 23:43:25 +0000 (16:43 -0700)]
Cleanup of shader building system

this is a huge refactor and cleanup of the gl shader building system in
Skia.  The entire shader building pipeline is now part of
GrGLProgramCreator, which takes a gp, and some fps, and creates a
program.  I added some subclasses of GrGLProgram to handle the
eccentricities of Nvpr/Nvpres.  Outside of the builders folder
and GrGLPrograms, this change is basically just a rename

solo gp

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/fe1233c3f12f81bb675718516bbb32f72af726ec

Review URL: https://codereview.chromium.org/611653002

10 years agoOnly use msaa target for blur mask when doAA is true
derekf [Tue, 7 Oct 2014 21:44:34 +0000 (14:44 -0700)]
Only use msaa target for blur mask when doAA is true

BUG=skia:2995

Review URL: https://codereview.chromium.org/639523002

10 years agoRevert of Cleanup of shader building system (patchset #25 id:470001 of https://codere...
joshualitt [Tue, 7 Oct 2014 19:42:26 +0000 (12:42 -0700)]
Revert of Cleanup of shader building system (patchset #25 id:470001 of https://codereview.chromium.org/611653002/)

Reason for revert:
Seems to have messed up windows 7 gms

Original issue's description:
> Cleanup of shader building system
>
> this is a huge refactor and cleanup of the gl shader building system in
> Skia.  The entire shader building pipeline is now part of
> GrGLProgramCreator, which takes a gp, and some fps, and creates a
> program.  I added some subclasses of GrGLProgram to handle the
> eccentricities of Nvpr/Nvpres.  Outside of the builders folder
> and GrGLPrograms, this change is basically just a rename
>
>
> solo gp
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/fe1233c3f12f81bb675718516bbb32f72af726ec

TBR=bsalomon@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/635533005

10 years agoCleanup of shader building system
joshualitt [Tue, 7 Oct 2014 19:16:35 +0000 (12:16 -0700)]
Cleanup of shader building system

this is a huge refactor and cleanup of the gl shader building system in
Skia.  The entire shader building pipeline is now part of
GrGLProgramCreator, which takes a gp, and some fps, and creates a
program.  I added some subclasses of GrGLProgram to handle the
eccentricities of Nvpr/Nvpres.  Outside of the builders folder
and GrGLPrograms, this change is basically just a rename

solo gp

BUG=skia:

Review URL: https://codereview.chromium.org/611653002

10 years agoRevert "GrResourceCache2 manages scratch texture."
Brian Salomon [Tue, 7 Oct 2014 19:07:38 +0000 (15:07 -0400)]
Revert "GrResourceCache2 manages scratch texture."

This reverts commit d14e1a27643125bfef37fa0ed314b64c1fae22b7.

10 years agoStay in floats as much as possible in SkTileGrid, particularly in insert.
mtklein [Tue, 7 Oct 2014 18:46:39 +0000 (11:46 -0700)]
Stay in floats as much as possible in SkTileGrid, particularly in insert.

SkTileGrid::insert() is about 15% of recording time before
this CL, which reduces it to ~10%.  Next steps are looking
into some of the TODOs I've left myself, and vectorizing
the math.

Most of the win here comes from converting integer
divisions into float multiplies.

BUG=skia:1021

Review URL: https://codereview.chromium.org/615853007

10 years agoUpdate perspective GMs for dfpaths
jvanverth [Tue, 7 Oct 2014 17:55:42 +0000 (10:55 -0700)]
Update perspective GMs for dfpaths

TBR=egdaniel@google.com

Review URL: https://codereview.chromium.org/632363004

10 years agoAdd baselines for dftext GM.
jvanverth [Tue, 7 Oct 2014 17:23:33 +0000 (10:23 -0700)]
Add baselines for dftext GM.

TBR=robertphillips@google.com

Review URL: https://codereview.chromium.org/638683002

10 years agoAdd -Wno-invalid-offsetof to Mac and iOS builds too.
mtklein [Tue, 7 Oct 2014 16:54:18 +0000 (09:54 -0700)]
Add -Wno-invalid-offsetof to Mac and iOS builds too.

We use this on Linux already, but for whatever reason wasn't a problem on iOS
until using it in SkPaint.  Mac 10.7 and 10.8 are showing this warning too,
but seems -Werror is not enabled.

CQ_EXTRA_TRYBOTS=tryserver.skia:Build-Mac10.7-Clang-Arm7-Release-iOS-Trybot

BUG=skia:

Review URL: https://codereview.chromium.org/637593002

10 years agoAdd SkPaint::getHash().
mtklein [Tue, 7 Oct 2014 16:26:10 +0000 (09:26 -0700)]
Add SkPaint::getHash().

BUG=skia:

Review URL: https://codereview.chromium.org/637583002

10 years agoRevert of gl programs rewrite (patchset #10 id:180001 of https://codereview.chromium...
joshualitt [Tue, 7 Oct 2014 15:37:36 +0000 (08:37 -0700)]
Revert of gl programs rewrite (patchset #10 id:180001 of https://codereview.chromium.org/628633003/)

Reason for revert:
breaks angle bot

Original issue's description:
> gl programs rewrite
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/07a255310aca9f3e83bf741dc663a58818ad681c

TBR=bsalomon@google.com,egdaniel@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/631183003

10 years agogl programs rewrite
joshualitt [Tue, 7 Oct 2014 15:05:21 +0000 (08:05 -0700)]
gl programs rewrite

BUG=skia:

Review URL: https://codereview.chromium.org/628633003

10 years agoFix for perspective GMs and df paths.
jvanverth [Tue, 7 Oct 2014 15:04:58 +0000 (08:04 -0700)]
Fix for perspective GMs and df paths.

Review URL: https://codereview.chromium.org/636933003

10 years agoFix perspective version of dftext GM
jvanverth [Tue, 7 Oct 2014 14:59:45 +0000 (07:59 -0700)]
Fix perspective version of dftext GM

Review URL: https://codereview.chromium.org/634923002

10 years agoGrResourceCache2 manages scratch texture.
bsalomon [Tue, 7 Oct 2014 14:27:07 +0000 (07:27 -0700)]
GrResourceCache2 manages scratch texture.

BUG=skia:2889

Review URL: https://codereview.chromium.org/608883003

10 years agoMake createOptDrawState return NULL if we would end up not drawing
egdaniel [Tue, 7 Oct 2014 13:45:44 +0000 (06:45 -0700)]
Make createOptDrawState return NULL if we would end up not drawing

BUG=skia:

Review URL: https://codereview.chromium.org/630063002

10 years agoexplicitly delete our c++ window on quit
reed [Tue, 7 Oct 2014 13:42:09 +0000 (06:42 -0700)]
explicitly delete our c++ window on quit

BUG=skia:
TBR=
NOTRY=True

Review URL: https://codereview.chromium.org/633923002

10 years agoRevert of Don't readback and reupload texture-backed bitmaps (patchset #1 id:1 of...
bsalomon [Tue, 7 Oct 2014 13:20:25 +0000 (06:20 -0700)]
Revert of Don't readback and reupload texture-backed bitmaps (patchset #1 id:1 of https://codereview.chromium.org/635573004/)

Reason for revert:
This fails on some Android devices, missing part of tileimagefilter GM which were previously triggering the readback/upload code path.

Original issue's description:
> Don't readback and reupload texture-backed bitmaps
>
> Committed: https://skia.googlesource.com/skia/+/b9ab5631703c258f1aae7a3ca1bb4b6596b5b42c

TBR=robertphillips@google.com
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/632293002

10 years agoAdded more msaa blurring rebaselines & a suppression
robertphillips [Tue, 7 Oct 2014 12:56:24 +0000 (05:56 -0700)]
Added more msaa blurring rebaselines & a suppression

These are rebaselines for: Create MSAA render target for blur mask texture - https://codereview.chromium.org/616923004

BUG=skia:2995
TBR=bsalomon@google.com
NOTRY=true

Review URL: https://codereview.chromium.org/628813003

10 years agoGrContext::copyTexture->GrContext::copySurface.
bsalomon [Tue, 7 Oct 2014 12:56:02 +0000 (05:56 -0700)]
GrContext::copyTexture->GrContext::copySurface.

Add a flush writes pixel ops flag.

Add an explicit flush writes for GrSurface.

BUG=skia:2977

Committed: https://skia.googlesource.com/skia/+/cf99b00980b6c9c557e71abf1a7c9f9b21217262

Review URL: https://codereview.chromium.org/622663002

10 years agoDon't readback and reupload texture-backed bitmaps
bsalomon [Tue, 7 Oct 2014 12:19:24 +0000 (05:19 -0700)]
Don't readback and reupload texture-backed bitmaps

Review URL: https://codereview.chromium.org/635573004

10 years agoRebaseline multipicturedraw_biglayer_*
robertphillips [Tue, 7 Oct 2014 12:08:12 +0000 (05:08 -0700)]
Rebaseline multipicturedraw_biglayer_*

TBR=reed@google.com
NOTRY=true

Review URL: https://codereview.chromium.org/635813003

10 years agoRemove suppressions in ignored-tests.txt
robertphillips [Tue, 7 Oct 2014 11:52:16 +0000 (04:52 -0700)]
Remove suppressions in ignored-tests.txt

This should be safe after: Update suppressed baseline images - https://codereview.chromium.org/605973003/

TBR=reed@google.com
NOTRY=true

Review URL: https://codereview.chromium.org/628013003

10 years agoextra call to flush until brian can figure it out
reed [Tue, 7 Oct 2014 11:04:46 +0000 (04:04 -0700)]
extra call to flush until brian can figure it out

BUG=skia:
TBR=bsalomon@google.com

Review URL: https://codereview.chromium.org/633643004

10 years agoUpdate SKP version to 119
borenet [Tue, 7 Oct 2014 11:04:36 +0000 (04:04 -0700)]
Update SKP version to 119

Automatic commit by the RecreateSKPs bot.

TBR=

Review URL: https://codereview.chromium.org/635723002

10 years agooverride applicationShouldTerminate so we can cleanup when we quit
reed [Tue, 7 Oct 2014 10:59:34 +0000 (03:59 -0700)]
override applicationShouldTerminate so we can cleanup when we quit

BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/636723002

10 years agoWhitespace change to test CQ
rmistry [Tue, 7 Oct 2014 10:59:27 +0000 (03:59 -0700)]
Whitespace change to test CQ

NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/630093003

10 years agoRebaseline after msaa blur change
bsalomon [Mon, 6 Oct 2014 20:29:22 +0000 (13:29 -0700)]
Rebaseline after msaa blur change

TBR=robertphillips@google.com
NOTRY=true

Review URL: https://codereview.chromium.org/631993002

10 years agoUpdate suppressed baseline images
robertphillips [Mon, 6 Oct 2014 19:54:15 +0000 (12:54 -0700)]
Update suppressed baseline images

This updates the non-multipicturedraw GM images suppressed in:
Don't turn on dither for saveLayers which have no paint - https://codereview.chromium.org/619363002/

TBR=reed@google.com
NOTRY=true

Review URL: https://codereview.chromium.org/605973003

10 years agoReduce sizes in dftext GM on Android to match desktop better.
jvanverth [Mon, 6 Oct 2014 19:50:54 +0000 (12:50 -0700)]
Reduce sizes in dftext GM on Android to match desktop better.

Review URL: https://codereview.chromium.org/630103003

10 years agofix missing webtry output capture display
Greg Humphreys [Mon, 6 Oct 2014 19:40:06 +0000 (15:40 -0400)]
fix missing webtry output capture display

BUG=skia:

Review URL: https://codereview.chromium.org/628353002

10 years agorework webtry css with compass and bootstrap
Greg Humphreys [Mon, 6 Oct 2014 19:34:28 +0000 (15:34 -0400)]
rework webtry css with compass and bootstrap

BUG=skia:

Review URL: https://codereview.chromium.org/623173004

10 years agoadd surfaceprops to SkWindow, and 'D' to toggle distancefieldfonts
reed [Mon, 6 Oct 2014 19:29:56 +0000 (12:29 -0700)]
add surfaceprops to SkWindow, and 'D' to toggle distancefieldfonts

BUG=skia:

Review URL: https://codereview.chromium.org/631943002

10 years agoAdd suppression for multipicturedraw_biglayer GM
robertphillips [Mon, 6 Oct 2014 19:27:53 +0000 (12:27 -0700)]
Add suppression for multipicturedraw_biglayer GM

TBR=reed@google.com
NOTRY=true

Review URL: https://codereview.chromium.org/631973002

10 years agoFix some incorrect assumptions in GrLayerCache.cpp
robertphillips [Mon, 6 Oct 2014 19:19:50 +0000 (12:19 -0700)]
Fix some incorrect assumptions in GrLayerCache.cpp

Review URL: https://codereview.chromium.org/630173002

10 years agoCreate MSAA render target for blur mask texture
derekf [Mon, 6 Oct 2014 19:19:12 +0000 (12:19 -0700)]
Create MSAA render target for blur mask texture

Original Author: Henry Song <henrysong@samsung.com>

Review URL: https://codereview.chromium.org/616923004

10 years agoPlumb OptDrawState down to VertexShaderBuilder
egdaniel [Mon, 6 Oct 2014 19:13:54 +0000 (12:13 -0700)]
Plumb OptDrawState down to VertexShaderBuilder

BUG=skia:

Review URL: https://codereview.chromium.org/628293002

10 years agoFix multipicturedraw_biglayer GM
robertphillips [Mon, 6 Oct 2014 18:50:31 +0000 (11:50 -0700)]
Fix multipicturedraw_biglayer GM

Having a layer is a prerequisite for having it be hoisted.

Review URL: https://codereview.chromium.org/632743002

10 years agoUpdate baseline GM images
robertphillips [Mon, 6 Oct 2014 18:41:04 +0000 (11:41 -0700)]
Update baseline GM images

This updates the multipicturedraw_* GM images for:

Reduce overdraw in MultiPictureDraw Sierpinski GM - https://codereview.chromium.org/582633003/
Don't turn on dither for saveLayers which have no paint - https://codereview.chromium.org/619363002/

TBR=reed@google.com
NOTRY=true

Review URL: https://codereview.chromium.org/632703003

10 years agoRestore a really single-threaded mode to DM.
mtklein [Mon, 6 Oct 2014 18:24:08 +0000 (11:24 -0700)]
Restore a really single-threaded mode to DM.

Used to be:
   0 -> run on main thread plus an autodetected number of extra threads (default)
   N -> run on main thread plus N extra threads

Now it's:
  -1 -> run on main thread plus an autodetected number of extra threads (default)
   0 -> run on main thread
   N -> run on main thread plus N extra threads

BUG=skia:

Review URL: https://codereview.chromium.org/636593002

10 years agoimplement some so we can test it
reed [Mon, 6 Oct 2014 18:00:51 +0000 (11:00 -0700)]
implement some so we can test it

NOTRY=True
TBR=

Review URL: https://codereview.chromium.org/629903004

10 years agoNew baselines
robertphillips [Mon, 6 Oct 2014 17:57:14 +0000 (10:57 -0700)]
New baselines

New baseline images for multipicturedraw_biglayer* GMs added in (Add a MultiPictureDraw GM to exercise layer clipping - https://codereview.chromium.org/617723004/).

NOTRY=true
TBR=reed@google.com

Review URL: https://codereview.chromium.org/629293002

10 years agoUpdate fontcache expectations
jvanverth [Mon, 6 Oct 2014 17:47:58 +0000 (10:47 -0700)]
Update fontcache expectations

TBR=reed@google.com

Review URL: https://codereview.chromium.org/634623002

10 years agoFix usage of SK_BUILD_* defines.
tfarina [Mon, 6 Oct 2014 17:46:50 +0000 (10:46 -0700)]
Fix usage of SK_BUILD_* defines.

Since we just 'define' them, but not attribute anything to them, like
'1' for example, cpp expands it to nothing and that breaks the "#if"
clauses.

To fix that, uses "#if defined(...)" which will correctly check if your
macro name was defined or not.

BUG=skia:2850
TEST=make most
R=robertphillips@google.com

Review URL: https://codereview.chromium.org/628763005

10 years agoa few more tweaks to the webtry setup doc
humper [Mon, 6 Oct 2014 16:56:14 +0000 (09:56 -0700)]
a few more tweaks to the webtry setup doc

BUG=skia:
TBR=tfarina

Review URL: https://codereview.chromium.org/626623002

10 years agoadd environment variable to webtry local run documentation
Greg Humphreys [Mon, 6 Oct 2014 16:33:32 +0000 (12:33 -0400)]
add environment variable to webtry local run documentation

BUG=skia:

Review URL: https://codereview.chromium.org/631693003

10 years agoAutomatically resize the webtry text editor to fit the content
Greg Humphreys [Mon, 6 Oct 2014 16:31:42 +0000 (12:31 -0400)]
Automatically resize the webtry text editor to fit the content

BUG=skia:

Review URL: https://codereview.chromium.org/626033004

10 years agofix webtry local run documentation
Greg Humphreys [Mon, 6 Oct 2014 16:04:40 +0000 (12:04 -0400)]
fix webtry local run documentation

BUG=skia:

Review URL: https://codereview.chromium.org/630093002

10 years agoexperimental c api
reed [Mon, 6 Oct 2014 13:08:16 +0000 (06:08 -0700)]
experimental c api

BUG=skia:

Review URL: https://codereview.chromium.org/624973004

10 years agoAdd GrAASmallPathRenderer.
jvanverth [Mon, 6 Oct 2014 12:59:05 +0000 (05:59 -0700)]
Add GrAASmallPathRenderer.

Uses cached signed distance fields to render scaled and rotated versions
of small paths.

BUG=skia:2935

Review URL: https://codereview.chromium.org/589103004

10 years agoUpdate SKP version to 118
borenet [Mon, 6 Oct 2014 03:37:06 +0000 (20:37 -0700)]
Update SKP version to 118

Automatic commit by the RecreateSKPs bot.

TBR=

Review URL: https://codereview.chromium.org/630733002

10 years agoUpdate SKP version to 117
borenet [Sun, 5 Oct 2014 05:19:07 +0000 (22:19 -0700)]
Update SKP version to 117

Automatic commit by the RecreateSKPs bot.

TBR=

Review URL: https://codereview.chromium.org/632503002

10 years agoUpdate SKP version to 116
borenet [Sat, 4 Oct 2014 04:10:15 +0000 (21:10 -0700)]
Update SKP version to 116

Automatic commit by the RecreateSKPs bot.

TBR=

Review URL: https://codereview.chromium.org/623423002

10 years agoRestart webtry to pick up changes.
tfarina [Sat, 4 Oct 2014 04:05:00 +0000 (21:05 -0700)]
Restart webtry to pick up changes.

Also add webtry.db to gitignore so it does not polute `git status`.

BUG=None
TEST=None
R=humper@google.com

Review URL: https://codereview.chromium.org/626703002

10 years agoRun goimports through 'go' code in bug_chomper.
tfarina [Fri, 3 Oct 2014 21:25:10 +0000 (14:25 -0700)]
Run goimports through 'go' code in bug_chomper.

$ cd ~/golib
$ go get code.google.com/p/go.tools/cmd/goimports
$ cd ~/skia/tools/bug_chomper/
$ ~/golib/bin/goimports -w src/

BUG=None
TEST=None
R=borenet@google.com

Review URL: https://codereview.chromium.org/624813002

10 years agoRemove globals from tests/CanvasTest.cpp
piotaixr [Fri, 3 Oct 2014 20:26:55 +0000 (13:26 -0700)]
Remove globals from tests/CanvasTest.cpp

BUG=skia:

Review URL: https://codereview.chromium.org/617093004

10 years agoSpeculative revert to diagnose crash in chrome. Revert "Add SkCachedData and use...
reed [Fri, 3 Oct 2014 20:23:30 +0000 (13:23 -0700)]
Speculative revert to diagnose crash in chrome. Revert "Add SkCachedData and use it for SkMipMap"

This reverts commit 92561a0b99ad6c08ab7a11dd1872f028199392e9.

crasher in question:
https://code.google.com/p/chromium/issues/detail?id=420178

Review URL: https://codereview.chromium.org/617613003

10 years agoremove unused TextBufferDirection enum
reed [Fri, 3 Oct 2014 19:44:37 +0000 (12:44 -0700)]
remove unused TextBufferDirection enum

BUG=skia:

Review URL: https://codereview.chromium.org/621403002

10 years agoFix int16_t for glyphs, const glyphs, and clarify glyph loop.
bungeman [Fri, 3 Oct 2014 14:55:58 +0000 (07:55 -0700)]
Fix int16_t for glyphs, const glyphs, and clarify glyph loop.

Several places in the PDF code are using int16_t for glyphs. With
newer NotoSans fonts, all possible glyph ids are being used, so this
can lead to problems.

The PDF glyphs from text code returns the text for the glyphs if the
encoding is for glyphs. However, it returns this using an unsafe const
cast which is hiding possible bugs and preventing correct use of const
in other places.

The way the glyph loop in SkPDFDevice::drawPosText is written uses a
'--i' in the loop, which makes it appear this can loop forever. I don't
believe it can, but it is an unecessary code folding. We should also at
least assert the forward progress correctness here.

Review URL: https://codereview.chromium.org/626613002

10 years agoReduce overdraw in MultiPictureDraw Sierpinski GM
robertphillips [Fri, 3 Oct 2014 14:29:20 +0000 (07:29 -0700)]
Reduce overdraw in MultiPictureDraw Sierpinski GM

As written, all the layers in the MPD Sierpinski GM are full screen. This CL bounds each layer to reduce overdraw.

This CL will cause differences in:

multipicturedraw_sierpinski_simple
multipicturedraw_sierpinski_tiled

but they are/will be suppressed in: (Don't turn on dither for saveLayers which have no paint - https://codereview.chromium.org/619363002/)

Review URL: https://codereview.chromium.org/582633003

10 years agoDon't turn on dither for saveLayers which have no paint
robertphillips [Fri, 3 Oct 2014 13:53:03 +0000 (06:53 -0700)]
Don't turn on dither for saveLayers which have no paint

Only the gpu, 565 and msaa configs of GMs in ignored-tests.txt need rebaselining.

NOTRY=true

Review URL: https://codereview.chromium.org/619363002

10 years agoAdd isSingleComponent bool to getConstantColorComponent
egdaniel [Fri, 3 Oct 2014 13:24:12 +0000 (06:24 -0700)]
Add isSingleComponent bool to getConstantColorComponent

Initial step to allowing effects to use/output 1 or 4 color/coverage components. This cl doesn't change any current logic and all effects still assume they are working with 4 components.

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/3b8af078281a5a20f951b9fd84f38d92b8f6217b

Review URL: https://codereview.chromium.org/608253002

10 years agoabort op early if path isn't parseable
caryclark [Fri, 3 Oct 2014 12:36:27 +0000 (05:36 -0700)]
abort op early if path isn't parseable

TBR=
BUG=419649

Review URL: https://codereview.chromium.org/623943002

10 years agoFix ref cnt'ing issue in GrProgramElement.
bsalomon [Fri, 3 Oct 2014 12:31:41 +0000 (05:31 -0700)]
Fix ref cnt'ing issue in GrProgramElement.

Drop ref on GrGpuResources when GrProgramElement loses its last ref and already has a pending execution.

BUG=skia:2889

Review URL: https://codereview.chromium.org/612293003

10 years agoUpdate SKP version to 115
borenet [Fri, 3 Oct 2014 04:25:20 +0000 (21:25 -0700)]
Update SKP version to 115

Automatic commit by the RecreateSKPs bot.

TBR=

Review URL: https://codereview.chromium.org/623023002

10 years agomake SkMatrix::dump always available
reed [Fri, 3 Oct 2014 00:52:03 +0000 (17:52 -0700)]
make SkMatrix::dump always available

BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/624783002

10 years agoAdd SkCachedData and use it for SkMipMap
reed [Thu, 2 Oct 2014 20:47:08 +0000 (13:47 -0700)]
Add SkCachedData and use it for SkMipMap

Review URL: https://codereview.chromium.org/592843003

10 years agoHandle getMemoryBase returning NULL in WriteTask.
bungeman [Thu, 2 Oct 2014 20:39:00 +0000 (13:39 -0700)]
Handle getMemoryBase returning NULL in WriteTask.

DM::WriteTask::fData was changed from a data to a stream in
"SkData to SkStreamAsset to avoid unneeded copying"
https://skia.googlesource.com/skia/+/a4c6094177ebde18c706cbcfbd2013d0a088e0ee
However, DM::WriteTask::draw was not updated to handle this,
resulting in segfaults when trying to write out PDF files.

Review URL: https://codereview.chromium.org/627473002

10 years agoSave/Restore around bench runs.
mtklein [Thu, 2 Oct 2014 20:03:58 +0000 (13:03 -0700)]
Save/Restore around bench runs.

BUG=skia:

Review URL: https://codereview.chromium.org/619353002

10 years agoUse +- 2B for unbounded draw ops.
mtklein [Thu, 2 Oct 2014 20:03:53 +0000 (13:03 -0700)]
Use +- 2B for unbounded draw ops.

This lets us skip a check inside SkTileGrid::insert().

BUG=skia:

Review URL: https://codereview.chromium.org/620093006

10 years agocheck for newSurface failure
reed [Thu, 2 Oct 2014 19:58:48 +0000 (12:58 -0700)]
check for newSurface failure

BUG=skia:

Review URL: https://codereview.chromium.org/622063003

10 years agospecialize setConcat for scale+translate
reed [Thu, 2 Oct 2014 19:58:43 +0000 (12:58 -0700)]
specialize setConcat for scale+translate

This reverts commit 2a382f519999109b2e3445e73ddb4f0eae926b51.

BUG=skia:

Review URL: https://codereview.chromium.org/626583002