platform/upstream/dotnet/runtime.git
2 years agoRPM package needs to create host symlink (#62925)
Nikola Milosavljevic [Fri, 17 Dec 2021 17:04:26 +0000 (09:04 -0800)]
RPM package needs to create host symlink (#62925)

2 years agoFix createdump failure on MacOS Monterey version 12.0.1. (#62548)
Mike McLaughlin [Fri, 17 Dec 2021 01:39:42 +0000 (17:39 -0800)]
Fix createdump failure on MacOS Monterey version 12.0.1. (#62548)

2 years ago[release/6.0] Fixing regression for AuthType.Anonymous which leads to a NullReferenc...
github-actions[bot] [Thu, 16 Dec 2021 20:56:06 +0000 (12:56 -0800)]
[release/6.0] Fixing regression for AuthType.Anonymous  which leads to a NullReferenceException be thrown. (#62824)

* Fixing regression for AuthType.Anonymous which leads to a NullReferenceException be thrown.

* Adding a unitTest to protect against a regression

* Ensure System.DirectoryServices.Protocols package gets built.

Co-authored-by: Jose Perez Rodriguez <joperezr@microsoft.com>
2 years agoFix Microsoft.VisualBasic.Core file version (#62848) (#62908)
Santiago Fernandez Madero [Thu, 16 Dec 2021 19:00:11 +0000 (13:00 -0600)]
Fix Microsoft.VisualBasic.Core file version (#62848) (#62908)

2 years agoInclude Microsoft.NETCore.App.Ref pack as part of 6.0.2 release (#62859)
Santiago Fernandez Madero [Thu, 16 Dec 2021 17:02:46 +0000 (11:02 -0600)]
Include Microsoft.NETCore.App.Ref pack as part of 6.0.2 release (#62859)

* Include Microsoft.NETCore.App.Ref pack as part of 6.0.2 release

* Update eng/Versions.props

2 years agoUpdate dependencies from https://github.com/dotnet/arcade build 20211209.4 (#62799)
dotnet-maestro[bot] [Thu, 16 Dec 2021 16:52:26 +0000 (10:52 -0600)]
Update dependencies from https://github.com/dotnet/arcade build 20211209.4 (#62799)

Microsoft.DotNet.XUnitExtensions , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.ApiCompat , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.GenFacades , Microsoft.DotNet.GenAPI , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SharedFramework.Sdk
 From Version 6.0.0-beta.21560.2 -> To Version 6.0.0-beta.21609.4

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
2 years ago[release/6.0] Fixes #62167. WriteAsync may truncate data if called after .Advance...
github-actions[bot] [Thu, 16 Dec 2021 16:48:22 +0000 (10:48 -0600)]
[release/6.0] Fixes #62167. WriteAsync may truncate data if called after .Advance(int) (#62348)

* Fixes #62167. WriteAsync was bugged when writing multiple segments if called after an .Advance(int)

* Add packaging changes to IO Pipelines

Co-authored-by: Kuinox <github@kuinox.io>
Co-authored-by: Santiago Fernandez Madero <safern@microsoft.com>
2 years agoProtecting send message to debugger if it's disables (#62210)
github-actions[bot] [Wed, 15 Dec 2021 20:06:52 +0000 (14:06 -0600)]
Protecting send message to debugger if it's disables (#62210)

Co-authored-by: DESKTOP-GEPIA6N\Thays <thaystg@gmail.com>
2 years ago[release/6.0] [HTTP/3] Fixed stress (#60723)
Anton Firszov [Wed, 15 Dec 2021 19:30:45 +0000 (20:30 +0100)]
[release/6.0] [HTTP/3] Fixed stress (#60723)

* Update msquic

* Remove exclusion of 100-continue

2 years ago<EnablePreviewFeatures> for HttpStress (#60682)
github-actions[bot] [Wed, 15 Dec 2021 19:29:54 +0000 (13:29 -0600)]
<EnablePreviewFeatures> for HttpStress (#60682)

Co-authored-by: Anton Firszov <Anton.Firszov@microsoft.com>
2 years agoBackporting part of pr 62278 (#62543)
Thays Grazia [Wed, 15 Dec 2021 19:23:38 +0000 (16:23 -0300)]
Backporting part of pr 62278 (#62543)

2 years agoBackport PR 60983 (#62283)
Thays Grazia [Wed, 15 Dec 2021 19:20:57 +0000 (16:20 -0300)]
Backport PR 60983 (#62283)

2 years ago[release/6.0] Cache LastAccessed during MemoryCache compaction (#62286)
Eric Erhardt [Wed, 15 Dec 2021 19:19:12 +0000 (13:19 -0600)]
[release/6.0] Cache LastAccessed during MemoryCache compaction (#62286)

* Cache LastAccessed during MemoryCache compaction (#61187)

* Cache LastAccessed during MemoryCache compaction

During cache compaction, we are sorting entries based on their LastAccessed time. However, since the cache entries can still be used concurrently on other threads, the LastAccessed time may be updated in the middle of sorting the entries. This leads to exceptions in a background thread, crashing the process.

The fix is to cache the LastAccessed time outside of the entry when we are adding it to the list. This will ensure the time is stable during the compaction process.

Fix #61032

* Update fix for 6.0.x servicing.

1. Remove the dependency on ValueTuple and use a custom struct instead.
2. Add servicing package changes.
3. In the tests, move the DisableParallelization collection declaration in the test project, since it is only in "Common" in main.

2 years agoMerge pull request #62403 from dotnet/backport/pr-62397-to-release/6.0
Santiago Fernandez Madero [Wed, 15 Dec 2021 19:10:30 +0000 (13:10 -0600)]
Merge pull request #62403 from dotnet/backport/pr-62397-to-release/6.0

[release/6.0] Fix re-initialization of hash objects on CNG.

2 years agoMerge pull request #62789 from vseanreesermsft/internal-merge-6.0-2021-12-14-0948
Santiago Fernandez Madero [Wed, 15 Dec 2021 19:09:40 +0000 (13:09 -0600)]
Merge pull request #62789 from vseanreesermsft/internal-merge-6.0-2021-12-14-0948

Merging internal commits for release/6.0

2 years ago[release/6.0] Use 1ES pool instead of deprecated windows image in "Publish to Build...
github-actions[bot] [Wed, 15 Dec 2021 18:46:47 +0000 (12:46 -0600)]
[release/6.0] Use 1ES pool instead of deprecated windows image in "Publish to Build Asset Registry" job (#62839)

* Use 1ES pool instead of deprecated windows image in "Publish to Build Asset Registry" job

* Use servicing 1ES pool

Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
2 years ago[release/6.0] Port #58410: Fix zero initialization use of "initReg" (#62207)
Bruce Forstall [Wed, 15 Dec 2021 18:45:48 +0000 (10:45 -0800)]
[release/6.0] Port #58410: Fix zero initialization use of "initReg" (#62207)

If the only local is an enregistered must-init struct,
we were setting `initReg` to its register (in this case, `xmm0`).
However, `initReg` is expected to be an integer register. In the
test case, with GS cookie stress, the GS cookie code asserted
that `initReg` was an integer register, but it wasn't.

The fix is the change the condition to use the actual register
assigned to the variable (in this case, `xmm0`), not the variable
type (here, `TYP_STRUCT`).

No spmi asm diffs.

Fixes #57911

2 years agoFix method HttpHeadersNonValidated uses to get HeaderDescriptor (#62194)
github-actions[bot] [Wed, 15 Dec 2021 18:45:10 +0000 (12:45 -0600)]
Fix method HttpHeadersNonValidated uses to get HeaderDescriptor (#62194)

We have two non-public methods for getting a HeaderDescriptor from a string name, one static on HeaderDescriptor and one instance on HttpHeaders.  HttpHeadersNonValidated was using the former, but this then doesn't take into account custom logic used by HttpHeaders in other methods, like TryAddWithoutValidation, which means some methods on HttpHeadersNonValidated can't find the corresponding headers.

Co-authored-by: Stephen Toub <stoub@microsoft.com>
2 years ago[release/6.0] Fix calling NLS with Cultures has alternative sort names (#62155)
github-actions[bot] [Wed, 15 Dec 2021 18:41:04 +0000 (12:41 -0600)]
[release/6.0] Fix calling NLS with Cultures has alternative sort names (#62155)

* Fix calling NLS with Cultures has alternative sort names

* Exclude the test for the browser

* Update src/libraries/System.Private.CoreLib/src/System/Globalization/CultureData.Nls.cs

Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
* Fix test typo

Co-authored-by: Tarek Mahmoud Sayed <tarekms@microsoft.com>
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
2 years ago[release/6.0] Allow runtimeconfig StartupHooks and Environment StartupHooks to both...
github-actions[bot] [Wed, 15 Dec 2021 18:40:04 +0000 (12:40 -0600)]
[release/6.0] Allow runtimeconfig StartupHooks and Environment StartupHooks to both be present (#62124)

* Allow configProperties "STARTUP_HOOKS" and env "DOTNET_STARTUP_HOOKS" to both be present

* Fix duplicate_property_error property names to reflect the actual duplicate

* fixup! Allow configProperties "STARTUP_HOOKS" and env "DOTNET_STARTUP_HOOKS" to both be present

* Enforce env startup hook precedence over runtimeconfig startup hooks

Co-authored-by: Tom de Goede <tom.degoede@afas.nl>
2 years ago[release/6.0] [HTTP] Scavenge fix (#62008)
github-actions[bot] [Wed, 15 Dec 2021 18:39:20 +0000 (12:39 -0600)]
[release/6.0] [HTTP] Scavenge fix (#62008)

* Guard pool scavenging callback from parallel execution when it takes longer than the timer interval gets triggered

* Dispose connection from the pool in a serate task to not to block the caller (scavenge timer callback)

* feedback

Co-authored-by: ManickaP <mapichov@microsoft.com>
2 years agoThe DestroyStructure API passes null to the IL marshaller for managed valuetypes...
github-actions[bot] [Wed, 15 Dec 2021 18:38:40 +0000 (12:38 -0600)]
The DestroyStructure API passes null to the IL marshaller for managed valuetypes. This is an issue with field marshallers of nested non-blittable types. (#62002)

Co-authored-by: Aaron Robinson <arobins@microsoft.com>
2 years agoEnvironment variable should override property for gcServer. (#61969)
github-actions[bot] [Wed, 15 Dec 2021 18:35:44 +0000 (12:35 -0600)]
Environment variable should override property for gcServer. (#61969)

Add tests for the scenario.

Co-authored-by: Aaron Robinson <arobins@microsoft.com>
2 years agoCheck for time-sensitive work when worker thread starvation is ongoing (#61931)
Koundinya Veluri [Wed, 15 Dec 2021 18:34:44 +0000 (10:34 -0800)]
Check for time-sensitive work when worker thread starvation is ongoing (#61931)

- Otherwise timer callbacks may not run when worker threads are continually starved
- The change is similar to what was done in CoreCLR's native thread pool
- Fixes https://github.com/dotnet/runtime/issues/61804

2 years ago[release/6.0] disable sending NT Authority in TLS handshake if specific trust was...
github-actions[bot] [Wed, 15 Dec 2021 18:29:01 +0000 (12:29 -0600)]
[release/6.0] disable sending NT Authority in TLS handshake if specific trust was specified (#61713)

* diable sending NT Authority if specific trust was specified

* feedback from review

* add missing file

* Apply suggestions from code review

Co-authored-by: Cory Nelson <phrosty@gmail.com>
* one more style update

Co-authored-by: wfurt <tweinfurt@yahoo.com>
Co-authored-by: Cory Nelson <phrosty@gmail.com>
2 years ago[release/6.0] Disable poisoning for large structs (#61601)
github-actions[bot] [Wed, 15 Dec 2021 18:27:03 +0000 (12:27 -0600)]
[release/6.0] Disable poisoning for large structs (#61601)

* Disable poisoning for large structs

For very large structs (> 64K in size) poisoning could end up generating
instructions requiring larger local var offsets than we can handle. This
hits IMPL_LIMIT that throws InvalidProgramException. Turn off poisoning
for larger structs that require more than 16 movs to also avoid the
significant code bloat by the singular movs.

This is a less risky version of #61521 for backporting to .NET 6.

Fix #60852

* Run jit-format

* Add regression test

* Update src/coreclr/jit/codegencommon.cpp

Co-authored-by: Andy Ayers <andya@microsoft.com>
* Don't check poisoning for large struct in test

Since it's disabled, there is nothing to check.

Co-authored-by: Jakob Botsch Nielsen <jakob.botsch.nielsen@gmail.com>
Co-authored-by: Andy Ayers <andya@microsoft.com>
2 years agoDon't run the JIT formatting job in release/6.0 (#61485)
Bruce Forstall [Wed, 15 Dec 2021 18:24:38 +0000 (10:24 -0800)]
Don't run the JIT formatting job in release/6.0 (#61485)

The format job depends on the `main` branch of dotnet/jitutils (which isn't
properly versioned). Avoid future changes to jitutils causing a break in
servicing by disabling the formatting job.

Note that there is very little benefit to maintaining the formatting
CI requirement in servicing anyway.

2 years agoBackport all CI matrix changes from 7.0 to reelase/6.0 (#62538)
Jan Jahoda [Wed, 15 Dec 2021 17:26:43 +0000 (18:26 +0100)]
Backport all CI matrix changes from 7.0 to reelase/6.0 (#62538)

* Replace Debian stretch with bullseye in Helix queues (#57841)

* add W11 test queue (#58570)

* CI matrix change: drop OSX 10.13 (#59084)

* Drop OSX 10.13 from CI matrix

* Drop OSX 10.14 from PR  CI matrix

* CI matrix change: ubuntu (#58987)

* Remove ubuntu 16.04

* Remove another occurence

* enable client certificate test for QUIC on Linux (#59544)

* CI matrix change: debian+centos+sles (#58988)

* CI matrix change: debian+centos+sles

* Adjust the CI matrix based on latest comments

* Rev Alpine WithNode from 3.9 to 3.13 (#57324)

* Rev Alpine WithNode from 3.9 to 3.13
Also,
* update helix queues from 3.12 to 3.13
* add 3.14 helix queues
* update performance job to install cargo from main branch

* Add Alpine 3.13 in rolling CI

* Add missing closing paren

* CI matrix change: add Windows.Server.Core.20H2 (#59572)

* Add Windows.Server.Core.20H2 to CI matrix

* add windows server 20H2

* Remove 20H2 from PR

* Remove 20H2 from PR run

* CI matrix: add openSUSE 15.2 (#59574)

* CI matrix update: add Ubuntu 21.04 (#59578)

* Rollback changes breaking rolling builds (#60040)

* Revert "CI matrix update: add Ubuntu 21.04 (#59578)"

This reverts commit 127a498bfe6202d097c3f290bce2d771ee2fb859.

* Revert "CI matrix: add openSUSE 15.2 (#59574)"

This reverts commit f9025ae80eba0b2f48ef8b413af3d357ff06987f.

* Revert "CI matrix change: add Windows.Server.Core.20H2 (#59572)"

This reverts commit 5ab435e1fa5e9c88ba7ad9bfb251d508746f337b.

* Add runtime-community.yml pipeline and add s390x job (#60255)

* Revert "Add runtime-community.yml pipeline and add s390x job (#60255)"

This reverts commit 4199aa1e8447408450c02c7ad96cacd4655bf767.

Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
Co-authored-by: Tomas Weinfurt <tweinfurt@yahoo.com>
Co-authored-by: Krzysztof Wicher <kwicher@microsoft.com>
Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
2 years agoMerge commit '3a25a7f1cc446b60678ed25c9d829420d6321eba' into internal-merge-6.0-2021...
Sean Reeser [Tue, 14 Dec 2021 17:48:14 +0000 (09:48 -0800)]
Merge commit '3a25a7f1cc446b60678ed25c9d829420d6321eba' into internal-merge-6.0-2021-12-14-0948

2 years agoClear list of OOB packages built on 6.0 (#62610)
Santiago Fernandez Madero [Mon, 13 Dec 2021 20:10:13 +0000 (14:10 -0600)]
Clear list of OOB packages built on 6.0 (#62610)

* Clear list of OOB packages built on 6.0

* Bump System.Text.Json servicing version to 2

2 years agoUpdate branding to 6.0.2 (#62493)
vseanreesermsft [Wed, 8 Dec 2021 19:07:25 +0000 (11:07 -0800)]
Update branding to 6.0.2 (#62493)

* Update branding to 6.0.2

* Fix installer test when ref packs are not produced on servicing builds

* Fix syntax

Co-authored-by: Santiago Fernandez Madero <safern@microsoft.com>
2 years agoFix whitespace
Kevin Jones [Sat, 4 Dec 2021 16:22:48 +0000 (16:22 +0000)]
Fix whitespace

2 years agoFix re-initialization of hash objects on CNG.
Kevin Jones [Sat, 4 Dec 2021 16:07:20 +0000 (11:07 -0500)]
Fix re-initialization of hash objects on CNG.

In .NET 6, we added "real" support for Initialize on hash objects.
However, the Reset call would create a new hash object without the CNG
"resuable" flag. This led to the HashProvider's "_reusable" field and
the actual reusability of the hash instance to disagree.

2 years agoMerge in 'release/6.0' changes
dotnet-bot [Wed, 17 Nov 2021 17:32:56 +0000 (17:32 +0000)]
Merge in 'release/6.0' changes

2 years ago[release/6.0] Add packaging changes for System.Text.Json (#61703)
Santiago Fernandez Madero [Wed, 17 Nov 2021 17:29:23 +0000 (09:29 -0800)]
[release/6.0] Add packaging changes for System.Text.Json (#61703)

* [release/6.0] Add packaging changes for System.Text.Json

* Fix version calculation when using ServicingVersion for dependencies and current package

* Simplify version calculation for servicing

* Disable assembly validation for DirectoryServices as its version is pinned

2 years agoMerge branch 'internal/release/6.0' of https://dev.azure.com/dnceng/internal/_git...
Matt Mitchell [Wed, 17 Nov 2021 15:28:29 +0000 (07:28 -0800)]
Merge branch 'internal/release/6.0' of https://dev.azure.com/dnceng/internal/_git/dotnet-runtime into internal/release/6.0

2 years agoMerge remote-tracking branch 'upstream/release/6.0' into internal/release/6.0
Matt Mitchell [Wed, 17 Nov 2021 15:28:11 +0000 (07:28 -0800)]
Merge remote-tracking branch 'upstream/release/6.0' into internal/release/6.0

2 years agoMerge in 'release/6.0' changes
dotnet-bot [Wed, 17 Nov 2021 03:24:16 +0000 (03:24 +0000)]
Merge in 'release/6.0' changes

2 years agoMerge in 'release/6.0' changes
dotnet-bot [Wed, 17 Nov 2021 03:22:41 +0000 (03:22 +0000)]
Merge in 'release/6.0' changes

2 years ago[release/6.0] Disable native ports package validation (#61697)
Santiago Fernandez Madero [Wed, 17 Nov 2021 03:20:21 +0000 (19:20 -0800)]
[release/6.0] Disable native ports package validation (#61697)

2 years agoHostFactoryResolver - Increase default timeout and add env var option (#61688)
Maryam Ariyan [Wed, 17 Nov 2021 03:19:18 +0000 (19:19 -0800)]
HostFactoryResolver - Increase default timeout and add env var option (#61688)

* HostFactoryResolver - Increase default timeout and add env var option

* Add GeneratePackageOnBuild on source csproj

* Add ServicingVersion property

* Update src/libraries/Microsoft.Extensions.HostFactoryResolver/tests/TopLevelStatementsTestsTimeout/TopLevelStatementsTestsTimeout.csproj

2 years agoMerge in 'release/6.0' changes
dotnet-bot [Tue, 16 Nov 2021 21:56:52 +0000 (21:56 +0000)]
Merge in 'release/6.0' changes

2 years ago[release/6.0] Disable activation host tests that fail with a 6.0 RC2 or newer SDK...
Santiago Fernandez Madero [Tue, 16 Nov 2021 21:53:32 +0000 (13:53 -0800)]
[release/6.0] Disable activation host tests that fail with a 6.0 RC2 or newer SDK (#61654)

* [release/6.0] Disable activation host tests that fail with a 6.0 RC2 or newer SDK

* Update src/installer/pkg/sfx/Microsoft.NETCore.App/Microsoft.NETCore.App.Ref.sfxproj

Co-authored-by: Anirudh Agnihotry <anirudhagnihotry098@gmail.com>
Co-authored-by: Anirudh Agnihotry <anirudhagnihotry098@gmail.com>
2 years agoMerge in 'release/6.0' changes
dotnet-bot [Tue, 16 Nov 2021 18:13:21 +0000 (18:13 +0000)]
Merge in 'release/6.0' changes

2 years ago[release/6.0] Provide locations for src-gen diagnostic output (#61614)
Layomi Akinrinade [Tue, 16 Nov 2021 18:09:58 +0000 (10:09 -0800)]
[release/6.0] Provide locations for src-gen diagnostic output (#61614)

* Provide locations for src-gen diagnostic output

* Fix tests and address feedback

* Add defensive check for context type location

2 years agoMerge in 'release/6.0' changes
dotnet-bot [Tue, 16 Nov 2021 04:40:31 +0000 (04:40 +0000)]
Merge in 'release/6.0' changes

2 years agoStabilize upgrade codes for host msi (#61606)
Nikola Milosavljevic [Tue, 16 Nov 2021 04:37:46 +0000 (20:37 -0800)]
Stabilize upgrade codes for host msi (#61606)

* Stabilize upgrade codes for host msi

* Override ProviderKey with values from 6.0.0 release

* Fixing typo

* Update version of Microsoft.DotNet.Build.Tasks.Installers package

2 years agoMerge in 'release/6.0' changes
dotnet-bot [Mon, 15 Nov 2021 23:36:54 +0000 (23:36 +0000)]
Merge in 'release/6.0' changes

2 years agoFix race condition with cancellation tokens in Read/Flush operations … (#61500)
David Fowler [Mon, 15 Nov 2021 23:34:08 +0000 (15:34 -0800)]
Fix race condition with cancellation tokens in Read/Flush operations … (#61500)

* Fix race condition with cancellation tokens in Read/Flush operations (#59090)

* Fix race condition with cancellation tokens in Read/Write operations
- There's a tight race where UnsafeRegister can fire inline and then ReadAsync never completes. This is because the cancellation token property has not been assigned yet so the callback noops. This change checks the result of the UnsafeRegister operation to see if ran synchronously and throws if it did. We also move any state transitions to after these checks to make sure the PipeAwaitable state doesn't change before throwing.

* Add a debug assert to make sure there's no state change.

* Add if debug

* More if DEBUG

* add packaging changes

* Run validation checks for just netcoreapp

* use targetIdentifier property to avoid function call and use netframework

* simplify some conditions

Co-authored-by: Anirudh Agnihotry <anirudhagnihotry098@gmail.com>
Co-authored-by: Anirudh Agnihotry <anagniho@microsoft.com>
2 years agoMerge in 'release/6.0' changes
dotnet-bot [Mon, 15 Nov 2021 18:20:17 +0000 (18:20 +0000)]
Merge in 'release/6.0' changes

2 years ago[release/6.0] Update dependencies from dotnet/arcade (#61422)
dotnet-maestro[bot] [Mon, 15 Nov 2021 18:15:23 +0000 (10:15 -0800)]
[release/6.0] Update dependencies from dotnet/arcade (#61422)

* Update dependencies from https://github.com/dotnet/arcade build 20211108.5

Microsoft.DotNet.XUnitExtensions , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.ApiCompat , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.GenFacades , Microsoft.DotNet.GenAPI , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SharedFramework.Sdk
 From Version 6.0.0-beta.21522.3 -> To Version 6.0.0-beta.21558.5

* Update dependencies from https://github.com/dotnet/arcade build 20211110.2

Microsoft.DotNet.XUnitExtensions , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.ApiCompat , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.GenFacades , Microsoft.DotNet.GenAPI , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SharedFramework.Sdk
 From Version 6.0.0-beta.21522.3 -> To Version 6.0.0-beta.21560.2

* pin the fileversions in the platformManifest file for ref pack

* Apply suggestions from code review

Co-authored-by: Santiago Fernandez Madero <safern@microsoft.com>
* Disable SDK Targeting Pack Cache

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Anirudh Agnihotry <anagniho@microsoft.com>
Co-authored-by: Anirudh Agnihotry <anirudhagnihotry098@gmail.com>
Co-authored-by: Santiago Fernandez Madero <safern@microsoft.com>
2 years agoMerge in 'release/6.0' changes
dotnet-bot [Mon, 15 Nov 2021 04:17:15 +0000 (04:17 +0000)]
Merge in 'release/6.0' changes

2 years ago[release/6.0] Fix UnobservedTaskException from SemaphoreSlim.WaitAsync (#61491)
github-actions[bot] [Mon, 15 Nov 2021 04:14:32 +0000 (21:14 -0700)]
[release/6.0] Fix UnobservedTaskException from SemaphoreSlim.WaitAsync (#61491)

* Fix UnobservedTaskException from SemaphoreSlim.WaitAsync

If a SemaphoreSlim.WaitAsync times out, it correctly returns false, but it also results in TaskScheduler.UnobservedTaskException being raised unexpectedly, due to internal use of a faulted task whose exception isn't observed.  This fixes that by marking any such exceptions as having been observed.

* Fix wasm build

Co-authored-by: Stephen Toub <stoub@microsoft.com>
2 years agoMerge in 'release/6.0' changes
dotnet-bot [Fri, 12 Nov 2021 22:29:21 +0000 (22:29 +0000)]
Merge in 'release/6.0' changes

2 years ago[release/6.0] Fix: add missed open curly (#61332)
github-actions[bot] [Fri, 12 Nov 2021 22:25:43 +0000 (15:25 -0700)]
[release/6.0] Fix: add missed open curly (#61332)

* fix: add missed open curly

* feat: add test

Co-authored-by: annchous <annchooousss@gmail.com>
2 years agoMerge in 'release/6.0' changes
dotnet-bot [Fri, 12 Nov 2021 17:48:45 +0000 (17:48 +0000)]
Merge in 'release/6.0' changes

2 years ago[mono][interp] Fix GetType called on ptr constrained to Nullable` (#61020) (#61305)
Vlad Brezae [Fri, 12 Nov 2021 17:45:23 +0000 (19:45 +0200)]
[mono][interp] Fix GetType called on ptr constrained to Nullable` (#61020) (#61305)

* [interp] Fix GetType called on ptr constrained to Nullable`

We were statically optimizing this call to return the actual constrained class type, which is incorrect for nullables, because boxing of a nullable (as part of the constrained call) actually creates an object with the type of the nullable's value (or null if there is no value).

* Add test for GetType call on ptr constrained to nullable

2 years agoMerge in 'release/6.0' changes
dotnet-bot [Fri, 12 Nov 2021 17:01:17 +0000 (17:01 +0000)]
Merge in 'release/6.0' changes

2 years agoSupport unseekable filestream when ReadAllBytes[Async] (#58434) (#61410)
Adam Sitnik [Fri, 12 Nov 2021 16:57:37 +0000 (17:57 +0100)]
Support unseekable filestream when ReadAllBytes[Async] (#58434) (#61410)

Co-authored-by: Adam Sitnik <adam.sitnik@gmail.com>
Co-authored-by: LateApexEarlySpeed <72254037+lateapexearlyspeed@users.noreply.github.com>
2 years agoMerge in 'release/6.0' changes
dotnet-bot [Fri, 12 Nov 2021 14:59:15 +0000 (14:59 +0000)]
Merge in 'release/6.0' changes

2 years ago[wasm] Allow enums in unmanaged callbacks. (#61393)
github-actions[bot] [Fri, 12 Nov 2021 14:55:46 +0000 (06:55 -0800)]
[wasm] Allow enums in unmanaged callbacks. (#61393)

Fixes https://github.com/dotnet/runtime/issues/61144.

Co-authored-by: Zoltan Varga <vargaz@gmail.com>
2 years agoMerge in 'release/6.0' changes
dotnet-bot [Thu, 11 Nov 2021 23:39:37 +0000 (23:39 +0000)]
Merge in 'release/6.0' changes

2 years agoPreserve last error in call-counting stubs (#60887)
github-actions[bot] [Thu, 11 Nov 2021 23:36:36 +0000 (15:36 -0800)]
Preserve last error in call-counting stubs (#60887)

Fixes #60819

Co-authored-by: Jan Kotas <jkotas@microsoft.com>
2 years agoMerge in 'release/6.0' changes
dotnet-bot [Thu, 11 Nov 2021 21:49:15 +0000 (21:49 +0000)]
Merge in 'release/6.0' changes

2 years agoMerge in 'release/6.0' changes
dotnet-bot [Thu, 11 Nov 2021 21:45:44 +0000 (21:45 +0000)]
Merge in 'release/6.0' changes

2 years agoAllow nfloat to be in the ObjCRuntime namespace, and make it work for Xamarin.MacCata...
github-actions[bot] [Thu, 11 Nov 2021 21:44:12 +0000 (13:44 -0800)]
Allow nfloat to be in the ObjCRuntime namespace, and make it work for Xamarin.MacCatalyst.dll as well. (#60861)

Ref: https://github.com/xamarin/xamarin-macios/pull/13092
Ref: https://github.com/mono/mono/pull/21261

Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>
2 years agoUpdate the ref pack version to 6.0.0 for apicompat (#61429)
Anirudh Agnihotry [Thu, 11 Nov 2021 21:42:46 +0000 (13:42 -0800)]
Update the ref pack version to 6.0.0 for apicompat (#61429)

* üpdate the apicompat for the ref pack

* update previous netcoreapp

2 years agoMerge in 'release/6.0' changes
dotnet-bot [Thu, 11 Nov 2021 17:27:31 +0000 (17:27 +0000)]
Merge in 'release/6.0' changes

2 years agoThe 6.0 branch is no longer pre-release (#61442)
Omair Majid [Thu, 11 Nov 2021 17:24:23 +0000 (12:24 -0500)]
The 6.0 branch is no longer pre-release (#61442)

This has limited affects, but it should have been set to false since 6.0
is now stable/released.

The one difference it makes is that -Werror is disabled when building
native code.

2 years agoMerge in 'release/6.0' changes
dotnet-bot [Thu, 11 Nov 2021 15:46:44 +0000 (15:46 +0000)]
Merge in 'release/6.0' changes

2 years agoRemove pre-release version iteration (#61438)
Matt Mitchell [Thu, 11 Nov 2021 15:43:24 +0000 (07:43 -0800)]
Remove pre-release version iteration (#61438)

This should always be empty in servicing.

2 years agoMerge in 'release/6.0' changes
dotnet-bot [Wed, 10 Nov 2021 18:44:30 +0000 (18:44 +0000)]
Merge in 'release/6.0' changes

2 years ago[release/6.0.1] add support for macOS 12 (#61028)
Tomas Weinfurt [Wed, 10 Nov 2021 18:39:07 +0000 (10:39 -0800)]
[release/6.0.1] add support for macOS 12 (#61028)

* RID work for macOS 12 (#59066)

* fix rid processing on macOS (#60494)

* fix rid processing on macOS

* Update src/native/corehost/hostmisc/pal.unix.cpp

* Update src/native/corehost/hostmisc/pal.unix.cpp

* remove extra size calculation

* Fix "fix rid processing on macOS" (#60668)

The `else if (major == 12)` is dead code, since the previous if `if (major > 11)` would be true for `major == 12`. Judging by the comment and code, it looks like the intention of this `else if` statement was to match `major == 11`.

* add the packaging for platforms package

Co-authored-by: Austin Wise <AustinWise@gmail.com>
Co-authored-by: Anirudh Agnihotry <anagniho@microsoft.com>
2 years agoMerge in 'release/6.0' changes
dotnet-bot [Wed, 10 Nov 2021 18:27:46 +0000 (18:27 +0000)]
Merge in 'release/6.0' changes

2 years agoMerge in 'release/6.0' changes
dotnet-bot [Wed, 10 Nov 2021 18:23:39 +0000 (18:23 +0000)]
Merge in 'release/6.0' changes

2 years ago[release/6.0.x] Add System.Diagnostics.StackFrame.GetMethodInfoFromNativeIP API for...
Mike McLaughlin [Wed, 10 Nov 2021 18:21:27 +0000 (10:21 -0800)]
[release/6.0.x] Add System.Diagnostics.StackFrame.GetMethodInfoFromNativeIP API for VS4Mac (#61298)

* Add System.Diagnostics.StackFrame.GetMethodInfoFromNativeIP API for VS4Mac

VS4Mac needs a way to symbolize managed IPs when rethrowing a native NSException from Objective C++. This is a short term API needed for the next 6.0 service release discoverable only through reflection.

Issue: #61186

* Code review feedback

* Remove unneccesary blank line

2 years ago[release/6.0][wasm] Change dotnet.wasm link optimization (#60632)
Radek Doulik [Wed, 10 Nov 2021 18:19:35 +0000 (19:19 +0100)]
[release/6.0][wasm] Change dotnet.wasm link optimization (#60632)

* [wasm] Change dotnet.wasm link optimization

Context: https://github.com/dotnet/runtime/issues/60349

When we switched to Emscripten 2.0.21, we stopped using deprecated
`--llvm-opts 2` option. This caused unwanted performance degradation.
Switching to `-O2` get us similar performance as with `--llvm-opts`.

Blazor wasm test app `Time to first UI` benchmark times:

    branch/commit        link option    time    dotnet.wasm size
    --------------------+------------+--------+-----------------
    release/6.0 92ff02       -Oz       491ms    2,430,639
    release/6.0 92ff02       -O2       457ms    2,474,518
    release/6.0 92ff02       -O3       444ms    2,555,824

* Fix native build too

Co-authored-by: Larry Ewing <lewing@microsoft.com>
2 years agoMerge in 'release/6.0' changes
dotnet-bot [Tue, 9 Nov 2021 20:58:49 +0000 (20:58 +0000)]
Merge in 'release/6.0' changes

2 years agoCredential fixes (#61114) (#61372)
Jan Jahoda [Tue, 9 Nov 2021 20:55:51 +0000 (21:55 +0100)]
Credential fixes (#61114) (#61372)

* fix HttpClientHandlerTest.RemoteServer.cs

* fix HttpClientHandlerTest.Authentication.cs

* fix HttpClientHandlerTest.cs

2 years ago[release/6.0] Fix for InformationalVersion (#61240)
github-actions[bot] [Tue, 9 Nov 2021 20:54:50 +0000 (12:54 -0800)]
[release/6.0] Fix for InformationalVersion (#61240)

* Fix for #60532

In stable package mode we should be setting CoreLib informational
version to the ProductVersion according to the discussion on the
issue thread. I have verified locally that this fixes the processinfo2
test for me that was previously failing in the StabilizePackageVersion
mode. Please let me know how to proceed with the fix, whether you
want me to just merge it into dotnet/runtime main, whether I should
pursue its backport into 6.0 release and / or whether Matt considers
cherry-picking my change to his stabilization PR.

Thanks

Tomas

* Port InformationVersion fix to Mono corelib (#60614)

https://github.com/dotnet/runtime/pull/60572 for Mono's corelib.

Co-authored-by: Tomas Rylek <trylek@microsoft.com>
Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
2 years agoMerge in 'release/6.0' changes
dotnet-bot [Tue, 9 Nov 2021 19:07:27 +0000 (19:07 +0000)]
Merge in 'release/6.0' changes

2 years agoMerge in 'release/6.0' changes
dotnet-bot [Tue, 9 Nov 2021 19:06:13 +0000 (19:06 +0000)]
Merge in 'release/6.0' changes

2 years agoOnly run source-index on main branch. (#61271)
Alex Perovich [Tue, 9 Nov 2021 19:04:05 +0000 (11:04 -0800)]
Only run source-index on main branch. (#61271)

2 years agoFix incorrect CCW decoding in GetObjectForCCW (#61193) (#61341)
Tom McDonald [Tue, 9 Nov 2021 19:02:38 +0000 (11:02 -0800)]
Fix incorrect CCW decoding in GetObjectForCCW (#61193) (#61341)

* Fix incorrect CCW decoding in GetObjectForCCW

* Fix linux/mac build

2 years ago[release/6.0] Don't create a COM weak reference if the object is an aggregated COMWra...
github-actions[bot] [Tue, 9 Nov 2021 19:01:58 +0000 (11:01 -0800)]
[release/6.0] Don't create a COM weak reference if the object is an aggregated COMWrappers RCW. (#61283)

* Don't create a COM weak reference if the object is an aggregated COMWrappers RCW.

* Add test for weak reference + aggregation with native weak reference impl.

* Apply suggestions from code review

Co-authored-by: Aaron Robinson <arobins@microsoft.com>
Co-authored-by: Jeremy Koritzinsky <jekoritz@microsoft.com>
Co-authored-by: Jeremy Koritzinsky <jkoritzinsky@gmail.com>
Co-authored-by: Aaron Robinson <arobins@microsoft.com>
2 years agoMerge in 'release/6.0' changes
dotnet-bot [Tue, 9 Nov 2021 18:28:00 +0000 (18:28 +0000)]
Merge in 'release/6.0' changes

2 years agoDisable a couple of pen tests on Windows (#60746) (#60789)
Santiago Fernandez Madero [Tue, 9 Nov 2021 18:23:43 +0000 (10:23 -0800)]
Disable a couple of pen tests on Windows (#60746) (#60789)

2 years ago[release/6.0] Disable package validation in source-build for reliability (#60881)
Davis Goodin [Tue, 9 Nov 2021 18:23:12 +0000 (12:23 -0600)]
[release/6.0] Disable package validation in source-build for reliability (#60881)

* Disable package validation in source-build for reliability

* Add tracking issue to comment

* Switch from property overwrite to a condition

2 years ago[release/6.0] Revise descriptions of VS workloads, and add missing ones (#60835)
github-actions[bot] [Tue, 9 Nov 2021 18:20:10 +0000 (10:20 -0800)]
[release/6.0] Revise descriptions of VS workloads, and add missing ones (#60835)

* Revise descriptions of VS workloads, and add missing ones

* typo

Co-authored-by: Jo Shields <joshield@microsoft.com>
2 years agoDotNetHost packages are not created during source-build (#60577)
github-actions[bot] [Tue, 9 Nov 2021 18:17:57 +0000 (10:17 -0800)]
DotNetHost packages are not created during source-build (#60577)

The subset `host.pkg` is not producing the DotNetHost* NuGet packages. This is because the "Pack" target is getting invoked on the pkgprojs, but pkgprojs expect the "Build" target to be called. Since the "Pack" target is overriden in the Directory.Build.targets to be empty, no one is calling the "Build" target on the pkgprojs.

In an official build, a later subset `packs.tests` comes through and builds `Microsoft.DotNet.CoreSetup.Packaging.Tests.csproj`, which explicitly calls "Build" on the pkgprojs. So official builds still get these packages produced.

In source-build, we are no longer building the `packs.tests` subset, so the packages are not produced.

Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
2 years ago[mono/win] Increase stack size (reserve) to 8MB (#60561)
github-actions[bot] [Tue, 9 Nov 2021 18:17:29 +0000 (10:17 -0800)]
[mono/win] Increase stack size (reserve) to 8MB (#60561)

Fix https://github.com/dotnet/runtime/issues/57141 in windows build.

Set the stack size (reserve) to 8MB, which is usually a default
on linux. This way we should get similar behavior on windows.

Co-authored-by: Radek Doulik <radekdoulik@gmail.com>
2 years agoFix dump generation issues for VS4Mac (#61063)
Mike McLaughlin [Tue, 9 Nov 2021 18:16:52 +0000 (10:16 -0800)]
Fix dump generation issues for VS4Mac (#61063)

The VS4Mac team found two issues preventing them from successfully diagnosing VS4Mac failures
on .NET:

1) Multiple "crashed" threads in the crash report json (#60932).
2) No flag or way to generate the crash report for hangs via the diagnostic server IPC commands (#60775).

Add new generate core dump IPC command that allows the generate crash report flag to be passed through to createdump for
VS4Mac. VS4Mac needs to distinguish between WriteDump/no signal and unknown signal ExceptionType. Change unknown signal
exception type to 0.

Issue: https://github.com/dotnet/runtime/issues/60775

Fix how the load bias is calculate for shared modules

Local testing with the SOS tests. VS4Mac team testing and verification.

Low risk because it only affects createdump, dump IPC command and the runtime dump generation path.

2 years agoupdate branding to 6.0.1 (#61176)
Anirudh Agnihotry [Fri, 5 Nov 2021 02:39:54 +0000 (19:39 -0700)]
update branding to 6.0.1 (#61176)

2 years agoMerge in 'release/6.0' changes
dotnet-bot [Sat, 23 Oct 2021 18:06:13 +0000 (18:06 +0000)]
Merge in 'release/6.0' changes

2 years agoUpdate dependencies from https://github.com/dotnet/arcade build 20211022.3 (#60783)
dotnet-maestro[bot] [Fri, 22 Oct 2021 20:27:45 +0000 (13:27 -0700)]
Update dependencies from https://github.com/dotnet/arcade build 20211022.3 (#60783)

Microsoft.DotNet.XUnitExtensions , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.ApiCompat , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.GenFacades , Microsoft.DotNet.GenAPI , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SharedFramework.Sdk
 From Version 6.0.0-beta.21519.3 -> To Version 6.0.0-beta.21522.3

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
2 years ago[release/6.0] [wasm][debugger] Fix loading a non wasm page and then returning to...
github-actions[bot] [Fri, 22 Oct 2021 20:21:03 +0000 (13:21 -0700)]
[release/6.0] [wasm][debugger] Fix loading a non wasm page and then returning to a wasm page. (#60777)

* Fix loading a non wasm page and then returning to a wasm page.

* Adding non-wasm-page.html

* fixing other method

* addressing @radical comments

* adding last empty line

Co-authored-by: DESKTOP-GEPIA6N\Thays <thaystg@gmail.com>
2 years ago[release/6.0] Create a parent CMake project for building app bundles on CI (#59154)
github-actions[bot] [Thu, 21 Oct 2021 18:43:50 +0000 (14:43 -0400)]
[release/6.0] Create a parent CMake project for building app bundles on CI (#59154)

Backport of #58965 to release/6.0

This allows us to not run the CMake configure step separately for each libraries test suite which speeds up the build.

Helps with #58549

2 years ago[release/6.0] Update dependencies from dotnet/icu dotnet/emsdk (#60684)
dotnet-maestro[bot] [Thu, 21 Oct 2021 15:07:10 +0000 (08:07 -0700)]
[release/6.0] Update dependencies from dotnet/icu dotnet/emsdk (#60684)

* Update dependencies from https://github.com/dotnet/icu build 20211019.1

Microsoft.NETCore.Runtime.ICU.Transport
 From Version 6.0.0-rtm.21515.1 -> To Version 6.0.0-rtm.21519.1

* Update dependencies from https://github.com/dotnet/emsdk build 20211020.1

Microsoft.NET.Workload.Emscripten.Manifest-6.0.100
 From Version 6.0.0 -> To Version 6.0.0

* Update dependencies from https://github.com/dotnet/emsdk build 20211020.3

Microsoft.NET.Workload.Emscripten.Manifest-6.0.100
 From Version 6.0.0 -> To Version 6.0.0

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
2 years agoMerge in 'release/6.0' changes
dotnet-bot [Wed, 20 Oct 2021 22:39:44 +0000 (22:39 +0000)]
Merge in 'release/6.0' changes

2 years ago[release/6.0] Tweak workload build to use _GenerateMsiVersionString target (#60695)
github-actions[bot] [Wed, 20 Oct 2021 22:36:28 +0000 (15:36 -0700)]
[release/6.0] Tweak workload build to use _GenerateMsiVersionString target (#60695)

* Tweak workload build to use _GenerateMsiVersionString target

Replaces GenerateVersions that wasn't quite accurate enough for what we need

* Pulled in arcade target that will be removed at a later date

* More tweaks

* Forget dependsontargets

Co-authored-by: Steve Pfister <steve.pfister@microsoft.com>