platform/upstream/libSkiaSharp.git
10 years agoMove distance field font code into GrDistanceFieldTextContext.
commit-bot@chromium.org [Thu, 19 Dec 2013 16:12:25 +0000 (16:12 +0000)]
Move distance field font code into GrDistanceFieldTextContext.

This avoids the SkDraw path and renders the distance field glyphs directly from
GrDistanceFieldTextContext. It also disables LCD, subpixel and autohinting, and
removes the supporting code when rendering DF fonts.

R=reed@google.com, bsalomon@google.com, robertphillips@google.com

Author: jvanverth@google.com

Review URL: https://codereview.chromium.org/85653004

git-svn-id: http://skia.googlecode.com/svn/trunk@12770 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoNew baselines for xfermodeimagefilter post-r12652.
senorblanco@chromium.org [Thu, 19 Dec 2013 15:41:12 +0000 (15:41 +0000)]
New baselines for xfermodeimagefilter post-r12652.

TBR=reed@google.com
BUG=

Review URL: https://codereview.chromium.org/118803003

git-svn-id: http://skia.googlecode.com/svn/trunk@12769 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agofix win build
reed@google.com [Thu, 19 Dec 2013 15:00:18 +0000 (15:00 +0000)]
fix win build

git-svn-id: http://skia.googlecode.com/svn/trunk@12768 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoremove unused SkFixed and SkFract functions
reed@google.com [Thu, 19 Dec 2013 14:22:03 +0000 (14:22 +0000)]
remove unused SkFixed and SkFract functions

BUG=
R=caryclark@google.com

Review URL: https://codereview.chromium.org/113873008

git-svn-id: http://skia.googlecode.com/svn/trunk@12767 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoYet another round of valgrind suppressions
robertphillips@google.com [Thu, 19 Dec 2013 13:41:48 +0000 (13:41 +0000)]
Yet another round of valgrind suppressions

https://codereview.chromium.org/116053004/

git-svn-id: http://skia.googlecode.com/svn/trunk@12766 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd cast to fix Win* compile complaint/failure
commit-bot@chromium.org [Thu, 19 Dec 2013 10:39:59 +0000 (10:39 +0000)]
Add cast to fix Win* compile complaint/failure

R=tomhudson@google.com, reed@google.com
TBR=tomhudson@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/100313005

git-svn-id: http://skia.googlecode.com/svn/trunk@12764 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Thu, 19 Dec 2013 07:01:38 +0000 (07:01 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@12763 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRevert r12758 (Updated GLintptr and GLsizeiptr to be the appropriate types on 64...
robertphillips@google.com [Wed, 18 Dec 2013 23:56:59 +0000 (23:56 +0000)]
Revert r12758 (Updated GLintptr and GLsizeiptr to be the appropriate types on 64 bit Windows (Take 2) - https://codereview.chromium.org/118533003) due to Chromium-side compilation issues

git-svn-id: http://skia.googlecode.com/svn/trunk@12762 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoUpdate expectations for r12729
vandebo@chromium.org [Wed, 18 Dec 2013 22:20:16 +0000 (22:20 +0000)]
Update expectations for r12729

"[PDF] Fix clipping in xfermode improvement."

TBR=bungeman@google.com

Review URL: https://codereview.chromium.org/112343007

git-svn-id: http://skia.googlecode.com/svn/trunk@12761 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoGet rid of DEFINE_TESTCLASS() macro.
tfarina@chromium.org [Wed, 18 Dec 2013 22:15:12 +0000 (22:15 +0000)]
Get rid of DEFINE_TESTCLASS() macro.

Remaining tests were rewrite to use DEF_TEST() macro instead. This fixes
the FIXME in TestClassDef.h

BUG=None
TEST=tests
R=mtklein@google.com

Review URL: https://codereview.chromium.org/114563003

git-svn-id: http://skia.googlecode.com/svn/trunk@12760 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRemove SkBitmapAlphaThresholdShader
commit-bot@chromium.org [Wed, 18 Dec 2013 21:58:53 +0000 (21:58 +0000)]
Remove SkBitmapAlphaThresholdShader

R=bsalomon@google.com

Author: zork@chromium.org

Review URL: https://codereview.chromium.org/108653012

git-svn-id: http://skia.googlecode.com/svn/trunk@12759 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoUpdated GLintptr and GLsizeiptr to be the appropriate types on 64 bit Windows (Take 2)
commit-bot@chromium.org [Wed, 18 Dec 2013 21:09:21 +0000 (21:09 +0000)]
Updated GLintptr and GLsizeiptr to be the appropriate types on 64 bit Windows (Take 2)

Requires changes from https://codereview.chromium.org/99053007/ before this can be rolled in Chromium DEPS. If this begins breaking the build due to an early roll, please contact bajones@chromium.org before reverting.

BUG=326382
R=bsalomon@chromium.org
TBR=bsalomon@chromium.org

Author: bajones@chromium.org

Review URL: https://codereview.chromium.org/118533003

git-svn-id: http://skia.googlecode.com/svn/trunk@12758 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAndroid now uses Harfbuzz-NG. No need to keep code specific to the old version of...
commit-bot@chromium.org [Wed, 18 Dec 2013 19:49:27 +0000 (19:49 +0000)]
Android now uses Harfbuzz-NG. No need to keep code specific to the old version of Harfbuzz around!

R=scroggo@google.com, reed@google.com, bungeman@google.com

Author: djsollen@google.com

Review URL: https://codereview.chromium.org/107663012

git-svn-id: http://skia.googlecode.com/svn/trunk@12756 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agofix off-by-one error with rotated HQ scaling
commit-bot@chromium.org [Wed, 18 Dec 2013 19:47:57 +0000 (19:47 +0000)]
fix off-by-one error with rotated HQ scaling

BUG=
R=reed@google.com

Author: humper@google.com

Review URL: https://codereview.chromium.org/118193005

git-svn-id: http://skia.googlecode.com/svn/trunk@12755 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd cast to fix Win* compile complaint/failure
robertphillips@google.com [Wed, 18 Dec 2013 19:00:47 +0000 (19:00 +0000)]
Add cast to fix Win* compile complaint/failure

https://codereview.chromium.org/100313005/

git-svn-id: http://skia.googlecode.com/svn/trunk@12750 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAddress memory leak in SkScaledImageCache
robertphillips@google.com [Wed, 18 Dec 2013 18:48:08 +0000 (18:48 +0000)]
Address memory leak in SkScaledImageCache

https://codereview.chromium.org/107443009/

git-svn-id: http://skia.googlecode.com/svn/trunk@12749 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRevert of https://codereview.chromium.org/93703004/
commit-bot@chromium.org [Wed, 18 Dec 2013 18:33:15 +0000 (18:33 +0000)]
Revert of https://codereview.chromium.org/93703004/
Reason for revert: Test failures

R=scroggo@google.com, djsollen@google.com, reed@google.com, halcanary@google.com
TBR=djsollen@google.com, halcanary@google.com, reed@google.com, scroggo@google.com
NOTREECHECKS=true
NOTRY=true

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/103753007

git-svn-id: http://skia.googlecode.com/svn/trunk@12747 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoExpose more SkPaint fields in Lua API.
commit-bot@chromium.org [Wed, 18 Dec 2013 18:28:07 +0000 (18:28 +0000)]
Expose more SkPaint fields in Lua API.

Adds getters (but not setters) for most SkPaint fields.

R=reed@google.com, robertphillips@google.com, tomhudson@google.com

Author: tomhudson@chromium.org

Review URL: https://codereview.chromium.org/105143009

git-svn-id: http://skia.googlecode.com/svn/trunk@12746 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd Options to SkDecodingImageGenerator, simplify API.
halcanary@google.com [Wed, 18 Dec 2013 17:40:25 +0000 (17:40 +0000)]
Add Options to SkDecodingImageGenerator, simplify API.

Motivation: We want to remove redundant classes from Skia.  To
that end we want to remove SkImageRef and its subclasses and
replace their uses with SkDiscardablePixelRef +
SkDecodingImageGenerator.  Since Android uses SkImageRef, we need
to make sure that SkDecodingImageGenerator allows all of the
settings that Android exposes in BitmapFactory.Options.

To that end, we have created an Options struct for the
SkDecodingImageGenerator which lets the client of the generator set
sample size, dithering, and bitmap config.

We have made the SkDecodingImageGenerator constructor private
and replaced the SkDecodingImageGenerator::Install functions
with a SkDecodingImageGenerator::Create functions (one for
SkData and one for SkStream) which now take a
SkDecodingImageGenerator::Options struct.

Also added a ImageDecoderOptions test which loops through a list
of sets of options and tries them on a set of 5 small encoded
images.

Also updated several users of SkDecodingImageGenerator::Install to
follow new call signature - gm/factory.cpp, LazyDecodeBitmap.cpp,
and PictureTest.cpp, CachedDecodingPixelRefTest.cpp.

We also added a new ImprovedBitmapFactory Test which simulates the
exact function that Android will need to modify to use this,
installPixelRef() in BitmapFactory.

R=reed@google.com, scroggo@google.com

Review URL: https://codereview.chromium.org/93703004

git-svn-id: http://skia.googlecode.com/svn/trunk@12744 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSuppress questionable gpu errors
robertphillips@google.com [Wed, 18 Dec 2013 17:28:55 +0000 (17:28 +0000)]
Suppress questionable gpu errors

https://codereview.chromium.org/118283002/

git-svn-id: http://skia.googlecode.com/svn/trunk@12743 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoUpdate bench pictures to time image decode & upload costs
robertphillips@google.com [Wed, 18 Dec 2013 17:25:33 +0000 (17:25 +0000)]
Update bench pictures to time image decode & upload costs

https://codereview.chromium.org/117583002/

git-svn-id: http://skia.googlecode.com/svn/trunk@12742 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRebaselining displacement gms
commit-bot@chromium.org [Wed, 18 Dec 2013 16:50:13 +0000 (16:50 +0000)]
Rebaselining displacement gms

Rebaseline needed because of changes made in https://codereview.chromium.org/101623007/

BUG=
R=senorblanco@chromium.org, senorblanco@google.com, bsalomon@google.com, bsalomon@chromium.org, sugoi@google.com

Author: sugoi@chromium.org

Review URL: https://codereview.chromium.org/101643003

git-svn-id: http://skia.googlecode.com/svn/trunk@12741 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoreplace SkScalarMulRound(a,b) with SkScalarRountToInt(a*b)
reed@google.com [Wed, 18 Dec 2013 15:49:32 +0000 (15:49 +0000)]
replace SkScalarMulRound(a,b) with SkScalarRountToInt(a*b)

BUG=
R=sugoi@google.com

Review URL: https://codereview.chromium.org/111393010

git-svn-id: http://skia.googlecode.com/svn/trunk@12740 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agorebaseline_server: write JSON files using Unix line endings, even on Windows
commit-bot@chromium.org [Wed, 18 Dec 2013 15:28:24 +0000 (15:28 +0000)]
rebaseline_server: write JSON files using Unix line endings, even on Windows

(SkipBuildbotRuns)
BUG=skia:1815
NOTRY=True
NOTREECHECKS=True
R=bsalomon@google.com, epoger@google.com

Author: epoger@gmail.com

Review URL: https://codereview.chromium.org/117783004

git-svn-id: http://skia.googlecode.com/svn/trunk@12739 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSplit atomic and mutex implementations and make inlinable.
bungeman@google.com [Wed, 18 Dec 2013 15:27:39 +0000 (15:27 +0000)]
Split atomic and mutex implementations and make inlinable.

Skia cannot use Chromium's implementation of mutex (Lock) due to static
initializers. However, we would like to be able to use Chromium's
implementation of atomics. This motivates the split of implementation.

Skia's atomic and mutex calls should be inlinable, especially the atomics.
These calls often compile down to very few instructions, and we currently have
the overhead of a function call. This motivates the header implementation.

There is still a desire for the build system to select the implementation, so
the SK_XXX_PLATFORM_H pattern for header files is introduced. This allows the
build system to control which platform specific header files are chosen.

The Chromium side changes (most of which will need to go in before this change
can be found at https://codereview.chromium.org/19477005/ .
The Chromium side changes after this lands can be seen at
https://codereview.chromium.org/98073013 .

Review URL: https://codereview.chromium.org/19808007

git-svn-id: http://skia.googlecode.com/svn/trunk@12738 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSamplePicture no longer uses SkImageRef
halcanary@google.com [Wed, 18 Dec 2013 15:08:35 +0000 (15:08 +0000)]
SamplePicture no longer uses SkImageRef

Motivation: in an attempt to simplify life, we are depricating
SkImageRef and its subclasses.  To that end, SamplePicture will now
use SkDiscardablePixelRef.

Also, fixed missing resource.

BUG=
R=scroggo@google.com

Review URL: https://codereview.chromium.org/116423006

git-svn-id: http://skia.googlecode.com/svn/trunk@12737 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdjusts Ubuntu bench multi_4_threads values. Widens range to cope with the new averag...
commit-bot@chromium.org [Wed, 18 Dec 2013 14:55:02 +0000 (14:55 +0000)]
Adjusts Ubuntu bench multi_4_threads values. Widens range to cope with the new average instead of 25th.

BUG=
R=robertphillips@google.com

Author: bensong@google.com

Review URL: https://codereview.chromium.org/108653014

git-svn-id: http://skia.googlecode.com/svn/trunk@12736 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Wed, 18 Dec 2013 07:01:56 +0000 (07:01 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@12734 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoremove last remnant of SK_SCALAR_IS_FIXED code
reed@google.com [Wed, 18 Dec 2013 05:19:22 +0000 (05:19 +0000)]
remove last remnant of SK_SCALAR_IS_FIXED code

move SkScalarMean into its only caller, reducing out public API exposure

BUG=

Review URL: https://codereview.chromium.org/117133004

git-svn-id: http://skia.googlecode.com/svn/trunk@12733 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agomove SkScalarMean into its only caller, reducing out public API exposure
reed@google.com [Wed, 18 Dec 2013 05:06:52 +0000 (05:06 +0000)]
move SkScalarMean into its only caller, reducing out public API exposure

BUG=

Review URL: https://codereview.chromium.org/117973002

git-svn-id: http://skia.googlecode.com/svn/trunk@12732 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agomove SkScalarLog2 into its only client, in a move to reduce our public API surface...
reed@google.com [Wed, 18 Dec 2013 04:59:26 +0000 (04:59 +0000)]
move SkScalarLog2 into its only client, in a move to reduce our public API surface area

BUG=

Review URL: https://codereview.chromium.org/93643004

git-svn-id: http://skia.googlecode.com/svn/trunk@12731 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd a setTimer() function.
commit-bot@chromium.org [Wed, 18 Dec 2013 04:45:37 +0000 (04:45 +0000)]
Add a setTimer() function.

Seemed simple, but required adding a Global class that contains all the global state (instance and context) for our running V8 instance. Also moved canvas.inval to be just inval() at the global level.

BUG=
R=robertphillips@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/103143009

git-svn-id: http://skia.googlecode.com/svn/trunk@12730 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years ago[PDF] Fix clipping in xfermode improvement.
commit-bot@chromium.org [Tue, 17 Dec 2013 23:38:28 +0000 (23:38 +0000)]
[PDF] Fix clipping in xfermode improvement.

In some cases, the wrong clip (src clip instead of initial clip) was used.
Switch almost exclusively to initial clip because it is safe and generates a smaller result.

BUG=chromium:328009
R=reed@google.com, bungeman@google.com

Author: vandebo@chromium.org

Review URL: https://codereview.chromium.org/116423004

git-svn-id: http://skia.googlecode.com/svn/trunk@12729 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoadd virtual destructor for SkExample to fix build error.
commit-bot@chromium.org [Tue, 17 Dec 2013 23:37:38 +0000 (23:37 +0000)]
add virtual destructor for SkExample to fix build error.

The original SkExample have virtual function draw(), but have no virtual destructor. This may lead to memory leak when free the instance of derived class of SkExample. The latest skia code show error when build SkiaExamples by "ninja -C out/Release SkiaExamples":
error: â€˜class SkExample’ has virtual functions and accessible non-virtual destructor.

R=caryclark@google.com

Author: yunchao.he@intel.com

Review URL: https://codereview.chromium.org/98463013

git-svn-id: http://skia.googlecode.com/svn/trunk@12728 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoFixing valgrind error
commit-bot@chromium.org [Tue, 17 Dec 2013 21:32:42 +0000 (21:32 +0000)]
Fixing valgrind error

After an error in the stream prevented the deserialization of SkRect members, there was no check to see if there was an error state before testing the validity of these uninitialized SkRect members. Added the check to fix the valgrind error.

BUG=
R=robertphillips@google.com, sugoi@google.com

Author: sugoi@chromium.org

Review URL: https://codereview.chromium.org/114493005

git-svn-id: http://skia.googlecode.com/svn/trunk@12727 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRemove bleed from ignored-tests.txt
bsalomon@google.com [Tue, 17 Dec 2013 21:27:39 +0000 (21:27 +0000)]
Remove bleed from ignored-tests.txt

BUG=skia:1880

Review URL: https://codereview.chromium.org/103213011

git-svn-id: http://skia.googlecode.com/svn/trunk@12726 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoMark bleed gpu as ignore failure on Xoom (Release version)
bsalomon@google.com [Tue, 17 Dec 2013 21:20:41 +0000 (21:20 +0000)]
Mark bleed gpu as ignore failure on Xoom (Release version)

BUG=skia:1938

Review URL: https://codereview.chromium.org/117633002

git-svn-id: http://skia.googlecode.com/svn/trunk@12725 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoMark bleed gpu as ignore failure on Xoom
bsalomon@google.com [Tue, 17 Dec 2013 21:13:00 +0000 (21:13 +0000)]
Mark bleed gpu as ignore failure on Xoom

BUG=skia:1938

Review URL: https://codereview.chromium.org/116093005

git-svn-id: http://skia.googlecode.com/svn/trunk@12724 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoFixed more fuzzer issues
commit-bot@chromium.org [Tue, 17 Dec 2013 20:49:46 +0000 (20:49 +0000)]
Fixed more fuzzer issues

- Added the "isAvailable" function to check how much bytes are remaining in the stream before doing potentially large mallocs. That way, we can signal a bad stream instead of crashing.
- Added data validation in SkImageInfo.cpp
- Added NULL pointer check in displacement
- Modified the fuzzer for randomized bitmap types

BUG=328934,329254
R=senorblanco@google.com, senorblanco@chromium.org, reed@google.com, sugoi@google.com

Author: sugoi@chromium.org

Review URL: https://codereview.chromium.org/116773002

git-svn-id: http://skia.googlecode.com/svn/trunk@12723 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoMark 8888/565 bleed GMS as ignore-failure
bsalomon@google.com [Tue, 17 Dec 2013 20:30:17 +0000 (20:30 +0000)]
Mark 8888/565 bleed GMS as ignore-failure

BUG=skia:1934

Review URL: https://codereview.chromium.org/117563003

git-svn-id: http://skia.googlecode.com/svn/trunk@12722 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdjusts Win7 bench tile_256x256_multi_4_threads. Using 8f4d230.
commit-bot@chromium.org [Tue, 17 Dec 2013 20:23:22 +0000 (20:23 +0000)]
Adjusts Win7 bench tile_256x256_multi_4_threads. Using 8f4d230.

BUG=
R=robertphillips@google.com

Author: bensong@google.com

Review URL: https://codereview.chromium.org/117523002

git-svn-id: http://skia.googlecode.com/svn/trunk@12721 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agochange SkScalarRound to SkScalarRoundToInt
reed@google.com [Tue, 17 Dec 2013 19:50:57 +0000 (19:50 +0000)]
change SkScalarRound to SkScalarRoundToInt

BUG=

Review URL: https://codereview.chromium.org/105073006

git-svn-id: http://skia.googlecode.com/svn/trunk@12720 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agodeprecate SkScalarRound (and its ilk), use SkScalarRound[ToInt,ToScalar]. #define...
reed@google.com [Tue, 17 Dec 2013 19:22:07 +0000 (19:22 +0000)]
deprecate SkScalarRound (and its ilk), use SkScalarRound[ToInt,ToScalar]. #define SK_SUPPORT_DEPRECATED_SCALARROUND for legacy clients

BUG=
R=robertphillips@google.com

Review URL: https://codereview.chromium.org/111353003

git-svn-id: http://skia.googlecode.com/svn/trunk@12719 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoBench rebaseline for Ubuntu. Also manually adjust one entry for Nexus7.
commit-bot@chromium.org [Tue, 17 Dec 2013 18:39:27 +0000 (18:39 +0000)]
Bench rebaseline for Ubuntu. Also manually adjust one entry for Nexus7.

BUG= https://code.google.com/p/skia/issues/detail?id=1871
R=robertphillips@google.com

Author: bensong@google.com

Review URL: https://codereview.chromium.org/106593003

git-svn-id: http://skia.googlecode.com/svn/trunk@12718 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agorebaseline_server: return rebaseline results faster, and reload UI page automatically...
commit-bot@chromium.org [Tue, 17 Dec 2013 18:06:13 +0000 (18:06 +0000)]
rebaseline_server: return rebaseline results faster, and reload UI page automatically after

Old way:
Wait until server has loaded the updated results before telling the user the rebaseline
was successful, and trust the user to reload the page before submitting more baselines.

New way:
Make server load the updated results in a separate thread, and automatically reload the page
so that the user can submit more baselines if she wants to.

(SkipBuildbotRuns)
NOTRY=True
NOTREECHECKS=True
R=bsalomon@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/117453002

git-svn-id: http://skia.googlecode.com/svn/trunk@12717 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdded five small images to the resources/encoding.
halcanary@google.com [Tue, 17 Dec 2013 17:40:13 +0000 (17:40 +0000)]
Added five small images to the resources/encoding.

1428 bytes total.

For use in testing https://codereview.chromium.org/93703004/

BUG=
R=scroggo@google.com

Review URL: https://codereview.chromium.org/107863005

git-svn-id: http://skia.googlecode.com/svn/trunk@12716 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd unreviewed skimage expectations for Test-Win8-ShuttleA-GTX660-x86-Release-NVPR
commit-bot@chromium.org [Tue, 17 Dec 2013 17:35:13 +0000 (17:35 +0000)]
Add unreviewed skimage expectations for Test-Win8-ShuttleA-GTX660-x86-Release-NVPR

NOTRY=True
BUG=
R=scroggo@google.com

Author: borenet@google.com

Review URL: https://codereview.chromium.org/110663006

git-svn-id: http://skia.googlecode.com/svn/trunk@12715 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd Win8 bots to rebaseline.py, add baselines for Win8
commit-bot@chromium.org [Tue, 17 Dec 2013 17:29:33 +0000 (17:29 +0000)]
Add Win8 bots to rebaseline.py, add baselines for Win8

NOTRY=True
BUG=
R=epoger@google.com

Author: borenet@google.com

Review URL: https://codereview.chromium.org/117433003

git-svn-id: http://skia.googlecode.com/svn/trunk@12714 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoremove SK_SCALAR_IS_[FLOAT,FIXED] and assume floats
reed@google.com [Tue, 17 Dec 2013 16:44:46 +0000 (16:44 +0000)]
remove SK_SCALAR_IS_[FLOAT,FIXED] and assume floats

To keep the CL (slightly) managable, this does not make any changes to
existing macros (e.g. SkScalarMul). Just tackling #ifdef constructs this
time around.

BUG=
R=bsalomon@google.com, caryclark@google.com

Review URL: https://codereview.chromium.org/117053002

git-svn-id: http://skia.googlecode.com/svn/trunk@12712 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRebaseline gpu and pdf bleed GM images
bsalomon@google.com [Tue, 17 Dec 2013 16:37:07 +0000 (16:37 +0000)]
Rebaseline gpu and pdf bleed GM images

BUG=1880

Review URL: https://codereview.chromium.org/100023006

git-svn-id: http://skia.googlecode.com/svn/trunk@12711 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoCreate empty GM expectations for all Win8 builders
commit-bot@chromium.org [Tue, 17 Dec 2013 16:33:35 +0000 (16:33 +0000)]
Create empty GM expectations for all Win8 builders

(SkipBuildbotRuns)
NOTRY=True
NOTREECHECKS=True
R=borenet@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/117233003

git-svn-id: http://skia.googlecode.com/svn/trunk@12710 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoFix handling of aggregate times in TimerData::getResult
robertphillips@google.com [Tue, 17 Dec 2013 16:32:51 +0000 (16:32 +0000)]
Fix handling of aggregate times in TimerData::getResult

https://codereview.chromium.org/117393002/

git-svn-id: http://skia.googlecode.com/svn/trunk@12709 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRebaseline innocuous image changes on Android.
bsalomon@google.com [Tue, 17 Dec 2013 15:34:17 +0000 (15:34 +0000)]
Rebaseline innocuous image changes on Android.

Review URL: https://codereview.chromium.org/117343002

git-svn-id: http://skia.googlecode.com/svn/trunk@12708 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRevert r12694 (Updated GLintptr and GLsizeiptr to be the appropriate types on 64...
robertphillips@google.com [Tue, 17 Dec 2013 15:13:55 +0000 (15:13 +0000)]
Revert r12694 (Updated GLintptr and GLsizeiptr to be the appropriate types on 64 bit Windows - https://codereview.chromium.org/111403003) due to Chromium-side compilation errors

git-svn-id: http://skia.googlecode.com/svn/trunk@12707 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoPrevent crash in Lua bindings.
commit-bot@chromium.org [Tue, 17 Dec 2013 14:28:19 +0000 (14:28 +0000)]
Prevent crash in Lua bindings.

SkPaint::getTypeface() can return NULL; paint:getTypeface() would
attempt to refcount that value before storing it on the Lua stack
and crash. This is a minimal workaround that fixes the crash.

R=reed@google.com, tomhudson@google.com, robertphillips@google.com

Author: tomhudson@chromium.org

Review URL: https://codereview.chromium.org/109793010

git-svn-id: http://skia.googlecode.com/svn/trunk@12706 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoMake bench_pictures' timing more GPU friendly
robertphillips@google.com [Tue, 17 Dec 2013 13:40:20 +0000 (13:40 +0000)]
Make bench_pictures' timing more GPU friendly

https://codereview.chromium.org/113873005/

git-svn-id: http://skia.googlecode.com/svn/trunk@12705 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Tue, 17 Dec 2013 07:01:45 +0000 (07:01 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@12703 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoThe register keyword is deprecated in C++, even at -O0, registers are used automatically.
commit-bot@chromium.org [Mon, 16 Dec 2013 23:51:11 +0000 (23:51 +0000)]
The register keyword is deprecated in C++, even at -O0, registers are used automatically.

Having the register keyword there causes a warning about deprecated keywords when using clang (and possibly future gcc versions), and isn't needed.

Patch originally submitted to AOSP
https://android-review.googlesource.com/#/c/72501

R=mtklein@google.com, scroggo@google.com, reed@google.com

Author: djsollen@google.com

Review URL: https://codereview.chromium.org/93703005

git-svn-id: http://skia.googlecode.com/svn/trunk@12702 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd new baselines for Win8 decoding tests.
scroggo@google.com [Mon, 16 Dec 2013 23:09:20 +0000 (23:09 +0000)]
Add new baselines for Win8 decoding tests.

Taken from server, and unreviewed.

Review URL: https://codereview.chromium.org/114813005

git-svn-id: http://skia.googlecode.com/svn/trunk@12700 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoBench rebaseline for Nexus7 and Win7. Expected values are from versions afada4c and...
commit-bot@chromium.org [Mon, 16 Dec 2013 22:58:40 +0000 (22:58 +0000)]
Bench rebaseline for Nexus7 and Win7. Expected values are from versions afada4c and 48d94b8.

BUG=
R=robertphillips@google.com, rmistry@google.com

Author: bensong@google.com

Review URL: https://codereview.chromium.org/107663007

git-svn-id: http://skia.googlecode.com/svn/trunk@12699 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoTweaks in how to apply bitmap filter levels in GPU.
commit-bot@chromium.org [Mon, 16 Dec 2013 21:02:29 +0000 (21:02 +0000)]
Tweaks in how to apply bitmap filter levels in GPU.

Fix fallback to MIP from bicubic for bitmap shaders
Skip MIP level generation on GPU when not minifying
Add medium quality and mixed up/down matrix test cases to filterbitmap tests

R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/103913012

git-svn-id: http://skia.googlecode.com/svn/trunk@12697 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRemove an assert that assumes too much.
scroggo@google.com [Mon, 16 Dec 2013 20:02:03 +0000 (20:02 +0000)]
Remove an assert that assumes too much.

The resulting bitmap may look funny, but it may not be our bug, and
the assert is making it difficult to use SKP files.

TBR=robertphillips@google.com, rmistry@google.com, bensong@google.com

BUG=skia:1905

Review URL: https://codereview.chromium.org/111463006

git-svn-id: http://skia.googlecode.com/svn/trunk@12696 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd a print function in the global JS scope for debugging.
commit-bot@chromium.org [Mon, 16 Dec 2013 19:55:01 +0000 (19:55 +0000)]
Add a print function in the global JS scope for debugging.

BUG=
R=robertphillips@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/100583005

git-svn-id: http://skia.googlecode.com/svn/trunk@12695 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoUpdated GLintptr and GLsizeiptr to be the appropriate types on 64 bit Windows
commit-bot@chromium.org [Mon, 16 Dec 2013 19:47:16 +0000 (19:47 +0000)]
Updated GLintptr and GLsizeiptr to be the appropriate types on 64 bit Windows

BUG=326382
R=reed@google.com, bsalomon@google.com

Author: bajones@chromium.org

Review URL: https://codereview.chromium.org/111403003

git-svn-id: http://skia.googlecode.com/svn/trunk@12694 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agorebaseline android images that use bicubic effect
bsalomon@google.com [Mon, 16 Dec 2013 18:51:33 +0000 (18:51 +0000)]
rebaseline android images that use bicubic effect

Review URL: https://codereview.chromium.org/116573002

git-svn-id: http://skia.googlecode.com/svn/trunk@12693 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd command line flag for optionally loading JS from external files.
commit-bot@chromium.org [Mon, 16 Dec 2013 18:24:51 +0000 (18:24 +0000)]
Add command line flag for optionally loading JS from external files.

BUG=
R=robertphillips@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/111853008

git-svn-id: http://skia.googlecode.com/svn/trunk@12692 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRefreshed SKPs to version 17. Triggering rebuilds.
rmistry@google.com [Mon, 16 Dec 2013 17:14:02 +0000 (17:14 +0000)]
Refreshed SKPs to version 17. Triggering rebuilds.

git-svn-id: http://skia.googlecode.com/svn/trunk@12690 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSupports the cap height for FreeType even when TT OS2 version is 1.
bungeman@google.com [Mon, 16 Dec 2013 17:02:39 +0000 (17:02 +0000)]
Supports the cap height for FreeType even when TT OS2 version is 1.

BUG=http://crbug.com/318645
R=bungeman@google.com, reed@google.com

Review URL: https://codereview.chromium.org/101333004

git-svn-id: http://skia.googlecode.com/svn/trunk@12689 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoUse GrTextureDomain in GrBicubicEffect to perform non-bleeding HQ filter drawBitmap.
commit-bot@chromium.org [Mon, 16 Dec 2013 15:18:11 +0000 (15:18 +0000)]
Use GrTextureDomain in GrBicubicEffect to perform non-bleeding HQ filter drawBitmap.

R=senorblanco@chromium.org, robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/99203011

git-svn-id: http://skia.googlecode.com/svn/trunk@12687 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoremove SkFP.h and replace SkFP with SkScalar stop respecting SK_SOFTWARE_FLOAT, assum...
reed@google.com [Mon, 16 Dec 2013 14:17:40 +0000 (14:17 +0000)]
remove SkFP.h and replace SkFP with SkScalar stop respecting SK_SOFTWARE_FLOAT, assume its always false stop respecting SK_SCALAR_SLOW_COMPARES, assume its always false

BUG=
R=caryclark@google.com

Review URL: https://codereview.chromium.org/116183002

git-svn-id: http://skia.googlecode.com/svn/trunk@12686 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Mon, 16 Dec 2013 07:01:40 +0000 (07:01 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@12685 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoFix some presubmit warnings.
tfarina@chromium.org [Sat, 14 Dec 2013 15:12:48 +0000 (15:12 +0000)]
Fix some presubmit warnings.

I found this while running a modified version of v8's tools/presubmit.py
script.

samplecode/SampleImage.cpp does not end with a single new line.
samplecode/SampleImageDir.cpp does not end with a single new line.
src/ports/SkFontHost_sandbox_none.cpp does not end with a single new line.
tests/FlatDataTest.cpp does not end with a single new line.
tests/ImageCacheTest.cpp has trailing whitespaces in line 31.

* Removed three empty files.
* Add single new line to FlatDataTest.cpp
* Removed trailing whitespace in ImageCacheTest.cpp

BUG=None
TEST=None
R=bsalomon@google.com
TBR=bsalomon@google.com

Review URL: https://codereview.chromium.org/111503008

git-svn-id: http://skia.googlecode.com/svn/trunk@12684 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoUse SkScalar when aligning glyphs in user space.
bungeman@google.com [Fri, 13 Dec 2013 21:26:02 +0000 (21:26 +0000)]
Use SkScalar when aligning glyphs in user space.

Drawing text from paths is done in user space and not in device space.
All operations in user space should be performed with SkScalars.

BUG=327031
R=reed@google.com

Review URL: https://codereview.chromium.org/113123005

git-svn-id: http://skia.googlecode.com/svn/trunk@12682 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoremove SkScalarCompare type and header
reed@google.com [Fri, 13 Dec 2013 21:16:12 +0000 (21:16 +0000)]
remove SkScalarCompare type and header

BUG=
R=fmalita@chromium.org

Review URL: https://codereview.chromium.org/113193004

git-svn-id: http://skia.googlecode.com/svn/trunk@12681 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agorender_pictures: add --writeJsonSummaryPath
commit-bot@chromium.org [Fri, 13 Dec 2013 20:52:36 +0000 (20:52 +0000)]
render_pictures: add --writeJsonSummaryPath

Known issues:
- JSON summary will be empty if --writePath not specified also
- testNames within summary do not include the config (8888, gpu, etc.)

BUG=
R=rmistry@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/98643007

git-svn-id: http://skia.googlecode.com/svn/trunk@12680 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agobump picture format to 17 to go with PixelRef Info CL
reed@google.com [Fri, 13 Dec 2013 19:58:46 +0000 (19:58 +0000)]
bump picture format to 17 to go with PixelRef Info CL

BUG=

Review URL: https://codereview.chromium.org/106763004

git-svn-id: http://skia.googlecode.com/svn/trunk@12678 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoUpdate all callsites to use info for pixelrefs
reed@google.com [Fri, 13 Dec 2013 19:45:58 +0000 (19:45 +0000)]
Update all callsites to use info for pixelrefs

#define SK_SUPPORT_LEGACY_PIXELREF_CONSTRUCTOR in chrome to keep old API signature (for now)

BUG=
R=scroggo@google.com

Review URL: https://codereview.chromium.org/100723005

git-svn-id: http://skia.googlecode.com/svn/trunk@12677 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoImproved SkPathRef interface security
robertphillips@google.com [Fri, 13 Dec 2013 19:36:25 +0000 (19:36 +0000)]
Improved SkPathRef interface security

https://codereview.chromium.org/115323004/

git-svn-id: http://skia.googlecode.com/svn/trunk@12676 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoFix win7 BitmapTest
halcanary@google.com [Fri, 13 Dec 2013 19:25:21 +0000 (19:25 +0000)]
Fix win7 BitmapTest

BUG=
R=bungeman@google.com

Review URL: https://codereview.chromium.org/110223005

git-svn-id: http://skia.googlecode.com/svn/trunk@12675 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAllow 0-width SkBitmap in setConfig.
halcanary@google.com [Fri, 13 Dec 2013 18:29:51 +0000 (18:29 +0000)]
Allow 0-width SkBitmap in setConfig.

Previously, SkBitmap::setConfig would allow zero height, but not zero
width.  This is changed for consistancy.

A unit test was added.

BUG=
R=reed@google.com, scroggo@google.com

Review URL: https://codereview.chromium.org/111953004

git-svn-id: http://skia.googlecode.com/svn/trunk@12673 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoReverting r12665 & r12666 (Remove duplicate impl for SkImageInfo flattening) due...
robertphillips@google.com [Fri, 13 Dec 2013 15:24:37 +0000 (15:24 +0000)]
Reverting r12665 & r12666 (Remove duplicate impl for SkImageInfo flattening) due to Chromium/Blink compilation errors

https://codereview.chromium.org/112603003/

git-svn-id: http://skia.googlecode.com/svn/trunk@12667 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoMac 10.6 compiler fix for r12665 (Remove duplicate impl for SkImageInfo flattening)
robertphillips@google.com [Fri, 13 Dec 2013 14:34:12 +0000 (14:34 +0000)]
Mac 10.6 compiler fix for r12665 (Remove duplicate impl for SkImageInfo flattening)

https://codereview.chromium.org/101913006/

git-svn-id: http://skia.googlecode.com/svn/trunk@12666 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRemvoe duplicate impl for SkImageInfo flattening
reed@google.com [Fri, 13 Dec 2013 14:18:14 +0000 (14:18 +0000)]
Remvoe duplicate impl for SkImageInfo flattening
Add onNewLockPixels

This reverts commit bb8eff6a70c52b7644391cfd4f4d21bf7294a6bf.

BUG=

Review URL: https://codereview.chromium.org/111323005

git-svn-id: http://skia.googlecode.com/svn/trunk@12665 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRevert "Revert of https://codereview.chromium.org/112783004/"
reed@google.com [Fri, 13 Dec 2013 13:41:14 +0000 (13:41 +0000)]
Revert "Revert of https://codereview.chromium.org/112783004/"

This reverts commit 3293fe57a7507541e9040eab880dcd82c43881f4.

Conflicts:
src/core/SkScaledImageCache.cpp

BUG=

Review URL: https://codereview.chromium.org/108613005

git-svn-id: http://skia.googlecode.com/svn/trunk@12663 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoDon't run the GM in serialization modes.
senorblanco@chromium.org [Thu, 12 Dec 2013 23:54:33 +0000 (23:54 +0000)]
Don't run the GM in serialization modes.

git-svn-id: http://skia.googlecode.com/svn/trunk@12662 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoImplement an SkPicture image filter source. This is required for the external-SVG...
senorblanco@chromium.org [Thu, 12 Dec 2013 23:28:52 +0000 (23:28 +0000)]
Implement an SkPicture image filter source. This is required for the external-SVG reference feature of feImage. It simply plays back an SkPicture to a given destination rect.

R=reed@google.com

Review URL: https://codereview.chromium.org/114263002

git-svn-id: http://skia.googlecode.com/svn/trunk@12661 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoMove segment mask from SkPath to SkPathRef
robertphillips@google.com [Thu, 12 Dec 2013 23:03:51 +0000 (23:03 +0000)]
Move segment mask from SkPath to SkPathRef

https://codereview.chromium.org/105083003/

git-svn-id: http://skia.googlecode.com/svn/trunk@12660 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoPerlin noise rebaseline
commit-bot@chromium.org [Thu, 12 Dec 2013 23:00:10 +0000 (23:00 +0000)]
Perlin noise rebaseline

BUG=skia:1881

Committed: https://code.google.com/p/skia/source/detail?r=5f145c9

R=sugoi@google.com, mtklein@google.com

Author: sugoi@chromium.org

Review URL: https://codereview.chromium.org/99433007

git-svn-id: http://skia.googlecode.com/svn/trunk@12659 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agobe sure to unlock the discardablememory before deleting it
reed@google.com [Thu, 12 Dec 2013 22:37:32 +0000 (22:37 +0000)]
be sure to unlock the discardablememory before deleting it

BUG=

Review URL: https://codereview.chromium.org/114673002

git-svn-id: http://skia.googlecode.com/svn/trunk@12658 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRevert "Implement an SkPicture image filter source. This is required for the external...
senorblanco@chromium.org [Thu, 12 Dec 2013 22:23:32 +0000 (22:23 +0000)]
Revert "Implement an SkPicture image filter source. This is required for the external-SVG reference feature of feImage. It simply plays back an SkPicture to a given destination rect."

This reverts commit a620349a24471546ad2e8f0679774c1f5b4de0a4 (r12656).

git-svn-id: http://skia.googlecode.com/svn/trunk@12657 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoImplement an SkPicture image filter source. This is required for the external-SVG...
senorblanco@chromium.org [Thu, 12 Dec 2013 22:00:34 +0000 (22:00 +0000)]
Implement an SkPicture image filter source. This is required for the external-SVG reference feature of feImage. It simply plays back an SkPicture to a given destination rect.

R=reed@google.com

Review URL: https://codereview.chromium.org/114263002

git-svn-id: http://skia.googlecode.com/svn/trunk@12656 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoFixed a displacement issue
commit-bot@chromium.org [Thu, 12 Dec 2013 21:48:32 +0000 (21:48 +0000)]
Fixed a displacement issue

The displacement filter was assuming that both inputs were of the same size, which is true in blink, but not necessarily in a compromised stream.

BUG=327372
R=senorblanco@chromium.org, senorblanco@google.com, reed@google.com, fmalita@chromium.org, fmalita@google.com, sugoi@google.com

Author: sugoi@chromium.org

Review URL: https://codereview.chromium.org/101623007

git-svn-id: http://skia.googlecode.com/svn/trunk@12655 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agodetect if the scaledimagecache returns a purged bitmap
reed@google.com [Thu, 12 Dec 2013 21:37:25 +0000 (21:37 +0000)]
detect if the scaledimagecache returns a purged bitmap

BUG=
R=scroggo@google.com

Review URL: https://codereview.chromium.org/110383005

git-svn-id: http://skia.googlecode.com/svn/trunk@12654 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoUse DEFINE_TESTCLASS_SHORT macro in tests.
tfarina@chromium.org [Thu, 12 Dec 2013 21:11:12 +0000 (21:11 +0000)]
Use DEFINE_TESTCLASS_SHORT macro in tests.

The three version of DEFINE_TESTCLASS macro is deprecated and thus just
use the simple, short one.

BUG=None
TEST=out/Debug/tests
R=mtklein@google.com, bsalomon@google.com, robertphillips@google.com

Review URL: https://codereview.chromium.org/100113004

git-svn-id: http://skia.googlecode.com/svn/trunk@12653 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoBounds fixes for SkXfermodeImageFilter:
senorblanco@chromium.org [Thu, 12 Dec 2013 21:00:58 +0000 (21:00 +0000)]
Bounds fixes for SkXfermodeImageFilter:

1) Change the default bounds to the union of the foreground and background bounds.
2) Use a canvas translate instead of manually offsetting the foreground and background bounds by the union.
3) Apply the transfer mode to all pixels, including those outside the foreground rect by using a difference clip.

Covered by the offset test cases in the xfermodeimagefilter GM (will need rebaselines).

R=reed@google.com

Review URL: https://codereview.chromium.org/112683004

git-svn-id: http://skia.googlecode.com/svn/trunk@12652 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoTry another GYP DEPS
commit-bot@chromium.org [Thu, 12 Dec 2013 20:55:00 +0000 (20:55 +0000)]
Try another GYP DEPS

This one is just before the introduction of the Python 2.7 requirement.

BUG=
R=rmistry@google.com, robertphillips@google.com

Author: borenet@google.com

Review URL: https://codereview.chromium.org/99583004

git-svn-id: http://skia.googlecode.com/svn/trunk@12651 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRevert r12648
borenet@google.com [Thu, 12 Dec 2013 19:58:10 +0000 (19:58 +0000)]
Revert r12648

Review URL: https://codereview.chromium.org/114453002

git-svn-id: http://skia.googlecode.com/svn/trunk@12650 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoPreventing division by 0
commit-bot@chromium.org [Thu, 12 Dec 2013 19:47:09 +0000 (19:47 +0000)]
Preventing division by 0

I did bench tests and I can't compute the denom before the if condition without taking a hit. After a few quick tests on my linux desktop, computing the 1st denom costs 6ms, the 2nd one 5ms and both together cost 9ms. The reason for this is that both if conditions here are exceptions and are expected to be false, so the denom computation should be skipped, if possible. The bench test I ran was :

out/Release/bench --match Xfermode_Hue --config 8888 --minMs 1000

BUG=
R=senorblanco@chromium.org, senorblanco@google.com, reed@google.com, sugoi@google.com

Author: sugoi@chromium.org

Review URL: https://codereview.chromium.org/114173002

git-svn-id: http://skia.googlecode.com/svn/trunk@12649 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoUpdate GYP DEPS to obtain VS 2013 support
commit-bot@chromium.org [Thu, 12 Dec 2013 19:39:04 +0000 (19:39 +0000)]
Update GYP DEPS to obtain VS 2013 support

R=rmistry@google.com

Author: borenet@google.com

Review URL: https://codereview.chromium.org/103893006

git-svn-id: http://skia.googlecode.com/svn/trunk@12648 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRevert of https://codereview.chromium.org/112783004/
commit-bot@chromium.org [Thu, 12 Dec 2013 18:08:08 +0000 (18:08 +0000)]
Revert of https://codereview.chromium.org/112783004/
Reason for revert: Failing assert on Android

R=scroggo@google.com, halcanary@google.com, reed@google.com, rmistry@google.com
TBR=halcanary@google.com, reed@google.com, scroggo@google.com
NOTREECHECKS=true
NOTRY=true

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/93673005

git-svn-id: http://skia.googlecode.com/svn/trunk@12646 2bbb7eff-a529-9590-31e7-b0007b416f81