platform/upstream/llvm.git
6 years ago[X86] Add skeleton support for icelake CPU.
Craig Topper [Sun, 19 Nov 2017 01:12:00 +0000 (01:12 +0000)]
[X86] Add skeleton support for icelake CPU.

There are several patches out for review right now to implement Icelake features. This adds a CPU to collect them under.

llvm-svn: 318612

6 years ago[X86] Fix 80 column violation and remove trailing whitespace. NFC
Craig Topper [Sun, 19 Nov 2017 01:11:58 +0000 (01:11 +0000)]
[X86] Fix 80 column violation and remove trailing whitespace. NFC

llvm-svn: 318611

6 years ago[X86] Add cpu detection for cannonlake.
Craig Topper [Sun, 19 Nov 2017 00:46:21 +0000 (00:46 +0000)]
[X86] Add cpu detection for cannonlake.

This uses the same encoding for cannonlake in the proposed gcc patches here. https://gcc.gnu.org/ml/gcc-patches/2017-11/msg00551.html

llvm-svn: 318610

6 years agoDriver: remove `SupportsObjCGC` (NFC)
Saleem Abdulrasool [Sun, 19 Nov 2017 00:45:33 +0000 (00:45 +0000)]
Driver: remove `SupportsObjCGC` (NFC)

This option is not used in the frontend.  Remove the method.

llvm-svn: 318609

6 years ago[Driver] add initial support for alpine linux
Martell Malone [Sun, 19 Nov 2017 00:08:12 +0000 (00:08 +0000)]
[Driver] add initial support for alpine linux

set -pie as default for musl linux targets
add detection of alpine linux
append appropriate compile flags for alpine

Reviewers: rnk

Differential Revision: https://reviews.llvm.org/D39588

llvm-svn: 318608

6 years ago[LIT] Fix testing out-of-tree Clang builds
Eric Fiselier [Sun, 19 Nov 2017 00:00:49 +0000 (00:00 +0000)]
[LIT] Fix testing out-of-tree Clang builds

Summary:
Currently, LIT configures the LLVM binary path before the Clang binary path. However this breaks testing out-of-tree Clang builds (where the LLVM binary path includes a copy of Clang).

This patch reverses the order of the paths when looking for Clang, putting the Clang binary directory first.

Reviewers: zturner, beanz, chapuni, modocache, EricWF

Reviewed By: EricWF

Subscribers: mgorny, cfe-commits, llvm-commits

Differential Revision: https://reviews.llvm.org/D40217

llvm-svn: 318607

6 years ago[MC][X86] Add test case from PR19251
Simon Pilgrim [Sat, 18 Nov 2017 23:23:25 +0000 (23:23 +0000)]
[MC][X86] Add test case from PR19251

llvm-svn: 318605

6 years ago[MC][X86] Add teet case from PR32807
Simon Pilgrim [Sat, 18 Nov 2017 23:06:42 +0000 (23:06 +0000)]
[MC][X86] Add teet case from PR32807

llvm-svn: 318603

6 years agoFix use of config.h in public headers.
Eric Fiselier [Sat, 18 Nov 2017 22:42:26 +0000 (22:42 +0000)]
Fix use of config.h in public headers.

The CodeGenCoverage.h header is installed, but it references
the build-only header "llvm/Config/config.h". This breaks use
of the CodeGenCoverage.h header once it is installed, because config.h isn't
available.

This patch fixes the error by moving the config.h include from
the CodeGenCoverage.h header (where it's not needed), to the
CodeGenCoverage.cpp source file.

llvm-svn: 318602

6 years ago[OpenMP] Show error if VLAs are not supported
Jonas Hahnfeld [Sat, 18 Nov 2017 21:00:46 +0000 (21:00 +0000)]
[OpenMP] Show error if VLAs are not supported

Some target devices (e.g. Nvidia GPUs) don't support dynamic stack
allocation and hence no VLAs. Print errors with description instead
of failing in the backend or generating code that doesn't work.

This patch handles explicit uses of VLAs (local variable in target
or declare target region) or implicitly generated (private) VLAs
for reductions on VLAs or on array sections with non-constant size.

Differential Revision: https://reviews.llvm.org/D39505

llvm-svn: 318601

6 years ago[clang-tidy] Add new hicpp-multiway-paths-covered check for missing branches
Jonas Toth [Sat, 18 Nov 2017 19:48:33 +0000 (19:48 +0000)]
[clang-tidy] Add new hicpp-multiway-paths-covered check for missing branches

Summary:
This check searches for missing `else` branches in `if-else if`-chains and
missing `default` labels in `switch` statements, that use integers as condition.

It is very similar to -Wswitch, but concentrates on integers only, since enums are
already covered.

The option to warn for missing `else` branches is deactivated by default, since it is
very noise on larger code bases.

Running it on LLVM:
{F5354858} for default configuration
{F5354866} just for llvm/lib/Analysis/ScalarEvolution.cpp, the else-path checker is very noisy!

Reviewers: alexfh, aaron.ballman, hokein

Reviewed By: aaron.ballman

Subscribers: lebedev.ri, Eugene.Zelenko, cfe-commits, mgorny, JDevlieghere, xazax.hun

Tags: #clang-tools-extra

Differential Revision: https://reviews.llvm.org/D37808

llvm-svn: 318600

6 years ago[X86][AVX512VL] Add AVX512VL tests to the vselect packss tests.
Simon Pilgrim [Sat, 18 Nov 2017 19:47:59 +0000 (19:47 +0000)]
[X86][AVX512VL] Add AVX512VL tests to the vselect packss tests.

PR34553 has gone, adding tests to ensure it doesn't come back.

vselect_packss_v16i64 still has some awful codegen on AVX512 targets....

llvm-svn: 318599

6 years ago[CodeGen] change const-ness of complex calls
Sanjay Patel [Sat, 18 Nov 2017 19:31:57 +0000 (19:31 +0000)]
[CodeGen] change const-ness of complex calls

After clarification about the C standard, POSIX, and implementations:
The C standard allows errno-setting, and it's (unfortunately for optimization) even
more clearly stated in the newer additions to the standards.

We can leave these functions as always constant ('c') because they don't
actually do any math and therefore won't set errno:
cimag ( http://en.cppreference.com/w/c/numeric/complex/cimag )
creal ( http://en.cppreference.com/w/c/numeric/complex/creal )
cproj ( http://en.cppreference.com/w/c/numeric/complex/cproj )
conj (http://en.cppreference.com/w/c/numeric/complex/conj )

Differential Revision: https://reviews.llvm.org/D39611

llvm-svn: 318598

6 years ago[X86] Add another gather test with v8i8 sign extended indices.
Craig Topper [Sat, 18 Nov 2017 19:25:35 +0000 (19:25 +0000)]
[X86] Add another gather test with v8i8 sign extended indices.

This requires the indices to be legalized and sign extended.

llvm-svn: 318597

6 years ago[X86] Simplify the gather/scatter isel predicates.
Craig Topper [Sat, 18 Nov 2017 19:05:12 +0000 (19:05 +0000)]
[X86] Simplify the gather/scatter isel predicates.

We don't need a dyn_cast, the predicate already specified the base node. We only need to check the type of the index, the base ptr is guaranteed to be scalar.

llvm-svn: 318596

6 years ago[X86] Qualify a few places with ExperimentalVectorWideningLegalization.
Craig Topper [Sat, 18 Nov 2017 18:49:16 +0000 (18:49 +0000)]
[X86] Qualify a few places with ExperimentalVectorWideningLegalization.

I'm playing around with this flag and these places cause errors if not qualified.

llvm-svn: 318595

6 years ago[X86] Add todo comment for TRUNC(SUB(X,C)) -> SUB(TRUNC(X),C')
Simon Pilgrim [Sat, 18 Nov 2017 18:33:07 +0000 (18:33 +0000)]
[X86] Add todo comment for TRUNC(SUB(X,C)) -> SUB(TRUNC(X),C')

As discussed on PR35295, but it causes regressions in combineSubToSubus which need to be addressed first

llvm-svn: 318594

6 years ago[CallSiteSplitting] Remove some indirection (NFC).
Florian Hahn [Sat, 18 Nov 2017 18:14:13 +0000 (18:14 +0000)]
[CallSiteSplitting] Remove some indirection (NFC).

Summary:
With this patch I tried to reduce the complexity of the code sightly, by
removing some indirection. Please let me know what you think.

Reviewers: junbuml, mcrosier, davidxl

Reviewed By: junbuml

Subscribers: llvm-commits

Differential Revision: https://reviews.llvm.org/D40037

llvm-svn: 318593

6 years ago[x86] add tests for unnecessary shuffling; NFC
Sanjay Patel [Sat, 18 Nov 2017 16:25:38 +0000 (16:25 +0000)]
[x86] add tests for unnecessary shuffling; NFC

llvm-svn: 318592

6 years ago[X86] Output cfi directives for saved XMM registers even if no GPRs are saved
Martin Storsjo [Sat, 18 Nov 2017 06:23:48 +0000 (06:23 +0000)]
[X86] Output cfi directives for saved XMM registers even if no GPRs are saved

This makes sure that functions that only clobber xmm registers
(on win64) also get the right cfi directives, if dwarf exceptions
are enabled.

Differential Revision: https://reviews.llvm.org/D40191

llvm-svn: 318591

6 years ago[X86] Fix typo in variable name. NFC
Craig Topper [Sat, 18 Nov 2017 05:09:55 +0000 (05:09 +0000)]
[X86] Fix typo in variable name. NFC

llvm-svn: 318590

6 years ago[AArch64] Map G_LOAD on FPR when the definition goes to a copy to FPR
Quentin Colombet [Sat, 18 Nov 2017 04:28:59 +0000 (04:28 +0000)]
[AArch64] Map G_LOAD on FPR when the definition goes to a copy to FPR

We used to detect loads feeding fp instructions, but we were
failing to take into account cases where this happens through copies.
For instance, loads can fed copies coming from the ABI lowering
of floating point arguments/results.

llvm-svn: 318589

6 years ago[AArch64] Map G_STORE on FPR when the source comes from a FPR copy
Quentin Colombet [Sat, 18 Nov 2017 04:28:58 +0000 (04:28 +0000)]
[AArch64] Map G_STORE on FPR when the source comes from a FPR copy

We used to detect that stores were fed by fp instructions, but we were
failing to take into account cases where this happens through copies.
For instance, stores can be fed by copies coming from the ABI lowering
of floating point arguments.

llvm-svn: 318588

6 years ago[RegisterBankInfo] Relax the assert of having matching type sizes on default mappings
Quentin Colombet [Sat, 18 Nov 2017 04:28:58 +0000 (04:28 +0000)]
[RegisterBankInfo] Relax the assert of having matching type sizes on default mappings

Instead of asserting that the type sizes are exactly equal, we check
that the new size is big enough to contain the original type.
We have to relax this constrain because, right now, we sometimes
specify that things that are smaller than a storage type are legal
instead of widening everything to the size of a storage type.
E.g., we say that G_AND s16 is legal and we map that on GPR32.

This is something we may revisit in the future (either by changing
the legalization process or keeping track separately of the storage
size and the size of the type), but let us reflect the reality of
the situation for now.

llvm-svn: 318587

6 years ago[AArch64][RegisterBankInfo] Teach instruction mapping about gpr32 -> fpr16 cross...
Quentin Colombet [Sat, 18 Nov 2017 04:28:56 +0000 (04:28 +0000)]
[AArch64][RegisterBankInfo] Teach instruction mapping about gpr32 -> fpr16 cross copies

Turns out this copies can actually occur because of the way we lower the
ABI for half.

llvm-svn: 318586

6 years agoReorder static functions. NFC.
Rafael Espindola [Sat, 18 Nov 2017 02:12:53 +0000 (02:12 +0000)]
Reorder static functions. NFC.

llvm-svn: 318584

6 years agoSplit realPathFromHandle in two.
Rafael Espindola [Sat, 18 Nov 2017 02:05:59 +0000 (02:05 +0000)]
Split realPathFromHandle in two.

By having an UTF-16 version we avoid some code duplication in calling
GetFinalPathNameByHandleW.

llvm-svn: 318583

6 years ago[AST] Fix some Clang-tidy modernize and Include What You Use warnings; other minor...
Eugene Zelenko [Sat, 18 Nov 2017 01:47:41 +0000 (01:47 +0000)]
[AST] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC).

llvm-svn: 318582

6 years ago[asan] Add a full redzone after every stack variable
Walter Lee [Sat, 18 Nov 2017 01:13:18 +0000 (01:13 +0000)]
[asan] Add a full redzone after every stack variable

We were not doing that for large shadow granularity.  Also add more
stack frame layout tests for large shadow granularity.

Differential Revision: https://reviews.llvm.org/D39475

llvm-svn: 318581

6 years ago[ABI] Remove dead code that was copy-pasted all around. NFCI.
Davide Italiano [Sat, 18 Nov 2017 00:54:31 +0000 (00:54 +0000)]
[ABI] Remove dead code that was copy-pasted all around. NFCI.

llvm-svn: 318580

6 years ago[Module] Throw away some more commented code. NFCI.
Davide Italiano [Sat, 18 Nov 2017 00:52:29 +0000 (00:52 +0000)]
[Module] Throw away some more commented code. NFCI.

llvm-svn: 318579

6 years agoFix some -Wunused-variable warnings
Hans Wennborg [Sat, 18 Nov 2017 00:49:18 +0000 (00:49 +0000)]
Fix some -Wunused-variable warnings

llvm-svn: 318578

6 years ago[ABI/SysV] Remove more dead code. NFCI.
Davide Italiano [Sat, 18 Nov 2017 00:35:27 +0000 (00:35 +0000)]
[ABI/SysV] Remove more dead code. NFCI.

llvm-svn: 318577

6 years ago[Core] Garbage collect dead code untouched in years. NFCI.
Davide Italiano [Sat, 18 Nov 2017 00:34:09 +0000 (00:34 +0000)]
[Core] Garbage collect dead code untouched in years. NFCI.

This sketching can be resurrected if anybody needs it, although
I doubt is relevant these days.

llvm-svn: 318576

6 years agoRevert "[asan] Use dynamic shadow on 32-bit Android" and 3 more.
Evgeniy Stepanov [Sat, 18 Nov 2017 00:22:34 +0000 (00:22 +0000)]
Revert "[asan] Use dynamic shadow on 32-bit Android" and 3 more.

Revert the following commits:
  r318369 [asan] Fallback to non-ifunc dynamic shadow on android<22.
  r318235 [asan] Prevent rematerialization of &__asan_shadow.
  r317948 [sanitizer] Remove unnecessary attribute hidden.
  r317943 [asan] Use dynamic shadow on 32-bit Android.

MemoryRangeIsAvailable() reads /proc/$PID/maps into an mmap-ed buffer
that may overlap with the address range that we plan to use for the
dynamic shadow mapping. This is causing random startup crashes.

llvm-svn: 318575

6 years ago[globalisel][tablegen] Generalize pointer-type inference by introducing ptypeN. NFC
Daniel Sanders [Sat, 18 Nov 2017 00:16:44 +0000 (00:16 +0000)]
[globalisel][tablegen] Generalize pointer-type inference by introducing ptypeN. NFC

ptypeN is functionally the same as typeN except that it informs the
SelectionDAG importer that an operand should be treated as a pointer even
if it was written as iN. This is important for patterns that use iN instead
of iPTR to represent pointers. E.g.:
  (set GPR64:$dst, (load GPR64:$addr))

Previously, this was handled as a hardcoded special case for the appropriate
operands to G_LOAD and G_STORE.

llvm-svn: 318574

6 years ago[asan] Fix asan_device_setup on KitKat.
Evgeniy Stepanov [Fri, 17 Nov 2017 23:52:34 +0000 (23:52 +0000)]
[asan] Fix asan_device_setup on KitKat.

"ln" from toybox does not understand -f (force) flag.

llvm-svn: 318573

6 years ago[lit] Try to improve Ctrl-C behavior on Windows
Reid Kleckner [Fri, 17 Nov 2017 23:52:33 +0000 (23:52 +0000)]
[lit] Try to improve Ctrl-C behavior on Windows

This functionality was broken during a refactor a while back because
'pool' is no longer in scope.

llvm-svn: 318572

6 years ago[CMake][runtimes] Don't passthrough prefixes for non-default targets
Petr Hosek [Fri, 17 Nov 2017 23:51:53 +0000 (23:51 +0000)]
[CMake][runtimes] Don't passthrough prefixes for non-default targets

The passthrough is useful for setting up the options for the default
build, but we already have a different mechanism to pass CMake flags
to builds for builtins and runtimes targets so this is not really
needed there. Furthermore, when the flags are set for the default
build, with the prefix passthrough set we have to explicitly override
all options in other targets which can be cumbersome.

Differential Revision: https://reviews.llvm.org/D39988

llvm-svn: 318571

6 years ago[AST] Fix some Clang-tidy modernize and Include What You Use warnings; other minor...
Eugene Zelenko [Fri, 17 Nov 2017 23:43:46 +0000 (23:43 +0000)]
[AST] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC).

llvm-svn: 318570

6 years ago[libunwind][CMake] Provide option to disable instalation of the library
Petr Hosek [Fri, 17 Nov 2017 23:29:46 +0000 (23:29 +0000)]
[libunwind][CMake] Provide option to disable instalation of the library

This is useful in cases where we only build static library and
libunwind.a is combined with libc++abi.a into a single archive in which
case we don't want to have libunwind.a installed separately. The same
option is already provided by libcxx CMake build.

This change also adds the install-unwind target for consistency with the
libcxxabi and libcxx CMake build.

Differential Revision: https://reviews.llvm.org/D40195

llvm-svn: 318569

6 years ago[libcxxabi][CMake] Provide option to disable installing of the library
Petr Hosek [Fri, 17 Nov 2017 23:25:09 +0000 (23:25 +0000)]
[libcxxabi][CMake] Provide option to disable installing of the library

This is useful in cases where we only build static library and
libc++abi.a is combined with libc++.a into a single archive in which
case we don't want to have libc++abi.a installed separately. The same
option is already provided by libcxx CMake build.

Differential Revision: https://reviews.llvm.org/D40194

llvm-svn: 318568

6 years agoChange code owner for Clang Static Analyzer to Devin Coughlin.
Anna Zaks [Fri, 17 Nov 2017 23:19:04 +0000 (23:19 +0000)]
Change code owner for Clang Static Analyzer to Devin Coughlin.

Differential Revision: https://reviews.llvm.org/D39964

llvm-svn: 318567

6 years agoFix an issue with llvm lit tool substitutions.
Zachary Turner [Fri, 17 Nov 2017 22:51:43 +0000 (22:51 +0000)]
Fix an issue with llvm lit tool substitutions.

When using an installed clang with an in-tree llvm, we were not
searching in the right paths for the tools.

llvm-svn: 318564

6 years ago[CMake][libcxxabi] Support merging objects when statically linking unwinder
Petr Hosek [Fri, 17 Nov 2017 22:49:39 +0000 (22:49 +0000)]
[CMake][libcxxabi] Support merging objects when statically linking unwinder

When using LLVM unwinder and static unwinder option is set, merge
libunwind and libc++abi objects into a single archive. libc++ already
supports merging libc++abi.a and libc++.a into a single archive; with
this change, it is possible to also include libunwind.a in the same
archive which is useful when doing static link and using libc++ as
a default C++ library and compiler-rt as a default runtime library.

Differential Revision: https://reviews.llvm.org/D39949

llvm-svn: 318563

6 years ago[cmake] Use llvm-lit directory when provided for stand-alone build
Michal Gorny [Fri, 17 Nov 2017 22:21:23 +0000 (22:21 +0000)]
[cmake] Use llvm-lit directory when provided for stand-alone build

After the recent lit test changes, clang attempts to run its tests
via llvm-lit by default. However, the llvm-lit binary is not present
when performing stand-alone build resulting in a failure out of the box.

To solve that, add the llvm-lit directory to CMake when performing
a stand-alone build and LLVM sources are provided. This includes
the CMake rules generating the llvm-lit binary and effectively makes
it possible for clang to use it.

Differential Revision: https://reviews.llvm.org/D40142

llvm-svn: 318562

6 years ago[NFC] Make r318597 compatible with clang-format
Zhaoshi Zheng [Fri, 17 Nov 2017 22:05:19 +0000 (22:05 +0000)]
[NFC] Make r318597 compatible with clang-format

llvm-svn: 318561

6 years ago[MC] Fix regression tests on Windows when git “core.autocrlf” is set to true.
Zhen Cao [Fri, 17 Nov 2017 21:59:43 +0000 (21:59 +0000)]
[MC] Fix regression tests on Windows when git “core.autocrlf” is set to true.

Differential Revision: https://reviews.llvm.org/D39737

This is the second attempt to commit this. The test was broken on Linux in the first attempt.

llvm-svn: 318560

6 years agoFix coverage test on Windows bot
Reid Kleckner [Fri, 17 Nov 2017 21:55:23 +0000 (21:55 +0000)]
Fix coverage test on Windows bot

llvm-svn: 318559

6 years agoDon't use llvm/Config/config.h.
Rafael Espindola [Fri, 17 Nov 2017 21:40:38 +0000 (21:40 +0000)]
Don't use llvm/Config/config.h.

It is private to llvm. Instead use llvm/Config/llvm-config.h and check
LLVM_ON_UNIX. That is the same guard that clang uses before including
unistd.h.

llvm-svn: 318558

6 years agoAMDGPU: Move hazard avoidance out of waitcnt pass.
Matt Arsenault [Fri, 17 Nov 2017 21:35:32 +0000 (21:35 +0000)]
AMDGPU: Move hazard avoidance out of waitcnt pass.

This is mostly moving VMEM clause breaking into
the hazard recognizer. Also move another hazard
currently handled in the waitcnt pass.

Also stops breaking clauses unless xnack is enabled.

llvm-svn: 318557

6 years agoLoosen -Wempty-body warning
Reid Kleckner [Fri, 17 Nov 2017 21:33:28 +0000 (21:33 +0000)]
Loosen -Wempty-body warning

Do not show it when `if` or `else` come from macros.
E.g.,

    #define USED(A) if (A); else
    #define SOME_IF(A) if (A)

    void test() {
      // No warnings are shown in those cases now.
      USED(0);
      SOME_IF(0);
    }

Patch by Ilya Biryukov!

Differential Revision: https://reviews.llvm.org/D40185

llvm-svn: 318556

6 years ago[llvm-profdata] Don't treat non-fatal merge errors as fatal
Vedant Kumar [Fri, 17 Nov 2017 21:18:32 +0000 (21:18 +0000)]
[llvm-profdata] Don't treat non-fatal merge errors as fatal

This fixes an issue seen on the coverage bot:
http://lab.llvm.org:8080/green/view/Experimental/job/clang-stage2-coverage-R/1930

Profile merging shouldn't fail if a single counter mismatch is detected.

llvm-svn: 318555

6 years ago[lldb] Ensure that dwo/dwp are not double-indexed
Alexander Shaposhnikov [Fri, 17 Nov 2017 20:50:54 +0000 (20:50 +0000)]
[lldb] Ensure that dwo/dwp are not double-indexed

DWO/DWP should not be indexed directly.
Instead, the corresponding base file should be used.
This diff adds an assert to DWARFCompileUnit::Index
and adjusts the methods
SymbolFileDWARF::FindCompleteObjCDefinitionTypeForDIE,
SymbolFileDWARF::GetObjCMethodDIEOffsets accordingly.

Differential revision: https://reviews.llvm.org/D39825

llvm-svn: 318554

6 years agollvm-demangle-fuzzer: Link in Support
Jonas Hahnfeld [Fri, 17 Nov 2017 20:46:55 +0000 (20:46 +0000)]
llvm-demangle-fuzzer: Link in Support

The refactoring in r318407 transiently includes abi-breaking.h
which defines EnableABIBreakingChecks. This breaks my Debug
build because this fuzzer did not link in Support with the symbol.

Differential Revision: https://reviews.llvm.org/D40190

llvm-svn: 318553

6 years ago[ObjC][ARC] Honor noescape attribute for -Warc-retain-cycles
Alex Lorenz [Fri, 17 Nov 2017 20:44:25 +0000 (20:44 +0000)]
[ObjC][ARC] Honor noescape attribute for -Warc-retain-cycles

rdar://35409566

Differential Revision: https://reviews.llvm.org/D40141

llvm-svn: 318552

6 years ago[LICM] Fix PR35342
Jun Bum Lim [Fri, 17 Nov 2017 20:38:25 +0000 (20:38 +0000)]
[LICM] Fix PR35342

Summary: This change fix PR35342 by replacing only the current use with undef in unreachable blocks.

Reviewers: efriedma, mcrosier, igor-laevsky

Reviewed By: efriedma

Subscribers: llvm-commits

Differential Revision: https://reviews.llvm.org/D40184

llvm-svn: 318551

6 years agoUse TempFile in the implementation of LockFileManager.
Rafael Espindola [Fri, 17 Nov 2017 20:06:41 +0000 (20:06 +0000)]
Use TempFile in the implementation of LockFileManager.

This move some of the complexity over to the lower level TempFile.

It also makes it a bit more explicit where errors are ignored since we
now have a call to consumeError.

llvm-svn: 318550

6 years ago[PM/Unswitch] Teach SimpleLoopUnswitch to do non-trivial unswitching,
Chandler Carruth [Fri, 17 Nov 2017 19:58:36 +0000 (19:58 +0000)]
[PM/Unswitch] Teach SimpleLoopUnswitch to do non-trivial unswitching,
making it no longer even remotely simple.

The pass will now be more of a "full loop unswitching" pass rather than
anything substantively simpler than any other approach. I plan to rename
it accordingly once the dust settles.

The key ideas of the new loop unswitcher are carried over for
non-trivial unswitching:
1) Fully unswitch a branch or switch instruction from inside of a loop to
   outside of it.
2) Update the CFG and IR. This avoids needing to "remember" the
   unswitched branches as well as avoiding excessively cloning and
   reliance on complex parts of simplify-cfg to cleanup the cfg.
3) Update the analyses (where we can) rather than just blowing them away
   or relying on something else updating them.

Sadly, #3 is somewhat compromised here as the dominator tree updates
were too complex for me to want to reason about. I will need to make
another attempt to do this now that we have a nice dynamic update API
for dominators. However, we do adhere to #3 w.r.t. LoopInfo.

This approach also adds an important principls specific to non-trivial
unswitching: not *all* of the loop will be duplicated when unswitching.
This fact allows us to compute the cost in terms of how much *duplicate*
code is inserted rather than just on raw size. Unswitching conditions
which essentialy partition loops will work regardless of the total loop
size.

Some remaining issues that I will be addressing in subsequent commits:
- Handling unstructured control flow.
- Unswitching 'switch' cases instead of just branches.
- Moving to the dynamic update API for dominators.

Some high-level, interesting limitationsV that folks might want to push
on as follow-ups but that I don't have any immediate plans around:
- We could be much more clever about not cloning things that will be
  deleted. In fact, we should be able to delete *nothing* and do
  a minimal number of clones.
- There are many more interesting selection criteria for which branch to
  unswitch that we might want to look at. One that I'm interested in
  particularly are a set of conditions which all exit the loop and which
  can be merged into a single unswitched test of them.

Differential revision: https://reviews.llvm.org/D34200

llvm-svn: 318549

6 years agoCOFF: Stop emitting a non-standard COFF symbol table into PEs.
Peter Collingbourne [Fri, 17 Nov 2017 19:51:20 +0000 (19:51 +0000)]
COFF: Stop emitting a non-standard COFF symbol table into PEs.

Now that our support for PDB emission is reasonably good, there is
no longer a need to emit a COFF symbol table.

Also fix a bug where we would fail to emit a string table for long
section names if /debug was not specified.

Differential Revision: https://reviews.llvm.org/D40189

llvm-svn: 318548

6 years agoAll .xdata sections are eligble for ICF
Reid Kleckner [Fri, 17 Nov 2017 19:50:10 +0000 (19:50 +0000)]
All .xdata sections are eligble for ICF

Summary:
Many small functions have identical unwind info because they push the
same sets of CSRs in the same order and have the same stack and prologue
size. The VC linker merges duplicate .xdata, and so should LLD.

This reduces the .xdata section size of clang.exe from 1.8MB to 94KB.

Reviewers: pcc, ruiu

Subscribers: llvm-commits

Differential Revision: https://reviews.llvm.org/D40160

llvm-svn: 318547

6 years agoEnable PDB generation with lld in asan and cfi tests on Windows.
Peter Collingbourne [Fri, 17 Nov 2017 19:49:41 +0000 (19:49 +0000)]
Enable PDB generation with lld in asan and cfi tests on Windows.

PDB emission now works well enough that we can rely on it for these
tests to pass.

Differential Revision: https://reviews.llvm.org/D40188

llvm-svn: 318546

6 years ago[CodeGen] Compute the objc EH vtable address point using inbounds GEP.
Ahmed Bougacha [Fri, 17 Nov 2017 19:46:47 +0000 (19:46 +0000)]
[CodeGen] Compute the objc EH vtable address point using inbounds GEP.

The object is provided by the objc runtime and is never visible in the
module itself, but even so, the address point we compute points into it,
and "+16" is guaranteed not to overflow.

This matches the c++ vtable IRGen.

Note that I'm not entirely convinced the 'i8*' type is correct here: at
the IR level, we're accessing memory that's outside the global object.
But we don't control the allocation, so it's not obviously wrong either.
But either way, this is only in a global initializer, so I don't think
it's going to be mucked with.  Filed PR35352 to discuss that.

llvm-svn: 318545

6 years ago[clangd] Release the old preamble before building a new one.
Ilya Biryukov [Fri, 17 Nov 2017 19:05:56 +0000 (19:05 +0000)]
[clangd] Release the old preamble before building a new one.

llvm-svn: 318544

6 years agoMIRParser: Avoid reading uninitialized memory on generic vregs
Justin Bogner [Fri, 17 Nov 2017 18:51:20 +0000 (18:51 +0000)]
MIRParser: Avoid reading uninitialized memory on generic vregs

If a vreg's bank is specified in the registers block and one of its
defs or uses also specifies the bank, we end up checking that the
RegBank is equal to diagnose conflicting banks. The problem comes up
for generic vregs, where we weren't fully initializing the VRegInfo
when parsing the registers block, so we'd end up comparing a null
pointer to uninitialized memory.

This fixes a non-deterministic failure when round tripping through MIR
with generic vregs.

llvm-svn: 318543

6 years ago[X86] Merge scheduling tests for SHLD/SHRD
Simon Pilgrim [Fri, 17 Nov 2017 18:35:49 +0000 (18:35 +0000)]
[X86] Merge scheduling tests for SHLD/SHRD

Reduces spsce used and makes it easier to compare the 2 values for the equivalent instructions

llvm-svn: 318541

6 years ago[ThinLTO] Remove too aggressive assertion in building function call graph.
Volodymyr Sapsai [Fri, 17 Nov 2017 18:28:05 +0000 (18:28 +0000)]
[ThinLTO] Remove too aggressive assertion in building function call graph.

The assertion was introduced in r317853 but there are cases when a call
isn't handled either as direct or indirect. In this case we add a
reference graph edge but not a call graph edge.

Reviewers: tejohnson

Reviewed By: tejohnson

Subscribers: mehdi_amini, inglorion, eraman, hiraditya, efriedma, llvm-commits

Differential Revision: https://reviews.llvm.org/D40056

llvm-svn: 318540

6 years ago[WebAssembly] Initial wasm linker implementation
Sam Clegg [Fri, 17 Nov 2017 18:14:09 +0000 (18:14 +0000)]
[WebAssembly] Initial wasm linker implementation

This linker backend is still a work in progress but is
enough to link simple programs including linking against
library archives.

Differential Revision: https://reviews.llvm.org/D34851

llvm-svn: 318539

6 years ago[AST] Partially revert r318341 to fix two broken tests on llvm-clang-x86_64-expensive...
Eugene Zelenko [Fri, 17 Nov 2017 18:09:48 +0000 (18:09 +0000)]
[AST] Partially revert r318341 to fix two broken tests on llvm-clang-x86_64-expensive-checks-win (NFC).

llvm-svn: 318538

6 years agoclang-format: remove trailing lines in lamdas and arrow functions.
Martin Probst [Fri, 17 Nov 2017 18:06:33 +0000 (18:06 +0000)]
clang-format: remove trailing lines in lamdas and arrow functions.

Summary:
clang-format already removes empty lines at the beginning & end of
blocks:

    int x() {

      foo();  // lines before and after will be removed.

    }

However because lamdas and arrow functions are parsed as expressions,
the existing logic to remove empty lines in UnwrappedLineFormatter
doesn't handle them.

This change special cases arrow functions in ContinuationIndenter to
remove empty lines:

    x = []() {

      foo();  // lines before and after will now be removed.

    };

Reviewers: djasper

Subscribers: klimek, cfe-commits

Differential Revision: https://reviews.llvm.org/D40178

llvm-svn: 318537

6 years ago[OPENMP] Codegen for `target simd` construct.
Alexey Bataev [Fri, 17 Nov 2017 17:57:25 +0000 (17:57 +0000)]
[OPENMP] Codegen for `target simd` construct.

Added codegen support for `target simd` directive.

llvm-svn: 318536

6 years agoTry to fix the windows build.
Rafael Espindola [Fri, 17 Nov 2017 17:46:39 +0000 (17:46 +0000)]
Try to fix the windows build.

llvm-svn: 318535

6 years agoUse TempFile in dsymutil.
Rafael Espindola [Fri, 17 Nov 2017 17:33:09 +0000 (17:33 +0000)]
Use TempFile in dsymutil.

I don't think there is any functionality change, but the code is
easier to understand IMHO.

llvm-svn: 318534

6 years agoRevert "[MC] Fix regression tests on Windows when git “core.autocrlf” is set to true."
Rafael Espindola [Fri, 17 Nov 2017 17:31:20 +0000 (17:31 +0000)]
Revert "[MC] Fix regression tests on Windows when git “core.autocrlf” is set to true."

This reverts commit r318528.

MC/AsmParser/preserve-comments-crlf.s fails on linux.

llvm-svn: 318533

6 years ago[CMake] Allow for Solaris ld -V output on stdout
Michal Gorny [Fri, 17 Nov 2017 17:12:14 +0000 (17:12 +0000)]
[CMake] Allow for Solaris ld -V output on stdout

In recent versions of Solaris 11.4 (previously 12), ld -V output went to
stdout instead of stderr. Since AddLLVM.cmake only expects it on stderr,
Solaris ld wasn't properly detected and options not understood by it are
passed during the build.

The following patch fixes this, allowing for both variants.

Tested on i386-pc-solaris2.11.4 (on top of D35755 which is needed for
proper Solaris support).

Patch by Rainer Orth.

Differential Revision: https://reviews.llvm.org/D39601

llvm-svn: 318532

6 years ago[AArch64] Adjust the cost model for Exynos M1 and M2
Evandro Menezes [Fri, 17 Nov 2017 16:42:15 +0000 (16:42 +0000)]
[AArch64] Adjust the cost model for Exynos M1 and M2

Improve the accuracy of the model by specifying the proper number of uops.

llvm-svn: 318531

6 years agoIndent code blocks so they are actually treated as such
Stephan Bergmann [Fri, 17 Nov 2017 16:34:36 +0000 (16:34 +0000)]
Indent code blocks so they are actually treated as such

llvm-svn: 318530

6 years agoFix skipping of flags in getClangStripDependencyFileAdjuster
Dave Lee [Fri, 17 Nov 2017 16:27:21 +0000 (16:27 +0000)]
Fix skipping of flags in getClangStripDependencyFileAdjuster

Summary:
The ArgumentsAdjuster returned from `getClangStripDependencyFileAdjuster` will
skip dependency flags, and also their associated values for those flags that
take an argument. This change corrects the handling of the `-MD` and `-MMD`
flags, which do not take an argument.

Reviewers: saugustine, klimek, alexshap

Reviewed By: alexshap

Subscribers: cfe-commits

Differential Revision: https://reviews.llvm.org/D40024

llvm-svn: 318529

6 years ago[MC] Fix regression tests on Windows when git “core.autocrlf” is set to true.
Zhen Cao [Fri, 17 Nov 2017 16:17:56 +0000 (16:17 +0000)]
[MC] Fix regression tests on Windows when git “core.autocrlf” is set to true.

Differential Revision: https://reviews.llvm.org/D39737

llvm-svn: 318528

6 years ago[OMPT] Fix inaccuracies in worksharing tests
Jonas Hahnfeld [Fri, 17 Nov 2017 15:26:44 +0000 (15:26 +0000)]
[OMPT] Fix inaccuracies in worksharing tests

These tests were failing rarely on my MacBook when there was some
activity in the background. Read: one of a thousand executions?

 * sections.c missed the sorting based on thread ids. This worked
   as long as the master thread finished its section before the
   worker thread started the second one but failed if the master
   thread was put to sleep by the OS.
 * The checks in single.c assumed that the master thread executes
   the single region which works most of the time because it is
   usually faster than the newly spawned worker thread.

Differential Revision: https://reviews.llvm.org/D39853

llvm-svn: 318527

6 years ago[AMDGPU][MC][GFX9][disassembler] Corrected decoding of op_sel_hi for v_mad_mix*
Dmitry Preobrazhensky [Fri, 17 Nov 2017 15:15:40 +0000 (15:15 +0000)]
[AMDGPU][MC][GFX9][disassembler] Corrected decoding of op_sel_hi for v_mad_mix*

See bug 35148: https://bugs.llvm.org//show_bug.cgi?id=35148

Reviewers: tamazov, SamWot, arsenm

Differential Revision: https://reviews.llvm.org/D39492

llvm-svn: 318526

6 years ago[clang-format] Add text proto filename detection
Krasimir Georgiev [Fri, 17 Nov 2017 15:10:49 +0000 (15:10 +0000)]
[clang-format] Add text proto filename detection

Summary: Adds text proto filename detection.

Reviewers: klimek

Reviewed By: klimek

Subscribers: cfe-commits

Differential Revision: https://reviews.llvm.org/D40120

llvm-svn: 318525

6 years ago[Support][CachePruning] Fix regression in pruning interval
Ben Dunbobbin [Fri, 17 Nov 2017 14:42:18 +0000 (14:42 +0000)]
[Support][CachePruning] Fix regression in pruning interval

Fixed broken comparison.
borked by: rL284966 (see: https://reviews.llvm.org/D25730).

Differential Revision: https://reviews.llvm.org/D40119

This is a second attempt to commit this.
The first attempt broke lld and gold tests that had been written against
the incorrect behaivour.

llvm-svn: 318524

6 years ago[clang-tidy] Fix an oversight after renaming a check
Gabor Horvath [Fri, 17 Nov 2017 12:28:58 +0000 (12:28 +0000)]
[clang-tidy] Fix an oversight after renaming a check

llvm-svn: 318523

6 years ago[clang-tidy] Add a check for undelegated copy of base classes
Gabor Horvath [Fri, 17 Nov 2017 12:23:30 +0000 (12:23 +0000)]
[clang-tidy] Add a check for undelegated copy of base classes

Finds copy constructors where the constructor don't call
the copy constructor of the base class.

```
class X : public Copyable {
    X(const X &other) {} // Copyable(other) is missing
};
```

Differential Revision: https://reviews.llvm.org/D33722

llvm-svn: 318522

6 years ago[gold] Fix broken thin LTO cache test NFC
Andrew Ng [Fri, 17 Nov 2017 12:00:57 +0000 (12:00 +0000)]
[gold] Fix broken thin LTO cache test NFC

Fix test as it is assuming that the cache pruning is always being
performed by default. Explicitly set prune interval to 0s to ensure
pruning is always performed.

llvm-svn: 318520

6 years ago[ELF] - Teach LLD to use information from .debug_str for error reporting.
George Rimar [Fri, 17 Nov 2017 11:57:47 +0000 (11:57 +0000)]
[ELF] - Teach LLD to use information from .debug_str for error reporting.

Recently we teached LLD to report line numbers for duplicate variables
definitions, though currently LLD is unable to do that for case when
strings are not built in .debug_info, but stored in .debug_str instead.
That is because out LLDDwarfObj does not handle .debug_str yet.
Patch fixes that.

Differential revision: https://reviews.llvm.org/D39542

llvm-svn: 318519

6 years ago[ELF] - Fix BB after r318516
George Rimar [Fri, 17 Nov 2017 11:39:26 +0000 (11:39 +0000)]
[ELF] - Fix BB after r318516

Test did not run under windows because uses zlib.

Content of section changed because now strings
merging is applied.

llvm-svn: 318518

6 years ago[nfc] Iwyu: forward-declare/include raw_ostream in zone algo
Philip Pfaffe [Fri, 17 Nov 2017 11:34:29 +0000 (11:34 +0000)]
[nfc] Iwyu: forward-declare/include  raw_ostream in zone algo

llvm-svn: 318517

6 years ago[ELF] - Allow applying SHF_MERGE optimization for relocatable output.
George Rimar [Fri, 17 Nov 2017 11:27:57 +0000 (11:27 +0000)]
[ELF] - Allow applying SHF_MERGE optimization for relocatable output.

This fixes PR35223.

Here I enabled SHF_MERGE section content merging for -r like
we do for regular linking.

Differential revision: https://reviews.llvm.org/D40026

llvm-svn: 318516

6 years agoImplement more accurate penalty & trade-offs while breaking protruding tokens.
Manuel Klimek [Fri, 17 Nov 2017 11:17:15 +0000 (11:17 +0000)]
Implement more accurate penalty & trade-offs while breaking protruding tokens.

For each line that we break in a protruding token, compute whether the
penalty of breaking is actually larger than the penalty of the excess
characters. Only break if that is the case.

llvm-svn: 318515

6 years agoUse llvm-config.h instead of config.h
Ilya Biryukov [Fri, 17 Nov 2017 10:09:02 +0000 (10:09 +0000)]
Use llvm-config.h instead of config.h

To fix standalone builds broken by r318411 (config.h is private to llvm).

llvm-svn: 318514

6 years agoIgnore -no-ctors-in-init-array.
Rui Ueyama [Fri, 17 Nov 2017 08:17:36 +0000 (08:17 +0000)]
Ignore -no-ctors-in-init-array.

Patch by dxf@google.com.

llvm-svn: 318513

6 years agoAdd a missing #include.
Rui Ueyama [Fri, 17 Nov 2017 08:17:21 +0000 (08:17 +0000)]
Add a missing #include.

llvm-svn: 318512

6 years ago[MinGW] Define __ARM_DWARF_EH__ for MinGW/ARM
Martin Storsjo [Fri, 17 Nov 2017 08:06:49 +0000 (08:06 +0000)]
[MinGW] Define __ARM_DWARF_EH__ for MinGW/ARM

Since SVN r318510, the MinGW/ARM configuration defaults to
dwarf exception handling.

Differential Revision: https://reviews.llvm.org/D39533

llvm-svn: 318511

6 years ago[ARM] Use dwarf exception handling on MinGW
Martin Storsjo [Fri, 17 Nov 2017 08:04:40 +0000 (08:04 +0000)]
[ARM] Use dwarf exception handling on MinGW

Enabling and using dwarf exceptions seems like an easier path
to take, than to make the COFF/ARM backend output EHABI directives.
Previously, no EH model was enabled at all on this target.

There's no point in setting UseIntegratedAssembler to false since
GNU binutils doesn't support Windows on ARM, and since we don't
need to support external assembler, we don't need to use register
numbers in cfi directives.

Differential Revision: https://reviews.llvm.org/D39532

llvm-svn: 318510

6 years ago[SelectionDAG] Allow custom vector widening through ReplaceNodeResults to handle...
Craig Topper [Fri, 17 Nov 2017 07:03:57 +0000 (07:03 +0000)]
[SelectionDAG] Allow custom vector widening through ReplaceNodeResults to handle nodes with chain outputs.

Previously we were assuming all results were vectors and calling SetWidenedVector, but if its a chain result we should just replace uses instead.

This fixes an error found by expensive checks after r318368.

llvm-svn: 318509

6 years ago[IRCE] Remove folding of two range checks into RANGE_CHECK_BOTH
Max Kazantsev [Fri, 17 Nov 2017 06:49:26 +0000 (06:49 +0000)]
[IRCE] Remove folding of two range checks into RANGE_CHECK_BOTH

The logic of replacing of a couple `RANGE_CHECK_LOWER + RANGE_CHECK_UPPER`
into `RANGE_CHECK_BOTH` in fact duplicates the logic of range intersection which
happens when we calculate safe iteration space. Effectively, the result of intersection of
these ranges doesn't differ from the range of merged range check.

We chose to remove duplicating logic in favor of code simplicity.

Differential Revision: https://reviews.llvm.org/D39589

llvm-svn: 318508

6 years agoChange path used in a test from r318503 to work on windows
Bruno Cardoso Lopes [Fri, 17 Nov 2017 04:26:07 +0000 (04:26 +0000)]
Change path used in a test from r318503 to work on windows

http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/13565

llvm-svn: 318507

6 years agoAMDGPU: Replace list of SMEM buffer opcodes
Matt Arsenault [Fri, 17 Nov 2017 04:18:26 +0000 (04:18 +0000)]
AMDGPU: Replace list of SMEM buffer opcodes

llvm-svn: 318506