platform/upstream/dotnet/runtime.git
5 years agoAddress PR feedback for nullability docs
Stephen Toub [Wed, 10 Apr 2019 16:51:50 +0000 (12:51 -0400)]
Address PR feedback for nullability docs

Commit migrated from https://github.com/dotnet/corefx/commit/99943e1060fcb45eae398a04076819e2939716dd

5 years agoFix docs on System.Text.Json.JsonElement.GetString
Paul Buonopane [Wed, 10 Apr 2019 14:10:36 +0000 (10:10 -0400)]
Fix docs on System.Text.Json.JsonElement.GetString

Commit migrated from https://github.com/dotnet/corefx/commit/ffd0ae699611a7b172408ebd96b52f6eec0ebe67

5 years agoCondition Utf8String package build on IsPrerelease flag
Levi Broderick [Wed, 10 Apr 2019 03:35:03 +0000 (20:35 -0700)]
Condition Utf8String package build on IsPrerelease flag

Commit migrated from https://github.com/dotnet/corefx/commit/5b6a71f295e5b7dcdff4fae98f1301c6a5772c7d

5 years agoFix official builds failing due to LinuxNoTest matrix being empty (dotnet/corefx...
Santiago Fernandez Madero [Tue, 9 Apr 2019 22:28:07 +0000 (15:28 -0700)]
Fix official builds failing due to LinuxNoTest matrix being empty (dotnet/corefx#36750)

Commit migrated from https://github.com/dotnet/corefx/commit/401436a3c0cfd48250bbf4d299d593397d49f0a8

5 years agoFix build breaks and undo package filtering
Eric St. John [Tue, 9 Apr 2019 19:17:52 +0000 (12:17 -0700)]
Fix build breaks and undo package filtering

Commit migrated from https://github.com/dotnet/corefx/commit/b67328f7ac17bd842a3f1b67bf969e03837f0c77

5 years agoDon't build UTF8String.Experimental in release/3.0
wtgodbe [Tue, 9 Apr 2019 18:35:29 +0000 (11:35 -0700)]
Don't build UTF8String.Experimental in release/3.0

Commit migrated from https://github.com/dotnet/corefx/commit/9fb566123fc1f4d5f662eee44847a2161933de5d

5 years agoRemoved netcoreappaot configuration from corefx (dotnet/corefx#36739)
Anirudh Agnihotry [Tue, 9 Apr 2019 21:07:31 +0000 (14:07 -0700)]
Removed netcoreappaot configuration from corefx (dotnet/corefx#36739)

* netcoreappaot-Windows_NT regex removed

* netcoreappaot-WebAssembly;\n regex removed

* netcoreappaot-Windows_NT-Debug;netcoreappaot-Windows_NT-Release;
regex removed

* netcoreappaot; regex removed

* netcoreappaot-Debug;netcoreappaot-Release; removed

* removing rest of occurences of netcoreappaot

* deleteing the netcoreappaot apicompat files

Commit migrated from https://github.com/dotnet/corefx/commit/e9d1a10ed1d38a8b1ed599b3b5be09b8349f8ea8

5 years agoCopy json dependency to test out dir (dotnet/corefx#36738)
Viktor Hofer [Tue, 9 Apr 2019 20:28:10 +0000 (22:28 +0200)]
Copy json dependency to test out dir (dotnet/corefx#36738)

Commit migrated from https://github.com/dotnet/corefx/commit/5bfb3d6e4e32e1cdb579c96cb1668710697d0383

5 years agoFix deserialize cache test (dotnet/corefx#36646)
Steve Harter [Tue, 9 Apr 2019 16:35:31 +0000 (09:35 -0700)]
Fix deserialize cache test (dotnet/corefx#36646)

Commit migrated from https://github.com/dotnet/corefx/commit/e3ec42fb156c0354aa4095b125f3f56c27d0ecf7

5 years agoAdd test for string.Concat(object) that ToString returns null (dotnet/corefx#36436)
Santiago Fernandez Madero [Tue, 9 Apr 2019 16:28:47 +0000 (09:28 -0700)]
Add test for string.Concat(object) that ToString returns null (dotnet/corefx#36436)

Commit migrated from https://github.com/dotnet/corefx/commit/f9c971097b9bea6206cc328188ee1fc3bc984fd1

5 years agoAdd more ArrayConverter tests and cleanup code (dotnet/corefx#36654)
Hugh Bellamy [Tue, 9 Apr 2019 15:51:19 +0000 (16:51 +0100)]
Add more ArrayConverter tests and cleanup code (dotnet/corefx#36654)

* Add more ArrayConverter tests and cleanup code

* Disable netfx test

Commit migrated from https://github.com/dotnet/corefx/commit/3f7071d66f563cc2f0d49d4c9be7dd538c0e24ae

5 years agoAdd more misc type converters tests (dotnet/corefx#36655)
Hugh Bellamy [Tue, 9 Apr 2019 15:47:39 +0000 (16:47 +0100)]
Add more misc type converters tests (dotnet/corefx#36655)

*  Add more misc type converters tests

* PR feedback

Commit migrated from https://github.com/dotnet/corefx/commit/e65153e07ff478d1e71ed54e6a8b8c6547bb884e

5 years agoAdd initial nullability annotations guidance (dotnet/corefx#36711)
Stephen Toub [Tue, 9 Apr 2019 14:58:04 +0000 (10:58 -0400)]
Add initial nullability annotations guidance (dotnet/corefx#36711)

* Add initial nullability annotations guidance

* Address PR feedback

Commit migrated from https://github.com/dotnet/corefx/commit/663af00ced6ba81a3a7715e6347270306c1bad52

5 years agoChange charsets to explicitly unicode in System.Drawing.Common (dotnet/corefx#36718)
Jeremy Koritzinsky [Tue, 9 Apr 2019 01:44:23 +0000 (18:44 -0700)]
Change charsets to explicitly unicode in System.Drawing.Common (dotnet/corefx#36718)

* Change charsets to explicitly unicode.

* Remove ActiveIssue.

Commit migrated from https://github.com/dotnet/corefx/commit/02d4a83f640a802ae34588579ba25e8d77ead8ac

5 years agoUpdating all types in System.Numerics.Vectors, minus Vector<T>, to use the readonly...
Tanner Gooding [Tue, 9 Apr 2019 00:18:02 +0000 (17:18 -0700)]
Updating all types in System.Numerics.Vectors, minus Vector<T>, to use the readonly members feature. (dotnet/corefx#36702)

Commit migrated from https://github.com/dotnet/corefx/commit/5023c2420a4145bcb560c4b8c57f4bb60cd6973f

5 years agoUpdate coding-style.md (dotnet/corefx#36695)
Milosz Kukla [Mon, 8 Apr 2019 23:54:36 +0000 (01:54 +0200)]
Update coding-style.md (dotnet/corefx#36695)

* Update coding-style.md

Removed info about corefx.vssettings since it was removed at https://github.com/dotnet/corefx/pull/35683

* Update coding-style.md

Commit migrated from https://github.com/dotnet/corefx/commit/7b320a0ad1ea83670f561a6ef9231916465bb4b4

5 years agoChanges required to use newGenfacadeModel (dotnet/corefx#36126)
Anirudh Agnihotry [Mon, 8 Apr 2019 23:01:30 +0000 (16:01 -0700)]
Changes required to use newGenfacadeModel (dotnet/corefx#36126)

* making corefx compatible with newGenfacadesTask

correcting the new runtime variable

updating genfacades version to latest

fixes uap build and removes extra seed ype preferences for uapaot

* adding build configuration, comments and updating genfacadwa version

* fixing build  for netcoreapaot

* removing netcoreappaot build from all configurations build

Commit migrated from https://github.com/dotnet/corefx/commit/52206f12e2a34b708f33304d9b076b4958fbaa5e

5 years agoUpdate APICompat Baselines (dotnet/corefx#36578)
William Godbe [Mon, 8 Apr 2019 22:40:41 +0000 (15:40 -0700)]
Update APICompat Baselines (dotnet/corefx#36578)

* Update APICompat Baselines

* Fix baslines for UAP/UAPAOT

* Fix baseline for UAPAOT

Commit migrated from https://github.com/dotnet/corefx/commit/9924aa7f049da3a902be5b70c9935dcc9fad0952

5 years agoAdd more Decimal constructor tests (dotnet/corefx#36668)
Hugh Bellamy [Mon, 8 Apr 2019 21:43:16 +0000 (22:43 +0100)]
Add more Decimal constructor tests (dotnet/corefx#36668)

Commit migrated from https://github.com/dotnet/corefx/commit/47d17e30dcbcdec64ec3b00a23145e20afbb048e

5 years agoRevert "Disable for coreclrdotnet/corefx#23583" (dotnet/corefx#36564)
Steve MacLean [Mon, 8 Apr 2019 21:13:58 +0000 (17:13 -0400)]
Revert "Disable for coreclrdotnet/corefx#23583" (dotnet/corefx#36564)

Commit migrated from https://github.com/dotnet/corefx/commit/090f99d94cd1fbcd8c3f9c67deeb53cd99f2d8ba

5 years agoadd Alpine ARM64 queue (dotnet/corefx#36548)
Tomas Weinfurt [Mon, 8 Apr 2019 20:44:07 +0000 (13:44 -0700)]
add Alpine ARM64 queue (dotnet/corefx#36548)

* try to add Alpine ARM64 queue

* remove extra line

* correct queue names

* update queues

* use open queue for CI

* final cleanup

* feedback from review

Commit migrated from https://github.com/dotnet/corefx/commit/37867bd2a298062b637ad7fcbe9bd19cda15326f

5 years agoImplement Serialization Guard - CoreFX portion
Morgan Brown [Mon, 8 Apr 2019 17:53:37 +0000 (10:53 -0700)]
Implement Serialization Guard - CoreFX portion

Consume Serialization Guard API in BinaryFormatter and Process.

Also includes Serialization Guard's tests.

Commit migrated from https://github.com/dotnet/corefx/commit/6ca16758a5d454c1f1b04975bf55f259dd71fc49

5 years agoDisable System.Drawing test (dotnet/corefx#36700)
Stephen Toub [Mon, 8 Apr 2019 16:45:00 +0000 (12:45 -0400)]
Disable System.Drawing test (dotnet/corefx#36700)

Commit migrated from https://github.com/dotnet/corefx/commit/c653c8966f9264470285bc7d54f7d439bee723c7

5 years ago Add support for trailing commas within Utf8JsonReader (dotnet/corefx#36690)
Ahson Khan [Mon, 8 Apr 2019 09:55:50 +0000 (02:55 -0700)]
 Add support for trailing commas within Utf8JsonReader (dotnet/corefx#36690)

* Add support for trailing commas with single-segment tests.

* Implement single-segment case and update tests.

* Update multi-segment path and add tests.

* Add more tests, add to state, and update rollback logic.

Commit migrated from https://github.com/dotnet/corefx/commit/87fdc75beacc76e02c8e572ae3b0613b418200eb

5 years agoAdd test for MemoryStream's buffer after Capacity reset (dotnet/corefx#36580)
Stephen Toub [Mon, 8 Apr 2019 03:19:33 +0000 (23:19 -0400)]
Add test for MemoryStream's buffer after Capacity reset (dotnet/corefx#36580)

Commit migrated from https://github.com/dotnet/corefx/commit/268812e10fe17e8177dc5ca680128b286207c82f

5 years ago[master] Update dependencies from dotnet/coreclr (dotnet/corefx#36596)
dotnet-maestro[bot] [Mon, 8 Apr 2019 01:21:44 +0000 (01:21 +0000)]
[master] Update dependencies from dotnet/coreclr (dotnet/corefx#36596)

* Update dependencies from https://github.com/dotnet/coreclr build 20190403.72

- Microsoft.NET.Sdk.IL - 3.0.0-preview4-27603-72
- Microsoft.NETCore.ILAsm - 3.0.0-preview4-27603-72
- Microsoft.NETCore.Runtime.CoreCLR - 3.0.0-preview4-27603-72

* Update dependencies from https://github.com/dotnet/coreclr build 20190404.75

- Microsoft.NET.Sdk.IL - 3.0.0-preview4-27604-75
- Microsoft.NETCore.ILAsm - 3.0.0-preview4-27604-75
- Microsoft.NETCore.Runtime.CoreCLR - 3.0.0-preview4-27604-75

* Update dependencies from https://github.com/dotnet/coreclr build 20190405.73

- Microsoft.NET.Sdk.IL - 3.0.0-preview5-27605-73
- Microsoft.NETCore.ILAsm - 3.0.0-preview5-27605-73
- Microsoft.NETCore.Runtime.CoreCLR - 3.0.0-preview5-27605-73

* Update dependencies from https://github.com/dotnet/coreclr build 20190406.72

- Microsoft.NET.Sdk.IL - 3.0.0-preview5-27606-72
- Microsoft.NETCore.ILAsm - 3.0.0-preview5-27606-72
- Microsoft.NETCore.Runtime.CoreCLR - 3.0.0-preview5-27606-72

* Fix argument name in Buffer.BlockCopy test

* Update StreamWriters tests for BaseStream dispose change

* Updated tests for new PtrToStringUTF8 behavior

Commit migrated from https://github.com/dotnet/corefx/commit/1d63519e16fdc298f79c23b0ea7f4e89013024c5

5 years agoPlumb CancellationToken through Socket.Receive/SendAsync (dotnet/corefx#36516)
Stephen Toub [Sun, 7 Apr 2019 20:51:29 +0000 (16:51 -0400)]
Plumb CancellationToken through Socket.Receive/SendAsync (dotnet/corefx#36516)

In .NET Core 2.1 we added overloads of Send/ReceiveAsync, and we proactively added CancellationToken arguments to them, but those tokens were only checked at the beginning of the call; if a cancellation request came in after that check, the operation would not be interrupted.

This PR plumbs the token through so that a cancellation request at any point in the operation will cancel that operation.  On Windows we register to use CancelIoEx to request cancellation of the specific overlapped operation on the specific socket.  On Unix we use the existing cancellation infrastructure already in place to support the existing custom queueing scheme.

Some caveats:
- On Windows, canceling a TCP receive will end up canceling all TCP receives pending on that socket, even when we request cancellation of a specific overlapped operation; this is just how cancellation works at the OS level, and there's little we can do about it.  It also shouldn't matter much, as multiple pending receives on the same socket are rare.
- If multiple concurrent receives or multiple concurrent sends are issued on the same socket, only the first will actually be cancelable.  This is because this implementation only plumbs the token through the SocketAsyncEventArgs-based code paths, not the APM based code paths, and currently when using the Task-based APIs, we use the SocketAsyncEventArgs under the covers for only one receive and one send at a time; other receives made while that SAEA receive is in progress or other sends made while that SAEA send is in progress will fall back to using the APM code paths.  This could be addressed in the future in various ways, including a) just using the SAEA code paths for all operations and deleting the APM fallback, or b) plumbing cancellation through APM as well.  However, for now, this approach addresses the primary use case and should be sufficient.
- This only affects code paths to which the CancellationToken passed to Send/ReceiveAsync could reach.  If in the future we add additional overloads taking CancellationToken, we will likely need to plumb it to more places.

Commit migrated from https://github.com/dotnet/corefx/commit/2190a0ffbbc0af808b67e827abdaf01be4271aeb

5 years agoMoved Interop Locations For System.IO.Compression.Brotli (dotnet/corefx#36614)
Erhan Atesoglu [Sun, 7 Apr 2019 20:44:07 +0000 (13:44 -0700)]
Moved Interop  Locations For System.IO.Compression.Brotli (dotnet/corefx#36614)

* MovedInteropLocationForBrotli

* Combined Brotli Files

Commit migrated from https://github.com/dotnet/corefx/commit/e5fddbc1aee5215d988f8044be6d48b273286689

5 years agoSupport json deserialize of 'null' and 'bool' when declared type is typeof(object...
Steve Harter [Sat, 6 Apr 2019 03:56:20 +0000 (20:56 -0700)]
Support json deserialize of 'null' and 'bool' when declared type is typeof(object) (dotnet/corefx#36637)

* Support null and bool values for typeof(object)

* Remove support for bool

Commit migrated from https://github.com/dotnet/corefx/commit/35249a0072b41a89ce1542deacb2611c2393dec0

5 years agoAdd the TPM Object Identifiers to the static table in OidLookup
Jeremy Barton [Sat, 6 Apr 2019 03:02:12 +0000 (20:02 -0700)]
Add the TPM Object Identifiers to the static table in OidLookup

Experimentation suggests that these values are non-localized in Windows,
and are currently unmapped in OpenSSL; so they are good candidates for
static registration in OidLookup.

The TpmIdentifiers test passed on Windows Server 2012 R2 before the change,
to help prevent typos with registration.

Commit migrated from https://github.com/dotnet/corefx/commit/2862fae4f7686c0db8cddd26e7da05d0521e2c1d

5 years agoLabel implements IEquatable<Label> (dotnet/corefx#35673)
Foxtrek_64 [Sat, 6 Apr 2019 02:53:21 +0000 (21:53 -0500)]
Label implements IEquatable<Label> (dotnet/corefx#35673)

* Label implements IEquatable<Label>

* Add Unit Tests for IEquatable<Label>

* Actually track LabelEquals.cs this time

* Move Label IEquatable declaration to ILGeneration.netcore

* Merge IEquatable unit tests with existing equality tests

Commit migrated from https://github.com/dotnet/corefx/commit/b561cd457ccaf4fbf700a561e9581a4214315b81

5 years agoRemove Microsoft.Windows.Compatibility.Shims package (dotnet/corefx#36644)
Santiago Fernandez Madero [Sat, 6 Apr 2019 02:40:22 +0000 (19:40 -0700)]
Remove Microsoft.Windows.Compatibility.Shims package (dotnet/corefx#36644)

* Remove Microsoft.Windows.Compatibility.Shims package

* PR Feedback

Commit migrated from https://github.com/dotnet/corefx/commit/f61f49711b441a6650e6989f3c1be551732dd10f

5 years agoFix a race condition in a TaskStatusTest (dotnet/corefx#36645)
Vladimir Sadov [Sat, 6 Apr 2019 02:39:51 +0000 (19:39 -0700)]
Fix a race condition in a TaskStatusTest (dotnet/corefx#36645)

See:https://github.com/dotnet/coreclr/issues/20706

Commit migrated from https://github.com/dotnet/corefx/commit/d00fa24e3ee8f55c81589c4ba6841e5baf8cd646

5 years agoProvide a temporary RSA decryption buffer when dest is too small (dotnet/corefx#36601)
Jeremy Barton [Sat, 6 Apr 2019 02:37:38 +0000 (19:37 -0700)]
Provide a temporary RSA decryption buffer when dest is too small (dotnet/corefx#36601)

* Provide a temporary RSA decryption buffer when dest is too small

* Remove the semi-redundant second span variable

* Add tests to ensure that destination is not tainted when decryption fails

* Make Decrypt_WrongKey_OAEP_SHA256 conditional

Commit migrated from https://github.com/dotnet/corefx/commit/df5bba114e23afc4a3621917da0a1f810be19e7a

5 years agoMerge pull request dotnet/corefx#36636 from dotnet/MicrosoftPrivateCoreFxNETCoreAppLi...
Egor Chesakov [Fri, 5 Apr 2019 22:47:01 +0000 (15:47 -0700)]
Merge pull request dotnet/corefx#36636 from dotnet/MicrosoftPrivateCoreFxNETCoreAppLinuxMuslArm64

Add linux-musl-arm64 RID to Microsoft.Private.CoreFx.NETCoreApp

Commit migrated from https://github.com/dotnet/corefx/commit/9cc965f2f2da6284b933204810e710cf0e46db10

5 years agoMerge pull request dotnet/corefx#36634 from wtgodbe/Preview5
William Godbe [Fri, 5 Apr 2019 21:41:13 +0000 (14:41 -0700)]
Merge pull request dotnet/corefx#36634 from wtgodbe/Preview5

Update branding to preview5

Commit migrated from https://github.com/dotnet/corefx/commit/facd959f5c1cead92dba0b1eb2350c430b5b1630

5 years agoNegotiated ciphersuite (dotnet/corefx#35029)
Krzysztof Wicher [Fri, 5 Apr 2019 20:05:34 +0000 (13:05 -0700)]
Negotiated ciphersuite (dotnet/corefx#35029)

* NegotiatedCiphersuite implementation

* fix after merge conflict

* fix netfx

* add more expected Tls 1.0 ciphersuites (rfc5289)

* change TlsCipherSuite API to nullable

* apply self-feedback

* apply feedback

* Revert "change TlsCipherSuite API to nullable"

This reverts commit dotnet/corefx@c8bffccb5b368239be8529f3789a47f322754907.

* simplification around nullables

* msbuild /t:GenerateReferenceSource instead of copy & paste

* revert badly generated APIs

* fix codegen after moving tt files

* apply feedback

Commit migrated from https://github.com/dotnet/corefx/commit/f9fbe70f05b6ca89e94dcc91126d5fd4829a100e

5 years agoVarious cleanup and feedback (dotnet/corefx#36633)
David Fowler [Fri, 5 Apr 2019 18:50:09 +0000 (11:50 -0700)]
Various cleanup and feedback (dotnet/corefx#36633)

* Various cleanup and feedback
- Doc comments for options
- Added test coverage for StreamPipeWriterOptions
- Reset tailBufferedBytes to 0 in StreamPipeWriter.FlushAsync
- Use UnsafeRegister in FlushAsync

Commit migrated from https://github.com/dotnet/corefx/commit/0c8fa4e730f966ec923d3f623deb00dba8c431b4

5 years agoChange values of Microsoft.XmlSerializer.Generator command parameters through msbuild...
Jiayi [Fri, 5 Apr 2019 18:22:26 +0000 (11:22 -0700)]
Change values of Microsoft.XmlSerializer.Generator command parameters through msbuild properties (dotnet/corefx#36085)

* sgen properties

* set default value for sgen references

* a few changes according to feedback

* if rsp file is not generated, ignore it and use default settings

Commit migrated from https://github.com/dotnet/corefx/commit/f07612542d5d099489792192d6e05fdb21cf808d

5 years agoAdded ConfigureAwait(false) to the Stream.ReadAsync call (dotnet/corefx#36621)
David Fowler [Fri, 5 Apr 2019 17:46:09 +0000 (10:46 -0700)]
Added ConfigureAwait(false) to the Stream.ReadAsync call (dotnet/corefx#36621)

* Added ConfigureAwait(false) to the Stream.ReadAsync call
* Make tests less flaky

Commit migrated from https://github.com/dotnet/corefx/commit/f7adff5131e97cfcdfb76014e34101fd75c5340b

5 years agoAdd a timer test (dotnet/corefx#36576)
Koundinya Veluri [Fri, 5 Apr 2019 17:25:08 +0000 (10:25 -0700)]
Add a timer test (dotnet/corefx#36576)

Add a timer test

- Separated from https://github.com/dotnet/corefx/pull/35502
- Added test from https://github.com/dotnet/corert/pull/7069 to CoreFX

Commit migrated from https://github.com/dotnet/corefx/commit/c575bed77090d8e37b466197151acc3c36a959b6

5 years agoAdd linux-musl-arm64 RID to Microsoft.Private.CoreFx.NETCoreApp
Egor Chesakov [Fri, 5 Apr 2019 17:22:33 +0000 (10:22 -0700)]
Add linux-musl-arm64 RID to Microsoft.Private.CoreFx.NETCoreApp

Commit migrated from https://github.com/dotnet/corefx/commit/98fdcd739c157d502c718a8a8e67071902b7daef

5 years agoAdded PipeWriter.Create(stream) (dotnet/corefx#36620)
David Fowler [Fri, 5 Apr 2019 16:58:38 +0000 (09:58 -0700)]
Added PipeWriter.Create(stream) (dotnet/corefx#36620)

- Adds the ability to wrap an existing Stream in a PipeWriter to get the buffer management benefits.
- Added tests

Commit migrated from https://github.com/dotnet/corefx/commit/3c4cb0e96319e315e62aa92334f837cdd6d43aa6

5 years agoFix decoding surrogates on error (dotnet/corefx#36159)
buyaa-n [Fri, 5 Apr 2019 16:33:57 +0000 (09:33 -0700)]
Fix decoding surrogates on error (dotnet/corefx#36159)

Thank you @GrabYourPitchforks diggin into it and helping to find better solution

Some test falilures on Linux seems not related merging

Commit migrated from https://github.com/dotnet/corefx/commit/004b31d6f838b51cf28b359607d74644502979e1

5 years agoUpdate Compat pack version and use stable DataSetExtensions (dotnet/corefx#36615)
Eric StJohn [Fri, 5 Apr 2019 13:04:07 +0000 (06:04 -0700)]
Update Compat pack version and use stable DataSetExtensions (dotnet/corefx#36615)

Commit migrated from https://github.com/dotnet/corefx/commit/3108747ea756115c20dba8ea2285aa71eccfd026

5 years agoAdded PipeReader.Create(stream) (dotnet/corefx#36575)
David Fowler [Fri, 5 Apr 2019 05:12:07 +0000 (22:12 -0700)]
Added PipeReader.Create(stream) (dotnet/corefx#36575)

- Adds the ability to wrap an existing Stream in a PipeReader to get the buffer management benefits.
- Added tests

Commit migrated from https://github.com/dotnet/corefx/commit/dc965e16c4f71163df9de013951c95916992c908

5 years agoDisable Json serializer CacheTests since its failing on linux. (dotnet/corefx#36619)
Ahson Khan [Fri, 5 Apr 2019 04:05:43 +0000 (21:05 -0700)]
Disable Json serializer CacheTests since its failing on linux. (dotnet/corefx#36619)

Commit migrated from https://github.com/dotnet/corefx/commit/643daf90020831ea4022edff73471faf7163b87f

5 years agoAdd System Colors to ColorTable (dotnet/corefx#33520)
Egor Bogatov [Fri, 5 Apr 2019 03:10:38 +0000 (06:10 +0300)]
Add System Colors to ColorTable (dotnet/corefx#33520)

* Add system colors to ColorTable

* move SystemColors to System.Drawing.Primitives (from S.D.Common)

* Move SystemColors down to System.Drawing.Primitives

* PR Feedback

Commit migrated from https://github.com/dotnet/corefx/commit/7ccfaac21e6ec32caa5efcb144abe97432caad5b

5 years agoMove corefx builds out of temp pools (dotnet/corefx#36421)
Santiago Fernandez Madero [Thu, 4 Apr 2019 20:52:06 +0000 (13:52 -0700)]
Move corefx builds out of temp pools (dotnet/corefx#36421)

Commit migrated from https://github.com/dotnet/corefx/commit/871c5eae12ce339221ef0329009470c9945e34e5

5 years agoMerge pull request dotnet/corefx#34049 from Wraith2/sqlperf-rpc
Tarikul Sabbir [Thu, 4 Apr 2019 20:39:29 +0000 (13:39 -0700)]
Merge pull request dotnet/corefx#34049 from Wraith2/sqlperf-rpc

Optimize SqlClient rpc parameter usage

Commit migrated from https://github.com/dotnet/corefx/commit/5458fe268482522aa5681f001157ba7c0a451561

5 years agoConsume Microsoft.DotNet.XUnitConsoleRunner for netcoreapp (dotnet/corefx#36587)
Viktor Hofer [Thu, 4 Apr 2019 19:21:10 +0000 (21:21 +0200)]
Consume Microsoft.DotNet.XUnitConsoleRunner for netcoreapp (dotnet/corefx#36587)

* Consume Microsoft.DotNet.XUnitConsoleRunner

Commit migrated from https://github.com/dotnet/corefx/commit/9c177ab5c7e4c8ca32eba052416be208f422b5df

5 years agoMake Decrypt_WrongKey_OAEP_SHA256 conditional
Jeremy Barton [Thu, 4 Apr 2019 17:09:51 +0000 (10:09 -0700)]
Make Decrypt_WrongKey_OAEP_SHA256 conditional

Commit migrated from https://github.com/dotnet/corefx/commit/85f3729915071bc61e00c2f442501a8bb68c902e

5 years agoAvoid serializer multi-threaded cache issues (dotnet/corefx#36549)
Steve Harter [Thu, 4 Apr 2019 16:59:35 +0000 (09:59 -0700)]
Avoid serializer multi-threaded cache issues (dotnet/corefx#36549)

Commit migrated from https://github.com/dotnet/corefx/commit/3a4c464e80c17c3cd4b2e08358db7b457e187818

5 years agoAdd tests to ensure that destination is not tainted when decryption fails
Jeremy Barton [Thu, 4 Apr 2019 16:12:29 +0000 (09:12 -0700)]
Add tests to ensure that destination is not tainted when decryption fails

Commit migrated from https://github.com/dotnet/corefx/commit/fadcc8d7a244c44ab7eb63e55bd7657bfa559584

5 years agoRemove the semi-redundant second span variable
Jeremy Barton [Thu, 4 Apr 2019 16:11:34 +0000 (09:11 -0700)]
Remove the semi-redundant second span variable

Commit migrated from https://github.com/dotnet/corefx/commit/10db47189406410fb5ea6745afc885ad812f5b1f

5 years agoProvide a temporary RSA decryption buffer when dest is too small
Jeremy Barton [Thu, 4 Apr 2019 15:02:44 +0000 (08:02 -0700)]
Provide a temporary RSA decryption buffer when dest is too small

Commit migrated from https://github.com/dotnet/corefx/commit/d91e6ccfa7a0182a286088e4de7ec1eff1152be4

5 years agoEnable dotnet test by routing to /t:BuildAndTest (dotnet/corefx#36585)
Viktor Hofer [Thu, 4 Apr 2019 08:51:33 +0000 (10:51 +0200)]
Enable dotnet test by routing to /t:BuildAndTest (dotnet/corefx#36585)

Commit migrated from https://github.com/dotnet/corefx/commit/a4fe9d1599d3ba16534b19b92657cfaac80a65dd

5 years agolimit official build to two alpine releases and add Alpine 3.9 to CI (dotnet/corefx...
Tomas Weinfurt [Thu, 4 Apr 2019 05:58:25 +0000 (22:58 -0700)]
limit official build to two alpine releases and add Alpine 3.9 to CI (dotnet/corefx#36392)

* limit official build to two alpine relases and add Alpine 3.9 to CI as linux-musl sample

* remove quotes around friendly name - it seems escaping \'\(\' is enough.

* move musl_x64_Debug

* fix missing space

Commit migrated from https://github.com/dotnet/corefx/commit/184089d748b705438a117002143ebb4429ce0d97

5 years agoOSX can return ENODEV if we attempt tcgetattr() on stdin without terminal (dotnet...
Tomas Weinfurt [Thu, 4 Apr 2019 03:32:46 +0000 (20:32 -0700)]
OSX can return ENODEV if we attempt tcgetattr() on stdin without terminal (dotnet/corefx#36551)

* OSX can return ENODEV if we attempt tcgetattr() without terminal

* assume no tty if tcgetattr() fails

* feedback from review

Commit migrated from https://github.com/dotnet/corefx/commit/53c0bae174088c3653391be6cc3c74a1e1f353c1

5 years agoAdd additional feed to avoid random restore errors (dotnet/corefx#36569)
Viktor Hofer [Wed, 3 Apr 2019 22:55:19 +0000 (00:55 +0200)]
Add additional feed to avoid random restore errors (dotnet/corefx#36569)

* Add additional feed to avoid random restore errors

Commit migrated from https://github.com/dotnet/corefx/commit/1d8be0f47ba19e87cec4b063f8c406e1469550b7

5 years agoFix System.IO.Ports configurations and netfx build (dotnet/corefx#36565)
Viktor Hofer [Wed, 3 Apr 2019 21:22:38 +0000 (23:22 +0200)]
Fix System.IO.Ports configurations and netfx build (dotnet/corefx#36565)

* Fix System.IO.Ports configurations and netfx build

Commit migrated from https://github.com/dotnet/corefx/commit/e8fa62f1e396a3e07a4d4d8f5a86c6043a3a370b

5 years agoAdd DataTableExtensions.AsDataView (dotnet/corefx#36528)
Eric StJohn [Wed, 3 Apr 2019 19:53:46 +0000 (12:53 -0700)]
Add DataTableExtensions.AsDataView (dotnet/corefx#36528)

* Move most DataSetExtensions code to common

* Add DataTableExtensions.AsDataView

This pushes down the minimal number of types required to implement
DataTableExtensions.AsDataView.

LinqDataView is added in order to implement AsDataView, the following
types need to be pushed down in order to implement this:
 - DataSetUtil
 - DataTableExtensions
 - EnumerableRowCollection
 - SortExpressionBuilder

Moving thse down requires that the following also be moved due to needing
internals access to moved types.
 - EnumerableRowCollectionExtensions
 - OrderedEnumerableRowCollection
 - TypedTableBase
 - TypedTableBaseExtensions

* Add license to LinqDataView.cs

* Add a couple simple AsDataView tests

* Move remaining types from DataSetExtensions to Common

* Clean up source. CR feedback.

* AsDataView test only NetCoreApp

* Make System.Data.DataSetExtensions inbox, remove package

We pushed all the types down into System.Data.Common, and the facade is
now inbox, so the package only remains meaningful to carry a netstandard2.0
implementation assembly.  This assembly is only applicable on older
netcoreapp versions, so rather than ship it from master we'll  service
it from the release/2.1 branch.

Commit migrated from https://github.com/dotnet/corefx/commit/770c50d6251009dee48c0481f3def171301639e4

5 years agoRemove native string layout checks for Auto since meaning of Auto is not the same...
Jeremy Koritzinsky [Wed, 3 Apr 2019 19:16:54 +0000 (12:16 -0700)]
Remove native string layout checks for Auto since meaning of Auto is not the same for Windows/Unix and the native layout is already tested in other unit tests. (dotnet/corefx#36571)

Commit migrated from https://github.com/dotnet/corefx/commit/8c1dfe17eaed2999ad89e7c66bb1254e1640dbd0

5 years agofix the existing api instead of adding a new one (dotnet/corefx#36552)
Sung Yoon Whang [Wed, 3 Apr 2019 03:21:45 +0000 (20:21 -0700)]
fix the existing api instead of adding a new one (dotnet/corefx#36552)

Commit migrated from https://github.com/dotnet/corefx/commit/355917229c2e5a35b8ea7f14d5d6de2455c5dc1b

5 years agoAvoid unnecessary SetLastError on PInvokes (dotnet/corefx#36544)
Jan Kotas [Tue, 2 Apr 2019 21:41:49 +0000 (14:41 -0700)]
Avoid unnecessary SetLastError on PInvokes (dotnet/corefx#36544)

These console PInvokes are used in nearly every app. Omitting unnecessary SetLastError
will save us from generating marshalling stub for them.

Commit migrated from https://github.com/dotnet/corefx/commit/ccb68c0602656cea9a2a33f35f54dccba9eef784

5 years agoUpdate issue-guide.md
Karel Zikmund [Tue, 2 Apr 2019 20:49:15 +0000 (13:49 -0700)]
Update issue-guide.md

Update System.Linq ownership

Commit migrated from https://github.com/dotnet/corefx/commit/a0e5918d0d1cf2e098f2d2d4bd902373f91fa239

5 years agoSupport for System.Diagnostics.Activity sampling. (dotnet/corefx#36340)
Vance Morrison [Tue, 2 Apr 2019 20:22:22 +0000 (13:22 -0700)]
Support for System.Diagnostics.Activity sampling.    (dotnet/corefx#36340)

* Initial implemenation

* Added Reference Assembly and tests.

* Fixed test error

* Fix verifier exception on Desktop

* Build Error Fix

* Fix build error rev 2.

* Fix build rev 3

* Fix build error rev 4

* Fix Build rev 5

* Fix Build rev 6

* remove whitespace

* Fix build errors rev 7

* Move code to fix build

* Fix Build rev 8

* Fixed spelling

* Fix build error caused by merge.

* Fix build rev 9

* added comment

* renamed based on API review

Commit migrated from https://github.com/dotnet/corefx/commit/43ca5e2aee8c4ada93ab30fc3fd34bb8f4c6224d

5 years agoFix typo
Christopher Costa [Tue, 2 Apr 2019 17:53:17 +0000 (10:53 -0700)]
Fix typo

Commit migrated from https://github.com/dotnet/corefx/commit/44f4102011e45bd4ac25f1c565f333302c2c3740

5 years agoFix System.Drawing.Tests.SystemFontsTests.SystemFont_Get_ReturnsExpected_WindowsNames...
Ganbarukamo41 [Tue, 2 Apr 2019 17:43:34 +0000 (18:43 +0100)]
Fix System.Drawing.Tests.SystemFontsTests.SystemFont_Get_ReturnsExpected_WindowsNames test for different locales (dotnet/corefx#36192)

* Add another native function, change SetLastError to false

* Fixed so it tests with appropriate test data according to user locale, tests for DefaultFont/DialogFont removed

* Remove unused native function

* Change non-ASCII characters to escape sequences

* Add a single space after the comment header

* Use nameof() instead of string literals for systemFontName

* Remove a using statement that has been added accidentally

* Include more detailed message when throwing an exception

Commit migrated from https://github.com/dotnet/corefx/commit/158cd903a64aa14b85d06b90ed2e8804c2f2eb11

5 years agoUpdate src folder
Viktor [Fri, 29 Mar 2019 17:15:10 +0000 (18:15 +0100)]
Update src folder

Commit migrated from https://github.com/dotnet/corefx/commit/817c36a05ef2d92e59ce6f5a37e2be50076361b3

5 years agoUse Microsoft.DotNet.RemoteExecutor
Viktor [Fri, 29 Mar 2019 12:15:45 +0000 (13:15 +0100)]
Use Microsoft.DotNet.RemoteExecutor

Commit migrated from https://github.com/dotnet/corefx/commit/a39f126f85bd045793b231a4df576dd71e0fa413

5 years agoCombine DbDataReaderExtensions.GetColumnSchema implementations and remove unused...
Wraith2 [Fri, 29 Mar 2019 11:18:14 +0000 (11:18 +0000)]
Combine DbDataReaderExtensions.GetColumnSchema implementations and remove unused facade

Closes dotnet/corefx#36235

Commit migrated from https://github.com/dotnet/corefx/commit/34d64f4817dacc1ad3d9b7428dfad01401797601

5 years agopull in new fedora images (dotnet/corefx#36537)
Tomas Weinfurt [Tue, 2 Apr 2019 16:31:25 +0000 (09:31 -0700)]
pull in new fedora images (dotnet/corefx#36537)

Commit migrated from https://github.com/dotnet/corefx/commit/5796efa5600f3720c356b72c358a7454278df691

5 years agoImplement escaped-character handling in Utf8JsonReader and JsonElement (dotnet/corefx...
Layomi Akinrinade [Tue, 2 Apr 2019 16:11:37 +0000 (12:11 -0400)]
Implement escaped-character handling in Utf8JsonReader and JsonElement (dotnet/corefx#36347)

* Implement escaped-character handling in (Try)GetDateTime(Offset) & (Try)GetGuid in Utf8JsonReader and JsonElement

This addresses https://github.com/dotnet/corefx/issues/36202.

* Address review comments

* Address more comments

* Simplify stackalloc logic

* Update fraction digit cap to 15

* Add (Try)GetGuid to JsonElement

* Address review feedback

* Add FormatException documentation

* Address review feedback

* Address review comments

Commit migrated from https://github.com/dotnet/corefx/commit/769c5ace33486fecb480c7bf0a572854c9f33375

5 years agofix "all configurations" build parameter (dotnet/corefx#36535)
Steven Kirbach [Tue, 2 Apr 2019 12:35:48 +0000 (05:35 -0700)]
fix "all configurations" build parameter (dotnet/corefx#36535)

looks like this changed at some point from "BuildAllConfigurations" to just "allconfigurations"

Commit migrated from https://github.com/dotnet/corefx/commit/aa3865a16e4b53a58414a99dc9fcaaee653f59e0

5 years agohandle multi-valued headers correctly (dotnet/corefx#35202)
Tomas Weinfurt [Tue, 2 Apr 2019 06:06:34 +0000 (23:06 -0700)]
handle multi-valued headers correctly (dotnet/corefx#35202)

* handle multi-valued headers correctly

* feedback from review

* enable SendAsync_UserAgent_CorrectlyWritten test for HTTP/2

* fix Cookie tests

* feedback from review and test updates

* udpdates from review

* fix itteration

* feedback from review

* remove Streamreader from LoopbackServer

* fix System.Net.WebSockets.Client tests

* feedback from review

* fix tests built for netstandard

* fix one more test

* feedback from review

* feedback from review

Commit migrated from https://github.com/dotnet/corefx/commit/85cec01822bc70fbc45a25001997b0c1e71b1d22

5 years agomoving PackUriHelper methods to S.IO.Packaging (dotnet/corefx#36493)
Steven Kirbach [Tue, 2 Apr 2019 00:08:41 +0000 (17:08 -0700)]
moving PackUriHelper methods to S.IO.Packaging (dotnet/corefx#36493)

* moving PackUriHelper methods to S.IO.Packaging

* moving registration of pack uri scheme to static constructor

* don't build system.io.packaging for netstandard1.3

APIs we use on Uri only exist in netstandard2

* responding to PR feedback and remove netstandard1.3 config

* adding back netstandard1.3 config

* remove system.linq reference

* fix exception message

* fixing whitespace and comment

Commit migrated from https://github.com/dotnet/corefx/commit/b07788d1f075ff46cc10a8bf61c602d8367301d0

5 years agostabilize Http2GetAsync_TrailerHeaders_TrailingHeaderNoBody test (dotnet/corefx#36534)
Tomas Weinfurt [Tue, 2 Apr 2019 00:05:51 +0000 (17:05 -0700)]
stabilize Http2GetAsync_TrailerHeaders_TrailingHeaderNoBody test (dotnet/corefx#36534)

Commit migrated from https://github.com/dotnet/corefx/commit/b0cbc1be82316f768c6d9876f3e566355a93df68

5 years agoAdd support for binding to COM objects in WPF (dotnet/corefx#36496)
Aaron Robinson [Mon, 1 Apr 2019 23:15:49 +0000 (16:15 -0700)]
Add support for binding to COM objects in WPF (dotnet/corefx#36496)

* Add support for binding to COM objects in WPF

Commit migrated from https://github.com/dotnet/corefx/commit/be2a1c4b62f8a7886792aaa361ca6b09d8aceaee

5 years agoModify Utf8JsonWriter to write DateTime(Offset) values with the smallest output that...
Layomi Akinrinade [Mon, 1 Apr 2019 23:15:21 +0000 (19:15 -0400)]
Modify Utf8JsonWriter to write DateTime(Offset) values with the smallest output that roundtrips (dotnet/corefx#35966)

* Modify Utf8JsonWriter to write DateTime(Offset) values with the smallest output that roundtrips

This change addresses https://github.com/dotnet/corefx/issues/34576.

We replace calls to `Utf8Formatter.TryParse`, which formats to the roundtrippable custom format "O", with internal formatting logic that:
- drops the fraction part of the output if the milliseconds part of the date is zero, else
- writes the fraction part up to 7 decimal places with no trailing zeros.

* Format to a stackalloc'd span and then trim it if necessary, then copy to the actual destination

* Address review feedback

* Re-merge trim implementation

* Use DivMod and correct buffer length checks

Commit migrated from https://github.com/dotnet/corefx/commit/6a0b0acf226c165c6b857de67c2200b01a4afd15

5 years agofixes to CurlHandler to pass on Alpine.39 Docker container (dotnet/corefx#36468)
Tomas Weinfurt [Mon, 1 Apr 2019 21:23:13 +0000 (14:23 -0700)]
fixes to CurlHandler to pass on Alpine.39 Docker container (dotnet/corefx#36468)

Fixes to curl to pass on Alpine.39 Docker container.

Fixes dotnet/corefx#36428

Commit migrated from https://github.com/dotnet/corefx/commit/105b70a2ee48cca52fef404449f350a4be485b40

5 years agoIntroduce new, simpler to use converter test base (dotnet/corefx#35100)
Hugh Bellamy [Mon, 1 Apr 2019 20:49:16 +0000 (04:49 +0800)]
Introduce new, simpler to use converter test base (dotnet/corefx#35100)

Commit migrated from https://github.com/dotnet/corefx/commit/9c39db8b96719e36bc7e0c1158e37db0b0f16c85

5 years agoMerge remote-tracking branch 'dotnet/master' into sqlperf-rpc
Wraith2 [Mon, 1 Apr 2019 20:47:16 +0000 (21:47 +0100)]
Merge remote-tracking branch 'dotnet/master' into sqlperf-rpc

Commit migrated from https://github.com/dotnet/corefx/commit/5b0018a2527717ac9cb2ecc41c71309853d52121

5 years agoAdd a few WaitHandle.WaitAny/All arg validation tests (dotnet/corefx#36512)
Stephen Toub [Mon, 1 Apr 2019 18:54:21 +0000 (14:54 -0400)]
Add a few WaitHandle.WaitAny/All arg validation tests (dotnet/corefx#36512)

* Add a few WaitHandle.WaitAny/All arg validation tests

* Disable tests on netfx

Commit migrated from https://github.com/dotnet/corefx/commit/4754d0270b2667ded4a4ff97f71210a8580b146b

5 years agopull in updated fedora image with ping (dotnet/corefx#36523)
Tomas Weinfurt [Mon, 1 Apr 2019 17:38:23 +0000 (10:38 -0700)]
pull in updated fedora image with ping (dotnet/corefx#36523)

Commit migrated from https://github.com/dotnet/corefx/commit/581fd675f61c8c6163ed0dc13aa3aeb05d64fc1e

5 years agoAdd polymorphic serialization support for typeof(object) (dotnet/corefx#36486)
Steve Harter [Mon, 1 Apr 2019 17:34:35 +0000 (10:34 -0700)]
Add polymorphic serialization support for typeof(object) (dotnet/corefx#36486)

Commit migrated from https://github.com/dotnet/corefx/commit/00663e8bf10580ef7b58712af8105a2341b1c8a3

5 years agoAdd TrailingHeaders support for HTTP/2 (dotnet/corefx#36128)
Tomas Weinfurt [Mon, 1 Apr 2019 16:18:23 +0000 (09:18 -0700)]
Add TrailingHeaders support for HTTP/2  (dotnet/corefx#36128)

* add trailing header tests for HTTP/2

* initial implementation

* more fixes and tests

* style cleanup

* feedback from review

* feedback from review

Commit migrated from https://github.com/dotnet/corefx/commit/57cb805d1fd7b7f602b6dc13a681cc8e726b15df

5 years agoFix SqlClient Kerberos on Linux (dotnet/corefx#36513)
David Shulman [Mon, 1 Apr 2019 04:17:07 +0000 (21:17 -0700)]
Fix SqlClient Kerberos on Linux (dotnet/corefx#36513)

This PR is a follow-up to PR dotnet/corefx#36329. In that previous PR, I changed to use the
GSS_C_NT_HOSTBASED_SERVICE format for the SPN. That requires using a '@' separator
character instead of a "/". I had assumed since System.Data.SqlClient was including
the source files from Common for SafeDeleteNegoContext.cs that it would have the
corresponding change to use the proper separator character. However, it appears that
the file was only included to get the project building. It was using a separate file
to calculate the SPN.

The customer requiring these fixes reported that Kerberos was working properly now
for HttpClient and NegotiateStream. But SqlClient was still broken.

This PR completes the fix so that SqlClient will work properly with Kerberos especially
in multiple domain/realm environments. This fix was manually tested in the enterprise
scenario test lab.

Commit migrated from https://github.com/dotnet/corefx/commit/78c4c8bea5121408b0b420c2aa029cdd992a0b26

5 years agoChange Write to fill the remaining Span (dotnet/corefx#36507)
David Fowler [Mon, 1 Apr 2019 00:19:30 +0000 (17:19 -0700)]
Change Write to fill the remaining Span (dotnet/corefx#36507)

- We made some changes to make the sizeHint a minimum instead of just a hint. This means that passing in a huge buffer could result in a heap allocation if the underlying impl cannot provide a pooled version (like in pipelines or something backed by any MemoryPool impl). Instead of asking for a single contiguous buffer of the remaining input size, just pass 0 as the sizeHint and let the underlying implementation return a buffer to use.

Commit migrated from https://github.com/dotnet/corefx/commit/2c1cf10610d8102e080b203ff396707eeced15bd

5 years agoLittle optimization for TakeLast (dotnet/corefx#36051)
Tomasz Romaszkiewicz [Sun, 31 Mar 2019 15:20:09 +0000 (17:20 +0200)]
Little optimization for TakeLast (dotnet/corefx#36051)

* Implement speed option for TakeLast

* Fix issues, improve Take.SizeOpt

* Remove redundant code.

* Fix redundant if statement case

* Take advantage of ICollection<T>.Count property

* Remove spaces

* Add checkups for non cheap GetCount()

* Renaming and getting rid of ICollection tests.

Commit migrated from https://github.com/dotnet/corefx/commit/50fc80c8023060d61a826b01733a93840018fe92

5 years agoBuild a JsonDocument from an already positioned Utf8JsonReader
Jeremy Barton [Sun, 31 Mar 2019 05:42:42 +0000 (22:42 -0700)]
Build a JsonDocument from an already positioned Utf8JsonReader

Commit migrated from https://github.com/dotnet/corefx/commit/af82fec3952c5d365bd6b26489d130ad320ebf1a

5 years agoConsole: toggle terminal echo based on presence of interactive child processes (dotne...
Tom Deseyn [Sun, 31 Mar 2019 00:28:18 +0000 (01:28 +0100)]
Console: toggle terminal echo based on presence of interactive child processes (dotnet/corefx#35621)

* Console: toggle terminal echo based on presence of interactive child processes

.NET applications echo characters during a Console.Read. By default,
Unix terminals echo characters as the user is typing them.

When a .NET Core application launches an interactive application (e.g. 'vi')
that application expects to find the terminal in an echoing state.

To make both work, corefx was disabling echo during Console.Read operations,
and turning it back on when the read is done.

This changes to echoing while there are interactive applications and not echoing
when there are none.

This means we no longer need to toggle echo off/on for each Console.Read.
And the terminal will no longer echo when there is no Console.Read going on.

* Make some tcsetattr operations non-blocking

* Fix order between changing console settings and SetExited

* Fix unbalanced lock/unlocks

* Cache notty

* Prefer configuring the terminal for Console over child processes

* Update comments

* Rename some 'console' to 'terminal'

* Only decrement when child is using terminal

* Rename ConfigureTerminalForConsole back to In/UninitializeConsoleBefore/AfterRead

* Move some code to original place

* Add some extra comments

* PR feedback

* typo

Commit migrated from https://github.com/dotnet/corefx/commit/007571b90c3cc555cd30f3b467b87c22f9f665e0

5 years agoDisable for coreclrdotnet/corefx#23583
Steve MacLean [Sat, 30 Mar 2019 01:09:47 +0000 (21:09 -0400)]
Disable for coreclrdotnet/corefx#23583

Disable checks of AssemblyLoadContext.Assemblies
until dotnet/coreclrdotnet/corefx#23583 is fixed

Commit migrated from https://github.com/dotnet/corefx/commit/366dc2c0f2af8830fd7bdcbcc61685695a63e3ea

5 years agoAmend ALC tests
Steve MacLean [Thu, 28 Mar 2019 21:09:50 +0000 (17:09 -0400)]
Amend ALC tests

Add simple assertions to test:

Test new public constructor
Test instantiating AssemblyLoadContext as a concrete type
Test All
Test Name
Test ToString
Test Assemblies

Commit migrated from https://github.com/dotnet/corefx/commit/3db3261f39945567d818b10a562acf86d334e07a

5 years agoMove package testing to RS5 (less busy queue)
Santiago Fernandez Madero [Fri, 29 Mar 2019 21:33:58 +0000 (14:33 -0700)]
Move package testing to RS5 (less busy queue)

Commit migrated from https://github.com/dotnet/corefx/commit/512cde947d9e4345ef3bd5f75da0bc18b808b836

5 years agoAdd JsonElement.WriteAs{Property|Value}
Jeremy Barton [Fri, 29 Mar 2019 23:31:29 +0000 (16:31 -0700)]
Add JsonElement.WriteAs{Property|Value}

These methods allow sending a JsonElement to a Utf8JsonWriter, respecting its options for formatting the content.

Commit migrated from https://github.com/dotnet/corefx/commit/d3eed78a3765aef0325384c61a4593570ae3622b

5 years agoMerge pull request dotnet/corefx#34573 from Wraith2/sqlperf-envchange
Afsaneh Rafighi [Fri, 29 Mar 2019 22:43:54 +0000 (15:43 -0700)]
Merge pull request dotnet/corefx#34573 from Wraith2/sqlperf-envchange

SqlClient enviroment change optimization

Commit migrated from https://github.com/dotnet/corefx/commit/6977dddc03f8263ad82228558eb9b02e2e6f530c

5 years ago Moving the System.Runtime.Intrinsics.Arm namespace into System.Runtime.Intrinsics...
Tanner Gooding [Fri, 29 Mar 2019 21:47:04 +0000 (14:47 -0700)]
 Moving the System.Runtime.Intrinsics.Arm namespace into System.Runtime.Intrinsics.Experimental (dotnet/corefx#36466)

* Pulling the System.Runtime.Intrinsics.Arm namespace out of System.Runtime.Intrinsics

* Moving the System.Runtime.Intrinsics.Arm namespace into System.Runtime.Intrinsics.Experimental

* Adding an entry for S.R.I.Experimental to the pkg/descriptions.json

* Adding a project reference from S.R.I.Experimental to S.R.Intrinsics

* Adding IgnoreTypes entries for the System.Runtime.Intrinsics.Arm.Arm64 namespace

Commit migrated from https://github.com/dotnet/corefx/commit/84e89f69c7f00e44bae5d960784bbc829b6f8feb

5 years agoIncrease timeout for 2 socket option name tests (dotnet/corefx#36485)
Dan Moseley [Fri, 29 Mar 2019 21:40:55 +0000 (14:40 -0700)]
Increase timeout for 2 socket option name tests (dotnet/corefx#36485)

* Increase timeout for 2 socket option name tests

* More

Commit migrated from https://github.com/dotnet/corefx/commit/785423a8831f9b68aaa99cedf08df8f98439b434

5 years agoImprove StaticTestGenerator and fix some visibility (dotnet/corefx#36472)
Stephen Toub [Fri, 29 Mar 2019 21:40:05 +0000 (17:40 -0400)]
Improve StaticTestGenerator and fix some visibility (dotnet/corefx#36472)

Worked through a bunch of additional assemblies and fixed cases where StaticTestGenerator was doing the wrong thing.  Also fixed the visibility on a bunch of test methods it wasn't able to access.

Commit migrated from https://github.com/dotnet/corefx/commit/475542441df2f054d5e9aa39576019775a5d2f52