Colin Walters [Fri, 30 May 2008 15:14:46 +0000 (11:14 -0400)]
Bug 15588: Fix typo in #ifdef for userdb cache (Scott James Remnant)
* dbus/dbus-userdb-util.c, dbus/dbus-userdb.c: Correct name of
macro used in #ifdef block to match that defined by configure,
otherwise the userdb cache will never be enabled.
Colin Walters [Wed, 28 May 2008 20:01:22 +0000 (16:01 -0400)]
Bug 15947: Close file descriptors before execing helper (Markus Rechberger)
* dbus/dbus-sysdeps-unix.c (_dbus_get_autolaunch_address):
Close file descriptors before exec.
Thiago Macieira [Sat, 17 May 2008 08:11:20 +0000 (10:11 +0200)]
Merge branch 'dbus-1.2'
Thiago Macieira [Sat, 17 May 2008 08:09:20 +0000 (10:09 +0200)]
Prevent a crash in some applications due to timers leaking after the
DVusPendingCall object was freed.
* dbus-connection.c: Remove the timer for the pending call's timeout in
case the reply has timed out in blocking code. This fixes bug 15684.
John (J5) Palmieri [Wed, 16 Apr 2008 14:49:25 +0000 (10:49 -0400)]
take out trailing comma inside an enum so non gcc compilers don't error out
* tools/dbus-monitor.c: take out the trailing comma in the
ProfileAttributeFlags enum as it isn't in our style guides and causes
some compilers to error out
John (J5) Palmieri [Wed, 16 Apr 2008 14:49:25 +0000 (10:49 -0400)]
take out trailing comma inside an enum so non gcc compilers don't error out
* tools/dbus-monitor.c: take out the trailing comma in the
ProfileAttributeFlags enum as it isn't in our style guides and causes
some compilers to error out
John (J5) Palmieri [Fri, 4 Apr 2008 19:42:58 +0000 (15:42 -0400)]
up version for unstable development
John (J5) Palmieri [Fri, 4 Apr 2008 19:37:50 +0000 (15:37 -0400)]
getting ready for 1.2 stable branch
* ChangeLog.pre-1-2: rename ChangeLog
* NEWS.pre-1-2: rename NEWS
* Makefile.am: list the pre files in EXTRA_DIST; the pre-1-0 files had not
been added yet so do that too
John (J5) Palmieri [Fri, 4 Apr 2008 19:26:52 +0000 (15:26 -0400)]
bump version after release
John (J5) Palmieri [Fri, 4 Apr 2008 19:24:46 +0000 (15:24 -0400)]
Released 1.2.1
John (J5) Palmieri [Fri, 4 Apr 2008 19:15:22 +0000 (15:15 -0400)]
change version to 1.2.1 to prep release
* we are moving to the 1.2.x version scheme because re-licensing seems to be
blocked indefinitely
John (J5) Palmieri [Fri, 4 Apr 2008 18:58:07 +0000 (14:58 -0400)]
Revert "fix dbus-send so it can correctly send dictionaries"
This reverts commit
a689ef29f176110b0f74e47fd5dd1d2d6ad3dfd3.
Conflicts:
ChangeLog
* Turns out I reversed a patch that was alread committed but the bug had not
been closed. Since the patch was applied before I also reverted the
mention of Jérémie in the AUTHORS list mainly for license book keeping
sanity.
John (J5) Palmieri [Thu, 3 Apr 2008 20:08:40 +0000 (16:08 -0400)]
fix memleak due to autolaunch and recursive calls to _dbus_open_transport
* Patch from Sumit <sumitskj_20@yahoo.com>, comments added
* dbus/dbus-transport.c(_dbus_transport_open): fix mem leak
John (J5) Palmieri [Thu, 3 Apr 2008 17:15:45 +0000 (13:15 -0400)]
modify dbus_connection_send documentation
* dbus/dbus-connection.c (dbus_connection_send): add documentation
to describe when to call dbus_connection_flush and
dbus_connection_unref after a call to dbus_connection_send is made
Initial wording by Stanislav Brabec <sbrabec at suse.cz>
(fd.o bug#13558)
Jérémie Dimino [Thu, 3 Apr 2008 15:32:09 +0000 (11:32 -0400)]
fix dbus-send so it can correctly send dictionaries
* tools/dbus-send.c (append_dict): Send in signature when opening up
a dict entry container
* AUTHORS: Add Jérémie to AUTHORS file since it was a slightly above
trivial fix
Kimmo Hämäläinen [Thu, 3 Apr 2008 15:12:27 +0000 (11:12 -0400)]
fix expiration of pending replies
* bus/expirelist.c
(do_expiration_with_current_time): calculate correct min wait time
and next interval
(bus_expire_list_add, bus_expire_list_add_link): if the timeout is
disabled when we add an item to the expire list, enable the timeout
(do_expiration_with_current_time): only set timeout if there are
items to expire
John (J5) Palmieri [Thu, 3 Apr 2008 15:11:19 +0000 (11:11 -0400)]
Merge branch 'master' of git+ssh://johnp@git.freedesktop.org/git/dbus/dbus
Conflicts:
ChangeLog
Frederic Crozat [Tue, 1 Apr 2008 16:09:46 +0000 (18:09 +0200)]
Fixes for the inotify configuration file monitor backend.
2008-04-01 Timo Hoenig <thoenig@suse.de>
Patch from Frederic Crozat <fcrozat@mandriva.com>
* bus/dir-watch-inotify.c (bus_watch_directory): Only monitor
IN_CLOSE_WRITE, IN_DELETE, IN_MOVE_TO and IN_MOVE_FROM events. This
way, only atomic changes to configuration file are monitored.
* bus/dir-watch-inotify.c (_handle_inotify_watch): Fix typo in
_dbus_verbose function call
* bus/dir-watch-inotify.c (bus_drop_all_directory_watches): Use
_dbus_strerror instead of perror
Colin Walters [Mon, 31 Mar 2008 22:20:07 +0000 (18:20 -0400)]
Check for X11 events before selecting (FDO bug #15293)
Colin Walters [Mon, 31 Mar 2008 22:16:00 +0000 (18:16 -0400)]
Make sure we call XFlush() on all code paths (FDO bug #15293)
Havoc Pennington [Thu, 27 Mar 2008 20:52:40 +0000 (16:52 -0400)]
Do not provide a signature to dbus_message_iter_open_container() when opening a dict entry.
2008-03-27 Havoc Pennington <hp@redhat.com>
* tools/dbus-send.c (append_dict): Do not provide a signature to
dbus_message_iter_open_container() when opening a dict entry.
Colin Walters [Wed, 26 Mar 2008 14:28:40 +0000 (10:28 -0400)]
Set default exit_on_disconnect after registration
2008-03-26 Colin Walters <walters@verbum.org>
Patch from Scott James Remnant <scott@netsplit.com>
* dbus/dbus-bus.c: Set default exit_on_disconnect after registration with
the bus, not before. This ensures that programs which wish to set
exit_on_disconnect to FALSE will not be terminated if the bus exits
during registration. (FDO Bug #15112)
Havoc Pennington [Thu, 8 Nov 2007 22:51:15 +0000 (17:51 -0500)]
Make BusExpireList an opaque data type
2007-11-08 Havoc Pennington <hp@redhat.com>
* bus/connection.c, bus/expirelist.c: Make the BusExpireList
struct opaque, adding accessors for manipulating the list. In this
commit there should be no change in functionality or behavior. The
purpose of this change is to improve encapsulation prior to fixing
some bugs Kimmo Hämäläinen found where the timeout is not properly
updated, since we need to e.g. take some action whenever adding
and removing stuff from the expire list.
John (J5) Palmieri [Tue, 4 Mar 2008 18:21:05 +0000 (13:21 -0500)]
fix broken poll on Mac OSX - build patch by Benjamin Reed
* configure.in: check for OSX's deadlocking poll
* dbus/dbus-sysdeps-unix.c (_dbus_poll): if we have a broken poll
don't use poll
John (J5) Palmieri [Tue, 4 Mar 2008 18:09:07 +0000 (13:09 -0500)]
check if the linker supports a flag instead of just checking for GNU ld
* configure.in: move AM_PROG_LIBTOOL to the top
(ld_supports_flag): new function for checking if the linker supports
a given flag
John (J5) Palmieri [Tue, 4 Mar 2008 18:07:38 +0000 (13:07 -0500)]
add a changelog for Benjamin Reed's git patch (OS X build fixes)
* configure.in: Platform build fixes for Mac OS X
the Darwin linker does not understand the -z option; wrap it in
a check for $with_gnu_ld.
environ is only available at runtime, so you need to make a
reference to _NSGetEnviron instead for symbols to resolve properly.
Benjamin Reed [Mon, 28 Jan 2008 18:25:56 +0000 (13:25 -0500)]
Platform build fixes for Mac OS X
- the Darwin linker does not understand the -z option; wrap it in
a check for $with_gnu_ld.
- environ is only available at runtime, so you need to make a
reference to _NSGetEnviron instead for symbols to resolve properly.
John (J5) Palmieri [Tue, 4 Mar 2008 15:12:57 +0000 (10:12 -0500)]
configure.in: add $THREAD_LIBS to DBUS_LAUNCHER_LIBS so we link correctly
John (J5) Palmieri [Tue, 4 Mar 2008 15:03:14 +0000 (10:03 -0500)]
tools/dbus-launch.c: wrap X'ism in #ifdef so we can compile without X
John (J5) Palmieri [Thu, 28 Feb 2008 18:19:14 +0000 (13:19 -0500)]
Merge branch 'master' of git+ssh://johnp@git.freedesktop.org/git/dbus/dbus
John (J5) Palmieri [Thu, 28 Feb 2008 18:18:03 +0000 (13:18 -0500)]
define _AI_ADDRCONFIG if not defined so that we can compile with an older glibc
Ryan Lortie [Wed, 27 Feb 2008 21:21:12 +0000 (16:21 -0500)]
add 'tags' to .gitignore
John (J5) Palmieri [Tue, 26 Feb 2008 18:37:48 +0000 (13:37 -0500)]
Released 1.1.20
John (J5) Palmieri [Tue, 26 Feb 2008 18:30:47 +0000 (13:30 -0500)]
CVE-2008-0595 dbus security policy circumvention
* CVE-2008-0595 - security policy of the type <allow send_interface=
"some.interface.WithMethods"/> work as an implicit allow for
messages sent without an interface bypassing the default deny rules
and potentially allowing restricted methods exported on the bus to be
executed by unauthorized users. This patch fixes the issue.
* bus/policy.c (bus_client_policy_check_can_send,
bus_client_policy_check_can_receive): skip messages without an
interface when evaluating an allow rule, and thus pass it to the
default deny rules
John (J5) Palmieri [Tue, 26 Feb 2008 15:35:56 +0000 (10:35 -0500)]
correctly unref connections without guids during shutdown
* dbus/dbus-connection.c (close_connection_on_shutdown): new method
split out from shared_connections_shutdown
(shared_connections_shutdown): shutdown all shared connections
without guids
(_dbus_connection_ref_unlocked): handle OOM when prepending no guid
connections to the shared_connections_no_guid list
* Patch by Kimmo Hämäläinen <kimmo dot hamalainen at nokia dot com>
John (J5) Palmieri [Thu, 21 Feb 2008 18:42:06 +0000 (13:42 -0500)]
fix build against the latest gcc/glibc
* dbus/dbus-sysdeps-unix.c: define _GNU_SOURCE
* bus/selinux.c: include limits.h
* Patch by Matthias Clasen <mclasen at redhat.com>
John (J5) Palmieri [Thu, 21 Feb 2008 17:02:58 +0000 (12:02 -0500)]
fixes dbus-launch so the bus goes away when X does (Red Hat Bug #430412)
* tools/dbus-launch.c (main): set xdisplay = NULL
* Patch by Matthias Clasen <mclasen at redhat.com>
+
John (J5) Palmieri [Thu, 17 Jan 2008 20:21:50 +0000 (15:21 -0500)]
post-release bump
John (J5) Palmieri [Thu, 17 Jan 2008 20:20:25 +0000 (15:20 -0500)]
Release 1.1.4(1.2.0RC2)
John (J5) Palmieri [Thu, 17 Jan 2008 19:57:47 +0000 (14:57 -0500)]
fix inotify support
2008-01-17 Timo Hoenig <thoenig@suse.de>
* fix inotify support
* bus/dir-watch-inotify.c (_handle_inotify_watch): fix reading of the
inotify events. Also, use ssize_t not size_t for 'ret'.
* bus/dir-watch-inotify.c (bus_watch_directory): watch not only for
IN_MODIFY but also for IN_CREATE and IN_DELETE
* bus/dir-watch-inotify.c (bus_drop_all_directory_watches): drop the
inotify watches more elegantly by closing inotify:_fd, set inotify_fd to
-1 after dropping the watches
John (J5) Palmieri [Wed, 16 Jan 2008 00:54:46 +0000 (19:54 -0500)]
post-release version bump
John (J5) Palmieri [Wed, 16 Jan 2008 00:52:40 +0000 (19:52 -0500)]
Released 1.1.3 (1.2.0RC1)
John (J5) Palmieri [Tue, 15 Jan 2008 23:35:41 +0000 (18:35 -0500)]
fix HACKING to say git instead of cvs
John (J5) Palmieri [Tue, 15 Jan 2008 23:10:50 +0000 (18:10 -0500)]
wrap all_reader_classes[] in #ifndef DBUS_DISABLE_ASSERT (FDO Bug #9030)
2008-01-15 John (J5) Palmieri <johnp@redhat.com>
* patch by Sébastien Couret <10function at gmail dot com>
* dbus/dbus-marshal-recursive.c (all_reader_classes[]): wrap in
#ifndef DBUS_DISABLE_ASSERT since it is only used in asserts which
are noop
John (J5) Palmieri [Tue, 15 Jan 2008 22:21:52 +0000 (17:21 -0500)]
handle SASL EXTERNAL's inital empty responce (FDO Bug #9945)
2008-01-15 John (J5) Palmieri <johnp@redhat.com>
* patch by Magnus Henoch <henoch plus bfdo at dtek dot chalmers dot se>
* dbus/dbus-auth.c (handle_server_data_external_mech): handle SASL
EXTERNAL's inital empty responce (FDO Bug #9945)
John (J5) Palmieri [Tue, 15 Jan 2008 21:58:36 +0000 (16:58 -0500)]
add lsb headers to init script (FDO Bug #11491)
2008-01-15 John (J5) Palmieri <johnp@redhat.com>
* bus/messagebus.in: add lsb headers (FDO Bug #11491)
John (J5) Palmieri [Tue, 15 Jan 2008 21:51:30 +0000 (16:51 -0500)]
check write return value so we don't hang (FDO Bug #11665)
2008-01-15 John (J5) Palmieri <johnp@redhat.com>
* patch by Peter O'Gorman <pogma at thewrittenword dot com>
* dbus/dbus-spawn.c (babysit_signal_handler): check write return value
so we don't hang (FDO Bug #11665)
John (J5) Palmieri [Tue, 15 Jan 2008 21:43:46 +0000 (16:43 -0500)]
support for AIX poll implementation (FDO Bug #11666)
2008-01-15 John (J5) Palmieri <johnp@redhat.com>
* patch by Peter O'Gorman <pogma at thewrittenword dot com>
* dbus/dbus-sysdeps.h: support for AIX poll implementation (FDO Bug
#11666)
John (J5) Palmieri [Tue, 15 Jan 2008 21:23:54 +0000 (16:23 -0500)]
make shell script more portable (FDO Bug #11667)
2008-01-15 John (J5) Palmieri <johnp@redhat.com>
* tests/name-test/run-test.sh: make more portable (FDO Bug #11667)
John (J5) Palmieri [Tue, 15 Jan 2008 20:57:34 +0000 (15:57 -0500)]
don't check for < 0 on an unsigned variable (FDO Bug #12924)
2008-01-15 John (J5) Palmieri <johnp@redhat.com>
* patch by Kimmo Hämäläinen <kimmo dot hamalainen at nokia dot com>
* dbus/dbus-connection.c (_dbus_connection_get_next_client_serial):
don't check for < 0 on an unsigned variable (FDO Bug #12924)
John (J5) Palmieri [Tue, 15 Jan 2008 20:49:35 +0000 (15:49 -0500)]
check failed allocation (FDO Bug #12920)
2008-01-15 John (J5) Palmieri <johnp@redhat.com>
* patch by Kimmo Hämäläinen <kimmo dot hamalainen at nokia dot com>
* bus/bus.c (setup_server): check failed allocation (FDO Bug #12920)
John (J5) Palmieri [Tue, 15 Jan 2008 20:45:20 +0000 (15:45 -0500)]
the API contract says sitter_p can be NULL, so let's check it (FDO Bug #12919)
2008-01-15 John (J5) Palmieri <johnp@redhat.com>
* patch by Kimmo Hämäläinen <kimmo dot hamalainen at nokia dot com>
* dbus/dbus-spawn.c (_dbus_spawn_async_with_babysitter): the API
contract says sitter_p can be NULL, so let's check it (FDO Bug #12919)
John (J5) Palmieri [Tue, 15 Jan 2008 20:40:31 +0000 (15:40 -0500)]
use correct ssize_t type instead of size_t (FDO Bug #12862)
2008-01-15 John (J5) Palmieri <johnp@redhat.com>
* patch by Kimmo Hämäläinen <kimmo dot hamalainen at nokia dot com>
* dbus/dbus-spawn.c (read_ints, read_pid): use correct ssize_t type
instead of size_t (FDO Bug #12862)
John (J5) Palmieri [Tue, 15 Jan 2008 20:30:19 +0000 (15:30 -0500)]
make sure to call va_end if we hit an OOM error inside va_start (FDO Bug #12846)
2008-01-15 John (J5) Palmieri <johnp@redhat.com>
* patch by Kimmo Hämäläinen <kimmo dot hamalainen at nokia dot com>
* dbus/dbus-errors.c (dbus_set_error): make sure to call va_end if we
hit an OOM error inside va_start (FDO Bug #12846)
John (J5) Palmieri [Tue, 15 Jan 2008 20:23:57 +0000 (15:23 -0500)]
fix possible crash if pending_return is NULL (FDO Bug #12673)
2008-01-15 John (J5) Palmieri <johnp@redhat.com>
* patch by Kimmo Hämäläinen <kimmo dot hamalainen at nokia dot com>
* dbus/dbus-connection.c (dbus_connection_send_with_reply):
fix possible crash if pending_return is NULL (FDO Bug #12673)
John (J5) Palmieri [Tue, 15 Jan 2008 20:16:23 +0000 (15:16 -0500)]
never auto-select libxml
2008-01-15 John (J5) Palmieri <johnp@redhat.com>
* portions of patch submitted by Tim Mooney
<enchanter at users dot sourceforge dot net>
* configure.in: never auto-select libxml (FDO Bug #12479)
John (J5) Palmieri [Tue, 15 Jan 2008 19:43:19 +0000 (14:43 -0500)]
add OOM handling in various places
2008-01-15 John (J5) Palmieri <johnp@redhat.com>
* patches by Kimmo Hämäläinen <kimmo dot hamalainen at nokia dot com>
* dbus/dbus-sysdeps-unix (_dbus_get_autolaunch_address): handle OOM
(FDO Bug #12945)
* dbus/dbus-uuidgen.c (return_uuid): handle OOM (FDO Bug #12928)
* dbus/dbus-misc.c (dbus_get_local_machine_id): handle OOM, fix return
value to return NULL not FALSE (FDO Bug #12946)
John (J5) Palmieri [Tue, 15 Jan 2008 19:20:43 +0000 (14:20 -0500)]
rewrite selinux error handling to not abort due to a NULL read
2008-01-15 John (J5) Palmieri <johnp@redhat.com>
* bus/bus.c (bus_context_check_security_policy): rewrite selinux error
handling to not abort due to a NULL read and to set the error only if
it is not already set (Based off of FDO Bug #12430)
John (J5) Palmieri [Tue, 15 Jan 2008 18:53:54 +0000 (13:53 -0500)]
add OOM handling
2008-01-15 John (J5) Palmieri <johnp@redhat.com>
* patch by Kimmo Hämäläinen <kimmo dot hamalainen at nokia dot com>
* dbus/dbus-internals.c (_dbus_read_uuid_file_without_creating,
_dbus_create_uuid_file_exclusively): add OOM handling (FDO Bug #12952)
John (J5) Palmieri [Tue, 15 Jan 2008 18:46:50 +0000 (13:46 -0500)]
add error handling when polling (FDO Bug #12954)
2008-01-15 John (J5) Palmieri <johnp@redhat.com>
* patch by Kimmo Hämäläinen <kimmo dot hamalainen at nokia dot com>
* dbus/dbus-spawn.c (babysit, babysitter_iteration): add error
handling when polling (FDO Bug #12954)
John (J5) Palmieri [Tue, 15 Jan 2008 18:32:47 +0000 (13:32 -0500)]
remove dead code
2008-01-15 John (J5) Palmieri <johnp@redhat.com>
* patch by Kimmo Hämäläinen <kimmo dot hamalainen at nokia dot com>
* bus/config-parser.c (locate_attributes): remove dead code which
always evaluated to TRUE
* dbus/dbus-shell.c (_dbus_shell_quote): remove unused code
John (J5) Palmieri [Tue, 15 Jan 2008 00:04:41 +0000 (19:04 -0500)]
plug a possible BusClientPolicy leak (FDO Bug #13242)
2008-01-14 John (J5) Palmieri <johnp@redhat.com>
* patch by Kimmo Hämäläinen <kimmo dot hamalainen at nokia dot com>
* bus/connection.c (bus_connection_complete): plug a possible
BusClientPolicy leak (FDO Bug #13242)
John (J5) Palmieri [Tue, 15 Jan 2008 00:00:36 +0000 (19:00 -0500)]
add inotify support (FDO Bz#13268)
2008-01-14 John (J5) Palmieri <johnp@redhat.com>
* patch by Frederic Crozat <fcrozat at mandriva dot com> (FDO Bz#
13268)
* add inotify support
* bus/Makefile.am: add inotify module to the build
* bus/dir-watch-inotify.c: inotify module based off the dnotify and
kqueue modules
* configure.in: add checks and switch for inotify
also add a printout at the end of configure if inotify and kqueue
support is being built in (dnotify already had this)
John (J5) Palmieri [Mon, 14 Jan 2008 23:17:53 +0000 (18:17 -0500)]
watch for file creates in dnotify
2008-01-14 John (J5) Palmieri <johnp@redhat.com>
* patch by Frederic Crozat <fcrozat at mandriva dot com>
* bus/dir-watch-dnotify.c (bus_watch_directory): watch for file
creates also
John (J5) Palmieri [Mon, 14 Jan 2008 23:09:14 +0000 (18:09 -0500)]
return message loader buffer in case of OOM (FDO Bug#12666)
2008-01-14 John (J5) Palmieri <johnp@redhat.com>
* patch by Kimmo Hämäläinen <kimmo dot hamalainen at nokia dot com>
* dbus/dbus-transport-socket.c(do_reading): return message
loader buffer in case of OOM (FDO Bug#12666)
John (J5) Palmieri [Mon, 14 Jan 2008 20:53:13 +0000 (15:53 -0500)]
add warning to output when libxml is selected
2008-01-14 John (J5) Palmieri <johnp@redhat.com>
* configure.in: add warning to output when libxml is selected since
we don't have a libxml maintainer and expat works perfectly fine
for what we need an xml parser for
John (J5) Palmieri [Mon, 14 Jan 2008 20:07:48 +0000 (15:07 -0500)]
add _dbus_geteuid to fix EXTERNAL authentication in setuid applications
2008-01-14 John (J5) Palmieri <johnp@redhat.com>
* Patch by Andrea Luzzardi <scox at sig11 dot org>: creates a
_dbus_geteuid function to fix EXTERNAL authentication in setuid
applications
* dbus/dbus-sysdeps-unix.c (_dbus_geteuid): used to get the effective
uid of the running program
(_dbus_credentials_add_from_current_process): use geteuid instead of
getuid
(_dbus_append_user_from_current_process): use geteuid instead of
getuid
* dbus/dbus-sysdeps-util-unix.c (_dbus_change_to_daemon_user): use
geteuid instead of getuid
(_dbus_unix_user_is_at_console): use geteuid instead of getuid
* dbus/dbus-sysdeps-win.c (_dbus_geteuid): add a windows equivilant
that returns DBUS_UID_UNSET
Havoc Pennington [Tue, 18 Dec 2007 20:20:17 +0000 (15:20 -0500)]
fix some curly braces that were on the wrong line
2007-12-18 Havoc Pennington <hp@redhat.com>
* dbus/dbus-connection.c (_dbus_connection_block_pending_call):
fix location of curly braces
Sjoerd Simons [Fri, 23 Nov 2007 10:31:05 +0000 (11:31 +0100)]
Allow a normal session bus to be reused by applications using autolaunching
2007-11-23 Sjoerd Simons <sjoerd@luon.net>
* tools/dbus-launch.c: let both a normal dbus-launch and an
autolaunched bus save their parameters in X11 if possible. This makes
the autolaunch and non-autolaunch behaviour more similar. With the
exception that on a normal launch there will always be a new session
bus and not being able to save parameters is not fatal. This also
enables to launch programs directly with autolaunch (not very usefull
though).
Havoc Pennington [Wed, 31 Oct 2007 17:58:28 +0000 (13:58 -0400)]
Fix a problem where a nul byte was wrongly introduced into UUIDs, due to _dbus_string_copy_to_buffer weird behavior.
2007-10-31 Havoc Pennington <hp@redhat.com>
* bus/selinux.c (log_audit_callback): rewrite to use
_dbus_string_copy_to_buffer_with_nul()
* dbus/dbus-string.c (_dbus_string_copy_to_buffer): change to NOT
nul-terminate the buffer; fail an assertion if there is not enough
space in the target buffer. This fixes two bugs where
copy_to_buffer was used to copy the binary bytes in a UUID, where
nul termination did not make sense. Bug reported by David Castelow.
(_dbus_string_copy_to_buffer_with_nul): new function that always
nul-terminates the buffer, and fails an assertion if there is not
enough space in the buffer.
Havoc Pennington [Tue, 23 Oct 2007 18:48:52 +0000 (14:48 -0400)]
audit_init() was not declared in header, causing warnings; fix this and namespace it
2007-10-23 Havoc Pennington <hp@redhat.com>
* bus/bus.c (bus_context_new): use the new name here
* bus/selinux.c (bus_selinux_audit_init): rename from audit_init()
to avoid possible libc conflict, and declare it in .h file to
avoid a warning
Havoc Pennington [Fri, 19 Oct 2007 21:20:06 +0000 (17:20 -0400)]
add HAVE_SELINUX around call to audit_init() so things build without selinux
2007-10-19 Havoc Pennington <hp@redhat.com>
* bus/bus.c (bus_context_new): put audit_init() in HAVE_SELINUX
Havoc Pennington [Fri, 19 Oct 2007 19:05:27 +0000 (15:05 -0400)]
do not call audit_init() from bus/ directory from files in dbus/
2007-10-19 Havoc Pennington <hp@redhat.com>
* bus/bus.c (bus_context_new): put the audit_init() in here
instead, which I believe ends up being the same as where it was
before, though I'm not sure I understand why it goes here.
* dbus/dbus-sysdeps-util-unix.c (_dbus_change_to_daemon_user):
remove audit_init() from here, this file can't depend on code in
bus/ directory
Simon McVittie [Tue, 16 Oct 2007 09:13:15 +0000 (10:13 +0100)]
configure.in: *Actually* fix detection of i486 atomic ops.
My previous attempt at a fix would always enable them due to wrong quoting.
Patch from Colin Walters <walters@verbum.org>
Simon McVittie [Thu, 11 Oct 2007 16:29:40 +0000 (17:29 +0100)]
Amend ChangeLog - DBUS_ERROR_INIT is now used within libdbus as well as provided
Simon McVittie [Wed, 10 Oct 2007 10:41:57 +0000 (11:41 +0100)]
Use DBUS_ERROR_INIT instead of dbus_error_init wherever it's clearly equivalent
Simon McVittie [Thu, 11 Oct 2007 16:24:18 +0000 (17:24 +0100)]
Merge branch 'inline'
Simon McVittie [Thu, 11 Oct 2007 16:24:16 +0000 (17:24 +0100)]
Merge branch 'atomic'
Conflicts:
ChangeLog
Simon McVittie [Thu, 11 Oct 2007 09:56:12 +0000 (10:56 +0100)]
Add J5's recent changes to ChangeLog
Simon McVittie [Thu, 11 Oct 2007 09:38:01 +0000 (10:38 +0100)]
Update ChangeLog
Simon McVittie [Wed, 10 Oct 2007 10:39:22 +0000 (11:39 +0100)]
Rename DBUS_ERROR_INITIALIZER to DBUS_ERROR_INIT per Havoc's review
Simon McVittie [Tue, 9 Oct 2007 16:34:09 +0000 (17:34 +0100)]
Add DBUS_ERROR_INITIALIZER macro
Simon McVittie [Thu, 11 Oct 2007 09:27:28 +0000 (10:27 +0100)]
Enable Autoconf's AC_C_INLINE to avoid compilation failure with gcc -ansi.
If inline isn't recognised (e.g. on a strict C90 compiler, like gcc -ansi) this
defines it to __inline__, __inline or nothing, whichever works. This is safe,
because we never use inline except in combination with static.
Simon McVittie [Thu, 11 Oct 2007 09:20:09 +0000 (10:20 +0100)]
Update ChangeLog
Simon McVittie [Thu, 11 Oct 2007 09:18:05 +0000 (10:18 +0100)]
.gitignore: ignore vi swapfiles
Simon McVittie [Wed, 10 Oct 2007 12:37:00 +0000 (13:37 +0100)]
dbus-launch: convert C++-style comment to C-style, add {} for clarity
Simon McVittie [Wed, 10 Oct 2007 12:34:56 +0000 (13:34 +0100)]
dbus/dbus-server-socket.c: remove unused variable if disabling assertions
Simon McVittie [Wed, 10 Oct 2007 12:34:15 +0000 (13:34 +0100)]
dbus/dbus-marshal-validate.c: get rid of empty statements
Simon McVittie [Thu, 11 Oct 2007 09:11:21 +0000 (10:11 +0100)]
As per Havoc's review, rename DBUS_GNUC_EXTENSION to _DBUS_GNUC_EXTENSION.
Also update ChangeLog.
Simon McVittie [Wed, 10 Oct 2007 12:37:48 +0000 (13:37 +0100)]
dbus/dbus-arch-deps.h.in: also use DBUS_GNUC_EXTENSION for DBUS_INT64_CONSTANT and UINT64 equivalent
Simon McVittie [Wed, 10 Oct 2007 12:04:08 +0000 (13:04 +0100)]
Use DBUS_GNUC_EXTENSION to avoid -ansi -pedantic warnings about use of long long. (#717)
Simon McVittie [Wed, 10 Oct 2007 12:02:57 +0000 (13:02 +0100)]
Add macro DBUS_GNUC_EXTENSION (the same as GLib's G_GNUC_EXTENSION)
Part of a fix for bug 717.
Simon McVittie [Thu, 11 Oct 2007 08:57:48 +0000 (09:57 +0100)]
Fix detection of i486 atomic ops.
Previously, the attempts to determine support at compile-time on Darwin were
causing the i486 atomic ops to be used on *all* i386 or x86-64 GCC builds
(AH_VERBATIM can't be conditionalized like we were trying to).
Simon McVittie [Wed, 10 Oct 2007 16:39:41 +0000 (17:39 +0100)]
Merge branch 'master' of ssh://git.freedesktop.org/git/dbus/dbus
Simon McVittie [Wed, 10 Oct 2007 16:39:12 +0000 (17:39 +0100)]
Update ChangeLog
Simon McVittie [Wed, 10 Oct 2007 10:59:14 +0000 (11:59 +0100)]
Bring .gitignore files up to date; add *.o, *~ etc. to top-level .gitignore
CVS ignores these automatically, so they weren't in the .cvsignore when Ryan
converted the repository.
Simon McVittie [Wed, 10 Oct 2007 10:41:08 +0000 (11:41 +0100)]
Fix indentation in _dbus_object_tree_register declaration as per Havoc's review
Simon McVittie [Wed, 10 Oct 2007 10:40:48 +0000 (11:40 +0100)]
_dbus_object_tree_register: don't duplicate check for NULL and use new DBUS_ERROR_OBJECT_PATH_IN_USE error, both as per Havoc's review
Simon McVittie [Wed, 10 Oct 2007 10:38:34 +0000 (11:38 +0100)]
Add error o.fd.D.Error.ObjectPathInUse (DBUS_ERROR_OBJECT_PATH_IN_USE)
Simon McVittie [Tue, 9 Oct 2007 16:19:36 +0000 (17:19 +0100)]
Add dbus_connection_try_register_object_path and dbus_connection_try_register_fallback, to make object path registration less painful for bindings