dotnet-maestro [Wed, 17 Apr 2019 12:25:01 +0000 (12:25 +0000)]
Update dependencies from https://github.com/dotnet/arcade build
20190417.1
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19217.1
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19217.1
Michal Strehovský [Wed, 24 Apr 2019 13:24:31 +0000 (15:24 +0200)]
Fix ProjectN build breaks (dotnet/corert#7343)
Porting changes from the non-WinRT files.
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Bruce Forstall [Wed, 24 Apr 2019 18:59:52 +0000 (11:59 -0700)]
Merge pull request #24222 from BruceForstall/AddCorefxExclusions
Expand corefx exclusions
Bruce Forstall [Wed, 24 Apr 2019 18:58:38 +0000 (11:58 -0700)]
Expand corefx exclusions
Jeremy Koritzinsky [Wed, 24 Apr 2019 18:50:14 +0000 (11:50 -0700)]
Update IBCMerge and ensure that it runs when in a release build and ibcoptimize is set. (#24205)
* Update IBCMerge and ensure that it runs when in a release build and ibcoptimize is set.
* Add major rollforward for ibcmerge.
William Godbe [Wed, 24 Apr 2019 18:49:32 +0000 (11:49 -0700)]
Merge pull request #24206 from dotnet-maestro-bot/master-UpdateDependencies
Update CoreClr to preview6-27624-71 (master)
Bruce Forstall [Wed, 24 Apr 2019 17:22:28 +0000 (10:22 -0700)]
Merge pull request #24218 from BruceForstall/FixLinuxX64CorefxTesting
Remove extraneous percent character in Linux/x64 corefx testing command
Bruce Forstall [Wed, 24 Apr 2019 17:21:00 +0000 (10:21 -0700)]
Remove extraneous percent character in Linux/x64 corefx testing command
dotnet-maestro[bot] [Wed, 24 Apr 2019 14:52:26 +0000 (14:52 +0000)]
Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build
20190424.1 (#24214)
- optimization.IBC.CoreCLR - 99.99.99-master-
20190424.1
- optimization.PGO.CoreCLR - 99.99.99-master-
20190424.1
dotnet-maestro-bot [Wed, 24 Apr 2019 13:05:02 +0000 (06:05 -0700)]
Update CoreClr to preview6-27624-71
Jeremy Koritzinsky [Wed, 24 Apr 2019 05:01:47 +0000 (22:01 -0700)]
Match managed DetermineLibraryNameVariations implementation to native DetermineLibNameVariations implementation. (#24203)
* Match managed DetermineLibraryNameVariations implementation to native DetermineLibNameVariations implementation.
* Update AssemblyDependencyResolver.cs
* Use ordinal comparison instead of culture-specific comparison
Jan Kotas [Wed, 24 Apr 2019 03:21:09 +0000 (20:21 -0700)]
Delete unnecessary static and update GCSample to VS2019 (#24204)
Bruce Forstall [Tue, 23 Apr 2019 23:34:57 +0000 (16:34 -0700)]
Merge pull request #24201 from BruceForstall/AllowFineGrainedCorefxTestExclusions
Enable fine-grained and universal exclusions for CoreFX tests
dotnet-maestro-bot [Tue, 23 Apr 2019 23:28:07 +0000 (16:28 -0700)]
Update CoreClr to preview6-27623-73 (#24200)
Anirudh Agnihotry [Tue, 23 Apr 2019 22:39:32 +0000 (15:39 -0700)]
Revert "Dummy commit" (#24197)
Bruce Forstall [Tue, 23 Apr 2019 21:12:32 +0000 (14:12 -0700)]
Enable fine-grained and universal exclusions for CoreFX tests
One problem we've had in coreclr Jenkins when running corefx
tests (in the coreclr outerloop runs -- the ones using the
run-corefx-tests.py harness) is the inability to exclude
failing tests for x86 or x64, and the inability to have
fine-grained exclusions. This has led to problems like
https://github.com/dotnet/coreclr/issues/22442 where
virtually all Windows x86 and x64 corefx runs fail due to
timeouts. And issues like https://github.com/dotnet/coreclr/issues/24159
where all corefx test legs fail, and we have no control
over exclusions to get them all passing again quickly.
Now that the corefx RunTests.cmd/sh wrapper scripts
parse named arguments, including a response file that
is passed on to xunit, and also that the corefx used
xunit has support for this response file as well as
fine-grained exclusions (per-method/per-class/per-namespace),
we can take advantage of it.
This change adds a single, global, corefx xunit exclusion
response file, that will be used for all platforms. Since this
run-corefx-tests.py mechanism is not expected to live much longer,
this seems sufficient.
Tarek Mahmoud Sayed [Tue, 23 Apr 2019 20:58:54 +0000 (13:58 -0700)]
Fix failures caused by ICU regression (#24190)
Fixes https://github.com/dotnet/corefx/issues/37098
.NET Core depends on ICU when running on Linux/OSX. Recently some people raised some failure on the framework stack. After investigation we found a regression in ICU which is the root cause of this failure. The regression is, when calling ICU to get some date patterns/properties, in some cases ICU return error code U_MISSING_RESOURCE_ERROR. Although the framework code written to fallback to some invariant values at that time, but we had some wrong line of code which assumed we never fail and trying to access the returned value without checking. That cause the framework to throw NullReferenceException.
The fix here is to make the framework resilient against such cases and continue to run nicely. I have contact ICU support members and I learned there is similar issue tracked in ICU repo https://unicode-org.atlassian.net/browse/ICU-20558
Brian Sullivan [Tue, 23 Apr 2019 20:22:16 +0000 (13:22 -0700)]
Merge pull request #23932 from briansull/zero-offset-map
Fixes for tracking struct field sequences
Jan Vorlicek [Tue, 23 Apr 2019 20:14:58 +0000 (22:14 +0200)]
Fix crash after unload with server GC (#24196)
When server GC is on, the DomainAssembly::EnumStaticGCRefs is called to
enumerate GC statics. For collectible assemblies, the GC statics are
stored in managed arrays and so there is no need for a special
enumeration of the GC statics. Attempt to do that was causing a crash
due to the fact that the corresponding DomainLocalModule::m_pGCStatics
is always NULL for collectible assemblies and we were trying to access
it.
Anirudh Agnihotry [Tue, 23 Apr 2019 19:56:09 +0000 (12:56 -0700)]
Nullable : System.Diagnostics.Eventing (Directory) (#24192)
* Eventing directory done
* adding comment and fixing unix build
Michal Strehovský [Tue, 23 Apr 2019 19:18:25 +0000 (21:18 +0200)]
Add test coverage for static members on interfaces (#23928)
This has been supported since v1 but we don't have much test coverage.
C# is going to enable interfaces to have static members and static constructors so we better start testing it.
Anirudh Agnihotry [Tue, 23 Apr 2019 18:21:57 +0000 (11:21 -0700)]
Merge pull request #24195 from Anipik/temp
Dummy commit
Anipik [Tue, 23 Apr 2019 18:20:03 +0000 (11:20 -0700)]
Dummy commit
Brian Sullivan [Tue, 23 Apr 2019 17:00:42 +0000 (10:00 -0700)]
Added additional comment explaining ChnageOper(GT_LCL_FLD) and NotAField
dotnet-maestro[bot] [Tue, 23 Apr 2019 15:17:39 +0000 (08:17 -0700)]
[master] Update dependencies from dotnet/corefx (#24148)
- Microsoft.NETCore.Platforms - 3.0.0-preview6.19222.12
- Microsoft.Private.CoreFx.NETCoreApp - 4.6.0-preview6.19222.12
dotnet-maestro[bot] [Tue, 23 Apr 2019 15:16:36 +0000 (08:16 -0700)]
[master] Update dependencies from dnceng/internal/dotnet-optimization (#24150)
- optimization.IBC.CoreCLR - 99.99.99-master-
20190423.1
- optimization.PGO.CoreCLR - 99.99.99-master-
20190423.1
dotnet-maestro-bot [Tue, 23 Apr 2019 15:14:44 +0000 (08:14 -0700)]
Update CoreClr to preview6-27623-71 (#24152)
Stephen Toub [Tue, 23 Apr 2019 14:18:46 +0000 (10:18 -0400)]
Fix handling of negative numbers in ThreadPool.SetMin/MaxThreads (#24163)
* Fix handling of negative numbers in ThreadPool.SetMin/MaxThreads
* Fix disabled test name
Koundinya Veluri [Tue, 23 Apr 2019 06:31:37 +0000 (23:31 -0700)]
Implement APIs for some threading metrics (CoreRT) (dotnet/corert#7066)
* Implement APIs for some threading metrics (CoreRT)
- API review: https://github.com/dotnet/corefx/issues/35500
- May depend on https://github.com/dotnet/coreclr/pull/22754
* Use thread-locals for counting, use finalizer instead of runtime to detect thread exit
* Don't let the count properties throw OOM
* Remove some flushes
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Bruce Forstall [Mon, 22 Apr 2019 23:32:22 +0000 (16:32 -0700)]
Merge pull request #24176 from BruceForstall/Fix24175
Disable 2 GC tests under HeapVerify for arm64
Bruce Forstall [Mon, 22 Apr 2019 23:01:08 +0000 (16:01 -0700)]
Merge pull request #24174 from BruceForstall/Fix24172
Disable _il_relthread-race test under GCStress
Bruce Forstall [Mon, 22 Apr 2019 21:37:08 +0000 (14:37 -0700)]
Disable 2 GC tests under HeapVerify for arm64
They fail due to timeout with `COMPlus_HeapVerify=1` on arm64.
They were already being disabled for HeapVerify for x86 and arm32.
Fixes #24175
Bruce Forstall [Mon, 22 Apr 2019 20:07:14 +0000 (13:07 -0700)]
Disable _il_relthread-race test under GCStress
It takes too long, and times out in CI.
Fixes #24172
William Godbe [Mon, 22 Apr 2019 19:13:55 +0000 (12:13 -0700)]
Merge pull request #24168 from wtgodbe/p6
Update branding in master to preview6
wtgodbe [Mon, 22 Apr 2019 19:01:18 +0000 (12:01 -0700)]
Update branding in master to preview6
Steve MacLean [Mon, 22 Apr 2019 18:23:04 +0000 (14:23 -0400)]
Fix `CORE_LIBRARIES` doc
Sinan Kaya [Mon, 22 Apr 2019 17:09:21 +0000 (13:09 -0400)]
Correct iterator (#24160)
Russ Keldorph [Mon, 22 Apr 2019 12:48:33 +0000 (05:48 -0700)]
Disable failing IJW tests against #23358
Steve MacLean [Mon, 22 Apr 2019 14:07:13 +0000 (10:07 -0400)]
Remove create assembly name (#24154)
* Remove RuntimeAssembly.CreateAssemblyName
Fixes #24135
CreateAssemblyName was not compatible with AssemblyLoadContext isolation.
Assembly.Load(string)
Assembly.LoadWithPartialName(string)
Activator.CreateInstance(...)
* Remove unused AssemblyNameNative::Init arguments
* Temp disable corefx CreateInstanceAssemblyResolve
Carol Eidt [Mon, 22 Apr 2019 11:04:59 +0000 (04:04 -0700)]
Fix Arm64 UpperVector save/restore (#24043)
* Fix Arm64 UpperVector save/restore
Change the general handling of end-of-block restores so that we always have a RefPosition on which to allocate the register needed on Arm64.
Fix #23885
Steve MacLean [Sun, 21 Apr 2019 22:25:04 +0000 (18:25 -0400)]
Fix AssemblyName cache hash and key (#24138)
* Add ContextualReflection LoadWithPartialName case
* Remove unnecessary MethodImplOptions.NoInlining
* Remove m_assembly warning
* Fix AssemblyName hash function
* AssemblyNative::Load fix stackMark usage
Do not use the stackMark if (ptrLoadContextBinder != NULL)
* Temporarily disable DefaultContextOverrideTPA
Test is failing due to a logic error.
Fix is pending in https://github.com/dotnet/corefx/pull/37071
Yoh Deadfall [Sun, 21 Apr 2019 16:59:20 +0000 (19:59 +0300)]
Fixed link to .NET Core SDK (#24147)
dotnet-maestro-bot [Sun, 21 Apr 2019 03:37:21 +0000 (20:37 -0700)]
Update BuildTools, CoreClr to preview4-03917-01, preview5-27618-71, respectively (master) (#24060)
* Update BuildTools, CoreClr to preview4-03917-01, preview5-27618-71, respectively
* Fix build errors
* Disable warning with pragma and linked issue
dotnet-maestro[bot] [Sun, 21 Apr 2019 03:31:53 +0000 (20:31 -0700)]
[master] Update dependencies from dnceng/internal/dotnet-optimization (#24120)
- optimization.IBC.CoreCLR - 99.99.99-master-
20190420.1
- optimization.PGO.CoreCLR - 99.99.99-master-
20190420.1
dotnet-maestro[bot] [Sat, 20 Apr 2019 23:31:19 +0000 (19:31 -0400)]
Update dependencies from https://github.com/dotnet/corefx build
20190419.11 (#24141)
- Microsoft.NETCore.Platforms - 3.0.0-preview5.19219.11
- Microsoft.Private.CoreFx.NETCoreApp - 4.6.0-preview5.19219.11
Sung Yoon Whang [Sat, 20 Apr 2019 22:56:19 +0000 (15:56 -0700)]
Eventpipe Crst ordering fix (#24101)
* Adding PendingTypeLoadEntry to Crst order for EventPipeCrst
* update header file
Andrew Au [Sat, 20 Apr 2019 20:18:54 +0000 (13:18 -0700)]
Tighten asserts (#24124)
dotnet-maestro[bot] [Sat, 20 Apr 2019 20:15:49 +0000 (13:15 -0700)]
Update dependencies from https://github.com/dotnet/core-setup build
20190420.01 (#24142)
- Microsoft.NETCore.App - 3.0.0-preview5-27620-01
Sergey Andreenko [Sat, 20 Apr 2019 08:49:30 +0000 (01:49 -0700)]
Merge pull request #24131 from sandreenko/addAReproTest
Add a repro test for #24114.
Steve MacLean [Sat, 20 Apr 2019 06:07:42 +0000 (02:07 -0400)]
Fix Timezone whitespace (#24137)
Aaron Robinson [Sat, 20 Apr 2019 05:11:39 +0000 (22:11 -0700)]
The thread triggering finalizer shutdown events should be in an alertable state. (#24133)
Tanner Gooding [Sat, 20 Apr 2019 03:33:46 +0000 (20:33 -0700)]
Pulling in CoreFX changes and fixing up Sse2.StoreLow to be Sse2.StoreScalar (#24123)
* Update dependencies from https://github.com/dotnet/corefx build
20190419.5
- Microsoft.NETCore.Platforms - 3.0.0-preview5.19219.5
- Microsoft.Private.CoreFx.NETCoreApp - 4.6.0-preview5.19219.5
* Removing the Sse2.StoreLow(long/ulong*, ...) methods that have been replaced
* Moving the Sse2.StoreLow(long/ulong*, ...) tests to be Sse2.StoreScalar tests
* Fixing some existing usages of Sse2.StoreLow(long/ulong*, ...)
Koundinya Veluri [Sat, 20 Apr 2019 02:22:53 +0000 (19:22 -0700)]
Implement APIs for some threading metrics (CoreCLR) (#24113)
Implement APIs for some threading metrics (CoreCLR)
API review: https://github.com/dotnet/corefx/issues/35500
Sergey Andreenko [Fri, 19 Apr 2019 22:42:23 +0000 (15:42 -0700)]
Add a repro test.
Sergey Andreenko [Sat, 20 Apr 2019 01:05:58 +0000 (18:05 -0700)]
Merge pull request #24126 from sandreenko/fixStmtBug
Fix bug in impGetStructAddr.
Sergey Andreenko [Fri, 19 Apr 2019 22:49:39 +0000 (15:49 -0700)]
Fix `impGetStructAddr`.
Brian Sullivan [Sat, 20 Apr 2019 00:32:35 +0000 (17:32 -0700)]
Code review feedback
Sergey Andreenko [Sat, 20 Apr 2019 00:15:02 +0000 (17:15 -0700)]
Merge pull request #24127 from sandreenko/fixArmUbuntuCoreFXTesting
Fix Arm32 Ubuntu CoreFX script.
Brian Sullivan [Tue, 16 Apr 2019 16:52:11 +0000 (09:52 -0700)]
Fixes for Zero Offset field sequence tracking
- A GT_LCL_VAR may have a zeroOffset field
- Add an assert to prevent building field sequences with duplicates
- Fix fgMorphField when we have a zero offset field
Improve fgAddFieldSeqForZeroOffset
- Add JItDump info
- Handle GT_LCL_FLD
Changing the sign of an int constant also remove any field sequence information.
Added method header comment for fgAddFieldSeqForZeroOffset
Changed when we call fgAddFieldSeqForZeroOffset to be before the call to fgMorphSmpOp.
Prefer calling fgAddFieldSeqForZeroOffset() to GetZeroOffsetFieldMap()->Set()
Sergey Andreenko [Fri, 19 Apr 2019 23:15:34 +0000 (16:15 -0700)]
Fix Arm32 Ubuntu CoreFX script.
dotnet-maestro[bot] [Fri, 19 Apr 2019 22:49:32 +0000 (15:49 -0700)]
[master] Update dependencies from dotnet/corefx (#24058)
* Update dependencies from https://github.com/dotnet/corefx build
20190418.11
- Microsoft.NETCore.Platforms - 3.0.0-preview5.19218.11
- Microsoft.Private.CoreFx.NETCoreApp - 4.6.0-preview5.19218.11
* Disable outdated test
Mukul Sabharwal [Fri, 19 Apr 2019 21:54:35 +0000 (14:54 -0700)]
Large Pages on Linux & macOS (#24098)
Fadi Hanna [Fri, 19 Apr 2019 21:17:18 +0000 (14:17 -0700)]
Exclude failing tests on all platforms/architectures (#24121)
Fadi Hanna [Fri, 19 Apr 2019 21:10:09 +0000 (14:10 -0700)]
Fix project metadata in test (#24119)
* Fix project metadata in test
Russ Keldorph [Fri, 19 Apr 2019 13:35:55 +0000 (06:35 -0700)]
Remove commit triggered linux_arm ReadyToRun jobs
We don't have the capacity to run these on every commit
dotnet-maestro[bot] [Fri, 19 Apr 2019 16:10:22 +0000 (09:10 -0700)]
[master] Update dependencies from dotnet/core-setup (#24059)
Microsoft.NETCore.App - 3.0.0-preview5-27618-16
Andrew Wang [Fri, 19 Apr 2019 16:08:12 +0000 (09:08 -0700)]
Move CLR_ADDITIONAL_COMPILER_OPTIONS to be set after default options (#24044)
CLR_ADDITIONAL_COMPILER_OPTIONS was set before visibility settings and
thus adding additional compiler options would be overwritten.
Santiago Fernandez Madero [Fri, 19 Apr 2019 05:45:29 +0000 (22:45 -0700)]
Fix build errors in Interop.Errors
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Santiago Fernandez Madero [Fri, 19 Apr 2019 01:43:28 +0000 (18:43 -0700)]
Disable warning in ValueStringBuilder.ToString
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Aaron Robinson [Fri, 19 Apr 2019 16:05:23 +0000 (09:05 -0700)]
Block usage of default interfaces feature in COM scenarios (#23970)
* Block default interface usage in COM scenarios
Add additional test cases and move some CCW functions to a more
consolidated layout.
Michal Strehovský [Fri, 19 Apr 2019 13:59:52 +0000 (15:59 +0200)]
Look for IBC data outside Windows (#24062)
#23363 added a crossplat implementation of `GetWin32Resource`, but forgot to enable places that call it.
Krzysztof Wicher [Fri, 19 Apr 2019 01:37:37 +0000 (18:37 -0700)]
Nullable: couple of missing #nullable enable (#24094)
Stephen Toub [Fri, 19 Apr 2019 01:36:10 +0000 (21:36 -0400)]
Nullable: System.Collections.Concurrent (#24054)
Filip Navara [Fri, 19 Apr 2019 13:07:47 +0000 (15:07 +0200)]
Fix performance regression on glibc on Linux (#24099)
Jan Kotas [Fri, 19 Apr 2019 02:57:17 +0000 (19:57 -0700)]
Move R2R-specific code to be outside FEATURE_PREJIT (#24075)
This refactoring is preparation for disabling fragile NGen support in the runtime. It keeps fragile-NGen specific code under FEATURE_PREJIT and moves the code required to support R2R to be outside FEATURE_PREJIT.
The eventual goal is to compile the runtime without FEATURE_PREJIT defined to avoid fragile-NGen specific overhead.
Tanner Gooding [Fri, 19 Apr 2019 00:44:56 +0000 (17:44 -0700)]
Adding Sse2.StoreScalar(long*, V128) which will replace Sse2.StoreLow(long*, V128) (#24102)
Omair Majid [Fri, 19 Apr 2019 00:33:22 +0000 (20:33 -0400)]
Don't return value types as const (#24103)
These types are value types; they are returned by copying. Marking the
return type as const has no effect: since the value is copied, the
caller can modify it anyway.
This resolves all the -Wignored-qualifiers warnings produced by clang 7
(when those warnings are explicitly enabled).
Bruce Forstall [Thu, 18 Apr 2019 23:29:38 +0000 (16:29 -0700)]
Merge pull request #24105 from BruceForstall/ReduceLinuxArm32PeriodicJobs
Reduce the number of Linux arm32 periodic jobs triggered
Carol Eidt [Thu, 18 Apr 2019 23:05:34 +0000 (16:05 -0700)]
Allow UpperVector Save and Restore without base type (#24080)
Fixes an issue with crossgen on Arm64/linux
Bruce Forstall [Thu, 18 Apr 2019 22:45:05 +0000 (15:45 -0700)]
Reduce the number of Linux arm32 periodic jobs triggered
Only the corefx jobs are left. The rest should be done in AzDO,
and scheduling both AzDO and Jenkins is causing too much work
for the few machines we have.
Fadi Hanna [Thu, 18 Apr 2019 21:16:47 +0000 (14:16 -0700)]
Fix RVA field placement order (#24047)
* Static RVA fields should be placed sequentially after the qsort operation to not break Managed C++ binaries in R2R
* Add regression test
Jeremy Koritzinsky [Thu, 18 Apr 2019 20:49:36 +0000 (15:49 -0500)]
Disable native-client tests on IL round-trip (#24041)
José Rivero [Thu, 18 Apr 2019 20:18:26 +0000 (13:18 -0700)]
If IPC connections fails, then remove active session. (#24082)
Russ Keldorph [Thu, 18 Apr 2019 18:11:59 +0000 (11:11 -0700)]
Merge pull request #24071 from AndyAyersMS/Fix24055
JIT: fix arm64 crossgen simd issue
Omair Majid [Thu, 18 Apr 2019 17:36:25 +0000 (13:36 -0400)]
Add a destructor for sos::GCHeap (#24072)
The constructor allocates memory via new[]. It should be freed up via
delete[] by a destructor to avoid a memory leak.
Jan Vorlicek [Thu, 18 Apr 2019 15:42:30 +0000 (17:42 +0200)]
Merge pull request #23853 from jkoritzinsky/cmake-ninja-fix
Fix CMake warning about clrjit.exports.in file when using Ninja generator
Jan Vorlicek [Thu, 18 Apr 2019 14:53:57 +0000 (16:53 +0200)]
Merge pull request #24066 from janvorli/put-back-cpu-limits
Put back the CPU limiting in GC
Jan Kotas [Thu, 18 Apr 2019 14:13:33 +0000 (07:13 -0700)]
Skip type sanity checks for CoreLib (#24074)
Benjamin Bartels [Thu, 18 Apr 2019 12:53:22 +0000 (13:53 +0100)]
Fixed ChunkEnumerator.Current NRE (#24076)
* Fixed ChunkEnumerator.Current NRE
* Added Nullable Flow analysis annotation comment
* Changed TODO-NULLABLE comment to link to appropriate issue
Jan Vorlicek [Thu, 18 Apr 2019 08:27:27 +0000 (10:27 +0200)]
Merge pull request #23934 from franksinankaya/gcc_cleanup_18
Integer Conversion Issues from GCC
Santiago Fernandez Madero [Thu, 18 Apr 2019 01:17:55 +0000 (20:17 -0500)]
Merge pull request #23762 from dotnet/NullableFeature
Nullable feature into master
Andy Ayers [Thu, 18 Apr 2019 00:03:12 +0000 (17:03 -0700)]
another similar fix
Andrew Au [Wed, 17 Apr 2019 18:37:26 +0000 (11:37 -0700)]
Removing the unnecessary friend relationship
Brian Sullivan [Wed, 17 Apr 2019 22:23:02 +0000 (15:23 -0700)]
Merge pull request #24067 from briansull/desktop-fix2
Fix for Desktop build break
Brian Sullivan [Wed, 17 Apr 2019 22:21:03 +0000 (15:21 -0700)]
Added comment on #endif
Andy Ayers [Wed, 17 Apr 2019 21:32:07 +0000 (14:32 -0700)]
JIT: fix arm64 crossgen simd issue
Need to check `supportSIMDType()` and not `featureSIMD` in rationalize.
Fixes #24055.
Andy Ayers [Wed, 17 Apr 2019 21:23:11 +0000 (14:23 -0700)]
JIT: ignore pinning of non-gc types (#24010)
We may see pin modifiers on locals that are not gc types.
Ignore these modifiers.
Closes #23950.
Also added a missing copyright header on an unrelated test.
Santiago Fernandez Madero [Wed, 17 Apr 2019 20:10:13 +0000 (15:10 -0500)]
Fix StringBuilder annotations and debug.asserts (#24069)
Sung Yoon Whang [Wed, 17 Apr 2019 20:05:57 +0000 (13:05 -0700)]
Runtime counters naming change and setting default rates. (#24052)
* Renaming runtime counters and giving them DisplayNames
* fix build err
* Adding default DisplayRateTimeScale to runtime counters
Eugene Rozenfeld [Wed, 17 Apr 2019 19:59:31 +0000 (12:59 -0700)]
Restrict morph add rearrangement. (#23984)
Morph has transformations
((x + const) + y) => ((x + y) + const)
and
((x + const1) + (y + const2)) => ((x + y) + (const1 + const2))
If x or y is a GC pointer and one of the int operands may be negative,
this may result in a byref temp that points outside of the ref object.
If the code is in a non-interruptible region and a GC happens, the byref
won't be updated.
This change disallows the transformations if one of the non-const
operands is a GC pointer.
Fixes #23792.