Fix for Tizen BLE build

Changed CAWaitResult_t to OCWaitResult_t in tizen caleclient.c
to fix the build error.

Change-Id: I46881f5c0a496babae1bc5adcb05d630ac58024f
Signed-off-by: Veeraj Khokale <veeraj.sk@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12259
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Abhishek Sharma <ce.abhishek@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

modified SConscript for building arduino with tcp

Since arduino with WIFI shield does not support tcp,
build script should be closed expectedly.

Change-Id: Icad92654355153574ed5928922164366271946ec
Signed-off-by: Jaewook Jung <jw0213.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12193
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Habib Virji <habib.virji@samsung.com>
Reviewed-by: Abhishek Sharma <ce.abhishek@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

EasySetup Script files are changed to make static library.
Also mistyping is fixed in easysetup sample app.

Change-Id: I339a34a9d8eef0c69af7d9a3ba2388db073935c5
Signed-off-by: sy01.youn <sy01.youn@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12247
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>

Add generic APIs for set/get header option.

These APIs should be applicable for setting/getting
header option operations for version number and proxy-uri.

Bug: https://jira.iotivity.org/browse/IOT-1223
Change-Id: Ifd2d1b6ad30dff3a247c84b63d139c9552bfb32f
Signed-off-by: Ziran Sun <ziran.sun@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11161
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

Enable Tizen build for proxy

Change-Id: Id5a8091ae5d1544581bb9991e18d20dd5b67e292
Signed-off-by: Abhishek Sharma <ce.abhishek@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12207
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

Improve log message in tcpserver.

Added logging to check the remote device address for connection.

Change-Id: Ia4ed72ba227ba5a2e2f06f8120f144301291cfe9
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12117
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

Delete Client callback when receive observe cancel response.

Bug: https://jira.iotivity.org/browse/IOT-1317
Change-Id: I4e5ef2a1c848b963c036efe4ddf73dfd76b2b262
Signed-off-by: Ziran Sun <ziran.sun@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12055
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

Add option to create proxy as secured resource

Modify CHPInitialize() api to allow secured
mode. Also minor code formating optimizations.

Change-Id: I4041c506d8ce41769b9c55d4850d551fae87ad2e
Signed-off-by: Abhishek Sharma <ce.abhishek@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12071
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>

Add condition about provider initialize.

This patch include,
It added the code to verify that the provider is already started.

Second patch include,
modify invalid return type.

Change-Id: Ib3038f8cc2c74ab465a6178eac56d1f8e508a238
Signed-off-by: jaesick.shin <jaesick.shin@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12173
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: JungYong KIM <jyong2.kim@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Fix Jira issues (IOT-1338)

Change-Id: Id3949851748bbcf8a528b7e86a4b07a91fbcedab
Signed-off-by: Parkhi <h_w.park@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12189
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Fix Jira issues(IOT-1268)

Change-Id: Ifaf1708cbcf2f0b3f66ecc10b8d2ee389ddb723e
Signed-off-by: Parkhi <h_w.park@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12187
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Update a condition of security provisioning failures for timeout

A request of a kind of security provisioning like ownership transfer,
ACL provisioning, cert provisioning, is sent as a CON message which
has a retransmission. And if retransmission timeout happens, then
we can say the security provisioning is failed. Thus, when timeout error
code is arrived at its callback function, mediator has to inform an app of
its failure.

Change-Id: I2e89f27f01cc6b834f4f60d106ec834b4c0d4a51
Signed-off-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11991
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>

[IOT-1329] Include OCResetDevice in header

Include OCResetDevice in ocprovisioningmanager.h

Change-Id: I0f55e2503b0dc5bd809b64edc4f812c1d646cb9a
Signed-off-by: Jongmin Choi <jminl.choi@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12203
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>

tizen: Use 1/0 for booleans

To prevent ambuiguity of low/up/case.

Bug: https://jira.iotivity.org/browse/IOT-1295
Change-Id: Ic918e0c95f13462cab85ade3828e635f47ee7484
Origin: https://gerrit.iotivity.org/gerrit/#/c/12097/
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12145
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashwini Kumar <k.ashwini@samsung.com>

add darwin feature test for bits/atomic_base.h etc.

Change-Id: I2f0dc21a7f11f6f071f37f6dec78685ce89354ba
Signed-off-by: Gregg Reynolds <reynolds-gregg@norc.org>
Reviewed-on: https://gerrit.iotivity.org/gerrit/8491
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Hun-je Yeon <hunje.yeon@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

[IOT-1319] Resolved potential buffer overflow case

Change-Id: Ic5779a529085514a9269321c60770cd13c8fcd25
Signed-off-by: Randeep Singh <randeep.s@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12137
Reviewed-by: Greg Zaverucha <gregz@microsoft.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashwini Kumar <k.ashwini@samsung.com>

Only multicast case, set to Low of QoS.

Application can set QoS in unicast case.

Change-Id: I14658d90bf36a76e6f9beccc470edb9f75d75859
Signed-off-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12165
Reviewed-by: Jihun Ha <jihun.ha@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

fixed Cloud provisioning logic fault.

 - The issued is when credId & CloudId is not valid,
   Cloud provisioning is skipped.

   associate with https://gerrit.iotivity.org/gerrit/#/c/11909/

Change-Id: Ida3045047da0fe3082119a703360160f2d43fc53
Signed-off-by: Parkhi <h_w.park@samsung.com>
Signed-off-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12155
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Senthil Kumar G S <senthil.gs@samsung.com>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>

Support CAGetNetworkInformation API for TCP

Support CAGetNetworkInformation API for TCP to get
tcp address and port information from CA.

Change-Id: I6da57d85267c26bf605c6e9f8679d263076e637a
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11999
Reviewed-by: Dave Thaler <dthaler@microsoft.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

[IOT-1295] remove wrong step related Security in Tizen gbs build.

the stop related secure mode should not be trigerred by default.

Change-Id: I4cf684b4af392fdd5b428028ade1479066ae6809
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11623
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

[IOT-1332] support multi network state changed callback in base layer.

Change-Id: I1027bb11d276d1daceafea1673ceaa5f2d9b4411
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11505
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

provisioning: Fix type mismatch for sessionObject.expiresin

Failure to build was observed on Tizen:Common (armv7l):

  cloudAuth.cpp:127:59: error: cannot convert 'long int*' to 'int64_t* \
  {aka long long int*}' for argument '3' to \
  'bool OCRepPayloadGetPropInt(const OCRepPayload*, const char*, int64_t*)'

Change-Id: I3feaea196d91e22d29cc0a2b1d5fc859ecb6ea6c
Origin: https://gerrit.iotivity.org/gerrit/#/c/12049/
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12049
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Habib Virji <habib.virji@samsung.com>
(cherry picked from commit cdca139c2403d88e3cb92af30f4cfe15b5e6b9fa)
Reviewed-on: https://gerrit.iotivity.org/gerrit/12143
Reviewed-by: Ashwini Kumar <k.ashwini@samsung.com>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>

Solve build issue

https://gerrit.iotivity.org/gerrit/#/c/11331/
older g++  version support (4.6.4)

Change-Id: Icd8750bd622247f9c3086560350e0c0d46ca9f28
Signed-off-by: Ashwini Kumar <k.ashwini@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12009
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>

fixed android build fail with SECURED flag.

 associated with https://gerrit.iotivity.org/gerrit/#/c/11331/25

Change-Id: I7b2aa38167d5573bd9b845c1d2e604c9ec23a3f4
Signed-off-by: Parkhi <h_w.park@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12139
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashwini Kumar <k.ashwini@samsung.com>
Reviewed-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>

Add parsing logic for extraInfo in the NSMessage.

extraInfo formed OCRepPayload was added in the NSMessage structure.
So, related parsing logic is added in consumer service.

Change-Id: Id0c0038dd8082ca6edcc037847a984df8bdfca9d
Signed-off-by: KIM JungYong <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12005
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Updated ESResult which supports more detail on Android layer.

 - The patch is associated with "https://gerrit.iotivity.org/gerrit/#/c/11947/"

Change-Id: I9e20fbccef12678c6f70a27e167ac2d7fdff9b00
Signed-off-by: Parkhi <h_w.park@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12151
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Enable unit tests on Windows

* Add OCPlatformTest.cpp back into build process. Disabled specific tests
  that cause the delta in exception handling between Windows and Linux to
  be a problem. Replaced use of NULL with nullptr
* Add OCRepresentationEncodingTest.cpp back into build process
  only for cl.exe 14.0 (not 12.0)
* Add OCDevicePayloadCreate to octbstack_product.def
* Add OCByteStringCopy to octbstack_product.def
* Explanation:
On the Windows platform, certain exceptions are not being
caught by Gtests' EXPECT_ANY_THROW macro.
Specifically; on Windows, asynchronous structured exceptions
are not caught with C++'s try/catch exception handling. Unfortunately,
these tests raise asynchronous structured exceptions, and the result
is the unit tests crash instead of reporting a failure.

The two most common exception tests being disabled are:
1) Assigning a null pointer to a std::string
2) Indexing into an empty vector

For a specific example, where an asynchronous structured exception
is provoked, look at:
TEST(BindInterfaceToResourceTest, BindZeroResourceInterface)
inside of resource/unittests/OCPlatformTest.cpp

The tests could be refactored because both of
the operations causing the exceptions are not acceptable for the caller to
perform. Expecting anything afterward may be hazardous.
Furthermore, these tests just prove that the C++ documentation is
correct when it states that passing a null pointer to a std::string
constructor, or indexing into an empty vector is a bad idea.

"If s is a null pointer, if n == npos, or if the range specified by
[first,last) is not valid, it causes undefined behavior."
http://www.cplusplus.com/reference/string/string/string/#exceptions

"Portable programs should never call this function with an argument n
that is out of range, since this causes undefined behavior."
http://www.cplusplus.com/reference/vector/vector/operator[]/

Change-Id: If8dbdcb54d7a0fe22ca71fc8513eab413620beed
Signed-off-by: Daniel Ferguson <daniel.j.ferguson@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11783
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>

Add logic for extra Information.

This patch include,
1. Add extraInfo field in NSMessage.
2. Modify logic for related sendMessage.

second patch include,
modify setting Message payload.

third and fourth patch include,
add defence code for double free.

Change-Id: I2dcfaa9cf9bc0e42b1c0aaff83de99819433f01e
Signed-off-by: jaesick.shin <jaesick.shin@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11975
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Fix bug about NSProvider Config

the changes about wrong parameter input.

Change-Id: I25e4f864d5e5713c3fdd04aea56271ba14362f23
Signed-off-by: jaesick.shin <jaesick.shin@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12123
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>

[IOT-1309] Remove potential buffer overflow

Change-Id: I4804381daf85003929a2d8f96945b170083c2ab4
Signed-off-by: Randeep Singh <randeep.s@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12125
Reviewed-by: Greg Zaverucha <gregz@microsoft.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

Modified c++ provisioning to support cert provisioning

Change-Id: I98b41b2b65d4f3ee52e3cabdbe3fab35789f555b
Signed-off-by: Randeep Singh <randeep.s@samsung.com>
Signed-off-by: Ashwini Kumar <k.ashwini@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/10999
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

Fix warning codes

2 warnings are fixed.
1. warning implicit declaration of function
1. warning ignoring return value of 'scanf'

Change-Id: Id7e5caa3902b9a5b4be04b383b4ef54a2b8a68df
Signed-off-by: ch79.cho <ch79.cho@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12043
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Create build_linux_secure_with_tcp and cleanup build_android job

- build_linux_secure_with_tcp
  flag: SECURED=1, WITH_TCP=1, WITH_CLOUD=1
- clean up build_android
  place the android armeabi build job only
  TRANSPORT=All is applied which will verify all transports.

This will not affect currently running Jenkins build trigger.
So related yaml file should be modified for this change effective

Change-Id: Id77f4fb23d45316b876356ba9b1e062c9f1e7f79
Reviewed-on: https://gerrit.iotivity.org/gerrit/12019
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Update a condition to do ownership transfer in easy setup

In case that Only mediator's PDM db is deleted, ownership transfer SHOULD
be terminated.

Change-Id: I6513da5fb1bd56e7fb132da94fa6be40dbe2d7f6
Signed-off-by: Parkhi <h_w.park@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12003
Reviewed-by: Jihun Ha <jihun.ha@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>

Fixed bug for conditional in API.

Fixed bug for invalid compare.

Change-Id: I3396a4884a8691edf08364ea7e65dfbcd9514c6e
Signed-off-by: jaesick.shin <jaesick.shin@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12013
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Add unittest for negative case.

Add unittest for negative case in provider side.
and remove printf, cout.

Change-Id: I6fd7119e4cade3da6d87e85f0c8e1957f3bf0ce4
Signed-off-by: jaesick.shin <jaesick.shin@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12025
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Updated all of request using High QOS.

Change-Id: Icdb0805a29f6385900b22703cda2eb824330f0d6
Signed-off-by: Parkhi <h_w.park@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11963
Reviewed-by: Jihun Ha <jihun.ha@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>

Modify SRPSaveTrustCertChain

When saved CertCahin as PEM format in SVR_DB file, null termination is required.

Change-Id: Icdb15c447f91c42b98a665ed82c169052245e61e
Signed-off-by: js126.lee <js126.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11939
Reviewed-by: Jihun Ha <jihun.ha@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit 677e3b7e0e37f852be8a5c4e62d22b925f991ce1)
Reviewed-on: https://gerrit.iotivity.org/gerrit/12015
Tested-by: Randeep Singh <randeep.s@samsung.com>

Updated doxygen comment due to ESResult is changed

Change-Id: I1dbbb6fe36d05797a27cd80c4e21331390a7179b
Signed-off-by: Parkhi <h_w.park@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11967
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>

Allow multiple calls on OCResource::observe().

Remove check against m_observeHandle in OCResource::observe().
This will allow mutliple calls on observe with different query
parameters.

Bug: https://jira.iotivity.org/browse/IOT-1115
Change-Id: I1bae9e8db8999bf6e805eec75ebcbe9f4af8b3c7
Signed-off-by: Ziran Sun <ziran.sun@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11735
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Todd Malsbary <todd.malsbary@intel.com>
Reviewed-by: Habib Virji <habib.virji@samsung.com>

Remove WITH_CHPROXY flag for build cleanup

To minimize feature specific build flags,
removed proxy flag from base layer.

Change-Id: Ic3498e181209b31aa7d531f1eb6f86a2fc92ba54
Signed-off-by: Abhishek Sharma <ce.abhishek@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11937
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>

Fix memory leak in OCDoResource

OCDoResource was leaking the resourceUri when the presence enabled,
so this patch fixes the issue by freeing the resourceUri before
re-assigning the presence uri.

Change-Id: I2fc2a6c42e5079e67cc72a8be22803bf7157ad36
Signed-off-by: Sudarsana Nagineni <sudarsana.nagineni@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11145
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>

Check parsing response from cjson

Prevent crash if invalid json response received from server.

Change-Id: I339796be64ca4ec46d2e68a02b7f128a8c2fcdab
Signed-off-by: Abhishek Sharma <ce.abhishek@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11905
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>

Added client sample for proxy

Removed proxy changes from csdk sample and
added separate sample for proxy.

Change-Id: I45b31b46ee61eee7dd440dad0b2957345a75b1d0
Signed-off-by: Abhishek Sharma <ce.abhishek@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11869
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>

Updated ESResult which supports more detail.

 - ES_COMMUNICATION_ERROR
 - ES_ENROLLEE_DISCOVERY_FAILURE
 - ES_SECURE_RESOURCE_DISCOVERY_FAILURE
 - ES_OWNERSHIP_TRANSFER_FAILURE
 - ES_ACL_TRANSFER_FAILURE
 - ES_CERT_TRANSFER_FAILURE

Change-Id: I5f6afd5923d3b6c72c56b2cf726514823ff8d24a
Signed-off-by: Parkhi <h_w.park@samsung.com>
Signed-off-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11947
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>

Configure resource security

A provider is able to create the secured resources
if the provider config is set by enabling resource security.

Change-Id: I007c0e115e8cc2841ca7203994fa81c54a545276
Signed-off-by: cc <ch79.cho@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11729
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>
(cherry picked from commit 2a851346faa28b61abef56ef5bdbbeb48a67ccde)
Reviewed-on: https://gerrit.iotivity.org/gerrit/11929

yocto: Use tools from sysroot before system PATH

To ensure reproductibily Scons avoids to rely on environment
 but some systems like Yocto are defining their own cross compiling env.

To deal with those orthogonal paradigms,
 a new CONFIG_ENVIRONMENT_IMPORT variable has been introduced,
 It enables import of needed variables (PATH and pkg-config's ones).

Without this change, system tools might be used by scons
 instead of looking into yocto's sysroot.
 This is not not wanted and may be less reproductible.

This problem was noticed when building Ostro OS
 (on a system without all Yocto dependencies)
 reported error messages were:

  | sh: gdbus-codegen: command not found
  | /bin/sh: 1: pkg-config: not found

More information about using SCONS along Yocto, check some notes at:

https://bitbucket.org/scons/scons/wiki/Notes

Bug: https://jira.iotivity.org/browse/IOT-1219
Change-Id: I6af59a590f8be489398623d29cf85c2f568dd6a3
Origin: https://github.com/TizenTeam/iotivity/tree/sandbox/pcoval/on/master/mine
Thanks-to: Mikko Ylinen <mikko.ylinen@intel.com>
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11897
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Habib Virji <habib.virji@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Update consumer example for deselect topic.

Option of topic deselection is added in the consumer sample app.

Change-Id: Ia757cb141d94735d8a3666667af8839ac42f4584
Signed-off-by: KIM JungYong <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11927
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Updated Android Sample App for Notification provider.

1) Added option to start provider service with different acceptors.
2) Added registerTopic and setTopic option.
3) Updated UI.

Change-Id: I8373173a9d9274b458e3c15680831ada91b30fee
Signed-off-by: nikhil.a <nikhil.a7@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11907
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>

Added UI modifications and API testing code for Notification Service Consumer Sample.

patch 2 : updated the file name from review comments
patch 3 : removed dependencies from application

Change-Id: Ie52324bc8f0601b73483ec066093356d86641293
Signed-off-by: Abitha Shankar <abitha.s@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11903
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>

Enable WITH_UPSTREAM_LIBCOAP on Windows

Make Windows start using the upstream libcoap rather than the forked
version

Change-Id: Iae4257d4f8246e033116381ef058668180e11ee2
Signed-off-by: Dave Thaler <dthaler@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/10041
Reviewed-by: David Antler <david.a.antler@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

Add C++ Cloud provisioning

[#1]: Initial version of header
[#2]: APIs definition
Added Unit Tests.
Added cloudClient, based on the C cloudClient.
Only the focus APIs are changed to C++

Change-Id: I482f19b80e674ebccae44731a9927ab19c2b4a80
Signed-off-by: Ashwini Kumar <k.ashwini@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11331
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>

Fix build SECURED=1 WITH_TCP=yes

Changed camutex.h to octhread.h

Change-Id: Ib50364eabe8c0921bc672a1acf4fbbb1f8620f4a
Signed-off-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11949
Reviewed-by: David Antler <david.a.antler@intel.com>
Reviewed-by: Daniel Jay Ferguson <daniel.j.ferguson@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>

Merge "Merge branch 'cloud-interface'"

Fix a condition to filter out a wrong cred ID

A range of cred ID starts from 1 not 0. This patch fixes this wrong comparison.

Change-Id: I46196c38bfbe8a55a59de68e817b8c790b5e73fd
Signed-off-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11909
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>

Modify logic for subscribe callback and bug fixed.

this patch included,
1. modify logic for subscribe callback.
   call the user subscriberquestcallback function always.
2. bug fixed for NSProviderUnsetConsumerTopic.

Change-Id: Iad177bdf56cc7932ba1b95c157496d47ab6f9132
Signed-off-by: jaesick.shin <jaesick.shin@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11923
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Set defines before including platform_features.h

This is needed since platform_features.h uses some of the ifdefs set in
iotivity_config.h

Change-Id: I93aa075f910ed9a4548a30d6a3fa5a6d0692ad9c
Signed-off-by: Dave Thaler <dthaler@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11893
Reviewed-by: David Antler <david.a.antler@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>

Merge branch 'cloud-interface'

Change-Id: Icf637fda6105ca562dcda22e2ff7c3fb9cd8f8ba
Signed-off-by: Jee Hyeok Kim <jihyeok13.kim@samsung.com>

relocate singleton object(getInstance) to GroupManager

Change-Id: I3c263e0edd69e92d17fa4bf49e15d797054e7c8f
Signed-off-by: Jung Seungho <shonest.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11241
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jee Hyeok Kim <jihyeok13.kim@samsung.com>

Token refresh logic in the sample device (thin_room_light)

1. Token refresh logic is added to the sample device (thin_room_light)

Change-Id: I4fbeab1a3f665e065c3297e808a0145f751631d6
Signed-off-by: yeonghun.nam <yeonghun.nam@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11403
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jee Hyeok Kim <jihyeok13.kim@samsung.com>

Merge branch 'master' into cloud-interface

Change-Id: I9af09877a796742be84589e70c7e3dec522422f4
Signed-off-by: Jee Hyeok Kim <jihyeok13.kim@samsung.com>

Delete Device logic fixed in the account server

1. When a device is deleted, the device ID in each group is removed.
2. The device ID is added only in the resource publish case
3. footnote added

Change-Id: Ifdff14f0f3132a753b2a05cd4e1691657a8b3560
Signed-off-by: yeonghun.nam <yeonghun.nam@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11137
Reviewed-by: jung seungho <shonest.jung@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jee Hyeok Kim <jihyeok13.kim@samsung.com>

fixed create response in message builder

when create response message, it is unnecessary to set observe option.

Change-Id: I293843dac9bdbcc3d1b88724d15c89f229649fde
Signed-off-by: Jung Seungho <shonest.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11661
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jee Hyeok Kim <jihyeok13.kim@samsung.com>

Cloud ACL Management

Cloud ACL Management

Patch #1-2: ACLTable, ACL Id, ACL Verify, request handler added
Patch #3-5: ACL resources renamed, DB API added
Patch #10: URI & Request Handler fixed
Patch #11-15: Support for Observe Added
Patch #16-18: Combine changes for acl verify and policy engine by Sunil Kumar
Patch #19: Issue fixed regarding DB document object to HashMap
Patch #20: Revisions in response to comments

Change-Id: I3acbe47d268cb6ad647317de39185cbd7bd552db
Signed-off-by: Jongmin Choi <jminl.choi@samsung.com>
Signed-off-by: Sunil Kumar K R <sunil.k14@samsung.com>
Signed-off-by: Jongmin Choi <jminl.choi@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/10191
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Reviewed-by: Jee Hyeok Kim <jihyeok13.kim@samsung.com>

Enable more unit tests on Windows

* Enable resource/c_common unit tests
* Enable resource/unittests binary (partially)
* Fix small unit test bugs related to MSVC
* Consolidate flags for gtest binaries on Windows

Change-Id: Iead5e4494f3cc0e597ccee4bd83e6d9978141972
Signed-off-by: David Antler <david.a.antler@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11609
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Soemin Tjong <stjong@microsoft.com>
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>

Resolve secure tcp build issue for Tizen

Build is failing for tizen if both SECURED and WITH_TCP is enabled.

Change-Id: Ib67fb59fe0ef37d7a0be7c157bfe4b6b86f652bf
Signed-off-by: Abhishek Sharma <ce.abhishek@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11797
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

Rename all threading and synchronization to oc_*

* The threading and synchronization facilities were prefixed with
  ca_* when they lived in connectivity_abstraction. Now that the
  facilities have been moved to c_common, ca_* was renamed to oc_*

Change-Id: I0acc00680c42ebecd376ac238958875d9f1032e4
Signed-off-by: Daniel Ferguson <daniel.j.ferguson@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11227
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>

Add generic thread & synchro facilities

* Split Windows and Posix threading and
  synchronization facilities into separate
  files.
* Add ca_thread_[new|free|wait]
* Moved facilities to a more generalized location
  within the iotivity directory hierarchy
* TODO: add ca_mutex_init

Change-Id: I7718a9f5bd07610f0f989ba4729cb89111331238
Signed-off-by: Daniel Ferguson <daniel.j.ferguson@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/10743
Reviewed-by: David Antler <david.a.antler@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>

IOT-1072 Unfork libcoap: update forked headers

Make the .h files compatible between the forked libcoap and the official
libcoap, so that no breaking changes (only additions) are done to the
official libcoap, which other projects depend on the current
types/prototypes in.

Make any additions (that are beyond the official libcoap, but that are
already used by IoTivity code) to libcoap .h files follow the conventions of
libcoap, to make it more likely they'll be accepted back into the upstream
libcoap.  E.g., coap_transport_type -> coap_transport_t, etc.

Leaving WITH_UPSTREAM_LIBCOAP off by default on all OS's in this change.
Turning it on by default in certain OS's will be done as part of a
separate change.

Change-Id: I373ef818b8aeb7608c5e3511dc9880047946fbe0
Signed-off-by: Dave Thaler <dthaler@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/9373
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: David Antler <david.a.antler@intel.com>

Add Copyright header.

Change-Id: I84b2af8096ac67b583c220dffc42fede8c3ca86a
Signed-off-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11829
Reviewed-by: David Antler <david.a.antler@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>
(cherry picked from commit 9310a33d3e1af5023812d919f960f7d00013643e)
Reviewed-on: https://gerrit.iotivity.org/gerrit/11871

[IOT-1294] install libraries when building WITH_RA_IBB flag

When building with the TEST option the libraries will be picked
up at run time.

Changed the order of libraries to prevent linker error related
to the pthread library.

Change-Id: I39e70dc33b774dcf46559306df0c5558975ec451
Signed-off-by: George Nash <george.nash@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11851
Reviewed-by: Dave Thaler <dthaler@microsoft.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Rick Bell <richard.s.bell@intel.com>
Tested-by: Rick Bell <richard.s.bell@intel.com>

IOT-1072 Unfork libcoap: add build flag

* Add WITH_UPSTREAM_LIBCOAP command line option for SCons
* Add libcoap downloader, starting on public 'develop' branch
* Move resource\csdk\connectivity\lib\SConscript to extlibs\libcoap
* Restructured forked libcoap to resemble GitHub version, using a
  separate include directory and #include "coap/file.h" where needed
* Modify tizen build scripts
* Note - most platforms will not yet build with WITH_UPSTREAM_LIBCOAP

Change-Id: I51a59701d903adb63ba73e09afd230b9a7fd8696
Signed-off-by: Daniel Ferguson <daniel.j.ferguson@intel.com>
Signed-off-by: David Antler <david.a.antler@intel.com>
Signed-off-by: Ajay Saini <ajay.saini@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/9257
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>

Updated scons build configuration for Yocto

* Added i686 to the list of supported target architectures
  for a Yocto build.

Change-Id: I2b5b3191807ab7229cb3457f42a21a94a1d1611e
Signed-off-by: Kishen Maloor <kishen.maloor@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2873
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Reviewed-by: Habib Virji <habib.virji@samsung.com>

Flush 'Build for ...' messages before each build

During a run of 'auto_build.py', stdout buffering get taken over by the
subprocess module, causing print statements in 'auto_build.py' to not
output until the very end of a build. Calling 'sys.stdout.flush()'
causes stdout to be output before the next call to 'subprocess'.

Change-Id: Ibb193b5d30458a3d9be20d418ee22cac302ee819
Signed-off-by: Trevor Bramwell <tbramwell@linuxfoundation.org>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11823
Reviewed-by: Rick Bell <richard.s.bell@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>

Seperate Android x86 and Armeabi Builds

- Does not change current builds
- Adds ability to run individual android builds in the matrix:
    - x86
    - Armeabi
    - IP Transport
    - Routing Manager
    - Bluetooth
    - Bluetooth Low Energy

Change-Id: I5fa2efc144f28ab74ed9d3e116cfa39d4f6d9d6a
Signed-off-by: Trevor Bramwell <tbramwell@linuxfoundation.org>
Reviewed-on: https://gerrit.iotivity.org/gerrit/10239
Reviewed-by: Rick Bell <richard.s.bell@intel.com>
Reviewed-by: George Nash <george.nash@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>

ocpayload: Adding OCByteString support in representation

Add Bytestring handling in OCRepPayloadClone()
 along arrays/vectors of them.

Also added in native java (JNI) part for android
 inspired by existing code, note for later,
 original code might be double checked for potential MLK
 regarding local references to allocated objects within loops.
 Maybe those unref are not mandatory
 as they "are freed automatically after the native method returns."
 http://docs.oracle.com/javase/7/docs/technotes/guides/jni/spec/functions.html

Improved tests, it is assumed that contents of OCByteString
 are not duplicated when not wanted,
 plus style cleanup on surrounding code.

Note of my understanding of this design mixing C++ and C paradigms :

 - As OCByteString is a C structure there is no destructor
 - If assigned (no deep copy) into Payload class
   bytes will be freed by Payload's destructor as it "owns" it.
 - If contents are deep copied anywhere else
   then bytes should be also freed manually
   (in other classes' destructor ? like Payload).

Bug: https://jira.iotivity.org/browse/IOT-983
Change-Id: Icfa0657df9b332b4d11b737731636c8fb2a80001
Credits-to: youngman <yman.jung@samsung.com>
Origin: https://gerrit.iotivity.org/gerrit/#/c/8931/
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/8931
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>

Fix for Jira issues [IOT-1157, IOT-1194]

[IOT-1157]: Added default case for mentioned switch statements.
[IOT-1194]: Removed unused structures and made
g_GatewayID in routingmanager.c as static.

Change-Id: I03ff080867d28e3d32a18bb74fa7a9a26e465774
Signed-off-by: Veeraj Khokale <veeraj.sk@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11775
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Abhishek Sharma <ce.abhishek@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

Cloud Client manual

Change-Id: I82f42e4fcdce91011eb4d6f0d329cfdd29a9789c
Signed-off-by: Andrii Shtompel <a.shtompel@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11745
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>

[IOT-1294] Fixed build failure for WITH_RA_IBB flags

When building code with the WITH_RA_IBB=1 the build
would fail with undefined references to code found in the external
code found in extlibs/libstrophe and extlibs/wksxmppxep.

The code was already being built but was not properly linked by the
linker. This commit adds the library paths and libraries needed to
pass the build.

Change-Id: Ia9a1a6c40f6eeed174caaeb428224b97ffb6b59d
Signed-off-by: George Nash <george.nash@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11717
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Rick Bell <richard.s.bell@intel.com>
Tested-by: Rick Bell <richard.s.bell@intel.com>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>

Improved support for Visual Studio

1. Use SCons's MSVC_VERSION variable to support multiple VS
versions, instead of more fragile IoTivity-specific solutions.

2. Don't execute vsvars32.bat "manually" from run.bat. Let SCons
execute that batch script when needed, based on the value of
MSVC_VERSION.

3. Remove VS version handling from gtest/SConscript. Use SCons for
building gtest (and eliminate the need for cmake on Windows).

4. Delete duplicated lines from build_common/windows/SConscript.

Change-Id: I6490a32533624b7959b0a30992c8f10811e7735e
Signed-off-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11727
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: David Antler <david.a.antler@intel.com>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>

Optimize stack for Arduino.

In RI, headeroptions are maintained as array with default size as this macro.
A default 100 headeroptions are too high and results in a structure size of 3KB+.
Moreover any vendor will not add 100 CoAP options.
Also optimized few clonings.

Change-Id: I65860c44ec1ba0c3ef2800a88f27ecad0f483568
Signed-off-by: Abhishek Sharma <ce.abhishek@samsung.com>
Signed-off-by: Veeraj Khokale <veeraj.sk@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/10585
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

Update a logic to convert a string UUID to oicuuid type

The previous convertStringToUUID function does not works well, which
can not convert from string UUID to oicuuid one, properly. Instead of it,
we use an existing API for that in srmutility, i.e. ConvertStrToUuid.

Change-Id: I09f407e8af1a4395bf1b406bdb0f1a729e75f1fe
Signed-off-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11725
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Cloud Acl Management for master branch

Cloud Acl Management moved from cloud-interface to master

Change-Id: Ib35221c06e5dc409dddeed641124d0505fea55a4
Signed-off-by: Jongmin Choi <jminl.choi@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11733
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>

Clean up ocrandom test

Change-Id: I1547651b8570940f2d08d76748333adab54a3a1b
Signed-off-by: David Antler <david.a.antler@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11651
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Larry Sachs <larry.j.sachs@intel.com>
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-by: George Nash <george.nash@intel.com>
Reviewed-by: Soemin Tjong <stjong@microsoft.com>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>

eliminate [-Wcomment] warning

The JNI files mix C and C++ comments, so we get tons of annoying
warnings: "/*" within comment [-Wcomment]

Since the JNI layer is in C++ we remove the C comments.

Change-Id: I7fb5b2009a787e62de0b9b62ff7d06de4f33b699
Signed-off-by: Gregg Reynolds <reynolds-gregg@norc.org>
Reviewed-on: https://gerrit.iotivity.org/gerrit/9109
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Petre Eftime <petre.p.eftime@intel.com>
Reviewed-by: Habib Virji <habib.virji@samsung.com>
Reviewed-by: George Nash <george.nash@intel.com>
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>

doc: Fix some typos in scons_script_how_to.txt

Maybe this file worth to be migrated to iotivity wiki in a scons page

Change-Id: I288da1273621a48add047993506ed40c107363ab
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11077
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>

Fix for IOT-1214: Incorrect use of tinyCBOR API in security code

mapSize is consistently larger than the actual size of doxmMap.
This results in an erroneous parse of the resulting payload wherein
the last key-value pair is truncated.

When creating containers, we must specify CborIndefiniteLength unless
we know the exact length the container.

Change-Id: I8beb6bc45ae41531e8a7528d9dbd254a27e14be9
Signed-off-by: Kishen Maloor <kishen.maloor@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/10455
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Reviewed-by: Kevin Kane <kkane@microsoft.com>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>

yocto: connectivity should build as linux

Change-Id: I0f7a92ab21edbbbab9043e35a1bad4f429719b67
Bug: https://jira.iotivity.org/browse/IOT-1111
Origin: https://github.com/tizenteam/iotivity
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11713
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>

Added jni/android implementation for trust cert chain
Provisioning client modified for save and provision cert chain

Change-Id: Iad4b7286ed9076026399d7f7088c4fc39d58c624
Signed-off-by: Sunil Kumar K R <sunil.k14@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11001
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>

Merge remote-tracking branch 'origin/notification-service'

Android wrapper service is updated.

Change-Id: Iec12e1b9f48b60913e5915e9b3a8bfcf7c4bd891
Signed-off-by: cc <ch79.cho@samsung.com>

Updated Android Provider sample according to latest APIs.

Change-Id: I3f8bab4b3992976648f6d20b7aa6b9aaedd83d65
Signed-off-by: nikhil.a <nikhil.a7@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11693
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Added Consumer Sample app changes for Notification.

1. Updated to call latest Android APIs
2. Added Topics API calls

Change-Id: Id2ceab934c4a1527911b5e25e6a4f522d8fed9cc
Signed-off-by: abitha.s <abitha.s@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11691
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Fix windows build in master (2)

[Patch #2] Removed duplicate sqlite parse-config for tizen
[Patch #3] Fix typo that causes tizen build fail

Change-Id: I5976ad8a4013d20037a6871ae975bb9ed581cf17
Signed-off-by: Andrii Shtompel <a.shtompel@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11689
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Reviewed-by: David Antler <david.a.antler@intel.com>
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-by: Joonghwan Lee <jh05.lee@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

The wrapper unittest is not required"

Change-Id: I3646b0da24192b6a34ceef64f2b4fd602a9a99c8
Signed-off-by: nikhil.a <nikhil.a7@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11675
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>

fix warning caleadapter and fragmentation

Change-Id: Ib6a83e0c59f2dde92881eb077d7575658deffbb4
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11557
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Abhishek Sharma <ce.abhishek@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

Send normal GET response for register request to
non-observablbe resource(s).

Bug: https://jira.iotivity.org/browse/IOT-1279
Change-Id: I93be3d3dc79bfc782e98ded57ef6cc0122077d7c
Signed-off-by: Ziran Sun <ziran.sun@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11635
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>

Cloud Client

Implemented:
1. Cloud Client itself with menu and folders structure
2. CRL/ACL requests according latest spec

[Patch #2] Remove OCPayload to ACL/CRL convertion.
           Convert OCpayload back to char * and
           Use ACL/CRL resource functions to parse and update DB
[Patch #3] Add sync to menu and start userRequests as thread
[Patch #4] Save minor changes before merge both clients
[Patch #5] Merge CSR to this cloud client
[Patch #6] Clean-up changes. Merged cloud client works
[Patch #7] Save minor changes before move to cloud-interface branch
[Patch #8] Store private data
[Patch #9] Implement CRL on device according latest spec
[Patch #10] Minor Crl on device fixes
[Patch #11] Handle review comments
[Patch #12] Implement ACL get info on device according spec
            Remove OC_EXPORT from headers
[Patch #13] Fix CBOR encoding
[Patch #14] Crl last update, crl db changes, fix build error
[Patch #15] Crl Get/Post are fully implemented
[Patch #16] Acl fix uri path'es
[Patch #17] PKIX interface to SRM
[Patch #18] CRL rcsn fix (use String Array instead of String)
[Patch #19] ACL callbacks implemetation (parse and print recv data)
[Patch #20] Complete ACL callbacks
[Patch #21] Update Menu UI
[Patch #22] ACL uid's length fixes
[Patch #23] ACL ace request + CRL encoding fix
[Patch #24] Fix crash when receive empty aclist
[Patch #25] Set public data default encoding to DER
            Fix CRL initialization
[Patch #26, 27] Restore #24
[Patch #28] Fix build error related to PKIX
[Patch #29] ACL few fixes, clean-up code, add comments
[Patch #32] Clean-up csr + handle all review comments
[Patch #34] Revert ocpayload.c changes
[Patch #35] Fix build without WITH_TCP, CRL/ACL clean-up, error on exit
[Patch #37] Fix private data encoding
[Patch #38] Test build on Windows
[Patch #40] Remove accidental changes
[Patch #41] TLS sample fix
[Patch #42] CRL changes to use CBORPayload() functions
[Patch #43] ACL changes to use CBORpayload() + printAcl() + minor fixes
[Patch #44] Added extern C for external linkage to C++
[Patch #45] Revert #44 + acl fix
[Patch #47] Implement OC_LOG_PAYLOAD to show nested objects and arrays
[Patch #48] Fix review comments
            Add dynamic cipher based on SVR
            Change close notify to alert
[Patch #49] Add rootcer.crt and SaveTrustCert in cloudClient sample
[Patch #50] Change cipher priority and add choose cipher option in sample
[Patch #51] Remove accidental changes
[Patch #52] Add RSA cipher selection
[Patch #53] Huge changes in API and handlers to provide it to external team
[Patch #54] Minor fix, clean-up, add comments
[Patch #55] Resoved issue for save TrustCert with PEM in cloudClient sample
[Patch #56] UpdateACE fix, add CoAPs selection to Menu
[Patch #57] Few ACL requests fix, now all of them are working
[Patch #58] Add db file to command-line args + few fixes
[Patch #60] Add alert messages
[Patch #61] Fix cipher selection
[Patch #62] Fix Svace warnings
[Patch #63] Fix acl db issue. Create CBORpayloadToAcl2() for cloud response
            Because in latest spec its wrong we need this workaround
[Patch #64] Fix service folder build error when secured enabled
[Patch #65] Implement responses to cloud cpp wrapper API
[Patch #66] Minor fix to cloud cpp wrapper responses
[Patch #67] Fix Cbor allocation when credresource increase
[Patch #68] Revert wrong changes made in Patch #64
[Patch #69] Remove wrong changes in other SConscript files
[Patch #70] Fix minor build error
[Patch #71] Remove wrong changes from 2 source files + clean-up Sconscripts
[Patch #72] Return back credresource.c + fix crlresource.c for tizen
[Patch #73] Return back richdk scons
[Patch #74] Disable build stack samples without SECURED=1
[Patch #75] Fix OTM PIN
[Patch #76] Fix conflict
[Patch #77,78] Fix tizen build error
[Patch #80] Remove changes in secure stack samples
[Patch #81] Add ours headers to doxygen, update comments, add static
[Patch #83] Fix conflicts with master
[Patch #84] Add Discovery + Get/Put/Post device-to-device requests
            Separate most sample source code to cloud folder
[Patch #86] Arduino build fix
[Patch #87] Resolve merge conflict

Change-Id: Ib83b14a40d49df3b62dd5a1863777c8a5504a4e5
Signed-off-by: Jonsgung Lee<js126.lee@samsung.com>
Signed-off-by: Andrii Shtompel <a.shtompel@samsung.com>
Signed-off-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
Signed-off-by: Andrii Shtompel <a.shtompel@samsung.com>
Signed-off-by: Joonghwan Lee<jh05.lee@samsung.com>
Signed-off-by: Andrii Shtompel <a.shtompel@samsung.com>
Signed-off-by: Joonghwan Lee<jh05.lee@samsung.com>
Signed-off-by: Andrii Shtompel <a.shtompel@samsung.com>
Signed-off-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
Signed-off-by: Andrii Shtompel <a.shtompel@samsung.com>
Signed-off-by: Oleksandr Dmytrenko <o.dmytrenko@samsung.com>
Signed-off-by: Andrii Shtompel <a.shtompel@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/10785
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Tested-by: Randeep Singh <randeep.s@samsung.com>

SimpleBase code clean up

Remove warning and change main page

Change-Id: I1535fe015414462d9320fccddee6ddea9bb7a530
Signed-off-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11319
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

fixed multicast presence for sample related c-sdk.

Change-Id: I011b0575b34b957ef776a3ca56db0b3f2d751f2b
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11329
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

[IOT-1248] Fix multiple APIs throwing wrong exception

Change-Id: Ide5d534e301492bfd5499fa6d1cc7778bf5e7611
Signed-off-by: saurabh.s9 <saurabh.s9@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11671
Reviewed-by: Md. Imtiaz Hossain <imtiaz.h@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Tested-by: Randeep Singh <randeep.s@samsung.com>