krishna.kb [Mon, 13 Apr 2015 11:49:52 +0000 (17:19 +0530)]
Modified the config and library path in PPM Service for Tizen Platform
Change-Id: I481c4eaaac1aa184f4a2a3b7f9254ddac7702598
Signed-off-by: krishna.kb <krishna.kb@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/701
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Younghyun Joo <yh_.joo@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Erich Keane [Mon, 13 Apr 2015 22:37:25 +0000 (15:37 -0700)]
Fixed Android Build error caused by merge issue
Apparently while merging the Sconscript for the libcoap directory,
I managed to grab some lines from somewhere else(I have no idea
where from!). This was a mistake, so I'm reverting this file
back to have the identical functionality as the CA branch,
since this doesn't exist on the pre-merge master branch.
Change-Id: I8fcfe692e4e4ab35666ed4a5f02041faffa440c0
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/708
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Rahul Rahul <rahul.rahul@intel.com>
Charlie Lenahan [Mon, 13 Apr 2015 21:26:28 +0000 (17:26 -0400)]
fix for os x build
This is a followup to https://gerrit.iotivity.org/gerrit/#/c/677/
Apple defines _POSIX_TIMERS as (-1) , thus the need to check for
both
Change-Id: I8a852febd45133177706a1d529040fce704200f9
Signed-off-by: Charlie Lenahan <charlie.lenahan@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/706
Reviewed-by: Thuyen Tran <thuyen.c.tran@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Joseph Morrow [Mon, 13 Apr 2015 20:01:20 +0000 (16:01 -0400)]
Enabled Arduino verification build.
During the latest merge of connectivity-abstraction branch into master branch,
the Arduino verification process was disabled in order to properly verify all other code paths on the build system post-merge to enable all IoTivity
contributors' work for post-merge efforts. This changeset allows for post-
merge efforts to continue as well as continuing verification of Arduino
code paths.
Change-Id: I3d4bc738afb072371820bb24144f6582cd4afa5c
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/705
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
jaehong.jo [Mon, 13 Apr 2015 07:50:26 +0000 (16:50 +0900)]
Define prefix SINGLE_THREAD, MULTI_THREAD
Currently using two separate files, like xxx.c and xxx_singlethread.c
Signed-off-by: jaehong <jaehong.jo@samsung.com>
Change-Id: I0b2f1ba23ecfd5b23ffc48266221eac2201b7745
Reviewed-on: https://gerrit.iotivity.org/gerrit/698
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Minji Park [Mon, 13 Apr 2015 10:06:35 +0000 (19:06 +0900)]
Fix build error of Soft sensor Manager after CA branch merging into master
Fix Sconscript for SSM linux Sample application due to link errors
Change-Id: Ia3d5d32b4069e669ae4d1792efd0e4d8a6c794b4
Signed-off-by: Minji Park <minjii.park@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/700
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>
YounghyunJoo [Mon, 13 Apr 2015 08:19:17 +0000 (17:19 +0900)]
Modify Protocol Plugin Manager code files for CA adaptation
1. Modify SCons file align
2. Modify Sample Application code to the latest version
Change-Id: I673fe819335230913aad90d069c13b8d443b987c
Signed-off-by: YounghyunJoo <yh_.joo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/696
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Erich Keane [Fri, 10 Apr 2015 21:42:24 +0000 (14:42 -0700)]
Re-enable Cereal download
The build post-CA/Master merge seems to have lost the auto-download
functionality that we put in to allow cereal to be captured
automatically.
This fix re-enables the script, which should fix a few of the
other build servers listening in.
Change-Id: Icf3d0d0ed0babaef37f2ceace55abc471a73d306
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/693
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Vijay Kesavan <vijay.s.kesavan@intel.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Reviewed-by: Jihun Ha <jihun.ha@samsung.com>
Erich Keane [Fri, 10 Apr 2015 00:50:26 +0000 (17:50 -0700)]
Merge branch 'connectivity-abstraction' to master
Change-Id: I54ea8ab0ea7c4929576ac9b613ce19c79a5c92b8
Signed-off-by: Erich Keane <erich.keane@intel.com>
Rahul Rahul [Thu, 9 Apr 2015 21:47:17 +0000 (14:47 -0700)]
Glib patch for Gnome-glib android build
Added boost dependency in the scons script.
The scons build script downloads the appropriate boost version for
android, unpacks and builds it.
This also builds C++ liboc library but not the examples.
Change-Id: I54d1a938e249a3e251d8508180c8cd103420d70f
Signed-off-by: jnashok <jn.ashok@samsung.com>
Signed-off-by: Rahul Rahul <rahul.rahul@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/623
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Thiago Macieira [Wed, 8 Apr 2015 20:03:02 +0000 (13:03 -0700)]
Update the use of clock_gettime(2)
clock_gettime(2) is a POSIX feature, but CLOCK_REALTIME_COARSE is a
Linux extension. So instead of using clock_gettime only on Linux, try to
use the POSIX macros instead. This way, we'll use clock_gettime on
systems that support it, falling back to gettimeofday if they don't.
POSIX.1-2008 requires clock_gettime(2) functionality, so up the
_POSIX_C_SOURCE macro requirement to the 2008 version. This will request
the 2008 API if it's available on some systems (QNX is known to not
enable all the API it has available). Older versions of POSIX don't
require the timer support.
Change-Id: I27eaacb532114dd188c4ffff13d3229d285d21cb
Signed-off-by: Thiago Macieira <thiago.macieira@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/677
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Charlie Lenahan <charlie.lenahan@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Joseph Morrow [Thu, 9 Apr 2015 16:22:06 +0000 (12:22 -0400)]
Cleaning previous debug build before running Unit Tests to rebuild debug.
By doing this, it will cause a trigger to rebuild the appropriate modules
of the stack's logging. This will make it so that when the Unit
Tests are ran, that all logging will actually be off. Until now, the Unit
Tests were re-using the binaries from the last debug build without re-
triggering a rebuild to remove the logging symbols from the CA and RI
Layers. We need the Unit Tests to run with debug symbols to fully enable
the Valgrind pluging on the Jenkins CI System.
Change-Id: I117f583a18be0f8dd9c9f2c52b30b61ceb34ed70
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/687
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Mandeep Shetty [Wed, 8 Apr 2015 23:20:45 +0000 (16:20 -0700)]
Added token length to direct stack responses.
Token length is required because the stack at the client side looks at
the token field only if token length is non zero. Without the token,
client application will not receive responses.
Change-Id: If1f9e85473bd964651669640d2fe48c1821600d5
Signed-off-by: Mandeep Shetty <mandeep.shetty@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/682
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
jihwan.seo [Thu, 9 Apr 2015 07:35:05 +0000 (16:35 +0900)]
Bug Fixed CA InterfaceController for TC-33
fixed some problem in TC-33 by transport option
when OIC base code is built with 'TARGET_TRANSPORT=WIFI'
now CA can return a suitable reason for the status
that Network has disabled
Change-Id: Iaf0142cad5db4b0ee287cbeec75add1431d2a754
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/685
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
HyunJun Kim [Thu, 2 Apr 2015 08:53:41 +0000 (17:53 +0900)]
Merge Things Manager codes CA and Master branch.
It was modified base on CA for preparing for official merge.
Change-Id: If3cb90d9a1a03a8d79d95952f5dfabb07c526634
Signed-off-by: HyunJun Kim <hyunjun2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/632
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Charlie Lenahan [Wed, 8 Apr 2015 19:58:11 +0000 (15:58 -0400)]
Resolve potential buffer overflow warning
Compiler warning generated because the value of the size argument in
'strncat' is too large.
Also, IF check was not accounting for DELIMTER size, which
could cause overflow.
Change-Id: Iee3724bb08d8254f7a99f84ec1571eeeb5974d22
Signed-off-by: Charlie Lenahan <charlie.lenahan@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/678
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Mandeep Shetty <mandeep.shetty@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Thiago Macieira [Wed, 8 Apr 2015 20:16:36 +0000 (13:16 -0700)]
Remove unnecessary, generated files that were committed
Those files should never have been in the repository in the first place. The
commit that introduced them (
3e4087ca6843ea40863488458eed22b31df08983) should
not have been approved.
Change-Id: I27eaacb532114dd188c4ffff13d3233af112d867
Signed-off-by: Thiago Macieira <thiago.macieira@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/679
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Charlie Lenahan [Tue, 7 Apr 2015 18:59:58 +0000 (14:59 -0400)]
Enable compilation and functionality on darwin(osx)
Currently, the iotivity project does not support compiling/
running on Apple Darwin platforms. This patch enables
compilation and minimal sample functionality for darwin.
It accomplishes this by adding 'darwin' as a valid
target_os in all build-scripts. glib2 compiling/linking
is also added for the darwin build, which was previously
missing and blocking building connectivity-abstraction.
Many positions in the code had #ifdef __linux__, which has
been switched to also recognize __APPLE__.
Finally, the logger time-functionality used linux-specific
clock_gettime, so this functionality has been broken up
into an osalGetTime function, with an implementation for
__APPLE__ included in this patch.
Change-Id: Iddc2462db44198be90a975536e0273f63c521ab6
Signed-off-by: Charlie Lenahan <charlie.lenahan@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/668
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Sakthivel Samidurai [Wed, 8 Apr 2015 04:44:37 +0000 (21:44 -0700)]
Update CA layer code for tinyDTLS location
Update CA layer code to pick tinyDTLS from iotivity/extlibs
location when compiling CA shared module.
Change-Id: I2e142453a43752073938cd56878597212ff606ae
Signed-off-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/671
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
eunok.shin [Wed, 8 Apr 2015 11:47:19 +0000 (20:47 +0900)]
fix problem by transport option when code is build and clean up.
Now, when code is build to 'transport type = WIFI'. some TC have error.
So, I changed TC 26, 28, 33.
Change-Id: I6ef9e9ea4d8718d3005585f162eeb3652af04f17
Signed-off-by: eunok.shin <eunok.shin@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/675
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
hyuna0213.jo [Wed, 8 Apr 2015 01:53:37 +0000 (10:53 +0900)]
Bug fixed for logging flag to scons build parameters.
Change-Id: Iae7d52afe44d915edcf887e6c1625b95e308512e
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/670
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
jnashok [Mon, 6 Apr 2015 13:04:33 +0000 (22:04 +0900)]
[Jira-IOT398] Fix for linux Scons build to not support BT/BLE build
Signed-off-by: jnashok <jn.ashok@samsung.com>
Change-Id: I754bce8832fd360983a0f732cde41240ea6ab4ad
Reviewed-on: https://gerrit.iotivity.org/gerrit/656
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Jon A. Cruz [Fri, 3 Apr 2015 23:01:45 +0000 (16:01 -0700)]
Updated Doxyfile to match master so that all code comments added
on the CA branch will not have to be redone.
Getting the Doxygen config file to match that in master will
prevent extra work of fixing doc comments once CA is merged back.
Instead all comments added and/or edited in the CA branch will
start correct and not require fixes post-merge.
Change-Id: I5a66c37c1b88582b309f841c58a0acb33f52cec6
Signed-off-by: Jon A. Cruz <jonc@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/647
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Sudarshan Prasad [Fri, 27 Mar 2015 06:35:39 +0000 (23:35 -0700)]
Modified unittests readme to be upto date
Change-Id: I6982ec502ae391b5664e66d62e7fca1eed192f5f
Signed-Off-By: Sudarshan Prasad <sudarshan.prasad@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/588
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Caiwen Zhang [Fri, 3 Apr 2015 06:26:40 +0000 (14:26 +0800)]
Fix x86 and x86_64 build errors
1) fix linux x86 cross compile error
2) fix android x86_64 build error
Change-Id: I07f8f821b596712766f9f7330020a22e23e4b66a
Signed-off-by: Caiwen Zhang<caiwen.zhang@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/642
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
hyuna0213.jo [Wed, 8 Apr 2015 11:30:36 +0000 (20:30 +0900)]
Fixed [IOT-442] "CA unit test 17,20,23 are expecting to fail"
Currently CA unit test 17,20,23 are expecting to fail but are actually
invalid parameter error.
Change-Id: Iaa4447425eab245c02168bb4984f3d4186631377
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/674
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Mandeep Shetty <mandeep.shetty@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Sachin Agrawal [Wed, 8 Apr 2015 06:08:52 +0000 (23:08 -0700)]
Fixed linker order for Arduino libraries for Due and WiFi combination
Incorrect order of WiFi and SPI libraries was causing linker
to generate output binary which Arduino Due MCU was unable to load.
Change-Id: I3e5aa19d531ed8d754dad7d4fd53848a6a4d1f68
Signed-off-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/673
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sanjay Sharma <sanjay1.sharma@intel.com>
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Sachin Agrawal [Mon, 6 Apr 2015 00:49:18 +0000 (17:49 -0700)]
Fixed bug to send discovery request as Non-Confirmable request
Discovery requests needs to be send as Non-Con requests. Recent change
was failing some of the test cases supported by sample apps.
Change-Id: Ic6a701eaabdcf51cc388618c1afc07baefc3362f
Signed-off-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/651
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Shilpa Sodani <shilpa.a.sodani@intel.com>
Reviewed-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Sachin Agrawal [Tue, 7 Apr 2015 20:55:51 +0000 (13:55 -0700)]
Updated DTLS usage as per discussion
As per discussion between Sachin and Ashok, following are updated:
1) CA API modified such that memory holding credentials is not
shared between RI and CA i.e. For GetCredential() call, RI will
allocate memory and CA will free it.
2) Since there was no consensus on "creds" member of
"OCDtlsPskCredsBlob", as per discussion, CA has forked a separate
structure i.e. CADtlsPskCredsBlob and samples modified to use it.
3) Duplicate ocsecurityconfig.h is updated as per the original version.
This will be removed in a separate commit with other forked files.
4) RI layer is updated to remove SEC_CA_MERGE_WORKAROUND.
Change-Id: I174d82616985e0064e9a2fdccf08cbf8a43dfb7d
Signed-off-by: Abhishek Sharma <ce.abhishek@samsung.com>
Signed-off-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/605
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Doug Hudson [Tue, 7 Apr 2015 19:58:24 +0000 (15:58 -0400)]
Fix incorrect usages of OIC_LOG_V macro.
The OIC_LOG_V macro is intended to be used for variadic log messages.
This macro was used in many cases for non-variadic messages. In these
cases, OIC_LOG_V was replaced with OIC_LOG.
Change-Id: I8a2c9319da495fc89d73146c3b57e67f64a60340
Signed-off-by: Doug Hudson <douglas.hudson@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/667
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Mandeep Shetty [Tue, 7 Apr 2015 19:52:59 +0000 (12:52 -0700)]
Support HighQoS and Cancel Observe in CA and RI
Modified the timeout callback in CA to add tokens in responses.
Modified CA codes to used pdu codes that are according to stranded.
RI now send ACK and RESET pdus to support High QOS when
receiving requests, responses and to cancel observations. Added
support for slow resources.
Change-Id: If8cd175690fb51e0f4c125eda6d67f95a21dc3e3
Signed-off-by: Yamin Al-Mousa <yamin.s.al-mousa@intel.com>
Signed-off-by: Vijay <vijay.s.kesavan@intel.com>
Signed-off-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Signed-off-by: Mandeep Shetty <mandeep.shetty@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/610
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
jihwan.seo [Fri, 27 Mar 2015 09:18:12 +0000 (18:18 +0900)]
RESET/ACK code review update.
updating review comment changes Re factored PDU creation API
for better usage Changed debug to error logs
during critical conditions.
https://gerrit.iotivity.org/gerrit/#/c/303/
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Change-Id: I5d5b82ab7368fb7c30bf1055dda6331613240051
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/589
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
eunok.shin [Tue, 7 Apr 2015 06:20:21 +0000 (15:20 +0900)]
Move unittest file to test folder to sync with existing folder structure
Change-Id: Id42c8139e86a1236b3524b6d07cb26392609a2cc
Signed-off-by: eunok.shin <eunok.shin@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/661
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Naga Ashok Jampani <jn.ashok@samsung.com>
Reviewed-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Joseph Morrow [Mon, 6 Apr 2015 17:00:37 +0000 (13:00 -0400)]
Add stack logging flag to scons build parameters.
This will allow people to build debug versions of the stack without
actually enabling all the stack debug logs. This is useful (for instance)
when you may want to run unit tests in debug mode (ie. with no optimizat-
ion and full debug symbols), run without stack logging noise, and run
valgrind as the CI (ie. build) system does. The default values of when
logging will be enabled remain the same as before, except the default for
stack logging when building/running the unit tests is disabled. You may
change this by simply adding "LOGGING=1" or "LOGGING=true" to the list
of scons options, however.
Change-Id: I70cedc9143c6015fd75bf4725cf72b6a64b8529e
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/657
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
hyuna0213.jo [Fri, 3 Apr 2015 06:57:31 +0000 (15:57 +0900)]
Linux sample application changes to test CA full function
Change-Id: I54d8410893d01dbb486422f1ffd4f68c7a24df46
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/641
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Jon A. Cruz [Mon, 6 Apr 2015 23:46:37 +0000 (16:46 -0700)]
Fix outdated SCons build scripts that were broken for WiFi.
Corrected outdated SCons build script that was still referencing the
'NET' environment variable instead of the TARGET_TRANSPORT one that
the CA branch was switched to using.
Removed setup/documentation of the outdated 'NET' option.
Change-Id: I2f22921b290da65d77fccb237b09dd0b6302996d
Signed-off-by: Jon A. Cruz <jonc@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/659
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Doug Hudson [Mon, 6 Apr 2015 22:01:14 +0000 (18:01 -0400)]
Mods per RI code review.
- Add doxygen comments
- Return OC_STACK_ERROR if observer notification fails
- Declared function that was only used in module as static
Change-Id: I129b88a21b228a1aceaa0ebd898cc25472bc46bb
Signed-off-by: Doug Hudson <douglas.hudson@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/627
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>
jk13 [Tue, 7 Apr 2015 08:45:45 +0000 (17:45 +0900)]
SoftSensor Manager - Apply java formatter to Android sample
1. Apply java formatter to Android sample
Change-Id: I0807aa0196ae4d612ceff30887f75ecc41141950
Signed-off-by: jk13 <jihyeok13.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/664
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>
jk13 [Tue, 7 Apr 2015 06:54:58 +0000 (15:54 +0900)]
SoftSensor Manager - Fix potential issues detected by static analysis tool
Fix potential issues
Change-Id: Ifc22e31b7e3e0028914458ce71d94f5d4e9c991c
Signed-off-by: jk13 <jihyeok13.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/663
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>
jk13 [Mon, 6 Apr 2015 11:16:52 +0000 (20:16 +0900)]
Softsensor Manager - Fix java api method name to follow coding guidelines
1. Fix jave api method name to follow coding guidelines
Change-Id: If707b52ee3da12b635e7bc44ecd18552b28e568d
Signed-off-by: jk13 <jihyeok13.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/654
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Rami Jung [Tue, 7 Apr 2015 06:26:25 +0000 (15:26 +0900)]
Additional removing 'makefile's for the primitive service
Change-Id: If556c6b5a0c83d9408d02875b7bfc22c3c279ab7
Signed-off-by: Rami Jung <rami.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/662
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Sakthivel Samidurai [Sun, 5 Apr 2015 19:35:16 +0000 (12:35 -0700)]
Addressing RI and CA integration code review.
Addressed the issues assigned to me in changeset 401 patch 2
Signed-off-by: Vijay Kesavan <vijay.s.kesavan@intel.com>
Change-Id: I4d7014d97e51bd85d61d25ac7693a917caede242
Signed-off-by: sanjaysh <sanjay1.sharma@intel.com>
Signed-off-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/543
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Mandeep Shetty <mandeep.shetty@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Sachin Agrawal [Fri, 3 Apr 2015 22:43:08 +0000 (15:43 -0700)]
Adding autoconf generated files in tinydtls repo
tinydtls build system uses autotools while Iotivity uses
scons build system. Since tinydtls contains few source files
and header files, it seems convenient for Iotivity to use
scons to build tinydtls library.
This patch is to add autoconf generated files so that tinydtls
can be build using scons script.
Note: Since this change is a custom change and specifically
for Iotivity, I do not intend to submit this patch for
upstreaming.
Change-Id: I4da593a8abccd731466a88d365dca536f608c94a
Signed-off-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/638
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Shilpa Sodani <shilpa.a.sodani@intel.com>
Reviewed-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Minji Park [Thu, 2 Apr 2015 09:07:01 +0000 (18:07 +0900)]
Soft Sensor Manager - Apply changed C.A. API
Modify ResourceFinder to find resources and check presence status with connectivity type options
Change-Id: Ieeab82369f40c05ec0cae68f6395cd9a8e415cf7
Signed-off-by: Minji Park <minjii.park@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/633
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>
hunje.yeon [Fri, 3 Apr 2015 14:46:20 +0000 (23:46 +0900)]
Notification Manager - Fix memory deallocation.
Problem: Memory unsafe function is used.
How: Change sprintf to snprinft to avoid memory problems.
Change-Id: I864c5c39c13c07533693b6b59f35e48d15518f4e
Signed-off-by: yeonhunje <hunje.yeon@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/643
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>
hunje.yeon [Sat, 4 Apr 2015 14:23:09 +0000 (23:23 +0900)]
Notification Manager API Doxygen update
remove the invalid return value from the documentation
Change-Id: Iba341cc59475764d52b06d4cf2fc5ba787a9bba8
Signed-off-by: hunje.yeon <hunje.yeon@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/649
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>
Rami Jung [Fri, 3 Apr 2015 01:00:15 +0000 (10:00 +0900)]
Removing 'Makefile's for the primitive service
Change-Id: I583d71d084692f49572d6e232f136d6288c1b1e9
Signed-off-by: Rami Jung <rami.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/639
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>
Sakthivel Samidurai [Fri, 3 Apr 2015 21:56:55 +0000 (14:56 -0700)]
Remove unused header and CPP files
Remove unused OCSecurityModel.h and OCSecurityModel.cpp files
Change-Id: Ic1308e4edaedce609edecae7950d44136e78c17e
Signed-off-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/646
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Sakthivel Samidurai [Fri, 3 Apr 2015 21:49:28 +0000 (14:49 -0700)]
Removed old_tests folder
The old_tests folder is not used.
Change-Id: I194ba0d7a11b38b682d62f3a95cd86406955f1fb
Signed-off-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/645
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Charlie Lenahan [Fri, 3 Apr 2015 19:57:41 +0000 (15:57 -0400)]
Add VERBOSE flag to scons
cleans up build noise so warnings errors can stand out more
Change-Id: Iad90dbfc8e92c02a9f65274bcba67e7bf01d7451
Signed-off-by: Charlie Lenahan <charlie.lenahan@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/644
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Erich Keane [Fri, 3 Apr 2015 17:55:08 +0000 (10:55 -0700)]
Fixed [IOT-396] "Sconscript not available in Iotivity repo"
Currently Sconscript alone has been added for tinydtls compilation.
Before compiling the code, Please add tinydtls source code in this folder.
Change-Id: Idd5f19f54dba5cc5cfb855658b08498ff5fda0d7
Signed-off-by: k.karthick <k.karthick@samsung.com>
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/595
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Mandeep Shetty [Wed, 1 Apr 2015 18:12:44 +0000 (11:12 -0700)]
Fix C client to receive presence notifications.
This fixes IOT-432.
Make occlient.cpp subscribe to the same resource ocserver.cpp is sending
out presence notifications on. Server sends out notifications for
core.led while client was subscribed to core.light.
Signed-off-by: Mandeep Shetty <mandeep.shetty@intel.com>
Change-Id: I8aeb96b981f1bb71ce0661f1fa54d58ba1a19b8c
Reviewed-on: https://gerrit.iotivity.org/gerrit/626
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
jnashok [Wed, 1 Apr 2015 12:35:42 +0000 (21:35 +0900)]
[Jira] IOT 409 Fix for CAInitializeWiFi naming to be in consistent with other APIs
Change-Id: Ib2fac3df7084cffff8f7a31cc63c972aad0bb327
Signed-off-by: jnashok <jn.ashok@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/624
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Doug Hudson [Thu, 2 Apr 2015 21:03:54 +0000 (17:03 -0400)]
Modifications based on RI comments.
- Add doxygen function comments
- Declared functions that were only used in module as static
Change-Id: Ib183811a163b084a303793479f66465f9ca3f1f5
Signed-off-by: Doug Hudson <douglas.hudson@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/636
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Abhishek Sharma [Fri, 27 Mar 2015 10:53:25 +0000 (16:23 +0530)]
Fix for Arduino WiFi shield fragmentation issue.
Added fix for Arduino WiFi shield fragmentation issue.
It was dropping outgoing packets that are more than 90 bytes.
Change-Id: I8d9f4a02268346b145ff8599232132414bc86123
Signed-off-by: Abhishek Sharma <ce.abhishek@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/594
Reviewed-by: Abhishek Pandey <abhi.siso@samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Sanjeev BA [Fri, 3 Apr 2015 04:56:46 +0000 (13:56 +0900)]
Fix build instruction.
Change-Id: I05df7a6900635c830dd59e4006a24c4fb399ce61
Signed-off-by: Sanjeev BA <as2902.b@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/640
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Jon A. Cruz [Fri, 20 Mar 2015 06:43:53 +0000 (23:43 -0700)]
Unify caprotocolmessage to fix bugs in different versions.
Unified the caprotocolmessage sources to a single version that
brings together bug fixes that had gone individually into either
one copy or the other, but not both.
Will also allow testing of the arduino-centric code under Linux
builds.
Follow-up to https://gerrit.iotivity.org/gerrit/#/c/470/
Fixes IoT-400
Change-Id: I47b726c940ef1dd45a26cf160b92e1cbbd7f5f2e
Signed-off-by: Jon A. Cruz <jonc@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/583
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Minchul Lee [Thu, 26 Mar 2015 14:59:06 +0000 (23:59 +0900)]
Fix aarch64 build error on tizen 3.0
Change-Id: Id5cc93c9264dcec660a76f6aa012ec2c31123b95
Signed-off-by: Minchul Lee <slotus.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/580
Reviewed-by: saerome kim <saerome.kim@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Caiwen Zhang <caiwen.zhang@intel.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Harish Kumara Marappa [Thu, 2 Apr 2015 17:10:13 +0000 (22:40 +0530)]
configuration server tizen sample application for testing configuration
APIs
Change-Id: I9a8c691d01307e08a7d1f86eee473f36cce8330f
Signed-off-by: Harish Kumara Marappa <h.marappa@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/478
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Harish Kumara Marappa [Thu, 2 Apr 2015 16:59:12 +0000 (22:29 +0530)]
ThingsManager service tizen sample application for testing configuration
APIs and Group action APIs
Change-Id: I6e77d1dba0488498da61df40d0a1a61e13badd0f
Signed-off-by: Harish Kumara Marappa <h.marappa@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/480
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
YounghyunJoo [Tue, 31 Mar 2015 14:34:03 +0000 (23:34 +0900)]
Align to the Java Class package name change in Protocol Plugin manager service JNI layer
Align to the Java Class package name change in Protocol Plugin manager service JNI layer
Change-Id: I9e24f7a9faeacf197b33a17bab1e0d1e3f335c2a
Signed-off-by: YounghyunJoo <yh_.joo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/612
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
HyunJun Kim [Thu, 2 Apr 2015 07:07:55 +0000 (16:07 +0900)]
Fix minor issue for Group Action of ThingsManager.
addActionSet and executeActionSet do not return error message when entered invalid parameters.
In this case, we return 'OC_STACK_INVALID_PARAM'.
getActionSetfromString didn't return when entered malformed string.
It will be returned NULL in this case.
Change-Id: Ifd28640d6aca6714646b33ea8fb69c55f8ca36f7
Signed-off-by: HyunJun Kim <hyunjun2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/631
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Joseph Morrow [Tue, 31 Mar 2015 15:06:39 +0000 (11:06 -0400)]
Enabled the build script to build for Arduino Due as well.
This enables the build server and endusers/developers to verify builds
for the Arduino Due as well.
Change-Id: I08ca0893b16d8cfcf133e8554379eeb69e489515
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/614
Reviewed-by: Doug Hudson <douglas.hudson@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Joseph Morrow [Thu, 2 Apr 2015 17:48:02 +0000 (13:48 -0400)]
Allow upload to an Arduino Due device from root of repo scons build.
Support to upload to an Arduino Due device was only added to the internal
CA Layer scons build. This commit mitigates this issue.
Change-Id: I7ffe3d38976b9de12fa987235d0ed1fe5305b6aa
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/615
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Joseph Morrow [Tue, 31 Mar 2015 17:48:35 +0000 (13:48 -0400)]
Changed flag from "-std=c99" to "-std=gnu99" to enable arduino due builds.
This will allow the stack to use asm.
Change-Id: I7565381ea7cc7abf5b71539eb57c0570ae7fced7
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/616
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
vimala.v [Tue, 31 Mar 2015 10:31:46 +0000 (16:01 +0530)]
Support for Arduino Due in CA Layer
1) Sconscript is modifed for Due support.
2) A separate patch(arduino_due_ble.patch) is provided for BLE support.
Change-Id: Ide9894f64a307f1b6c17c19f1009150803458e16
Signed-off-by: vimala.v <vimala.v@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/590
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Erich Keane [Wed, 1 Apr 2015 20:38:17 +0000 (13:38 -0700)]
Wrapping auto-ran unit tests with valgrind.
Along with Jenkins' valgrind publisher plugin, the build server will now
be keeping track of memory leaks that are/can be tracked by the unit
tests.
Change-Id: Ic5f20ef07faa57e4689fa334b628fcd3e44b0f1e
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/621
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
jnashok [Sat, 28 Mar 2015 10:46:39 +0000 (19:46 +0900)]
Removed Token ASCII-char limit and length limit
Currently, the stack has a fixed-size for Tokens (CAToken_t)
which is null terminated and limited to the ASCII character
set. The OIC specification requires that tokens be variable
length up to 8 bytes, not be null terminated, and be the
full binary set.
This change removes the null termination behavior (bad,
since it is binary data, where the NUL is a valid value),
provides for a variable length token, and removes the previous
limit that held us to the printable ASCII character set.
This issue was captured in IOT-380 in JIRA.
Change-Id: I2159dd3202edeff4025c7e1d0de50360b6521e53
Signed-off-by: jnashok <jn.ashok@samsung.com>
Signed-off-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/598
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Jon A. Cruz [Thu, 2 Apr 2015 14:48:30 +0000 (07:48 -0700)]
Added interruption of select() to linux IP reading to allow for proper
stopping.
Added standard mechanism to cleanly interrupt select() calls in linux
network code so that stack shutdown is now immediate.
Among other things this allows for a longer timeout to be used in
select() calls which reduces log spam and increases performance.
Another effect is to clean up unit test performance with a main dev box
gaining more than two orders of magnitude in performance. Stack unit
tests were taking 39 seconds to complete whereas with this change they
complete in less than 1/3rd of a second (1/10th for release builds).
Change-Id: I330b1d7507ab81c5b54677d1ef21434862f63508
Signed-off-by: Jon A. Cruz <jonc@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/635
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Jon A. Cruz [Wed, 1 Apr 2015 07:59:31 +0000 (00:59 -0700)]
Adding base timestamps to linux log output.
This updates logging output on linux to have basic timestamps prepended.
It includes additions of link flag adjustments needed for gcc 4.6.
This currently uses coarse timers to allow for faster response. The
timer type could be switched to normal if testing something more
precise. On some systems tested the resolution was 4ms.
Change-Id: Ief75680bfd17178e4c035ef6a69db00b8c7de73e
Signed-off-by: Jon A. Cruz <jonc@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/622
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Erich Keane [Tue, 31 Mar 2015 22:01:02 +0000 (15:01 -0700)]
Added function pointer validation to InProcClientWrapper
InProcClientWrapper permitted calls with an invalid function
object being sent. This ensures that the parameter is correctly
validated.
Change-Id: If38af50fd6fb3ab2006c0c5cb53dd9af0c42a57b
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/620
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>
Doug Hudson [Tue, 31 Mar 2015 20:15:11 +0000 (16:15 -0400)]
Modifications per RI code review.
- Add function missing headers
- Changed return type to bool where appropriate
- Declared functions that were only used in module as static
Change-Id: I6c4eb32714a5582b6237aa6ab624652c64929fb5
Signed-off-by: Doug Hudson <douglas.hudson@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/617
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Mandeep Shetty <mandeep.shetty@intel.com>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Jon A. Cruz [Mon, 30 Mar 2015 03:22:06 +0000 (20:22 -0700)]
Adding simple internal developer documentation with examples of
integration of graphviz diagrams in doxygen for automatic cross-linking.
Change-Id: Ifcd1869f06c1025cd9192b74f02365280bc929bc
Signed-off-by: Jon A. Cruz <jonc@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/602
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ossama Othman <ossama.othman@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Ossama Othman [Thu, 12 Mar 2015 16:59:11 +0000 (09:59 -0700)]
Fix clean build error.
".sconsign.dblite" should be deleted before running any configuration
tests. Furthermore, do not run configuration tests when running scons
'clean' or 'help' operations.
Change-Id: Iedd97533db808bd2ac401defb38fd5b672649d45
Signed-off-by: Caiwen Zhang<caiwen.zhang@intel.com>
Signed-off-by: Ossama Othman <ossama.othman@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/426
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
jk13 [Mon, 30 Mar 2015 02:36:26 +0000 (11:36 +0900)]
[SSM] Fix Java api comments
Fix Java api comments
Change-Id: I0931eca3e4d3cab1861f3add814a2e9395653d2a
Signed-off-by: jk13 <jihyeok13.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/601
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Mandeep Shetty [Fri, 6 Mar 2015 20:23:42 +0000 (12:23 -0800)]
Fix unobservable resource being observed.
Fix of IOT-343.
Add test to check if resource is observable.
Added comments to make code in ocserverrequest.c
Change-Id: Ie5bb98e7f8bece3f7b8ab9e50998156f7328892c
Signed-off-by: Mandeep Shetty <mandeep.shetty@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/441
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Mandeep Shetty [Mon, 30 Mar 2015 22:30:42 +0000 (15:30 -0700)]
Check valid function pointer before calling.
This fixes IOT - 431.
Check if function pointer to context deleter is valid before calling function.
Change-Id: Ie66a79b14153b3cd09b6fb478307bc5f3d17afcd
Signed-off-by: Mandeep Shetty: <mandeep.shetty@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/609
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Mandeep Shetty [Thu, 19 Mar 2015 22:25:28 +0000 (15:25 -0700)]
Fixed few klockwork issues.
Pointers not being checked before being dereferenced.
Return values of functions being ignored leading to possible dereference
of NULL pointers.
Change-Id: Iaa5507ff6c6e1b310fdba83d0c4e21a884794653
Signed-off-by: Mandeep Shetty <mandeep.shetty@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/518
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Mandeep Shetty [Mon, 23 Mar 2015 22:45:43 +0000 (15:45 -0700)]
Clean up extra characters in logs, validate params.
Validate function parameters. Fixed some style.
Added bounded string function in ocserverrequest::HandleSingleResponse
Change-Id: I7cbda0c88d2a16265e35e8b4ba24f874bc0285c1
Signed-off-by: Mandeep Shetty <mandeep.shetty@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/549
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Charlie Lenahan [Fri, 27 Mar 2015 18:08:13 +0000 (14:08 -0400)]
changes to build CSDK for iOS, make .frameworks
iOS support for the CSDK is still experimental.
Change-Id: Ie5572d5246ffb2f1098437e78f332373eed4d8e9
Signed-off-by: Charlie Lenahan <charlie.lenahan@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/596
Reviewed-by: Patrick Lankswert <patrick.lankswert@intel.com>
Tested-by: Patrick Lankswert <patrick.lankswert@intel.com>
Jon A. Cruz [Thu, 26 Mar 2015 04:41:20 +0000 (21:41 -0700)]
Fix unit test lockup on the build server
Add timeout for a unit test if it takes forever to complete it.
Change-Id: If562cf69db0cc81f20932a99110c28704cbd7129
Signed-off-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Signed-off-by: Jon A. Cruz <jonc@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/536
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Caiwen Zhang [Wed, 25 Mar 2015 03:50:44 +0000 (11:50 +0800)]
Clean Arduino build intermediate files
1) Remove .d files
2) Remove .map file
Change-Id: I866c5542b4bc51f48841588a3a1f880b18439a61
Signed-off-by: Caiwen Zhang<caiwen.zhang@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/569
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Sudarshan Prasad [Mon, 23 Mar 2015 22:27:17 +0000 (15:27 -0700)]
Added comments for a macro.
- This changeset addresses one of the comment from full RI-CA review.
Change-Id: I62b1ffb53104dcc57e8a04e067cafcc34e6bc655
Signed-Off-By: Sudarshan Prasad <sudarshan.prasad@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/550
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Mandeep Shetty [Tue, 17 Mar 2015 20:55:11 +0000 (13:55 -0700)]
Klockwork fixes on C samples
Send MAX_HEADER_OPTION_DATA_LENGTH as buffer size to avoid array bounds
violation by potentially sending a larger size contained in the
optionLength field in received headers.
Change-Id: If9f6ea0688298a2ba7723db67f5082509fad1d5f
Signed-off-by: Mandeep Shetty <mandeep.shetty@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/493
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Caiwen Zhang [Tue, 24 Mar 2015 07:37:12 +0000 (15:37 +0800)]
fix notification manager sample app build error
liboc.so isn't required to be linked when build C application
Otherwise there may be following error:
out/linux/x86_64/release/liboc.so: undefined reference to
`std::__detail::_Prime_rehash_policy::_M_next_bkt(unsigned long)
const@GLIBCXX_3.4.18'
Change-Id: Idbb5ca305c22477aba19495c8e2b8cf5278bd058
Signed-off-by: Caiwen Zhang<caiwen.zhang@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/554
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: minsuk1.choi <minsuk1.choi@samsung.com>
Reviewed-by: JungYong KIM <jyong2.kim@samsung.com>
Reviewed-by: Heewon Parkhi <h_w.park@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Erich Keane [Thu, 26 Mar 2015 23:24:51 +0000 (16:24 -0700)]
Added OCHeaderOption unit tests
Adding a bunch of unit tests to completely validate the functionality
of OCHeaderOption
Change-Id: I53efd7e92b03a371f4a302e743128572195f1c29
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/586
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
Erich Keane [Thu, 26 Mar 2015 22:43:30 +0000 (15:43 -0700)]
Adding OCException unit tests
Adding a bunch of unit tests to validate the functionality of
OCException.
Also removed the unused 'reason' function that didn't use 'this'
Change-Id: I34bac1c06b2bc755a0af19e3ddcc1ac9ae3611fc
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/584
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
Erich Keane [Thu, 26 Mar 2015 21:11:54 +0000 (14:11 -0700)]
Fixed Presence Resource Filter crash
The AddClientCB method would delete the resourceTypeName
before it got a chance to insert it due to the logic designed
to make the free'ing consistent. This fix moves the free until
afterwards. Note that the insert method does NOT makes a copy,
so it is the responsibility of this method to free in the event
that the pointer is not captured.
Change-Id: I9c0c66cfbfb9e8d1ace5df9de372476fbf262659
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/582
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
Sachin Agrawal [Thu, 26 Feb 2015 17:28:56 +0000 (09:28 -0800)]
Updated tinyDTLS test apps to use identity hint
dtls-server test is updated to pass 'psk hint' to tinyDTLS library so that
it can send ServerKeyExchange packet. Similarly, dtls-client test
is updated to retrieve PSK specific for the server whose identity was
received via 'psk hint' packet.
Change-Id: Ifba720f1505ed6afbf56dfc179d98790176ce0b0
Signed-off-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/348
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Seung-Woo Lee <sw0524.lee@samsung.com>
Reviewed-by: Patrick Lankswert <patrick.lankswert@intel.com>
(cherry picked from commit
f5fb7aae180aa04babd2fc1364365b8ae1452efd)
Reviewed-on: https://gerrit.iotivity.org/gerrit/433
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
(cherry picked from commit
a8c761f0b18ecdfe1b4d4fa5d15ccdc2700d8bcc)
Reviewed-on: https://gerrit.iotivity.org/gerrit/597
Sakthivel Samidurai [Thu, 26 Mar 2015 22:43:41 +0000 (15:43 -0700)]
Update C++ Unit test for OCResource
Add unit test for missing OCResource API.
Change-Id: I8434a5410a774a9b95863ab3f6a19844a4a4007b
Signed-off-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/585
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Doug Hudson <douglas.hudson@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Mandeep Shetty [Thu, 26 Mar 2015 23:43:45 +0000 (16:43 -0700)]
Fix return type to enable callback.
UpdateResponseAddr() did not set success as result which caused the
stack to return quietly.
Set response type to OC_STACK_OK so stack can do the callback.
Change-Id: I3958c51f08735d2e7bf30bcefdfbb99255ea69bf
Signed-off-by: Mandeep Shetty <mandeep.shetty@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/587
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Sakthivel Samidurai [Thu, 26 Mar 2015 00:07:24 +0000 (17:07 -0700)]
Update C++ OCPlatform Unit test
Add unit test for external OCPlatform APIs
Change-Id: I0c17134429f99b9a6d28a79b248c92b2ad84b989
Signed-off-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/573
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Doug Hudson <douglas.hudson@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Mandeep Shetty [Tue, 24 Mar 2015 23:55:14 +0000 (16:55 -0700)]
Fix possible buffer overflows & array out of bound
Init char buffer to null so we don't have to keep adding null
characters.
Fixed potential array out of bounds issue in
occollection::HandleBatchInterface()
Change-Id: Ief43e5196fe360e0035f8aff49b15d969fb92b5e
Signed-off-by: Mandeep Shetty <mandeep.shetty@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/568
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Doug Hudson <douglas.hudson@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Erich Keane [Wed, 25 Mar 2015 23:46:28 +0000 (16:46 -0700)]
Explicitly specify OCResourceIdentifier assignments/ctors
The OCResourceIdentifier proxy class depends on compiler rules
to determine validity of constructors and assignments. This patch
correctly explicitly specifies these values.
Note: This patch does NOT change any behavior or functionality, it
solely specifies behavior explicitly rather than implicitly.
Change-Id: I5110cb10e07112e7786c56fedee43f76cfdab3bd
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/572
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
Mandeep Shetty [Thu, 26 Mar 2015 00:16:05 +0000 (17:16 -0700)]
Added check to not add duplicate resourcetype.
Do not add already existing resourcetype and or resource interface to linked list.
Also fixed incorrect logic in insertResourceType().
Change-Id: I43195e8f9d0d6c71274fd7321baf3a02268e2cf2
Signed-off-by: Mandeep Shetty <mandeep.shetty@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/574
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Charlie Lenahan [Thu, 26 Mar 2015 18:08:04 +0000 (14:08 -0400)]
changes to build csdk for os x(darwin)
resolves conflict with ERR_SUCCESS on os x.
rename ERR_????? to OC_ERR_???
Change-Id: I991b1e0aab5fa271c6bfca0a69f8bbbb98ccf610
Signed-off-by: Charlie Lenahan <charlie.lenahan@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/581
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Erich Keane [Tue, 24 Mar 2015 21:16:13 +0000 (14:16 -0700)]
Fixed memory handling of HandleSingleResponse
As identified in the RI code review, the options and token
were leaked and had some interesting behavior if the options count
was zero. This patch corrects those, and repairs some return
values that were inconsistent and detected while chaising the
memory around.
Change-Id: Ica590fefc8702faa7108cc00642cbc2424f402ac
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/564
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Jon A. Cruz [Mon, 23 Mar 2015 07:13:15 +0000 (00:13 -0700)]
Code portability cleanup.
Added required #includes and #defines to allow the code to be compiled without
errors in more situations.
Fixed platform and compiler assumptions that would prevent the code from
compiling successfully under different compilers and platforms. This helps
with building with different compilers or even later versions of current ones.
Added comments documenting resons for the #defines and portability info.
Change-Id: Ia4a943af1d2d06509e46669f952b5e7ca80efaf4
Signed-off-by: Jon A. Cruz <jonc@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/532
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
jk13 [Thu, 26 Mar 2015 08:39:19 +0000 (17:39 +0900)]
[SSM] Modify comments to generate doxygen correctly
1. Modify cpp and java code comments to generate doxygen correctly
Change-Id: I828cebcd4979168e5e9d4de6b8e4defb303e85a8
Signed-off-by: jk13 <jihyeok13.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/579
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Caiwen Zhang [Tue, 24 Mar 2015 07:58:18 +0000 (15:58 +0800)]
Complete to_string function implementation
Change-Id: I34eae18836b59d1f3b723d35e172a0c5f805192c
Signed-off-by: Caiwen Zhang <caiwen.zhang@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/557
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
projects / platform / upstream / iotivity.git / log