erik.corry@gmail.com [Fri, 1 May 2009 12:20:31 +0000 (12:20 +0000)]
Add change accidentally omitted from last changelist.
Review URL: http://codereview.chromium.org/100252
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1832
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
erik.corry@gmail.com [Fri, 1 May 2009 11:16:29 +0000 (11:16 +0000)]
When strings can change from an ASCII representation to a
UC16 representation we need to be careful about flat strings.
Flat strings can be sliced or cons strings that have a flat
string under them, so when we ask a flat cons or a slice whether
it is ASCII or not we should ask the underlying string about
its representation. This should fix
http://code.google.com/p/chromium/issues/detail?id=10971
Review URL: http://codereview.chromium.org/100249
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1830
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
lrn@chromium.org [Fri, 1 May 2009 10:06:55 +0000 (10:06 +0000)]
Made sort on non-arrays also affect elements on the prototype, for JSC compatability.
Made sort on non-objects with inherited elements JSC compatible.
Review URL: http://codereview.chromium.org/99272
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1829
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
iposva@chromium.org [Thu, 30 Apr 2009 17:06:02 +0000 (17:06 +0000)]
Add version.cc and version.h to Xcode project.
Review URL: http://codereview.chromium.org/100211
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1828
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
sgjesse@chromium.org [Thu, 30 Apr 2009 10:30:44 +0000 (10:30 +0000)]
Fixed SCons build when not running from the V8 root directory.
TBR=ager@chromium.org
Review URL: http://codereview.chromium.org/100201
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1827
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
sgjesse@chromium.org [Thu, 30 Apr 2009 09:29:15 +0000 (09:29 +0000)]
Added better version information
The current version is now held in src/version.cc in a number of defines which needs to be modified when changing version.
The following defines make up the version information:
MAJOR_VERSION
MINOR_VERSION
BUILD_NUMBER
PATCH_LEVEL
CANDIDATE_VERSION
The first four are numbers and the fifth is a boolean. Besides these five the define
SONAME
can be used to set a specific soname when building the a shared library (see below). This will most likely be used on stable branches where binary compatibility is ensured between different versions. This define is a string.
This version information is now read by the SCons build to support setting the soname for a Linux shared library. This requires passing the option soname=on to the SCons build.
When soname=on is specified the soname for the shared library can be set in two different ways. Either it will be the full versioned library name (e.g. libv8-1.2.2.so) or a specific soname defined in src/version.cc. Whenever a shared library is build with an soname the filename of the library will hold the full version name (e.g. libv8-1.2.2.so).
I did not update the xcode project with the new files.
BUG=151
Review URL: http://codereview.chromium.org/100104
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1826
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
whesse@chromium.org [Thu, 30 Apr 2009 09:21:50 +0000 (09:21 +0000)]
Improve register allocation of left shift operation. Add tests
for all shift operations.
Review URL: http://codereview.chromium.org/101016
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1825
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ager@chromium.org [Thu, 30 Apr 2009 08:12:32 +0000 (08:12 +0000)]
svn ignore gyp generated files
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1824
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mikhail.naganov@gmail.com [Thu, 30 Apr 2009 08:10:27 +0000 (08:10 +0000)]
Enhancing profiling data processing code with functionality needed for the Dev Tools Profiler.
Details:
- added properties / functions in view objects needed for WebKit's ProfileView;
- added ability to count profiles for specific functions.
The tickprocessor functionality does not affected.
Review URL: http://codereview.chromium.org/99181
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1823
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
lrn@chromium.org [Thu, 30 Apr 2009 07:21:54 +0000 (07:21 +0000)]
Added architecture properties to Windows Scons build.
Made scons build work on windows.
Review URL: http://codereview.chromium.org/100175
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1822
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
asargent@chromium.org [Wed, 29 Apr 2009 21:44:13 +0000 (21:44 +0000)]
Make Object::GetIdentityHash() never return 0.
This is convenient when using identity hashes in data structures that
want to reserve 0 as a sentinel value, such as WebKit's WTF::HashMap.
Review URL: http://codereview.chromium.org/100147
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1821
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
lrn@chromium.org [Wed, 29 Apr 2009 15:20:37 +0000 (15:20 +0000)]
Fix .gyp file and avoid adding -m32 on 32 bit systems.
Fix SConstruct to only add -m32 if the compiler needs it.
Review URL: http://codereview.chromium.org/100160
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1820
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ager@chromium.org [Wed, 29 Apr 2009 14:06:10 +0000 (14:06 +0000)]
Fix the xcode project to define the correct V8_ARCH_*.
TBR=lrn@chromium.org
Review URL: http://codereview.chromium.org/99188
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1819
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
whesse@chromium.org [Wed, 29 Apr 2009 13:57:48 +0000 (13:57 +0000)]
Add a mjsunit test to cover more paths in the ia32 code generator.
Review URL: http://codereview.chromium.org/99187
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1818
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
lrn@chromium.org [Wed, 29 Apr 2009 13:11:48 +0000 (13:11 +0000)]
Create build structure for X64.
Possible to attempt to build for X64.
Build will be unsuccessful, since all x64 source files are
missing and pointers are reinterpreted as integers everywhere.
Review URL: http://codereview.chromium.org/99186
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1817
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
sgjesse@chromium.org [Wed, 29 Apr 2009 12:54:07 +0000 (12:54 +0000)]
Create a transition API for the debug message handler.
Kept the previous message handler API to avoid breaking clients depending on it.
The new message handler API uses a new name ending with 2.
Review URL: http://codereview.chromium.org/100158
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1816
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
sgjesse@chromium.org [Wed, 29 Apr 2009 11:12:58 +0000 (11:12 +0000)]
Remove tab to satisfy lint
TBR=ager@chromium.org
Review URL: http://codereview.chromium.org/99180
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1815
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
erik.corry@gmail.com [Wed, 29 Apr 2009 11:04:28 +0000 (11:04 +0000)]
Unbreak IA32 generated code coverage.
Review URL: http://codereview.chromium.org/100156
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1814
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
sgjesse@chromium.org [Wed, 29 Apr 2009 09:04:20 +0000 (09:04 +0000)]
Re-submit codereview.chromium.org/99122 after fixing compilation issues.
TBR=yurys@chromium.org
Review URL: http://codereview.chromium.org/100155
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1813
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
sgjesse@chromium.org [Wed, 29 Apr 2009 08:33:01 +0000 (08:33 +0000)]
Reverting 1811.
Review URL: http://codereview.chromium.org/99175
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1812
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
sgjesse@chromium.org [Wed, 29 Apr 2009 08:23:58 +0000 (08:23 +0000)]
Changed the debugger message API to receive an object instead of a JSON string.
The object delivered to the debug message handler contains additional information on the current break handling the messages.
Clients which require just JSON message parsing can simply get the JSON using the GetJSON message on the message object to still have the previous behaviour.
NewMessageHangler(const v8::Debug::Message& message) {
v8::String::Value val(message.GetJSON());
OldMessageHandler(Vector<uint16_t>(const_cast<uint16_t*>(*val), val.length()));
}
Refactored some of the debugger code to use internal handles instead of API handles. Also changed Object to JSObject is some places.
The access to the active context when the break occurred is still not implemented. I will add this in a new CL, as this one is quite big already.
Review URL: http://codereview.chromium.org/99122
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1811
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
iposva@chromium.org [Wed, 29 Apr 2009 00:01:51 +0000 (00:01 +0000)]
Fix names after move of architecture dependent files.
TBR=lrn
Review URL: http://codereview.chromium.org/100138
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1810
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
whesse@chromium.org [Tue, 28 Apr 2009 15:14:44 +0000 (15:14 +0000)]
Fix lint error
Review URL: http://codereview.chromium.org/100105
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1809
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
whesse@chromium.org [Tue, 28 Apr 2009 13:53:15 +0000 (13:53 +0000)]
Change MergeTo code for virtual frames to use register indices.
Review URL: http://codereview.chromium.org/99052
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1808
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
kmillikin@chromium.org [Tue, 28 Apr 2009 10:53:47 +0000 (10:53 +0000)]
Add stubbed-out versions of missing member functions on ARM.
TBR=erik.corry@gmail.com
Review URL: http://codereview.chromium.org/99123
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1807
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
kmillikin@chromium.org [Tue, 28 Apr 2009 10:40:36 +0000 (10:40 +0000)]
Inline the inobject property case for named property loads.
Review URL: http://codereview.chromium.org/99120
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1806
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mikhail.naganov@gmail.com [Tue, 28 Apr 2009 09:15:31 +0000 (09:15 +0000)]
Rename profileview.js -> profile_view.js because WebInspector already has ProfileView.js.
Review URL: http://codereview.chromium.org/100102
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1805
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mikhail.naganov@gmail.com [Mon, 27 Apr 2009 13:50:42 +0000 (13:50 +0000)]
TickProcessor script reimplemented in JavaScript.
This is an effort to reuse profiler data processing code both in
TickProcessor and Dev Tools Profiler. The old Python implementation
will be removed.
The new TickProcessor works almost identical to the previous one.
However, it has some differences:
1. Not very useful "Call profile" section is replaced with a new
WebKit-like "Bottom up (heavy) profile" which shows the most
expensive functions together with their callers. I used it
personally in order to find and remove bottlenecks in the
tickprocessor script itself, and found it quite helpful.
2. Code entries with duplicate names (they occur for RegExes, stubs
and sometimes for anonymous Function objects) are now distinguished
by adding an occurence number inside curly brackets.
3. (Address -> code entry) mapping is more precise in boundary cases.
4. Windows version no more requires specifying .map file location.
5. Works faster.
Review URL: http://codereview.chromium.org/99054
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1802
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yurys@chromium.org [Mon, 27 Apr 2009 12:38:20 +0000 (12:38 +0000)]
1. Send 'afterCompile' event to the debug message handler.2. Process messages from the debugger command queue on each event not only break and exception.3. auto_continue is always true for compilation events.
Review URL: http://codereview.chromium.org/100034
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1801
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
lrn@chromium.org [Mon, 27 Apr 2009 11:16:59 +0000 (11:16 +0000)]
Fix Issue 326. Handle sorting of non-array objects correctly.
Change handling of sorting to be the same for all JS-arrays.
Collect undefined values as well while removing holes.
Review URL: http://codereview.chromium.org/92123
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1800
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
erik.corry@gmail.com [Mon, 27 Apr 2009 10:52:44 +0000 (10:52 +0000)]
Remove dependency on libstdc++ from test framework.
Review URL: http://codereview.chromium.org/99051
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1799
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
erik.corry@gmail.com [Mon, 27 Apr 2009 09:27:18 +0000 (09:27 +0000)]
Lint.
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1798
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ager@chromium.org [Mon, 27 Apr 2009 09:14:19 +0000 (09:14 +0000)]
Prepare push of version 1.2.1 to trunk. The main reason for this push
is to get the chromium V8-latest builder working again and to move the
gyp file used for the chromium build to V8 to make it easier to roll
V8 DEPS.
Review URL: http://codereview.chromium.org/99049
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1796
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ager@chromium.org [Mon, 27 Apr 2009 09:04:39 +0000 (09:04 +0000)]
Add gyp file to v8 repository.
Gyp is used to generate project files used to build chromium. Moving
the v8.gyp file to the v8 repository makes it easier to have V8 and
the v8.gyp file synchronized (so a DEPS update in chromium gets the
right v8.gyp file associated with that revision of V8).
Review URL http://codereview.chromium.org/100035
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1795
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
erik.corry@gmail.com [Mon, 27 Apr 2009 07:03:10 +0000 (07:03 +0000)]
Fix bugs 145 and 323, preemption and apply on ARM.
Review URL: http://codereview.chromium.org/93121
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1794
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
sgjesse@chromium.org [Fri, 24 Apr 2009 14:29:42 +0000 (14:29 +0000)]
Changed the ASSERT's in the cctest's to CHECK's.
There are no ASSERTS left in the cctest's.
Review URL: http://codereview.chromium.org/93120
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1793
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ager@chromium.org [Fri, 24 Apr 2009 13:18:40 +0000 (13:18 +0000)]
Fix V8 xcode build.
Let xcode fix a couple of things and add json-delay.js to the project.
Review URL: http://codereview.chromium.org/93122
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1792
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
erik.corry@gmail.com [Fri, 24 Apr 2009 12:56:58 +0000 (12:56 +0000)]
Fix Android build after arch-subdir reorganisation.
Review URL: http://codereview.chromium.org/94008
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1791
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
christian.plesner.hansen@gmail.com [Fri, 24 Apr 2009 12:45:29 +0000 (12:45 +0000)]
- When cloning maps to set the 'lazy loading' bit remember to clone
the properties as well. This fixes some failing tests.
- Moved json parsing into native code.
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1789
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
sgjesse@chromium.org [Fri, 24 Apr 2009 12:05:40 +0000 (12:05 +0000)]
Removed the debug message thread.
The debug message thread was introduced to make it possible to have the message handler callback be called from a different thread than the thread running V8 where the debug event occoured, but it never had any practical use, and prevents providing information to the message handler which is only available from the V8 thread.
In the future any thread decoupling will have do be done by the embedder.
This also removes the queue used for outbound messages.
Renamed the class Message to CommandMessage as it is only used for debugger commands from the client. Related message queue classes has also been renamed.
Review URL: http://codereview.chromium.org/93118
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1788
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mikhail.naganov@gmail.com [Fri, 24 Apr 2009 11:37:38 +0000 (11:37 +0000)]
Added ProfileView object for performing sorting, searching and filtering operations on a profile.
It will be used both in the new tickprocessor and Dev Tools profiler.
Review URL: http://codereview.chromium.org/92120
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1786
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
kmillikin@chromium.org [Fri, 24 Apr 2009 11:26:49 +0000 (11:26 +0000)]
Materializing a frame element on the stack by pushing it can cause the
stack pointer to change by more than one in a corner case. If we push
a constant smi larger than 16 bits, we push it via a temporary
register. Allocating the temporary can cause a register to be spilled
from the frame somewhere above the stack pointer.
As a fix, do not use pushes to materialize ranges of elements of size
larger than one.
Review URL: http://codereview.chromium.org/92121
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1785
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
christian.plesner.hansen@gmail.com [Fri, 24 Apr 2009 08:13:09 +0000 (08:13 +0000)]
- Extended lazy loading to general objects, not just functions.
- Added lazily loaded JSON object.
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1784
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
lrn@chromium.org [Thu, 23 Apr 2009 12:06:38 +0000 (12:06 +0000)]
Move backend specific files to separate directories.
Move ia32 and arm specific files to subdirectories to make it easier to add more backends.
Review URL: http://codereview.chromium.org/92068
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1782
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
erik.corry@gmail.com [Thu, 23 Apr 2009 07:52:38 +0000 (07:52 +0000)]
2nd try at fixing coverage of inline keyed access on IA32.
Review URL: http://codereview.chromium.org/92067
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1780
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ager@chromium.org [Thu, 23 Apr 2009 07:32:25 +0000 (07:32 +0000)]
Prepare to push version 1.2.0 to trunk. Now worker on version 1.2.1.
Review URL: http://codereview.chromium.org/92066
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1779
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
erik.corry@gmail.com [Thu, 23 Apr 2009 05:45:40 +0000 (05:45 +0000)]
Remove if inside contradictory if.
Review URL: http://codereview.chromium.org/93059
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1777
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
kmillikin@chromium.org [Wed, 22 Apr 2009 17:44:28 +0000 (17:44 +0000)]
Fix regression test by wrapping expression in a thunk^H^H^H^H^Hstring.
Review URL: http://codereview.chromium.org/95001
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1776
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
erik.corry@gmail.com [Wed, 22 Apr 2009 15:20:25 +0000 (15:20 +0000)]
Mark failing test on ARM.
Review URL: http://codereview.chromium.org/92014
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1775
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
pfeldman@chromium.org [Wed, 22 Apr 2009 14:16:50 +0000 (14:16 +0000)]
DevTools: Add support for eventless host message dispatching.
Review URL: http://codereview.chromium.org/87026
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1773
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
erik.corry@gmail.com [Wed, 22 Apr 2009 14:09:50 +0000 (14:09 +0000)]
Make a test that excercises the preemption code in apply().
Review URL: http://codereview.chromium.org/93015
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1772
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
sgjesse@chromium.org [Wed, 22 Apr 2009 14:00:12 +0000 (14:00 +0000)]
Use CollectAllGarbage for the gc() extension.
Review URL: http://codereview.chromium.org/5666
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1771
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
sgjesse@chromium.org [Wed, 22 Apr 2009 13:59:48 +0000 (13:59 +0000)]
Add setting break points by using handles.
Extend the D8 break command to handle script names with :line[:column] position specification and handles using #<id>#.
Review URL: http://codereview.chromium.org/92011
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1770
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
erik.corry@gmail.com [Wed, 22 Apr 2009 13:34:35 +0000 (13:34 +0000)]
Small changes to improve test coverage in codegen-ia32.cc.
Review URL: http://codereview.chromium.org/92008
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1769
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
kmillikin@chromium.org [Wed, 22 Apr 2009 13:19:38 +0000 (13:19 +0000)]
When merging a frame to an expected on at block entry, the static type
of elements is set to a safe lower bound. Move the setting of the
static type out of VirtualFrame::MergeTo (which is not necessarily run
for all frames) and into VirtualFrame::PrepareMergeTo (which is).
Review URL: http://codereview.chromium.org/92009
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1767
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yurys@chromium.org [Wed, 22 Apr 2009 13:04:19 +0000 (13:04 +0000)]
This issue was introduced by codereview.chromium.org/67266
Review URL: http://codereview.chromium.org/93014
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1766
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
lrn@chromium.org [Wed, 22 Apr 2009 11:43:05 +0000 (11:43 +0000)]
Fix for Issue 317 - bug in string.replace(string, "$foo").
Fix for Issue 317. Replace string with something containing dollar now works.
Review URL: http://codereview.chromium.org/94002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1764
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
sgjesse@chromium.org [Wed, 22 Apr 2009 11:41:19 +0000 (11:41 +0000)]
Change the expectations of the ARM debugger tests once more
A couple of the tests actually passes now.
Review URL: http://codereview.chromium.org/93011
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1763
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
sgjesse@chromium.org [Wed, 22 Apr 2009 11:39:47 +0000 (11:39 +0000)]
Add missing files to the Visual Studio ARM simulator project.
Review URL: http://codereview.chromium.org/93007
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1762
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
erik.corry@gmail.com [Wed, 22 Apr 2009 09:25:41 +0000 (09:25 +0000)]
Abolish kDebug and use ifdef DEBUG throughout for consistency.
Review URL: http://codereview.chromium.org/94001
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1761
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
sgjesse@chromium.org [Wed, 22 Apr 2009 09:01:13 +0000 (09:01 +0000)]
Enable flaky test that was fixed some time ago.
Review URL: http://codereview.chromium.org/80001
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1760
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
sgjesse@chromium.org [Wed, 22 Apr 2009 08:54:59 +0000 (08:54 +0000)]
Change the expectations of the ARM debugger tests.
Previous change r1756 caused some ARM debugger tests to fail instead of crash in release mode.
Review URL: http://codereview.chromium.org/93005
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1759
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ager@chromium.org [Wed, 22 Apr 2009 07:38:08 +0000 (07:38 +0000)]
Adding hidden values always turned the object slow case because the
hidden symbol is not an identifier. Make sure to keep objects fast
case when adding hidden values if possible.
Review URL: http://codereview.chromium.org/93004
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1758
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
sgjesse@chromium.org [Tue, 21 Apr 2009 14:48:54 +0000 (14:48 +0000)]
Handle breaks on keyed IC loads which can have an inlined version.
For keyed IC loads setting a break point now ensures that the inlined code is not used. When the break point is set the inlined map check is changed to fail causing the inlined code not to be used but the IC to be called. As long at the break point is set the map check will stay invalid.
Review URL: http://codereview.chromium.org/87025
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1756
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yurys@chromium.org [Tue, 21 Apr 2009 14:06:48 +0000 (14:06 +0000)]
As long as all debugger messages are handled by a single static method we need a way to identify request sender to route the response to the right handler. To accomplish this clients can send some additional data along with command text and debugger will later pass this data to the message handler along with the response text.
Review URL: http://codereview.chromium.org/67266
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1755
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
erik.corry@gmail.com [Tue, 21 Apr 2009 13:42:12 +0000 (13:42 +0000)]
* Add code to check coverage of generated code on IA32 port.
* Move ARM coverage code to ARM-specific file and add missing
file to cover.
Review URL: http://codereview.chromium.org/88025
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1754
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
christian.plesner.hansen@gmail.com [Tue, 21 Apr 2009 13:28:34 +0000 (13:28 +0000)]
review
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1753
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
christian.plesner.hansen@gmail.com [Tue, 21 Apr 2009 13:28:22 +0000 (13:28 +0000)]
doc
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1752
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
christian.plesner.hansen@gmail.com [Tue, 21 Apr 2009 13:28:11 +0000 (13:28 +0000)]
force-set
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1751
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
lrn@chromium.org [Tue, 21 Apr 2009 11:25:51 +0000 (11:25 +0000)]
Reduced size of Array.reduce test.
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1750
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
lrn@chromium.org [Tue, 21 Apr 2009 09:57:30 +0000 (09:57 +0000)]
Add ES5 Array methods reduce and reduceRight, with test.
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1749
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
sgjesse@chromium.org [Tue, 21 Apr 2009 07:22:06 +0000 (07:22 +0000)]
Make it possible to add a user data object to each script compiled.
Review URL: http://codereview.chromium.org/90003
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1748
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
feng@chromium.org [Mon, 20 Apr 2009 17:44:39 +0000 (17:44 +0000)]
Fix style issues caught by presubmit script.
TBR = erikcorry
Review URL: http://codereview.chromium.org/83004
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1746
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
feng@chromium.org [Mon, 20 Apr 2009 16:36:13 +0000 (16:36 +0000)]
Add ENABLE_DEBUGGER_SUPPORT macro.
ENABLE_DEBUGGER_SUPPORT is enabled by default unless it is on Android platform.
On Android platform, it can also enabled by passing -DENABLE_DEBUGGER_SUPPORT flag to the compiler.
This should not affect any existing build (I hope, cross my fingers) except the build in real Android environment (in other word, it only affects me now).
There are lot of room for code refactoring in stead of using #ifdef all over the place. I will leave this to v8 folks.
Review URL: http://codereview.chromium.org/77035
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1745
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
sgjesse@chromium.org [Mon, 20 Apr 2009 12:15:27 +0000 (12:15 +0000)]
Remove unused runtime function.
The CompileScript runtime function is not used by any builtins any more.
Review URL: http://codereview.chromium.org/80003
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1744
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ager@chromium.org [Mon, 20 Apr 2009 09:40:08 +0000 (09:40 +0000)]
Correct the marking of tests that only fail on the simulator.
Review URL: http://codereview.chromium.org/80002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1743
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
sgjesse@chromium.org [Sat, 18 Apr 2009 00:03:15 +0000 (00:03 +0000)]
Add an option to the SCons build to control Microsoft Visual C++ link-time code generation.
Turning off Microsoft Visual C++ link-time code generation makes linking on Windows significantly which is convenient during development. There has also been a request from embedders for a way to control this for embedding application which does not use link-time code generation.
The name of the option is msvcltcg and the default value is 'on' to keep the same behaviour as before.
Review URL: http://codereview.chromium.org/69026
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1742
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
iposva@chromium.org [Fri, 17 Apr 2009 21:04:34 +0000 (21:04 +0000)]
Add a "read" extension to the shell programs. This global function
reads the contents of a file into a string and returns it.
Review URL: http://codereview.chromium.org/67262
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1741
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mikhail.naganov@gmail.com [Fri, 17 Apr 2009 17:58:14 +0000 (17:58 +0000)]
Implemented a CSV parser in JavaScript.
Review URL: http://codereview.chromium.org/67253
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1740
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mikhail.naganov@gmail.com [Fri, 17 Apr 2009 17:40:52 +0000 (17:40 +0000)]
Implemented Profile object that processes profiling events and calculates profiling data.
Review URL: http://codereview.chromium.org/77014
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1739
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
erik.corry@gmail.com [Fri, 17 Apr 2009 14:34:35 +0000 (14:34 +0000)]
Improve coverage of line 619 in stub-cache-arm.cc
Review URL: http://codereview.chromium.org/77028
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1738
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
erik.corry@gmail.com [Fri, 17 Apr 2009 13:57:15 +0000 (13:57 +0000)]
Lint.
Review URL: http://codereview.chromium.org/77026
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1737
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
erik.corry@gmail.com [Fri, 17 Apr 2009 13:27:36 +0000 (13:27 +0000)]
* Remove unused code from codegen-arm.cc
* Fix fp ops on pre-EABI ARM targets.
* Fix missing TIMEVAL_TO_TIMESPEC on Android.
Review URL: http://codereview.chromium.org/77025
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1736
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ager@chromium.org [Fri, 17 Apr 2009 09:17:04 +0000 (09:17 +0000)]
If an external string enters the symbol table, make sure to set the
resource to NULL when removing it from the symbol table. This makes
sure that the debugger can recognize the external string as being
"deleted". Now, whenever an external resource is deleted, the
resource pointer is set to NULL.
This is really a workaround of a debugger problem. We need to make
sure that the debugger only finds scripts in the heap that are
actually live.
Review URL: http://codereview.chromium.org/69029
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1734
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
iposva@chromium.org [Fri, 17 Apr 2009 00:57:21 +0000 (00:57 +0000)]
- Fix buffer overflow in the pre-allocated memory thread.
Review URL: http://codereview.chromium.org/67248
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1733
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
iposva@chromium.org [Fri, 17 Apr 2009 00:56:52 +0000 (00:56 +0000)]
- Fix delta time calculation in LinuxSemaphore::Wait.
Review URL: http://codereview.chromium.org/69024
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1732
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
sgjesse@chromium.org [Fri, 17 Apr 2009 00:15:12 +0000 (00:15 +0000)]
Fix building of snapshots on Windows.
The romoval of _HAS_EXCEPTIONS=0 from the source files was not fully complemented with changes to the compiler flags used for mksnapshot.
Review URL: http://codereview.chromium.org/67242
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1731
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
iposva@chromium.org [Thu, 16 Apr 2009 21:01:05 +0000 (21:01 +0000)]
Start addressing massive arrays on the stack. There is hardly ever
a reason to stack allocate large chunks of stack space.
- Runtime_GetCFrames used to allocate a frame size of 52040 bytes.
- PreallocatedMemoryThread::Run used to allocate 32784 bytes.
- Fixed StringStream overflow conditions.
Review URL: http://codereview.chromium.org/67197
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1729
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mikhail.naganov@gmail.com [Thu, 16 Apr 2009 17:30:27 +0000 (17:30 +0000)]
Remove unused CodeRegion class and corresponding logging functions.
Review URL: http://codereview.chromium.org/67221
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1728
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mikhail.naganov@gmail.com [Thu, 16 Apr 2009 16:34:24 +0000 (16:34 +0000)]
Allow multiple function literals to be assigned to the same var / property.
In such a case all functions get the same name. I think it's a good performance / usability tradeoff. In case a developer wants more clarity, it's up to him to give names to functions.
Review URL: http://codereview.chromium.org/67168
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1727
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mikhail.naganov@gmail.com [Thu, 16 Apr 2009 16:05:17 +0000 (16:05 +0000)]
Reimplement (address -> code) mapping from tickprocessor.py in JS.
Found a pair of bugs concerned with border cases in the original implementation.
Review URL: http://codereview.chromium.org/67191
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1726
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ager@chromium.org [Thu, 16 Apr 2009 13:46:55 +0000 (13:46 +0000)]
Migrate a couple of old tests to mjsunit tests.
Review URL: http://codereview.chromium.org/67215
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1725
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ager@chromium.org [Thu, 16 Apr 2009 12:58:14 +0000 (12:58 +0000)]
Fix lint. Accidentally commited a reindentation of a parameter list
that introduced line that was too long.
Review URL: http://codereview.chromium.org/67214
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1724
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
erik.corry@gmail.com [Thu, 16 Apr 2009 12:12:47 +0000 (12:12 +0000)]
Don't blindly use blx instruction without knowing whether the CPU supports it.
Review URL: http://codereview.chromium.org/67213
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1723
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ager@chromium.org [Thu, 16 Apr 2009 11:30:55 +0000 (11:30 +0000)]
Change the enumeration order for unsigned integer keys to always be
numerical order independently of the representation of the object.
Exchanged the order of enumeration of integer and string keys so
integer keys are first instead of string keys to better match
WebKit/JSC behavior.
Added test cases that document our enumeration order choice.
Review URL: http://codereview.chromium.org/75035
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1722
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
kmillikin@chromium.org [Thu, 16 Apr 2009 11:30:00 +0000 (11:30 +0000)]
Remove some unused macros from objects.cc.
Review URL: http://codereview.chromium.org/67211
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1721
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
erik.corry@gmail.com [Thu, 16 Apr 2009 09:30:23 +0000 (09:30 +0000)]
Avoid a call to the runtime system when doing binary fp ops on ARM
(at the moment only if we do not need to allocate a heap number).
Find a few more oportunities to avoid heap number allocation on IA32.
Add some infrastructure to test coverage of generated ARM code in our
tests.
Review URL: http://codereview.chromium.org/67163
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1720
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yurys@chromium.org [Thu, 16 Apr 2009 06:03:17 +0000 (06:03 +0000)]
Lookup can now be performed for several handles.
Review URL: http://codereview.chromium.org/67155
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1719
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
sgjesse@chromium.org [Wed, 15 Apr 2009 19:09:38 +0000 (19:09 +0000)]
Add debug command break flag for debugger host dispatch.
Ensure that debugger host dispatch is processed even though there are no debugger commands in the queue.
Review URL: http://codereview.chromium.org/67180
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1718
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
kasperl@chromium.org [Wed, 15 Apr 2009 13:16:51 +0000 (13:16 +0000)]
Prepare a push to trunk (version 1.1.10).
Review URL: http://codereview.chromium.org/67167
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1716
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00