platform/upstream/gstreamer.git
2 years agodecodebin3: Handle upstream selection
Edward Hervey [Fri, 28 May 2021 05:49:10 +0000 (07:49 +0200)]
decodebin3: Handle upstream selection

Detect if upstream handles stream-selection, and if so bypass all stream
selection handling (streams are forwarded as-is).

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1905>

2 years agoquery: Add a new stream selection query
Edward Hervey [Wed, 30 Mar 2022 08:01:33 +0000 (10:01 +0200)]
query: Add a new stream selection query

This new API allows querying whether elements can handle stream selection
themselves or not.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1905>

2 years agoci: Don't tie up a full job slot for cerbero trigger
Daniel Stone [Wed, 30 Mar 2022 09:52:53 +0000 (10:52 +0100)]
ci: Don't tie up a full job slot for cerbero trigger

We don't have a huge amount of capacity on shared runners, so better if
we don't use that limited capacity on a job which sits there doing
~nothing.

There is a new runner class called 'placeholder-job' which accepts a
huge number of parallel jobs, separately to normal jobs, on the
assumption that they will consume ~no resources; start using that.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2071>

2 years agova: Don't expose internal classes.
Víctor Manuel Jáquez Leal [Wed, 30 Mar 2022 05:03:59 +0000 (07:03 +0200)]
va: Don't expose internal classes.

VA allocators and pools classes don't need to be exposed as external
symbols.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2070>

2 years agogstplay: don't print error log in warning_cb
Haihua Hu [Wed, 30 Mar 2022 04:01:20 +0000 (12:01 +0800)]
gstplay: don't print error log in warning_cb

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2069>

2 years agovapostproc: Build classification dynamically.
Víctor Manuel Jáquez Leal [Tue, 29 Mar 2022 18:14:40 +0000 (20:14 +0200)]
vapostproc: Build classification dynamically.

By default, the classification is
"Converter/Filter/Colorspace/Scaler/Video/Hardware", but if VA
post-processor driver supports either color balance, skin tone
enhancement, sharpening or noise reduction, "Effect" is added.

Thus, if vapostproc ranking is raised, it can be chosen by
autovideosink.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2066>

2 years agowebrtc: produce stats for all relevant streams
Matthew Waters [Mon, 21 Feb 2022 03:02:52 +0000 (14:02 +1100)]
webrtc: produce stats for all relevant streams

Instead of only using the last ssrc that was pushed into a sink pad.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1664>

2 years agowebrtc: avoid different versions of gnu-indent always wanting to change !!
Matthew Waters [Fri, 11 Feb 2022 05:50:42 +0000 (16:50 +1100)]
webrtc: avoid different versions of gnu-indent always wanting to change !!

Add some sneaky parenthesis to avoid always having to use git commit -n
or revert out hunk of the change.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1664>

2 years agowebrtc: implement initial simulcast fec/rtx usage
Matthew Waters [Fri, 26 Nov 2021 11:04:14 +0000 (22:04 +1100)]
webrtc: implement initial simulcast fec/rtx usage

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1664>

2 years agowebrtc/datachannel: fix use-after-free in sctp state notification
Matthew Waters [Fri, 26 Nov 2021 11:11:06 +0000 (22:11 +1100)]
webrtc/datachannel: fix use-after-free in sctp state notification

g_signal_disconnect*() doesn't stop any existing callbacks from running
which means that if the notify::state callback is in progress in one
thread and the data channel object is finalize()ed in another thread,
then there could be a use-after-free trying lock the data channel
object.

We can't reasonably use a GWeakRef as we don't have a 'parent' object to
free the GWeakRef after the data channel is finalized.  This is also
complicated by the fact that the application can hold a reference to the
data channel object that would live beyond the lifetime of webrtcbin
itself.

We solve this by implementing a ghetto weak-ref solution internally with
a list of outstanding data channels.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1664>

2 years agotests/webrtc: fix a use-after-free in test_data_channel_close
Matthew Waters [Fri, 26 Nov 2021 11:06:39 +0000 (22:06 +1100)]
tests/webrtc: fix a use-after-free in test_data_channel_close

g_object_weak_ref() is not thread-safe and the data channel object's
refs/unrefs can happen on multiple threads.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1664>

2 years agotests/webrtc: fix a race in the tests related to state tracking
Matthew Waters [Fri, 26 Nov 2021 10:51:57 +0000 (21:51 +1100)]
tests/webrtc: fix a race in the tests related to state tracking

If things progress fast enough, some state changes may not be seen be
the waiting code.

Fix by:
1. keeping a list of all the state changes
2. waiting checks each entry and if the relevant state is found, all
   states up to and including then are removed.

This ensures that any waits will see all the state sets.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1664>

2 years agotests/webrtc: factor out src pad property checking to a separate function
Matthew Waters [Thu, 25 Nov 2021 15:00:12 +0000 (02:00 +1100)]
tests/webrtc: factor out src pad property checking to a separate function

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1664>

2 years agowebrtcbin: initial support for sending and receiving simulcast streams
Matthew Waters [Tue, 16 Nov 2021 08:27:11 +0000 (19:27 +1100)]
webrtcbin: initial support for sending and receiving simulcast streams

Input (sink pads) is the already-ssrc-muxed stream with the relevant rtp
sdes header extensions already applied:
  - mid
  - stream-id
  - repaired-stream-id

Output (src pads) have the pads separated into individual ssrc's as
that's what rtpbin gives us.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1664>

2 years agotests/webrtc: test for enabled bundled fec/rtx
Matthew Waters [Tue, 16 Nov 2021 07:11:49 +0000 (18:11 +1100)]
tests/webrtc: test for enabled bundled fec/rtx

Doesn't actually check that any fec/rtx happens, just that the pipeline
is vaguely sane and doesn't error.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1664>

2 years agowebrtcbin: support multiple received streams for a single mline
Matthew Waters [Tue, 16 Nov 2021 06:39:18 +0000 (17:39 +1100)]
webrtcbin: support multiple received streams for a single mline

Each rtpbin exposed recv_src pad is now exposed as webrtcbin src_%u pad
now with no meaining applied to the value of %u.  Previously this used
to mean the mline in the SDP.  If this is is still required, then the
transceiver can be retrieved from the pad and the "mlineindex" property
from the transciever.  The "mid" is also retrievable from the
transceiver.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1664>

2 years agowebrtc: explicitly error out in a couple of renegotiation cases
Matthew Waters [Tue, 16 Nov 2021 06:28:04 +0000 (17:28 +1100)]
webrtc: explicitly error out in a couple of renegotiation cases

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1664>

2 years agowebrtc/transportstream: add debug category
Matthew Waters [Tue, 16 Nov 2021 06:21:31 +0000 (17:21 +1100)]
webrtc/transportstream: add debug category

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1664>

2 years agotests/webrtc: also check valid mline for srcpad codec-preferences negotiation
Matthew Waters [Wed, 3 Nov 2021 10:18:53 +0000 (21:18 +1100)]
tests/webrtc: also check valid mline for srcpad codec-preferences negotiation

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1664>

2 years agowebrtcbin: don't name src pads based on the mline specifically anymore
Matthew Waters [Wed, 3 Nov 2021 09:46:23 +0000 (20:46 +1100)]
webrtcbin: don't name src pads based on the mline specifically anymore

Naming based on the mline doesn't really work with e.g. simulcast
scenarios.

It is entirely possible to retrieve the transceiver and then the mline
from that if that is so required.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1664>

2 years agowebrtc/tests: print the correct media idx on error
Matthew Waters [Fri, 29 Oct 2021 07:40:04 +0000 (18:40 +1100)]
webrtc/tests: print the correct media idx on error

Instead of the attribute index

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1664>

2 years agowebrtc/tests: give slightly better names to the dot file dumps
Matthew Waters [Fri, 29 Oct 2021 07:38:37 +0000 (18:38 +1100)]
webrtc/tests: give slightly better names to the dot file dumps

Don't use printf-specifiers with g_strconcat().

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1664>

2 years agowebrtcbin: improve some debugging output
Matthew Waters [Wed, 21 Jul 2021 07:48:34 +0000 (17:48 +1000)]
webrtcbin: improve some debugging output

- Put human readable names into debug strings.
- Demote some frequent rtpbin signal logging
- Don't use GST_PTR_FORMAT in g_set_error()

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1664>

2 years agowebrtcbin: silence spurious warning when creating answer transceiver
Matthew Waters [Wed, 21 Jul 2021 07:39:11 +0000 (17:39 +1000)]
webrtcbin: silence spurious warning when creating answer transceiver

When creating a transceiver when creating an answer, the media kind of the
transceiver was never set correctly initially.  This would lead to a
GST_WARNING being produced about changin a transceiver's media kind.

Fix by retrieving the GstSDPMedia kind from the offer instead as the answer
GstSDPMedia has not been set as the answer caps have not been chosen yet.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1664>

2 years agotests/webrtc: always use a unique SSRC for each stream
Matthew Waters [Wed, 21 Jul 2021 04:29:35 +0000 (14:29 +1000)]
tests/webrtc: always use a unique SSRC for each stream

Will become more relevant with mid/rid->ssrc mappings

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1664>

2 years agowebrtcbin: add a specific find_transceiver_by_mid function
Matthew Waters [Wed, 21 Jul 2021 04:14:30 +0000 (14:14 +1000)]
webrtcbin: add a specific find_transceiver_by_mid function

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1664>

2 years agowebrtcbin: explicitly use a variable for the rtp session idx
Matthew Waters [Tue, 20 Jul 2021 10:17:13 +0000 (20:17 +1000)]
webrtcbin: explicitly use a variable for the rtp session idx

Slightly clearer in meaning.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1664>

2 years agowebrtcbin: support using an a=mid value from the sink/transceiver caps
Matthew Waters [Thu, 1 Jul 2021 05:54:34 +0000 (15:54 +1000)]
webrtcbin: support using an a=mid value from the sink/transceiver caps

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1664>

2 years agova: Set <gst/va/gstva.h> as library single point entry header.
Víctor Manuel Jáquez Leal [Fri, 25 Mar 2022 14:56:01 +0000 (15:56 +0100)]
va: Set <gst/va/gstva.h> as library single point entry header.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2048>

2 years agova: Move allocators and pool objects into gstva library.
He Junyan [Wed, 23 Feb 2022 07:40:19 +0000 (15:40 +0800)]
va: Move allocators and pool objects into gstva library.

In order to other plugins use gstva objects, such as allocators and buffer
pools, this merge request move them from the va plugin to the gstva library.

This objects are not exposed in <gst/va/gstva.h> since they are not expected
to be used by users, only by plugin implementators.

Because of the surface copy design, which is used to implement allocator's
mem_copy() virtual function, depends on the vafilter, which is kept inside
the plugin, memory copy through VAPosproc is disabled and removed temporarly.

Also added some missing parameter validation.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2048>

2 years agova: Move the video format functions into gstlibva.
He Junyan [Wed, 23 Feb 2022 07:25:08 +0000 (15:25 +0800)]
va: Move the video format functions into gstlibva.

Untabifying header file.

The logging category was moved from the plugin generic category to
the display category. It can argue that video formats hacks are
display dependant.

Added validations for input parameters.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2048>

2 years agomeson: Add some messages when selecting libsoup
Nirbheek Chauhan [Fri, 25 Mar 2022 19:32:02 +0000 (01:02 +0530)]
meson: Add some messages when selecting libsoup

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2032>

2 years agosoup: Fix usage of symbols / defines that are gone in libsoup3
Nirbheek Chauhan [Fri, 25 Mar 2022 19:29:12 +0000 (00:59 +0530)]
soup: Fix usage of symbols / defines that are gone in libsoup3

I am not sure about the SOUP_MESSAGE_OVERWRITE_CHUNKS change, but it
was definitely already broken when using libsoup-3.0 in a shared
build. souphttpsrc probably needs to be ported from SoupMessage to
SoupServerMessage when using libsoup-3.0.

Fixes https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/1111

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2032>

2 years agosoup: Fix pre-processor macros in souploader for libsoup-3.0
Nirbheek Chauhan [Fri, 25 Mar 2022 19:26:04 +0000 (00:56 +0530)]
soup: Fix pre-processor macros in souploader for libsoup-3.0

Some of the preprocessor conditionals in the loader were very broken
with libsoup-3.0 + --default-library=static

Fixes https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/1111

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2032>

2 years agopbutils: Fix wmv screen detection
Edward Hervey [Mon, 28 Mar 2022 10:13:12 +0000 (12:13 +0200)]
pbutils: Fix wmv screen detection

strncmp vs !strncmp :)

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2050>

2 years agoges: remove memory leak with description
Stéphane Cerveau [Mon, 28 Mar 2022 11:47:52 +0000 (13:47 +0200)]
ges: remove memory leak with description

free the capsdesc

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2047>

2 years agonle: clear seek event properly
Stéphane Cerveau [Mon, 28 Mar 2022 11:20:40 +0000 (13:20 +0200)]
nle: clear seek event properly

Use gst_clear_event instead of g_clear_object
avoiding a failing gobject unref

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2047>

2 years agoqsvencoder: Add support for dynamic bitrate update
Seungha Yang [Sun, 27 Mar 2022 14:27:54 +0000 (23:27 +0900)]
qsvencoder: Add support for dynamic bitrate update

... and add more encoding options.

QSV API supports dynamic bitrate change without IDR insertion.
That's more efficient way of runtime encoding option update
than starting from new sequence with IDR per bitrate option change.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2039>

2 years agoqsvh265enc: Add missing gop-size property
Seungha Yang [Fri, 25 Mar 2022 14:15:33 +0000 (23:15 +0900)]
qsvh265enc: Add missing gop-size property

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2039>

2 years agoqsv: Fix mfxFrameAllocator::Lock for encoder
Seungha Yang [Fri, 25 Mar 2022 12:13:22 +0000 (21:13 +0900)]
qsv: Fix mfxFrameAllocator::Lock for encoder

Only read map is possible for encoder input system memory

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2039>

2 years agopython: Add a suppression file for a leak in PyGObject
Thibault Saunier [Tue, 29 Mar 2022 16:43:56 +0000 (18:43 +0200)]
python: Add a suppression file for a leak in PyGObject

And ensure that the CI runs GES valgrind test when we change the
overrides as many GES tests are implemented in python

Proper fix is at: https://gitlab.gnome.org/GNOME/pygobject/-/merge_requests/204

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2060>

2 years agoavviddec: Remove vc1/wmv3 override
Edward Hervey [Tue, 29 Mar 2022 07:36:06 +0000 (09:36 +0200)]
avviddec: Remove vc1/wmv3 override

FFMPEG 5+ doesn't allow overriding the codec anymore (causes a segfault if you
attempt to do that). But the best part is ... that with the current caps
implementation in pad template and gst_ffmpeg_caps_to_codecid() we would never
replace it by anything different than the existing codec id.

Fixes #1054

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2052>

2 years agodocs: Fix doc generation example
Edward Hervey [Tue, 29 Mar 2022 07:24:55 +0000 (09:24 +0200)]
docs: Fix doc generation example

They need to be generated from the devenv else it just hangs for no reason.

See #1108

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2051>

2 years agopython: Add support for the GstURIHandlerInterface
Thibault Saunier [Mon, 6 Dec 2021 22:27:24 +0000 (19:27 -0300)]
python: Add support for the GstURIHandlerInterface

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1423>

2 years agovalidate/media-info: silence unsed variable warning
Matthew Waters [Mon, 28 Mar 2022 10:15:15 +0000 (21:15 +1100)]
validate/media-info: silence unsed variable warning

Fixes:

../validate/gst/validate/gst-validate-media-info.c:714:28: error: variable 'total_sink_count' set but not used [-Werror,-Wunused-but-set-variable]
  guint id, ncounters = 0, total_sink_count = 0;
                           ^

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2046>

2 years agortsp-stream: remove unused variable:
Matthew Waters [Mon, 28 Mar 2022 10:03:16 +0000 (21:03 +1100)]
rtsp-stream: remove unused variable:

Fixes:

../gst/rtsp-server/rtsp-stream.c:2670:9: error: variable 'n_messages' set but not used [-Werror,-Wunused-but-set-variable]
  guint n_messages = 0;
        ^

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2046>

2 years agoapplemeida/texturecache: remove unused variable
Matthew Waters [Mon, 28 Mar 2022 09:51:35 +0000 (20:51 +1100)]
applemeida/texturecache: remove unused variable

Fixes:

../sys/applemedia/videotexturecache.m:71:20: error: variable 'features' set but not used [-Werror,-Wunused-but-set-variable]
  GstCapsFeatures *features;
                   ^

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2046>

2 years agoapplemedia/corevideobuffer: remove unused variable
Matthew Waters [Mon, 28 Mar 2022 09:50:27 +0000 (20:50 +1100)]
applemedia/corevideobuffer: remove unused variable

Fixes:

../sys/applemedia/corevideobuffer.c:209:19: error: variable 'video_meta' set but not used [-Werror,-Wunused-but-set-variable]
    GstVideoMeta *video_meta;
                  ^

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2046>

2 years agoapplemedia/iosgl: remove unused variable
Matthew Waters [Mon, 28 Mar 2022 09:49:01 +0000 (20:49 +1100)]
applemedia/iosgl: remove unused variable

Fixes:

../sys/applemedia/iosurfaceglmemory.c:219:41: error: variable 'texfmt' set but not used [-Werror,-Wunused-but-set-variable]
    GLuint tex_id, tex_target, texifmt, texfmt;
                                        ^

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2046>

2 years agovtdec: remove unused variable
Matthew Waters [Mon, 28 Mar 2022 09:37:54 +0000 (20:37 +1100)]
vtdec: remove unused variable

Fixes:

../sys/applemedia/vtdec.c:611:35: error: variable 'output_flags' set but not used [-Werror,-Wunused-but-set-variable]
  VTDecodeFrameFlags input_flags, output_flags;
                                  ^

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2046>

2 years agoavsamplevideosink: remove unused variable
Matthew Waters [Mon, 28 Mar 2022 09:24:59 +0000 (20:24 +1100)]
avsamplevideosink: remove unused variable

Fixes

../sys/applemedia/avsamplevideosink.m:80:20: error: variable 'gstelement_class' set but not used [-Werror,-Wunused-but-set-variable]
  GstElementClass *gstelement_class;
                   ^

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2046>

2 years agoavfassetsrc: fix unused-but-set warning
Matthew Waters [Mon, 28 Mar 2022 09:11:29 +0000 (20:11 +1100)]
avfassetsrc: fix unused-but-set warning

../sys/applemedia/avfassetsrc.m:1014:12: error: variable 'caps' set but not used [-Werror,-Wunused-but-set-variable]
  GstCaps *caps;
           ^

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2046>

2 years agospeed: fix unused-but-set warning
Matthew Waters [Mon, 28 Mar 2022 08:42:04 +0000 (19:42 +1100)]
speed: fix unused-but-set warning

../gst/speed/gstspeed.c:523:39: error: variable 'base' set but not used [-Werror,-Wunused-but-set-variable]
      gint64 start_value, stop_value, base;
                                      ^

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2046>

2 years agoresindvd: silence unused-but-set warning
Matthew Waters [Mon, 28 Mar 2022 07:38:23 +0000 (18:38 +1100)]
resindvd: silence unused-but-set warning

../ext/resindvd/gstpesfilter.c:117:11: error: variable 'STD_buffer_size_bound' set but not used [-Werror,-Wunused-but-set-variable]
  guint16 STD_buffer_size_bound;
          ^

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2046>

2 years agompegts: don't shadow res variable
Matthew Waters [Mon, 28 Mar 2022 07:23:20 +0000 (18:23 +1100)]
mpegts: don't shadow res variable

Fixes unused-but-set warning:

../gst/mpegtsmux/gstbasetsmux.c:2115:43: error: variable 'res' set but not used [-Werror,-Wunused-but-set-variable]
      gboolean all_headers, done = FALSE, res = FALSE;
                                          ^

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2046>

2 years agompeg: fix unused-but-set warning
Matthew Waters [Mon, 28 Mar 2022 07:12:43 +0000 (18:12 +1100)]
mpeg: fix unused-but-set warning

../gst-libs/gst/mpegts/gst-dvb-section.c:206:9: error: variable 'i' set but not used [-Werror,-Wunused-but-set-variable]
  guint i = 0, allocated_events = 12;
        ^
../gst-libs/gst/mpegts/gst-dvb-section.c:365:9: error: variable 'i' set but not used [-Werror,-Wunused-but-set-variable]
  guint i = 0, allocated_streams = 12;
        ^
../gst-libs/gst/mpegts/gst-dvb-section.c:543:9: error: variable 'i' set but not used [-Werror,-Wunused-but-set-variable]
  guint i = 0, allocated_streams = 12;
        ^
../gst-libs/gst/mpegts/gst-dvb-section.c:885:9: error: variable 'i' set but not used [-Werror,-Wunused-but-set-variable]
  guint i = 0, allocated_services = 8;
        ^
../gst-libs/gst/mpegts/gst-dvb-section.c:1316:9: error: variable 'i' set but not used [-Werror,-Wunused-but-set-variable]
  guint i = 0, allocated_services = 8;
        ^

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2046>

2 years agoosxcoreaudio: fix unused-but-set warning
Matthew Waters [Mon, 28 Mar 2022 07:12:03 +0000 (18:12 +1100)]
osxcoreaudio: fix unused-but-set warning

../sys/osxaudio/gstosxcoreaudio.c:480:18: error: variable 'interleaved' set but not used [-Werror,-Wunused-but-set-variable]
  gboolean sign, interleaved;
                 ^

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2046>

2 years agovideo-format: Move NV12_8L128 into the correct position in GST_VIDEO_FORMATS_ALL
Sebastian Dröge [Mon, 28 Mar 2022 07:10:45 +0000 (10:10 +0300)]
video-format: Move NV12_8L128 into the correct position in GST_VIDEO_FORMATS_ALL

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2045>

2 years agompegdemux: silence unused-but-set werror
Matthew Waters [Mon, 28 Mar 2022 04:56:22 +0000 (15:56 +1100)]
mpegdemux: silence unused-but-set werror

../gst/mpegdemux/gstpesfilter.c:117:11: error: variable 'STD_buffer_size_bound' set but not used [-Werror,-Wunused-but-set-variable]
  guint16 STD_buffer_size_bound;
          ^

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2044>

2 years agoFix GstAmcSurfaceTexture segfault
Andrew Pritchard [Fri, 25 Mar 2022 03:25:02 +0000 (14:25 +1100)]
Fix GstAmcSurfaceTexture segfault
Check that `self` and `self->callback` are defined. `self` can be set to
`NULL` in `remove_listener`, and `self->callback` can be set to `NULL`
inside `gst_amc_surface_texture_jni_set_on_frame_available_callback`.
This can cause a segfault since the Java object can outlive the C
object, and call the callback after `remove_listener` is called.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2024>

2 years agoexamples/player/android: add missing dummy.cpp
Matthew Waters [Mon, 28 Mar 2022 03:36:24 +0000 (14:36 +1100)]
examples/player/android: add missing dummy.cpp

allows libc++_shared.so to be placed in the application

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2043>

2 years agodeinterlace: silence unused-but-set werror from imported code
Matthew Waters [Mon, 28 Mar 2022 02:35:17 +0000 (13:35 +1100)]
deinterlace: silence unused-but-set werror from imported code

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2042>

2 years agoexamples/player/android: update for android changes
Matthew Waters [Mon, 28 Mar 2022 02:28:56 +0000 (13:28 +1100)]
examples/player/android: update for android changes

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2041>

2 years agoosxvideosink: fix unused-but-set-variable warning
Matthew Waters [Sun, 27 Mar 2022 22:50:38 +0000 (09:50 +1100)]
osxvideosink: fix unused-but-set-variable warning

../sys/osxvideo/osxvideosink.m:859:11: error: variable 'data' set but not used [-Werror,-Wunused-but-set-variable]
  guint8 *data, *readp, *writep;
          ^

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2040>

2 years agorawvideoparse: set format from caps in gst_raw_video_parse_set_config_from_caps
Corentin Damman [Wed, 16 Mar 2022 10:31:56 +0000 (10:31 +0000)]
rawvideoparse: set format from caps in gst_raw_video_parse_set_config_from_caps

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1970>

2 years agoglmixerbin: slightly better pad/element creation
Matthew Waters [Sun, 27 Mar 2022 05:35:14 +0000 (16:35 +1100)]
glmixerbin: slightly better pad/element creation

Use the return value from gst_element_link_pads() and gst_bin_add()

Fixes:

../ext/gl/gstglmixerbin.c:305:12: error: variable 'res' set but not used [-Werror,-Wunused-but-set-variable]
  gboolean res = TRUE;
           ^

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2038>

2 years agoccconverter: ensure correct ordering of cea608 across output buffers
Matthew Waters [Wed, 23 Mar 2022 06:31:37 +0000 (17:31 +1100)]
ccconverter: ensure correct ordering of cea608 across output buffers

e.g. if a 60fps output is configured, we can only produce a single field
of cea608 that must alternate between field 1 and field 2.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2019>

2 years agoccconverter: ignore padding cea608 data even if marked as 'valid'
Matthew Waters [Wed, 23 Mar 2022 04:13:10 +0000 (15:13 +1100)]
ccconverter: ignore padding cea608 data even if marked as 'valid'

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2019>

2 years agov4l2codecs: Detect missing M2M_HOLD_CAPTURE_BUF
Nicolas Dufresne [Wed, 23 Mar 2022 14:36:28 +0000 (10:36 -0400)]
v4l2codecs: Detect missing M2M_HOLD_CAPTURE_BUF

Produce an error if we try to use the feature of holding capture buffer
but it is not supported by the driver. Ingoring this can lead to stalls
as the driver will run-out of capture buffer to decode into. This
affects slice decoders but also split-field interlaced decoding.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2009>

2 years agov4l2codecs: h264: Set other field poc if available
Nicolas Dufresne [Wed, 23 Mar 2022 13:11:35 +0000 (09:11 -0400)]
v4l2codecs: h264: Set other field poc if available

Whenever the other field POC is available, pass it back to the
driver. This should not be strictly required, but it makes things
easier to debug and more forgiven.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2009>

2 years agov4l2codecs: Trace request by it FD
Nicolas Dufresne [Tue, 21 Dec 2021 15:59:37 +0000 (10:59 -0500)]
v4l2codecs: Trace request by it FD

This helps when crossing the debug logs with the kernel logs.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2009>

2 years agov4l2codecs: h264: Fix dpb entry flag FLAG_FIELD
Nicolas Dufresne [Tue, 21 Dec 2021 15:55:58 +0000 (10:55 -0500)]
v4l2codecs: h264: Fix dpb entry flag FLAG_FIELD

The logic to guess back this value was broken. Use the value
now saved into the picture instead. This was tested using
LibreELEC patched 5.15 kernel, and fixed the interlaced decode
issues.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2009>

2 years agocodecs: h264: Save the field_pic_flag
Nicolas Dufresne [Tue, 21 Dec 2021 15:52:32 +0000 (10:52 -0500)]
codecs: h264: Save the field_pic_flag

This flag is set when the stream is interlaced and the specific
slice is made of single parity fields rather the paired at the
macroblock layer. This is rarely needed in late decoding process
but the Rockchip RKVDEC HW interface requires it, hence needs to
be passed through V4L2 Stateless interface.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2009>

2 years agod3d11: Fix example build error
Xavier Claessens [Fri, 25 Mar 2022 17:26:52 +0000 (13:26 -0400)]
d3d11: Fix example build error

```
../subprojects/gst-plugins-bad/tests/examples/d3d11/d3d11device.cpp:129:50: error: invalid conversion from ‘int’ to ‘DXGI_FORMAT’ [-fpermissive]
  129 |     D3D11_SHADER_RESOURCE_VIEW_DESC srv_desc = { 0, };
```

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2029>

2 years agogl: cocoa: fix warnings of unused variables
Stéphane Cerveau [Fri, 25 Mar 2022 12:00:13 +0000 (13:00 +0100)]
gl: cocoa: fix warnings of unused variables

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2026>

2 years agoFetch libxml2 subproject using http instead of ftp
Johan Sternerup [Wed, 23 Mar 2022 12:58:24 +0000 (13:58 +0100)]
Fetch libxml2 subproject using http instead of ftp

The official releases of libxml2 have been migrated to gitlab where
they are published for download via HTTP instead of FTP. Besides
adapting to the new location we now also get the benefit that the
tarball can be downloaded in restricted networks where FTP might be
blocked.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2020>

2 years agonavigationtest: Add some support for modifiers
Thibault Saunier [Fri, 25 Mar 2022 14:42:03 +0000 (11:42 -0300)]
navigationtest: Add some support for modifiers

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2010>

2 years agonavigation: Add support for key Modifiers in all relevant events
Thibault Saunier [Fri, 18 Mar 2022 16:59:32 +0000 (16:59 +0000)]
navigation: Add support for key Modifiers in all relevant events

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2010>

2 years agova: h265dec: Fix a crash because of missing reference frame.
He Junyan [Thu, 24 Mar 2022 13:39:30 +0000 (21:39 +0800)]
va: h265dec: Fix a crash because of missing reference frame.

Some problematic H265 stream may miss the reference frame in the DPB,
and get some message like: "No short term reference picture for xxx".
So there may be empty entries in ref_pic_list0/1 when passing to
decode_slice() function of sub class. We need to check the NULL pointer.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2018>

2 years agoopenexr: Specify modules when finding OpenEXR.
Chun-wei Fan [Thu, 24 Mar 2022 07:19:27 +0000 (15:19 +0800)]
openexr: Specify modules when finding OpenEXR.

Specify modules to look for OpenEXR when CMake is used, as we may have
CMake config files instead of pkg-config files that result from building
OpenEXR, which may be built with CMake which is typically the case on Visual
Studio builds.

In this case, Meson does seem to find the 'OpenEXR' package with CMake
after trying pkg-config, but does not consider it enough without the
'modules:' argument.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2014>

2 years agowebrtcbin: Update documentation of 'get-stats' action signal
Sangchul Lee [Mon, 21 Mar 2022 15:30:28 +0000 (00:30 +0900)]
webrtcbin: Update documentation of 'get-stats' action signal

Some stats fields are updated according to the current implementation.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2005>

2 years agortpptdemux: fix leak of caps when ignoring a pt
Matthew Waters [Wed, 17 Nov 2021 06:27:13 +0000 (17:27 +1100)]
rtpptdemux: fix leak of caps when ignoring a pt

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2025>

2 years agoRevert "webrtcbin: fix msid line and allow customization"
Mathieu Duponchelle [Thu, 24 Mar 2022 23:27:42 +0000 (00:27 +0100)]
Revert "webrtcbin: fix msid line and allow customization"

This reverts commit 3cad3455377d5a22faa138d9df840257059776c8.

That commit was breaking the association between an audio and
a video track in the standard case.

In practice, to support carrying separate MediaStream, we are
going a way to map what MediaStreamTrack belong to what MediaStream,
but that will require some thinking about the API.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2023>

2 years agotsdemux: Don't check SCTE events for being too far from the PCR
Vivia Nikolaidou [Thu, 24 Mar 2022 17:55:48 +0000 (19:55 +0200)]
tsdemux: Don't check SCTE events for being too far from the PCR

Otherwise it happens that SCTE events can only be scheduled up to 15
seconds since the last seen PCR, which is a useless restriction.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2021>

2 years agonavigation: Add missing annotation to send_event_simple
Vivienne Watermeier [Thu, 24 Mar 2022 12:01:52 +0000 (13:01 +0100)]
navigation: Add missing annotation to send_event_simple

Adds the missing "transfer full" annotation for the event argument.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2017>

2 years agowebrtcbin: fix msid line and allow customization
Mathieu Duponchelle [Mon, 21 Mar 2022 22:03:36 +0000 (23:03 +0100)]
webrtcbin: fix msid line and allow customization

From https://datatracker.ietf.org/doc/html/draft-ietf-mmusic-msid-16:

> Multiple media descriptions with the same value for msid-id and
> msid-appdata are not permitted.

Our previous implementation of simply using the CNAME as the msid
identifier and the name of the transceiver as the msid appdata was
misguided and incorrect, and created issues when bundling multiple
video streams together: the ontrack event was emitted with the same
streams for the two bundled medias, at least in Firefox.

Instead, use the transceiver name as the identifier, and expose
a msid-appdata property on transceivers to allow for further
customization by the application. When the property is not set,
msid-appdata can be left empty as it is specified as optional.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2003>

2 years agowebrtc: Update dependencies of the Rust examples
Sebastian Dröge [Thu, 24 Mar 2022 10:05:29 +0000 (12:05 +0200)]
webrtc: Update dependencies of the Rust examples

And also clean up code a bit while updating to new APIs.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2016>

2 years agoFix license as GES is released under the LGPL2+ license
Thibault Saunier [Mon, 14 Mar 2022 12:06:46 +0000 (09:06 -0300)]
Fix license as GES is released under the LGPL2+ license

This was a mistake that some of the licensing notice in a few files was
referring to GPL3+ and it needs fixing

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1956>

2 years agowpe: Mark first audio buffer as discont
Thibault Saunier [Wed, 5 Jan 2022 13:15:34 +0000 (10:15 -0300)]
wpe: Mark first audio buffer as discont

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1492>

2 years agowpe: Use `about:blank` as default URL to support only using load-bytes
Thibault Saunier [Tue, 4 Jan 2022 18:49:35 +0000 (15:49 -0300)]
wpe: Use `about:blank` as default URL to support only using load-bytes

WebKit is not going to render anything until a URI is set, leading to a
WPE posting a `WPE View did not render a buffer` error message. To avoid
requiring the user to know it if they only want to use
`wpesrc::load-bytes` we can just use `about:blank` as default and
everything will work as users would expect.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1492>

2 years agovalidate:scenario: Support args in the `emit-signal` action
Thibault Saunier [Tue, 4 Jan 2022 17:53:06 +0000 (14:53 -0300)]
validate:scenario: Support args in the `emit-signal` action

This was never needed before but it is generally useful and there
was a todo about it

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1492>

2 years agowebrtc_sendrecv.py: Link pads instead of elements
Nirbheek Chauhan [Wed, 23 Mar 2022 09:59:55 +0000 (15:29 +0530)]
webrtc_sendrecv.py: Link pads instead of elements

This was not a problem here because even if we end up accidentally
linking to the wrong pad, things will work out eventually as long as
one pad-added is emitted for each pad that is added.

But it will be a huge problem if someone copies this code and changes
something that requires different handling for different sorts of
pads. The resultant code will be racy. Let's not do this, it's a bad
example.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2008>

2 years agoREADME: update documentation for macOS
Stéphane Cerveau [Fri, 25 Feb 2022 14:03:11 +0000 (15:03 +0100)]
README: update documentation for macOS

Give hints regarding the certificates
needed by Python.

urllib.error.URLError: urlopen error [SSL ..

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1794>

2 years agofakevideosink,fakeaudiosink: Proxy handoff and preroll-handoff signals
Seungha Yang [Thu, 27 Jan 2022 14:54:34 +0000 (23:54 +0900)]
fakevideosink,fakeaudiosink: Proxy handoff and preroll-handoff signals

Proxy signals for application to be able to consume them

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1585>

2 years agoaom: av1enc: Specify Temporal Unit alignment
Seungha Yang [Fri, 24 Dec 2021 10:49:34 +0000 (19:49 +0900)]
aom: av1enc: Specify Temporal Unit alignment

Encoded bitstream consists of leading Temporal delimiter OBU
with frame, that's Temporal Unit alignment.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1471>

2 years agoqsvencoder: Clear caps after debug print
Seungha Yang [Wed, 23 Mar 2022 17:52:45 +0000 (02:52 +0900)]
qsvencoder: Clear caps after debug print

Otherwise debug function will print (null) for alread cleared pointer

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2012>

2 years agoqsvh264enc: Fix profile and level setting in codec data
Seungha Yang [Wed, 23 Mar 2022 17:43:43 +0000 (02:43 +0900)]
qsvh264enc: Fix profile and level setting in codec data

The profile field in SPS is located after header byte

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2012>

2 years agonvcodec: Add new Direct3D11/CUDA mode encoder implementation
Seungha Yang [Tue, 15 Mar 2022 19:58:16 +0000 (04:58 +0900)]
nvcodec: Add new Direct3D11/CUDA mode encoder implementation

Adding new encoder elements nvd3d11{h264,h265}enc for Direct3D11
input support and re-written nvcuda{h264,h265}enc elements.
Newly writeen elements have some differences compared with old
nv{h264,h265}enc including non-backward compatible changes.

* RGBA is not a supported input format any more:
  New elements will support only YUV formats to avoid implicit conversion
  done by hardware. Ideally it should be done by upstream element
  in order to have more control on it. Moreover, RGBA support can cause
  redundant RGBA -> YUV conversion if multiple encoders are
  used for the same RGBA input
* Subsampled planar format support is dropped:
  I420 and YV12 format are not supported formats for Direct3D11.
  Although it's supported in CUDA mode, it's not a hardware friendly
  memory layout and it will waste GPU memory since UV planes
  will have large padding due to the memory layout requirement of NVENC.
* GL support is dropped: Similar to the RGBA case,
  GL support in encoder would be suboptimal if GL input is
  used by multiple encoders, because each encoder will copy GL memory
  into CUDA memory.
  Upstream cudaupload element can be used for GL <-> CUDA
  interop instead.
* No more pre-allocation of encoder input surfaces. New implementation
  will use input CUDA memory without copy (zero-copy) or
  will copy into a NVENC's input buffer struct in case of
  system memory input.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1997>

2 years agoqt: Add touch event support
Vivienne Watermeier [Wed, 23 Feb 2022 11:53:04 +0000 (12:53 +0100)]
qt: Add touch event support

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1633>

2 years agogtk: Add touch event support
Vivienne Watermeier [Mon, 21 Feb 2022 19:16:06 +0000 (20:16 +0100)]
gtk: Add touch event support

Add a handler for touch events to gtkbasewidget.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1633>