Matthias Clasen [Fri, 13 Aug 2010 21:19:01 +0000 (17:19 -0400)]
Fix a typo, and some doc reformatting
Matthias Clasen [Fri, 13 Aug 2010 20:04:04 +0000 (16:04 -0400)]
Add some long descriptions for filter streams
Matthias Clasen [Fri, 13 Aug 2010 19:15:21 +0000 (15:15 -0400)]
Run volumemonitor test with local vfs
This is an attempt to stop the test from hanging on some build bots
in build.gnome.org.
David Zeuthen [Fri, 13 Aug 2010 17:58:27 +0000 (13:58 -0400)]
Bug 626841 – Add test-case for non-socket GIOStream
Also fix a couple of bugs so it actually works.
https://bugzilla.gnome.org/show_bug.cgi?id=626841
Signed-off-by: David Zeuthen <davidz@redhat.com>
Michael Meeks [Fri, 13 Aug 2010 16:56:19 +0000 (17:56 +0100)]
Add test for EAGAIN overflow in gdbusconnection based on David's test.
Matthias Clasen [Fri, 13 Aug 2010 16:04:21 +0000 (12:04 -0400)]
Add some async file tests
Matthias Clasen [Fri, 13 Aug 2010 04:47:02 +0000 (00:47 -0400)]
Collect NEWS for 2.25.14
Matthias Clasen [Fri, 13 Aug 2010 04:30:58 +0000 (00:30 -0400)]
Bump version
Havoc Pennington [Fri, 13 Aug 2010 03:57:26 +0000 (23:57 -0400)]
GAsyncQueue: use g_queue_init() not g_queue_new()
By using g_queue_init() instead of g_queue_new(), we can avoid
a separate memory allocation.
Bug 626704
Daniel Nylander [Thu, 12 Aug 2010 11:19:50 +0000 (13:19 +0200)]
Updated Swedish translation
Tor Lillqvist [Tue, 10 Aug 2010 13:01:39 +0000 (16:01 +0300)]
Fix gio/win32 build after -I flag changes
Aron Xu [Mon, 9 Aug 2010 06:26:38 +0000 (14:26 +0800)]
Update Simplified Chinese translation.
Matthias Clasen [Mon, 9 Aug 2010 03:53:52 +0000 (23:53 -0400)]
Replace the explicit list of character categories by a reference
to the GUnicodeType docs.
Matthias Clasen [Mon, 9 Aug 2010 03:43:29 +0000 (23:43 -0400)]
Refer to GUnicodeScript docs instead of listing scripts explicitly
Matthias Clasen [Mon, 9 Aug 2010 03:21:54 +0000 (23:21 -0400)]
Move GRegex docs inline
Matthias Clasen [Mon, 9 Aug 2010 02:19:10 +0000 (22:19 -0400)]
Whitespace cleanup
Matthias Clasen [Mon, 9 Aug 2010 02:15:16 +0000 (22:15 -0400)]
Remove two redundant comments
Matthias Clasen [Mon, 9 Aug 2010 02:14:56 +0000 (22:14 -0400)]
Fix up a doc typo
Matthias Clasen [Mon, 9 Aug 2010 02:12:40 +0000 (22:12 -0400)]
Minor cleanup
The definition is now present in pcre.h
Matthias Clasen [Mon, 9 Aug 2010 02:11:38 +0000 (22:11 -0400)]
Move GConvert docs inline
A S Alam [Tue, 10 Aug 2010 00:54:02 +0000 (06:24 +0530)]
update translation for master
Matthias Clasen [Mon, 9 Aug 2010 01:29:26 +0000 (21:29 -0400)]
Add introspection annotations in gregex.c
Also, make the new getters follow the style of other GRegex getters,
and take a const GRegex *.
Matthias Clasen [Mon, 9 Aug 2010 00:49:59 +0000 (20:49 -0400)]
Don't compile some unused functions in gio/xdgmime/
Matthias Clasen [Sun, 8 Aug 2010 22:35:12 +0000 (18:35 -0400)]
Don't compile an unused function
Matthias Clasen [Sun, 8 Aug 2010 22:34:59 +0000 (18:34 -0400)]
Trivial typo fix
Matthias Clasen [Sun, 8 Aug 2010 22:34:38 +0000 (18:34 -0400)]
Improve regex test coverage
Matthias Clasen [Sun, 8 Aug 2010 15:32:50 +0000 (11:32 -0400)]
Improve the async result test coverage
Matthias Clasen [Sun, 8 Aug 2010 15:31:53 +0000 (11:31 -0400)]
Improve dbus address test coverage
Fran Diéguez [Sun, 8 Aug 2010 23:11:59 +0000 (01:11 +0200)]
Updated galician translations
Matthias Clasen [Sun, 8 Aug 2010 05:09:18 +0000 (01:09 -0400)]
Improve regex test coverage
Matthias Clasen [Sun, 8 Aug 2010 05:08:34 +0000 (01:08 -0400)]
Drop some unused code
Some functions in pcre_get.c are not used.
Matthias Clasen [Sun, 8 Aug 2010 05:07:53 +0000 (01:07 -0400)]
Simplify gcov generation
lcov seems to handle .libs just fine on its own.
Ryan Lortie [Sat, 7 Aug 2010 23:58:12 +0000 (19:58 -0400)]
Bug 578295 - gtester has a race condition
Deal with the race in GMainLoop by installing a do-nothing timeout.
Matthias Clasen [Sat, 7 Aug 2010 22:56:12 +0000 (18:56 -0400)]
Make g_dbus_error_unregister_error work
Matthias Clasen [Sat, 7 Aug 2010 22:55:21 +0000 (18:55 -0400)]
Add some more test about gdbus_error apis
Matthias Clasen [Sat, 7 Aug 2010 21:08:54 +0000 (17:08 -0400)]
Make g_simple_async_result_is_valid work without source
The problem was pointed out by Xavier Claessens in bug 626208.
Matthias Clasen [Sat, 7 Aug 2010 20:27:38 +0000 (16:27 -0400)]
Make the closure variants of name owning and watching actually work
The GClosure API is a bit funky (and badly documented), and requires
you to set a marshaller on the closure, and the marshaller has an
implicit 'this' argument, and the caller is reponsible for unsetting
the values after invoking the closure.
I've added some calls of the _with_closures variants to the
gdbus-names test now.
Kjartan Maraas [Sat, 7 Aug 2010 16:43:01 +0000 (18:43 +0200)]
Updated Norwegian bokmål translation
Benjamin Otte [Fri, 6 Aug 2010 21:15:28 +0000 (23:15 +0200)]
notifyqueue: Dedup pspecs when adding
The previous code dedup'd when thawing and threw nasty warnings your way
if you notified too often. This can now easily be avoided.
Performance should be roughly identical, as both are O(n²).
Ryan Lortie [Fri, 6 Aug 2010 20:48:03 +0000 (16:48 -0400)]
Prepare to release glib 2.25.13
Ryan Lortie [Fri, 6 Aug 2010 20:42:36 +0000 (16:42 -0400)]
gitignore update
Ryan Lortie [Fri, 6 Aug 2010 19:28:58 +0000 (15:28 -0400)]
gtester: Run tests only once on 'make check'
The gtester makefile runs 'make test' on 'make check' and also recurses
on 'make test'. automake recurses on 'make check'.
This means that every level of recursive make that we go through results
in the tests running twice as many times. If you type 'make check' at
the toplevel, for example, tests in gio/tests/ run 4 times.
Fix that by introducing a 'test-nonrecursive' target and using that one
from 'make check'. 'make test', 'make test-report', etc. are still
recursive.
Ryan Lortie [Fri, 6 Aug 2010 17:12:20 +0000 (13:12 -0400)]
Fix volumemonitor test case
Don't blindly g_object_unref() that which may be NULL.
Ryan Lortie [Fri, 6 Aug 2010 17:11:38 +0000 (13:11 -0400)]
gio.symbols: add g_dbus_message_[gs]et_byte_order
Ryan Lortie [Fri, 6 Aug 2010 17:11:20 +0000 (13:11 -0400)]
typo fix: Dist the data for the test cases
change 'dist_hook:' to 'dist-hook:'
Ryan Lortie [Fri, 6 Aug 2010 17:09:26 +0000 (13:09 -0400)]
Replace -I with $(glib_INCLUDES) and friends
Stop using ad hoc -I in all of our Makefile.am. Use the new variables
instead.
Ryan Lortie [Fri, 6 Aug 2010 17:07:31 +0000 (13:07 -0400)]
configure.ac: define glib_INCLUDES and friends
These macros should be used instead of -I for things in the tree that
depend on various bits of glib.
also gobject_INCLUDES, gthread_INCLUDES, gmodule_INCLUDES, gio_INCLUDES
Ryan Lortie [Fri, 6 Aug 2010 17:05:18 +0000 (13:05 -0400)]
Clean up improper #includes
We have a lot of broken #including going on around the tree. This has
gone unnoticed due to our sloppy use of -I.
Ryan Lortie [Fri, 6 Aug 2010 14:53:07 +0000 (10:53 -0400)]
Don't dist 'glibconfig.h'
This is causing very serious problems when doing out-of-tree builds from
tarballs on architectures that are different from the architecture that
the tarball was created on.
This commit breaks the build in those cases, but I'll fix that in the
next commits.
https://bugzilla.gnome.org/show_bug.cgi?id=626107
Ryan Lortie [Fri, 6 Aug 2010 14:29:32 +0000 (10:29 -0400)]
error test case: don't double-free the source
g_propagate_prefixed_error() frees the source already, don't
g_error_free() it.
Hannes Müller [Thu, 5 Aug 2010 21:11:03 +0000 (23:11 +0200)]
avoid warning in gutils.h when using gcc with -Wconversion
https://bugzilla.gnome.org/show_bug.cgi?id=619026
Fran Diéguez [Thu, 5 Aug 2010 13:36:39 +0000 (15:36 +0200)]
Updated Galician translations
Claude Paroz [Thu, 5 Aug 2010 13:17:40 +0000 (15:17 +0200)]
Updated French translation
Contributed by Gérard Baylard and Claude Paroz
paul [Thu, 5 Aug 2010 13:08:34 +0000 (09:08 -0400)]
Add $(top_builddir)/glib to includes
This is required to find glibconfig.h during srcdir != builddir builds
Jorge González [Thu, 5 Aug 2010 10:11:05 +0000 (12:11 +0200)]
Updated Spanish translation
Philip Withnall [Mon, 2 Aug 2010 13:14:11 +0000 (14:14 +0100)]
Expand documentation about error quark naming
Closes: bgo#625827
Matthias Clasen [Thu, 5 Aug 2010 06:23:42 +0000 (02:23 -0400)]
Test an option handling corner-case
Matthias Clasen [Thu, 5 Aug 2010 06:01:58 +0000 (02:01 -0400)]
Add a not about arguments beginning with dashes
Yaron Shahrabani [Thu, 5 Aug 2010 06:14:40 +0000 (09:14 +0300)]
Updated Hebrew translation.
Matthias Clasen [Thu, 5 Aug 2010 05:53:15 +0000 (01:53 -0400)]
Beautify configure output
Checking for cpp before using it avoids somewhat ugly
nested output. Pointed out in bug 593544.
Matthias Clasen [Thu, 5 Aug 2010 05:45:26 +0000 (01:45 -0400)]
Modernize pkg-config check
As pointed out in bug 599590, our hand-rolled check fails to find
cross-complication variants of pkg-config like i686-pc-mingw32-pkg-config.
Matthias Clasen [Thu, 5 Aug 2010 05:39:02 +0000 (01:39 -0400)]
Add missing files
Reported in bug 624739
David Zeuthen [Wed, 4 Aug 2010 20:59:26 +0000 (16:59 -0400)]
GDBus: Add `return' debug option
This prints all GDBusMethodInvocation API usage and is normally used
with the `incoming' option. Example:
# G_DBUS_DEBUG=incoming,return ./polkitd --replace
Entering main event loop
Connected to the system bus
Registering null backend at priority -10
[...]
Acquired the name org.freedesktop.PolicyKit1
[...]
========================================================================
GDBus-debug:Incoming:
<<<< METHOD INVOCATION org.freedesktop.PolicyKit1.Authority.RegisterAuthenticationAgent()
on object /org/freedesktop/PolicyKit1/Authority
invoked by name :1.26
serial 299
========================================================================
GDBus-debug:Return:
>>>> METHOD ERROR org.freedesktop.PolicyKit1.Error.Failed
message `Cannot determine session the caller is in'
in response to org.freedesktop.PolicyKit1.Authority.RegisterAuthenticationAgent()
on object /org/freedesktop/PolicyKit1/Authority
to name :1.26
reply-serial 299
[...]
========================================================================
GDBus-debug:Incoming:
<<<< METHOD INVOCATION org.freedesktop.PolicyKit1.Authority.RegisterAuthenticationAgent()
on object /org/freedesktop/PolicyKit1/Authority
invoked by name :1.2402
serial 25
========================================================================
GDBus-debug:Return:
>>>> METHOD RETURN
in response to org.freedesktop.PolicyKit1.Authority.RegisterAuthenticationAgent()
on object /org/freedesktop/PolicyKit1/Authority
to name :1.2402
reply-serial 25
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Wed, 4 Aug 2010 18:38:51 +0000 (14:38 -0400)]
GDBusMessage: Validate header fields when serializing/deserializing
The D-Bus spec mentions exactly what header fields are required for
various message types. Add tests for this as well.
Also disallow empty interfaces for signals since the D-Bus spec says
this is Verboten already.
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Wed, 4 Aug 2010 17:32:19 +0000 (13:32 -0400)]
GDBusMessage: Add a way to get/set byte order of a message
Also use this in the test cases to check that serialization to and
from both big and little endian works.
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Wed, 4 Aug 2010 16:24:22 +0000 (12:24 -0400)]
GDBusMessage: Assert various things when serializing to a blob
We use g_assert() instead of setting the GError because it is a
programming error if the GVariant contains invalid data - see commit
5e6f762d61db1a5c64bd1d33e5ba112755106581 for where the last hole in
GVariant was closed.
So if we can trust GVariant to only contain valid data (ignoring the
case where unsafe API such as g_variant_new_from_data() is used), why
g_assert() at all with costly g_utf8_validate() checks? Because a) it
is relatively inexpensive; and b) it helps find bugs such as the one
fixed in commit
5e6f762d61db1a5c64bd1d33e5ba112755106581.
If performance is a concern we can play games like introducing
environment variables or other machinery to avoid such "costly"
checks. I doubt it will ever be an issue.
Also replace two "Hmm" TODO item with a static assert - the code that
serializes a gdouble into the D-Bus wire format by treating it as a
guint64 is indeed correct - endianess needs to be taken into account
(see the D-Bus reference implementation for similar code). But we want
to make sure that we're indeed using an architecture/compiler where a
gdouble takes up 8 bytes - hence the assertion.
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Wed, 4 Aug 2010 15:26:48 +0000 (11:26 -0400)]
GDBusMessage: Validate UTF-8 strings when serializing from blob
Signed-off-by: David Zeuthen <davidz@redhat.com>
Dan Winship [Wed, 4 Aug 2010 11:36:04 +0000 (07:36 -0400)]
remove a junk line
Kjartan Maraas [Wed, 4 Aug 2010 11:23:02 +0000 (13:23 +0200)]
Updated Norwegian bokmål translation
Emmanuele Bassi [Tue, 3 Aug 2010 23:57:52 +0000 (00:57 +0100)]
binding: Add a default marshaller for the closure API
The g_object_bind_property_with_closures() function should set a
marshaller if the two GClosures don't have one already. This simplifies
the caller code and avoids duplication.
We need to add a new marshaller to the gmarshal.list matching the
signature of the GBindingTransformFunc function.
David Zeuthen [Tue, 3 Aug 2010 19:36:16 +0000 (15:36 -0400)]
GDBusConnection: Debug messages when receiving signals and method invocations
Spell out "RECEIVED SIGNAL" instead of "SIGNAL" to emphasize this is
about receiving a signal, not emitting one (which is "SIGNAL
EMISSION"). Also make the "arrows" point in the "right" direction
("<<<<" vs ">>>>") - like this:
========================================================================
GDBus-debug:Signal:
<<<< RECEIVED SIGNAL org.freedesktop.DBus.NameOwnerChanged
on object /org/freedesktop/DBus
sent by name org.freedesktop.DBus
and
========================================================================
GDBus-debug:Incoming:
<<<< METHOD INVOCATION org.freedesktop.PolicyKit1.Authority.EnumerateTemporaryAuthorizations()
on object /org/freedesktop/PolicyKit1/Authority
invoked by name :1.2176
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Tue, 3 Aug 2010 18:32:29 +0000 (14:32 -0400)]
glib-compile-schemas: Pass a C string, not a GString wrapper
Commit
5e6f762d61db1a5c64bd1d33e5ba112755106581 (introducing UTF-8
validity checks for GVariant instances containing strsings) actually
uncovered a bug in glib-compile-schemas - a GString was passed when a
C string was expected.
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Tue, 3 Aug 2010 17:33:03 +0000 (13:33 -0400)]
GVariant: validate that passed string is UTF-8
As discussed with Ryan on IRC.
This check is crucial because it guarantees that
g_variant_get_string() will _always_ return valid UTF-8. Except in
cases where the programmer used unsafe API such as
g_variant_new_from_data() and setting @trusted to TRUE.
In fact, this check revealed a flaw in my polkit gdbus port
(lt-polkitd:11632): GLib-CRITICAL **: g_variant_new_string: assertion
`g_utf8_validate (string, len, NULL)' failed
and with this I could easily find the problem by using gdb(1) and
G_DBUS=fatal-warnings.
Without this check we'd pass the non-UTF8 string all the way to the
message bus and the bus would then disconnect us. So instead I was
seeing
g_dbus_connection_real_closed: Remote peer vanished with error:
Underlying GIOStream returned 0 bytes on an async read
(g-io-error-quark, 0). Exiting.
and then SIGTERM as raised by g_dbus_connection_real_closed() and my
polkitd process would exit. This behavior is much harder to debug than
failing early (as this patch implements).
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Tue, 3 Aug 2010 16:47:07 +0000 (12:47 -0400)]
Fix gdbus-exit-on-close test case
Forgot to update the test case after last commit.
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Tue, 3 Aug 2010 16:24:48 +0000 (12:24 -0400)]
GDBus: If exiting b/c remote peer disconnected and error is set, print it
This should make things easier to debug:
g_dbus_connection_real_closed: Remote peer vanished with error:
Underlying GIOStream returned 0 bytes on an async read
(g-io-error-quark, 0). Exiting.
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Tue, 3 Aug 2010 15:14:21 +0000 (11:14 -0400)]
GDBusProxy: Don't leak a GSimpleAsyncResult when doing async calls
Signed-off-by: David Zeuthen <davidz@redhat.com>
Matthias Clasen [Tue, 3 Aug 2010 14:41:21 +0000 (10:41 -0400)]
Fix a possible deadlock
the FdSource was calling g_cancellable_disconnect while holding the
main context lock, which is bad news if the ::cancelled handler is
trying to get that lock to wake up the mainloop...
Bug 586432
Matthias Clasen [Sun, 1 Aug 2010 06:36:27 +0000 (02:36 -0400)]
fix the completion test
Matthias Clasen [Sun, 1 Aug 2010 06:11:15 +0000 (02:11 -0400)]
improve completion test coverage
Matthias Clasen [Sun, 1 Aug 2010 06:07:50 +0000 (02:07 -0400)]
Don't assert too much
Matthias Clasen [Sun, 1 Aug 2010 06:07:21 +0000 (02:07 -0400)]
Move bookmarkfile tests to the test framework
Emmanuele Bassi [Tue, 3 Aug 2010 13:21:02 +0000 (14:21 +0100)]
Update the Git ignore files
Mark Wielaard [Mon, 2 Aug 2010 21:28:50 +0000 (23:28 +0200)]
Don't add (extra) DESTDIR to tapsetdir for tapset_DATA.
https://bugzilla.gnome.org/show_bug.cgi?id=625876
Emmanuele Bassi [Tue, 3 Aug 2010 09:34:59 +0000 (10:34 +0100)]
docs: Clarify user_data behavior for bind_property_full()
Emmanuele Bassi [Tue, 3 Aug 2010 09:29:50 +0000 (10:29 +0100)]
binding: Add G_BINDING_INVERT_BOOLEAN
Since GSettings got the same functionality and flag in commit
ca3b7b75b
GBinding should also have the ability to automatically invert a boolean
value without requiring a custom transformation function.
Emmanuele Bassi [Tue, 13 Jul 2010 05:03:03 +0000 (06:03 +0100)]
binding: Add a closure-based variant of bind_property_full()
Since using the function pointer version muddles the memory management
requirements of language bindings, we should implement a GClosure-based
variant on top of g_object_bind_property_full().
https://bugzilla.gnome.org/show_bug.cgi?id=622278
Ryan Lortie [Tue, 3 Aug 2010 06:08:03 +0000 (02:08 -0400)]
GSettings: add G_SETTINGS_BIND_INVERT_BOOLEAN flag
When binding a boolean setting to a boolean property, invert the values.
This avoids the requirement for writing a pair of mapping functions for
this extremely common case.
Add a test.
https://bugzilla.gnome.org/show_bug.cgi?id=625833
Fridrich Štrba [Mon, 2 Aug 2010 08:16:29 +0000 (10:16 +0200)]
On windows, export also symbols defined in gio/gwin32appinfo.c
Fran Diéguez [Sun, 1 Aug 2010 21:18:31 +0000 (23:18 +0200)]
Updated Galician translations
Carlos Garcia Campos [Sun, 1 Aug 2010 10:56:06 +0000 (12:56 +0200)]
GDBusConnection: fix message flags in g_dbus_connection_call_sync()
GDBusCallFlags were used instead of GDBusSendMessageFlags for
g_dbus_connection_send_message_with_reply_sync(). Fixes bug #625753.
Stef Walter [Sun, 1 Aug 2010 05:14:43 +0000 (07:14 +0200)]
Add comment to g_date_set_time_val about local timezone.
Local time zone is used in conversion during g_date_set_time_val().
We now mention this in the documentation.
Fixes bug #625500
Milan Crha [Sun, 1 Aug 2010 03:51:45 +0000 (23:51 -0400)]
Silence valgrind
Initialize all fields of struct msghdr. Bug 625472.
Jorge González [Sat, 31 Jul 2010 13:11:48 +0000 (15:11 +0200)]
Updated Spanish translation
Yaron Shahrabani [Sat, 31 Jul 2010 07:05:05 +0000 (10:05 +0300)]
Updated Hebrew translation.
Matthias Clasen [Sat, 31 Jul 2010 06:40:16 +0000 (02:40 -0400)]
Also use trylock in the bitlock tests
Matthias Clasen [Sat, 31 Jul 2010 06:39:53 +0000 (02:39 -0400)]
improve scanner api test coverage
Matthias Clasen [Sat, 31 Jul 2010 06:15:03 +0000 (02:15 -0400)]
Improve tree test coverage
Matthias Clasen [Sat, 31 Jul 2010 06:14:51 +0000 (02:14 -0400)]
Improve keyfile test coverage
Matthias Clasen [Sat, 31 Jul 2010 06:14:28 +0000 (02:14 -0400)]
Test some GError functionality explicitly
Matthias Clasen [Sat, 31 Jul 2010 06:14:01 +0000 (02:14 -0400)]
Add a test for g_variant_builder_add_parsed