platform/upstream/flatbuffers.git
6 years agoAn user-defined attribute name validation (#4689)
Vladimir Glavnyy [Fri, 6 Apr 2018 16:07:59 +0000 (23:07 +0700)]
An user-defined attribute name validation (#4689)

* User-declared attribute should be either identifier or string with the identifier.

* Attribute can be identifier or string in metadata.

6 years agoRename MANUALLY_ALIGNED_STRUCT to add FLATBUFFERS_ prefix in generated code within...
Paul Reimer [Thu, 5 Apr 2018 23:36:42 +0000 (16:36 -0700)]
Rename MANUALLY_ALIGNED_STRUCT to add FLATBUFFERS_ prefix in generated code within tests/. Via running `cd tests && sh generate_code.sh` (#4696)

6 years agoAdd FLATBUFFERS_ prefix to defines [C++] (#4695)
Paul Reimer [Thu, 5 Apr 2018 23:00:54 +0000 (16:00 -0700)]
Add FLATBUFFERS_ prefix to defines [C++] (#4695)

* Rename STRUCT_END to add FLATBUFFERS_ prefix, now FLATBUFFERS_STRUCT_END. Via running `ag -l STRUCT_END | xargs rpl STRUCT_END FLATBUFFERS_STRUCT_END`

* Rename MANUALLY_ALIGNED_STRUCT to add FLATBUFFERS_ prefix, now FLATBUFFERS_MANUALLY_ALIGNED_STRUCT. Via running `ag -l MANUALLY_ALIGNED_STRUCT | xargs rpl MANUALLY_ALIGNED_STRUCT FLATBUFFERS_MANUALLY_ALIGNED_STRUCT && cd tests && sh generate_code.sh`

* Rename DEFINE_BITMASK_OPERATORS to add FLATBUFFERS_ prefix, now FLATBUFFERS_DEFINE_BITMASK_OPERATORS. Via running `ag -l DEFINE_BITMASK_OPERATORS | xargs rpl DEFINE_BITMASK_OPERATORS FLATBUFFERS_DEFINE_BITMASK_OPERATORS`

6 years agoUpdate version number to 1.9 v1.9.0
Wouter van Oortmerssen [Thu, 5 Apr 2018 22:11:52 +0000 (15:11 -0700)]
Update version number to 1.9

Change-Id: I0b0ed43129c4d8fc88a177792df50adfeb52a1e3

6 years agoAdded missing generated code files.
Wouter van Oortmerssen [Thu, 5 Apr 2018 22:01:35 +0000 (15:01 -0700)]
Added missing generated code files.

Change-Id: I59af6ca1825870461c0badc7e7a045b97befdc1a

6 years agoMissing TS links in docs (#4693)
Kamil Rojewski [Thu, 5 Apr 2018 16:54:37 +0000 (18:54 +0200)]
Missing TS links in docs (#4693)

* Eclipse ignore

* TypeScript support

* Prefixing enums

* Test results

* Merged JS and TS generators

* Fixed AppVeyor build problems

* Fixed more AppVeyor build problems

* Fixed more AppVeyor build problems

* Changed TS flag to options struct

* Storing options by value

* Removed unneeded const

* Re-export support for unions

* Uint support

* Casting bools to numbers for mutation

* TS shell tests

* Reverted generates js test file to original version

* Backing up js tests and properly generating test data

* Not importing flatbuffers for TS test generation

* Not overwriting generated js for tests

* AppVeyor test fixes

* Generating the most strict TS code possible

* Not returning null when creating vectors

* Not returning null from struct contructors

* Vector of unions for ts/js

* Sanity check for languages

* Indentation fix + output test files

* Vectors of unions for php

* Fixes to union vector handling + tests

* Fix for strictPropertyInitialization

* Fix for new aligned operator new for gcc >= 7.1

* Not generating imports/ns prefixes with --gen-all

* TypeScript docs

* Missing imports of enums

* Missing TS links

6 years agoRemove line break of CMakeLists.txt (#4691)
Juyeon Yoon [Thu, 5 Apr 2018 16:17:33 +0000 (01:17 +0900)]
Remove line break of CMakeLists.txt (#4691)

Fix #4650

6 years agoFix typos in C++ tutorial (#4685)
David Stephan [Mon, 2 Apr 2018 16:25:05 +0000 (09:25 -0700)]
Fix typos in C++ tutorial (#4685)

CreateMonster and MonsterBuilder examples fixed for C++

6 years agoFix for missing enum imports (#4683)
Kamil Rojewski [Mon, 26 Mar 2018 17:29:45 +0000 (19:29 +0200)]
Fix for missing enum imports (#4683)

* Eclipse ignore

* TypeScript support

* Prefixing enums

* Test results

* Merged JS and TS generators

* Fixed AppVeyor build problems

* Fixed more AppVeyor build problems

* Fixed more AppVeyor build problems

* Changed TS flag to options struct

* Storing options by value

* Removed unneeded const

* Re-export support for unions

* Uint support

* Casting bools to numbers for mutation

* TS shell tests

* Reverted generates js test file to original version

* Backing up js tests and properly generating test data

* Not importing flatbuffers for TS test generation

* Not overwriting generated js for tests

* AppVeyor test fixes

* Generating the most strict TS code possible

* Not returning null when creating vectors

* Not returning null from struct contructors

* Vector of unions for ts/js

* Sanity check for languages

* Indentation fix + output test files

* Vectors of unions for php

* Fixes to union vector handling + tests

* Fix for strictPropertyInitialization

* Fix for new aligned operator new for gcc >= 7.1

* Not generating imports/ns prefixes with --gen-all

* TypeScript docs

* Missing imports of enums

6 years agoTypeScript docs (#4680)
Kamil Rojewski [Fri, 23 Mar 2018 16:01:39 +0000 (17:01 +0100)]
TypeScript docs (#4680)

* Eclipse ignore

* TypeScript support

* Prefixing enums

* Test results

* Merged JS and TS generators

* Fixed AppVeyor build problems

* Fixed more AppVeyor build problems

* Fixed more AppVeyor build problems

* Changed TS flag to options struct

* Storing options by value

* Removed unneeded const

* Re-export support for unions

* Uint support

* Casting bools to numbers for mutation

* TS shell tests

* Reverted generates js test file to original version

* Backing up js tests and properly generating test data

* Not importing flatbuffers for TS test generation

* Not overwriting generated js for tests

* AppVeyor test fixes

* Generating the most strict TS code possible

* Not returning null when creating vectors

* Not returning null from struct contructors

* Vector of unions for ts/js

* Sanity check for languages

* Indentation fix + output test files

* Vectors of unions for php

* Fixes to union vector handling + tests

* Fix for strictPropertyInitialization

* Fix for new aligned operator new for gcc >= 7.1

* Not generating imports/ns prefixes with --gen-all

* TypeScript docs

6 years agoConst correctness in generated code and in code generators. Added missing \reflection...
Flaviu [Fri, 23 Mar 2018 15:58:07 +0000 (17:58 +0200)]
Const correctness in generated code and in code generators. Added missing \reflection\generate_code.bat file. (#4679)

6 years ago[C++, Go, Bazel]: Fix up Bazel support (#4672)
Andreas Bergmeier [Thu, 15 Mar 2018 19:31:16 +0000 (20:31 +0100)]
[C++, Go, Bazel]: Fix up Bazel support (#4672)

* Add Bazel support for Go library

* Make flatc compile again.

Was missing java_generator, which is now referenced from source.

6 years agoJava/C#/Python prefixed size support (#4445)
Robert Schmidtke [Mon, 12 Mar 2018 18:30:46 +0000 (19:30 +0100)]
Java/C#/Python prefixed size support (#4445)

* initial changes to support size prefixed buffers in Java

* add slice equivalent to CSharp ByteBuffer

* resolve TODO for slicing in CSharp code generation

* add newly generated Java and CSharp test sources

* fix typo in comment

* add FinishSizePrefixed methods to CSharp FlatBufferBuilder as well

* add option to allow writing the prefix as well

* generate size-prefixed monster binary as well

* extend JavaTest to test the size prefixed binary as well

* use constants for size prefix length

* fuse common code for getRootAs and getSizePrefixedRootAs

* pulled file identifier out of if

* add FinishSizePrefixed, GetSizePrefixedRootAs support for Python

* Revert "extend JavaTest to test the size prefixed binary as well"

This reverts commit 68be4420dda47e8d0600bb19691f03be71503a68.

* Revert "generate size-prefixed monster binary as well"

This reverts commit 2939516fdf78df4f061c627221e232b312301417.

* fix ByteBuffer.cs Slice() method; add proper CSharp and Java tests

* fix unused parameter

* increment version number

* pulled out generated methods into separate utility class

* pulled out generated methods into separate utility class for Python

* fix indentation

* remove unnecessary comment

* fix newline and copyright

* add ByteBufferUtil to csproj compilation

* hide ByteBuffer's internal data; track offset into parent's array

* test unsafe versions as well; compile and run in debug mode

* clarify help text for size prefix

* move ByteBuffer slicing behavior to subclass

* fix protection levels

* add size prefix support for text generation

* add ByteBufferSlice to csproj compilation

* revert size prefix handling for nested buffers

* use duplicate instead of slice for removing size prefix

* remove slice subclass and use duplicate for removing size prefix

* remove slice specific tests

* remove superfluous command line option

6 years agoRemove unnecessary const qualifier from cast (#4666)
Sergey Avseyev [Mon, 12 Mar 2018 15:22:17 +0000 (18:22 +0300)]
Remove unnecessary const qualifier from cast (#4666)

Const does not make sense here, and compiler actually throws warning
(error with -Werror) when you would try to compile it.

    In file included from include/flatbuffers/flexbuffers.h:24,
                     from include/flatbuffers/idl.h:26,
                     from include/flatbuffers/code_generators.h:22,
                     from src/code_generators.cpp:17:
    include/flatbuffers/util.h: In function ‘int flatbuffers::FromUTF8(const char**)’:
    include/flatbuffers/util.h:325:44: error: type qualifiers ignored on cast result type [-Werror=ignored-qualifiers]
       if ((static_cast<const unsigned char>(tmp) << len) & 0x80) return -1;  // Bit after leading 1's must be 0.
                                            ^
    cc1plus: all warnings being treated as errors

This warning caught by gcc8:

    $ g++ --version
    g++ (GCC) 8.0.1 20180222 (Red Hat 8.0.1-0.16)

6 years agoConvert to unsigned char before applying bit shift operator (#4664)
ianXian [Fri, 9 Mar 2018 17:45:47 +0000 (09:45 -0800)]
Convert to unsigned char before applying bit shift operator (#4664)

* Convert to unsigned char before applying bit shift operator

* convert to const unsigned char inline

* convert to unsigned char inline

6 years agoJson : Add --size-prefixed option to flatc (#4645)
desqaz [Fri, 9 Mar 2018 16:21:28 +0000 (17:21 +0100)]
Json : Add --size-prefixed option to flatc (#4645)

to be able to convert to json size prefixed buffers.

6 years agoSwapped the order of two conditions in an assert. (#4663)
Montoli [Thu, 8 Mar 2018 22:18:41 +0000 (14:18 -0800)]
Swapped the order of two conditions in an assert. (#4663)

An assert in flexbuffers was bit-shifting a 64-bit number by
64 bits, which throws up warnings in some automated tools.

The same assert also checks to see if the number of bytes
being shifted is 8.  Swapped the order, so that the bitshift
only occurs if the number of bits being shifted is not 64.

Should be the same behavior, but plays nicer with diagnostic
tools.

6 years agoUpdate .gitignore with Ninja stuff (#4659)
desqaz [Thu, 8 Mar 2018 18:36:27 +0000 (19:36 +0100)]
Update .gitignore with Ninja stuff (#4659)

6 years agoFix broken Java/C# codegen
Wouter van Oortmerssen [Tue, 6 Mar 2018 00:37:04 +0000 (16:37 -0800)]
Fix broken Java/C# codegen

6 years agoAdded missing generated code files.
Wouter van Oortmerssen [Mon, 5 Mar 2018 23:47:16 +0000 (15:47 -0800)]
Added missing generated code files.

Change-Id: Ie1cab284cb6e0fe5bd2b2c293c3136c148927ac3

6 years agoProtobufs: Added '--oneof-union' option. (#4647)
Nik Hemmings [Mon, 5 Mar 2018 16:45:25 +0000 (16:45 +0000)]
Protobufs: Added '--oneof-union' option. (#4647)

* Added '--oneof-union' option.

Used with the .proto -> .fbs converter, will translate protobuff oneofs to flatbuffer unions.
Updated proto test to check both methods of converting oneofs.

* Added '--oneof-union' option.

Used with the .proto -> .fbs converter, will translate protobuff oneofs to flatbuffer unions.
Updated proto test to check both methods of converting oneofs.

* FlatBuffers: Moved MakeCamel() into idl_parser.cpp

Removes library dependency on Java/C# generator code.

6 years agoMake nested flatbuffer lookup consistent. (#4656)
smillius [Mon, 5 Mar 2018 16:44:14 +0000 (17:44 +0100)]
Make nested flatbuffer lookup consistent. (#4656)

Lookup type of nested flatbuffer field with either raw name or fully qualified name as already done in the parser.
LookupCreateStruct tries both the raw name and the fully qualified one.
Without this, we cannot reference types outside of the current namespace, e.g. in a different module.

6 years agoSupport attribute "cpp_ptr_type" on table elements marked as "hash" (#4643)
Christian Helmich [Mon, 5 Mar 2018 16:40:56 +0000 (01:40 +0900)]
Support attribute "cpp_ptr_type" on table elements marked as "hash" (#4643)

* added intended use-cases to monster_test.fbs

* added check for `cpp_ptr_type` on hashed fields
added default value 'naked' to `cpp_ptr_type` on hashed fields

* added C++ generation of cpp_type vectors
removed ctor call for vector fields
added condition !vector for cpp_type check
added Pack() and UnPack() code generation for vector of hashes
added generation of correct resolve/rehash for cpp_type elements

* added attribute 'cpp_ptr_type_get' to hold accessor for pointer types possible where '.get()' does not work
use case: cpp_ptr_type:"std::weak_ptr", cpp_ptr_type_get:".lock().get()"

* run flatc to re-generate headers

* added bool param is_ctor to GetDefaultScalarValue() to differentiate between usage places

* modified monster_test.fbs to remove usage of shared_ptr/weak_ptr
reason: STLport does not support std::shared_ptr and std::weak_ptr

* run flatc again to re-generate headers

* fixed symbol unique_ptr not in namespace std when building with STLport

6 years agoJava + C#, reuse object in lookup_by_key (#4648)
Mitchel [Fri, 2 Mar 2018 23:22:46 +0000 (18:22 -0500)]
Java + C#, reuse object in lookup_by_key (#4648)

* Java + C#, reuse object in lookup_by_key

* Java + C#, reuse object in lookup_by_key

6 years agoFix for Java infinite loop encoding into 0-sized buffer (#4654)
Mitchel [Fri, 2 Mar 2018 23:21:08 +0000 (18:21 -0500)]
Fix for Java infinite loop encoding into 0-sized buffer (#4654)

6 years agomade HashFnv functions constexpr (#4640)
Christian Helmich [Fri, 2 Mar 2018 17:13:55 +0000 (02:13 +0900)]
made HashFnv functions constexpr (#4640)

* added FLATBUFFERS_CONSTEXPR_CPP14 define for C++14 and above constexpr

* made HashFnv functions constexpr (depending on FLATBUFFERS_CONSTEXPR)

6 years agoNot generating imports/ns prefixes with --gen-all (#4644)
Kamil Rojewski [Mon, 26 Feb 2018 16:56:04 +0000 (17:56 +0100)]
Not generating imports/ns prefixes with --gen-all (#4644)

* Eclipse ignore

* TypeScript support

* Prefixing enums

* Test results

* Merged JS and TS generators

* Fixed AppVeyor build problems

* Fixed more AppVeyor build problems

* Fixed more AppVeyor build problems

* Changed TS flag to options struct

* Storing options by value

* Removed unneeded const

* Re-export support for unions

* Uint support

* Casting bools to numbers for mutation

* TS shell tests

* Reverted generates js test file to original version

* Backing up js tests and properly generating test data

* Not importing flatbuffers for TS test generation

* Not overwriting generated js for tests

* AppVeyor test fixes

* Generating the most strict TS code possible

* Not returning null when creating vectors

* Not returning null from struct contructors

* Vector of unions for ts/js

* Sanity check for languages

* Indentation fix + output test files

* Vectors of unions for php

* Fixes to union vector handling + tests

* Fix for strictPropertyInitialization

* Fix for new aligned operator new for gcc >= 7.1

* Not generating imports/ns prefixes with --gen-all

6 years agoIn Java, allow reusing ByteBuffer in getters (#4633)
Mitchel [Fri, 23 Feb 2018 22:01:05 +0000 (17:01 -0500)]
In Java, allow reusing ByteBuffer in getters  (#4633)

* In Java, allow reusing ByteBuffer in getters

* In Java, allow reusing ByteBuffer in getters

* In Java, allow reusing ByteBuffer in getters

6 years agotemplate specialized Hash functions for 16-bit hash types (#4631)
Christian Helmich [Fri, 23 Feb 2018 18:29:37 +0000 (03:29 +0900)]
template specialized Hash functions for 16-bit hash types (#4631)

added access to HashFunction for 16 bit

6 years agoWhen Java raises a CharacterCodingException, the catch block rethrows this exception...
Philip S Doctor [Thu, 22 Feb 2018 22:54:35 +0000 (16:54 -0600)]
When Java raises a CharacterCodingException, the catch block rethrows this exception as a java.lang.Error.  Per the docs https://docs.oracle.com/javase/8/docs/api/java/lang/Error.html an Error is a serious problem that applications should not attempt to catch such as ThreadDeath.  In this case, it is reasonable for a consumer to try to catch this error as it likely indicates a problem with the underlying data. (#4630)

As Error does not inherit from Exception, a generic `catch(Exception ex)` will not catch this error.

A simple change from `Error` to `Exception` is not sufficient as an `Exception` is checked by the compiler, so in order to keep this issue unchecked, I am proposing raising a `RuntimeException` which is not checked, but is still a subclass of `Exception`.

The only possible breaking change would be if a consumer was explicitly catching `Error` already for this library.

https://github.com/google/flatbuffers/issues/4629

6 years agoadded support for parsing hash on vector elements (#4502)
Christian Helmich [Thu, 22 Feb 2018 19:04:26 +0000 (04:04 +0900)]
added support for parsing hash on vector elements (#4502)

* added support for parsing hash on vector elements

reversed check for scalar to check for vector

added C++ generation of cpp_type vectors

removed ctor call for vector fields
added condition !vector for cpp_type check

added Pack() and UnPack() code generation for vector of hashes

* schema change:
added table Referrable and weak references towards it from Monster

added single_weak_reference to Monster table
changed order with vector_of_weak_references

* re-generated monster schema dependent code

added Referrable.cs to FlatBuffers.Test.csproj

6 years agoAdd new c++ helpers to ease usage of size prefixed FlatBuffers (#4626)
desqaz [Thu, 22 Feb 2018 17:19:08 +0000 (18:19 +0100)]
Add new c++ helpers to ease usage of size prefixed FlatBuffers (#4626)

It was missing some helpers when we choose to use
size prefixed FlatBuffers.

* Add general helper : GetPrefixedSize
* Add generated helpers :
 * GetSizePrefixedXXX
 * VerfifySizePrefixedXXXBuffer
 * FinishSizePrefixedXXXBuffer

6 years ago[C++] better type mismatch error (#4623)
Masato Nagai [Fri, 16 Feb 2018 16:32:50 +0000 (01:32 +0900)]
[C++] better type mismatch error (#4623)

* better parse error

* pass str as a pointer instead of a reference for more efficient performance

6 years agoC++: mini_reflect: Add DefaultTypeTable (#4614)
Alexander Gallego [Thu, 15 Feb 2018 22:58:06 +0000 (17:58 -0500)]
C++: mini_reflect: Add DefaultTypeTable (#4614)

* mini_reflect: Add DefaultTypeTable

Currently it's very easy to make a mistake when it comes to
instantiating the TypeTable to print a buffer because it is not type
safe.

This will allow us to write safer cpp code:

flatbuffers::FlatBufferToString(reinterpret_cast<const uint8_t *>(&t),
                                decltype(t)::DefaultTypeTable());

* c++: mini_reflect: update generated code

* Ensure types and names are set for mini_reflect

* c++: mini_refelct: update unit tests with new typed TypeTable

* Adding PR feedback of sylte and naming convention

6 years agoSupport version compatibility checks via find_package command (#4625)
Dmitry Volosnykh [Thu, 15 Feb 2018 21:39:15 +0000 (00:39 +0300)]
Support version compatibility checks via find_package command (#4625)

6 years agoFix for aligned new for gcc >= 7.1 (#4621)
Kamil Rojewski [Mon, 12 Feb 2018 16:37:51 +0000 (17:37 +0100)]
Fix for aligned new for gcc >= 7.1 (#4621)

* Eclipse ignore

* TypeScript support

* Prefixing enums

* Test results

* Merged JS and TS generators

* Fixed AppVeyor build problems

* Fixed more AppVeyor build problems

* Fixed more AppVeyor build problems

* Changed TS flag to options struct

* Storing options by value

* Removed unneeded const

* Re-export support for unions

* Uint support

* Casting bools to numbers for mutation

* TS shell tests

* Reverted generates js test file to original version

* Backing up js tests and properly generating test data

* Not importing flatbuffers for TS test generation

* Not overwriting generated js for tests

* AppVeyor test fixes

* Generating the most strict TS code possible

* Not returning null when creating vectors

* Not returning null from struct contructors

* Vector of unions for ts/js

* Sanity check for languages

* Indentation fix + output test files

* Vectors of unions for php

* Fixes to union vector handling + tests

* Fix for strictPropertyInitialization

* Fix for new aligned operator new for gcc >= 7.1

6 years agoFix vector_data failure under debug (#4606)
vglavnyy [Thu, 8 Feb 2018 23:15:17 +0000 (06:15 +0700)]
Fix vector_data failure under debug (#4606)

6 years agoMisc fixes from internal integration / clang tidy.
Wouter van Oortmerssen [Thu, 8 Feb 2018 22:56:16 +0000 (14:56 -0800)]
Misc fixes from internal integration / clang tidy.

Change-Id: Ic5e8f6a423b426abb9f8b90d39db0f85f28b94be
Tested: on Linux.

6 years agoFix compiler errors in parser (#4612)
Sergey Avseyev [Mon, 5 Feb 2018 20:04:55 +0000 (23:04 +0300)]
Fix compiler errors in parser (#4612)

src/idl_parser.cpp: In member function 'flatbuffers::CheckedError flatbuffers::Parser::ParseHexNum(int, uint64_t*)':
src/idl_parser.cpp:220:62: error: type qualifiers ignored on cast result type [-Werror=ignored-qualifiers]
     if (!isxdigit(static_cast<const unsigned char>(cursor_[i])))
                                                              ^
src/idl_parser.cpp: In member function 'flatbuffers::CheckedError flatbuffers::Parser::Next()':
src/idl_parser.cpp:260:62: error: type qualifiers ignored on cast result type [-Werror=ignored-qualifiers]
         if(!isdigit(static_cast<const unsigned char>(*cursor_))) return NoError();
                                                              ^
cc1plus: all warnings being treated as errors

6 years agoAdd initial Bazel WORKSPACE and BUILD (#4608)
Joe Schafer [Mon, 5 Feb 2018 18:23:15 +0000 (10:23 -0800)]
Add initial Bazel WORKSPACE and BUILD (#4608)

For #4574.

To test:

    bazel test --verbose_failures //:flatbuffers_test

6 years agoCleaned up & fixed buffer alignment handling.
Wouter van Oortmerssen [Mon, 29 Jan 2018 19:46:30 +0000 (11:46 -0800)]
Cleaned up & fixed buffer alignment handling.

- Fixed ForceVectorAlignment (and possibly other call-sites) not
  setting minalign_.
- Fixed flipped alignment parameters in CopyTable (reflection).
- Made aligment for FlatBufferBuilder internal buffer configurable
  (useful when reading a constructed buffer directly).
- Ensured Alignment rounding is always up.

Change-Id: I33ca4887d92a09cb11a369c14a109f4b07ae707a
Tested: on Linux.

6 years agoMade doubles output with higher precision in JSON and elsewhere.
Wouter van Oortmerssen [Mon, 22 Jan 2018 18:11:51 +0000 (10:11 -0800)]
Made doubles output with higher precision in JSON and elsewhere.

Change-Id: I5dd8f3a7c315c40b86a67aba5c2cca4d36363523
Tested: on Linux.

6 years agoRemoved truncating of enum vals to int in ReverseLookup.
Wouter van Oortmerssen [Mon, 22 Jan 2018 17:49:06 +0000 (09:49 -0800)]
Removed truncating of enum vals to int in ReverseLookup.

Some implementations (e.g. C++98) won't support 64-bit enum values,
but there is no reason to silently truncate them.

Change-Id: I8629563523a96e887068f9c0efcd53741f60e0d6
Tested: on Linux.

6 years agoFix the spell mistake (#4599)
Li-Deng [Mon, 22 Jan 2018 17:08:13 +0000 (01:08 +0800)]
Fix the spell mistake (#4599)

6 years agoFixed native_include not requiring a ; terminator.
Wouter van Oortmerssen [Mon, 22 Jan 2018 17:06:13 +0000 (09:06 -0800)]
Fixed native_include not requiring a ; terminator.

Change-Id: Ic4f49e94c67ba23f07e5ba7e87ca94e8db5d5906
Tested: on Linux.

6 years agoNew error: declaring an enum field without a default in range of the enum.
Wouter van Oortmerssen [Thu, 18 Jan 2018 20:06:01 +0000 (12:06 -0800)]
New error: declaring an enum field without a default in range of the enum.

Change-Id: I4db7f032440c00d31c7434975b8a3f17c29d74b9
Tested: on Linux.

6 years agoDisallow defaults on structs.
Wouter van Oortmerssen [Thu, 18 Jan 2018 19:41:43 +0000 (11:41 -0800)]
Disallow defaults on structs.

Change-Id: Ia098126c92ea6f8abe94561bd9c09b29ac8f61f5
Context: https://github.com/google/flatbuffers/issues/4591
Tested: on Linux.

6 years agoRemoved date/time from generated code, causing commit polution.
Wouter van Oortmerssen [Thu, 18 Jan 2018 19:21:10 +0000 (11:21 -0800)]
Removed date/time from generated code, causing commit polution.

Change-Id: I79724416110a3d2241d7eeecf0e12aa6d5b760a0

6 years agoAdded missing generated code.
Wouter van Oortmerssen [Thu, 18 Jan 2018 19:20:58 +0000 (11:20 -0800)]
Added missing generated code.

Change-Id: I9420bf01d2bdb6ccfe3703c835297be73457c0d7

6 years agoRemoved internal variable with name "data" inside a generated method _nested_root...
vglavnyy [Thu, 18 Jan 2018 19:15:31 +0000 (02:15 +0700)]
Removed internal variable with name "data" inside a generated method _nested_root(). Local variable with name "data" violates [-Werror=shadow]. (#4587)

6 years agoUse CreateVectorOfStructs when creating a vector of structs.
Wouter van Oortmerssen [Thu, 18 Jan 2018 19:06:38 +0000 (11:06 -0800)]
Use CreateVectorOfStructs when creating a vector of structs.

(mirrored from cl/180944741)

Change-Id: Ib9f1613ccc355528c5c495fd953a9b3944ecb4ce

6 years agoAuthor: Daniel Lin <danielin@umich.edi> (#4595)
Daniel Lin [Thu, 18 Jan 2018 16:51:57 +0000 (08:51 -0800)]
Author: Daniel Lin <danielin@umich.edi> (#4595)

Date:   Mon Jan 15 11:38:20 2018 -0200

Compilation failure with grpc.h

If cmake run with flag FLATBUFFERS_BUILD_GRPCTEST=ON
compilation fails.

Fix :
-Fix argument list for overriden function in grpc.
-Fix member function name called by FlatBufferBuilder from
buf() to scratch_data()

6 years agoCleaned up FlatBufferBuilder clearing.
Wouter van Oortmerssen [Tue, 16 Jan 2018 17:39:35 +0000 (09:39 -0800)]
Cleaned up FlatBufferBuilder clearing.

Change-Id: I81cf4d268670bdd11d1d56ca9f2de78c120df842
Tested: on Linux.

6 years ago#4522 Conan package support (#4590)
Uilian Ries [Fri, 12 Jan 2018 16:18:20 +0000 (14:18 -0200)]
#4522 Conan package support (#4590)

- Added Conan recipe to build Flatbuffers
- Added Travis job to create Conan package

Signed-off-by: Uilian Ries <uilianries@gmail.com>
6 years agoReduced FlatBufferBuilder from 3 buffers to 1
Wouter van Oortmerssen [Thu, 28 Dec 2017 22:38:04 +0000 (14:38 -0800)]
Reduced FlatBufferBuilder from 3 buffers to 1

Previously, FlatBufferBuilder used 3 resizable buffers:
- serialization (vector_downward)
- field offsets (std::vector)
- vtable offsets (std::vector)

Since the serialization buffer grows downwards, the bottom part of
it can be used as a "scratchpad" storage for the other two. Since
field offsets are only accumulated during table construction, and
vtable offsets only after table construction, the two can trivially
share the same storage.

Not only does this reduce the amount of allocation, it also removes
the bulk of std::vector usage from FlatBufferBuilder which was
the #1 cause of slow-down in debug mode, see e.g.:
https://stackoverflow.com/questions/36085285/any-way-to-improve-flatbuffer-performance-in-debug-c-msvc

Change-Id: I0224cf2f2a863d2d7ef762bc9163b52fdc149522
Tested: on Linux.

6 years agoAdd char * overload for FlatBufferBuilder::CreateString() (#4583)
Andrew Gunnerson [Mon, 8 Jan 2018 16:26:19 +0000 (11:26 -0500)]
Add char * overload for FlatBufferBuilder::CreateString() (#4583)

Without this change, the compiler tries to select the following overload
when CreateString is passed a `char *`:

    template<typename T>
    Offset<String> CreateString(const T &str) {
      return CreateString(str.c_str(), str.length());
    }

which is not valid since char pointers don't have methods.

(Fixes #4579)

Signed-off-by: Andrew Gunnerson <chenxiaolong@cxl.epac.to>
6 years agoPortable range check for *cursor_ value. (#4582)
brianhall77 [Fri, 5 Jan 2018 00:03:03 +0000 (16:03 -0800)]
Portable range check for *cursor_ value. (#4582)

Avoids the following compile error when char is unsigned:

error: comparison of unsigned expression >= 0 is always true [-Werror,-Wtautological-unsigned-zero-compare]

6 years agoGenerateText generate a text string for default identifier of enum and float scalar...
vglavnyy [Thu, 4 Jan 2018 18:12:18 +0000 (01:12 +0700)]
GenerateText generate a text string for default identifier of enum and float scalar. An enum identifier printed as the strictly quoted string. (#4527)

6 years agoRemove unused declarations (#4578)
Andrei Polushin [Thu, 4 Jan 2018 18:01:41 +0000 (01:01 +0700)]
Remove unused declarations (#4578)

6 years agoUpdate URL (#4576)
Darío Hereñú [Thu, 4 Jan 2018 17:10:03 +0000 (14:10 -0300)]
Update URL (#4576)

6 years agoFix error in ConCatPathFileName (#4575)
Bastien Brunnenstein [Thu, 4 Jan 2018 17:09:09 +0000 (18:09 +0100)]
Fix error in ConCatPathFileName (#4575)

6 years agonew maven jar called flatbuffers-java-grpc which contains utility … (#4558)
Yuri Finkelstein [Thu, 28 Dec 2017 23:26:29 +0000 (15:26 -0800)]
new maven jar called flatbuffers-java-grpc which contains utility … (#4558)

* new maven jar called flatbuffers-java-grpc which contains utility class supporting generated code for grpc over flatbuffers; grpc java unit test based on maven and junit (maven is used only for simplicity of testing); removed straneous namespace_test/NamespaceA/TableInC.java which is not longer used in the test and no longer generated but contains complilation errors if java compiler picks it up

* moved java grpc tests files according to review request

* Added missing generated code for Java gRPC.

Change-Id: Iada090fe2e99b80a4b7c2f8e39c838a992a1feae

* added missing name and url

6 years agoAdded missing nullptr check in vector of union verifiers.
Wouter van Oortmerssen [Thu, 28 Dec 2017 18:09:48 +0000 (10:09 -0800)]
Added missing nullptr check in vector of union verifiers.

Change-Id: Iec720991e68ad27580537135bfd8eb4159333921
Tested: on Linux.

6 years agoDisabled python in travis.yml pending fix.
Wouter van Oortmerssen [Thu, 28 Dec 2017 17:56:57 +0000 (09:56 -0800)]
Disabled python in travis.yml pending fix.

Change-Id: I6d2a9cc8b32c531d4a1e272ddf29974a0a1a2ee3

6 years agoVarious build fixes; update checked-in codegen. (#4572)
Josh Ventura [Thu, 28 Dec 2017 17:10:55 +0000 (12:10 -0500)]
Various build fixes; update checked-in codegen. (#4572)

6 years ago fixed java codegen bug documented in #4563 (#4565)
Yuri Finkelstein [Thu, 21 Dec 2017 21:32:34 +0000 (11:32 -1000)]
 fixed java codegen bug documented in #4563 (#4565)

* grpc bindings generator for Java and a few minor supporting changes in improvements

* restored formatting before my previous changes for ease of review

* Fixed grpc java code generation bug resulting in duplicate extractor declarations in case the same is used in more than a single RPC method

* fixed previous merge issue

* removed extra space

* restored extra space

* restored extra space

* fixed java codegen bug documented in https://github.com/google/flatbuffers/issues/4563

6 years agoMade all C++ files clang-formatted.
Wouter van Oortmerssen [Thu, 21 Dec 2017 18:54:28 +0000 (10:54 -0800)]
Made all C++ files clang-formatted.

Also added missing generated files.

Change-Id: Ifd22a643a08e3f2edfce92812ed57b87fc0e1875

6 years agoadded config files for popular formatting tools (#4554)
Yuri Finkelstein [Thu, 21 Dec 2017 18:18:20 +0000 (08:18 -1000)]
added config files for popular formatting tools (#4554)

* added config files for popular formatting tools

* edited and moved formatting files to root per review suggestion

6 years agogrpc bindings generator for Java and a few minor supporting changes i… (#4553)
Yuri Finkelstein [Thu, 21 Dec 2017 17:55:57 +0000 (07:55 -1000)]
grpc bindings generator for Java and a few minor supporting changes i… (#4553)

* grpc bindings generator for Java and a few minor supporting changes in improvements

* restored formatting before my previous changes for ease of review

* Fixed grpc java code generation bug resulting in duplicate extractor declarations in case the same is used in more than a single RPC method

6 years agosynchronized grpc cpp_generator with latest version as of today: grpc-1.8.1. (#4556)
Yuri Finkelstein [Thu, 21 Dec 2017 16:49:00 +0000 (06:49 -1000)]
synchronized grpc cpp_generator with latest version as of today: grpc-1.8.1.  (#4556)

* updateed cpp_generator.cc to be compatible with the latest grpc version

* preserved the original license

* synchronized grpc cpp_generator with latest version as of today: GRPC 1.8.1. Regenerated test/monster_test.grpc.fb.* files and verified that grpctest is nicely passing

* fixed merge glitch

6 years agoupdated cpp_generator.cc to be compatible with the latest grpc version (#4551)
Yuri Finkelstein [Mon, 18 Dec 2017 22:17:59 +0000 (12:17 -1000)]
updated cpp_generator.cc to be compatible with the latest grpc version (#4551)

* updateed cpp_generator.cc to be compatible with the latest grpc version

* preserved the original license

6 years agoupdate mutation status in doc (#4549)
xgdgsc [Mon, 18 Dec 2017 17:14:15 +0000 (01:14 +0800)]
update mutation status in doc (#4549)

6 years agoMerge pull request #4516 from mikeholler/travis
Robert [Thu, 14 Dec 2017 21:20:18 +0000 (13:20 -0800)]
Merge pull request #4516 from mikeholler/travis

Add support for Python lib continuous deployment.

6 years agoFix for strictPropertyInitialization for TS (#4540)
Kamil Rojewski [Thu, 14 Dec 2017 16:30:02 +0000 (17:30 +0100)]
Fix for strictPropertyInitialization for TS (#4540)

* Eclipse ignore

* TypeScript support

* Prefixing enums

* Test results

* Merged JS and TS generators

* Fixed AppVeyor build problems

* Fixed more AppVeyor build problems

* Fixed more AppVeyor build problems

* Changed TS flag to options struct

* Storing options by value

* Removed unneeded const

* Re-export support for unions

* Uint support

* Casting bools to numbers for mutation

* TS shell tests

* Reverted generates js test file to original version

* Backing up js tests and properly generating test data

* Not importing flatbuffers for TS test generation

* Not overwriting generated js for tests

* AppVeyor test fixes

* Generating the most strict TS code possible

* Not returning null when creating vectors

* Not returning null from struct contructors

* Vector of unions for ts/js

* Sanity check for languages

* Indentation fix + output test files

* Vectors of unions for php

* Fixes to union vector handling + tests

* Fix for strictPropertyInitialization

6 years agoChange mikeholler to PYPI_USERNAME
Mike Holler [Wed, 13 Dec 2017 21:14:01 +0000 (15:14 -0600)]
Change mikeholler to PYPI_USERNAME

6 years agoFixed CreateStruct not testing for nesting.
Wouter van Oortmerssen [Thu, 7 Dec 2017 19:15:37 +0000 (11:15 -0800)]
Fixed CreateStruct not testing for nesting.

Change-Id: I16bf46682ad68c62b778ed1514b6b706c8cb8f6f
Tested: on Linux.

6 years agoReplace the non standard M_PI with a constant (#4528)
Bastien Brunnenstein [Mon, 4 Dec 2017 23:06:13 +0000 (00:06 +0100)]
Replace the non standard M_PI with a constant (#4528)

6 years agopublish additional js/flatbuffers.mjs to npm to support ESModules in node (#4504)
Paul Taylor [Fri, 1 Dec 2017 22:18:43 +0000 (14:18 -0800)]
publish additional js/flatbuffers.mjs to npm to support ESModules in node (#4504)

6 years agothis is allow custom allocator for obj-api structs/tables. (#4520)
rmawatson [Fri, 1 Dec 2017 17:15:41 +0000 (18:15 +0100)]
this is allow custom allocator for obj-api structs/tables. (#4520)

added "native_custom_alloc" attribute to tables/structs, eg.

table parent_table( native_custom_alloc:"custom_alloc_name" ) {
...
}

with a custom allocator defined as

template <typename T> class custom_alloc_name : public std::allocator<T> {
public:

 typedef T*       pointer;

 template <class U>
 struct rebind {
  typedef custom_alloc_name<U> other;
 };

 pointer allocate(const std::size_t n) {
      return ....;
 }

 void deallocate(T* ptr, std::size_t n) {
    ...
 }

 custom_alloc_name() throw() {}
 template <class U> custom_alloc_name(const custom_alloc_name<U>&) throw() {}
};
};

6 years agoAdd include directory to CMake install targets (#4510)
Bastien Brunnenstein [Thu, 30 Nov 2017 16:45:58 +0000 (17:45 +0100)]
Add include directory to CMake install targets (#4510)

6 years agoFixed prod PyPI URL and deploy block list.
Mike Holler [Mon, 27 Nov 2017 22:05:45 +0000 (16:05 -0600)]
Fixed prod PyPI URL and deploy block list.

6 years agoAdded all_branches to tags: true block
Mike Holler [Mon, 27 Nov 2017 19:59:01 +0000 (13:59 -0600)]
Added all_branches to tags: true block

6 years agoAdd support for Python lib continuous deployment.
Michael Holler [Wed, 22 Nov 2017 22:46:00 +0000 (16:46 -0600)]
Add support for Python lib continuous deployment.

Use a combination of travis and twine to publish to PyPI. New
publications will be made:

* When `master` is updated. This will trigger the publication of a
  the Python artifact versioned an iso-compliant build datetime. In this
  way, the cutting edge version will always be available via PyPI.
* When a new git tag is pushed. Tag pushes trigger the publication of
  a python artifact with the same version as the git tag, with the
  leading `v` stripped if present (`v1.2.3` becomes `1.2.3`).

Publications rely on Travis having a PYPI_PASSWORD environment set in
the project settings. See the Travis CI documentation for information on
[setting environment variables which containing sensitive data][1]. Make
extra sure the "Display value in build log" switch is OFF.

In addition to setting the previously mentioned `PYPI_PASSWORD`
environment variable, the owner of the PyPI `flatbuffers` repository
should, after merging this commit into master, add his own commit to
change `mikeholler` in `.travis/deploy-python.sh` to his username. It's
also recommended that the owner of `flatbuffers` use a separate account
in the unlikely event that the environment variable somehow becomes
compromised. Again, this is very unlikely, since the environment
variable is only set for "safe" builds approved by maintainers (not on
random pull requests).

[1]: https://docs.travis-ci.com/user/environment-variables/#Defining-Variables-in-Repository-Settings

6 years agoUpdated version numbers to 1.8.0 v1.8.0
Wouter van Oortmerssen [Mon, 20 Nov 2017 17:46:03 +0000 (09:46 -0800)]
Updated version numbers to 1.8.0

Change-Id: I9cf9fe1e2572d3f9c4066624a87249ca1e62a297

6 years agoMissing generated code files.
Wouter van Oortmerssen [Mon, 20 Nov 2017 17:19:35 +0000 (09:19 -0800)]
Missing generated code files.

Change-Id: I8808b0b419981ba7d0699da4a1effb0b660a21cb

6 years agoDocument type aliases (#4499)
MikkelFJ [Fri, 17 Nov 2017 16:57:01 +0000 (17:57 +0100)]
Document type aliases (#4499)

6 years agofix typo (#4495)
Dan Douglas [Fri, 17 Nov 2017 00:03:16 +0000 (16:03 -0800)]
fix typo (#4495)

`Equipment` is a union, not an enum.

6 years agoFixed potential strict-aliasing violation in big-endian code.
Wouter van Oortmerssen [Thu, 16 Nov 2017 22:19:31 +0000 (14:19 -0800)]
Fixed potential strict-aliasing violation in big-endian code.

Also added a test.

Tested on: Linux.

Change-Id: I7b3230f8f6043eec139d5e3e8c9cb45814124274

6 years agoAdd exports for all targets (#4491)
red1939 [Thu, 16 Nov 2017 20:51:25 +0000 (21:51 +0100)]
Add exports for all targets (#4491)

Each target that will be installed will also generate a target that will be
included by CMake config file.

6 years agoc++ Tutorial fix (#4494)
Hong Wu [Thu, 16 Nov 2017 18:09:48 +0000 (12:09 -0600)]
c++ Tutorial fix (#4494)

6 years agoRemove copy constructor to make flatbuffers struct trivially copyable… (#4476)
Louis-Paul CORDIER [Thu, 16 Nov 2017 18:08:41 +0000 (19:08 +0100)]
Remove copy constructor to make flatbuffers struct trivially copyable… (#4476)

* Remove copy constructor to make flatbuffers struct trivially copyable + add tests.

* Add support non c++11 compliant compilers.

* Fix std::trivially_copyiable test for non-C++11 compliant compilers.

* Fix trivially_copyable not part of glibc < 5 even with c++11 switch enabled.

6 years agotutorial docs (#4492)
David Komer [Thu, 16 Nov 2017 16:51:35 +0000 (18:51 +0200)]
tutorial docs (#4492)

6 years agoFix valid params limit exceeded for generated table constructor (#4490)
Angela Sheu [Mon, 13 Nov 2017 21:39:49 +0000 (13:39 -0800)]
Fix valid params limit exceeded for generated table constructor (#4490)

6 years agoMade stl_emulation.h usable by itself.
Wouter van Oortmerssen [Thu, 9 Nov 2017 23:47:44 +0000 (15:47 -0800)]
Made stl_emulation.h usable by itself.

Change-Id: I1d9d301412fe0a036f12eb2cc82a3fbee5bb838d

6 years agoSpecify ABI version for shared library (#4479)
Sergey Avseyev [Thu, 9 Nov 2017 22:39:32 +0000 (01:39 +0300)]
Specify ABI version for shared library (#4479)

6 years agoUse CMake install directories instead of hardcoded (#4481)
Sergey Avseyev [Mon, 6 Nov 2017 18:38:53 +0000 (21:38 +0300)]
Use CMake install directories instead of hardcoded (#4481)

6 years agoText files should not have executable bit set (#4480)
Sergey Avseyev [Mon, 6 Nov 2017 18:20:22 +0000 (21:20 +0300)]
Text files should not have executable bit set (#4480)

6 years agoLink grpctest with libgrpc_unsecure explicitly (#4474)
Lawrence Chan [Mon, 6 Nov 2017 16:43:22 +0000 (10:43 -0600)]
Link grpctest with libgrpc_unsecure explicitly (#4474)

6 years agoUpdated pom.xml to be able to deploy to Maven central.
Wouter van Oortmerssen [Thu, 26 Oct 2017 23:13:04 +0000 (16:13 -0700)]
Updated pom.xml to be able to deploy to Maven central.

Change-Id: Ie28dda5e1854eeff3e254e975925ff846c137008

6 years agoAdded missing EndTable() call to VerifyObject() (#4468)
stefan301 [Mon, 23 Oct 2017 16:15:18 +0000 (18:15 +0200)]
Added missing EndTable() call to VerifyObject() (#4468)

VerifyObject called VerifyTableStart() but not EndTable(). This made Verifier::VerifyComplexity() increase depth_ with each table, not with the depth of tables.

https://groups.google.com/forum/#!topic/flatbuffers/OpxtW5UFAdg