profile/ivi/qtbase.git
12 years agoSkip tests toolbar-dialog/widget_window.
Friedemann Kleint [Mon, 16 Apr 2012 08:30:47 +0000 (10:30 +0200)]
Skip tests toolbar-dialog/widget_window.

To enable merging the api_changes branch.

Task-number: QTBUG-25331
Change-Id: I90d32ca0bd96eed62bae5f01316d6360a3b435c8
Reviewed-by: Sergio Ahumada <sergio.ahumada@nokia.com>
12 years agoMerge "Merge remote-tracking branch 'origin/master' into api_changes" into refs/stagi...
Sergio Ahumada [Tue, 17 Apr 2012 08:38:24 +0000 (10:38 +0200)]
Merge "Merge remote-tracking branch 'origin/master' into api_changes" into refs/staging/api_changes

12 years agoapi: remove QWindow::move
Girish Ramakrishnan [Fri, 13 Apr 2012 20:17:13 +0000 (13:17 -0700)]
api: remove QWindow::move

QWindow::setPos is the correct api.

Change-Id: I5439338e9bc6933800d66331f20ce554b017c4fb
Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
12 years agoapi: Fix const correctness of api in QScreen
Girish Ramakrishnan [Fri, 13 Apr 2012 22:38:41 +0000 (15:38 -0700)]
api: Fix const correctness of api in QScreen

const was missing in many convenience functions.

grabWindow should not be const since it actually does something.

Change-Id: I0ffa718878d4251c4fb5c34789cf58ebb85cff37
Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
12 years agoapi: Make QGuiApplication::styleHints() static
Girish Ramakrishnan [Fri, 13 Apr 2012 14:30:02 +0000 (07:30 -0700)]
api: Make QGuiApplication::styleHints() static

Practically all functions in QGuiApplication are static.

Change-Id: I5948620865c021029a3c04b31901b1110e6c0d27
Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
12 years agoFix tst_qtracebench benchmark.
Jędrzej Nowacki [Mon, 16 Apr 2012 14:01:50 +0000 (16:01 +0200)]
Fix tst_qtracebench benchmark.

Default QDataStream version was changed in Qt5, but the test tried to
load an old dumped file.

Change-Id: I49c06c232ec8a27f33c9da345bae4e03cd0c56fb
Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
12 years agoUpdate parent indexes first with changePersistentIndex.
Stephen Kelly [Sun, 15 Apr 2012 21:03:40 +0000 (23:03 +0200)]
Update parent indexes first with changePersistentIndex.

Otherwise, the order of updating of the indexes will cause
inconsistent results because it will rely on ordering within a
QHash (which is indeterminate).

Task-number: QTBUG-25325

Change-Id: I7d99578c8ee2954b8562dc5aff7dc32e74d41fb5
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
12 years agoMake reallocData use QArrayData::AllocationOptions
João Abecasis [Fri, 6 Apr 2012 08:12:36 +0000 (10:12 +0200)]
Make reallocData use QArrayData::AllocationOptions

Growth computations are deferred to QArrayData::allocate, except in the
case of realloc as that functionality is currently lacking in
QArrayData. Since that sits in library code, anyway, it can be changed
later to use a future QArrayData::reallocate.

As it is, reallocData is becoming a model for QArrayData::reallocate
and what it can offer to containers of POD/movable types.

Change-Id: I045483f729114be43e4818149d1be1b333bcbe13
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
12 years agoDrop unnecessary assignment
João Abecasis [Fri, 6 Apr 2012 07:56:20 +0000 (09:56 +0200)]
Drop unnecessary assignment

In this branch, !IS_RAW_DATA has already established that offset is
sizeof(QByteArrayData) and realloc maintains the assumption.

Change-Id: Ic160e36d7781d4c4f64a3b2ebec98c9cb605b3eb
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@nokia.com>
12 years agoMigrate QByteArray over QArrayData.
Jędrzej Nowacki [Tue, 27 Mar 2012 11:17:46 +0000 (13:17 +0200)]
Migrate QByteArray over QArrayData.

For the time being QByteArrayData keeps its independent existence, for
the sake of other modules. Once they have been ported to use the new
initializer macros it can be changed to:

    struct QByteArrayData { QArrayData array; };

Extra braces can then be added to the macros.

With respect to source compatibility, the only concern is with other
modules, as QByteArrayData has already changed in incompatible ways with
Qt 4.x

Done-with: João Abecasis
Change-Id: I044e2a680317431777a098feec8839a90a3d3da3
Reviewed-by: João Abecasis <joao.abecasis@nokia.com>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
12 years agoRemove explicit checks for shared_null/empty
João Abecasis [Fri, 6 Apr 2012 07:24:37 +0000 (09:24 +0200)]
Remove explicit checks for shared_null/empty

This eases porting to QArrayData and retains semantics. In append() and
prepend() a conditional was generalized so that no work is done if there
is nothing to add.

Done-with: Jędrzej Nowacki
Change-Id: Ib9e7bb572801b2434fa040cde2bf66dacf595f22
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@nokia.com>
12 years agoMake QByteArray and QString keep track of terminating null
João Abecasis [Wed, 4 Apr 2012 13:36:09 +0000 (15:36 +0200)]
Make QByteArray and QString keep track of terminating null

In conceptual terms, this change increments the Data::alloc member by
one for all strings allocated and maintained by these classes. Instances
initialized with fromRawData retain 0 as the member value, so they are
treated as immutable.

This brings QByteArray and QString closer to QVector, making it possible
for them to reference and share the same data in memory, in the future.
It also brings them closer to QArrayData.

In practical terms all comparisons to the alloc member were changed to
take into account that it also tracks the terminating null character.

Aside from the increment in the alloc member, there should be no user
visible changes.

Change-Id: I618f49022a9b1845754500c8f8706c72a68b9c7d
Reviewed-by: João Abecasis <joao.abecasis@nokia.com>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
12 years agoMerge remote-tracking branch 'origin/master' into api_changes
Lars Knoll [Mon, 16 Apr 2012 10:04:34 +0000 (12:04 +0200)]
Merge remote-tracking branch 'origin/master' into api_changes

Conflicts:
configure
src/corelib/io/qurl.cpp
src/gui/kernel/qwindow.cpp
src/tools/moc/generator.cpp
src/widgets/kernel/qwidget_qpa.cpp
src/widgets/styles/qstyle.h
src/widgets/widgets/qtabbar.cpp
tests/auto/corelib/codecs/utf8/tst_utf8.cpp

Change-Id: Ia457228d6f684ec8184e13e8fcc9d25857b1751e

12 years agoShow the type and address of QObjects in debug output.
Stephen Kelly [Sun, 15 Apr 2012 23:17:00 +0000 (01:17 +0200)]
Show the type and address of QObjects in debug output.

Change-Id: I9f44ab80a6fb763adc9cbaf47de8e1b97212332d
Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@nokia.com>
12 years agoqmenu.h includes private headers
Girish Ramakrishnan [Sun, 15 Apr 2012 11:02:31 +0000 (04:02 -0700)]
qmenu.h includes private headers

qpa includes are considered private and should not be included
in public header files.

Change-Id: I26c744ec1d8ddef7b0c11c3d26b593be05f5aa54
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
12 years agoapi: fix constness of QOpenGLContext::getProcAddress
Girish Ramakrishnan [Fri, 13 Apr 2012 22:53:50 +0000 (15:53 -0700)]
api: fix constness of QOpenGLContext::getProcAddress

Should be const just like Qt4's QGLContext::getProcAddress.

Change-Id: I273467d5cf852cd49f48cec3f335c4ddac795363
Reviewed-by: Gunnar Sletta <gunnar.sletta@nokia.com>
12 years agoAdding support for obtaining an OpenGL Core Profile context on Mac OSX
Sean Harmer [Wed, 21 Mar 2012 10:39:55 +0000 (10:39 +0000)]
Adding support for obtaining an OpenGL Core Profile context on Mac OSX

Change-Id: I08048ecee9b243b122ee93fce316e498aa7e2d51
Reviewed-by: James Turner <james.turner@kdab.com>
Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
Reviewed-by: Morten Johan Sørvig <morten.sorvig@nokia.com>
12 years agoFix incorrect state of show/hide menu items in Mac application menu
Pasi Matilainen [Thu, 2 Feb 2012 06:18:50 +0000 (08:18 +0200)]
Fix incorrect state of show/hide menu items in Mac application menu

The "Hide <app>", "Hide Others" and "Show All" menu items in Mac
application menu are always enabled, and do not get disabled correctly.
Fix by turning on autoenable for the menu in qt_menu.nib, and by
implementing menu item validation in QCocoaMenuLoader.

Task-number: QTBUG-10705
Change-Id: Ic181dfa26a71acad0067f5269c72517b50b17362
Reviewed-by: Morten Johan Sørvig <morten.sorvig@nokia.com>
(cherry picked from commit 8f23a6be1069455e609e8bea7527726c24bebb36)

12 years agoPut bug numbers on same line as insignificant_test markers.
Jason McDonald [Fri, 13 Apr 2012 07:59:37 +0000 (17:59 +1000)]
Put bug numbers on same line as insignificant_test markers.

This makes it easier to find insignificant tests that have no associated
bug report.

Change-Id: Ia71d59da062818d3860b0365d063e044705267fd
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
12 years agomoc: Fix parsing of the empty preprocessor command
Olivier Goffart [Tue, 10 Apr 2012 11:38:41 +0000 (13:38 +0200)]
moc: Fix parsing of the empty preprocessor command

When encountering a null preprocessing directive (which is supposed to
be ignored), the moc preprocessor will leave a PP_NEWLINE token in the
token stream. That will confuse the parser.
The PP_NEWLINE token need to be ignored in the preprocessing phase.

Task-number: QTBUG-22717
Change-Id: I1e502a7e5bc6fa8ce2f82109ba7199b95747ff0a
Reviewed-by: João Abecasis <joao.abecasis@nokia.com>
Reviewed-by: Bradley T. Hughes <bradley.hughes@nokia.com>
12 years agoUpdate com.trolltech -> org.qtproject in the bootstrapped tools
Thiago Macieira [Thu, 29 Mar 2012 14:14:12 +0000 (11:14 -0300)]
Update com.trolltech -> org.qtproject in the bootstrapped tools

The tools will now generate the new org.qtproject annotations only,
matching the XML generator in the library. They accept both types of
annotations as input though -- and will generate a warning about the
older one.

This commit should be backported to Qt 4, so XML files can start to be
ported.

Task-number: QTBUG-23274
Change-Id: If298c342ab4774cbca1be1898a01af8b46e80446
Reviewed-by: Jason McDonald <jason.mcdonald@nokia.com>
Reviewed-by: Lorn Potter <lorn.potter@nokia.com>
12 years agoIntroduce the new UnknownProperty and PropertyReadOnly errors
Thiago Macieira [Thu, 29 Mar 2012 14:11:51 +0000 (11:11 -0300)]
Introduce the new UnknownProperty and PropertyReadOnly errors

Those error codes have been standardised for years but we haven't used
them until now.

Task-number: QTBUG-23274
Change-Id: Iebc9ded949f363281a4d43fd9d29a284f2e2df08
Reviewed-by: Jason McDonald <jason.mcdonald@nokia.com>
Reviewed-by: Lorn Potter <lorn.potter@nokia.com>
12 years agoFinish cleaning up com.trolltech -> org.qtproject in QtDBus
Thiago Macieira [Thu, 29 Mar 2012 14:11:03 +0000 (11:11 -0300)]
Finish cleaning up com.trolltech -> org.qtproject in QtDBus

Lots of uses of the annotations and error names, plus a bunch of local
unit test names (including one file that had to be renamed).

The meta object generator is updated to support both the old and new
names. That means some references to com.trolltech *must* remain in the
source code.

Task-number: QTBUG-23274
Change-Id: Icc38ae040232f07c437e7546ee744a4703f41726
Reviewed-by: Jason McDonald <jason.mcdonald@nokia.com>
Reviewed-by: Lorn Potter <lorn.potter@nokia.com>
12 years agoUpdate the error codes in QtDBus
Thiago Macieira [Thu, 29 Mar 2012 12:53:06 +0000 (09:53 -0300)]
Update the error codes in QtDBus

Change the old com.trolltech ones to org.qtproject and introduce Use
the alternate domain name for the Qt Project because the dash
character is not valid in interface and error names.

Task-number: QTBUG-23274
Change-Id: Iac1699e70525d67f983c10560932acff6b2ecde6
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
Reviewed-by: Jason McDonald <jason.mcdonald@nokia.com>
12 years agoMark tst_qabstractitemmodel as insignificant after QHash randomization
Giuseppe D'Angelo [Sun, 15 Apr 2012 18:05:10 +0000 (19:05 +0100)]
Mark tst_qabstractitemmodel as insignificant after QHash randomization

The testChildrenLayoutsChanged fails randomly. This happens rarely,
f.i. wasn't spotted by CI when QHash randomization itself was merged;
but is indeed reproducible by running the test a few times in a row.

This is now blocking api_merges integration, and I have no idea
how to fix it.

This patch marks the test as insignificant for now (the bug
tracking this test failure is QTBUG-25325), and switches the failing
tests from QVERIFY(a == b) to a proper QCOMPARE (so that the
expected values do show up in the build logs).

Change-Id: I16f0e28bcbb06dbac2e7169f4676a19ccf626a92
Reviewed-by: Stephen Kelly <stephen.kelly@kdab.com>
12 years agowidgets: Fix painting to a fully transparent top level widget
Holger Hans Peter Freyther [Mon, 2 Apr 2012 09:59:04 +0000 (11:59 +0200)]
widgets: Fix painting to a fully transparent top level widget

QWS used to have a line to change the composite mode from SourceOver
to Source for the top level widget. This wasn't used with QPA and I
removed the internal DontSetCompositionMode in qtbase. It turns out that
the QWS way is the most efficient one to initialize the background of
the widget.

The alternative is to have the QPlatformBackingStore::beginPaint
always clear the entire to be painted area and then paint the background
of the widget. The difference of painting each pixel once or twice is
noticable on embedded platforms and in the range of one to two fps.

Reproduce the issue with:
echo "QWidget {background: transparent}" > style.css
./examples/widgets/wiggly/wiggly -stylesheet style.css

Task-number: QTBUG-24526
Change-Id: Ica4c980bb3bf6eb87ddb5b510ac7493292d01543
Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
Reviewed-by: Girish Ramakrishnan <girish.1.ramakrishnan@nokia.com>
12 years agoNow QSplitter can have 0-pixel handle
ABBAPOH [Sat, 25 Feb 2012 19:52:09 +0000 (23:52 +0400)]
Now QSplitter can have 0-pixel handle

Change-Id: Iad920ffcd5d7f4c01504d41d1740f130b7aa53dd
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Reviewed-by: Girish Ramakrishnan <girish.1.ramakrishnan@nokia.com>
12 years agoUCD-5.0: apply Corrigendum #6
Konstantin Ritt [Tue, 10 Apr 2012 20:39:40 +0000 (23:39 +0300)]
UCD-5.0: apply Corrigendum #6

http://unicode.org/versions/corrigendum6.html:
> in Unicode 5.0, the list of characters with the Bidi_Mirrored property
> was made consistent for brackets and quotation marks, in preparation for
> new constraints on bidi mirroring. However, after publication of
> Unicode 5.0.0 it was discovered that this change adversely affected
> several quotation mark characters in deployed data.

Task-number: QTBUG-25169
Change-Id: Id49caf401af2d5a1e6dbcc32b2f350aa20b7f901
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
12 years agoFixed broken logic in evdev input plugins.
Samuel Rødal [Fri, 13 Apr 2012 18:31:41 +0000 (20:31 +0200)]
Fixed broken logic in evdev input plugins.

If we do multiple reads we need to accumulate the total amount of bytes
read, instead of just taking the last read amount into account.

Change-Id: Iaa9b90c269f3ed9d09dae67452ca816d9db6217f
Reviewed-by: Johannes Zellner <johannes.zellner@nokia.com>
Reviewed-by: Girish Ramakrishnan <girish.1.ramakrishnan@nokia.com>
12 years agoFold qpaintdevice_qpa.cpp into qpaintdevice.cpp
Girish Ramakrishnan [Sat, 14 Apr 2012 00:02:37 +0000 (17:02 -0700)]
Fold qpaintdevice_qpa.cpp into qpaintdevice.cpp

Change-Id: I274508826b9be4eb00f67fccae5a18ecbdf41a36
Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
12 years agoFix header inclusion guard
Girish Ramakrishnan [Fri, 13 Apr 2012 23:28:26 +0000 (16:28 -0700)]
Fix header inclusion guard

Change-Id: Icc537d5b52315b9563078da9fa69ddd67b567f76
Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
12 years agoFix tst_QMdiSubWindow::emittingOfSignals CI failures
Girish Ramakrishnan [Sat, 14 Apr 2012 21:19:45 +0000 (14:19 -0700)]
Fix tst_QMdiSubWindow::emittingOfSignals CI failures

The test fails consistently on the CI (but never fails on any
of the developer machines). This is possibly a timing issue.

Change-Id: Ie40d9c38c3128a93898b0e50bfde5a754bd2b7fb
Reviewed-by: Giuseppe D'Angelo <dangelog@gmail.com>
Reviewed-by: Robin Burchell <robin+qt@viroteck.net>
12 years agodoc: QWindowSurface is dead
Girish Ramakrishnan [Fri, 13 Apr 2012 16:14:59 +0000 (09:14 -0700)]
doc: QWindowSurface is dead

It goes by the name of QBackingStore these days.

Change-Id: Id46254e47ee0abf9e669862eec6c2205d9634368
Reviewed-by: Holger Freyther <holger+qt@freyther.de>
Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
12 years agoQDoc: add missing newline characters in qdoc -help.
Casper van Donderen [Fri, 13 Apr 2012 10:04:55 +0000 (12:04 +0200)]
QDoc: add missing newline characters in qdoc -help.

Change-Id: Ibd50091693be393c6b479d6ca8927ba1ed578709
Reviewed-by: Martin Smith <martin.smith@nokia.com>
12 years agoqdoc: Fixed bugs causing invalid DITA XML
Martin Smith [Fri, 13 Apr 2012 10:55:56 +0000 (12:55 +0200)]
qdoc: Fixed bugs causing invalid DITA XML

Fixed a bug in qdoc that caused too many end elements to be generated.
Also fixed some doc errors that caused invalid DITA to be generated.

Task nr: QTBUG-25302

Change-Id: Ifbbf457d28c51c2691a252888447739da7713bc9
Reviewed-by: Martin Smith <martin.smith@nokia.com>
Reviewed-by: Casper van Donderen <casper.vandonderen@nokia.com>
12 years agoQHash security fix (2/2): enable QHash random seed
Giuseppe D'Angelo [Sat, 24 Mar 2012 08:50:02 +0000 (08:50 +0000)]
QHash security fix (2/2): enable QHash random seed

Algorithmic complexity attacks against hash tables have been known
since 2003 (cf. [1, 2]), and they have been left unpatched for years
until the 2011 attacks [3] against many libraries /
(reference) implementations of programming languages.

This patch makes qHash use the QHash seed introduced in the
previous commits, thus truly randomizing bucketing in QHash.

[1] http://www.cs.rice.edu/~scrosby/hash/CrosbyWallach_UsenixSec2003.pdf
[2] http://perldoc.perl.org/perlsec.html#Algorithmic-Complexity-Attacks
[3] http://www.ocert.org/advisories/ocert-2011-003.html

Task-number: QTBUG-23529
Change-Id: Ibee9cf6aa820af5d777fcde478647665c728052a
Reviewed-by: Jason McDonald <jason.mcdonald@nokia.com>
12 years agoQHash: remove optimization for QHash<int, T>
Giuseppe D'Angelo [Fri, 13 Apr 2012 17:59:58 +0000 (18:59 +0100)]
QHash: remove optimization for QHash<int, T>

QHash employs an optimization for int/uints, squashing the hash
value and the key value inside an union. This obviously works
iff qHash(int k) = k. If the hash value gets salted, the hash
table is corrupted.

This patch removes that optimization by means of a #if 0,
so if further research finds out that we want those 4 bytes back
it's pretty simple to revert.

Change-Id: If273f0bf2ff007f4f2f7c46d2aab364a3b455cf1
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
12 years agoQHash: fix key() test
Giuseppe D'Angelo [Fri, 13 Apr 2012 18:41:47 +0000 (19:41 +0100)]
QHash: fix key() test

The key returned by QHash::key is an arbitrary one that maps to the
given value. The test instead relied on it being a specific one.

Change-Id: I090351797e8b52036d78160fd810518a11e8107d
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
12 years agoqHash: qHash(T*) two arguments support
Giuseppe D'Angelo [Tue, 10 Apr 2012 20:28:10 +0000 (21:28 +0100)]
qHash: qHash(T*) two arguments support

Change-Id: I1b78914fe9c6ee9251d68af1f2e95f1e3e0f1db5
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
12 years agoqHash: two arguments support for simple integer types (and QChar)
Giuseppe D'Angelo [Fri, 13 Apr 2012 18:01:16 +0000 (19:01 +0100)]
qHash: two arguments support for simple integer types (and QChar)

Change-Id: I24bed73422fb1d2e90cf3dd4e5375e249b3dcac4
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Reviewed-by: João Abecasis <joao.abecasis@nokia.com>
12 years agoUpdate accessibility selections in QTextControl.
Frederik Gladhorn [Fri, 20 Jan 2012 18:07:54 +0000 (19:07 +0100)]
Update accessibility selections in QTextControl.

Forwardport from Qt 4.

Change-Id: Iae0c2792b64b8ec2736a9ff621cf7c313a394093
Reviewed-by: Jan-Arve Sæther <jan-arve.saether@nokia.com>
(cherry picked from commit d5649547d641b9c5af3c3f814caf8e1ab5bf9f47)

12 years agoFix header inclusion guards
Girish Ramakrishnan [Fri, 13 Apr 2012 16:39:15 +0000 (09:39 -0700)]
Fix header inclusion guards

_QPA_ should only be used for qpa (plugin specific api) files.

Change-Id: I1fb6cd5973fcabec4c7e87eb6ccb048f825e2aad
Reviewed-by: Holger Freyther <holger+qt@freyther.de>
Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
12 years agoRemoved QXmlStreamReader::readElementText overload
Thorbjørn Lindeijer [Thu, 12 Apr 2012 20:21:56 +0000 (22:21 +0200)]
Removed QXmlStreamReader::readElementText overload

The version without argument was kept for binary compatibility when
the configurable ReadElementTextBehaviour was introduced. It is now
dropped in favour of using a default argument value.

Change-Id: Ic08c41d5a5aad9f22df7fc37a2d53ffbc6df1fe9
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
12 years agoQTBUG-1363: fix QSqlField.length() for ODBC
Mark Brand [Thu, 12 Apr 2012 10:49:03 +0000 (12:49 +0200)]
QTBUG-1363: fix QSqlField.length() for ODBC

Applied Bill King's suggestion in QTBUG-1363. Columns of
hStmt must be accessed in order.

Verified using ODBC driver on SQL Server 2005 on Windows 7.

Added test for length of text field for MS SQL Server over ODBC.

Task-Id: QTBUG-1363
Change-Id: I6673dafe75e3ef394d41e439adb45096c1421068
Reviewed-by: Bill King <bill.king@nokia.com>
Reviewed-by: Mark Brand <mabrand@mabrand.nl>
12 years agoWindows: Determine suitable font engine from application.
Friedemann Kleint [Thu, 12 Apr 2012 14:30:23 +0000 (16:30 +0200)]
Windows: Determine suitable font engine from application.

The Freetype engine currently works better for QML2, whereas
the native engine is better suited to the widgets.

Task-number: QTBUG-24205

Change-Id: I76de98c3e7c84a2d72542ea9860b8be1e67f7e04
Reviewed-by: Jan-Arve Sæther <jan-arve.saether@nokia.com>
12 years agoFix warnings in manual tests.
Friedemann Kleint [Thu, 12 Apr 2012 11:59:03 +0000 (13:59 +0200)]
Fix warnings in manual tests.

- Constructor order.
- Unused variables.
- size_t -> int conversions.

Change-Id: Ic5b016f41d01a4d8153ae0900b607bf946523c1d
Reviewed-by: Jason McDonald <jason.mcdonald@nokia.com>
12 years agoUse QPointer to store accessible object.
Frederik Gladhorn [Tue, 10 Apr 2012 20:58:05 +0000 (22:58 +0200)]
Use QPointer to store accessible object.

Itemview were not following the established pattern
of keeping the referenced object in a QPointer.
This made them a lot more crash prone.

Port of Qt 4 change.

Conflicts:

src/plugins/accessible/widgets/itemviews.cpp
src/plugins/accessible/widgets/itemviews.h

Change-Id: I210b112b9c3647b246fde2d6c69aba9ce8d25bd3
Reviewed-by: Jan-Arve Sæther <jan-arve.saether@nokia.com>
(cherry picked from commit f420ab2870d3c96e9678c24c64b4e26ec8a771bd)

12 years agodoc: Fix QObject::connect documentation
Olivier Goffart [Thu, 12 Apr 2012 20:46:01 +0000 (22:46 +0200)]
doc: Fix QObject::connect documentation

Unfortunately, qdoc is too simple to understand any pointer to member
function syntax.
(the ::* token is not even tokenized. And even if it was, it would be a
difficult way to hack that into the parser. (there is already an ugly
workaround for non-member pointer to function hat works by having '(*'
as a token,but the same hack is not possible for pointer to member function))
So I just put verbatim 'PointerToMemberFunction'

Also remove the obsolete mention that Qt::UniqueConnection is not supported
in that overload. It is now. (And it even contradicts the previous
paragraph)

Change-Id: I8fc9544808c9a462b0f11ccea406e2e33dee15b1
Reviewed-by: Geir Vattekar <geir.vattekar@nokia.com>
Reviewed-by: Casper van Donderen <casper.vandonderen@nokia.com>
12 years agoMove QPainterPathPrivate to the private header files.
Gunnar Sletta [Fri, 13 Apr 2012 07:28:44 +0000 (09:28 +0200)]
Move QPainterPathPrivate to the private header files.

This was made inline for the sake of performance, but has in hindsight
proven to be not really worth it. It also prevents us from aligning
the internal datastructure of QPainterPath with that of QPolygonF
and the internal QVectorPath class which would make mapping
between the two inside QPainter a lot faster.

Making all this out-of-line now as discussed in the task
https://bugreports.qt-project.org/browse/QTBUG-19998
so we can adress this in a binary compatible fashion during
Qt 5.x

Change-Id: I61058171ed31f8a845fa45517248367c85ce52cd
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
12 years agodirectfb: Integrate building into configure.
Holger Hans Peter Freyther [Tue, 28 Feb 2012 09:00:32 +0000 (10:00 +0100)]
directfb: Integrate building into configure.

Add DirectFB buildsystem integration by adding a configure target
and adding it as subdirectory to the project file. The default is
to automatically build directfb. Update the Broadcom/9425 build.

Change-Id: I482f865cebd9d5cd4c98c184773f8534f92db9df
Reviewed-by: Girish Ramakrishnan <girish.1.ramakrishnan@nokia.com>
12 years agoQSharedPointer: hash autotest fix
Giuseppe D'Angelo [Mon, 9 Apr 2012 18:14:31 +0000 (19:14 +0100)]
QSharedPointer: hash autotest fix

The hash autotest is wrong: it assumed that the iterator on the hash
would reach the end after iterating on two elements with identical key.
But three elements were added to that hash, and the third one
can appear after the other two.

That code path is left for the map test only.

Change-Id: I51de7987e2b132b6caff7bb4bac6a57fb7fcb530
Reviewed-by: Robin Burchell <robin+qt@viroteck.net>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
12 years agoQSharedPointer: qHash two arguments support
Giuseppe D'Angelo [Tue, 10 Apr 2012 23:40:36 +0000 (00:40 +0100)]
QSharedPointer: qHash two arguments support

Change-Id: I800de3fd9769e4829018360c25a8cf2ee2e2e08b
Reviewed-by: Robin Burchell <robin+qt@viroteck.net>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
12 years agoMinor cleanup of the header file.
Jan-Arve Saether [Wed, 11 Apr 2012 05:58:20 +0000 (07:58 +0200)]
Minor cleanup of the header file.

Move inline implementations to iaccessible2.cpp.
Makes it easier to read and navigate the source code.

Change-Id: I8da44ba0d40395356f612ff6b3ce2a808105838a
Reviewed-by: Mark Brand <mabrand@mabrand.nl>
12 years agore-enable qabstractnetworkcache autotest
Shane Kearns [Thu, 12 Apr 2012 17:42:51 +0000 (18:42 +0100)]
re-enable qabstractnetworkcache autotest

I have run the test 250 times in each of these configs with no
crashes observed, so assuming the instability has been fixed
by another change.
ubuntu 11.10 64 bit
ubuntu 10.04 32 bit
windows 7 msvc2010 64 bit (debug)
windows 7 msvc2010 32 bit (release)

Task-number: QTBUG-20686
Change-Id: I02bab165c263cf79684c7723eae1e278839b1e37
Reviewed-by: Jason McDonald <jason.mcdonald@nokia.com>
12 years agoQRegularExpression: add more test data
Giuseppe D'Angelo [Mon, 9 Apr 2012 00:38:43 +0000 (01:38 +0100)]
QRegularExpression: add more test data

Change-Id: I44d19f976ced7b073f66d0ea943fafea37940c48
Reviewed-by: Jason McDonald <jason.mcdonald@nokia.com>
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
12 years agoWindows QPA plugin: Fix logging.
Friedemann Kleint [Thu, 12 Apr 2012 13:32:45 +0000 (15:32 +0200)]
Windows QPA plugin: Fix logging.

- Remove frequently occurring messages.
- Rename variable to QT_QPA_VERBOSE.

Change-Id: Id930e1422675355a9657edae6505be87aaec98a5
Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
12 years agoAdd unit test for BackgroundRequestAttribute
Shane Kearns [Tue, 10 Apr 2012 12:14:51 +0000 (13:14 +0100)]
Add unit test for BackgroundRequestAttribute

Change-Id: I807953cac3d23825461f9ae860badbd148835330
Reviewed-by: Martin Petersson <Martin.Petersson@nokia.com>
12 years agotest: Don't mark tst_qscrollbar as insignificant on Mac OS X
Sergio Ahumada [Thu, 12 Apr 2012 10:23:46 +0000 (12:23 +0200)]
test: Don't mark tst_qscrollbar as insignificant on Mac OS X

Just XFAIL the failing test instead of ignoring the whole test.

Task-number: QTBUG-25272
Change-Id: Iedca9913032f13c6610b049a0313c9e4336216e0
Reviewed-by: Bradley T. Hughes <bradley.hughes@nokia.com>
12 years agoreplace hardcoded values with a surrogate handling methods
Konstantin Ritt [Thu, 12 Apr 2012 15:21:39 +0000 (18:21 +0300)]
replace hardcoded values with a surrogate handling methods

Change-Id: Ib41e08d835f2e8ca2e32b4025c6f5a99840f2e27
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
12 years agoMerge the two overloads of QButtonGroup::addButton().
Jason McDonald [Wed, 11 Apr 2012 13:46:41 +0000 (23:46 +1000)]
Merge the two overloads of QButtonGroup::addButton().

This change is source-compatible, but binary-incompatible.

Task-number: QTBUG-25101
Change-Id: If67aec2ca8dd54ad9315f6497c2dafbbbc0b775f
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
12 years agoQLayoutItem - make controlTypes a virtual function.
Thorbjørn Lund Martsum [Fri, 16 Mar 2012 06:00:45 +0000 (07:00 +0100)]
QLayoutItem - make controlTypes a virtual function.

Just implementing the ### Qt5 suggestion about making
controlTypes a virtual function.

Change-Id: Ic1db47fe488f089de965438e456e9b48e0b96f32
Reviewed-by: Girish Ramakrishnan <girish.1.ramakrishnan@nokia.com>
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
12 years agoFix unsigned comparison warning.
Stephen Kelly [Wed, 11 Apr 2012 16:04:53 +0000 (18:04 +0200)]
Fix unsigned comparison warning.

Change-Id: I8544f47177b68cf29ce9fbebb152ca73db6e219d
Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@nokia.com>
12 years agoFix compiling with XCode 4.3
Aron Rosenberg [Sat, 31 Mar 2012 20:03:34 +0000 (13:03 -0700)]
Fix compiling with XCode 4.3

XCode 4.3 moved the location of the SDK dir, so change the qmake
test to not use the old hardcoded location. Also change the test
to look for versions before 10.6 instead of later than 10.6 so 10.8+
gets detected correctly.

Change-Id: I1cb53a18c4b4f484d0d9de9c9d5e9641018f2502
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
Reviewed-by: Morten Johan Sørvig <morten.sorvig@nokia.com>
12 years agoQChar: documentation fixes
Konstantin Ritt [Wed, 11 Apr 2012 08:42:31 +0000 (11:42 +0300)]
QChar: documentation fixes

Change-Id: Ic4b58ab811e53cf175ebaf0a67c40c56678f0f35
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
12 years agoFix wrong casing in include of qcocoaclipboard.h
Tor Arne Vestbø [Fri, 30 Mar 2012 10:42:02 +0000 (12:42 +0200)]
Fix wrong casing in include of qcocoaclipboard.h

Change-Id: Ib8294849d07abdf957a03ce0cb67c533905247a7
Reviewed-by: Morten Johan Sørvig <morten.sorvig@nokia.com>
12 years agoAdded iOS compatibility.
Qt4iOS [Sat, 24 Mar 2012 14:20:56 +0000 (14:20 +0000)]
Added iOS compatibility.

Put MacOS-specific code in #ifdef blocks to disable compilation on iOS.

Change-Id: I02c99c62b8ceb468b8b58e3c4ef52ca8ae2495f1
Reviewed-by: Morten Johan Sørvig <morten.sorvig@nokia.com>
12 years agoAdded iOS compatibility.
Qt4iOS [Sat, 24 Mar 2012 14:18:43 +0000 (14:18 +0000)]
Added iOS compatibility.

Put MacOS-specific code in #ifdef blocks so that it is not compiled for
iOS. Add iOS implementation for MacOS-specific code, where possible.

Change-Id: I3664c76fcfa8d5497ad1db676b9331e4ae0dca0e
Reviewed-by: Morten Johan Sørvig <morten.sorvig@nokia.com>
12 years agoAdded iOS compatibility.
Qt4iOS [Sat, 24 Mar 2012 14:15:29 +0000 (14:15 +0000)]
Added iOS compatibility.

Modified OpenGL header inclusion block to support iOS GL include paths.
Removed ability to build for MacOS with GLES2, as no support on MacOS
for OpenGLES.

Change-Id: I2bcf302278545147632b23a86380fa3980ec10a4
Reviewed-by: Morten Johan Sørvig <morten.sorvig@nokia.com>
12 years agoAdded iOS compatibility.
Qt4iOS [Sat, 24 Mar 2012 14:12:43 +0000 (14:12 +0000)]
Added iOS compatibility.

Put MacOS-specific code into #ifdef blocks to enable compilation on iOS.

Change-Id: I0bb3846f457d1b3a56d99fe182b1718bc8429117
Reviewed-by: Shane Kearns <shane.kearns@accenture.com>
12 years agoQDoc: Fix infinite loop when finding items in ditamaps.
Casper van Donderen [Thu, 12 Apr 2012 08:11:59 +0000 (10:11 +0200)]
QDoc: Fix infinite loop when finding items in ditamaps.

Change-Id: Ic033676e21a252db07543fccba0d2a41f4b52294
Reviewed-by: Martin Smith <martin.smith@nokia.com>
12 years agoPrevent warning when using QPainter on a QGLWidget.
Samuel Rødal [Thu, 12 Apr 2012 07:39:24 +0000 (09:39 +0200)]
Prevent warning when using QPainter on a QGLWidget.

Prevents warning "QOpenGLContext::swapBuffers() called without
corresponding makeCurrent()".

Change-Id: I7e4f94df8654f899c25b3f41cbf4d007ca293f16
Reviewed-by: Gunnar Sletta <gunnar.sletta@nokia.com>
12 years agoImplement modality in the Windows plugin.
Friedemann Kleint [Thu, 29 Mar 2012 10:55:12 +0000 (12:55 +0200)]
Implement modality in the Windows plugin.

Disable blocked windows and flash the active window if
a blocked one is activated (as in Qt 4).

Change-Id: I6b6d230f94a271ce2aa649e3f4e13ebd63e93da4
Reviewed-by: Bradley T. Hughes <bradley.hughes@nokia.com>
12 years agotest: Re-enabling tst_QScrollBar::task_209492() on Mac
Sergio Ahumada [Wed, 11 Apr 2012 18:08:29 +0000 (20:08 +0200)]
test: Re-enabling tst_QScrollBar::task_209492() on Mac

This test has been XPASS'ing since a long time now.

Change-Id: Ibfcd1b5078e0b8efed9ed0740a4238d24ef8ca33
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
Reviewed-by: Morten Johan Sørvig <morten.sorvig@nokia.com>
Reviewed-by: Bradley T. Hughes <bradley.hughes@nokia.com>
12 years ago__builtin_unreachable was added to GCC in version 4.5, so fix macros
Thiago Macieira [Thu, 12 Apr 2012 18:40:00 +0000 (15:40 -0300)]
__builtin_unreachable was added to GCC in version 4.5, so fix macros

Change-Id: Ida63bb46f696ae9d60331d863bf1478415a08ff2
Reviewed-by: Olivier Goffart <ogoffart@woboq.com>
12 years agoUse the new udev based framework for detecting graphics cards.
Hannu Lyytinen [Thu, 12 Apr 2012 12:15:26 +0000 (15:15 +0300)]
Use the new udev based framework for detecting graphics cards.

Get rid of hard coded device node and support any number of graphics
cards.

Change-Id: I50f07fb1e6ea321a4ae751db8fb49ab439dce51e
Reviewed-by: Andy Nichols <andy.nichols@nokia.com>
12 years agoImplement basic bits for device autodetection via udev.
Hannu Lyytinen [Thu, 12 Apr 2012 12:09:52 +0000 (15:09 +0300)]
Implement basic bits for device autodetection via udev.

The graphics cards and eventually the input devices need to be resolved
via udev. This commit adds a listener class and an abstract base class
for writing device specific handlers.

Change-Id: I62784c98bc7ad4bc1431d61cd5f13c8b48edf330
Reviewed-by: Andy Nichols <andy.nichols@nokia.com>
12 years agodevice: Introduce hooks for the directfb plugin and use them
Holger Hans Peter Freyther [Fri, 16 Mar 2012 21:50:30 +0000 (22:50 +0100)]
device: Introduce hooks for the directfb plugin and use them

The EGL integration is vendor specific, add platform hooks to the
DirectFB plugin and implement them for the Broadcom 97425. The hook
interface is internal and there are no ABI/API gurantees.

Change-Id: I33359830c51f16895e771837fccb71e03c81cf18
Reviewed-by: Girish Ramakrishnan <girish.1.ramakrishnan@nokia.com>
12 years agomoc: fix compilation of signals returning pointers.
Olivier Goffart [Wed, 11 Apr 2012 12:10:12 +0000 (14:10 +0200)]
moc: fix compilation of signals returning pointers.

That was a regression introduced in 1c5db1aff

Example:
  signals: int *someSignal();
would produce this code:
   int* _t0 = int*();
which does not compile

So have special handling for pointer to change it to '= 0'

Change-Id: Ie695e15e309d15c3cfd5c5a69ac8bf6d61ae9915
Reviewed-by: Stephen Kelly <stephen.kelly@kdab.com>
12 years agoRemove Q_CORE_EXPORT from the simple QFlag and QIncompatibleFlag
Thiago Macieira [Wed, 28 Mar 2012 19:54:52 +0000 (16:54 -0300)]
Remove Q_CORE_EXPORT from the simple QFlag and QIncompatibleFlag

Change-Id: I0302238e817fc7d3b4682c5cc4f9cb51d181a7d2
Reviewed-by: Olivier Goffart <ogoffart@woboq.com>
12 years agoMove QFlags to qflags.h
Thiago Macieira [Wed, 28 Mar 2012 19:54:15 +0000 (16:54 -0300)]
Move QFlags to qflags.h

This is a verbatim copy of the source code.

Change-Id: I1f7efc75cad1ba05dda31d8ccfd091ae9ae40fd5
Reviewed-by: Olivier Goffart <ogoffart@woboq.com>
12 years agoFix compiler warning in evdevmouse plugin.
Friedemann Kleint [Thu, 12 Apr 2012 07:01:45 +0000 (09:01 +0200)]
Fix compiler warning in evdevmouse plugin.

Change-Id: I3b203b485079ff2cc96044789b06525ab2cde448
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
12 years agoFix MinGW warning about qDebug() formats.
Friedemann Kleint [Thu, 12 Apr 2012 14:50:52 +0000 (16:50 +0200)]
Fix MinGW warning about qDebug() formats.

Change-Id: I927d17240a7cc7b88814601b0711aa46ca166ff9
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
12 years agotest: marked tst_qlocale as insignificant on Windows
Rohan McGovern [Fri, 13 Apr 2012 05:14:35 +0000 (15:14 +1000)]
test: marked tst_qlocale as insignificant on Windows

This test hangs 2-3% of the time.

Task-number: QTBUG-25284
Change-Id: I32e01696262be2de7e015b8f811d1666551426cc
Reviewed-by: Toby Tomkins <toby.tomkins@nokia.com>
12 years agoStyle: Don't put an else after a return.
Stephen Kelly [Sun, 1 Apr 2012 18:25:33 +0000 (20:25 +0200)]
Style: Don't put an else after a return.

Change-Id: I41d031d92489e5539f293c30a6257310f2a1c657
Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@nokia.com>
12 years agoRe-add the Qt 4 compatibility methods for QUrl encoded query items
Thiago Macieira [Thu, 12 Apr 2012 16:36:23 +0000 (13:36 -0300)]
Re-add the Qt 4 compatibility methods for QUrl encoded query items

I forgot to re-add those when I re-added the non-encoded (QString)
forms.

Change-Id: I9d635d40106273177df2c332f09d66415efc15a3
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
12 years agoEnsure proper handling of empty-but-present URL components
Thiago Macieira [Wed, 11 Apr 2012 20:55:18 +0000 (17:55 -0300)]
Ensure proper handling of empty-but-present URL components

The new QUrl is able to distinguish a URL component that is empty from
one that is absent. The previous one already had that capability for
the port, fragment and query, and the new one extends that to the username,
password and path. The path did not need this handling because its
delimiter from the authority it part of the path.

For example, a URL with no username is one where it's set to QString()
(null). A URL like "http://:kde@kde.org" is understood as an
empty-but-present username, for which toString(RemovePassword) will
return "http://@kde.org", keeping the empty-but-present username.

Change-Id: I2d97a7656f3f1099e3cf400b199e68e4c480d924
Reviewed-by: Shane Kearns <shane.kearns@accenture.com>
12 years agoApply Qt config option "-no-largefile" to SQLite make process
Sergey Gusarov [Thu, 12 Apr 2012 15:15:15 +0000 (19:15 +0400)]
Apply Qt config option "-no-largefile" to SQLite make process

This patch fixes compilation error if there is no
64 bit support in compiler.

Task-number: QTBUG-15395
Change-Id: Ife4afb05491d36af93bf4ad3ba8fa227710655f0
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
12 years agoDo not ignore tests/auto/corelib/io/qtextstream on Mac OS X
Bradley T. Hughes [Thu, 12 Apr 2012 13:55:20 +0000 (15:55 +0200)]
Do not ignore tests/auto/corelib/io/qtextstream on Mac OS X

This test no longer fails, so we can remove CONFIG+=insignificant_test

Task-number: QTBUG-22767
Change-Id: If3ca194fc982ad8fdc3e9a7f62fc346190ff01ea
Reviewed-by: Jason McDonald <jason.mcdonald@nokia.com>
12 years agoDo not ignore tests/auto/corelib/io/qiodevice on Mac OS X
Bradley T. Hughes [Thu, 12 Apr 2012 13:50:26 +0000 (15:50 +0200)]
Do not ignore tests/auto/corelib/io/qiodevice on Mac OS X

This test no longer fails, so we can remove CONFIG+=insignificant_test

Task-number: QTBUG-22766
Change-Id: I379873d5c483157e414201e5f8a13c3f4407f9fd
Reviewed-by: Jason McDonald <jason.mcdonald@nokia.com>
12 years agoDo not ignore tests/auto/corelib/io/qfile on Mac OS X
Bradley T. Hughes [Thu, 12 Apr 2012 13:34:24 +0000 (15:34 +0200)]
Do not ignore tests/auto/corelib/io/qfile on Mac OS X

This does not fail anymore, remove CONFIG+=insignificant_test

Change-Id: I4f98cfad563adfa460910976317c91e852db6872
Reviewed-by: Jason McDonald <jason.mcdonald@nokia.com>
12 years agofixed compiling of QDnsRunner for wince and windows desktop
Bjoern Breitmeyer [Thu, 12 Apr 2012 08:35:40 +0000 (10:35 +0200)]
fixed compiling of QDnsRunner for wince and windows desktop

ce only has the utf16 variant desktop has all variants
of the DnsQuery call. Unified it to the utf16 variant.

Change-Id: Ic126c3f53da71c85a41a5c24c85970335700bcf0
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
Reviewed-by: Andreas Holzammer <andreas.holzammer@kdab.com>
Reviewed-by: Shane Kearns <shane.kearns@accenture.com>
12 years agoFix autotest failures in QAbstractNetworkCache
Shane Kearns [Thu, 12 Apr 2012 16:28:37 +0000 (17:28 +0100)]
Fix autotest failures in QAbstractNetworkCache

The cache expiration calculation was previously removed to avoid
calculating it every time an object is fetched from the cache.
This is because the expiration date is calculated from max-age or
expires headers when the object is added to the cache.

However this broke the case where the server only provides a
last-modified header. In this case, the expiration date needs
to be checked at fetch time in order to add the warning if the
object is >24h old.

Change-Id: Iad381da0f91c27ac603abbaa94f268700ad2297f
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
12 years agoAdd OS version detection for windows 8
Shane Kearns [Wed, 11 Apr 2012 14:16:09 +0000 (15:16 +0100)]
Add OS version detection for windows 8

Based on consumer preview, the internal version is 6.2

Change-Id: I9d6ff6c7614f46a20d489e8a8f4aefeb60c547f6
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
12 years agoFix possible crash issue when testing the state of a QAccessibleMenuItem
Yan Shapochnik [Wed, 11 Apr 2012 19:02:49 +0000 (15:02 -0400)]
Fix possible crash issue when testing the state of a QAccessibleMenuItem

The owner widget of a QAccessibleMenuItem may be NULL. Checking for a valid pointer before dereferncing.

Port of Qt 4 patch.

Change-Id: Ic3149ccc5d6ae0ebc83dae58163ae2f60397fd28
(cherry picked from commit 3f526366af14f6c640dd52cd089b00776ab06731)
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@nokia.com>
12 years agoRemove QPaintBufferSignalProxy and QPaintBufferResource.
Robin Burchell [Thu, 12 Apr 2012 11:37:43 +0000 (13:37 +0200)]
Remove QPaintBufferSignalProxy and QPaintBufferResource.

Nothing seems to use these...

Change-Id: I58b3e5f8536e43b3076da0a86d9093a6e11b947a
Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
12 years agoRemove hasDirtyFromPreviousSync from backingstore.
Girish Ramakrishnan [Thu, 12 Apr 2012 05:42:41 +0000 (22:42 -0700)]
Remove hasDirtyFromPreviousSync from backingstore.

It's always false (used to be some qws specific variable).

Change-Id: I3dc185dba4c778797f180410ce8d293336ecfd9c
Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
12 years agoMove QSurface destructor to qsurface.cpp
Girish Ramakrishnan [Wed, 11 Apr 2012 23:59:39 +0000 (16:59 -0700)]
Move QSurface destructor to qsurface.cpp

fa0407bdb50262f8748e955cf698181cc6906542 moved all QSurface code to
a separate except the destructor.

Change-Id: I2bf426a0b70cbffafae7aca8dd5550192f762aeb
Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
12 years agoremove references to qws from backingstore
Girish Ramakrishnan [Thu, 12 Apr 2012 05:38:15 +0000 (22:38 -0700)]
remove references to qws from backingstore

The backingstore code is already hard to read as-is. Let's
simplify things by removing qws code.

Change-Id: Ibefd3ea17d29970d1f7348461959fdc5b01c1f42
Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
12 years agoRemove redundant platformNativeInterface()
Girish Ramakrishnan [Thu, 12 Apr 2012 02:31:39 +0000 (19:31 -0700)]
Remove redundant platformNativeInterface()

platformNativeInterface() is already defined in QGuiApplication.

Change-Id: Ice720fb6f7e4b01c4627219d66a5a3c8980a79a5
Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
12 years agoRemove QWidget::setWindowHandle
Girish Ramakrishnan [Thu, 12 Apr 2012 02:42:54 +0000 (19:42 -0700)]
Remove QWidget::setWindowHandle

It's unused. The window (QWidgetWindow) is created and managed implicitly
by QWidget.

Change-Id: I28ee3f120a99c877f318e1abd7d73c9f3e542d03
Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>