Stephen Toub [Tue, 31 Jan 2017 19:50:44 +0000 (14:50 -0500)]
Make SpinLock.TryEnter(ref bool) fail faster
One uses SpinLock.TryEnter(ref bool) when they want to do a quick test to either acquire the lock or know it's held by someone else. We can make the latter path much faster so that it fails faster.
Commit migrated from https://github.com/dotnet/coreclr/commit/
7ee26ae908da9b1f48c37186b07b3dc860f4f1ba
Aditya Mandaleeka [Tue, 31 Jan 2017 18:26:49 +0000 (10:26 -0800)]
Merge pull request dotnet/coreclr#9207 from adityamandaleeka/ci_dump_improvements
Switch to a newer version of the dump management service we use
Commit migrated from https://github.com/dotnet/coreclr/commit/
b2b3e07625fa3308110d88cd9f013f788e02e5f7
Gaurav Khanna [Tue, 31 Jan 2017 16:55:02 +0000 (08:55 -0800)]
Merge pull request dotnet/coreclr#9206 from dotnet-bot/master-UpdateDependencies
Update CoreFx to beta-24931-02 (master)
Commit migrated from https://github.com/dotnet/coreclr/commit/
6f1d51049a0c90b6402c575c2b8d05859616b6bf
Bruce Forstall [Tue, 31 Jan 2017 16:51:09 +0000 (08:51 -0800)]
Merge pull request dotnet/coreclr#9127 from BruceForstall/FixSimdFieldMorphing
Fix morphing of GT_FIELD of SIMD in IND context
Commit migrated from https://github.com/dotnet/coreclr/commit/
52f254c97ccbd7fa39e9e3059e4f729300608c0d
dotnet-bot [Tue, 31 Jan 2017 14:58:57 +0000 (14:58 +0000)]
Update CoreFx to beta-24931-02
Commit migrated from https://github.com/dotnet/coreclr/commit/
904d6948eaf80dabbd5ea7478d6c7d8d529b02de
Jonghyun Park [Tue, 31 Jan 2017 09:43:27 +0000 (18:43 +0900)]
Enable EECodeManager::GetGSCookieAddr when CROSSGEN_COMPILE is not defined (dotnet/coreclr#9209)
Commit migrated from https://github.com/dotnet/coreclr/commit/
93cb39e3c1bbd4407261926a7365949f288ebc37
Bruce Forstall [Tue, 24 Jan 2017 01:40:57 +0000 (17:40 -0800)]
Fix morphing of GT_FIELD of SIMD in IND context
Commit migrated from https://github.com/dotnet/coreclr/commit/
10220038dca2f64c75d8cf9d5ca05afa3f25d3c5
Bruce Forstall [Tue, 31 Jan 2017 07:19:28 +0000 (23:19 -0800)]
Merge pull request dotnet/coreclr#9183 from BruceForstall/FixBlockOpMorphing
Fix morphing of block op assignments
Commit migrated from https://github.com/dotnet/coreclr/commit/
b2d57bb99fce38ef8b150d5eac5b0a56b6e5f6b2
Aditya Mandaleeka [Thu, 26 Jan 2017 23:25:10 +0000 (15:25 -0800)]
Switch to a newer version of the dump management service we use.
Commit migrated from https://github.com/dotnet/coreclr/commit/
a6b8ea0c1e329ee73303ec0dbecf22a97bdb0755
Bruce Forstall [Mon, 30 Jan 2017 23:46:39 +0000 (15:46 -0800)]
Merge pull request dotnet/coreclr#9199 from BruceForstall/FixBadIfCondition
Fix misspelling of FEATURE_MULTIREG_ARGS
Commit migrated from https://github.com/dotnet/coreclr/commit/
91d5a8bc2b73fd03b6107d31e8bd1798f65c740b
Frederik Carlier [Mon, 30 Jan 2017 23:21:49 +0000 (00:21 +0100)]
Support cross-building CoreCLR for arm64 Android (dotnet/coreclr#9173)
* Support cross-building CoreCLR for arm64 Android
* Link gcc_s before libunwind
Commit migrated from https://github.com/dotnet/coreclr/commit/
55268bf4b98b6e1f202179d9a5ebc876dd154230
Koundinya Veluri [Mon, 30 Jan 2017 22:47:29 +0000 (14:47 -0800)]
Fix Thread constructor with stack size argument (dotnet/coreclr#9186)
Fix Thread constructor with stack size argument
Functional fix for dotnet/coreclr#9158 and dotnet/coreclr#9167
Commit migrated from https://github.com/dotnet/coreclr/commit/
b390ea94d52a9089e24973a12a6413bc8eb9bc3d
William Godbe [Mon, 30 Jan 2017 22:30:43 +0000 (14:30 -0800)]
Merge pull request dotnet/coreclr#9200 from wtgodbe/FixPublish
Change '.' to '-' in publishing test native binaries
Commit migrated from https://github.com/dotnet/coreclr/commit/
b9495704513bf345903e146a5d2a11517b932d15
wtgodbe [Mon, 30 Jan 2017 21:24:16 +0000 (13:24 -0800)]
Change '.' to '-' in publishing test native binaries
Commit migrated from https://github.com/dotnet/coreclr/commit/
6344b1859ffebb8d0bea095573a32ce022b9d929
Bruce Forstall [Mon, 30 Jan 2017 20:26:25 +0000 (12:26 -0800)]
Fix misspelling of FEATURE_MULTIREG_ARGS
Commit migrated from https://github.com/dotnet/coreclr/commit/
7b98a4fbbaed169bdfa146c3997b42c9ea2859e9
Dan Moseley [Mon, 30 Jan 2017 19:47:31 +0000 (12:47 -0700)]
Merge pull request dotnet/coreclr#9188 from justinvp/fixed_addressof
Avoid unnecessary branches when fixing non-null/empty arrays
Commit migrated from https://github.com/dotnet/coreclr/commit/
6723e913ac6dbe079972563fdbdf92def9be4d6a
Dan Moseley [Mon, 30 Jan 2017 19:47:04 +0000 (12:47 -0700)]
Merge pull request dotnet/coreclr#9197 from dotnet-bot/master-UpdateDependencies
Update CoreClr to beta-24930-03 (master)
Commit migrated from https://github.com/dotnet/coreclr/commit/
55eec6ca3b6d6796e2a98403b6774c738bc4b721
William Godbe [Mon, 30 Jan 2017 18:46:55 +0000 (10:46 -0800)]
Merge pull request dotnet/coreclr#9198 from wtgodbe/FixReleaseHelix
Set BuildType in HelixPublish.proj
Commit migrated from https://github.com/dotnet/coreclr/commit/
9557dde1a911a1d53eeab6f661bfcce951945f90
wtgodbe [Mon, 30 Jan 2017 18:30:48 +0000 (10:30 -0800)]
Set BuildType in HelixPublish.proj
Commit migrated from https://github.com/dotnet/coreclr/commit/
55f87777535f4a70841488ba361dc47ab2360ab6
William Godbe [Mon, 30 Jan 2017 18:27:20 +0000 (10:27 -0800)]
Merge pull request dotnet/coreclr#9156 from dotnet/revert-9155-revert-9152-SpeedUpSync
Speed up test native binary syncing in pipeline
Commit migrated from https://github.com/dotnet/coreclr/commit/
40f9d18c485e6b93185f9e3012f072c26566f8ae
Carol Eidt [Mon, 30 Jan 2017 18:26:15 +0000 (10:26 -0800)]
Merge pull request dotnet/coreclr#9170 from CarolEidt/Fix9159
Fix GT_LCL_FLD case in gtGetStructHandleIfPresent
Commit migrated from https://github.com/dotnet/coreclr/commit/
90db75f7e0ed1486d8fff05d30ed6f547f86cf9e
dotnet-bot [Mon, 30 Jan 2017 17:44:04 +0000 (17:44 +0000)]
Update CoreClr to beta-24930-03
Commit migrated from https://github.com/dotnet/coreclr/commit/
9cf5dc34acf6663cb49a7ab8645519d6d6c93c8f
Dan Moseley [Mon, 30 Jan 2017 17:41:30 +0000 (10:41 -0700)]
Merge pull request dotnet/coreclr#9117 from jamesqo/copy.names
Fix parameter names for Array.Copy
Commit migrated from https://github.com/dotnet/coreclr/commit/
cd207519445bf6ba66bcf21af653b43f68bd3976
Dan Moseley [Mon, 30 Jan 2017 17:38:28 +0000 (10:38 -0700)]
Merge pull request dotnet/coreclr#8438 from JonHanna/fix_1764
Support filter and fault blocks in DynamicILGenerator
Commit migrated from https://github.com/dotnet/coreclr/commit/
dafad808aba25d940a64568d24d83ee04beebaf2
Dan Moseley [Mon, 30 Jan 2017 17:37:48 +0000 (10:37 -0700)]
Merge pull request dotnet/coreclr#8564 from lucenticus/x86-gdbjit
[x86/Linux] Initial support of GDB JIT interface
Commit migrated from https://github.com/dotnet/coreclr/commit/
5e61ff96c21b5caca03084cb64379a650832e7d6
Dan Moseley [Mon, 30 Jan 2017 17:37:11 +0000 (10:37 -0700)]
Merge pull request dotnet/coreclr#9140 from dotnet-bot/master-UpdateDependencies
Update CoreClr, CoreFx to beta-24930-02, beta-24930-01, respectively (master)
Commit migrated from https://github.com/dotnet/coreclr/commit/
c32c99120863db56b825cd6065f2e24873542d71
Frederik Carlier [Mon, 30 Jan 2017 16:52:12 +0000 (17:52 +0100)]
Support building lldbplugin on ARM64 (dotnet/coreclr#9195)
Commit migrated from https://github.com/dotnet/coreclr/commit/
8fc684957641c2984ec66d8e92eb3d326f986dba
Stephen Toub [Mon, 30 Jan 2017 16:37:27 +0000 (11:37 -0500)]
Remove allocations from Environment.GetResourceString (dotnet/coreclr#9194)
* Remove delegate allocations from ResourceHelper.GetResourceString
* Remove state object allocation from GetResourceString
Now that we're no longer using ExecuteCodeWithGuaranteedBackout, we don't need the try/catch/finally functionality separated out into separate methods, and thus we don't need to allocate an object to pass into them.
Commit migrated from https://github.com/dotnet/coreclr/commit/
d1699dce65111fe44a85b35637b1f05a5b497f7e
Jan Kotas [Mon, 30 Jan 2017 16:36:29 +0000 (08:36 -0800)]
Delete unused encodings from CoreLib (dotnet/coreclr#9196)
Commit migrated from https://github.com/dotnet/coreclr/commit/
7eca552c787ae8638b11130882eeaacc9c1210b9
Andy Ayers [Mon, 30 Jan 2017 16:19:25 +0000 (08:19 -0800)]
JIT: fixup finally target flag after finally opts run (dotnet/coreclr#9171)
The finally target flag can't be incrementally maintaned during finally
opts, so flag if any of these opts run and then run a post-opts fixup pass
to properly determine the flag value.
Only impacts arm targets.
Closes dotnet/coreclr#9015.
Commit migrated from https://github.com/dotnet/coreclr/commit/
31ad45c2fd059da82855226313606d9824bae25e
dotnet-bot [Mon, 30 Jan 2017 15:18:54 +0000 (15:18 +0000)]
Update CoreClr, CoreFx to beta-24930-02, beta-24930-01, respectively
Commit migrated from https://github.com/dotnet/coreclr/commit/
8e457e0c91f6c97bf7effc5ab619f1469f76d9a2
Frederik Carlier [Mon, 30 Jan 2017 10:53:45 +0000 (11:53 +0100)]
Add support for lldb-3.9 (dotnet/coreclr#9190)
Commit migrated from https://github.com/dotnet/coreclr/commit/
4c06f08661d351a3a960bfbabc9b426a3c4c0db1
Evgeny Pavlov [Mon, 30 Jan 2017 10:12:17 +0000 (13:12 +0300)]
[GDB-JIT][Linux] Add support of base classes introspection (dotnet/coreclr#9083)
* [GDB-JIT] Initial support of inherited fields displaying for classes
* [GDB-JIT] Fix link to already existed parent class
* [GDB-JIT] Fix incorrect processing of links to parent class with RefTypeInfo
* [GDB-JIT] Ignore inheritance from System.ValueType
* [GDB-JIT] Insert additional check whether we already dump parent class
Commit migrated from https://github.com/dotnet/coreclr/commit/
3ff336da45a4f755bf94a60a1774f615b801f45f
Jan Kotas [Sun, 29 Jan 2017 15:22:30 +0000 (07:22 -0800)]
Merge pull request dotnet/coreclr#9181 from dotnet/revertevent
Revert recent changes of #if blocks in Eventing code
Commit migrated from https://github.com/dotnet/coreclr/commit/
dbfae571c2bb1f970e7430b07d0ab9550470f850
Jan Kotas [Sun, 29 Jan 2017 03:54:57 +0000 (19:54 -0800)]
Remove invalid asserts on unsupported underlying enum type (dotnet/coreclr#9192)
The underlying enum type can be floating point type or native integer for historic reasons.
However, not all framework methods support these special enum types. They should throw exception
for them instead of asserting.
Fix issue dotnet/coreclr#7670
Commit migrated from https://github.com/dotnet/coreclr/commit/
fbe52109370516c19e47451040752305d5dc0fe0
Sivarv [Sat, 28 Jan 2017 17:54:45 +0000 (09:54 -0800)]
Merge pull request dotnet/coreclr#9184 from AndyAyersMS/RegexDna
Add BenchmarkGames regexdna test
Commit migrated from https://github.com/dotnet/coreclr/commit/
ab709855f21ca49a63b148d5c4e0be5e3b8b5e28
Justin Van Patten [Sat, 28 Jan 2017 17:31:32 +0000 (09:31 -0800)]
Avoid unnecessary branches when fixing non-null/empty arrays
Commit migrated from https://github.com/dotnet/coreclr/commit/
79050e273669e986e1fa9acc56707bd697f0ab09
Karel Zikmund [Sat, 28 Jan 2017 17:06:43 +0000 (09:06 -0800)]
Update glossary.md
Commit migrated from https://github.com/dotnet/coreclr/commit/
9bcc3cefcd46769a0596e6192e0d61eecfd393e4
Andy Ayers [Sat, 28 Jan 2017 00:45:38 +0000 (16:45 -0800)]
Add BenchmarkGames regexdna test
Based on the "version 6" test base. As with revcomp, keeping the input
files as unix line ending, and relatively small.
Commit migrated from https://github.com/dotnet/coreclr/commit/
47fa373a9bdb460bdd90b51c2bbd40f9bc48937f
Bruce Forstall [Sat, 28 Jan 2017 01:05:05 +0000 (17:05 -0800)]
Fix morphing of block op assignments
During morphing, block op assignments had their children set to
the "IND" morph context. This is incorrect. Previously, block
ops would "incorporate" the "IND-ness" of their children. However,
now, the operands will be a IND/BLK/OBJ node explicitly. Deleting
this incorrect code enables other changes, not yet merged, to work.
This causes no amd64 SPMI desktop asm diffs.
Commit migrated from https://github.com/dotnet/coreclr/commit/
87ebd5f4fca70a50d51e5503d13b4e5a05d8d712
Dan Moseley [Sat, 28 Jan 2017 00:46:56 +0000 (17:46 -0700)]
Merge pull request dotnet/coreclr#9164 from justinvp/string_split
Remove unnecessary private String.SplitInternal method
Commit migrated from https://github.com/dotnet/coreclr/commit/
cff36bfdfaa459cd3c0f79b75e9a4f834bb6e2a8
Karel Zikmund [Fri, 27 Jan 2017 23:58:18 +0000 (15:58 -0800)]
Update glossary.md
Commit migrated from https://github.com/dotnet/coreclr/commit/
7551e45532af1696dab23a5c5ac021e724c823fe
danmosemsft [Fri, 27 Jan 2017 23:20:20 +0000 (15:20 -0800)]
Revert `Remove #if false blocks` just for Eventing
Commit migrated from https://github.com/dotnet/coreclr/commit/
31d6e5ec55f06ca7c6c84dc0ea0f133aec105c1a
danmosemsft [Fri, 27 Jan 2017 23:19:04 +0000 (15:19 -0800)]
Revert `Remove FEATURE_MANAGED_ETW_CHANNELS`
Commit migrated from https://github.com/dotnet/coreclr/commit/
ebad4067f3ae31c667dc807c64a1c3db419a54cb
danmosemsft [Fri, 27 Jan 2017 23:17:25 +0000 (15:17 -0800)]
Revert `Remove disabled FEATURE_ADVANCED_MANAGED_ETW_CHANNELS`
Commit migrated from https://github.com/dotnet/coreclr/commit/
8540bb123d6bffbdeef8c935b73085f3e42e5bf0
Bruce Forstall [Fri, 27 Jan 2017 22:42:26 +0000 (14:42 -0800)]
Merge pull request dotnet/coreclr#9163 from BruceForstall/FixAddrModeBuilding
Stop address mode building in TreeNodeInfoInit pass
Commit migrated from https://github.com/dotnet/coreclr/commit/
44d4d3be49948136ea9453829b3e11e9cfdf0e45
Carol Eidt [Fri, 27 Jan 2017 18:09:58 +0000 (10:09 -0800)]
Fix GT_LCL_FLD case in gtGetStructHandleIfPresent
This method was incorrectly returning the parent struct handle instead of the handle for the field. This is showing up in remorphing of a SIMD field that was assigned in a field-by-field assignment.
Fix dotnet/coreclr#9159
Commit migrated from https://github.com/dotnet/coreclr/commit/
9f09b8e05871a407dbd2233ae6a8e123ea52fd72
Andy Ayers [Fri, 27 Jan 2017 17:36:09 +0000 (09:36 -0800)]
JIT: Remove empty try regions (dotnet/coreclr#8949)
In runtimes that do not support thread abort, a try-finally with
an empty try can be optimized to simply the content of the finally.
See documentation update for more details.
Closes dotnet/coreclr#8924.
Commit migrated from https://github.com/dotnet/coreclr/commit/
119b04c1d3b7a9842eaaacb974e991e5d454f2b4
Jonghyun Park [Fri, 27 Jan 2017 11:58:40 +0000 (20:58 +0900)]
Enable IsInPrologOrEpilog only if GC Info Decoder is not used (dotnet/coreclr#9136)
* Enable IsInPrologOrEpilog only if GC Info Decoder is not used
Commit migrated from https://github.com/dotnet/coreclr/commit/
13ff59c43fcf7ddede25579a8651d7ba50ecaa31
Russ Keldorph [Fri, 27 Jan 2017 10:59:28 +0000 (02:59 -0800)]
Merge pull request dotnet/coreclr#9130 from RussKeldorph/corefx
Support new corefx workflow
Commit migrated from https://github.com/dotnet/coreclr/commit/
1ba64840b54c98781d9536d4ac6052c2c1ba5242
Frederik Carlier [Fri, 27 Jan 2017 09:38:32 +0000 (10:38 +0100)]
Use a constant to define the location of '/tmp' (dotnet/coreclr#9150)
* The temp folder is in /data/local/tmp on Android, not /tmp
Commit migrated from https://github.com/dotnet/coreclr/commit/
c01abca4e3d47f53ed973848d822877defaa99ce
Frederik Carlier [Fri, 27 Jan 2017 09:37:49 +0000 (10:37 +0100)]
Support platforms where pthread is part of libc (dotnet/coreclr#9154)
* Make threading code compatible with Android
Commit migrated from https://github.com/dotnet/coreclr/commit/
6ee7c2074cb6e9be0425af981c08593fd505f723
Ahson Ahmed Khan [Fri, 27 Jan 2017 04:33:48 +0000 (20:33 -0800)]
Adding trivial implementations of Span Fill and Clear (dotnet/coreclr#9162)
Commit migrated from https://github.com/dotnet/coreclr/commit/
b462e748844f61726c51b0e1792c004cf7c7647f
Justin Van Patten [Fri, 27 Jan 2017 03:42:29 +0000 (19:42 -0800)]
Remove unnecessary private String.SplitInternal method
Avoid the unnecessary intermediate method call.
Commit migrated from https://github.com/dotnet/coreclr/commit/
a8b0f75f8f6849cef6a1193f220cad4d09e4f4c1
Sivarv [Fri, 27 Jan 2017 03:23:26 +0000 (19:23 -0800)]
Merge pull request dotnet/coreclr#9054 from kouvel/SpanGcReporting
Fix GC info for `ByReference<T>`
Commit migrated from https://github.com/dotnet/coreclr/commit/
b8f8a13b900a4b3a175e7597cd7119db3846d43a
Bruce Forstall [Fri, 27 Jan 2017 02:44:31 +0000 (18:44 -0800)]
Stop address mode building in TreeNodeInfoInit pass
During Lower, TryCreateAddrMode() will try to find address
modes and convert them to GT_LEA by calling genCreateAddrMode().
Later, the TreeNodeInfoInit() pass walks the IR annotating
nodes with register requirements. It was also calling
genCreateAddrMode() and then clearing various previously
created register requirements, but not actually changing the
node to a GT_LEA. In some cases (in new code I have not checked
in yet), this was leading to code that codegen couldn't handle.
It turns out this second call to genCreateAddrMode() is
unnecessary (and undesireable), so I've removed it. This causes
no asm diffs on amd64 or x86 (run on desktop: superpmi
and ngen, respectively).
Commit migrated from https://github.com/dotnet/coreclr/commit/
b358e5c43373730910b1c45e6777b3ed207955da
Carol Eidt [Fri, 27 Jan 2017 01:54:31 +0000 (17:54 -0800)]
Merge pull request dotnet/coreclr#9123 from CarolEidt/FixCoreFx15309
Fix SIMD field issues
Commit migrated from https://github.com/dotnet/coreclr/commit/
7478520c40f9ccea0ead7bd9f3853387679a6466
Frederik Carlier [Fri, 27 Jan 2017 01:11:40 +0000 (02:11 +0100)]
PAL Tests: Centralize common code (dotnet/coreclr#9151)
Create a single COMMON_TEST_LIBRARIES variable which contains all libraries
with which the tests link.
Commit migrated from https://github.com/dotnet/coreclr/commit/
a928a37a1503871b5da5c80f74fe54b9f937ddc3
Brian Sullivan [Fri, 27 Jan 2017 01:08:58 +0000 (17:08 -0800)]
Merge pull request dotnet/coreclr#9157 from dotnet-bot/from-tfs
Merge changes from TFS
Commit migrated from https://github.com/dotnet/coreclr/commit/
7ad71a1a0a7704286c50652f103ac100e997c490
William Godbe [Fri, 27 Jan 2017 00:55:06 +0000 (16:55 -0800)]
Revert "Revert "Speed up test native binary syncing in pipeline""
Commit migrated from https://github.com/dotnet/coreclr/commit/
fbe0c29ed30496eec55910c6bb6c9b1d305ee920
William Godbe [Fri, 27 Jan 2017 00:55:03 +0000 (16:55 -0800)]
Merge pull request dotnet/coreclr#9155 from dotnet/revert-9152-SpeedUpSync
Revert "Speed up test native binary syncing in pipeline"
Commit migrated from https://github.com/dotnet/coreclr/commit/
427b02caf1efdfb7c4ed1f8070851de564bde839
William Godbe [Fri, 27 Jan 2017 00:54:39 +0000 (16:54 -0800)]
Revert "Speed up test native binary syncing in pipeline"
Commit migrated from https://github.com/dotnet/coreclr/commit/
fdcda4dd6da13d903228a66625fac4d6e2a1afe0
William Godbe [Fri, 27 Jan 2017 00:54:10 +0000 (16:54 -0800)]
Merge pull request dotnet/coreclr#9152 from wtgodbe/SpeedUpSync
Speed up test native binary syncing in pipeline
Commit migrated from https://github.com/dotnet/coreclr/commit/
0ff5302eb0fab432c3af5b7277f0f86f2705f7b3
Aditya Mandaleeka [Fri, 27 Jan 2017 00:53:54 +0000 (16:53 -0800)]
Merge pull request dotnet/coreclr#9153 from adityamandaleeka/jitdisasm_fix
Fix another JIT-disasm check
Commit migrated from https://github.com/dotnet/coreclr/commit/
ff68f30c877740c18bfe8f942a23b8cfcf8bd41f
Pat Gavlin [Thu, 26 Jan 2017 23:22:02 +0000 (15:22 -0800)]
Merge pull request dotnet/coreclr#9141 from pgavlin/RemoveDeadCode
Remove dead code in the JIT.
Commit migrated from https://github.com/dotnet/coreclr/commit/
7dda23fa137844c43ab2912fbbbc25cfecb471f4
Koundinya Veluri [Thu, 26 Jan 2017 22:21:03 +0000 (14:21 -0800)]
Don't require write barrier for assignment to ByRef
The legacy code gen was hitting an assert when trying to use a write barrier for ByRef to ByRef assignment. RyuJIT is also generating an unnecessary write barrier but the assert is not there. As ByRefs are never in GC locations, don't require a write barrier.
Commit migrated from https://github.com/dotnet/coreclr/commit/
4727df385c68b5b5f83d694167b4d0b902f5bbb9
Aditya Mandaleeka [Thu, 26 Jan 2017 22:53:54 +0000 (14:53 -0800)]
Fix another JIT-disasm check.
Commit migrated from https://github.com/dotnet/coreclr/commit/
dc7c98f4a09d0d5e9fe476978f01724a9446ead1
Evgeny Pavlov [Thu, 26 Jan 2017 22:52:31 +0000 (01:52 +0300)]
[GDB-JIT][Linux] Fix incorrect DWARF offset for primitive types with typedef node (char, byte and sbyte) (dotnet/coreclr#9106)
Commit migrated from https://github.com/dotnet/coreclr/commit/
04549885287571dfb9ca59c986ad1211b27bcf39
Frederik Carlier [Thu, 26 Jan 2017 22:35:37 +0000 (23:35 +0100)]
Clean up PAL functions (dotnet/coreclr#9149)
Clean up PAL functions to enable cross-compiling for Android
* Rename wcsnlen to PAL_wcsnlen, avoids a name collision on Android
* Remove unuwed _getw and _putw functions
Commit migrated from https://github.com/dotnet/coreclr/commit/
69b5d5c46e007cbb580c411b60dc501362af0486
wtgodbe [Thu, 26 Jan 2017 22:01:18 +0000 (14:01 -0800)]
Speed up test native binary syncing in pipeline
Commit migrated from https://github.com/dotnet/coreclr/commit/
fede4b52f4f2f4b767045a0c9c5d689d877f24b3
Andy Ayers [Thu, 26 Jan 2017 21:18:55 +0000 (13:18 -0800)]
Merge pull request dotnet/coreclr#9142 from AndyAyersMS/FixAsserts
JIT: fix some bad asserts
Commit migrated from https://github.com/dotnet/coreclr/commit/
10b85acbf6f635b9b2094b28758e60e86ab9e5d1
Russ Keldorph [Thu, 26 Jan 2017 21:01:52 +0000 (13:01 -0800)]
Merge pull request dotnet/coreclr#9129 from RussKeldorph/defineenum
Disable assertions in ModuleBuilder.DefineEnum
Commit migrated from https://github.com/dotnet/coreclr/commit/
347a36da580d1f6889d20f2b54d014e74d900cba
Jan Kotas [Thu, 26 Jan 2017 20:41:45 +0000 (12:41 -0800)]
Fix encoding of native signatures in the presence of Enum.GetHashCode optimization (dotnet/coreclr#9138)
Fixes dotnet/coreclr#9118
Commit migrated from https://github.com/dotnet/coreclr/commit/
0bc4bffb923a792ac15b070610fe40a4e4629146
dotnet-bot [Thu, 26 Jan 2017 18:51:17 +0000 (10:51 -0800)]
Fix CodeGenMirror build break due to
347243f80d62d5aaa5359ef8c8d. This includes the new file unwindx86.cpp to be compiled.
[tfs-changeset: 1645771]
Commit migrated from https://github.com/dotnet/coreclr/commit/
6d0f1745a0d298c675a7137fdda102c6d93d906f
Andy Ayers [Thu, 26 Jan 2017 18:48:35 +0000 (10:48 -0800)]
JIT: fix some bad asserts
Fix a few asserts that use = instead of ==.
Commit migrated from https://github.com/dotnet/coreclr/commit/
d0322cdd07f8090239254f9eafb3ba52ff87337e
Pat Gavlin [Thu, 26 Jan 2017 18:35:03 +0000 (10:35 -0800)]
Remove dead code in the JIT.
All code under `LONG_ASG_OPS` and `FANCY_ARRAY_OPT` is statically dead
(these symbols are never defined as anything besides 0). This change
removes this cruft.
Commit migrated from https://github.com/dotnet/coreclr/commit/
6c1998c03e4b888b8f000bdd9069964c76507048
Bruce Forstall [Thu, 26 Jan 2017 18:32:20 +0000 (10:32 -0800)]
Merge pull request dotnet/coreclr#9132 from BruceForstall/FixBuildTest
Fix build-test.cmd
Commit migrated from https://github.com/dotnet/coreclr/commit/
63b07cc9c659642d6fb00fecf5a7b2683c82f4b1
Bruce Forstall [Thu, 26 Jan 2017 18:16:32 +0000 (10:16 -0800)]
Merge pull request dotnet/coreclr#9125 from BruceForstall/ImproveAddrModeJitDump
Improve address mode detection JitDumps
Commit migrated from https://github.com/dotnet/coreclr/commit/
8724be8c109dd2db2f4cebd4335c8cb92bbcb17d
Bruce Forstall [Thu, 26 Jan 2017 18:16:08 +0000 (10:16 -0800)]
Merge pull request dotnet/coreclr#9126 from BruceForstall/CleanUnusedTailcallNodes
Clean up unused tailcall via helper nodes
Commit migrated from https://github.com/dotnet/coreclr/commit/
206522569d11c753c302142b3ee74f3336d45f86
Bruce Forstall [Thu, 26 Jan 2017 18:14:55 +0000 (10:14 -0800)]
Merge pull request dotnet/coreclr#9133 from BruceForstall/ImproveSimdTests
Improve SIMD tests
Commit migrated from https://github.com/dotnet/coreclr/commit/
ad3fc59cc25726f130b7afee75c91e6ab5e23e71
Gaurav Khanna [Thu, 26 Jan 2017 16:32:50 +0000 (08:32 -0800)]
Merge pull request dotnet/coreclr#9120 from dotnet-bot/master-UpdateDependencies
Update CoreClr, CoreFx to beta-24925-08, beta-24926-02, respectively (master)
Commit migrated from https://github.com/dotnet/coreclr/commit/
a126c83cbd09a9f2e060a6f0b02f0a671708f42b
dotnet-bot [Thu, 26 Jan 2017 15:15:11 +0000 (15:15 +0000)]
Update CoreClr, CoreFx to beta-24925-08, beta-24926-02, respectively
Commit migrated from https://github.com/dotnet/coreclr/commit/
2422572d6a4bc33d8eb3c90a4699c99d58f76ce8
Jonghyun Park [Thu, 26 Jan 2017 14:13:23 +0000 (23:13 +0900)]
Extract GetStackParameterSize from ESPIncrOnReturn (dotnet/coreclr#9135)
Commit migrated from https://github.com/dotnet/coreclr/commit/
6849320915a0ed7a4f9ddc9553950f21da8d6fb9
Jonghyun Park [Thu, 26 Jan 2017 14:10:59 +0000 (23:10 +0900)]
Show register name in UPDATEREG log (dotnet/coreclr#9134)
Commit migrated from https://github.com/dotnet/coreclr/commit/
d24162bd144b37b2b353797db846aab80bf13db1
Mike McLaughlin [Thu, 26 Jan 2017 14:07:00 +0000 (06:07 -0800)]
Implement PAL_ProbeMemory with write/read to pipe (issue dotnet/coreclr#4094) (dotnet/coreclr#9122)
The recommended way to validate/probe memory on Linux/xplat is to use the write/read file apis to a pipe instead
of the hacky fragile hardware exception catching based probing we have now.
This builds on previous cleanup work in the master branch that removed the PAL Read/WriteProcessMemory
functions and added/replaced them with PAL_ProbeMemory. The DbgTransportSession::CheckBufferAccess that
issue mentions was also replaced.
Commit migrated from https://github.com/dotnet/coreclr/commit/
69527c9bcdf1c6f163c0acd3e42a2e012f2b4328
Eugene Rozenfeld [Thu, 26 Jan 2017 06:08:24 +0000 (22:08 -0800)]
Merge pull request dotnet/coreclr#9114 from erozenfeld/SecurityPermissionAttribute
Remove System.Security.Permissions.SecurityPermissionAttribute from System.Private.CoreLib.
Commit migrated from https://github.com/dotnet/coreclr/commit/
4f1be9361b960ae49999d5df2e388105d974b57c
Bruce Forstall [Thu, 26 Jan 2017 05:48:36 +0000 (21:48 -0800)]
Merge pull request dotnet/coreclr#9124 from BruceForstall/FixSimdDetection
Fix non-deterministic AVX2 detection
Commit migrated from https://github.com/dotnet/coreclr/commit/
b0e0168b65813f0067648966c81befff0a439da1
Justin Van Patten [Thu, 26 Jan 2017 05:30:02 +0000 (21:30 -0800)]
Reduce number of branches and IL size of string.Trim methods (dotnet/coreclr#9115)
Commit migrated from https://github.com/dotnet/coreclr/commit/
fa3eac0956c70454d7f9768a58f4effb0482cc5b
Koundinya Veluri [Mon, 23 Jan 2017 07:14:09 +0000 (23:14 -0800)]
Fix GC info for `ByReference<T>`
When `ByRefernece<T>` is directly on the stack, not inside a `Span<T>`, ComputeGCLayout was missing to include in the GC info. This was causing many span tests to fail in GCStress=c mode.
Commit migrated from https://github.com/dotnet/coreclr/commit/
1fd11a910fc7b2d7c5355047987cc8cff73fbae9
James Ko [Thu, 26 Jan 2017 03:28:40 +0000 (22:28 -0500)]
Merge branch 'copy.names' of github.com:jamesqo/coreclr into copy.names
Commit migrated from https://github.com/dotnet/coreclr/commit/
a8a42c87d526d64b8efa047bb4a24fd2cb81de25
James Ko [Thu, 26 Jan 2017 03:28:32 +0000 (22:28 -0500)]
Fix corelib.txt message
Commit migrated from https://github.com/dotnet/coreclr/commit/
5d82a0eae7edaed8ec3db03433237d45483d7572
Bruce Forstall [Thu, 26 Jan 2017 02:53:44 +0000 (18:53 -0800)]
Improve SIMD tests
1. Since the F1/F2 tests of VectorReturn found an issue Vector2
on x86, I added variants of the same test for Vector3 and Vector4
(by basically copying F1/F2 and altering appropriately).
2. I noticed VectorMin for Vector4 wasn't checking the 'W' member,
so I fixed that.
Commit migrated from https://github.com/dotnet/coreclr/commit/
92fb13263f3be6da8f2069027e20e304be5f249c
James Ko [Thu, 26 Jan 2017 02:40:48 +0000 (21:40 -0500)]
Fix parameter names for Array.Copy
Commit migrated from https://github.com/dotnet/coreclr/commit/
64700c3f88ec547d3b41bdfc4b801c0a4491cf8a
Bruce Forstall [Thu, 26 Jan 2017 02:25:11 +0000 (18:25 -0800)]
Fix build-test.cmd
Move set of __TestWorkingDir so it is available even when
__BuildAgainstPackages is not defined.
Commit migrated from https://github.com/dotnet/coreclr/commit/
32ef113b7c1a63a7f2bbeb343ff279b3292fe570
Russ Keldorph [Thu, 19 Jan 2017 16:58:56 +0000 (08:58 -0800)]
Support new corefx workflow
Update the run-corefx-tests.py script and enable it to run CI jobs
against corefx HEAD again. Also update the instructions for running
corefx tests with a private coreclr.
Commit migrated from https://github.com/dotnet/coreclr/commit/
d32a829c127be5195b3bf666ec063f2d9134e521
Russ Keldorph [Thu, 26 Jan 2017 01:47:55 +0000 (17:47 -0800)]
Disable assertions in ModuleBuilder.DefineEnum
The assertions fire when the enum name contains embedded null characters,
and we don't want to take a breaking change to fix that.
Fixes dotnet/coreclr#7669
Commit migrated from https://github.com/dotnet/coreclr/commit/
1de6fe60fd616b4c25f64f8d1c6f17a1e45915d1
Carol Eidt [Thu, 26 Jan 2017 00:18:56 +0000 (16:18 -0800)]
Fix SIMD field issues
First, when a GT_FIELD is transformed to a GT_IND, if its GTF_FLD_NULLCHECK flag is set, it must be cleared. Having this set leads to assertions or worse in value numbering. It is not entirely clear why this is only causing issues for SIMD fields.
Second, when a SIMD assignment is re-morphed, the dest may have already been changed to a GT_IND, in which case no further morphing is required (it is already a simple assignment).
Commit migrated from https://github.com/dotnet/coreclr/commit/
86ebb7becabe39d8994ca98c6a62ff3fc56ed76d
Eugene Rozenfeld [Wed, 25 Jan 2017 19:09:57 +0000 (11:09 -0800)]
Remove System.Security.Permissions.SecurityPermissionAttribute from System.Private.CoreLib.
When compiling with /unsafe+ Roslyn emits
.permissionset reqmin
= {class 'System.Security.Permissions.SecurityPermissionAttribute, System.Private.CoreLib,
Version=4.0.0.0, Culture=neutral, PublicKeyToken=
7cec85d7bea7798e' =
{property bool 'SkipVerification' = bool(true)}}
if System.Security.Permissions.SecurityPermissionAttribute is present.
In particular, System.Private.CoreLib.dll is compiled with /unsafe+ and has the above in the manifest.
https://github.com/dotnet/coreclr/commit/dotnet/coreclr@
e516211b2d3a3ae2dbd80f2c94b129910a9e280d
made BclRewriter remove System.Security.Permissions.SecurityPermissionAttribute
from System.Private.CoreLib.dll but the above reference remained.
This change removes System.Security.Permissions.SecurityPermissionAttribute completely
to avoid confusion when tools are analyzing msil and try to resolve the manifest
of System.Private.CoreLib.dll.
Commit migrated from https://github.com/dotnet/coreclr/commit/
b6c8522d8c02d7ed3ebc0ee8200a0d7a001b1c6d
Bruce Forstall [Fri, 13 Jan 2017 07:28:51 +0000 (23:28 -0800)]
Clean up unused tailcall via helper nodes
For x86 tailcall via helper, delete the unused placeholder target
location nodes when they are replaced.
Commit migrated from https://github.com/dotnet/coreclr/commit/
88772400b7c5dab645f8e900ddc2cae754859d47
Bruce Forstall [Thu, 26 Jan 2017 00:23:55 +0000 (16:23 -0800)]
Improve address mode detection JitDumps
Commit migrated from https://github.com/dotnet/coreclr/commit/
7e2a6cbd352f4be72a41e6e70b69e7ad825d74b0