Simon McVittie [Thu, 22 Aug 2013 17:03:59 +0000 (18:03 +0100)]
Merge branch 'dbus-1.6'
Conflicts:
NEWS
Simon McVittie [Thu, 22 Aug 2013 17:03:24 +0000 (18:03 +0100)]
NEWS for 1.6
Simon McVittie [Thu, 22 Aug 2013 17:02:42 +0000 (18:02 +0100)]
NEWS
Radoslaw Pajak [Tue, 13 Aug 2013 10:17:36 +0000 (12:17 +0200)]
Next 2 org.freedesktop.DBus method, comments, cleanups
- added handling of next 2 org.freedesktop.DBus methods: GetConnectionUnixUser, GetConnectionUnixProcessID
- comments added
- some cleanups
Change-Id: Ie840bfce48b849e037a128b2a76587d3e0f80197
Ralf Habacker [Mon, 19 Aug 2013 19:29:18 +0000 (21:29 +0200)]
Fixed compiler warning on windows.
https://bugs.freedesktop.org/show_bug.cgi?id=61874
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Ralf Habacker [Mon, 12 Aug 2013 15:46:48 +0000 (17:46 +0200)]
Documentation fix.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=29666
Reviewed-by: Chengwei Yang <chengwei.yang.cn@gmail.com>
Michal [Mon, 12 Aug 2013 15:10:54 +0000 (17:10 +0200)]
Documentation expanded
Change-Id: I91b6e1de13794e5fc585b16c08c1d4a85cb4f966
Radoslaw Pajak [Tue, 13 Aug 2013 07:58:55 +0000 (09:58 +0200)]
Fix for long id continued, iprovements, comments
- fix for long id continued (in next lines)
- bloom size changed from define to actual value sent by bus
- unnecessary parameters removed from functions
- some comments added
Change-Id: I8547b7253ef1a518a950d290bb07f3a5b257c212
Michal [Mon, 12 Aug 2013 13:24:32 +0000 (15:24 +0200)]
Memfd: fix big messages receiving.
Memory buffer needs to be bigger
Change-Id: Ibb19986c267a7e80bcbfe47c74f270e7acd47ea2
Radoslaw Pajak [Mon, 12 Aug 2013 12:10:42 +0000 (14:10 +0200)]
Fixed error with id >0x7FFFFFFFFFFFFFFF and others
- fixed error with id > 0x7FFFFFFFFFFFFFFF because of wrong string to unsigned long long int conversion
- KDBUS_MSG_REPLY_DEAD reply error mapped to dbus reply error
- removed unused function parameters
- another part of currently unused authentication related code put into #ifdef DBUS_AUTHENTICATION
- some comments added
- removed unnecesery code commented out in past
Change-Id: I19012c23e4afc808ff3e2607a237303bd5552822
Ralf Habacker [Fri, 9 Aug 2013 14:14:35 +0000 (16:14 +0200)]
Fixed remaining issues.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=66060
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Ralf Habacker [Thu, 8 Aug 2013 21:23:11 +0000 (23:23 +0200)]
Add debug messages to load_ex_ip_helper_procedures().
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=66060
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Ralf Habacker [Thu, 8 Aug 2013 20:53:40 +0000 (22:53 +0200)]
Refactored get_pid_from_extended_tcp_table() and get_pid_from_tcp_ex_table() to be more equal.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=66060
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Ralf Habacker [Thu, 8 Aug 2013 20:42:35 +0000 (22:42 +0200)]
Fix for broken wine AllocateAndGetTcpExTableFromStack() implementation.
On wine (tested with 1.5.6) the mentioned function could not be located in
iphlpapi.dll using LoadLibrary()/GetProcAddress(), which is the prefered
method to get a tcp peer pid on WinXP <= SP2.
To workaround this limitation we use GetExtendedTcpTable() first to get the peer pid.
If this fails (which happens at least on real WinXP SP2) we then use
AllocateAndGetTcpExTableFromStack() to get the pid.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=66060
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Ralf Habacker [Thu, 8 Aug 2013 14:52:54 +0000 (16:52 +0200)]
Add doc to load_ex_ip_helper_procedures().
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=66060
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Ralf Habacker [Thu, 8 Aug 2013 14:48:04 +0000 (16:48 +0200)]
Only take process id of localhost client connection entries.
This patch makes sure, that the process id is fetched only from localhost
client address connections fetched from the tcp table.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=66060
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Ralf Habacker [Wed, 7 Aug 2013 18:47:55 +0000 (20:47 +0200)]
Fixed bug of unsupported GetExtendTcpTable() on Windows XP SP2 and earlier.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=66060
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Radoslaw Pajak [Thu, 8 Aug 2013 08:19:59 +0000 (10:19 +0200)]
Added NameList method handling, small improvemnets and cleanups
- Addded handling of org.freedesktop.DBus method "NameList"
- Element not found added to error messages
- in hello message commented out flags for sending unnecessary kdbus message parts
- change in kdbus message decoding - if part size is incorrect, stop decoding
- some small cleanups and improvements
Change-Id: I8ee4cf8301f1f3876f614c25798abc63c4ebe634
Ralf Habacker [Sat, 29 Jun 2013 11:46:53 +0000 (13:46 +0200)]
Dump fetched sid on return of _dbus_getsid().
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=66060
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Ralf Habacker [Sat, 29 Jun 2013 11:45:41 +0000 (13:45 +0200)]
Add WINXP <= SP3 support to _dbus_getsid().
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=66060
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Radoslaw Pajak [Tue, 6 Aug 2013 13:27:20 +0000 (15:27 +0200)]
Added fd passing and small corrections
- added passing fd through kdbus
- fixed sizes of mapped area when receiving memfd and receive pool
- unnecessary authentication code disabled by definition DBUS_AUTHENTICATION
- small fixes and cleanups
Change-Id: Ibe505c5ccb2790a054eb37a3f899ed5b2a378bc6
Jacek Janczyk [Tue, 6 Aug 2013 13:49:28 +0000 (15:49 +0200)]
Fix_for_32bit: added data alignment for some kdbus structures
Added alignments required by kdbus architecture in structures
passed to ioctl.
Change-Id: I4ab48709a4f6f43091f3fffa299e75ee1801ccc1
Signed-off-by: Jacek Janczyk <j.janczyk@samsung.com>
Michal Eljasiewicz [Tue, 6 Aug 2013 11:28:37 +0000 (13:28 +0200)]
refactored memfd
setup at every message. Pool sizes changed
Change-Id: Ia0bc93ceb0928fb241f6ed0c638c7b89e8cca73f
Radoslaw Pajak [Mon, 5 Aug 2013 06:50:06 +0000 (08:50 +0200)]
Pool sizes redefined and cleanup
- POOL_SIZE split into RECEIVE_POOL_SIZE and MEMFD_POOL_SIZE
- deleted some unused lines already commented out
- fixed dbus_bus_register
Change-Id: I981e00b795856e83000445bc68df208e01257594
Radoslaw Pajak [Wed, 24 Jul 2013 13:17:26 +0000 (15:17 +0200)]
- fixed detecting whether emulate org.freedesktop.DBus interface (dbus daemon)
when sending message
- improved dbus_bus_add_match for kdbus - now distinguish sender key (mapped to src_name),
interface key (mapped to bloom) and detects org.freedesktop.DBus's name related members
- bloom filled in kdbus_write... functions because of above dbus_bus_add_match improvement
- added dbus_bus_remove_match - but it ignire rules and deletes everythig for given connection id
Change-Id: I09e658f748ba9230601c128c3e67a0cb6ce8340d
Colin Walters [Wed, 24 Jul 2013 20:48:58 +0000 (21:48 +0100)]
test/marshal: Ensure we use suitably aligned buffers
This test was failing on s390; though it could fail
on other platforms too. Basically we need to be sure
we're passing at least word-aligned buffers to the
demarshalling code. malloc() will do that for us.
https://bugs.freedesktop.org/show_bug.cgi?id=67279
Michal Eljasiewicz [Tue, 23 Jul 2013 10:30:49 +0000 (12:30 +0200)]
kdbus_write_msg refactored.
kdbus_write_msg_encoded merged into single
function kdbus_write_msg.
added MEMFD handling.
FIX refactored out concatenating msg header & body
FIX encoded data is sent with memfd too
Radoslaw Pajak [Fri, 19 Jul 2013 13:38:17 +0000 (15:38 +0200)]
- fixed dbus_bus_request_name
- fixed error handling when writing to not existinig recipient
- added handling of org.freedesktop.DBus methods: GetNameOwner and NameHasOwner
- some small optimizations
Change-Id: I4ffdce1a7b089bedb065efe2247a22c44ccf9d86
Radoslaw Pajak [Tue, 16 Jul 2013 11:39:29 +0000 (13:39 +0200)]
Minor fixes and improvements. Deleted some not needed debug verboses.
Change-Id: I43ed82dd0f103d96e7df48ee7e6cd859dcb640af
Radoslaw Pajak [Thu, 11 Jul 2013 12:57:19 +0000 (14:57 +0200)]
- fixed sending messages without body
- fixed sending messages without requesting name
Change-Id: Ib2c5de13829b51b1a2ddac78511f6e4c83dc6c22
Radoslaw Pajak [Wed, 10 Jul 2013 13:14:22 +0000 (15:14 +0200)]
- kdbus reply timeout translated to DBus message
- kdbus message sending error ENXIO (no recipient on the bus) translated to corresponding DBus error message ServiceU$
- compatibility with 32bit machines improved
Michal Eljasiewicz [Tue, 9 Jul 2013 13:37:58 +0000 (15:37 +0200)]
refactoring: function prototypes unnecessary
Change-Id: Ib41be287421d45c0ba284fd88cb9dff59c85eccc
Signed-off-by: Michal Eljasiewicz <m.eljasiewic@samsung.com>
Radoslaw Pajak [Tue, 9 Jul 2013 11:31:48 +0000 (13:31 +0200)]
Only comments - commit needed to overcome git/gerrit problems
Radoslaw Pajak [Tue, 9 Jul 2013 07:37:37 +0000 (09:37 +0200)]
Added translation of system broadcast (new id, id remove, new name, name removed)
from kdbus format to dbus messages(signals).
do_io_error in do_reading don't need to be commented out any more.
todo message replay timeout to be translated form kdbus to dbus
Radoslaw Pajak [Fri, 5 Jul 2013 12:46:33 +0000 (14:46 +0200)]
Working - send method call and reply with serverClient
added sender to message header when kdbus
header aligned by upper layers - do not need to align in kdbus
do_io_error stil must be commented out in do reading when bytes_read == 0
todo - translate kdbus "system" broadcasts into dbus messages
Radoslaw Pajak [Fri, 5 Jul 2013 08:01:13 +0000 (10:01 +0200)]
Working - simple message passing with serverClient signal send-receive
BUT do_io_error must be commented out in do_reading when bytes_read == 0 to filter out kdbus "system" broadcasts (new id, new name, name remove, id remove)
TODO - translate kdbus "system" broadcasts into dbus messages
- test messages with header not aligned
Radoslaw Pajak [Wed, 3 Jul 2013 07:47:11 +0000 (09:47 +0200)]
Working: - dbus authorization replaced by kdbus policies
- sending message
To do: dbus authorization replaced by kdbus policies to be refactored when kdbus policies will be documented
Simon McVittie [Mon, 1 Jul 2013 11:24:53 +0000 (12:24 +0100)]
NEWS for 1.7.x
Chengwei Yang [Fri, 28 Jun 2013 12:26:28 +0000 (20:26 +0800)]
cmake: do not bind to any particular POSIX C standard
This caused build failures on FreeBSD. Defining _POSIX_C_SOURCE to
a particular version will disable common non-POSIX extensions like
PF_UNIX, and on some systems will also disable features of later
POSIX versions, like IPv6. If we don't ask for a specific version,
we'll get some sort of sensible default.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=66257
Signed-off-by: Chengwei Yang <chengwei.yang@intel.com>
[made the commit message more concise -smcv]
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Simon McVittie [Mon, 1 Jul 2013 11:16:05 +0000 (12:16 +0100)]
Merge branch 'dbus-1.6'
Conflicts:
NEWS
Simon McVittie [Mon, 1 Jul 2013 11:15:04 +0000 (12:15 +0100)]
NEWS for 1.6.x
Simon McVittie [Mon, 1 Jul 2013 11:14:02 +0000 (12:14 +0100)]
Make the test for #53499 more obviously correct
Chengwei Yang [Sat, 29 Jun 2013 04:21:27 +0000 (12:21 +0800)]
Test: add a test case for escaping byte > 127
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=53499
Signed-off-by: Chengwei Yang <chengwei.yang@intel.com>
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Chengwei Yang [Sat, 29 Jun 2013 03:56:20 +0000 (11:56 +0800)]
Fix: a non ascii byte will trigger BadAddress error
If a byte in DBusString *unescaped isn't a ascii byte, which will be
cast to char (signed char on most of platform), so that's the issue
unsigned char cast to signed char. e.g. "\303\266" is a valid unicode
character, if everything goes right, it will be escaped to "%c3%b6".
However, in fact, it escaped to "%<garbage-byte>3%<garbage-byte>6".
_dbus_string_append_byte_as_hex() take an int parameter, so negative
byte is valid, but cause get a negative index in array. So garbage value
will get. e.g. '\303' --> hexdigits[((signed byte)(-61)) >> 4] is
hexdigits[-4].
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=53499
Sgne-off-by: Chengwei Yang <chengwei.yang@intel.com>
[fixed whitespace -smcv]
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Chengwei Yang [Fri, 28 Jun 2013 08:23:03 +0000 (16:23 +0800)]
tests to embedded tests: replaced in cmake files
Signed-off-by: Chengwei Yang <chengwei.yang@intel.com>
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=66291
Chengwei Yang [Fri, 28 Jun 2013 08:06:41 +0000 (16:06 +0800)]
tests to embedded tests: replaced in automake files
Signed-off-by: Chengwei Yang <chengwei.yang@intel.com>
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=66291
Chengwei Yang [Fri, 28 Jun 2013 08:25:54 +0000 (16:25 +0800)]
tests to embedded tests: replaced in libdbus
Signed-off-by: Chengwei Yang <chengwei.yang@intel.com>
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=66291
Chengwei Yang [Fri, 28 Jun 2013 08:26:27 +0000 (16:26 +0800)]
tests to embedded tests: replaced in tools
Signed-off-by: Chengwei Yang <chengwei.yang@intel.com>
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=66291
Chengwei Yang [Fri, 28 Jun 2013 08:24:37 +0000 (16:24 +0800)]
tests to embedded tests: replaced in dbus-daemon
Signed-off-by: Chengwei Yang <chengwei.yang@intel.com>
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=66291
Chengwei Yang [Fri, 28 Jun 2013 06:40:42 +0000 (14:40 +0800)]
DBusString: fix a typo
Signed-off-by: Chengwei Yang <chengwei.yang@intel.com>
[separated out of a larger patch -smcv]
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=66300
Simon McVittie [Fri, 28 Jun 2013 11:03:05 +0000 (12:03 +0100)]
NEWS for 33001
Chengwei Yang [Fri, 28 Jun 2013 02:48:15 +0000 (10:48 +0800)]
cmake: align dir watch backend detection with autotools
Signed-off-by: Chengwei Yang <chengwei.yang@intel.com>
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=66257
Chengwei Yang [Fri, 28 Jun 2013 02:27:08 +0000 (10:27 +0800)]
cmake: terminate to generate makefiles due to fatal error
FATAL isn't a valid key for message according to cmake document here.
http://www.cmake.org/cmake/help/v2.8.8/cmake.html#command%3amessage
Due to the real fatal error, FATAL_ERROR should be used to terminate
cmake from continue generating makefiles.
Signed-off-by: Chengwei Yang <chengwei.yang@intel.com>
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=66257
Chengwei Yang [Fri, 28 Jun 2013 02:23:12 +0000 (10:23 +0800)]
cmake: get rid of useless commented out code
Signed-off-by: Chengwei Yang <chengwei.yang@intel.com>
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=66257
Chengwei Yang [Fri, 28 Jun 2013 01:36:32 +0000 (09:36 +0800)]
dir-watch: remove dnotify backend
dnotify as a dir watch backend is broken since Jan 2010 (almost 3.5
years). According to fd.o: #33001, it's no harm to remove dnotify from
this project.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=33001
Signed-off-by: Chengwei Yang <chengwei.yang@intel.com>
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Chengwei Yang [Fri, 28 Jun 2013 02:18:35 +0000 (10:18 +0800)]
cmake: clean up libxml2 glue
Signed-off-by: Chengwei Yang <chengwei.yang@intel.com>
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=66257
Simon McVittie [Fri, 28 Jun 2013 10:47:15 +0000 (11:47 +0100)]
NEWS for master
Simon McVittie [Fri, 28 Jun 2013 10:38:33 +0000 (11:38 +0100)]
Merge branch 'dbus-1.6'
Conflicts:
NEWS
Simon McVittie [Fri, 28 Jun 2013 10:37:28 +0000 (11:37 +0100)]
NEWS
Chengwei Yang [Fri, 28 Jun 2013 06:34:22 +0000 (14:34 +0800)]
Remove invoke of va_end before va_start
Signed-off-by: Chengwei Yang <chengwei.yang@intel.com>
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=66300
Chengwei Yang [Fri, 28 Jun 2013 05:55:14 +0000 (13:55 +0800)]
Fix two small typos in README.win
Signed-off-by: Chengwei Yang <chengwei.yang@intel.com>
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=66300
Radoslaw Pajak [Thu, 27 Jun 2013 09:23:29 +0000 (11:23 +0200)]
Updated dbus_bus_request_name
Added dbus_bus_add_match - because of differences and lack of documentation of kdus match adding it adds match to everything
Chengwei Yang [Wed, 26 Jun 2013 13:35:09 +0000 (21:35 +0800)]
kqueue: remove unused variable
Signed-off-by: Chengwei Yang <chengwei.yang@intel.com>
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=66035
Chengwei Yang [Wed, 26 Jun 2013 12:31:07 +0000 (20:31 +0800)]
dbus-launch: do not verbose output if build with verbose mode disabled
Signed-off-by: Chengwei Yang <chengwei.yang@intel.com>
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=66068
Chengwei Yang [Sun, 23 Jun 2013 02:49:09 +0000 (10:49 +0800)]
dbus-launch: align document
Signed-off-by: Chengwei Yang <chengwei.yang@intel.com>
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=66068
Chengwei Yang [Wed, 26 Jun 2013 12:26:37 +0000 (20:26 +0800)]
dbus-launch: fix coding style
Signed-off-by: Chengwei Yang <chengwei.yang@intel.com>
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=66068
Radoslaw Pajak [Wed, 26 Jun 2013 13:53:12 +0000 (15:53 +0200)]
working:
- request name (without some flags not supperted by kdbus now)
- upload policy for kdbus (probably to use in different place)
new useful function - dbus_transport_is_kdbus - tells whether transfor is kdbus
Chengwei Yang [Wed, 26 Jun 2013 07:40:12 +0000 (15:40 +0800)]
FreeBSD: explicit include signal.h to fix build failure
In Linux envrionment, signal.h included by sys/wait.h, however, this
isn't the case in FreeBSD. So explicit include it to fix build failure.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=66197
Signed-off-by: Chengwei Yang <chengwei.yang@intel.com>
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Chengwei Yang [Fri, 21 Jun 2013 09:58:56 +0000 (17:58 +0800)]
Fix build failure if build with tests but without verbose mode
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=66005
Signed-off-by: Chengwei Yang <chengwei.yang@intel.com>
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Radoslaw Pajak [Wed, 26 Jun 2013 07:35:37 +0000 (09:35 +0200)]
_dbus_transport_new_for_socket replaced by _dbus_transport_new_for_socket_kdbus in dbus-transport-kdbus.c
Inside this, socket_vtable replaced by kdbus_vtable, but kdbus_vtable is fiiled with socket_... functions, that have to be checked and modified when appropriate.
When checking and modifying that functions and functions below them, please do modify the name from socket_... to kdbus_...
modified: dbus/dbus-transport-kdbus.c
Radoslaw Pajak [Tue, 25 Jun 2013 11:34:15 +0000 (13:34 +0200)]
Beginning of kdbus support
Working:
- connecting to the bus
- bus registration (hello message)
Tested on the serverClient program made by L.Stempien
Not working:
- all the rest
Simon McVittie [Tue, 25 Jun 2013 11:29:30 +0000 (12:29 +0100)]
_dbus_message_iter_check: compile non-dummy version if asserting, too
Chengwei Yang [Tue, 25 Jun 2013 07:42:23 +0000 (15:42 +0800)]
Explicitly define macros to get less confusing conditions
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=65990
Signed-off-by: Chengwei Yang <chengwei.yang@intel.com>
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Chengwei Yang [Tue, 25 Jun 2013 03:34:11 +0000 (11:34 +0800)]
Fix build failure if build with checks but without asserts
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=65990
Signed-off-by: Chengwei Yang <chengwei.yang@intel.com>
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Simon McVittie [Mon, 24 Jun 2013 12:41:33 +0000 (13:41 +0100)]
Convert a{sv} helpers from Stats into generic utility code
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=54445
Reviewed-by: Ralf Habacker <ralf.habacker@freenet.de>
Chengwei Yang [Tue, 25 Jun 2013 05:45:35 +0000 (13:45 +0800)]
cmake: remove a duplicate line and fix coding style
Signed-off-by: Chengwei Yang <chengwei.yang@intel.com>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=66142
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Simon McVittie [Tue, 25 Jun 2013 11:16:54 +0000 (12:16 +0100)]
NEWS, noting build-time configuration change
Chengwei Yang [Tue, 25 Jun 2013 07:37:27 +0000 (15:37 +0800)]
cmake: fix a typo DBUS_DISABLE_ASSERTS should be DBUS_DISABLE_ASSERT
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=66142
Signed-off-by: Chengwei Yang <chengwei.yang@intel.com>
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Ralf Habacker [Thu, 20 Jun 2013 14:46:15 +0000 (16:46 +0200)]
Use Doxyfile.in for cmake build system too.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=64875
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Chengwei Yang [Fri, 21 Jun 2013 09:13:06 +0000 (17:13 +0800)]
Fix build failure if build with "--enable-stats"
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=66004
Signed-off-by: Chengwei Yang <chengwei.yang@intel.com>
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Chengwei Yang [Mon, 24 Jun 2013 08:00:29 +0000 (16:00 +0800)]
DBus Specification: remove incorrect table description
I doubt this line was copied by mistake from section "Summary of types".
Signed-off-by: Chengwei Yang <chengwei.yang@intel.com>
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=66115
Ralf Habacker [Wed, 23 Jan 2013 12:14:17 +0000 (13:14 +0100)]
Let dbus-daemon not print unavailable options on windows.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=42441
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Colin Walters [Tue, 2 Apr 2013 20:20:45 +0000 (16:20 -0400)]
connection: Add incoming message serials to verbose mode logging
This helps pair up messages with verbose mode output from the other
side of a connection.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=63047
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Simon McVittie [Thu, 20 Jun 2013 12:32:20 +0000 (13:32 +0100)]
NEWS
Chengwei Yang [Wed, 19 Jun 2013 08:35:43 +0000 (16:35 +0800)]
dbus-send: Fix fail to run without "--dest" option
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=65923
Signed-off-by: Chengwei Yang <chengwei.yang@intel.com>
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Simon McVittie [Thu, 20 Jun 2013 12:24:41 +0000 (13:24 +0100)]
Merge branch 'dbus-1.6'
Conflicts:
NEWS
Simon McVittie [Thu, 20 Jun 2013 12:20:08 +0000 (13:20 +0100)]
NEWS for #65959
Chengwei Yang [Thu, 20 Jun 2013 09:24:04 +0000 (17:24 +0800)]
DBusString: fix may crash if try to free an uninitialized str
If the str will be freed hasn't been initialized by _dbus_string_init
correctly, _dbus_string_free may crash due to trying to free an
undefined memory.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=65959
Signed-off-by: Chengwei Yang <chengwei.yang@intel.com>
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Chengwei Yang [Sat, 15 Jun 2013 07:42:19 +0000 (15:42 +0800)]
Doc: fix invalid usage of doxygen @param command
Signed-off-by: Chengwei Yang <chengwei.yang@intel.com>
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=65755
Ralf Habacker [Tue, 18 Jun 2013 12:07:38 +0000 (14:07 +0200)]
Fix of cmake xmldoc dependencies chain.
This patch fixes an issues that xml documentation is generated on all builds regardless
if related files has been changed or not.
The patch adds a global xmldoc make target to which all generated html or man files are
added as build dependency. Each dependency itself depends on related CMakeLists.txt and
the xml file generated from the related xml.in file.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=64058
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Ralf Habacker [Tue, 18 Jun 2013 11:42:34 +0000 (13:42 +0200)]
Fixed wrong path for generated xml files when creating man pages with cmake.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=64058
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Simon McVittie [Tue, 16 Apr 2013 15:48:11 +0000 (16:48 +0100)]
Add a statically-initialized implementation of _dbus_lock() on glibc systems
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=54972
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Alban Crequy <alban.crequy@collabora.co.uk>
Reviewed-by: Anas Nashif <anas.nashif@intel.com>
Simon McVittie [Tue, 16 Apr 2013 15:37:51 +0000 (16:37 +0100)]
Always initialize threading before allocating a dynamic mutex
Dynamic allocation of mutexes can fail anyway, so this is easy.
Justification for not keeping the dummy mutex code-paths, even as an
opt-in thing for processes known to be high-performance and
single-threaded: real mutexes only cut the throughput of
test/dbus-daemon.c by a couple of percent on my laptop (from around
6700 to around 6600 messages per second), and libdbus crashes caused
by not calling dbus_threads_init_default() are sufficiently widespread
that they're wasting a lot of everyone's time.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=54972
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Alban Crequy <alban.crequy@collabora.co.uk>
Reviewed-by: Anas Nashif <anas.nashif@intel.com>
Simon McVittie [Tue, 16 Apr 2013 15:28:44 +0000 (16:28 +0100)]
Make taking a global lock automatically initialize locking if needed
This lets them be thread-safe by default, at the cost that they can
now fail.
init_uninitialized_locks() and init_global_locks() must now both
reimplement the equivalent of _dbus_register_shutdown_func(), by using
_dbus_platform_rmutex_lock() on the same underlying mutex around a call
to _dbus_register_shutdown_func_unlocked().
This is because if they used the usual _DBUS_LOCK() API (as
_dbus_register_shutdown_func() does), it would automatically try to
initialize global locking, leading to infinite recursion.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=54972
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Alban Crequy <alban.crequy@collabora.co.uk>
Reviewed-by: Anas Nashif <anas.nashif@intel.com>
Simon McVittie [Tue, 16 Apr 2013 14:39:54 +0000 (15:39 +0100)]
Replace individual global-lock variables with an array of DBusRMutex *
This means we can use a much simpler code structure in data-slot
allocators: instead of giving them a DBusRMutex ** at first-allocation,
we can just give them an index into the array, which can be done
statically.
It doesn't make us any more thread-safe-by-default - the mutexes will
only actually be used if threads were already initialized - but it's
substantially better than nothing.
These locks really do have to be recursive: for instance,
internal_bus_get() calls dbus_bus_register() under the bus lock,
and dbus_bus_register() can call _dbus_connection_close_possibly_shared(),
which takes the bus lock.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=54972
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Alban Crequy <alban.crequy@collabora.co.uk>
Reviewed-by: Ralf Habacker <ralf.habacker@freenet.de>
Reviewed-by: Anas Nashif <anas.nashif@intel.com>
Simon McVittie [Thu, 2 May 2013 13:50:24 +0000 (14:50 +0100)]
start spec 0.22 development
Simon McVittie [Thu, 13 Jun 2013 15:18:30 +0000 (16:18 +0100)]
Fix Werror=unused-function if build without X11
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=65712
Signed-off-by: Chengwei Yang <chengwei.yang@intel.com>
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Simon McVittie [Thu, 13 Jun 2013 12:47:19 +0000 (13:47 +0100)]
Start on 1.7.5, add release name for 1.7.4
Simon McVittie [Thu, 13 Jun 2013 12:46:33 +0000 (13:46 +0100)]
Add release name for 1.6.12
Simon McVittie [Wed, 12 Jun 2013 18:49:44 +0000 (19:49 +0100)]
Prepare 1.7.4 for tomorrow