Ahson Ahmed Khan [Mon, 9 Oct 2017 21:24:43 +0000 (14:24 -0700)]
Making some small updates to Memory and S.R.CS test projects. (dotnet/corefx#24436)
Commit migrated from https://github.com/dotnet/corefx/commit/
b7eda119216f71458e81f3bcb2096c45056ca527
Dan Moseley [Mon, 9 Oct 2017 20:45:59 +0000 (13:45 -0700)]
Update ReportGenerator to 3.0.1 (dotnet/corefx#24512)
Commit migrated from https://github.com/dotnet/corefx/commit/
4db947a434a6c73df70515fe26387d77f92ae3ac
dotnet-maestro-bot [Mon, 9 Oct 2017 20:45:41 +0000 (15:45 -0500)]
Update BuildTools to prerelease-02109-01 (dotnet/corefx#24523)
Commit migrated from https://github.com/dotnet/corefx/commit/
73ee9d0cbb9064cd51c443e96ac09147f5acd968
Wes Haggard [Mon, 9 Oct 2017 20:06:12 +0000 (13:06 -0700)]
Merge pull request dotnet/corefx#24490 from fiigii/x86intrinsic
Move S.R.Intrinsics.X86 to shared framework
Commit migrated from https://github.com/dotnet/corefx/commit/
7d85622501e4e7e91ff3189549a7f813a7879907
chcosta [Mon, 9 Oct 2017 20:03:43 +0000 (13:03 -0700)]
Replace deprecated VSTS task (dotnet/corefx#24519)
* Always run cleanup agent task on windows build
* Replace deprecated VSTS task for copy/publish artifacts
Commit migrated from https://github.com/dotnet/corefx/commit/
2798823bf009453e561cfabaa5ef2b910a59c640
Maryam Ariyan [Mon, 9 Oct 2017 18:55:55 +0000 (14:55 -0400)]
Allow ProcessStart when folder in CurDirectory has same name as file in ExecDirectory (dotnet/corefx#24498)
We do not support Process.Start on a directory on Unix unless UseShellExecute is set.
When UseShellExecute is set, we can call xdg-open to open a window showing the directory.
When Process.Start is passed the directory (via ProcessStartInfo.FileName) we will attempt to resolve it to a fully qualified path.
We should be testing the actual path we are going to give to execve.
To get the actual path we first check if the path is exact, then we try path relative to executable and then current directory.
Lastly we check in all directories provided in PATH to find ProcessStartInfo.FileName.
After finding this path, we were inadvertently still checking the input path before this conversion was done.
The fix is to make the check after converting the path.
fixes dotnet/corefx#24402
Commit migrated from https://github.com/dotnet/corefx/commit/
911a8798e79215ed9805660238d85a63866510de
Karel Zikmund [Mon, 9 Oct 2017 18:55:25 +0000 (11:55 -0700)]
Updated ownership of Numerics and Threading
Commit migrated from https://github.com/dotnet/corefx/commit/
5f083c7ac0d8ab35f48e7ff9176e05af894c4562
Shin Mao [Mon, 9 Oct 2017 17:57:29 +0000 (10:57 -0700)]
Add Ref and Pkg for S.SM.Syndication. (dotnet/corefx#24383)
* Add Ref and Pkg for S.SM.Syndication.
* Add System.ServiceModel.Web to the ExcludeFromClosure list.
* Exclude System.ServiceModel.Web from Closure on UAP.
* Added description entry for S.SM.Syndication.
Commit migrated from https://github.com/dotnet/corefx/commit/
b065b84092839e96cfe267c57e25608f12157d3c
Karel Zikmund [Mon, 9 Oct 2017 17:17:49 +0000 (10:17 -0700)]
Removed @shiftylogic from area ownerships
Commit migrated from https://github.com/dotnet/corefx/commit/
4980752ca08094b6700f4667a70d7f72251aec09
Karel Zikmund [Mon, 9 Oct 2017 17:14:15 +0000 (10:14 -0700)]
Removed @mellinoe from area ownership
Commit migrated from https://github.com/dotnet/corefx/commit/
a9ef6e8e53816170db977f369471efa1593678d6
Stephen Toub [Mon, 9 Oct 2017 15:17:27 +0000 (11:17 -0400)]
Merge pull request dotnet/corefx#24471 from stephentoub/expose_ctrtoken
Expose/test CancellationTokenRegistration.Token
Commit migrated from https://github.com/dotnet/corefx/commit/
3cbd3c98c8d28aa1510eb3021ed556b04934748d
dotnet-maestro-bot [Mon, 9 Oct 2017 14:33:48 +0000 (09:33 -0500)]
Update Standard to preview1-25809-01 (dotnet/corefx#24513)
Commit migrated from https://github.com/dotnet/corefx/commit/
caed9d9d749f885f71b35e272b4ba3d4990524e8
dotnet-maestro-bot [Mon, 9 Oct 2017 05:18:42 +0000 (00:18 -0500)]
Update ProjectNTfs, ProjectNTfsTestILC to beta-25809-00, beta-25809-00, respectively (dotnet/corefx#24506)
Commit migrated from https://github.com/dotnet/corefx/commit/
a17b150a7a174494fa8e74fc47dd0269413dfe77
dotnet-maestro-bot [Mon, 9 Oct 2017 02:46:06 +0000 (21:46 -0500)]
Update CoreFx to preview1-25809-01 (dotnet/corefx#24503)
Commit migrated from https://github.com/dotnet/corefx/commit/
018f4e69d1b21a34ba239282add120cc123e9fd5
dotnet-maestro-bot [Sun, 8 Oct 2017 21:13:23 +0000 (16:13 -0500)]
Update BuildTools, CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC, Standard to prerelease-02106-01, preview1-25806-01, preview1-25808-02, preview1-25806-02, beta-25806-00, beta-25806-00, preview1-25806-01, respectively (dotnet/corefx#24465)
Commit migrated from https://github.com/dotnet/corefx/commit/
5a0a182e6b8abed5b45baf7f35f28091aa88b51a
Santiago Fernandez Madero [Sat, 7 Oct 2017 19:25:07 +0000 (12:25 -0700)]
Calculate CoreCLRSymbols from ReferenceCopyLocalPaths instead of hardcoding the nuget id and avoid warnings when the RID is different (dotnet/corefx#24489)
Commit migrated from https://github.com/dotnet/corefx/commit/
12a8a95e1e92871226e39425aa1220cf4a1f9df7
Santiago Fernandez Madero [Sat, 7 Oct 2017 19:22:14 +0000 (12:22 -0700)]
Add build Configurations.props to performance tests (dotnet/corefx#24493)
Commit migrated from https://github.com/dotnet/corefx/commit/
907e2a5ebf0904551ee2c6a90607ae2b133b5b10
Jan Vorlicek [Sat, 7 Oct 2017 10:54:17 +0000 (12:54 +0200)]
Update CentOS 6 and 7 docker images (dotnet/corefx#24463)
The images now contain clang 3.9 with PGO support
Commit migrated from https://github.com/dotnet/corefx/commit/
983507fab9c3f93c85dfb1d6f4d169fb961d6ef6
Fei Peng [Fri, 6 Oct 2017 21:17:57 +0000 (14:17 -0700)]
Move S.R.Intrinsics.X86 to shared framework
Commit migrated from https://github.com/dotnet/corefx/commit/
fb040bef44017f02183dd313e015aae85667552a
Eric Mellino [Fri, 6 Oct 2017 18:59:32 +0000 (11:59 -0700)]
Merge pull request dotnet/corefx#24464 from mellinoe/system.drawing-fix-function-wrapper-exceptions
Give a meaningful exception message when FunctionWrapper targets are not successfully loaded.
Commit migrated from https://github.com/dotnet/corefx/commit/
c1539411e4bc053eda9f864ba0a285aecd25e5b3
Eric Mellino [Fri, 6 Oct 2017 17:02:17 +0000 (10:02 -0700)]
Remove unused resource string in System.Drawing.Common.
Commit migrated from https://github.com/dotnet/corefx/commit/
25031c34e55cbce657a6c806ddd7a183d59b3c46
Atsushi Kanamori [Fri, 6 Oct 2017 13:54:12 +0000 (06:54 -0700)]
Expose IsGenericTypeParameter and IsGenericMethodParameter on System.Type (dotnet/corefx#24450)
Api approved here:
https://github.com/dotnet/corefx/issues/23883
Commit migrated from https://github.com/dotnet/corefx/commit/
19b1ac1aef00b2ceb7b00962bf059382c494e7f6
Stephen Toub [Fri, 6 Oct 2017 03:49:56 +0000 (23:49 -0400)]
Use CancellationTokenRegistration.Token in PipeCompletionSource
Shrinks each instance by the size of a reference.
Commit migrated from https://github.com/dotnet/corefx/commit/
7e050b7408ec88b07ad81d296a57a14fc644dada
Stephen Toub [Fri, 6 Oct 2017 03:45:21 +0000 (23:45 -0400)]
Expose/test CancellationTokenRegistration.Token
Commit migrated from https://github.com/dotnet/corefx/commit/
2ac4caae413b4a734a0df48aee847611577cb021
Anirudh Agnihotry [Fri, 6 Oct 2017 12:15:35 +0000 (05:15 -0700)]
Port System.Diagnostics.EventLog to .NET Core (dotnet/corefx#24344)
* Adding sources for System.Diagnostics.EventLog
* Adding some tests for System.Diagnostics.EventLog
Commit migrated from https://github.com/dotnet/corefx/commit/
e6084de42bbef119027a8ac4eb7a60789b153b51
David Shulman [Fri, 6 Oct 2017 00:33:50 +0000 (17:33 -0700)]
Removed obsolete System.Net.Http NETFX related files (dotnet/corefx#24453)
Due to PR dotnet/corefx#23611, the master branch no longer builds a NETFX binary for
System.Net.Http. Instead this is now handled only in the release/2.0.0
branch as part of the "NETStandard support package".
This effectively means that we have already stopped OOB'ing
System.Net.Http on .NET Framework platforms as of .NET 4.7.1 since that
version of .NET Framework supports all NETStandard2.0 APIs. And .NET
Framework versions prior to that (4.6.x, etc.) are handled with the OOB
System.Net.Http.dll that is part of the NETStandard support package.
Commit migrated from https://github.com/dotnet/corefx/commit/
a6b0655b1537044d85e97a69ef80bfd661e25ca5
Maryam Ariyan [Fri, 6 Oct 2017 00:12:23 +0000 (20:12 -0400)]
removing comments not anymore tracked by dotnet/corefx#24048 (dotnet/corefx#24460)
* removing comments not anymore tracked by dotnet/corefx#24048
* keeping useful comment: sometimes process is null.
Commit migrated from https://github.com/dotnet/corefx/commit/
ef00cf7d5d786f64d2025e8ea6a8379d088ac781
Eric Mellino [Thu, 5 Oct 2017 23:25:13 +0000 (16:25 -0700)]
Give a meaningful exception message when FunctionWrapper targets are not successfully loaded.
Commit migrated from https://github.com/dotnet/corefx/commit/
f519f45c4f8c5fbc069d1fd751b76c42c9525acc
Stephen Toub [Thu, 5 Oct 2017 20:53:49 +0000 (16:53 -0400)]
Add Memory-based APIs to Sockets (dotnet/corefx#24431)
Commit migrated from https://github.com/dotnet/corefx/commit/
b6ef0f1458bbbb43465eaef04ca396e192ff19ed
Jon Hanna [Thu, 5 Oct 2017 19:19:45 +0000 (20:19 +0100)]
Remove dead code concernin TypeParameterType/Symbol from Microsoft.CSharp (dotnet/corefx#23278)
* Remove cases concerning TypeParameterType conversions
Only relevant when compiling generic methods, not in dynamic code.
Entails removal of ERR_TypeVarCantBeNull. Contributes to dotnet/corefx#22470
* Remove case for TypeParameterType in AllPossibleInterfaces
Since both callsites ensure the type is a struct, class or interface type, it can only be called with an AggregateType or NullableType
* Remove _bHasRefBound, _bHasValBound and _pDeducedBaseClass
Only ever false, false and null respectively.
* Remove base and boxing type parameter conversions.
Only relevant when compiling generic methods, so never hit in dynamic code.
* Don't consider type parameter types in GetRefEqualSigs
Only comes up when statically compiling generic methods.
* Remove unnecessary gotos
* Dont consider type parameter types in HasImplicitReferenceConversion
Only comes up when static compiling generic methods.
* Reduce repeated checks within HasImplicitReferenceConversion
(Some of these will become better still when some methods that only return true for AggregateType are made sealed and virtual within it)
* Remove unnecessary identity check form HasImplicitReferenceConversion.
Never true when it is called, and if it was true the method should return true anyway.
* Move check that pDest is AggregateType
As all true-returning branches depend on it in some way, and it simplifies the rest.
* Replace if ladder on types of AggregateType into switch on symbol's AggKind
* Remove TypeParameterType case from MemberLookup.Lookup
Cannot happen outside of static compilation of generic method.
* Remove type parameter case from SearchSingleType
Cannot happen in dynamic code.
* Remove TypeVarsAllowed and ExtensionCall from MemLookFlags
Unused
* Remove GetInterfaceBounds from TypeParameterType and TypeParameterSymbol
Always null and no longer used.
* Remove GetEffectiveBaseClass from TypeParameterType/Symbol
Always null, and unused. (Removing either still results in null being
the value that would be found, or removing a case that would throw if
it was hittable).
* More consistent spacing in switch (respond to PR feedback).
Commit migrated from https://github.com/dotnet/corefx/commit/
038f2e4f5d5a0764096021e8bc495dcf8aac1ed4
Jan Vorlicek [Thu, 5 Oct 2017 16:47:01 +0000 (18:47 +0200)]
Fix init-tools.sh for Alpine Linux (dotnet/corefx#24423)
The URL used to get the dotnet sdk for Alpine was accidentally left
unchanged when the URL for other targets was modified.
I have fixed that and also unified the creation of the dotnet-sdk-XXX
part of the URL for all platforms.
Commit migrated from https://github.com/dotnet/corefx/commit/
60b6385e29d9c986ed0331498bbaec204eda4ac3
dotnet-maestro-bot [Thu, 5 Oct 2017 16:38:34 +0000 (11:38 -0500)]
Update CoreClr, CoreFx, ProjectNTfs, ProjectNTfsTestILC, Standard to preview1-25805-02, preview1-25805-02, beta-25805-01, beta-25805-01, preview1-25805-01, respectively (dotnet/corefx#24438)
Commit migrated from https://github.com/dotnet/corefx/commit/
8dd3815b77adde0be84f87cec6833edd847eab44
Stephen Toub [Thu, 5 Oct 2017 04:36:18 +0000 (00:36 -0400)]
Add TextReader/Writer Memory-based virtuals (dotnet/corefx#24434)
* Add Memory-based Read/WriteAsync virtuals to TextReader/Writer
* Override Span/Memory-based APIs on StringReader/Writer
* Address PR feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
03d705664c6c14b3ac3b1c73caae69e91542f530
Tristram Bethea [Thu, 5 Oct 2017 03:53:21 +0000 (23:53 -0400)]
Unifying the style of property delcarations and fixing some bracket indentations. (dotnet/corefx#24437)
Commit migrated from https://github.com/dotnet/corefx/commit/
fc225bd023e4e692d18442b02454cada7c252368
Bar Arnon [Wed, 4 Oct 2017 23:50:45 +0000 (01:50 +0200)]
IPAddress.GetHashCode based on Marvin instead of ToString (dotnet/corefx#24188)
* IPAddress.GetHashCode based on Marvin instead of ToString
* Copy address and scope id without going using pointers to avoid GC holes
* Reset cahced ToString, GetHashCode values when address or scope id are set.
* Use safe stackalloc
* Change Common.Tests to target netcoreapp
* Change to netcoreapp in Common.Tests's Configurations.props
* Remove BitConverter with span usage in Marvin
Commit migrated from https://github.com/dotnet/corefx/commit/
b48277b29f65c7c6b7c3d9210db7207f1627c687
Tim Seaward [Wed, 4 Oct 2017 23:48:01 +0000 (00:48 +0100)]
SSLStream : Add WriteAsync overloads (dotnet/corefx#24295)
* Added Async overload
* Added overloads for readonlymemory on the write side
* Unix/osx
* Fixing unix and osx
* Make a dump buffer that takes a ReadOnlyMemory
* Add back validation for writeasync with the traditional array
* Move the ReadOnlyMemory overload to a partial class outside the common NetEventSource
* Backout inlining of EncryptDecrypt Method
* Reacting to review
Added named const on retain
Removed try catch put using
Fixed SLN
Commit migrated from https://github.com/dotnet/corefx/commit/
287f7a1f19401138f00267031454941b658de193
Tarek Mahmoud Sayed [Wed, 4 Oct 2017 21:15:08 +0000 (14:15 -0700)]
More DirectoryServices tests (dotnet/corefx#24388)
* More DirectoryServices tests
* Minor fix
Commit migrated from https://github.com/dotnet/corefx/commit/
453ac241dcb8df878cf8e9968cf4ec42a83ac496
Eric Mellino [Wed, 4 Oct 2017 18:24:49 +0000 (11:24 -0700)]
Merge pull request dotnet/corefx#24428 from dotnet-maestro-bot/master-UpdateDependencies
Update BuildTools, CoreSetup to prerelease-02104-03, preview1-25804-01, respectively (master)
Commit migrated from https://github.com/dotnet/corefx/commit/
5813eb3a7e491f059f763397a9837e4f2f17a10e
Santiago Fernandez Madero [Wed, 4 Oct 2017 18:17:00 +0000 (11:17 -0700)]
Add targets to download CoreCLR symbols (dotnet/corefx#24294)
* Add targets to download CoreCLR symbols
* Clean up now that target was moved to Symbols.targets
* Add condition to disable target and add warning if it failed to download CoreCLR symbols
Commit migrated from https://github.com/dotnet/corefx/commit/
f628457a906daedb32bd626517c99b39410c5750
dotnet-maestro-bot [Wed, 4 Oct 2017 17:31:00 +0000 (10:31 -0700)]
Update BuildTools, CoreSetup to prerelease-02104-03, preview1-25804-01, respectively
Commit migrated from https://github.com/dotnet/corefx/commit/
98898089c83a491189bf6736bcd721521478fa0f
Paulo Janotti [Wed, 4 Oct 2017 15:25:38 +0000 (08:25 -0700)]
[UWP]allow all security flags on named pipe client (dotnet/corefx#24414)
* [UWP]allow all security flags on named pipe client
Perhaps the more proper way to deal with this is to define proper
constants and enumerations but that needs to be done for the whole IO
area/usage. However, even after that likely we should change the signature of the
method since there will be some values that are not supported with the
current signature.
Opportunistic fix: RunAsClient was not raising proper exceptions in case
of error.
* Add comment for bit masks used
* Added test to force throw in RunAsClient
* local constant for SECURITY_VALID_SQOS_FLAGS
Commit migrated from https://github.com/dotnet/corefx/commit/
7d1b1e97f1999bf38eb2ce8ce84c209ab7a5d83b
dotnet-maestro-bot [Wed, 4 Oct 2017 04:12:51 +0000 (23:12 -0500)]
Update CoreFx, ProjectNTfs, ProjectNTfsTestILC to preview1-25804-01, beta-25804-00, beta-25804-00, respectively (dotnet/corefx#24418)
Commit migrated from https://github.com/dotnet/corefx/commit/
e9797436b1729e31f9de6a69ef99dfdccf0dcf42
Santiago Fernandez Madero [Wed, 4 Oct 2017 03:58:20 +0000 (20:58 -0700)]
Skip GC tests on desktop with difference in behavior (dotnet/corefx#24419)
Commit migrated from https://github.com/dotnet/corefx/commit/
26ec0da463d423e2e475d24d12a1ad22af454f15
dotnet-maestro-bot [Wed, 4 Oct 2017 01:33:20 +0000 (20:33 -0500)]
Update BuildTools, CoreSetup to prerelease-02104-02, preview1-25803-02, respectively (dotnet/corefx#24413)
Commit migrated from https://github.com/dotnet/corefx/commit/
4d68f7e50983c852bc5d4d7d5fc2af0f3df78176
Arthur Vickers [Tue, 3 Oct 2017 22:34:41 +0000 (15:34 -0700)]
Revert bad PR that was merged to soon (dotnet/corefx#24412)
See dotnet/corefx#24064. The checked in fix is wrong because it changes the behavior when .NET Native is being used such that a nonsensical exception will be thrown which would never be thrown when .NET Native is not being used. These kinds of errors are really hard for developers to debug.
Instead we will let .NET Native fail in the normal way when rd.xml data is not available. This will direct people to add metadata appropriately when they need to get this to work.
Commit migrated from https://github.com/dotnet/corefx/commit/
33d3ed08cdc0c59b00aa14874c2bd5a6be256fee
Kasper Fabæch Brandt [Tue, 3 Oct 2017 21:38:04 +0000 (23:38 +0200)]
Make FileSystemWatcher tests tolerant of spurious/extra events on all platforms. Fixes dotnet/coreclrdotnet/corefx#14154. (dotnet/corefx#24406)
Commit migrated from https://github.com/dotnet/corefx/commit/
8665e8bbd98cc47bf4bcfdc7c2939c477953d85c
Ian Hays [Tue, 3 Oct 2017 20:59:00 +0000 (13:59 -0700)]
Merge pull request dotnet/corefx#24171 from ianhays/master_ecdsa_segfault
Fix ECDsa ExportParameters segfault
Commit migrated from https://github.com/dotnet/corefx/commit/
031930560a4ab20e24181d30db1e4463b93aff62
Ian Hays [Tue, 19 Sep 2017 19:45:00 +0000 (12:45 -0700)]
Fix ECDsa ExportParameters segfault
ECDSa.Export(Explicit)Parameters(includePrivateParameters:true) on an EC object containing only a public key will currently segfault on Linux. It is supposed to throw a CryptographicException, so this commit changes it to do so.
Commit migrated from https://github.com/dotnet/corefx/commit/
a78b89cd4746009d0fbe0d60c293e237706c88f1
Ahson Ahmed Khan [Tue, 3 Oct 2017 19:28:33 +0000 (12:28 -0700)]
Reenabling disabled tests and disabling others (for uapaot) (dotnet/corefx#24385)
Commit migrated from https://github.com/dotnet/corefx/commit/
402fc2013317dc314198842daddcd114d909badd
Stephen Toub [Tue, 3 Oct 2017 19:08:27 +0000 (15:08 -0400)]
Add string.Concat(IEnumerable<char>) tests (dotnet/corefx#24398)
Exercise char special paths in string.Concat.
Commit migrated from https://github.com/dotnet/corefx/commit/
ec275b2e5c05f81661b8223ef9bc0b46c49bc8e9
Stephen Toub [Tue, 3 Oct 2017 17:37:02 +0000 (13:37 -0400)]
Expose/test ThreadPool.QueueUserWorkItem(..., bool preferLocal) (dotnet/corefx#24396)
Commit migrated from https://github.com/dotnet/corefx/commit/
59f127d39937a97b5b2bce27c70785b1cde2ade0
Jeremy Kuhne [Tue, 3 Oct 2017 16:52:39 +0000 (09:52 -0700)]
Allow directory not empty errors (dotnet/corefx#24382)
If we've successfully removed all of the file content without errors we should allow for directory not empty to allow for active file handles to close.
Commit migrated from https://github.com/dotnet/corefx/commit/
e791e8b7a4f1e4d6ff5b4295fad04a6c9f65e909
Stephen Toub [Tue, 3 Oct 2017 16:49:38 +0000 (12:49 -0400)]
Expose MemoryStream.Read/WriteAsync(Memory) from ref (dotnet/corefx#24397)
MemoryStream's other Read/Write{Async} overrides are exposed from the ref, but these two were missing. The lack of them causes stream's derived from MemoryStream that then call down to the base methods to skip these and go instead to Stream's implementation.
Commit migrated from https://github.com/dotnet/corefx/commit/
b6244c5260ee9433c3c62b56d085fc5db20b4bb1
dotnet-maestro-bot [Tue, 3 Oct 2017 13:58:39 +0000 (08:58 -0500)]
Update CoreClr to preview1-25803-02 (dotnet/corefx#24393)
Commit migrated from https://github.com/dotnet/corefx/commit/
bdfd72920fc059ce1bfc70b28587d7e295cc68c0
Stephen Toub [Tue, 3 Oct 2017 13:13:24 +0000 (09:13 -0400)]
Disable stack trace tests on netfx (dotnet/corefx#24392)
These just started failing across PRs.
Commit migrated from https://github.com/dotnet/corefx/commit/
2f75c12ac0e435920415891f391ff2a48d67a193
dotnet-maestro-bot [Tue, 3 Oct 2017 11:59:11 +0000 (06:59 -0500)]
Update ProjectNTfs, ProjectNTfsTestILC to beta-25803-00, beta-25803-00, respectively (dotnet/corefx#24391)
Commit migrated from https://github.com/dotnet/corefx/commit/
c229224064f567b41d67d96850aa0709f1c35fa2
Kasper Fabæch Brandt [Tue, 3 Oct 2017 03:56:07 +0000 (05:56 +0200)]
Add test for dotnet/corefx#24081 (succeeds after dotnet/coreclrdotnet/corefx#14043) (dotnet/corefx#24163)
Commit migrated from https://github.com/dotnet/corefx/commit/
819da8af67f04867012a3fb274e1eca6078a048e
Koundinya Veluri [Tue, 3 Oct 2017 03:55:23 +0000 (20:55 -0700)]
Reenable Task stack guard tests (dotnet/corefx#24087)
Fixed by https://github.com/dotnet/coreclr/pull/14015
Reenables tests in and closes https://github.com/dotnet/corefx/issues/23201
Commit migrated from https://github.com/dotnet/corefx/commit/
9d02dcf8fb6035a4958e36117b857f80b5436874
dotnet-maestro-bot [Tue, 3 Oct 2017 03:50:59 +0000 (22:50 -0500)]
Update BuildTools, CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to prerelease-02102-02, preview1-25803-01, preview1-25803-01, preview1-25802-02, beta-25802-00, beta-25802-00, respectively (dotnet/corefx#24381)
Commit migrated from https://github.com/dotnet/corefx/commit/
2b25c6c739ada3e8da8b8783e008f48f9078fb33
Tomas Weinfurt [Tue, 3 Oct 2017 03:40:30 +0000 (20:40 -0700)]
Add minimal handling for HTTP 1.0 requests to ManagedHandler (dotnet/corefx#23653)
* add minimal handling for 1.0 requests.
* use 1.1 as default version and move some message to resource file
* fix spelling
* remove exception for 2.0 requests and fall-back to 1.1
* remove s_spaceHttp20NewlineAsciiBytes as it is not used now
* add isHttp10 bool to avoid duplicate check.
Commit migrated from https://github.com/dotnet/corefx/commit/
8b266d0ca4a12428629b3a7abf79c61c29e50883
Ahson Ahmed Khan [Mon, 2 Oct 2017 21:18:15 +0000 (14:18 -0700)]
Adding MemoryHandle AddOffset to fix Memory.Retain impl (dotnet/corefx#24323)
* Adding MemoryHandle AddOffset to fix Memory.Retain impl
* Adding AddOffset to System.Runtime ref.
* Make the AddOffset API internal.
Commit migrated from https://github.com/dotnet/corefx/commit/
b9676be62166e90a07763f070330a9ffc8ef6cc7
Huangli Wu [Mon, 2 Oct 2017 20:45:16 +0000 (13:45 -0700)]
Make the public class be internal in sgen. (dotnet/corefx#24345)
* Make the public class be internal in sgen.
* Make Sgen class be internal.
* Make XmlSerializationWriteCallback be internal in SGEN.
Commit migrated from https://github.com/dotnet/corefx/commit/
b5626e6a1cbeb56d272f015e06259a4dfb7a40dc
Stephen Toub [Mon, 2 Oct 2017 19:33:56 +0000 (15:33 -0400)]
Merge pull request dotnet/corefx#24349 from dotnet-maestro-bot/master-UpdateDependencies
Update BuildTools, CoreClr, CoreFx, CoreSetup, Standard to prerelease-02102-01, preview1-25730-01, preview1-25802-02, preview1-25802-01, preview1-25802-01, respectively (master)
Commit migrated from https://github.com/dotnet/corefx/commit/
63eeffc7a0cddd212f0a98089d7b679d2dd8d6c1
Stephen Toub [Mon, 2 Oct 2017 19:33:00 +0000 (15:33 -0400)]
Fix DebuggerDisplay for XmlNode (dotnet/corefx#24367)
Somewhere along the way XmlNode's debuggerDisplayProxy property was removed. That doesn't break the build, as it's only used via reflection, but it does break the debugger display tooltip.
This just copy-and-pastes the corresponding implementation from reference source to fix it. The only other change I made was renaming "node" to "_node" and making it readonly.
Commit migrated from https://github.com/dotnet/corefx/commit/
ae2ea6649e7d4e780277e6bcdeb102f7d8fd60d3
Stephen Toub [Mon, 2 Oct 2017 19:23:19 +0000 (15:23 -0400)]
Disable Tizen leg for PRs
Commit migrated from https://github.com/dotnet/corefx/commit/
570a91f9316a9fbab170aa83752ee5ccde7c2341
Ahson Ahmed Khan [Mon, 2 Oct 2017 19:17:48 +0000 (12:17 -0700)]
Adding {ReadOnly}Memory<T> debugger view (dotnet/corefx#24203)
* Adding {readonly}memory debugger view.
* Addressing PR feedback.
* Removing unnecessary using directives.
* Updating to master. Changing use of AsSpan to Span.
* Using workaround for VSTS bug 286592 and reverting back to Span.ToArray.
* Adding RO span debug view and updating debugger display string.
* Adding link to VSTS bug for clarity.
* Removing redundant info in comments.
Commit migrated from https://github.com/dotnet/corefx/commit/
8d212b41126baff94fc025e4438d6f4e8cbff7e9
dotnet-maestro-bot [Mon, 2 Oct 2017 18:13:48 +0000 (11:13 -0700)]
Update BuildTools, CoreClr, CoreFx, CoreSetup, Standard to prerelease-02102-01, preview1-25730-01, preview1-25802-02, preview1-25802-01, preview1-25802-01, respectively
Commit migrated from https://github.com/dotnet/corefx/commit/
a2a0525001dae85578c739ba15b2321199e4fc6f
Stephen Toub [Mon, 2 Oct 2017 17:33:52 +0000 (13:33 -0400)]
Merge pull request dotnet/corefx#24116 from stephentoub/orderby_perf
Use Array.Sort instead of custom QuickSort implementation in LINQ's OrderBy
Commit migrated from https://github.com/dotnet/corefx/commit/
ed0ee133ac49cee86f10ca4692b1d72e337bc012
dnickless [Mon, 2 Oct 2017 16:47:54 +0000 (18:47 +0200)]
Make GetProcessInfo() for a single PID cheaper on Windows (dotnet/corefx#24198)
* Improved performance of local process information retrieval by not constructing all ProcessInfo instances for all running processes anymore if only one is of interest.
* Removed superfluous space characters only
* Remove superfluous default parameter value
* Added a Debug.Assert()
* Moved a variable from the .Win32 file into the .Windows file in order to fix the UAP build and improved a Debug.Assert() message
* Attempt to make the UAP build happy again
* Removed the optionality of the "int processId" parameter from NtProcessInfoHelper.GetProcessInfos() to try and make the UAP build happy.
* Revert "Removed the optionality of the "int processId" parameter from NtProcessInfoHelper.GetProcessInfos() to try and make the UAP build happy."
This reverts commit dotnet/corefx@
78ef4706f412d00d8396a073bd73f9fbd87a5696.
* Revert "Attempt to make the UAP build happy again"
This reverts commit dotnet/corefx@
9ca6a02f2d2886ed9acc7e9643307e0ba0ca94b8.
* Fixed UAP builds by creating an NtProcessInfoHelper type with a contained GetProcessInfos(int processId = AllProcessIds) method in the ProcessManager.Uap.cs file which will just throw a NotSupportedException
* Aligned the implementations of GetProcessInfos(string machineName) for both Uap and Win32 into a shared Windows method (possible now because of previous check-in)
* Switched to a Predicate<T> based implementation instead of the "AllProcessIds = -1" magic number based version
Commit migrated from https://github.com/dotnet/corefx/commit/
ebf11343ff80295d49607eef5114df917e45f9bb
Sean Gillespie [Mon, 2 Oct 2017 16:29:43 +0000 (09:29 -0700)]
New tests covering GC.TryStartNoGCRegion (dotnet/corefx#24201)
* Add a number of TryStartNoGCRegion tests for corner case parameter validation
* Combine two related tests into a single theory
Commit migrated from https://github.com/dotnet/corefx/commit/
82374ba7b930bdb836a6bfd27c794068ba981e10
Jan Vorlicek [Mon, 2 Oct 2017 15:05:38 +0000 (17:05 +0200)]
Fix RHEL.6 CI build (dotnet/corefx#24331)
I have missed msbuild options separator in the build.sh
invocation when adding the /p:PortableBuild=false option.
Commit migrated from https://github.com/dotnet/corefx/commit/
df8e3b568b3115e09df264dd891f218c5d288385
Paulo Janotti [Sat, 30 Sep 2017 04:06:02 +0000 (21:06 -0700)]
Avoid deadlock on NamedPipeTest.Specific on UWP (dotnet/corefx#24348)
* Avoid deadlock on NamedPipeTest.Specific on UWP
For now this test is not running in UWP but this change prevents the
test from deadlocking if some of the blocking steps fail.
* Fix typo on method names
Commit migrated from https://github.com/dotnet/corefx/commit/
1525832151f05d790d7cd311ec87597e77fbf9fd
Eric StJohn [Fri, 29 Sep 2017 23:49:19 +0000 (16:49 -0700)]
Merge pull request dotnet/corefx#24306 from ericstj/buildRuntimeJson
Don't update runtime.*.json during the build
Commit migrated from https://github.com/dotnet/corefx/commit/
4c7b6465d8dcb944d08a3eb355689ea813acea67
Mike McLaughlin [Fri, 29 Sep 2017 22:49:30 +0000 (15:49 -0700)]
Merge pull request dotnet/corefx#24315 from mikem8361/llvm3.9a
Update build to clang/llvm 3.9
Commit migrated from https://github.com/dotnet/corefx/commit/
28615b146b0ecc0f36f2bd879d13eea4847a8565
Huangli Wu [Fri, 29 Sep 2017 22:00:36 +0000 (15:00 -0700)]
Add more parameters support in SGEN. (dotnet/corefx#24322)
* Add more parameters support in SGEN.
* Add the change in Strings.resx
* rename nolog to noLogo, parsableerrors to parsableErrors.
Commit migrated from https://github.com/dotnet/corefx/commit/
024f17e558dcc2666a336d6d60c9da3981d1d3db
Shin Mao [Fri, 29 Sep 2017 21:12:17 +0000 (14:12 -0700)]
Merge pull request dotnet/corefx#24313 from shmao/RemoveRdXml
Removed Microsoft.XmlSerializer.Generator's rd.xml
Commit migrated from https://github.com/dotnet/corefx/commit/
6d3804c5d9edec46c85797701834bbb135c8500f
Stephen Toub [Fri, 29 Sep 2017 19:37:25 +0000 (15:37 -0400)]
Fix handling of empty inputs to TakeLast (dotnet/corefx#24328)
It currently ends up trying to remove an element from an empty queue, causing an exception.
Commit migrated from https://github.com/dotnet/corefx/commit/
f74844b5b90ca9f3fda8439349071f549df03d43
Eric St. John [Fri, 29 Sep 2017 19:29:02 +0000 (12:29 -0700)]
Run GenerateRuntimeGraph during build
This turns GenerateRuntimeGraph back on, but it will now only check consistency of the
generated runtime files with what is checked in.
If it detects an inconsistency the build will fail and this project can be rebuilt specifying
/p:UpdateRuntimeFiles=true to commit the updates.
Commit migrated from https://github.com/dotnet/corefx/commit/
989a84f355eb6df5612f37bc783510e2d6b4e4c9
Eric Mellino [Fri, 29 Sep 2017 16:32:20 +0000 (09:32 -0700)]
Merge pull request dotnet/corefx#24208 from qmfrederik/drawing/mono-codec-tests
Tests Drawing Codecs (based on Mono's test suite)
Commit migrated from https://github.com/dotnet/corefx/commit/
25b0a9b6f784216de7f357ba680aa9a835ad3cba
Tarek Mahmoud Sayed [Fri, 29 Sep 2017 15:50:11 +0000 (08:50 -0700)]
First DirectoryServcies tests which runs against real server (dotnet/corefx#24316)
* First DirectoryServcies tests which runs against real server
* Fix msbuild failure with None element
* Address the feedback
* Fix some formatting
Commit migrated from https://github.com/dotnet/corefx/commit/
f4c2ba68f9e0b0f8735ce4eaecd71a207f520bd1
dotnet-maestro-bot [Fri, 29 Sep 2017 15:37:32 +0000 (10:37 -0500)]
Update Standard to preview1-25729-01 (dotnet/corefx#24330)
Commit migrated from https://github.com/dotnet/corefx/commit/
63df758be847ce00422ac2e9bf473282aef94d31
Stephen Toub [Fri, 29 Sep 2017 11:14:18 +0000 (07:14 -0400)]
Merge pull request dotnet/corefx#24288 from stephentoub/websocket_managedhandler
Use ManagedHandler in managed ClientWebSocket
Commit migrated from https://github.com/dotnet/corefx/commit/
ed12fd8ed08a71af95accf545c90fc41eff75a57
dotnet-maestro-bot [Fri, 29 Sep 2017 06:49:06 +0000 (01:49 -0500)]
Update ProjectNTfs, ProjectNTfsTestILC to beta-25729-00, beta-25729-00, respectively (dotnet/corefx#24326)
Commit migrated from https://github.com/dotnet/corefx/commit/
9a66ec30c0340f992a4924cbdebad499657aaa8c
Paulo Janotti [Fri, 29 Sep 2017 05:25:00 +0000 (22:25 -0700)]
Revert "Conditionally run namedPipes tests in uap if windows version contains fix (dotnet/corefx#24307)" (dotnet/corefx#24324)
This reverts commit dotnet/corefx@
161267c8645d4fd4cde51c3783d3c9326ed034f1. Fixes dotnet/corefx#24318
Commit migrated from https://github.com/dotnet/corefx/commit/
475bfdd5b0b2bcc21b5fd96f4dabf07b9ac418c8
dotnet-maestro-bot [Fri, 29 Sep 2017 03:20:36 +0000 (22:20 -0500)]
Update BuildTools, CoreFx, CoreSetup to prerelease-02029-01, preview1-25729-01, preview1-25728-02, respectively (dotnet/corefx#24314)
Commit migrated from https://github.com/dotnet/corefx/commit/
198205322cde8120c731c48e4c877fb14c467674
Stephen Toub [Thu, 28 Sep 2017 15:09:12 +0000 (11:09 -0400)]
Address PR feedback
- Have ClientWebSocket change the scheme from http{s} -> ws{s} instead of having HttpClient accept ws{s} urls.
- Use a duplex response stream only when the status code is 101
- Disable a test that relies on connection opening being cancelable
Commit migrated from https://github.com/dotnet/corefx/commit/
518ea1c2f8ad882c9829c8c35d27d92063ac67f7
Stephen Toub [Wed, 27 Sep 2017 21:07:26 +0000 (17:07 -0400)]
Use ManagedHandler in managed ClientWebSocket
ClientWebSocket's managed implementation currently has its own basic Socket-based code for establishing a websocket connection. This change switches it to use ManagedHandler instead, and in doing so benefits from improvements made to ManagedHandler thus far and in the future. For example, currently ManagedWebSocket doesn't support ClientWebSocketOptions.Proxy or ClientWebSocketOptions.Credentials, but since ManagedHandler does, now ManagedWebSocket does, too.
Commit migrated from https://github.com/dotnet/corefx/commit/
db9f342cc43e0096b42d4d6d008c095da2bb8cfa
Stephen Toub [Wed, 27 Sep 2017 20:57:31 +0000 (16:57 -0400)]
Make several allocations from ClientWebSocketOptions lazy
Commit migrated from https://github.com/dotnet/corefx/commit/
87ae016da78b9a29be33cc17f076b32c57c2a699
Stephen Toub [Wed, 27 Sep 2017 20:53:53 +0000 (16:53 -0400)]
Several HttpClient/ManagedHandler fixes to better support ClientWebSocket
- Allow ws:// and wss:// schemes
- Add an HttpContentDuplexStream base class to parallel the existing HttpContentReadStream and HttpContentWriteStream base classes
- Move more shared functionality down to the base HttpContentStream class
- Make ConnectionCloseStream duplex instead of read-only
Commit migrated from https://github.com/dotnet/corefx/commit/
9438b0a760b1ef827729662186e107abccb7524d
Stephen Toub [Wed, 27 Sep 2017 20:12:55 +0000 (16:12 -0400)]
Fix several Connect test's dependence on ReceiveAsync returning complete message
There's no guarantee that WebSocket.ReceiveAsync will return a complete message; in the extreme, a message can contain long.MaxValue bytes but the API only allows you to retrieve ~int.MaxValue at a time, but even way below that, it's common for ReceiveAsync to return the data it has available rather than gathering up all of the data from the message. However, several of the ConnectTest tests were depending on the full-message behavior. This commit fixes that.
Commit migrated from https://github.com/dotnet/corefx/commit/
ffaf5375c00622b285997bc9626c042b9d64195c
Stephen Toub [Wed, 27 Sep 2017 19:25:31 +0000 (15:25 -0400)]
Stop using ArrayPool<byte> for ManagedWebSocket's receive buffer
We end up draining the relevant bucket in the pool very quickly, such that we still end up doing a lot of allocating while also harming other users of the same bucket size.
Commit migrated from https://github.com/dotnet/corefx/commit/
7eedd7c8c6bd3729697878afecac6bb9b225b69b
Stephen Toub [Wed, 27 Sep 2017 19:20:38 +0000 (15:20 -0400)]
Reduce spurious completions in ManagedWebSocket
Currently if a web socket message arrives but not all of its data is there, ManagedWebSocket.ReceiveAsync will manufacture a non-EndOfMessage WebSocketReceiveResult with the available data. This means for larger messages, we end up artificially splitting the messages, which in turns leads to all of the async methods up the stack doing extra allocations due to needing to call back in to get the remainder of the message. While the approach does allow for the consumer to start processing the data from the message immediately, in most cases the consumer needs the full message anyway. So we can avoid these costs by being more aggressive about reading the full message size, up to whatever receive buffer we have to work with.
Commit migrated from https://github.com/dotnet/corefx/commit/
8bfe84e7e19632894de5ee9be46190a33e518273
Stephen Toub [Wed, 27 Sep 2017 13:39:40 +0000 (09:39 -0400)]
Reduce running time of KeepAlive_LongDelayBetweenSendReceives_Succeeds test
60 seconds is annoyingly long when trying to iterate. Reduced to 10.
Commit migrated from https://github.com/dotnet/corefx/commit/
941c4c80f0d25b34808d19adc7f8556107a88718
Stephen Toub [Fri, 29 Sep 2017 00:03:16 +0000 (20:03 -0400)]
Avoid blocking ThreadPool threads in cancelable NamedPipe*Stream.ReadAsync on Unix (dotnet/corefx#24302)
Named pipes on Unix are implemented via sockets. When a ReadAsync is issued, that it turns results in a ReceiveAsync on the socket. But today we lack a ReceiveAsync overload that takes a CancellationToken, and until such an overload exists, we need a workaround.
Today's workaround involves polling and blocking a thread pool thread doing a synchronous read; that's very expensive, especially when many such calls are made across one or more pipes and we end up blocking many threads.
This PR provides an alternative workaround. Instead of queueing a blocking poll to the thread pool, we issue a zero-length async receive so that we're notified when data is available, and we concurrently monitor the cancellation token. This is more efficient when cancellation doesn't occur. If cancellation does occur, we potentially "leak" the read request until data is available (or the socket closes), but cancellation is relatively rare, and even more rare is reusing the stream after cancellation has occurred, so this shouldn't be much more than a small fixed overhead.
Commit migrated from https://github.com/dotnet/corefx/commit/
668b634b6653d5eb0b8f65044e601805ad890957
Xing Mao [Thu, 28 Sep 2017 21:32:29 +0000 (14:32 -0700)]
Removed Microsoft.XmlSerializer.Generator's rd.xml
Commit migrated from https://github.com/dotnet/corefx/commit/
377b119c55304c28b71aae6c7f178be6f501da57
Frederik Carlier [Thu, 28 Sep 2017 21:04:17 +0000 (23:04 +0200)]
PR feeback - code cleanup
Commit migrated from https://github.com/dotnet/corefx/commit/
bde4f33dcf16fa56d078b0d29874ab10708cc04e
Frederik Carlier [Thu, 28 Sep 2017 21:02:13 +0000 (23:02 +0200)]
PR feedback - code cleanup
Commit migrated from https://github.com/dotnet/corefx/commit/
e7f3c94cfa3ae11fc4916eb7e236c55cd2148745
Jose Perez Rodriguez [Thu, 28 Sep 2017 20:11:11 +0000 (13:11 -0700)]
Conditionally run namedPipes tests in uap if windows version contains fix (dotnet/corefx#24307)
* Conditionally run namedPipes tests in uap if windows version contains fix
* PR Feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
161267c8645d4fd4cde51c3783d3c9326ed034f1
Frederik Carlier [Thu, 28 Sep 2017 19:18:37 +0000 (21:18 +0200)]
Use PlatformSpecific instead of ActiveIssue
Commit migrated from https://github.com/dotnet/corefx/commit/
29509cf8132796c46b06854c0242fd3c46e6e1b4
Eric StJohn [Thu, 28 Sep 2017 18:35:36 +0000 (11:35 -0700)]
Merge pull request dotnet/corefx#24310 from ericstj/disableGeneratingRuntimeJson
Disable automatic generation of runtime.json during the build
Commit migrated from https://github.com/dotnet/corefx/commit/
e4525ebb2fe351814cd7456a1a7e1e4423a514f3