platform/upstream/llvm.git
4 years ago[lldb][modules] Disable Clang Modules in source/Host directory on macOS
Raphael Isemann [Fri, 8 May 2020 16:13:43 +0000 (18:13 +0200)]
[lldb][modules] Disable Clang Modules in source/Host directory on macOS

Summary:
The arpa/inet.h header in macOS is providing an incorrect htonl
function with enabled local submodule visibility while building LLDB. This
caused several networking tests to fail as the IP addresses are now flipped
in LLDB.

This patch disables building with modules when local submodule visibility is
active and the current system is macOS for the source/Host directory (which
is the *only directory that includes arpa/inet.h).

* debugserver also includes arpa/inet.h but there we already disabled
modules.

Reviewers: aprantl

Reviewed By: aprantl

Subscribers: mgorny, JDevlieghere

Differential Revision: https://reviews.llvm.org/D79632

4 years ago[InstCombine] clean up foldItoFPtoI; NFC
Sanjay Patel [Fri, 8 May 2020 16:06:38 +0000 (12:06 -0400)]
[InstCombine] clean up foldItoFPtoI; NFC

Mostly cosmetic improvements to variable names and logic to ease
refactoring suggested in D79116.

4 years agoFix MSan test use-after-dtor.cpp under new pass manager
Arthur Eubanks [Thu, 7 May 2020 19:14:43 +0000 (12:14 -0700)]
Fix MSan test use-after-dtor.cpp under new pass manager

Summary: The new pass manager symbolizes the location as ~Simple instead of Simple::~Simple.

Reviewers: rnk, leonardchan, vitalybuka

Subscribers: #sanitizers

Tags: #sanitizers

Differential Revision: https://reviews.llvm.org/D79594

4 years agoAdd a flag that controls if clang-tidy and clang-include-fixer are built into libclang.
Nico Weber [Thu, 7 May 2020 21:05:42 +0000 (17:05 -0400)]
Add a flag that controls if clang-tidy and clang-include-fixer are built into libclang.

Based on the discussion on D55415, also make the flag default to false.
Having libclang depend on clang-tools-extra means check-clang builds all
of clang-tools-extra, which besides being a layering violation takes
quite some time, since clang-tools-extra has many files that are slow
to compile.

Longer term, we likely will want to remove this flag completely. If
people need this functionality, maybe there could be a
libclang-tools-extra that's libclang + clang-tidy and
clang-includes-fixer linked in.

Differential Revision: https://reviews.llvm.org/D79599

4 years agoRevert "[DebugInfo] Fix handling DW_OP_call_ref in DWARF64 units."
Krasimir Georgiev [Fri, 8 May 2020 15:14:12 +0000 (17:14 +0200)]
Revert "[DebugInfo] Fix handling DW_OP_call_ref in DWARF64 units."

This reverts commit 989ae9e848a079715c2d23e5d3622cac9b48e08e.

Newly added test fails:
FAIL: LLVM::DW_OP_call_ref_unexpected.s

http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/28298

4 years ago[mlir][spirv] Handle debuginfo for variables.
Denis Khalikov [Fri, 8 May 2020 11:56:58 +0000 (14:56 +0300)]
[mlir][spirv] Handle debuginfo for variables.

Summary:
Handle debuginfo for spv.Variable and spv.globalVariable during
(de)serialization.

Differential Revision: https://reviews.llvm.org/D79566

4 years agoAMDGPU/GlobalISel: Regenerate checks
Matt Arsenault [Fri, 8 May 2020 14:29:25 +0000 (10:29 -0400)]
AMDGPU/GlobalISel: Regenerate checks

Avoids extra diffs from the rename of G_GEP to G_PTR_ADD in the
generated check variables in a future patch.

4 years agoAMDGPU: Lower addrspacecast to 32-bit constant
Matt Arsenault [Thu, 7 May 2020 15:49:39 +0000 (11:49 -0400)]
AMDGPU: Lower addrspacecast to 32-bit constant

Somehow this was missing from the DAG path, but not global isel.

4 years ago[ELF] Add convenience TableGen classes to enforce two dashes for options not supporte...
Fangrui Song [Mon, 4 May 2020 21:42:36 +0000 (14:42 -0700)]
[ELF] Add convenience TableGen classes to enforce two dashes for options not supported by GNU ld

Announced on https://lists.llvm.org/pipermail/llvm-dev/2020-May/141416.html

For many options, we have to support either one or two dash to be
compatible with GNU ld. For newer and lld specific options, we can enforce strict double dashes.

Affected options:

* --thinlto-*
* --lto-*
* --shuffle-sections=

This patch does not change `-plugin-opt=*` because clang driver passes
`-plugin-opt=*` and I don't intend to cause churn.

In 2000, GNU ld tried something similar with --omagic
https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=e4897a3288f37d5f69e8acd256a6e83e607fe8d8

Reviewed By: tejohnson, psmith

Differential Revision: https://reviews.llvm.org/D79371

4 years ago[PatternMatch] add missing FP cast matchers; NFC
Sanjay Patel [Fri, 8 May 2020 13:56:59 +0000 (09:56 -0400)]
[PatternMatch] add missing FP cast matchers; NFC

These are the obvious counterparts to the existing cast matchers.
Moving out of D79116 to reduce that patch.

4 years ago[InstCombine] simplify code for FP to integer casts; NFCI
Sanjay Patel [Fri, 8 May 2020 13:05:41 +0000 (09:05 -0400)]
[InstCombine] simplify code for FP to integer casts; NFCI

FoldIToFPtoI() returns immediately if the operand is not
an opposite cast instruction, so the extra checks in the
callers are redundant.

4 years agoLiveIntervalCalc - remove unnecessary includes. NFC.
Simon Pilgrim [Fri, 8 May 2020 13:57:35 +0000 (14:57 +0100)]
LiveIntervalCalc - remove unnecessary includes. NFC.

As we're inheriting from LiveRangeCalc, all the headers are already explicitly required by LiveRangeCalc.h

4 years agoDFAEmitter.h - remove unnecessary headers. NFC.
Simon Pilgrim [Fri, 8 May 2020 13:53:10 +0000 (14:53 +0100)]
DFAEmitter.h - remove unnecessary headers. NFC.

Reduce StringRef.h include to forward declaration and add implicit SmallVector.h and <map> include dependencies.

4 years agoItaniumManglingCanonicalizer.h - add cstdint.h include for missing uintptr_t def
Simon Pilgrim [Fri, 8 May 2020 13:21:49 +0000 (14:21 +0100)]
ItaniumManglingCanonicalizer.h - add cstdint.h include for missing uintptr_t def

MSVC builds don't need it but everything else does.

4 years ago[ARM] Change test target to arm-none-none-eabi. NFC
David Green [Fri, 8 May 2020 12:30:04 +0000 (13:30 +0100)]
[ARM] Change test target to arm-none-none-eabi. NFC

4 years ago[libc++][test] Add test coverage for codecvt<char(16|32)_t, char8_t, mbstate_t>
Casey Carter [Thu, 7 May 2020 17:42:10 +0000 (10:42 -0700)]
[libc++][test] Add test coverage for codecvt<char(16|32)_t, char8_t, mbstate_t>

This change adds test coverage for the `codecvt<char16_t, char8_t, mbstate_t>` and `codecvt<char32_t, char8_t, mbstate_t>` ctype facets added to the C++20 WD by [P0482R6](https://wg21.link/P0428R6). Note that libc++ does not implement these facets despite implementing the remainder of P0482, presumably for ABI reasons, so these tests are marked `UNSUPPORTED: libc++`.

4 years ago[clangd] Update the new clangd url, NFC.
Haojian Wu [Fri, 8 May 2020 13:11:44 +0000 (15:11 +0200)]
[clangd] Update the new clangd url, NFC.

4 years agoCachePruning.h - reduce StringRef.h to Optional.h include. NFC
Simon Pilgrim [Fri, 8 May 2020 12:15:49 +0000 (13:15 +0100)]
CachePruning.h - reduce StringRef.h to Optional.h include. NFC

We only need to include Optional.h, forward declare StringRef and move the StringRef.h include down to CachePruning.cpp.

4 years agoItaniumManglingCanonicalizer - reduce StringRef.h include to forward declaration...
Simon Pilgrim [Fri, 8 May 2020 12:02:57 +0000 (13:02 +0100)]
ItaniumManglingCanonicalizer - reduce StringRef.h include to forward declaration + remove duplicate includes. NFC

4 years ago[lldb] Fix RecordDecl match string in module-ownership.mm to get the test running...
Raphael Isemann [Fri, 8 May 2020 12:43:16 +0000 (14:43 +0200)]
[lldb] Fix RecordDecl match string in module-ownership.mm to get the test running again

The relevant output FileCheck is scanning in this test is as follows:

    CXXRecordDecl 0x7f96cf8239c8 <<invalid sloc>> <invalid sloc> imported in A.B <undeserialized declarations> struct definition
    <<DefinitionData boilerplate>>
    `-FieldDecl 0x7f96cf823b90 <<invalid sloc>> <invalid sloc> imported in A.B anon_field_b 'int'
    (anonymous struct)
    CXXRecordDecl 0x7f96cf823be8 <<invalid sloc>> <invalid sloc> imported in A.B struct

Before 710fa2c4ee346e1ec2db66ac5fdf6909e79d9a8c this test was passing by
accident as it had a -DAG suffix in the checks changed by this patch,
causing FileCheck to first match the last line of the output above
(instead of the first one), and then finding the FieldDecl above.
When I removed the -DAG suffix, FileCheck actually enforced the ordering
and started failing as the FieldDecl comes before the CXXRecordDecl match
we get.

This patch fixes the CXXRecordDecl check to find the first line of the output
above which caused FileCheck to also find the FieldDecl that follows. Also
gives the FieldDecl a more unique name to make name collisions less likely.

4 years agoRevert "Recommit "[LV] Induction Variable does not remain scalar under tail-folding.""
Benjamin Kramer [Fri, 8 May 2020 12:48:17 +0000 (14:48 +0200)]
Revert "Recommit "[LV] Induction Variable does not remain scalar under tail-folding.""

This reverts commit ae45b4dbe73ffde5fe3119835aa947d5a49635ed. It
causes miscompilations, test case on the mailing list.

4 years ago[lldb] Prevent objc-root-class warning when compiling module-ownership.mm test
Raphael Isemann [Fri, 8 May 2020 12:40:57 +0000 (14:40 +0200)]
[lldb] Prevent objc-root-class warning when compiling module-ownership.mm test

This test was generating the following false-positive warning when being compiled:
 warning: class 'SomeClass' defined without specifying a base class [-Wobjc-root-class]

4 years ago[clangd] Fix crash in AddUsing tweak due to non-identifier DeclName
Adam Czachorowski [Fri, 8 May 2020 12:23:19 +0000 (14:23 +0200)]
[clangd] Fix crash in AddUsing tweak due to non-identifier DeclName

Patch by Adam Czachorowski!

Reviewers: hokein

Reviewed By: hokein

Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, kadircet, usaxena95, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D79582

4 years ago[lldb] Make module-ownership.mm test more robust against AST node ordering
Raphael Isemann [Fri, 8 May 2020 11:26:42 +0000 (13:26 +0200)]
[lldb] Make module-ownership.mm test more robust against AST node ordering

The current test is checking both the anonymous structs and the template
specializations in one FileCheck run, but the anonymous struct line can
partially match the AST dump of a template specialization, causing that
FileCheck won't match that same line later against the template specialization
check and incorrectly fails on that check. This only happens when the
template specialization node somehow ends up before the anonymous struct node.

This patch just puts the checks for the anonymous structs in their own FileCheck
run to prevent them from partially matching any other record decl.

Fixes rdar://62997926

4 years ago[X86][AVX] Don't let X86ISD::BROADCAST peek through bitcasts to illegal types.
Simon Pilgrim [Fri, 8 May 2020 11:30:33 +0000 (12:30 +0100)]
[X86][AVX] Don't let X86ISD::BROADCAST peek through bitcasts to illegal types.

This was an existing bug exposed by the more aggressive X86ISD::BROADCAST generation by rG8817334ce3c7

Original test case thanks to @mstorsjo

4 years agoRemarkStringTable.h - reduce StringRef/Remark includes to forward declarations. NFC
Simon Pilgrim [Fri, 8 May 2020 11:25:15 +0000 (12:25 +0100)]
RemarkStringTable.h - reduce StringRef/Remark includes to forward declarations. NFC

Move StringRef.h include down to RemarkStringTable.cpp and remove some unused includes there as well.

4 years ago[compiler-rt] Reduce the number of threads in gcov test to avoid failure
Calixte Denizet [Fri, 8 May 2020 09:04:17 +0000 (11:04 +0200)]
[compiler-rt] Reduce the number of threads in gcov test to avoid failure

Summary:
Patch in D78477 introduced a new test for gcov and this test is failing on arm:
 - http://lab.llvm.org:8011/builders/clang-cmake-thumbv7-full-sh/builds/4752/steps/ninja%20check%202/logs/stdio
  - http://lab.llvm.org:8011/builders/clang-cmake-armv7-full/builds/10501/steps/ninja%20check%202/logs/stdio
So try to fix it in reducing the number of threads.

Reviewers: marco-c

Reviewed By: marco-c

Subscribers: dberris, kristof.beyls, #sanitizers, serge-sans-paille, sylvestre.ledru

Tags: #sanitizers

Differential Revision: https://reviews.llvm.org/D79621

4 years agoRemark.h - reduce ArrayRef.h include to SmallVector.h. NFC.
Simon Pilgrim [Thu, 7 May 2020 17:06:23 +0000 (18:06 +0100)]
Remark.h - reduce ArrayRef.h include to SmallVector.h. NFC.

We only need to include SmallVector.h in Remark.h, and then the more bulky ArrayRef.h in Remark.cpp.

4 years agoAArch6/ARMTargetParser.h - move Triple.h dependency down to cpp file. NFC.
Simon Pilgrim [Thu, 7 May 2020 16:14:14 +0000 (17:14 +0100)]
AArch6/ARMTargetParser.h - move Triple.h dependency down to cpp file. NFC.

Reduce Triple.h include to a forward declaration in the header. Only the implementations in the cpp files need the actual Triple class definition.

4 years ago[MLIR] Add complex addition and substraction to the standard dialect
Frederik Gossen [Fri, 8 May 2020 09:49:48 +0000 (09:49 +0000)]
[MLIR] Add complex addition and substraction to the standard dialect

Complex addition and substraction are the first two binary operations on complex
numbers.
Remaining operations will follow the same pattern.

Differential Revision: https://reviews.llvm.org/D79479

4 years ago[clangd] NFC: Use deprecated grpc++ headers for compatibility
Kirill Bobyrev [Fri, 8 May 2020 09:01:34 +0000 (11:01 +0200)]
[clangd] NFC: Use deprecated grpc++ headers for compatibility

Summary:
Ubuntu 18.04 and older versions do not provide latest gRCP packages and the
ones that are in the repository use deprecated headers. Use these headers to
make builds possible.

https://packages.ubuntu.com/bionic/amd64/libgrpc++-dev/filelist

Reviewers: sammccall

Reviewed By: sammccall

Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, kadircet, usaxena95, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D79487

4 years agoFix a failing test.
Igor Kudrin [Fri, 8 May 2020 08:36:01 +0000 (15:36 +0700)]
Fix a failing test.

Differential Revision: https://reviews.llvm.org/D79501

4 years agoReapply [InstSimplify] Remove known bits constant folding
Nikita Popov [Fri, 20 Mar 2020 10:57:20 +0000 (11:57 +0100)]
Reapply [InstSimplify] Remove known bits constant folding

No changes relative to last time, but after a mitigation for
an AMDGPU regression landed.

---

If SimplifyInstruction() does not succeed in simplifying the
instruction, it will compute the known bits of the instruction
in the hope that all bits are known and the instruction can be
folded to a constant. I have removed a similar optimization
from InstCombine in D75801, and would like to drop this one as well.

On average, we spend ~1% of total compile-time performing this
known bits calculation. However, if we introduce some additional
statistics for known bits computations and how many of them succeed
in simplifying the instruction we get (on test-suite):

    instsimplify.NumKnownBits: 216
    instsimplify.NumKnownBitsComputed: 13828375
    valuetracking.NumKnownBitsComputed: 45860806

Out of ~14M known bits calculations (accounting for approximately
one third of all known bits calculations), only 0.0015% succeed in
producing a constant. Those cases where we do succeed to compute
all known bits will get folded by other passes like InstCombine
later. On test-suite, only lencod.test and GCC-C-execute-pr44858.test
show a hash difference after this change. On lencod we see an
improvement (a loop phi is optimized away), on the GCC torture
test a regression (a function return value is determined only
after IPSCCP, preventing propagation from a noinline function.)

There are various regressions in InstSimplify tests. However, all
of these cases are already handled by InstCombine, and corresponding
tests have already been added there.

Differential Revision: https://reviews.llvm.org/D79294

4 years ago[DebugInfo] Fix handling DW_OP_call_ref in DWARF64 units.
Igor Kudrin [Fri, 8 May 2020 08:02:20 +0000 (15:02 +0700)]
[DebugInfo] Fix handling DW_OP_call_ref in DWARF64 units.

DW_OP_call_ref is the only operation that has an operand which depends
on the DWARF format. The patch fixes handling that operation in DWARF64
units.

Differential Revision: https://reviews.llvm.org/D79501

4 years ago[DebugInfo] Fix printing values of forms which depend on the DWARF format.
Igor Kudrin [Fri, 8 May 2020 05:58:01 +0000 (12:58 +0700)]
[DebugInfo] Fix printing values of forms which depend on the DWARF format.

The values are 8 bytes long in DWARF64, so they should not be truncated
to uint32_t on dumping.

Differential Revision: https://reviews.llvm.org/D79093

4 years ago[AMDGPU] Try to determine sign bit during div/rem expansion
Nikita Popov [Thu, 7 May 2020 20:42:18 +0000 (22:42 +0200)]
[AMDGPU] Try to determine sign bit during div/rem expansion

This is preparation for D79294, which removes an expensive
InstSimplify optimization, on the assumption that it will be
picked up by InstCombine instead. Of course, this does not hold
up if a backend performs non-trivial IR expansions without running
a canonicalization pipeline afterwards, which turned up as an
issue in the context of AMDGPU div/rem expansion.

This patch mitigates the issue by explicitly performing a known
bits calculation where it matters. No test changes, as those would
only be visible after the other patch lands.

Differential Revision: https://reviews.llvm.org/D79596

4 years ago[mlir] Updated SideEffect interface definitions to use tablegen Resource objects.
Marcel Koester [Mon, 27 Apr 2020 11:46:04 +0000 (13:46 +0200)]
[mlir] Updated SideEffect interface definitions to use tablegen Resource objects.

The SideEffect interface definitions currently use string expressions to
reference custom resource objects. This CL introduces Resource objects in
tablegen definitions to simplify linking of resource reference to resource
objects.

Differential Revision: https://reviews.llvm.org/D78917

4 years ago[X86] Add v32i8 and v64i8 tests to vec_smulo.ll and vec_umulo.ll. NFC
Craig Topper [Fri, 8 May 2020 05:16:23 +0000 (22:16 -0700)]
[X86] Add v32i8 and v64i8 tests to vec_smulo.ll and vec_umulo.ll. NFC

I was look at our vXi8 handling in LowerMULH and noticed that
vXi8 mulo uses but we don't test all types.

4 years ago [flang]Semantics for SELECT RANK.
sameeran joshi [Wed, 22 Apr 2020 09:16:37 +0000 (14:46 +0530)]
[flang]Semantics for SELECT RANK.

    Summary:
    Initially on github I worked on semantic checks.Then I tried some compile-time
    test of the rank value, they were failing as there were no symbols
    generated for them inside SELECT RANK's scope.So I went further to
    add new symbol in each scope, also added the respective 'rank: '
    field for a symbol when we dump the symboltable. I added a field to
    keep track of the rank in AssocEntityDetails class.This caused shape
    analysis framework to become inconsistent. So shape analysis framework
    was updated to handle this new representation.

 *   I added more tests for above changes.

 *   On phabricator I addressed some minor changes.

 *   Lastly I worked on review comments.

    Reviewers: klausler,sscalpone,DavidTruby,kiranchandramohan,tskeith,anchu-rajendran,kiranktp

    Reviewed By:klausler, DavidTruby, tskeith

    Subscribers:#flang-commits, #llvm-commits

    Tags: #flang, #llvm

    Differential Revision: https://reviews.llvm.org/D78623

4 years agoFix false positive with -Wnon-c-typedef-for-linkage
Weverything [Fri, 8 May 2020 01:47:19 +0000 (18:47 -0700)]
Fix false positive with -Wnon-c-typedef-for-linkage

Implicit methods for structs can confuse the warning, so exclude checking
the Decl's that are implicit. Implicit Decl's for lambdas still need to
be checked, so skipping all implicit Decl's won't work.

Differential Revision: https://reviews.llvm.org/D79548

4 years ago[llvm] [CodeGen] Fixed vector halving bug for masked store
aartbik [Fri, 8 May 2020 01:39:10 +0000 (18:39 -0700)]
[llvm] [CodeGen] Fixed vector halving bug for masked store

Summary:
Note that this fix is very similar to what has already been
done for the masked load in https://reviews.llvm.org/D78608

Bugs:
https://bugs.llvm.org/show_bug.cgi?id=45563
https://bugs.llvm.org/show_bug.cgi?id=45833

Reviewers: craig.topper, nicolasvasilache, mehdi_amini

Reviewed By: craig.topper

Subscribers: hiraditya, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D79611

4 years agoAdd a new lockdownd plist for launching posix processes
Jason Molenda [Fri, 8 May 2020 01:52:10 +0000 (18:52 -0700)]
Add a new lockdownd plist for launching posix processes

Similar to
com.apple.debugserver.plist & com.apple.debugserver.internal.plist
com.apple.debugserver.applist.plist & com.apple.debugserver.applist.internal.plist
add a variant of the posix plist.

<rdar://problem/62995567>

4 years ago[Object] Remove unneeded check in ELFFile<ELFT>::dynamicEntries().
Xing GUO [Fri, 8 May 2020 01:54:08 +0000 (09:54 +0800)]
[Object] Remove unneeded check in ELFFile<ELFT>::dynamicEntries().

Check for `DynSecSize % sizeof(Elf_Dyn) != 0` is unneeded in this context.

1. If the .dynamic section is acquired from program headers, the .dynamic
section is "cut off" by

```
makeArrayRef(..., Phdr.p_filesz / sizeof(Elf_Dyn));
DynSeSize = Phdr.p_filesz;
```

2. If the .dynamic section is acquired from section headers, the .dynamic
section is checked in `getSectionContentsAsArray<Elf_Dyn>(&Sec)`.

Reviewed By: MaskRay

Differential Revision: https://reviews.llvm.org/D79560

4 years agoUniuqe Names for Internal Linkage Symbols.
Sriraman Tallam [Fri, 8 May 2020 01:18:37 +0000 (18:18 -0700)]
Uniuqe Names for Internal Linkage Symbols.

This is a standalone patch and this would help Propeller do a better job of code
layout as it can accurately attribute the profiles to the right internal linkage
function.

This also helps SampledFDO/AutoFDO correctly associate sampled profiles to the
right internal function. Currently, if there is more than one internal symbol
foo, their profiles are aggregated by SampledFDO.

This patch adds a new clang option, -funique-internal-funcnames, to generate
unique names for functions with internal linkage. This patch appends the md5
hash of the module name to the function symbol as a best effort to generate a
unique name for symbols with internal linkage.

Differential Revision: https://reviews.llvm.org/D73307

4 years ago[LoopFusion] Remove unreachable blocks from DT and LI after fusion
Diego Caballero [Tue, 21 Apr 2020 19:10:55 +0000 (22:10 +0300)]
[LoopFusion] Remove unreachable blocks from DT and LI after fusion

This patch removes FC0.ExitBlock and FC1GuardBlock from DT and LI
after fusion of guarded loops. They become unreachable and LI
verification failed when they happened to be inside another loop.

Reviewed By: kbarton

Differential Revision: https://reviews.llvm.org/D78679

4 years agoRevert "[YAMLVFSWriter][Test][NFC] Add couple tests"
Nico Weber [Thu, 7 May 2020 23:07:08 +0000 (19:07 -0400)]
Revert "[YAMLVFSWriter][Test][NFC] Add couple tests"

This reverts commit 7143d7925490e9123b1c93305700221584ba10c6.
Breaks check-llvm on Windows, see e.g.
http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds/15919/steps/stage%201%20check/logs/stdio

4 years agoCorrectly modify the CFG in IfConverter, and then remove the
James Y Knight [Thu, 20 Feb 2020 06:16:13 +0000 (01:16 -0500)]
Correctly modify the CFG in IfConverter, and then remove the
CorrectExtraCFGEdges function.

The latter was a workaround for "Various pieces of code" leaving bogus
extra CFG edges in place. Where by "various" it meant only
IfConverter::MergeBlocks, which failed to clear all of the successors
of dead blocks it emptied out. This wouldn't matter a whole lot,
except that the dead blocks remained listed as predecessors of
still-useful blocks, inhibiting optimizations.

This fix slightly changed two thumb tests, because the correct CFG
successors allowed for the "diamond" if-conversion pattern to be
detected, when it could only use "simple" before.

Additionally, the removal of a now-redundant call to analyzeBranch
(with AllowModify=true) in BranchFolder::OptimizeFunction caused a
later check for an empty block in BranchFolder::OptimizeBlock to
fail. Correct this by moving the call to analyzeBranch in
OptimizeBlock higher.

Differential Revision: https://reviews.llvm.org/D79527

4 years ago[lldb/Test] Skip more tests that are not expected to work with passive replay
Jonas Devlieghere [Thu, 7 May 2020 22:13:18 +0000 (15:13 -0700)]
[lldb/Test] Skip more tests that are not expected to work with passive replay

This skips some tests that pass with active replay (which doesn't check
the output) but fail with passive replay. Valid reasons for this
include:

 - Checking the output of the process (which doesn't run during replay),
 - Checking files that cannot be captured in the VFS (non-existing or
   unreadable files or files that are removed during test),

Unfortunately there's no good way to mark a test as supported for active
replay but unsupported for passive replay because the number and order
of API calls needs to be identical during capture and replay. I don't
think this is a huge loss however.

4 years ago[Attributor][FIX] Record dependences for assumed dead abstract attributes
Johannes Doerfert [Thu, 7 May 2020 21:50:50 +0000 (16:50 -0500)]
[Attributor][FIX] Record dependences for assumed dead abstract attributes

In a recent patch we introduced a problem with abstract attributes that
were assumed dead at some point. Since `Attributor::updateAA` was
introduced in 95e0d28b71e42c9b7cd77c96f728311981a021f6, we did not
remember the dependence on the liveness AA when an abstract attribute
was assumed dead and therefore not updated.

Explicit reproducer added in liveness.ll.

---

Single run of the Attributor module and then CGSCC pass (oldPM)
for SPASS/clause.c (~10k LLVM-IR loc):

Before:
```
calls to allocation functions: 509242 (345483/s)
temporary memory allocations: 98666 (66937/s)
peak heap memory consumption: 18.60MB
peak RSS (including heaptrack overhead): 103.29MB
total memory leaked: 269.10KB
```

After:
```
calls to allocation functions: 529332 (355494/s)
temporary memory allocations: 102107 (68574/s)
peak heap memory consumption: 19.40MB
peak RSS (including heaptrack overhead): 102.79MB
total memory leaked: 269.10KB
```

Difference:
```
calls to allocation functions: 20090 (1339333/s)
temporary memory allocations: 3441 (229400/s)
peak heap memory consumption: 801.45KB
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B
```

4 years ago[Attributor] Mark dependence as optional
Johannes Doerfert [Thu, 7 May 2020 21:47:57 +0000 (16:47 -0500)]
[Attributor] Mark dependence as optional

4 years ago[libc++] ECMAScript IdentityEscape is ambiguous (2584)
zoecarver [Thu, 7 May 2020 21:26:25 +0000 (14:26 -0700)]
[libc++] ECMAScript IdentityEscape is ambiguous (2584)

This patch fixes [[ https://cplusplus.github.io/LWG/issue2584 | 2584 ]]. Now the following works:
    const std::regex r1("\\z");
    assert(std::regex_match("z", r1));

Differential Revision: https://reviews.llvm.org/D66610

4 years agogetMainExecutable: Fix hand-rolled AT_EXECPATH for older FreeBSD
Ed Maste [Thu, 7 May 2020 18:57:11 +0000 (14:57 -0400)]
getMainExecutable: Fix hand-rolled AT_EXECPATH for older FreeBSD

Once we hit AT_NULL, we need to bail out of the loop; not just the
enclosing switch.  This fixes basic usage (e.g. `cc --version`) when
AT_EXECPATH isn't present on older branches (e.g. under
emu-user-static, at the moment), where we would previously run off
the end of ::environ.

Patch By: kevans

Reviewed By: arichardson

Differential Revision: https://reviews.llvm.org/D79239

4 years ago[libcxx] [NFC] fpos Requirements (p0759r1).
zoecarver [Thu, 7 May 2020 21:01:58 +0000 (14:01 -0700)]
[libcxx] [NFC] fpos Requirements (p0759r1).

Implements p0759r1. Test-only change. Adds explicit test for table 106 and type checking.

Differential Review: https://reviews.llvm.org/D60491

4 years ago[clang-format] [PR45639] clang-format splits up the brackets of C++17 attribute ...
mydeveloperday [Thu, 7 May 2020 20:57:14 +0000 (21:57 +0100)]
[clang-format] [PR45639] clang-format splits up the brackets of C++17 attribute [[ ]] when used with the first parameter

Summary:
https://bugs.llvm.org/show_bug.cgi?id=45639

clang-format incorrectly splits the `[[` in a long argument list

```
void SomeLongClassName::ALongMethodNameInThatClass([[maybe_unused]] const shared_ptr<ALongTypeName>& argumentNameForThat
LongType) {

}
```

becomes

```
void SomeLongClassName::ALongMethodNameInThatClass([
    [maybe_unused]] const shared_ptr<ALongTypeName> &argumentNameForThatLongType) {

}
```

leaving one `[` on the previous line

For a function with just 1 very long argument, clang-format chooses to split between the `[[`,

This revision prevents the slip between the two `[` and the second `[`

Reviewed By: krasimir

Subscribers: cfe-commits

Tags: #clang, #clang-format

Differential Revision: https://reviews.llvm.org/D79401

4 years ago[SimpleLoopUnswitch] Update DefaultExit condition to check unreachable is not empty.
Alina Sbirlea [Thu, 16 Apr 2020 04:49:00 +0000 (21:49 -0700)]
[SimpleLoopUnswitch] Update DefaultExit condition to check unreachable is not empty.

Summary:
Update the check for the default exit block to not only check that the
terminator is not unreachable, but also check that unreachable block has
*only* the unreachable instruction.

Reviewers: chandlerc

Subscribers: hiraditya, uabelho, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D78277

4 years agoRemove unused _LIBCPP_RAW_ITERATORS
Marcel Hlopko [Thu, 7 May 2020 20:14:26 +0000 (22:14 +0200)]
Remove unused _LIBCPP_RAW_ITERATORS

Summary: This change removes seemingly unused _LIBCPP_RAW_ITERATORS.

Reviewers: #libc, EricWF, ldionne

Reviewed By: #libc, EricWF, ldionne

Subscribers: dexonsmith, ldionne, gribozavr2, libcxx-commits

Tags: #libc

Differential Revision: https://reviews.llvm.org/D79323

4 years agoEnsure aux-target specific builtins get validated.
Erich Keane [Thu, 7 May 2020 16:28:10 +0000 (09:28 -0700)]
Ensure aux-target specific builtins get validated.

I discovered that when using an aux-target builtin, it was recognized as
a builtin but never checked. This patch checks for an aux-target builtin
and instead validates it against the correct target.

It does this by extracting the checking code for Target-specific
builtins into its own function, then calls with either targetInfo or
AuxTargetInfo.

4 years ago[VectorCombine] adjust test to make intent clearer; NFC
Sanjay Patel [Thu, 7 May 2020 20:08:43 +0000 (16:08 -0400)]
[VectorCombine] adjust test to make intent clearer; NFC

Create a non-zero result to show that the other lane is computed correctly.

4 years ago[NFC] Adjust test check lines for D78267.
Huihui Zhang [Thu, 7 May 2020 20:18:09 +0000 (13:18 -0700)]
[NFC] Adjust test check lines for D78267.

This wasn't identified through buildbot before.

4 years agoAllow -fsanitize-minimal-runtime with memtag sanitizer.
Evgenii Stepanov [Tue, 14 Apr 2020 21:38:10 +0000 (14:38 -0700)]
Allow -fsanitize-minimal-runtime with memtag sanitizer.

Summary:
MemTag does not have any runtime at the moment, it's strictly code
instrumentation.

Reviewers: pcc

Subscribers: cryptoad, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D79522

4 years ago[InstCombine][SVE] Fix visitExtractElementInst for scalable type.
Huihui Zhang [Thu, 7 May 2020 20:03:26 +0000 (13:03 -0700)]
[InstCombine][SVE] Fix visitExtractElementInst for scalable type.

Summary:
This patch fix the following issues with visitExtractElementInst:

      1. Restrict VectorUtils::findScalarElement to fixed-length vector.
         For scalable type, the number of elements in shuffle mask is
         unknown at compile-time.
      2. Fix out-of-range calculation for fixed-length vector.
      3. Skip scalable type when analysis rely on fixed number of elements.
      4. Add unit tests to check functionality of extractelement for scalable type.

Reviewers: sdesmalen, efriedma, spatel, nikic

Reviewed By: efriedma

Subscribers: tschuett, hiraditya, rkruppe, psnobl, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D78267

4 years agoMake -Wnonportable-include-path ignore drive case on Windows.
Nico Weber [Thu, 7 May 2020 00:19:14 +0000 (20:19 -0400)]
Make -Wnonportable-include-path ignore drive case on Windows.

See PR45812 for motivation.

No explicit test since I couldn't figure out how to get the
current disk drive in lower case into a form in lit where I could
mkdir it and cd to it. But the change does have test coverage in
that I can remove the case normalization in lit, and tests failed
on several bots (and for me locally if in a pwd with a lower-case
drive) without that normalization prior to this change.

Differential Revision: https://reviews.llvm.org/D79531

4 years agoAdd static assert to ID Table to make sure aux targets work right.
Erich Keane [Thu, 7 May 2020 19:11:03 +0000 (12:11 -0700)]
Add static assert to ID Table to make sure aux targets work right.

I discovered that the limit on possible builtins managed by this
ObjCOrBuiltin variable is too low when combining large targets, since
aux-targets are appended to the targets list. A runtime assert exists
for this, however this patch creates a static-assert as well.

The logic for said static-assert is to make sure we have the room for
the aux-target and target to both be the largest list, which makes sure
we have room for all possible combinations.

I also incremented the number of bits by 1, since I discovered this
currently broken.  The current bit-count was 36, so this doesn't
increase any size.

4 years ago[InstCombine][SVE] Fix visitInsertElementInst for scalable type.
Huihui Zhang [Thu, 7 May 2020 19:43:14 +0000 (12:43 -0700)]
[InstCombine][SVE] Fix visitInsertElementInst for scalable type.

Summary:
This patch fixes the following issues in visitInsertElementInst:

      1. Bail out for scalable type when analysis requires fixed size number of vector elements.
      2. Use cast<FixedVectorType> to get vector number of elements. This ensure assertion
          on scalable vector type.
      3. For scalable type, avoid folding a chain of insertelement into splat:
            insertelt(insertelt(insertelt(insertelt X, %k, 0), %k, 1), %k, 2) ...
              ->
            shufflevector(insertelt(X, %k, 0), undef, zero)
          The length of scalable vector is unknown at compile-time, therefore we don't know if
          given insertelement sequence is valid for splat.

Reviewers: sdesmalen, efriedma, spatel, nikic

Reviewed By: sdesmalen, efriedma

Subscribers: tschuett, hiraditya, rkruppe, psnobl, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D78895

4 years ago[mlir] Add NamedAttrList
Jacques Pienaar [Wed, 6 May 2020 20:48:36 +0000 (13:48 -0700)]
[mlir] Add NamedAttrList

This is a wrapper around vector of NamedAttributes that keeps track of whether sorted and does some minimal effort to remain sorted (doing more, e.g., appending attributes in sorted order, could be done in follow up). It contains whether sorted and if a DictionaryAttr is queried, it caches the returned DictionaryAttr along with whether sorted.

Change MutableDictionaryAttr to always return a non-null Attribute even when empty (reserve null cases for errors). To this end change the getter to take a context as input so that the empty DictionaryAttr could be queried. Also create one instance of the empty dictionary attribute that could be reused without needing to lock context etc.

Update infer type op interface to use DictionaryAttr and use NamedAttrList to avoid incurring multiple conversion costs.

Fix bug in sorting helper function.

Differential Revision: https://reviews.llvm.org/D79463

4 years ago[VectorCombine] add tests with undefs; NFC
Sanjay Patel [Thu, 7 May 2020 19:23:37 +0000 (15:23 -0400)]
[VectorCombine] add tests with undefs; NFC

Goes with D79452.

4 years agoAMDGPU: Fix broken tests for HSA metadata
Matt Arsenault [Thu, 7 May 2020 18:26:14 +0000 (14:26 -0400)]
AMDGPU: Fix broken tests for HSA metadata

These were testing byval private kernel arguments, which doesn't make
any sense and has never been used. There didn't seem to be any tests
for real value struct arguments, which are.

4 years ago[SLP] add another bailout for load-combine patterns (2nd try)
Sanjay Patel [Thu, 7 May 2020 19:00:23 +0000 (15:00 -0400)]
[SLP] add another bailout for load-combine patterns (2nd try)

The original patch (rG86dfbc676ebe) exposed an existing bug:
we could wrongly cast a constant expression to BinaryOperator
because the pattern matching allows that. This adds a check
for that case, and there's a reduced test case to verify no
crashing.

Original commit message:

This builds on the or-reduction bailout that was added with D67841.
We still do not have IR-level load combining, although that could
be a target-specific enhancement for -vector-combiner.

The heuristic is narrowly defined to catch the motivating case from
PR39538:
https://bugs.llvm.org/show_bug.cgi?id=39538
...while preserving existing functionality.

That is, there's an unmodified test of pure load/zext/store that is
not seen in this patch at llvm/test/Transforms/SLPVectorizer/X86/cast.ll.
That's the reason for the logic difference to require the 'or'
instructions. The chances that vectorization would actually help a
memory-bound sequence like that seem small, but it looks nicer with:

  vpmovzxwd     (%rsi), %xmm0
  vmovdqu       %xmm0, (%rdi)

rather than:

  movzwl        (%rsi), %eax
  movl  %eax, (%rdi)
  ...

In the motivating test, we avoid creating a vector mess that is
unrecoverable in the backend, and SDAG forms the expected bswap
instructions after load combining:

  movzbl (%rdi), %eax
  vmovd %eax, %xmm0
  movzbl 1(%rdi), %eax
  vmovd %eax, %xmm1
  movzbl 2(%rdi), %eax
  vpinsrb $4, 4(%rdi), %xmm0, %xmm0
  vpinsrb $8, 8(%rdi), %xmm0, %xmm0
  vpinsrb $12, 12(%rdi), %xmm0, %xmm0
  vmovd %eax, %xmm2
  movzbl 3(%rdi), %eax
  vpinsrb $1, 5(%rdi), %xmm1, %xmm1
  vpinsrb $2, 9(%rdi), %xmm1, %xmm1
  vpinsrb $3, 13(%rdi), %xmm1, %xmm1
  vpslld $24, %xmm0, %xmm0
  vpmovzxbd %xmm1, %xmm1 # xmm1 = xmm1[0],zero,zero,zero,xmm1[1],zero,zero,zero,xmm1[2],zero,zero,zero,xmm1[3],zero,zero,zero
  vpslld $16, %xmm1, %xmm1
  vpor %xmm0, %xmm1, %xmm0
  vpinsrb $1, 6(%rdi), %xmm2, %xmm1
  vmovd %eax, %xmm2
  vpinsrb $2, 10(%rdi), %xmm1, %xmm1
  vpinsrb $3, 14(%rdi), %xmm1, %xmm1
  vpinsrb $1, 7(%rdi), %xmm2, %xmm2
  vpinsrb $2, 11(%rdi), %xmm2, %xmm2
  vpmovzxbd %xmm1, %xmm1 # xmm1 = xmm1[0],zero,zero,zero,xmm1[1],zero,zero,zero,xmm1[2],zero,zero,zero,xmm1[3],zero,zero,zero
  vpinsrb $3, 15(%rdi), %xmm2, %xmm2
  vpslld $8, %xmm1, %xmm1
  vpmovzxbd %xmm2, %xmm2 # xmm2 = xmm2[0],zero,zero,zero,xmm2[1],zero,zero,zero,xmm2[2],zero,zero,zero,xmm2[3],zero,zero,zero
  vpor %xmm2, %xmm1, %xmm1
  vpor %xmm1, %xmm0, %xmm0
  vmovdqu %xmm0, (%rsi)

  movl  (%rdi), %eax
  movl  4(%rdi), %ecx
  movl  8(%rdi), %edx
  movbel        %eax, (%rsi)
  movbel        %ecx, 4(%rsi)
  movl  12(%rdi), %ecx
  movbel        %edx, 8(%rsi)
  movbel        %ecx, 12(%rsi)

Differential Revision: https://reviews.llvm.org/D78997

4 years ago[SLP] add test for constant expression fake of load-combine pattern; NFC
Sanjay Patel [Thu, 7 May 2020 18:53:57 +0000 (14:53 -0400)]
[SLP] add test for constant expression fake of load-combine pattern; NFC

This is a reduction of the test that caused D78997 to be reverted.

4 years ago[BFI][CGP] Add limited support for detecting missed BFI updates and fix one in CodeGe...
Hiroshi Yamauchi [Fri, 3 Apr 2020 17:40:26 +0000 (10:40 -0700)]
[BFI][CGP] Add limited support for detecting missed BFI updates and fix one in CodeGenPrepare.

Summary:
This helps detect some missed BFI updates during CodeGenPrepare.

This is debug build only and disabled behind a flag.

Fix a missed update in CodeGenPrepare::dupRetToEnableTailCallOpts().

Reviewers: davidxl

Subscribers: hiraditya, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D77417

4 years ago[libc] Fix warnings on release build.
Paula Toth [Thu, 7 May 2020 18:55:29 +0000 (11:55 -0700)]
[libc] Fix warnings on release build.

Summary:
These warnings were present when building llvm-libc in release mode.

```
workspace/llvm-project/libc/utils/benchmarks/LibcMemoryBenchmarkTest.cpp:50:34: warning: 'None' is deprecated: Use Align() or Align(1) instead [-Wdeprecated-declarations]
  Conf.AddressAlignment = Align::None();

workspace/llvm-project/libc/utils/testutils/FDReaderUnix.cpp:19:7: warning: unused variable 'err' [-Wunused-variable]
  int err = ::pipe(pipefd);
```

For test-utils it seems in general we should use `report_fatal_error` instead of asserts as these are turned off when building in release mode.
https://llvm.org/docs/CodingStandards.html#assert-liberally

Reviewers: abrachet, sivachandra

Reviewed By: abrachet, sivachandra

Subscribers: tschuett, libc-commits

Tags: #libc-project

Differential Revision: https://reviews.llvm.org/D79469

4 years ago[lldb/Test] Fix typo in find-and-replace.
Jonas Devlieghere [Thu, 7 May 2020 18:53:57 +0000 (11:53 -0700)]
[lldb/Test] Fix typo in find-and-replace.

4 years ago[clang-format] [PR45791] BeforeLambdaBody is confused by comment inside lambda
mydeveloperday [Thu, 7 May 2020 18:53:56 +0000 (19:53 +0100)]
[clang-format] [PR45791] BeforeLambdaBody is confused by comment inside lambda

Summary:
https://bugs.llvm.org/show_bug.cgi?id=45791

Lambda with line comment is incorrectly formatted

```
auto k = []() // comment
{ return; };
````

```
auto k = []() // comment { return; };
```

Reviewed By: Wawha

Subscribers: cfe-commits

Tags: #clang, #clang-format

Differential Revision: https://reviews.llvm.org/D79320

4 years ago[clang-format] ensure dump_format_style.py works with Python3 correctly
mydeveloperday [Thu, 7 May 2020 18:52:12 +0000 (19:52 +0100)]
[clang-format] ensure dump_format_style.py works with Python3 correctly

Summary:
Python2 has been removed from cygwin, this means anyone running the dump_format_style.py in a cygwin shell could pick up python3 instead

In Python3 all strings are unicode as the file is opened in binary mode we need to encode the contents string or we'll face the following error

```
Traceback (most recent call last):
  File "./dump_format_style.py", line 228, in <module>
    output.write(contents)
TypeError: a bytes-like object is required, not 'str'
```

Reviewed By: krasimir

Subscribers: cfe-commits

Tags: #clang, #clang-format

Differential Revision: https://reviews.llvm.org/D79326

4 years ago[clang-format] [PR45126] Help text is missing all available formats
mydeveloperday [Thu, 7 May 2020 18:50:21 +0000 (19:50 +0100)]
[clang-format] [PR45126] Help text is missing all available formats

Summary:
https://bugs.llvm.org/show_bug.cgi?id=45126

GNU and Microsoft styles are built in supported styles but are not displayed in the help text

Reviewed By: sammccall

Subscribers: cfe-commits

Tags: #clang, #clang-format

Differential Revision: https://reviews.llvm.org/D79372

4 years ago [flang]Add examples in documentation/BijectiveInternalNameUniquing.md
sameeran joshi [Tue, 5 May 2020 20:11:58 +0000 (01:41 +0530)]
[flang]Add examples in documentation/BijectiveInternalNameUniquing.md

    Summary:
    I thought it would be simpler to understand on how the unique names would
    look like when an example is present. So I added some examples.

    I found 2 such places to add examples
    -Common blocks
    -Module scope global data

    Reviewers: schweitz, kiranchandramohan, sscalpone, jeanPerier, jdoerfert, DavidTruby

    Reviewed By: schweitz, jeanPerier

    Subscribers: llvm-commits, flang-commits

    Tags: #flang, #llvm

    Differential Revision: https://reviews.llvm.org/D79442

4 years agoAdd a function to detect whether an Xcode SDK supports Swift
Adrian Prantl [Thu, 7 May 2020 01:02:44 +0000 (18:02 -0700)]
Add a function to detect whether an Xcode SDK supports Swift

Differential Revision: https://reviews.llvm.org/D79535

4 years ago[lldb/Test] Add @skipIfReproducer to tests using lldb::FileSP.
Jonas Devlieghere [Thu, 7 May 2020 18:15:58 +0000 (11:15 -0700)]
[lldb/Test] Add @skipIfReproducer to tests using lldb::FileSP.

lldb::FileSP is a typedef for std::shared_ptr<lldb_private::File> and
the reproducers cannot instrument a lldb_private constructor.

4 years agoAdd an XcodeSDK::GetSDKTypeForTriple function
Adrian Prantl [Thu, 7 May 2020 17:53:50 +0000 (10:53 -0700)]
Add an XcodeSDK::GetSDKTypeForTriple function

This is something used in swift-lldb, but of general usefulness.

Differential Revision: https://reviews.llvm.org/D79538

<rdar://problem/62684906>

4 years ago[YAMLVFSWriter][Test][NFC] Add couple tests
Jan Korous [Wed, 6 May 2020 19:15:49 +0000 (12:15 -0700)]
[YAMLVFSWriter][Test][NFC] Add couple tests

Differential Revision: https://reviews.llvm.org/D79552

4 years ago[mlir] Remove unnecessary DEPENDS for MLIRMlirOptMain
Lei Zhang [Thu, 7 May 2020 13:47:27 +0000 (09:47 -0400)]
[mlir] Remove unnecessary DEPENDS for MLIRMlirOptMain

https://github.com/llvm/llvm-project/commit/c296d2dc53d5c11c
fixes the dependency issue by turning LINK_LIBS to PUBLIC.
These explicit DEPENDS are not needed anymore.

Differential Revision: https://reviews.llvm.org/D79574

4 years ago[YAMLVFSWriter] Fix directory handling
Jan Korous [Wed, 6 May 2020 06:45:49 +0000 (23:45 -0700)]
[YAMLVFSWriter] Fix directory handling

For empty directories (except the first one) we've been adding a file
with the same name as the directory to the result VFS mapping.

Differential Revision: https://reviews.llvm.org/D79551

4 years ago[mlir][vulkan-runner] Remove duplicated/uncessary link libraries
Lei Zhang [Thu, 7 May 2020 14:31:19 +0000 (10:31 -0400)]
[mlir][vulkan-runner] Remove duplicated/uncessary link libraries

vulkan-runtime-wrappers does not need MLIRSPIRVSerialization,
which is used by the ConvertGpuLaunchFuncToVulkanLaunchFunc pass
under the hood.

Differential Revision: https://reviews.llvm.org/D79577

4 years ago[libc++] Fix ostream for complex numbers with fixed field width
Antonio Sanchez [Thu, 7 May 2020 17:49:12 +0000 (13:49 -0400)]
[libc++] Fix ostream for complex numbers with fixed field width

The ostream operator<< is currently broken for std::complex with
specified field widths.

This patch a partial revert of c3478eff7a65 (reviewed as D71214),
restoring the correct behavior.

Differential Revision: https://reviews.llvm.org/D78816

4 years agoReuse existing functionality in XcodeSDK::SDKSupportsModules (NFC)
Adrian Prantl [Thu, 7 May 2020 00:20:15 +0000 (17:20 -0700)]
Reuse existing functionality in XcodeSDK::SDKSupportsModules (NFC)

Differential Revision: https://reviews.llvm.org/D79533

4 years ago[YAMLVFSWriter][Tests] Fix YAMLVFSWriterTest
Jan Korous [Wed, 6 May 2020 05:03:37 +0000 (22:03 -0700)]
[YAMLVFSWriter][Tests] Fix YAMLVFSWriterTest

Differential Revision: https://reviews.llvm.org/D79550

4 years ago[libc++] NFC: Port type_info tests to C++03
Louis Dionne [Thu, 7 May 2020 17:41:45 +0000 (13:41 -0400)]
[libc++] NFC: Port type_info tests to C++03

4 years ago[dsymutil] Avoid relocating DW_AT_call_pc twice
Vedant Kumar [Thu, 7 May 2020 01:06:40 +0000 (18:06 -0700)]
[dsymutil] Avoid relocating DW_AT_call_pc twice

Summary:
Avoid relocating DW_AT_call_pc, e.g. when a call PC is equal to the
function's low_pc as is the case in the test:

```
__Z5func1v:
0000000100007f94        b       __Z5func2v
```

rdar://62952440

Reviewers: friss, JDevlieghere

Subscribers: hiraditya, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D79536

4 years ago[libc++] chrono: check _POSIX_TIMERS before using clock_gettime
Mara Sophie Grosch [Thu, 7 May 2020 16:10:33 +0000 (12:10 -0400)]
[libc++] chrono: check _POSIX_TIMERS before using clock_gettime

clock_gettime is documented to be available when _POSIX_TIMERS is
defined. Add a check for this.

Differential Revision: https://reviews.llvm.org/D79305

4 years ago[lldb/Reproducers] Make DoConnectRemote connect to the replay server.
Jonas Devlieghere [Thu, 7 May 2020 17:02:08 +0000 (10:02 -0700)]
[lldb/Reproducers] Make DoConnectRemote connect to the replay server.

All entry points into ProcessGDBRemote that connect to the debug server
should connect to the replay server instead during reproducer replay.
This patch adds the necessary logic for ConnectRemote, which is
accessible from the SB API. This fixes active replay for
TestRecognizeBreakpoint.py as described in D78588.

4 years ago[ModuloSchedule] Fix epilogue peeling with illegal phi.
Thomas Raoux [Thu, 7 May 2020 15:30:00 +0000 (08:30 -0700)]
[ModuloSchedule] Fix epilogue peeling with illegal phi.

When peeling out the epilogue we need to ignore illegal phis coming from stages
greater than the producer stage. Otherwise we end up with circular phi
dependencies.

Differential Revision: https://reviews.llvm.org/D79581

4 years ago[libc++][test] Adjust move_iterator tests to allow C++20
Casey Carter [Thu, 7 May 2020 16:58:13 +0000 (09:58 -0700)]
[libc++][test] Adjust move_iterator tests to allow C++20

These tests fail due to a couple of changes to `move_iterator` for C++20:

* `move_iterator<I>::operator++(int)` returns `void` in C++20 if `I` doesn't model `forward_iterator`.

* `move_iterator<I>::reference` is calculated in C++20, so `I` must actually have an `operator*() const`.

Differential Revision: https://reviews.llvm.org/D79343

4 years ago[libc++] Add tests for _LIBCPP_HAS_MERGED_TYPEINFO_NAMES_DEFAULT
Louis Dionne [Mon, 27 Apr 2020 18:46:52 +0000 (14:46 -0400)]
[libc++] Add tests for _LIBCPP_HAS_MERGED_TYPEINFO_NAMES_DEFAULT

The issue on Apple platforms was fixed in 2464d8135e2a, but this commit
adds some tests to make sure we don't regress.

See https://llvm.org/PR45549.

Differential Revision: https://reviews.llvm.org/D78963

4 years ago[mlir] Drop forward-declaration of loop::TerminatorOp.
Alex Zinenko [Thu, 7 May 2020 16:27:40 +0000 (18:27 +0200)]
[mlir] Drop forward-declaration of loop::TerminatorOp.

This Op has been deleted in favor of loop::YieldOp, but the forward
declaration remain in the header.

4 years agoAdd a test for "clang --version".
Nico Weber [Thu, 7 May 2020 16:14:51 +0000 (12:14 -0400)]
Add a test for "clang --version".

4 years agotab completion for register read/write
Gongyu Deng [Thu, 7 May 2020 16:12:39 +0000 (18:12 +0200)]
tab completion for register read/write

Summary:
1. Created a new common completion for the registers of the current context;
2. Apply this new common completion to the commands register read/write;
3. Unit test.

Reviewers: teemperor, JDevlieghere

Reviewed By: teemperor

Tags: #lldb

Differential Revision: https://reviews.llvm.org/D79490

4 years ago[libcxx] Add deduction guides for shared_ptr and weak_ptr
Logan Smith [Thu, 7 May 2020 16:07:01 +0000 (12:07 -0400)]
[libcxx] Add deduction guides for shared_ptr and weak_ptr

This patch adds deduction guides to <memory> to allow deducing
construction of shared_ptrs from unique_ptrs, and from weak_ptrs
and vice versa, as specified by C++17.

Differential Revision: https://reviews.llvm.org/D69603

4 years ago[libcxx] Qualify make_pair in searcher implementations to prevent ADL
Logan Smith [Thu, 7 May 2020 15:54:25 +0000 (11:54 -0400)]
[libcxx] Qualify make_pair in searcher implementations to prevent ADL

This patch adds `_VSTD::` to some calls to `make_pair` inside the
implementations of searchers, to prevent things exploding if there is
a make_pair in an associated namespace of a user-defined type.
https://godbolt.org/z/xAFG98

Differential Revision: https://reviews.llvm.org/D72640

4 years ago[lldb][NFC] Also initialize language_flags in ValueObject::Dereference
Raphael Isemann [Thu, 7 May 2020 15:33:45 +0000 (17:33 +0200)]
[lldb][NFC] Also initialize language_flags in ValueObject::Dereference

We currently rely on the TypeSystem implementation to initialize this value
with 0 in the GetChildCompilerTypeAtIndex call below. Let's just initialize
this variable like the rest.

4 years ago[SVE] Fix incorrect usage of getNumElements() in InstCombineCalls
Christopher Tetreault [Thu, 7 May 2020 15:34:55 +0000 (08:34 -0700)]
[SVE] Fix incorrect usage of getNumElements() in InstCombineCalls

Summary:
Remove incorrect usage of getNumElements() from visitCallInst(). The
number of elements was being used to construct a DemandedElts bitfield.
This operation does not make sense for scalable vectors. Cast to
FixedVectorType

Identified by test case Clang :: CodeGen/aarch64-sve-intrinsics/acle_sve_mla.c

Reviewers: rengolin, efriedma, sdesmalen, c-rhodes, david-arm

Reviewed By: david-arm

Subscribers: tschuett, kristof.beyls, hiraditya, rkruppe, psnobl, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D79524