platform/upstream/gstreamer.git
4 years agotests: check: initial unit test support
U. Artie Eoff [Tue, 8 Oct 2019 19:20:26 +0000 (12:20 -0700)]
tests: check: initial unit test support

Add minimal unit test toolchain files and a simple
vaapipostproc unit test.

4 years agotests: move examples and tests to subfolders
U. Artie Eoff [Tue, 8 Oct 2019 19:19:06 +0000 (12:19 -0700)]
tests: move examples and tests to subfolders

This makes way for adding unit (check) tests.

4 years agoRemove autotools build
Tim-Philipp Müller [Mon, 14 Oct 2019 00:01:27 +0000 (01:01 +0100)]
Remove autotools build

4 years agovaapipostproc: fix off-by-one coord translations
U. Artie Eoff [Thu, 10 Oct 2019 22:26:36 +0000 (15:26 -0700)]
vaapipostproc: fix off-by-one coord translations

When translating navigation x,y coordinates for
video-direction, it is necessary to subtract 1
when using the video dimensions to compute the
new x,y coordinates.  That is, a 100x200 image
should map coordinates in x=[0-99],y=[0-199].

This issue was found with unit tests provided
in !182.

4 years agolibs: window: x11: Avoid usage of deprecated API
Víctor Manuel Jáquez Leal [Fri, 11 Oct 2019 15:34:06 +0000 (17:34 +0200)]
libs: window: x11: Avoid usage of deprecated API

4 years agobuild: halt meson configuration if no renderer API
Víctor Manuel Jáquez Leal [Fri, 11 Oct 2019 15:13:34 +0000 (17:13 +0200)]
build: halt meson configuration if no renderer API

We should halt meson configuration if there is no render API
installed (either DRM, Wayland or X11).

That behavior was already in autotools but missed in meson. This patch
brings it back.

Fixes: #196

4 years agolibs: filter: fix default orientation regression
U. Artie Eoff [Wed, 9 Oct 2019 19:12:18 +0000 (12:12 -0700)]
libs: filter: fix default orientation regression

Fix regression introduced in f232f87f7082

4 years agolibs: filter: use OP_DATA_DEFAULT_VALUE macro
U. Artie Eoff [Mon, 7 Oct 2019 18:53:23 +0000 (11:53 -0700)]
libs: filter: use OP_DATA_DEFAULT_VALUE macro

4 years agolibs: filter: use macro for returning op default value
U. Artie Eoff [Mon, 7 Oct 2019 18:39:19 +0000 (11:39 -0700)]
libs: filter: use macro for returning op default value

The code is essentially the same for getting all op default
values.  Thus, use a macro to help minimize code duplication
and [hopefully] encourage using the same mechanism for all
default getters.

4 years agolibs: filter: query param spec for default scale method
U. Artie Eoff [Mon, 7 Oct 2019 16:56:37 +0000 (09:56 -0700)]
libs: filter: query param spec for default scale method

Related: #159

4 years agolibs: filter: query param spec for default skin-tone values
U. Artie Eoff [Mon, 7 Oct 2019 16:44:06 +0000 (09:44 -0700)]
libs: filter: query param spec for default skin-tone values

Related: #159

4 years agolibs: filter: query param spec for default video-direction
U. Artie Eoff [Wed, 2 Oct 2019 19:54:52 +0000 (12:54 -0700)]
libs: filter: query param spec for default video-direction

Related: #159

4 years agoadd .gitignore
U. Artie Eoff [Mon, 7 Oct 2019 17:23:09 +0000 (10:23 -0700)]
add .gitignore

4 years agovaapipostproc: Use level value for skin-tone-enhancement filter.
Yan Wang [Thu, 5 Sep 2019 08:40:52 +0000 (16:40 +0800)]
vaapipostproc: Use level value for skin-tone-enhancement filter.

Currently the parameter of skin-tone-enhancement filter is forced
to zero. In fact it could be set different value by the user.
So create a new property named as "skin-tone-enhancement-level"
for accepting the used defined parameter value.
At the same time, skin-tone-enhancement is marked as deprecated.
When skin-tone-enhancement-level is set, skin-tone-enhancement
will be ignored.

4 years agolibs: decoder: h264, h266: fix g_return_val_if_fail() missuse
Víctor Manuel Jáquez Leal [Sat, 21 Sep 2019 11:39:42 +0000 (13:39 +0200)]
libs: decoder: h264, h266: fix g_return_val_if_fail() missuse

g_return_val_fail() documentations says:

  If expr evaluates to FALSE, the current function should be
  considered to have undefined behaviour (a programmer error).
  The only correct solution to such an error is to change the
  module that is calling the current function, so that it avoids
  this incorrect call.

So it was missused in a couple parts of the H264 and H265 internal
decoders. This patch changes that to plain conditionals.

Also, it was included a couple code-style fixes.

4 years agolibs: encoder: remove gst_vaapi_encoder_{ref,unref}()
Víctor Manuel Jáquez Leal [Mon, 23 Sep 2019 17:52:20 +0000 (19:52 +0200)]
libs: encoder: remove gst_vaapi_encoder_{ref,unref}()

Since GstVaapiEncoder is a descendant of of GstObject, there is no
need to keep a custom ref()/unref() methods. This patch deletes them.

4 years agolibs: encoder: correct encoder's ref/unref function.
He Junyan [Mon, 23 Sep 2019 17:03:02 +0000 (01:03 +0800)]
libs: encoder: correct encoder's ref/unref function.

GstVaapiEncoder now is a standard gstobject and need to use
gst_object_ref/unref functions.

4 years agogst: encode: h264_fei: remove useless comparison
U. Artie Eoff [Thu, 19 Sep 2019 19:09:20 +0000 (12:09 -0700)]
gst: encode: h264_fei: remove useless comparison

The expression "len >= 0" is always true since "len"
is an unsigned type.  And it is clear that the writers
intention was not to write "len > 0" since we handle
len == 0 in the ensuing "if (len < 3)" conditional
block.

4 years agolibs: encoder: h264_fei: fix potential overflow before widen
U. Artie Eoff [Thu, 19 Sep 2019 18:17:24 +0000 (11:17 -0700)]
libs: encoder: h264_fei: fix potential overflow before widen

Found by static analysis. encoder->mb_width * encoder->mb_height
is evaluated using 32-bit arithmetic before widen.  Thus, cast
at least one of these to guint64 to avoid overflow.

4 years agolibs: encoder: h264_fei: remove dead error condition
U. Artie Eoff [Thu, 19 Sep 2019 17:56:13 +0000 (10:56 -0700)]
libs: encoder: h264_fei: remove dead error condition

Found by static analysis.  The feipak is always null
when we reach the error target.

4 years agolibs: utils: add missing break in switch
U. Artie Eoff [Thu, 19 Sep 2019 17:49:11 +0000 (10:49 -0700)]
libs: utils: add missing break in switch

4 years agolibs: video-format: Make all YUV format available
He Junyan [Wed, 11 Sep 2019 03:56:35 +0000 (11:56 +0800)]
libs: video-format: Make all YUV format available

The YUV formats have no ambiguity for drivers, so we can add them all.
Some old driver(i965) does not implement full get/put image functions
but can use derive image funtions for the YUV format. It does not
report that kind of formats correctly in image query, but will derive
that YUV format image from surface. The dynamic mapping of YUV format
will block that manner.
Adding more YUV format mapping has no side effect. So considering the
legacy driver conformance, we add all YUV formats mapping statically
and dynamic mapping RBG formats

Fix: #189
Fix: #190

4 years agoegl: Fix racyness in display thread creation
Matthew Waters [Wed, 18 Sep 2019 05:30:03 +0000 (15:30 +1000)]
egl: Fix racyness in display thread creation

Multiple different scenarios could break the display thread creation and
end up blocking waiting for thread o be created.  Fix them all by
correctly waiting for a new boolean to become valid.

4 years agoegl: don't advertise a wrapped EGLContext as actually wrapped
Matthew Waters [Wed, 18 Sep 2019 05:29:03 +0000 (15:29 +1000)]
egl: don't advertise a wrapped EGLContext as actually wrapped

It's not actually wrapped as we create a new EGLContext from the passed
in EGLContext.  As a result, the created EGLContext was never destroyed.

4 years agolibs: h264decoder: do not return error for unhandled NAL unit.
He Junyan [Mon, 16 Sep 2019 15:28:31 +0000 (23:28 +0800)]
libs: h264decoder: do not return error for unhandled NAL unit.

Some streams have error data introducing unknown NAL type. There are
also kinds of NAL types we do not want to handle. The old manner will
set a decoder error when encounter this, which cause a latent crash bug.
The decoder may successfully decode the picture and insert it into DPB.
But there are error NAL units after the AU which cause the post unit error
and make that frame dropped. The later output of the picture still want
to ref that frame and crash.
No need to set decoder error when can not recognize or handle the NAL
unit, just skip it and continue.

Fix: #191

4 years agolibs: encoders: use GST_PARAM_USER_SHIFT to define internal params
Víctor Manuel Jáquez Leal [Wed, 11 Sep 2019 12:32:22 +0000 (14:32 +0200)]
libs: encoders: use GST_PARAM_USER_SHIFT to define internal params

This patch makes use of GST_PARAM_USER_SHIFT to define the internal
param in encoders to decide which parameters to expose. Thus
gstreamer-vaapi will not interfere with any change in GStreamer in the
future.

Also, the internal symbol was change to
GST_VAAPI_PARAM_ENCODER_EXPOSURE to keep the namespacing.

4 years agolibs: Add BGR10A2_LE support for color space conversion.
He Junyan [Mon, 9 Sep 2019 10:06:51 +0000 (18:06 +0800)]
libs: Add BGR10A2_LE support for color space conversion.

Fix: #179

4 years agolibs: surface: add pointer check for surface_new_from_formats.
He Junyan [Fri, 23 Aug 2019 06:41:06 +0000 (14:41 +0800)]
libs: surface: add pointer check for surface_new_from_formats.

The command line:
  gst-launch-1.0 filesrc location=some_name.mjpeg ! jpegparse !
  vaapijpegdec !  videoconvert ! video/x-raw,format=I420 ! vaapisink
will crash on i965 driver because of no pointer check.

We now generate the video format map between GST format and VA format
dynamically based on the image format returned by vaQueryImageFormats.
i965 driver does to report image format of 444P and Y800 forcc, while
the jpeg decoder context VASurfaceAttribPixelFormat use them. We can
not recognize these format and pass a NULL pointer to
gst_vaapi_surface_new_from_formats.
We need to add a pointer check here and let the fallback logic handle
this case correctly.
Other drivers work well.

4 years agolibs: utils: guard the VAEntrypointFEI symbol
Víctor Manuel Jáquez Leal [Sat, 7 Sep 2019 11:23:01 +0000 (13:23 +0200)]
libs: utils: guard the VAEntrypointFEI symbol

VAEntrypointFEI appeared in libva 2.0.0 (API version 1.0.0)

4 years agolibs: video-format: Refine the video format mapping.
He Junyan [Thu, 5 Sep 2019 06:48:22 +0000 (14:48 +0800)]
libs: video-format: Refine the video format mapping.

Improve the mapping between va format and gst format. The new map
will be generated dynamically, based on the query result of image
format in VA driver. Also consider the ambiguity of RGB color
format in LSB mode.

4 years agopluginutil: Remove Mesa from drivers white list
Philippe Normand [Mon, 15 Apr 2019 15:51:26 +0000 (16:51 +0100)]
pluginutil: Remove Mesa from drivers white list

The Mesa Gallium driver is poorly tested currently, leading to bad user
experience for AMD users. The driver can be added back to the white list at
runtime using the GST_VAAPI_ALL_DRIVERS environment variable.

4 years agovaapipostproc: allow cropping via properties
U. Artie Eoff [Mon, 8 Jul 2019 21:18:00 +0000 (14:18 -0700)]
vaapipostproc: allow cropping via properties

Add crop-left, crop-right, crop-top and crop-bottom
properties to vaapipostproc.

4 years agovaapipostproc: rotate outbuf and crop meta if forwarding
U. Artie Eoff [Sat, 31 Aug 2019 00:31:45 +0000 (17:31 -0700)]
vaapipostproc: rotate outbuf and crop meta if forwarding

When forwarding crop meta to downstream, the output
buffer and crop meta need to be rotated, too.

Test:
 for i in 90r 180 90l vert horiz ul-lr ur-ll
 do
  gst-launch-1.0 -vf videotestsrc num-buffers=500 \
   ! videocrop top=100 bottom=30 left=40 right=20 \
   ! vaapipostproc video-direction=$i \
   ! vaapisink & \
  gst-launch-1.0 -vf videotestsrc num-buffers=500 \
   ! videocrop top=100 bottom=30 left=40 right=20 \
   ! vaapipostproc video-direction=$i \
   ! identity drop-allocation=true \
   ! vaapisink
 done

4 years agovaapipostproc: fix output buffer WxH for crop meta forwarding
U. Artie Eoff [Fri, 30 Aug 2019 21:14:30 +0000 (14:14 -0700)]
vaapipostproc: fix output buffer WxH for crop meta forwarding

Adding crop meta x,y to w,h only compensates for left,top
cropping.  But we also need to compensate for right,bottom
cropping.

The video meta contains the appropriate w,h (uncropped)
values, so use it instead.

Test:

 gst-launch-1.0 -vf videotestsrc num-buffers=500 \
  ! videocrop top=50 bottom=30 left=40 right=20 \
  ! vaapipostproc ! vaapisink & \
 gst-launch-1.0 -vf videotestsrc num-buffers=500 \
  ! videocrop top=50 bottom=30 left=40 right=20 \
  ! vaapipostproc ! identity drop-allocation=1 \
  ! vaapisink

4 years agovaapipostproc: handle size and direction together in src events
U. Artie Eoff [Wed, 4 Sep 2019 17:52:51 +0000 (10:52 -0700)]
vaapipostproc: handle size and direction together in src events

Mapping a pointer event needs to consider both size and
video-direction operations together, not just one or the other.

This fixes an issue where x,y were not being mapped correctly
for 90r, 90l, ur-ll and ul-lr video-direction. In these directions,
the WxH are swapped and GST_VAAPI_POSTPROC_FLAG_SIZE is set.  Thus,
the first condition in the pointer event handling was entered and
x,y scale factor were incorrectly computed due to srcpad WxH
swap.

This also fixes all cases where both video-direction and scaling
are enabled at the same time.

Test that all pointer events map appropriately:

for i in `seq 0 7`
do
 GST_DEBUG=vaapipostproc:5 gst-launch-1.0 -vf videotestsrc \
  ! vaapipostproc video-direction=${i} width=300 \
  ! vaapisink
 GST_DEBUG=vaapipostproc:5 gst-launch-1.0 -vf videotestsrc \
  ! vaapipostproc video-direction=${i} width=300 height=200 \
  ! vaapisink
 GST_DEBUG=vaapipostproc:5 gst-launch-1.0 -vf videotestsrc \
  ! vaapipostproc video-direction=${i} height=200 \
  ! vaapisink
 GST_DEBUG=vaapipostproc:5 gst-launch-1.0 -vf videotestsrc \
  ! vaapipostproc video-direction=${i} \
  ! vaapisink
done

4 years agovaapipostproc: advertise crop meta is handled
U. Artie Eoff [Tue, 20 Aug 2019 21:22:57 +0000 (14:22 -0700)]
vaapipostproc: advertise crop meta is handled

Advertise to upstream that vaapipostproc can handle
crop meta.

When used in conjunction with videocrop plugin, the
videocrop plugin will only do in-place transform on the
crop meta when vaapipostproc advertises the ability to
handle it.  This allows vaapipostproc to apply the crop
meta on the output buffer using vaapi acceleration.
Without this advertisement, the videocrop plugin will
crop the output buffer directly via software methods,
which is not what we desire.

vaapipostproc will not apply the crop meta if downstream
advertises crop meta handling; vaapipostproc will just
forward the crop meta to downstream.  If crop meta is
not advertised by downstream, then vaapipostproc will
apply the crop meta.

Examples:

1. vaapipostproc will forward crop meta to vaapisink
 gst-launch-1.0 videotestsrc \
  ! videocrop left=10 \
  ! vaapipostproc \
  ! vaapisink

2. vaapipostproc will do the cropping
 gst-launch-1.0 videotestsrc \
  ! videocrop left=10 \
  ! vaapipostproc \
  ! identity drop-allocation=1 \
  ! vaapisink

4 years agolibs: encoder: clean two virtual func in encoder class
He Junyan [Thu, 29 Aug 2019 10:44:36 +0000 (18:44 +0800)]
libs: encoder: clean two virtual func in encoder class

set_property and get_default_properties functions are no longer
needed for encoder class.

4 years agolibs: encoder: delete old set_property and property enum feienc264
He Junyan [Thu, 29 Aug 2019 10:43:30 +0000 (18:43 +0800)]
libs: encoder: delete old set_property and property enum feienc264

4 years agolibs: encoder: delete old set_property and property enum in h264 fei
He Junyan [Thu, 29 Aug 2019 10:39:27 +0000 (18:39 +0800)]
libs: encoder: delete old set_property and property enum in h264 fei

4 years agolibs: encoder: delete old set_property and property enum in vp9
He Junyan [Thu, 29 Aug 2019 10:37:58 +0000 (18:37 +0800)]
libs: encoder: delete old set_property and property enum in vp9

4 years agolibs: encoder: delete old set_property and property enum in vp8
He Junyan [Thu, 29 Aug 2019 10:36:51 +0000 (18:36 +0800)]
libs: encoder: delete old set_property and property enum in vp8

4 years agolibs: encoder: delete old set_property and property enum in mpeg2
He Junyan [Thu, 29 Aug 2019 10:35:59 +0000 (18:35 +0800)]
libs: encoder: delete old set_property and property enum in mpeg2

4 years agolibs: encoder: delete old set_property and property enum in jpeg
He Junyan [Thu, 29 Aug 2019 10:34:57 +0000 (18:34 +0800)]
libs: encoder: delete old set_property and property enum in jpeg

4 years agolibs: encoder: delete old set_property and property enum in h265
He Junyan [Thu, 29 Aug 2019 10:31:56 +0000 (18:31 +0800)]
libs: encoder: delete old set_property and property enum in h265

4 years agolibs: encoder: delete old set_property and property enum in h264
He Junyan [Thu, 29 Aug 2019 10:30:07 +0000 (18:30 +0800)]
libs: encoder: delete old set_property and property enum in h264

4 years agolibs: encoder: delete EncoderPropInfo related functions
He Junyan [Thu, 29 Aug 2019 10:17:42 +0000 (18:17 +0800)]
libs: encoder: delete EncoderPropInfo related functions

4 years agolibs: encoder: delete encoder_set_property
He Junyan [Thu, 29 Aug 2019 08:13:19 +0000 (16:13 +0800)]
libs: encoder: delete encoder_set_property

We no longer need this obsolete set_property function now after
switch to standard gobject's property manner.
Also delete the old encoder's property enum in the header file.

4 years agolibs: encoder: delete properties_get_default for base class
He Junyan [Thu, 29 Aug 2019 07:59:43 +0000 (15:59 +0800)]
libs: encoder: delete properties_get_default for base class

4 years agoplugin: encode: delete useless init_properties.
He Junyan [Thu, 29 Aug 2019 07:52:04 +0000 (15:52 +0800)]
plugin: encode: delete useless init_properties.

Also delete the get_properties function in encode class. We now
use g_object_class_list_properties to get all properties for
internal encoder class.

4 years agoplugin: encode: delete set/get_property func in encode class
He Junyan [Thu, 29 Aug 2019 07:43:45 +0000 (15:43 +0800)]
plugin: encode: delete set/get_property func in encode class

Use standard gobject's property functions to replace the old way.

4 years agoplugin: encode: delete gst_vaapiencode_init_properties
He Junyan [Thu, 29 Aug 2019 07:31:16 +0000 (15:31 +0800)]
plugin: encode: delete gst_vaapiencode_init_properties

No need to init the properties got by get_default_properties func
now. The properties are inited correctly in internal encoder class.

4 years agolibs: encoder: delete 3 useless init macro
He Junyan [Thu, 29 Aug 2019 07:19:10 +0000 (15:19 +0800)]
libs: encoder: delete 3 useless init macro

4 years agolibs: encoder: delete get_default_properties of feienc
He Junyan [Thu, 29 Aug 2019 07:16:26 +0000 (15:16 +0800)]
libs: encoder: delete get_default_properties of feienc

4 years agolibs: encoder: delete get_default_properties of H264 Fei
He Junyan [Thu, 29 Aug 2019 07:14:14 +0000 (15:14 +0800)]
libs: encoder: delete get_default_properties of H264 Fei

4 years agolibs: encoder: delete get_default_properties of VP9
He Junyan [Thu, 29 Aug 2019 07:07:17 +0000 (15:07 +0800)]
libs: encoder: delete get_default_properties of VP9

4 years agolibs: encoder: delete get_default_properties of VP8
He Junyan [Thu, 29 Aug 2019 07:06:25 +0000 (15:06 +0800)]
libs: encoder: delete get_default_properties of VP8

4 years agolibs: encoder: delete get_default_properties of MPEG2
He Junyan [Thu, 29 Aug 2019 07:03:52 +0000 (15:03 +0800)]
libs: encoder: delete get_default_properties of MPEG2

4 years agolibs: encoder: delete get_default_properties of JPEG
He Junyan [Thu, 29 Aug 2019 07:03:19 +0000 (15:03 +0800)]
libs: encoder: delete get_default_properties of JPEG

4 years ago libs: encoder: delete get_default_properties of H265
He Junyan [Fri, 30 Aug 2019 11:15:38 +0000 (19:15 +0800)]
 libs: encoder: delete get_default_properties of H265

4 years agolibs: encoder: delete get_default_properties of H264
He Junyan [Thu, 29 Aug 2019 06:59:12 +0000 (14:59 +0800)]
libs: encoder: delete get_default_properties of H264

4 years agolibs: encoder: delete the useless constructed func for encoder.
He Junyan [Thu, 29 Aug 2019 06:53:59 +0000 (14:53 +0800)]
libs: encoder: delete the useless constructed func for encoder.

4 years agolibs: encoder: implement get_view_ids for h264 encoder.
He Junyan [Mon, 26 Aug 2019 15:16:33 +0000 (23:16 +0800)]
libs: encoder: implement get_view_ids for h264 encoder.

4 years agogst: encode: enable new type of property mechanism.
He Junyan [Tue, 20 Aug 2019 15:56:33 +0000 (23:56 +0800)]
gst: encode: enable new type of property mechanism.

4 years agogst: encode: add property help functions for encoder properties.
He Junyan [Tue, 20 Aug 2019 14:16:35 +0000 (22:16 +0800)]
gst: encode: add property help functions for encoder properties.

The encoder is a true gstobject now and all the properties are using
gobject's properties mechanism. Add help functions to handle the properties
between encode and encoder class.
The basic idea is mapping the same property between encoder and encode. All
the encoder's properties will have the same name, the same type in encode.
The set/get property function just forward the property setting/getting to
the encoder using the same property name and value. Because the encoder is
created on needed, we need to cache the property setting in encode.

4 years agolibs: encoder: add flags to all encoder properties.
He Junyan [Fri, 30 Aug 2019 10:39:32 +0000 (18:39 +0800)]
libs: encoder: add flags to all encoder properties.

G_PARAM_CONSTRUCT make all properties init correctly, we do not
need to init the properties manually.
G_PARAM_FLAG_VAAPI_ENCODER_EXPOSURE is a vaapi encoder specific
flag, means need to expose the property to according encode class.

4 years agolibs: encoder: Add properties for h264 encoder fei.
He Junyan [Tue, 20 Aug 2019 09:00:39 +0000 (17:00 +0800)]
libs: encoder: Add properties for h264 encoder fei.

Install properties for h264 encoder fei class. Also set the new get/set
property functions for gobject class. Still use the old properties
way now and this new feature will be enabled later.

4 years agolibs: encoder: Add properties for h264 fei encoder.
He Junyan [Tue, 20 Aug 2019 07:58:30 +0000 (15:58 +0800)]
libs: encoder: Add properties for h264 fei encoder.

Install properties for h264 fei encoder class. Also set the new get/set
property functions for gobject class. Still use the old properties
way now and this new feature will be enabled later.

4 years agolibs: encoder: Add properties for vp9 encoder.
He Junyan [Tue, 20 Aug 2019 07:29:27 +0000 (15:29 +0800)]
libs: encoder: Add properties for vp9 encoder.

Install properties for vp9 encoder class. Also set the new get/set
property functions for gobject class. Still use the old properties
way now and this new feature will be enabled later.

4 years agolibs: encoder: Add properties for vp8 encoder.
He Junyan [Tue, 20 Aug 2019 07:01:02 +0000 (15:01 +0800)]
libs: encoder: Add properties for vp8 encoder.

Install properties for vp8 encoder class. Also set the new get/set
property functions for gobject class. Still use the old properties
way now and this new feature will be enabled later.

4 years agolibs: encoder: Add properties for mpeg2 encoder.
He Junyan [Tue, 20 Aug 2019 06:31:58 +0000 (14:31 +0800)]
libs: encoder: Add properties for mpeg2 encoder.

Install properties for mpeg2 encoder class. Also set the new get/set
property functions for gobject class. Still use the old properties
way now and this new feature will be enabled later.

4 years agolibs: encoder: Add properties for jpeg encoder.
He Junyan [Tue, 20 Aug 2019 06:53:06 +0000 (14:53 +0800)]
libs: encoder: Add properties for jpeg encoder.

Install properties for jpeg encoder class. Also set the new get/set
property functions for gobject class. Still use the old properties
way now and this new feature will be enabled later.

4 years agolibs: encoder: Add properties for h265 encoder.
He Junyan [Tue, 20 Aug 2019 06:12:36 +0000 (14:12 +0800)]
libs: encoder: Add properties for h265 encoder.

Install properties for h265 encoder class. Also set the new get/set
property functions for gobject class. Still use the old properties
way now and this new feature will be enabled later.

4 years agolibs: encoder: Add properties for h264 encoder.
He Junyan [Mon, 19 Aug 2019 17:33:40 +0000 (01:33 +0800)]
libs: encoder: Add properties for h264 encoder.

Install properties for h264 encoder class. Also set the new get/set
property functions for gobject class. Still use the old properties
way now and this new feature will be enabled later.

4 years agolibs: encoder: add properties and prop help functions
He Junyan [Mon, 19 Aug 2019 07:38:09 +0000 (15:38 +0800)]
libs: encoder: add properties and prop help functions

Add all common properties to encoder base class. rate-control and
tune are moved to sub class.

4 years agolibs: encoder: delete useless gst_vaapi_encoder_new func.
He Junyan [Thu, 29 Aug 2019 06:38:49 +0000 (14:38 +0800)]
libs: encoder: delete useless gst_vaapi_encoder_new func.

GstVaapiEncoder is a abstract gobject and never be created directly.

4 years agolib: encoder: gstobjectfy all vaapi encoders.
He Junyan [Fri, 26 Jul 2019 16:55:53 +0000 (00:55 +0800)]
lib: encoder: gstobjectfy all vaapi encoders.

Replace all gstvaapiobject in vaapi encoders with standard gstobject.
Let the gstobject common logic to handle all the init and finalize
works. But the property install/set/get still use the old way, need
to be improved later.

4 years agovaapipostproc: check for filter before appending caps
Víctor Manuel Jáquez Leal [Thu, 29 Aug 2019 10:11:36 +0000 (12:11 +0200)]
vaapipostproc: check for filter before appending caps

While ensuring the allowed sink pad caps, the filter attributes set
the frame size restriction, but it is not ensured, at that moment,
that the filter is already instantiaded.

In order to silence the glib logs, this patch add only calls
gst_vaapi_filter_append_caps() if the filter is instantiated.

4 years agoClassify vaapidecodebin as a hardware decoder
Thibault Saunier [Wed, 28 Aug 2019 16:49:03 +0000 (12:49 -0400)]
Classify vaapidecodebin as a hardware decoder

4 years agolibs: postproc: fix a memory leak point.
He Junyan [Tue, 27 Aug 2019 10:12:45 +0000 (18:12 +0800)]
libs: postproc: fix a memory leak point.

filter_ops and filter_formats should already have valid value when
the function gst_vaapipostproc_ensure_filter_caps re-enter

4 years agolibs: util: Fix a memory leak in config_surface_attributes_get
He Junyan [Mon, 26 Aug 2019 17:30:36 +0000 (01:30 +0800)]
libs: util: Fix a memory leak in config_surface_attributes_get

4 years agovaapidecode: support transform ROI meta
Wangfei [Thu, 22 Aug 2019 06:33:54 +0000 (14:33 +0800)]
vaapidecode: support transform ROI meta

This will benefit the use case like:

src --->   encode    ---> decode ---> circle ROI ---> sink
     |                |
     --> analyse to -->
         get ROI

4 years agodocstrings: port ulinks to markdown links
Mathieu Duponchelle [Fri, 23 Aug 2019 17:10:15 +0000 (19:10 +0200)]
docstrings: port ulinks to markdown links

4 years agolibs: remove context's overlay
Víctor Manuel Jáquez Leal [Tue, 20 Aug 2019 15:05:14 +0000 (17:05 +0200)]
libs: remove context's overlay

The context overlay was an optimization to apply a video composition
to all the surfaces bound to a context.

But since commit 18031dc6 this optimization was disabled, so it is
better just get rid of it.

4 years agolibs: remove surface's parent context
Víctor Manuel Jáquez Leal [Tue, 20 Aug 2019 14:50:46 +0000 (16:50 +0200)]
libs: remove surface's parent context

In commit 18031dc6 surface's parent context is not assigned because of
circular references. Since then (2013), there's has no issue with
subpictures attached to a context, the current only users of this API.

This patch cleans up all of related code with the unused surface's
parent context.

4 years agovaapidecode: guard if no structure is available in caps
Víctor Manuel Jáquez Leal [Sun, 18 Aug 2019 11:53:53 +0000 (13:53 +0200)]
vaapidecode: guard if no structure is available in caps

4 years agovaapipostproc: append frame size restrictions in caps
Víctor Manuel Jáquez Leal [Sun, 18 Aug 2019 11:53:19 +0000 (13:53 +0200)]
vaapipostproc: append frame size restrictions in caps

4 years agolibs: profilecaps: refactor common code
Víctor Manuel Jáquez Leal [Sun, 18 Aug 2019 11:09:58 +0000 (13:09 +0200)]
libs: profilecaps: refactor common code

4 years agovaapiencode: set frame size restrictions in caps
Víctor Manuel Jáquez Leal [Fri, 16 Aug 2019 17:35:58 +0000 (19:35 +0200)]
vaapiencode: set frame size restrictions in caps

Fixes: #12

4 years agovaapiencode: enhance how the profile is defined
Víctor Manuel Jáquez Leal [Fri, 16 Aug 2019 17:28:27 +0000 (19:28 +0200)]
vaapiencode: enhance how the profile is defined

This code doesn't define the profile used by the internal encoder, but
it used to "predict" which is going to be used and to get the caps
restrictions.

Before the profile was predicted by checking the donwstream caps, but
sometimes they are not defined, setting an unknown profile. In order
to enhances this situation, the encoder asks to internal encoder if it
has one. If so, it is used.

To ask the internal encoder's profile a new accessor function was
added: gst_vaapi_encoder_get_profile()

4 years agolibs: profilecaps: defines gst_vaapi_profile_caps_append_encoder()
Víctor Manuel Jáquez Leal [Fri, 16 Aug 2019 17:26:36 +0000 (19:26 +0200)]
libs: profilecaps: defines gst_vaapi_profile_caps_append_encoder()

Previously it was just a boilerplate. Now it is real implementation.

4 years agolibs: utils: treat va_rt_format as bitwise flag
Víctor Manuel Jáquez Leal [Fri, 16 Aug 2019 17:17:48 +0000 (19:17 +0200)]
libs: utils: treat va_rt_format as bitwise flag

The return value of vaGetConfigAttributes() of VAConfigAttribRTFormat
is a bitwise flag with *all* the supported chroma types.

Previously it was assumed that the return value was a single value,
thus when returning the GST_VAAPI_CHROMA_TYPE_XXX the code was a
simple case. But it is wrong.

This patch changes the case block with a sequence of ifs testing the
bitwise. For now we assume a "priority" list in the testing sequence.

4 years agolibs: profile: add gst_vaapi_profile_get_va_name()
Víctor Manuel Jáquez Leal [Fri, 16 Aug 2019 16:07:43 +0000 (18:07 +0200)]
libs: profile: add gst_vaapi_profile_get_va_name()

gst_vaapi_profile_get_name() returns a proper name for
GstCaps. Nonetheless, there are many profiles which don't have a name
representation for that realm.

gst_vaapi_profile_get_va_name() returns the name of the profile
according to its VAProfile name.

This new funtion is used in the encoder error message.

4 years agolibs: profilecaps: move caps config into a new file
Víctor Manuel Jáquez Leal [Mon, 5 Aug 2019 17:47:30 +0000 (19:47 +0200)]
libs: profilecaps: move caps config into a new file

Implement all the appending of frame size restrictions in caps, for
encoders and decoders, in a new source file.

4 years agolibs: decoder: ref the caps as property
Víctor Manuel Jáquez Leal [Mon, 5 Aug 2019 17:45:49 +0000 (19:45 +0200)]
libs: decoder: ref the caps as property

4 years agolibs: context: add gst_vaapi_context_get_surface_attributes()
Víctor Manuel Jáquez Leal [Fri, 2 Aug 2019 14:56:17 +0000 (16:56 +0200)]
libs: context: add gst_vaapi_context_get_surface_attributes()

This function copies the surface attributes from the context's object
to the caller.

4 years agolibs: move memory types conversions to gstvaapiutils
Víctor Manuel Jáquez Leal [Fri, 2 Aug 2019 10:46:55 +0000 (12:46 +0200)]
libs: move memory types conversions to gstvaapiutils

And add more supported memory types by current VA.

4 years agolibs: utils: remove unused function gst_vaapi_get_surface_formats()
Víctor Manuel Jáquez Leal [Thu, 1 Aug 2019 17:48:21 +0000 (19:48 +0200)]
libs: utils: remove unused function gst_vaapi_get_surface_formats()

4 years agolibs: context, filter: use new surface attributes API
Víctor Manuel Jáquez Leal [Thu, 1 Aug 2019 17:46:17 +0000 (19:46 +0200)]
libs: context, filter: use new surface attributes API

4 years agolibs: utils: add gst_vaapi_config_surface_attributes_get()
Víctor Manuel Jáquez Leal [Thu, 1 Aug 2019 17:13:39 +0000 (19:13 +0200)]
libs: utils: add gst_vaapi_config_surface_attributes_get()

To extract the surface restrictions per config using a new structure:
GstVaapiConfigSurfaceAttributes

4 years agoSplit the surface attribute retrieval
Víctor Manuel Jáquez Leal [Wed, 31 Jul 2019 11:08:43 +0000 (13:08 +0200)]
Split the surface attribute retrieval