Mariya Podchishchaeva [Thu, 27 Apr 2023 09:24:31 +0000 (05:24 -0400)]
[clang] Do not crash on undefined template partial specialization
Before checking that template partial specialization is "reachable",
ensure it exists.
Fixes https://github.com/llvm/llvm-project/issues/61356
Reviewed By: shafik, erichkeane
Differential Revision: https://reviews.llvm.org/D148330
Nikita Popov [Thu, 27 Apr 2023 09:25:40 +0000 (11:25 +0200)]
[SCEV] Check correct binary operator for nowrap flags
We should be checking the current BO here, not the nested one. If
the current BO has nowrap flags (and is UB on poison), then we'll
fetch both operand SCEVs of that BO. We'll check the nested BO
on the next iteration of the do/while loop.
Nikita Popov [Thu, 27 Apr 2023 09:04:55 +0000 (11:04 +0200)]
[SCEV] Check MatchBinaryOp opcode instead of original opcode
These are not necessarily the same (e.g. or can become add) and
this is what we're switching over in the first place.
Jie Fu [Thu, 27 Apr 2023 09:08:24 +0000 (17:08 +0800)]
[X86] Fix -Wsometimes-uninitialized in X86InstrInfo.cpp (NFC)
/data/llvm-project/llvm/lib/Target/X86/X86InstrInfo.cpp:9793:3: error: variable 'MaddOpc' is used uninitialized whenever switch default is taken [-Werror,-Wsometimes-uninitialized]
default:
^~~~~~~
/data/llvm-project/llvm/lib/Target/X86/X86InstrInfo.cpp:9854:25: note: uninitialized use occurs here
Madd->setDesc(TII.get(MaddOpc));
^~~~~~~
/data/llvm-project/llvm/lib/Target/X86/X86InstrInfo.cpp:9791:19: note: initialize the variable 'MaddOpc' to silence this warning
unsigned MaddOpc;
^
= 0
/data/llvm-project/llvm/lib/Target/X86/X86InstrInfo.cpp:9793:3: error: variable 'AddOpc' is used uninitialized whenever switch default is taken [-Werror,-Wsometimes-uninitialized]
default:
^~~~~~~
/data/llvm-project/llvm/lib/Target/X86/X86InstrInfo.cpp:9862:46: note: uninitialized use occurs here
BuildMI(*MF, MIMetadata(Root), TII.get(AddOpc), DstReg)
^~~~~~
/data/llvm-project/llvm/lib/Target/X86/X86InstrInfo.cpp:9790:18: note: initialize the variable 'AddOpc' to silence this warning
unsigned AddOpc;
^
= 0
2 errors generated.
Mikhail Goncharov [Thu, 27 Apr 2023 08:43:13 +0000 (10:43 +0200)]
[bazel][mlir] update build for mem2reg
f88f8fd0bca34dc8e5571cb828b1a159a50fd504
Differential Revision: https://reviews.llvm.org/D149326
Nikita Popov [Thu, 27 Apr 2023 08:49:34 +0000 (10:49 +0200)]
[SCEV] Fix getOperandsToCreate() for and/or
We can create expressions either for constant operand or i1
and/or. The implementation was inverting the latter check.
gilsaia [Thu, 27 Apr 2023 08:36:29 +0000 (14:06 +0530)]
[MLIR][presburger] normalize divisionrepr
Added a simple normalize function to divisionrepr and added a simple unittest.
Added a normalizediv call to divisionrepr's removeDuplicateDivs function, which now eliminates divs that are consistent after gcd's normalize
Reviewed By: Groverkss
Differential Revision: https://reviews.llvm.org/D147381
Luo, Yuanke [Fri, 21 Apr 2023 11:28:58 +0000 (19:28 +0800)]
[X86] Machine combine vnni instruction.
"vpmaddwd + vpaddd" can be combined to vpdpwssd and the latency is
reduced after combination. However when vpdpwssd is in a critical path
the combination get less ILP. It happens when vpdpwssd is in a loop, the
vpmaddwd can be executed in parallel in multi-iterations while vpdpwssd
has data dependency for each iterations. If vpaddd is in a critical path
while vpmaddwd is not, it is profitable to split vpdpwssd into "vpmaddwd
+ vpaddd".
This patch is based on the machine combiner framework to acheive decision
on "vpmaddwd + vpaddd" combination. The typical example code is as
below.
```
__m256i foo(int cnt, __m256i c, __m256i b, __m256i *p) {
for (int i = 0; i < cnt; ++i) {
__m256i a = p[i];
__m256i m = _mm256_madd_epi16 (b, a);
c = _mm256_add_epi32(m, c);
}
return c;
}
```
Differential Revision: https://reviews.llvm.org/D148980
Jay Foad [Mon, 17 Apr 2023 10:06:06 +0000 (11:06 +0100)]
[BranchFolder] Skip redundant IMPLICIT_DEFs of subregs
Differential Revision: https://reviews.llvm.org/D148509
Jay Foad [Mon, 17 Apr 2023 10:05:14 +0000 (11:05 +0100)]
[BranchFolder] Precommit AMDGPU test case for D148509
Alvin Wong [Mon, 24 Apr 2023 13:52:18 +0000 (21:52 +0800)]
[lit] Set __COMPAT_LAYER=RunAsInvoker when running tests on Windows
Windows heuristics try to detect old installer programs and run them as
elevated. These heuristics include checking for certain substrings in
file names, e.g. "patch", "update", "setup". When lit tries to run
affected executables, it produces "[WinError 740] The requested
operation requires elevation" instead. Several tests have been affected
by this issue (see https://reviews.llvm.org/D137772,
https://reviews.llvm.org/D148988, https://reviews.llvm.org/D149004).
We should set this environment variable to disable this heuristic once
and for all, instead of setting it in inidividual test suites. There
should be no lit tests that legitimately want to run as elevated.
Differential Revision: https://reviews.llvm.org/D149064
Lorenzo Chelini [Wed, 26 Apr 2023 09:08:31 +0000 (11:08 +0200)]
[MLIR][Linalg] Change destination logic in `bubbleUpPackOpThroughGenericOp`.
In `bubbleUpPackOpThroughGenericOp`, we replaced the init operands with
a new `tensor.empty` if the operation was a pure element-wise op. This
behaviour is not wrong but not ideal because we "break" the original
use-def-chain of the output operand by materializing a new
`tensor.empty`. We should use `tensor.empty` as a destination *only* if the
initial init operand was already a `tensor.empty`, as we do in
`PushDownUnpack`.
Reviewed By: hanchung
Differential Revision: https://reviews.llvm.org/D149250
Nicolai Hähnle [Wed, 26 Apr 2023 13:18:51 +0000 (15:18 +0200)]
AMDGPU: Fix an assertion in SIOptimizeVGPRLiveRange
As the comment notes, the shader results in an INSERT_SUBREG with
"undef" (dead) operand in the Endif block. The same can happen with
REG_SEQUENCE. The register is considered dead from a liveness
analysis perspective. The correct thing to do seems to be nothing:
we keep the undef use of the register, the register allocator should
still be able to take the liveness into account correctly.
Differential Revision: https://reviews.llvm.org/D149161
Kito Cheng [Thu, 27 Apr 2023 06:35:15 +0000 (14:35 +0800)]
[RISCV][Driver] Allow the use of CPUs with a different XLEN than the triple.
Our downstream toolchain release got some issue is we set the default
triple by creating symbolic link of clang like `riscv64-unknown-elf-clang`,
and has lots of multi-lib config including rv32's config.
However when we trying to set arch by a 32 bit CPU like generic-rv32
but got error message below:
error: unsupported argument 'generic-rv32' to option '-mcpu='
`generic-rv32` is listed in the output of `-mcpu=help`, that
might be confusing for user since help message say supported.
So let clang driver also consider -mcpu option during computing
the target triple to archvie that.
Reviewed By: asb, craig.topper
Differential Revision: https://reviews.llvm.org/D148124
Vitaly Buka [Wed, 26 Apr 2023 23:26:48 +0000 (16:26 -0700)]
[HWASAN] Use InTaggableRegion in basic tagging functions
For primary use-case when !HWASAN_ALIASING_MODE the function is constant
true and should be eliminated by optimizations.
In case HWASAN_ALIASING_MODE all new calls to the functions were missing
in the first place. We just not use this mode for anything but tests, so
we didn't noticed.
Addressing @thurston comment on D149293
Reviewed By: thurston
Differential Revision: https://reviews.llvm.org/D149305
Vitaly Buka [Wed, 26 Apr 2023 02:36:26 +0000 (19:36 -0700)]
[HWASAN] Untag pointer with TagMaskByte instead 0xFF
This applies only X86_64 where mask is 0x3F.
Reviewed By: kstoimenov
Differential Revision: https://reviews.llvm.org/D149227
Yi Kong [Fri, 31 Mar 2023 09:08:16 +0000 (17:08 +0800)]
[BOLT] Parallelize legacy profile merging
Merging profiles is quite expensive, but easily paralleizable.
8359 profiles on n2d-standard-128:
single-thread: 808s
multi-thread: 200s (~75% speed up)
Differential Revision: https://reviews.llvm.org/D149014
Vitaly Buka [Wed, 26 Apr 2023 02:32:25 +0000 (19:32 -0700)]
[HWASAN] Fix X86 ClInstrumentWithCalls
It was always ON for X86.
Vitaly Buka [Wed, 26 Apr 2023 02:29:05 +0000 (19:29 -0700)]
[NFC][hwasan] Precommit X86 inline tests
-hwasan-instrument-with-calls is broken on X86.
Kazu Hirata [Thu, 27 Apr 2023 06:29:03 +0000 (23:29 -0700)]
[clang] Modernize DelayedDiagnostics (NFC)
Kazu Hirata [Thu, 27 Apr 2023 06:29:02 +0000 (23:29 -0700)]
[mlir] Replace None with std::nullopt in comments (NFC)
This is part of an effort to migrate from llvm::Optional to
std::optional:
https://discourse.llvm.org/t/deprecating-llvm-optional-x-hasvalue-getvalue-getvalueor/63716
Chuanqi Xu [Thu, 27 Apr 2023 06:19:32 +0000 (14:19 +0800)]
[C++20] [Modules] Avoid crash if the inconsistency the size of lang options exceeds 1
Close https://github.com/llvm/llvm-project/issues/62359
The root reason for the crash is that we didn't test the case that
the bits number of a language option exceeds 1.
Théo Degioanni [Thu, 27 Apr 2023 06:00:39 +0000 (06:00 +0000)]
[mlir] Add a generic mem2reg implementation.
This patch introduces a generic implementation of mem2reg on
unstructured control-flow, along with a specialization for LLVM IR. This
is achieved by defining three new interfaces, representing 1. allocating
operations, 2. operations doing memory accesses, 3. operations that can
be rewired and/or deleted to stop using a specific use.
The file containing the core implementation of the algorithm
(`Mem2Reg.cpp`) contains a detailed explanation of how the algorithm
works. The contract for this pass is that given a memory slot with a
single non-aliased pointer, the pass will either remove all the uses of
the pointer or not change anything.
To help review this patch, I recommend starting by looking at the
interfaces defined in `Mem2Reg.td`, along with their reference
implementation for LLVM IR defined in `LLVMMem2Reg.cpp`. Then, the core
algorithm is implemented in `Mem2Reg.cpp`.
If this is all good I also have an implementation of the interfaces for
0-dimensional memref promotion that I can upstream afterwards.
Reviewed By: gysit
Differential Revision: https://reviews.llvm.org/D148109
Tobias Gysi [Thu, 27 Apr 2023 05:45:46 +0000 (05:45 +0000)]
[mlir][llvm] Add assertion in LLVM IR import (NFC).
This revision adds an assertion to convertConstantExpr to ensure the
function is not called if the constant has been converted before.
This is a follow up for https://reviews.llvm.org/D149247.
Reviewed By: victor-eds
Differential Revision: https://reviews.llvm.org/D149253
Noah Goldstein [Thu, 27 Apr 2023 03:00:53 +0000 (22:00 -0500)]
[X86] Support `X86ISD::PCMPEQ` and `X86ISD::PCMPGT` in ComputeKnownBits
These functions where missing support but are used enough that it
makes sense to track them.
Reviewed By: RKSimon
Differential Revision: https://reviews.llvm.org/D148963
Noah Goldstein [Thu, 27 Apr 2023 03:00:32 +0000 (22:00 -0500)]
[ValueTracking] Add logic for `add nuw x,y != 0` -> `x != 0 || y != 0`
Alive2 Link:
https://alive2.llvm.org/ce/z/TKpqxc
Reviewed By: nikic
Differential Revision: https://reviews.llvm.org/D149204
Noah Goldstein [Tue, 25 Apr 2023 18:47:49 +0000 (13:47 -0500)]
[ValueTracking] Add logic for `(sub x, y) != 0` if we know `KnownX != KnownY`
Alive2 Link:
https://alive2.llvm.org/ce/z/TAFcjF
Differential Revision: https://reviews.llvm.org/D149202
Noah Goldstein [Tue, 25 Apr 2023 18:46:41 +0000 (13:46 -0500)]
[ValueTracking] Add some additional tests for `isKnownNonZero`; NFC
Differential Revision: https://reviews.llvm.org/D149201
Serguei Katkov [Wed, 29 Mar 2023 05:37:03 +0000 (12:37 +0700)]
[InstSimplify] Extend handlng of fp min/max.
Add support the cases like
m(m(X,Y),m'(X,Y)) => m(X,Y)
where m is one of maxnum, minnum, maximum, minimum and
m' is m or inverse of m.
alive2 correctness check:
maxnum(maxnum,maxnum) https://alive2.llvm.org/ce/z/kSyAzo
maxnum(maxnum,minnum) https://alive2.llvm.org/ce/z/Vra8j2
minnum(minnum,minnum) https://alive2.llvm.org/ce/z/B6h-hW
minnum(minnum,maxnum) https://alive2.llvm.org/ce/z/rG2u_b
maximum(maximum,maximum) https://alive2.llvm.org/ce/z/N2nevY
maximum(maximum,minimum) https://alive2.llvm.org/ce/z/23RFcP
minimum(minimum,minimum) https://alive2.llvm.org/ce/z/spHZ-U
minimum(minimum,maximum) https://alive2.llvm.org/ce/z/Aa-VE8
Reviewed By: dantrushin, RKSimon
Differential Revision: https://reviews.llvm.org/D147137
Fangrui Song [Thu, 27 Apr 2023 03:43:11 +0000 (20:43 -0700)]
[LTO] Change getThinLTOOutputFile to take StringRef
Yeting Kuo [Mon, 17 Apr 2023 07:26:51 +0000 (15:26 +0800)]
[RISCV] Support vector strict rounding operations.
The patch basically models custom lowering of base rounding operations to expand
rounding by coverting to ingter and coverting back to FP. The other one thing
the patch does is to covert sNan of the source to qNan.
Reviewed By: craig.topper
Differential Revision: https://reviews.llvm.org/D148519
luxufan [Thu, 27 Apr 2023 02:40:27 +0000 (10:40 +0800)]
[ValueTracking] Guaranteed not to be undef if has dereferenceable attribute
As LangRef says, "dereferenceable<n> implies noundef".
`isGuaranteedNotToBeUndefOrPoison` should return true if the parameter
has dereferenceable attribute.
Reviewed By: nikic
Differential Revision: https://reviews.llvm.org/D149035
Vitaly Buka [Wed, 26 Apr 2023 23:20:04 +0000 (16:20 -0700)]
[NFC][HWASAN] Move InTaggableRegion
Prepare to use it in all tag related functions.
Reviewed By: thurston
Differential Revision: https://reviews.llvm.org/D149304
Vitaly Buka [Thu, 27 Apr 2023 02:41:26 +0000 (19:41 -0700)]
Revert "[SPARC][MC] Fix encoding of backwards BPr branches"
Introduces UB, details in D144012.
This reverts commit
92f1156efc5f762ac3a4cc4eebe62742f6d75789.
Vitaly Buka [Wed, 26 Apr 2023 00:48:24 +0000 (17:48 -0700)]
[HWASAN] Support tagged stack pointer
If stack was allocated using regular allocator, it may be tagged
and it will make memToShadow calculate invalid offset.
Also when UAR tag should be the tag of the stack frame pointer.
Reviewed By: eugenis
Differential Revision: https://reviews.llvm.org/D149228
Vitaly Buka [Wed, 26 Apr 2023 07:50:34 +0000 (00:50 -0700)]
[hwasan] Implement __sanitizer_purge_allocator
Reviewed By: kstoimenov
Differential Revision: https://reviews.llvm.org/D149241
Wu, Yingcong [Thu, 27 Apr 2023 01:59:49 +0000 (18:59 -0700)]
[libfuzzer] avoid unneccessary auto-copy
Avoid an unneccessary auto-copy
Reviewed By: vitalybuka
Differential Revision: https://reviews.llvm.org/D148902
Wu, Yingcong [Thu, 27 Apr 2023 01:56:30 +0000 (18:56 -0700)]
[sanitizer] move a pointer dereference after its null check
The dereference of pointer `ctx` is not protected by its null check, this could be problematic.
Reviewed By: vitalybuka, MaskRay
Differential Revision: https://reviews.llvm.org/D149011
Vitaly Buka [Wed, 26 Apr 2023 06:35:20 +0000 (23:35 -0700)]
[HWASAN] Fix __sanitizer_get_allocated_{begin,size}
HWASAN_ALIASING_MODE needs to untag only
primary allocator pointers.
Reviewed By: kstoimenov, thurston
Differential Revision: https://reviews.llvm.org/D149238
DianQK [Thu, 27 Apr 2023 00:10:15 +0000 (08:10 +0800)]
[GlobalOpt] Don't replace the aliasee if it has other references.
As long as aliasee has `@llvm.used` or `@llvm.compiler.used` references, we cannot do the related replace or delete operations. Even if it is a Local Linkage, we cannot infer if there is no other use for it, such as asm or other future added cases.
Reviewed By: nikic
Differential Revision: https://reviews.llvm.org/D145293
Vitaly Buka [Wed, 26 Apr 2023 21:03:49 +0000 (14:03 -0700)]
[HWASAN] Fix HwasanReallocate in aliasing mode
HWASAN_ALIASING_MODE needs to untag only
primary allocator pointers.
Reviewed By: kstoimenov
Differential Revision: https://reviews.llvm.org/D149293
Haohai Wen [Thu, 27 Apr 2023 01:32:44 +0000 (09:32 +0800)]
Always emit symbol table when dwarf section exists in COFF
This also fixes check prefix NO which is pointless in symtab.test
Reviewed By: mstorsjo
Differential Revision: https://reviews.llvm.org/D149235
H.J. Lu [Wed, 26 Apr 2023 23:34:08 +0000 (16:34 -0700)]
[sanitizer] Correct alignment of x32 __sanitizer_siginfo
Since alignment of x32 siginfo_t is 8 bytes, not 4 bytes, use u64 in
__sanitizer_siginfo_pad to align x32 __sanitizer_siginfo to 8 bytes.
Fixes https://github.com/llvm/llvm-project/issues/62394
Differential Revision: https://reviews.llvm.org/D149309
Raghu Maddhipatla [Thu, 13 Apr 2023 16:33:21 +0000 (11:33 -0500)]
[OpenMP][Flang][Semantics] Add semantics support for USE_DEVICE_PTR clause on OMP TARGET DATA directive.
Initial support for USE_DEVICE_PTR clause on OMP TARGET DATA directive.
Reviewed By: kiranchandramohan
Differential Revision: https://reviews.llvm.org/D148254
walter erquinigo [Thu, 27 Apr 2023 00:09:26 +0000 (19:09 -0500)]
[lldb] Create a way to force remove commands
Some LLDB set ups need to hide certain commands for security reasons, so I'm adding a flag that allows removing non-user commands.
Differential Revision: https://reviews.llvm.org/D149312
Gulfem Savrun Yeniceri [Wed, 26 Apr 2023 22:49:09 +0000 (22:49 +0000)]
[clang] Apply -fcoverage-prefix-map reverse order
This patch changes handling multiple -fcoverage-prefix-map options to
match GCC's behavior. GCC applies prefix remappings that are provided
in reverse order (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109591).
Reviewed By: phosek
Differential Revision: https://reviews.llvm.org/D148757
Craig Topper [Thu, 27 Apr 2023 00:11:58 +0000 (17:11 -0700)]
[RISCV] Remove the uret instruction.
This was part of the N extension which did not make it into
version 1.12 of the privilege specification.
Reviewed By: jrtc27
Differential Revision: https://reviews.llvm.org/D149308
Chia-hung Duan [Tue, 25 Apr 2023 07:32:57 +0000 (07:32 +0000)]
[scudo] Fix missing pushing 1 block to BatchClassId
This was happened rarely. The only case is when a thread is teared down
and it only has one block of BatchClass and the freelist of BatchClass
is empty. The impact is leaking 1 block of BatchClass and which is minor.
Differential Revision: https://reviews.llvm.org/D149141
Jorge Gorbe Moya [Thu, 27 Apr 2023 00:01:39 +0000 (17:01 -0700)]
[bazel][NFC] Run buildifier on libc/libc_build_rules.bzl.
Vitaly Buka [Wed, 26 Apr 2023 23:58:37 +0000 (16:58 -0700)]
[NFC][sanitizer] Fix typo
Vitaly Buka [Wed, 26 Apr 2023 23:57:13 +0000 (16:57 -0700)]
[test][HWASAN] XFAIL broken test on aarch64
Richard Smith [Wed, 26 Apr 2023 23:53:34 +0000 (16:53 -0700)]
Pass the found declaration to DiagnoseUseOfDecl.
Don't pass in the resolved declaration, because that might be an
inheriting constructor declaration, which should never be used directly
and for which constraint satisfaction checking doesn't work.
Fixes #62361.
Michael Maitland [Mon, 24 Apr 2023 14:53:56 +0000 (07:53 -0700)]
[llvm-mca][RISCV] Fix checking if data valid in createInstrument
Fixes createInstrument to return instrument when LMUL data is valid, and
return nullptr when LMUL data is not valid for RISCV target.
Differential Revision: https://reviews.llvm.org/D149068
Vitaly Buka [Wed, 26 Apr 2023 23:48:38 +0000 (16:48 -0700)]
[test][HWASAN] Suppress memory leak in getpass
Reported after D149234.
Vitaly Buka [Wed, 26 Apr 2023 23:38:24 +0000 (16:38 -0700)]
Revert "[test][HWASAN] Suppress memory leak in getpass"
Does not fix the leak.
This reverts commit
1533478615e998192e227bded9d0e9029474936b.
Henry Yu [Wed, 26 Apr 2023 23:43:48 +0000 (16:43 -0700)]
[FuzzMutate] Skip EHPad during mutation and avoid replacing callee with pointer when sinking
This patch addresses 2 problems:
- In `ShuffleBlockStrategy`, when `BB` is an EHPad, `BB.getFirstInsertionPt()` will return `BB.end()`, which cannot be dereferenced and will cause crash in following loop.
- In `isCompatibleReplacement`, a call instruction's callee might be replaced by a pointer, causing 2 subproblems:
- we cannot guarantee that the pointer is a function pointer (even if it is, we cannot guarantee it matches the signature).
- after such a replacement, `getCalledFunction` will from then on return `nullptr` (since it's indirect call) which causes Segmentation Fault in the lines below.
This patch fixes the first problem by checking if a block to be mutated is an EHPad in base class `IRMutationStrategy` and skipping mutating it if so.
This patch fixes the second problem by avoiding replacing callee with pointer and adding a null check for indirect calls.
Reviewed By: Peter
Differential Revision: https://reviews.llvm.org/D148853
Matt Arsenault [Sat, 29 Oct 2022 20:01:58 +0000 (13:01 -0700)]
VE: Register null MCTargetStreamer
Matt Arsenault [Sun, 20 Nov 2022 16:33:14 +0000 (08:33 -0800)]
HIP: Directly call fma builtins
Shubham Sandeep Rastogi [Wed, 5 Apr 2023 16:05:06 +0000 (09:05 -0700)]
Emit unwind information in .debug_frame section when .cfi_sections .debug_frame intrinsic is used
The .cfi_sections .debug_frame intrinsic is used to emit .debug_frame
section. This directive tells the assembler to write out a section of
debug frame data. AArch64 is a platform where eh_frame is not needed for
unwind information. Unfortunately, that means that even when the
.cfi_sections .debug_frame intrinsic is used, the compiler skips
emitting the CIE's and FDE's in the debug_frame section. This patch
address that issue by making sure that the emission of CIE's and FDE's
are only skipped if the unwind information does not require a
debug_frame section and is a platform where the eh_frame can be skipped.
Differential Revision: https://reviews.llvm.org/D147980
Shubham Sandeep Rastogi [Thu, 6 Apr 2023 21:30:27 +0000 (14:30 -0700)]
Add tests to verify behavior of .cfi_sections .debug_frame intrinsic.
There was some lacking test coverage for checking when the
.cfi_sections .debug_frame intrinsic is emitted. On x86_64,
with -fno-exceptions there is no .cfi_sections .debug_frame intrinsic
emitted because there is an unwind table attribute.
On AArch64, with -fno-exceptions, there is no unwind table attribute, so
the .cfi_sections .debug_frame intrinsic is emitted correctly.
Alternatively, with -fexceptions, both AArch64 and x86_64 emit an unwind
table and therefore do not emit a .cfi_sections .debug_frame intrinsic
All this work was done in addition to https://reviews.llvm.org/D139663
patch.
Differential Revision: https://reviews.llvm.org/D147747
Vitaly Buka [Wed, 26 Apr 2023 23:11:30 +0000 (16:11 -0700)]
[test][HWASAN] Suppress memory leak in getpass
Reported after D149234.
Vitaly Buka [Wed, 26 Apr 2023 23:10:30 +0000 (16:10 -0700)]
[test][sanitizer] Reformat the test
Siva Chandra Reddy [Wed, 26 Apr 2023 22:11:31 +0000 (22:11 +0000)]
[libc] Add a new target named LibcHermeticTestMain.
The existing LibcTestMain has been renamed to LibcUnitTestMain.
Hermetic tests are linked to LibcHermeticTestMain and unit tests are
linked to LibcUnitTestMain.
Reviewed By: jhuber6
Differential Revision: https://reviews.llvm.org/D149303
Alex Langford [Wed, 26 Apr 2023 22:01:12 +0000 (15:01 -0700)]
[lldb] Change return type of FileSpec::GetFileNameExtension
These don't really need to be in ConstStrings. It's nice that comparing
ConstStrings is fast (just a pointer comparison) but the cost of
creating the ConstString usually already includes the cost of doing a
StringRef comparison anyway, so this is just extra work and extra memory
consumption for basically no benefit.
Differential Revision: https://reviews.llvm.org/D149300
Brad Smith [Wed, 26 Apr 2023 22:53:52 +0000 (18:53 -0400)]
[SPARC][MC] Fix encoding of backwards BPr branches
Make sure that the upper bits of the offset is placed in bits 20-21 of the
instruction word.
This fixes the encoding of backwards (negative offset) BPr branches.
(Previously, the upper two bits of the offset would overwrite parts of the rs1
field, causing it to branch on the wrong register, with the wrong offset)
Reviewed By: arsenm
Differential Revision: https://reviews.llvm.org/D144012
Brad Smith [Wed, 26 Apr 2023 22:50:49 +0000 (18:50 -0400)]
[SPARC] Lower BR_CC to BPr on 64-bit target whenever possible
On 64-bit target, when doing i64 BR_CC where one of the comparison operands is a
constant zero, try to fold the compare and BPcc into a BPr instruction.
For all integers, EQ and NE comparison are available, additionally for signed
integers, GT, GE, LT, and LE is also available.
Reviewed By: arsenm
Differential Revision: https://reviews.llvm.org/D142461
Fabian Mora [Wed, 26 Apr 2023 22:52:37 +0000 (17:52 -0500)]
[mlir][GPUDialect] Implement memory attributions for LaunchOp
Currently memory attributions are not supported for gpu::LaunchOp, this patch implements memory attributions for gpu::LaunchOp and modifies the KernelOutlining pass to make the attributions available in GPUFuncOp.
Reviewed By: makslevental
Differential Revision: https://reviews.llvm.org/D147809
max [Wed, 26 Apr 2023 20:27:07 +0000 (15:27 -0500)]
[MLIR][python bindings] Add some AttrBuilder and port _exts to use them.
Differential Revision: https://reviews.llvm.org/D149287
Jason Molenda [Wed, 26 Apr 2023 22:44:39 +0000 (15:44 -0700)]
Fix CI failure - this depended on constants only defined on arm64 macs
Congcong Cai [Mon, 24 Apr 2023 22:30:58 +0000 (00:30 +0200)]
[Sema]Select correct lexical context during template instantiate
This patch wants to fix inline friend decl like
```
template <class F1> int foo(F1 X);
template <int A1> struct A {
template <class F1> friend int foo(F1 X) { return A1; }
};
template struct A<1>;
int a = foo(1.0);
```
Differential Revision: https://reviews.llvm.org/D149009
Vitaly Buka [Sun, 23 Apr 2023 07:03:58 +0000 (00:03 -0700)]
[NFC][HWASAN] Move getUARTag into the Entry
Reviewed By: kstoimenov, eugenis
Differential Revision: https://reviews.llvm.org/D149221
Vitaly Buka [Sun, 23 Apr 2023 06:40:50 +0000 (23:40 -0700)]
[HWASAN] Remove UAR tag branch !ClUARRetagToZero
This is leftover from older version of HWASAN.
The current HWASAN assumes that the new stack
frames are tagged with zeroes, which make getNextTagWithCall
or StackTag ^ TagMaskByte unusable.
Reviewed By: kstoimenov, eugenis
Differential Revision: https://reviews.llvm.org/D149220
Joseph Huber [Wed, 26 Apr 2023 22:07:47 +0000 (17:07 -0500)]
[libc][fix] Also remove the headers for the other flags
Summary:
This patch makes this only apply to the GPU build. This should be
handled more intelligently in the future so it's common between all of t
hem.
Jonas Devlieghere [Wed, 26 Apr 2023 22:00:57 +0000 (15:00 -0700)]
[lldb] `or` -> `||` in SBDefines.h
Address Dave's post-commit review feedback from
https://reviews.llvm.org/D147736#inline-1441914
Joseph Huber [Wed, 26 Apr 2023 21:58:08 +0000 (16:58 -0500)]
[libc][fix] Only add the hermetic test flags in GPU mode
Summary:
This is a little broken, what we really need is a separate target to use
with the hermetic tests, but this is a stop-gap to get the bots green
again.
Alex Langford [Wed, 26 Apr 2023 17:54:02 +0000 (10:54 -0700)]
[lldb] Remove finding .Bundle directories in PlatformDarwinKernel
Jason isn't sure what this is used for and isn't aware of a .Bundle
suffix related to kernel debugging. Let's remove it.
Differential Revision: https://reviews.llvm.org/D149284
Joseph Huber [Wed, 26 Apr 2023 02:34:59 +0000 (21:34 -0500)]
[libc] Partially implement `atexit` on the GPU
The `atexit` function controls registering functions to call at the end
of the program. This is difficult to do in general on the GPU because of
the lack of a real mutex implementation. We primarily provide this for
testing where we can explicitly restrict how the `atexit` registration
functions are called. So we simply create a passthrough Mutex to get
past the usage of it as per @sivachandra's suggestion.
Depends on D149225
Reviewed By: sivachandra
Differential Revision: https://reviews.llvm.org/D149226
Joseph Huber [Wed, 26 Apr 2023 02:32:22 +0000 (21:32 -0500)]
[libc] Correctly pass 'CXX_STANDARD' to the packaged GPU build
We need to perform the GPU build separately. The `CXX_STANDARD` option
was not being passed properly.
Reviewed By: sivachandra
Differential Revision: https://reviews.llvm.org/D149225
Joseph Huber [Wed, 26 Apr 2023 00:03:43 +0000 (19:03 -0500)]
[libc] Enable the GPU build to build the UnitTest library
The previous patch in D149216 allows us to use the internal `<stdlib.h>`
include for the GPU build. However, we currently don't provide the
memory functions so the header wasn't resolving them. This patch adds
these as entrypoints. They don't cause any entrypoints to be emitted
because they are not implemented, but they provide it in the header so
that we can rely on the test's implementation of them.
Depends on D149216
Reviewed By: sivachandra
Differential Revision: https://reviews.llvm.org/D149217
Joseph Huber [Tue, 25 Apr 2023 23:29:35 +0000 (18:29 -0500)]
[libc] Add path to include generated headers for hermetic tests
The generated header files live in the build directory's include path.
When targeting a hermetic build we want to make sure we only use headers
generated by the project itself if availible.
Reviewed By: sivachandra
Differential Revision: https://reviews.llvm.org/D149216
Leonard Chan [Wed, 26 Apr 2023 21:48:37 +0000 (21:48 +0000)]
[hwasan] Do not memset allocation if it comes from the secondary allocator
The secondary allocator calls mmap which should return zero-inited pages, so we
don't need to explicitly memset it with zeros. This is similar to what asan's
calloc does.
Differential Revision: https://reviews.llvm.org/D149285
Michael Jones [Mon, 27 Mar 2023 22:14:17 +0000 (15:14 -0700)]
[libc][bazel] add file printf targets and support
This patch adds targets for printf and fprintf to the bazel build.
Additionally, it adds support for the build system to specify where
files should be written for testing purposes. This was necessary to
enable the fprintf test under bazel.
Reviewed By: sivachandra
Differential Revision: https://reviews.llvm.org/D147008
Matt Arsenault [Fri, 23 Dec 2022 23:33:34 +0000 (18:33 -0500)]
AMDGPU: Remove invalid testcase for enqueue kernel
The call didn't have the right calling convention, but calls to
kernels are supposed to be illegal anyway.
David Green [Wed, 26 Apr 2023 21:12:00 +0000 (22:12 +0100)]
[AArch64][SVE] Generate smull/umull instead of sve v2i64 mul
A neon smull/umull should be preferred over a sve v2i64 mul with two extends.
It will be both less instructions and a lower cost multiply instruction.
Differential Revision: https://reviews.llvm.org/D148248
Vitaly Buka [Wed, 26 Apr 2023 21:01:18 +0000 (14:01 -0700)]
[test][HWASAN] Add hwasan-aliasing
Some tests of D149234 deppend on
aliasing mode.
Jan Sjodin [Wed, 26 Apr 2023 20:39:14 +0000 (16:39 -0400)]
[OpenMP][Flang][MLIR] Add lowering of TargetOp for host codegen to LLVM-IR
Fix uninitialied value use introduced in
d3f9388ffb889d2ef512a17b9c4d37d09f03c693
Craig Topper [Wed, 26 Apr 2023 20:35:20 +0000 (13:35 -0700)]
[RISCV] Remove CSR names that are not in Privileged Specification 1.12.
These are from the N extension (User-Level Interrupts) which did
not make it into 1.12 of the Privileged Specification.
D117653 also tried to remove some of these, but it was never reviewed.
Reviewed By: jrtc27
Differential Revision: https://reviews.llvm.org/D149278
Fangrui Song [Wed, 26 Apr 2023 20:18:55 +0000 (13:18 -0700)]
[ELF] Add --remap-inputs= and --remap-inputs-file=
--remap-inputs-file= can be specified multiple times, each naming a
remap file that contains `from-glob=to-file` lines or `#`-led comments.
('=' is used a separator a la -fdebug-prefix-map=)
--remap-inputs-file= can be used to:
* replace an input file. E.g. `"*/libz.so=exp/libz.so"` can replace a resolved
`-lz` without updating the input file list or (if used) a response file.
When debugging an application where a bug is isolated to one single
input file, this option gives a convenient way to test fixes.
* remove an input file with `/dev/null` (changed to `NUL` on Windows), e.g.
`"a.o=/dev/null"`. A build system may add unneeded dependencies.
This option gives a convenient way to test the result removing some inputs.
`--remap-inputs=a.o=aa.o` can be specified to provide one pattern without using
an extra file.
(bash/zsh process substitution is handy for specifying a pattern without using
a remap file, e.g. `--remap-inputs-file=<(printf 'a.o=aa.o')`, but it may be
unavailable in some systems. An extra file can be inconvenient for a build
system.)
Exact patterns are tested before wildcard patterns. In case of a tie, the first
patterns wins. This is an implementation detail that users should not rely on.
Co-authored-by: Marco Elver <elver@google.com>
Link: https://discourse.llvm.org/t/rfc-support-exclude-inputs/70070
Reviewed By: melver, peter.smith
Differential Revision: https://reviews.llvm.org/D148859
LLVM GN Syncbot [Wed, 26 Apr 2023 20:11:45 +0000 (20:11 +0000)]
[gn build] Port
244560329603
Nikolas Klauser [Fri, 21 Apr 2023 03:48:10 +0000 (05:48 +0200)]
[libc++][PSTL] Integrate the headers and add a CI job
Reviewed By: ldionne, #libc
Spies: libcxx-commits, arichardson
Differential Revision: https://reviews.llvm.org/D141780
Patrick McCormick [Wed, 26 Apr 2023 19:49:58 +0000 (13:49 -0600)]
[flang] Raise configure-time error when LLVM_ENABLE_EH is set
flang cannot be built with exceptions enabled. Doing so results in a link-time
error.
This addresses issue #59353 [https://github.com/llvm/llvm-project/issues/59353]
Differential Revision: https://reviews.llvm.org/D146173
Jason Molenda [Wed, 26 Apr 2023 20:04:38 +0000 (13:04 -0700)]
Fix off-by-one error in armv7 mach-o corefile register context
The sanity check on the size of the register context we found in
the corefile was off by one, so lldb would not add the register
contents. Add a test case to ensure it doesn't regress.
Differential Revision: https://reviews.llvm.org/D149224
rdar://
108306070
Vitaly Buka [Mon, 24 Apr 2023 04:43:32 +0000 (21:43 -0700)]
[test][HWASAN] Regenerate some HWASAN tests
Example of the command used to update tests:
```
ninja -C <build_dir> opt && llvm/utils/update_test_checks.py \
--opt-binary <build_dir>/bin/opt llvm/test/Instrumentation/HWAddressSanitizer/X86/alloca.ll
```
Reviewed By: kstoimenov
Differential Revision: https://reviews.llvm.org/D149219
Vitaly Buka [Wed, 26 Apr 2023 06:15:34 +0000 (23:15 -0700)]
[HWASAN] Run sanitizer_common tests
ninja check-sanitizer will run tests with hwasan as well
Reviewed By: kstoimenov
Differential Revision: https://reviews.llvm.org/D149234
Vitaly Buka [Wed, 26 Apr 2023 06:15:34 +0000 (23:15 -0700)]
[test][HWASAN] Add XFAILs for missing hwasan features
Reviewed By: thurston
Differential Revision: https://reviews.llvm.org/D149271
Alex Langford [Wed, 26 Apr 2023 19:38:53 +0000 (12:38 -0700)]
[lldb] Skip Watchpoint/ExpressionLanguage.test on Windows
This test fails on the aarch64-windows bots unfortunately. Mark as
unsupported.
Context: https://lab.llvm.org/buildbot/#/builders/219/builds/2389
Aaron Ballman [Wed, 26 Apr 2023 19:29:02 +0000 (15:29 -0400)]
Fix Clang sphinx bot
Addresses the issue found in:
https://lab.llvm.org/buildbot/#/builders/92/builds/43413
ipriyanshi1708 [Wed, 26 Apr 2023 19:18:40 +0000 (15:18 -0400)]
Fix the diagnostic about attribute placement for scoped enumerations
Fixed the error message for attribute placement. Earlier it was showing
'place it after "enum"' but it should be 'place it after "enum class"'
which I have fixed in this patch.
Fixes https://github.com/llvm/llvm-project/issues/61660
Differential Revision: https://reviews.llvm.org/D147989
max [Wed, 26 Apr 2023 14:55:27 +0000 (09:55 -0500)]
[MLIR][python bindings] Reimplement `replace_all_uses_with` on `PyValue`
Differential Revision: https://reviews.llvm.org/D149261
Zarko Todorovski [Wed, 26 Apr 2023 17:43:12 +0000 (13:43 -0400)]
[Clang][AIX] Add back error for -fprofile-sample-generate/use on AIX
D148177 also removed the error for sampling based profiling which is not currently
supported on AIX. Adding that error back.
Reviewed By: qiongsiwu1
Differential Revision: https://reviews.llvm.org/D148960