tools/librpm-tizen.git
14 years agoDo not emit perl(#) dependencies for multiline use/require with comments.
Ville Skyttä [Sun, 24 Jan 2010 11:28:44 +0000 (13:28 +0200)]
Do not emit perl(#) dependencies for multiline use/require with comments.

For example:

    use # comment goes here
        Foo::Bar;

14 years agoUpdated Polish translation from Piotr Drąg
Panu Matilainen [Mon, 25 Jan 2010 10:19:05 +0000 (12:19 +0200)]
Updated Polish translation from Piotr Drąg

14 years agoDocument --conflicts in rpm(8).
Ville Skyttä [Sat, 23 Jan 2010 12:50:17 +0000 (14:50 +0200)]
Document --conflicts in rpm(8).

14 years agoUse %{__make} macro instead of "make"
Panu Matilainen [Fri, 22 Jan 2010 12:51:43 +0000 (14:51 +0200)]
Use %{__make} macro instead of "make"
- allows easy overriding of the used make version for %make_install and
  %makeinstall

14 years agoReally fix verification error code to not depend on verbosity (RhBug:557101)
Panu Matilainen [Thu, 21 Jan 2010 12:14:28 +0000 (14:14 +0200)]
Really fix verification error code to not depend on verbosity (RhBug:557101)
- earlier fix from commit 6649c23cac5823d0c7415df5cfd66e5aac5eebd2 was
  broken as it could reset return code to zero after detecting errors
  earlier

14 years agoFix double-free segfault on url retrieve to read-only media (RhBug:557118)
Panu Matilainen [Thu, 21 Jan 2010 11:45:34 +0000 (13:45 +0200)]
Fix double-free segfault on url retrieve to read-only media (RhBug:557118)

14 years agoConcatenate multiline tags in macros only in case of
Jindrich Novy [Wed, 20 Jan 2010 09:28:40 +0000 (10:28 +0100)]
Concatenate multiline tags in macros only in case of
Requires/Obsoletes/Conflicts and Provides. Preserve
older behaviour for other tags.

14 years agoCorrectly expand %{obsoletes}, %{requires}, etc. in spec (RhBug:555926)
Jindrich Novy [Sat, 16 Jan 2010 11:43:16 +0000 (12:43 +0100)]
Correctly expand %{obsoletes}, %{requires}, etc. in spec (RhBug:555926)
- tags declared multiple times in spec were simply overwritten so
  referencing it via %{} just showed contents of the last one

14 years agoBump version to appear newer than 4.8.0, update translations too
Panu Matilainen [Fri, 8 Jan 2010 10:23:54 +0000 (12:23 +0200)]
Bump version to appear newer than 4.8.0, update translations too

14 years agoMerge branch 'master' of ssh://rpm.org/srv/projects/rpm/git/rpm
Panu Matilainen [Thu, 7 Jan 2010 15:07:50 +0000 (17:07 +0200)]
Merge branch 'master' of ssh://rpm.org/srv/projects/rpm/git/rpm

14 years agoRevert "Always free locally defined macros when they go out of scope"
Panu Matilainen [Thu, 7 Jan 2010 10:04:53 +0000 (12:04 +0200)]
Revert "Always free locally defined macros when they go out of scope"
- the "fix" breaks seemingly legitimate use in fedora font package
  macros, possibly some funky interaction with %{lua: } macros or something
- this reverts commit f895acd285366cf58cc3c97b5f188fecbfd782a8.

14 years agoAdd %{__id_u} back, duh
Panu Matilainen [Wed, 6 Jan 2010 10:57:48 +0000 (12:57 +0200)]
Add %{__id_u} back, duh
- appears to be rather commonly used afterall
- dont bother with the former id|sed foo though

14 years agoMove <stdio.h> includes out of system.h to the places that need it
Panu Matilainen [Tue, 5 Jan 2010 14:06:02 +0000 (16:06 +0200)]
Move <stdio.h> includes out of system.h to the places that need it

14 years agoLose <sys/types.h> and <sys/stat.h> includes from system.h
Panu Matilainen [Tue, 5 Jan 2010 14:01:46 +0000 (16:01 +0200)]
Lose <sys/types.h> and <sys/stat.h> includes from system.h
- these seem to be already included where needed through rpm's public
  header needs

14 years agoMove <ctype.h> include out of system.h to the places that need it
Panu Matilainen [Tue, 5 Jan 2010 13:33:47 +0000 (15:33 +0200)]
Move <ctype.h> include out of system.h to the places that need it

14 years agoMove <errno.h> include out of system.h to the places that need it
Panu Matilainen [Tue, 5 Jan 2010 13:25:31 +0000 (15:25 +0200)]
Move <errno.h> include out of system.h to the places that need it

14 years agoRemove <string.h> include from system.h into the few places that still need
Panu Matilainen [Tue, 5 Jan 2010 13:17:34 +0000 (15:17 +0200)]
Remove <string.h> include from system.h into the few places that still need
- most of the places get it through <rpm/rpmstring.h> already

14 years agoLoose string header compatibility goo
Panu Matilainen [Tue, 5 Jan 2010 13:09:08 +0000 (15:09 +0200)]
Loose string header compatibility goo
- <string.h> is required by C standard, we dont support ancient
  non-conformant compilers anyway

14 years agoInclude <stdlib.h> as necessary instead of system.h
Panu Matilainen [Tue, 5 Jan 2010 13:04:20 +0000 (15:04 +0200)]
Include <stdlib.h> as necessary instead of system.h
- also loose the related ancient compatibility goo

14 years agoShove the mount entry include voodoo where sun doesn't ... <cough> fs.c
Panu Matilainen [Tue, 5 Jan 2010 12:37:47 +0000 (14:37 +0200)]
Shove the mount entry include voodoo where sun doesn't ... <cough> fs.c

14 years agoRemove unnecessary NLS definitions from system.h
Panu Matilainen [Tue, 5 Jan 2010 12:28:47 +0000 (14:28 +0200)]
Remove unnecessary NLS definitions from system.h
- all uses of dgettext() and friends are already protected by
  appropriate ifdef's, no need to provide dummy defines here
- setlocale() and <locale.h> are required by C89, C99 and POSIX .. assume
  its there and if not, one can disable the whole thing with --disable-nls

14 years agoSanitize i18nTag() when NLS disabled
Panu Matilainen [Tue, 5 Jan 2010 12:14:23 +0000 (14:14 +0200)]
Sanitize i18nTag() when NLS disabled
- if NLS is disabled, the whole thing becomes just a plain old headerGet()

14 years agoRemove libcap stuff out of system.h
Panu Matilainen [Tue, 5 Jan 2010 11:29:52 +0000 (13:29 +0200)]
Remove libcap stuff out of system.h
- just a few places need, avoid polluting everything with it
- make fsm->fcaps void * to avoid having to deal with fcap_t not defined

14 years agofts.h requires <stdint.h>, include it there explicitly
Panu Matilainen [Tue, 5 Jan 2010 11:09:38 +0000 (13:09 +0200)]
fts.h requires <stdint.h>, include it there explicitly
- this has been masked by system.h including <netdb.h> which apparently
  brought in <stdint.h> as a side-effect
- commit 5c084f842ae21d861818a33922b5c77cb17ad8e4 broke compilation
  without capability support as <sys/capability.h> also happens to bring
  in <stdint.h>

14 years agoRemove unused selinux dummy defines
Panu Matilainen [Tue, 5 Jan 2010 10:51:36 +0000 (12:51 +0200)]
Remove unused selinux dummy defines

14 years agoMove <mcheck.h> include out of system.h to the couple of places that care
Panu Matilainen [Tue, 5 Jan 2010 10:36:37 +0000 (12:36 +0200)]
Move <mcheck.h> include out of system.h to the couple of places that care
- only two real users inside rpm
- remove mcheck foo from rpminject and rpmsort, we're not interested...

14 years agoUnconditionally include <sys/wait.h> where needed
Panu Matilainen [Tue, 5 Jan 2010 10:35:54 +0000 (12:35 +0200)]
Unconditionally include <sys/wait.h> where needed
- no point conditionalizing what we cant live without

14 years agoMove sys/mman.h include out of system.h to the places that care
Panu Matilainen [Tue, 5 Jan 2010 10:14:37 +0000 (12:14 +0200)]
Move sys/mman.h include out of system.h to the places that care
- just two places where needed, dont pollute system.h needlessly
- include depending on HAVE_MMAP instead of separately checking for
  sys/mman.h, if sys/mman.h doesn't exist or is broken HAVE_MMAP wont be set

14 years agoMove libacl.h include out of system.h to the only place that cares
Panu Matilainen [Tue, 5 Jan 2010 09:52:56 +0000 (11:52 +0200)]
Move libacl.h include out of system.h to the only place that cares

14 years agoEliminate SEEK_FOO and [RWXF]_OK definitions from system.h
Panu Matilainen [Tue, 5 Jan 2010 09:45:28 +0000 (11:45 +0200)]
Eliminate SEEK_FOO and [RWXF]_OK definitions from system.h
- systems not defining these constants are broken beyond our caring

14 years agoRemove unnecessary and broken time.h related configure + system.h checks
Panu Matilainen [Tue, 5 Jan 2010 09:33:51 +0000 (11:33 +0200)]
Remove unnecessary and broken time.h related configure + system.h checks
- the AC_HEADER_TIME check is unnecessary for any remotely recent systems,
  and the HAVE_SYS_TIME_H conditional in system.h is just broken as we
  dont even check for <sys/time.h> header in configure
- dont include from system.h, the time.h and sys/time.h get already
  included through our public headers where necessary

14 years agoUnconditionally include <netdb.h> where needed instead of system.h
Panu Matilainen [Tue, 5 Jan 2010 09:26:14 +0000 (11:26 +0200)]
Unconditionally include <netdb.h> where needed instead of system.h
- there's no fallback for missing netdb.h so there's little point
  conditionalizing it
- avoid yet more system.h pollution

14 years agoRemove pointless & unused configure checks
Panu Matilainen [Tue, 5 Jan 2010 08:56:56 +0000 (10:56 +0200)]
Remove pointless & unused configure checks
- vprintf(), vsnprintf() and snprintf() are in C99, no point checking
  especially as we dont have fallbacks for them
- no point testing for inline capability as we dont try to work around

14 years agoSanitize signature checking formatResult() a bit
Panu Matilainen [Tue, 5 Jan 2010 08:45:23 +0000 (10:45 +0200)]
Sanitize signature checking formatResult() a bit
- whole lotta unnecessary wankery here (what have I been thinking)
- avoid using the non-standard strndup(), we checked for it in configure
  but didn't provide an alternative so checking was just bogus

14 years agoOops, ftok() is really optional
Panu Matilainen [Tue, 5 Jan 2010 08:19:52 +0000 (10:19 +0200)]
Oops, ftok() is really optional

14 years agoClean up poll() vs select() tests
Panu Matilainen [Mon, 4 Jan 2010 15:15:26 +0000 (17:15 +0200)]
Clean up poll() vs select() tests
- move the includes out of system.h, not commonly needed
- <poll.h> is conditional as we actually provide a fallback through select(),
  but for <sys/select.h> missing there's no fallback so doesn't make
  much sense to test for (and both poll.h and sys/select.h are posix anyway...)

14 years agoRemove unused header checks from configure
Panu Matilainen [Mon, 4 Jan 2010 14:59:39 +0000 (16:59 +0200)]
Remove unused header checks from configure
- maybe these have been used at some point but not anymore...

14 years agoEliminate unused id -u tests
Panu Matilainen [Mon, 4 Jan 2010 14:31:10 +0000 (16:31 +0200)]
Eliminate unused id -u tests
- this was used by _fixowner and _fixgroup macros back in the day but they
  no longer exist as they're unusable without building as root

14 years agoUse MAP_FAILED instead of hardwired (void *)-1
Panu Matilainen [Mon, 4 Jan 2010 14:22:56 +0000 (16:22 +0200)]
Use MAP_FAILED instead of hardwired (void *)-1

14 years agoRe-enable mmap test in configure & fix the code build again
Panu Matilainen [Mon, 4 Jan 2010 14:20:11 +0000 (16:20 +0200)]
Re-enable mmap test in configure & fix the code build again
- this stuff has been disabled for years, lets see what breaks...

14 years agoRemove unnecessary stdint check from configure
Panu Matilainen [Mon, 4 Jan 2010 14:10:44 +0000 (16:10 +0200)]
Remove unnecessary stdint check from configure
- a leftover from pre-C99 requirement times

14 years agoRemove S_IFSOCK and S_IFLNK kludgery for ancient unixes
Panu Matilainen [Mon, 4 Jan 2010 14:07:11 +0000 (16:07 +0200)]
Remove S_IFSOCK and S_IFLNK kludgery for ancient unixes
- these are specified by POSIX 2001, it's not really rpm's job to
  provide them if the system doesn't

14 years agoRequire lchown() and remove ancient broken chown kludgery
Panu Matilainen [Mon, 4 Jan 2010 13:58:55 +0000 (15:58 +0200)]
Require lchown() and remove ancient broken chown kludgery
- lchown() is POSIX 2001, we dont care about older / nonconformant stuff

14 years agoCheck for our POSIX 2001 requirements and abort if not found
Panu Matilainen [Mon, 4 Jan 2010 12:58:51 +0000 (14:58 +0200)]
Check for our POSIX 2001 requirements and abort if not found

14 years agoLose the hysterical fakefork hack
Panu Matilainen [Mon, 4 Jan 2010 12:44:26 +0000 (14:44 +0200)]
Lose the hysterical fakefork hack
- we're not particularly interested in AmigaOS quirks from 1996

14 years agoRemove further replacement functions for POSIX 2001 required bits
Panu Matilainen [Mon, 4 Jan 2010 13:27:05 +0000 (15:27 +0200)]
Remove further replacement functions for POSIX 2001 required bits
- getwd(), getcwd(), basename() and realpath() are all POSIX 2001
  defined, we dont care about older stuff

14 years agoRemove unnecessary setenv() replacement function
Panu Matilainen [Mon, 4 Jan 2010 12:21:42 +0000 (14:21 +0200)]
Remove unnecessary setenv() replacement function
- setenv() and unsetenv() are required by POSIX 2001, we dont care about
  older systems

14 years agoRemove largely unnecessary putenv() replacement
Panu Matilainen [Mon, 4 Jan 2010 12:15:20 +0000 (14:15 +0200)]
Remove largely unnecessary putenv() replacement
- only the lua posix extension "uses" this by providing putenv()
  to Lua, make it conditional and return error if not supported by
  the underlying operating system

14 years agoEliminate myrealloc() replacement function
Panu Matilainen [Mon, 4 Jan 2010 11:46:43 +0000 (13:46 +0200)]
Eliminate myrealloc() replacement function
- realloc(NULL, size) is defined as equal to malloc(size) in C99 and
  POSIX 2001, we dont care about anything older than that

14 years agoRemove unneeded strdup() replacement in misc/
Panu Matilainen [Mon, 4 Jan 2010 11:34:39 +0000 (13:34 +0200)]
Remove unneeded strdup() replacement in misc/
- rpmio's own version is always there and portable, this is not needed

14 years agoUse rpm's own strdup() clone everywhere
Panu Matilainen [Mon, 4 Jan 2010 11:30:14 +0000 (13:30 +0200)]
Use rpm's own strdup() clone everywhere

14 years agoAlways free locally defined macros when they go out of scope
Panu Matilainen [Mon, 4 Jan 2010 10:20:09 +0000 (12:20 +0200)]
Always free locally defined macros when they go out of scope
- Prior to this, local defines in constructs like %{!?foo: %define foo bar}
  would remain defined until a parametrized macro gets called, causing
  obscure and confusing errors in specs such as RhBug:551971 and countless
  others. Use of %global is now always required for such constructs.

14 years agoRemove -98 vintage ifdef'ed dead code
Panu Matilainen [Mon, 4 Jan 2010 08:52:22 +0000 (10:52 +0200)]
Remove -98 vintage ifdef'ed dead code

14 years agoerror.c was getting translated too, duh
Panu Matilainen [Mon, 4 Jan 2010 07:12:19 +0000 (09:12 +0200)]
error.c was getting translated too, duh
- should've been in commit 5741334a857a783b033c647223f206a7ca43cef3

14 years agoOops, update stubs.c too for the removed replacements
Panu Matilainen [Wed, 23 Dec 2009 13:02:00 +0000 (15:02 +0200)]
Oops, update stubs.c too for the removed replacements

14 years agoRemove replacements for C99 mandated functions
Panu Matilainen [Wed, 23 Dec 2009 12:52:49 +0000 (14:52 +0200)]
Remove replacements for C99 mandated functions
- rpm requires C99 compiler anyway, no point in carrying these around

14 years agoRemove unneeded replacement error/warn functions
Panu Matilainen [Wed, 23 Dec 2009 12:36:36 +0000 (14:36 +0200)]
Remove unneeded replacement error/warn functions

14 years agoInclude <utime.h> where needed instead of system.h
Panu Matilainen [Wed, 23 Dec 2009 12:19:54 +0000 (14:19 +0200)]
Include <utime.h> where needed instead of system.h
- include unconditionally as we dont try to deal with utime() missing

14 years agoMove major, minor + makedev portability stuff out of system.h, simplify
Panu Matilainen [Wed, 23 Dec 2009 12:14:35 +0000 (14:14 +0200)]
Move major, minor + makedev portability stuff out of system.h, simplify
- only cpio.c needs, move it there
- if none of the standard headers define these, its not our headache anymore

14 years agoMove getopt() portability fiddles out of system.h
Panu Matilainen [Wed, 23 Dec 2009 12:02:19 +0000 (14:02 +0200)]
Move getopt() portability fiddles out of system.h
- only macro.c needs, no point polluting includes everywhere

14 years agoDont include <pwd.h> from system.h, dont bother checking for it either
Panu Matilainen [Wed, 23 Dec 2009 11:40:10 +0000 (13:40 +0200)]
Dont include <pwd.h> from system.h, dont bother checking for it either
- no much point conditionalizing something we can't live without
- just three places need, no point polluting include space everywhere

14 years agoDont bother including <sys/socket.h>, we dont use anything from there
Panu Matilainen [Wed, 23 Dec 2009 11:36:29 +0000 (13:36 +0200)]
Dont bother including <sys/socket.h>, we dont use anything from there

14 years agoDont bother including <err.h>, we dont use anything from there
Panu Matilainen [Wed, 23 Dec 2009 11:32:53 +0000 (13:32 +0200)]
Dont bother including <err.h>, we dont use anything from there

14 years agoOnly rpmrc.c cares about utsname.h, move out of system.h
Panu Matilainen [Wed, 23 Dec 2009 11:31:57 +0000 (13:31 +0200)]
Only rpmrc.c cares about utsname.h, move out of system.h

14 years agoDont include grp.h from system.h, dont bother checking in configure either
Panu Matilainen [Wed, 23 Dec 2009 11:15:59 +0000 (13:15 +0200)]
Dont include grp.h from system.h, dont bother checking in configure either
- no much point conditionalizing something we can't live without
- just two places need, no point polluting include space everywhere

14 years agoDont bother checking and including a header we dont use or need
Panu Matilainen [Wed, 23 Dec 2009 10:58:17 +0000 (12:58 +0200)]
Dont bother checking and including a header we dont use or need

14 years agoMove malloc portability tweaks out of system.h
Panu Matilainen [Wed, 23 Dec 2009 10:55:45 +0000 (12:55 +0200)]
Move malloc portability tweaks out of system.h
- only rpmmalloc.c needs, no need to pollute system.h

14 years agoWe dont use memchr() anywhere
Panu Matilainen [Wed, 23 Dec 2009 10:47:59 +0000 (12:47 +0200)]
We dont use memchr() anywhere

14 years agoMove getpass() portability tweaks out of system.h
Panu Matilainen [Wed, 23 Dec 2009 10:41:38 +0000 (12:41 +0200)]
Move getpass() portability tweaks out of system.h
- only signature.c needs, no need to pollute system.h

14 years agoDont bother checking for a header we dont use
Panu Matilainen [Wed, 23 Dec 2009 10:37:37 +0000 (12:37 +0200)]
Dont bother checking for a header we dont use

14 years agoDont bother checking for functions we dont use
Panu Matilainen [Wed, 23 Dec 2009 10:25:32 +0000 (12:25 +0200)]
Dont bother checking for functions we dont use
- some of this stuff was used in 4.4.x but not anymore
- additionally we dont even use getdomainnname(), check for gethostname()
  instead

14 years agoUse AC_PROG_MKDIR_P for testing mkdir -p capability
Panu Matilainen [Wed, 23 Dec 2009 09:40:55 +0000 (11:40 +0200)]
Use AC_PROG_MKDIR_P for testing mkdir -p capability
- for rpmbuild's purposes MKDIR_P doesn't cut it though, we need to
  point it to something that exists on an installed system

14 years agoUse %{__mkdir_p} macro in build instead of hardwired RPM_MKDIR_P
Panu Matilainen [Tue, 22 Dec 2009 13:32:17 +0000 (15:32 +0200)]
Use %{__mkdir_p} macro in build instead of hardwired RPM_MKDIR_P

14 years agoRemove unused h_errno test from configure.ac
Panu Matilainen [Tue, 22 Dec 2009 12:55:54 +0000 (14:55 +0200)]
Remove unused h_errno test from configure.ac

14 years agoKill off last remaining uses of _constfree()
Panu Matilainen [Tue, 22 Dec 2009 12:36:35 +0000 (14:36 +0200)]
Kill off last remaining uses of _constfree()
- practially all the data in rpmfi needs to be treated as const, these
  are just a funky special case which point to header memory for the
  couple of cases where KEEPHEADER is still used

14 years agoMake header struct really opaque outside header.c
Panu Matilainen [Tue, 22 Dec 2009 11:25:48 +0000 (13:25 +0200)]
Make header struct really opaque outside header.c
- the low-level stuff in signature.c and package.c need entryInfo_s
  and indexEntry_s but not the header itself
- also move the other defines which have no use outside header.c there

14 years agoRemove redundant NULL-check
Panu Matilainen [Tue, 22 Dec 2009 11:11:00 +0000 (13:11 +0200)]
Remove redundant NULL-check

14 years agoEliminate unnecessary url parsing from rpmtsRootDir()
Panu Matilainen [Tue, 22 Dec 2009 11:01:36 +0000 (13:01 +0200)]
Eliminate unnecessary url parsing from rpmtsRootDir()
- url's in transaction root hasn't been permitted since rpm 4.6.0 days

14 years agoLose the now empty header_internal.c source
Panu Matilainen [Tue, 22 Dec 2009 10:34:19 +0000 (12:34 +0200)]
Lose the now empty header_internal.c source

14 years agoMove htonll() into header.c and make static, not needed elsewhere
Panu Matilainen [Tue, 22 Dec 2009 10:33:16 +0000 (12:33 +0200)]
Move htonll() into header.c and make static, not needed elsewhere

14 years agoMove the legacy compatibility goo into legacy.c
Panu Matilainen [Tue, 22 Dec 2009 10:30:45 +0000 (12:30 +0200)]
Move the legacy compatibility goo into legacy.c
- no functional changes
- headerGetRawEntry() hasn't had a public prototype since rpm 4.0 days
  but there are some 3rd party users still (sigh), leave it alone as
  exposing the proto now would only cause *more* trouble to the external
  users

14 years agoMove the higher level convenience functions out of header.c
Panu Matilainen [Tue, 22 Dec 2009 10:11:42 +0000 (12:11 +0200)]
Move the higher level convenience functions out of header.c
- header.c is big enough as it is, and none of these things needs
  header struct internals for anything
- no functional changes, just moving stuff around

14 years agoRename hdrNVR.c to more obvious and generic headerutil.c
Panu Matilainen [Tue, 22 Dec 2009 10:07:12 +0000 (12:07 +0200)]
Rename hdrNVR.c to more obvious and generic headerutil.c
- no functional changes
- remove it from translation list, there's nothing here to translate...

14 years agoWork on tsortinfo instead of ts elements when ordering everywhere
Panu Matilainen [Mon, 21 Dec 2009 13:01:27 +0000 (15:01 +0200)]
Work on tsortinfo instead of ts elements when ordering everywhere
- ...except addRelation() which still needs rpmteTSI() for grabbing
  tsort info from elements in rpmal

14 years agoWork on tsortInfo nodes directly when detecting SCC's
Panu Matilainen [Mon, 21 Dec 2009 12:13:35 +0000 (14:13 +0200)]
Work on tsortInfo nodes directly when detecting SCC's
- pass the local order info struct to detectSCC() and work on that
  instead of ping-ponging to the TSI's through transaction elements

14 years agoRecord relations to tsortInfos instead of transaction elements
Panu Matilainen [Mon, 21 Dec 2009 10:59:38 +0000 (12:59 +0200)]
Record relations to tsortInfos instead of transaction elements

14 years agoSave pointer to ts element in the tsort info struct
Panu Matilainen [Mon, 21 Dec 2009 10:30:04 +0000 (12:30 +0200)]
Save pointer to ts element in the tsort info struct

14 years agoAvoid a bunch of redundant rpmteTSI() calls
Panu Matilainen [Mon, 21 Dec 2009 10:18:22 +0000 (12:18 +0200)]
Avoid a bunch of redundant rpmteTSI() calls

14 years agoEliminate unnecessary depth member from tsortinfo
Panu Matilainen [Mon, 21 Dec 2009 10:12:29 +0000 (12:12 +0200)]
Eliminate unnecessary depth member from tsortinfo
- its only used for debug log formatting and we can calculate it from
  the number of parents in the debug case

14 years agoEliminate unnecessary npreds member from tsort info
Panu Matilainen [Mon, 21 Dec 2009 08:41:03 +0000 (10:41 +0200)]
Eliminate unnecessary npreds member from tsort info
- this is the same as tsi_count

14 years agoEliminate unused tree index and degree from ordering calculations
Panu Matilainen [Mon, 21 Dec 2009 08:37:48 +0000 (10:37 +0200)]
Eliminate unused tree index and degree from ordering calculations

14 years agoAvoid a few unnecessary rpmteTSI() calls in addRelation()
Panu Matilainen [Mon, 21 Dec 2009 06:17:05 +0000 (08:17 +0200)]
Avoid a few unnecessary rpmteTSI() calls in addRelation()

14 years agoRemove unused ordering related members from rpmts struct
Panu Matilainen [Fri, 18 Dec 2009 13:28:36 +0000 (15:28 +0200)]
Remove unused ordering related members from rpmts struct

14 years agoBury ordering structures and their alloc+free inside order.c
Panu Matilainen [Mon, 21 Dec 2009 07:20:09 +0000 (09:20 +0200)]
Bury ordering structures and their alloc+free inside order.c
- nothing outside order.c needs this stuff, TSI alloc+free routines
  have no business being exported
- for now we need to store a pointer to tsortInfo in the elements,
  its just an opaque pointer for ping-ponging the data through ts elements
- all allocation + freeing is local to ordering code

14 years agoEliminate the rpmte tsort info manipulation public API
Panu Matilainen [Fri, 18 Dec 2009 10:20:05 +0000 (12:20 +0200)]
Eliminate the rpmte tsort info manipulation public API
- its not useful outside the ordering internals and API users have no
  business messing with it

14 years agoConvert rpmtsOrder() to manipulate the tsort data from tsortInfo directly
Panu Matilainen [Fri, 18 Dec 2009 10:16:25 +0000 (12:16 +0200)]
Convert rpmtsOrder() to manipulate the tsort data from tsortInfo directly

14 years agoConvert addRelation() to manipulate the tsort data from tsortInfo directly
Panu Matilainen [Fri, 18 Dec 2009 10:12:44 +0000 (12:12 +0200)]
Convert addRelation() to manipulate the tsort data from tsortInfo directly

14 years agoConvert collectTE() to manipulate the tsort data from tsortInfo directly
Panu Matilainen [Fri, 18 Dec 2009 10:10:01 +0000 (12:10 +0200)]
Convert collectTE() to manipulate the tsort data from tsortInfo directly

14 years agoAvoid some unnecessary rpmteTSI() calls in collectTE()
Panu Matilainen [Fri, 18 Dec 2009 10:05:30 +0000 (12:05 +0200)]
Avoid some unnecessary rpmteTSI() calls in collectTE()
- we have q's TSI in local variable already, use it
- also rename tsi -> q_tsi so it's obvious which one we're manipulating

14 years agoMove tsort data out of rpmte into, duh, tsortInfo
Panu Matilainen [Fri, 18 Dec 2009 09:56:04 +0000 (11:56 +0200)]
Move tsort data out of rpmte into, duh, tsortInfo