Tim-Philipp Müller [Thu, 27 Jan 2022 01:40:17 +0000 (01:40 +0000)]
gst-plugins-bad: update translations
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1579>
Tim-Philipp Müller [Thu, 27 Jan 2022 01:39:28 +0000 (01:39 +0000)]
gst-plugins-ugly: update translations
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1579>
Tim-Philipp Müller [Thu, 27 Jan 2022 01:38:39 +0000 (01:38 +0000)]
gst-plugins-good: update translations
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1579>
Tim-Philipp Müller [Thu, 27 Jan 2022 01:38:12 +0000 (01:38 +0000)]
gst-plugins-base: update translations
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1579>
Tim-Philipp Müller [Thu, 27 Jan 2022 01:37:18 +0000 (01:37 +0000)]
gstreamer: update translations
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1579>
Seungha Yang [Wed, 26 Jan 2022 18:10:39 +0000 (03:10 +0900)]
d3d11av1dec: Fix typo in debug message
Fixing copy and paste mistake, It's AV1 decoder not VP8
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1576>
Nirbheek Chauhan [Wed, 26 Jan 2022 05:52:31 +0000 (11:22 +0530)]
rtspsrc: Fix critical while serializing timeout element message
The "cause" field wasn't registered as a GEnumValue, so do that.
Fixes this critical in gst_structure_to_string():
`gst_value_serialize: assertion 'G_IS_VALUE (value)' failed`
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1573>
Vivia Nikolaidou [Mon, 24 Jan 2022 10:26:25 +0000 (12:26 +0200)]
audioaggregator: Return NOT_NEGOTIATED when the configuration is invalid
Otherwise we just end up outputting garbage.
https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/-/issues/957
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1558>
Nirbheek Chauhan [Wed, 26 Jan 2022 05:42:34 +0000 (11:12 +0530)]
videoaggregator: Remove extra semicolon in macro usage
This is usually necessary to allow gst-indent to treat it as
a statement, but we do not run gst-indent on headers and we do not
have extra semicolons in other places that this macro is used in the
header. Fixes warnings when using the header:
```
In file included from gstreamer/subprojects/gst-plugins-base/gst-libs/gst/video/video.h:185,
from XYZ:9001:
gstreamer/subprojects/gst-plugins-base/gst-libs/gst/video/gstvideoaggregator.h:206:78: warning: ISO C does not allow extra ‘;’ outside of a function [-Wpedantic]
206 | G_DEFINE_AUTOPTR_CLEANUP_FUNC(GstVideoAggregatorConvertPad, gst_object_unref);
| ^
gstreamer/subprojects/gst-plugins-base/gst-libs/gst/video/gstvideoaggregator.h:214:181: warning: ISO C does not allow extra ‘;’ outside of a function [-Wpedantic]
214 | G_DECLARE_DERIVABLE_TYPE (GstVideoAggregatorParallelConvertPad, gst_video_aggregator_parallel_convert_pad, GST, VIDEO_AGGREGATOR_PARALLEL_CONVERT_PAD, GstVideoAggregatorConvertPad);
| ^
```
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1572>
Seungha Yang [Tue, 25 Jan 2022 17:46:49 +0000 (02:46 +0900)]
gstplugin: Fix for UWP build
SetThreadErrorMode() API is available on UWP but flag values
are desktop API only. Since error dialogs don't exist on UWP,
we don't need to suppress it
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1569>
Víctor Manuel Jáquez Leal [Tue, 25 Jan 2022 11:32:50 +0000 (12:32 +0100)]
va: basetransform: Pass component index not plane index.
This is an issue detected and fixed in commit
3897b24f for other
libraries and elements.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1566>
Sebastian Dröge [Mon, 24 Jan 2022 08:45:33 +0000 (10:45 +0200)]
splitmuxsink: Warn when calculating the next fragment time in timecode mode fails
But only if timecode mode is enabled as it will fail all the time
otherwise.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1557>
Nirbheek Chauhan [Tue, 25 Jan 2022 09:35:47 +0000 (15:05 +0530)]
qt: Retain compatibility with Qt 5.9
QSharedPointer.get() was added in Qt 5.11, and it does the same thing
as .data()
https://doc.qt.io/qt-5/qsharedpointer.html#get
Fixes https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/867
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1565>
Nirbheek Chauhan [Tue, 25 Jan 2022 08:55:19 +0000 (14:25 +0530)]
meson: Update subprojects to fix warnings
glib-2-70 commit
359a837e
meson: fix warnings for extract_all_objects
libdrm-2.4.109 commit
05b0a955
man: convert to reStructuredText
Fixes warning about run_command() check: kwarg
pixman commit
adc07d46
meson: Fix warning about extract_all_objects usage
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1564>
Sebastian Dröge [Mon, 24 Jan 2022 17:44:32 +0000 (19:44 +0200)]
ges: Include ges-image-source.h in the installed headers
It's referenced by `ges.h` and was previously available, so removing it
is an API change.
Fixes https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/963
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1563>
Víctor Manuel Jáquez Leal [Mon, 24 Jan 2022 10:14:14 +0000 (11:14 +0100)]
va: filter & postproc: Match color with caps features.
When fixating color, there might be "other caps" with color spaces not
supported by the caps features exposed in the vapostproc's source pad
caps template (perhaps it's a bug somewhere else in GStreamer).
This solution checks if the proposed format exists in the filter
within the caps feature associated with the proposed format.
The check is done with the new filter's function
gst_va_filter_has_video_format().
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1559>
Jan Alexander Steffens (heftig) [Mon, 10 Jan 2022 12:34:21 +0000 (13:34 +0100)]
tsmux: Allow specifying PMT order via the prog-map
Look for an entry `PMT_<PID>` in the `prog-map`, which specifies the
relative index of the stream in the PMT.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1510>
Jan Alexander Steffens (heftig) [Mon, 10 Jan 2022 13:16:28 +0000 (14:16 +0100)]
tsmux: Deterministically order program streams by PID
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1510>
Jan Alexander Steffens (heftig) [Mon, 10 Jan 2022 11:59:58 +0000 (12:59 +0100)]
tsmux: Deterministically order PAT programs by number
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1510>
Jan Alexander Steffens (heftig) [Mon, 10 Jan 2022 12:03:11 +0000 (13:03 +0100)]
tsmux: Remove program_array_index
It's only used for removal. Let's just scan the array.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1510>
Jan Alexander Steffens (heftig) [Mon, 10 Jan 2022 11:31:42 +0000 (12:31 +0100)]
tsmux: Replace streams GArray with GPtrArray
This is more appropriate.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1510>
Vivia Nikolaidou [Mon, 24 Jan 2022 10:57:10 +0000 (12:57 +0200)]
audiotestsrc: Produce a default channel mask if possible
https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/-/issues/957
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1560>
Seungha Yang [Fri, 10 Dec 2021 11:09:42 +0000 (20:09 +0900)]
video-converter: Fix for broken gamma remap with high bitdepth YUV output
Scale down the matrix before calculating RGB -> YUV matrix
otherwise offset values will be wrong
Fixing pipeline
videotestsrc ! video/x-raw,format=ARGB ! videoconvert gamma-mode=remap ! \
video/x-raw,format=P010_10LE,colorimetry="bt2020"
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1432>
Michael Gruner [Thu, 20 Jan 2022 23:13:36 +0000 (17:13 -0600)]
gst-rtsp-server: Fix leak in appsrc2 example
In the need-data appsrc callback, a buffer is pulled from the
appsink. This buffer is then copied so that metadata is writable.
The copy is pushed to the appsrc but it doesn't take ownership
of the buffer so we need to manually unref it. The original buffer
is finally unreffed when the sample is freed.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1548>
Sebastian Dröge [Sun, 23 Jan 2022 11:38:37 +0000 (13:38 +0200)]
videodecoder: Fix property description for new properties
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1556>
Sangchul Lee [Wed, 19 Jan 2022 14:17:23 +0000 (23:17 +0900)]
webrtc: Fix memory leaks
Redundant condition and unreachable codes are also removed.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1544>
Nicolas Dufresne [Tue, 14 Jul 2020 15:11:11 +0000 (11:11 -0400)]
v4l2codecs: Unify the src template caps format
Notably NV12_4L4 ended up being applied to only VP9 decoder. This fixes the
situation by using a central define for all static src pad templated formats.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/965>
Nicolas Dufresne [Fri, 21 Jan 2022 19:13:39 +0000 (14:13 -0500)]
v4l2codecs: Sync kernel headers against 5.16.0
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/965>
Nicolas Dufresne [Fri, 21 Jan 2022 19:13:12 +0000 (14:13 -0500)]
video4linux2: Sync kernel headers against 5.16.0
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/965>
Nicolas Dufresne [Mon, 17 Jan 2022 16:44:47 +0000 (11:44 -0500)]
v4l2videdec: Fix race condition between drain and state changes
This is due to an unsafe usage of the pad task. We didn't ensure proper
ownership of the task. That race involved the task being released too early,
and was detected, luckily, by the glib mutex implementationt that
reported the mutex being disposed while being locked.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1478>
Víctor Manuel Jáquez Leal [Fri, 21 Jan 2022 10:13:55 +0000 (11:13 +0100)]
msdk: Avoid noisy registry when no MSDK device.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1550>
Víctor Manuel Jáquez Leal [Fri, 21 Jan 2022 09:53:21 +0000 (10:53 +0100)]
va: libs: Avoid noisy registry when no VA device.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1550>
Philippe Normand [Sun, 16 Jan 2022 14:41:41 +0000 (14:41 +0000)]
soup: Reintroduce compile-time libsoup dependency for static builds
On Android (especially) and for static builds in general it is safer to link
against libsoup and have the dynamic custom loading disabled. For those cases we
can safely assume the application will use either libsoup2 or libsoup3 and not
both.
Fixes #939
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1536>
Philippe Normand [Sun, 16 Jan 2022 14:40:11 +0000 (14:40 +0000)]
soup: Initialize debug category before use
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1536>
Philippe Normand [Sun, 16 Jan 2022 14:39:42 +0000 (14:39 +0000)]
soup: Fix return types for a couple VTable functions
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1536>
Nirbheek Chauhan [Fri, 14 Jan 2022 14:23:29 +0000 (19:53 +0530)]
meson: Build cairo subproject when unavailable on the system
Fixes https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/952
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1523>
Mathieu Duponchelle [Wed, 19 Jan 2022 01:42:35 +0000 (02:42 +0100)]
decodebin2: raise multiqueue max-size-bytes
The earlier size of 2 MB was set back in 2009, it doesn't
seem unreasonable to raise it to 8 MB these days. The use
case at hand is matroskademux containing both a video stream
with a very low amount of compression but no decoding latency,
and a H265 stream.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1538>
Aleksandar Topic [Thu, 20 Jan 2022 16:59:30 +0000 (17:59 +0100)]
imagefreeze: Fix example launch line format issue
The currently shown example launch line will not run, because it
cannot handle png images.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1547>
Seungha Yang [Sun, 26 Dec 2021 18:35:29 +0000 (03:35 +0900)]
Revert "videodecoder: Forward hdr-format info downstream"
This reverts commit
9b852181d8a1fa2fb1bf3ba898c6ffa04eea3fd4.
It's leftover commit which should've been reverted as a part of
https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/-/merge_requests/1148
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1475>
Seungha Yang [Wed, 19 Jan 2022 20:59:36 +0000 (05:59 +0900)]
wasapi2: Fix for device open failure on old OS
To open automatic stream routing aware device,
at least Windows10 Anniversary Update is required.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1545>
Sebastian Dröge [Thu, 20 Jan 2022 08:59:56 +0000 (10:59 +0200)]
gstreamer: capsfeatures: Fix docs of `gst_caps_features_new_single()`
They were just a copy of the `new_any()` docs before.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1542>
Seungha Yang [Wed, 19 Jan 2022 18:17:58 +0000 (03:17 +0900)]
tools: gst-play: Enable Windows high-resolution clock
Apply https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/817
to gst-play as well, especially for better high-framerate
(60fps or higher) video support, because
15ms default clock precision (actual value is system dependent)
is not sufficient for such scenario.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1541>
Nirbheek Chauhan [Wed, 19 Jan 2022 15:28:36 +0000 (20:58 +0530)]
gstplugin: Better warnings on plugin load failure on Windows
It is an extremely common mistake on Windows to have incorrect PATH
values when loading a plugin, and the error from g_module_error()
(which just calls FormatMessageW()) is very confusing in this case:
The specified module could not be found.
https://docs.microsoft.com/en-us/windows/win32/debug/system-error-codes--0-499-#ERROR_MOD_NOT_FOUND
It implies the plugin itself could not be found. The actual issue is
that a DLL dependency could not be found. We need to detect this case
and print a more useful error message.
We should still print the error fetched from FormatMessage() so that
people are able to google for it.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1540>
Tomasz Andrzejak [Sat, 15 Jan 2022 18:03:33 +0000 (19:03 +0100)]
Add FEC SDP message test
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1527>
Tomasz Andrzejak [Sat, 15 Jan 2022 16:02:52 +0000 (17:02 +0100)]
sdpmessage: fix mapping single char fmtp params
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1527>
Sebastian Dröge [Wed, 19 Jan 2022 09:05:26 +0000 (11:05 +0200)]
codec-utils: Mark various string return values as `nullable`
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1539>
Tim-Philipp Müller [Tue, 18 Jan 2022 23:17:49 +0000 (23:17 +0000)]
rtphdrext: increase GstRTPHeaderExtensionClass padding to LARGE
https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/-/merge_requests/748#note_1223253
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1537>
Philippe Normand [Sat, 15 Jan 2022 10:06:23 +0000 (10:06 +0000)]
pbutils: Define one debug category per module
Follow-up of https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1505
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1526>
Seungha Yang [Mon, 17 Jan 2022 18:03:30 +0000 (03:03 +0900)]
wasapi2ringbuffer: Fix for desynced buffer-size and segsize
GstAudioRingBufferSpec::segsize has been configured by using
device period but GstWasapi2RingBuffer was referencing the
buffer size returned by IAudioClient::GetBufferSize()
which is most likely larger than device period.
Fixing to sync them.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1533>
Robert Mader [Thu, 30 Dec 2021 15:52:17 +0000 (16:52 +0100)]
waylandsink: Ensure correct mapping of area_surface
If the `area_surface` got unmapped when changing to the `READY` or
`NULL` state, we currently don't remap it when playback resumes and
`wp_viewporter` is supported. Without `wp_viewporter` we do remap
it, but rather unintentionally and also when not wanted.
On Weston this has not been a big problem as it so far wrongly maps
subsurfaces of unmapped surfaces anyway - i.e. only the black
background was missing on resume. On other compositors and future
Weston this prevents the `video_surface` to get remapped.
Shuffle things around to ensure `area_surface` is mapped in the
right situations and do some minor cleanup.
See also https://gitlab.freedesktop.org/wayland/weston/-/issues/426
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1483>
Xi Ruoyao [Sun, 16 Jan 2022 17:33:47 +0000 (01:33 +0800)]
gst-libav: fix build with ffmpeg-5.0.0
Latest ffmpeg has removed avcodec_get_context_defaults(), and its
documentation says a new AVCodecContext should be allocated for this
purpose. The pointer returned by avcodec_find_decoder() is now
const-qualified so we also need to adjust for it. And, AVCOL_RANGE_MPEG
is now rejected with strict_std_compliance > FF_COMPLIANCE_UNOFFICIAL.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1531>
Seungha Yang [Sat, 15 Jan 2022 17:21:43 +0000 (02:21 +0900)]
d3d11deinterlace: Do not restrict minimum resolution to 64x64
The value 64 was completely arbitrary one, and this element
will be able to support smaller resolutions
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1528>
Seungha Yang [Thu, 13 Jan 2022 19:45:08 +0000 (04:45 +0900)]
pluginfeature: Fix object leak
Need to release GstPluginFeature object after use
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1521>
Seungha Yang [Fri, 7 Jan 2022 09:25:00 +0000 (18:25 +0900)]
compositor: Always draw if all input buffers are GAP
Otherwise output buffers will contain random scene
(previously rendered or arbitrary initial values) since we don't
draw onto output buffer at all.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1498>
Seungha Yang [Thu, 6 Jan 2022 13:10:18 +0000 (22:10 +0900)]
videoaggregator: Don't pass GAP buffer to prepare_frame_start()
Likewise we do check the same condition in prepare_frames_finish(),
ignore GAP buffer (zero size with GST_BUFFER_FLAG_GAP flag) without
any further processing.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1498>
Seungha Yang [Thu, 6 Jan 2022 13:00:11 +0000 (22:00 +0900)]
d3d11compositor: Don't try to read empty buffer
The queued buffer may not be readable buffer in case that
upstream sends GAP event or so.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1497>
Robert Mader [Thu, 13 Jan 2022 13:17:09 +0000 (14:17 +0100)]
waylandsink: Fix alpha value for the test pattern in example
The background-color property is in big-endian ARGB, resulting in
a alpha value of `0`. This accidentally used to work on all common
compositors, but on Weston this now correctly results in a black
background.
See also https://gitlab.freedesktop.org/wayland/weston/-/issues/577
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1446>
Robert Mader [Mon, 13 Dec 2021 12:16:06 +0000 (13:16 +0100)]
waylandsink: Use wl_surface_damage_buffer() instead of wl_surface_damage()
The later, doing damage in surface coordinates instead of buffer
coordinates, has been deprecated. The reason for that is that it
is more prone to bugs, both on the client and the compositor side,
especially when paired with buffer scale, `wp_viewporter` or
buffer transforms.
Unfortunately, on Weston this risks running into
https://gitlab.freedesktop.org/wayland/weston/-/issues/446
(which causes trouble for several other projects as well). However,
that bug only affects cases where we run in sync mode, i.e. only
during resizes. In practise I haven't been able to observe the
issue.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1446>
Robert Mader [Mon, 13 Dec 2021 11:21:06 +0000 (12:21 +0100)]
waylandsink: Use G_MAXINT32 for surface damage
Each time we call `wl_surface_damage()` we want to do full surface
damage. Like Mesa, just use `G_MAXINT32` to ensure we always do
full damage, reducing the need to track the right dimensions.
`window->video_rectangle` is now unused, but we keep it around for
now as we may need it again in the future.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1446>
Robert Mader [Thu, 30 Dec 2021 17:14:24 +0000 (18:14 +0100)]
waylandsink: Only call wl_surface_damage() when buffer content changed
From the spec:
> This request is used to describe the regions where the pending
> buffer is different from the current surface contents
We currently also call `wl_surface_damage()` on surfaces without
new or still compositor-hold buffers, e.g. when resizing the window.
In that case we call it on `area_surface_wrapper`, even though it
gets resized via `wp_viewport_set_destination()`, in which case
the compositor is in charge of repainting the area on screen.
Doing so is currently not forbidden by the spec, however it might
be in the future, see
https://gitlab.freedesktop.org/wayland/wayland/-/issues/267
Thus lets stay close to the spec and only call `wl_surface_damage()`
when we just attached a buffer.
Right now this prevents runtime assertions in Mutter.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1446>
Robert Mader [Mon, 13 Dec 2021 13:31:06 +0000 (14:31 +0100)]
waylandsink: Simplify input region handling
We only need to unset the input region for the area surface when
we don't have our own toplevel surface. By default, the input region
covers the whole surface, thus no need to change it on resize.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1446>
Robert Mader [Mon, 13 Dec 2021 11:00:10 +0000 (12:00 +0100)]
waylandsink: Use G_MAXINT32 for opaque regions
`gst_wl_window_set_opaque` does not get called on window resizes,
potentially leaving opaque regions too small.
According to the spec opaque regions can be bigger than the surface
size - parts that fall outside of the surface will get ignored.
Thus we can can simply use `G_MAXINT32` and be sure that the whole
surfaces will always be covered.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1446>
Seungha Yang [Thu, 13 Jan 2022 14:00:41 +0000 (23:00 +0900)]
uridecodebin: Fix critical warnings
Don't pass non-GstObject object to there.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1519>
Philippe Normand [Sun, 9 Jan 2022 09:39:32 +0000 (09:39 +0000)]
pbutils: Simplify h264_caps_structure_get_profile_flags_level a bit
Refactoring, removing one level of indentation from the function.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1505>
Philippe Normand [Sat, 8 Jan 2022 14:57:00 +0000 (14:57 +0000)]
pbutils: H.265 support for gst_codec_utils_caps_get_mime_codec()
The codec_data caps payload is parsed and a MIME codec string is generated
according to the ISO/IEC 14496-15 specification.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1505>
Philippe Normand [Sat, 8 Jan 2022 14:56:06 +0000 (14:56 +0000)]
pbutils: Add a pbutils debug category
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1505>
Dave Piché [Tue, 11 Jan 2022 18:21:55 +0000 (13:21 -0500)]
webrtc: fix log error message in function gst_webrtc_bin_set_local_description
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1511>
Tim-Philipp Müller [Thu, 13 Jan 2022 11:31:55 +0000 (11:31 +0000)]
mxfdemux: don't error out if VANC track only contains packets we don't handle
If the VANC track does contain packets, but we skip over all packets, just
treat it the same as if there hadn't been any packets at all and send a
GAP event instead of erroring out with "Failed to handle essence element".
We would error out because when we reach the end of the loop without having
found a closed caption packet the flow return variable is still FLOW_ERROR
which is what it has been initialised to.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1518>
He Junyan [Thu, 13 Jan 2022 02:36:24 +0000 (10:36 +0800)]
codecparsers: h265parser: return invalid profile if len is 0.
Though the profiles[0] is inited as GST_H265_PROFILE_INVALID in the
gst_h265_profile_tier_level_get_profile(), the profile detecting may
change its content later. So the return of profiles[0] may not be an
invalid profile even the len is 0.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1517>
He Junyan [Thu, 13 Jan 2022 02:11:52 +0000 (10:11 +0800)]
codecparsers: h265parser: Fix the index incrementation error in append_profile().
The current "*idx++" operation just refers the pointer and increment the pointer
itself, not the content of the pointer. This causes that the count of the profiles
is always 0.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1517>
Dmitry Osipenko [Tue, 4 Jan 2022 01:56:55 +0000 (04:56 +0300)]
kmssink: Support auto-detection of NVIDIA Tegra driver
NVIDIA Tegra SoCs have a separate (from GPU) display controller. It's
the primary display device on all Tegra SoCs. Add Tegra to the list
of primary DRM drivers.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1514>
Mark Nauwelaerts [Sun, 26 Dec 2021 18:01:24 +0000 (19:01 +0100)]
gst-env: extend PATH to include plugin scanner and generator
Mathieu Duponchelle [Fri, 7 Jan 2022 23:16:29 +0000 (00:16 +0100)]
cccombiner: fix s334-1a scheduling
The previous code was mistakenly trying to compute a cc_type out
of the first byte in the byte triplet, whereas it is to be interpreted
as:
> Bit b7 of the LINE value is the field number (0 for field 2; 1 for field 1).
> Bits b6 and b5 are 0. Bits b4-b0 form a 5-bit unsigned integer which
> represents the offset
The same mistake was made when creating padding packets.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1496>
Mathieu Duponchelle [Wed, 5 Jan 2022 21:48:31 +0000 (22:48 +0100)]
cccombiner: merge buffers for both fields with caption type s334-1a
Other elements such as line21encoder expect both fields to be present
in the same meta, not one meta per field.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1496>
Bastien Nocera [Fri, 7 May 2021 16:22:06 +0000 (18:22 +0200)]
gtk: Add "video-aspect-ratio-override" property
Allow front-ends to override the pixel aspect ratio found inside the
video file itself, or most likely, missing from the video file.
This is a long-standing feature of totem.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1137>
Bastien Nocera [Wed, 13 Oct 2021 13:33:14 +0000 (15:33 +0200)]
gtk: Remove _update_par() forward declaration
No functional changes.
https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1137/diffs#note_1102782
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1137>
Bastien Nocera [Wed, 13 Oct 2021 13:38:52 +0000 (15:38 +0200)]
gtk: Mark properties as changeable in the PLAYING state
https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1137#note_1102789
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1137>
Bastien Nocera [Tue, 11 May 2021 09:28:57 +0000 (11:28 +0200)]
gtk: Fix "pixel-aspect-ratio" property range
Fix the arguments passed to gst_param_spec_fraction in the incorrect
order.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1137>
Bastien Nocera [Fri, 7 May 2021 16:19:55 +0000 (18:19 +0200)]
gtk: Rename display pixel aspect ratio related constants
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1137>
Bastien Nocera [Fri, 7 May 2021 16:16:30 +0000 (18:16 +0200)]
gtk: Make "pixel-aspect-ratio" changes immediate
Schedule a resize when the display's pixel aspect ratio has changed, if
one isn't already scheduled.
Closes: https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/issues/883
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1137>
Jordan Petridis [Fri, 7 Jan 2022 12:17:46 +0000 (14:17 +0200)]
gstglutils: introspection annotations fixups
* gst_gl_ensure_element_data: specify the type for the element arg
* gst_gl_handle_set_context: correctly annotate the display and
gl_ctx as just (out) instead of (inout)
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1501>
Mengkejiergeli Ba [Mon, 10 Jan 2022 07:24:13 +0000 (15:24 +0800)]
av1parser: Fix data type of film grain param
Fix cb_offset and cr_offset data type from guint8 to guint16. According
to spec, cb_offset and cr_offset are 9 bit long, while guint8 can cause
interger overflow, and thus change to guint16.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1508>
Sebastian Dröge [Sun, 9 Jan 2022 12:07:12 +0000 (14:07 +0200)]
codec-utils: Use nullable annotation instead of allow-none for various Opus functions
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1506>
Sebastian Dröge [Sun, 9 Jan 2022 12:05:48 +0000 (14:05 +0200)]
codec-utils: Annotate out parameters for Opus functions as (optional)
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1506>
Sebastian Dröge [Sun, 9 Jan 2022 12:05:11 +0000 (14:05 +0200)]
codec-utils: Add missing annotations to gst_codec_utils_h264_get_profile_flags_level()
And fix some minor typos.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1506>
Mathieu Duponchelle [Fri, 7 Jan 2022 21:26:16 +0000 (22:26 +0100)]
validate: loggable: fix Callable import
Since 3.3 importing Callable from collections is deprecated,
it should be imported from collections.abc .
Since 3.10 the alias has been removed altogether.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1504>
Nirbheek Chauhan [Tue, 4 Jan 2022 20:37:59 +0000 (02:07 +0530)]
meson: Add explicit check: kwarg to all run_command() calls
This is required since Meson 0.61.0, and causes a warning to be
emitted otherwise:
https://github.com/mesonbuild/meson/commit/
2c079d855ed87488bdcc6c5c06f59abdb9b85b6c
https://github.com/mesonbuild/meson/issues/9300
This exposed a bunch of places where we had broken run_command()
calls, unnecessary run_command() calls, and places where check: true
should be used.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1507>
Nirbheek Chauhan [Mon, 20 Dec 2021 16:13:25 +0000 (21:43 +0530)]
audio: Add logging that was useful in figuring out the last commit
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1461>
Nirbheek Chauhan [Mon, 20 Dec 2021 16:07:18 +0000 (21:37 +0530)]
audio-converter: Fix resampling when there's nothing to output
Sometimes we can't output anything because we don't have enough
incoming frames. In that case, the resampler was trying to call
do_quantize() and do_resample() in a loop forever because there would
never be samples to output (so chain->samples would always be NULL).
Fix this by not calling chain->make_func() in a loop -- seems
completely unnecessary since calling it over and over won't change
anything if the make_func() can't output samples.
Also add some checks for the input and / or output being NULL when
doing conversion or quantization. This will happen when we have
nothing to output.
We can't bail early, because we need resampler->samples_avail to be
updated in gst_audio_resampler_resample(), so we must call that and
no-op everything along the way.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1461>
Stéphane Cerveau [Wed, 5 Jan 2022 09:53:55 +0000 (10:53 +0100)]
alphacombine: update example launch line
Fix typos and missing videoconvert element to demonstrate
the alphacombine element.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1494>
He Junyan [Tue, 4 Jan 2022 08:19:44 +0000 (16:19 +0800)]
vaapi: av1dec: Use named profiles to replace the numeric ones.
Use named AV1 profiles (i.e., main, high) to replace the old "0"
and "1" profiles.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1491>
He Junyan [Fri, 24 Dec 2021 15:09:59 +0000 (23:09 +0800)]
av1parse: Set the "tu" as the default alignment.
The tu(temporal unit) is more widely used than the current alignment.
We now change the default alignment to tu.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1468>
He Junyan [Fri, 24 Dec 2021 13:50:01 +0000 (21:50 +0800)]
av1parse: Fix the wrong DELTA_UNIT flag setting for key frames.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1468>
He Junyan [Wed, 22 Dec 2021 04:36:15 +0000 (12:36 +0800)]
av1parse: Copy the PTS and DURATION when we create data.
We need to create header buffers for annex b format. This kind of
buffers should inherit the PTS and DURATION from the original buffers.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1468>
Nirbheek Chauhan [Mon, 3 Jan 2022 15:32:47 +0000 (21:02 +0530)]
vtenc: Signal ignored alpha component with ProRes
When the image is opaque but the output ProRes format has an alpha
component (4 component, 32 bits per pixel), Apple requires that we
signal that it should be ignored by setting the depth to 24 bits per
pixel. Not doing so causes the encoded files to fail validation.
So we set that in the caps and qtmux sets the depth value in the
container, which will be read by demuxers so that decoders can skip
those bytes entirely. qtdemux does this, but vtdec does not use this
information at present.
The sister change was made in qtmux and qtdemux in:
https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/merge_requests/1061
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1489>
He Junyan [Mon, 3 Jan 2022 14:15:12 +0000 (22:15 +0800)]
codecparsers: h265parser: Correct the read of slice_sao_chroma_flag.
According to the SPEC, for parsing the slice header, we should read the
slice_sao_chroma_flag only when ChromaArrayType is not equal to 0.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1488>
Thibault Saunier [Sun, 12 Dec 2021 13:20:55 +0000 (13:20 +0000)]
meson: Allow using GStreamer plugins from custom_subprojects
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1490>
Jordan Petridis [Mon, 3 Jan 2022 10:43:15 +0000 (12:43 +0200)]
ci: replace license notice
This file was copied from microsoft documentation [1]
and its header was refering to the license on that repo.
This change was lost during gstreamer/gstreamer!1000
[1] https://github.com/MicrosoftDocs/visualstudio-docs/blob/
9ec230dfd4908a92738d8dac5f44ad3e4ac751e3/LICENSE-CODE
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1487>
Rafał Dzięgiel [Wed, 29 Dec 2021 20:29:02 +0000 (21:29 +0100)]
assrender: Support RFC8081 mime types
Old "application/*" are now as per RFC8081 deprecated in favor of
new "font/*" mime types. Some new encoders are already using the
updated mime types. We need to also add them to the support list
in order for assrender to correctly identify them as fonts.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1481>
Rafał Dzięgiel [Wed, 29 Dec 2021 20:28:56 +0000 (21:28 +0100)]
assrender: Handle ".ttc" attachment extension
TTC stands for "TrueType Collection" file. We can pass it
into libass as any other attachment. Add it to the supported
extensions list, so the fonts it contains will be used.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1481>