Sachin Agrawal [Thu, 26 Feb 2015 17:28:56 +0000 (09:28 -0800)]
Updated tinyDTLS test apps to use identity hint
dtls-server test is updated to pass 'psk hint' to tinyDTLS library so that
it can send ServerKeyExchange packet. Similarly, dtls-client test
is updated to retrieve PSK specific for the server whose identity was
received via 'psk hint' packet.
Change-Id: Ifba720f1505ed6afbf56dfc179d98790176ce0b0
Signed-off-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/348
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Seung-Woo Lee <sw0524.lee@samsung.com>
Reviewed-by: Patrick Lankswert <patrick.lankswert@intel.com>
(cherry picked from commit
f5fb7aae180aa04babd2fc1364365b8ae1452efd)
Reviewed-on: https://gerrit.iotivity.org/gerrit/433
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
(cherry picked from commit
a8c761f0b18ecdfe1b4d4fa5d15ccdc2700d8bcc)
Reviewed-on: https://gerrit.iotivity.org/gerrit/597
Sakthivel Samidurai [Thu, 26 Mar 2015 22:43:41 +0000 (15:43 -0700)]
Update C++ Unit test for OCResource
Add unit test for missing OCResource API.
Change-Id: I8434a5410a774a9b95863ab3f6a19844a4a4007b
Signed-off-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/585
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Doug Hudson <douglas.hudson@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Mandeep Shetty [Thu, 26 Mar 2015 23:43:45 +0000 (16:43 -0700)]
Fix return type to enable callback.
UpdateResponseAddr() did not set success as result which caused the
stack to return quietly.
Set response type to OC_STACK_OK so stack can do the callback.
Change-Id: I3958c51f08735d2e7bf30bcefdfbb99255ea69bf
Signed-off-by: Mandeep Shetty <mandeep.shetty@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/587
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Sakthivel Samidurai [Thu, 26 Mar 2015 00:07:24 +0000 (17:07 -0700)]
Update C++ OCPlatform Unit test
Add unit test for external OCPlatform APIs
Change-Id: I0c17134429f99b9a6d28a79b248c92b2ad84b989
Signed-off-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/573
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Doug Hudson <douglas.hudson@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Mandeep Shetty [Tue, 24 Mar 2015 23:55:14 +0000 (16:55 -0700)]
Fix possible buffer overflows & array out of bound
Init char buffer to null so we don't have to keep adding null
characters.
Fixed potential array out of bounds issue in
occollection::HandleBatchInterface()
Change-Id: Ief43e5196fe360e0035f8aff49b15d969fb92b5e
Signed-off-by: Mandeep Shetty <mandeep.shetty@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/568
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Doug Hudson <douglas.hudson@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Erich Keane [Wed, 25 Mar 2015 23:46:28 +0000 (16:46 -0700)]
Explicitly specify OCResourceIdentifier assignments/ctors
The OCResourceIdentifier proxy class depends on compiler rules
to determine validity of constructors and assignments. This patch
correctly explicitly specifies these values.
Note: This patch does NOT change any behavior or functionality, it
solely specifies behavior explicitly rather than implicitly.
Change-Id: I5110cb10e07112e7786c56fedee43f76cfdab3bd
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/572
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
Mandeep Shetty [Thu, 26 Mar 2015 00:16:05 +0000 (17:16 -0700)]
Added check to not add duplicate resourcetype.
Do not add already existing resourcetype and or resource interface to linked list.
Also fixed incorrect logic in insertResourceType().
Change-Id: I43195e8f9d0d6c71274fd7321baf3a02268e2cf2
Signed-off-by: Mandeep Shetty <mandeep.shetty@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/574
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Erich Keane [Tue, 24 Mar 2015 21:16:13 +0000 (14:16 -0700)]
Fixed memory handling of HandleSingleResponse
As identified in the RI code review, the options and token
were leaked and had some interesting behavior if the options count
was zero. This patch corrects those, and repairs some return
values that were inconsistent and detected while chaising the
memory around.
Change-Id: Ica590fefc8702faa7108cc00642cbc2424f402ac
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/564
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Jon A. Cruz [Mon, 23 Mar 2015 07:13:15 +0000 (00:13 -0700)]
Code portability cleanup.
Added required #includes and #defines to allow the code to be compiled without
errors in more situations.
Fixed platform and compiler assumptions that would prevent the code from
compiling successfully under different compilers and platforms. This helps
with building with different compilers or even later versions of current ones.
Added comments documenting resons for the #defines and portability info.
Change-Id: Ia4a943af1d2d06509e46669f952b5e7ca80efaf4
Signed-off-by: Jon A. Cruz <jonc@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/532
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Erich Keane [Thu, 19 Mar 2015 23:10:11 +0000 (16:10 -0700)]
Fixed a number of KW Memory leaks in ocstack.c
Klocwork discovered a number of memory leaks. This fix repairs most
of them. A few are left behind due to Mandeep's commit in 518,
and Sachin's intent to look into the tok issues.
Change-Id: I92f5902e22dfbaa59e6b7d24985cfa489c93348b
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/520
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
Jon A. Cruz [Fri, 13 Mar 2015 01:29:37 +0000 (18:29 -0700)]
Adding unit test for connectivity-abstraction work.
Simple addition of unit test for adding cases related to the
connectivity-abstraction work. Utilized in subsequent commits.
Change-Id: Iee4d688ff78bcb358a4d403e32b81f5fdc3bd060
Signed-off-by: Jon A. Cruz <jonc@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/474
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Reviewed-by: Patrick Lankswert <patrick.lankswert@intel.com>
Jon A. Cruz [Sat, 21 Mar 2015 01:22:47 +0000 (18:22 -0700)]
Fixed Arduino config setup when 'ALL' is selected as a transport.
Arduino scons config was only structured to handle one transport as a time,
and would fail to configure needed lib imports when 'ALL' was the selected
transport.
This change removes the choice of 'ALL' when Arduino is the selected OS. It
also will log an error and stop the build when more than a single transport
is selected for Arduino builds. This is mainly until resources permit
testing of the code on hardware configurations with multiple transport
shields attached.
Change-Id: I9da97df1db696904581eaccbbbc519b291b0b3ed
Signed-off-by: Jon A. Cruz <jonc@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/507
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Reviewed-by: Patrick Lankswert <patrick.lankswert@intel.com>
Sudarshan Prasad [Tue, 24 Mar 2015 03:01:15 +0000 (20:01 -0700)]
Addressed magic strings, incorrect logging
- This changeset is put up to address comments from the full
code review of RI-CA integration
Change-Id: If89b482b3d13584529a399b761ef8d8d0a36caa7
Signed-Off-By: Sudarshan Prasad <sudarshan.prasad@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/551
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
Erich Keane [Tue, 24 Mar 2015 22:08:03 +0000 (15:08 -0700)]
Fixed memory leak from Observer
The observer delete mechanism was not properly deleting the token
that was created for it in the AddObserver method and was identified
in the RI code review in ocstack.c line 2109.
Change-Id: I56ba9c89a1890e28c79efb2d76b0783c037cd6e2
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/567
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
Sashi Penta [Tue, 24 Mar 2015 07:44:49 +0000 (00:44 -0700)]
Defined OC_MULTICAST_PORT instead of using const 5683
Change-Id: I6b73a795f02d244d9e0b417a2b7b2f3aa7fc91a3
Signed-off-by: Sashi Penta <sashi.kumar.penta@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/553
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Joseph Morrow [Mon, 23 Mar 2015 18:49:12 +0000 (14:49 -0400)]
Removed a single instance of the usage of a "magic number" in the stack.
After walking through the logic in ValidateQuery() its clear that there
was an intention add a second #define, but this must have been over-
looked at that time. There a single #define to avoid usage of a
"magic number" (or a raw value, ie. "2") but it was actually being used
in the wrong spot in the code.
Change-Id: I2ff045005ccacc9822280d93e6b20bfac8df1cbd
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/539
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Joseph Morrow [Tue, 24 Mar 2015 22:47:43 +0000 (18:47 -0400)]
Cleaned up some static initialization and casting errors in one function.
Cleaned up function to ensure that different scopes within the stack don't
act negatively on eachother by malloc'ing space for each caller to
obtain their own copy of the address.
Change-Id: I7ebdfde0fb6edbbe57f0d52b541fc252e7509b17
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/541
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Erich Keane [Tue, 24 Mar 2015 19:36:01 +0000 (12:36 -0700)]
Implemented OCRepresentation::setChildren
As reported in IOT 410, setChildren had a header entry, and
no implementation. This patch implements setChildren
Change-Id: I0f881dab27c09d72fd068c0b2d446bbfcc77a42b
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/561
Reviewed-by: Tim Kourt <tim.a.kourt@intel.com>
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
Sakthivel Samidurai [Mon, 23 Mar 2015 21:00:11 +0000 (14:00 -0700)]
Clean up OCStop in C stack
Cleanup OCStop method in the C stack. Remove unnecessary
error check.
Change-Id: I4a1618c684c685a32f70b3087f08fca0961d3461
Signed-off-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/545
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Sakthivel Samidurai [Mon, 23 Mar 2015 18:13:04 +0000 (11:13 -0700)]
Address RI Code review comments
Remove duplicate code to convert qualityOfService to
CAMessageType.
Change-Id: Icfc7365587cd4306d619544acfa9e6e70bea5d8e
Signed-off-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/537
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
Erich Keane [Thu, 19 Mar 2015 22:16:31 +0000 (15:16 -0700)]
Fixed KW Warnings based on using uninitialized values
The values adjusted here were improperly initialized, so these
fixes ensure that they are only used when properly initialized.
Note that in the second case, we were checking for NULL, but
dereferencing anyway. This adds an else case to avoid that.
Change-Id: I34cb292267f6ba21d3849fa5ad06b89eca02b557
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/519
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Mandeep Shetty <mandeep.shetty@intel.com>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
Erich Keane [Wed, 18 Mar 2015 21:06:09 +0000 (14:06 -0700)]
Fixed memory issues related to AddClientCB
AddClientCB had a weak memory-guarantee that caused 3 values to be
leaked in certain conditions. This will prevent those from happening.
The result-setting is done in order to ensure that the values are always
properly free'd.
Change-Id: I027fab84ddf62526d51a6e7e35dd54a96acbb48d
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/502
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
Erich Keane [Tue, 17 Mar 2015 22:19:38 +0000 (15:19 -0700)]
Fixed build warnings in stack
OCException's string handling was missing a few items.
ocstack used some creative casting to get a 16 bit value out
of an 8 bit array that could likely result in bad-optimizations
or undefined behavior.
Removed an unused variable.
Change-Id: I9af5d22f450f72d15b793cec57630e8c81f7b5de
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/496
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
sanjaysh [Mon, 23 Mar 2015 21:34:45 +0000 (14:34 -0700)]
isListOfObservers replaced with ObserveType in simpleserverHQ.cp
Signed-off-by: Sanjay Sharma<sanjay1.sharma@intel.com>
Change-Id: I733fd8e7e051ebf747dac58259df31c45546889e
Reviewed-on: https://gerrit.iotivity.org/gerrit/547
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Joseph Morrow [Mon, 23 Mar 2015 20:21:36 +0000 (16:21 -0400)]
Cleaned up some misdirection when copying a string's value.
A weird case occurred where a char* string was referencing array location
'0', then was being pass-by reference to appear as a "char*" which simply
returned the origin char* string.
Change-Id: I014207a4050d69cf5b8e2360f6c8d9d82a6c628e
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/542
Reviewed-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Joseph Morrow [Mon, 23 Mar 2015 19:26:34 +0000 (15:26 -0400)]
Added const keyword to several function parameters.
This file was considered in need of re-examination with regards to making
parameters const "where necessary" during the RI Code Review process (be-
fore merging the connectivity-abstraction and master branch).
Change-Id: I12db60e5404a0a5ce7811d53efc637815160a012
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/540
Reviewed-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Sachin Agrawal [Mon, 23 Mar 2015 19:14:23 +0000 (12:14 -0700)]
Fixed presence payload parsing logic (IOT-406)
Updated method parsePresencePayload to handle scenarios
when payload is not in the expected presence format.
Also added unit test to verify parsing functionality.
Change-Id: I47d995b8f49cc96805bf837ac2c2f77c1859da82
Signed-off-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/538
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
Caiwen Zhang [Tue, 3 Mar 2015 07:13:20 +0000 (15:13 +0800)]
Update scons build readme and howto document
Change-Id: I3a9e7dd82ad98f969449da42acadfad2e0eb4705
Signed-off-by: Caiwen Zhang<caiwen.zhang@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/432
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Patrick Lankswert <patrick.lankswert@intel.com>
(cherry picked from commit
f7c465f6d306179b4244591cfe0be73a14feb047)
Reviewed-on: https://gerrit.iotivity.org/gerrit/472
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
Jon A. Cruz [Fri, 20 Mar 2015 06:53:15 +0000 (23:53 -0700)]
Add missing c flag.
Adding missing c99 flag to arduino scons files to match other builds.
Change-Id: I118374979c448981ae2a7ca59648a1d30ca33f5b
Signed-off-by: Jon A. Cruz <jonc@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/531
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Joseph Morrow [Fri, 20 Mar 2015 21:34:18 +0000 (17:34 -0400)]
Enable build process for Arduino Mega on CA Branch for the CI System.
I believe this was previously mistakenly disabled. By re-enabling this,
we can ensure that all new commits to the CA Branch are validated
correctly.
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Change-Id: Icc882206bc3e2b8dc8dd5955bfa518e361f95b2b
Reviewed-on: https://gerrit.iotivity.org/gerrit/527
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Joseph Morrow [Fri, 20 Mar 2015 22:08:36 +0000 (18:08 -0400)]
Enable ability to build for Arduino with debug enabled.
The changes in this commit were required because for some reason the
function to log out a buffer's value was fully commented out for
the Arduino platform, while calls for it still existed for the Arduino
platform when running in debug mode.
Change-Id: Ia84761503627b05856819cca672f72ff7f897582
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/529
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Joseph Morrow [Fri, 20 Mar 2015 22:39:57 +0000 (18:39 -0400)]
Disable default to auto install to Arduino device after build.
By defaulting auto-upload to false, this will allow developers to build
for the Arduino platform and remove any need to actually have an Arduino
device plugged in to their machine to see a successful build output from
Scons.
Change-Id: I804bb8cc03f38bf4d79206905bcf4bdf23ee7bb9
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/530
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Sachin Agrawal [Fri, 20 Mar 2015 20:42:21 +0000 (13:42 -0700)]
Fixed RI-CA review integration changes
Updated files for some issues identified in Gerrit Patch 401.
Change-Id: I5b6bfb60e10d9ae4af358e03aaf8c5a4d8854911
Signed-off-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/486
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Doug Hudson <douglas.hudson@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Sakthivel Samidurai [Wed, 18 Mar 2015 23:01:26 +0000 (16:01 -0700)]
Update C++ unit test
Integrate OCRepresentation tests to C++ unit test.
Change-Id: I65a3bd0066d084fb51a062005e8da39a6e9e5bdc
Signed-off-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/503
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
Doug Hudson [Thu, 19 Mar 2015 22:02:22 +0000 (18:02 -0400)]
Fix potential memcpy buffer overruns.
Change-Id: Ia43054f29a3f3b3ac8118848847a06046822615e
Signed-off-by: Doug Hudson <douglas.hudson@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/516
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Doug Hudson [Mon, 16 Mar 2015 19:24:30 +0000 (15:24 -0400)]
Fixed CA logging issues.
- Fixed incorrect use of DEBUG label for logging error conditions.
Mod done as part of fixing unresolved CA issues.
- Fixed incorrect use of OIC_LOG_V in connectivity/src and
for single thread files that might affect Arduino stack size.
This issue was not listed in CA review.
Change-Id: I38cc2310bf3a7c91d0dd8b457a237c7f930e6646
Signed-off-by: Doug Hudson <douglas.hudson@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/479
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
Sachin Agrawal [Thu, 19 Mar 2015 19:26:19 +0000 (12:26 -0700)]
Fix OCInit review comments identified in CA-RI Integration Review
Updated OCInit to correctly handle all error situations and also
improved logging in case of failures.
Change-Id: I946255883a26b4afe96ee9d2b00ba775f7250fb1
Signed-off-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/487
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Doug Hudson <douglas.hudson@intel.com>
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Jon A. Cruz [Thu, 19 Mar 2015 21:00:06 +0000 (14:00 -0700)]
Do not try to build OICMiddle examples on arduino.
When the target OS is arduino, avoid attempting to build the OICMiddle
example since it is C++ and not supported for that platform.
Change-Id: I054ab220214c707954f4bf3cf17b6667ee9a82a6
Signed-off-by: Jon A. Cruz <jonc@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/517
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Joseph Morrow [Thu, 19 Mar 2015 16:43:04 +0000 (12:43 -0400)]
Made changes required to get the RI layer to build properly for Arduino.
Changes made in the RI Code Review(
49ead758a03c532e7c95f5b6eb88c1d979cd36a0)
introduced build warnings on Linux. Due to the use of an older and more
verbose compiler when building for Arduino, these warnings are errors in the
build process for Arduino. This commit enables Arduino compilation by fixing
those errors.
Change-Id: I36643b4769a65badad5fc69b6fc18dbce18e22fa
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/515
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Mandeep Shetty [Thu, 19 Mar 2015 00:44:18 +0000 (17:44 -0700)]
Removed potential buffer overflow.
Malloc based on strlen() did not acount for the null character.
Change-Id: Iff9fed3e684e26576d24d9607ebd5afefec32ef0
Signed-off-by: Mandeep Shetty <mandeep.shetty@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/504
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Joseph Morrow [Thu, 19 Mar 2015 14:57:59 +0000 (10:57 -0400)]
Added proper doxygen documentation to the file ocresourcehandler.h.
Change-Id: Iaef7aa463856615bfe4696cb3ec517e18188f28d
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/491
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Mandeep Shetty [Wed, 18 Mar 2015 18:23:53 +0000 (11:23 -0700)]
Added logging of tokens as hex for readability.
Tokens being printed as hex.
Removed printing of ASCII tokens as token not guranteed to be null
terminated. There seems to be some discussion about this issue in
IOT-380.
Signed-off-by: Mandeep Shetty <mandeep.shetty@intel.com>
Change-Id: I9756c552f3abc3acdadb9e9fe4b9eb20d7ecf3eb
Reviewed-on: https://gerrit.iotivity.org/gerrit/501
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Erich Keane [Mon, 16 Mar 2015 20:38:00 +0000 (13:38 -0700)]
Fixed InitializeException issues
InitializeException had a number of minor issues that are repaired in
this fix. Note that the interface of InitializeException changes a bit,
however it seems that no one is actually catching InitializeException
anywhere, so they wouldn't be able to use the old version.
This fix switches InitializeException to inherit from OCException,
permitting us to catch it properly, rather than being a different exception
type. This results in the reason, code, and 'what' methods working properly
in both cases, rather than differing slightly by behavior.
Change-Id: If41377af1b1c4ef7297ae9644ef2e7e7e4f8b603
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/483
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
Erich Keane [Tue, 17 Mar 2015 21:05:51 +0000 (14:05 -0700)]
Removed Dead FormOCResponse Code
The function FormOCResponse was previously only used in one place,
and had no side effects other than allocating memory and filling an
object with a bunch of different values.
The calling site (OCProcessPresence) only refers to the OCResponse
object in this single call, then leaks it immediately after.
This changeset removes the function, the variable, and the call to
this function.
Change-Id: Ic40440fce04343149528fb4d33f42f73da908171
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/494
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
Sakthivel Samidurai [Mon, 16 Mar 2015 22:37:32 +0000 (15:37 -0700)]
Changeset for reviewing RI-CA integration changes.
--Added a single line at the end for full RI code review.
--For specific RI integration changes refer
https://gerrit.iotivity.org/gerrit/#/c/394/
Change-Id: I54e3fcf2e0c10c382d4be59d2d380eb4db5f9791
Signed-Off-By: Sudarshan Prasad <sudarshan.prasad@intel.com>
Signed-off-by: Erich Keane <erich.keane@intel.com>
Signed-off-by: Shilpa Sodani <shilpa.a.sodani@intel.com>
Signed-off-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/401
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
Tested-by: Sashi Penta <sashi.kumar.penta@intel.com>
Jon A. Cruz [Fri, 13 Mar 2015 01:29:37 +0000 (18:29 -0700)]
Fixed problems in URI parsing including memory corruption.
Fixed issues in CAParseURI that included
* Use of uint32_t instead of size_t.
- Passing by address resulted in corruption on 64-bit builds and all
others where the datatypes are different. This includes various
embedded devices that have a size_t smaller than uint32_t.
* Miscalculation of offset would freeze parsing once a few path components
or parameters were processed.
- While walking parsed results list the buffer-check addition would fail
and all subsequent path components or parameters (depending on each
independently) would repeat the contents of a prior item. Thus the end
of path components and/or parameter parts of the list would be filled
with repeats of a single value instead of the correct latter values.
* Replaced duplicated code blocks with a single helper function.
* Added unit tests for issue. However the test cases won't be runnable
until after the build machine issue with connectivity/test is addressed.
Change-Id: Ife3f327ae3bbda518d663bb0d6c5b4c0d8f98e9a
Signed-off-by: Jon A. Cruz <jonc@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/470
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Joseph Morrow [Tue, 17 Mar 2015 18:14:23 +0000 (14:14 -0400)]
Removed unused macro.
Cleaned up the definition of an unused macro in occlientcb.c.
Change-Id: Id43fcb3df6140dea11fa76cd59519b007af90974
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/492
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Erich Keane [Mon, 16 Mar 2015 22:03:29 +0000 (15:03 -0700)]
Fixed InProcClientWrapper's option parameter to OCDoResource
InProcClientWrapper was calling OCDoResource with the option
parameter set to a valid value despite the numOptions being 0.
This commit ensures that it will send a nullptr in that event,
preventing confusion during debugging in the future.
Change-Id: Ided75e1c90a971ea205e9e04bf170a5144e8206d
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/485
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
Sakthivel Samidurai [Mon, 9 Mar 2015 23:40:49 +0000 (16:40 -0700)]
Run unit tests after building the stack
Run unit tests after building the C/C++ stacks and unit tests.
Change-Id: I11bf90f95f30815abd272a26d82c97815d4e8bc7
Signed-off-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/455
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
Reviewed-by: William Dieter <william.r.dieter@intel.com>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
Erich Keane [Mon, 16 Mar 2015 20:14:31 +0000 (13:14 -0700)]
Fixed Free of invalid memory in remote handler
Previously review 476 (
75980f86) was submitted as a workaround
for this one, however this fixes the root cause, which is the
options pointer not being set to zero in the condition where there
is no options being set.
Change-Id: I0152dfc8c1813def7762be37fb91cc3cc3f120d3
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/482
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
Mandeep Shetty [Fri, 13 Mar 2015 21:02:44 +0000 (14:02 -0700)]
Fix result code translations from COAP to CA.
Temp fix with macros to convert COAP codes to CA code.
Change-Id: I3bb759c63dafcfcc5a491133577c75240d63affe
Signed-off-by: Mandeep Shetty <mandeep.shetty@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/475
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
Mandeep Shetty [Sat, 14 Mar 2015 00:08:02 +0000 (17:08 -0700)]
Check validity before free-ing options pointer.
Free pointer only if pointer is valid decided on basis of
number of options preset in the header.
Change-Id: I21666e4f694652120ed164ffc763b0aeeb0ea951
Signed-off-by: Mandeep Shetty <mandeep.shetty@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/476
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
Mandeep Shetty [Tue, 10 Mar 2015 23:20:49 +0000 (16:20 -0700)]
Return correct stack result on malloc fail in ocstack.c
Assign OC_STACK_NO_MEMORY to result variable when memory allocation
fails before jumping to exit.
Change-Id: I99c8f4ee18d82ef1b6a70c29b4625a06f61f7e4a
Signed-off-by: Mandeep Shetty <mandeep.shetty@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/460
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
Doug Hudson [Thu, 12 Mar 2015 19:20:49 +0000 (15:20 -0400)]
Fixed bug where pointer is dereferenced before it is validated.
Change-Id: I6628c52bd3536cf57a320008e46b61968927e3f6
Signed-off-by: Doug Hudson <douglas.hudson@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/468
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
Jon A. Cruz [Thu, 12 Mar 2015 17:17:32 +0000 (10:17 -0700)]
Removed incorrect static from function declaration.
Declaring the function as 'static' in a header attempts to create a private
copy of the function in each file that includes the header. Correcting this
cleared several warnings.
Change-Id: Ie1bb47e929fb0aa5530c397e4dce275ad1e0fb0e
Signed-off-by: Jon A. Cruz <jonc@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/465
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
Jon A. Cruz [Fri, 6 Mar 2015 00:44:03 +0000 (16:44 -0800)]
Corrected @file tags and restored 'Files' section.
* Corrected @file tags that were inadvertently broken which left their
comments falling to the next item to be documented.
* Removed unnecessary '@brief' tags and explicit filenames. The latter are
only required when the @file is targeting a source other than the one it
is present in.
* Unified formatting of @file doc comment blocks.
* Added 'Files' section back to generated docs.
Change-Id: I7f3fbc3cecf5a922c9f8a98d673bc91a18be8847
Signed-off-by: Jon A. Cruz <jonc@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/461
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Patrick Lankswert <patrick.lankswert@intel.com>
Joseph Morrow [Tue, 10 Mar 2015 18:53:51 +0000 (14:53 -0400)]
Added SCons support for Arduino platform.
Change-Id: I9dcf69cef00dc14e099c1355ad7f2118746fa3e1
Signed-off-by: Doug Hudson <douglas.hudson@intel.com>
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/431
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Ashok Channa [Wed, 4 Feb 2015 09:48:20 +0000 (18:48 +0900)]
Added connectivity files for full code review
Please comment on patch set 14 if any comments are not addressed
from 1~13.
NOTE:
1)Code Comments till Patch Set 13 are updated.
2)Please put your comments on new patch sets(at least from 13) and
try to avoid on old patch sets as it difficult to review the old sets
Modified CA source files for review comments.
Updated documentation, return parameters with CAResult, optimization etc.
Global variable naming conventions ..
Change-Id: Id19ec37831ae46896b59007cdde07217b5d8696a
Signed-off-by: Ashok Channa <ashok.channa@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/193
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Patrick Lankswert <patrick.lankswert@intel.com>
Joseph Morrow [Mon, 9 Mar 2015 17:53:03 +0000 (13:53 -0400)]
Applied fixes to enable Unicast discovery in the RI Layer's sample apps.
This fixes IOT-372 "Unicast Discovery over Wifi does not work."
Change-Id: Ifbc545f8a04049518410a4d9f54f692388921288
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/452
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Doug Hudson <douglas.hudson@intel.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Doug Hudson [Mon, 9 Mar 2015 20:21:23 +0000 (16:21 -0400)]
Fix error in downloading hippomocks library.
Apparently, the filename of the hippomocks library zip file that is
downloaded from the github changed from 'master.zip'
to 'hippomocks-master.zip' since the hippomocks.scons script was created.
This modification uses a SHA hash to download a specific version of
the hippomocks library.
Change-Id: Iaa3b523b11c35a918a0a3de22876f2d62f339372
Signed-off-by: Doug Hudson <douglas.hudson@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/454
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
Mandeep Shetty [Fri, 6 Mar 2015 21:39:58 +0000 (13:39 -0800)]
Constant time insert into linked list of resources.
Do not iterate over linked list to insert at end.
We already iterate once to check if resource uri already exists.
Use a pointer to the tail of the linked list to insert resource.
Changed two extern variables to static as they're only used in one module.
Change-Id: I41f458a2384b4fa2d8a23d78e632e1614d4875c8
Signed-off-by: Mandeep Shetty <mandeep.shetty@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/365
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Doug Hudson <douglas.hudson@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Joseph Morrow [Mon, 9 Mar 2015 17:54:15 +0000 (13:54 -0400)]
Fixed issues that are warnings on Linux, but errors on Arduino.
Change-Id: Ibbc1d31e64e5aad711dc576c517c7665f622f40f
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/453
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
Reviewed-by: Doug Hudson <douglas.hudson@intel.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Mandeep Shetty [Fri, 27 Feb 2015 23:30:19 +0000 (15:30 -0800)]
Fixing query delimiters in uri reassembly.
The first delimiter after the uri and before the query is '?'
All eventual delimiters between query params are '&'.
This is missed out on the patch :
https://gerrit.iotivity.org/gerrit/#/c/193.
Change-Id: Iec533d10075e1692a84b36683b0b42b2b702a01e
Signed-off-by: Mandeep Shetty <mandeep.shetty@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/422
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
Sanjeev BA [Wed, 4 Feb 2015 03:06:10 +0000 (12:06 +0900)]
Minor typo fixes.
Change-Id: I9e36e8f6f9f88620b4d65a889f927d6c7c9c2f97
Signed-off-by: Sanjeev BA <as2902.b@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/302
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
Erich Keane [Mon, 2 Mar 2015 21:04:47 +0000 (13:04 -0800)]
Fixed Klocwork errors in InProcClientWrapper.cpp
Klocworks identified a number of issues as memory leaks, so
this fix updates the calls to use the newer version of OCDoResource
which permits passing of a NULL rather than using the out parameter.
Change-Id: I02cf1d83d4dfafca0773e6e3385881d180335de4
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/428
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
Mandeep Shetty [Thu, 5 Mar 2015 22:35:29 +0000 (14:35 -0800)]
Removing unneccesary floating point conversions.
Remove casting uint types to float in presence bounds calculation
and using division with a single floating point constant instead.
Change-Id: I7b1738753ccec3109c698774204d3d92fde7de21
Signed-off-by: Mandeep Shetty <mandeep.shetty@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/443
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
Shilpa Sodani [Thu, 26 Feb 2015 23:10:38 +0000 (15:10 -0800)]
Fix Presence issue of not working on Ethernet
Change connectivityType of Presence resource to OC_ALL
Send presence notification on all the n/w interface
Fix IOT-351 & IOT-270
Fixed the if-statement for freeing header options
Change-Id: I553434b77885a466a63fba0968edf400abacb53f
Signed-off-by: Shilpa Sodani <shilpa.a.sodani@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/415
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
William Dieter [Fri, 27 Feb 2015 15:11:38 +0000 (15:11 +0000)]
Removed unneeded references to oic-utilities
The oic-utilities repo was used as a temporary solution for holding third
party libraries. The build system now has a better way to handle them.
This commit removes obsolete instructions to copy the oic-utilities repo
from the scons build instructions.
The resource/csdk/README.txt file still has a reference to oic-utilties,
as do some of the old release notes files. The csdk README can probably
be deleted when makefiles are eliminated.
Change-Id: Ic5824264835359a59cfd79443ce4e773205eeb07
Signed-off-by: William Dieter <william.r.dieter@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/420
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Caiwen Zhang <caiwen.zhang@intel.com>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
(cherry picked from commit
18d902402335fb1394b2c8c57640255a5f707917)
Reviewed-on: https://gerrit.iotivity.org/gerrit/424
Sashi Penta [Fri, 20 Feb 2015 09:29:06 +0000 (01:29 -0800)]
Remove unused HandleStackResponses function
Change-Id: I31e854345ee7d25308a37bbebde3e1eb19dc8f47
Signed-off-by: Sashi Penta <sashi.kumar.penta@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/373
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-by: Shilpa Sodani <shilpa.a.sodani@intel.com>
Reviewed-by: Patrick Lankswert <patrick.lankswert@intel.com>
Sashi Penta [Tue, 24 Feb 2015 06:09:08 +0000 (22:09 -0800)]
Fix Presence notification issues.
* Handle duplicate stop notification on the client side.
* Once StopPresence is called on the server, no more notifications are sent. Fixes IOT-66.
* Correct implementation for sending the presence notification when unbinding.
Change-Id: I112a1ef2cb5c04d847c0c83f5309d67acdc4c1fb
Signed-off-by: Sashi Penta <sashi.kumar.penta@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/402
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Patrick Lankswert <patrick.lankswert@intel.com>
Sachin Agrawal [Thu, 5 Mar 2015 16:44:30 +0000 (08:44 -0800)]
Added workaround to enable security in CA branch
Currently there is a disconnect in the data structure used between RI
layer and CA layer to convey DTLS PSK credentials. We cannot update this
data structure in CA layer until all reviews of CA layer is completed.
This inhibits security testing of CA branch. Adding this workaround until
an update happens in CA layer to use common data structure.
Change-Id: Ieb17043c6ab3a32961133c5e009f5c06d968979f
Signed-off-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/369
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
Sakthivel Samidurai [Mon, 2 Mar 2015 23:07:44 +0000 (15:07 -0800)]
Run Unit test after building the stack
Build using scons with TEST=1 command line option to run both
iotivity core C and C++ unittests. Output the unittest
result file in ./out/linux/x86_64/debug/ for debug build.
Output the unittest result file in ./out/linux/x86_64/release
for release build.
Change-Id: I871d3c84a32263f2861fe2896bc3f34ab25b9474
Signed-off-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/430
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: William Dieter <william.r.dieter@intel.com>
Reviewed-by: Caiwen Zhang <caiwen.zhang@intel.com>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
Sachin Agrawal [Fri, 27 Feb 2015 19:49:26 +0000 (11:49 -0800)]
Fixing Klocwork reported error in secure sample apps
Recently OCDoResource API was updated to take a NULL handle.
Updated sample apps to pass a NULL handle. This will stop
Klocwork on generating false positives.
Change-Id: I35f81cdde155a4118578ea86a35a981038c22f2e
Signed-off-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/421
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Reviewed-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
Shilpa Sodani [Thu, 26 Feb 2015 22:17:20 +0000 (14:17 -0800)]
Fix CA invalid free memory bug
Fixed the if-statement for freeing header options
Change-Id: I13e809b805cb94495aa7487dfb6ed1ca4bd53396
Signed-off-by: Shilpa Sodani <shilpa.a.sodani@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/413
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
Sakthivel Samidurai [Thu, 26 Feb 2015 19:14:32 +0000 (11:14 -0800)]
Fix scons build issue
The scons fails due to 'stacktest_env' is not defined.
Replace stacktest_env with unittests_env.
Change-Id: I9ec68a05f7c576be3686fe12f93077cd6c7ac7ca
Signed-off-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/412
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
Reviewed-by: Ossama Othman <ossama.othman@intel.com>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
Erich Keane [Mon, 23 Feb 2015 22:40:13 +0000 (14:40 -0800)]
Changed OCDOResource's handle param to take NULL
Most calls to OCDoResource were ignoring the handle parameter's
out value, so this call formalizes that a NULL is an acceptable value
for this parameter. The callers that were using this (as highlighted
by Static Code Analaysis) without using the handle parameter were all
switched to use this new NULL functionality.
Change-Id: I9fc047c080499d1283ffc2cba32addd0f5689c77
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/400
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
Joseph Morrow [Mon, 23 Feb 2015 21:07:13 +0000 (16:07 -0500)]
Added ability to init with only transports that are compiled-in.
Added algorithm to try to initialize all transports. If a transport
is not currently supported (ie. not compile-in to CA Library) then
we ignore the error.
This fixes Jira Ticket IOT-255 -> "CA Call to CASelectNetwork() fails
with CA_NOT_SUPPORTED when two network types are specified."
Change-Id: I599a4a70fa3f64aa6215997bfbb0e0252437e830
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/326
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
Joseph Morrow [Mon, 23 Feb 2015 21:01:03 +0000 (16:01 -0500)]
Added helper function to map CAResult_t types to OCStackResult types.
Change-Id: I448b9d4abf416b17b7853cfa4a361a15a5244163
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/377
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
Sachin Agrawal [Fri, 20 Feb 2015 14:20:56 +0000 (06:20 -0800)]
Fixing errors reported by Klocwork tool
Error Report from Klocwork
1)FUNCRET.GEN: Non-void function does not return value :
C and C++ : gen_sec_bin.cpp : Critical (1) : Analyze : Local
2)NPD.CHECK.MIGHT: Pointer 'fps' checked for NULL at line 123
may be dereferenced at line 132. : C and C++ : gen_sec_bin.cpp :
Critical (1) : Analyze : Local
3)NPD.FUNC.MIGHT: Pointer 'fps' returned from call to function 'fopen'
at line 123 may be NULL and may be dereferenced at line 132. :
C and C++ : gen_sec_bin.cpp : Critical (1) : Analyze : Local
4)UNINIT.STACK.ARRAY.MIGHT: 'payload' array elements might be used
uninitialized in this function. : C and C++ : ocserverbasicops.cpp :
Critical (1) : Analyze : Local
Change-Id: I970bc060191caf17b102b165bbe5656b079ad063
Signed-off-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/374
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-by: Patrick Lankswert <patrick.lankswert@intel.com>
Sanjeev BA [Thu, 5 Feb 2015 02:37:07 +0000 (11:37 +0900)]
Remove redundant check.
Change-Id: Ic431d64964d8eea9fd29571cab33ba16475cfc66
Signed-off-by: Sanjeev BA <as2902.b@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/307
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ossama Othman <ossama.othman@intel.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
Ossama Othman [Wed, 18 Feb 2015 21:59:06 +0000 (13:59 -0800)]
Retrieve build flags from pkg-config only once.
The pkg-config command used to retrieve the build flags for several
libraries in Linux, Tizen and Android builds was added to the C and
C++ command line flags as a shell "backtick" expression, e.g.:
gcc ... `pkg-config glib-2.0 --cflags` ...
That caused pkg-config to be run for each and every source file
compilation command executed by SCons. Doing so is an expensive
operation since it causes an additional process to be spawned to read
the same flags for each source file being compiled.
Just have SCons read them and merge them to the build environment
once!
Change-Id: I3120aef7929464c033c8dabf6ec0ca88e5b67f89
Signed-off-by: Ossama Othman <ossama.othman@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/367
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Patrick Lankswert <patrick.lankswert@intel.com>
Ossama Othman [Wed, 18 Feb 2015 22:32:23 +0000 (14:32 -0800)]
Removed carriage returns in middle of text and at line endings.
Depending on the editor or viewer, the carriage returns may not
be readily apparent. To search for them via the command line
something like the following may be used:
find . -name "*.[ch]" -o -name "*.cpp" | xargs grep -n $'\r' \
| grep -v extlibs
Change-Id: Ifabf59b1becbd3d8c8cbfa6363c9bc9f5f3ab4e7
Signed-off-by: Ossama Othman <ossama.othman@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/368
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Reviewed-by: Patrick Lankswert <patrick.lankswert@intel.com>
Sakthivel Samidurai [Tue, 17 Feb 2015 16:48:23 +0000 (13:48 -0300)]
Fix klocwork issues in C samples
Check "*targetString" pointer before using it.
Change-Id: I47223c9787f5c9855d5850db40da4637265bd2d7
Signed-off-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/361
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
William Dieter [Thu, 4 Dec 2014 03:35:04 +0000 (22:35 -0500)]
Added Vagrant config files that will create a build VM
As described in the tools/vagrant/README.md, Vagrant can use the
configuration provided in this commit to provision a build VM for building
IoTivity.
Change-Id: Ic2ae5a7bfc9e4274aa76be99a0807517f89c94b8
Signed-off-by: William Dieter <william.r.dieter@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/88
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Patrick Lankswert <patrick.lankswert@intel.com>
(cherry picked from commit
3b864d1ab9656a2570888b64b8384b406e9212c6)
Reviewed-on: https://gerrit.iotivity.org/gerrit/383
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
William Dieter [Tue, 17 Feb 2015 04:53:35 +0000 (23:53 -0500)]
Updated Doxygen @param for OCResourceResponse::setResourceRepresentation
The parameter was updated in a previous commit without updating the
Doxygen comments.
Change-Id: Ia6fc35d7a7ad8c6fd8a0d076aa21915813fe2820
Signed-off-by: William Dieter <william.r.dieter@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/352
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
(cherry picked from commit
50ef54a78a90638144db9fe55c1fb97b6196ff9b)
Reviewed-on: https://gerrit.iotivity.org/gerrit/356
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
William Dieter [Tue, 17 Feb 2015 05:41:32 +0000 (00:41 -0500)]
Guard against spurious wakeups in devicediscoveryclient.cpp
Like most condition variable implementations, std::condition_variable may
wake up spuriously, even though it is not signalled (see
http://en.cppreference.com/w/cpp/thread/condition_variable/wait). Since
the intention of blocking on the std::condition_variable in main is to
wait forever, add a loop to block again after spurious wakeups.
Change-Id: I19b7ee13650b9b80250f935e2099119611fa61b3
Signed-off-by: William Dieter <william.r.dieter@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/355
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
(cherry picked from commit
73b122b0590bc350c1a451d7d05db86e3f0121d3)
Reviewed-on: https://gerrit.iotivity.org/gerrit/392
William Dieter [Tue, 17 Feb 2015 06:45:00 +0000 (01:45 -0500)]
Guard against spurious wakeups in devicediscoveryserver.cpp
Like most condition variable implementations, std::condition_variable may
wake up spuriously, even though it is not signalled (see
http://en.cppreference.com/w/cpp/thread/condition_variable/wait). Since
the intention of blocking on the std::condition_variable in main is to
wait forever, add a loop to block again after spurious wakeups.
Change-Id: I97e89a1ec95d6ba65eeb7daff861ee0a65d03a7e
Signed-off-by: William Dieter <william.r.dieter@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/357
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
(cherry picked from commit
5df6036cde74bf174d9d61b618d81f8d7034d6c4)
Reviewed-on: https://gerrit.iotivity.org/gerrit/391
William Dieter [Tue, 17 Feb 2015 04:52:13 +0000 (23:52 -0500)]
Added resource/include/OCRepresentation.h to Doxyfile
OCRepresentation is passed as a paramter to documented API calls, so
presumably, it should be part of the public, documented API.
Change-Id: Ia17813b8ade749d0446d1ed4068f7e49d60d6ec4
Signed-off-by: William Dieter <william.r.dieter@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/351
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
(cherry picked from commit
9dcf248ecb99d3eb18fea0ca445818329f7d4e1e)
Reviewed-on: https://gerrit.iotivity.org/gerrit/393
jk13 [Mon, 16 Feb 2015 03:50:01 +0000 (12:50 +0900)]
[SSM] Fix console sample
1. Fix sample application while reading query string from console
Change-Id: I90076ad0711ce165293a4db159e5796f1b7c93ee
Signed-off-by: jk13 <jihyeok13.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/347
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
(cherry picked from commit
5d2e8e333eb30d38e636d329f03dda36a1189d9e)
Reviewed-on: https://gerrit.iotivity.org/gerrit/390
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
HyunJun Kim [Thu, 12 Feb 2015 07:09:59 +0000 (16:09 +0900)]
Fix runtime error of ThingsManager API.
Some API and examples show runtime errors.
So we fixed runtime errors and issues.
Fix [IOT-324], [IOT-326], [IOT-336], [IOT-337]
Change-Id: I0f71b3a2243e4856203140aae71db473f4fa32ad
Signed-off-by: HyunJun Kim <hyunjun2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/330
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
(cherry picked from commit
24b19311190ac247aee64809064f63c5c796384a)
Reviewed-on: https://gerrit.iotivity.org/gerrit/389
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
HyunJun Kim [Mon, 9 Feb 2015 08:09:45 +0000 (17:09 +0900)]
Improve usability of Group Interface API.
GetActionSetFromString function has memory leak.
So we fix memory leak and improve usability of the function.
We call two function, ExtractKeyValueFromRequest and BuildActionSetFromString
to extract key and value from requset and get ActionSet object from string.
Fix [IOT-283]
Change-Id: Ie13dcd0afc168632d9a53ad27182d15a55c3aca0
Signed-off-by: HyunJun Kim <hyunjun2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/308
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
(cherry picked from commit
061a9bc4c0ef896016ea94ebf17c18c55a28e799)
Reviewed-on: https://gerrit.iotivity.org/gerrit/387
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
Caiwen Zhang [Thu, 12 Feb 2015 02:31:49 +0000 (10:31 +0800)]
Improve external library management error handling
Change-Id: I2a0b7003f0bd2987fa101285977fa0621688017b
Signed-off-by: Caiwen Zhang<caiwen.zhang@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/327
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Patrick Lankswert <patrick.lankswert@intel.com>
(cherry picked from commit
c824277b602590f2f4af8b553106b6913e62fad2)
Reviewed-on: https://gerrit.iotivity.org/gerrit/388
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
Patrick C Lankswert [Mon, 2 Feb 2015 15:50:39 +0000 (10:50 -0500)]
Add missing LICENSE and NOTICE file to repository.
Change-Id: Ib47076ee53884cb4bd87cc822dff0437ca1deb9e
Signed-off-by: Patrick Lankswert <patrick.lankswert@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/283
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ossama Othman <ossama.othman@intel.com>
Reviewed-by: Fred Cooper <fred.cooper@intel.com>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
(cherry picked from commit
a02e3f263c942496b5e1e05fb1d523b77d9e8500)
Reviewed-on: https://gerrit.iotivity.org/gerrit/386
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
Erich Keane [Wed, 4 Feb 2015 20:08:26 +0000 (12:08 -0800)]
Adding OCRep destructor, various move activities
Apparently OCRepresentation's destructor was causing issues
in the JNI version. Seemingly adding a virtual destructor to
the OCRepresentation is enough to cause this to go away.
Also adding move construction/assignment to our more expensive
types.
Change-Id: Icb3b6f25e268384b51126e18ec55fc5099c9b2f9
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/305
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Patrick Lankswert <patrick.lankswert@intel.com>
(cherry picked from commit
b7a33ba1905fcef02c21532a944ddc0958a121af)
Reviewed-on: https://gerrit.iotivity.org/gerrit/385
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
Minji Park [Fri, 6 Feb 2015 06:07:46 +0000 (15:07 +0900)]
[SSM] Fix SSM Sample App to handle invalid input for app menu (IOT-290)
Modify SSM Linux Sample App to to prevent unexpected input values
Change-Id: Ic9de6e894a44a903f02d60f6eeaf0fa9035e0e5a
Signed-off-by: Minji Park <minjii.park@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/315
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
(cherry picked from commit
d37ac7328d1f6bf0fc8da65aac9af8b0edcdd904)
Reviewed-on: https://gerrit.iotivity.org/gerrit/384
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
jjack.lee [Mon, 26 Jan 2015 04:59:03 +0000 (13:59 +0900)]
Fix problem for multiple api call
It is thread issue. So, add lock mechanism.
Fix [IOT-263]
Change-Id: Ic0fac30b1a4c0c305af607e5caa7c1afd21163b6
Signed-off-by: Jack Lee <jjack.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/243
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
(cherry picked from commit
522c05e82f1ccd3ae2cf4b4a63ec414f7ebcb8ce)
Reviewed-on: https://gerrit.iotivity.org/gerrit/381
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
HyunJun Kim [Tue, 3 Feb 2015 02:10:55 +0000 (11:10 +0900)]
Fix infinite loop in GroupAction.
Fix infinite loop in FindAndDeleteActionSet function.
So we change the code.
Fix [IOT-282]
Change-Id: I23d3663ea32c5e56a456b013d4c697fcf0f886d2
Signed-off-by: HyunJun Kim <hyunjun2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/286
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>
(cherry picked from commit
6a8ad4c43926df7541b414452ed57dbc9761137a)
Reviewed-on: https://gerrit.iotivity.org/gerrit/380
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
Sudarshan Prasad [Mon, 2 Feb 2015 02:18:44 +0000 (18:18 -0800)]
Release notes for Feb 1st release
Change-Id: I046922a66eaa03b18482fb139986a439a49f568f
Signed-off-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/282
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
(cherry picked from commit
0d8fae69e903dffdd90ad2e8ff5a7cd58afb78da)
Reviewed-on: https://gerrit.iotivity.org/gerrit/379
HyunJun Kim [Thu, 29 Jan 2015 04:38:08 +0000 (13:38 +0900)]
Add API description of Things Manager.
joinGroup and findGroup function call were ambiguous
when join to a local(or remote) resource.
We provide more detail description of function for the user.
Fix [IOT-265],[IOT-267]
Change-Id: I43de1f6671dc73d0725bdc9c0e85ffca45878d2e
Signed-off-by: HyunJun Kim <hyunjun2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/245
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
(cherry picked from commit
a3c86a7a2d2fce37f68fd3cf738500e17480cbbe)
Reviewed-on: https://gerrit.iotivity.org/gerrit/378
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
HyunJun Kim [Fri, 23 Jan 2015 04:15:09 +0000 (13:15 +0900)]
Fix GroupSync API of about GroupSync of Group feature.
Crash is occured when som api of ThingsManager is called multiple times.
Fix [IOT-261], [IOT-264], [IOT-268]
Change-Id: Iec1cb11c570357411351c69450ace91ea6fa3754
Signed-off-by: HyunJun Kim <hyunjun2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/228
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
(cherry picked from commit
135e8386212533f4c62e892f0695c78d945f2879)
Reviewed-on: https://gerrit.iotivity.org/gerrit/375
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>