Mike Blumenkrantz [Fri, 17 Jun 2022 14:14:00 +0000 (10:14 -0400)]
zink: move draw-time barrier generation down a little
ensure that this occurs after potential rebind handling
Acked-by: Dave Airlie <airlied@redhat.com>
Reviewed-By: Tatsuyuki Ishi <ishitatsuyuki@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17111>
Mike Blumenkrantz [Thu, 16 Jun 2022 20:58:37 +0000 (16:58 -0400)]
mesa/st: increment num_uniforms for hw accel select shaders
this otherwise breaks nir_lower_uniforms_to_ubo() and probably lots
of drivers
Fixes:
9b22ab4167e ("mesa/st: implement hardware accelerated GL_SELECT")
Reviewed-by: Qiang Yu <yuq825@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17092>
Mike Blumenkrantz [Wed, 23 Sep 2020 14:08:02 +0000 (10:08 -0400)]
zink: unset PIPE_CAP_DITHERING
there's no point in updating blend state for this when it does nothing,
so skip updates for this functionality
in the future, I expect zink will export this conditionally based on
the underlying driver, and some sort of functionality will be implemented
to do something
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17043>
Mike Blumenkrantz [Wed, 23 Sep 2020 14:06:53 +0000 (10:06 -0400)]
mesa/st: add PIPE_CAP_DITHERING
this is for drivers like zink that may or may not
handle dithering and so getting blend state changes
when this state changes isn't useful
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17043>
Martin Roukala (né Peres) [Thu, 16 Jun 2022 13:39:32 +0000 (16:39 +0300)]
radv/ci: test vkd3d on kabini
The machine is extremely slow and fails to finish vkcts, but vkd3d may
still be used as a way to detect extreme regressions.
Signed-off-by: Martin Roukala (né Peres) <martin.roukala@mupuf.org>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17081>
Martin Roukala (né Peres) [Sat, 18 Jun 2022 14:48:34 +0000 (17:48 +0300)]
Revert "ci/valve: uprev boot2container"
This reverts commit
48243965723e53f283d7c9fbfc801c1406795e31.
The newest version of b2c has changed the mount point of the cache
device, which is has proven to be working very well in my local
testing, but ends up confusing podman when the cache device had been
initialized using an older version of b2c. The end result is that we
end up using tmpfs to run our jobs, and some machines just run out of
RAM before the end of the job...
We'll be fixing this issue, cut a new b2c release, then re-introduce
in Mesa.
Signed-off-by: Martin Roukala (né Peres) <martin.roukala@mupuf.org>
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17120>
Jason Ekstrand [Wed, 15 Jun 2022 17:05:51 +0000 (12:05 -0500)]
anv: Properly clamp attachment layer counts
Vulkan requires that the acutal layer count come from
VkRenderingInfo::layerCount or VkFramebufferCreateInfo::layers rather
than from the image view itself.
Cc: mesa-stable@lists.freedesktop.org
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17060>
Chia-I Wu [Fri, 20 May 2022 23:49:42 +0000 (16:49 -0700)]
freedreno/fdl: use XYZW swap for PIPE_FORMAT_X24S8_UINT
We used to use WZYX and apply swizzles. Because swizzles apply for
border colors as well, the gallium driver un-swizzled the border colors
to cancel out swizzles. That did not work for turnip because turnip
advertises customBorderColorWithoutFormat and does not know when to
un-swizzle.
This change replaces WZYX by XYZW and removes the swizzles.
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/6516
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16647>
Icecream95 [Fri, 10 Jun 2022 11:03:33 +0000 (23:03 +1200)]
panfrost: Remove sync arguments from panfrost_batch_submit
Whether a sync object is used cannot depend on where the batch is
submitted from, remove the in_sync and out_sync fields from
panfrost_batch_submit.
Always use an output syncobj, this is required for glFinish to work
correctly. This could be skipped for batches which another batch
depends on, but because of the existence of empty batches which emit
no job, doing so is not trivial.
Never use an input syncobj. There appears to be no point to this, the
kernel driver does implicit sync anyway.
Fixes "seconds per frame" rendering with Neverball; previously, every
batch was submitted with out_sync=0, so DRI's frame throttling could
do nothing. New jobs would keep getting submitted until more than a
thousand were queued in the kernel, which increased rendering latency
for the compositor far beyond acceptable levels.
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16966>
Icecream95 [Fri, 10 Jun 2022 10:51:07 +0000 (22:51 +1200)]
panfrost: Use a macro for checking for a shared bind type
PAN_BIND_SHARED_MASK is all binding flags that mean that a resource
might be shared and accessible by other contexts.
Don't replace the usage of this pattern in panfrost_should_afbc and
panfrost_should_tile in case a new binding is introduced that not all
layouts can support.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16966>
Andres Calderon Jaramillo [Sat, 21 May 2022 23:27:34 +0000 (23:27 +0000)]
mesa/st: Account for YUV color space and range.
This patch plumbs the YUV color space and range provided through
EGL_EXT_image_dma_buf_import all the way to nir_lower_tex().
NIR already accounts for the YUV color space courtesy of commit
d8fdb8da. However, the color space was wired only for i965/i915 (see
6c11a799) and not for Gallium.
Tested-by: Andres Calderon Jaramillo <andrescj@chromium.org>
Reviewed-by: Rob Clark <robdclark@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16651>
Andres Calderon Jaramillo [Sat, 21 May 2022 23:25:02 +0000 (23:25 +0000)]
nir: Account for YUV range.
This patch expands on what commit
d8fdb8dab4658de2d255718627ee671e84fedf2d did. It adds support for
YUV-to-RGB conversions depending on the range of the YUV samples.
The conversion matrices and offsets are derived from
https://gist.github.com/yohhoy/
dafa5a47dade85d8b40625261af3776a.
Tested-by: Andres Calderon Jaramillo <andrescj@chromium.org>
Reviewed-by: Rob Clark <robdclark@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16651>
Ian Romanick [Tue, 14 Jun 2022 19:30:21 +0000 (12:30 -0700)]
intel/fs: Add missing synchronization for WaW dependency
v2: Do the synchronization in the correct place. Noticed by Curro.
Fixes:
b5fa43952aa ("intel/fs: Better handle constant sources of FS_OPCODE_PACK_HALF_2x16_SPLIT")
Reviewed-by: Francisco Jerez <currojerez@riseup.net>
Tested-by: Felix DeGrood <felix.j.degrood@intel.com> [v1]
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17037>
Rob Clark [Fri, 17 Jun 2022 13:13:41 +0000 (06:13 -0700)]
Revert "ci: freedreno farm is down"
They seem to be responding again.
This reverts commit
551442b53ebf531ab010dad2a3127ce41432ed4c.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17110>
Lionel Landwerlin [Fri, 10 Jun 2022 21:23:44 +0000 (00:23 +0300)]
intel/validator: validate dst/src types against devinfo support
v2: deal with src3_a1/src3_a16 instruction types (Curro)
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Francisco Jerez <currojerez@riseup.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16985>
Ken Johnson [Thu, 16 Jun 2022 02:29:19 +0000 (19:29 -0700)]
mesa/main: Correct alloca() use without #include "c99_alloca.h"
Fixes:
d231f955913e3265d9a560b45dba48ea6336ab90 ("mesa: add hw select name stack code path")
Reviewed-by: Jesse Natalie <jenatali@microsoft.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17073>
Roman Stratiienko [Thu, 16 Jun 2022 10:32:56 +0000 (13:32 +0300)]
Android.mk: Fix c11-related build failures
When building with Android.mk we are ending-up with:
gcc ..... -std=gnu99 .... -std=c11 .... target.o
^^^^^^^^^^ ^^^^^^^^
| |
_______________^_____ _____^___________
AOSP/KATI GENERATED MESON GENERATED
Some compilers uses first -std=gnu99 option and ignores second,
which results:
c99 implicit declaration of function static_assert()
This patch filters-out the first '-std=gnu99' from the cflags obtained
from AOSP/KATI dummy target output to avoid such kind of errors.
Signed-off-by: Roman Stratiienko <r.stratiienko@gmail.com>
Reviewed-by: Jesse Natalie <jenatali@microsoft.com>
Reviewed-by: Mauro Rossi <issor.oruam@gmail.com>
Acked-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17078>
Martin Roukala (né Peres) [Wed, 15 Jun 2022 10:04:11 +0000 (13:04 +0300)]
ci/valve: uprev boot2container
The latest version of the initramfs brings in the latest podman, but
most importantly brings in the usage of collapsed sections, thus
reducing the amount of scrolling up necessary when wanting to find out
the list of failures/flakes.
Signed-off-by: Martin Roukala (né Peres) <martin.roukala@mupuf.org>
Acked-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17051>
Daniel Stone [Fri, 17 Jun 2022 08:27:53 +0000 (09:27 +0100)]
ci: freedreno farm is down
Signed-off-by: Daniel Stone <daniels@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17104>
Mike Blumenkrantz [Tue, 14 Jun 2022 13:56:00 +0000 (09:56 -0400)]
zink: print runtime warning on missing EXT_border_color_swizzle
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17029>
Mike Blumenkrantz [Tue, 14 Jun 2022 13:55:25 +0000 (09:55 -0400)]
zink: use VK_EXT_border_color_swizzle
if borderColorSwizzleFromImage isn't supported, assume the border color
must be pre-swizzled
fixes #6651
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17029>
Mike Blumenkrantz [Tue, 14 Jun 2022 13:55:13 +0000 (09:55 -0400)]
zink: hook up VK_EXT_border_color_swizzle
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17029>
Mike Blumenkrantz [Thu, 16 Jun 2022 21:55:50 +0000 (17:55 -0400)]
zink: be a little selective about BAR fallback memory type
some resources MUST be host-visible, so use the appropriate heap for them
cc: mesa-stable
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17093>
Mike Blumenkrantz [Thu, 16 Jun 2022 16:06:51 +0000 (12:06 -0400)]
zink: move BAR allocation demotion up the stack
having this so far down in the BO allocation path meant that slabs were
getting demoted to device-local and then stored as BAR in the pb cache,
which broke the cache pretty badly
cc: mesa-stable
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17093>
Mike Blumenkrantz [Thu, 16 Jun 2022 15:06:53 +0000 (11:06 -0400)]
zink: store and reuse memory heap flags for buffer placement
the flags in vk_domain_from_heap() are the MINIMUM required flags for
the heap, but there may be other flags present, so ensure those are picked
up as expected
cc: mesa-stable
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17093>
Mike Blumenkrantz [Thu, 16 Jun 2022 18:33:46 +0000 (14:33 -0400)]
zink: fix buffer transfer flushes with offsets
the src and dst ofsets need to be adjusted by the base map offset
in order to flush the correct region
cc: mesa-stable
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17095>
Mike Blumenkrantz [Thu, 16 Jun 2022 18:56:32 +0000 (14:56 -0400)]
zink: use only the extents for buffer unmap flushes
flush_region is relative to the map, so passing in the offsets again
breaks the flush (if the flush hook is implemented correctly)
cc: mesa-stable
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17095>
Mike Blumenkrantz [Thu, 16 Jun 2022 18:32:46 +0000 (14:32 -0400)]
zink: unify actual map calls in buffer mapping
make this a bit easier to debug by moving the calls to one place
cc: mesa-stable
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17095>
Mike Blumenkrantz [Thu, 16 Jun 2022 17:46:56 +0000 (13:46 -0400)]
zink: rename a variable
make this a little clearer to read
cc: mesa-stable
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17095>
Yiwei Zhang [Tue, 7 Jun 2022 06:59:32 +0000 (06:59 +0000)]
venus: resolve YV12 AHB to VK_FORMAT_G8_B8_R8_3PLANE_420_UNORM
YV12 is a 3-plane format with minigbm. This change mitigates the crash
of testGLViewLargerHeightDecodeAccuracy[4], and successfully creates the
host side image and imports the memory.
vk_format(
1000156002) drm_fourcc(
842094169)
offsets(0, 27648, 34560, 0)
strides(256, 128, 128, 0)
modifier(0)
Signed-off-by: Yiwei Zhang <zzyiwei@chromium.org>
Reviewed-by: Ryan Neph <ryanneph@google.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16913>
Brian Paul [Tue, 14 Jun 2022 21:42:37 +0000 (15:42 -0600)]
gallivm: use enum types instead of unsigned in lp_bld_sample.[ch]
Signed-off-by: Brian Paul <brianp@vmware.com>
Acked-by: Dave Airlie <airlied@redhat.com>
Reviewed-by: Roland Scheidegger <sroland@vmware.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17064>
Brian Paul [Fri, 10 Jun 2022 17:40:28 +0000 (11:40 -0600)]
draw: asst. clean-up in draw_vbuf.h
Signed-off-by: Brian Paul <brianp@vmware.com>
Acked-by: Dave Airlie <airlied@redhat.com>
Reviewed-by: Roland Scheidegger <sroland@vmware.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17064>
Brian Paul [Fri, 10 Jun 2022 17:40:09 +0000 (11:40 -0600)]
draw: asst. clean-up in draw_pt_vsplit.c
Signed-off-by: Brian Paul <brianp@vmware.com>
Acked-by: Dave Airlie <airlied@redhat.com>
Reviewed-by: Roland Scheidegger <sroland@vmware.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17064>
Brian Paul [Fri, 10 Jun 2022 17:40:01 +0000 (11:40 -0600)]
draw: asst. clean-up in draw_pt_util.c
Signed-off-by: Brian Paul <brianp@vmware.com>
Acked-by: Dave Airlie <airlied@redhat.com>
Reviewed-by: Roland Scheidegger <sroland@vmware.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17064>
Brian Paul [Fri, 10 Jun 2022 17:39:48 +0000 (11:39 -0600)]
draw: asst. clean-up in draw_pt_fetch_shader_pipeline.c
Signed-off-by: Brian Paul <brianp@vmware.com>
Acked-by: Dave Airlie <airlied@redhat.com>
Reviewed-by: Roland Scheidegger <sroland@vmware.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17064>
Brian Paul [Fri, 10 Jun 2022 17:39:38 +0000 (11:39 -0600)]
draw: asst. clean-up in draw_pt_fetch_shader_emit.c
Signed-off-by: Brian Paul <brianp@vmware.com>
Acked-by: Dave Airlie <airlied@redhat.com>
Reviewed-by: Roland Scheidegger <sroland@vmware.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17064>
Brian Paul [Fri, 10 Jun 2022 17:39:19 +0000 (11:39 -0600)]
draw: asst. clean-up in draw_pt.c
Signed-off-by: Brian Paul <brianp@vmware.com>
Acked-by: Dave Airlie <airlied@redhat.com>
Reviewed-by: Roland Scheidegger <sroland@vmware.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17064>
Brian Paul [Fri, 10 Jun 2022 17:39:15 +0000 (11:39 -0600)]
draw: asst. clean-up in draw_pt.h
Signed-off-by: Brian Paul <brianp@vmware.com>
Acked-by: Dave Airlie <airlied@redhat.com>
Reviewed-by: Roland Scheidegger <sroland@vmware.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17064>
Brian Paul [Fri, 10 Jun 2022 17:39:07 +0000 (11:39 -0600)]
draw: asst. clean-up in draw_private.h
Signed-off-by: Brian Paul <brianp@vmware.com>
Acked-by: Dave Airlie <airlied@redhat.com>
Reviewed-by: Roland Scheidegger <sroland@vmware.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17064>
Brian Paul [Fri, 10 Jun 2022 17:38:54 +0000 (11:38 -0600)]
draw: asst. clean-up in draw_pipe_validate.c
Signed-off-by: Brian Paul <brianp@vmware.com>
Acked-by: Dave Airlie <airlied@redhat.com>
Reviewed-by: Roland Scheidegger <sroland@vmware.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17064>
Brian Paul [Fri, 10 Jun 2022 17:38:46 +0000 (11:38 -0600)]
draw: asst. clean-up in draw_pipe.c
Signed-off-by: Brian Paul <brianp@vmware.com>
Acked-by: Dave Airlie <airlied@redhat.com>
Reviewed-by: Roland Scheidegger <sroland@vmware.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17064>
Brian Paul [Fri, 10 Jun 2022 17:38:37 +0000 (11:38 -0600)]
draw: asst. clean-up in draw_gs.h
Signed-off-by: Brian Paul <brianp@vmware.com>
Acked-by: Dave Airlie <airlied@redhat.com>
Reviewed-by: Roland Scheidegger <sroland@vmware.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17064>
Brian Paul [Fri, 10 Jun 2022 17:38:24 +0000 (11:38 -0600)]
draw: asst. clean-up in draw_context.h
Signed-off-by: Brian Paul <brianp@vmware.com>
Acked-by: Dave Airlie <airlied@redhat.com>
Reviewed-by: Roland Scheidegger <sroland@vmware.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17064>
Brian Paul [Fri, 10 Jun 2022 17:12:16 +0000 (11:12 -0600)]
draw: s/unsigned/enum pipe_prim_type/
Signed-off-by: Brian Paul <brianp@vmware.com>
Acked-by: Dave Airlie <airlied@redhat.com>
Reviewed-by: Roland Scheidegger <sroland@vmware.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17064>
Brian Paul [Thu, 9 Jun 2022 17:59:42 +0000 (11:59 -0600)]
llvmpipe: asst. clean-ups in lp_state_fs.c
Signed-off-by: Brian Paul <brianp@vmware.com>
Acked-by: Dave Airlie <airlied@redhat.com>
Reviewed-by: Roland Scheidegger <sroland@vmware.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17064>
Brian Paul [Thu, 9 Jun 2022 17:44:03 +0000 (11:44 -0600)]
gallivm: asst. clean-ups in lp_bld_logic.
Signed-off-by: Brian Paul <brianp@vmware.com>
Acked-by: Dave Airlie <airlied@redhat.com>
Reviewed-by: Roland Scheidegger <sroland@vmware.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17064>
Brian Paul [Thu, 9 Jun 2022 17:32:35 +0000 (11:32 -0600)]
llvmpipe: s/unsigned/enum pipe_compare_func/
Signed-off-by: Brian Paul <brianp@vmware.com>
Acked-by: Dave Airlie <airlied@redhat.com>
Reviewed-by: Roland Scheidegger <sroland@vmware.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17064>
Brian Paul [Thu, 9 Jun 2022 17:18:02 +0000 (11:18 -0600)]
llvmpipe: use enum blend types instead of unsigned
Signed-off-by: Brian Paul <brianp@vmware.com>
Acked-by: Dave Airlie <airlied@redhat.com>
Reviewed-by: Roland Scheidegger <sroland@vmware.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17064>
Brian Paul [Thu, 9 Jun 2022 17:11:15 +0000 (11:11 -0600)]
llvmpipe: minor clean-up in lp_state_blend.c
Signed-off-by: Brian Paul <brianp@vmware.com>
Acked-by: Dave Airlie <airlied@redhat.com>
Reviewed-by: Roland Scheidegger <sroland@vmware.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17064>
Dylan Baker [Thu, 16 Jun 2022 17:02:35 +0000 (10:02 -0700)]
docs: Extend calendar entries for 22.1 by 3 releases.
This gives us a last release of the 22.1 series lining up with 22.2.1,
assuming that the 22.1.0 is on time.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17090>
Dylan Baker [Thu, 16 Jun 2022 17:02:04 +0000 (10:02 -0700)]
docs: Add calendar entries for 22.2 release candidates.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17090>
Dylan Baker [Thu, 16 Jun 2022 17:01:20 +0000 (10:01 -0700)]
docs: drop 22.1.4 calendar entry.
We're done with the 22.1 series, so lets not have it on the calendar
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17090>
Mike Blumenkrantz [Thu, 9 Jun 2022 15:21:05 +0000 (11:21 -0400)]
kmsro: add error message on drm ioctl failure
Reviewed-by: Adam Jackson <ajax@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16949>
Mike Blumenkrantz [Thu, 9 Jun 2022 15:03:13 +0000 (11:03 -0400)]
drisw: probe kms if fd is passed
Reviewed-by: Adam Jackson <ajax@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16949>
Jesse Natalie [Thu, 16 Jun 2022 19:18:42 +0000 (12:18 -0700)]
dzn: Skip another test that times out occasionally
Reviewed-by: Yonggang Luo <luoyonggang@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17089>
Dave Airlie [Wed, 15 Jun 2022 06:26:18 +0000 (16:26 +1000)]
llvmpipe: disable alpha test branch if multisample is enabled.
If multisample is enabled and alpha testing happens, the
branch can jump out of the fragment shader before the other
samples are generated. Just don't take the branch optimisation
post alpha test if multisample is enabled.
This should fix some rendering bugs in kicad with multisample
enabled.
Cc: mesa-stable
Reviewed-by: Roland Scheidegger <sroland@vmware.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17049>
Mike Blumenkrantz [Thu, 16 Jun 2022 19:15:54 +0000 (15:15 -0400)]
zink: radv baseline updates
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17088>
Yonggang Luo [Wed, 15 Jun 2022 15:25:23 +0000 (23:25 +0800)]
docs: Update windows build requirement with Visual Studio
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Reviewed-by: Jesse Natalie <jenatali@microsoft.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17044>
Yonggang Luo [Fri, 10 Jun 2022 06:04:33 +0000 (14:04 +0800)]
ci/vs2019: Upgrade Windows 10 SDK version to 20348
This comes with stdalign.h for more C11 conformance
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Reviewed-by: Jesse Natalie <jenatali@microsoft.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17044>
Yonggang Luo [Wed, 15 Jun 2022 17:42:49 +0000 (01:42 +0800)]
meson/clover: Getting clover can be built with no-rtti llvm in mingw
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Acked-by: Dylan Baker <dylan@pnwbakers.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17055>
Yonggang Luo [Thu, 19 May 2022 10:27:44 +0000 (18:27 +0800)]
meson/rtti: Using get_argument_syntax to check msvc compatible compiler
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Acked-by: Dylan Baker <dylan@pnwbakers.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17055>
Yonggang Luo [Thu, 21 Apr 2022 06:06:17 +0000 (14:06 +0800)]
meson: Use cc.get_argument_syntax instead cc.get_id when possible.
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Reviewed-by: Dylan Baker <dylan@pnwbakers.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17065>
Yonggang Luo [Thu, 21 Apr 2022 17:09:19 +0000 (01:09 +0800)]
meson: Using get_argument_syntax as the `--compiler_id` option for gen_vs_module_defs.py
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Reviewed-by: Dylan Baker <dylan@pnwbakers.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17065>
Jesse Natalie [Thu, 16 Jun 2022 18:21:54 +0000 (11:21 -0700)]
CI: Lima farm is offline
Acked-by: Alyssa Rosenzweig <alyssa@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17087>
David Heidelberg [Thu, 16 Jun 2022 14:43:15 +0000 (16:43 +0200)]
ci/iris: disable Blender Diorama trace (incompatible with perf. traces)
Sadly, Blender Diorama trace causes crash for our performance tracing as we
use it right now.
Let's disable it for now, until we figure out what's wrong.
Reported in: https://gitlab.freedesktop.org/mesa/mesa/-/issues/6676
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17083>
Yiwei Zhang [Wed, 25 May 2022 07:13:13 +0000 (07:13 +0000)]
venus: add fence feedback
- intercept to record feedback cmds for:
- vkQueueSubmit
- add feedback code path for
- vkGetFenceStatus
- vkResetFences
- VN_PERF_NO_FENCE_FEEDBACK can disable fence feedback
Test: dEQP-VK.synchronization.basic.fence.*
Test: dEQP-VK.wsi.android.swapchain.render.basic*
Test: dEQP-VK.api.object_management.*
Test: dEQP-VK.api.external.fence.sync_fd.*
Signed-off-by: Yiwei Zhang <zzyiwei@chromium.org>
Reviewed-by: Ryan Neph <ryanneph@google.com>
Reviewed-by: Chad Versace <chadversary@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16731>
Yiwei Zhang [Tue, 31 May 2022 23:26:07 +0000 (23:26 +0000)]
venus: renderer to store allow_vk_wait_syncs capset
Signed-off-by: Yiwei Zhang <zzyiwei@chromium.org>
Reviewed-by: Ryan Neph <ryanneph@google.com>
Reviewed-by: Chad Versace <chadversary@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16731>
Yiwei Zhang [Wed, 25 May 2022 22:51:59 +0000 (22:51 +0000)]
venus: create per queue family command pool for feedback cmd
Signed-off-by: Yiwei Zhang <zzyiwei@chromium.org>
Reviewed-by: Ryan Neph <ryanneph@google.com>
Reviewed-by: Chad Versace <chadversary@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16731>
Yiwei Zhang [Tue, 24 May 2022 05:25:03 +0000 (05:25 +0000)]
venus: add NO_FENCE_FEEDBACK perf option and disable sparse resource
Signed-off-by: Yiwei Zhang <zzyiwei@chromium.org>
Reviewed-by: Ryan Neph <ryanneph@google.com>
Reviewed-by: Chad Versace <chadversary@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16731>
Yiwei Zhang [Tue, 24 May 2022 16:31:20 +0000 (16:31 +0000)]
venus: add event feedback
- add perf option VN_PERF_NO_EVENT_FEEDBACK
- intercept to record feedback cmds for:
- vkCmdSetEvent
- vkCmdResetEvent
- add feedback code path for
- vkGetEventStatus
- vkSetEvent
- vkResetEvent
Test: dEQP-VK.synchronization.basic.event.*
Test: dEQP-VK.api.command_buffers.record_simul*
Signed-off-by: Yiwei Zhang <zzyiwei@chromium.org>
Reviewed-by: Ryan Neph <ryanneph@google.com>
Reviewed-by: Chad Versace <chadversary@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16731>
Yiwei Zhang [Mon, 23 May 2022 20:46:34 +0000 (20:46 +0000)]
venus: add feedback check/set/reset helpers
Implemented:
- vn_feedback_get_status
- vn_feedback_reset_status
- vn_feedback_set_status
- vn_feedback_get_counter
- vn_feedback_set_counter
Signed-off-by: Yiwei Zhang <zzyiwei@chromium.org>
Reviewed-by: Ryan Neph <ryanneph@google.com>
Reviewed-by: Chad Versace <chadversary@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16731>
Yiwei Zhang [Fri, 20 May 2022 06:38:09 +0000 (06:38 +0000)]
venus: add vn_feedback_pool backed by coherent buffer (part 2)
Implemented:
- vn_feedback_pool_alloc
- vn_feedback_pool_free
Signed-off-by: Yiwei Zhang <zzyiwei@chromium.org>
Reviewed-by: Ryan Neph <ryanneph@google.com>
Reviewed-by: Chad Versace <chadversary@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16731>
Yiwei Zhang [Thu, 19 May 2022 06:36:03 +0000 (06:36 +0000)]
venus: add vn_feedback_pool backed by coherent buffer (part 1)
Implemented:
- vn_feedback_pool_init
- vn_feedback_pool_fini
Signed-off-by: Yiwei Zhang <zzyiwei@chromium.org>
Reviewed-by: Ryan Neph <ryanneph@google.com>
Reviewed-by: Chad Versace <chadversary@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16731>
Yiwei Zhang [Thu, 19 May 2022 22:23:32 +0000 (22:23 +0000)]
venus: let device track queue families used for device creation
Signed-off-by: Yiwei Zhang <zzyiwei@chromium.org>
Reviewed-by: Ryan Neph <ryanneph@google.com>
Reviewed-by: Chad Versace <chadversary@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16731>
Yiwei Zhang [Thu, 19 May 2022 21:54:42 +0000 (21:54 +0000)]
venus: adjust device resources init order
queue init involves fence creation, and we need to do that at the last
to prepare for other resource creation dependencies involved in fence
creation.
Signed-off-by: Yiwei Zhang <zzyiwei@chromium.org>
Reviewed-by: Ryan Neph <ryanneph@google.com>
Reviewed-by: Chad Versace <chadversary@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16731>
Yiwei Zhang [Thu, 19 May 2022 20:56:08 +0000 (20:56 +0000)]
venus: fix a missing mtx_destroy in vn_device_init
This was introduced in commit
e08960482, however, the logic around has
been largly refactored since then. It's not worth adding the fixes tag.
Signed-off-by: Yiwei Zhang <zzyiwei@chromium.org>
Reviewed-by: Chad Versace <chadversary@chromium.org>
Reviewed-by: Ryan Neph <ryanneph@google.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16731>
Yiwei Zhang [Fri, 20 May 2022 20:47:32 +0000 (20:47 +0000)]
venus: fix the queue init failure path
The prior behavior can ignore certain failure result, and might also
clean up queues that are never initialized.
Fixes:
ddd75330559 ("venus: initial support for queue/fence/semaphore")
Signed-off-by: Yiwei Zhang <zzyiwei@chromium.org>
Reviewed-by: Chad Versace <chadversary@chromium.org>
Reviewed-by: Ryan Neph <ryanneph@google.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16731>
Yiwei Zhang [Sat, 21 May 2022 22:28:54 +0000 (22:28 +0000)]
venus: fix a bug on buffer cache init failure path
The failure path was never hit though, and will not either.
Fixes:
65abd1d4aed ("venus: implement vn_buffer_cache_entries_create")
Signed-off-by: Yiwei Zhang <zzyiwei@chromium.org>
Reviewed-by: Chad Versace <chadversary@chromium.org>
Reviewed-by: Ryan Neph <ryanneph@google.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16731>
Dylan Baker [Thu, 16 Jun 2022 16:56:33 +0000 (09:56 -0700)]
docs: update calendar and link releases notes for 22.1.2
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17086>
Dylan Baker [Thu, 16 Jun 2022 16:55:22 +0000 (09:55 -0700)]
docs: add sha256sum to 22.1.2 notes
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17086>
Dylan Baker [Thu, 16 Jun 2022 16:17:14 +0000 (09:17 -0700)]
docs: add release notes for 22.1.2
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17086>
Samuel Pitoiset [Tue, 14 Jun 2022 08:30:54 +0000 (10:30 +0200)]
radv: advertise VK_EXT_border_color_swizzle on GFX10+
On GFX9 and older, the driver needs to swizzle itself it seems.
Exposing it on GFX10+, allows us to test it with Zink, at least.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Acked-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17057>
Mike Blumenkrantz [Thu, 16 Jun 2022 12:58:01 +0000 (08:58 -0400)]
zink: tu ci baseline update
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17080>
Iván Briano [Tue, 14 Jun 2022 19:57:20 +0000 (12:57 -0700)]
anv: do not get rid of empty/useless fragment shaders
This was an optimization done a while ago that doesn't seem to be having
much of an impact anymore, and on the other hand, causes all sorts of
breakage with queries, as many of our HW counters don't get incremented
when rasterization is disabled.
This fixes a bunch of issues Zink has with ANV, but more importantly, it
fixes upcoming CTS tests:
dEQP-VK.transform_feedback.primitives_generated_query.*.empty_frag.*
dEQP-VK.transform_feedback.primitives_generated_query.*.no_attachment.*
dEQP-VK.transform_feedback.primitives_generated_query.*.color_write_disable_*
Cc: mesa-stable
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Jason Ekstrand <jason.ekstrand@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17038>
Danylo Piliaiev [Wed, 15 Jun 2022 14:35:39 +0000 (17:35 +0300)]
turnip: copy disasm strings for pipeline executables
A single compiled_shaders instance could be reused by several
pipelines, but strings from disasm info could be stolen only once.
So now we have to copy them.
Fixes crashes when using RenderDoc.
Fixes:
05329d7f9acabbc9306c9538a30b502d4c580d38
("tu: Implement pipeline caching with shared Vulkan cache")
Signed-off-by: Danylo Piliaiev <dpiliaiev@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17053>
Samuel Pitoiset [Wed, 8 Jun 2022 10:59:38 +0000 (12:59 +0200)]
radv/ci: add vkd3d-proton testing
The vkd3d-proton can be very useful, I recently found issues while
implementing VK_EXT_primitives_generated_query and
VK_KHR_fragment_shader_barycentric.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Martin Roukala <martin.roukala@mupuf.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17050>
Samuel Pitoiset [Thu, 9 Jun 2022 10:05:07 +0000 (12:05 +0200)]
ci: add VKD3D_PROTON_RESULTS to the list of variables to pass down for testing
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Martin Roukala <martin.roukala@mupuf.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17050>
Samuel Pitoiset [Thu, 9 Jun 2022 11:37:43 +0000 (13:37 +0200)]
ci: print a message when vk3d-proton returns successfully
To detect if an error occured.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Martin Roukala <martin.roukala@mupuf.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17050>
Samuel Pitoiset [Thu, 9 Jun 2022 11:37:33 +0000 (13:37 +0200)]
ci: update vkd3d-proton builder/runner
Do not need to cross compile just for running the testsuite. Only
RADV will make use of it anyways.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Martin Roukala <martin.roukala@mupuf.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17050>
Samuel Pitoiset [Tue, 14 Jun 2022 06:39:11 +0000 (08:39 +0200)]
radv/ci: refactor test machines and dEQP rules to reduce copy&paste config
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Martin Roukala <martin.roukala@mupuf.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17050>
Ruijing Dong [Sat, 11 Jun 2022 00:21:58 +0000 (20:21 -0400)]
radeonsi/vcn: support unified queue in vcn4
- use unified queue only in vcn4
- implement signature and engine-info ib headers
in vcn4
- implemented unified queue functions
Reviewed-by: Boyuan Zhang <Boyuan.Zhang@amd.com>
Reviewed-by: Mihai Preda <mhpreda@gmail.com>
Signed-off-by: Ruijing Dong <ruijing.dong@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16911>
Ruijing Dong [Sat, 11 Jun 2022 00:16:14 +0000 (20:16 -0400)]
radeonsi/vcn: prepare for unified queue in vcn4
- apply unified queue ib headers to vcn4
- re-use encoding queue as unified queue
- define unified queue functions and structures
Reviewed-by: Boyuan Zhang <Boyuan.Zhang@amd.com>
Reviewed-by: Mihai Preda <mhpreda@gmail.com>
Signed-off-by: Ruijing Dong <ruijing.dong@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16911>
Mark Janes [Mon, 16 May 2022 20:03:25 +0000 (13:03 -0700)]
iris: provide a callback to INTEL_MEASURE to clean up snapshots
Snapshots are processed asynchronously by INTEL_MEASURE, but snapshot
memory is allocated and associated with an iris batch. Provide a
callback that will free snapshot memory after a batch is fully
processed.
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16571>
Mark Janes [Mon, 16 May 2022 19:56:08 +0000 (12:56 -0700)]
intel: provide a callback to clean up after intel_measure_gather
The caller may have passed ownership of intel_measure_batch structures
to intel_measure until they are ready to be gathered. The caller
needs a notification when rendering is complete and snapshots have
been processed, so it can free the resources that measure the batch.
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16571>
Mark Janes [Mon, 16 May 2022 19:52:42 +0000 (12:52 -0700)]
anv: fix performance bug in INTEL_MEASURE
Re-allocating the buffer object for snapshots carries a heavy penalty
at run-time. When resetting a command buffer, the buffer object that
is allocated for snapshots may be re-used directly on subsequent
renders.
Stale snapshot data will persist in the buffer object. To verify that
rendering is complete, zero the final timestamp value and check that
it has been written before gathering data.
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16571>
Mark Janes [Wed, 18 May 2022 18:58:43 +0000 (11:58 -0700)]
intel: relax assertion in INTEL_MEASURE
It is possible that a secondary command buffer was submitted with no
renders in it. For that case, no timestamp will be collected. Only
verify that timestamps if the index is nonzero.
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16571>
Mark Janes [Tue, 24 May 2022 19:16:27 +0000 (12:16 -0700)]
intel: parse intel_measure environment without side effects
If an application links agaist both iris and anv, they will clash when
parsing the INTEL_MEASURE environment variable.
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16571>
Jan Beich [Sat, 11 Jun 2022 06:05:17 +0000 (06:05 +0000)]
vulkan/wsi: treat EBADF as missing DMA_BUF_IOCTL_{EXPORT,IMPORT}_SYNC_FILE
FreeBSD supports DMA-BUF but not DMA_BUF_IOCTL_SYNC and similar yet.
As it returns EBADF instead of ENOTTY all consumers fail due to
VK_ERROR_OUT_OF_HOST_MEMORY.
Fixes:
30b57f10b36d ("vulkan/wsi: Signal semaphores and fences from the dma-buf")
Reviewed-by: Jason Ekstrand <jason.ekstrand@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17070>
Mike Blumenkrantz [Wed, 15 Jun 2022 21:09:03 +0000 (17:09 -0400)]
zink: only enable vtn debugging if validation is active
this is otherwise incredibly cumbersome and eats up minutes in ci
Acked-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17069>
Mike Blumenkrantz [Fri, 10 Jun 2022 19:33:56 +0000 (15:33 -0400)]
zink: always bind on the sparse queue
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17066>