Stefan Schmidt [Thu, 26 Nov 2015 16:27:01 +0000 (17:27 +0100)]
rg_etc: use void to force empty function parameters
We have to use void in a function declaration if we want no function
parameters. Using just empty parenthesis means the function takes an
unspecified number of parameters.
We had it correct for most declarations and this series fixes it for
the rest.
Stefan Schmidt [Thu, 26 Nov 2015 16:26:36 +0000 (17:26 +0100)]
evas software_x11: use void to force empty function parameters
We have to use void in a function declaration if we want no function
parameters. Using just empty parenthesis means the function takes an
unspecified number of parameters.
We had it correct for most declarations and this series fixes it for
the rest.
Stefan Schmidt [Thu, 26 Nov 2015 16:26:07 +0000 (17:26 +0100)]
evas gl_common: use void to force empty function parameters
We have to use void in a function declaration if we want no function
parameters. Using just empty parenthesis means the function takes an
unspecified number of parameters.
We had it correct for most declarations and this series fixes it for
the rest.
Stefan Schmidt [Thu, 26 Nov 2015 16:25:36 +0000 (17:25 +0100)]
evas_common3d: use void to force empty function parameters
We have to use void in a function declaration if we want no function
parameters. Using just empty parenthesis means the function takes an
unspecified number of parameters.
We had it correct for most declarations and this series fixes it for
the rest.
Stefan Schmidt [Thu, 26 Nov 2015 16:25:06 +0000 (17:25 +0100)]
eolian: use void to force empty function parameters
We have to use void in a function declaration if we want no function
parameters. Using just empty parenthesis means the function takes an
unspecified number of parameters.
We had it correct for most declarations and this series fixes it for
the rest.
Stefan Schmidt [Thu, 26 Nov 2015 16:24:37 +0000 (17:24 +0100)]
ector: use void to force empty function parameters
We have to use void in a function declaration if we want no function
parameters. Using just empty parenthesis means the function takes an
unspecified number of parameters.
We had it correct for most declarations and this series fixes it for
the rest.
Stefan Schmidt [Thu, 26 Nov 2015 16:23:47 +0000 (17:23 +0100)]
evas_cserve2: use void to force empty function parameters
We have to use void in a function declaration if we want no function
parameters. Using just empty parenthesis means the function takes an
unspecified number of parameters.
We had it correct for most declarations and this series fixes it for
the rest.
Stefan Schmidt [Thu, 26 Nov 2015 16:20:14 +0000 (17:20 +0100)]
edje_decc: use void to force empty function parameters
We have to use void in a function declaration if we want no function
parameters. Using just empty parenthesis means the function takes an
unspecified number of parameters.
We had it correct for most declarations and this series fixes it for
the rest.
Youngbok Shin [Thu, 26 Nov 2015 08:16:13 +0000 (10:16 +0200)]
evas: Add ExtraLight, ExtraBold for font weight.
Summary:
Evas supports UltraLight, UltraBold as font weight.
These terms have same weight value as ExtraLight, ExtraBold.
Some applications, for example, fontforge, use ExtraLight, ExtraBold terms for these weight values.
So, it would be better to support these terms, too.
@feature
Test Plan: None
Reviewers: tasn, woohyun, herdsman
Reviewed By: herdsman
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D3126
Thiep Ha [Thu, 26 Nov 2015 07:52:48 +0000 (09:52 +0200)]
edje entry: return correct selection
Summary:
In entry, when selection_get function is called, selection is not
always returned the current selection.
Scenario:
- In select mode, entry has selection (e.g, by double click).
- When selection handler is moved, set the cursor the current coordinate
with edje_object_part_text_cursor_pos_set() API.
- Edje emits "selection,changed" signal.
- Elementary gets current selection and stores it.
- Elementary does not get selection as visual selection (e.g, text is
highlighted with "entry test", but the selection returned
from edje is "entry").
- If we copy and then paste to the entry, the pasted text is not same as
selected text.
Reason:
- In _edje_entry_cursor_coord_set function, if entry has selection, we only
emit "selection,changed" signal without freeing en->selection.
- When _edje_entry_selection_get is called, we check the en->selection,
since it is existed, we just return it which is not updated one.
This patch clears en->selection, so that it is updated at _selection_get,
and the updated selection is returned to caller.
@fix
Test Plan:
In mobile profile, open entry
- Right click, choose select, double click -> selection handlers are shown.
- Drag selection handlers to change selection.
- Right click, do copy.
- Right click, do paste.
- See the pasted text is not same as selection.
Reviewers: raster, tasn, herdsman
Subscribers: seoz, JackDanielZ, cedric
Differential Revision: https://phab.enlightenment.org/D2746
Stefan Schmidt [Wed, 25 Nov 2015 15:46:04 +0000 (16:46 +0100)]
build: rename Eolian helper cmake file to mark it as input
Align it with the rest of our cmake support files. Adding it to configure as
well so the cmake file gets generate from the cmake.in
Without this I had distcheck failing with a missing target for it.
Marcel Hollerbach [Wed, 25 Nov 2015 15:10:27 +0000 (16:10 +0100)]
cmake: Include module per default
if someone uses eolian its likly that he wants to install some rules
Marcel Hollerbach [Wed, 25 Nov 2015 11:22:59 +0000 (12:22 +0100)]
cmake: Add a helper script which defines generator rules for eo files
eo_rule_create adds rules to generate to .eo.x .eo.h .eot.h files.
It also monitors its deps.
@feature
Marcel Hollerbach [Sat, 21 Nov 2015 14:17:47 +0000 (15:17 +0100)]
efreet_icon: Fix wrong inherit selection
Summary:
The list of elem->paths is given with the actual icon at position 0 and
the bigger the index is the lower the icon in the inherit structure is.
Due to the for loop beginning at 0 walking to the end this
direction is flipped. So the last r is returned, which is the lowest
icon in the inherit structure.
This is fixed by returning if the first valid path is found.
@fix
Test Plan: run jesus or efm with a custom icon theme beore the wrong icons are taken, now the correct ones are taken
Reviewers: raster, cedric
Subscribers: DaveMDS
Differential Revision: https://phab.enlightenment.org/D3366
Jean-Philippe Andre [Wed, 25 Nov 2015 06:42:29 +0000 (15:42 +0900)]
Evas: Temporarily hack OT_SUPPORT to fix textgrid
See T2865.
Since Harfbuzz 1.1.0, terminology displays fonts funnily aligned to
the top. This is apparently because until 1.0.6 the y_offset was
always 0 for all glyphs, but since 1.1.1 the offset is actually
set.
This is a TEMPORARY fix. There might be an underlying issue left
here.
Harfbuzz changed behaviour in this commit:
commit
44f82750807475aa5b16099ccccd917d488df703
Author: Behdad Esfahbod <behdad@behdad.org>
Date: Wed Nov 4 20:40:05 2015 -0800
[ft] Remove font funcs that do nothing
Subhransu Mohanty [Thu, 29 Oct 2015 08:20:09 +0000 (17:20 +0900)]
ector: cleanup freetype raster
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Subhransu Mohanty [Wed, 18 Nov 2015 05:45:16 +0000 (14:45 +0900)]
ector: support fill rule for shape object.
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Subhransu Mohanty [Wed, 18 Nov 2015 05:25:09 +0000 (14:25 +0900)]
efl: added fill_rule property in efl_gfx_shape class
Open question, should fill rule be part of the public data ? Let's
say no for now.
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Subhransu Mohanty [Wed, 18 Nov 2015 02:13:00 +0000 (11:13 +0900)]
efl: make path stroke related api as non virtual.
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Cedric BAIL [Tue, 24 Nov 2015 22:57:58 +0000 (14:57 -0800)]
efl: quick code cleanup.
Subhransu Mohanty [Thu, 29 Oct 2015 07:59:51 +0000 (16:59 +0900)]
ector: updated the freetype raster with faster line renderer.
Merged from freetype repo with 'smooth', faster, alternative line renderer.
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Subhransu Mohanty [Wed, 21 Oct 2015 07:00:28 +0000 (16:00 +0900)]
ector: fix the rounding issue when applying transformation to shape data in freetype backend.
@fix
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Cedric BAIL [Tue, 24 Nov 2015 22:33:20 +0000 (14:33 -0800)]
evas: avoid double eet_close call while caching GL shader.
Cedric BAIL [Tue, 24 Nov 2015 22:27:13 +0000 (14:27 -0800)]
eet: improve error message during eet_close.
Daniel Hirt [Thu, 19 Nov 2015 14:25:04 +0000 (16:25 +0200)]
Edje: Add example for hyphenation style
A small example how hyphenation is set as a style in TEXTBLOCK parts.
Daniel Hirt [Thu, 12 Nov 2015 07:49:08 +0000 (09:49 +0200)]
Evas textblock: add hyphenation tests
Daniel Hirt [Tue, 13 Oct 2015 07:59:19 +0000 (10:59 +0300)]
Evas textblock: add support for hyphenation wrap style
We now support hyphenation in style. Use "wrap=hyphenation" to use this
wrap option. It will hyphenate based on explicit SOFT HYPHEN (­)
placement in the text, and with the (optional) assistance of dictionaries
compatible with Hunspell's "hyphen" library.
This wrap mode favors breaking at hyphen positions in a word, over moving
the whole word to the next line. It will put an additional "-" at the
break position if it was hyphened.
Enabling the hyphen dictionaries is done by adding these configure
options:
--enable-hyphen (requires Hunspell's "hyphen" library installed)
--with-dictionaries-hyphen-dir=DIR (specifies the install location of
the actual .dic dictionary files e.g. /usr/share/hyphen)
Note that dictionary files are expected to be in the form of "en_US.dic"
or anything that ends with it e.g. "hyph_en_US.dic" (this how they are
named in Arch Linux).
@feature
Daniel Hirt [Sat, 21 Nov 2015 10:39:00 +0000 (12:39 +0200)]
Eina unicode: add eina_unicode_unicode_to_utf8_range
Required some special treatment to get words (substring) out of an
input Unicode string to a utf8 one. This saves the trouble converting
the whole string: you input an offset in the Eina_Unicode array, and
provide the required length. That's is, now you can extract words and
whatnot in utf8 form.
To save code I wrapped the original one to get the whole length.
Anand [Tue, 24 Nov 2015 08:50:09 +0000 (17:50 +0900)]
eina: Applied NULL check
Summary:
In _eina_list_setup_accounting function
{
...
...
if (!list->accounting)
goto on_error;
...
...
on_error:
_eina_list_mempool_list_free(list);
}
_eina_list_mempool_list_free function deference the "list->accounting"
variable which is already NULL.
Reviewers: JackDanielZ, jpeg
Reviewed By: jpeg
Subscribers: cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D3376
Deepjyoti Dutta [Tue, 24 Nov 2015 08:03:58 +0000 (17:03 +0900)]
Evas 3d: Initialized local variables
Summary:
The OpenGL functions assigns a value to the local variable. However,
in case of error it would take the uninitialized garbage value. So, the
correct solution would be to initialize it to 0.
Signed-off-by: Deepjyoti Dutta <deepjyoti.d@samsung.com>
Reviewers: Hermet, singh.amitesh, raster, jpeg
Reviewed By: jpeg
Subscribers: yashu21985, mvsovani, alok25, sachin.dev, cedric
Differential Revision: https://phab.enlightenment.org/D3375
Vincent Torri [Tue, 24 Nov 2015 06:27:30 +0000 (07:27 +0100)]
autotools: detect IPV6 support on Windows
The detection in configure.ac includes netinet/in.h, for linux, but this header
file does not exist on Windows. So guard this header.
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Cedric BAIL [Mon, 23 Nov 2015 19:57:28 +0000 (11:57 -0800)]
eina: simplify tests logic for base64.
Cedric BAIL [Mon, 23 Nov 2015 19:57:04 +0000 (11:57 -0800)]
eina: always terminate the string with a '\0'.
Yeshwanth Reddivari [Mon, 23 Nov 2015 12:04:15 +0000 (21:04 +0900)]
Eina Example: Fix memory leak of variable buf
Summary: Fix memory leak of buf in eina_test_simple_xml_parser.c as reported by static analysis tool, Cppcheck.
Reviewers: singh.amitesh, Hermet, jpeg
Reviewed By: jpeg
Subscribers: alok25, mvsovani, sachin.dev, cedric
Differential Revision: https://phab.enlightenment.org/D3371
Minwoo, Lee [Mon, 23 Nov 2015 11:53:29 +0000 (20:53 +0900)]
evas: Fix text effect which has shadow direction
Summary:
If text object has outline and shadow effect (OUTLINE_SHADOW or OUTLINE_SOFT_SHADOW), and has shadow direction except BOTTOM_RIGHT then outline is not displayed.
So fix logic of style checking.
OUTLINE_SOFT_SHADOW effect of text object is different with text block, so fix it.
Test Plan: Make text obect with OUTLINE_SHADOW or OUTLINE_SOFT_SHADOW effect with any direction except BOTTOM_RIGHT
Reviewers: cedric, woohyun, herdsman, tasn
Subscribers: id213sin
Differential Revision: https://phab.enlightenment.org/D3047
Srivardhan Hebbar [Mon, 23 Nov 2015 11:44:27 +0000 (20:44 +0900)]
evas_fb: Handling memory leak on realloc failure.
Summary:
I thought its better to fail and return null if realloc fails than to
continue. So returning by closing all openend file.
Signed-off-by: Srivardhan Hebbar <sri.hebbar@samsung.com>
Reviewers: cedric, illogict
Differential Revision: https://phab.enlightenment.org/D3232
Jean-Philippe Andre [Mon, 23 Nov 2015 10:44:04 +0000 (19:44 +0900)]
Evas 3d: Remove left over debug message from recent commit
Jean-Philippe Andre [Mon, 23 Nov 2015 10:40:59 +0000 (19:40 +0900)]
Edje edit: Free textblock styles with the proper function
Yeshwanth Reddivari [Mon, 23 Nov 2015 09:51:08 +0000 (18:51 +0900)]
Edje: Remove duplicate NULL reassignment
Summary:
Remove duplicate code of variable 's' assignment to NULL in edje_edit_style_del.
Signed-off-by: Yeshwanth Reddivari <r.yeshwanth@samsung.com>
Reviewers: Hermet, alok25, mvsovani, singh.amitesh, jpeg
Reviewed By: jpeg
Subscribers: sachin.dev, cedric
Differential Revision: https://phab.enlightenment.org/D3358
Vivek Ellur [Mon, 23 Nov 2015 08:35:07 +0000 (17:35 +0900)]
eet: Fix warning in eet file
Summary:
variable 'total' is of unsigned long long but %lli was used to print..so fixed
warning
Signed-off-by: Vivek Ellur <vivek.ellur@samsung.com>
Reviewers: cedric, jpeg
Reviewed By: jpeg
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D3325
perepelits.m [Mon, 23 Nov 2015 07:28:24 +0000 (08:28 +0100)]
evas: fix PLY loader and saver.
Summary:
Use less memory by indexation vertices and not keeping more than one copy of it (from task T2713).
[Fix]
Reviewers: cedric, raster, Hermet
Subscribers: artem.popov
Differential Revision: https://phab.enlightenment.org/D3355
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Oleksandr Shcherbina [Mon, 23 Nov 2015 07:19:49 +0000 (08:19 +0100)]
evas: remove useless part of code in evas_convex_hull_get function
Summary:
@fix
CID: 1339788
Reviewers: raster, cedric
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D3350
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Oleksandr Shcherbina [Mon, 23 Nov 2015 07:18:51 +0000 (08:18 +0100)]
evas: fix uninitialize variable in convex_hull_vertex_set function
Summary:
A bit of useless claim, becouse parameter coord always have value 0 or 1 or 2.
May be for escape problem in future.
@fix
CID: 1339781
Reviewers: raster, cedric
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D3349
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Oleksandr Shcherbina [Mon, 23 Nov 2015 07:15:41 +0000 (08:15 +0100)]
evas: fix possible accsess to NULL pointer in Evas.Canvas3d.
Summary:
@fix
CID:1339784
Reviewers: raster, cedric
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D3348
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Oleksandr Shcherbina [Mon, 23 Nov 2015 07:11:27 +0000 (08:11 +0100)]
evas: fix unreachable code in _generate_unic_color_key function in Evas.Canvas3D.
Summary:
Have a sence. It is hard to assume that more that 16 million color will be used.
@fix
CID: 1339790
Reviewers: raster, cedric
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D3347
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Vivek Ellur [Fri, 20 Nov 2015 04:52:56 +0000 (05:52 +0100)]
evil: fix uninitialize warning
Summary:
@Fix
Signed-off-by: Vivek Ellur <vivek.ellur@samsung.com>
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D3324
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Vivek Ellur [Fri, 20 Nov 2015 02:01:54 +0000 (03:01 +0100)]
eet: remove useless assignment in eet cipher and silence warning.
Summary:
Signed-off-by: Vivek Ellur <vivek.ellur@samsung.com>
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D3310
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Srivardhan Hebbar [Fri, 20 Nov 2015 01:45:39 +0000 (02:45 +0100)]
eina: example for base64 encoding.
Summary:
Depends on D3228
Signed-off-by: Srivardhan Hebbar <sri.hebbar@samsung.com>
Reviewers: cedric
Differential Revision: https://phab.enlightenment.org/D3230
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Srivardhan Hebbar [Fri, 20 Nov 2015 01:44:07 +0000 (02:44 +0100)]
eina: test case for base64 encoding function.
Summary: Signed-off-by: Srivardhan Hebbar <sri.hebbar@samsung.com>
Reviewers: cedric
Differential Revision: https://phab.enlightenment.org/D3229
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Subhransu Mohanty [Tue, 10 Nov 2015 04:22:19 +0000 (13:22 +0900)]
eina: added bounds_get api to Eina_Bezier
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Chidambar Zinnoury [Fri, 20 Nov 2015 16:46:38 +0000 (17:46 +0100)]
ecore con: Fix UDP sockets.
The client structure holds a file descriptor, which is not initialized (which means 0) in case of UDP as there is no client-specific socket.
However, we check for the file descriptor being positive before closing it in the client destructor, which means that we actually end up closing the 0 file descriptor.
That means that things were going crazy with real strange things happening afterwards…
Jean-Philippe Andre [Fri, 20 Nov 2015 05:23:29 +0000 (14:23 +0900)]
Evas render: Fix another map clip render issue
This time it's only about performance. We seem to be setting the
changed flag too often, which might trigger unnecessary redraws.
- map flag is set if there is currently a map AND it's not an image
object (because images can map themselves)
- hmap flag is set if there was a map before
So, map != hmap does not imply a transition between a mapped and
non-mapped state. Add an extra check before marking the clip
as dirty and changed.
Jean-Philippe Andre [Fri, 20 Nov 2015 03:07:01 +0000 (12:07 +0900)]
Ector: Simplify confusing code
The base class data was already stored, no need to figure it out again
Andy Williams [Thu, 19 Nov 2015 22:59:09 +0000 (22:59 +0000)]
[eolian_gen] remove documentation for removed argument.
Used to be mandatory, is now not recognised, let's not confuse people @fix
Daniel Kolesa [Thu, 19 Nov 2015 15:28:48 +0000 (15:28 +0000)]
eolian: more relaxed safety in types API
This changes the checks in eolian type API so that you can use the various
type funcs on incompatible types, getting a NULL in return; this allows
simplified generator logic, with error handling done on generator side,
without getting annoying messages from the Eolian lib.
Daniel Kolesa [Thu, 19 Nov 2015 14:04:37 +0000 (14:04 +0000)]
eolian: turn "undefined type" into its own EOLIAN_TYPE
Cedric BAIL [Tue, 17 Nov 2015 00:20:22 +0000 (01:20 +0100)]
ector: don't use parent relationship to get access to the surface for freetype backend.
Cedric BAIL [Sun, 15 Nov 2015 23:56:28 +0000 (00:56 +0100)]
ector: don't use eo parent relationship for accessing the surface.
Cedric BAIL [Sun, 15 Nov 2015 21:57:48 +0000 (22:57 +0100)]
ector: starting decoralating surface and parent by adding a property to access the surface independently.
NOTE: It would be nice to be able to protect independently the setter from the getter in eolian.
Cedric BAIL [Thu, 19 Nov 2015 12:15:51 +0000 (13:15 +0100)]
ector: improve uploading of GL texture for vector graphism
This rely on a faster code path to upload dynamic texture. Once we get support
for gbm, we should see significant performance improvement in speed, but this
first step is already a 5 times improvement (Ok, we get from really bad, to not
really useful...).
Daniel Kolesa [Thu, 19 Nov 2015 13:19:22 +0000 (13:19 +0000)]
elua: add eolian_type_aliased_base_get to lua bindings
Youngbok Shin [Thu, 19 Nov 2015 11:37:07 +0000 (11:37 +0000)]
Evas object: Add paragraph_direciton APIs
Summary:
It adds evas_object_paragraph_direction_set, get APIs.
The APIs set or get paragraph direction to/from the given object.
It changes BiDi calculations and affect the direction and aligning of text.
It doesn't have any effect to text without Fribidi library.
The default paragraph direction is EVAS_BIDI_DIRECTION_INHERIT.
If dir is EVAS_BIDI_DIRECTION_INHERIT, paragraph direction is changed
according to smart parent object. If there is no smart parent object,
paragraph direction works as EVAS_BIDI_DIRECTION_NEUTRAL.
@feature
Test Plan:
Test cases included to the following files.
- evas_test_textblock.c
- evas_test_text.c
- evas_test_object_smart.c
Run "make check".
Reviewers: woohyun, raster, herdsman, tasn
Subscribers: c, raster, cedric
Differential Revision: https://phab.enlightenment.org/D1690
Jean-Philippe Andre [Thu, 19 Nov 2015 07:10:41 +0000 (16:10 +0900)]
Efl: eo-ify enum Efl.Gfx.Fill
Jee-Yong Um [Thu, 19 Nov 2015 06:33:45 +0000 (15:33 +0900)]
edje: revise the explanation for mask_flags attribute
Reviewers: cedric, raster
Reviewed By: raster
Subscribers: raster
Differential Revision: https://phab.enlightenment.org/D3330
Chris Michael [Wed, 18 Nov 2015 17:56:12 +0000 (12:56 -0500)]
ecore-wayland: Reduce overhead for maximize/fullscreen set functions
This patch just gets the state flags directly from the window rather
than calling "get" functions to return the same parameter.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Wed, 18 Nov 2015 17:54:00 +0000 (12:54 -0500)]
ecore-wayland: Fix iconified functions for consistency
* sanitize bool params
* enforce window state flag setting
* correctly detect window state using window flag
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Wed, 18 Nov 2015 17:19:17 +0000 (12:19 -0500)]
ecore-wayland: Add EINA_SAFETY checks to window functions
This adds EINA_SAFETY returns for all public facing ecore_wl_window
functions.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Daniel Kolesa [Wed, 18 Nov 2015 16:02:15 +0000 (16:02 +0000)]
eolian: add eolian_type_aliased_base_get
This adds a new API function that is there mainly for convenience (see doc).
Also added/updated tests as necessary.
@feature
Daniel Kolesa [Wed, 18 Nov 2015 12:40:33 +0000 (12:40 +0000)]
gitignore: ignore core dumps
Tom Hacohen [Wed, 18 Nov 2015 10:56:48 +0000 (10:56 +0000)]
Evas text: Fix last up to pos error return value.
This commit also simplifies the code a (tiny) bit.
This fixes the bug introduced in:
392df9479f816a641fabbf333326bdab4b9cfc28
Tom Hacohen [Wed, 18 Nov 2015 10:53:29 +0000 (10:53 +0000)]
Evas text: Remove useless FIXME.
Subodh Kumar [Wed, 18 Nov 2015 10:52:34 +0000 (10:52 +0000)]
Evas text: Fix memory leak
Summary:
Fix memory leak
Position is getting returned without
freeing the temporary logical item list.
@fix
Test Plan: NA
Reviewers: tasn, raster
Reviewed By: raster
Subscribers: raster, cedric
Differential Revision: https://phab.enlightenment.org/D3345
Tom Hacohen [Wed, 18 Nov 2015 10:11:55 +0000 (10:11 +0000)]
Eet: remove dead variable assignment.
I guess this is what
2a01c4517b5b97c2b988ce590d7dae913ec1f085 was meant to be doing.
Stefan Schmidt [Wed, 18 Nov 2015 09:26:25 +0000 (10:26 +0100)]
Revert "eet: removing useless assignment variables."
This reverts commit
2a01c4517b5b97c2b988ce590d7dae913ec1f085.
Declaring these variable void breaks the build with disabled crypto.
Fixes T2855
Jean-Philippe Andre [Wed, 18 Nov 2015 03:06:00 +0000 (12:06 +0900)]
Edje data: Remove redondant array in Evas 3D edd
Since I just broke EDJ ABI, as well clean it up. The same array
was saved twice under two different names.
Jean-Philippe Andre [Wed, 18 Nov 2015 02:17:27 +0000 (11:17 +0900)]
Edje: Fix Evas 3D eet data descriptors
Memleak found with valgrind points to this line, where clearly the
edd field name is incorrect. It looks like this feature has no example,
no test case either.
This breaks EDJ ABI!
I do this because I believe there are zero users of this API
at this point, as Evas 3D is still not ready yet.
See also https://phab.enlightenment.org/D2544
@fix
Jean-Philippe Andre [Wed, 18 Nov 2015 02:32:37 +0000 (11:32 +0900)]
Edje data: Fix memory leak in nested data descriptors
sunghyun kim [Tue, 17 Nov 2015 09:36:31 +0000 (18:36 +0900)]
Evas GL: XFreeColormap when window free
When gl window is created, XCreateColormap is called in eng_best_visual_get
but when gl window is freed, Colormap is not freed.
See original patch: D3342.
Mike Blumenkrantz [Tue, 17 Nov 2015 23:24:09 +0000 (18:24 -0500)]
ecore-wayland: rewrite maximize/fullscreen set functions for consistency
* use safety macros for win struct param (should be the case for all fns here)
* sanitize bool params
* enforce window state flag setting
* correctly detect window state using window flag instead of type
@fix
ref T2841
Mike Blumenkrantz [Tue, 17 Nov 2015 23:23:07 +0000 (18:23 -0500)]
ecore-wayland: return only the relevant state value for maximize/fullscreen
having window types for fullscreen/maximize is not defined by spec and leads
to state mismatches when toggling from api vs receiving events from the compositor
@fix
Mike Blumenkrantz [Tue, 17 Nov 2015 23:21:11 +0000 (18:21 -0500)]
ecore-evas wayland: enforce frame/state change triggering before move/resize
if a state change occurs on the ee, related callbacks must be run prior to
performing any resizes in order to ensure that the correct csd sizes are
calculated
@fix
ref T2841
Chris Michael [Tue, 17 Nov 2015 21:07:14 +0000 (16:07 -0500)]
evas-gl_drm: Remove set but unused variable
Variable 'osurface' is not actually being used inside the code here,
so remove it.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Tue, 17 Nov 2015 20:57:45 +0000 (15:57 -0500)]
ecore-wayland: Make ecore_wl_window_maximized_get return proper values
This brings ecore_wl_window_maximized_get more inline with
ecore_wl_fullscreen_get function in that it will now check either the
window maximized state, or the window type, to determine if a window
is actually maximized
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Tue, 17 Nov 2015 20:55:41 +0000 (15:55 -0500)]
ecore-evas-drm: Send fake mouse_move event after registering
This fixes an issue where ecore_drm was sending an initial mouse_move
event too early in the startup process. Instead, we will send the
event from Ecore_Evas after it has been registered with Ecore_Input.
This is done here to address and Fix T2854.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Tue, 17 Nov 2015 20:54:34 +0000 (15:54 -0500)]
ecore-drm: Don't send mouse_move event too early
We cannot be sending an ecore_event for mouse move here as it is too
early in the startup process for that too happen. Raising the event
here never gets caught because the ecore_evas has not yet registered
for ecore_input listening.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Tue, 17 Nov 2015 18:51:19 +0000 (13:51 -0500)]
ecore-evas-wl: Fix issue of improper window geometry
This fixes an issue where maximizing a window would set improper xdg
surface window geometry. We receive window configure sizes based on
xdg surface window geometry, so we need to subtract framespace there
or else window size grows when maximizing/unmaximizing multiple times.
This also adjusts the call to xdg_surface_set_window_geometry to
account for framespace (Fixes T2842).
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Tue, 17 Nov 2015 15:06:55 +0000 (10:06 -0500)]
ector: Fix incorrect expression
Coverity reports that 'obj' is written twice with the same value
here., so fix this with a proper call to eo_do_super_ret
NB: Fixes Coverity CID1339786
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Tue, 17 Nov 2015 15:00:19 +0000 (10:00 -0500)]
evas-software-x11: Fix resource leak
If we end up leaving evas_xlib_image_dri_native_set due to a failure
to allocate memory, we should free the previously allocated
Evas_DRI_Image so that we don't leak
NB: Fixes Coverity CID1339782
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Daniel Hirt [Sun, 8 Nov 2015 12:24:34 +0000 (14:24 +0200)]
Evas textblock: fix bad deletion in test case
No need to delete this object. It is already being deleted when the
textblock is freed at the end of the test.
Daniel Hirt [Sun, 15 Nov 2015 09:31:32 +0000 (11:31 +0200)]
Evas language: add full locale language getter
evas_common_language_from_locale_get truncates the country letters in
the language. We don't always want that (one example is dictionaries).
Chris Michael [Tue, 17 Nov 2015 14:07:45 +0000 (09:07 -0500)]
evas-software-x11: Fix returning NULL pointer
evas_xlib_image_dri_native_set should be returning a pointer to an
RGBA_Image on success, or NULL on failure. Returning EINA_FALSE here
leads to an expression which evaluates to zero being treated as a null
pointer constant
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Tue, 17 Nov 2015 14:06:51 +0000 (09:06 -0500)]
evas-software-x11: Fix formatting
NB: No functional changes
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Tue, 17 Nov 2015 14:03:53 +0000 (09:03 -0500)]
evas-gl: Remove extra parentheses
clang warns of equality comparison with extraneous parentheses in
these cases. Remove the extra parens as they are not needed anyway
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Tue, 17 Nov 2015 13:58:58 +0000 (08:58 -0500)]
ector: Add missing EINA_UNUSED for unused function parameter
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Tom Hacohen [Tue, 17 Nov 2015 12:07:39 +0000 (12:07 +0000)]
Evas language: Fix language from locale function.
This function was trying to infer from the LANG env var, though it should
have just queried the locale all along, as the language we want is the
system's text language, and not necessarily the LANG variable's value.
@fix.
Subodh Kumar [Tue, 17 Nov 2015 11:24:39 +0000 (11:24 +0000)]
Evas text: Remove fixme marker
Summary:
Remove fixme marker
Algorithm used is good enough to sort
very few number of items, usually 2 to 6
items.
Test Plan: NA
Reviewers: herdsman, cedric, tasn
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D3312
Subodh Kumar [Tue, 17 Nov 2015 11:22:17 +0000 (11:22 +0000)]
Evas text: Remove tabs for readability
Summary: Remove tabs
Test Plan: NA
Reviewers: tasn
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D3337
Cedric BAIL [Tue, 17 Nov 2015 09:32:25 +0000 (10:32 +0100)]
ector: disable NEON build.
There is more problem with this code, better disable it for now.
@fix
T2851
Jean-Philippe Andre [Tue, 17 Nov 2015 08:57:18 +0000 (17:57 +0900)]
Evas GL: Remove invalid call inside make current pbuffer
There was some confusion as color_buf is a texture but it was used
as an fbo. Not sure was this call was for.
@fix
Jean-Philippe Andre [Tue, 17 Nov 2015 08:34:23 +0000 (17:34 +0900)]
Evas GL: Ignore compilation warning
Desktop OpenGL doesn't care about the version here (GLES 2 or 3)