platform/upstream/VK-GL-CTS.git
7 years agoCP: Non-compressed copy image target size (64,64,8
Kalle Raita [Wed, 7 Dec 2016 17:41:41 +0000 (09:41 -0800)]
CP: Non-compressed copy image target size (64,64,8

Cherry-pick commit 8076c97ac0fc706288ef266b0cbe748012c4e0c4 from master:

Non-compressed copy image tests target size reduced to (64,64,8). The
compressed cases retain old size of (128,128,16) to ensure coverage of
all block size combinations.

Bug: 33965234
Test: Run tests on N6 and N9 on L MR 1 with known failures
Change-Id: If22e8722c1de58aa239cf6fe29e79d3bdd13c589

7 years agoMerge "Remove tests affected by NV/OES_viewport_array extension" into nougat-cts-dev
Tina Zhou [Fri, 20 Jan 2017 18:28:49 +0000 (18:28 +0000)]
Merge "Remove tests affected by NV/OES_viewport_array extension" into nougat-cts-dev

7 years agoMerge "Generate flat triangles in polygon offset tests." into nougat-cts-dev
Tina Zhou [Fri, 20 Jan 2017 18:28:42 +0000 (18:28 +0000)]
Merge "Generate flat triangles in polygon offset tests." into nougat-cts-dev

7 years agoMerge "Relax line width verification in primitive bbox tests" into nougat-cts-dev
Tina Zhou [Fri, 20 Jan 2017 18:28:34 +0000 (18:28 +0000)]
Merge "Relax line width verification in primitive bbox tests" into nougat-cts-dev

7 years agoMerge "Fix eglBindAPI negative test" into nougat-cts-dev
Tina Zhou [Fri, 20 Jan 2017 18:28:26 +0000 (18:28 +0000)]
Merge "Fix eglBindAPI negative test" into nougat-cts-dev

7 years agoMerge "Drop incorrect framebuffer texture subtests." into nougat-cts-dev
Tina Zhou [Fri, 20 Jan 2017 18:28:18 +0000 (18:28 +0000)]
Merge "Drop incorrect framebuffer texture subtests." into nougat-cts-dev

7 years agoMerge "Optimize swapchain OOM tests" into nougat-cts-dev
Tina Zhou [Fri, 20 Jan 2017 18:27:50 +0000 (18:27 +0000)]
Merge "Optimize swapchain OOM tests" into nougat-cts-dev

7 years agoMerge "Fix internal format/type for ES3 3D + depth/stencil negative API tests." into...
Tina Zhou [Fri, 20 Jan 2017 18:27:40 +0000 (18:27 +0000)]
Merge "Fix internal format/type for ES3 3D + depth/stencil negative API tests." into nougat-cts-dev

7 years agoMerge "Add support for EGL_EXT_pixel_format_float" into nougat-cts-dev
Tina Zhou [Fri, 20 Jan 2017 18:27:14 +0000 (18:27 +0000)]
Merge "Add support for EGL_EXT_pixel_format_float" into nougat-cts-dev

7 years agoRemove tests affected by NV/OES_viewport_array extension
Pyry Haulos [Wed, 18 Jan 2017 20:28:32 +0000 (12:28 -0800)]
Remove tests affected by NV/OES_viewport_array extension

Tests were not properly taking into account viewport clamping behavior
introduced by GL_NV/OES_viewport_array extensions.

Bug: 34349411
Change-Id: I3eae36359e6408191e0fbefb20cededec2a5bd39
Merged-In: I3d3c2e32d7dd96d1db960aa53dc18cc690187ec0

7 years agoGenerate flat triangles in polygon offset tests.
Alexander Galazin [Wed, 11 Jan 2017 07:50:13 +0000 (08:50 +0100)]
Generate flat triangles in polygon offset tests.

The tests setup triangles with a depth slope and then call
glPolygonOffset(factor, units) with variable units and
always 0 slope scaled factor.

According to the GLES 3.2 spec 13.7.2 Depth Offset:
"void PolygonOffset( float factor, float units );
factor scales the maximum depth slope of the polygon, and units scales an
implementation-dependent constant that relates to the usable resolution of the
depth buffer."

If the polygon has a depth slope,
the depth slope factor has to be not equal to zero.
The rationale of the slope scaled factor is to ensure that the offset
(equation 13.11) is greater than max(dz/dx, dz/dy) for all resolutions,
which may not be the case for the constant offset since it doesn't take
the screen resolution into account.

Changed tests:

dEQP-GLES2.functional.polygon_offset.*_displacement_with_units
dEQP-GLES3.functional.polygon_offset.*_displacement_with_units

Bug: 34386628

Change-Id: Ie8009ba1766eb50c3c5a750122aa8bb231144210

7 years agoDrop incorrect framebuffer texture subtests.
Kenneth Graunke [Fri, 6 Jan 2017 08:25:28 +0000 (00:25 -0800)]
Drop incorrect framebuffer texture subtests.

This patch removes two broken subcases of:
dEQP-GLES31.functional.debug.negative_coverage.log.buffer.framebuffer_texture_layer

These were fixed in dEQP master by commit f28187809176f5eeb1ee25ccfa70d3,
but we cannot backport that to release branches because it changes the
existing expectations, which would break previously passing
implementations.  See buganizer 30287182 and 28090252.

The first subtest incorrectly checked layer (array slice) when it should
have checked miplevel.  The subtest description says:

"GL_INVALID_VALUE is generated if texture is a 2D multisample array
 texture and layer not 0."

which is wrong - array textures can certainly have multiple slices.
The ES 3.1 specification says that:

"An INVALID_VALUE error is generated if texture is not zero and level is
 not a supported texture level for texture, as described above."

and miplevel 0 is the only valid miplevel for a multisample texture.

The second subtest is no longer valid according to the resolution of
https://cvs.khronos.org/bugzilla/show_bug.cgi?id=15968.

Bug: 34281627
Merged-In: I500074c1777d88291c0b395498bb0f7d5613d27d

7 years agoRelax line width verification in primitive bbox tests
Pyry Haulos [Tue, 15 Nov 2016 18:28:48 +0000 (10:28 -0800)]
Relax line width verification in primitive bbox tests

Originally contributed by ARM to Khronos OpenGL ES CTS. Cherry-picked
with permission.

Google bug: 22713865
Khronos OpenGL issue: #19

Change-Id: I95359847611144e179819aaab6ac5dfe4bf4e4da

7 years agoOptimize swapchain OOM tests
Pyry Haulos [Wed, 4 Jan 2017 22:30:07 +0000 (14:30 -0800)]
Optimize swapchain OOM tests

Swapchain OOM tests were hitting timeouts on some platforms. This commit
optimizes the tests in two ways:

 * VkInstance, VkDevice, and VkSurface are now re-used across all
sub-cases.

 * Loop is re-written to avoid re-creating swapchains for parameters
0..N-1 when testing parameter combination N.

Affects: dEQP-VK.wsi.*.swapchain.simulate_oom.*

Bug: 33555898
(cherry picked from commit 2beac9057d9113ac306632d819ded852691a6842)

Change-Id: I19e9c7c8012a82cd12322a733afab961f4c7a1ae

7 years agoFix internal format/type for ES3 3D + depth/stencil negative API tests.
Kenneth Graunke [Mon, 12 Sep 2016 19:37:08 +0000 (12:37 -0700)]
Fix internal format/type for ES3 3D + depth/stencil negative API tests.

This is a port of commit ae7f8e0a07730e693b24d3dc7a23d2372319145e from
the ES 3.1 tests to the ES 3.0 tests.

According to the ES 3.2 specification:

   "Textures with a base internal format of DEPTH_COMPONENT, DEPTH_STENCIL
    or STENCIL_INDEX are supported by texture image specification commands
    only if target is TEXTURE_2D, TEXTURE_2D_MULTISAMPLE, TEXTURE_2D_ARRAY,
    TEXTURE_2D_MULTISAMPLE_ARRAY, TEXTURE_CUBE_MAP or TEXTURE_CUBE_MAP_ARRAY.
    Using these formats in conjunction with any other target will result in
    an INVALID_OPERATION error."

This subtest tried to check the above error condition, but it specified
GL_DEPTH_STENCIL / GL_DEPTH_COMPONENT as format, rather than internalFormat.
Since the above text calls out "base internal format", we should specify
it as internalFormat.

We also change GL_DEPTH_STENCIL to use GL_UNSIGNED_INT_24_8 rather than
GL_UNSIGNED_BYTE, as that combination was illegal for a different reason
than the one the test intended to check.

Affects dEQP-GLES3.functional.negative_api.texture.teximage3d.

Bug: 34103293

Change-Id: Ie01e2d130bb1cadc821153487e3e41593e3ca15e

7 years agoFix eglBindAPI negative test
Nicolas Boichat [Sun, 18 Dec 2016 16:13:28 +0000 (00:13 +0800)]
Fix eglBindAPI negative test

It is ok for an implementation to not fail eglBindAPI if the current
display does not support the specified client API. However, in that
case, getConfig must not return any configuration for that specific
API.

Bug: 33278378
Affects: dEQP-EGL.functional.negative_api.bind_api
Test: Deploy to elm Chromebook, run with Cherry, test passes.
Change-Id: Idb86971de7a30e1aa78bb0951f971ed2829e2794

7 years agoAdd support for EGL_EXT_pixel_format_float
Mark Adams [Wed, 14 Dec 2016 22:02:52 +0000 (17:02 -0500)]
Add support for EGL_EXT_pixel_format_float

This updates the egl.xml version and identifies/skips the float configs

Bug: 32969314
Change-Id: Iacfdf6b1c32c86ea0e6f80ca7ebaaeef583d1135
Merged-In: Iadeb0d4a76a06b2be716f3e76a1cc9fb69aff16a

7 years agoDO NOT MERGE: Remove changed texel buffer access tests from mustpass
Pyry Haulos [Wed, 4 Jan 2017 16:20:43 +0000 (08:20 -0800)]
DO NOT MERGE: Remove changed texel buffer access tests from mustpass

NYC CTS bug-fix changes the SPIR-V for these tests causing drivers that
passed old CTS fail the new version.

Bug: 33041922
Change-Id: I7e23a700693d5e6ee7c4264e05d449f49f820516

7 years agoDO NOT MERGE: Remove a few changed Vulkan tests from mustpass
Pyry Haulos [Wed, 4 Jan 2017 00:45:19 +0000 (16:45 -0800)]
DO NOT MERGE: Remove a few changed Vulkan tests from mustpass

Original NYC CTS was decorating struct member locations differently and
this was later fixed causing drivers that pass original NYC CTS fail.

Bug: 34060750
Bug: 33041922
Change-Id: I3fe33960a74fb8f568aa7e1327bc09de8bc3df41

7 years agoMerge "Blacklist match_different_[member_]struct_names SSO validation tests." into...
Tina Zhou [Wed, 21 Dec 2016 22:32:08 +0000 (22:32 +0000)]
Merge "Blacklist match_different_[member_]struct_names SSO validation tests." into nougat-cts-dev

7 years agoMerge "Change GL_MAX_TESS_CONTROL_TOTAL_OUTPUT_COMPONENTS minmax to 2048" into nougat...
Tina Zhou [Wed, 21 Dec 2016 22:31:04 +0000 (22:31 +0000)]
Merge "Change GL_MAX_TESS_CONTROL_TOTAL_OUTPUT_COMPONENTS minmax to 2048" into nougat-cts-dev

7 years agoMerge changes I7c2ffd66,Ib53b245d,I4862cca3 into nougat-cts-dev
Tina Zhou [Wed, 21 Dec 2016 22:30:03 +0000 (22:30 +0000)]
Merge changes I7c2ffd66,Ib53b245d,I4862cca3 into nougat-cts-dev

* changes:
  Update glslang to d02dc5d
  Cherry-pick SPIR-V ClipDistance validation fixes
  Cherry-pick dEQP-VK.pipeline.cache fixes to nougat-cts-dev

7 years agoGetDevices: Also allow `\.` to be part of the host name
Nicolas Boichat [Tue, 20 Dec 2016 18:55:24 +0000 (18:55 +0000)]
GetDevices: Also allow `\.` to be part of the host name
am: dbf9715509

Change-Id: I659ce579867c7ca0c9b47e3b53a734265e0fbb26

7 years agoBlacklist match_different_[member_]struct_names SSO validation tests.
Kenneth Graunke [Thu, 8 Dec 2016 22:09:31 +0000 (14:09 -0800)]
Blacklist match_different_[member_]struct_names SSO validation tests.

This patch blacklists the following tests:

- dEQP-GLES31.functional.separate_shader.validation.varying.match_different_struct_names
- dEQP-GLES31.functional.separate_shader.validation.io_blocks.match_different_member_struct_names

The resolution of Khronos bug #15866 is that the spec should be changed
to require that "structures have the same name" in order for the types
to match during SSO validation.  These structures differ in name,
so they should not match, and we should get an SSO validation failure.

See https://cvs.khronos.org/bugzilla/show_bug.cgi?id=15866 and Khronos
legacy CTS commit 1607a3ce7caa5736471fb460d08130e62d689351.

Bug: 33457655

7 years agoGetDevices: Also allow `\.` to be part of the host name
Nicolas Boichat [Wed, 30 Nov 2016 04:14:52 +0000 (12:14 +0800)]
GetDevices: Also allow `\.` to be part of the host name

Useful when connecting over TCP to a device with a given IP.

Change-Id: Ibe3b75e5ba3ab0ff90219bb31d45e21d8f5fd61b

7 years agoUpdate glslang to d02dc5d
Pyry Haulos [Tue, 29 Nov 2016 23:24:17 +0000 (15:24 -0800)]
Update glslang to d02dc5d

Bug: 33041922

(cherry picked from commit 4e1f56d2457e0c8736e3e92c48bd8df0c309d600)

Change-Id: I7c2ffd66f55cafa402ffc7a0222973e282f4825f

7 years agoCherry-pick SPIR-V ClipDistance validation fixes
Pyry Haulos [Wed, 23 Nov 2016 00:13:32 +0000 (16:13 -0800)]
Cherry-pick SPIR-V ClipDistance validation fixes

These fixes are needed in order for SPIR-V validation to pass when
shaders are compiled with a newer glslang version.

Bug: 33041922

Explicitly declare gl_PerVertex block

This fixes SPIR-V validation error in shaders generated from GLSL (not ES)
due to missing ClipDistance capability.

(cherry picked from commit 0a6fe1448b303a6a4e4ab48712eaf1c0b16d75b1)

Explicitly declare gl_PerVertex in push constant tests

(cherry picked from commit cba5d02d184b771bc4a21b8aecbbde3377d86167)

Change tes/geom shaders in timestamp tests use 310 es

Vertex and fragment shaders were already using that GLSL version.

(cherry picked from commit d47309690aa9b2e685b267ea6395e88b32c855a8)

Change ubo and ssbo tests to use 310 es shaders

(cherry picked from commit 4d36051923691c5f92cf3615e82d30d54ed3b09b)

Explicitly declare gl_PerVertex in dynamic viewport state tests

(cherry picked from commit 816c46d518d08a4ff321ca93780f2786fa86ba60)

Explicitly declare gl_PerVertex in occlusion query tests

(cherry picked from commit a1257f69aa6008d4e5a22148a43d59692eb24822)

Change-Id: Ib53b245d25c6cbc345a88e8b247f01ac7cf8a541

7 years agoCherry-pick dEQP-VK.pipeline.cache fixes to nougat-cts-dev
Pyry Haulos [Mon, 21 Nov 2016 23:54:55 +0000 (15:54 -0800)]
Cherry-pick dEQP-VK.pipeline.cache fixes to nougat-cts-dev

Bug: 33041922

Validation fixes in dEQP-VK.pipeline

- Corrected out of range minDepthBounds value
- Added missing image layout transitions
- timestamp, cache tests: pass data through geometry shader
- cache test: use correct initialLayout in attachment when starting
  a second render pass

(cherry picked from commit 1d3585c5ec71cf90d6519913db6a01ef2c0f840c)

Fix use of out-of-scope struct in pipeline cache tests

Fixes #363

(cherry picked from commit 1ec71c633e5755a1932c1da7692aef69b66999db)

Pipeline cache test: fix SPIRV validation error

(cherry picked from commit 89cce75bae9beb123311281386fb59b8da59052b)

Change-Id: I4862cca352955c33d04540f2f881760f4e4ffd65

7 years agoChange GL_MAX_TESS_CONTROL_TOTAL_OUTPUT_COMPONENTS minmax to 2048
Pyry Haulos [Tue, 15 Nov 2016 18:34:57 +0000 (10:34 -0800)]
Change GL_MAX_TESS_CONTROL_TOTAL_OUTPUT_COMPONENTS minmax to 2048

Google bug: 33105204
Khronos bug: 12823

(cherry picked from commit fe6bb67987a4d7fc59739c878e658f2a6d071cde)

Change-Id: I56fcc4ce527c31e48004c43e43e2ec994675e1b4

7 years agoMerge "Fix sample_mask_in.bit_count_per_two_samples tests for 2x MSAA." into marshmal...
Tina Zhou [Thu, 17 Nov 2016 17:10:28 +0000 (17:10 +0000)]
Merge "Fix sample_mask_in.bit_count_per_two_samples tests for 2x MSAA." into marshmallow-cts-dev
am: a5af1b076f

Change-Id: I01c65d693d7ad5befe9244cb0d24814750a80bd2

7 years agoFix sample_mask_in.bit_count_per_two_samples tests for 2x MSAA.
Kenneth Graunke [Thu, 17 Nov 2016 17:10:28 +0000 (17:10 +0000)]
Fix sample_mask_in.bit_count_per_two_samples tests for 2x MSAA.
am: ea5589c748

Change-Id: I7358276f100608371da5b44ebc8e102a54706197

7 years agoMerge "Fix internal format/type for 3D + depth/stencil negative API tests." into...
Tina Zhou [Thu, 17 Nov 2016 17:10:12 +0000 (17:10 +0000)]
Merge "Fix internal format/type for 3D + depth/stencil negative API tests." into marshmallow-cts-dev
am: d962b86909

Change-Id: I6a82d71f2fed9f848a953ae21c30079bacb07052

7 years agoFix internal format/type for 3D + depth/stencil negative API tests.
Kenneth Graunke [Thu, 17 Nov 2016 17:10:05 +0000 (17:10 +0000)]
Fix internal format/type for 3D + depth/stencil negative API tests.
am: d2f3b468db

Change-Id: Id43b369d67e04cf3a6d6b5b4e3303f02c7a35b87

7 years agoMerge "Fix sample_mask_in.bit_count_per_two_samples tests for 2x MSAA." into marshmal...
Tina Zhou [Thu, 17 Nov 2016 17:03:36 +0000 (17:03 +0000)]
Merge "Fix sample_mask_in.bit_count_per_two_samples tests for 2x MSAA." into marshmallow-cts-dev

7 years agoMerge "Fix internal format/type for 3D + depth/stencil negative API tests." into...
Tina Zhou [Thu, 17 Nov 2016 17:02:44 +0000 (17:02 +0000)]
Merge "Fix internal format/type for 3D + depth/stencil negative API tests." into marshmallow-cts-dev

7 years agoMerge "Add the support to device connection via TCP/IP" into marshmallow-cts-dev
Tina Zhou [Thu, 17 Nov 2016 00:43:40 +0000 (00:43 +0000)]
Merge "Add the support to device connection via TCP/IP" into marshmallow-cts-dev
am: 6cea9dbc62

Change-Id: I3525d88dbc3e04b702cef54d1759f406222047b2

7 years agoAdd the support to device connection via TCP/IP
Chun-Ta Lin [Thu, 17 Nov 2016 00:43:39 +0000 (00:43 +0000)]
Add the support to device connection via TCP/IP
am: 4ccc9fd56c

Change-Id: I16ab5038ff64448458aaafc7bda43128e0941e4e

7 years agoMerge "Add the support to device connection via TCP/IP" into marshmallow-cts-dev
Tina Zhou [Thu, 17 Nov 2016 00:38:13 +0000 (00:38 +0000)]
Merge "Add the support to device connection via TCP/IP" into marshmallow-cts-dev

7 years agoAdd runtime to CtsDeqpTestCases
Aaron Holden [Tue, 15 Nov 2016 01:47:00 +0000 (17:47 -0800)]
Add runtime to CtsDeqpTestCases

Test: cts-tradefed run cts -m CtsDeqpTestCases
Bug:32843094
Change-Id: I6ea71f0d6658b1f06354374ece54743609472345

8 years agoMerge "Check for EXT_color_buffer_float in read_pixels_fbo_format_mismatch" into...
Tina Zhou [Wed, 19 Oct 2016 15:59:19 +0000 (15:59 +0000)]
Merge "Check for EXT_color_buffer_float in read_pixels_fbo_format_mismatch" into nougat-cts-dev

8 years agoMerge "CP: Use empty region when buffer age is not supported" into nougat-cts-dev
Tina Zhou [Wed, 19 Oct 2016 15:58:07 +0000 (15:58 +0000)]
Merge "CP: Use empty region when buffer age is not supported" into nougat-cts-dev

8 years agoMerge "Fix deStrnlen fall-back implementation" into nougat-cts-dev
Tina Zhou [Wed, 19 Oct 2016 15:56:53 +0000 (15:56 +0000)]
Merge "Fix deStrnlen fall-back implementation" into nougat-cts-dev

8 years agoMerge "Remove a few preprocessor cases testing undefined behavior" into nougat-cts-dev
Tina Zhou [Wed, 19 Oct 2016 15:56:21 +0000 (15:56 +0000)]
Merge "Remove a few preprocessor cases testing undefined behavior" into nougat-cts-dev

8 years agoMerge "Check for shader type support in negative precise tests" into nougat-cts-dev
Tina Zhou [Wed, 19 Oct 2016 15:52:15 +0000 (15:52 +0000)]
Merge "Check for shader type support in negative precise tests" into nougat-cts-dev

8 years agoMerge "Check for shader type support in negative shader directive tests" into nougat...
Tina Zhou [Wed, 19 Oct 2016 15:50:37 +0000 (15:50 +0000)]
Merge "Check for shader type support in negative shader directive tests" into nougat-cts-dev

8 years agoFix sample_mask_in.bit_count_per_two_samples tests for 2x MSAA.
Kenneth Graunke [Sun, 4 Sep 2016 07:34:47 +0000 (00:34 -0700)]
Fix sample_mask_in.bit_count_per_two_samples tests for 2x MSAA.

The dEQP-GLES31.functional.shaders.sample_variables.sample_mask_in.
bit_count_per_two_samples.multisample_{texture,renderbuffer}_{1,2}
tests report:

    Verifying gl_SampleMaskIn.
    Fragment shader may be invoked [ceil(numSamples/2), numSamples] times.
    => gl_SampleMaskIn should have the number of bits set in range
       [1, numSamples - ceil(numSamples/2) + 1]:

which suggests that maxBitCount should be ceil(2/2) + 1 = 1 + 1 = 2.

However, it then says:

    Setting minBitCount = 1, maxBitCount = 1.

Having two bits should be acceptable for 2x MSAA.

This patch drops the special case for 1x/2x MSAA, making them work
like all the other MSAA levels.

Change-Id: Ie615c82150588dab53226dc46670182a29d85ef5
(cherry picked from commit 724519b8fda9c2a92d646c3dfd1478e0daa282e9)

8 years agoFix internal format/type for 3D + depth/stencil negative API tests.
Kenneth Graunke [Mon, 12 Sep 2016 19:37:08 +0000 (12:37 -0700)]
Fix internal format/type for 3D + depth/stencil negative API tests.

According to the ES 3.2 specification:

   "Textures with a base internal format of DEPTH_COMPONENT, DEPTH_STENCIL
    or STENCIL_INDEX are supported by texture image specification commands
    only if target is TEXTURE_2D, TEXTURE_2D_MULTISAMPLE, TEXTURE_2D_ARRAY,
    TEXTURE_2D_MULTISAMPLE_ARRAY, TEXTURE_CUBE_MAP or TEXTURE_CUBE_MAP_ARRAY.
    Using these formats in conjunction with any other target will result in
    an INVALID_OPERATION error."

This subtest tried to check the above error condition, but it specified
GL_DEPTH_STENCIL / GL_DEPTH_COMPONENT as format, rather than internalFormat.
Since the above text calls out "base internal format", we should specify
it as internalFormat.

We also change GL_DEPTH_STENCIL to use GL_UNSIGNED_INT_24_8 rather than
GL_UNSIGNED_BYTE, as that combination was illegal for a different reason
than the one the test intended to check.

Change-Id: I44bf607533b59f93fa42415bd6cad8783352582d
(cherry picked from commit ae7f8e0a07730e693b24d3dc7a23d2372319145e)

8 years agoFix deStrnlen fall-back implementation
Pyry Haulos [Thu, 7 Jul 2016 21:58:52 +0000 (14:58 -0700)]
Fix deStrnlen fall-back implementation

Fixes #423

Bug: 31952754

(cherry picked from commit 038db60bcbb1cdaf0157e5176af6422bda13ff28)

Change-Id: I7f22c2f0d325ecd2a57462f324214b7009c18782

8 years agoCherry-pick image_format_properties changes from upstream
Pyry Haulos [Tue, 11 Oct 2016 17:24:27 +0000 (10:24 -0700)]
Cherry-pick image_format_properties changes from upstream

Bug: 31732496

Contains 4 commits:

1: Fix dEQP-VK.api.info.image_format_properties - TRANSIENT usage flag used with DMA flags

(cherry picked from commit 83f90be9118a121b47f5e16f04029e205c68f994)

2: Fix VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT handling in query tests

83f90be9 added a check that was intended to make tests treat combination
of TRANSIENT_ATTACHMENT_BIT with non-RT usages invalid. However, that
change was buggy and lead the tests to treat _all_ usages of
TRANSIENT_ATTACHMENT_BIT invalid and thus skip testing them.

(cherry picked from commit 570326e5c8d85fe16fa6ce36de73c8f9bcba4d3e)

3: Do not require TRANSIENT usage support without other RT usages

Affects dEQP-VK.api.info.image_format_properties.*

See CTS issue #507 and spec issue #540

(cherry picked from commit 377ad0ad5962351d14badb1857b55dc8e8e49218)

4: Fix required sample counts per spec issue 478

Affects dEQP-VK.api.info.image_format_properties.*

See CTS issue #507 and spec issue #478

(cherry picked from commit 02c61e30f50cb04505f421b1ebe07c4a42864acf)

Change-Id: I4c714f887c1554994f90ec361ed44876465cd5a3

8 years agoRemove a few preprocessor cases testing undefined behavior
Pyry Haulos [Thu, 29 Sep 2016 17:11:52 +0000 (10:11 -0700)]
Remove a few preprocessor cases testing undefined behavior

Bug: 27126954
Change-Id: I1ee7ca0c0102b6273b1bc165b3d1ad24cee449e2

8 years agoMerge "CP: Split load/store image tests into sub-groups" into nougat-cts-dev
Daniel Xie [Wed, 14 Sep 2016 18:15:10 +0000 (18:15 +0000)]
Merge "CP: Split load/store image tests into sub-groups" into nougat-cts-dev

8 years agoMerge "CP: Require 'master' config to be supported in Android CTS" into nougat-cts-dev
Daniel Xie [Tue, 13 Sep 2016 16:43:43 +0000 (16:43 +0000)]
Merge "CP: Require 'master' config to be supported in Android CTS" into nougat-cts-dev

8 years agoMerge "CP: Handle EGL_EXT_yuv_surface in eglChooseConfig() tests" into nougat-cts-dev
Daniel Xie [Tue, 13 Sep 2016 16:43:39 +0000 (16:43 +0000)]
Merge "CP: Handle EGL_EXT_yuv_surface in eglChooseConfig() tests" into nougat-cts-dev

8 years agoMerge "Remove a few EGL tests using RGBA4 format from mustpass" into nougat-cts-dev
Daniel Xie [Tue, 13 Sep 2016 16:43:35 +0000 (16:43 +0000)]
Merge "Remove a few EGL tests using RGBA4 format from mustpass" into nougat-cts-dev

8 years agoMerge "CP: Reduce max iter count in alloc_callback_fail.device" into nougat-cts-dev
Daniel Xie [Tue, 13 Sep 2016 16:43:30 +0000 (16:43 +0000)]
Merge "CP: Reduce max iter count in alloc_callback_fail.device" into nougat-cts-dev

8 years agoMerge changes I212a8bc2,I476b6586 into nougat-cts-dev
Daniel Xie [Tue, 13 Sep 2016 16:43:20 +0000 (16:43 +0000)]
Merge changes I212a8bc2,I476b6586 into nougat-cts-dev

* changes:
  DO NOT MERGE Allow old behavior in image format property tests
  CP: Fix required sample count tests

8 years agoMerge "CP: Fix ext check in EXT_draw_buffers_indexed negative tests" into nougat...
Daniel Xie [Tue, 13 Sep 2016 16:43:15 +0000 (16:43 +0000)]
Merge "CP: Fix ext check in EXT_draw_buffers_indexed negative tests" into nougat-cts-dev

8 years agoMerge "CP: Fix geometry shader support check" into nougat-cts-dev
Daniel Xie [Tue, 13 Sep 2016 16:43:11 +0000 (16:43 +0000)]
Merge "CP: Fix geometry shader support check" into nougat-cts-dev

8 years agoMerge "CP: Check and enable VK_KHR_sampler_mirror_clamp_to_edge" into nougat-cts-dev
Daniel Xie [Tue, 13 Sep 2016 16:43:06 +0000 (16:43 +0000)]
Merge "CP: Check and enable VK_KHR_sampler_mirror_clamp_to_edge" into nougat-cts-dev

8 years agoMerge changes I85492417,I93389a2c into nougat-cts-dev
Daniel Xie [Tue, 13 Sep 2016 16:42:54 +0000 (16:42 +0000)]
Merge changes I85492417,I93389a2c into nougat-cts-dev

* changes:
  CP: Limit VkInstance count in object_management.multithreaded*
  CP: Do not test VkDevice, VkInstance creation OOM paths in WSI tests

8 years agoCheck for shader type support in negative shader directive tests
Pyry Haulos [Thu, 8 Sep 2016 22:27:06 +0000 (15:27 -0700)]
Check for shader type support in negative shader directive tests

Bug: 31312897
Change-Id: I40c2b47b0a6e6d0478cb6b63051ff474aae02f1f

8 years agoCheck for shader type support in negative precise tests
Pyry Haulos [Thu, 8 Sep 2016 22:18:16 +0000 (15:18 -0700)]
Check for shader type support in negative precise tests

Bug: 31312494
Change-Id: I8bc1536e238efcef23fea0164731b9851ddf35b9

8 years agoCP: Split load/store image tests into sub-groups
Kalle Raita [Sat, 13 Aug 2016 00:09:41 +0000 (17:09 -0700)]
CP: Split load/store image tests into sub-groups

Split load/store negative tests into sub-groups per texture type to
reduce the time required per single test case.

Bug: 30785598
Bug: 31343756

(cherry picked from commit 90763f1f7dfed4880fee7305b8f5789137951afc)

Change-Id: I4bd10004ee90f42ae616e654e425aa11df0cdd8d

8 years agoCheck for EXT_color_buffer_float in read_pixels_fbo_format_mismatch
Pyry Haulos [Thu, 1 Sep 2016 20:40:14 +0000 (13:40 -0700)]
Check for EXT_color_buffer_float in read_pixels_fbo_format_mismatch

Bug: 31244127
Change-Id: I0e25c5042aa832679f2da06b8401456058762750

8 years agoDO NOT MERGE Allow old behavior in image format property tests
Pyry Haulos [Wed, 31 Aug 2016 16:45:39 +0000 (09:45 -0700)]
DO NOT MERGE Allow old behavior in image format property tests

Vulkan API specification has changed in respect to what sample counts
vkGetPhysicalDeviceImageFormatProperties() should report. The change has
been made after initial Android Nougat drivers were frozen. For NYC CTS
we need to tolerate the old behavior and issue compatibility warning
instead.

Bug: 30739954
Change-Id: I212a8bc2b948760d3bf457e1c0e1199e0a8cc31e

8 years agoCP: Fix required sample count tests
Nanley Chery [Tue, 19 Apr 2016 19:13:58 +0000 (12:13 -0700)]
CP: Fix required sample count tests

According to,

   Table 11.1. Image and image view parameter compatibility requirements

Only non-cube images with type VK_IMAGE_TYPE_2D can have sample counts
greater than one.

In addition, the following properties should hold for multisampled
images: the formats must support being used in a color or depth/stencil
attachment, or in a storage image when shaderStorageImageMultisample is
supported. Images not fitting the above descriptions may have a sample
count of one or zero (in error conditions). Align tests for sample
counts to this behavior.

Bug: 30739954

(cherry picked from commit dc4227d5ec87080f5dad810b5e33ae3b3fa014a4)

Change-Id: I476b6586c351bddfb9f0b92cd7ec45fb9cc297c8

8 years agoMerge "Don't require supported binary formats in negative tests." into marshmallow...
Unsuk Jung [Tue, 30 Aug 2016 20:44:03 +0000 (20:44 +0000)]
Merge "Don't require supported binary formats in negative tests." into marshmallow-cts-dev
am: 3aa5258338

Change-Id: I8cb9cdf8f87cacaa2cb4c586953f884a3cfee098

8 years agoDon't require supported binary formats in negative tests.
Haixia Shi [Tue, 30 Aug 2016 20:44:02 +0000 (20:44 +0000)]
Don't require supported binary formats in negative tests.
am: 7cd59a4409

Change-Id: If08ea28912fe10ddc570841c8862d0918b1c224d

8 years agoMerge "Don't require supported binary formats in negative tests." into marshmallow...
Unsuk Jung [Tue, 30 Aug 2016 20:39:55 +0000 (20:39 +0000)]
Merge "Don't require supported binary formats in negative tests." into marshmallow-cts-dev

8 years agoCP: Use empty region when buffer age is not supported
Kalle Raita [Thu, 25 Aug 2016 21:52:52 +0000 (14:52 -0700)]
CP: Use empty region when buffer age is not supported

In the dEQP-EGL.functional.partial_update.* tests the damage region
needs to set to empty instead of implicit full screen for frame that do
not draw when the EGL_KHR_buffer_age is not supported. Otherwise the
contents become invalid and cannot be verified.

Bug: 30735352
Test: Local run of dEQP-EGL.functional.partial_update.* on various Nexus devices

(cherry picked from commit bc29554d7eed0bd996506fc1e074f264305c8143)

Change-Id: I17fc4fdca1da176e13e78b1ec2bebc8cb6d266b0

8 years agoCP: Check and enable VK_KHR_sampler_mirror_clamp_to_edge
Pyry Haulos [Mon, 8 Aug 2016 18:08:47 +0000 (11:08 -0700)]
CP: Check and enable VK_KHR_sampler_mirror_clamp_to_edge

Several tests in dEQP-VK.pipeline group assume that
VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE mode is supported. Spec
actually requires that VK_KHR_sampler_mirror_clamp_to_edge is enabled if
that mode is used.

This change enables VK_KHR_sampler_mirror_clamp_to_edge in default
device, if supported, and adds relevant checks in the test code.

In the future we'll want to clean this up by giving test cases more
control about the device configuration they need.

Fixes #339
Bug: 29996742

(cherry picked from commit ed8561a07cdb1bb7730eccf9025b738838392464)

Change-Id: I12312f0e48d20724c082f31c4ab03792dbb44826

8 years agoCP: Fix geometry shader support check
Pyry Haulos [Mon, 8 Aug 2016 19:34:35 +0000 (12:34 -0700)]
CP: Fix geometry shader support check

Bug: 30738286

(cherry picked from commit 83470b2dcbff396773f94d7a1448c12362ad3380)

Change-Id: Ife07ebd21f115114441ac8dc794a8d9e12c8acae

8 years agoCP: Fix ext check in EXT_draw_buffers_indexed negative tests
Pyry Haulos [Thu, 11 Aug 2016 20:32:47 +0000 (13:32 -0700)]
CP: Fix ext check in EXT_draw_buffers_indexed negative tests

Bug: 30738817

(cherry picked from commit cdfbadd0238044279cbc928bac9d895b002bcca6)

Change-Id: Iab592f4f97896995b6fb5a0f3a7ce0d885f9b834

8 years agoCP: Handle EGL_EXT_yuv_surface in eglChooseConfig() tests
Pyry Haulos [Mon, 22 Aug 2016 22:56:52 +0000 (15:56 -0700)]
CP: Handle EGL_EXT_yuv_surface in eglChooseConfig() tests

Includes various small code fixes to related utilities.

Bug: 30909517

(cherry picked from commit baea2158190b91fcf5d1aa78628dbad01d52a3ce)

Change-Id: I6f8c992daf81fafe796308a3e02c792096f2ae9f

8 years agoCP: Require 'master' config to be supported in Android CTS
Pyry Haulos [Tue, 23 Aug 2016 22:37:44 +0000 (15:37 -0700)]
CP: Require 'master' config to be supported in Android CTS

All Android devices should support rgba8888d24s8 for compatiblity and
test coverage.

Bug: 30938718

(cherry picked from commit e232a6e83c482b219ee1e7678c8ccf91c64b3086)

Change-Id: Ia924a13e5e62b3b8e51981b200314b911aa57bc4

8 years agoCP: Reduce max iter count in alloc_callback_fail.device
Pyry Haulos [Thu, 18 Aug 2016 14:29:04 +0000 (15:29 +0100)]
CP: Reduce max iter count in alloc_callback_fail.device

Creating VkDevice can be costly operation so we need to limit number of
tries to a pretty low value. Other tests already use per-thread limit of
20.

Additionally, this patch adds a way to override the limit by specifying
--deqp-test-iteration-count=N command line parameter. This is useful for
full OOM testing.

Bug: 30811856

(cherry picked from commit 3b17fd4c4e2d450f34f68989ff786939032cdcb9)

Change-Id: Ib3aaeff24d7753d52a6a444abfbecf863803c9ec

8 years agoCP: Limit VkInstance count in object_management.multithreaded*
Pyry Haulos [Thu, 11 Aug 2016 21:14:23 +0000 (14:14 -0700)]
CP: Limit VkInstance count in object_management.multithreaded*

Bug: 30811856

(cherry picked from commit fe2c3850aa70fd4ad253856de08e49f241e0fc90)

Change-Id: I854924178a7732eae44fd140340490c453fe3a03

8 years agoCP: Do not test VkDevice, VkInstance creation OOM paths in WSI tests
Pyry Haulos [Thu, 18 Aug 2016 14:22:00 +0000 (15:22 +0100)]
CP: Do not test VkDevice, VkInstance creation OOM paths in WSI tests

VkInstance and VkDevice creation OOM simulation is done already in
dEQP-VK.api.object_management.alloc_callback fail and repeating testing
in WSI tests just wastes time.

Since we want to trigger OOM even if implementation calls into instance-
or device-level callbacks, this is done by setting a mode in
DeterministicFailAllocator that stops alloc counting and failure
simulation.

Bug: 30811856

(cherry picked from commit 2dd2c2dc560092c80b636551237758b62fae78d7)

Change-Id: I93389a2c6b85f2dd8407824afb25d68770d4e6bd

8 years agoDon't require supported binary formats in negative tests.
Haixia Shi [Thu, 25 Aug 2016 21:24:06 +0000 (14:24 -0700)]
Don't require supported binary formats in negative tests.

Bug: 26906411
Change-Id: Ic1b50096695fbcd64d6af312d56f12c4381a5b7a

8 years agoMerge "DO NOT MERGE CP vertex array test and warning fixes" into marshmallow-cts-dev
Daniel Xie [Thu, 25 Aug 2016 20:52:41 +0000 (20:52 +0000)]
Merge "DO NOT MERGE CP vertex array test and warning fixes" into marshmallow-cts-dev
am: b9c3777b77  -s ours

Change-Id: I08bbe10aebbbd22e20b7fc98307be51f7629a353

8 years agoDO NOT MERGE CP vertex array test and warning fixes
Jarkko Pyry [Thu, 25 Aug 2016 20:52:40 +0000 (20:52 +0000)]
DO NOT MERGE CP vertex array test and warning fixes
am: c63640e53a  -s ours

Change-Id: If7c81a04a11470c6690daa793dedb3affaaeeb79

8 years agoMerge "Fix GLES2 format mismatch" into marshmallow-cts-dev
Daniel Xie [Thu, 25 Aug 2016 20:52:40 +0000 (20:52 +0000)]
Merge "Fix GLES2 format mismatch" into marshmallow-cts-dev
am: 98dd6ac745

Change-Id: I849a65a2f31bf0203935d3c73369c3e777a71c66

8 years agoFix GLES2 format mismatch
Stphane Marchesin [Thu, 25 Aug 2016 20:52:39 +0000 (20:52 +0000)]
Fix GLES2 format mismatch
am: 4b80682693

Change-Id: I7495cac0e459bbe38d9a38b4fb66bcbf9140c844

8 years agoIncrease no-data timeout to 5 seconds.
Haixia Shi [Thu, 25 Aug 2016 20:52:39 +0000 (20:52 +0000)]
Increase no-data timeout to 5 seconds.
am: d00b71cbc3

Change-Id: Ifeac2af6683b130a36ba69e5b8aee95092df1d14

8 years agoRemove a few EGL tests using RGBA4 format from mustpass
Pyry Haulos [Thu, 25 Aug 2016 20:43:23 +0000 (13:43 -0700)]
Remove a few EGL tests using RGBA4 format from mustpass

These suffer from threshold issues that are not trival to address with
current code.

Bug: 30909609
Change-Id: Ic6525f9749402009d495073c64e1f58869a93261

8 years agoMerge "DO NOT MERGE CP vertex array test and warning fixes" into marshmallow-cts-dev
Daniel Xie [Mon, 1 Aug 2016 19:36:29 +0000 (19:36 +0000)]
Merge "DO NOT MERGE CP vertex array test and warning fixes" into marshmallow-cts-dev

8 years agoMerge "Fix GLES2 format mismatch" into marshmallow-cts-dev
Daniel Xie [Wed, 27 Jul 2016 22:43:00 +0000 (22:43 +0000)]
Merge "Fix GLES2 format mismatch" into marshmallow-cts-dev

8 years agoIncrease no-data timeout to 5 seconds.
Haixia Shi [Tue, 26 Jul 2016 22:08:02 +0000 (15:08 -0700)]
Increase no-data timeout to 5 seconds.

On some low-end hardware we are observing the no-data timeout being exceeded
with no genuine hangs. Some tests take up to 1.7 seconds to complete. By
generously increasing this timeout we can eliminate flakes on slow devices
without any negative side-effects.

Bug: 29870344

Change-Id: I0a3165f26aefb4cdd18acb1ca0dd0210d7fdba69

8 years agoDO NOT MERGE CP vertex array test and warning fixes
Jarkko Pöyry [Wed, 20 May 2015 02:31:53 +0000 (19:31 -0700)]
DO NOT MERGE CP vertex array test and warning fixes

Cherry-pick fix to vertex array tests and a preceding conversion warning
fix for Marshmallow CTS for the files affected by the vertex array test fix.

8ed28c1e05f2325dc4b20c8f471067b29188c82f
Snap values to 3x3 grid in vertex array tests

This avoids cases where on small resolutions tests would fail because some
geometry was not visible or hidden in both result and reference.

Bug: 23495935

c8e526bfc2141e1cb7a269483fb55dc2a8e77c11
Fix -Wconversion warnings in glshared.

Bug: 21161908
Change-Id: If346e35335863344494c2513782e0b42d9a408e2

8 years agoFix build with new Interface
Julien Desprez [Mon, 27 Jun 2016 18:22:07 +0000 (19:22 +0100)]
Fix build with new Interface

Bug: 29622918
Change-Id: I73ccd7891869d2d67a144e8787d2fff8fb9c6878

8 years agoUpdate TF interface for filters
Julien Desprez [Mon, 27 Jun 2016 09:47:19 +0000 (10:47 +0100)]
Update TF interface for filters

Bug: 29622918
Change-Id: I5832fadb1b88426677e87de86f0bc51194548ada

8 years agoCheck duplicate layers and extensions
Mika Isojärvi [Wed, 27 Apr 2016 21:19:13 +0000 (14:19 -0700)]
Check duplicate layers and extensions

Bug: 28100235
Change-Id: I1fdae715a1bbda43b6bc6ebe346ca21f3e294df6

8 years agoMerge "Reset debug message callback if exception is thrown" into nyc-dev
Mika Isojarvi [Mon, 13 Jun 2016 22:26:39 +0000 (22:26 +0000)]
Merge "Reset debug message callback if exception is thrown" into nyc-dev

8 years agoMerge "Allow specifying version when creating OpenGL context" into nyc-dev
Mika Isojarvi [Mon, 13 Jun 2016 22:26:09 +0000 (22:26 +0000)]
Merge "Allow specifying version when creating OpenGL context" into nyc-dev

8 years agoMerge "Add negative tessellation IO array size cases to mustpass" into nyc-dev
Pyry Haulos [Mon, 13 Jun 2016 21:45:05 +0000 (21:45 +0000)]
Merge "Add negative tessellation IO array size cases to mustpass" into nyc-dev

8 years agoMerge "Add tests for varying linking by location" into nyc-dev
Pyry Haulos [Mon, 13 Jun 2016 21:41:39 +0000 (21:41 +0000)]
Merge "Add tests for varying linking by location" into nyc-dev

8 years agoMerge "Add simple Vulkan smoke test that doesn't use OpName" into nyc-dev
Pyry Haulos [Mon, 13 Jun 2016 21:41:26 +0000 (21:41 +0000)]
Merge "Add simple Vulkan smoke test that doesn't use OpName" into nyc-dev

8 years agoMerge "Add tests for uniform block linking by binding" into nyc-dev
Pyry Haulos [Mon, 13 Jun 2016 21:41:10 +0000 (21:41 +0000)]
Merge "Add tests for uniform block linking by binding" into nyc-dev

8 years agoReset debug message callback if exception is thrown
Mika Isojärvi [Thu, 9 Jun 2016 17:08:17 +0000 (10:08 -0700)]
Reset debug message callback if exception is thrown

Bug: 29190874
Change-Id: Ie98b2286d1e9257247bfd0ff5924670c68631056

8 years agoAllow specifying version when creating OpenGL context
Mika Isojärvi [Thu, 9 Jun 2016 16:45:35 +0000 (09:45 -0700)]
Allow specifying version when creating OpenGL context

Allow specifying version number when creating OpenGL context using
EGL_KHR_create_context.

Bug: 29191048
Change-Id: Ia827f8b1ba69c0695943d34f43255d4153780bbf