bungeman [Fri, 29 Apr 2016 14:08:12 +0000 (07:08 -0700)]
Update running Chromium trybots on Skia CLs docs.
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=
1930773005
Review-Url: https://codereview.chromium.org/
1930773005
bsalomon [Fri, 29 Apr 2016 14:07:03 +0000 (07:07 -0700)]
Unify implementations of stroking radius calculationsns
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1928133002
Review-Url: https://codereview.chromium.org/
1928133002
robertphillips [Fri, 29 Apr 2016 13:46:36 +0000 (06:46 -0700)]
Add sk_sp to SkSurface_Gpu and SkGpuDevice
Split off of https://codereview.chromium.org/
1930013002/ ((Mostly) Retract GrRenderTarget from SkGpuDevice)
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1925803004
Review-Url: https://codereview.chromium.org/
1925803004
djsollen [Fri, 29 Apr 2016 13:41:35 +0000 (06:41 -0700)]
Repurpose Release_Developer BUILDTYPE and remove SK_DEVELOPER.
The Release_Developer build type is now used to build Skia with
release level optimizations but still enable SK_DEBUG. This in turn
means that SkASSERTS and SkRTConf are available in this mode.
Further we can then remove SK_DEVELOPER as a define as it is true
iff SK_DEBUG is true.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1931903002
DOCS_PREVIEW= https://skia.org/?cl=
1931903002
Review-Url: https://codereview.chromium.org/
1931903002
kkinnunen [Fri, 29 Apr 2016 13:41:29 +0000 (06:41 -0700)]
Make stencils be attachable to render targets created via SkSurface::MakeFromBackendTextureAsRenderTarget
This is a regression from "Refactor to separate backend object lifecycle
and GpuResource budget decision".
GrGLRenderTarget::CreateWrapped creates only render targets that wrap
the FBO.
GrGLRenderTargetTexture::CreateWrapped creates render targets that
wrap the texture.
Use the latter as the implementation for
SkSurface::MakeFromBackendTextureAsRenderTarget.
The test contains disabled code. The
MakeFromBackendTextureAsRenderTarget does not copy the existing texture
contents to the FBO render buffer.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1924183003
Review-Url: https://codereview.chromium.org/
1924183003
borenet [Fri, 29 Apr 2016 13:25:47 +0000 (06:25 -0700)]
Whitespace change to test bots
NOTREECHECKS=true
TBR=rmistry
BUG=skia:4763
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1936543002
Review-Url: https://codereview.chromium.org/
1936543002
xidachen [Fri, 29 Apr 2016 01:25:25 +0000 (18:25 -0700)]
Adjust tolerance to fix bezier glitches issue
In a previous CL: https://codereview.chromium.org/
1126793003, the value
of gDegenerateToLineTol was changed from 1.0 to 0.25 which caused the
bezier glitches.
This CL changes the value to SK_ScalarRoot2Over2, with this change the
bezier curve looks fine, and the result of the layout tests pointed out
in this bug: https://bugs.chromium.org/p/chromium/issues/detail?id=472847
is also reasonable.
BUG=605439
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1926063002
Review-Url: https://codereview.chromium.org/
1926063002
robertphillips [Thu, 28 Apr 2016 22:09:34 +0000 (15:09 -0700)]
Tighten up SkSpecialSurface factory functions
This is split out of https://codereview.chromium.org/
1930013002/ ((Mostly) Retract GrRenderTarget from SkGpuDevice)
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1925313002
Review-Url: https://codereview.chromium.org/
1925313002
robertphillips [Thu, 28 Apr 2016 21:32:04 +0000 (14:32 -0700)]
Clean up test drawContext usage
The general idea is to provide access to SkGpuDevice's drawContext rather than its GrRenderTarget. That is usually what the testing framework actually wants.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1930623003
Review-Url: https://codereview.chromium.org/
1930623003
bungeman [Thu, 28 Apr 2016 18:18:07 +0000 (11:18 -0700)]
Remove skstd::is_convertible.
We should now be able to use std::is_convertible.
TBR=reed@google.com
This doesn't change any API, just where we get a type trait from.
Review-Url: https://codereview.chromium.org/
1931003002
mtklein [Thu, 28 Apr 2016 18:02:36 +0000 (11:02 -0700)]
Update Win toolchain
I believe this now correctly updates us to VS 2015 update 2.
CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Win-MSVC-x86-Debug-VS2015-Trybot
https://isolateserver.appspot.com/browse?namespace=default-gzip&digest=
3c710fd7f4df8ec24fde62681536fad21be2751c
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1926813007
Review-Url: https://codereview.chromium.org/
1926813007
robertphillips [Thu, 28 Apr 2016 16:55:15 +0000 (09:55 -0700)]
Refactor drawContext/RenderTarget creation
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1914883002
Committed: https://skia.googlesource.com/skia/+/
2f1c42e8448bbbadeb3df1c626faa90aa33f8907
Review-Url: https://codereview.chromium.org/
1914883002
msarett [Thu, 28 Apr 2016 16:50:12 +0000 (09:50 -0700)]
Delete unused code from SkColorSpace
IMO, a lot of this code reflects an oversimplified view of
handling color profiles. And a lot of this code is valid
math/checks/enums that we will eventually need.
Right now, it's all unused and is adding a bit of clutter
and confusion as I try to redesign this object. I think
it makes sense to start simpler and build this back up as
necessary.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1932743002
Review-Url: https://codereview.chromium.org/
1932743002
msarett [Thu, 28 Apr 2016 16:36:34 +0000 (09:36 -0700)]
Parse A2B0 tag on ICC profiles
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1925753002
Review-Url: https://codereview.chromium.org/
1925753002
borenet [Thu, 28 Apr 2016 16:31:38 +0000 (09:31 -0700)]
Stop printing warnings about ADB version
BUG=skia:5156
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1927973002
Review-Url: https://codereview.chromium.org/
1927973002
reed [Thu, 28 Apr 2016 16:31:31 +0000 (09:31 -0700)]
remove (now unused) SkDivBits
needs https://codereview.chromium.org/
1927823002/ to land first
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1925913002
Review-Url: https://codereview.chromium.org/
1925913002
bsalomon [Thu, 28 Apr 2016 16:30:46 +0000 (09:30 -0700)]
Detect empty (r)rects in GrShape.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1929643002
Review-Url: https://codereview.chromium.org/
1929643002
egdaniel [Thu, 28 Apr 2016 16:30:39 +0000 (09:30 -0700)]
Fix vulkan build on linux and android
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1921963003
Review-Url: https://codereview.chromium.org/
1921963003
reed [Thu, 28 Apr 2016 15:12:55 +0000 (08:12 -0700)]
Revert of Repurpose Release_Developer BUILDTYPE and remove SK_DEVELOPER. (patchset #2 id:20001 of https://codereview.chromium.org/
1927583002/ )
Reason for revert:
still blocking DEPS roll
Original issue's description:
> Repurpose Release_Developer BUILDTYPE and remove SK_DEVELOPER.
>
> The Release_Developer build type is now used to build Skia with
> release level optimizations but still enable SK_DEBUG. This in turn
> means that SkASSERTS and SkRTConf are available in this mode.
>
> Further we can then remove SK_DEVELOPER as a define as it is true
> iff SK_DEBUG is true.
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1927583002
> DOCS_PREVIEW= https://skia.org/?cl=
1927583002
>
> Committed: https://skia.googlesource.com/skia/+/
48d6f88479e72efaf9b9d8f9c0769acb1ba773db
TBR=bungeman@gmail.com,bungeman@google.com,benjaminwagner@google.com,djsollen@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review-Url: https://codereview.chromium.org/
1918253006
reed [Thu, 28 Apr 2016 15:11:51 +0000 (08:11 -0700)]
Revert of fix build by using ifdef instead of if for SK_DEBUG (patchset #1 id:1 of https://codereview.chromium.org/
1924943003/ )
Reason for revert:
need to revert main change for now
Original issue's description:
> fix build by using ifdef instead of if for SK_DEBUG
>
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1924943003
>
> TBR=
> NOTRY=True
>
> Committed: https://skia.googlesource.com/skia/+/
b8498825b54718cdd90c30c39323cfc433695f23
TBR=djsollen@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review-Url: https://codereview.chromium.org/
1927113002
robertphillips [Thu, 28 Apr 2016 13:21:55 +0000 (06:21 -0700)]
Revert of Refactor drawContext/RenderTarget creation (patchset #8 id:140001 of https://codereview.chromium.org/
1914883002/ )
Reason for revert:
Experimental revert to see if this is blocking the DEPS roll.
Original issue's description:
> Refactor drawContext/RenderTarget creation
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1914883002
>
> Committed: https://skia.googlesource.com/skia/+/
2f1c42e8448bbbadeb3df1c626faa90aa33f8907
TBR=bsalomon@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review-Url: https://codereview.chromium.org/
1929833004
reed [Thu, 28 Apr 2016 01:46:46 +0000 (18:46 -0700)]
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1924943003
TBR=
NOTRY=True
Review-Url: https://codereview.chromium.org/
1924943003
reed [Thu, 28 Apr 2016 01:45:36 +0000 (18:45 -0700)]
remove SK_SUPPORT_LEGACY_DIVBITS_UB -- chrome no longer defines this
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1927823002
TBR=mtklein@google.com
Review-Url: https://codereview.chromium.org/
1927823002
msarett [Wed, 27 Apr 2016 20:51:20 +0000 (13:51 -0700)]
Enable flattening of SkRecordedDrawable
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1913843002
Committed: https://skia.googlesource.com/skia/+/
d636950e8ecba89c0021ce4e76037c67aa6ee2cd
Review-Url: https://codereview.chromium.org/
1913843002
reed [Wed, 27 Apr 2016 20:49:32 +0000 (13:49 -0700)]
skip unneeded header from writeFlattenable when building font-cache-key. Saves ~30% in size
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1924033002
TBR=mtklein
Review-Url: https://codereview.chromium.org/
1924033002
borenet [Wed, 27 Apr 2016 20:44:57 +0000 (13:44 -0700)]
adb_wait_for_charge: Don't download toolchains
BUG=skia:5156
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1926833003
Review-Url: https://codereview.chromium.org/
1926833003
djsollen [Wed, 27 Apr 2016 20:44:28 +0000 (13:44 -0700)]
Make the default android build be release_developer.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1929663002
Review-Url: https://codereview.chromium.org/
1929663002
djsollen [Wed, 27 Apr 2016 20:37:23 +0000 (13:37 -0700)]
Repurpose Release_Developer BUILDTYPE and remove SK_DEVELOPER.
The Release_Developer build type is now used to build Skia with
release level optimizations but still enable SK_DEBUG. This in turn
means that SkASSERTS and SkRTConf are available in this mode.
Further we can then remove SK_DEVELOPER as a define as it is true
iff SK_DEBUG is true.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1927583002
DOCS_PREVIEW= https://skia.org/?cl=
1927583002
Review-Url: https://codereview.chromium.org/
1927583002
robertphillips [Wed, 27 Apr 2016 20:34:01 +0000 (13:34 -0700)]
Refactor drawContext/RenderTarget creation
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1914883002
Review-Url: https://codereview.chromium.org/
1914883002
bsalomon [Wed, 27 Apr 2016 20:30:25 +0000 (13:30 -0700)]
Add tests for volatile paths to GrShapeTest
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1923403003
Review-Url: https://codereview.chromium.org/
1923403003
bsalomon [Wed, 27 Apr 2016 19:36:02 +0000 (12:36 -0700)]
Add tests for empty GrShapes.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1927673002
Review-Url: https://codereview.chromium.org/
1927673002
bungeman [Wed, 27 Apr 2016 19:30:25 +0000 (12:30 -0700)]
Simplify style handling in custom font manager.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1915103002
Review-Url: https://codereview.chromium.org/
1915103002
halcanary [Wed, 27 Apr 2016 19:07:55 +0000 (12:07 -0700)]
SkDocument::CreateXPS fix roll
NOTRY=true
TBR=reed@google.com
Review-Url: https://codereview.chromium.org/
1918713006
jvanverth [Wed, 27 Apr 2016 18:42:21 +0000 (11:42 -0700)]
Remove AttachmentInfo from VulkanViewer setup
It's not necessary to pass this information back up to the client;
we can store it in the TestContext if needed for Surface creation.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1920163004
Review-Url: https://codereview.chromium.org/
1920163004
egdaniel [Wed, 27 Apr 2016 18:31:59 +0000 (11:31 -0700)]
Add work around for vulkan copies on the 5X
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1923963002
Review-Url: https://codereview.chromium.org/
1923963002
senorblanco [Wed, 27 Apr 2016 18:31:23 +0000 (11:31 -0700)]
Image filters: de-nest SkImageFilter::Cache and Cache::Key.
This reduces the public header, and also allows us to foward-
declare them, so we can remove an #include from all the
SkDevice subclass headers.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1919063002
Review-Url: https://codereview.chromium.org/
1919063002
halcanary [Wed, 27 Apr 2016 17:57:52 +0000 (10:57 -0700)]
SkPDF/None: fix compilation
TBR=stephana@google.com
Review-Url: https://codereview.chromium.org/
1929593002
robertphillips [Wed, 27 Apr 2016 17:47:51 +0000 (10:47 -0700)]
Bring sk_sp to GrDrawContext
This is split out of: https://codereview.chromium.org/
1914883002/ (Refactor drawContext/RenderTarget creation)
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1918003003
Review-Url: https://codereview.chromium.org/
1918003003
bungeman [Wed, 27 Apr 2016 17:21:04 +0000 (10:21 -0700)]
Add oblique as a slant.
Some fonts have italic and oblique in the same family, see
http://lucidafonts.com/fonts/family/lucida-sans
http://www.gust.org.pl/projects/e-foundry/latin-modern
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1921903002
Chromium side change at https://crrev.com/
1921503006/ .
Review-Url: https://codereview.chromium.org/
1921903002
rmistry [Wed, 27 Apr 2016 16:43:20 +0000 (09:43 -0700)]
Add dry_run_access_list to Skia's cq.proto
This will give all users who have access to our trybots access to our dry run CQ as well.
BUG=591183
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1926783002
Review-Url: https://codereview.chromium.org/
1926783002
mtklein [Wed, 27 Apr 2016 16:29:34 +0000 (09:29 -0700)]
Revert of Enable flattening of SkRecordedDrawable (patchset #8 id:140001 of https://codereview.chromium.org/
1913843002/ )
Reason for revert:
Release mode bots appear to be crashing while loading .skp files in nanobench.
Original issue's description:
> Enable flattening of SkRecordedDrawable
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1913843002
>
> Committed: https://skia.googlesource.com/skia/+/
d636950e8ecba89c0021ce4e76037c67aa6ee2cd
TBR=djsollen@google.com,reed@google.com,msarett@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review-Url: https://codereview.chromium.org/
1923393002
msarett [Wed, 27 Apr 2016 16:03:17 +0000 (09:03 -0700)]
Enable flattening of SkRecordedDrawable
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1913843002
Review-Url: https://codereview.chromium.org/
1913843002
djsollen [Wed, 27 Apr 2016 15:48:56 +0000 (08:48 -0700)]
Upgrade Android Gradle plugins
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1926743002
Review-Url: https://codereview.chromium.org/
1926743002
reed [Wed, 27 Apr 2016 14:49:17 +0000 (07:49 -0700)]
remove 'deprecated' region from SkDraw
Most call-sites that used it just took its bounds, so it was trivial to convert them
to get the bounds of the RasterClip. Two clients wanted the actual region:
1. layeriter for android
2. pdf
Android already only has BW clips, so should be safe.
PDF now overrides its clip methods to ensure that all clips are BW.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1925693002
Review URL: https://codereview.chromium.org/
1925693002
halcanary [Wed, 27 Apr 2016 14:45:18 +0000 (07:45 -0700)]
SkDocument/PDF: new API
has a pdf/a switch.
sets metadata in factory.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1916093002
Review URL: https://codereview.chromium.org/
1916093002
halcanary [Wed, 27 Apr 2016 14:44:03 +0000 (07:44 -0700)]
tools/pdf-comparison.sh: stop relying on /usr/bin/timeout
NOTRY=true
TBR=
Review URL: https://codereview.chromium.org/
1921943006
rmistry [Wed, 27 Apr 2016 14:31:23 +0000 (07:31 -0700)]
Treat kIncompleteInput as successes in get_images_from_skps
Context:
https://bugs.chromium.org/p/skia/issues/detail?id=5226
and
https://codereview.chromium.org/
1844713003/diff/160001/tools/get_images_from_skps.cpp#newcode83
BUG=skia:5226
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1917413003
Review URL: https://codereview.chromium.org/
1917413003
stephana [Wed, 27 Apr 2016 13:50:03 +0000 (06:50 -0700)]
Disable ReadWriteAlpha on TSAN
BUG=skia:
R=borenet
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1927573002
Review URL: https://codereview.chromium.org/
1927573002
bsalomon [Wed, 27 Apr 2016 13:46:23 +0000 (06:46 -0700)]
Add support for building GrShape from SkPath and more tests
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1922713002
Review URL: https://codereview.chromium.org/
1922713002
msarett [Wed, 27 Apr 2016 13:12:26 +0000 (06:12 -0700)]
Add comments and sanity checks to parsing of ICC headers
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1922073003
Review URL: https://codereview.chromium.org/
1922073003
borenet [Wed, 27 Apr 2016 13:06:25 +0000 (06:06 -0700)]
Don't isolate the Skia repo for Swarming compiles
BUG=skia:
NOTREECHECKS=true
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1886343002
Review URL: https://codereview.chromium.org/
1886343002
brianosman [Tue, 26 Apr 2016 23:51:03 +0000 (16:51 -0700)]
Change default window size on Windows.
The OS tends to pick a very large size if you let it. Instead, choose a
smaller (fixed) window (matching what we currently use on Linux).
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1919133004
Review URL: https://codereview.chromium.org/
1919133004
brianosman [Tue, 26 Apr 2016 23:48:06 +0000 (16:48 -0700)]
Ensure we're operating on the correct texture when generating mipmaps.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1915403004
Review URL: https://codereview.chromium.org/
1915403004
robertphillips [Tue, 26 Apr 2016 22:02:25 +0000 (15:02 -0700)]
Revert of Remove gpu-specialization of SkSpecialImage (patchset #5 id:80001 of https://codereview.chromium.org/
1918993002/ )
Reason for revert:
N6 bot has gone red
Original issue's description:
> Remove gpu-specialization of SkSpecialImage
>
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1918993002
>
> Committed: https://skia.googlesource.com/skia/+/
0533d6e4142c2787d6d3c325ef0d8d1962292cad
TBR=reed@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/
1921393003
brianosman [Tue, 26 Apr 2016 21:37:27 +0000 (14:37 -0700)]
Remove unmatched restore call in gamma GM
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1917303002
Review URL: https://codereview.chromium.org/
1917303002
robertphillips [Tue, 26 Apr 2016 21:33:36 +0000 (14:33 -0700)]
Remove gpu-specialization of SkSpecialImage
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1918993002
Review URL: https://codereview.chromium.org/
1918993002
bsalomon [Tue, 26 Apr 2016 21:27:21 +0000 (14:27 -0700)]
Don't buffer stdout in DM
TBR=egdaniel@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1922223002
Review URL: https://codereview.chromium.org/
1922223002
deanm [Tue, 26 Apr 2016 21:15:21 +0000 (14:15 -0700)]
pathops: Split loop type cubics only when there is a self-intersection.
The ComplexBreak code comes from Loop and Blinn, which requires loops to be
split if either double point is visible. However for intersection loops only
need to be split when there is actually a self-intersection (when both double
points are in [0, 1]). This patch splits cubics much less often so the output
doesn't have extra segments unless the input had a self-intersecting loop.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1920663002
Review URL: https://codereview.chromium.org/
1920663002
deanm [Tue, 26 Apr 2016 21:12:22 +0000 (14:12 -0700)]
pathops: Cosmetic only change, update comments around ComplexBreak().
Rename loopT to splitT and make it clearer that it is not just
self intersecting loop cubics that are split.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1921173003
Review URL: https://codereview.chromium.org/
1921173003
deanm [Tue, 26 Apr 2016 21:09:01 +0000 (14:09 -0700)]
pathops: Add missing header guards in two files.
Guards were missing in SkIntersectionHelper.h and
SkPathOpsTSect.h.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1914873002
Review URL: https://codereview.chromium.org/
1914873002
msarett [Tue, 26 Apr 2016 20:08:57 +0000 (13:08 -0700)]
Update SK_IMAGE_VERSION, run nanobench on its own image set
I've added a new directory to the cloud
(gs://chromium-skia-gm/skimage/v4/nanobench) which will
allow us to run dm and nanobench on different sets of
images.
The dm image set will stay the same, and includes
incomplete images, edge cases images, etc.
The nanobench set is much smaller, and includes jpegs and
pngs that we've found useful to bench in the past, plus
a couple of each for the other formats. We can refine
this set as we move forward (and may also want to monitor
these images on perf.skia.org).
For now the goal is to reduce nanobench runtime by not
testing on many, many obscure images that are not
particularly interesting to time.
The actual change to use nanobench images is in:
https://codereview.chromium.org/
1917903003/
BUG=skia:5181
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1913813004
Review URL: https://codereview.chromium.org/
1913813004
msarett [Tue, 26 Apr 2016 20:06:38 +0000 (13:06 -0700)]
Remove redundant tests to make DM a little faster
This should help with some of the slow down caused by
https://codereview.chromium.org/
1907593004.
BUG=skia:5181
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1923533002
Review URL: https://codereview.chromium.org/
1923533002
msarett [Tue, 26 Apr 2016 19:59:47 +0000 (12:59 -0700)]
Remove redundant test
FlattenDrawable test now exercises the use of custom unflatten procs.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1917183002
Review URL: https://codereview.chromium.org/
1917183002
bsalomon [Tue, 26 Apr 2016 19:56:00 +0000 (12:56 -0700)]
Add initial implementation of GrShape and GrStyle classes and tests
The initial intent is to use GrShape to simplify the mask blur code paths. However, I also want to use this to explore a more unified drawing code flow for different geometry types. The goal is to have a single representation for geometries+styling that attempts to always keep the geometry in the simplest form (e.g. preferring rrects to paths). It also allows for converting styling information into modified geometry and for computing consistent keys.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1822723003
Committed: https://skia.googlesource.com/skia/+/
c885dacfe4625af8b0e2e5c6e8a8ae8dc2d620a8
Committed: https://skia.googlesource.com/skia/+/
824e58fc6df8fc149d9675f577f7deeaba698b09
Review URL: https://codereview.chromium.org/
1822723003
liyuqian [Tue, 26 Apr 2016 19:54:05 +0000 (12:54 -0700)]
Add runhooks to multi_repo_trybots
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1924573002
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=
1924573002
Review URL: https://codereview.chromium.org/
1924573002
halcanary [Tue, 26 Apr 2016 19:43:59 +0000 (12:43 -0700)]
pdf comparison tool
NOTRY=true
Review URL: https://codereview.chromium.org/
1924513002
djsollen [Tue, 26 Apr 2016 19:38:52 +0000 (12:38 -0700)]
Update android docs for how to sync source code
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1921023002
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=
1921023002
Review URL: https://codereview.chromium.org/
1921023002
halcanary [Tue, 26 Apr 2016 19:38:47 +0000 (12:38 -0700)]
bin/fetch-skps: print instruction on error
NOTRY=true
Review URL: https://codereview.chromium.org/
1919133003
borenet [Tue, 26 Apr 2016 19:16:52 +0000 (12:16 -0700)]
Whitespace change to trigger bots after recipe fix
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1922783003
NOTREECHECKS=true
Review URL: https://codereview.chromium.org/
1922783003
bsalomon [Tue, 26 Apr 2016 15:41:47 +0000 (08:41 -0700)]
Revert of Add initial implementation of GrShape and GrStyle classes and tests (patchset #11 id:280001 of https://codereview.chromium.org/
1822723003/ )
Reason for revert:
test failing
Original issue's description:
> Add initial implementation of GrShape and GrStyle classes and tests
>
> The initial intent is to use GrShape to simplify the mask blur code paths. However, I also want to use this to explore a more unified drawing code flow for different geometry types. The goal is to have a single representation for geometries+styling that attempts to always keep the geometry in the simplest form (e.g. preferring rrects to paths). It also allows for converting styling information into modified geometry and for computing consistent keys.
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1822723003
>
> Committed: https://skia.googlesource.com/skia/+/
c885dacfe4625af8b0e2e5c6e8a8ae8dc2d620a8
>
> Committed: https://skia.googlesource.com/skia/+/
824e58fc6df8fc149d9675f577f7deeaba698b09
TBR=robertphillips@google.com,egdaniel@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
1919243002
rmistry [Tue, 26 Apr 2016 15:27:49 +0000 (08:27 -0700)]
Return error code when get_images_from_skps has failures.
BUG=skia:4981
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1916183002
Review URL: https://codereview.chromium.org/
1916183002
msarett [Tue, 26 Apr 2016 15:20:14 +0000 (08:20 -0700)]
Do not globally register drawables in test code
TBR=reed@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1922853003
Review URL: https://codereview.chromium.org/
1922853003
herb [Tue, 26 Apr 2016 15:15:27 +0000 (08:15 -0700)]
Add guards for edge cases.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1915263002
Review URL: https://codereview.chromium.org/
1915263002
egdaniel [Tue, 26 Apr 2016 15:15:09 +0000 (08:15 -0700)]
Remove unnessary uniform barriers in Vulkan.
Also added a fix to descriptor set allocation.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1914053004
Review URL: https://codereview.chromium.org/
1914053004
jvanverth [Tue, 26 Apr 2016 15:01:44 +0000 (08:01 -0700)]
Add automatic generation of mipmaps to Vulkan
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1916563002
Review URL: https://codereview.chromium.org/
1916563002
jvanverth [Tue, 26 Apr 2016 15:01:33 +0000 (08:01 -0700)]
Fix animation with stats in VulkanViewer
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1918083003
Review URL: https://codereview.chromium.org/
1918083003
reed [Tue, 26 Apr 2016 13:57:31 +0000 (06:57 -0700)]
make context() virtual on device
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1922123002
TBR=robertphilips
Review URL: https://codereview.chromium.org/
1922123002
bsalomon [Tue, 26 Apr 2016 13:53:45 +0000 (06:53 -0700)]
Add initial implementation of GrShape and GrStyle classes and tests
The initial intent is to use GrShape to simplify the mask blur code paths. However, I also want to use this to explore a more unified drawing code flow for different geometry types. The goal is to have a single representation for geometries+styling that attempts to always keep the geometry in the simplest form (e.g. preferring rrects to paths). It also allows for converting styling information into modified geometry and for computing consistent keys.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1822723003
Committed: https://skia.googlesource.com/skia/+/
c885dacfe4625af8b0e2e5c6e8a8ae8dc2d620a8
Review URL: https://codereview.chromium.org/
1822723003
robertphillips [Tue, 26 Apr 2016 12:07:23 +0000 (05:07 -0700)]
Revert of Add initial implementation of GrShape and GrStyle classes and tests (patchset #10 id:260001 of https://codereview.chromium.org/
1822723003/ )
Reason for revert:
From what I can tell, this compiles on 2015 but not 2013.
Original issue's description:
> Add initial implementation of GrShape and GrStyle classes and tests
>
> The initial intent is to use GrShape to simplify the mask blur code paths. However, I also want to use this to explore a more unified drawing code flow for different geometry types. The goal is to have a single representation for geometries+styling that attempts to always keep the geometry in the simplest form (e.g. preferring rrects to paths). It also allows for converting styling information into modified geometry and for computing consistent keys.
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1822723003
>
> Committed: https://skia.googlesource.com/skia/+/
c885dacfe4625af8b0e2e5c6e8a8ae8dc2d620a8
TBR=egdaniel@google.com,bsalomon@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
1918203002
halcanary [Tue, 26 Apr 2016 11:49:45 +0000 (04:49 -0700)]
Documentation: FAQ: drop shadow
NOTRY=true
DOCS_PREVIEW= https://skia.org/user/tips?cl=
1918833003#text-shadow
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1918833003
Review URL: https://codereview.chromium.org/
1918833003
bsalomon [Mon, 25 Apr 2016 20:37:22 +0000 (13:37 -0700)]
Add initial implementation of GrShape and GrStyle classes and tests
The initial intent is to use GrShape to simplify the mask blur code paths. However, I also want to use this to explore a more unified drawing code flow for different geometry types. The goal is to have a single representation for geometries+styling that attempts to always keep the geometry in the simplest form (e.g. preferring rrects to paths). It also allows for converting styling information into modified geometry and for computing consistent keys.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1822723003
Review URL: https://codereview.chromium.org/
1822723003
halcanary [Mon, 25 Apr 2016 20:34:06 +0000 (13:34 -0700)]
bin/sync
Review URL: https://codereview.chromium.org/
1915223002
liyuqian [Mon, 25 Apr 2016 20:15:37 +0000 (13:15 -0700)]
Improve Android Quick Start Guide
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1919973002
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=
1919973002
Review URL: https://codereview.chromium.org/
1919973002
halcanary [Mon, 25 Apr 2016 19:39:39 +0000 (12:39 -0700)]
bin/sync-and-gyp: more dirs to search
Review URL: https://codereview.chromium.org/
1914993003
robertphillips [Mon, 25 Apr 2016 19:32:54 +0000 (12:32 -0700)]
Add another dollop of sk_sp to SkSpecialImage and SkSpecialSurface
This is split out of https://codereview.chromium.org/
1914883002/ (Refactor drawContext/RenderTarget creation)
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1913743002
Review URL: https://codereview.chromium.org/
1913743002
reed [Mon, 25 Apr 2016 19:29:38 +0000 (12:29 -0700)]
share code with drawSpriteWithFilter
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1920733003
Review URL: https://codereview.chromium.org/
1920733003
djsollen [Mon, 25 Apr 2016 18:45:35 +0000 (11:45 -0700)]
Make clang the default Android compiler.
BUG=skia:5215
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1919873003
Review URL: https://codereview.chromium.org/
1919873003
msarett [Mon, 25 Apr 2016 18:41:15 +0000 (11:41 -0700)]
Remove SkEncodedInfo kPreSwizzled_Color from public API
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1918943002
Review URL: https://codereview.chromium.org/
1918943002
borenet [Mon, 25 Apr 2016 18:22:41 +0000 (11:22 -0700)]
build_command_buffer: Don't 'git checkout' when --no-sync
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1915063002
Review URL: https://codereview.chromium.org/
1915063002
rmistry [Mon, 25 Apr 2016 17:35:03 +0000 (10:35 -0700)]
Test decoding and output failures to JSON in get_images_from_skps.
Testing for decoding was copy pasted from msarett's CL https://codereview.chromium.org/
1828323002/
BUG=skia:4981
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1844713003
Review URL: https://codereview.chromium.org/
1844713003
halcanary [Mon, 25 Apr 2016 17:32:23 +0000 (10:32 -0700)]
SkDefaultColorProfile: Hide gDefaultProfileIsSRGB
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1917443002
Review URL: https://codereview.chromium.org/
1917443002
halcanary [Mon, 25 Apr 2016 17:29:36 +0000 (10:29 -0700)]
SkMD5: .update() -> .write()
Review URL: https://codereview.chromium.org/
1913173003
msarett [Mon, 25 Apr 2016 16:30:24 +0000 (09:30 -0700)]
Remove SkEncodedInfo kUnknown_Color and kUnknown_Alpha from public API
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1918873002
Review URL: https://codereview.chromium.org/
1918873002
halcanary [Mon, 25 Apr 2016 16:25:35 +0000 (09:25 -0700)]
SkStringPrintf and SkString::printf now are no longer limted by a static buffer
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1403803002
Committed: https://skia.googlesource.com/skia/+/
606cadd5aac62299ef2e277709b3684cae2bf96c
Review URL: https://codereview.chromium.org/
1403803002
reed [Mon, 25 Apr 2016 16:25:15 +0000 (09:25 -0700)]
simplify handle-affine: subclass overrides just describe their leaf behavior
added new test case (that would have failed before) of blur with a colorfilter input
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1915943002
Review URL: https://codereview.chromium.org/
1915943002
herb [Mon, 25 Apr 2016 16:05:14 +0000 (09:05 -0700)]
Whitespace change.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1915073002
Review URL: https://codereview.chromium.org/
1915073002
stephana [Mon, 25 Apr 2016 15:35:04 +0000 (08:35 -0700)]
Whitespace change
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1920893002
TBR=borenet
NOTREECHECKS=true
Review URL: https://codereview.chromium.org/
1920893002
benjaminwagner [Mon, 25 Apr 2016 14:33:19 +0000 (07:33 -0700)]
Revert of Call SkGraphics::Init() automatically for Google3 processes. (patchset #1 id:1 of https://codereview.chromium.org/
1906813002/ )
Reason for revert:
Fixed in a different way in internal cl/
120632580.
Original issue's description:
> Call SkGraphics::Init() automatically for Google3 processes.
>
> This is logically a partial revert of https://codereview.chromium.org/
1903503002.
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1906813002
>
> Committed: https://skia.googlesource.com/skia/+/
868060602975834c33eb33a937545c6af8ac8395
TBR=mtklein@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=skia:
Review URL: https://codereview.chromium.org/
1916793002
msarett [Mon, 25 Apr 2016 14:04:58 +0000 (07:04 -0700)]
Fix kSubset_Mode tests on non-native swizzles
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1918813002
Review URL: https://codereview.chromium.org/
1918813002
stephana [Mon, 25 Apr 2016 14:01:22 +0000 (07:01 -0700)]
Revert of Batch multiple single NVPR draw paths to instanced draws (patchset #5 id:80001 of https://codereview.chromium.org/
1908433002/ )
Reason for revert:
This causes what looks like significantly wrong results. Here is an example:
https://gold.skia.org/diff?test=stroke-fill&left=
cb47dc2cabbad7d146aedaac199ebace&top=
2c6e65d597c574e3bb170a19ca9634c6
Original issue's description:
> Batch multiple single NVPR draw paths to instanced draws
>
> Batch multiple single NVPR draw paths to instanced draws.
> A draw path batch can be combined to other batch if the
> batches do not overlap and have same draw characteristics.
>
> Join the batches in linked list and flatten the list to a
> path list during draw time.
>
> Replace GrPathRendering::drawPath with GrPathRendering::drawPaths.
>
> Perf changes ARM, Shield TV device, Tegra X1 GPU:
> desk_chalkboard.skp_1 21.5ms -> 17.8ms 0.83x
> desk_mapsvg.skp_1 7.49ms -> 6.18ms 0.82x
> Others results are more volatile.
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1908433002
>
> Committed: https://skia.googlesource.com/skia/+/
3c33c389e9f8d14d86756ea1ddeba2097f31ad22
TBR=joshualitt@chromium.org,bsalomon@google.com,kkinnunen@nvidia.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/
1919843002