Geoff Kizer [Fri, 8 Feb 2019 00:21:04 +0000 (16:21 -0800)]
Merge pull request dotnet/corefx#34630 from geoffkizer/http2tests
HTTP2: Modify HTTP2 tests to run against platform handlers as well
Commit migrated from https://github.com/dotnet/corefx/commit/
073bf4793f49e46f3a07e865b82045724ccc3641
Tanner Gooding [Thu, 7 Feb 2019 23:00:35 +0000 (15:00 -0800)]
Upgrading Roslyn to 3.0.0-beta2-final (dotnet/corefx#35134)
* Upgrading Roslyn to 3.0.0-beta2-final
* Updating the dotnet sdk to 2.2.103
* Fixing a netcoreapp reference in ref/System.Threading.Channels
Commit migrated from https://github.com/dotnet/corefx/commit/
c2bbb6a5ee5ff67e5e8353e154d7b4c4f2f83143
Krzysztof Wicher [Thu, 7 Feb 2019 18:41:44 +0000 (10:41 -0800)]
Fix casing of files to get closer to ./build.sh -allConfiguration working on linux (dotnet/corefx#35085)
* Rename directories to use CamelCasing
* Fix CsProj files to match file names and their casing
* fix couple of Compile items which were not in csproj file
Commit migrated from https://github.com/dotnet/corefx/commit/
8c5260061b11323dfd97fbab614d54402405513f
matejskubic [Thu, 7 Feb 2019 18:36:36 +0000 (19:36 +0100)]
Process.Close check for null before using variable (dotnet/corefx#32792)
* Process.Close check for null before using
Fix when Process.Close throws Exception on redirected StandardOutput or StandardError.
Steps to reproduce
process.Start
process.BeginOutputReadLine
process.Start
process.Dispose
* Address PR feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
ff8f3149fc7aa1362b35b15da315646c3bb48dc9
Hugh Bellamy [Thu, 7 Feb 2019 02:14:53 +0000 (02:14 +0000)]
Remove dead code from Composition.Hosting (dotnet/corefx#35131)
Commit migrated from https://github.com/dotnet/corefx/commit/
4d180567e9dc5500006b58480184f0dcfe967c1e
Stephen Toub [Thu, 7 Feb 2019 00:49:16 +0000 (19:49 -0500)]
Fix failing xNodeBuilder tests (dotnet/corefx#35140)
1 of the tests is failing because float.MaxValue.ToString() changed and it had hardcoded the previous value.
4 of the tests failed because it was doing a string comparison on the type name of Encoding.UTF8, which a while ago changed to be a sealed derived type and thus is no longer exactly "System.Text.UTF8Encoding". My only explanation for why these just started failing is that we weren't previously running them? Might have something to do with the lack of a Configurations.props file, which I had to add in order to run the tests locally.
Commit migrated from https://github.com/dotnet/corefx/commit/
a27099da194460992a9b8c098f1b5f07837577e0
Kevin Jones [Wed, 6 Feb 2019 22:55:44 +0000 (17:55 -0500)]
Allow ephemeral CNG keys to be used when signing a CMS.
Commit migrated from https://github.com/dotnet/corefx/commit/
f664e3d68c1699b218b8b94d2208bd0c5c5f678f
Maxim Dobryakov [Wed, 6 Feb 2019 22:04:40 +0000 (01:04 +0300)]
Fix overflow exception in StringParsingHelpers (dotnet/corefx#35098)
* Replace all 'int' fields to 'long' in structures related to 'StringParsingHelpers' class because some parsed values can be great than 'int.MaxValue' (dotnet/corefx#34719)
* Fix type of 'IPGlobalStatisticsTable.DefaultTtl' property
Commit migrated from https://github.com/dotnet/corefx/commit/
2f8f6f1be75ea2cc8132e18de5fe8375006ca36f
Geoff Kizer [Wed, 6 Feb 2019 19:10:02 +0000 (11:10 -0800)]
fix merge issues and some test cleanup
Commit migrated from https://github.com/dotnet/corefx/commit/
340d2ac71afcbb6f9ea220e7549fcf8247995678
Geoff Kizer [Thu, 17 Jan 2019 11:11:35 +0000 (03:11 -0800)]
add basic GOAWAY tests and connection shutdown handling
Commit migrated from https://github.com/dotnet/corefx/commit/
449a47ba2c6dbb568692d554787405dde7d14d8e
Geoff Kizer [Wed, 9 Jan 2019 11:37:45 +0000 (03:37 -0800)]
test fixes for various handlers and some additional tests
Commit migrated from https://github.com/dotnet/corefx/commit/
d1c85401a2d9d727e4f87dab62277d569cbc09c5
dotnet-maestro-bot [Wed, 6 Feb 2019 21:29:41 +0000 (13:29 -0800)]
Update BuildTools, ProjectNTfs, ProjectNTfsTestILC to preview1-03706-01, beta-27406-00, beta-27406-00, respectively (dotnet/corefx#35139)
Commit migrated from https://github.com/dotnet/corefx/commit/
76cc535c26b8783c5c99e81e78ec9ce1b18410b6
Geoff Kizer [Wed, 9 Jan 2019 11:21:24 +0000 (03:21 -0800)]
make HTTP2 tests run for platform handler as well
Commit migrated from https://github.com/dotnet/corefx/commit/
686bf6eb6973713f4845fbb874b53f81ea16e50b
Stephen Toub [Wed, 6 Feb 2019 18:29:12 +0000 (13:29 -0500)]
Add SocketErrorPal mapping for EPERM (dotnet/corefx#35133)
Commit migrated from https://github.com/dotnet/corefx/commit/
470a7ffeb5badcd465f88b3fb1b2444fd2f5c69d
Stephen Toub [Wed, 6 Feb 2019 17:29:07 +0000 (12:29 -0500)]
Merge pull request dotnet/corefx#35069 from dotnet-maestro-bot/master-UpdateDependencies
Update ProjectNTfs, ProjectNTfsTestILC to beta-27406-00, beta-27405-00, respectively (master)
Commit migrated from https://github.com/dotnet/corefx/commit/
ccc5315d1e99eedc1e5560ef1d225ba136fd2b4f
Jose Perez Rodriguez [Wed, 6 Feb 2019 16:43:54 +0000 (08:43 -0800)]
Removing UAPvNext Assets from OOB packages (dotnet/corefx#35119)
Commit migrated from https://github.com/dotnet/corefx/commit/
c38c10d28e223aeea2f363a6ef0bf4a63d00a776
Dan Moseley [Wed, 6 Feb 2019 15:53:59 +0000 (07:53 -0800)]
Some test fixes (dotnet/corefx#35092)
* Disable Media test on NETFX
* Fix S.R.E for Uapaot
* Disable varargs for PN
* missing method 'AssemblyLoadContext..ctor(bool)
* IO test
* Fix UapAot RuntimeInformation tests
* Set correct tfm for AppDomainTests
* Merge driveonly tests into one
* Revert math
Commit migrated from https://github.com/dotnet/corefx/commit/
0a751af9afe28042a720411925e6e6c55bdc10cc
Hugh Bellamy [Wed, 6 Feb 2019 15:00:06 +0000 (15:00 +0000)]
Add more ComponentModel.Annotations tests (dotnet/corefx#35052)
* Add more ComponentModel.Annotations tests
* Address PR feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
c13a641e12c23c3ac07a78964478a9a4b3137cc2
Filip Navara [Wed, 6 Feb 2019 14:58:10 +0000 (15:58 +0100)]
Test more invalid values for ThreadPool.[Unsafe]RegisterWaitForSingleObject (dotnet/corefx#34818)
* Test more invalid values for ThreadPool.[Unsafe]RegisterWaitForSingleObject.
* Add checks for argument names in ArgumentOutOfRangeException.
* Disable failing test on NetFX.
Commit migrated from https://github.com/dotnet/corefx/commit/
41948bf0fd29ad5b668f6479ae329c91aeb31f32
Stephen Toub [Wed, 6 Feb 2019 14:55:45 +0000 (09:55 -0500)]
Fix CountdownEvent.Wait to respect underlying event's status (dotnet/corefx#35024)
A common pattern with CountdownEvent is:
```C#
ce.Reset(count);
.. // launch count operations that'll all call ce.Signal()
ce.Wait();
```
and to use that repeatedly. Reset is explicitly not a thread-safe operation, but in a pattern like this, it should be acceptable as long as the only operations signaling the event are those launched here, since Wait should only return when they've all completed. However, CountdownEvent.Wait is currently checking CountdownEvent.IsSet, which returns true if the count has reached 0, and the CountdownEvent.Signal method first decrements the count and the sets the underlying event if it reaches 0. That means there's a window where the count is 0 but the event hasn't been set, which means if Wait is called in that window, it could return successfully even though an operation is still in flight invoking Signal, which then in turn is problematic as that could race with a subsequent call to Reset.
This fixes that by checking this._event.IsSet instead of this.IsSet.
Commit migrated from https://github.com/dotnet/corefx/commit/
66403fb0e4c9e3c05e23db23c04742b8a50dbe0a
Stephen Toub [Wed, 6 Feb 2019 04:13:26 +0000 (23:13 -0500)]
Finish removing Environment from corefx
Commit migrated from https://github.com/dotnet/corefx/commit/
5d43b70e75fc9419d9a39ca7d8f4e7143c74b235
Hugh Bellamy [Wed, 6 Feb 2019 03:43:14 +0000 (03:43 +0000)]
Cleanup ObjectModel code (dotnet/corefx#35047)
* Cleanup ObjectModel code
* Improve parameter names
Commit migrated from https://github.com/dotnet/corefx/commit/
bab7da282613120288759dd7b7d3ff7d42dc00cf
dotnet-maestro-bot [Wed, 6 Feb 2019 03:12:41 +0000 (19:12 -0800)]
Update ProjectNTfs, ProjectNTfsTestILC to beta-27405-00, beta-27405-00, respectively
Commit migrated from https://github.com/dotnet/corefx/commit/
9cce85f7f2001b79f0fa3f9f4bf38e67b4ec25e2
Hugh Bellamy [Wed, 6 Feb 2019 03:34:50 +0000 (03:34 +0000)]
Increase Serialization.Primitives coverage (dotnet/corefx#35101)
Commit migrated from https://github.com/dotnet/corefx/commit/
e7a6ae6df547cb48112e8df712db7c0252871e13
George Stocker [Wed, 6 Feb 2019 03:33:52 +0000 (22:33 -0500)]
Fixed Initialized misspelling on unit tests (dotnet/corefx#35108)
Commit migrated from https://github.com/dotnet/corefx/commit/
382183fa612bfdce65fb8a837e4a89b8d80d0966
Santiago Fernandez Madero [Wed, 6 Feb 2019 00:43:28 +0000 (16:43 -0800)]
Add build batching for official builds (dotnet/corefx#35122)
Commit migrated from https://github.com/dotnet/corefx/commit/
55d782a76e3021b7979b91198d78145d6399be54
Jose Perez Rodriguez [Wed, 6 Feb 2019 00:18:14 +0000 (16:18 -0800)]
Adding readme to source package and changing the nested file path. (dotnet/corefx#35089)
* Adding readme to source package and changing the nested file path.
* Address feedback and add README.md to None
* Adding new class to descriptions.json
Commit migrated from https://github.com/dotnet/corefx/commit/
92eda9e19a886cbf7f8c7e97680df42a3ca1a2be
Afsaneh Rafighi [Tue, 5 Feb 2019 22:54:02 +0000 (14:54 -0800)]
Merge pull request dotnet/corefx#34880 from Wraith2/sqlfeature-getfieldvaluexml
SqlClient enhancement enable GetFieldValue<XmlReader>
Commit migrated from https://github.com/dotnet/corefx/commit/
9007057ab6ba649c67dbca2a422d997075404e6c
Tomas Weinfurt [Tue, 5 Feb 2019 22:39:38 +0000 (14:39 -0800)]
remove instrumentation and move unreliable tests to Outerloop (dotnet/corefx#35113)
Commit migrated from https://github.com/dotnet/corefx/commit/
da8f7ea039030dea3f5808df0ee90d0e206af4e2
Jeremy Barton [Tue, 5 Feb 2019 21:59:08 +0000 (13:59 -0800)]
Restore the Linux X509Certificates tests to 0 SafeX509Handle finalizations
Since the last drive down to zero finalizations (ensuring no platform-induced ones) a few have slipped back in. This caused unnecessary distraction while
investigating a different problem.
This also leaves the "print a stack trace during finalization" code in place for DEBUG builds, behind an environment variable check (cached at type load).
Commit migrated from https://github.com/dotnet/corefx/commit/
5012dfe0813bf9f3eaf7a6460671e07ea048fd52
Hugh Bellamy [Tue, 5 Feb 2019 10:06:01 +0000 (10:06 +0000)]
Add more System.Json tests and remove dead xunit workarounds (dotnet/corefx#35057)
* Add more Json tests and remove old xunit workarounds
* Move files to the right place
* Fix tests
Commit migrated from https://github.com/dotnet/corefx/commit/
53b8e52dbf12355ce845230f6bbe6c5425bb73e6
Hugh Bellamy [Tue, 5 Feb 2019 00:00:19 +0000 (00:00 +0000)]
Cleanup doc comments in ComponentModel.Primitives (dotnet/corefx#35056)
* Cleanup doc comments in ComponentModel.Primitives
* Pr feedback, remove incorrect comment
Commit migrated from https://github.com/dotnet/corefx/commit/
53a33cf2662ac8c9a45d13067012d80cf0ba6956
Tanner Gooding [Mon, 4 Feb 2019 23:53:03 +0000 (15:53 -0800)]
Adding some tests for double/float roundtripping. (dotnet/corefx#35083)
Commit migrated from https://github.com/dotnet/corefx/commit/
404af492722040b61cc9268cdc6f2d5fc76699b8
Viktor Hofer [Mon, 4 Feb 2019 23:52:11 +0000 (00:52 +0100)]
Fix uapaot binaryformatter tests (dotnet/corefx#35079)
Commit migrated from https://github.com/dotnet/corefx/commit/
61a8b5b02aa88772d2a73d643cfeb20bf3715458
Hugh Bellamy [Mon, 4 Feb 2019 14:55:42 +0000 (14:55 +0000)]
Increase code coverage of System.ComponentModel.Primitives to 100% (dotnet/corefx#35055)
* Increase code coverage of System.ComponentModel.Primitives to 100%
* Move files to right folder
Commit migrated from https://github.com/dotnet/corefx/commit/
81c116a55d8788f563a8e02c21c9388bdf681647
dotnet-maestro[bot] [Sun, 3 Feb 2019 16:38:37 +0000 (16:38 +0000)]
Update dependencies from dotnet/coreclr (dotnet/corefx#35051)
* Update dependencies from https://github.com/dotnet/coreclr build
20190201.72
This change updates the following dependencies
- Microsoft.NET.Sdk.IL - 3.0.0-preview-27401-72
- Microsoft.NETCore.ILAsm - 3.0.0-preview-27401-72
- Microsoft.NETCore.Runtime.CoreCLR - 3.0.0-preview-27401-72
* Update dependencies from https://github.com/dotnet/coreclr build
20190202.72
This change updates the following dependencies
- Microsoft.NET.Sdk.IL - 3.0.0-preview-27402-72
- Microsoft.NETCore.ILAsm - 3.0.0-preview-27402-72
- Microsoft.NETCore.Runtime.CoreCLR - 3.0.0-preview-27402-72
* Fixing various tests that have new behavior due to the string formatting changes for double/float.
Commit migrated from https://github.com/dotnet/corefx/commit/
ebf1c9753ab5624c967b0dbd352b1e73805b1fe5
Filip Navara [Sun, 3 Feb 2019 01:35:39 +0000 (02:35 +0100)]
Move Interop.GetTimestamp.cs to shared CoreLib partition. (dotnet/corefx#35031)
Commit migrated from https://github.com/dotnet/corefx/commit/
c28f9c24d236d4d254d8299897e981ccf6492431
dotnet-maestro-bot [Sat, 2 Feb 2019 06:49:37 +0000 (22:49 -0800)]
Update ProjectNTfs, ProjectNTfsTestILC to beta-27401-00, beta-27401-00, respectively
Commit migrated from https://github.com/dotnet/corefx/commit/
c8da75f0b3fa5742d4aa9b4456be8cc9f4835511
Jan Kotas [Sat, 2 Feb 2019 08:09:09 +0000 (00:09 -0800)]
Cleanup security permission and resource consumption attribute references (dotnet/corefx#35042)
Commit migrated from https://github.com/dotnet/corefx/commit/
2c2e4a599889652ec579a870054b0f8915ea70fd
Ben Gribaudo [Sat, 2 Feb 2019 01:09:16 +0000 (19:09 -0600)]
Adding Kill(bool entireProcessTree) -- terminates a process tree (dotnet/corefx#34147)
* Adding Kill(bool entireProcessTree)
* Slightly cleaning up NtQueryInformationProcess interop code
* Trimming down PROCESSINFOCLASS enum members
* Refactoring--adjusting indents, changing param from ref to out, etc.
* Revising NtQueryInformationProcess-related code
* Comment & indentation tweaks
* TryGetParentProcessId -> GetParentProcessId rename/refactoring -- includes eliminating the output parameter
* Removing UAP double-definition of KillTree()
* Moving code so that not included in Uap build & tests so that not included in Uap and NetFx builds
* Moving relevant code from Windows -> Win32
* Moving relevant code from Windows -> Win32
* Working to satisfy contract for Uap (code written to fail test to verify that it works)
* Typo fix (missing return signature)
* Removing unneeded Uap-specific test file
* Adding temp. test to verify that UAP CI is catching test failures.
* Using lists (vs. enumerables) as test assert arguments
* Giving Kill() a moment to take effect
* Removing whitespace
* Removing irrelevant comment
* Revising initial check that ensures process has started.
* Moving process tree creation outside of finally
* Adding retry logic to tests
* Adjusting retry times/delay
* Adding backoff to retry helper
* Introducing non-auto-dispose variant of CreateProcess; refactoring
* Improving exception handling
* Moving catch
* Minor refactoring/reformatting
* Testing test execution by CI
* Partially removing code testing CI system
* Experimenting with implementing on OSX
* Adding cast
* Re-adding [ActiveIssue] attribute accidentally removed
* Re-adding inadvertently-removed commented-out test attributes
* Allowing aggregated Win32Exceptions to propagate out; disallowing calling Kill(true) on tree containing caller
* Adjusting test attributes, removing CI verification test, adjusting expected exception
* Marking non-local process test as platform-specific
* Adding PlatformNotSupported throw for Uap.
* Adding missing closing XML tag
* XML doc tag tweak
* Cleaning up two merge artifacts (whitespace + comment)
* Adding console output for debugging
* Fixing typo
* Removing logging to console
* Removing unused parameter
* Unix & OSX exception tweaks
* Variable rename
* Whitespace tweak
* Refactoring IsInTreeOf to use @danmosemsft's optimization suggestion; Renaming method
* Missed a rename
* Tweaking
* Reworking IsSelfOrDescendant to use refactored GetChildProcesses
* Minor fix
* Applying minor tweaks suggested by @krwq
* Adding a delay safety cutoff to RetryWithBackoff per
@krwq's suggestion.
* Adjusting backoff delay max to 10 seconds.
* IsSelfOrDescendant -> IsSelfOrDescendantOf
* Unix: If Stop() fails, don't try to continue with the process (thanks @tmds!).
* Fixing typo.
* Adding comments about kill/stop returning before termination/stopping completes.
* Adding comment.
Commit migrated from https://github.com/dotnet/corefx/commit/
81bd671efda5db20fae1eb381aeff2cf8ea727ac
Hugh Bellamy [Sat, 2 Feb 2019 00:00:18 +0000 (00:00 +0000)]
Add TypeConverterAttribute tests and fix bugs (dotnet/corefx#35019)
Commit migrated from https://github.com/dotnet/corefx/commit/
93ecfc6e1e5646328b85e113409de7797774fb97
Santiago Fernandez Madero [Fri, 1 Feb 2019 23:50:55 +0000 (15:50 -0800)]
Filter symbols by shipping and non-shipping for BAR metadata (dotnet/corefx#35028)
Commit migrated from https://github.com/dotnet/corefx/commit/
75a42d467d617b04cd4c0daae8ff185cb82bc73b
Stephen Toub [Fri, 1 Feb 2019 19:57:35 +0000 (14:57 -0500)]
Remove stale warning 420 pragmas (dotnet/corefx#35023)
It used to be that the CS0420 warning ("a reference to a volatile field will not be treated as volatile") would fire when a volatile was used with an Interlocked.* operation. That warning was unnecessary, as Interlocked.* would itself provide the relevant barriers, and these functions were special cased in Roslyn a long time ago. But there are still lots of places where pragmas disabling the warning have stuck around. I'm deleting them.
Commit migrated from https://github.com/dotnet/corefx/commit/
8b3446f4e8ad1a7b19c7298e20396629c6e0092e
Santiago Fernandez Madero [Fri, 1 Feb 2019 19:25:46 +0000 (11:25 -0800)]
Move corefx dependencies to itself to consume from BAR (dotnet/corefx#34981)
Commit migrated from https://github.com/dotnet/corefx/commit/
38c9269a1152be6f5b157f78b1d95c4bb1997127
dotnet-maestro-bot [Fri, 1 Feb 2019 18:07:37 +0000 (10:07 -0800)]
Update CoreFx, ProjectNTfs, ProjectNTfsTestILC to preview.19101.1, beta-27401-00, beta-27401-00, respectively (dotnet/corefx#35015)
Commit migrated from https://github.com/dotnet/corefx/commit/
bd3cb6968320e3f2fc0397036e7420e774e1b558
Filip Navara [Fri, 1 Feb 2019 12:52:54 +0000 (13:52 +0100)]
Fix time conversion in SystemNative_GetCpuUtilization (dotnet/corefx#35017)
Commit migrated from https://github.com/dotnet/corefx/commit/
0d41c895ff6e3094e1e8105a9bb6b4cf3d985bd7
David Shulman [Fri, 1 Feb 2019 01:31:03 +0000 (17:31 -0800)]
Enable TLS channel binding token for NTLM authentication on Linux (dotnet/corefx#34998)
This PR adds support for passing in the computed TLS channel binding
token (cbt) into the gssapi during NTLM authentication. This included
removing the code that threw the PlatformNotSupported exception.
No new tests were added to this PR since it requires machine changes
to test. However, I manually tested various combinations of NTLM
authentication including when the server requires (or NOT) the cbt
to be used. Currently only Windows Servers uses this functionality
as part of the "Extended Protection for Authentication" feature.
CurlHandler does not support using the cbt during NTLM authentication.
This is a problem with libcurl itself.
As part of this PR I removed a redundant assert and refactored the
SecChannelBindings structure into src/Common.
Fixes dotnet/corefx#34879
Commit migrated from https://github.com/dotnet/corefx/commit/
6575de65608c95717b2a032b689adae32378778f
Caesar Chen [Thu, 31 Jan 2019 23:55:40 +0000 (15:55 -0800)]
Diable System.Net.Http.FunctionalTests parallel execution on UAP run (dotnet/corefx#35004)
* diable parallel execution
* fix format....
* address feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
5543097d8b6039dedffdcd8b8e713de38e5a1ece
dotnet-maestro-bot [Thu, 31 Jan 2019 23:37:13 +0000 (15:37 -0800)]
Update CoreFx to preview.19081.2 (dotnet/corefx#35005)
Commit migrated from https://github.com/dotnet/corefx/commit/
154e8eaad6b79393af8ac9745c7f49c92cfbbf7a
Stephen Toub [Thu, 31 Jan 2019 20:28:35 +0000 (15:28 -0500)]
Re-enable disabled DecimalTestData (dotnet/corefx#34975)
Commit migrated from https://github.com/dotnet/corefx/commit/
6e56a8fa5e237e5d9789a08918bf22d0fde4d785
Eric StJohn [Thu, 31 Jan 2019 20:07:42 +0000 (12:07 -0800)]
Refactor pre-test targets (dotnet/corefx#34973)
* Refactor pre-test targets
Moves pre-testing targets to their own project that builds after others, rather than as targets in dirs.proj.
Use the GenerateTestSharedFrameworkDepsFile from the CoreFxTesting package rather than from buildtools.
* Manually update Arcade to latest
Commit migrated from https://github.com/dotnet/corefx/commit/
f1336fa043309e587dee5e3d59ee04249ddff97b
dotnet-maestro-bot [Thu, 31 Jan 2019 17:10:21 +0000 (09:10 -0800)]
Update CoreFx, ProjectNTfs, ProjectNTfsTestILC to preview.19081.1, beta-27331-00, beta-27331-00, respectively (dotnet/corefx#34978)
Commit migrated from https://github.com/dotnet/corefx/commit/
e849d7a98d8137a0d0d325f7c610b36c3903250f
Stephen Toub [Thu, 31 Jan 2019 17:09:58 +0000 (12:09 -0500)]
Mirror changes from dotnet/coreclr (dotnet/corefx#34987)
* Reverting "Fixing up the UTF8Formatter and some tests to properly handle -0.0" (dotnet/corefx#22300)
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
* Add managed implementation of GetSystemMaxDBCSCharSize (dotnet/corefx#22290)
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Commit migrated from https://github.com/dotnet/corefx/commit/
35a2040b73969b0d69a3cc0d358eb91c5238de26
Santiago Fernandez Madero [Thu, 31 Jan 2019 17:09:37 +0000 (09:09 -0800)]
Manual darc update for arcade and coreclr (dotnet/corefx#34977)
* Remove target to print MCUrl now that helix sdk always prints it
* Run darc update for dotnet/arcade
* Run darc update for dotnet\coreclr
* Fix build after Environment pushed down to coreclr
Commit migrated from https://github.com/dotnet/corefx/commit/
28c46ef8a123864178c099580b7eb3c8eda3f495
Stephen Toub [Thu, 31 Jan 2019 15:21:30 +0000 (10:21 -0500)]
Expose/test IAsyncDisposable.ConfigureAwait (dotnet/corefx#34783)
Commit migrated from https://github.com/dotnet/corefx/commit/
e6939de2997edf49444ac2c12ad22d5d5f6dea89
Stephen Toub [Wed, 30 Jan 2019 22:01:42 +0000 (17:01 -0500)]
Fix build break due to 'W'
Commit migrated from https://github.com/dotnet/corefx/commit/
94e9d02ad70b2224d012ac4a66eaa1f913ae4f29
Stephen Toub [Thu, 31 Jan 2019 14:46:39 +0000 (09:46 -0500)]
Fix several related inheritability bugs on Unix (dotnet/corefx#34967)
- AnonymousPipeServerStream accepts a HandleInheritability value. When it's set to None, both ends of the pipe are correctly created as O_CLOEXEC to prevent them from being inherited. However, when it's set to Inheritable, we're not marking either end of the pipe as O_CLOEXEC, which means both file descriptors are inherited by the child process. While technically that meets the letter of the law as to what the API requires, in the 99.9% use case the server handle really isn't intended to be inherited, and rather it's only the client handle that is; by allowing the server handle to also be inherited, when the server closes its end of the pipe, the client doesn't get an EOF or broken pipe, because it still has its dup of the file descriptor open, and will for the lifetime of the process. The fix is to always mark the server file descriptor as O_CLOEXEC even if the inheritability is set to Inheritable.
- NamedPipeServer/ClientStream is built on Socket. Previously, sockets defaulted to being inheritable, but we changed that for .NET Core 3.0, such that they're now not inherited. But the pipe code was written expecting the default of Inheritable, and has an if block that says "if inheritability requested was not inheritable, then set O_CLOEXEC"; that now needs to be flipped to say "if inheritability was requested, clear O_CLOEXEC".
- MemoryMappedFile has a similar issue. It tries to use shm_open to create the backing store, but shm_open defaults to having O_CLOEXEC set, and so if Inheritabile was requested, we're neglecting to clear the O_CLOEXEC flag.
Commit migrated from https://github.com/dotnet/corefx/commit/
e5d6c6fc20e72c9d5ba3214f99c25f418bcff0a0
Santiago Fernandez Madero [Thu, 31 Jan 2019 14:28:37 +0000 (06:28 -0800)]
Bring back hooks to AddRuntimeProjectReference from buildtools (dotnet/corefx#34979)
Commit migrated from https://github.com/dotnet/corefx/commit/
38b2d1d4e298a717d99adadcfb0803a8e2a0b04f
Stephen Toub [Thu, 31 Jan 2019 14:26:38 +0000 (09:26 -0500)]
Add test for new CancellationTokenSource(0) (dotnet/corefx#34832)
Validate correct behavior when a CTS is constructed to be immediately canceled via a 0 timeout.
Commit migrated from https://github.com/dotnet/corefx/commit/
fdf1d66f37cc09e2b9de05eadcaa14c9dd5fb223
dotnet-maestro-bot [Thu, 31 Jan 2019 04:31:22 +0000 (20:31 -0800)]
Update CoreFx, CoreFxOptimizationData to preview.19080.4, master-
20190130.3, respectively (dotnet/corefx#34971)
Commit migrated from https://github.com/dotnet/corefx/commit/
4e7ce8acfae39beab8c30053d3da95417b5a16dc
Stephen Toub [Thu, 31 Jan 2019 01:05:49 +0000 (20:05 -0500)]
Merge pull request dotnet/corefx#34956 from dotnet/darc-master-
53aad4d1-974a-49c0-b59b-
ba0be0d0481f
Update dependencies from dotnet/coreclr
Commit migrated from https://github.com/dotnet/corefx/commit/
9e074e4a3f3626fa953f36ab79e3cd3e6db1c9de
Aaron Robinson [Thu, 31 Jan 2019 01:03:40 +0000 (17:03 -0800)]
Handle the case where the Marshal.ThrowExceptionForHR is inlined in (dotnet/corefx#34968)
the test assembly and the Source isn't corlib.
Commit migrated from https://github.com/dotnet/corefx/commit/
09bac5feb0e4c2a015102e021536a031b8d10ef4
Stephen Toub [Wed, 30 Jan 2019 23:03:01 +0000 (18:03 -0500)]
Merge branch 'master' into darc-master-
53aad4d1-974a-49c0-b59b-
ba0be0d0481f
Commit migrated from https://github.com/dotnet/corefx/commit/
601b264612cdba4f4a1896324eaf5e34807c9113
Stephen Toub [Wed, 30 Jan 2019 22:46:23 +0000 (17:46 -0500)]
Disable decimal tests that'll fail until an updated coreclr arrives
Commit migrated from https://github.com/dotnet/corefx/commit/
709f3ab1178df667e10b3929d19c2dcf49da7c15
William Godbe [Wed, 30 Jan 2019 22:42:24 +0000 (14:42 -0800)]
Merge pull request dotnet/corefx#34796 from wtgodbe/ApiCompatNS21
Run APICompat for netstandard2.1 vs netcoreapp3.0
Commit migrated from https://github.com/dotnet/corefx/commit/
ee57e77c81a18ced855685f519b521e6a34d9821
Sung Yoon Whang [Wed, 30 Jan 2019 21:45:22 +0000 (13:45 -0800)]
some misc typos and wording fixes in eventcounter tutorial (dotnet/corefx#34960)
Commit migrated from https://github.com/dotnet/corefx/commit/
7cbda74a0bbee1321c6966891bca6c7aba520aef
Max Kerr [Wed, 30 Jan 2019 21:40:28 +0000 (13:40 -0800)]
Improve handling of HTTP/2 frames received on closed stream (dotnet/corefx#34629)
* Basic support for GoAway frames.
* Review feedback.
* Remove go-away frame handling, add testing to ensure that the loopback server closes the connection instead.
* Remove comma.
* Change error code to reflect the actual failure mode.
* Correct swapped error codes.
Commit migrated from https://github.com/dotnet/corefx/commit/
47f6404357832466585f06d5c9ee07ed2f7a27a4
Eric StJohn [Wed, 30 Jan 2019 21:04:45 +0000 (13:04 -0800)]
Remove UpdateVSConfigurations (dotnet/corefx#34952)
* Update Microsoft.DotNet.Build.Tasks.Configuration to build
20190129.6
* Use UpdateVSConfigurations from arcade
Commit migrated from https://github.com/dotnet/corefx/commit/
d0997060a80f41d4c03c0f8cc2b8ce5ac40ec941
Tomas Weinfurt [Wed, 30 Jan 2019 20:58:02 +0000 (12:58 -0800)]
add Fact attribute instead of removed ConditionalFact (dotnet/corefx#34962)
Commit migrated from https://github.com/dotnet/corefx/commit/
dfd25d13a9d0f5f86d3964eb5bf6b33b7b22a3cc
wtgodbe [Wed, 30 Jan 2019 20:46:50 +0000 (12:46 -0800)]
Update comment
Commit migrated from https://github.com/dotnet/corefx/commit/
4fc403006af495aa8c66f528998703473c51e854
wtgodbe [Fri, 25 Jan 2019 00:00:58 +0000 (16:00 -0800)]
Update baseline files
Commit migrated from https://github.com/dotnet/corefx/commit/
5f251504a1a523bed7f81d6aff86fbc2a8409aeb
wtgodbe [Fri, 18 Jan 2019 00:01:06 +0000 (16:01 -0800)]
Run APICompat for netstandard2.1 vs netcoreapp3.0
Commit migrated from https://github.com/dotnet/corefx/commit/
c05b1971dc2e554522218810f663f534b75934e6
Santiago Fernandez Madero [Wed, 30 Jan 2019 18:24:09 +0000 (10:24 -0800)]
Enable tests for UAPAOT x86 and x64 official builds (dotnet/corefx#34940)
* Enable tests for UAPAOT x86 and x64 official builds
* Manually update CoreFxTesting package
Commit migrated from https://github.com/dotnet/corefx/commit/
9e9bc17c701860ceb80525ea50aee9e08a7173a8
Jan Kotas [Wed, 30 Jan 2019 17:55:14 +0000 (09:55 -0800)]
Fix link to interop-pinvokes.md
Commit migrated from https://github.com/dotnet/corefx/commit/
c5118d8a571b75b6333893b7be8d4a0c77dedd1e
Stephen Toub [Wed, 30 Jan 2019 17:53:04 +0000 (12:53 -0500)]
Temporarily give System.Runtime.Extensions its own Environment.* copy (dotnet/corefx#34951)
The files were moved to shared to propagate them to coreclr. But changes being made in coreclr are going to break System.Runtime.Extensions when the files mirror back. As a temporary stop-gap, I'm creating local copies of the files and taking System.Runtime.Environment off of the shared copies. Then once coreclr builds with the updates and corefx consumes the updated coreclr, we'll just delete these temporary copies and remove the relevant entries entirely from System.Runtime.Extensions.
Commit migrated from https://github.com/dotnet/corefx/commit/
2f6536eb0a2f6ac246f99382d0235dffd75eb1c4
dotnet-maestro-bot [Wed, 30 Jan 2019 14:20:08 +0000 (06:20 -0800)]
Update CoreFx, ProjectNTfs, ProjectNTfsTestILC to preview.19079.11, beta-27330-00, beta-27330-00, respectively (dotnet/corefx#34936)
Commit migrated from https://github.com/dotnet/corefx/commit/
f30910f1bf38f0caaefcd443072b025cfe2c7293
Marco Rossignoli [Wed, 30 Jan 2019 12:48:28 +0000 (13:48 +0100)]
Flow Thread.CurrentPrincipal with ExecutionContext (dotnet/corefx#34747)
* flow Thread.CurrentPrincipal with ExecutionContext
* fix netfx test
* address PR feedback
* address PR feedback
* try to make test more reliable using StartNew(), removed from NetFramework
* address PR feedback
* nit: extraline
* add null set test
* nit: extraline, again...
* rename test
* apply Stephen fix
* nit: typos
* address PR feedback
* nit: update comment
Commit migrated from https://github.com/dotnet/corefx/commit/
bab35ecc6f3f94215705d109d5094c1b3c461992
Meir Blachman [Wed, 30 Jan 2019 12:45:32 +0000 (14:45 +0200)]
removed project-priorities link from docs readme (dotnet/corefx#34945)
Commit migrated from https://github.com/dotnet/corefx/commit/
d02107dcf324fb52312add364d743b1a15d1e7ff
Ahson Khan [Wed, 30 Jan 2019 12:43:02 +0000 (04:43 -0800)]
Seed the porting guide for going from Json.NET to System.Text.Json. (dotnet/corefx#34944)
* Seed the porting guide for going from Json.NET to System.Text.Json.
* Fix heading capitalization.
Commit migrated from https://github.com/dotnet/corefx/commit/
aa9b7c2632ae07b68c109b051faf35ea38491c63
Tomas Weinfurt [Wed, 30 Jan 2019 03:14:29 +0000 (19:14 -0800)]
add instrumentation for intermittent DNS failures (dotnet/corefx#34934)
* add instrumentation for dotnet/corefx#32797
* actually retry the lookup
* use PlatformID.Unix
Commit migrated from https://github.com/dotnet/corefx/commit/
673fe7880790e79549266cea25a385af82917b6e
Santiago Fernandez Madero [Wed, 30 Jan 2019 02:12:48 +0000 (18:12 -0800)]
Change helix queues for package testing to be RS4 (dotnet/corefx#34911)
Commit migrated from https://github.com/dotnet/corefx/commit/
9df66573b5b80362b21103d44bc87c40042e9662
Afsaneh Rafighi [Wed, 30 Jan 2019 02:04:50 +0000 (18:04 -0800)]
update area owners (dotnet/corefx#34939)
Commit migrated from https://github.com/dotnet/corefx/commit/
50a05b377cc9c4e1082de132955740d80a713b87
Maryam Ariyan [Wed, 30 Jan 2019 00:42:13 +0000 (16:42 -0800)]
Add System.Reflection.Emit.DynamicILInfo (dotnet/corefx#34532)
Commit migrated from https://github.com/dotnet/corefx/commit/
5f177b6dce0724f3a2a2c114ba9df86987f13002
Viktor Hofer [Tue, 29 Jan 2019 19:00:25 +0000 (20:00 +0100)]
Restore missing xunit package in aot builds (dotnet/corefx#34923)
* Include missing xunit package for aot builds
* remove obsolete condition
Commit migrated from https://github.com/dotnet/corefx/commit/
a8218c53907e01109a5bbf7d8d6ef741040b41ec
Viktor Hofer [Tue, 29 Jan 2019 16:43:01 +0000 (17:43 +0100)]
Make global tools work with helix (dotnet/corefx#34913)
* Make global tools work with helix
* Add runtime dependencies as target inputs
Commit migrated from https://github.com/dotnet/corefx/commit/
409c4b936defb81c09c0ed41fa3881200be14af1
Santiago Fernandez Madero [Tue, 29 Jan 2019 14:07:28 +0000 (06:07 -0800)]
Add outerloop legs in new CI definitions (dotnet/corefx#34871)
* Add outerloop legs in new CI definitions
* Add Linux Debug matrix to outerloop testing
Commit migrated from https://github.com/dotnet/corefx/commit/
bfc29eda3da9e9dfb5f31708ce57f0c6a74d7816
dotnet-maestro-bot [Tue, 29 Jan 2019 14:04:25 +0000 (06:04 -0800)]
Update CoreFx, ProjectNTfs, ProjectNTfsTestILC to preview.19078.4, beta-27329-00, beta-27329-00, respectively (dotnet/corefx#34916)
Commit migrated from https://github.com/dotnet/corefx/commit/
6cb6d133d2ad8f62720753739131d3fd2570e4b3
Marco Rossignoli [Tue, 29 Jan 2019 03:55:08 +0000 (04:55 +0100)]
Add Helix definition to guide (dotnet/corefx#34888)
* add Helix definition
* move to glossary.md
* address PR feedback
* add Azure DevOps guide
* Nits
Commit migrated from https://github.com/dotnet/corefx/commit/
ddea95ce4e99c09cf48f132c17a68b70cf98a625
Austin Wise [Tue, 29 Jan 2019 02:24:56 +0000 (18:24 -0800)]
Correct link to example review (dotnet/corefx#34914)
Commit migrated from https://github.com/dotnet/corefx/commit/
3574c12100a719d767bfabf69b52c2be290a99a3
dotnet-maestro-bot [Tue, 29 Jan 2019 01:18:34 +0000 (17:18 -0800)]
Update CoreFx, ProjectNTfs, ProjectNTfsTestILC to preview.19078.2, beta-27328-00, beta-27328-00, respectively (dotnet/corefx#34907)
Commit migrated from https://github.com/dotnet/corefx/commit/
be21a3ec9a40a17bffdeda27747463daf997b212
Viktor Hofer [Mon, 28 Jan 2019 23:27:52 +0000 (00:27 +0100)]
Bump UAPTools version (dotnet/corefx#34819)
Commit migrated from https://github.com/dotnet/corefx/commit/
fcc3a911fde8cdde9ab02d2d258909e82fdd123a
Eric StJohn [Mon, 28 Jan 2019 22:18:49 +0000 (14:18 -0800)]
Remove buildtools imports from Directory.Build.* (dotnet/corefx#34001)
* Remove buildtools imports from Directory.Build.*
Remove buildtools imports and implement remaining functionality in CoreFx.
I was able to do most of what BuildTools was doing with 3 exceptions, which will be split into separate issues.
1. Test shared framework deps file: GenerateDepsJson. We need to port this task to arcade or change how we test to not need it.
2. codeOptimization.targets -> should be moved to arcade, work is pending.
3. optionalTooling.targets -> move to a CSProj that is restored by the official build workflow.
* Address feedack, fix unix and UAP build issues
* Fix UWP, Tizen, and AllConfigurations build
* Remove buildtools dependency from package testing
* Remove a few more buildtools dependencies
* Eliminate RunningOnUnix property
* Remove NuGetTargetMoniker from shims.proj
* Remove ResourcesFolderPath
* Fix Microsoft.XmlSerializer.Generator.Tests
* Specify NuGetTargetMoniker for shims
* Remove a couple remaining ToolsDir uses
Commit migrated from https://github.com/dotnet/corefx/commit/
49d249fa023e8575dba7e35febb4446e4fa13f98
Viktor Hofer [Mon, 28 Jan 2019 19:40:35 +0000 (20:40 +0100)]
Disable coverage status checks for project and patch (dotnet/corefx#34901)
Commit migrated from https://github.com/dotnet/corefx/commit/
f70e98cb00b30184e26976b46573a8a7cbaddced
Stephen Toub [Mon, 28 Jan 2019 19:24:56 +0000 (14:24 -0500)]
Add IAsyncDisposable implementations to refs (dotnet/corefx#34898)
Apparently when I added the DisposeAsync methods to the refs, I didn't actually mark the corresponding types as implementing the interface. This fixes that.
Commit migrated from https://github.com/dotnet/corefx/commit/
672d6b0145fca5ac5ef99ea2b9f661e45470ea73
Viktor Hofer [Mon, 28 Jan 2019 14:15:01 +0000 (15:15 +0100)]
Add codecov yml configuration (dotnet/corefx#34896)
Commit migrated from https://github.com/dotnet/corefx/commit/
88d519be4dcda815b906ec0ff654d7ae0452e84e
David Shulman [Sun, 27 Jan 2019 23:41:53 +0000 (15:41 -0800)]
Fix GSSAPI error handling (dotnet/corefx#34883)
This PR addresses 3 issues in GSSAPI error handling:
* Fixes an uninitialized variable when calling gss_display_status().
This was causing the major statuscode error message to always return
'An invalid status code was supplied'.
* If the minor statuscode is 0 (GSS_S_COMPLETE), we shouldn't be calling
for the minor statuscode error message text. That is why we were always getting
'Unknown error' for that text.
* Added more text (help text) to certain errors returned from GSSAPI
such as when the NTLM plugin is not installed.
No new tests were added to this PR since it requires machine changes
to test. However, I manually tested various combinations of errors
including when 'gss-ntlmssp' is installed or not.
In terms of dotnet/corefx#34877, the exception message goes from:
>GSSAPI operation failed with error - An invalid status code was supplied (Unknown error).
to
>GSSAPI operation failed with error - An unsupported mechanism was requested. NTLM authentication requires the GSSAPI plugin 'gss-ntlmssp'.
Fixes dotnet/corefx#34877
Commit migrated from https://github.com/dotnet/corefx/commit/
eec001d96a68376c0e504eb7635c8edec196f90f
Wraith2 [Sat, 26 Jan 2019 22:14:30 +0000 (22:14 +0000)]
add GetFieldValueAsync test cases
Commit migrated from https://github.com/dotnet/corefx/commit/
eeb6139173c18af0b4c14a34fcc4745644a11b57
Wraith2 [Sat, 26 Jan 2019 22:12:30 +0000 (22:12 +0000)]
change GetFieldValueFromSqlBufferInternal<T> to check for XmlReader
add SqlTypeWorkarounds xml reader creation overload for TextReader
add DataStream test for GetFielvdValue<XmlReader> for value and null
Commit migrated from https://github.com/dotnet/corefx/commit/
b4792140f978c102e9c104db6972d41646d12c98
Maryam Ariyan [Sat, 26 Jan 2019 14:26:19 +0000 (06:26 -0800)]
Add test using short timeout throws WebException (dotnet/corefx#34856)
* Add test using short timeout throwing WebException
Fixes: dotnet/corefx#34849
* Make test conditional and target internal location
* code cleanup
Commit migrated from https://github.com/dotnet/corefx/commit/
a3df534fca15e6053aab748e020006a5cb3b0d31
Stephen Toub [Sat, 26 Jan 2019 11:26:35 +0000 (06:26 -0500)]
Factor WinRT GetFolderPath into static accessible via reflection (dotnet/corefx#34873)
Commit migrated from https://github.com/dotnet/corefx/commit/
3fc7efd29ce1fbc57c95eb0b82267b2ad0f7e3ff