Ronald S. Bultje [Mon, 14 Jul 2003 17:37:34 +0000 (17:37 +0000)]
Add matroska support to the build tree
Original commit message from CVS:
Add matroska support to the build tree
David Schleef [Mon, 14 Jul 2003 08:36:03 +0000 (08:36 +0000)]
Caps fixes. Change meaning of parameters to "default" size and rate. Minor fixes with timestamps. Added 'YUV9', 'Y...
Original commit message from CVS:
Caps fixes. Change meaning of parameters to "default" size and
rate. Minor fixes with timestamps. Added 'YUV9', 'YVU9', and 'IYU2'
formats.
David Schleef [Mon, 14 Jul 2003 08:32:38 +0000 (08:32 +0000)]
Caps fixes and general cleanup.
Original commit message from CVS:
Caps fixes and general cleanup.
David Schleef [Mon, 14 Jul 2003 08:31:26 +0000 (08:31 +0000)]
Simple replacement for fast, but broken, algorithm. Needs to be refixed.
Original commit message from CVS:
Simple replacement for fast, but broken, algorithm. Needs to be
refixed.
David Schleef [Mon, 14 Jul 2003 08:30:45 +0000 (08:30 +0000)]
Simple replacement for faster, but broken, algorithm. Needs to be refixed.
Original commit message from CVS:
Simple replacement for faster, but broken, algorithm. Needs to be
refixed.
David Schleef [Mon, 14 Jul 2003 08:29:25 +0000 (08:29 +0000)]
Fixes for new caps system
Original commit message from CVS:
Fixes for new caps system
David Schleef [Mon, 14 Jul 2003 08:26:54 +0000 (08:26 +0000)]
Add gst/overlay directory
Original commit message from CVS:
Add gst/overlay directory
Thomas Vander Stichele [Sat, 12 Jul 2003 12:49:14 +0000 (12:49 +0000)]
various spec file and build fixes agogo /me kicks ds in a friendly way
Original commit message from CVS:
various spec file and build fixes agogo
/me kicks ds in a friendly way
Julien Moutte [Sat, 12 Jul 2003 09:18:31 +0000 (09:18 +0000)]
fixing buggy error handling
Original commit message from CVS:
fixing buggy error handling
Benjamin Otte [Wed, 9 Jul 2003 02:07:14 +0000 (02:07 +0000)]
vorbisfile is LGPL (see sources)
Original commit message from CVS:
vorbisfile is LGPL (see sources)
David Schleef [Tue, 8 Jul 2003 07:40:09 +0000 (07:40 +0000)]
Fixes from caps changes
Original commit message from CVS:
Fixes from caps changes
Christian Schaller [Mon, 7 Jul 2003 22:40:55 +0000 (22:40 +0000)]
A big rewrite of the spec file and some ffmpeg disting fixes. The ffmpeg plugin still doesn't build for me, but I thi...
Original commit message from CVS:
A big rewrite of the spec file and some ffmpeg disting fixes. The ffmpeg plugin still doesn't build for me, but I think I am getting close :)
David Schleef [Mon, 7 Jul 2003 00:34:24 +0000 (00:34 +0000)]
/me attempts to fix stuff that BBB apparently never compiled
Original commit message from CVS:
/me attempts to fix stuff that BBB apparently never compiled
Ronald S. Bultje [Sun, 6 Jul 2003 20:49:52 +0000 (20:49 +0000)]
New mimetypes gone into effect today - this commit changes all old mimetypes over to the new mimetypes spec as descri...
Original commit message from CVS:
New mimetypes gone into effect today - this commit changes all old mimetypes over to the new mimetypes spec as described in the previous commit's document. Note: some plugins will break, some pipelines will break, expect HEAD to be broken or at least not 100% working for a few days, but don't forget to report bugs
Ronald S. Bultje [Sun, 6 Jul 2003 15:12:40 +0000 (15:12 +0000)]
Superseeded by vorbisfile
Original commit message from CVS:
Superseeded by vorbisfile
Christian Schaller [Sat, 5 Jul 2003 22:45:39 +0000 (22:45 +0000)]
small disting fix
Original commit message from CVS:
small disting fix
Brian Cameron [Thu, 3 Jul 2003 15:56:49 +0000 (15:56 +0000)]
Now build xvideosink if Xwindows is available, and properly #ifdef the
Original commit message from CVS:
Now build xvideosink if Xwindows is available, and properly #ifdef the
Xv extension code in the xvideosink code.
David Schleef [Thu, 3 Jul 2003 05:28:57 +0000 (05:28 +0000)]
add pango and gtk
Original commit message from CVS:
add pango and gtk
David Schleef [Wed, 2 Jul 2003 08:15:01 +0000 (08:15 +0000)]
add gst/videofilter and ext/pango
Original commit message from CVS:
add gst/videofilter and ext/pango
David Schleef [Wed, 2 Jul 2003 08:08:34 +0000 (08:08 +0000)]
Add a base init function
Original commit message from CVS:
Add a base init function
David Schleef [Wed, 2 Jul 2003 08:07:24 +0000 (08:07 +0000)]
overlays text of the current timestamp
Original commit message from CVS:
overlays text of the current timestamp
David Schleef [Wed, 2 Jul 2003 05:22:47 +0000 (05:22 +0000)]
GstVideofilter abstract class for video filters
Original commit message from CVS:
GstVideofilter abstract class for video filters
David Schleef [Mon, 30 Jun 2003 05:21:09 +0000 (05:21 +0000)]
be more graceful when caps negotiation fails
Original commit message from CVS:
be more graceful when caps negotiation fails
Benjamin Otte [Sun, 29 Jun 2003 19:46:12 +0000 (19:46 +0000)]
compatibility fix for new GST_DEBUG stuff.
Original commit message from CVS:
compatibility fix for new GST_DEBUG stuff.
Includes fixes for missing includes for config.h and unistd.h
I only ensured for plugins I can build that they work, so if some of them are still broken, you gotta fix them yourselves unfortunately.
Ronald S. Bultje [Sat, 28 Jun 2003 06:38:07 +0000 (06:38 +0000)]
Re-add int2float/float2int, someone told me audioconvert handled all this, but it doesn't. oops
Original commit message from CVS:
Re-add int2float/float2int, someone told me audioconvert handled all this, but it doesn't. oops
Ronald S. Bultje [Wed, 25 Jun 2003 19:17:59 +0000 (19:17 +0000)]
Plugins cleanup:
Original commit message from CVS:
Plugins cleanup:
* stereo2mono, mono2stereo, int2float, float2int: replaced by audioconvert.
* stereosplit replaced by oneton.
* vumeter replaced by level (and was broken anyway).
* avifile replaced by ffmpeg.
* mjpegtools duplicates functionality of jpeg. jpeg now works with jpeg-mmx,
too, which makes mjpegtools unneeded.
* allow for jpegmmx instead of jpeg.
* openquicktime replaced by qtdemux and ffmpeg. Broken anyway.
* XMMS is broken and will never be fixed.
* vga is broken and will not be fixed anywhere soon.
* videosink has never worked. If it works, add it back to replace xvideosink.
David Schleef [Wed, 25 Jun 2003 03:19:20 +0000 (03:19 +0000)]
Added gst/realmedia gst/debug and ext/gdk_pixbuf
Original commit message from CVS:
Added gst/realmedia gst/debug and ext/gdk_pixbuf
David Schleef [Wed, 25 Jun 2003 03:18:27 +0000 (03:18 +0000)]
Add gdkpixbuf subdir. Alphabetize a few others.
Original commit message from CVS:
Add gdkpixbuf subdir. Alphabetize a few others.
Ronald S. Bultje [Tue, 17 Jun 2003 11:43:24 +0000 (11:43 +0000)]
New ffmpeg version fixes mpeg decoding segfaults (mpeg1)
Original commit message from CVS:
New ffmpeg version fixes mpeg decoding segfaults (mpeg1)
Andy Wingo [Mon, 16 Jun 2003 14:56:34 +0000 (14:56 +0000)]
caps refcounting fixes for float2int fixed wrt setting of caps on int pad with dynamic number of sink pads in float2i...
Original commit message from CVS:
* caps refcounting fixes for float2int
* fixed wrt setting of caps on int pad with dynamic number of sink pads in float2int
* added libsndfile plugin (currently only the src is implemented) - currently only float output, noninterleaved is implemented
Julien Moutte [Mon, 16 Jun 2003 10:22:39 +0000 (10:22 +0000)]
Fixing indentation
Original commit message from CVS:
Fixing indentation
Benjamin Otte [Sat, 14 Jun 2003 20:10:13 +0000 (20:10 +0000)]
gcc 3.3 and ppc fixes
Original commit message from CVS:
gcc 3.3 and ppc fixes
David Schleef [Fri, 13 Jun 2003 05:38:16 +0000 (05:38 +0000)]
Add videoflip
Original commit message from CVS:
Add videoflip
Thomas Vander Stichele [Wed, 11 Jun 2003 22:39:37 +0000 (22:39 +0000)]
fix object reset
Original commit message from CVS:
fix object reset
Ronald S. Bultje [Wed, 11 Jun 2003 19:42:20 +0000 (19:42 +0000)]
Fix 114948 - adds some autotools magic that makes sure that we only make install ffmpeg if its actually there
Original commit message from CVS:
Fix 114948 - adds some autotools magic that makes sure that we only make install ffmpeg if its actually there
David Schleef [Wed, 11 Jun 2003 06:14:29 +0000 (06:14 +0000)]
Fix test for qcamsrc: only works on i386-linux. Fix assignment of GST_CVS
Original commit message from CVS:
Fix test for qcamsrc: only works on i386-linux. Fix assignment of GST_CVS
Ronald S. Bultje [Tue, 10 Jun 2003 16:22:41 +0000 (16:22 +0000)]
Backport of #109069
Original commit message from CVS:
Backport of #109069
David Schleef [Tue, 10 Jun 2003 06:32:59 +0000 (06:32 +0000)]
fix: width is in bytes, not bits. Remove incorrect assertion.
Original commit message from CVS:
fix: width is in bytes, not bits. Remove incorrect assertion.
Ronald S. Bultje [Sun, 8 Jun 2003 13:55:42 +0000 (13:55 +0000)]
Fix some weirdities in the man page, see #114060
Original commit message from CVS:
Fix some weirdities in the man page, see #114060
Thomas Vander Stichele [Sat, 7 Jun 2003 22:28:39 +0000 (22:28 +0000)]
warn on state change failures
Original commit message from CVS:
warn on state change failures
Ronald S. Bultje [Sat, 7 Jun 2003 00:17:51 +0000 (00:17 +0000)]
Remove NEW_MEDIA from plugins
Original commit message from CVS:
Remove NEW_MEDIA from plugins
Ronald S. Bultje [Sun, 1 Jun 2003 20:55:38 +0000 (20:55 +0000)]
Add some bugreport about spider+v4lsrc to TODO list (aka testing this CIA commit bot)
Original commit message from CVS:
Add some bugreport about spider+v4lsrc to TODO list (aka testing this CIA commit bot)
Julien Moutte [Sun, 1 Jun 2003 11:43:08 +0000 (11:43 +0000)]
Fixing error message when a plugin is missing (gst-player -> libgstplay).
Original commit message from CVS:
Fixing error message when a plugin is missing (gst-player -> libgstplay).
Pipeline state change on error is now done directly in error callback, there's still something weird with oss /dev/dsp ressource busy error.
Wim Taymans [Sun, 1 Jun 2003 08:34:23 +0000 (08:34 +0000)]
fix negotiation error handling
Original commit message from CVS:
fix negotiation error handling
Julien Moutte [Fri, 30 May 2003 22:36:19 +0000 (22:36 +0000)]
Error handling is inside and works :)
Original commit message from CVS:
Error handling is inside and works :)
Mutexes have been removed. That should fix UI responsiveness problems on query_length. Please heavily test to check if they were really needed.
Some fixes in GClosures
Ronald S. Bultje [Fri, 30 May 2003 21:44:52 +0000 (21:44 +0000)]
Update plugins to newest divx.com release API (5.2) (why aren't these libs API stable?!?)
Original commit message from CVS:
Update plugins to newest divx.com release API (5.2) (why aren't these libs API stable?!?)
Colin Walters [Fri, 30 May 2003 21:42:03 +0000 (21:42 +0000)]
Don't set the mime type.
Original commit message from CVS:
Don't set the mime type.
Thomas Vander Stichele [Fri, 30 May 2003 10:53:14 +0000 (10:53 +0000)]
pkgconfig checks for mad, audiofile, fix for mcopidl
Original commit message from CVS:
pkgconfig checks for mad, audiofile, fix for mcopidl
Ronald S. Bultje [Thu, 29 May 2003 19:33:58 +0000 (19:33 +0000)]
Use new ffmpeg revision
Original commit message from CVS:
Use new ffmpeg revision
Thomas Vander Stichele [Thu, 29 May 2003 17:00:55 +0000 (17:00 +0000)]
don't warn on recoverable problems
Original commit message from CVS:
don't warn on recoverable problems
Ronald S. Bultje [Thu, 29 May 2003 14:35:23 +0000 (14:35 +0000)]
I'm too lazy to comment this
Original commit message from CVS:
New dxr3 plugins from Martin Soto <soto@informatik.uni-kl.de>
Wim Taymans [Thu, 29 May 2003 13:17:17 +0000 (13:17 +0000)]
- small cleanups
Original commit message from CVS:
- small cleanups
- fix DURATION field
Wim Taymans [Thu, 29 May 2003 13:02:16 +0000 (13:02 +0000)]
- small cleanups
Original commit message from CVS:
- small cleanups
- fix offset
- added blocksize property
Thomas Vander Stichele [Wed, 28 May 2003 16:06:00 +0000 (16:06 +0000)]
I'm too lazy to comment this
Original commit message from CVS:
*** empty log message ***
David Schleef [Wed, 28 May 2003 06:25:39 +0000 (06:25 +0000)]
GST_FORMAT_UNITS -> GST_FORMAT_DEFAULT conversion
Original commit message from CVS:
GST_FORMAT_UNITS -> GST_FORMAT_DEFAULT conversion
Wim Taymans [Sat, 24 May 2003 10:51:02 +0000 (10:51 +0000)]
- removed UNITS
Original commit message from CVS:
- removed UNITS
Wim Taymans [Sat, 24 May 2003 10:46:31 +0000 (10:46 +0000)]
- UNITS -> DEFAULT
Original commit message from CVS:
- UNITS -> DEFAULT
Wim Taymans [Sat, 24 May 2003 10:41:58 +0000 (10:41 +0000)]
UNITS -> DEFAULT
Original commit message from CVS:
UNITS -> DEFAULT
Wim Taymans [Sat, 24 May 2003 10:31:38 +0000 (10:31 +0000)]
removed UNITS
Original commit message from CVS:
removed UNITS
Wim Taymans [Sat, 24 May 2003 10:18:38 +0000 (10:18 +0000)]
- return result of parent state change too
Original commit message from CVS:
- return result of parent state change too
Benjamin Otte [Thu, 22 May 2003 20:45:09 +0000 (20:45 +0000)]
fix Makefiles for C++ libraries. They should now work with Forte. This needs a new libtool, update autogen.sh to refl...
Original commit message from CVS:
fix Makefiles for C++ libraries. They should now work with Forte. This needs a new libtool, update autogen.sh to reflect this.
Brian Cameron [Thu, 22 May 2003 10:03:31 +0000 (10:03 +0000)]
This ISO_VARARGS macro is more consistant with the others.
Original commit message from CVS:
This ISO_VARARGS macro is more consistant with the others.
David Schleef [Wed, 21 May 2003 19:56:30 +0000 (19:56 +0000)]
gsize != gint on some platforms. Fix.
Original commit message from CVS:
gsize != gint on some platforms. Fix.
Brian Cameron [Wed, 21 May 2003 18:16:30 +0000 (18:16 +0000)]
Corrected the configure.ac so it actually works. Updated some c files so that they build on Solaris. This mostly in...
Original commit message from CVS:
Corrected the configure.ac so it actually works. Updated some c files
so that they build on Solaris. This mostly involved supporting ISO
style variable-argument macros.
Brian Cameron [Wed, 21 May 2003 15:16:51 +0000 (15:16 +0000)]
Updated autogen.sh/configure.ac and various Makefiles to make the configure script set up all gcc specific compiler a...
Original commit message from CVS:
Updated autogen.sh/configure.ac and various Makefiles to make the
configure script set up all gcc specific compiler arguments, rather
than hardcoding them in the Makefile.am files
David Schleef [Wed, 21 May 2003 07:47:28 +0000 (07:47 +0000)]
Links also against libgstcontrol
Original commit message from CVS:
Links also against libgstcontrol
Ronald S. Bultje [Wed, 21 May 2003 06:33:18 +0000 (06:33 +0000)]
Some final fixes for the v4lsrc elements. remove software sync thread (use GST_ELEMENT_THREAD_SUGGESTED instead) make...
Original commit message from CVS:
Some final fixes for the v4lsrc elements.
* remove software sync thread (use GST_ELEMENT_THREAD_SUGGESTED instead)
* make all src elements threadsafe
* fix num_buffer argument setting in v4l2src (VIDIOC_S_PARM)
* re-add bufsize (RO) for v4lmjpegsrc
* fix the A/V sync calculation in all elements (spvf=GST_SECOND/fps, not GST_SECOND*fps)
* probably some more crap....
With all this, it actually works quite well. The TODO files describes the
next steps in order to make a full-featured video recorder based on these
elements and GStreamer (bottom). Making a simple recorder should be fairly
easy now, btw.
David Schleef [Mon, 19 May 2003 21:55:11 +0000 (21:55 +0000)]
remove creation of makefile in nonexistent (sys/x11) directory
Original commit message from CVS:
remove creation of makefile in nonexistent (sys/x11) directory
Jeremy Simon [Mon, 19 May 2003 18:36:53 +0000 (18:36 +0000)]
update libflac check
Original commit message from CVS:
update libflac check
David Schleef [Sun, 18 May 2003 23:20:24 +0000 (23:20 +0000)]
Add sync parameter
Original commit message from CVS:
Add sync parameter
Benjamin Otte [Sat, 17 May 2003 20:39:34 +0000 (20:39 +0000)]
make filtered connections actually work. Remove a leftover g_print
Original commit message from CVS:
make filtered connections actually work. Remove a leftover g_print
Benjamin Otte [Thu, 15 May 2003 16:32:22 +0000 (16:32 +0000)]
next big bunch of stuff:
Original commit message from CVS:
next big bunch of stuff:
- proper caps setting in alsasrc
- query / conversion functions
WARNING: Alsa 0.9.2 is heavily borked wrt recording - expect segfaults
Ronald S. Bultje [Wed, 14 May 2003 19:54:37 +0000 (19:54 +0000)]
Un-globalize variable
Original commit message from CVS:
Un-globalize variable
David Schleef [Wed, 14 May 2003 18:43:36 +0000 (18:43 +0000)]
Fix issues with invalid fourcc parameters.
Original commit message from CVS:
Fix issues with invalid fourcc parameters.
Benjamin Otte [Wed, 14 May 2003 00:05:29 +0000 (00:05 +0000)]
fixed gst-launch-ext to use new pipelines (bug 111108)
Original commit message from CVS:
fixed gst-launch-ext to use new pipelines (bug 111108)
David Schleef [Tue, 13 May 2003 07:14:36 +0000 (07:14 +0000)]
code cleanup. Changed g_print to GST_DEBUG(). Fixed RGB caps to work with 0.6.
Original commit message from CVS:
code cleanup. Changed g_print to GST_DEBUG(). Fixed RGB caps to
work with 0.6.
Benjamin Otte [Mon, 12 May 2003 16:31:31 +0000 (16:31 +0000)]
make error signal use the right types
Original commit message from CVS:
make error signal use the right types
Benjamin Otte [Mon, 12 May 2003 16:25:26 +0000 (16:25 +0000)]
uh, maybe putting new signals before LAST_SIGNAL might help against memory corruption?
Original commit message from CVS:
uh, maybe putting new signals before LAST_SIGNAL might help against memory corruption?
Thomas Vander Stichele [Mon, 12 May 2003 15:08:49 +0000 (15:08 +0000)]
fixes 107967
Original commit message from CVS:
fixes 107967
Christian Schaller [Mon, 12 May 2003 13:17:11 +0000 (13:17 +0000)]
Some bugfixes:
Original commit message from CVS:
Some bugfixes:
- Add missing .h file to videoscale disting
- Remove http plugin from build
Thomas Vander Stichele [Sat, 10 May 2003 17:37:27 +0000 (17:37 +0000)]
fixes #112711
Original commit message from CVS:
fixes #112711
Ronald S. Bultje [Sat, 10 May 2003 14:36:34 +0000 (14:36 +0000)]
This implements filtered-caps negotiation for all the v4l*src elements, and removes the accompanying properties since...
Original commit message from CVS:
This implements filtered-caps negotiation for all the v4l*src elements, and removes the accompanying properties since they're no longer needed
Benjamin Otte [Sat, 10 May 2003 11:37:35 +0000 (11:37 +0000)]
be parent of own clock
Original commit message from CVS:
be parent of own clock
David Schleef [Fri, 9 May 2003 18:36:50 +0000 (18:36 +0000)]
Change .p2align to .align for non-gas assemblers. (Fixes: #112608)
Original commit message from CVS:
Change .p2align to .align for non-gas assemblers. (Fixes: #112608)
David Schleef [Fri, 9 May 2003 08:09:38 +0000 (08:09 +0000)]
remove bashisms
Original commit message from CVS:
remove bashisms
Julien Moutte [Tue, 6 May 2003 22:22:39 +0000 (22:22 +0000)]
deep-notify can come from pads too, replacing GstElement by GstObject.
Original commit message from CVS:
deep-notify can come from pads too, replacing GstElement by GstObject.
Ronald S. Bultje [Fri, 2 May 2003 21:16:55 +0000 (21:16 +0000)]
Implement element synchronization (#108301)
Original commit message from CVS:
Implement element synchronization (#108301)
Ronald S. Bultje [Fri, 2 May 2003 20:36:55 +0000 (20:36 +0000)]
Fix compile error because of unused functions
Original commit message from CVS:
Fix compile error because of unused functions
Ronald S. Bultje [Fri, 2 May 2003 20:13:08 +0000 (20:13 +0000)]
Gcc < 3.0 fix
Original commit message from CVS:
Gcc < 3.0 fix
David Schleef [Thu, 1 May 2003 06:24:34 +0000 (06:24 +0000)]
restore wtay's clocking changes in 1.17->1.18
Original commit message from CVS:
restore wtay's clocking changes in 1.17->1.18
Benjamin Otte [Tue, 29 Apr 2003 21:51:10 +0000 (21:51 +0000)]
bugfixes:
Original commit message from CVS:
bugfixes:
- better error reporting
- segfault when using alsasrc without alsasink (d'oh)
- don't try to round when doing samples => time conversion
Julien Moutte [Mon, 28 Apr 2003 10:52:29 +0000 (10:52 +0000)]
Make vis_video_thread play when connected afterwards
Original commit message from CVS:
Make vis_video_thread play when connected afterwards
This generates some segfaults in gst_thread but we need to fix that
Thomas Vander Stichele [Sun, 27 Apr 2003 15:20:07 +0000 (15:20 +0000)]
more uninstalled fixes
Original commit message from CVS:
more uninstalled fixes
Thomas Vander Stichele [Sun, 27 Apr 2003 14:22:01 +0000 (14:22 +0000)]
more uninstalled fixes
Original commit message from CVS:
more uninstalled fixes
Thomas Vander Stichele [Sun, 27 Apr 2003 11:34:56 +0000 (11:34 +0000)]
uninstalled pkgconfig fixes
Original commit message from CVS:
uninstalled pkgconfig fixes
Steve Baker [Sun, 27 Apr 2003 06:12:29 +0000 (06:12 +0000)]
ignore .pc files
Original commit message from CVS:
ignore .pc files
Benjamin Otte [Thu, 24 Apr 2003 22:58:33 +0000 (22:58 +0000)]
alsasrc works now, but it still uses hardcoded caps
Original commit message from CVS:
alsasrc works now, but it still uses hardcoded caps
Benjamin Otte [Thu, 24 Apr 2003 20:31:20 +0000 (20:31 +0000)]
fix segfault when --gst-mask=-1 is enabled
Original commit message from CVS:
fix segfault when --gst-mask=-1 is enabled
Benjamin Otte [Thu, 24 Apr 2003 18:56:47 +0000 (18:56 +0000)]
We're not at EOS after a successfull seek (fixes #111498)
Original commit message from CVS:
We're not at EOS after a successfull seek (fixes #111498)
Benjamin Otte [Thu, 24 Apr 2003 00:03:06 +0000 (00:03 +0000)]
total code reorganization as a start to get alsasrc working - sink and src are now really different classes, not just...
Original commit message from CVS:
total code reorganization as a start to get alsasrc working - sink and src are now really different classes, not just on paper - includes a fix that makes the testsuite work that might be an older bug