dotnet-maestro-bot [Fri, 16 Feb 2018 05:35:06 +0000 (23:35 -0600)]
Update BuildTools, CoreFx to preview2-02516-02, preview2-26216-01, respectively (dotnet/corefx#27186)
Commit migrated from https://github.com/dotnet/corefx/commit/
808a63a56e11d8c03c4551e738f76510c65dd1fc
Paulo Janotti [Fri, 16 Feb 2018 04:00:49 +0000 (20:00 -0800)]
Enforce ILLink AssemblyPath order (dotnet/corefx#27188)
The order of assembly references should take project references first.
Commit migrated from https://github.com/dotnet/corefx/commit/
7c4602eff88e30241f8f07a4ea7146e623045e90
Dan Moseley [Fri, 16 Feb 2018 03:59:23 +0000 (19:59 -0800)]
Log libc version in our "OS info logging test" (dotnet/corefx#27143)
* Glibc logging
* Updates
Commit migrated from https://github.com/dotnet/corefx/commit/
1840df10f8ea2d62ceb2b5ab2c367f4f9e54e6da
Jeremy Kuhne [Fri, 16 Feb 2018 02:45:51 +0000 (18:45 -0800)]
Remove FileSystem unused common files (dotnet/corefx#27184)
Also update .sln using UpdateVSConfigurations
Commit migrated from https://github.com/dotnet/corefx/commit/
7eb6dba62ec630d33db7dcd9e810a937a92d975f
Jeremy Kuhne [Fri, 16 Feb 2018 00:41:51 +0000 (16:41 -0800)]
Change RootDirectory properties to span (dotnet/corefx#27134)
Exposing string restricts the ability to change internals without introducing unnecessary allocations.
Commit migrated from https://github.com/dotnet/corefx/commit/
3ac69e86e0c8e654a9802bf593fdc98ea69a4fb8
dotnet-maestro-bot [Fri, 16 Feb 2018 00:20:07 +0000 (18:20 -0600)]
Update BuildTools to preview2-02515-02 (dotnet/corefx#27175)
Commit migrated from https://github.com/dotnet/corefx/commit/
bda2ef6506e6bd8bd8a839bca3d02d2517e587f4
Viktor Hofer [Thu, 15 Feb 2018 22:32:19 +0000 (23:32 +0100)]
Fix regression & enable ClearInitLocals in System.Text.RegularExpressions (dotnet/corefx#27146)
* Fix bug in RegexWriter ref struct change
* Remove duplicate ValueListBuilder implementation
* Enable ILLinkClearInitLocals
* Rename concrete ValueListBuilder impl to Pop
Commit migrated from https://github.com/dotnet/corefx/commit/
9e0151b48f3a45d497e8835423ed38e7661cd056
Geoff Kizer [Thu, 15 Feb 2018 21:39:32 +0000 (13:39 -0800)]
Merge pull request dotnet/corefx#27151 from geoffkizer/sslproxytunnel
SocketsHttpHandler: refactor pool manager logic to enable SSL proxy tunneling support
Commit migrated from https://github.com/dotnet/corefx/commit/
6e3bcbec17273cd38db67e47e7a2975a25160ac2
Stephen Toub [Thu, 15 Feb 2018 21:04:40 +0000 (16:04 -0500)]
Streamline SocketHttpHandler's ParseStatusLine validation (dotnet/corefx#27163)
* Streamline SocketHttpHandler's ParseStatusLine validation
For a typical status line like "HTTP/1.1 200 OK", cuts the time of ParseStatusLine almost in half.
* Address PR feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
c8d23b4941b3b620633db397a0094f55b01be22b
Jon Hanna [Thu, 15 Feb 2018 20:37:30 +0000 (20:37 +0000)]
Make many helpers, factories and tables static in Microsoft.CSharp (dotnet/corefx#27044)
* Have TypeArray in charge of the empty TypeArray singleton
* Make TypeArray allocation a static responsibility of TypeArray
* Remove some orphaned members.
Mostly BSYMMGR-returning members that had been used to allocate
TypeArrays
* Make members static were possible.
Those that can already be easily made static. Includes removing some
members that this makes no longer necessary.
* Remove unused parameters
Since some are of the types we'll be making static, and such parameters
will have to go anyway.
* Make TypeTable static
And more conventional names within TypeTable.
* More TypeManager state & methods to static
* Make SYMTBL.Key an immutable struct.
* SYMTBL completely static and renamed to SymbolStore
More conventional name, and doesn't clash with other SymbolTable class.
* GetWinRTCollectionIfacesAll to property.
* SymFactory static class.
* Remove PredefinedTypes._symbolManager field
Only used in assertion.
* Remove assert comparison with this in GetAggregate
Assert is the only reason to not be static, allows a cascade of more
changes to static.
* Make InternalsVisibleTo check static.
* Make cycle of instance methods static
Take quite a large set of methods which must be instance because of
cyclic instance dependencies, and make them all static.
Removes dependency in AggregateSymbol and NullableType on TypeManager
instances.
* Replace GetAggTypeSym with virtual method on CType.
Merged with existing GetAts on NullableType. Comment says this would be
nice, and indeed it would, and its easy now.
* Make those members that can now be static, static.
* Remove orphaned members and fields.
* PredefinedMembers entirely static.
* Remove UserStringBuilder.m_buildingInProgress
Only used in asserts, just assert on whether m_strBuilder is null or
not.
Also rename m_strBuilder to _strBuilder to be more conventional.
* Favour returning over out in UserStringBuilder
And favour clearing StringBuilder over creating another.
* Make ErrorHandling completely static.
Creating UserStringBuilder instances on demand.
* TypeManager static.
* Make CNullable methods static and merge directly into ExpressionBinder
Don't cache method and property, as they're already cached.
* Don't preload types.
Either they'll be loaded soon anyway, or else it's a wasted effort.
* Move CompareTypes into Better.cs
* Remove BSYMMGR.LookupAggMember
Just call into SymbolStore.LookupSym
* Move LookupNextSym logic into Symbol
* Remove BSYMMGR and GlobalSymbolContext
No longer any use.
* ExprFactory static
* SymbolLoader static
* CSemanticChecker static
* Don't pre-emptively load System.Object
Will be loaded as a base of the first type encountered anyway.
* SymbolTable static
* More methods can be made static
* Remove orphaned method.
* Move methods for getting MemberInfos from expressions into those expressions
* Replace ExpressionTreeCallRewriter.GetObject with virtual property in Expr
* TypeArray tidy-up.
* Pass ExpressionBinder to operator delegates, and make them static.
Allows array to be created once statically, rather than on each
instance construction.
* Create RuntimeBinder, ExpressionBinder and BindingContext per operation
These are now very lightweight, so it's simpler to create them anew
each time rather than overwriting the values in the BindingContext.
* Make RuntimeBinder, ExpressionBinder and BindingContext structs
No need to allocate on the heap.
* Remove AggregateDeclaration
We only ever care about the AggregateSymbol it relates to.
(The two aren't really separate in dynamic code, where there aren't
really declarations).
* Remove IsChecked and CallingContext from C# binders.
Now not used as they are passed to RuntimeBinder on construction,
except for CallingContext remaining in CSharpInvokeMemberBinder for use
in deferring.
* Make RecordBinOpSigFromArgs static.
A last member that can be made static.
* Make static-member-only classes static.
* Make NameHashKey a readonly struct.
Commit migrated from https://github.com/dotnet/corefx/commit/
b7d1ae93c179510991f75709c3c3c1d3e3d062c1
Stephen Toub [Thu, 15 Feb 2018 19:59:30 +0000 (14:59 -0500)]
Fix race condition in PostAsyncExpect100Continue_RetryOnConnectionClosed_Success test (dotnet/corefx#27148)
Commit migrated from https://github.com/dotnet/corefx/commit/
28799e8af0556efe1b9e5e98b700460951ae9eb2
dotnet-maestro-bot [Thu, 15 Feb 2018 19:25:39 +0000 (13:25 -0600)]
Update BuildTools, CoreClr, CoreFx, ProjectNTfs, ProjectNTfsTestILC to preview2-02515-01, preview2-26214-07, preview2-26215-04, beta-26215-00, beta-26215-00, respectively (dotnet/corefx#27112)
Commit migrated from https://github.com/dotnet/corefx/commit/
42a3e4384f419322bb4ea32a63fda0ff75e3f29d
Jiayi Yu [Thu, 15 Feb 2018 19:08:39 +0000 (11:08 -0800)]
Initialized a bool variable to fix warning (dotnet/corefx#26947)
Commit migrated from https://github.com/dotnet/corefx/commit/
5615f5325cd41e49ba970b3f8bd620d3680cfe90
Geoff Kizer [Thu, 15 Feb 2018 18:55:32 +0000 (10:55 -0800)]
address review feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
46785d3ae61987ae8ae389b2138645e82b54efb0
Jeremy Kuhne [Thu, 15 Feb 2018 18:32:03 +0000 (10:32 -0800)]
Current directory code duplicates Environment (dotnet/corefx#27153)
Just call Environment.CurrentDirectory. Remove a number of P/Invokes
that are no longer in use.
Commit migrated from https://github.com/dotnet/corefx/commit/
8e6222ab2f2b48f20a274272693665dac8259c79
Jon Hanna [Thu, 15 Feb 2018 18:18:00 +0000 (18:18 +0000)]
Remove more orphaned code in Microsoft.CSharp (dotnet/corefx#27104)
* Remove IExprWithObject and ExprWithArgs.OptionalObject
No longer used.
* Remove CLR_PostIncrement/Decrement
Rename CLR_PreIncrement/Decrement to CLR_Increment/Decrement as it
covers both pre- and post- cases.
* Remove Symbol.IsVirtual()
Commit migrated from https://github.com/dotnet/corefx/commit/
0a61a146f78eb396d057eae9734d3f6e335d9a8b
David Fowler [Thu, 15 Feb 2018 18:03:02 +0000 (10:03 -0800)]
Made a few tweaks to pipelines (dotnet/corefx#27158)
* Made a few tweaks to pipelines
- Renamed the file containing the class IDuplexPipe
- Changed the default scheduler to use the ThreadPool if none was specified
Commit migrated from https://github.com/dotnet/corefx/commit/
c2b5a8e3d6339a2c863b1cd48b8663273574fe48
Ben Adams [Thu, 15 Feb 2018 16:10:22 +0000 (16:10 +0000)]
Remove intrinsic from Vector4:op_Division(struct,float) (dotnet/corefx#27122)
* Remove intrinsic from Vector4:op_Division(struct,float)
* feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
820949492d84ed81c6f793e142b54f33cbd65524
Tomas Weinfurt [Thu, 15 Feb 2018 10:47:50 +0000 (02:47 -0800)]
disable two tests on ubuntu 18 while investigating root casue (dotnet/corefx#27144)
Commit migrated from https://github.com/dotnet/corefx/commit/
d00eb7ec42434b0a7e2c3b4f6cd88c896ebaa30f
Jeremy Kuhne [Thu, 15 Feb 2018 06:49:17 +0000 (22:49 -0800)]
Cleaning out dead code (dotnet/corefx#27150)
Also refactor Unix attribute handling a bit to be more consistent and
ensure that we don't make unnecessary addtional filesystem calls.
Commit migrated from https://github.com/dotnet/corefx/commit/
16f26ba855f5cc6d52a738e8bc3856c6f77cf761
Brian Robbins [Thu, 15 Feb 2018 03:48:46 +0000 (19:48 -0800)]
Temporarily Disable EventSource ETW Tests and Revert TraceEvent Package Version (dotnet/corefx#27141)
Commit migrated from https://github.com/dotnet/corefx/commit/
0cf7583bf8d01e5445950b03956b2134402de286
Maryam Ariyan [Thu, 15 Feb 2018 03:20:00 +0000 (22:20 -0500)]
Adding test to verify FileStream.Dispose() ignores IO Related Exception in finalizer (dotnet/corefx#26921)
* Adding test to verify FileStream.Dispose() skips IO Related Exception only on finalization
* Skipping test on netfx because the behavior in netfx is different
Commit migrated from https://github.com/dotnet/corefx/commit/
a15cc53eb5a4248c76bdc60beb3e31628bd8acf8
Maryam Ariyan [Thu, 15 Feb 2018 03:03:22 +0000 (22:03 -0500)]
Fixing fa-IR negative currency format for test GetCurrencyNegativePatterns (dotnet/corefx#27138)
Fixes dotnet/corefx#27022 and dotnet/corefx#27127
Commit migrated from https://github.com/dotnet/corefx/commit/
fe548ac62bdc46785e7e153a5f2a3de15daefd6d
Geoff Kizer [Thu, 15 Feb 2018 02:43:15 +0000 (18:43 -0800)]
add code to establish proxy tunnel for SSL
Commit migrated from https://github.com/dotnet/corefx/commit/
d84a28844502bcf30538a18e30e33118ca879467
Geoff Kizer [Wed, 14 Feb 2018 06:52:20 +0000 (22:52 -0800)]
reorganize pool manager logic and rework HttpConnectionKey to support ssl proxy tunneling
Commit migrated from https://github.com/dotnet/corefx/commit/
39ed24e9f6f55d6077742776e154ead199e1b3a0
Koundinya Veluri [Thu, 15 Feb 2018 00:15:01 +0000 (16:15 -0800)]
Disable a SignalAndWait test so that relevant change in CoreCLR can be brought into CoreFX (dotnet/corefx#27131)
Commit migrated from https://github.com/dotnet/corefx/commit/
6f06dcc32df6939e726d46ca45f8491db7967fb8
Jeremy Kuhne [Thu, 15 Feb 2018 00:06:04 +0000 (16:06 -0800)]
Add some pattern transformation tests (dotnet/corefx#27133)
Commit migrated from https://github.com/dotnet/corefx/commit/
11182e0c4e65fb1e6fa0596ca9d991e3382c9fb2
Viktor Hofer [Thu, 15 Feb 2018 00:02:08 +0000 (01:02 +0100)]
reduce regex op code time (dotnet/corefx#26877)
* reduce regex op code time
* Use ValueListBuilder and stackalloc during op code generation
* Increasing op array size
Commit migrated from https://github.com/dotnet/corefx/commit/
1eb5ddf1d0a3dbc0a221769a45d81d2a2b7fa81d
Tomáš Matoušek [Wed, 14 Feb 2018 23:01:55 +0000 (15:01 -0800)]
Add support for PDB Checksum debug directory entry (dotnet/corefx#26976)
Commit migrated from https://github.com/dotnet/corefx/commit/
6b099e771d3b775b5cd273ec1b6fcec12ee7abbe
Geoff Kizer [Wed, 14 Feb 2018 19:13:34 +0000 (11:13 -0800)]
Merge pull request dotnet/corefx#27088 from geoffkizer/refactorloopbackserver
reorganize and cleanup some LoopbackServer code
Commit migrated from https://github.com/dotnet/corefx/commit/
46267c1dbe46f0127e670ce25933ff49a5ec9d6e
Jeremy Barton [Wed, 14 Feb 2018 15:33:30 +0000 (07:33 -0800)]
Add FixedTimeEquals and other crypto helper routines as public API
Commit migrated from https://github.com/dotnet/corefx/commit/
3872bafe8186a3e74cb66efa4a2835d60ed67ba2
Jeremy Kuhne [Wed, 14 Feb 2018 05:49:57 +0000 (21:49 -0800)]
API tweaks to match latest updates to spec (dotnet/corefx#27102)
* API tweaks to match latest updates to spec
Add a few new tests
See dotnet/corefx#25873
* Properly clear state when enumerating on Unix.
Make sure we don't include special directories in subdir processing. Add test.
Collapse helper that was only called in one place, and remove dead one.
Commit migrated from https://github.com/dotnet/corefx/commit/
1c9cd8118abfa13165d88a4e660fbdcc6c2ebc4c
Brian Robbins [Wed, 14 Feb 2018 04:25:55 +0000 (20:25 -0800)]
Fix and Enable Most ETW EventSource Tests (dotnet/corefx#27107)
Commit migrated from https://github.com/dotnet/corefx/commit/
ad52ae103416ea67e30abf21c19d5d0c0cd01b11
Krzysztof Cwalina [Wed, 14 Feb 2018 00:37:20 +0000 (16:37 -0800)]
Merge pull request dotnet/corefx#27007 from pakrym/pakrym/pipelines
Add System.IO.Pipelines API
Commit migrated from https://github.com/dotnet/corefx/commit/
3c708ab64564304fed352355b52e2ea047860e4d
Geoff Kizer [Wed, 14 Feb 2018 00:03:28 +0000 (16:03 -0800)]
fix tests from merge
Commit migrated from https://github.com/dotnet/corefx/commit/
b028092ce1af45e109edb0609b7b8cef42ee8a99
Geoff Kizer [Tue, 13 Feb 2018 23:03:42 +0000 (15:03 -0800)]
add response generation overloads
Commit migrated from https://github.com/dotnet/corefx/commit/
6943fc7c0e92359e6335a618f6ff5ee8402af4ac
Geoff Kizer [Tue, 13 Feb 2018 21:14:44 +0000 (13:14 -0800)]
address PR feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
6ab005635528a03daa52ca727a4a74dcc0316830
Geoff Kizer [Sun, 11 Feb 2018 22:04:30 +0000 (14:04 -0800)]
reorganize and cleanup some LoopbackServer code
Commit migrated from https://github.com/dotnet/corefx/commit/
ec6a7215bb28a061d2357d8c3874447bc575132d
Caesar Chen [Tue, 13 Feb 2018 23:24:22 +0000 (15:24 -0800)]
Change HTTP default request version to HTTP/2 (dotnet/corefx#27079)
* change http default request version
* fix innerloop test
Commit migrated from https://github.com/dotnet/corefx/commit/
f7a852f64bf20889579be70710f386a8d4802a34
Pavel Krymets [Tue, 13 Feb 2018 22:32:58 +0000 (14:32 -0800)]
More comments
Commit migrated from https://github.com/dotnet/corefx/commit/
17b00a58129e659cf01a1cb6c045c400f8e0c984
Jose Perez Rodriguez [Tue, 13 Feb 2018 22:24:40 +0000 (14:24 -0800)]
Fix test project
Commit migrated from https://github.com/dotnet/corefx/commit/
bb72f2e32593383ec3862d064cc8916ba5c4daa4
Stephen Toub [Tue, 13 Feb 2018 21:30:34 +0000 (16:30 -0500)]
Enable SocketsHttpHandler cancellation support (dotnet/corefx#27029)
* Enable SocketsHttpHandler cancellation support
This change significantly improves the cancellation support in SocketsHttpHandler. Previously we were passing the CancellationToken around to every method, eventually bottoming out in calls to the underlying Stream which then ends up passing them down to the underlying Socket. But today Socket's support for cancellation is minimal, only doing up-front checks; if cancellation is requested during the socket operation rather than before, the request will be ignored. Since HttpClient implements features like timeouts on top of cancellation support, it's important to do better than this.
The change implements cancellation by registering with the CancellationToken to dispose of the connection. This will cause any reads/writes to wake up. We then translate resulting exceptions into cancellation exceptions. When in the main SendAsync method, we register once for the whole body of the operation until the point that we're returning the response message. For individual operations on the response content stream, we register per operation; however, when feasible we try to avoid the registration costs by only registering if operations don't complete synchronously. We also account for the case that on Unix, closing the connection may result in read operations waking up not with an exception but rather with EOF, which we also need to translate into cancellation when appropriate.
Along the way I cleaned up a few minor issues as well.
I also added a bunch of cancellation-related tests:
- Test cancellation occurring while sending request content
- Test cancellation occurring while receiving response headers
- Test cancellation occurring while receiving response body and using a buffered operation
- Test that all of the above are triggerable with CancellationTokenSource.Cancel, HttpClient.CancelPendingRequests, and HttpClient.Dispose
- Test cancellation occurring while receiving response body and using an unbuffered operation, either a ReadAsync or CopyToAsync on the response stream
- Test that a CancelPendingRequests doesn't affect unbuffered operations on the response stream
There are deficiencies here in the existing handlers, and tests have been selectively disabled accordingly (I also fixed a couple cases that naturally fell out of the changes I was making for SocketsHttpHandler). SocketsHttpHandler passes now for all of them.
* Add test that Dispose doesn't cancel response stream
Commit migrated from https://github.com/dotnet/corefx/commit/
53be85c2fe473fdea8c001e3d9fd81dd478b858e
Oswald Maskens [Tue, 13 Feb 2018 21:04:14 +0000 (22:04 +0100)]
Added tests for Microsoft.VisualBasic.CompilerServices.Conversions dotnet/corefx#1… (dotnet/corefx#26744)
* Added tests for Microsoft.VisualBasic.CompilerServices.Conversions dotnet/corefx#14344
* added tests for ToBoolean fro Object
Commit migrated from https://github.com/dotnet/corefx/commit/
c705032f0f4f6e3d34f65cf5660e3c8ea109ad47
dotnet-maestro-bot [Tue, 13 Feb 2018 20:02:54 +0000 (14:02 -0600)]
Update BuildTools, CoreClr, CoreFx to preview2-02513-01, preview2-26213-05, preview2-26213-06, respectively (dotnet/corefx#27093)
Commit migrated from https://github.com/dotnet/corefx/commit/
b9b5b807378f7d17817749288c6b89db9694181a
Tomáš Matoušek [Tue, 13 Feb 2018 19:41:05 +0000 (11:41 -0800)]
Remove 'PDBC' data signature
Commit migrated from https://github.com/dotnet/corefx/commit/
a3647d844791f916dff1053665bbce4574d0b8ee
Jose Perez Rodriguez [Tue, 13 Feb 2018 19:24:31 +0000 (11:24 -0800)]
Fixing pkgproj
Commit migrated from https://github.com/dotnet/corefx/commit/
200bae71172c2aaae4698eb7ab5f14d72d678bea
Eric Erhardt [Fri, 9 Feb 2018 05:02:42 +0000 (21:02 -0800)]
Fix Process Start tests in outerloop on Unix.
Get the real user name in the test process, not the child process. The outerloop tests are run with 'sudo'. Which means by the time we are in the child process SUDO_USER will be set to 'root', since the parent test process was run with 'sudo'.
Fixes dotnet/corefx#26675
Commit migrated from https://github.com/dotnet/corefx/commit/
bca11a079c914ed971b2f300b876f89a920a0398
Pavel Krymets [Tue, 13 Feb 2018 18:39:47 +0000 (10:39 -0800)]
NetCoreapp
Commit migrated from https://github.com/dotnet/corefx/commit/
bb0d1299434fcaeabaecef5c602552cdcbe87359
Pavel Krymets [Tue, 13 Feb 2018 16:46:24 +0000 (08:46 -0800)]
IDuplexPipe
Commit migrated from https://github.com/dotnet/corefx/commit/
82be16bb63124e8113ffb339b3d81c009996f957
Pavel Krymets [Tue, 13 Feb 2018 16:22:58 +0000 (08:22 -0800)]
T
Commit migrated from https://github.com/dotnet/corefx/commit/
792c5cdda0a93f59428e58a1d830dac0c1176e87
Stephen Toub [Tue, 13 Feb 2018 13:38:32 +0000 (08:38 -0500)]
Fix SocketsHttpHandler connection pool accounting for dropped connections (dotnet/corefx#27068)
When MaxConnectionsPerServer is set to anything other than int.MaxValue, the SocketsHttpHandler pool keeps track of the number of connections handed out, and this count is updated when a connection is disposed. But if a response stream isn't disposed of, resulting in the connection never being disposed of, the count may never be updated. This fix adds an HttpConnection derived type that simply adds a finalizer, making it pay-for-play when MaxConnectionsPerServer is set to something other than the default.
Commit migrated from https://github.com/dotnet/corefx/commit/
ffa5db357252913c52e0cdad63c1573020185f6e
Stephen Toub [Tue, 13 Feb 2018 11:30:25 +0000 (06:30 -0500)]
Clear initlocals in a bunch of assemblies (dotnet/corefx#26993)
* Clear initlocals in a bunch of assemblies
Sets
```XML
<ILLinkClearInitLocals>true</ILLinkClearInitLocals>
```
for the assemblies:
- System.IO.FileSystem
- System.IO.Pipes
- System.Memory
- System.Net.Http
- System.Net.Http.WinHttpHandler
- System.Net.NameResolution
- System.Net.NetworkInformation
- System.Net.Primitives
- System.Net.Requests
- System.Net.Security
- System.Net.Sockets
- System.Net.WebSockets
- System.Net.WebSockets.Client
- System.Net.WebSockets.WebSocketsProtocol
- System.Private.Uri
- System.Runtime
- System.Runtime.Extensions
Eventually we'd ideally set the flag for the whole repo; these are just the ones I audited thus far. In a few cases I had to make code changes to adapt, where the code was expecting stackallocs to be cleared. I also looked at a few other projects (System.Collections, System.Runtime.Numerics) where there were more significant dependencies on clearing and I decided to leave those for later.
* Disable ILLinkClearInitLocals running on Unix until it works there
Commit migrated from https://github.com/dotnet/corefx/commit/
f0a032e4a1c8a848574a5db3e69e8a6fa0aae91e
Saurabh Singh [Tue, 13 Feb 2018 09:47:02 +0000 (01:47 -0800)]
Revert Managed SNI usage flag (dotnet/corefx#27089)
Commit migrated from https://github.com/dotnet/corefx/commit/
23709d07c3cb8e5c4be36ffe7f480151becc54b3
Saurabh Singh [Tue, 13 Feb 2018 07:54:59 +0000 (23:54 -0800)]
Workstation Id should be returned correctly (dotnet/corefx#27076)
* Fix workstation Id
* Tests for workstation id
* Add more test cases
Commit migrated from https://github.com/dotnet/corefx/commit/
7425455ace4c7819b786c2f0b42fb630944aeef3
Geoff Kizer [Tue, 13 Feb 2018 07:11:11 +0000 (23:11 -0800)]
Merge pull request dotnet/corefx#27069 from stephentoub/cachessl
Cache SslClientAuthenticationOptions on SocketsHttpHandler pool
Commit migrated from https://github.com/dotnet/corefx/commit/
a438733f09a739bfbd4b9f945ba049386858019a
dotnet-maestro-bot [Tue, 13 Feb 2018 05:58:07 +0000 (23:58 -0600)]
Update ProjectNTfs, ProjectNTfsTestILC to beta-26213-00, beta-26213-00, respectively (dotnet/corefx#27083)
Commit migrated from https://github.com/dotnet/corefx/commit/
73d8163328b17fee3d32ff295b03fab13fdb721e
dotnet-maestro-bot [Tue, 13 Feb 2018 03:59:14 +0000 (21:59 -0600)]
Update CoreClr, CoreFx to preview2-26212-08, preview2-26213-01, respectively (dotnet/corefx#27080)
Commit migrated from https://github.com/dotnet/corefx/commit/
bf5f02752633d92afcb249fe166a81ae84d59c77
Eric Erhardt [Tue, 13 Feb 2018 01:39:17 +0000 (19:39 -0600)]
Lower the default stack buffer size for calling getpwXXX_r methods.
By default, 1K is too large of a buffer to allocate on the stack.
Fixes dotnet/corefx#26959
Commit migrated from https://github.com/dotnet/corefx/commit/
5cbac95f5530695a31a43e7748a4561e3a2dd32d
Pavel Krymets [Mon, 12 Feb 2018 23:48:28 +0000 (15:48 -0800)]
More PR comments
Commit migrated from https://github.com/dotnet/corefx/commit/
1f7f6a2bb900b132689be5926c3fb132d7fe702d
Pavel Krymets [Mon, 12 Feb 2018 23:34:33 +0000 (15:34 -0800)]
PR Comments, temporary undo src crosscompile
Commit migrated from https://github.com/dotnet/corefx/commit/
0cfbb25249dc640059d10120ae044455764cc71a
Jeremy Kuhne [Mon, 12 Feb 2018 21:56:17 +0000 (13:56 -0800)]
Switch from using SafeHandle for Unix enumeration (dotnet/corefx#27052)
* Switch from using SafeHandle for Unix enumeration
* Address feedback
* Fix faceplant, dispose in test.
Commit migrated from https://github.com/dotnet/corefx/commit/
c9100ffc2988a0faf0e92898762a445ccb3c0e13
Pavel Krymets [Mon, 12 Feb 2018 20:49:14 +0000 (12:49 -0800)]
Project changeS
Commit migrated from https://github.com/dotnet/corefx/commit/
2d44625e288fd28ba644c813a9e0d23ecfc95ddb
Pavel Krymets [Mon, 12 Feb 2018 20:35:48 +0000 (12:35 -0800)]
Pipelines RP comments
Commit migrated from https://github.com/dotnet/corefx/commit/
50713cf859900e8116986e80b6d1a1da736645fc
Maryam Ariyan [Mon, 12 Feb 2018 19:35:36 +0000 (14:35 -0500)]
Disable drawing test for distro Ubuntu18.04 (dotnet/corefx#27036)
* Disable drawing test for distro Ubuntu18.04
* Adding a new properties called IsUbuntu1804 and IsUbuntu1710OrHigher in PlatformDetection
Related to dotnet/corefx#27021
Commit migrated from https://github.com/dotnet/corefx/commit/
4b4440b4c0fc280d3a9c09d117a1a6eafbbcb6c2
Max Kerr [Mon, 12 Feb 2018 19:28:09 +0000 (11:28 -0800)]
Clear Authorization Headers on Redirect (dotnet/corefx#26864)
When a user has added an Authorization header to a request via the HttpClient DefaultRequestHeaders Authorization field, ensure that header is stripped on redirect.
This change adds a method to strip Authorization headers that were set via the HttpClient DefaultRequestHeaders Authorization field, and calls that method on redirect. In addition, it adds a test to ensure that this behavior occurs as expected.
The new method ResetAuthRequestHeaders is based on the method ResetCookieRequestHeaders, which is used to reset cookie headers on redirect.
The issue also occurs in CurlHandler, but the fix is slightly different. Rather than remove the headers that have already been set, we can instead just skip them when copying over the new headers to the redirected request.
Fixes dotnet/corefx#26426
Commit migrated from https://github.com/dotnet/corefx/commit/
7e6396b2bcb4d372b199cfb7b3b13e290c441124
Tarek Mahmoud Sayed [Mon, 12 Feb 2018 19:20:55 +0000 (11:20 -0800)]
Fix the throwing exception from ChannelReader.ReadAsync (dotnet/corefx#27070)
Commit migrated from https://github.com/dotnet/corefx/commit/
20d9824ac3f877b2a72dd6a729134e0c5fd960ee
Stephen Toub [Mon, 12 Feb 2018 18:39:02 +0000 (13:39 -0500)]
Fix HttpClientMiniStress.UnreadResponseMessage_Collectible test (dotnet/corefx#27061)
The async state machine was holding a reference to the response content object, which in turn prevented the response stream from being collected.
Commit migrated from https://github.com/dotnet/corefx/commit/
6c9b62981190ae5886196f37d0f5dc614f4b0244
Karel Zikmund [Mon, 12 Feb 2018 17:51:53 +0000 (09:51 -0800)]
Update rename of ManagedHandler to SocketsHttpHandler
Commit migrated from https://github.com/dotnet/corefx/commit/
a07b356e61a0a1d8e2d6d02bcc1e2062fbbd64ae
Stephen Toub [Mon, 12 Feb 2018 17:17:33 +0000 (12:17 -0500)]
Cache SslClientAuthenticationOptions on SocketsHttpHandler pool
For the common case, we can just use a singleton cached instance with settings computed when the pool is created. Only if it's accessed via HttpClientHandler with a server certificate callback do we need to still create an instance per request, in order to wrap the delegate to provide the expected semantics.
Commit migrated from https://github.com/dotnet/corefx/commit/
911d4aff095f1c8648334d4a221c217cd09e466b
dotnet-maestro-bot [Mon, 12 Feb 2018 17:13:52 +0000 (11:13 -0600)]
Update CoreClr, CoreFx to preview2-26212-05, preview2-26212-05, respectively (dotnet/corefx#27060)
Commit migrated from https://github.com/dotnet/corefx/commit/
38ff6d112eee1b93d402521f924d9952bef98ef9
Jon Hanna [Mon, 12 Feb 2018 16:30:14 +0000 (16:30 +0000)]
Allow RangeAttribute use to request InvariantCulture conversions. (dotnet/corefx#25918)
* Allow RangeAttribute use to request InvariantCulture conversions.
Adds a ParseLimitsInInvariantCulture that affects the interpretation of
the extrema set, and ConvertValueInInvariantCulture that affects the
interpretation of values.
Separate methods allows for e.g. a component assuming a
dot-decimal-separator culture defining a property with the attribute
(so invariant culture should be used) the use of the property is done
in a comma-decimal-separator (so the current culture should be used),
or any permutation of the two booleans.
Fixes dotnet/corefx#2648
* Skip NetFX on associated tests.
* Update tests in dotnet/corefx#25918 to work with changes from dotnet/corefx#26050
Commit migrated from https://github.com/dotnet/corefx/commit/
015cf5d9832ed9d6734367c8a2e29dfa8bae4a25
Geoff Kizer [Mon, 12 Feb 2018 12:25:24 +0000 (04:25 -0800)]
fix stress response generation, and disable failing test (dotnet/corefx#27059)
Commit migrated from https://github.com/dotnet/corefx/commit/
472c3d95749910ba600df296bbf01d78d7c4f6d8
dotnet-maestro-bot [Mon, 12 Feb 2018 10:28:43 +0000 (04:28 -0600)]
Update CoreClr, CoreFx, ProjectNTfs, ProjectNTfsTestILC to preview2-26212-01, preview2-26212-01, beta-26212-00, beta-26212-00, respectively (dotnet/corefx#27053)
Commit migrated from https://github.com/dotnet/corefx/commit/
241ea5372d4770a7f596adf272833aa6dd63a289
Stephen Toub [Mon, 12 Feb 2018 10:27:57 +0000 (05:27 -0500)]
Tweak CurlHandler SSL not supported messages to be more helpful (dotnet/corefx#27043)
* Tweak CurlHandler SSL not supported messages to be more helpful
* Address PR feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
9cde3e174b2495cbcdf95995aea0bea4030d4aa9
Dan Moseley [Mon, 12 Feb 2018 03:33:12 +0000 (19:33 -0800)]
Ensure services get removed (dotnet/corefx#27054)
Commit migrated from https://github.com/dotnet/corefx/commit/
744c4cf021c1744082e12caf3e9b8dacf05a671a
Geoff Kizer [Mon, 12 Feb 2018 02:23:50 +0000 (18:23 -0800)]
Merge pull request dotnet/corefx#26989 from geoffkizer/fixcookiehandling
SocketsHttpHandler: Fix some issues with cookie handling, and add cookie tests
Commit migrated from https://github.com/dotnet/corefx/commit/
8cee267154ef9dc6dde7a76a828844a200437872
John Doe [Mon, 12 Feb 2018 00:18:31 +0000 (16:18 -0800)]
acutal -> actual (dotnet/corefx#27050)
Commit migrated from https://github.com/dotnet/corefx/commit/
36a15af564c8359881da9f98a7011a89253c0847
Jeff Cyr [Mon, 12 Feb 2018 00:18:08 +0000 (19:18 -0500)]
Modified Dns.GetHostAddressesAsync to be truly async (dotnet/corefx#26850)
* Modified Dns.GetHostAddressesAsync to be truly async
* Applied code review recommendations
* Unix build fix
* Unix build fix dotnet/corefx#2
* Unix build fix dotnet/corefx#3
* NETFX build fix
* Fixed useGetHostByName logic
* Simplified ProcessResult code
* Cleaned up cancel code
* cleanup
Commit migrated from https://github.com/dotnet/corefx/commit/
d3ff31e3b9e8c7b1e6003196650bae4a658ef889
Geoff Kizer [Sun, 11 Feb 2018 22:49:42 +0000 (14:49 -0800)]
fix tests on netfx
Commit migrated from https://github.com/dotnet/corefx/commit/
c7cc2a879d0a5b5f039caff36bef0c99f52604a2
Geoff Kizer [Sun, 11 Feb 2018 20:38:20 +0000 (12:38 -0800)]
consolidate cookie tests
Commit migrated from https://github.com/dotnet/corefx/commit/
c20262c69a93449498d511014e9e69bad18f987a
dotnet-maestro-bot [Sun, 11 Feb 2018 17:41:34 +0000 (11:41 -0600)]
Update CoreClr, CoreFx to preview2-26211-03, preview2-26211-04, respectively (dotnet/corefx#27041)
Commit migrated from https://github.com/dotnet/corefx/commit/
14185df4430c7f9432ea4654676c7663c5f8957e
Stephen Toub [Sun, 11 Feb 2018 17:19:03 +0000 (12:19 -0500)]
Add SocketsHttpHandler check for TransferEncodingChunked w/o Content (dotnet/corefx#27040)
Commit migrated from https://github.com/dotnet/corefx/commit/
bf5a3183bc901723ebe0bb3d178bec86cda57429
Stephen Toub [Sun, 11 Feb 2018 17:18:33 +0000 (12:18 -0500)]
Fix more new T[0] to be Array.Empty<T>() (dotnet/corefx#27042)
We've done several passes through the repo in the past. More cases have snuck in since then.
Commit migrated from https://github.com/dotnet/corefx/commit/
a127f01141ff4ffe2224da9ff63a1b5233ee5f06
Stephen Toub [Sun, 11 Feb 2018 13:55:26 +0000 (08:55 -0500)]
Fix some license headers across the repo (dotnet/corefx#27039)
Commit migrated from https://github.com/dotnet/corefx/commit/
7f19e761b7400521030707df2e6fac10daa36f26
Stephen Toub [Sun, 11 Feb 2018 10:15:15 +0000 (05:15 -0500)]
Mark {Configured}ValueTaskAwaiter as readonly in contracts (dotnet/corefx#27030)
Commit migrated from https://github.com/dotnet/corefx/commit/
4ff3c791c0eac88d96f135b16fc5425d48e02211
Stephen Toub [Sun, 11 Feb 2018 10:10:13 +0000 (05:10 -0500)]
Add tests for T[] -> ArraySegment<T> cast (dotnet/corefx#27032)
Commit migrated from https://github.com/dotnet/corefx/commit/
d690bb63b15556190fad7e6bb85eb7a4dce69c79
dotnet-maestro-bot [Sun, 11 Feb 2018 08:50:47 +0000 (02:50 -0600)]
Update BuildTools to preview2-02511-02 (dotnet/corefx#27034)
Commit migrated from https://github.com/dotnet/corefx/commit/
f54ee41039db4b84fb5dc58bec4e1dd393fc2d0b
Maryam Ariyan [Sun, 11 Feb 2018 06:46:58 +0000 (01:46 -0500)]
Fixing test CurrencyNegativePattern_Get() on newly added distro Ubuntu18.04 (dotnet/corefx#27035)
From class/project System.Globalization.Tests.NumberFormatInfoCurrencyNegativePattern
Fixes dotnet/corefx#27022
Commit migrated from https://github.com/dotnet/corefx/commit/
8fdf896ebb78fcab5612de7a0ea84518d416d7c7
Dan Moseley [Sun, 11 Feb 2018 03:13:07 +0000 (19:13 -0800)]
Fix TestService shutdown (dotnet/corefx#27028)
Commit migrated from https://github.com/dotnet/corefx/commit/
2af251c3c083817975d76d659069400d98073965
dotnet-maestro-bot [Sun, 11 Feb 2018 02:43:50 +0000 (20:43 -0600)]
Update CoreClr to preview2-26210-06 (dotnet/corefx#27026)
Commit migrated from https://github.com/dotnet/corefx/commit/
530385c33afaf373ae28f5ab49cf5c0d902dda3e
John Doe [Sun, 11 Feb 2018 01:57:33 +0000 (17:57 -0800)]
clasname -> classname (dotnet/corefx#27025)
Commit migrated from https://github.com/dotnet/corefx/commit/
08bcfb4b95ec4be00ce70eb985682aca8aec8fe9
Jeremy Kuhne [Sun, 11 Feb 2018 01:19:49 +0000 (17:19 -0800)]
Fix *Info classes for Unix when opened on root (dotnet/corefx#27024)
Commit migrated from https://github.com/dotnet/corefx/commit/
5349873018e481a2ad8a14bbdd5ff237780f02e3
dotnet-maestro-bot [Sat, 10 Feb 2018 15:27:34 +0000 (09:27 -0600)]
Update CoreClr to preview2-26210-04 (dotnet/corefx#27020)
Commit migrated from https://github.com/dotnet/corefx/commit/
221950b31c1057b040670936519ddbc13f893062
Stephen Toub [Sat, 10 Feb 2018 12:11:12 +0000 (07:11 -0500)]
Add FileStream tests for custom OwnedMemory with Read/WriteAsync (dotnet/corefx#26931)
Commit migrated from https://github.com/dotnet/corefx/commit/
7130581c8bd7114143628679624f7ae29cb56818
Tarek Mahmoud Sayed [Sat, 10 Feb 2018 12:11:03 +0000 (04:11 -0800)]
Add Hebrew Months test (dotnet/corefx#26915)
* Add Hebrew Months test
* add some spaces
Commit migrated from https://github.com/dotnet/corefx/commit/
57ba13cbfa203c8bc5003dd9b3ab4aaa796c22f8
dotnet-maestro-bot [Sat, 10 Feb 2018 04:58:58 +0000 (22:58 -0600)]
Update BuildTools, CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview2-02509-01, preview2-26209-08, preview2-26210-01, preview2-26209-04, beta-26209-02, beta-26209-02, respectively (dotnet/corefx#26940)
Commit migrated from https://github.com/dotnet/corefx/commit/
1fc770a6cbc26dc072a44ee9ae6e6d9af5e61e1c
Jeremy Kuhne [Sat, 10 Feb 2018 04:33:26 +0000 (20:33 -0800)]
Fix Unix enumeration (dotnet/corefx#27019)
For non-trivial recursive enumerations we were running out of file descriptors. Stop creating them when we queue pending subdirectories and only create when we dequeue.
Commit migrated from https://github.com/dotnet/corefx/commit/
430de8f582afb111697dd1e203f5c7a20f46acb2
Saurabh Singh [Sat, 10 Feb 2018 01:57:04 +0000 (17:57 -0800)]
Restrict the Long Running option to MARS (dotnet/corefx#27010)
* Restrict the Long Running option to MARS
* Code review comments
Commit migrated from https://github.com/dotnet/corefx/commit/
8cc3ffbea1da042f4f0ca61ad81e234630434f21
Paulo Janotti [Fri, 9 Feb 2018 23:48:29 +0000 (15:48 -0800)]
Trying to collect info about ping test failures in macOS 10.12 (dotnet/corefx#26997)
See dotnet/corefx#26358
Commit migrated from https://github.com/dotnet/corefx/commit/
7406c4c12ab76df15e0fde191856860eb87166d5
Wes Haggard [Fri, 9 Feb 2018 23:24:18 +0000 (15:24 -0800)]
Update intellisense file drop based on 2-2-2018 doc build (dotnet/corefx#27005)
Commit migrated from https://github.com/dotnet/corefx/commit/
54c80d877e2f90c4973b44db5033f2cb7abf5ce2