platform/upstream/libSkiaSharp.git
11 years agoImplement SSE2-based implementations of the morphology filters (dilate & erode)....
senorblanco@chromium.org [Wed, 30 Oct 2013 21:57:04 +0000 (21:57 +0000)]
Implement SSE2-based implementations of the morphology filters (dilate & erode). This gives a 3-5X speedup over the naive implementation, and also mitigates a timing-based security attack in Chrome (https://code.google.com/p/chromium/issues/detail?id=251711).

NOTE: this will require a corresponding GYP change on the Skia roll into Chrome: https://codereview.chromium.org/52453004/

R=mtklein@google.com, reed@google.com

Review URL: https://codereview.chromium.org/52603004

git-svn-id: http://skia.googlecode.com/svn/trunk@12038 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMake not-reusing-scratch-textures only apply to texture uploads
robertphillips@google.com [Wed, 30 Oct 2013 21:30:43 +0000 (21:30 +0000)]
Make not-reusing-scratch-textures only apply to texture uploads

https://codereview.chromium.org/53133002/

git-svn-id: http://skia.googlecode.com/svn/trunk@12037 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix int/SkScalar mismatch in gm.
vandebo@chromium.org [Wed, 30 Oct 2013 21:29:47 +0000 (21:29 +0000)]
Fix int/SkScalar mismatch in gm.

Review URL: https://codereview.chromium.org/45953005

git-svn-id: http://skia.googlecode.com/svn/trunk@12036 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix int/SkScalar mismatch.
vandebo@chromium.org [Wed, 30 Oct 2013 21:00:47 +0000 (21:00 +0000)]
Fix int/SkScalar mismatch.

Review URL: https://codereview.chromium.org/51043005

git-svn-id: http://skia.googlecode.com/svn/trunk@12035 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years ago[PDF] Improve complex xfer mode support.
vandebo@chromium.org [Wed, 30 Oct 2013 20:48:05 +0000 (20:48 +0000)]
[PDF] Improve complex xfer mode support.

Xfer mode applies only to the shape of the source drawing, not everything in the clip as in currently implemented.  It's just that the current gm examples draw a shape that fills the visible layer.

R=edisonn@google.com, reed@google.com

Review URL: https://codereview.appspot.com/4631078

git-svn-id: http://skia.googlecode.com/svn/trunk@12034 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoDM: add --rtree.
commit-bot@chromium.org [Wed, 30 Oct 2013 20:45:28 +0000 (20:45 +0000)]
DM: add --rtree.

BUG=
R=epoger@google.com

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/51243003

git-svn-id: http://skia.googlecode.com/svn/trunk@12033 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoDon't check if shaders compile or program links in release Chromium
commit-bot@chromium.org [Wed, 30 Oct 2013 20:03:16 +0000 (20:03 +0000)]
Don't check if shaders compile or program links in release Chromium

R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/52843003

git-svn-id: http://skia.googlecode.com/svn/trunk@12032 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoExclude verylargebitmap test from replay modes on windows.
commit-bot@chromium.org [Wed, 30 Oct 2013 18:58:03 +0000 (18:58 +0000)]
Exclude verylargebitmap test from replay modes on windows.

BUG=skia:1756
R=epoger@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/52903003

git-svn-id: http://skia.googlecode.com/svn/trunk@12030 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoUse SkPathRef gen id for SkPath::getGenerationID
commit-bot@chromium.org [Wed, 30 Oct 2013 18:57:55 +0000 (18:57 +0000)]
Use SkPathRef gen id for SkPath::getGenerationID

R=mtklein@google.com, robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/49693002

git-svn-id: http://skia.googlecode.com/svn/trunk@12029 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMark GMs that are not preserving the perspective for the canvas passed
edisonn@google.com [Wed, 30 Oct 2013 18:57:09 +0000 (18:57 +0000)]
Mark GMs that are not preserving the perspective for the canvas passed

Review URL: https://codereview.chromium.org/52443005

git-svn-id: http://skia.googlecode.com/svn/trunk@12028 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoupdate results for Nexus4 gms that run in perspespective mode
edisonn@google.com [Wed, 30 Oct 2013 18:46:31 +0000 (18:46 +0000)]
update results for Nexus4 gms that run in perspespective mode

Review URL: https://codereview.chromium.org/48623004

git-svn-id: http://skia.googlecode.com/svn/trunk@12026 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agosemi-blindly rebaseline some GM results, keeping them marked as unreviewed
epoger@google.com [Wed, 30 Oct 2013 18:14:29 +0000 (18:14 +0000)]
semi-blindly rebaseline some GM results, keeping them marked as unreviewed
(they were unreviewed in the first place, so there's no particular reason
to think they are either better or worse than they were before)

As discussed live with bsalomon
TBR=bsalomon

Review URL: https://codereview.chromium.org/53023002

git-svn-id: http://skia.googlecode.com/svn/trunk@12024 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agorebaseline GM results on Android-IntelRhb and Valgrind bots which were not running...
epoger@google.com [Wed, 30 Oct 2013 17:56:17 +0000 (17:56 +0000)]
rebaseline GM results on Android-IntelRhb and Valgrind bots which were not running for a while

Mostly tiny diffs due to roundrect implementation changes.  Also a couple of
GM tests that are known to have changed.

Visually reviewed by bsalomon and epoger

BUG=skia:1771
TBR=bsalomon

Review URL: https://codereview.chromium.org/52963002

git-svn-id: http://skia.googlecode.com/svn/trunk@12023 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoremove contains(x,y) for rects and rrects ... not well defined, and unused
reed@google.com [Wed, 30 Oct 2013 17:39:43 +0000 (17:39 +0000)]
remove contains(x,y) for rects and rrects ... not well defined, and unused

BUG=
R=robertphillips@google.com

Review URL: https://codereview.chromium.org/51953003

git-svn-id: http://skia.googlecode.com/svn/trunk@12022 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAllow specifying the max texture count on the bots
robertphillips@google.com [Wed, 30 Oct 2013 17:04:16 +0000 (17:04 +0000)]
Allow specifying the max texture count on the bots

https://codereview.chromium.org/50413011/

git-svn-id: http://skia.googlecode.com/svn/trunk@12020 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoprototype for kerning api
reed@google.com [Wed, 30 Oct 2013 15:07:03 +0000 (15:07 +0000)]
prototype for kerning api

BUG=
R=bungeman@google.com

Review URL: https://codereview.chromium.org/29363009

git-svn-id: http://skia.googlecode.com/svn/trunk@12018 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agorebaseline_server: report proper URL upon launch
epoger@google.com [Wed, 30 Oct 2013 14:09:04 +0000 (14:09 +0000)]
rebaseline_server: report proper URL upon launch
BUG=skia:1767
(SkipBuildbotRuns)

R=jcgregorio@google.com

Review URL: https://codereview.chromium.org/51353002

git-svn-id: http://skia.googlecode.com/svn/trunk@12016 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd triangles to fatbits sample ('t')
reed@google.com [Wed, 30 Oct 2013 13:41:19 +0000 (13:41 +0000)]
add triangles to fatbits sample ('t')

git-svn-id: http://skia.googlecode.com/svn/trunk@12015 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Wed, 30 Oct 2013 07:01:56 +0000 (07:01 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@12013 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoReverting r12010 (Use SkPathRef gen id for SkPath::getGenerationID https://codereview...
robertphillips@google.com [Tue, 29 Oct 2013 22:45:37 +0000 (22:45 +0000)]
Reverting r12010 (Use SkPathRef gen id for SkPath::getGenerationID https://codereview.chromium.org/49693002) due to test failures in PathTest on Android

git-svn-id: http://skia.googlecode.com/svn/trunk@12012 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoGM is passing the wrong flag to beginRecording() for --rtree.
commit-bot@chromium.org [Tue, 29 Oct 2013 21:38:54 +0000 (21:38 +0000)]
GM is passing the wrong flag to beginRecording() for --rtree.

BUG=
R=epoger@google.com, reed@google.com

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/50713004

git-svn-id: http://skia.googlecode.com/svn/trunk@12011 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoUse SkPathRef gen id for SkPath::getGenerationID
commit-bot@chromium.org [Tue, 29 Oct 2013 21:34:55 +0000 (21:34 +0000)]
Use SkPathRef gen id for SkPath::getGenerationID

R=mtklein@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/49693002

git-svn-id: http://skia.googlecode.com/svn/trunk@12010 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemove SkMatrix44 float conversions without precision loss
commit-bot@chromium.org [Tue, 29 Oct 2013 21:08:51 +0000 (21:08 +0000)]
Remove SkMatrix44 float conversions without precision loss

BUG=none
R=reed@google.com

Author: enne@chromium.org

Review URL: https://codereview.chromium.org/50423004

git-svn-id: http://skia.googlecode.com/svn/trunk@12009 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAll SkAnnotations are no-draw. Propose we fold that through.
commit-bot@chromium.org [Tue, 29 Oct 2013 20:44:39 +0000 (20:44 +0000)]
All SkAnnotations are no-draw.  Propose we fold that through.

BUG=
R=edisonn@google.com, reed@google.com

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/48523008

git-svn-id: http://skia.googlecode.com/svn/trunk@12008 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoLittle changes to SkAnnotation in pipe:
commit-bot@chromium.org [Tue, 29 Oct 2013 20:29:38 +0000 (20:29 +0000)]
Little changes to SkAnnotation in pipe:
  - store size in the op data field rather than separately (saves 4 bytes);
  - trim out a malloc/memcpy in each of read and write;
  - remove unused enum value;
  - use the right _unpackOp function;
  - make sure we call needOpBytes().

BUG=
R=reed@google.com, scroggo@google.com

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/50523004

git-svn-id: http://skia.googlecode.com/svn/trunk@12007 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAllow SkLazyPixelRef to use SkScaledImageCache
commit-bot@chromium.org [Tue, 29 Oct 2013 19:55:00 +0000 (19:55 +0000)]
Allow SkLazyPixelRef to use SkScaledImageCache

-   SkScaledImageCache:
    -   Add new FindAndLock/AddAndLock variants that work well with
        SkLazyPixelRefs (take width, height, generation_id).
    -   Add static versions of these new variants.

-   SkLazyPixelRef:
    -   If NULL passed in as SkImageCache* in the constructor, it will
        now default to using the static SkScaledImageCache methods to
        cache decoded images.
    -   If (fImageCache==NULL), the default allocator can be changed
        with the setAllocator method.  If (fImageCache!=NULL), the
        SkImageCache handles allocation.

-   CachedDecodingPixelRefTest to test the new functionality.

BUG=
R=scroggo@google.com, mtklein@google.com, reed@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/37343002

git-svn-id: http://skia.googlecode.com/svn/trunk@12006 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agotests: Provide a default resources path.
commit-bot@chromium.org [Tue, 29 Oct 2013 19:50:39 +0000 (19:50 +0000)]
tests: Provide a default resources path.

This is cuts down noise when running from skia/trunk, where this is the right
path to look in.

BUG=
R=epoger@google.com

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/51263002

git-svn-id: http://skia.googlecode.com/svn/trunk@12005 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix pipe/annotation.
commit-bot@chromium.org [Tue, 29 Oct 2013 19:23:26 +0000 (19:23 +0000)]
Fix pipe/annotation.

We weren't keeping track of the annotation that's on the other side of the pipe.

BUG=skia:1761
R=scroggo@google.com

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/48273011

git-svn-id: http://skia.googlecode.com/svn/trunk@12004 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agorebaseline_server: replace TODOs section with link to documentation/roadmap
epoger@google.com [Tue, 29 Oct 2013 17:39:09 +0000 (17:39 +0000)]
rebaseline_server: replace TODOs section with link to documentation/roadmap
(SkipBuildbotRuns)

R=bsalomon@google.com

Review URL: https://codereview.chromium.org/47543008

git-svn-id: http://skia.googlecode.com/svn/trunk@12002 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agorebaseline_server: allow substring filtering for builder and test
epoger@google.com [Tue, 29 Oct 2013 15:49:40 +0000 (15:49 +0000)]
rebaseline_server: allow substring filtering for builder and test

If the user clicks on a particular value for one of these fields, that field's
value will go into the filtering box (so you will only see results matching
that field value).

(SkipBuildbotRuns)

R=borenet@google.com

Review URL: https://codereview.chromium.org/47423002

git-svn-id: http://skia.googlecode.com/svn/trunk@12000 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoGet rid of two unused variables from the .data section.
commit-bot@chromium.org [Tue, 29 Oct 2013 15:32:09 +0000 (15:32 +0000)]
Get rid of two unused variables from the .data section.

Before:
$ objdump -x out/Release/libskia_opts.a | grep "\.data" | c++filt
1 .data         00000000  0000000000000000  0000000000000000  000004ec  2**2
0000000000000000 l    d  .data        0000000000000000 .data
1 .data         00000000  0000000000000000  0000000000000000  00000f58  2**2
0000000000000000 l    d  .data      0000000000000000 .data
2 .data         00000008  0000000000000000  0000000000000000  00001774  2**2
0000000000000000 l    d  .data    0000000000000000 .data
0000000000000000 g     O .data    0000000000000004 debug_x
0000000000000004 g     O .data    0000000000000004 debug_y
1 .data         00000000  0000000000000000  0000000000000000  00001d8c  2**2
0000000000000000 l    d  .data  0000000000000000 .data
1 .data         00000000  0000000000000000  0000000000000000  00000054  2**2
0000000000000000 l    d  .data        0000000000000000 .data
1 .data         00000000  0000000000000000  0000000000000000  000001f0  2**2
0000000000000000 l    d  .data      0000000000000000 .data
1 .data         00000000  0000000000000000  0000000000000000  00000044  2**2
0000000000000000 l    d  .data    0000000000000000 .data

After:
$ objdump -x out/Release/libskia_opts.a | grep "\.data" | c++filt
1 .data         00000000  0000000000000000  0000000000000000  000004ec  2**2
0000000000000000 l    d  .data        0000000000000000 .data
1 .data         00000000  0000000000000000  0000000000000000  00000f58  2**2
0000000000000000 l    d  .data      0000000000000000 .data
2 .data         00000000  0000000000000000  0000000000000000  00001774  2**2
0000000000000000 l    d  .data    0000000000000000 .data
1 .data         00000000  0000000000000000  0000000000000000  00001d8c  2**2
0000000000000000 l    d  .data  0000000000000000 .data
1 .data         00000000  0000000000000000  0000000000000000  00000054  2**2
0000000000000000 l    d  .data        0000000000000000 .data
1 .data         00000000  0000000000000000  0000000000000000  000001f0  2**2
0000000000000000 l    d  .data      0000000000000000 .data
1 .data         00000000  0000000000000000  0000000000000000  00000044  2**2
0000000000000000 l    d  .data    0000000000000000 .data

Not sure why clang didn't catch them.

R=mtklein@google.com
BUG=

Author: tfarina@chromium.org

Review URL: https://codereview.chromium.org/50013002

git-svn-id: http://skia.googlecode.com/svn/trunk@11999 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoDM: add --quiet
commit-bot@chromium.org [Tue, 29 Oct 2013 15:02:17 +0000 (15:02 +0000)]
DM: add --quiet

This has been handy when tossing in other SkDebugf's.

BUG=
R=bsalomon@google.com

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/49323007

git-svn-id: http://skia.googlecode.com/svn/trunk@11998 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoDon't reuse scratch textures patch
robertphillips@google.com [Tue, 29 Oct 2013 14:06:15 +0000 (14:06 +0000)]
Don't reuse scratch textures patch

https://codereview.chromium.org/24222004/

git-svn-id: http://skia.googlecode.com/svn/trunk@11997 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix bug in erosion filtering
robertphillips@google.com [Tue, 29 Oct 2013 13:59:31 +0000 (13:59 +0000)]
Fix bug in erosion filtering

https://codereview.chromium.org/50813002/

git-svn-id: http://skia.googlecode.com/svn/trunk@11996 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agosvndiff for the windows
bsalomon@google.com [Tue, 29 Oct 2013 13:55:29 +0000 (13:55 +0000)]
svndiff for the windows

R=epoger@google.com

Review URL: https://codereview.chromium.org/49323006

git-svn-id: http://skia.googlecode.com/svn/trunk@11995 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Tue, 29 Oct 2013 07:01:50 +0000 (07:01 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@11992 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix narrowing conversion errors from r11986
commit-bot@chromium.org [Mon, 28 Oct 2013 22:05:41 +0000 (22:05 +0000)]
Fix narrowing conversion errors from r11986

Although this function only gets used for SkMScalar=float, it gets
compiled in when SkMScalar=double.

R=epoger@google.com
BUG=1764

Author: enne@chromium.org

Review URL: https://codereview.chromium.org/49463005

git-svn-id: http://skia.googlecode.com/svn/trunk@11991 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoA fix for annoying clang error "unused-const-variabl" in third_party code.
commit-bot@chromium.org [Mon, 28 Oct 2013 22:05:12 +0000 (22:05 +0000)]
A fix for annoying clang error "unused-const-variabl" in third_party code.

../../third_party/externals/libwebp/src/enc/quant.c:105:23: error: unused variable 'kCoeffThresh' [-Werror,-Wunused-const-variable]
static const uint16_t kCoeffThresh[16] = {
                              ^
                      1 error generated.

BUG=None
TEST=build with clang, ninja -C out/Debug most.
R=bsalomon@google.com, epoger@google.com, thakis@chromium.org, mtklein@google.com

Author: tfarina@chromium.org

Review URL: https://codereview.chromium.org/47603012

git-svn-id: http://skia.googlecode.com/svn/trunk@11990 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agorebase msaa4 tests that haven't run in a long time
bsalomon@google.com [Mon, 28 Oct 2013 21:12:50 +0000 (21:12 +0000)]
rebase msaa4 tests that haven't run in a long time

Review URL: https://codereview.chromium.org/48183006

git-svn-id: http://skia.googlecode.com/svn/trunk@11989 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoskip android_paint GM in pipe mode
mtklein@google.com [Mon, 28 Oct 2013 20:40:41 +0000 (20:40 +0000)]
skip android_paint GM in pipe mode

BUG=skia:1763
R=scroggo@google.com

Review URL: https://codereview.chromium.org/48113010

git-svn-id: http://skia.googlecode.com/svn/trunk@11988 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agogm/internal_links test: add kSkipPipe_Flag until we fix bug 1761
epoger@google.com [Mon, 28 Oct 2013 20:21:12 +0000 (20:21 +0000)]
gm/internal_links test: add kSkipPipe_Flag until we fix bug 1761
BUG=skia:1761
TBR=reed

Review URL: https://codereview.chromium.org/49693004

git-svn-id: http://skia.googlecode.com/svn/trunk@11987 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemove float/double conversions from SkMatrix44's map2_pf
commit-bot@chromium.org [Mon, 28 Oct 2013 20:20:54 +0000 (20:20 +0000)]
Remove float/double conversions from SkMatrix44's map2_pf

BUG=chromium:303811
R=reed@google.com

Author: enne@chromium.org

Review URL: https://codereview.chromium.org/37693004

git-svn-id: http://skia.googlecode.com/svn/trunk@11986 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoDM: add --pipe
commit-bot@chromium.org [Mon, 28 Oct 2013 19:51:26 +0000 (19:51 +0000)]
DM: add --pipe

internal_links is failing across all three versions.  One of the rects doesn't draw.

BUG=
R=epoger@google.com

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/47773002

git-svn-id: http://skia.googlecode.com/svn/trunk@11985 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoWhitespace change to pick up buildbot change https://code.google.com/p/skia/source...
epoger@google.com [Mon, 28 Oct 2013 18:22:19 +0000 (18:22 +0000)]
Whitespace change to pick up buildbot change https://code.google.com/p/skia/source/detail?r=11983

git-svn-id: http://skia.googlecode.com/svn/trunk@11984 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoCleanup displacement bench
robertphillips@google.com [Mon, 28 Oct 2013 18:07:44 +0000 (18:07 +0000)]
Cleanup displacement bench

https://codereview.chromium.org/47553005/

git-svn-id: http://skia.googlecode.com/svn/trunk@11982 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoEnabling validation code in serialization and adding serialization to fuzzer
commit-bot@chromium.org [Mon, 28 Oct 2013 15:52:02 +0000 (15:52 +0000)]
Enabling validation code in serialization and adding serialization to fuzzer

BUG=

Committed: http://code.google.com/p/skia/source/detail?r=11968

R=reed@google.com, mtklein@google.com, senorblanco@chromium.org, bsalomon@google.com, robertphillips@google.com

Author: sugoi@chromium.org

Review URL: https://codereview.chromium.org/44573002

git-svn-id: http://skia.googlecode.com/svn/trunk@11981 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix for issue 1728: raster vs. gpu text draws with the wrong color
commit-bot@chromium.org [Mon, 28 Oct 2013 15:13:50 +0000 (15:13 +0000)]
Fix for issue 1728: raster vs. gpu text draws with the wrong color

The blend mode for LCD text was not set up correctly when using colors with alpha. This takes the color's alpha value
into account when setting up the blending function.

BUG=Skia:1728
R=bsalomon@google.com

Author: jvanverth@google.com

Review URL: https://codereview.chromium.org/45363002

git-svn-id: http://skia.googlecode.com/svn/trunk@11980 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix broken MSAA for RGBA
commit-bot@chromium.org [Mon, 28 Oct 2013 15:09:13 +0000 (15:09 +0000)]
Fix broken MSAA for RGBA

R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/46763003

git-svn-id: http://skia.googlecode.com/svn/trunk@11979 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoReverting r11968 (Enabling validation code in serialization and adding serialization...
robertphillips@google.com [Mon, 28 Oct 2013 12:08:52 +0000 (12:08 +0000)]
Reverting r11968 (Enabling validation code in serialization and adding serialization to fuzzer - https://codereview.chromium.org/44573002) due to failure on Chromium AllQuads test.

git-svn-id: http://skia.googlecode.com/svn/trunk@11974 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoClean up the GrTHashTable API.
commit-bot@chromium.org [Sun, 27 Oct 2013 20:50:23 +0000 (20:50 +0000)]
Clean up the GrTHashTable API.

removeAt() and slowFindIndex() were only used by GrFontCache, and didn't really need to exist: they can be replaced by a simple remove() call.  This new code should actually be faster; slowFindIndex() was O(N), and this should be O(lg N).

BUG=
R=bsalomon@google.com, jvanverth@google.com

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/43383006

git-svn-id: http://skia.googlecode.com/svn/trunk@11973 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agorebaseline_server: tiny fix to un-break UI when ng-repeate (key, value) has duplicate...
epoger@google.com [Sat, 26 Oct 2013 15:01:08 +0000 (15:01 +0000)]
rebaseline_server: tiny fix to un-break UI when ng-repeate (key, value) has duplicate values

See https://github.com/angular/angular.js/pull/2505

(SkipBuildbotRuns)
TBR=jcgregorio

Review URL: https://codereview.chromium.org/46063005

git-svn-id: http://skia.googlecode.com/svn/trunk@11972 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agomass-committing another round of GM results, marked as reviewed-by-human=false
epoger@google.com [Sat, 26 Oct 2013 14:44:22 +0000 (14:44 +0000)]
mass-committing another round of GM results, marked as reviewed-by-human=false
BUG=skia:1759
TBR=bsalomon

Review URL: https://codereview.chromium.org/46653003

git-svn-id: http://skia.googlecode.com/svn/trunk@11971 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agorebaseline_server: UI improvements + set reviewed-by-human on commit
epoger@google.com [Sat, 26 Oct 2013 14:31:11 +0000 (14:31 +0000)]
rebaseline_server: UI improvements + set reviewed-by-human on commit

- select/clear/toggle all tests
- display "bugs" column
- set reviewed-by-human on commit
- a couple more tiny fixes, TODOs adjusted, etc.

(SkipBuildbotRuns)

R=senorblanco@chromium.org

Review URL: https://codereview.chromium.org/44123004

git-svn-id: http://skia.googlecode.com/svn/trunk@11970 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Sat, 26 Oct 2013 07:01:53 +0000 (07:01 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@11969 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoEnabling validation code in serialization and adding serialization to fuzzer
commit-bot@chromium.org [Fri, 25 Oct 2013 21:04:40 +0000 (21:04 +0000)]
Enabling validation code in serialization and adding serialization to fuzzer

BUG=
R=reed@google.com, mtklein@google.com, senorblanco@chromium.org, bsalomon@google.com

Author: sugoi@chromium.org

Review URL: https://codereview.chromium.org/44573002

git-svn-id: http://skia.googlecode.com/svn/trunk@11968 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAllow users to build on top of, instead of beneath, SkRefCnt.
bungeman@google.com [Fri, 25 Oct 2013 18:40:24 +0000 (18:40 +0000)]
Allow users to build on top of, instead of beneath, SkRefCnt.

Alternative to r11811.

The Chromium half of this can be seen at https://codereview.chromium.org/40973002/ .

R=reed@google.com

Review URL: https://codereview.chromium.org/40503002

git-svn-id: http://skia.googlecode.com/svn/trunk@11967 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFactor out skia_keep_frame_pointer. Handy with perf to get call stacks.
commit-bot@chromium.org [Fri, 25 Oct 2013 18:14:54 +0000 (18:14 +0000)]
Factor out skia_keep_frame_pointer.  Handy with perf to get call stacks.

Today it's set when we're running a sanitizer, but it's more generally useful.  perf record -g (--call-graph) only works for me if we don't omit the frame pointer.

BUG=
R=bungeman@google.com

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/41923004

git-svn-id: http://skia.googlecode.com/svn/trunk@11966 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoonCharsToGlyphs to handle non-bmp on Mac.
bungeman@google.com [Fri, 25 Oct 2013 17:49:08 +0000 (17:49 +0000)]
onCharsToGlyphs to handle non-bmp on Mac.

CTFontGetGlyphsForCharacters is a strange API for non-bmp code points.

R=caryclark@google.com

Review URL: https://codereview.chromium.org/43463005

git-svn-id: http://skia.googlecode.com/svn/trunk@11965 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoNew baselines for imagefiltersgraph GM.
senorblanco@chromium.org [Fri, 25 Oct 2013 17:04:56 +0000 (17:04 +0000)]
New baselines for imagefiltersgraph GM.

TBR=bsalomon@google.com

Review URL: https://codereview.chromium.org/44323002

git-svn-id: http://skia.googlecode.com/svn/trunk@11964 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoDM: move --match check earlier to fix the "N GMs x M configs" log line.
commit-bot@chromium.org [Fri, 25 Oct 2013 15:02:57 +0000 (15:02 +0000)]
DM: move --match check earlier to fix the "N GMs x M configs" log line.

BUG=
R=bsalomon@google.com

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/44443002

git-svn-id: http://skia.googlecode.com/svn/trunk@11963 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoCompute clipped src rect once in tiled bitmap draws
commit-bot@chromium.org [Fri, 25 Oct 2013 14:58:12 +0000 (14:58 +0000)]
Compute clipped src rect once in tiled bitmap draws

R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/40403002

git-svn-id: http://skia.googlecode.com/svn/trunk@11962 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix warnings as errors from r11960.
bungeman@google.com [Fri, 25 Oct 2013 13:39:42 +0000 (13:39 +0000)]
Fix warnings as errors from r11960.

git-svn-id: http://skia.googlecode.com/svn/trunk@11961 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoDisable charsToGlyphs test until Mac can pass.
bungeman@google.com [Fri, 25 Oct 2013 12:32:16 +0000 (12:32 +0000)]
Disable charsToGlyphs test until Mac can pass.

git-svn-id: http://skia.googlecode.com/svn/trunk@11960 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Fri, 25 Oct 2013 07:02:14 +0000 (07:02 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@11959 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRevert unwanted change to verttext.cpp.
bungeman@google.com [Thu, 24 Oct 2013 22:38:48 +0000 (22:38 +0000)]
Revert unwanted change to verttext.cpp.

git-svn-id: http://skia.googlecode.com/svn/trunk@11958 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix non-bmp in generateCharToGlyph on Mac.
bungeman@google.com [Thu, 24 Oct 2013 22:32:43 +0000 (22:32 +0000)]
Fix non-bmp in generateCharToGlyph on Mac.

git-svn-id: http://skia.googlecode.com/svn/trunk@11957 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd missing braces for r11955.
bungeman@google.com [Thu, 24 Oct 2013 21:50:12 +0000 (21:50 +0000)]
Add missing braces for r11955.

git-svn-id: http://skia.googlecode.com/svn/trunk@11956 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoImplement charToGlyph on remaining ports.
bungeman@google.com [Thu, 24 Oct 2013 21:39:35 +0000 (21:39 +0000)]
Implement charToGlyph on remaining ports.

R=reed@google.com

Review URL: https://codereview.chromium.org/22859070

git-svn-id: http://skia.googlecode.com/svn/trunk@11955 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoReduce bitmap sizes in verylargebitmap GM to not crash on windows
bsalomon@google.com [Thu, 24 Oct 2013 20:55:14 +0000 (20:55 +0000)]
Reduce bitmap sizes in verylargebitmap GM to not crash on windows

R=scroggo@google.com

Review URL: https://codereview.chromium.org/39033005

git-svn-id: http://skia.googlecode.com/svn/trunk@11954 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRebaseline strokes_round and strokes3 on SGX devices
bsalomon@google.com [Thu, 24 Oct 2013 20:03:27 +0000 (20:03 +0000)]
Rebaseline strokes_round and strokes3 on SGX devices

BUG=skia:1752

Review URL: https://codereview.chromium.org/41083003

git-svn-id: http://skia.googlecode.com/svn/trunk@11953 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoChanges bench_graph_svg.py test to check_bench_regressions.py test; deletes deprecate...
bensong@google.com [Thu, 24 Oct 2013 18:08:45 +0000 (18:08 +0000)]
Changes bench_graph_svg.py test to check_bench_regressions.py test; deletes deprecated chunks in syn_bucket_subdir.
Review URL: https://codereview.chromium.org/27377002

git-svn-id: http://skia.googlecode.com/svn/trunk@11952 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoTile large bitmaps that are clipped.
bsalomon@google.com [Thu, 24 Oct 2013 17:52:07 +0000 (17:52 +0000)]
Tile large bitmaps that are clipped.

R=robertphillips@google.com

Review URL: https://codereview.chromium.org/31033002

git-svn-id: http://skia.googlecode.com/svn/trunk@11951 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoDM: print cache stats after every GPU GM when GR_CACHE_STATS is set
commit-bot@chromium.org [Thu, 24 Oct 2013 17:44:43 +0000 (17:44 +0000)]
DM: print cache stats after every GPU GM when GR_CACHE_STATS is set

BUG=
R=bsalomon@google.com

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/39743003

git-svn-id: http://skia.googlecode.com/svn/trunk@11950 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoWe want to give SkPixelRef a way to signal over to GrResourceCache that it's become...
commit-bot@chromium.org [Thu, 24 Oct 2013 17:44:27 +0000 (17:44 +0000)]
We want to give SkPixelRef a way to signal over to GrResourceCache that it's become pointless to keep around textures based on that SkPixelRef when its pixels change, so that it can be a good citizen and free those textures.

This adds an invalidation listener mechanism to SkPixelRef to let it send this message while still staying ignorant of who's listening.

These messages are tricky to deliver.  The SkPixelRefs they originates from and the GrResourceCaches they ultimately end up at may be on different threads; neither class is threadsafe; their object lifetimes are totally independent; it's a many-senders-to-many-receivers relation; and neither codebase should really know about the other.

So I've added a per-message-type global message bus to broadcast messages to threadsafe inboxes.  Anyone can post() a message, which will show up in all the inboxes of that type, read whenever the inbox's owner calls poll().  The implementation is _dumb_; it can be improved in several dimensions (inbox size limits, lock-free message delivery) if we find the need.

I took some care to make sure not to send the invalidation message for any SkPixelRef that's sharing a generation ID with another SkPixelRef.

BUG=
R=bsalomon@google.com, scroggo@google.com, reed@google.com

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/26734003

git-svn-id: http://skia.googlecode.com/svn/trunk@11949 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years ago[PDF] Rebaseline mac expectations after fixing image unpremtuliplication in r11945
vandebo@chromium.org [Thu, 24 Oct 2013 16:40:12 +0000 (16:40 +0000)]
[PDF] Rebaseline mac expectations after fixing image unpremtuliplication in r11945

Review URL: https://codereview.chromium.org/40263003

git-svn-id: http://skia.googlecode.com/svn/trunk@11948 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix drawBitmap() of scratch texture.
senorblanco@chromium.org [Thu, 24 Oct 2013 15:59:31 +0000 (15:59 +0000)]
Fix drawBitmap() of scratch texture.

R=bsalomon@google.com

Review URL: https://codereview.chromium.org/40163004

git-svn-id: http://skia.googlecode.com/svn/trunk@11947 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agorebaseline_server: cleanup of HTML/Javascript
epoger@google.com [Thu, 24 Oct 2013 15:38:27 +0000 (15:38 +0000)]
rebaseline_server: cleanup of HTML/Javascript

No behavioral change at all.
(SkipBuildbotRuns)

R=borenet@google.com

Review URL: https://codereview.chromium.org/31583007

git-svn-id: http://skia.googlecode.com/svn/trunk@11946 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years ago[PDF] Add unpremultiply support and a GM (try5)
vandebo@chromium.org [Thu, 24 Oct 2013 15:20:00 +0000 (15:20 +0000)]
[PDF] Add unpremultiply support and a GM (try5)

This is a resubmit of https://codereview.chromium.org/22831039 which was
reverted because it causes issues on Windows.

BUG=chromium:175548
R=edisonn@google.com

Review URL: https://codereview.chromium.org/37873003

git-svn-id: http://skia.googlecode.com/svn/trunk@11945 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoWhitespace change to trigger buildbots
epoger@google.com [Thu, 24 Oct 2013 15:05:13 +0000 (15:05 +0000)]
Whitespace change to trigger buildbots

git-svn-id: http://skia.googlecode.com/svn/trunk@11944 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd note to ignored-tests.txt
epoger@google.com [Thu, 24 Oct 2013 14:42:19 +0000 (14:42 +0000)]
Add note to ignored-tests.txt
BUG=skia:1748
(SkipBuildbotRuns)

R=scroggo@google.com

Review URL: https://codereview.chromium.org/40353002

git-svn-id: http://skia.googlecode.com/svn/trunk@11943 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoupdate pdf-mac gms, after adding duport for perspective shaders in pdf
edisonn@google.com [Thu, 24 Oct 2013 14:24:59 +0000 (14:24 +0000)]
update pdf-mac gms, after adding duport for perspective shaders in pdf

Review URL: https://codereview.chromium.org/40313002

git-svn-id: http://skia.googlecode.com/svn/trunk@11942 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoBorrow Android's ARMv6 memory barrier for SkOnce.
commit-bot@chromium.org [Thu, 24 Oct 2013 14:25:22 +0000 (14:25 +0000)]
Borrow Android's ARMv6 memory barrier for SkOnce.

BUG=skia:1743
R=bungeman@google.com

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/34353009

git-svn-id: http://skia.googlecode.com/svn/trunk@11941 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMinor changes
robertphillips@google.com [Thu, 24 Oct 2013 14:03:01 +0000 (14:03 +0000)]
Minor changes

https://codereview.chromium.org/39973004/

git-svn-id: http://skia.googlecode.com/svn/trunk@11940 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAlways create an instance when testing GrEffects for SkXfermode and SkArithmeticMode
commit-bot@chromium.org [Thu, 24 Oct 2013 13:33:32 +0000 (13:33 +0000)]
Always create an instance when testing GrEffects for SkXfermode and SkArithmeticMode

Previously the TestCreate methods of the effects would create a static
instance and return that for all invocations. This is probably a
copy-paste error going back to initial TestCreate method in r8449. At
that time, the effect was always the same and thus static usage made
sense.

R=bsalomon@google.com, senorblanco@google.com

Author: kkinnunen@nvidia.com

Review URL: https://codereview.chromium.org/39393002

git-svn-id: http://skia.googlecode.com/svn/trunk@11939 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix ModeColorFilterEffect assert during GLProgramsTest
commit-bot@chromium.org [Thu, 24 Oct 2013 13:29:38 +0000 (13:29 +0000)]
Fix ModeColorFilterEffect assert during GLProgramsTest

Select random filter mode for the test-case until the mode is not
Dst. SkModeColorFilter with Dst mode will not create a
ModeColorFilterEffect, and thus the case is not implemented.

Also changes it so that each call to ModeColorFilterEffect::TestCreate
creates a new GrEffect. Previously only one static effect was ever
created, due to copy-paste error.

R=bsalomon@google.com

Author: kkinnunen@nvidia.com

Review URL: https://codereview.chromium.org/39403002

git-svn-id: http://skia.googlecode.com/svn/trunk@11938 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoPDF: support perspective in simple shaders. (this version does not work well with...
edisonn@google.com [Thu, 24 Oct 2013 13:19:28 +0000 (13:19 +0000)]
PDF: support perspective in simple shaders. (this version does not work well with tilling)

R=vandebo@chromium.org

Review URL: https://codereview.chromium.org/26389006

git-svn-id: http://skia.googlecode.com/svn/trunk@11937 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoReplacing SkTDArray with SkAutoSTArray to reduce memory allocation overhead in SkTile...
commit-bot@chromium.org [Thu, 24 Oct 2013 11:24:38 +0000 (11:24 +0000)]
Replacing SkTDArray with SkAutoSTArray to reduce memory allocation overhead in SkTileGrid::search

BUG=https://code.google.com/p/skia/issues/detail?id=1735
R=tomhudson@chromium.org

Author: junov@chromium.org

Review URL: https://codereview.chromium.org/35633002

git-svn-id: http://skia.googlecode.com/svn/trunk@11936 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoExpose SkPicture::willPlayBackBitmaps()
tomhudson@google.com [Thu, 24 Oct 2013 11:12:47 +0000 (11:12 +0000)]
Expose SkPicture::willPlayBackBitmaps()

This returns true if (1) the picture has finished recording and
(2) this picture or any picture drawn into it refers to any bitmaps.
It allows clients doing complicated manipulations of the picture to
early-out when there are no bitmaps present.

BUG=303281
R=reed@google.com

git-svn-id: http://skia.googlecode.com/svn/trunk@11935 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Thu, 24 Oct 2013 07:01:59 +0000 (07:01 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@11934 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoApply matrix early in draw bitmap
commit-bot@chromium.org [Thu, 24 Oct 2013 01:46:11 +0000 (01:46 +0000)]
Apply matrix early in draw bitmap

Committed: http://code.google.com/p/skia/source/detail?r=11930

Reverted: https://code.google.com/p/skia/source/detail?r=11932

R=robertphillips@google.com, senorblanco@chromium.org

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/30593003

git-svn-id: http://skia.googlecode.com/svn/trunk@11933 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRevert "Apply matrix early in draw bitmap"
scroggo@google.com [Wed, 23 Oct 2013 22:19:06 +0000 (22:19 +0000)]
Revert "Apply matrix early in draw bitmap"

This reverts commit 4c446c8eb50b7a6e6f917fae7b4c4ffe5658a949.

Fix build.

git-svn-id: http://skia.googlecode.com/svn/trunk@11932 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRevert "[PDF] Add unpremultiply support and a GM (try4)"
vandebo@chromium.org [Wed, 23 Oct 2013 21:36:43 +0000 (21:36 +0000)]
Revert "[PDF] Add unpremultiply support and a GM (try4)"

This reverts commit r11928

gm seems to crash on windows.

Review URL: https://codereview.chromium.org/38153003

git-svn-id: http://skia.googlecode.com/svn/trunk@11931 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoApply matrix early in draw bitmap
commit-bot@chromium.org [Wed, 23 Oct 2013 21:06:51 +0000 (21:06 +0000)]
Apply matrix early in draw bitmap

R=robertphillips@google.com, senorblanco@chromium.org

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/30593003

git-svn-id: http://skia.googlecode.com/svn/trunk@11930 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years ago[PDF] Add unpremultiply support and a GM (try4)
vandebo@chromium.org [Wed, 23 Oct 2013 20:17:29 +0000 (20:17 +0000)]
[PDF] Add unpremultiply support and a GM (try4)

This is a resubmit of https://codereview.chromium.org/22831039 which was
reverted because it causes issues on Windows (really, release builds).

BUG=chromium:175548
R=edisonn@google.com

Review URL: https://codereview.chromium.org/33493003

git-svn-id: http://skia.googlecode.com/svn/trunk@11928 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agorebaseline scaled tilemodes gms on the GPU
humper@google.com [Wed, 23 Oct 2013 19:41:08 +0000 (19:41 +0000)]
rebaseline scaled tilemodes gms on the GPU

git-svn-id: http://skia.googlecode.com/svn/trunk@11927 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSplit up SkXfermode::asNewEffectOrCoeff() into asNewEffect(), asCoeff().
senorblanco@chromium.org [Wed, 23 Oct 2013 18:41:36 +0000 (18:41 +0000)]
Split up SkXfermode::asNewEffectOrCoeff() into asNewEffect(), asCoeff().

R=bsalomon@google.com

Review URL: https://codereview.chromium.org/37593002

git-svn-id: http://skia.googlecode.com/svn/trunk@11926 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFollow up to serialization validation code
commit-bot@chromium.org [Wed, 23 Oct 2013 18:33:18 +0000 (18:33 +0000)]
Follow up to serialization validation code

1 ) Added check for bool to make sure is it either 0 or 1 and not garbage

2 ) Added more solid kernel size checks in SkMatrixConvolutionImageFilter

3 ) Make sure array size is validated in SkMergeImageFilter

BUG=
R=reed@google.com, mtklein@google.com, senorblanco@google.com, senorblanco@chromium.org

Author: sugoi@chromium.org

Review URL: https://codereview.chromium.org/23548034

git-svn-id: http://skia.googlecode.com/svn/trunk@11925 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoInitial error handling code
commit-bot@chromium.org [Wed, 23 Oct 2013 17:06:21 +0000 (17:06 +0000)]
Initial error handling code

I made it as simple as possible. The impact seems minimal and it should do what's necessary to make this code secure.

BUG=

Committed: http://code.google.com/p/skia/source/detail?r=11247

R=reed@google.com, scroggo@google.com, djsollen@google.com, sugoi@google.com, bsalomon@google.com, mtklein@google.com, senorblanco@google.com, senorblanco@chromium.org

Author: sugoi@chromium.org

Review URL: https://codereview.chromium.org/23021015

git-svn-id: http://skia.googlecode.com/svn/trunk@11922 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agouse the supplied matrix instead of the texture w/h div for the bicubic GPU effect
commit-bot@chromium.org [Wed, 23 Oct 2013 16:18:50 +0000 (16:18 +0000)]
use the supplied matrix instead of the texture w/h div for the bicubic GPU effect

BUG=
R=bsalomon@google.com, caryclark@google.com

Author: humper@google.com

Review URL: https://codereview.chromium.org/37003005

git-svn-id: http://skia.googlecode.com/svn/trunk@11921 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoLighting filter uses input on raster path
commit-bot@chromium.org [Wed, 23 Oct 2013 15:33:44 +0000 (15:33 +0000)]
Lighting filter uses input on raster path

BUG=
R=senorblanco@chromium.org

Author: sugoi@chromium.org

Review URL: https://codereview.chromium.org/35703002

git-svn-id: http://skia.googlecode.com/svn/trunk@11918 2bbb7eff-a529-9590-31e7-b0007b416f81