Andy Green [Thu, 12 Apr 2012 03:08:55 +0000 (11:08 +0800)]
remove duplicated netdb include from client handshake
Based on work from Radu Sorici <soriciradu@gmail.com>
Signed-off-by: Andy Green <andy.green@linaro.org>
Andy Green [Thu, 12 Apr 2012 03:06:05 +0000 (11:06 +0800)]
change DATADIR to INSTALL_DATADIR solve mingw conflict
Based on work from Radu Sorici <soriciradu@gmail.com>
Signed-off-by: Andy Green <andy.green@linaro.org>
Andy Green [Thu, 12 Apr 2012 03:02:06 +0000 (11:02 +0800)]
mingw gettimeofday avoid missing include
Based on work from Radu Sorici <soriciradu@gmail.com>
Signed-off-by: Andy Green <andy.green@linaro.org>
Andy Green [Thu, 12 Apr 2012 02:56:20 +0000 (10:56 +0800)]
mingw add in missing poll defs
Based on work from Radu Sorici <soriciradu@gmail.com>
Signed-off-by: Andy Green <andy.green@linaro.org>
Andy Green [Thu, 12 Apr 2012 02:54:22 +0000 (10:54 +0800)]
mingw hide some missing includes
Based on work from Radu Sorici <soriciradu@gmail.com>
Signed-off-by: Andy Green <andy.green@linaro.org>
Andy Green [Thu, 12 Apr 2012 02:11:29 +0000 (10:11 +0800)]
autoconf introduce enable mingw and adapt compiler options
Based on work from Radu Sorici <soriciradu@gmail.com>
Signed-off-by: Andy Green <andy.green@linaro.org>
Andy Green [Mon, 9 Apr 2012 07:09:01 +0000 (15:09 +0800)]
style cleaning
Signed-off-by: Andy Green <andy.green@linaro.org>
Andy Green [Mon, 9 Apr 2012 07:23:47 +0000 (15:23 +0800)]
fix onopen browser context patch
Signed-off-by: Andy Green <andy.green@linaro.org>
Yonathan Yusim [Sun, 8 Apr 2012 22:42:39 +0000 (06:42 +0800)]
allow message processing from onopen browser context
Found an issue in libwebsockets - if a server sends a message within its "onopen" context then the message is getting swallowed and not passed to calling client (means LWS_CALLBACK_CLIENT_RECEIVE is never getting called).
I've fixed the bug - pls find attached patch.
Signed-off-by: Yonathan Yusim <yonathan@boxee.tv>
Signed-off-by: Andy Green <andy@warmcat.com>
Tobias Maier [Thu, 5 Apr 2012 09:57:12 +0000 (11:57 +0200)]
use ssize_t instead of size_t for return values of read/recv/SSL_read
Signed-off-by: Tobias Maier <tobias.maier@netplace.com>
Nick Dowell [Thu, 5 Apr 2012 02:31:48 +0000 (10:31 +0800)]
make duplicate headers append instead of get ignored
The code to prevent memory leaks caused by reallocating a wsi->utf8_token
was also causing wsi->parser_state to not be updated, preventing the
handshake from completing.
This patch changes the logic to append to previous allocation which is
correct behaviour actually.
Signed-off-by: Nick Dowell <nick@nickdowell.com>
Signed-off-by: Andy Green <andy@warmcat.com>
Nick Dowell [Thu, 5 Apr 2012 02:29:39 +0000 (10:29 +0800)]
close connection if socket recv() fails.
This prevents a problem observed on Windows whereby a client that
disconnects before fully establishing the WebSocket would cause the
server to use 100% CPU since recv() would continually return -1 for that
socket.
Signed-off-by: Nick Dowell <nick@nickdowell.com>
Nick Dowell [Thu, 5 Apr 2012 02:29:29 +0000 (10:29 +0800)]
fix heap corruption if HTTP callback calls libwebsocket_close_and_free_session
Signed-off-by: Nick Dowell <nick@nickdowell.com>
Andy Green [Tue, 3 Apr 2012 15:02:20 +0000 (17:02 +0200)]
map wsorigin on to origin at an early point and stop dupe header mem leaks
Carlo wrote
''I'm interested to use the libwebsockets server (C based) with a Java
websocket client. I was able to implement a Java websocket client based
on JWebSocket library that works fine with the libwebsockets server, but
I was obliged to patch the libwebsockets server in order to reach my
goal. In particular I patched the handshake_00() function because
JWebSocket library uses hixie 76 version. The problem was that the
JWebSocket library sends only WSI_TOKEN_SWORIGIN token instead
WSI_TOKEN_ORIGIN token. For this reason the handshake_00 failed because
the token length of WSI_TOKEN_ORIGIN was 0. I have written a patch in
order to control if at least one of the two tokens (WSI_TOKEN_SWORIGIN
and WSI_TOKEN_ORIGIN) is defined. I have attached into the e-mail the
patch. Probably it can be written better, but in any case I think that
this problem should be fixed for client/server compatibility.''
I found a simpler approach which is convert WSORIGIN processing to
go into ORIGIN token at the earliest point, then everything else can
stay the same.
I also noticed we would leak on duplicated headers and fixed that.
Reported-by: Carlo PARATA <carlo.parata@st.com>
Signed-off-by: Andy Green <andy@warmcat.com>
Nick Dowell [Tue, 3 Apr 2012 16:22:19 +0000 (17:22 +0100)]
handle unsupported protocol correctly
Hi Andy,
First off, thanks for libwebsockets :-)
I've encountered a crash when a client connects to a libwebsockets server
but speicifies an unsupported protocol (Sec-WebSocket-Protocol).
handshake.c should probably be checking that wsi->protocol->name is not
null before doing a strcmp with it...
Attached is a patch for your consideration.
Cheers!
Nick
Signed-off-by: Nick Dowell <nick@nickdowell.com>
Andy Green [Thu, 29 Mar 2012 01:27:13 +0000 (09:27 +0800)]
fix issuing null extension header if none supported
Josh realized that with new Chrome, because we don't support the type of
compression extension yet we returned a null extension header.
This patch fixes that by deferring issuing the extension header until we
find we have something to say.
tested OK on google-chrome 19.0.1081.2-129295
Reported-by: Josh Roberson <josh@asteriasgi.com>
Signed-off-by: Andy Green <andy.green@linaro.org>
Artem Egorkine [Wed, 23 Nov 2011 08:46:24 +0000 (10:46 +0200)]
Don't care for the human-readable part of "HTTP/1.1 101" reply
While the protocol specification gives example of the
human-readable message associated with a 101-code reply,
nowhere does it actually enforce it. Ws4py gevent middleware
is known to have a message other than "Switching Protocols".
Dan Zhang [Wed, 9 Nov 2011 07:55:16 +0000 (15:55 +0800)]
cleanup fixes tested on win32 compiler
Signed-off-by: Dan Zhang <emaildanzhang@gmail.com>
Andy Green [Tue, 8 Nov 2011 23:28:45 +0000 (07:28 +0800)]
win32 poll emulation clean and address PEEK issue
Dan Zhang needed to defeat the recv() with PEEK in order to get working
poll() emulation on 64-bit windows.
I cleaned up the style in that file and made a version of his workaround
(which was force recv result to 0). I can't test the result so it may
need more work.
Reported-by: Dan Zhang <emaildanzhang@gmail.com>
Signed-off-by: Andy Green <andy@warmcat.com>
Andy Green [Mon, 7 Nov 2011 11:53:23 +0000 (19:53 +0800)]
debug move most spew into debug macro
This quietens the spew so all typical debug info now is coming from
the user code (mirror protocol in the sample server / client case).
Signed-off-by: Andy Green <andy@warmcat.com>
Alex Bligh [Mon, 7 Nov 2011 09:19:25 +0000 (17:19 +0800)]
Add libwebsockets_ensure_user_space
This patch unifies the code for per-connection user allocation, and allows
it to be allocated earlier, duiring HTTP service time. It's also OK to
attempt allocation multiple times, it will just return any existing
allocation.
Signed-off-by: Alex Bligh <alex@alex.org.uk>
David Galeano [Tue, 4 Oct 2011 12:59:24 +0000 (20:59 +0800)]
add missing win32 zlib pieces
Signed-off-by: David Galeano <davidgaleano@turbulenz.biz>
Oleg Golosovskiy [Tue, 4 Oct 2011 12:20:14 +0000 (20:20 +0800)]
http charsets have case insensitive tokens
Andy,
According http://www.ietf.org/rfc/rfc2616.txt HTTP character sets are identified by case-insensitive tokens.
Please replase
if (strcmp(lws_tokens[n].token, wsi->name_buffer))
continue;
to
if (stricmp(lws_tokens[n].token, wsi->name_buffer))
continue;
Oleg
Also introduce strcasecmp definition for win32
Signed-off-by: Oleg Golosovskiy <ogolosovskiy@unison.com>
David Galeano [Tue, 4 Oct 2011 11:55:18 +0000 (19:55 +0800)]
Added support for Windows XP.
David Galeano [Mon, 3 Oct 2011 11:30:27 +0000 (19:30 +0800)]
Added BYTE_ORDER definition for win32 builds.
Andy Green [Mon, 3 Oct 2011 11:30:22 +0000 (19:30 +0800)]
doc LWS_EXTERN
Signed-off-by: Andy Green <andy@warmcat.com>
David Galeno [Mon, 26 Sep 2011 16:33:45 +0000 (17:33 +0100)]
zlib update
Signed-off-by: David Galeno <davidgaleano@turbulenz.biz>
David Galeano [Mon, 26 Sep 2011 16:30:34 +0000 (17:30 +0100)]
Added "Release DLL" configuration.
David Galeano [Mon, 26 Sep 2011 11:17:20 +0000 (12:17 +0100)]
Added LWS_EXTERN to allow building a DLL.
Signed-off-by: David Galeano <davidgaleano@turbulenz.biz>
David Galeano [Mon, 26 Sep 2011 11:09:54 +0000 (12:09 +0100)]
Fixed compiler warnings.
Signed-off-by: David Galeano <davidgaleano@turbulenz.biz>
David Galeano [Mon, 26 Sep 2011 11:09:20 +0000 (12:09 +0100)]
Ignoring Release build and opensdf files.
Signed-off-by: David Galeano <davidgaleano@turbulenz.biz>
Andy Green [Sun, 25 Sep 2011 09:46:31 +0000 (10:46 +0100)]
fix failure to limit 7bit lengths
Reported-by: Tran Le Hung <tranhung44@gmail.com>
Reported-by: Tobias Maier <tobias.maier@netplace.com>
Signed-off-by: Andy Green <andy@warmcat.com>
M K [Sun, 25 Sep 2011 09:34:35 +0000 (10:34 +0100)]
Fix compile issue on Apple
Signed-off-by: M K <mkroehnert42@googlemail.com>
Andy Green [Sun, 25 Sep 2011 09:30:26 +0000 (10:30 +0100)]
correct cpp extern only being on win32
Signed-off-by: Andy Green <andy@warmcat.com>
Andy Green [Sun, 25 Sep 2011 09:01:02 +0000 (10:01 +0100)]
test html uplevel detect browser and MozWebSocket
Signed-off-by: Andy Green <andy@warmcat.com>
Andy Green [Sun, 25 Sep 2011 08:32:54 +0000 (09:32 +0100)]
v08v13 add support v13 default
Signed-off-by: Andy Green <andy@warmcat.com>
Andy Green [Sun, 25 Sep 2011 07:47:57 +0000 (08:47 +0100)]
v08 receiver ignore frame with unhandled ext opcode
Signed-off-by: Andy Green <andy@warmcat.com>
Andy Green [Sun, 25 Sep 2011 07:47:53 +0000 (08:47 +0100)]
v08 change ignore incoming set ext bits
Signed-off-by: Andy Green <andy@warmcat.com>
Andy Green [Sun, 26 Jun 2011 09:27:28 +0000 (10:27 +0100)]
my compiler version didn't find it, but there is an uninitialized usage of
len pointed out by Sonic on the blog
Reported-by: Sven <sven@killig.de>
Signed-off-by: Andy Green <andy@warmcat.com>
Andy Green [Sat, 28 May 2011 09:19:19 +0000 (10:19 +0100)]
extensions fix deflate stream vs mux and veto it on mux children
This patch gets deflate-stream working with x-google-mux.
It adds a clean veto system where are extension can veto the proposal
of any extension when opening a new connection. x-google-mux uses that
in its callback to defeat any use of deflate-stream on mux children.
However deflate stream is allowed on the parent connection and works
transparently now alongside x-google-mux.
Signed-off-by: Andy Green <andy@warmcat.com>
Andy Green [Thu, 26 May 2011 11:59:13 +0000 (12:59 +0100)]
x google mux handle illegal channel add indexes cleanup handle ch1 rx
Signed-off-by: Andy Green <andy@warmcat.com>
Andy Green [Wed, 25 May 2011 20:41:57 +0000 (21:41 +0100)]
extensions introduce pre close veto
This establishes a pre-close extension check to allow an extension to
veto a close. x-google-mux then uses this to stop ch1 going down
(subchannel 1 is the original socket connection that turns into a mux
parent) if it has active mux children; it just marks ch1 as closed in
its conn struct in that case and returns 1 from the callback to veto.
Code is also added to take care of the case ch1 is 'closed', and the
last child is subsequently closed, it actively calls close on the mux
parent then.
Signed-off-by: Andy Green <andy@warmcat.com>
Andy Green [Wed, 25 May 2011 20:07:20 +0000 (21:07 +0100)]
extensions change child count to highest child subchannel
This also changes the wsi_children array to be indexed by subchannel - 2,
non-existent channels are NULL in there and highest_child_subchannel
is a highwater mark for the highest subchannel ever used. That way we
can immediately get the wsi for a subchannel at the cost of some extra
sparse skipping during management.
This also takes care of scanning for empty slots on allocation and
NULLing on close of subchannel instead of deletion.
Signed-off-by: Andy Green <andy@warmcat.com>
Andy Green [Wed, 25 May 2011 19:46:18 +0000 (20:46 +0100)]
extensions ensure per conn allocation starts zeroed
Signed-off-by: Andy Green <andy@warmcat.com>
Andy Green [Wed, 25 May 2011 11:16:00 +0000 (12:16 +0100)]
x google mux complete introduction of MUX_REAL_CHILD_INDEX_OFFSET that got included accidentally
Accidentally included half-done MUX_REAL_CHILD_INDEX_OFFSET addition a couple
of patches back after late night hacking, this patch completes it.
This makes mux added channels start at channel index 2.
1 is reserved for original carrier channel, 0 for as-yet badly defined global mux commands
Signed-off-by: Andy Green <andy@warmcat.com>
Jean-Pierre Gygax [Wed, 25 May 2011 08:51:48 +0000 (09:51 +0100)]
add gitignore
Signed-off-by: Jean-Pierre Gygax <gygax@practicomp.ch>
Jean-Pierre Gygax [Wed, 25 May 2011 08:50:58 +0000 (09:50 +0100)]
win32 update for vc 2010 contributed
Signed-off-by: Jean-Pierre Gygax <gygax@practicomp.ch>
Andy Green [Wed, 25 May 2011 08:48:03 +0000 (09:48 +0100)]
remove use mux blocks macro
Signed-off-by: Andy Green <andy@warmcat.com>
Andy Green [Tue, 24 May 2011 22:08:05 +0000 (23:08 +0100)]
x google mux change to new compact channel index scheme
Signed-off-by: Andy Green <andy@warmcat.com>
Andy Green [Tue, 24 May 2011 21:57:41 +0000 (22:57 +0100)]
x google mux introduce sticky mux opcode usage if ever used in channel
Signed-off-by: Andy Green <andy@warmcat.com>
Andy Green [Tue, 24 May 2011 21:07:45 +0000 (22:07 +0100)]
x google mux implement child close
This implements clean client and server close for mux child connections,
and deals with accounting for parent child lists.
The mux link can then survive constant connection bringup and teardown
found in the new test client.
Signed-off-by: Andy Green <andy@warmcat.com>
Andy Green [Tue, 24 May 2011 21:06:17 +0000 (22:06 +0100)]
test client add flag to defeat mux extension
Signed-off-by: Andy Green <andy@warmcat.com>
Andy Green [Tue, 24 May 2011 21:06:17 +0000 (22:06 +0100)]
test client make mirror data source channel open and close all the time
This changes the test client so that for the mirror protocol socket,
the lifetime of the connection is decided randomly to last on the order
of a second or so, then the connection is closed and a new one opened when
the close is complete.
This is to enhance testing of connection bringup and teardown especially
in mux case.
The overall functionality remains the same, spamming circles to all clients.
Signed-off-by: Andy Green <andy@warmcat.com>
Michel Archembault [Tue, 24 May 2011 18:07:16 +0000 (19:07 +0100)]
Modify Zlib VS project to be able to build in 64 bit
Signed-off-by: Michel Archembault <marchamb@matrox.com>
Michel Archambault [Tue, 24 May 2011 16:15:25 +0000 (17:15 +0100)]
Move include of gettimeofday.h to be able to build in C and C++
Signed-off-by: Michel Archambault <marchamb@matrox.com>
Michel Archembault [Tue, 24 May 2011 15:42:42 +0000 (16:42 +0100)]
move win32 zlib to correct place
Signed-off-by: Michel Archembault <marchamb@matrox.com>
Signed-off-by: Andy Green <andy@warmcat.com>
Andy Green [Tue, 24 May 2011 09:14:41 +0000 (10:14 +0100)]
dump active protocols and extensions at context create
Signed-off-by: Andy Green <andy@warmcat.com>
Andy Green [Tue, 24 May 2011 08:40:59 +0000 (09:40 +0100)]
fix parser reaction to zero length payloads
Zero length payloads aren't handled properly. This patch
should solve that.
Reported-by: Chee Wooi Saw <cheewooi@gtwholdings.com>
Signed-off-by: Andy Green <andy@warmcat.com>
Andy Green [Tue, 24 May 2011 08:34:50 +0000 (09:34 +0100)]
fix server ping coming as client payload
Client does auto-service server's ping, but then it
fell through and issued it as payload. This fixes that
so there is no payload issued.
Reported-by: Chee Wooi Saw <cheewooi@gtwholdings.com>
Signed-off-by: Andy Green <andy@warmcat.com>
Andy Green [Mon, 23 May 2011 09:00:03 +0000 (10:00 +0100)]
introduce x google mux very draft indeed
This is initial x-google-mux support. It's disabled by default
since it's very pre-alpha.
1) To enable it, reconfigure with --enable-x-google-mux
2) It conflicts with deflate-stream, use the -u switch on
the test client to disable deflate-stream
3) It deviates from the google standard by sending full
headers in the addchannel subcommand rather than just
changed ones from original connect
4) Quota is not implemented yet
5) Close of subchannel is not really implemented yet
6) Google opcode 0xf is changed to 0x7 to account for
v7 protocol changes to opcode layout
However despite those caveats, in fact it can run the
test client reliably over one socket (both dumb-increment
and lws-mirror-protocol), you can open a browser on the
same test server too and see the circles, etc.
Signed-off-by: Andy Green <andy@warmcat.com>
Michel Archambault [Sat, 14 May 2011 14:01:02 +0000 (16:01 +0200)]
win32 update projects
Signed-off-by: Michel Archambault <marchamb@matrox.com>
Signed-off-by: Andy Green <andy@warmcat.com>
Andy Green [Sat, 14 May 2011 13:08:00 +0000 (15:08 +0200)]
remove line end at 72 for base64 encode
Reported-by: Michel Archambault <marchamb@matrox.com>
Signed-off-by: Andy Green <andy@warmcat.com>
Andy Green [Sat, 14 May 2011 13:08:00 +0000 (15:08 +0200)]
win32 use binary flag on opening http file
Reported-by: Michel Archambault <marchamb@matrox.com>
Signed-off-by: Andy Green <andy@warmcat.com>
Andy Green [Sat, 14 May 2011 13:07:59 +0000 (15:07 +0200)]
make base 64 helper apis public
Signed-off-by: Andy Green <andy@warmcat.com>
Andy Green [Sat, 14 May 2011 13:07:56 +0000 (15:07 +0200)]
win32 move gettimeofday include inside extern c
Reported-by: Michel Archambault <marchamb@matrox.com>
Signed-off-by: Andy Green <andy@warmcat.com>
Andy Green [Sat, 14 May 2011 11:15:09 +0000 (13:15 +0200)]
win32 nuke autogenerated files from tree
These guys aren't needed in git
Reported-by: Michel Archambault <marchamb@matrox.com>
Signed-off-by: Andy Green <andy@warmcat.com>
Andy Green [Sat, 14 May 2011 11:12:01 +0000 (13:12 +0200)]
win32 fix release build
static inline blows up release builds on VC
Reported-by: Michel Archambault <marchamb@matrox.com>
Signed-off-by: Andy Green <andy@warmcat.com>
Andy Green [Fri, 29 Apr 2011 09:43:06 +0000 (17:43 +0800)]
fix deflate window
Mozilla implementationcan issue window of up to 15,
need to match it
Reported-by: Patrick McManus <pmcmanus@mozilla.com>
Signed-off-by: Andy Green <andy@warmcat.com>
Andy Green [Mon, 25 Apr 2011 15:54:11 +0000 (23:54 +0800)]
move send pipe choked api to public exports
Signed-off-by: Andy Green <andy.green@linaro.org>
Andy Green [Sun, 24 Apr 2011 07:12:38 +0000 (08:12 +0100)]
handle new masking order and fixups
Signed-off-by: Andy Green <andy@warmcat.com>
Andy Green [Sun, 24 Apr 2011 05:19:22 +0000 (06:19 +0100)]
interpret new opcode map when 07
Signed-off-by: Andy Green <andy@warmcat.com>
Andy Green [Sun, 24 Apr 2011 05:05:29 +0000 (06:05 +0100)]
issue new opcodes when 07
Signed-off-by: Andy Green <andy@warmcat.com>
Andy Green [Sun, 24 Apr 2011 05:04:03 +0000 (06:04 +0100)]
write client frames the new way for 07
Signed-off-by: Andy Green <andy@warmcat.com>
Andy Green [Sun, 24 Apr 2011 04:49:44 +0000 (05:49 +0100)]
carry over 06 stuff to 07
Signed-off-by: Andy Green <andy@warmcat.com>
Andy Green [Sun, 24 Apr 2011 04:46:23 +0000 (05:46 +0100)]
add 07 support
Signed-off-by: Andy Green <andy@warmcat.com>
Andy Green [Sat, 23 Apr 2011 09:54:53 +0000 (10:54 +0100)]
introduce 07 opcode ordering
Signed-off-by: Andy Green <andy@warmcat.com>
Andy Green [Sat, 16 Apr 2011 09:54:28 +0000 (10:54 +0100)]
fix frgmented server reply
Server handshake reply might not come in one packet as pointed out by
Pavel Borzenkov. This replaces his fix with one directly in the packet
state machine.
Signed-off-by: Andy Green <andy@warmcat.com>
Andy Green [Sat, 16 Apr 2011 09:46:21 +0000 (10:46 +0100)]
Revert Pavel's patch looping in recv
Signed-off-by: Andy Green <andy@warmcat.com>
Pavel Borzenkov [Fri, 15 Apr 2011 12:17:26 +0000 (13:17 +0100)]
Fix segfault in libwebsocket_write()
Since 'shift' has unsigned integer type,
the following code may lead to infinite cycle
and segfault:
while (shift >= 0) {
if (shift)
buf[0 - pre + n] =
((len >> shift) & 127) | 0x80;
else
buf[0 - pre + n] =
((len >> shift) & 127);
n++;
shift -= 7;
}
Change type to signed integer.
Signed-off-by: Pavel Borzenkov <pavel.borzenkov@auriga.com>
Pavel Borzenkov [Fri, 15 Apr 2011 12:16:58 +0000 (13:16 +0100)]
recv() may not return all data
While performing handshake recv() is called only once.
It may return only part of the data and handshake
will fail. This patch modifies libwebsocket_service_fd()
to ensure that there is not data left in the socket.
Signed-off-by: Pavel Borzenkov <pavel.borzenkov@auriga.com>
Pavel Borzenkov [Fri, 15 Apr 2011 12:16:32 +0000 (13:16 +0100)]
Use IPPROTO_TCP instead of SOL_TCP
This change fixes compilation on *BSD systems.
Signed-off-by: Pavel Borzenkov <pavel.borzenkov@auriga.com>
Pavel Borzenkov [Tue, 12 Apr 2011 08:47:50 +0000 (09:47 +0100)]
HTTP headers may be case-sensitive
For the IETF revision 00 send 'Upgrade: WebSocket' header
instead of 'Upgrade: websocket' as described in the IETF standard.
Some servers (for example, phpdaemon) are case-sensitive.
Signed-off-by: Pavel Borzenkov <pavel.borzenkov@auriga.com>
Andy Green [Tue, 22 Mar 2011 09:06:52 +0000 (09:06 +0000)]
select raw zlib compression
Patrick McManus from Mozilla pointed out that the spec requires a specific kind
of zlib compression, which is raw. You can select that by using a funny api in
zlib. Mozilla are correcting their compression to this, pywebsockets already did
it right in the first place, libwebsockets should now work OK with those.
Signed-off-by: Andy Green <andy@warmcat.com>
Andy Green [Tue, 22 Mar 2011 09:04:01 +0000 (09:04 +0000)]
pass ext pointer in ext callback
Signed-off-by: Andy Green <andy@warmcat.com>
Peter Hinz [Thu, 10 Mar 2011 18:19:10 +0000 (18:19 +0000)]
update win32 support for zlib
Signed-off-by: Peter Hinz <cerebusrc@gmail.com>
Peter Hinz [Thu, 10 Mar 2011 18:14:01 +0000 (18:14 +0000)]
Re: Windows port of your libwebsocket
The latest code changed need some win32 fixes:
Signed-off-by: Peter Hinz <cerebusrc@gmail.com>
Andy Green [Wed, 9 Mar 2011 15:13:52 +0000 (15:13 +0000)]
try to cover AF_LOCAL in libwebsockets_get_peer_addresses
Signed-off-by: Andy Green <andy@warmcat.com>
Andy Green [Wed, 9 Mar 2011 15:02:20 +0000 (15:02 +0000)]
use unsigned peer dotted quad
Reported-by: Pierre-Paul Lavoie <ppl@idios.org>
Signed-off-by: Andy Green <andy@warmcat.com>
Andy Green [Wed, 9 Mar 2011 09:21:24 +0000 (09:21 +0000)]
beautify fraggle
Signed-off-by: Andy Green <andy@warmcat.com>
Patrick McManus [Wed, 9 Mar 2011 07:18:28 +0000 (07:18 +0000)]
libwebsockets - gcc warnings
you have your makefiles set up to treat warnings as errors, and my gcc
4.4.5 (64 bit) compiler generates 3 warnings that need fixing:
(that sprintf() one is a real bug.. if ext_name contains formatting
characters you are looking at a potential segv).
Signed-off-by: Patrick McManus <mcmanus@ducksong.com>
Andy Green [Tue, 8 Mar 2011 08:56:57 +0000 (08:56 +0000)]
disable nagle algorithm
Ago noticed that some Windows clients experience small packets
from the server being aggregated and set after a long delay
(200-300ms).
He found that TCP_NODELAY on the socket solved this, I tested it
and it didn't have any noticable bad effect, so I implemented it
for all sockets, client and server.
Thans Ago for debugging this and notifying the cause.
Reported-by: Ago Allikmaa <maxorator@gmail.com>
Signed-off-by: Andy Green <andy@warmcat.com>
Andy Green [Tue, 8 Mar 2011 08:43:59 +0000 (08:43 +0000)]
clean fraggle
Signed-off-by: Andy Green <andy@warmcat.com>
Andy Green [Mon, 7 Mar 2011 21:40:59 +0000 (21:40 +0000)]
introduce fraggle test app
Signed-off-by: Andy Green <andy@warmcat.com>
Andy Green [Mon, 7 Mar 2011 21:16:31 +0000 (21:16 +0000)]
introduce libwebsocket_is_final_fragment
Signed-off-by: Andy Green <andy@warmcat.com>
Andy Green [Mon, 7 Mar 2011 21:14:23 +0000 (21:14 +0000)]
fix misunderstood fragmentation restriction
Signed-off-by: Andy Green <andy@warmcat.com>
Andy Green [Mon, 7 Mar 2011 20:47:41 +0000 (20:47 +0000)]
add CONTINUATION write mode
Signed-off-by: Andy Green <andy@warmcat.com>
Andy Green [Mon, 7 Mar 2011 20:47:41 +0000 (20:47 +0000)]
expose SHA1 api
Signed-off-by: Andy Green <andy@warmcat.com>
Andy Green [Mon, 7 Mar 2011 20:47:40 +0000 (20:47 +0000)]
expose random api
Signed-off-by: Andy Green <andy@warmcat.com>
Andy Green [Mon, 7 Mar 2011 20:47:39 +0000 (20:47 +0000)]
add separate server writeable and change naming to match rest of callbacks
Notice that the naming is changed, the notification to a server that it can write to
the client is now called LWS_CALLBACK_SERVER_WRITEABLE, and the notification to a client
that it can write to a server is LWS_CALLBACK_CLIENT_WRITEABLE.
Signed-off-by: Andy Green <andy@warmcat.com>
Andy Green [Mon, 7 Mar 2011 17:54:06 +0000 (17:54 +0000)]
remove bogus bytes on first line of websockets.c
Reported-by: Pierre-Paul Lavoie <ppl@idios.org>
Signed-off-by: Andy Green <andy@warmcat.com>