platform/upstream/dotnet/runtime.git
6 years agoRemoving unused Target
Jose Perez Rodriguez [Tue, 3 Apr 2018 23:16:23 +0000 (16:16 -0700)]
Removing unused Target

This target was only really for my testing and it accidentally made it to the final merge, so I'm reverting that piece now.

Commit migrated from https://github.com/dotnet/corefx/commit/2ed087eff0c2a9d8882dbbc1f22a92ae014625a3

6 years agoSslStream IDN mapping host name on Windows (dotnet/corefx#28725)
Krzysztof Wicher [Tue, 3 Apr 2018 21:50:55 +0000 (14:50 -0700)]
SslStream IDN mapping host name on Windows (dotnet/corefx#28725)

* SslStream IDN mapping host name on Windows

* Update SniHelper.cs

Commit migrated from https://github.com/dotnet/corefx/commit/e43901d03a3183c62dba9f354e51130a5c514a30

6 years agoAdding support for ncurses 6.1 TERM format on System.Console (dotnet/corefx#28786)
Jose Perez Rodriguez [Tue, 3 Apr 2018 20:28:53 +0000 (13:28 -0700)]
Adding support for ncurses 6.1 TERM format on System.Console (dotnet/corefx#28786)

Commit migrated from https://github.com/dotnet/corefx/commit/d8ee1a7389a8a9fd52fb08eb1da60f17ad0c82b0

6 years agoExisting Directory ReadOnlyVolume Disabled for alpine (dotnet/corefx#28783)
Anirudh Agnihotry [Tue, 3 Apr 2018 19:07:36 +0000 (12:07 -0700)]
Existing Directory ReadOnlyVolume Disabled for alpine (dotnet/corefx#28783)

Commit migrated from https://github.com/dotnet/corefx/commit/9403c51f2b14a2e31f5ad952c9ce28a75d4060c3

6 years agoFix grammar issue that made sentence ambiguous (dotnet/corefx#28785)
Daniel Imms [Tue, 3 Apr 2018 19:06:53 +0000 (12:06 -0700)]
Fix grammar issue that made sentence ambiguous (dotnet/corefx#28785)

Commit migrated from https://github.com/dotnet/corefx/commit/52897e9d76186004c3f8c6b1100fe7d6ff0a6089

6 years agoAdding test execution to the allConfigurations leg (dotnet/corefx#28663)
Jose Perez Rodriguez [Tue, 3 Apr 2018 18:48:52 +0000 (11:48 -0700)]
Adding test execution to the allConfigurations leg (dotnet/corefx#28663)

* Adding test execution to the allConfigurations leg

* Changing the root of tests to avoid long path issues

* Excluding NuGetFallbackFolder

* Test

* Fixing exclude so that NuGetFallbackFolder doesn't get copied

Commit migrated from https://github.com/dotnet/corefx/commit/f16ba601a2746a99ec9219adde277cb67bfd2da7

6 years agoMerge pull request dotnet/corefx#28779 from weshaggard/PinPlatformAbstractionVersions_m
Wes Haggard [Tue, 3 Apr 2018 17:35:47 +0000 (10:35 -0700)]
Merge pull request dotnet/corefx#28779 from weshaggard/PinPlatformAbstractionVersions_m

Pin PlatformAbstraction version to last stable

Commit migrated from https://github.com/dotnet/corefx/commit/495fa7bb44a04645c9baf8f50ec867ebdfac6aa3

6 years agoImprove throughput of Uri construction (dotnet/corefx#28776)
Stephen Toub [Tue, 3 Apr 2018 17:08:52 +0000 (10:08 -0700)]
Improve throughput of Uri construction (dotnet/corefx#28776)

Commit migrated from https://github.com/dotnet/corefx/commit/46c1fa7c5b26b85e5adece79fc4a45e472e476fa

6 years agoFix allocated Encoding memory initialization (dotnet/corefx#28720)
Tarek Mahmoud Sayed [Tue, 3 Apr 2018 17:06:31 +0000 (10:06 -0700)]
Fix allocated Encoding memory initialization (dotnet/corefx#28720)

* Fix allocated Encoding memory initialization

We allocate native memory using GlobalHAlloc which usually doesn’t zero out the allocated memory and that cause a problem when using this memory. We fixed similar issue before in SBCS but looks we missed the DBCS one.

* Use Unsafe.InitBlockUnaligned

* remove un-needed empty line

* remove space

* Include System.Runtime.CompilerServices.Unsafe to inbox packag

* fix package build breaks

Commit migrated from https://github.com/dotnet/corefx/commit/d5b142984587ac3c1b8562a76c83d5dede117289

6 years agoStop artificially rooting SocketAsyncEventArgs (dotnet/corefx#28767)
Stephen Toub [Tue, 3 Apr 2018 16:57:29 +0000 (09:57 -0700)]
Stop artificially rooting SocketAsyncEventArgs (dotnet/corefx#28767)

SocketAsyncEventArgs creates an overlapped object that references the SAEA.  That overlapped object creates an async pinning handle in the runtime, which roots the SocketAsyncEventArgs.  The cycle from SAEA->Overlapped->handle->SAEA involving the root means that a dropped SAEA that's not Dispose'd will end up leaking.

This commit fixes that by adding a level of indirection between the handle and the SAEA.  Rather than wrapping the SAEA directly, the handle is given an intermediate object that references the SAEA, and the SAEA then stores itself as a reference into that object only while an active operation is in progress.  Once the operation completes, the reference in that object is nulled out, and the SAEA will no longer be kept alive by the pinning handle.

Commit migrated from https://github.com/dotnet/corefx/commit/4d6521c572c44c5872281c125d8e341af054eec3

6 years agoPin PlatformAbstraction version to last stable
Wes Haggard [Fri, 30 Mar 2018 00:59:34 +0000 (17:59 -0700)]
Pin PlatformAbstraction version to last stable

We cannot depend on the latest PlatformAbstractions package
which is built from core-setup as it adds a cycle which we cannot
have in our source-build. To fix this temporarily we are pinning
to the last stable version 2.0.4.

See issue https://github.com/dotnet/corefx/issues/28620.

Commit migrated from https://github.com/dotnet/corefx/commit/bcc792badda16ef8bc8babf87ab67817d568219d

6 years agoFix ProxyExplicitlyProvided_DefaultCredentials_Ignored test (dotnet/corefx#28770)
Stephen Toub [Tue, 3 Apr 2018 16:00:59 +0000 (09:00 -0700)]
Fix ProxyExplicitlyProvided_DefaultCredentials_Ignored test (dotnet/corefx#28770)

I couldn't get it to fail locally, but I believe the issue was that sporadically WinHttpHandler would not reuse the original connection, in which case it would either not close the first and the test would hang because nothing was accepting the second connection, or it would close the first and fail because the server was expecting a second request on the connection.  This fixes it by using Connection: close on the first response so that the client won't reuse the same connection.

Commit migrated from https://github.com/dotnet/corefx/commit/586cffcdfdf23ad6c193a4bf37fce88a1bf69508

6 years agoFix build with xcode 9.3 (dotnet/corefx#28768)
Jan Vorlicek [Tue, 3 Apr 2018 15:38:24 +0000 (17:38 +0200)]
Fix build with xcode 9.3 (dotnet/corefx#28768)

The c_static_assert definition is causing build problems on OSX.
The compiler complains about the typedef we use to implement the
c_static_assert:
declaration shadows a typedef in the global scope [-Werror,-Wshadow]
This is due to multiple static asserts

To fix it, I have modified the c_static_assert to use _Static_assert
C feature that's available in clang.

Commit migrated from https://github.com/dotnet/corefx/commit/133d190320ecb2ff3f13a4e95c90b8e59bdd75e5

6 years agoMerge pull request dotnet/corefx#28744 from MattGal/debian-94-stuff
Matt Galbraith [Tue, 3 Apr 2018 15:32:24 +0000 (08:32 -0700)]
Merge pull request dotnet/corefx#28744 from MattGal/debian-94-stuff

Add new Debian.9.Amd64 queue

Commit migrated from https://github.com/dotnet/corefx/commit/d0c47fa0569cf024fcd7cc7dc3dfc4f4eeb71882

6 years agoAdd char.ToLower/Upper perf tests (dotnet/corefx#28765)
Stephen Toub [Tue, 3 Apr 2018 13:45:33 +0000 (06:45 -0700)]
Add char.ToLower/Upper perf tests (dotnet/corefx#28765)

Commit migrated from https://github.com/dotnet/corefx/commit/0ce0f2a2d55a4298d9d06ea29d26a28f14373ea3

6 years agoAdd more functional and perf tests for string.ToLower/Upper (dotnet/corefx#28748)
Stephen Toub [Tue, 3 Apr 2018 11:02:09 +0000 (04:02 -0700)]
Add more functional and perf tests for string.ToLower/Upper (dotnet/corefx#28748)

* Add more functional tests for string.ToLower/Upper{Invariant}

* Add more string.ToLower/Upper perf tests

Commit migrated from https://github.com/dotnet/corefx/commit/fd239bc73b05447a24cef9938c277f43171c1e06

6 years agoAdd new Debian.9.Amd64 queue. Debian's Azure versioning is unusual, so this queue...
Matt Galbraith [Tue, 3 Apr 2018 01:29:48 +0000 (18:29 -0700)]
Add new Debian.9.Amd64 queue.  Debian's Azure versioning is unusual, so this queue represents "newest available".

Commit migrated from https://github.com/dotnet/corefx/commit/fac2bf7062f534f5c7b2dcffb5702c7f89db82c9

6 years agoTests for Directory Exists (dotnet/corefx#28732)
Anirudh Agnihotry [Mon, 2 Apr 2018 23:06:45 +0000 (16:06 -0700)]
Tests for Directory Exists  (dotnet/corefx#28732)

Commit migrated from https://github.com/dotnet/corefx/commit/f759243d724f462da0bcef54e86588f8a55352c6

6 years agoSwitch threading perf tests to use constant instead of Benchmark.InnerIteration ...
Koundinya Veluri [Mon, 2 Apr 2018 22:11:34 +0000 (15:11 -0700)]
Switch threading perf tests to use constant instead of Benchmark.InnerIteration (dotnet/corefx#28728)

Commit migrated from https://github.com/dotnet/corefx/commit/bd8c8ed26d74c10d03e8b7b66864effddf2c6e19

6 years agoUpdate CoreFx, CoreSetup to preview3-26402-05, preview3-26402-02, respectively (dotne...
dotnet-maestro-bot [Mon, 2 Apr 2018 22:11:08 +0000 (17:11 -0500)]
Update CoreFx, CoreSetup to preview3-26402-05, preview3-26402-02, respectively (dotnet/corefx#28731)

Commit migrated from https://github.com/dotnet/corefx/commit/78bdc6e9b0f1dfcb805c2f8e9cf62d7854d88d90

6 years agoadd proxy bypass list processing for windows (dotnet/corefx#28210)
Tomas Weinfurt [Mon, 2 Apr 2018 20:45:51 +0000 (13:45 -0700)]
add proxy bypass list processing for windows (dotnet/corefx#28210)

* add bypass list processing

* remove 10.37.129.2

* update assembly references

* add bypass list processing

* remove 10.37.129.2

* update assembly references

* use Regex.Escape to escape . and [. Add more test cases.

* feedback from reviews

* fix some of the style comments. more changes to come.

* feedback from @stephentoub

* use UriHostNameType and IdnHost consistently to possibly avoid allocations. Add new test for various unexpected input

* replace String.Compare with string.Compare

Commit migrated from https://github.com/dotnet/corefx/commit/c9d1ec1764f421f35cfe0bbc71bf2f81bc8f0f8d

6 years agoUse a non-contigous Dictionary for tests (dotnet/corefx#28643)
Ben Adams [Mon, 2 Apr 2018 19:12:18 +0000 (20:12 +0100)]
Use a non-contigous Dictionary for tests (dotnet/corefx#28643)

Commit migrated from https://github.com/dotnet/corefx/commit/25c5878a7309b1361178e4eb3441af5b3e767c85

6 years agoSlight grammar improvement to coding-style.md (dotnet/corefx#28723)
Daniel Henry [Mon, 2 Apr 2018 19:09:20 +0000 (15:09 -0400)]
Slight grammar improvement to coding-style.md (dotnet/corefx#28723)

i.e. was being used when it really should have been e.g. (see: https://www.grammarly.com/blog/know-your-latin-i-e-vs-e-g/)

Commit migrated from https://github.com/dotnet/corefx/commit/aca57537adf4015a8a69e0ae386970d45bd60c9a

6 years agoUpdate CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview3-26402...
dotnet-maestro-bot [Mon, 2 Apr 2018 18:47:00 +0000 (13:47 -0500)]
Update CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview3-26402-06, preview3-26402-02, preview3-26402-01, beta-26402-01, beta-26402-01, respectively (dotnet/corefx#28710)

Commit migrated from https://github.com/dotnet/corefx/commit/54a988a8a3f91bcc0bbb0d4a92a656b9ab0b76c8

6 years agoFix ipv6 address format in Host header (dotnet/corefx#28578)
Caesar Chen [Mon, 2 Apr 2018 18:26:29 +0000 (11:26 -0700)]
Fix ipv6 address format in Host header (dotnet/corefx#28578)

* fix ipv6 format in host header

* address feedback

* address feedback

* fix common case

* reduce allocation

* address feedback

* fix indexof issue

* disable on curlhandler

* revert to simple fix

* address feedback and add comment

* address test issue, enable on curlhandler

* fix framework failure

* address feedback

Commit migrated from https://github.com/dotnet/corefx/commit/24889e293731f12b11f1205b641cd3e6cb3a3b90

6 years agoFix the message for Cryptography_InvalidPadding
Jeremy Barton [Mon, 2 Apr 2018 18:25:04 +0000 (11:25 -0700)]
Fix the message for Cryptography_InvalidPadding

Also audited all usages of this string to ensure they had the "the padding is wrong"
semantic instead of the "I don't know how to do this padding" semantic.  Only
one usage was seemingly wrong, and while it's in a Debug.Fail block it got fixed
anyways.

Commit migrated from https://github.com/dotnet/corefx/commit/5f574a5673026d9e361e6cf938b4a0f112e5bab2

6 years agoArrayMemoryPoolBuffer should only implement IMemoryOwner<T> (dotnet/corefx#28690)
Ben Adams [Mon, 2 Apr 2018 18:23:14 +0000 (19:23 +0100)]
ArrayMemoryPoolBuffer should only implement IMemoryOwner<T> (dotnet/corefx#28690)

* ArrayMemoryPoolBuffer should only implement IMemoryOwner<T>

* React pipelines to changes

Commit migrated from https://github.com/dotnet/corefx/commit/d67ea510c68dbce13e735bc18b7356822a0df235

6 years agoIncrease iteration counts in threading perf tests (dotnet/corefx#28712)
Koundinya Veluri [Mon, 2 Apr 2018 17:41:14 +0000 (10:41 -0700)]
Increase iteration counts in threading perf tests (dotnet/corefx#28712)

Relevant to https://github.com/dotnet/coreclr/issues/17345

Commit migrated from https://github.com/dotnet/corefx/commit/b01e361a6f8422b673c54c427c46710ab19b6e92

6 years agoUpdate CoreFx to preview3-26402-01 (dotnet/corefx#28706)
dotnet-maestro-bot [Mon, 2 Apr 2018 05:40:13 +0000 (00:40 -0500)]
Update CoreFx to preview3-26402-01 (dotnet/corefx#28706)

Commit migrated from https://github.com/dotnet/corefx/commit/6ae0da1563e6e701bac61012c62ede8f8737f065

6 years agoFix comment in AuthenticationHelper.NtAuth.cs
Stephen Toub [Mon, 2 Apr 2018 03:12:13 +0000 (23:12 -0400)]
Fix comment in AuthenticationHelper.NtAuth.cs

Commit migrated from https://github.com/dotnet/corefx/commit/6bcfd33ec5e6c3a8ebc81bd0cde0254f4f5a22b0

6 years agoUpdate CoreClr, CoreSetup to preview3-26402-01, preview3-26401-02, respectively ...
dotnet-maestro-bot [Mon, 2 Apr 2018 01:25:40 +0000 (20:25 -0500)]
Update CoreClr, CoreSetup to preview3-26402-01, preview3-26401-02, respectively (dotnet/corefx#28705)

Commit migrated from https://github.com/dotnet/corefx/commit/176dea50327c9fb49365872c11913e0f3c92019c

6 years agoif server sends invalid challenge, don't continue processing (dotnet/corefx#28704)
Geoff Kizer [Mon, 2 Apr 2018 01:06:52 +0000 (18:06 -0700)]
if server sends invalid challenge, don't continue processing (dotnet/corefx#28704)

Commit migrated from https://github.com/dotnet/corefx/commit/660dc94410cdaaba1bfc5bd6720e78eee5c5786c

6 years agoUpdate CoreClr, CoreFx, CoreSetup to preview3-26401-03, preview3-26401-02, preview3...
dotnet-maestro-bot [Sun, 1 Apr 2018 13:45:21 +0000 (06:45 -0700)]
Update CoreClr, CoreFx, CoreSetup to preview3-26401-03, preview3-26401-02, preview3-26401-01, respectively

Commit migrated from https://github.com/dotnet/corefx/commit/ff79c494f80b92ea260df24f9d8ae6bf959c6c5d

6 years agoFix intermittent crashes on FileSystemEnumeration on Unix (dotnet/corefx#28692)
Paulo Janotti [Sun, 1 Apr 2018 12:28:37 +0000 (05:28 -0700)]
Fix intermittent crashes on FileSystemEnumeration on Unix (dotnet/corefx#28692)

* Marking tests affected by 27740 as active issue

* ActiveIssue for other test in XmlSchema using TempDirectory

* Fix intermittent crash in FileSystemEnumerator for Unix

Commit migrated from https://github.com/dotnet/corefx/commit/b96c29aedf9b2f4197d161f632b4387a17be72f8

6 years agoFix thread constructor test on newer kernels (dotnet/corefx#28613)
Koundinya Veluri [Sun, 1 Apr 2018 11:26:11 +0000 (04:26 -0700)]
Fix thread constructor test on newer kernels (dotnet/corefx#28613)

Works around and closes https://github.com/dotnet/coreclr/issues/17170
- Works around an issue on linux-arm64 where pthread_create appears to reserve less stack space than requested without failing, and limits the max reserved stack size to the ulimit-configued value, leading to seg fault when the requested size of stack space is attempted to be used
- Fixed to write every page in the stack region that is being checked, to guarantee hitting the guard page in case of failure. The JIT's stack probe for stackalloc should cover this, https://github.com/dotnet/coreclr/issues/16827 details why that was not happening, in any case this test is not intended to test stack probing behavior, so this change makes the test a bit stronger in what it actually intends to test.

Commit migrated from https://github.com/dotnet/corefx/commit/d73eb9141ea4b8ca526881e7bbaebe5b36db0fe1

6 years agoCleanup Console.WriteLine() (dotnet/corefx#28687)
Marco Rossignoli [Sun, 1 Apr 2018 00:19:54 +0000 (02:19 +0200)]
Cleanup Console.WriteLine() (dotnet/corefx#28687)

* cleanup

* cleanup

Commit migrated from https://github.com/dotnet/corefx/commit/dfd9930b3471c3ed03281912506c9da5681f3b21

6 years agoCorrected a typo 'nanager' to 'manager' (dotnet/corefx#28684)
Alexander Radchenko [Sat, 31 Mar 2018 19:05:42 +0000 (02:05 +0700)]
Corrected a typo 'nanager' to 'manager' (dotnet/corefx#28684)

Commit migrated from https://github.com/dotnet/corefx/commit/f6a0db6b4d9fe1656eae0e1973b950fd595f8ab5

6 years agoUpdate issue-guide.md (dotnet/corefx#28685)
Saurabh Singh [Sat, 31 Mar 2018 19:04:44 +0000 (12:04 -0700)]
Update issue-guide.md (dotnet/corefx#28685)

Commit migrated from https://github.com/dotnet/corefx/commit/66c9cdc6d438b8a01c0afbdb65e2348cba9eb803

6 years agoUpdate CoreClr, CoreFx, CoreSetup to preview3-26331-05, preview3-26331-04, preview3...
dotnet-maestro-bot [Sat, 31 Mar 2018 13:46:14 +0000 (08:46 -0500)]
Update CoreClr, CoreFx, CoreSetup to preview3-26331-05, preview3-26331-04, preview3-26331-02, respectively (dotnet/corefx#28677)

Commit migrated from https://github.com/dotnet/corefx/commit/54d131f4174491bc2a7f5d6e4b0b8b725d299a8f

6 years agoAvoid unnecessarily propagating ExecutionContext in SocketAsyncEngine (dotnet/corefx...
Stephen Toub [Sat, 31 Mar 2018 13:14:03 +0000 (06:14 -0700)]
Avoid unnecessarily propagating ExecutionContext in SocketAsyncEngine (dotnet/corefx#28676)

SocketAsyncEngines are created lazily on-demand.  If we happen to create one at a point where there's a non-default ExecutionContext, we end up capturing that context onto the event loop thread, such that all subsequent dispatches capture and restore that ExecutionContext.

Commit migrated from https://github.com/dotnet/corefx/commit/ec5fb4162c8376cf8ced69f1d2442c586e9197f3

6 years agoMarking tests affected by 27740 in XmlSchemaValidatorApi as active issue (dotnet...
Paulo Janotti [Sat, 31 Mar 2018 12:57:25 +0000 (05:57 -0700)]
Marking tests affected by 27740 in XmlSchemaValidatorApi as active issue (dotnet/corefx#28679)

* Marking tests affected by 27740 as active issue

* ActiveIssue for other test in XmlSchema using TempDirectory

Commit migrated from https://github.com/dotnet/corefx/commit/fe0edc425686dc6d1229745daba253c3f6abde91

6 years agoDisable frequently failing GetAsync_SupportedSSLVersion_Succeeds test
Stephen Toub [Sat, 31 Mar 2018 05:01:45 +0000 (01:01 -0400)]
Disable frequently failing GetAsync_SupportedSSLVersion_Succeeds test

Commit migrated from https://github.com/dotnet/corefx/commit/031e40a64bd7a148f43e5a49055abbf5743b4543

6 years agoStop blocking explicit opt-in to Ssl2/3 in SslStream and HttpClient (dotnet/corefx...
Stephen Toub [Sat, 31 Mar 2018 05:00:37 +0000 (22:00 -0700)]
Stop blocking explicit opt-in to Ssl2/3 in SslStream and HttpClient (dotnet/corefx#28639)

By default, .NET Core defaults to allowing TLSv1, TLSv1.1, and TLSv1.2.  However, whereas .NET Framework allows a developer to opt-in to SSLv2/SSLv3, .NET Core currently blocks it.  This means developers are unable to use .NET Core when they need to communicate with an endpoint they don't control and that's unfortunately limited to one of these protocols, which blocks adoption of .NET Core.

This commit stops blocking these protocols.  They're still disabled by default, and compiling against them still results in a deprecation warning, but if a developer chooses to ignore the warning and explicitly sets SslProtocols, they are at least able to use the protocols, subject to whatever the underlying operating system allows (e.g. Windows stops supporting SSLv2 as of v1607).

Commit migrated from https://github.com/dotnet/corefx/commit/3cc6fda0c6abe76eea222c165ebdf816e83df564

6 years agoBump System.Data.SqlClient assembly version to 4.4.0. (dotnet/corefx#27011)
Cory Rivera [Sat, 31 Mar 2018 04:34:20 +0000 (21:34 -0700)]
Bump System.Data.SqlClient assembly version to 4.4.0. (dotnet/corefx#27011)

* Bump System.Data.SqlClient assembly version to 4.4.0.

Add UAP build configuration to SqlClient.

* Add build config for uap10.0.16299.

* Re-add uap to sqlclient package config.

Commit migrated from https://github.com/dotnet/corefx/commit/307401c673c3e25ab8402664f22fba271b1dabb5

6 years agoAdd tests for calling Span APIs via reflection to verify graceful failures. (dotnet...
Ahson Khan [Sat, 31 Mar 2018 04:24:49 +0000 (21:24 -0700)]
Add tests for calling Span APIs via reflection to verify graceful failures. (dotnet/corefx#28674)

* Add tests for calling Span APIs via reflection to verify graceful failures.

* Add Span reflection tests to verify graceful failures

* Address PR feedback (test cleanup and rename)

* Fix up some test names

* Minor tweak: Reorder the tests

* Exclude running the reflection tests for portable span (netfx)

* Remove unused constant from csproj

Commit migrated from https://github.com/dotnet/corefx/commit/a7b59b08f3f92038011ff967efcc250fc305c925

6 years agoUpdate BuildTools, CoreClr, CoreFx to preview3-02631-01, preview3-26331-01, preview3...
dotnet-maestro-bot [Sat, 31 Mar 2018 03:36:41 +0000 (22:36 -0500)]
Update BuildTools, CoreClr, CoreFx to preview3-02631-01, preview3-26331-01, preview3-26331-02, respectively (dotnet/corefx#28670)

Commit migrated from https://github.com/dotnet/corefx/commit/808edc21eb60ef03f792fefc019f594caf936aab

6 years agoReact to X509Chain changes in macOS 10.13.4 (dotnet/corefx#28673)
Jeremy Barton [Sat, 31 Mar 2018 03:22:55 +0000 (20:22 -0700)]
React to X509Chain changes in macOS 10.13.4 (dotnet/corefx#28673)

10.13.4 changed some of the detail codes for building the X509ChainStatusFlag values.

"ValidLeaf" (etc) => "TemporalValidity"
"WeakLeaf" (etc) => "WeakKeySize"
new "MissingIntermediate" when the chain didn't complete instead of "AnchorTrusted" lower down.

Commit migrated from https://github.com/dotnet/corefx/commit/e49a617ba2a98a54b10c8a520b17cb05e9618b30

6 years agoEmit less junk from Process test (dotnet/corefx#28669)
Dan Moseley [Sat, 31 Mar 2018 03:04:22 +0000 (20:04 -0700)]
Emit less junk from Process test (dotnet/corefx#28669)

Commit migrated from https://github.com/dotnet/corefx/commit/2a7568d64228249a9ec1d40a56130c576213b159

6 years agoAdding test checking working Directory in childProcess (dotnet/corefx#28628)
Anirudh Agnihotry [Sat, 31 Mar 2018 01:31:57 +0000 (18:31 -0700)]
Adding test checking working Directory in childProcess (dotnet/corefx#28628)

Commit migrated from https://github.com/dotnet/corefx/commit/415e0aa8d5c9988ccb1cc73276bb0145f7901e11

6 years agoMerge pull request dotnet/corefx#28638 from stephentoub/shhallocs
Stephen Toub [Sat, 31 Mar 2018 01:27:39 +0000 (18:27 -0700)]
Merge pull request dotnet/corefx#28638 from stephentoub/shhallocs

Some more allocation reduction in SocketsHttpHandler

Commit migrated from https://github.com/dotnet/corefx/commit/26f3de6527bdde97d589134d10780a418dd9ff98

6 years agoSslStream mutates state of options (dotnet/corefx#28666)
Krzysztof Wicher [Sat, 31 Mar 2018 01:23:30 +0000 (18:23 -0700)]
SslStream mutates state of options (dotnet/corefx#28666)

* decouple SslState from SslServerAuthenticationOptions

* rename certCallback to certSelectionCallback

* remove mutable ServerCertSelectionCallback from SslServerAuthenticationOptions

* remove mutable RemoteCertValidationCallback from SslServerAuthenticationOptions

* fix FakeSslState to match args

Commit migrated from https://github.com/dotnet/corefx/commit/00bcad0f047186047d3021584b732a8c5d124376

6 years agoFontFamily.Equals in Linux use .Name instead of NativeFamily pointer which is not...
Santiago Fernandez Madero [Sat, 31 Mar 2018 00:57:59 +0000 (19:57 -0500)]
FontFamily.Equals in Linux use .Name instead of NativeFamily pointer which is not a singleton (dotnet/corefx#28650)

* FontFamily.Equals in Linux use .Name instead of NativeFamily pointer which is not a singleton

* Fix tests and PR Feedback

Commit migrated from https://github.com/dotnet/corefx/commit/6f38488ee5097d0b9b9332a8eb173dd03ae8e49f

6 years agoUpdate BuildTools to preview3-02630-02 (dotnet/corefx#28619)
dotnet-maestro-bot [Sat, 31 Mar 2018 00:29:32 +0000 (19:29 -0500)]
Update BuildTools to preview3-02630-02 (dotnet/corefx#28619)

Commit migrated from https://github.com/dotnet/corefx/commit/906d23f764ffd84f9d8ba2c5e1bc2468a79a0c68

6 years agoRemoving System.Runtime.Caching/src/MatchingRefApiCompatBaseline.txt (dotnet/corefx...
Konst Khurin [Sat, 31 Mar 2018 00:25:19 +0000 (17:25 -0700)]
Removing System.Runtime.Caching/src/MatchingRefApiCompatBaseline.txt (dotnet/corefx#28665)

Commit migrated from https://github.com/dotnet/corefx/commit/a9ecb8ed5647881a6ccbf6f80bac1b031e1a9d21

6 years agoremove empty baseline files (dotnet/corefx#28656)
Jiayi Yu [Fri, 30 Mar 2018 22:26:46 +0000 (15:26 -0700)]
remove empty baseline files (dotnet/corefx#28656)

Commit migrated from https://github.com/dotnet/corefx/commit/e3694f9b8a69d21d1cb0e30412b7e52079ae69d6

6 years agoMerge pull request dotnet/corefx#28659 from weshaggard/EnableOptionalToolsInNoTestDef
Wes Haggard [Fri, 30 Mar 2018 22:25:07 +0000 (15:25 -0700)]
Merge pull request dotnet/corefx#28659 from weshaggard/EnableOptionalToolsInNoTestDef

Enable optional tools in no-test build definition

Commit migrated from https://github.com/dotnet/corefx/commit/62614491cedaff7ae85f0f8dd4e906bd0d6edc2a

6 years agoAddress PR feedback
Stephen Toub [Fri, 30 Mar 2018 21:34:33 +0000 (17:34 -0400)]
Address PR feedback

Commit migrated from https://github.com/dotnet/corefx/commit/9f9b34a2dd82cbd19766c720748bf50f37968752

6 years agoSplit OwnedMemory into MemoryManager and IMemoryOwner (dotnet/corefx#28640)
Ahson Khan [Fri, 30 Mar 2018 21:30:48 +0000 (14:30 -0700)]
Split OwnedMemory into MemoryManager and IMemoryOwner (dotnet/corefx#28640)

* Update IRetainable, OwnedMemory, and MemoryHandle APIs

* Split OwnedMemory into MemoryManager and IMemoryOwner

* Update ReadOnlySequence, ArrayMemoryPool, and BufferSegment

* Update System.Memory and System.IO.Pipeline tests

* Temporarily skipping the failing Pipelines tests until impl is corrected.

* Update the reference assembly to match implementation and cleanup

* Update API compat baseline for UAPAOT and add GenFacadesIgnoreMissingTypes

* Fix the System.Runtime ref

* Add back the Pin methods to the uapaot api compat baseline

* Clone the API compat baseline from uapaot and add it for uap as well.

* Update BuildTools, CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview3-02630-01, preview3-26330-08, preview3-26330-06, preview3-26330-04, beta-26330-00, beta-26330-00, respectively

* Fix pipelines tests and update the api compat baseline shim for uapaot

* Add empty Unpin override to pipe pool test.

* Fix the System.Net.Http Functional tests

Commit migrated from https://github.com/dotnet/corefx/commit/f592e887e2349ed52af6a83070c42adb9d26408c

6 years agoFix race condition on read ahead task in SocketsHttpHandler (dotnet/corefx#28637)
Stephen Toub [Fri, 30 Mar 2018 21:25:29 +0000 (14:25 -0700)]
Fix race condition on read ahead task in SocketsHttpHandler (dotnet/corefx#28637)

We're supposed to only use a ValueTask<int> once.  But there's a race condition where we may not only use one more than once, we might do so concurrently, resulting in a variety of different exceptions depending on how the race condition manifests.

When we take a connection out of the connection pool, we want to check whether it's still valid for use.  We could poll, but since the request/response is going to need to issue at least one read anyway, we just do so preemptively, then checking whether the read completed synchronously (if it did, we can't use the connection).  This gets stored in a field on the HttpConnection that can later be read.  However, we may also create the read ahead task in another situation, which is if we're unable to easily fish out the underlying socket used by the connection (as happens with tunneling), when the pool periodically scavenges and looks for dead connections, rather than polling it just issues that read even earlier.  Doing so, however, means that we'll have kicked off tasks that are likely to complete with an exception if the connection is terminated in an unfriendly manner.  To avoid such exceptions spamming TaskScheduler.UnobservedTaskException, we check this stored task when disposing the connection.

That, however, creates the race condition.  If the connection is disposed (e.g. due to cancellation) at just the wrong time, the request/response may be in the process of working with that initial read just as the disposal goes to interact with that same read ahead task.  Badness results.

The fix is to add a tiny amount of synchronization, such that just one call site can take ownership of the read ahead task.

Commit migrated from https://github.com/dotnet/corefx/commit/366496832fbf9c893a33ebed176d6e053c721ca1

6 years agoRemove buffer argument from WebSocket.CreateFromStream (dotnet/corefx#28649)
Stephen Toub [Fri, 30 Mar 2018 21:23:56 +0000 (14:23 -0700)]
Remove buffer argument from WebSocket.CreateFromStream (dotnet/corefx#28649)

Commit migrated from https://github.com/dotnet/corefx/commit/bf38b7b8c56e7fbe10796dcfa1918a36377a1cd6

6 years agoEnable optional tools in no-test build definition
Wes Haggard [Fri, 30 Mar 2018 21:18:48 +0000 (14:18 -0700)]
Enable optional tools in no-test build definition

We produce our nuget packages in the allconfigurations leg
which uses the notest build definition. In order for us to
embed optimization data we need to enable the optional tools
and pass in the EnableProfileGuidedOptimization=true property

Commit migrated from https://github.com/dotnet/corefx/commit/9919aa9e7ed18a6a74960e535638a35b5d2103f0

6 years agoFixing two additional package tests (dotnet/corefx#28654)
Jose Perez Rodriguez [Fri, 30 Mar 2018 21:18:21 +0000 (14:18 -0700)]
Fixing two additional package tests (dotnet/corefx#28654)

Commit migrated from https://github.com/dotnet/corefx/commit/2d4a49d7a9c609042391f56b2a6cdce1179aaabd

6 years agoFix 1DES and RC2 CryptoServiceProvider CreateTransform tests on Unix
Jeremy Barton [Fri, 30 Mar 2018 17:46:18 +0000 (10:46 -0700)]
Fix 1DES and RC2 CryptoServiceProvider CreateTransform tests on Unix

Commit migrated from https://github.com/dotnet/corefx/commit/3f376c305c214d3f621ab2158dc4b9e804035d49

6 years agoMake TripleDESCryptoServiceProvider CreateTransform behave like netfx
Jeremy Barton [Thu, 29 Mar 2018 22:54:53 +0000 (15:54 -0700)]
Make TripleDESCryptoServiceProvider CreateTransform behave like netfx

.NET Framework's TripleDESCryptoServiceProvider rejects small inputs, but
accepts oversized IVs (effectively truncating them to the block size).  This
change makes the .NET Core type behave the same way, and adds a test to
codify all of the oversized IV relationships with the CryptoServiceProvider
compat types.  (DES and RC2 apparently already allowed it)

Commit migrated from https://github.com/dotnet/corefx/commit/78357cf19232383d8e6b5356b760bf4c2f0e2f09

6 years agoAdd server-side SNI support (dotnet/corefx#28278)
Krzysztof Wicher [Fri, 30 Mar 2018 21:00:44 +0000 (14:00 -0700)]
Add server-side SNI support (dotnet/corefx#28278)

* add initial implementation for server side SNI support

* remove analyzerdata

* add braces around single line if statements and inline simple functions

* fix deadlock on linux

* add test with special characters

* IDN decoding

* idn unmapping (with fallback)

* apply feedback, fix netfx/uwp

* rename the SNIHelper to SniHelper

* rename test file as well (git does not like renames on windows)

* change file casing in csproj

* test should expect AuthenticationException

* add SniHelper tests

* apply review feedback

* shorten SNI (limit is 63 bytes)

* replace remaining constants

* test behavior on truncated client hello

* add structures descriptions

* apply review feedback

* get rid of the new dependency and add a test for invalid utf-8 bytes

Commit migrated from https://github.com/dotnet/corefx/commit/2d39212fc69a6c0a78c48a3ad8e191ca94872548

6 years agoMaking types listed in dotnet/corefx#27980 internal (dotnet/corefx#28636)
Konst Khurin [Fri, 30 Mar 2018 20:24:51 +0000 (13:24 -0700)]
Making types listed in dotnet/corefx#27980 internal (dotnet/corefx#28636)

Commit migrated from https://github.com/dotnet/corefx/commit/f6ff5c214bc9ad1d409913c789398be3e5546948

6 years agoFix Microsoft.VisualBasic Ref API surface issues (dotnet/corefx#28531)
Omar Tawfik [Fri, 30 Mar 2018 19:58:55 +0000 (15:58 -0400)]
Fix Microsoft.VisualBasic Ref API surface issues (dotnet/corefx#28531)

* Fix Microsoft.VisualBasic Ref API surface issues

* PR Comments

Commit migrated from https://github.com/dotnet/corefx/commit/74126cad20a1d86e44b52e0f12983f9c855886a1

6 years agoUsing random string for temp files (dotnet/corefx#28589)
Anirudh Agnihotry [Fri, 30 Mar 2018 19:35:45 +0000 (12:35 -0700)]
Using random string for temp files (dotnet/corefx#28589)

Commit migrated from https://github.com/dotnet/corefx/commit/73e8a1f8130a792e6661819e6236533576fca45a

6 years agoFix ConnectionTimeoutTestWithThread test (dotnet/corefx#28618)
Gene Lee [Fri, 30 Mar 2018 18:51:15 +0000 (11:51 -0700)]
Fix ConnectionTimeoutTestWithThread test (dotnet/corefx#28618)

Commit migrated from https://github.com/dotnet/corefx/commit/94fe40287a5f61e96b09acaabacce55210ced8a0

6 years agoFix MatchingRefApiCompat issues (dotnet/corefx#28369)
Gene Lee [Fri, 30 Mar 2018 18:50:41 +0000 (11:50 -0700)]
Fix MatchingRefApiCompat issues (dotnet/corefx#28369)

Commit migrated from https://github.com/dotnet/corefx/commit/7cd16376a835ffd4fd981d2e9b813b82a6985d91

6 years agoDo not resume reader on 0-byte FlushAsync (dotnet/corefx#28550)
Pavel Krymets [Fri, 30 Mar 2018 18:40:39 +0000 (11:40 -0700)]
Do not resume reader on 0-byte FlushAsync (dotnet/corefx#28550)

Commit migrated from https://github.com/dotnet/corefx/commit/82518b91848023b521621a18896270b72aaf0ae3

6 years agoFix MatchingRefApiCompat issues in Serialization libraries (dotnet/corefx#28552)
Jiayi Yu [Fri, 30 Mar 2018 18:30:35 +0000 (11:30 -0700)]
Fix MatchingRefApiCompat issues in Serialization libraries (dotnet/corefx#28552)

* Fixes: System.Xml.XmlSerializer/src/MatchingRefApiCompatBaseline.uap.txt

* fixes System.Xml.XmlSerializer/src/MatchingRefApiCompatBaseline.uapaot.txt

* Fixes: System.Xml.XmlSerializer/src/MatchingRefApiCompatBaseline.netcoreapp.txt

* Fixes: System.Runtime.Serialization.Xml/src/MatchingRefApiCompatBaseline.txt

* Bring back ReadString() as it is used somewhere else

* fix build errors

Commit migrated from https://github.com/dotnet/corefx/commit/3d6e00c9be13dc047810d2ca877671b3bed6fd41

6 years agoMake AuthenticationException message less platform-specific (dotnet/corefx#28645)
Stephen Toub [Fri, 30 Mar 2018 16:54:08 +0000 (09:54 -0700)]
Make AuthenticationException message less platform-specific (dotnet/corefx#28645)

SSPI is a Windows thing.

Commit migrated from https://github.com/dotnet/corefx/commit/d1d5135ef69f0b64001694d93a6a9fc4cd23d23b

6 years agoReduce buffering in ManagedWebSocket.ReceiveAsync (dotnet/corefx#28577)
Stephen Toub [Fri, 30 Mar 2018 16:53:26 +0000 (09:53 -0700)]
Reduce buffering in ManagedWebSocket.ReceiveAsync (dotnet/corefx#28577)

* Change SocketsHttpHandler's 101 response stream to buffer response reads

The connection already has a buffer; use it.

* Reduce buffering in ManagedWebSocket.ReceiveAsync

Today we use a big-ish receive buffer, reading all data into the receive buffer and then copying from there into the caller-provided destination buffer.  With this change, we assume that the underlying stream is providing the desired level of buffering, and thus only use a buffer small enough to handle message headers and control payloads (the latter for simplicity, as no caller-supplied buffer is available there).

* Change ClientWebSocket to avoid creating a large buffer

Commit migrated from https://github.com/dotnet/corefx/commit/06aa6f0ce4cdf78985f029f218007a7d55f8965f

6 years agoMerge pull request dotnet/corefx#28600 from ericstj/packageTesting
Eric StJohn [Fri, 30 Mar 2018 15:04:00 +0000 (08:04 -0700)]
Merge pull request dotnet/corefx#28600 from ericstj/packageTesting

Fix package testing infrastructure and fix issues.

Commit migrated from https://github.com/dotnet/corefx/commit/ef52017da09efe47200479001988e924720598b0

6 years agoUpdate dogfood instructions with current SDK version (dotnet/corefx#28601)
Eric Erhardt [Fri, 30 Mar 2018 13:51:54 +0000 (08:51 -0500)]
Update dogfood instructions with current SDK version (dotnet/corefx#28601)

Commit migrated from https://github.com/dotnet/corefx/commit/458ee023de704eb468f0a7cbaa5924828e57aeb0

6 years agoSupport musl-libc based linux RIDs (dotnet/corefx#28560)
Eric Erhardt [Fri, 30 Mar 2018 13:14:54 +0000 (08:14 -0500)]
Support musl-libc based linux RIDs (dotnet/corefx#28560)

* Support musl-libc based linux RIDs

- Add `linux-musl` RID
- Set `alpine`'s parent to `linux-musl`
- Add `alpine.3.7` to the graph
- Fix up `android` to inherit from `unix` while we are here

Fixes https://github.com/dotnet/core-setup/issues/3817

* Change linux-musl to be parented to linux.

* Reparent android RID to linux.

Commit migrated from https://github.com/dotnet/corefx/commit/81ba6280047eb1129fd4938e54626d1f973fd281

6 years agoPool SocketAsyncEventArgs used to establish connections
Stephen Toub [Thu, 29 Mar 2018 06:06:11 +0000 (23:06 -0700)]
Pool SocketAsyncEventArgs used to establish connections

SocketAsyncEventArgs is a heavy object to use once and throw away.  This change lets us pool and reuse them.

Commit migrated from https://github.com/dotnet/corefx/commit/da8c62d22bc68eed381f1a3c7b895150e5b21946

6 years agoSplit ConcurrentQueue<T>.Segment into its own file
Stephen Toub [Thu, 29 Mar 2018 05:51:47 +0000 (22:51 -0700)]
Split ConcurrentQueue<T>.Segment into its own file

Commit migrated from https://github.com/dotnet/corefx/commit/fdfc497e7c22f8513ee785ce94a5148632e84645

6 years agoRemove string allocation from CookieContainer ctor
Stephen Toub [Thu, 29 Mar 2018 05:04:40 +0000 (22:04 -0700)]
Remove string allocation from CookieContainer ctor

There's no need to recompute the same string every time a CookieContainer is created.

Commit migrated from https://github.com/dotnet/corefx/commit/e7a796128e12d618be00aecda8e80708e0cba865

6 years agoDispose connections immediately when returned to a pool with zero timeouts
Stephen Toub [Thu, 29 Mar 2018 04:44:27 +0000 (21:44 -0700)]
Dispose connections immediately when returned to a pool with zero timeouts

Commit migrated from https://github.com/dotnet/corefx/commit/b4301aad9ee8de67e47345a7cc40fcdd95a286ca

6 years agoAvoid creating cleaning timer if no connections will ever be added to pool
Stephen Toub [Thu, 29 Mar 2018 04:29:08 +0000 (21:29 -0700)]
Avoid creating cleaning timer if no connections will ever be added to pool

Commit migrated from https://github.com/dotnet/corefx/commit/48719a0c3b49ad788320fe3c65b918b0ff97810c

6 years agoRemove long running option from MARS (dotnet/corefx#28627)
Saurabh Singh [Fri, 30 Mar 2018 01:52:27 +0000 (18:52 -0700)]
Remove long running option from MARS (dotnet/corefx#28627)

Commit migrated from https://github.com/dotnet/corefx/commit/ee4aa4f1d29c6fb4f415577efcc7e14fe029b0ad

6 years agoRe-enable GetTaskSchedulersForDebugger test (dotnet/corefx#28564)
Jan Kotas [Fri, 30 Mar 2018 00:41:07 +0000 (17:41 -0700)]
Re-enable GetTaskSchedulersForDebugger test (dotnet/corefx#28564)

Fixes dotnet/corefx#28539

Commit migrated from https://github.com/dotnet/corefx/commit/5ffc9b3dd6a3ee0bd128c63e2698617101827d23

6 years agoMerge pull request dotnet/corefx#28616 from weshaggard/FixPackageBuildFiltering
Wes Haggard [Fri, 30 Mar 2018 00:22:11 +0000 (17:22 -0700)]
Merge pull request dotnet/corefx#28616 from weshaggard/FixPackageBuildFiltering

Account for source-build in our package build filtering

Commit migrated from https://github.com/dotnet/corefx/commit/f8933eb2df82fd25b62541f342682cd738c120e5

6 years agoUsing System.ComponentModel.Composition vs. System.Composition to get exports (dotnet...
Maryam Ariyan [Thu, 29 Mar 2018 23:16:31 +0000 (16:16 -0700)]
Using System.ComponentModel.Composition vs. System.Composition to get exports (dotnet/corefx#28483)

* Adding test showing using "where" clause in exported interface works fine.

Related to dotnet/corefx#23607

* Applying PR feedbacks

* Using TypeCatalog instead of AssemblyCatalog to export value

* Add tests in System.Composition

* Simplifying arguments to TypeCatalog, only listing the exports

* Moving test

Commit migrated from https://github.com/dotnet/corefx/commit/5830df27f7a3556c1edab91867c5ef926698f1db

6 years agoMake it clear that the default proxy cannot by set via environment variable on Window...
Max Kerr [Thu, 29 Mar 2018 22:41:18 +0000 (15:41 -0700)]
Make it clear that the default proxy cannot by set via environment variable on Windows (dotnet/corefx#28610)

* Remove ActiveIssue tag to make it clear this is by design.

* Disable test using attribute.

Commit migrated from https://github.com/dotnet/corefx/commit/620d01432fd37e69cb106752524bed24185a422b

6 years agoDisable OOBing for Vectors on NCA2.1 and UAP6+
Eric St. John [Thu, 29 Mar 2018 15:48:25 +0000 (08:48 -0700)]
Disable OOBing for Vectors on NCA2.1 and UAP6+

Fixes dotnet/corefx#26834

Vectors forwards types to S.P.C but we were oobing the non-facade implementation assembly.
As a result, when using the package we switch from using type-forwards to using the types
defined in the assembly. This will break type unification.

We can decide to either:
1. Put placeholders in the package and effectively freeze the API.
2. Put the partial facades in the package.

System.Buffers had a similar problem and we decided to use placeholders. It was slightly different since it was a full facade.

The pro of going with 1 is that it simplifies the build.  The con is that it freezes the API:
 future additions would need to be in a new netstandard version.  Additionally it means
that new packages can't deliver bugfixes out-of-band.

We can always unfreeze the API in the future by bringing back a live build for netcoreapp2.1
that builds against S.P.C. This allows us to effectively switch to 2 *as needed*.

As a result I will go with option1.

Commit migrated from https://github.com/dotnet/corefx/commit/2d420dddeaa0c21b37550dc69a76c6da66b6d1f7

6 years agoFix missing System.Memory dependency from Registry
Eric St. John [Thu, 29 Mar 2018 15:30:13 +0000 (08:30 -0700)]
Fix missing System.Memory dependency from Registry

Since Registry only targeted netcoreapp2.0 for Unix, only the Unix-specific dependencies
were listed in the netcoreapp2.0 dependency group.  This was a problem since the windows
netstandard impl required System.Memory but the unix netcoreapp2.0 impl did not.

As a result netcoreapp2.0 was missing the System.Memory dependency.

Commit migrated from https://github.com/dotnet/corefx/commit/fd7048cbadc466e09fdfd51339dc347a3411276d

6 years agoMS.NETCore.Targets should not be tested on 1.x as it drops all runtime-dependencies
Eric St. John [Thu, 29 Mar 2018 15:11:39 +0000 (08:11 -0700)]
MS.NETCore.Targets should not be tested on 1.x as it drops all runtime-dependencies

Commit migrated from https://github.com/dotnet/corefx/commit/f78d8f5bb2dbf45805c637605dd3b8f44c7b73a9

6 years agoPermit cycles in netstandard when testing OOB packages
Eric St. John [Thu, 29 Mar 2018 15:10:51 +0000 (08:10 -0700)]
Permit cycles in netstandard when testing OOB packages

Commit migrated from https://github.com/dotnet/corefx/commit/e449875413a846cbbeb84e0e23e0f988de31e8e7

6 years agoEnable package testing of latest NETCoreApp2.1
Eric St. John [Wed, 28 Mar 2018 21:51:21 +0000 (14:51 -0700)]
Enable package testing of latest NETCoreApp2.1

Commit migrated from https://github.com/dotnet/corefx/commit/1c6f2fa2845716aadbcab66a07a575a44fa6ad47

6 years agoEnsure we run on private CLI/SDK and not a newer machine wide one
Eric St. John [Wed, 28 Mar 2018 21:49:09 +0000 (14:49 -0700)]
Ensure we run on private CLI/SDK and not a newer machine wide one

Also continue on error.

Commit migrated from https://github.com/dotnet/corefx/commit/96ca4023fe4b9ab15256360dc85850512b66fa40

6 years agoExclude CoreFx.Private.TestUtilities from testing
Eric St. John [Wed, 28 Mar 2018 21:48:29 +0000 (14:48 -0700)]
Exclude CoreFx.Private.TestUtilities from testing

Commit migrated from https://github.com/dotnet/corefx/commit/ab8633a949090a528868e83d4948581454a745e1

6 years agoEnsure we test runtime closure
Eric St. John [Wed, 28 Mar 2018 21:47:50 +0000 (14:47 -0700)]
Ensure we test runtime closure

We were skipping it because the condition was evaluating before references were resolved.

Conflict resolution was also knocking out files because we weren't setting SelfContained to turn off the platform manifest.

Commit migrated from https://github.com/dotnet/corefx/commit/a74bc9bc3b209013bf0d46dc14cc7baa428cafc6

6 years agoFix System.Security.Permissions facade.
Eric St. John [Wed, 28 Mar 2018 18:41:49 +0000 (11:41 -0700)]
Fix System.Security.Permissions facade.

Commit migrated from https://github.com/dotnet/corefx/commit/1d0b45103fac33487b738c0289b849f4ac4b89dd

6 years agoPermit type overlap between System.Memory and S.P.Corelib on netcoreapp2.0
Eric St. John [Wed, 28 Mar 2018 17:31:12 +0000 (10:31 -0700)]
Permit type overlap between System.Memory and S.P.Corelib on netcoreapp2.0

In netcoreapp2.0 the types in CoreLib were experimental and should not be exposed by System.Memory.

Commit migrated from https://github.com/dotnet/corefx/commit/fd04b17b728aa93ad06cfce20faa52c8e81f8b11

6 years agoAccount for source-build in our package build filtering
Wes Haggard [Thu, 29 Mar 2018 17:56:26 +0000 (10:56 -0700)]
Account for source-build in our package build filtering

We need to account for source-build which sets the
OfficialBuildId property to replicate the official builds,
so we also look at the DotNetBuildOffline property to
determine that we should still build the all the packages.

Commit migrated from https://github.com/dotnet/corefx/commit/2219e550dd790a91fe3dd68874c347c711bccc14

6 years agoFix compat pack publish script to work if we build corefx on debug or release mode...
Santiago Fernandez Madero [Thu, 29 Mar 2018 20:54:11 +0000 (15:54 -0500)]
Fix compat pack publish script to work if we build corefx on debug or release mode (dotnet/corefx#28608)

Commit migrated from https://github.com/dotnet/corefx/commit/b50c15c4d798413b671b2a4cad20d2923a3abec2

6 years agoSgen parameter conversion change: replace colon with space in arguments (dotnet/coref...
Jiayi Yu [Thu, 29 Mar 2018 19:56:25 +0000 (12:56 -0700)]
Sgen parameter conversion change: replace colon with space in arguments (dotnet/corefx#28439)

* replace colon with space in argument

* ErrInvalidArgument

* fixes according to pr comments

* update usage message

* usage message

* Fix reference arg method

* Update Microsoft.XmlSerializer.Generator.targets

Commit migrated from https://github.com/dotnet/corefx/commit/a4c601d34b5eabfc708b2e368e33d22f0360e2bf