Jonathan Peppers [Tue, 23 Apr 2019 19:21:21 +0000 (14:21 -0500)]
Remove Xamarin.Android.Support.v7.MediaRouter (#5941)
Context: https://github.com/xamarin/xamarin-android/issues/2982
The Blank Xamarin.Forms app template in VS 2019 takes longer to build
than in VS 2017. A little research is showing that this is due to use
of the 28.x support libraries... For example, the build includes ~20
*more* jar files in the template from 2019 than 2017. The
`_CompileDex` step alone goes from ~15.2s to ~18.2s.
This lead me down the road of investigating if we can remove any
support libraries by default in Xamarin.Forms apps. I am also seeing
if there is more we can do in Xamarin.Android for this problem, in
general.
It looks like we can remove:
* Xamarin.Android.Support.v7.MediaRouter
* Xamarin.Android.Support.Media.Compat
Neither of these appear to be used, but have been listed as
dependencies of Xamarin.Forms for a long time.
~~ Results ~~
I made these changes, then did a `Debug` build of
`Xamarin.Forms.ControlGallery.Android.csproj` for comparison.
Comparing dex file sizes (in bytes):
Before:
3428092 classes.dex
3265616 classes2.dex
6693708 total
After:
4938000 classes.dex
1098772 classes2.dex
6036772 total
This looks like it could potentially save ~600KB of compiled dex code
on every Xamarin.Forms app.
Comparing methods:
Before:
classes.dex 11,492 methods
classes2.dex 19,451 methods
total 30,943 methods
After:
classes.dex 22,171 methods
classes2.dex 7,635 methods
total 29,806 methods
~1,137 methods removed, which should help with the dex limit.
Comparing APK sizes (in bytes):
Before:
26442597 AndroidControlGallery.AndroidControlGallery-Signed.apk
After:
25741701 AndroidControlGallery.AndroidControlGallery-Signed.apk
~700KB smaller APK, due to less .NET assemblies & dex code.
Comparing build time (this was using dx):
Before:
19785 ms CompileToDalvik 1 calls
After:
18532 ms CompileToDalvik 1 calls
Looks like it saved over a second of build time for this project.
Seems like an "easy win", let's do this!
E.Z. Hart [Mon, 22 Apr 2019 22:44:12 +0000 (16:44 -0600)]
[UWP] Allow embedding Forms page in secondary window (#5658)
* Make secondary window work in UWP (fixes #2229)
* Update Xamarin.Forms.Core/Internals/Ticker.cs
Co-Authored-By: hartez <hartez@users.noreply.github.com>
puppetSpace [Mon, 22 Apr 2019 21:05:54 +0000 (23:05 +0200)]
Add UITest for issue 1763 (#5907)
* Add UITest for issue 1763
* Removed restriction for Windows Only. Also added the PreserveAttribute on the classes the test used.
E.Z. Hart [Mon, 22 Apr 2019 00:41:10 +0000 (18:41 -0600)]
Testing a theory about an unreliable memory leak test (#5964)
Rui Marinho [Thu, 18 Apr 2019 15:27:58 +0000 (16:27 +0100)]
Merge branch '4.0.0'
Shane Neuville [Thu, 18 Apr 2019 15:25:58 +0000 (09:25 -0600)]
[Android] move runtime registration of renderers to its own method (#5946)
* move renderer registration to its own method
* - move to static
Shane Neuville [Thu, 18 Apr 2019 15:25:31 +0000 (09:25 -0600)]
[Shell] Propagate Page bindings to TitleView and Shell Binding to Flyout (#5934) fixes #5650 fixes #5501
* propagate bindingcontext
* - add exception message and fix poorly named xaml file
* add ui test automation
* - fix unit test to represent new code
* - changed from ui test to unit test
* - propagate visual, parent, bc to titleview
* - style fixes
Rui Marinho [Thu, 18 Apr 2019 15:15:48 +0000 (16:15 +0100)]
Merge branch '3.6.0' into 4.0.0
Rui Marinho [Thu, 18 Apr 2019 15:14:47 +0000 (16:14 +0100)]
[Build] Fixes to yaml public build (#5948)
* [Build] Don't sign on public builds
* [Build] Use vmImages
* [Build] Fix pool specification
* [Build] Revert back to pool name
* [Build] add osx demands
* [Build] Fix indentation
* [Build] Add more demands
* [Build] Try using certs
* [Build] Try use name
* cert password
* [Build] Add endpoint back
* [Build] Add VSTS feed as variable
* [Build] Add signing stuff
* Fix
* [Build] Try simplify Windows build
* [Build] Publish android apps
* [Build] Add signVmImage
Andrei [Thu, 18 Apr 2019 01:11:31 +0000 (04:11 +0300)]
macOs: fixes NRE in during entryRenderer disposing (#5914)
fixes https://github.com/xamarin/Xamarin.Forms/issues/5881
Shane Neuville [Wed, 17 Apr 2019 17:59:16 +0000 (11:59 -0600)]
Move IElementConfiguration to an internal structure on Cell (#5850)
* Move IElementConfiguration to an internal structure on Cell
* set custom ElementConfiguration to private
* fix comments
E.Z. Hart [Wed, 17 Apr 2019 16:13:10 +0000 (10:13 -0600)]
Remove need for PressEnter on test 5535 because it crashes iOS 12 tests
Larry O'Brien [Tue, 16 Apr 2019 22:04:55 +0000 (12:04 -1000)]
s/SearchBoxVisiblity/SearchBoxVisibility/ from base 4.0.0 (#5931)
* s/SearchBoxVisiblty/SearchBoxVisibility/
Fix typo in type name.
* s/Collapsable/Collapsible/
* Changed capitalization in comment
Shane Neuville [Tue, 16 Apr 2019 16:38:17 +0000 (10:38 -0600)]
remove used Group Header Template (#5906)
Samantha Houts [Mon, 15 Apr 2019 21:54:48 +0000 (14:54 -0700)]
Merge branch '4.0.0'
Rui Marinho [Mon, 15 Apr 2019 21:24:50 +0000 (22:24 +0100)]
[iOS] Fix usage of iOS11 api (#5893)
* [iOS] Fix usage of iOS11 api
* [iOS] Fix remaining calls to HomeIndicatorHidden feature
Kangho Hur [Mon, 15 Apr 2019 16:55:56 +0000 (01:55 +0900)]
[Material] [Tizen] Adds Xamarin.Forms.Material.Tizen for Visual (#5453)
* [Tizen] Adds Xamarin.Forms.Material.Tizen for Visual
* Update Tizen.NET.MaterialComponent for applying color scheme
* Don't build XF.Material.Tzien on iPhone and iPhoneSimulator
* Fix MCanvas build issue
* Update build-windows.yml for XF.Material.Tizen
Shane Neuville [Mon, 15 Apr 2019 16:22:47 +0000 (10:22 -0600)]
[Shell] Hide Shell types from being browsable (#5915)
* set shell things to EditorBrowsable false
* - EditorBrowsable always
* delete tab content
Samantha Houts [Sat, 13 Apr 2019 01:28:49 +0000 (18:28 -0700)]
Merge branch '3.6.0' into 4.0.0
Shane Neuville [Fri, 12 Apr 2019 23:25:54 +0000 (17:25 -0600)]
- add explicit references back into nuspec (#5902)
Pavel Yakovlev [Fri, 12 Apr 2019 16:33:33 +0000 (19:33 +0300)]
[Android, shell] fixes visibility of tabs after their changes (#5896)
Samantha Houts [Thu, 11 Apr 2019 05:03:02 +0000 (22:03 -0700)]
Merge branch '4.0.0'
Samantha Houts [Thu, 11 Apr 2019 04:59:38 +0000 (21:59 -0700)]
Merge branch '3.6.0' into 4.0.0
piotrkonowalski [Thu, 11 Apr 2019 04:58:34 +0000 (06:58 +0200)]
[iOS] Add Platform Specific features for PrefersHomeIndicatorAutoHidden (#5717)
fixes #5310
Shane Neuville [Thu, 11 Apr 2019 04:54:50 +0000 (22:54 -0600)]
[Shell] refactor of processing uris (#5852)
fixes #5790
Samantha Houts [Thu, 11 Apr 2019 04:53:37 +0000 (21:53 -0700)]
[Android/iOS] TabIndex sets focus order for TalkBack traversal (#3989)
fixes #2789
E.Z. Hart [Thu, 11 Apr 2019 04:28:11 +0000 (22:28 -0600)]
Porting fix from 4794 to handle clip bounds on sub-API-19 Android; fixes #4790 (#5863)
fixes #4790
Samantha Houts [Thu, 11 Apr 2019 00:25:45 +0000 (17:25 -0700)]
[Android] Null check on Switch TrackDrawable (#5851)
* [Android] Null check on Switch TrackDrawable
fixes #5553
* Add a few more checks, dispose Drawable, fix copy/paste error
* Couple more for safety's sake
Stephane Delcroix [Wed, 10 Apr 2019 23:10:54 +0000 (01:10 +0200)]
[X] update Cecil (#5878)
- fixes #5875
Kevin Petit [Mon, 18 Feb 2019 11:24:26 +0000 (12:24 +0100)]
[Android] Fix ObjectDisposedException on MasterDetailPageRenderer update (#4955)
* Android - MasterDetailPageRenderer - Fix ObjectDisposedException on update.
* Fix update call to master.
* Move checks inside update methods.
Add HandleMasterPropertyChanged handler unsubscribing.
puppetSpace [Wed, 10 Apr 2019 16:43:10 +0000 (18:43 +0200)]
Create UITest for issue B44476 (#5859)
fixes #2381
Shane Neuville [Wed, 10 Apr 2019 00:40:28 +0000 (18:40 -0600)]
[Android] add another gc.collect for Android to ensure all is collected (#5847)
* add another gc.collect for Android
* move all gc collects to a helper
Shane Neuville [Wed, 10 Apr 2019 00:36:53 +0000 (18:36 -0600)]
Add automated test for Bugzilla41205 (#5826)
fixes #2353
Sunner [Tue, 9 Apr 2019 18:16:39 +0000 (20:16 +0200)]
Implemented ImageButtonRenderer for WPF (#5668)
* Added ImageButton renderer for WPF
* Removed private modifiers
fixes #4991
Samantha Houts [Tue, 9 Apr 2019 17:31:33 +0000 (10:31 -0700)]
Update issue templates
ShaneN [Mon, 8 Apr 2019 19:17:37 +0000 (13:17 -0600)]
merge 4.0.0 into master
Stephane Delcroix [Mon, 8 Apr 2019 19:09:04 +0000 (21:09 +0200)]
Merge branch '3.6.0' into 4.0.0
Rui Marinho [Mon, 8 Apr 2019 17:15:53 +0000 (18:15 +0100)]
[iOS] Fix when we render the font icon image as original (#5753)
fixes #5071
Stephane Delcroix [Mon, 8 Apr 2019 17:15:14 +0000 (19:15 +0200)]
[C] allow inheriting from Behavior (#5559)
- fixes #5520
yourina [Mon, 8 Apr 2019 16:54:41 +0000 (01:54 +0900)]
Add the ShellRenderer for Tizen (#5818)
Shane Neuville [Mon, 8 Apr 2019 16:48:23 +0000 (10:48 -0600)]
update build script for mac and readme based on vs mac 2019 (#5827)
Pedro Jesus [Mon, 8 Apr 2019 15:17:49 +0000 (12:17 -0300)]
Create UITest for Bugzilla41619 (#5829)
* - create UITest for Bugzilla41619
* - remove the hard code
Pavel Yakovlev [Sat, 6 Apr 2019 03:42:41 +0000 (06:42 +0300)]
[Android] fixes material placeholder (#5823)
E.Z. Hart [Fri, 5 Apr 2019 12:02:29 +0000 (06:02 -0600)]
Increase API level check for setting Android ripple effect on selection (#5760) fixes #5693
Fixes #5693
Tim Barham [Fri, 5 Apr 2019 05:31:28 +0000 (15:31 +1000)]
XamlLoader should not ignore x:TypeArguments on root node (#5804)
kingces95 [Thu, 4 Apr 2019 20:38:27 +0000 (10:38 -1000)]
Revert "Man init (#5587) closes #5248" (#5814)
This reverts commit
0b69ead5a034dbc6535ed9768e5b79998b1939a3.
kingces95 [Thu, 4 Apr 2019 18:50:39 +0000 (08:50 -1000)]
Man init (#5587) closes #5248
* man init
* man init w/o profile
* Update Xamarin.Forms.Platform.Android/Forms.cs
Co-Authored-By: rmarinho <me@ruimarinho.net>
Andres G. Aragoneses [Thu, 4 Apr 2019 11:23:45 +0000 (19:23 +0800)]
[Core] Add some Device.InvokeOnMainThread helpers (#5028)
* [Core] Add some Device.InvokeOnMainThread helpers
These helpers keep popping up on forums/stackoverflow[1][2],
would be nice to include them out of the box.
[1] https://forums.xamarin.com/discussion/51720/wait-for-device-begininvokeonmainthread
[2] https://stackoverflow.com/a/
47941859
* [Core] Add a helper to get the mainthread's SynchronizationContext
It might be handy to expose it, so that F# devs can use it when
employing the Async.SwitchToContext API.
Stephane Delcroix [Thu, 4 Apr 2019 06:55:24 +0000 (08:55 +0200)]
Merge branch '4.0.0'
Andrei [Wed, 3 Apr 2019 17:00:48 +0000 (20:00 +0300)]
[macOS] Fixes #5257 (#5262)
E.Z. Hart [Wed, 3 Apr 2019 16:49:05 +0000 (10:49 -0600)]
Allow EmptyView swapping in Android CollectionView (#5720) fixes #5535
* Automated test for issue
* Fix empty view swapping for Android (fixes #5535)
* Remove private modifier
* Account for null Flags when setting flags for test
* Fix rebase issue
Stephane Delcroix [Wed, 3 Apr 2019 13:19:48 +0000 (15:19 +0200)]
[X] check for null on the parent property (#5796)
In case of value types in Compiled Binding Paths, we weren't checking
for null property on the right part of the path
before
```csharp
bindingExtension.TypedBinding = new TypedBinding<Gh5770, Color>(delegate(Gh5770 gh)
{
if (gh == null)
{
return new ValueTuple<Color, bool>(default(Color), false);
}
Gh5770VM expr_24 = gh.MyContentViewModel;
return new ValueTuple<Color, bool>(expr_24.TextColor, true);
}, ..., ...);
```
after
```csharp
bindingExtension.TypedBinding = new TypedBinding<Gh5770, Color>(delegate(Gh5770 gh)
{
if (gh == null)
{
return new ValueTuple<Color, bool>(default(Color), false);
}
Gh5770VM expr_24 = gh.MyContentViewModel;
if (expr_24 == null)
{
return new ValueTuple<Color, bool>(default(Color), false);
}
return new ValueTuple<Color, bool>(expr_24.TextColor, true);
}, ..., ...);
```
- fixes #5770
Stephane Delcroix [Wed, 3 Apr 2019 13:19:33 +0000 (15:19 +0200)]
[X] resolve generic indexer types (#5794)
- fixes #5510
Stephane Delcroix [Wed, 3 Apr 2019 07:27:13 +0000 (09:27 +0200)]
[C] SearchHandler.SelectedItem (#5775)
- fixes #5712
Stephane Delcroix [Wed, 3 Apr 2019 06:49:40 +0000 (08:49 +0200)]
try to avoid merge conflicts in GitInfo.txt (#5715)
Stephane Delcroix [Wed, 3 Apr 2019 06:49:01 +0000 (08:49 +0200)]
[Shell] propagate BindingContext to SearchHandler (#5730)
- fixes #5705
Shane Neuville [Wed, 3 Apr 2019 02:13:35 +0000 (20:13 -0600)]
fix reference to local folder (#5792)
Rui Marinho [Tue, 2 Apr 2019 17:28:23 +0000 (18:28 +0100)]
Merge branch '3.6.0' into 4.0.0
Stephane Delcroix [Tue, 2 Apr 2019 16:52:48 +0000 (18:52 +0200)]
[Shell] propagate BC to BackButtonBehavior (#5743) fixes #5734
- fixes #5734
no test, as it's straightforward, and mimics #5730
Matthew Leibowitz [Tue, 2 Apr 2019 15:06:59 +0000 (17:06 +0200)]
[nuspec] Start using the 28.x versions of Android support (#5512)
Stephane Delcroix [Tue, 2 Apr 2019 08:02:44 +0000 (10:02 +0200)]
[C] change searchHandler bindingMode (#5776)
Change the default BindingMode for some properties
- fixes #5706
Pavel Yakovlev [Tue, 2 Apr 2019 02:45:41 +0000 (05:45 +0300)]
[UItest] Added dynamic view gallery (#5402)
E.Z. Hart [Tue, 2 Apr 2019 02:34:36 +0000 (20:34 -0600)]
Fix UI test 4600 for Android/iOS; fixes #4943 (#5726)
Shane Neuville [Mon, 1 Apr 2019 20:25:01 +0000 (14:25 -0600)]
Extend Control Gallery to allow for Shell UI Tests (#5740)
* enable UI tests for shell
* - fix test for ios shell
* - add scrollview so success is visible on ios
* - add instructions
* - add shell category
Shane Neuville [Mon, 1 Apr 2019 20:07:59 +0000 (14:07 -0600)]
Add covariance back to IElementConfiguration (#5771)
* add covariance back
* - remove confusing comment
Andrei Nitescu [Mon, 1 Apr 2019 18:12:40 +0000 (21:12 +0300)]
Map with ItemTemplateSelector (#5226)
* Map with ItemTemplateSelector
* Fixed Map test
Shane Neuville [Mon, 1 Apr 2019 08:53:53 +0000 (02:53 -0600)]
Check if Element parent is null before getting the padding insets (#5757)
* Check if Element parent is null before getting the padding insets
* - move if up earlier
Shane Neuville [Mon, 1 Apr 2019 08:52:18 +0000 (02:52 -0600)]
Shell.CurrentShell is too many Shells (#5761)
Samantha Houts [Thu, 28 Mar 2019 00:14:57 +0000 (17:14 -0700)]
Merge branch '4.0.0'
Samantha Houts [Thu, 28 Mar 2019 00:13:02 +0000 (17:13 -0700)]
Merge branch '3.6.0' into 4.0.0
Samantha Houts [Wed, 27 Mar 2019 23:41:38 +0000 (16:41 -0700)]
[iOS] Don't crash if no Thumbnail specified for AppLink (#5684)
* Add test for #5470
* [iOS] Don't crash if no Thumbnail specified for AppLink
fixes #5470
* Add braces
* fix test on Android
Andrei Nitescu [Wed, 27 Mar 2019 23:38:45 +0000 (01:38 +0200)]
Removed dependency on modernhttpclient (#5390)
fixes #1886
Pavel Yakovlev [Wed, 27 Mar 2019 23:26:05 +0000 (02:26 +0300)]
[UWP] Fixes the casting crash of the FontImageSource (#5678)
Shane Neuville [Wed, 27 Mar 2019 23:10:21 +0000 (17:10 -0600)]
[visual] Add extra parameter to android visual constructors (#5289)
* [visual] Add extra parameter to android visual constructors
* - add null check and constructor to Material Button Renderer to prove scenario
E.Z. Hart [Wed, 27 Mar 2019 23:03:35 +0000 (17:03 -0600)]
Handle DataTemplateSelector on iOS/Android CollectionView (#5429)
* DataTemplateSelector working on Android for ItemTemplate and EmptyTemplate
* Demonstrate DataTemplateSelector working with EmptyViewTemplate
* Handle DataTemplateSelector on iOS CollectionView
* Add UI test
Fixes #4826
* Temporarily patching EditorRenderer to get tests running
* Add test for binding errors;
Fix binding errors on Android;
* Fix binding errors for iOS
* Add flag setting to allow UI test to run
* Fix rebase errors
Stephane Delcroix [Wed, 27 Mar 2019 18:52:12 +0000 (19:52 +0100)]
[C] alias shell names (#5624)
* [C] alias shell names
* - change from ShellTab to Tab
Rui Marinho [Wed, 27 Mar 2019 18:51:38 +0000 (18:51 +0000)]
Merge branch '3.6.0' into 4.0.0
E.Z. Hart [Wed, 27 Mar 2019 18:38:38 +0000 (12:38 -0600)]
Re-enable "Treat warnings as errors" (#5602)
* Enable "treat warnings as errors"
* Remove unnecessary for loop
* Remove properties which already exist in base class
* Make property hiding explicit and obsolete hiding property
* Move Treat Warnings as Errors setting to props file
* Fix weird quotation changes in Xamarin.Forms.Build.Tasks.csproj
* Scrub empty WarningsAsErrors tags
* Remove unused variable
* Fix TearDown method hiding in UI tests
* Fix Id member hiding in test for Bugzilla32871
* Fix RootPage member hiding in Bugzilla51503
* Fix RooPage member hiding in Issue1483
* Disable warnings for deprecated OpenGL calls
* Fix member hiding in test view models
* Fix RootPage member hiding in Issue1931
* Fix Id member hiding in Bugzilla42620
* Fix AutomationId member hiding in Bugzilla57114
* Fix Layout member hiding in Bugzilla40911
* Remove unused variables from Bugzilla31114
* Remove unused variable
* Fix various unused variable warnings
* Disable warning to leave example code for reference
* Fix unused variable from macOS test
* Remove unused members
* Fix unused variable warnings
* Fixed unused property warnings
* Fix warnings for unused code
* Disable 'await' warning
* Remove unused variable
* Adding pragma directives for await warnings
* Remove member hiding
* Turn off global "Treat warnings as errors" in other platforms
* Use MarkerId instead of obsolete Id member
* Fix await warnings in WPF GeocoderBackend
* Add missing await
* Disable warning for unused event
Shane Neuville [Wed, 27 Mar 2019 18:32:47 +0000 (12:32 -0600)]
remove covariant out on IElementConfiguration (#5449) closes #5235
Rui Marinho [Wed, 27 Mar 2019 17:05:21 +0000 (17:05 +0000)]
[Shell] Add FlyoutIcon (#5567) fixes #4766 fixes #4767 fixes #4845 fixes #5219
* [Controls] Add repo for shell issue
* [iOS] Allow specify SetPaddingInsets on the ShellContent
* [iOS,Shell] Fix issue when disposing ToolbarItems of old page
* [Controls] Add demo repo for #5466
* [Shell,Core] Fix navigating to a registered route
* [Shell,Core] Add better exception messages for wrong or non existing content fixes #5081
* [Core,Shell,iOS,Android] Add FlyoutIcon property
* [Controls] Make shell sample work on Android
* [Controls,Android] Add ImageSource support to FlyoutIcon
* [Android]Allow to set text on the back button
* [Android] Create default text back button
* [Controls] Add example to push with back button behavior
* [Android] Fix back button tint color
* [Android] Cleanup and refactor UpdateDrawerArrow
* Update Xamarin.Forms.Platform.Android/Renderers/ShellToolbarTracker.cs
Co-Authored-By: rmarinho <me@ruimarinho.net>
* [iOS,Shell] Fix go back (Pop) when proving BackButtonBehavior
* [iOS] Check the ParentViewController since we were push to it
* [Android,iOS,Shell] Remove extra code implement feedback
* removed old code
* minor cleanup
Shane Neuville [Wed, 27 Mar 2019 16:07:15 +0000 (10:07 -0600)]
[Android] Fix various issues with material found by a full run of the UI Tests with Material active (#5676)
* - locate activity
* get tests to run
* - fix and force core gallery to work against default
* - fix check if control already disposed
* - fixing what automationid assigns to
* - input transparent fixes
* - fix sandbox back
* - set default visual back to default
* Update Xamarin.Forms.Material.Android/MaterialStepperRenderer.cs
* Update Xamarin.Forms.Material.Android/MaterialSliderRenderer.cs
* - fix core gallery ui tests to find container
* - ui test tweak
* - fix background color on pickers
* - suggested changes
* - suggested fix
Stephane Delcroix [Wed, 27 Mar 2019 14:41:53 +0000 (15:41 +0100)]
bump
Stephane Delcroix [Wed, 27 Mar 2019 14:41:20 +0000 (15:41 +0100)]
bump
Stephane Delcroix [Wed, 27 Mar 2019 14:40:50 +0000 (15:40 +0100)]
bump
Shane Neuville [Wed, 27 Mar 2019 11:58:35 +0000 (05:58 -0600)]
[Android] don't clear shell content because native page isn't visible (#5671) fixes #4684
* [Android] don't clear shell content because native page isn't visible
* - move checks up a line
yourina [Wed, 27 Mar 2019 11:20:56 +0000 (20:20 +0900)]
[Tizen] Support the Keyboard, MaxLength, IsSpellCheckEnabled, IsReadOnly propertyon SearchBarRenderer (#5688) fixes #2902
kingces95 [Wed, 27 Mar 2019 11:20:21 +0000 (01:20 -1000)]
dispose FrameRenderer's FrameDrawable (#5617) fixes #5446
Rui Marinho [Tue, 26 Mar 2019 22:58:29 +0000 (22:58 +0000)]
[CollectionView] Fixes for ObservableCollection usage on Android and iOS (#4664)
* [Controls] Update CollectionView observable gallery
* [Controls] Add test case with timer to add items to ObservableCollection
* [Android] Implement IDisposable on IItemsViewSource
* [iOS] ObservableItemSource takes a IList
* [iOS] Update ItemsViewLayout.cs
* [Android] Implement review feedback
* [Controls] Fix adder
* [Build] Update submodule
* [Android] Make similar change to iOS for consistency
* [iOS] Unsubscribe from ObservableCollection on ItemsViewController
* [iOS] Dispose ItemsController
* [Build] Update submodule
Rui Marinho [Tue, 26 Mar 2019 22:56:27 +0000 (22:56 +0000)]
[Shell] Fix Register route and Navigate to it (#5564) fixes #5466
* [Controls] Add repo for shell issue
* [iOS] Allow specify SetPaddingInsets on the ShellContent
* [Shell,iOS] Fix toolbaritems on Shell
* [Controls] Add demo repo for #5466
* [Shell,Core] Fix navigating to a registered route
* [Controls] Fix android example add missing images
* nested routing
* [Controls] Fix build on pre app compact
Pavel Yakovlev [Tue, 26 Mar 2019 18:42:05 +0000 (21:42 +0300)]
[Android] Fixes ObjectDisposedException when call Unfocus of Entry (#5670)
* [Android] Fixes ObjectDisposedException when call Unfocus of Entry
* address comment
* fix ui test
Akihiko Odaki [Tue, 26 Mar 2019 14:49:05 +0000 (23:49 +0900)]
[Xaml] Throw XamlParseException when a duplicate property is detected (#5558)
jcmanke [Tue, 26 Mar 2019 14:02:30 +0000 (09:02 -0500)]
Set ImeOptions to Done on Android Editor (#5653)
* Set ImeOptions to Done on Android Editor
* Apply fix to Material Editor renderer
- fixes #4832
- fixes #5030
Rui Marinho [Mon, 25 Mar 2019 14:47:28 +0000 (14:47 +0000)]
[Build] Update major version
Rui Marinho [Mon, 25 Mar 2019 14:45:56 +0000 (14:45 +0000)]
Merge branch '4.0.0'
Rui Marinho [Mon, 25 Mar 2019 14:42:52 +0000 (14:42 +0000)]
[Build] Update verssion
Rui Marinho [Mon, 25 Mar 2019 14:42:29 +0000 (14:42 +0000)]
Merge branch '3.6.0' into 4.0.0
Rui Marinho [Mon, 25 Mar 2019 11:54:50 +0000 (11:54 +0000)]
Merge branch '3.5.0' into 3.6.0
Rui Marinho [Mon, 25 Mar 2019 11:47:05 +0000 (11:47 +0000)]
[Build] Fix suffix check
Rui Marinho [Mon, 25 Mar 2019 11:06:21 +0000 (11:06 +0000)]
Merge branch '3.5.0' into 3.6.0
Rui Marinho [Mon, 25 Mar 2019 11:05:22 +0000 (11:05 +0000)]
[Update] Yaml build