Lennart Poettering [Fri, 22 Dec 2017 14:07:22 +0000 (15:07 +0100)]
process-util: move fork_agent() to process-util.[ch]
It's a relatively small wrapper around safe_fork() now, hence let's move
it over, and make its signature even more alike. Also, set a different
process name for the polkit and askpw agents.
Lennart Poettering [Fri, 22 Dec 2017 12:31:55 +0000 (13:31 +0100)]
tree-wide: properly name all threads we fork off
Lennart Poettering [Fri, 22 Dec 2017 12:25:14 +0000 (13:25 +0100)]
udev: some very trivial coding style updates
Lennart Poettering [Fri, 22 Dec 2017 12:24:40 +0000 (13:24 +0100)]
tree-wide: use EXIT_SUCCESS/EXIT_FAILURE in exit() where we can
Lennart Poettering [Fri, 22 Dec 2017 12:19:56 +0000 (13:19 +0100)]
shutdown: unify shutdown.c's and async.c's sync() helper process
The helper processes are pretty much the same now, let's unify them
hence.
Lennart Poettering [Fri, 22 Dec 2017 12:08:14 +0000 (13:08 +0100)]
tree-wide: introduce new safe_fork() helper and port everything over
This adds a new safe_fork() wrapper around fork() and makes use of it
everywhere. The new wrapper does a couple of things we previously did
manually and separately in a safer, more correct and automatic way:
1. Optionally resets signal handlers/mask in the child
2. Sets a name on all processes we fork off right after forking off (and
the patch assigns useful names for all processes we fork off now,
following a systematic naming scheme: always enclosed in () – in order
to indicate that these are not proper, exec()ed processes, but only
forked off children, and if the process is long-running with only our
own code, without execve()'ing something else, it gets am "sd-" prefix.)
3. Optionally closes all file descriptors in the child
4. Optionally sets a PR_SET_DEATHSIG to SIGTERM in the child, in a safe
way so that the parent dying before this happens being handled
safely.
5. Optionally reopens the logs
6. Optionally connects stdin/stdout/stderr to /dev/null
7. Debug logs about the forked off processes.
Lennart Poettering [Sat, 23 Dec 2017 23:54:40 +0000 (00:54 +0100)]
terminal-util: open /dev/null with O_CLOEXEC in make_stdio_null()
Ultimately, O_CLOEXEC should be off in fd 0, 1, 2, but when we open
/dev/null here it's unlikely to be < 0, and after dupping the fd to 0,
1, 2 we turn off O_CLOEXEC explicitly anyway.
Unless we know that what we are about to open will return 0, 1 or 2 we
should always set O_CLOEXEC in order to be safe to other threads forking
of subprocesses at the wrong moment.
Lennart Poettering [Fri, 22 Dec 2017 12:05:33 +0000 (13:05 +0100)]
terminal-util: return first error, not last in make_stdio()
Just a minor tweak, making sure we execute as much as we can of the
funciton, but return the first error instead of the last we encounter.
This is usuelly how we do things when we have functions that continue on
the first error, so let's do it like that here too.
Lennart Poettering [Fri, 22 Dec 2017 12:04:24 +0000 (13:04 +0100)]
fd-util: use close_nointr() return value instead of errno
Our own calls return errors in their return values, hence use that
rather than errno when checking errors.
Lennart Poettering [Fri, 22 Dec 2017 12:03:35 +0000 (13:03 +0100)]
fd-util: add some (void) casts
Lennart Poettering [Thu, 21 Dec 2017 17:24:28 +0000 (18:24 +0100)]
sync: fork off sync() in a process instead of a thread
Let's fork off sync() ina process instead of a thread, as a safety
measure. This is beneficial to ensure that the original process can exit
without having to wait for the sync() to finish (note that the kernel
will delay process termination until all threads finished their
syscalls). In case of hanging NFS this increases the chance that PID 1
can safely transition to the "systemd-shutdown" process as the sync() is
initiated early on but definitely not waited for.
Yu Watanabe [Mon, 25 Dec 2017 10:42:42 +0000 (19:42 +0900)]
meson: define _GNU_SOURCE to detect copy_file_range() (#7734)
Follow-up for
bad7a0c81f501fbbcc79af9eaa4b8254441c4a1f of git
repository for glibc.
Recently glibc added `copy_file_range()`, but to use it,
`_GNU_SOURCE` needs to be defined. This adds the flag in
meson.build to detect the function by meson correctly.
Lennart Poettering [Sun, 24 Dec 2017 10:59:58 +0000 (11:59 +0100)]
Merge pull request #7663 from keszybz/mkdir-return-value
util-lib: fix return value in mkdir_parents()
Lennart Poettering [Sat, 23 Dec 2017 23:47:24 +0000 (00:47 +0100)]
systemctl: don't show vendor preset state for generated/transient units (#7711)
Showing the preset state for those suggests they could actually be
enabled/disabled, but that concept doesn't exist for generated/transient
units, hence hide this information.
This came up here:
https://lists.freedesktop.org/archives/systemd-devel/2017-December/040022.html
Lennart Poettering [Sat, 23 Dec 2017 18:20:29 +0000 (19:20 +0100)]
Merge pull request #7695 from yuwata/transient-socket
DBus-API: implement transient socket unit
Susant Sahani [Sat, 23 Dec 2017 17:55:03 +0000 (23:25 +0530)]
networkd: Add support for ipvlan L3s and flags (#7726)
This works supports to configure L3S mode and flags
such as bridge, private and vepa
Lennart Poettering [Sat, 23 Dec 2017 11:40:48 +0000 (12:40 +0100)]
Merge pull request #7620 from keszybz/two-docs
Two docs
Lucas Werkmeister [Thu, 21 Dec 2017 22:25:00 +0000 (23:25 +0100)]
man: mention StateDirectory in file-hierarchy(7)
Yu Watanabe [Sat, 23 Dec 2017 10:16:49 +0000 (19:16 +0900)]
load-fragment: simplify list insertion logic
LIST_FIND_TAIL and LIST_INSERT_AFTER can work for empty list.
Yu Watanabe [Sat, 23 Dec 2017 10:10:24 +0000 (19:10 +0900)]
cgroup: IODeviceWeight= or friends can take device node files in /run/systemd/inaccessible/
systemd creates several device nodes in /run/systemd/inaccessible/.
This makes CGroup's settings related to IO can take device node
files in the directory.
Yu Watanabe [Tue, 19 Dec 2017 11:12:01 +0000 (20:12 +0900)]
core/socket: shorten socket_fdname()
Yu Watanabe [Sat, 23 Dec 2017 09:53:36 +0000 (18:53 +0900)]
core/socket: dump more settings
Yu Watanabe [Tue, 19 Dec 2017 09:14:39 +0000 (18:14 +0900)]
dbus-cgroup: merge several blocks which operate almost same tasks
Yu Watanabe [Tue, 19 Dec 2017 07:49:37 +0000 (16:49 +0900)]
dbus-execute: use empty_to_null() where it can be applicable
Yu Watanabe [Tue, 19 Dec 2017 06:36:36 +0000 (15:36 +0900)]
doc: add {Condition,Assert}ControlGroupController= to TRANSIENT-SETTINGS.md
Follow-up for
e16647c39d195804711a006667d5bce49c0ef73d.
Yu Watanabe [Tue, 19 Dec 2017 06:34:04 +0000 (15:34 +0900)]
cgroup: move path checking logic to dbus-cgroup.c
Yu Watanabe [Tue, 19 Dec 2017 06:33:20 +0000 (15:33 +0900)]
bus-unit-util: simplify bus_append_cgroup_property()
Yu Watanabe [Tue, 19 Dec 2017 06:32:11 +0000 (15:32 +0900)]
bus-unit-util: make dependency settings can take multiple units
This allows people to specify multiple units in dependency settings
e.g. `Requires=foo.service baz.service`.
Yu Watanabe [Tue, 19 Dec 2017 06:30:59 +0000 (15:30 +0900)]
dbus-socket: move truncation check to bus_socket_set_transient_property()
Yu Watanabe [Sat, 23 Dec 2017 10:32:04 +0000 (19:32 +0900)]
basic: introduce socket_protocol_{from,to}_name()
And use them where they can be applicable.
Yu Watanabe [Tue, 19 Dec 2017 01:53:38 +0000 (10:53 +0900)]
doc: update TRANSIENT-SETTINGS.md
Yu Watanabe [Mon, 18 Dec 2017 15:07:11 +0000 (00:07 +0900)]
man: add explanation about transient path or socket units in systemd-run
Yu Watanabe [Mon, 18 Dec 2017 14:46:45 +0000 (23:46 +0900)]
run: add support to create transient path and socket unit
Yu Watanabe [Sat, 23 Dec 2017 07:59:56 +0000 (16:59 +0900)]
bus-unit-util: add socket unit related options
Also, split bus_append_unit_property_assignment().
Yu Watanabe [Sat, 23 Dec 2017 09:47:33 +0000 (18:47 +0900)]
core: implement transient socket unit
Yu Watanabe [Sat, 23 Dec 2017 07:55:36 +0000 (16:55 +0900)]
socket-util: add socket_address_type_{from,to}_string()
Yu Watanabe [Sat, 23 Dec 2017 07:29:40 +0000 (16:29 +0900)]
core/socket: add socket_port_type_from_string()
Yu Watanabe [Tue, 19 Dec 2017 13:14:07 +0000 (22:14 +0900)]
core:socket: fix string in socket_exec_command_table
Yu Watanabe [Tue, 19 Dec 2017 02:05:43 +0000 (11:05 +0900)]
core,seccomp: fix logic to parse RestrictAddressFamilies= in dbus-execute.c
If multiple RestrictAddressFamilies= settings, some of them are
whitelist and the others are blacklist, are sent to bus, then parsing
result was corrupted.
This fixes the parse logic, now it is the same as one used in
load-fragment.c
Yu Watanabe [Sat, 23 Dec 2017 09:45:32 +0000 (18:45 +0900)]
core,seccomp: fix logic to parse syscall filter in dbus-execute.c
If multiple SystemCallFilter= settings, some of them are whitelist
and the others are blacklist, are sent to bus, then the parse
result was corrupted.
This fixes the parse logic, now it is the same as one used in
load-fragment.c
Lennart Poettering [Sat, 23 Dec 2017 07:47:55 +0000 (08:47 +0100)]
coccinelle: beef up isempty() checks (#7729)
With these additions, coccinelle finds everything fixed by the first
commit in PR #7695. In order not to needlessly conflict with that PR
this PR won't include those fixes, but only the coccinelle changes to
detect them automatically in the future.
Dmitry Rozhkov [Thu, 21 Dec 2017 12:55:29 +0000 (14:55 +0200)]
man: fix example config to conform the content of the man page
The config example contains wrong specificator for hostname.
It should be %H instead of %h as documented in the man page.
Use correct specificator for hostname.
Sylvain Plantefève [Thu, 21 Dec 2017 22:11:25 +0000 (23:11 +0100)]
catalog: update french translation
Mathieu Malaterre [Fri, 22 Dec 2017 09:06:29 +0000 (10:06 +0100)]
shared/seccomp: add mmap handling for powerpc
Also remove the warning:
./src/shared/seccomp-util.c:1414:2: warning: #warning "Consider adding the right mmap() syscall definitions here!" [-Wcpp]
#warning "Consider adding the right mmap() syscall definitions here!"
Yu Watanabe [Thu, 21 Dec 2017 18:07:23 +0000 (03:07 +0900)]
networkd: show warning on error or cast to void when error is ignored (#7716)
Michał [Thu, 21 Dec 2017 13:17:33 +0000 (14:17 +0100)]
hwdb: Add accelerometer orientation entry for Lenovo MIIX3-1030 tablet (#7713)
Full dmi/id/modalias:
dmi:bvnLENOVO:bvrB4CN29WW:bd12/04/2015:svnLENOVO:pn80HV:pvrLenovoMIIX3-1030:rvnLENOVO:rnMartini:rvrSDK0G98662WIN:cvnLENOVO:ct11:cvrLenovoMIIX3-1030:
Tested on Lenovo MIIX3 with Debian 9
Susant Sahani [Thu, 21 Dec 2017 12:27:45 +0000 (17:57 +0530)]
Fix #7704 and #7708. (#7712)
Init rule variable iif oif and to, from
While foreign rules are added the network part is not attached.
attach manager to rules and use it in routing_policy_rule_free.
Zbigniew Jędrzejewski-Szmek [Wed, 20 Dec 2017 09:17:37 +0000 (10:17 +0100)]
network: fix memory leak when an netdev was skipped
In general we'd leak anything that was allocated in the first parsing of
netdev, e.g. netdev name, host name, etc. Use normal netdev_unref to make sure
everything is freed.
--- command ---
/home/zbyszek/src/systemd/build2/test-network
--- stderr ---
/etc/systemd/network/wg0.netdev:3: Failed to parse netdev kind, ignoring: wireguard
/etc/systemd/network/wg0.netdev:5: Unknown section 'WireGuard'. Ignoring.
/etc/systemd/network/wg0.netdev:9: Unknown section 'WireGuardPeer'. Ignoring.
NetDev has no Kind configured in /etc/systemd/network/wg0.netdev. Ignoring
/etc/systemd/network/br0.network:13: Unknown lvalue 'NetDev' in section 'Network'
br0: netdev ready
=================================================================
==11666==ERROR: LeakSanitizer: detected memory leaks
Direct leak of 4 byte(s) in 1 object(s) allocated from:
#0 0x7f3a314cf238 in __interceptor_strdup (/lib64/libasan.so.4+0x77238)
#1 0x7f3a30e71ad1 in free_and_strdup ../src/basic/string-util.c:870
#2 0x7f3a30d34fba in config_parse_ifname ../src/shared/conf-parser.c:981
#3 0x7f3a30d2f5b0 in next_assignment ../src/shared/conf-parser.c:155
#4 0x7f3a30d30303 in parse_line ../src/shared/conf-parser.c:273
#5 0x7f3a30d30dee in config_parse ../src/shared/conf-parser.c:390
#6 0x7f3a30d310a5 in config_parse_many_files ../src/shared/conf-parser.c:428
#7 0x7f3a30d3181c in config_parse_many ../src/shared/conf-parser.c:487
#8 0x55b4200f9b00 in netdev_load_one ../src/network/netdev/netdev.c:634
#9 0x55b4200fb562 in netdev_load ../src/network/netdev/netdev.c:778
#10 0x55b4200c607a in manager_load_config ../src/network/networkd-manager.c:1299
#11 0x55b4200818e0 in test_load_config ../src/network/test-network.c:128
#12 0x55b42008343b in main ../src/network/test-network.c:254
#13 0x7f3a305f8889 in __libc_start_main (/lib64/libc.so.6+0x20889)
SUMMARY: AddressSanitizer: 4 byte(s) leaked in 1 allocation(s).
-------
Zbigniew Jędrzejewski-Szmek [Wed, 20 Dec 2017 12:57:12 +0000 (13:57 +0100)]
Merge pull request #7710 from jwrdegoede/hwdb-accel-chuwi-vi8-teclast-x80-pro
hwdb/60-sensor.hwdb: Add entries for the Chuwi vi8 and Teclast x80 pro tablets
Lennart Poettering [Wed, 20 Dec 2017 11:08:40 +0000 (12:08 +0100)]
Merge pull request #7702 from keszybz/reduce-linkage
Some small cleanups and another attempt to reduce linkage of nss modules
Hans de Goede [Wed, 20 Dec 2017 10:06:13 +0000 (11:06 +0100)]
hwdb: Add accelerometer orientation entry for Teclast X80 Pro tablet
Add an accelerometer orientation entry for the Teclast X80 Pro tablet.
Hans de Goede [Wed, 20 Dec 2017 09:57:38 +0000 (10:57 +0100)]
hwdb: Add accelerometer orientation entry for Chuwi Vi8 (CWI506) tablet
Add an accelerometer orientation entry for the Chuwi Vi8 (CWI506) tablet.
Alan Jenkins [Tue, 19 Dec 2017 20:22:05 +0000 (20:22 +0000)]
man: User=, Group= *never* work for mount units (#7602)
Old text:
> Note that the User= and
> Group= options are not particularly useful for mount units specifying a
> "Type=" option or using configuration not specified in /etc/fstab;
> mount(8) will refuse options that are not listed in /etc/fstab if it is
> not run as UID 0.
However I recently learnt the following:
> The mount program does not read the /etc/fstab file if both device
> and dir are specified.
Therefore, if both device and dir are specified, the `user` or `users`
options in `fstab` will not have any effect. Run as a normal user,
you will always see
mount: only root can do that
Fix the explanation in the man page.
Also make sure to markup User= and Group= with <varname>.
Zbigniew Jędrzejewski-Szmek [Tue, 19 Dec 2017 18:31:55 +0000 (19:31 +0100)]
Merge pull request #7697 from yuwata/fix-man-exec-no-new-priv
man: LockPersonality= implies NoNewPrivileges=
Zbigniew Jędrzejewski-Szmek [Tue, 19 Dec 2017 14:12:50 +0000 (15:12 +0100)]
sd-bus: drop check for selinux before calling getsockopt(SO_PEERSEC)
Quoting Lennart Poettering in
https://github.com/systemd/systemd/pull/6464#issuecomment-
319029293:
> If the kernel allows us to query that data we should also be Ok with passing
> it on to our own caller, regardless if selinux is technically on or off...
The advantage is that this allows gcc to be smarter and reduce linkage:
(before)$ ldd build/libnss_systemd.so.2
linux-vdso.so.1 (0x00007ffeb46ff000)
librt.so.1 => /lib64/librt.so.1 (0x00007f2f60da6000)
libcap.so.2 => /lib64/libcap.so.2 (0x00007f2f60ba1000)
libselinux.so.1 => /lib64/libselinux.so.1 (0x00007f2f60978000)
libpthread.so.0 => /lib64/libpthread.so.0 (0x00007f2f60759000)
libc.so.6 => /lib64/libc.so.6 (0x00007f2f60374000)
/lib64/ld-linux-x86-64.so.2 (0x00007f2f61294000)
libpcre2-8.so.0 => /lib64/libpcre2-8.so.0 (0x00007f2f600f0000)
libdl.so.2 => /lib64/libdl.so.2 (0x00007f2f5feec000)
(after )$ ldd build/libnss_systemd.so.2
linux-vdso.so.1 (0x00007ffe5f543000)
librt.so.1 => /lib64/librt.so.1 (0x00007f427dcaa000)
libcap.so.2 => /lib64/libcap.so.2 (0x00007f427daa5000)
libpthread.so.0 => /lib64/libpthread.so.0 (0x00007f427d886000)
libc.so.6 => /lib64/libc.so.6 (0x00007f427d4a1000)
/lib64/ld-linux-x86-64.so.2 (0x00007f427e196000)
Note that this only works in conjuction with the previous commit: either
of the two commits alone does not have the desired effect on linkage.
Replaces #6464.
Zbigniew Jędrzejewski-Szmek [Tue, 19 Dec 2017 13:33:11 +0000 (14:33 +0100)]
Move selinux-related stuff from btrfs-util.c to label.c
In preparation for future changes.
Zbigniew Jędrzejewski-Szmek [Tue, 19 Dec 2017 09:02:27 +0000 (10:02 +0100)]
machine-id-setup: use return log_error… pattern
No functional difference, but this way it's clearer that the original errno
value is returned.
Zbigniew Jędrzejewski-Szmek [Tue, 19 Dec 2017 08:21:02 +0000 (09:21 +0100)]
bootctl: silence warning about signed/unsigned comparison
John Paul Herold [Tue, 19 Dec 2017 10:22:36 +0000 (04:22 -0600)]
Add T430 series to list of supported trackpoint (#7699)
Confirmed via `udevadm test /sys/class/input/eventX` that
POINTINGSTICK_* properties were not being set for my T430s trackpoint.
After adding a local entry file (as advised in this file), the same
`udevadm test` command showed properties.
More importantly, the movement of mouse using trackpoint felt much
better. Hard to describe its previous state, but following come to mind:
slippery, hard to control, awkward. Now it feels more consistent and predictable.
A little on the sensitive side with the defaults, but didn't think it warranted
dedicated properties just for this series though as the X230 is same generation
and uses the defaults.
Before local change:
$ udevadm info /dev/input/event5
P: /devices/platform/i8042/serio1/serio2/input/input6/event5
N: input/event5
E: DEVNAME=/dev/input/event5
E: DEVPATH=/devices/platform/i8042/serio1/serio2/input/input6/event5
E: ID_BUS=i8042
E: ID_INPUT=1
E: ID_INPUT_MOUSE=1
E: ID_INPUT_POINTINGSTICK=1
E: LIBINPUT_DEVICE_GROUP=11/2/a:synaptics-pt/serio0
E: MAJOR=13
E: MINOR=69
E: SUBSYSTEM=input
E: USEC_INITIALIZED=
38609915
After change:
$ udevadm info /dev/input/event5
P: /devices/platform/i8042/serio1/serio2/input/input6/event5
N: input/event5
E: DEVNAME=/dev/input/event5
E: DEVPATH=/devices/platform/i8042/serio1/serio2/input/input6/event5
E: ID_BUS=i8042
E: ID_INPUT=1
E: ID_INPUT_MOUSE=1
E: ID_INPUT_POINTINGSTICK=1
E: LIBINPUT_DEVICE_GROUP=11/2/a:synaptics-pt/serio0
E: MAJOR=13
E: MINOR=69
E: POINTINGSTICK_CONST_ACCEL=1.0
E: POINTINGSTICK_SENSITIVITY=200
E: SUBSYSTEM=input
E: USEC_INITIALIZED=
38609915
Yu Watanabe [Tue, 19 Dec 2017 10:15:50 +0000 (19:15 +0900)]
timedatectl: fix status output (#7696)
Follow-up for
3ec530a1890925efe347f739917dd4078c1b1942.
Fixes #7693.
Jörg Thalheim [Tue, 19 Dec 2017 10:13:34 +0000 (10:13 +0000)]
more portable perl shebangs (#7701)
same motivation as in #5816:
- distributions have scripts to rewrite shebangs on installation and
they know what locations to rely on.
- For tests/compilation we should rather rely on the user to have setup
there PATH correctly.
Zbigniew Jędrzejewski-Szmek [Tue, 19 Dec 2017 07:51:12 +0000 (08:51 +0100)]
cryptsetup: use uint64_t for keyfile-offset= (#7689)
On 32bit, refuse large offsets. Once https://gitlab.com/cryptsetup/cryptsetup/issues/359
is resolved, we should switch to the new api, whatever it is.
Fixes #7677.
Yu Watanabe [Tue, 19 Dec 2017 07:07:04 +0000 (16:07 +0900)]
man: note that `systemctl show` does not overridden value
Fixes #7694.
Yu Watanabe [Tue, 19 Dec 2017 03:48:54 +0000 (12:48 +0900)]
man: LockPersonality= implies NoNewPrivileges=
Yu Watanabe [Fri, 15 Dec 2017 12:25:00 +0000 (21:25 +0900)]
core: move path_kill_slashes() to manager
Yu Watanabe [Fri, 15 Dec 2017 12:22:01 +0000 (21:22 +0900)]
core: fix wrong validity check
Yu Watanabe [Fri, 15 Dec 2017 07:36:35 +0000 (16:36 +0900)]
tree-wide: use !strv_isempty() instead of strv_length() > 0
Zbigniew Jędrzejewski-Szmek [Mon, 18 Dec 2017 18:35:03 +0000 (19:35 +0100)]
analyze: use normal bus connection for "plot" verb (#7685)
We need to connect to hostnamed, so a private bus connection is no good.
It'd be simpler to use the normal bus connection unconditionally, but
that'd mean that e.g. systemd-analyze set-log-level might not work in
emergency mode. So let's keep trying to use the private connection except
for "plot".
Fixes #7667.
Lennart Poettering [Mon, 18 Dec 2017 18:29:00 +0000 (19:29 +0100)]
Merge pull request #7687 from hbakken/work/add-missing-features2
Kernel 3.10 compat
Felipe Sateler [Mon, 18 Dec 2017 13:58:13 +0000 (10:58 -0300)]
build-sys: install TRANSIENT-SETTINGS.md and UIDS-GIDS.md (#7690)
Jan Alexander Steffens [Mon, 18 Dec 2017 13:47:18 +0000 (14:47 +0100)]
cryptsetup-generator: Don't mistake NULL input as OOM (#7688)
Since systemd v236, several Arch users complained that
systemd-cryptsetup-generator exits with an OOM error and that it
prevents the boot from continuing.
Investigating the diff of cryptsetup-generator between v235 and v236 I
noticed that create_disk allowed for the `password` and `filtered`
variables to be NULL (they're handled with `strempty()`) but not their
`*_escaped` versions, and returned OOM errors in those cases.
Fix this by checking that the input string is non-NULL before deciding
that `specifier_escape` had an OOM error.
I could not test this fix myself, but some users have reported success.
Downstream bug: https://bugs.archlinux.org/task/56733
Henrik Grindal Bakken [Thu, 23 Mar 2017 15:19:15 +0000 (16:19 +0100)]
missing: Add DM_DEFERRED_REMOVE
Also include missing.h in dissect-image.c to pick it up.
Henrik Grindal Bakken [Thu, 23 Mar 2017 15:09:10 +0000 (16:09 +0100)]
missing: Define SMACK_MAGIC if it's missing
Henrik Grindal Bakken [Thu, 23 Mar 2017 15:02:43 +0000 (16:02 +0100)]
nspawn: Include missing.h
Henrik Grindal Bakken [Thu, 23 Mar 2017 15:02:20 +0000 (16:02 +0100)]
missing: Define EFIVARFS_MAGIC if missing
Henrik Grindal Bakken [Thu, 23 Mar 2017 15:07:33 +0000 (16:07 +0100)]
missing: Add MAX_HANDLE_SZ
Sergey Ptashnick [Mon, 18 Dec 2017 12:41:43 +0000 (15:41 +0300)]
catalog: update Russian translation (#7678)
Translated taint message.
Also added a blank line before "Current system is tagged" for better
visual separation between current system state and tags description.
Henrik Grindal Bakken [Thu, 23 Mar 2017 14:42:15 +0000 (15:42 +0100)]
missing: Add PR_SET_MM_{ARG,ENV}_{START,END}
Henrik Grindal Bakken [Thu, 23 Mar 2017 14:33:06 +0000 (15:33 +0100)]
missing: Add some more btrfs structs and constants
Henrik Grindal Bakken [Thu, 23 Mar 2017 14:30:57 +0000 (15:30 +0100)]
btrfs: Include missing.h in btrfs-ctree.h
Chris Down [Mon, 18 Dec 2017 07:53:29 +0000 (07:53 +0000)]
condition: Create AssertControlGroupController (#7630)
Up until now, the behaviour in systemd has (mostly) been to silently
ignore failures to action unit directives that refer to an unavailble
controller. The addition of AssertControlGroupController and its
conditional counterpart allow explicit specification of the desired
behaviour when such a situation occurs.
As for how this can happen, it is possible that a particular controller
is not available in the cgroup hierarchy. One possible reason for this
is that, in the running kernel, the controller simply doesn't exist --
for example, the CPU controller in cgroup v2 has only recently been
merged and was out of tree until then. Another possibility is that the
controller exists, but has been forcibly disabled by `cgroup_disable=`
on the kernel command line.
In future this will also support whatever comes out of issue #7624,
`DefaultXAccounting=never`, or similar.
Zbigniew Jędrzejewski-Szmek [Mon, 18 Dec 2017 07:26:36 +0000 (08:26 +0100)]
Merge pull request #7665 from poettering/main-cleanup
let's split up main() into more functions, to make it digestable
Piotr Drąg [Sat, 16 Dec 2017 14:20:34 +0000 (15:20 +0100)]
catalog: update Polish translation (#7660)
Zbigniew Jędrzejewski-Szmek [Sat, 16 Dec 2017 14:01:04 +0000 (15:01 +0100)]
Merge pull request #7664 from poettering/fix-integration-tests
Fix integration tests
Zbigniew Jędrzejewski-Szmek [Sat, 16 Dec 2017 12:32:42 +0000 (13:32 +0100)]
Move mkdir_label() to mkdir-label.c
It just seems strange to have it in a different file if mkdir-label.c exists.
Zbigniew Jędrzejewski-Szmek [Sat, 16 Dec 2017 12:22:57 +0000 (13:22 +0100)]
smack-util: remove unneeded initalization
Zbigniew Jędrzejewski-Szmek [Fri, 15 Dec 2017 16:08:13 +0000 (17:08 +0100)]
Add mkdir_errno_wrapper() and use instead of mkdir() in various places
We'd pass pointers to mkdir and mkdir_label to call in various places. mkdir
returns the error in errno while mkdir_label returns the error directly.
Alan Jenkins [Sat, 16 Dec 2017 10:48:12 +0000 (10:48 +0000)]
man: generalize "binary" to "program" (#7668)
Systemd services are permitted to be scripts, as well as binary
executables.
The same also applies to the underlying /sbin/mount and /sbin/swapon.
It is not necessary for the user to consider what type of program file
these are. Nor is it necessary with systemd-nspawn, to distinguish between
init as a "binary" v.s. a user-specified "program".
Also fix a couple of grammar nits in the modified sentences.
Franck Bui [Sat, 16 Dec 2017 08:36:36 +0000 (09:36 +0100)]
meson: libudev_core and udevadm should have LOG_REALM=LOG_REALM_UDEV (#7666)
Otherwise, setting udev_log=debug in /etc/udev/udev.conf has no effects since
systemd-udevd is built with LOG_REALM=LOG_REALM_UDEV.
However using LOG_REALM_UDEV (for libudev_core) reveals another similar bug for
udevadm which should also define LOG_REALM_UDEV.
Lennart Poettering [Fri, 15 Dec 2017 19:55:39 +0000 (20:55 +0100)]
Merge pull request #7661 from keszybz/slice-cleanups
Slice cleanups and systemd-mount --owner
Lennart Poettering [Fri, 15 Dec 2017 18:03:17 +0000 (19:03 +0100)]
main: add some more comments for the early initialization phase
Lennart Poettering [Fri, 15 Dec 2017 18:02:35 +0000 (19:02 +0100)]
main: reorder variable declarations a bit
Let's remove a bit redundancy, and list variables of the same
type/category in one declaration line.
Lennart Poettering [Fri, 15 Dec 2017 17:53:03 +0000 (18:53 +0100)]
main: split out 'skip_setup' check into its own functions
And let's optimize it a tiny bit, by only iterating through the argument
list once, instead of twice.
Lennart Poettering [Fri, 15 Dec 2017 17:51:54 +0000 (18:51 +0100)]
main: do bother with uid_to_name() unless we do debug logging
Lennart Poettering [Fri, 15 Dec 2017 16:54:20 +0000 (17:54 +0100)]
main: conditionalize fixup_environment() internally
This code is executed before we parse command line/configuration
parameters, hence let's not use arg_system to figure our how to clean up
things, but instead PID == 1. Let's move that check inside of the
function, to make things a bit more robust abstract from the outside.
Also, let's add a log message about this, that was so far missing.
Lennart Poettering [Fri, 15 Dec 2017 16:52:33 +0000 (17:52 +0100)]
main: let's move ACTION_RUN test into initialize_runtime()
Let's hide this check inside the function and make it easier to follow
the general control flow of main().
Lennart Poettering [Fri, 15 Dec 2017 16:37:16 +0000 (17:37 +0100)]
mount-setup: fix MNT_CHECK_WRITABLE error handling, and log about the issue
Let's correct the error handling (the error is in errno, not r), and
let's add logging like the rest of the function has it.
Lennart Poettering [Fri, 15 Dec 2017 16:36:19 +0000 (17:36 +0100)]
main: tweak timerslack message a bit
Let's clarify that this is a non-issue, by downgrading it to LOG_WARN
and saying "ignoring" in the message.
Lennart Poettering [Fri, 15 Dec 2017 16:34:12 +0000 (17:34 +0100)]
main: move install_crash_handler() and mount_cgroup_controllers() invocations
Let's place them in initialize_runtime(), where they appear to fit best.
Effectively this is just a move a little bit down, swapping places with
log_execution_mode(), which should require neither call to be done
first.
Note that changes the conditionalization a bit for these calls, from
(PID == 1) to (arg_system && arg_action == ACTION_RUN). At this point this is pretty much the same
however, as we don't allow PID 1 without ACTION_RUN and without
arg_system set, safety_checks() ensures that.
Lennart Poettering [Fri, 15 Dec 2017 16:16:24 +0000 (17:16 +0100)]
core: move arg_show_status fix-up into load_configuration()
It's part of finalizing our runtime parameters, hence let's move this
into load_configuration() after we loaded everything else. This is safe,
since we don't use it between the location where it was and where we
place it now yet.