skia.committer@gmail.com [Tue, 16 Apr 2013 07:01:17 +0000 (07:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@8693
2bbb7eff-a529-9590-31e7-
b0007b416f81
tfarina@chromium.org [Mon, 15 Apr 2013 22:12:43 +0000 (22:12 +0000)]
Use ILLEGAL_MODE macro to silence clang error.
This fixes the following clang error:
../../tests/XfermodeTest.cpp:43:44: error: comparison of constant -1 with expression of type 'SkXfermode::Mode' is always false [-Werror,-Wtautological-constant-out-of-range-compare]
REPORTER_ASSERT(reporter, reportedMode == -1);
~~~~~~~~~~~~ ^ ~~
R=vandebo@chromium.org,reed@google.com
Review URL: https://codereview.chromium.org/
14180004
git-svn-id: http://skia.googlecode.com/svn/trunk@8692
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Mon, 15 Apr 2013 22:05:03 +0000 (22:05 +0000)]
Link webp in skimage and debugger.
Review URL: https://codereview.chromium.org/
14103020
git-svn-id: http://skia.googlecode.com/svn/trunk@8691
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Mon, 15 Apr 2013 21:51:52 +0000 (21:51 +0000)]
Enable caching of texture domain extents
https://codereview.chromium.org/
14261009/
git-svn-id: http://skia.googlecode.com/svn/trunk@8690
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Mon, 15 Apr 2013 19:13:59 +0000 (19:13 +0000)]
path ops work in progress
standardize tests
use SK_ARRAY_COUNT everywhere
debug why x87 differs from SIMD 64
various platform specific fixes
git-svn-id: http://skia.googlecode.com/svn/trunk@8689
2bbb7eff-a529-9590-31e7-
b0007b416f81
junov@chromium.org [Mon, 15 Apr 2013 18:15:23 +0000 (18:15 +0000)]
Fix crash with SkDeferredCanvas+SkSurface integration with in order draw buffer.
The fImmediateDevice member of DeferredDevice (SkDeferredCanvas.cpp) was becoming invalid after a fork of the backingstore in SkSurface_Gpu cause the device to be substituted.
New unit test code was to exercise SkSurface copy on write with draws that are deferred in GrInOrderDrawBuffer. The bad pointer was causing the test to crash.
TEST=skia unit test DeferredCanvas, subtest TestDeferredCanvasSurface
Review URL: https://codereview.chromium.org/
14263015
git-svn-id: http://skia.googlecode.com/svn/trunk@8686
2bbb7eff-a529-9590-31e7-
b0007b416f81
borenet@google.com [Mon, 15 Apr 2013 17:36:08 +0000 (17:36 +0000)]
Move resource dir from gm to trunk
git-svn-id: http://skia.googlecode.com/svn/trunk@8684
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 15 Apr 2013 15:23:38 +0000 (15:23 +0000)]
fix release warning (unused debug variable)
git-svn-id: http://skia.googlecode.com/svn/trunk@8682
2bbb7eff-a529-9590-31e7-
b0007b416f81
mike@reedtribe.org [Mon, 15 Apr 2013 15:20:52 +0000 (15:20 +0000)]
add experimental chop-into-quads for conics
git-svn-id: http://skia.googlecode.com/svn/trunk@8681
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 15 Apr 2013 15:16:47 +0000 (15:16 +0000)]
Add coeffecients for kScreen xfermode.
Review URL: https://codereview.chromium.org/
14046021
git-svn-id: http://skia.googlecode.com/svn/trunk@8680
2bbb7eff-a529-9590-31e7-
b0007b416f81
djsollen@google.com [Mon, 15 Apr 2013 14:37:28 +0000 (14:37 +0000)]
Remove freetype dependency from core.gyp
Committed: https://code.google.com/p/skia/source/detail?r=8677
Review URL: https://codereview.chromium.org/
13975014
git-svn-id: http://skia.googlecode.com/svn/trunk@8678
2bbb7eff-a529-9590-31e7-
b0007b416f81
djsollen@google.com [Mon, 15 Apr 2013 14:02:32 +0000 (14:02 +0000)]
Remove freetype dependency from core.gyp
Review URL: https://codereview.chromium.org/
13975014
git-svn-id: http://skia.googlecode.com/svn/trunk@8677
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 15 Apr 2013 13:55:02 +0000 (13:55 +0000)]
Comment only change. (forgot to save comment edit before landing r8675).
git-svn-id: http://skia.googlecode.com/svn/trunk@8676
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 15 Apr 2013 13:51:00 +0000 (13:51 +0000)]
Add support for using glCopyTexSubImage2D when possible to copy surfaces.
Review URL: https://codereview.chromium.org/
13915011
git-svn-id: http://skia.googlecode.com/svn/trunk@8675
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Sun, 14 Apr 2013 07:01:08 +0000 (07:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@8673
2bbb7eff-a529-9590-31e7-
b0007b416f81
mike@reedtribe.org [Sun, 14 Apr 2013 02:40:50 +0000 (02:40 +0000)]
add special-case for chopping at exactly half for rational-quads (2-3x faster)
git-svn-id: http://skia.googlecode.com/svn/trunk@8672
2bbb7eff-a529-9590-31e7-
b0007b416f81
mike@reedtribe.org [Sat, 13 Apr 2013 10:51:51 +0000 (10:51 +0000)]
compute new weight in standard-form
git-svn-id: http://skia.googlecode.com/svn/trunk@8671
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Sat, 13 Apr 2013 07:01:15 +0000 (07:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@8670
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Fri, 12 Apr 2013 22:14:03 +0000 (22:14 +0000)]
GM::height() now returns the height, not the width.
Fortunately, the only current caller has a width and height that
match, so this should not change any existing GMs.
Review URL: https://codereview.chromium.org/
14234022
git-svn-id: http://skia.googlecode.com/svn/trunk@8669
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 12 Apr 2013 21:55:26 +0000 (21:55 +0000)]
incomplete impl for chopping rational quads (need to "normalize" so I can get
the new middle weight).
git-svn-id: http://skia.googlecode.com/svn/trunk@8668
2bbb7eff-a529-9590-31e7-
b0007b416f81
junov@chromium.org [Fri, 12 Apr 2013 20:20:50 +0000 (20:20 +0000)]
Fixing viral copy/paste typo Shapshot -> Snapshot
Unreviewed
git-svn-id: http://skia.googlecode.com/svn/trunk@8667
2bbb7eff-a529-9590-31e7-
b0007b416f81
rmistry@google.com [Fri, 12 Apr 2013 19:45:46 +0000 (19:45 +0000)]
If the tree is closed then print information about contacting the sheriff.
The motivation for this CL is because it is not very obvious on how to submit when tree is closed in git.
Also added a section 'How to submit when tree is closed' in https://sites.google.com/site/skiadocs/developer-documentation/tree-sheriff
(SkipBuildbotRuns)
Review URL: https://codereview.chromium.org/
13932026
git-svn-id: http://skia.googlecode.com/svn/trunk@8666
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 12 Apr 2013 19:11:10 +0000 (19:11 +0000)]
experimental start to arcs
git-svn-id: http://skia.googlecode.com/svn/trunk@8665
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Fri, 12 Apr 2013 19:05:57 +0000 (19:05 +0000)]
GM: add self-test that sets --readPath to a nonexistent directory path
Review URL: https://codereview.chromium.org/
13844011
git-svn-id: http://skia.googlecode.com/svn/trunk@8664
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Fri, 12 Apr 2013 16:28:21 +0000 (16:28 +0000)]
Only use JDCT_FAST if it is supported in jpeg.
Fixes a bug where jpeg decoder did not work on linux.
Review URL: https://codereview.chromium.org/
14188002
git-svn-id: http://skia.googlecode.com/svn/trunk@8661
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 12 Apr 2013 15:34:53 +0000 (15:34 +0000)]
explicitly initialize all entries in array of SkBaseMatrix, since we can't say
that implicitly in C (given that our initializer value may not be all zeros).
crbug.com/174644
Review URL: https://codereview.chromium.org/
13990003
git-svn-id: http://skia.googlecode.com/svn/trunk@8660
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Fri, 12 Apr 2013 15:24:29 +0000 (15:24 +0000)]
Compiler warning/error patch for r8658
git-svn-id: http://skia.googlecode.com/svn/trunk@8659
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Fri, 12 Apr 2013 15:13:35 +0000 (15:13 +0000)]
Add testing of optimizations to GM
https://codereview.chromium.org/
12843028/
git-svn-id: http://skia.googlecode.com/svn/trunk@8658
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Fri, 12 Apr 2013 15:04:33 +0000 (15:04 +0000)]
Fix NaCl build.
In SkDebugger.cpp::forceLinking(), call CreateGIFDecoder on linux
but not on NaCl.
Review URL: https://codereview.chromium.org/
13975008
git-svn-id: http://skia.googlecode.com/svn/trunk@8656
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Fri, 12 Apr 2013 14:59:02 +0000 (14:59 +0000)]
Reverting r8654
git-svn-id: http://skia.googlecode.com/svn/trunk@8655
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Fri, 12 Apr 2013 14:53:29 +0000 (14:53 +0000)]
Add testing of optimizations to GM
https://codereview.chromium.org/
12843028/
git-svn-id: http://skia.googlecode.com/svn/trunk@8654
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Fri, 12 Apr 2013 14:50:10 +0000 (14:50 +0000)]
Force the debugger to link decoders.
This is required to play back SKPs with encoded data in them.
Review URL: https://codereview.chromium.org/
14135004
git-svn-id: http://skia.googlecode.com/svn/trunk@8653
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Fri, 12 Apr 2013 14:11:21 +0000 (14:11 +0000)]
GM: allow caller to specify which result types trigger an error
Review URL: https://codereview.chromium.org/
14187007
git-svn-id: http://skia.googlecode.com/svn/trunk@8652
2bbb7eff-a529-9590-31e7-
b0007b416f81
junov@chromium.org [Fri, 12 Apr 2013 13:34:47 +0000 (13:34 +0000)]
Adding 'static' to eleminate compile warning on mac
Unreviewed.
git-svn-id: http://skia.googlecode.com/svn/trunk@8649
2bbb7eff-a529-9590-31e7-
b0007b416f81
junov@chromium.org [Fri, 12 Apr 2013 13:33:01 +0000 (13:33 +0000)]
Adding SkSurface support to SkDeferredCanvas
Review URL: https://codereview.chromium.org/
14178002
git-svn-id: http://skia.googlecode.com/svn/trunk@8648
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Fri, 12 Apr 2013 12:12:09 +0000 (12:12 +0000)]
revert path ops unit test until errors are fixed
git-svn-id: http://skia.googlecode.com/svn/trunk@8645
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Fri, 12 Apr 2013 11:59:41 +0000 (11:59 +0000)]
turn on pathops unit test
This temporarily disables SK_ENABLE_INST_COUNT
( skbug.com/1219 )
This fixes a linktime error on VS2012 in
PathTest.cpp; -SK_ScalarInfinity should be
SK_ScalarNegativeInfinity instead.
This adds pathops and pathops unit tests to the
main unit tests.
Should this change destabilize anything, it should
be sufficient to comment out the pathops gypi
includes. at test.gyp:18,21.
Review URL: https://codereview.chromium.org/
14137010
git-svn-id: http://skia.googlecode.com/svn/trunk@8644
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Fri, 12 Apr 2013 07:01:51 +0000 (07:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@8641
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Fri, 12 Apr 2013 03:32:46 +0000 (03:32 +0000)]
whitespace commit to trigger buildbots after resetting skia-autogen
git-svn-id: http://skia.googlecode.com/svn/trunk@8640
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Fri, 12 Apr 2013 02:23:55 +0000 (02:23 +0000)]
rename SkBitmapChecksummer as SkBitmapHasher, and prepare for it to possibly use
some algorithm other than CityHash
Review URL: https://codereview.chromium.org/
14170010
git-svn-id: http://skia.googlecode.com/svn/trunk@8639
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Fri, 12 Apr 2013 02:11:54 +0000 (02:11 +0000)]
GM: print list of GMs run, even in non-verbose mode (rolls back part of r8600)
Review URL: https://codereview.chromium.org/
14052003
git-svn-id: http://skia.googlecode.com/svn/trunk@8638
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Thu, 11 Apr 2013 23:25:36 +0000 (23:25 +0000)]
Update debug GL backend to match r8633
git-svn-id: http://skia.googlecode.com/svn/trunk@8637
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Thu, 11 Apr 2013 22:24:35 +0000 (22:24 +0000)]
Fix the NaCl build.
Do not attempt to build our gif files or link gif in Nacl.
Review URL: https://codereview.chromium.org/
14201002
git-svn-id: http://skia.googlecode.com/svn/trunk@8635
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 11 Apr 2013 22:00:34 +0000 (22:00 +0000)]
Add glCopyTexSubImage2D to GrGLInterface
Author: bsalomon@google.com
Reviewed By: robertphillips@google.com
Review URL: https://chromiumcodereview.appspot.com/
13941006
git-svn-id: http://skia.googlecode.com/svn/trunk@8634
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 11 Apr 2013 22:00:22 +0000 (22:00 +0000)]
Use blitframebuffer to implement copySurface.
Author: bsalomon@google.com
Reviewed By: robertphillips@google.com
Review URL: https://chromiumcodereview.appspot.com/
13910009
git-svn-id: http://skia.googlecode.com/svn/trunk@8633
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Thu, 11 Apr 2013 20:11:40 +0000 (20:11 +0000)]
Better fix for the patched build.
skia_test is also built on Android in pathops_unittest, which needed
to also depend on the flags project.
Remove the hack in skia_test of providing the full path.
Review URL: https://codereview.chromium.org/
14177002
git-svn-id: http://skia.googlecode.com/svn/trunk@8632
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 11 Apr 2013 19:04:34 +0000 (19:04 +0000)]
short names should be ... short, in commandlineflags
git-svn-id: http://skia.googlecode.com/svn/trunk@8629
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Thu, 11 Apr 2013 18:56:08 +0000 (18:56 +0000)]
Whitespace change to trigger a rebuild.
Review URL: https://codereview.chromium.org/
13941005
git-svn-id: http://skia.googlecode.com/svn/trunk@8628
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Thu, 11 Apr 2013 18:32:01 +0000 (18:32 +0000)]
Include gif image decoding in images/ on linux.
Build SkImageDecoder_libgif in images project and link against
libgif on linux.
Ensure that the GIF decoder is used in skimage.
Requires a new dependency on libgif-dev when building on linux.
Review URL: https://codereview.chromium.org/
14029011
git-svn-id: http://skia.googlecode.com/svn/trunk@8627
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 11 Apr 2013 18:31:25 +0000 (18:31 +0000)]
add fontmgr tests, and optional --verboseFontMgr flag (or -vfm) for more output
git-svn-id: http://skia.googlecode.com/svn/trunk@8626
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 11 Apr 2013 18:27:52 +0000 (18:27 +0000)]
restore option to --match (instead of --matchStr)
git-svn-id: http://skia.googlecode.com/svn/trunk@8624
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 11 Apr 2013 18:27:26 +0000 (18:27 +0000)]
forward declare SkTypeface
git-svn-id: http://skia.googlecode.com/svn/trunk@8623
2bbb7eff-a529-9590-31e7-
b0007b416f81
junov@chromium.org [Thu, 11 Apr 2013 17:52:05 +0000 (17:52 +0000)]
Fixed bug in SkSurface_Gpu to make the surface receive the new copy when copy
on write happens.
Review URL: https://codereview.chromium.org/
13195002
git-svn-id: http://skia.googlecode.com/svn/trunk@8622
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Thu, 11 Apr 2013 17:27:58 +0000 (17:27 +0000)]
Fix build. Unreviewed.
I don't understand why this change is necessary. On Android,
SkCommandLineFlags.h is not found, but only in this project.
Other projects depend on flags and include the file without
using the full path. Likewise, this works on other platforms.
Removing for now until I figure out the correct fix.
Review URL: https://codereview.chromium.org/
13910008
git-svn-id: http://skia.googlecode.com/svn/trunk@8621
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 11 Apr 2013 16:54:09 +0000 (16:54 +0000)]
use commandlineflags for tests/
Author: reed@google.com
Reviewed By: scroggo@google.com
Review URL: https://chromiumcodereview.appspot.com/
14047009
git-svn-id: http://skia.googlecode.com/svn/trunk@8616
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Thu, 11 Apr 2013 15:53:35 +0000 (15:53 +0000)]
Updates for the skimage tool.
Allow passing files or folders on the command line.
Group the output to show all successes together, all failures
together, etc.
When writing a new png, do not make its file type ".png.png"
if the original was a png.
Force linking for JPEG decoder.
Use SkCommandLineFlags.
Review URL: https://codereview.chromium.org/
14089002
git-svn-id: http://skia.googlecode.com/svn/trunk@8615
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Thu, 11 Apr 2013 15:41:02 +0000 (15:41 +0000)]
GM: signal error if the total number of tests run was less than expected
Review URL: https://codereview.chromium.org/
13863009
git-svn-id: http://skia.googlecode.com/svn/trunk@8614
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 11 Apr 2013 15:05:37 +0000 (15:05 +0000)]
Shader optimization for ovals.
Previously we were setting a center point as an attribute
across all vertices, then using that with the interpolated
position to compute an offset. However, because the offset
computation is linear, we can just set the appropriate offset
at the vertices and let the rasterizer interpolate it for us.
Author: jvanverth@google.com
Reviewed By: robertphillips@google.com
Review URL: https://chromiumcodereview.appspot.com/
14093002
git-svn-id: http://skia.googlecode.com/svn/trunk@8613
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Thu, 11 Apr 2013 14:09:50 +0000 (14:09 +0000)]
path ops fix release android build
git-svn-id: http://skia.googlecode.com/svn/trunk@8611
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Thu, 11 Apr 2013 12:33:23 +0000 (12:33 +0000)]
shape ops test fixes
- fix rand for Android
- build unit test on linux
- use atomic inc in test count
- add casting for Android
git-svn-id: http://skia.googlecode.com/svn/trunk@8610
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Thu, 11 Apr 2013 07:01:45 +0000 (07:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@8608
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Wed, 10 Apr 2013 23:25:36 +0000 (23:25 +0000)]
Rebaseline Nexus-7 performance triggers
git-svn-id: http://skia.googlecode.com/svn/trunk@8607
2bbb7eff-a529-9590-31e7-
b0007b416f81
borenet@google.com [Wed, 10 Apr 2013 20:12:52 +0000 (20:12 +0000)]
Whitespace change to verify gclient_utils
git-svn-id: http://skia.googlecode.com/svn/trunk@8606
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Wed, 10 Apr 2013 18:57:58 +0000 (18:57 +0000)]
Remove MacMini 10.8 performance triggers because they keep flip flopping
git-svn-id: http://skia.googlecode.com/svn/trunk@8603
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Wed, 10 Apr 2013 18:55:11 +0000 (18:55 +0000)]
fix path ops assert
git-svn-id: http://skia.googlecode.com/svn/trunk@8602
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Wed, 10 Apr 2013 18:53:01 +0000 (18:53 +0000)]
fix a few pathops test bugs exposed on Mac and Linux
git-svn-id: http://skia.googlecode.com/svn/trunk@8601
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Wed, 10 Apr 2013 18:46:25 +0000 (18:46 +0000)]
GM: remove enableMissingWarning in favor of verbose flag, and trim output in nonverbose mode
Review URL: https://codereview.chromium.org/
14080003
git-svn-id: http://skia.googlecode.com/svn/trunk@8600
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 10 Apr 2013 18:44:00 +0000 (18:44 +0000)]
fix bug introduced with SK_IGNORE_CUBIC_STROKE_FIX where we no longer respected
subDivide limit. This caused problems with degenate paths (too much recursion).
The fix was two parts:
1. decrement the subDivide limit as we recurse
2. up the limit for cubics to 7, to match our current quality
added unittest that replicated the too-much-recursion bug.
Review URL: https://codereview.chromium.org/
14086002
git-svn-id: http://skia.googlecode.com/svn/trunk@8599
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Wed, 10 Apr 2013 18:10:41 +0000 (18:10 +0000)]
Run mixedxfermodes GM through the pipe.
Pass the size of the GM to SkGPipeWriter.startRecording(), so that
calls to getDeviceSize() on the returned SkCanvas return a reasonable
result. This allows removing the flag to skip mixedxfermodes.
BUG=https://code.google.com/p/skia/issues/detail?id=1199
Review URL: https://codereview.chromium.org/
13814023
git-svn-id: http://skia.googlecode.com/svn/trunk@8598
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 10 Apr 2013 17:27:30 +0000 (17:27 +0000)]
Simplify bench pictures render target creation.
Author: bsalomon@google.com
Reviewed By: robertphillips@google.com
Review URL: https://chromiumcodereview.appspot.com/
13947016
git-svn-id: http://skia.googlecode.com/svn/trunk@8596
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Wed, 10 Apr 2013 15:57:31 +0000 (15:57 +0000)]
add extended option to Test
The command line option
--extended runs extended tests
--verbose reports number of tests run (if recorded)
Added simple help as well.
Review URL: https://codereview.chromium.org/
14063005
git-svn-id: http://skia.googlecode.com/svn/trunk@8595
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Wed, 10 Apr 2013 15:55:37 +0000 (15:55 +0000)]
Make parallel unit testing work on windows
Review URL: https://codereview.chromium.org/
14072002
git-svn-id: http://skia.googlecode.com/svn/trunk@8594
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Wed, 10 Apr 2013 15:24:53 +0000 (15:24 +0000)]
gm: hide list of tests with ignored errors, by default
Review URL: https://codereview.chromium.org/
13811031
git-svn-id: http://skia.googlecode.com/svn/trunk@8591
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 10 Apr 2013 13:10:40 +0000 (13:10 +0000)]
add SK_API to public classes for sharedlib build
git-svn-id: http://skia.googlecode.com/svn/trunk@8588
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Wed, 10 Apr 2013 12:17:34 +0000 (12:17 +0000)]
gm: record IntentionallySkipped tests
Review URL: https://codereview.chromium.org/
13663003
git-svn-id: http://skia.googlecode.com/svn/trunk@8586
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Wed, 10 Apr 2013 07:01:15 +0000 (07:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@8584
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Tue, 9 Apr 2013 23:56:51 +0000 (23:56 +0000)]
Temporary patch to get Chrome Windows compiling
git-svn-id: http://skia.googlecode.com/svn/trunk@8583
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Tue, 9 Apr 2013 21:25:46 +0000 (21:25 +0000)]
SkFlags now follows proper dashing convention.
Two dashes are used for flags with multiple characters, and one
dash is used for flags with single characters.
In GM, changed '-wp' to '-p' (the command to choose a directory
for writing SKPs) to fit with the convention.
In render_pictures and bench_pictures, changed the flag for
read and write path to have full names (which are consistent)
and use the old single character names as their shortcuts.
SkCommandLineFlags: Updated the documentation, and only allow
-h or --help for help (again, to match the convention).
Also enforce the single character limit for the short name, and
require the full name to be at least two characters.
Provide full names for skhello.
BUG=https://code.google.com/p/skia/issues/detail?id=1174
Review URL: https://codereview.chromium.org/
12521019
git-svn-id: http://skia.googlecode.com/svn/trunk@8582
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 9 Apr 2013 19:33:28 +0000 (19:33 +0000)]
Whitespace change to test the CQ.
TBR=borenet@google.com
(SkipBuildbotRuns)
Author: rmistry@google.com
Reviewed By: borenet@google.com
Review URL: https://chromiumcodereview.appspot.com/
13913016
git-svn-id: http://skia.googlecode.com/svn/trunk@8581
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Tue, 9 Apr 2013 19:29:45 +0000 (19:29 +0000)]
Make SkTypeFace::Deserialize work for embedded fonts.
https://codereview.appspot.com/
8584044/
git-svn-id: http://skia.googlecode.com/svn/trunk@8580
2bbb7eff-a529-9590-31e7-
b0007b416f81
djsollen@google.com [Tue, 9 Apr 2013 18:06:06 +0000 (18:06 +0000)]
Partial reapply of r5364 minus the non-neon code path.
See https://codereview.appspot.com/
6465075 for a more detailed description of the contents of this CL.
Review URL: https://codereview.chromium.org/
13060004
git-svn-id: http://skia.googlecode.com/svn/trunk@8579
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Tue, 9 Apr 2013 17:35:29 +0000 (17:35 +0000)]
Partial fix for skp reading failure on fonts
verbal lgtm from bungeman@
git-svn-id: http://skia.googlecode.com/svn/trunk@8578
2bbb7eff-a529-9590-31e7-
b0007b416f81
junov@chromium.org [Tue, 9 Apr 2013 16:13:09 +0000 (16:13 +0000)]
Fixing SkTileGrid to clamp rather than clip content and querries that are outside the bounds of the grid
This fix prevents border padding and offsets on the tile grid structure from resulting in bad clipping. The job of clipping contents is left to the playback canvas.
BUG=https://code.google.com/p/skia/issues/detail?id=1209
TEST=TileGrid unit test,
Review URL: https://codereview.chromium.org/
13493016
git-svn-id: http://skia.googlecode.com/svn/trunk@8576
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 9 Apr 2013 15:54:52 +0000 (15:54 +0000)]
extend FontConfigInterface to start to match new fontmgr design
Review URL: https://codereview.chromium.org/
13297004
git-svn-id: http://skia.googlecode.com/svn/trunk@8575
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Tue, 9 Apr 2013 15:38:19 +0000 (15:38 +0000)]
Make GrIODB record and play back copySurface.
Review URL: https://codereview.chromium.org/
13581003
git-svn-id: http://skia.googlecode.com/svn/trunk@8574
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Tue, 9 Apr 2013 15:04:12 +0000 (15:04 +0000)]
Reland of 8525 with fix for case when GrRT outlives GrTexture.
Review URL: https://codereview.chromium.org/
13814015
git-svn-id: http://skia.googlecode.com/svn/trunk@8573
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Tue, 9 Apr 2013 14:08:15 +0000 (14:08 +0000)]
Fix compiler warning/error in r8571
git-svn-id: http://skia.googlecode.com/svn/trunk@8572
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Tue, 9 Apr 2013 14:01:44 +0000 (14:01 +0000)]
First pass at Rect Effect
https://codereview.chromium.org/
13521006/
git-svn-id: http://skia.googlecode.com/svn/trunk@8571
2bbb7eff-a529-9590-31e7-
b0007b416f81
rmistry@google.com [Tue, 9 Apr 2013 11:59:42 +0000 (11:59 +0000)]
Deleting the hardcoded list of compile bots in trybots_to_run.
The submitted change https://codereview.chromium.org/
13493012/ makes this list unnecessary.
(SkipBuildbotRuns)
Review URL: https://codereview.chromium.org/
13947006
git-svn-id: http://skia.googlecode.com/svn/trunk@8570
2bbb7eff-a529-9590-31e7-
b0007b416f81
rmistry@google.com [Tue, 9 Apr 2013 11:46:46 +0000 (11:46 +0000)]
Introduce aliases and regex in submit_try.
Adding the aliases 'compile' and 'cq'. Also adding a alias 'regex' that prompts the user for a regex, displays results and prompts again for confirmation.
Created to fix the feature request https://code.google.com/p/skia/issues/detail?id=1207 : replace hard-coded trybot lists with automated filtering.
(SkipBuildbotRuns)
Review URL: https://codereview.chromium.org/
13493012
git-svn-id: http://skia.googlecode.com/svn/trunk@8569
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Tue, 9 Apr 2013 07:01:27 +0000 (07:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@8568
2bbb7eff-a529-9590-31e7-
b0007b416f81
humper@google.com [Mon, 8 Apr 2013 21:54:58 +0000 (21:54 +0000)]
silence android warning
git-svn-id: http://skia.googlecode.com/svn/trunk@8567
2bbb7eff-a529-9590-31e7-
b0007b416f81
humper@google.com [Mon, 8 Apr 2013 21:44:11 +0000 (21:44 +0000)]
Error checking / reporting API
Review URL: https://codereview.chromium.org/
13699004
git-svn-id: http://skia.googlecode.com/svn/trunk@8566
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Mon, 8 Apr 2013 20:37:35 +0000 (20:37 +0000)]
saving the old before blowing away
git-svn-id: http://skia.googlecode.com/svn/trunk@8565
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Mon, 8 Apr 2013 20:36:19 +0000 (20:36 +0000)]
saving away the old before blowing the machine away
git-svn-id: http://skia.googlecode.com/svn/trunk@8564
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Mon, 8 Apr 2013 19:43:22 +0000 (19:43 +0000)]
Allow single-pass filters (which use asNewEffect()) to participate in the image filter DAG. This was done by introducing the SkSinglePassImageFilter abstract base class, which implements canFilterImageGPU() and filterImageGPU() on behalf of the derived class. The derived class still only needs to asNewEffect(). This allows us to recurse on the filter input in SkSinglePassImageFilter::onFilterImageGPU(). It also allows us to remove any knowledge of single-pass image filters from SkGpuDevice and from the SkImageFilter base class as well.
BUG=
Review URL: https://codereview.chromium.org/
13602013
git-svn-id: http://skia.googlecode.com/svn/trunk@8563
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Mon, 8 Apr 2013 15:45:30 +0000 (15:45 +0000)]
Add before and after command count to filter tool
https://codereview.chromium.org/
13405003/
git-svn-id: http://skia.googlecode.com/svn/trunk@8562
2bbb7eff-a529-9590-31e7-
b0007b416f81
bensong@google.com [Mon, 8 Apr 2013 14:57:40 +0000 (14:57 +0000)]
Switches to a Skia-specific appengine entry point that uses condensed data and taskqueue writes (SkipBuildbotRuns).
The default entry /add_point does not handle large data efficiently, so we've seen >30min timeouts for some bots to upload data. We now switch to using /skia_add_points that I'm writing for Skia, so we can condense the data to send to minimum (since all points in each batch have the same revision, platform and config), and dedicate the actual data processing to /skia_write_datastore which is a taskqueue task that has longer timeout and can run at app backend instead of blocking the bots.
Initial testing from my MacBook on Mac 64 bench data via vpn gave only a little more than 1 second for uploading data for one config, about 15 seconds for all 12 configs. That's a big win against 20+ minutes.
Review URL: https://codereview.chromium.org/
13762002
git-svn-id: http://skia.googlecode.com/svn/trunk@8560
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Mon, 8 Apr 2013 11:53:42 +0000 (11:53 +0000)]
keep old experimental code in sync
git-svn-id: http://skia.googlecode.com/svn/trunk@8554
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Mon, 8 Apr 2013 11:50:46 +0000 (11:50 +0000)]
Add implementation of path ops
This CL depends on
https://codereview.chromium.org/
12880016/
"Add intersections for path ops"
Given a path, iterate through its contour, and
construct an array of segments containing its curves.
Intersect each curve with every other curve, and for
cubics, with itself.
Given the set of intersections, find one with the
smallest y and sort the curves eminating from the
intersection. Assign each curve a winding value.
Operate on the curves, keeping and discarding them
according to the current operation and the sum of
the winding values.
Assemble the kept curves into an output path.
Review URL: https://codereview.chromium.org/
13094010
git-svn-id: http://skia.googlecode.com/svn/trunk@8553
2bbb7eff-a529-9590-31e7-
b0007b416f81